GitHub PushEvent at 2014-02-19 17:46:16
Repository: chromium
Actor: anirudhSK
Payload: {"shas":[["5e03d1d2ff8ab8b11964654838a43fd976d1c7de","621c5fbeb859e0ab8d5d27ceb9e911eb7ee8c5c8@chromium.org","Revert 251918 \"Do not send a frame swap ack from the browser unt...\"\n\nThe bots tells this CL broke most of the webrtc browser tests on Mac.\nhttp://chromegw/i/internal.chromium.webrtc/builders/Mac%20Tester\n\n\nBUG=344912\nTEST=webrtc bots.\n\n> Do not send a frame swap ack from the browser until the frame is drawn\n> \n> Code to do this was recently removed because it was no longer being\n> used in r241225 (https://codereview.chromium.org/116103002). This is\n> now necessary again to throttle renderers when using CoreAnimation.\n> \n> Frames are acked only when they are drawn. Both the CoreAnimation and\n> the non-CoreAnimation paths are changed to behave this way. By virtue\n> of the fact that the non-CoreAnimation path draws immediately, this\n> should have no functional effect on that path.\n> \n> This differs from the mechanism deleted in the aforementioned patch in\n> two ways.\n> \n> First, it uses a scoped_ptr of a struct instead of a vector of pairs to\n> store the information about the swap being returned. This should improve\n> readability in that the ack has struct names instead of just first and\n> second in the pair, and in that the scoped_ptr does not suggest support\n> for multiple pending swaps (which does not exist).\n> \n> Second, it does makes RWHVMac ack frames more aggressively when\n> inside a draw call, rather than adding a call from RWHImpl to the view,\n> to effect the ack (which is what the old way does).\n> \n> BUG=340133\n> \n> Review URL: https://codereview.chromium.org/165703002\n\nTBR=ccameron@chromium.org\n\nReview URL: https://codereview.chromium.org/172633002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@252031 0039d316-1c4b-4281-b951-d872f2087c98","xians@chromium.org",true],["4218e5ea93bec8e078b28a710926aab5b5d92fd4","afd682864eefb200fdfc0ca64f16291795733c34@chromium.org","SVN changes up to revision 252031","gitdeps",true]],"size":2,"ref":"refs/heads/master","head":"4218e5ea93bec8e078b28a710926aab5b5d92fd4"}