GitHub PullRequestReviewCommentEvent at 2014-09-12 15:48:51
Repository: TrinityCore
Actor: jackpoz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/17486088","id":17486088,"diff_hunk":"@@ -140,9 +209,31 @@ class spell_ioc_parachute_ic : public SpellScriptLoader\n         }\n };\n \n-enum Launch\n+class StartLaunchEvent : public BasicEvent\n {\n-    SPELL_LAUNCH_NO_FALLING_DAMAGE  = 66251\n+    public:\n+        StartLaunchEvent(WorldLocation const* const position, Player* player) : _position(position), _player(player)\n+        {\n+        }\n+\n+        bool Execute(uint64 /*time*/, uint32 /*diff*/)\n+        {\n+            if (!_player || !_position || !_player->GetVehicle())\n+                return true;\n+\n+            _player->AddAura(SPELL_LAUNCH_NO_FALLING_DAMAGE, _player); // prevents falling damage\n+            float speedZ = 10.0f;\n+            float dist = _position->GetExactDist2d(_player->GetPositionX(), _player->GetPositionY());\n+            float speedXY = dist;","path":"src/server/scripts/Northrend/isle_of_conquest.cpp","position":136,"original_position":136,"commit_id":"43cdf2025a6cba25e0abcc414bc556c7b32c90b0","original_commit_id":"43cdf2025a6cba25e0abcc414bc556c7b32c90b0","user":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=2","gravatar_id":"67fa9f51db871840fdb4057958689ec7","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"body":"is speedXY supposed to be = dist ? if so, 1 variable is enough","created_at":"2014-09-12T15:48:51Z","updated_at":"2014-09-12T15:48:51Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/13052#discussion_r17486088","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13052","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/17486088"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/13052#discussion_r17486088"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13052"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13052","id":20847611,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/13052","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/13052.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/13052.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13052","number":13052,"state":"open","locked":false,"title":"Core/BattlegroundIC:","user":{"login":"Golrag","id":6825243,"avatar_url":"https://avatars.githubusercontent.com/u/6825243?v=2","gravatar_id":null,"url":"https://api.github.com/users/Golrag","html_url":"https://github.com/Golrag","followers_url":"https://api.github.com/users/Golrag/followers","following_url":"https://api.github.com/users/Golrag/following{/other_user}","gists_url":"https://api.github.com/users/Golrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Golrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golrag/subscriptions","organizations_url":"https://api.github.com/users/Golrag/orgs","repos_url":"https://api.github.com/users/Golrag/repos","events_url":"https://api.github.com/users/Golrag/events{/privacy}","received_events_url":"https://api.github.com/users/Golrag/received_events","type":"User","site_admin":false},"body":"* Fixed Catapults\r\n* Fixed Graveyards\r\n* Fixed Cannons on Gunships\r\n* More Blizzlike Teleport to Gunship\r\n* Fixed Gunship Teleport to Hangar\r\n\r\nCloses https://github.com/TrinityCore/TrinityCore/issues/12323 and https://github.com/TrinityCore/TrinityCore/issues/9557\r\n\r\nBut it's not yet finished...\r\n\r\nMissing waypoints (captains on transport)\r\nSome hacks... (like in spell_ioc_gunship_portal)","created_at":"2014-09-06T10:29:31Z","updated_at":"2014-09-12T15:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20f5870eff0948b3539e30db0e521681fb99bb7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13052/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13052/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13052/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/43cdf2025a6cba25e0abcc414bc556c7b32c90b0","head":{"label":"Golrag:IsleOfConquest","ref":"IsleOfConquest","sha":"43cdf2025a6cba25e0abcc414bc556c7b32c90b0","user":{"login":"Golrag","id":6825243,"avatar_url":"https://avatars.githubusercontent.com/u/6825243?v=2","gravatar_id":null,"url":"https://api.github.com/users/Golrag","html_url":"https://github.com/Golrag","followers_url":"https://api.github.com/users/Golrag/followers","following_url":"https://api.github.com/users/Golrag/following{/other_user}","gists_url":"https://api.github.com/users/Golrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Golrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golrag/subscriptions","organizations_url":"https://api.github.com/users/Golrag/orgs","repos_url":"https://api.github.com/users/Golrag/repos","events_url":"https://api.github.com/users/Golrag/events{/privacy}","received_events_url":"https://api.github.com/users/Golrag/received_events","type":"User","site_admin":false},"repo":{"id":23447727,"name":"TrinityCore","full_name":"Golrag/TrinityCore","owner":{"login":"Golrag","id":6825243,"avatar_url":"https://avatars.githubusercontent.com/u/6825243?v=2","gravatar_id":null,"url":"https://api.github.com/users/Golrag","html_url":"https://github.com/Golrag","followers_url":"https://api.github.com/users/Golrag/followers","following_url":"https://api.github.com/users/Golrag/following{/other_user}","gists_url":"https://api.github.com/users/Golrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Golrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golrag/subscriptions","organizations_url":"https://api.github.com/users/Golrag/orgs","repos_url":"https://api.github.com/users/Golrag/repos","events_url":"https://api.github.com/users/Golrag/events{/privacy}","received_events_url":"https://api.github.com/users/Golrag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Golrag/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Golrag/TrinityCore","forks_url":"https://api.github.com/repos/Golrag/TrinityCore/forks","keys_url":"https://api.github.com/repos/Golrag/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Golrag/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Golrag/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Golrag/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Golrag/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Golrag/TrinityCore/events","assignees_url":"https://api.github.com/repos/Golrag/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Golrag/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Golrag/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Golrag/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Golrag/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Golrag/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Golrag/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Golrag/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Golrag/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Golrag/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Golrag/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Golrag/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Golrag/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Golrag/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Golrag/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Golrag/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Golrag/TrinityCore/issues/comments/{number}","contents_url":"https://api.github.com/repos/Golrag/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Golrag/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Golrag/TrinityCore/merges","archive_url":"https://api.github.com/repos/Golrag/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Golrag/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Golrag/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Golrag/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Golrag/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Golrag/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Golrag/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Golrag/TrinityCore/releases{/id}","created_at":"2014-08-29T00:44:35Z","updated_at":"2014-08-29T00:45:13Z","pushed_at":"2014-09-12T13:41:02Z","git_url":"git://github.com/Golrag/TrinityCore.git","ssh_url":"git@github.com:Golrag/TrinityCore.git","clone_url":"https://github.com/Golrag/TrinityCore.git","svn_url":"https://github.com/Golrag/TrinityCore","homepage":"http://www.trinitycore.org","size":206028,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TrinityCore:master","ref":"master","sha":"d7b0ee7c0366bf78e09f4eca5f93e65361c5a2b6","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=2","gravatar_id":"82bb775f86534f2bee3d4dc40e4c7e17","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=2","gravatar_id":"82bb775f86534f2bee3d4dc40e4c7e17","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/{number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2014-09-12T15:29:11Z","pushed_at":"2014-09-12T15:11:24Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":626496,"stargazers_count":2554,"watchers_count":2554,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2537,"mirror_url":null,"open_issues_count":1561,"forks":2537,"open_issues":1561,"watchers":2554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13052"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/13052"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13052"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13052/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13052/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13052/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/43cdf2025a6cba25e0abcc414bc556c7b32c90b0"}}}}