GitHub PullRequestReviewCommentEvent at 2014-03-05 11:35:34
Repository: django-oscar
Actor: maikhoepfel
Payload: {"comment":{"url":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/comments/10296119","id":10296119,"diff_hunk":"@@ -9,6 +9,7 @@ def metadata(request):\n             'version': getattr(settings, 'VERSION', 'N/A'),\n             'shop_name': settings.OSCAR_SHOP_NAME,\n             'shop_tagline': settings.OSCAR_SHOP_TAGLINE,\n+            'homepage_url': settings.OSCAR_HOMEPAGE,","path":"oscar/core/context_processors.py","position":4,"original_position":4,"commit_id":"35e7a832c0d7fb9410cf9e4067a3aed281f7a50b","original_commit_id":"35e7a832c0d7fb9410cf9e4067a3aed281f7a50b","user":{"login":"maikhoepfel","id":509427,"avatar_url":"https://gravatar.com/avatar/9a313a0126d7f38f6e5bf0a337e9fbf4?d=https%3A%2F%2Fidenticons.github.com%2Fd610d91afe1cb0cd8dcaf23b551c8540.png&r=x","gravatar_id":"9a313a0126d7f38f6e5bf0a337e9fbf4","url":"https://api.github.com/users/maikhoepfel","html_url":"https://github.com/maikhoepfel","followers_url":"https://api.github.com/users/maikhoepfel/followers","following_url":"https://api.github.com/users/maikhoepfel/following{/other_user}","gists_url":"https://api.github.com/users/maikhoepfel/gists{/gist_id}","starred_url":"https://api.github.com/users/maikhoepfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maikhoepfel/subscriptions","organizations_url":"https://api.github.com/users/maikhoepfel/orgs","repos_url":"https://api.github.com/users/maikhoepfel/repos","events_url":"https://api.github.com/users/maikhoepfel/events{/privacy}","received_events_url":"https://api.github.com/users/maikhoepfel/received_events","type":"User","site_admin":false},"body":"It's a good name, but it makes me slightly queasy as we might accidentally overwrite things. We really should start namespacing as suggested in https://github.com/tangentlabs/django-oscar/issues/979","created_at":"2014-03-05T11:35:34Z","updated_at":"2014-03-05T11:35:34Z","html_url":"https://github.com/tangentlabs/django-oscar/pull/846#discussion_r10296119","pull_request_url":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/846","_links":{"self":{"href":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/comments/10296119"},"html":{"href":"https://github.com/tangentlabs/django-oscar/pull/846#discussion_r10296119"},"pull_request":{"href":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/846"}}}}