GitHub PullRequestReviewCommentEvent at 2014-04-29 15:24:37
Repository: WebODF
Actor: kossebau
Payload: {"comment":{"url":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/12098817","id":12098817,"diff_hunk":"@@ -138,9 +138,9 @@ xmldom.RelaxNG2 = function RelaxNG2() {\n         for (i = 0; i < l; i += 1) {\n             a = element.getAttributeNS(elementdef.namespaces[i],\n                     elementdef.localnames[i]);\n-            // if an element is not present, getAttributeNS will return an empty\n-            // string but an empty string is possible attribute value, so an\n-            // extra check is needed\n+            // if an element is not present, getAttributeNS can return an empty\n+            // string for older browsers, but an empty string is possible\n+            // attribute value, so an extra check is needed\n             if (a === \"\" && !element.hasAttributeNS(elementdef.namespaces[i],","path":"webodf/lib/xmldom/RelaxNG2.js","position":null,"original_position":10,"commit_id":"7ee35a0b43c5ffa72cc0565d265003673a5101bb","original_commit_id":"1675d4973d5efb24cb72f4f385692f56a7652b70","user":{"login":"kossebau","id":4068037,"avatar_url":"https://avatars.githubusercontent.com/u/4068037?","gravatar_id":"6ec9d5b4b917b38c571b568766c59bf4","url":"https://api.github.com/users/kossebau","html_url":"https://github.com/kossebau","followers_url":"https://api.github.com/users/kossebau/followers","following_url":"https://api.github.com/users/kossebau/following{/other_user}","gists_url":"https://api.github.com/users/kossebau/gists{/gist_id}","starred_url":"https://api.github.com/users/kossebau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kossebau/subscriptions","organizations_url":"https://api.github.com/users/kossebau/orgs","repos_url":"https://api.github.com/users/kossebau/repos","events_url":"https://api.github.com/users/kossebau/events{/privacy}","received_events_url":"https://api.github.com/users/kossebau/received_events","type":"User","site_admin":false},"body":"Done (by first explicitely checking with hasAttributeNS)","created_at":"2014-04-29T15:24:37Z","updated_at":"2014-04-29T15:24:37Z","html_url":"https://github.com/kogmbh/WebODF/pull/564#discussion_r12098817","pull_request_url":"https://api.github.com/repos/kogmbh/WebODF/pulls/564","_links":{"self":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/12098817"},"html":{"href":"https://github.com/kogmbh/WebODF/pull/564#discussion_r12098817"},"pull_request":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/564"}}}}