GitHub PullRequestReviewCommentEvent at 2014-01-03 23:21:07
Repository: zippy
Actor: kumar303
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/zippy/pulls/comments/8648414","id":8648414,"diff_hunk":"@@ -103,7 +108,21 @@ exports.create = function(req, res, next) {\n       return Q.ninvoke(models, 'create' , ob);\n     })\n     .then(function(ob) {\n-      res.send(201, z.serialize(ob, 'transations'));","path":"lib/trans.js","position":28,"original_position":28,"commit_id":"440840e32689cd437b65bb29aa48323f6857c76a","original_commit_id":"440840e32689cd437b65bb29aa48323f6857c76a","user":{"login":"kumar303","id":55398,"avatar_url":"https://gravatar.com/avatar/3e7e975f0fa432f4ae6604f72c132309?d=https%3A%2F%2Fidenticons.github.com%2F01074d0e0ca64dd52127d542d631eef0.png&r=x","gravatar_id":"3e7e975f0fa432f4ae6604f72c132309","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"This looks like it blocks until it makes a postback. There is no need to block. I'd suggest immediately returning this:\r\n\r\n    res.send(201, z.serialize(ob, 'transations'));\r\n\r\nThen call ``next()`` and after that, begin the async ``request.post(...)``.","created_at":"2014-01-03T23:21:07Z","updated_at":"2014-01-03T23:21:07Z","html_url":"https://github.com/mozilla/zippy/pull/43#discussion_r8648414","pull_request_url":"https://api.github.com/repos/mozilla/zippy/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zippy/pulls/comments/8648414"},"html":{"href":"https://github.com/mozilla/zippy/pull/43#discussion_r8648414"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zippy/pulls/43"}}}}