GitHub PullRequestEvent at 2014-05-09 22:40:01
Repository: RxJava
Actor: akarnokd
Payload: {"action":"opened","number":1185,"pull_request":{"url":"https://api.github.com/repos/Netflix/RxJava/pulls/1185","id":15725880,"html_url":"https://github.com/Netflix/RxJava/pull/1185","diff_url":"https://github.com/Netflix/RxJava/pull/1185.diff","patch_url":"https://github.com/Netflix/RxJava/pull/1185.patch","issue_url":"https://api.github.com/repos/Netflix/RxJava/issues/1185","number":1185,"state":"open","title":"Behavior subject time gap fix 2","user":{"login":"akarnokd","id":1269832,"avatar_url":"https://avatars.githubusercontent.com/u/1269832?","gravatar_id":"db0a0198951e15aadcb42b40452c29f7","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"body":"Based on discussions in #1181, I've unified the behavior among the Subjects.\r\n\r\nBehaviorSubject doesn't seem to exhibit issue #658 and #1184.\r\n\r\nA second pair of eyes would be great to confirm the correctness and check if the removal of the CountDownLatch was the correct approach.","created_at":"2014-05-09T22:40:00Z","updated_at":"2014-05-09T22:40:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/RxJava/pulls/1185/commits","review_comments_url":"https://api.github.com/repos/Netflix/RxJava/pulls/1185/comments","review_comment_url":"https://api.github.com/repos/Netflix/RxJava/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Netflix/RxJava/issues/1185/comments","statuses_url":"https://api.github.com/repos/Netflix/RxJava/statuses/1b88781653cde78650f34eabe1f07e53560b0880","head":{"label":"akarnokd:BehaviorSubjectTimeGapFix2","ref":"BehaviorSubjectTimeGapFix2","sha":"1b88781653cde78650f34eabe1f07e53560b0880","user":{"login":"akarnokd","id":1269832,"avatar_url":"https://avatars.githubusercontent.com/u/1269832?","gravatar_id":"db0a0198951e15aadcb42b40452c29f7","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"repo":{"id":14518033,"name":"RxJava","full_name":"akarnokd/RxJava","owner":{"login":"akarnokd","id":1269832,"avatar_url":"https://avatars.githubusercontent.com/u/1269832?","gravatar_id":"db0a0198951e15aadcb42b40452c29f7","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akarnokd/RxJava","description":"RxJava - a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":true,"url":"https://api.github.com/repos/akarnokd/RxJava","forks_url":"https://api.github.com/repos/akarnokd/RxJava/forks","keys_url":"https://api.github.com/repos/akarnokd/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akarnokd/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akarnokd/RxJava/teams","hooks_url":"https://api.github.com/repos/akarnokd/RxJava/hooks","issue_events_url":"https://api.github.com/repos/akarnokd/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/akarnokd/RxJava/events","assignees_url":"https://api.github.com/repos/akarnokd/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/akarnokd/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/akarnokd/RxJava/tags","blobs_url":"https://api.github.com/repos/akarnokd/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akarnokd/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akarnokd/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/akarnokd/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akarnokd/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/akarnokd/RxJava/languages","stargazers_url":"https://api.github.com/repos/akarnokd/RxJava/stargazers","contributors_url":"https://api.github.com/repos/akarnokd/RxJava/contributors","subscribers_url":"https://api.github.com/repos/akarnokd/RxJava/subscribers","subscription_url":"https://api.github.com/repos/akarnokd/RxJava/subscription","commits_url":"https://api.github.com/repos/akarnokd/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/akarnokd/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/akarnokd/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/akarnokd/RxJava/issues/comments/{number}","contents_url":"https://api.github.com/repos/akarnokd/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/akarnokd/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akarnokd/RxJava/merges","archive_url":"https://api.github.com/repos/akarnokd/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akarnokd/RxJava/downloads","issues_url":"https://api.github.com/repos/akarnokd/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/akarnokd/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/akarnokd/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/akarnokd/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akarnokd/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/akarnokd/RxJava/releases{/id}","created_at":"2013-11-19T08:04:52Z","updated_at":"2014-05-09T22:40:00Z","pushed_at":"2014-05-09T22:31:26Z","git_url":"git://github.com/akarnokd/RxJava.git","ssh_url":"git@github.com:akarnokd/RxJava.git","clone_url":"https://github.com/akarnokd/RxJava.git","svn_url":"https://github.com/akarnokd/RxJava","homepage":"","size":340524,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"cb60dd4bf72a806ab4609db8ae86fecb9e87e521","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":7508411,"name":"RxJava","full_name":"Netflix/RxJava","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":false,"url":"https://api.github.com/repos/Netflix/RxJava","forks_url":"https://api.github.com/repos/Netflix/RxJava/forks","keys_url":"https://api.github.com/repos/Netflix/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/RxJava/teams","hooks_url":"https://api.github.com/repos/Netflix/RxJava/hooks","issue_events_url":"https://api.github.com/repos/Netflix/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/RxJava/events","assignees_url":"https://api.github.com/repos/Netflix/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/RxJava/tags","blobs_url":"https://api.github.com/repos/Netflix/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/RxJava/languages","stargazers_url":"https://api.github.com/repos/Netflix/RxJava/stargazers","contributors_url":"https://api.github.com/repos/Netflix/RxJava/contributors","subscribers_url":"https://api.github.com/repos/Netflix/RxJava/subscribers","subscription_url":"https://api.github.com/repos/Netflix/RxJava/subscription","commits_url":"https://api.github.com/repos/Netflix/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/RxJava/issues/comments/{number}","contents_url":"https://api.github.com/repos/Netflix/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/RxJava/merges","archive_url":"https://api.github.com/repos/Netflix/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/RxJava/downloads","issues_url":"https://api.github.com/repos/Netflix/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/RxJava/releases{/id}","created_at":"2013-01-08T20:11:48Z","updated_at":"2014-05-09T21:38:00Z","pushed_at":"2014-05-09T17:56:12Z","git_url":"git://github.com/Netflix/RxJava.git","ssh_url":"git@github.com:Netflix/RxJava.git","clone_url":"https://github.com/Netflix/RxJava.git","svn_url":"https://github.com/Netflix/RxJava","homepage":"","size":518437,"stargazers_count":2185,"watchers_count":2185,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":391,"mirror_url":null,"open_issues_count":140,"forks":391,"open_issues":140,"watchers":2185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1185"},"html":{"href":"https://github.com/Netflix/RxJava/pull/1185"},"issue":{"href":"https://api.github.com/repos/Netflix/RxJava/issues/1185"},"comments":{"href":"https://api.github.com/repos/Netflix/RxJava/issues/1185/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1185/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1185/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/RxJava/statuses/1b88781653cde78650f34eabe1f07e53560b0880"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":546,"deletions":558,"changed_files":7}}