GitHub PullRequestReviewCommentEvent at 2014-07-17 20:58:32
Repository: zamboni
Actor: ngokevin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/15083600","id":15083600,"diff_hunk":"@@ -21,34 +26,66 @@ def get_mapping(cls):\n         \"\"\"Returns an Elasticsearch mapping for this MappingType\"\"\"\n         doc_type = cls.get_mapping_type_name()\n \n-        return {\n+        mapping = {\n             doc_type: {\n+                'dynamic': 'strict',","path":"mkt/feed/indexers.py","position":25,"original_position":25,"commit_id":"580fed4ac217b8a67e637243c7f6a6a01c37a311","original_commit_id":"580fed4ac217b8a67e637243c7f6a6a01c37a311","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?","gravatar_id":"f1fa62935c8064826634fc93ce7aa4bb","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"Oh, I'll just use it to dbl-check and get rid of it.","created_at":"2014-07-17T20:58:32Z","updated_at":"2014-07-17T20:58:32Z","html_url":"https://github.com/mozilla/zamboni/pull/2314#discussion_r15083600","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2314","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/15083600"},"html":{"href":"https://github.com/mozilla/zamboni/pull/2314#discussion_r15083600"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2314"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/2314","id":18363763,"html_url":"https://github.com/mozilla/zamboni/pull/2314","diff_url":"https://github.com/mozilla/zamboni/pull/2314.diff","patch_url":"https://github.com/mozilla/zamboni/pull/2314.patch","issue_url":"https://api.github.com/repos/mozilla/zamboni/issues/2314","number":2314,"state":"open","title":"feed item indexer for es feed (bug 1036216)","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?","gravatar_id":"f1fa62935c8064826634fc93ce7aa4bb","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"Breaking https://github.com/mozilla/zamboni/pull/2298 up.\r\n\r\n- Index the FeedItem -> FeedApp/Brand/Collection/Shelf -> Apps relation in ES using denormalization \"schema\"\r\n- FeedItem store FeedApp/Brand/Collection/Shelf IDs\r\n- FeedApp/Brand/Collection/Shelf store app IDs\r\n- Some special logic for grouped feed collections\r\n\r\nRelated serializers at https://github.com/mozilla/zamboni/pull/2313","created_at":"2014-07-14T18:05:17Z","updated_at":"2014-07-17T20:58:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aab1d421024be3e3ae228728f775c4290a38f62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2314/commits","review_comments_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2314/comments","review_comment_url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/zamboni/issues/2314/comments","statuses_url":"https://api.github.com/repos/mozilla/zamboni/statuses/580fed4ac217b8a67e637243c7f6a6a01c37a311","head":{"label":"ngokevin:feedindexindexers","ref":"feedindexindexers","sha":"580fed4ac217b8a67e637243c7f6a6a01c37a311","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?","gravatar_id":"f1fa62935c8064826634fc93ce7aa4bb","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"repo":{"id":4227957,"name":"zamboni","full_name":"ngokevin/zamboni","owner":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?","gravatar_id":"f1fa62935c8064826634fc93ce7aa4bb","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngokevin/zamboni","description":"A clandestine operation to make AMO happy","fork":true,"url":"https://api.github.com/repos/ngokevin/zamboni","forks_url":"https://api.github.com/repos/ngokevin/zamboni/forks","keys_url":"https://api.github.com/repos/ngokevin/zamboni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngokevin/zamboni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngokevin/zamboni/teams","hooks_url":"https://api.github.com/repos/ngokevin/zamboni/hooks","issue_events_url":"https://api.github.com/repos/ngokevin/zamboni/issues/events{/number}","events_url":"https://api.github.com/repos/ngokevin/zamboni/events","assignees_url":"https://api.github.com/repos/ngokevin/zamboni/assignees{/user}","branches_url":"https://api.github.com/repos/ngokevin/zamboni/branches{/branch}","tags_url":"https://api.github.com/repos/ngokevin/zamboni/tags","blobs_url":"https://api.github.com/repos/ngokevin/zamboni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngokevin/zamboni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngokevin/zamboni/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngokevin/zamboni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngokevin/zamboni/statuses/{sha}","languages_url":"https://api.github.com/repos/ngokevin/zamboni/languages","stargazers_url":"https://api.github.com/repos/ngokevin/zamboni/stargazers","contributors_url":"https://api.github.com/repos/ngokevin/zamboni/contributors","subscribers_url":"https://api.github.com/repos/ngokevin/zamboni/subscribers","subscription_url":"https://api.github.com/repos/ngokevin/zamboni/subscription","commits_url":"https://api.github.com/repos/ngokevin/zamboni/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngokevin/zamboni/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngokevin/zamboni/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngokevin/zamboni/issues/comments/{number}","contents_url":"https://api.github.com/repos/ngokevin/zamboni/contents/{+path}","compare_url":"https://api.github.com/repos/ngokevin/zamboni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngokevin/zamboni/merges","archive_url":"https://api.github.com/repos/ngokevin/zamboni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngokevin/zamboni/downloads","issues_url":"https://api.github.com/repos/ngokevin/zamboni/issues{/number}","pulls_url":"https://api.github.com/repos/ngokevin/zamboni/pulls{/number}","milestones_url":"https://api.github.com/repos/ngokevin/zamboni/milestones{/number}","notifications_url":"https://api.github.com/repos/ngokevin/zamboni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngokevin/zamboni/labels{/name}","releases_url":"https://api.github.com/repos/ngokevin/zamboni/releases{/id}","created_at":"2012-05-04T18:44:23Z","updated_at":"2014-07-02T20:29:57Z","pushed_at":"2014-07-17T20:16:14Z","git_url":"git://github.com/ngokevin/zamboni.git","ssh_url":"git@github.com:ngokevin/zamboni.git","clone_url":"https://github.com/ngokevin/zamboni.git","svn_url":"https://github.com/ngokevin/zamboni","homepage":"http://mozilla.github.com/zamboni/","size":280529,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"b03a244415b5d822bd194f918e9420b87bf3ff1b","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":347655,"name":"zamboni","full_name":"mozilla/zamboni","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/zamboni","description":"The backend of the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/zamboni","forks_url":"https://api.github.com/repos/mozilla/zamboni/forks","keys_url":"https://api.github.com/repos/mozilla/zamboni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/zamboni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/zamboni/teams","hooks_url":"https://api.github.com/repos/mozilla/zamboni/hooks","issue_events_url":"https://api.github.com/repos/mozilla/zamboni/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/zamboni/events","assignees_url":"https://api.github.com/repos/mozilla/zamboni/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/zamboni/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/zamboni/tags","blobs_url":"https://api.github.com/repos/mozilla/zamboni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/zamboni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/zamboni/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/zamboni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/zamboni/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/zamboni/languages","stargazers_url":"https://api.github.com/repos/mozilla/zamboni/stargazers","contributors_url":"https://api.github.com/repos/mozilla/zamboni/contributors","subscribers_url":"https://api.github.com/repos/mozilla/zamboni/subscribers","subscription_url":"https://api.github.com/repos/mozilla/zamboni/subscription","commits_url":"https://api.github.com/repos/mozilla/zamboni/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/zamboni/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/zamboni/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/zamboni/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/zamboni/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/zamboni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/zamboni/merges","archive_url":"https://api.github.com/repos/mozilla/zamboni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/zamboni/downloads","issues_url":"https://api.github.com/repos/mozilla/zamboni/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/zamboni/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/zamboni/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/zamboni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/zamboni/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/zamboni/releases{/id}","created_at":"2009-10-23T19:35:34Z","updated_at":"2014-07-15T06:38:45Z","pushed_at":"2014-07-17T18:15:08Z","git_url":"git://github.com/mozilla/zamboni.git","ssh_url":"git@github.com:mozilla/zamboni.git","clone_url":"https://github.com/mozilla/zamboni.git","svn_url":"https://github.com/mozilla/zamboni","homepage":"http://zamboni.readthedocs.org","size":350619,"stargazers_count":418,"watchers_count":418,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":230,"mirror_url":null,"open_issues_count":18,"forks":230,"open_issues":18,"watchers":418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2314"},"html":{"href":"https://github.com/mozilla/zamboni/pull/2314"},"issue":{"href":"https://api.github.com/repos/mozilla/zamboni/issues/2314"},"comments":{"href":"https://api.github.com/repos/mozilla/zamboni/issues/2314/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2314/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2314/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/zamboni/statuses/580fed4ac217b8a67e637243c7f6a6a01c37a311"}}}}