GitHub PullRequestReviewCommentEvent at 2014-07-14 05:25:53
Repository: spark
Actor: andrewor14
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/14864917","id":14864917,"diff_hunk":"@@ -129,7 +128,7 @@ class BlockManagerMasterActor(val isLocal: Boolean, conf: SparkConf, listenerBus\n     case ExpireDeadHosts =>\n       expireDeadHosts()\n \n-    case HeartBeat(blockManagerId) =>\n+    case BlockManagerHeartbeat(blockManagerId) =>","path":"core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala","position":39,"original_position":39,"commit_id":"9ff13c60a91c41e9dd72e605af22807a2e5b5281","original_commit_id":"9ff13c60a91c41e9dd72e605af22807a2e5b5281","user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?","gravatar_id":"a05e843641a8e04d55eca499e2d04997","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"body":"It seems that this is no longer an actual heartbeat, i.e. we used to receive this from executors, but now we receive this from the driver to check whether this block manager exists.","created_at":"2014-07-14T05:25:53Z","updated_at":"2014-07-14T05:25:53Z","html_url":"https://github.com/apache/spark/pull/1056#discussion_r14864917","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/1056","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/14864917"},"html":{"href":"https://github.com/apache/spark/pull/1056#discussion_r14864917"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/1056"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/1056","id":17028356,"html_url":"https://github.com/apache/spark/pull/1056","diff_url":"https://github.com/apache/spark/pull/1056.diff","patch_url":"https://github.com/apache/spark/pull/1056.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/1056","number":1056,"state":"open","title":"SPARK-2099. Report progress while task is running.","user":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?","gravatar_id":"dab861f2a8878e52c6f9289d6bb3817b","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"body":"This is a sketch of a patch that allows the UI to show metrics for tasks that have not yet completed.  It adds a heartbeat every 2 seconds from the executors to the driver, reporting metrics for all of the executor's tasks. \r\n\r\nIt still needs unit tests, polish, and cluster testing, but I wanted to put it up to get feedback on the approach.","created_at":"2014-06-11T22:34:06Z","updated_at":"2014-07-14T05:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc7ad2fd896ca786b00b3135815ebabfc6695edc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/1056/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/1056/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/1056/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/9ff13c60a91c41e9dd72e605af22807a2e5b5281","head":{"label":"sryza:sandy-spark-2099","ref":"sandy-spark-2099","sha":"9ff13c60a91c41e9dd72e605af22807a2e5b5281","user":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?","gravatar_id":"dab861f2a8878e52c6f9289d6bb3817b","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"repo":{"id":17230980,"name":"spark","full_name":"sryza/spark","owner":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?","gravatar_id":"dab861f2a8878e52c6f9289d6bb3817b","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sryza/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sryza/spark","forks_url":"https://api.github.com/repos/sryza/spark/forks","keys_url":"https://api.github.com/repos/sryza/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sryza/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sryza/spark/teams","hooks_url":"https://api.github.com/repos/sryza/spark/hooks","issue_events_url":"https://api.github.com/repos/sryza/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sryza/spark/events","assignees_url":"https://api.github.com/repos/sryza/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sryza/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sryza/spark/tags","blobs_url":"https://api.github.com/repos/sryza/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sryza/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sryza/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sryza/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sryza/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sryza/spark/languages","stargazers_url":"https://api.github.com/repos/sryza/spark/stargazers","contributors_url":"https://api.github.com/repos/sryza/spark/contributors","subscribers_url":"https://api.github.com/repos/sryza/spark/subscribers","subscription_url":"https://api.github.com/repos/sryza/spark/subscription","commits_url":"https://api.github.com/repos/sryza/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sryza/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sryza/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sryza/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/sryza/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sryza/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sryza/spark/merges","archive_url":"https://api.github.com/repos/sryza/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sryza/spark/downloads","issues_url":"https://api.github.com/repos/sryza/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sryza/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sryza/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sryza/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sryza/spark/labels{/name}","releases_url":"https://api.github.com/repos/sryza/spark/releases{/id}","created_at":"2014-02-27T00:28:05Z","updated_at":"2014-06-25T08:18:09Z","pushed_at":"2014-07-12T19:47:03Z","git_url":"git://github.com/sryza/spark.git","ssh_url":"git@github.com:sryza/spark.git","clone_url":"https://github.com/sryza/spark.git","svn_url":"https://github.com/sryza/spark","homepage":null,"size":71353,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"18f29b96c7e0948f5f504e522e5aa8a8d1ab163e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-07-14T04:17:03Z","pushed_at":"2014-07-14T02:29:01Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":2194807,"stargazers_count":806,"watchers_count":806,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":829,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":242,"forks":829,"open_issues":242,"watchers":806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/1056"},"html":{"href":"https://github.com/apache/spark/pull/1056"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/1056"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/1056/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/1056/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/1056/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/9ff13c60a91c41e9dd72e605af22807a2e5b5281"}}}}