GitHub PullRequestReviewCommentEvent at 2014-09-12 01:27:46
Repository: ceph
Actor: ukernel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/17459542","id":17459542,"diff_hunk":"@@ -2009,8 +2030,13 @@ void Client::handle_mds_map(MMDSMap* m)\n     if (!mdsmap->is_up(p->first) ||\n \tmdsmap->get_inst(p->first) != p->second->inst) {\n       p->second->con->mark_down();\n-      if (mdsmap->is_up(p->first))\n+      if (mdsmap->is_up(p->first)) {\n \tp->second->inst = mdsmap->get_inst(p->first);\n+\t// When new MDS starts to take over, notify kernel to trim unused entries\n+\t// in its dcache/icache. Hopefully, the kernel will release some unused\n+\t// inodes before the new MDS enters reconnect state.\n+\ttrim_cache(1);\n+      }","path":"src/client/Client.cc","position":57,"original_position":57,"commit_id":"6a2a8579ee50e4cbdc2ba57ac966a36b65f76503","original_commit_id":"6a2a8579ee50e4cbdc2ba57ac966a36b65f76503","user":{"login":"ukernel","id":2775471,"avatar_url":"https://avatars.githubusercontent.com/u/2775471?v=2","gravatar_id":"ee0d301c23c8f8edb5d5880910e8de0d","url":"https://api.github.com/users/ukernel","html_url":"https://github.com/ukernel","followers_url":"https://api.github.com/users/ukernel/followers","following_url":"https://api.github.com/users/ukernel/following{/other_user}","gists_url":"https://api.github.com/users/ukernel/gists{/gist_id}","starred_url":"https://api.github.com/users/ukernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukernel/subscriptions","organizations_url":"https://api.github.com/users/ukernel/orgs","repos_url":"https://api.github.com/users/ukernel/repos","events_url":"https://api.github.com/users/ukernel/events{/privacy}","received_events_url":"https://api.github.com/users/ukernel/received_events","type":"User","site_admin":false},"body":"we can't wait too long once the MDS enters reconnect state. otherwise MDS will give up and close the session. there should be several seconds between MDS starts and MDS enters reconnect state. I think it should be enough for most case.","created_at":"2014-09-12T01:27:46Z","updated_at":"2014-09-12T01:27:46Z","html_url":"https://github.com/ceph/ceph/pull/2458#discussion_r17459542","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/2458","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/17459542"},"html":{"href":"https://github.com/ceph/ceph/pull/2458#discussion_r17459542"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/2458"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/2458","id":21062728,"html_url":"https://github.com/ceph/ceph/pull/2458","diff_url":"https://github.com/ceph/ceph/pull/2458.diff","patch_url":"https://github.com/ceph/ceph/pull/2458.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/2458","number":2458,"state":"open","locked":false,"title":"client: trim unused inodes before reconnecting to recovering MDS","user":{"login":"ukernel","id":2775471,"avatar_url":"https://avatars.githubusercontent.com/u/2775471?v=2","gravatar_id":"ee0d301c23c8f8edb5d5880910e8de0d","url":"https://api.github.com/users/ukernel","html_url":"https://github.com/ukernel","followers_url":"https://api.github.com/users/ukernel/followers","following_url":"https://api.github.com/users/ukernel/following{/other_user}","gists_url":"https://api.github.com/users/ukernel/gists{/gist_id}","starred_url":"https://api.github.com/users/ukernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukernel/subscriptions","organizations_url":"https://api.github.com/users/ukernel/orgs","repos_url":"https://api.github.com/users/ukernel/repos","events_url":"https://api.github.com/users/ukernel/events{/privacy}","received_events_url":"https://api.github.com/users/ukernel/received_events","type":"User","site_admin":false},"body":"So the recovering MDS does not need to fetch these ununsed inodes during\r\ncache rejoin. This may reduce MDS recovery time.\r\n\r\nSigned-off-by: Yan, Zheng <zyan@redhat.com>","created_at":"2014-09-11T02:05:43Z","updated_at":"2014-09-12T01:27:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d330b11efec2556019b80eaa3ef3007191f5b96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/2458/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/2458/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/2458/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/6a2a8579ee50e4cbdc2ba57ac966a36b65f76503","head":{"label":"ceph:wip-9341","ref":"wip-9341","sha":"6a2a8579ee50e4cbdc2ba57ac966a36b65f76503","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=2","gravatar_id":"05461e7575b7a9bb4499cec987f9da6d","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=2","gravatar_id":"05461e7575b7a9bb4499cec987f9da6d","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2014-09-11T22:51:22Z","pushed_at":"2014-09-12T00:47:26Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":282992,"stargazers_count":880,"watchers_count":880,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":418,"mirror_url":null,"open_issues_count":51,"forks":418,"open_issues":51,"watchers":880,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"e50c426bef4eba5b7f09bdc4e2e4f41ea1120d6b","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=2","gravatar_id":"05461e7575b7a9bb4499cec987f9da6d","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=2","gravatar_id":"05461e7575b7a9bb4499cec987f9da6d","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2014-09-11T22:51:22Z","pushed_at":"2014-09-12T00:47:26Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":282992,"stargazers_count":880,"watchers_count":880,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":418,"mirror_url":null,"open_issues_count":51,"forks":418,"open_issues":51,"watchers":880,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/2458"},"html":{"href":"https://github.com/ceph/ceph/pull/2458"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/2458"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/2458/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/2458/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/2458/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/6a2a8579ee50e4cbdc2ba57ac966a36b65f76503"}}}}