GitHub PullRequestEvent at 2014-05-19 12:26:06
Repository: puppet
Actor: hlindberg
Payload: {"action":"closed","number":2664,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2664","id":16015614,"html_url":"https://github.com/puppetlabs/puppet/pull/2664","diff_url":"https://github.com/puppetlabs/puppet/pull/2664.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/2664.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2664","number":2664,"state":"closed","title":"(PUP-2610) Maintain context during application exit","user":{"login":"zaphod42","id":295810,"avatar_url":"https://avatars.githubusercontent.com/u/295810?","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"body":"Because of the way rack servers get configured by puppet, the application\nsystem needs to maintain any context information that is setup while starting\neven after the application has exited. This is because the rack app is\ncreated by calling the \"master\" application and using the return value (which\nthreads all the way back through the application and command line layers) as\nthe rack app. When the contexts were removed on the way out of the\napplication they also removed the setup for how environments were loaded.\n\nThis also required that there be a way of undoing a series of context pushes\nwithout knowing how many had been done. For this there is now a mark and\nrollback capability in the Puppet::Context system. This is used in the tests\nto always return to the context that was present at the start of every test.","created_at":"2014-05-17T01:02:16Z","updated_at":"2014-05-19T12:26:05Z","closed_at":"2014-05-19T12:26:05Z","merged_at":"2014-05-19T12:26:05Z","merge_commit_sha":"74244b1c33ff45e12caf383880173685ca5155ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2664/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2664/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2664/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/6cd1969598463f73fc26cf400d40cb3943a708b8","head":{"label":"zaphod42:issue/stable/pup-2610-rack-fails-to-track-environments","ref":"issue/stable/pup-2610-rack-fails-to-track-environments","sha":"6cd1969598463f73fc26cf400d40cb3943a708b8","user":{"login":"zaphod42","id":295810,"avatar_url":"https://avatars.githubusercontent.com/u/295810?","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"repo":{"id":3769776,"name":"puppet","full_name":"zaphod42/puppet","owner":{"login":"zaphod42","id":295810,"avatar_url":"https://avatars.githubusercontent.com/u/295810?","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zaphod42/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/zaphod42/puppet","forks_url":"https://api.github.com/repos/zaphod42/puppet/forks","keys_url":"https://api.github.com/repos/zaphod42/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaphod42/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaphod42/puppet/teams","hooks_url":"https://api.github.com/repos/zaphod42/puppet/hooks","issue_events_url":"https://api.github.com/repos/zaphod42/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/zaphod42/puppet/events","assignees_url":"https://api.github.com/repos/zaphod42/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/zaphod42/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/zaphod42/puppet/tags","blobs_url":"https://api.github.com/repos/zaphod42/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaphod42/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaphod42/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaphod42/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaphod42/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/zaphod42/puppet/languages","stargazers_url":"https://api.github.com/repos/zaphod42/puppet/stargazers","contributors_url":"https://api.github.com/repos/zaphod42/puppet/contributors","subscribers_url":"https://api.github.com/repos/zaphod42/puppet/subscribers","subscription_url":"https://api.github.com/repos/zaphod42/puppet/subscription","commits_url":"https://api.github.com/repos/zaphod42/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaphod42/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaphod42/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaphod42/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/zaphod42/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/zaphod42/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaphod42/puppet/merges","archive_url":"https://api.github.com/repos/zaphod42/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaphod42/puppet/downloads","issues_url":"https://api.github.com/repos/zaphod42/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/zaphod42/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/zaphod42/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/zaphod42/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaphod42/puppet/labels{/name}","releases_url":"https://api.github.com/repos/zaphod42/puppet/releases{/id}","created_at":"2012-03-19T23:17:16Z","updated_at":"2014-05-19T12:26:05Z","pushed_at":"2014-05-17T01:14:56Z","git_url":"git://github.com/zaphod42/puppet.git","ssh_url":"git@github.com:zaphod42/puppet.git","clone_url":"https://github.com/zaphod42/puppet.git","svn_url":"https://github.com/zaphod42/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":43037,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"75569b11d209328be9491d7ed9623ed64405e1f0","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-05-19T12:26:05Z","pushed_at":"2014-05-19T12:26:05Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":93396,"stargazers_count":2192,"watchers_count":2192,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":978,"mirror_url":null,"open_issues_count":41,"forks":978,"open_issues":41,"watchers":2192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2664"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2664"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2664"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2664/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2664/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2664/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/6cd1969598463f73fc26cf400d40cb3943a708b8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":113,"deletions":24,"changed_files":5}}