GitHub PullRequestReviewCommentEvent at 2014-03-31 11:17:07
Repository: ofono
Actor: alfonsosanchezbeato
Payload: {"comment":{"url":"https://api.github.com/repos/rilmodem/ofono/pulls/comments/11111268","id":11111268,"diff_hunk":"@@ -82,22 +172,27 @@ static int provision_get_settings(const char *mcc, const char *mnc,\n \t*count = ap_count;\n \n \tfor (l = apns, i = 0; l; l = l->next, i++) {\n-\t\tstruct ofono_gprs_provision_data *ap = l->data;","path":"plugins/android-provision.c","position":140,"original_position":140,"commit_id":"392b9a34f8ea274f6ed3fdaa038c495a08bc2356","original_commit_id":"392b9a34f8ea274f6ed3fdaa038c495a08bc2356","user":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?","gravatar_id":"453820f22faaf41a8a02ac1f67261e34","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"body":"(I comment this here because I cannot do it in the right line as there is no change there)\r\n\r\ng_slist_free_full(apns, android_apndb_ap_free);\r\n\r\nis wrong, as android_apndb_ap_free() frees an ofono_gprs_provision_data struct instead of an apndb_provision_data struct","created_at":"2014-03-31T11:17:07Z","updated_at":"2014-03-31T11:17:07Z","html_url":"https://github.com/rilmodem/ofono/pull/65#discussion_r11111268","pull_request_url":"https://api.github.com/repos/rilmodem/ofono/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/rilmodem/ofono/pulls/comments/11111268"},"html":{"href":"https://github.com/rilmodem/ofono/pull/65#discussion_r11111268"},"pull_request":{"href":"https://api.github.com/repos/rilmodem/ofono/pulls/65"}}}}