GitHub PullRequestReviewCommentEvent at 2014-11-03 12:49:50
Repository: picongpu
Actor: PrometheusPi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/19730740","id":19730740,"diff_hunk":"@@ -34,12 +34,6 @@ namespace limits\n {\n \n template<>\n-struct Max<size_t>\n-{\n-    static const size_t value=static_cast<size_t>(-1);\n-};\n-\n-template<>\n struct Max<int>","path":"src/libPMacc/include/traits/Limits.tpp","position":10,"original_position":10,"commit_id":"ed9a16f31410888ff0b6c37e31a678f70bce1de7","original_commit_id":"ed9a16f31410888ff0b6c37e31a678f70bce1de7","user":{"login":"PrometheusPi","id":5121158,"avatar_url":"https://avatars.githubusercontent.com/u/5121158?v=2","gravatar_id":"","url":"https://api.github.com/users/PrometheusPi","html_url":"https://github.com/PrometheusPi","followers_url":"https://api.github.com/users/PrometheusPi/followers","following_url":"https://api.github.com/users/PrometheusPi/following{/other_user}","gists_url":"https://api.github.com/users/PrometheusPi/gists{/gist_id}","starred_url":"https://api.github.com/users/PrometheusPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrometheusPi/subscriptions","organizations_url":"https://api.github.com/users/PrometheusPi/orgs","repos_url":"https://api.github.com/users/PrometheusPi/repos","events_url":"https://api.github.com/users/PrometheusPi/events{/privacy}","received_events_url":"https://api.github.com/users/PrometheusPi/received_events","type":"User","site_admin":false},"body":"why do you still use `int` not `uint32_t` here?","created_at":"2014-11-03T12:49:50Z","updated_at":"2014-11-03T12:49:50Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/572#discussion_r19730740","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/572","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/19730740"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/572#discussion_r19730740"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/572"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/572","id":23520769,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/572","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/572.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/572.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/572","number":572,"state":"open","locked":false,"title":"Fix #571 libPMacc limits: 32 bit host","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=2","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"Fix for #571: on 32bit hosts, size_t is the same as uint32_t (hopefully) which declares the `max` for it twice.\r\n\r\nReported by @sigkill on github, thanks!\r\n\r\n@psychocoderHPC @f-schmitt-zih can one of you please review that? :)\r\n\r\n- [x] @ax3l needs to be cherry-picked in `release-beta-rc6` afterwards","created_at":"2014-10-29T10:38:49Z","updated_at":"2014-11-03T12:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84692eb9c389b4d048d07d33613157edfcc4cf9e","assignee":{"login":"PrometheusPi","id":5121158,"avatar_url":"https://avatars.githubusercontent.com/u/5121158?v=2","gravatar_id":"","url":"https://api.github.com/users/PrometheusPi","html_url":"https://github.com/PrometheusPi","followers_url":"https://api.github.com/users/PrometheusPi/followers","following_url":"https://api.github.com/users/PrometheusPi/following{/other_user}","gists_url":"https://api.github.com/users/PrometheusPi/gists{/gist_id}","starred_url":"https://api.github.com/users/PrometheusPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrometheusPi/subscriptions","organizations_url":"https://api.github.com/users/PrometheusPi/orgs","repos_url":"https://api.github.com/users/PrometheusPi/repos","events_url":"https://api.github.com/users/PrometheusPi/events{/privacy}","received_events_url":"https://api.github.com/users/PrometheusPi/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=2","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":464,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2014-10-29T10:38:56Z","due_on":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/572/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/572/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/572/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/ed9a16f31410888ff0b6c37e31a678f70bce1de7","head":{"label":"ax3l:fix-limits32BitHost","ref":"fix-limits32BitHost","sha":"ed9a16f31410888ff0b6c37e31a678f70bce1de7","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=2","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"repo":{"id":12108745,"name":"picongpu","full_name":"ax3l/picongpu","owner":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=2","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ax3l/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/ax3l/picongpu","forks_url":"https://api.github.com/repos/ax3l/picongpu/forks","keys_url":"https://api.github.com/repos/ax3l/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ax3l/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ax3l/picongpu/teams","hooks_url":"https://api.github.com/repos/ax3l/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ax3l/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ax3l/picongpu/events","assignees_url":"https://api.github.com/repos/ax3l/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ax3l/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ax3l/picongpu/tags","blobs_url":"https://api.github.com/repos/ax3l/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ax3l/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ax3l/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ax3l/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ax3l/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ax3l/picongpu/languages","stargazers_url":"https://api.github.com/repos/ax3l/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ax3l/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ax3l/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ax3l/picongpu/subscription","commits_url":"https://api.github.com/repos/ax3l/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ax3l/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ax3l/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ax3l/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/ax3l/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ax3l/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ax3l/picongpu/merges","archive_url":"https://api.github.com/repos/ax3l/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ax3l/picongpu/downloads","issues_url":"https://api.github.com/repos/ax3l/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ax3l/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ax3l/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ax3l/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ax3l/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ax3l/picongpu/releases{/id}","created_at":"2013-08-14T12:51:14Z","updated_at":"2014-10-30T00:42:05Z","pushed_at":"2014-10-29T10:42:17Z","git_url":"git://github.com/ax3l/picongpu.git","ssh_url":"git@github.com:ax3l/picongpu.git","clone_url":"https://github.com/ax3l/picongpu.git","svn_url":"https://github.com/ax3l/picongpu","homepage":"http://picongpu.hzdr.de","size":10578,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"cff7dc525eda324b92caa22a6dd24799fa83fd71","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=2","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=2","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2014-10-29T04:48:10Z","pushed_at":"2014-11-03T12:48:32Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":23872,"stargazers_count":69,"watchers_count":69,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":82,"forks":35,"open_issues":82,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/572"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/572"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/572"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/572/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/572/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/572/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/ed9a16f31410888ff0b6c37e31a678f70bce1de7"}}}}