GitHub PullRequestReviewCommentEvent at 2014-06-17 17:57:09
Repository: OpenTreeMap-Android
Actor: maurizi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/comments/13874820","id":13874820,"diff_hunk":"@@ -103,6 +103,15 @@ public void getPlotsNearLocation(double geoY, double geoX, boolean recent, boole\n \t\tgetPlotsNearLocation(geoY, geoX, params, handler);\n \t}\n \n+\tpublic void getInstancesNearLocation(double geoY, double geoX,\n+\t\t\tJsonHttpResponseHandler handler) {\n+\t\tSharedPreferences sharedPrefs = App.getSharedPreferences();\n+\n+\t\tString url = String.format(\"locations/%s,%s/instances\", geoY, geoX);\n+        userOptionalGet(url, null, handler);","path":"OpenTreeMap/src/org/azavea/otm/rest/RequestGenerator.java","position":9,"original_position":9,"commit_id":"1227e6222747fdc1a5ef95e2c398e61735287d2b","original_commit_id":"1227e6222747fdc1a5ef95e2c398e61735287d2b","user":{"login":"maurizi","id":4432106,"avatar_url":"https://avatars.githubusercontent.com/u/4432106?","gravatar_id":"846d2ec7efaf249ea46484f423ed1be7","url":"https://api.github.com/users/maurizi","html_url":"https://github.com/maurizi","followers_url":"https://api.github.com/users/maurizi/followers","following_url":"https://api.github.com/users/maurizi/following{/other_user}","gists_url":"https://api.github.com/users/maurizi/gists{/gist_id}","starred_url":"https://api.github.com/users/maurizi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurizi/subscriptions","organizations_url":"https://api.github.com/users/maurizi/orgs","repos_url":"https://api.github.com/users/maurizi/repos","events_url":"https://api.github.com/users/maurizi/events{/privacy}","received_events_url":"https://api.github.com/users/maurizi/received_events","type":"User","site_admin":false},"body":"The indentation is a little funky here","created_at":"2014-06-17T17:57:09Z","updated_at":"2014-06-17T17:57:09Z","html_url":"https://github.com/OpenTreeMap/OpenTreeMap-Android/pull/86#discussion_r13874820","pull_request_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/comments/13874820"},"html":{"href":"https://github.com/OpenTreeMap/OpenTreeMap-Android/pull/86#discussion_r13874820"},"pull_request":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/86","id":17249774,"html_url":"https://github.com/OpenTreeMap/OpenTreeMap-Android/pull/86","diff_url":"https://github.com/OpenTreeMap/OpenTreeMap-Android/pull/86.diff","patch_url":"https://github.com/OpenTreeMap/OpenTreeMap-Android/pull/86.patch","issue_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/issues/86","number":86,"state":"open","title":"Topic/instance switcher","user":{"login":"steventlamb","id":1699455,"avatar_url":"https://avatars.githubusercontent.com/u/1699455?","gravatar_id":"217b45ba11fa1aaa49acde2b1283747a","url":"https://api.github.com/users/steventlamb","html_url":"https://github.com/steventlamb","followers_url":"https://api.github.com/users/steventlamb/followers","following_url":"https://api.github.com/users/steventlamb/following{/other_user}","gists_url":"https://api.github.com/users/steventlamb/gists{/gist_id}","starred_url":"https://api.github.com/users/steventlamb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steventlamb/subscriptions","organizations_url":"https://api.github.com/users/steventlamb/orgs","repos_url":"https://api.github.com/users/steventlamb/repos","events_url":"https://api.github.com/users/steventlamb/events{/privacy}","received_events_url":"https://api.github.com/users/steventlamb/received_events","type":"User","site_admin":false},"body":"Opening this at Mike's request. The feature basically works, but there are a few fatal crashes that I'm still working through, which will get fixed before this is merged.\r\n\r\nPlease disregard the first two commits, they mirror each other. This was used as a way to check in inbetween changes, but continue to edit them in the staging environment, by backing them out. This will not be merged.","created_at":"2014-06-17T17:32:32Z","updated_at":"2014-06-17T17:57:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba5a3b6a848666916ad58673369a29957c09df30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/86/commits","review_comments_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/86/comments","review_comment_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/issues/86/comments","statuses_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/statuses/1227e6222747fdc1a5ef95e2c398e61735287d2b","head":{"label":"steventlamb:topic/instance_switcher","ref":"topic/instance_switcher","sha":"1227e6222747fdc1a5ef95e2c398e61735287d2b","user":{"login":"steventlamb","id":1699455,"avatar_url":"https://avatars.githubusercontent.com/u/1699455?","gravatar_id":"217b45ba11fa1aaa49acde2b1283747a","url":"https://api.github.com/users/steventlamb","html_url":"https://github.com/steventlamb","followers_url":"https://api.github.com/users/steventlamb/followers","following_url":"https://api.github.com/users/steventlamb/following{/other_user}","gists_url":"https://api.github.com/users/steventlamb/gists{/gist_id}","starred_url":"https://api.github.com/users/steventlamb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steventlamb/subscriptions","organizations_url":"https://api.github.com/users/steventlamb/orgs","repos_url":"https://api.github.com/users/steventlamb/repos","events_url":"https://api.github.com/users/steventlamb/events{/privacy}","received_events_url":"https://api.github.com/users/steventlamb/received_events","type":"User","site_admin":false},"repo":{"id":17985876,"name":"OpenTreeMap-Android","full_name":"steventlamb/OpenTreeMap-Android","owner":{"login":"steventlamb","id":1699455,"avatar_url":"https://avatars.githubusercontent.com/u/1699455?","gravatar_id":"217b45ba11fa1aaa49acde2b1283747a","url":"https://api.github.com/users/steventlamb","html_url":"https://github.com/steventlamb","followers_url":"https://api.github.com/users/steventlamb/followers","following_url":"https://api.github.com/users/steventlamb/following{/other_user}","gists_url":"https://api.github.com/users/steventlamb/gists{/gist_id}","starred_url":"https://api.github.com/users/steventlamb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steventlamb/subscriptions","organizations_url":"https://api.github.com/users/steventlamb/orgs","repos_url":"https://api.github.com/users/steventlamb/repos","events_url":"https://api.github.com/users/steventlamb/events{/privacy}","received_events_url":"https://api.github.com/users/steventlamb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steventlamb/OpenTreeMap-Android","description":"An OpenTreeMap client for Android. The OpenTreeMap code can be downloaded at https://github.com/OpenTreeMap/OpenTreeMap.","fork":true,"url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android","forks_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/forks","keys_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/teams","hooks_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/hooks","issue_events_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/issues/events{/number}","events_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/events","assignees_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/assignees{/user}","branches_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/branches{/branch}","tags_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/tags","blobs_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/languages","stargazers_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/stargazers","contributors_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/contributors","subscribers_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/subscribers","subscription_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/subscription","commits_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/issues/comments/{number}","contents_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/contents/{+path}","compare_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/merges","archive_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/downloads","issues_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/issues{/number}","pulls_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/labels{/name}","releases_url":"https://api.github.com/repos/steventlamb/OpenTreeMap-Android/releases{/id}","created_at":"2014-03-21T16:16:06Z","updated_at":"2014-06-17T17:32:32Z","pushed_at":"2014-06-17T17:30:35Z","git_url":"git://github.com/steventlamb/OpenTreeMap-Android.git","ssh_url":"git@github.com:steventlamb/OpenTreeMap-Android.git","clone_url":"https://github.com/steventlamb/OpenTreeMap-Android.git","svn_url":"https://github.com/steventlamb/OpenTreeMap-Android","homepage":"","size":84580,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenTreeMap:master","ref":"master","sha":"b261850ae7508f1dea7a03d916409786a08cd9b0","user":{"login":"OpenTreeMap","id":1125635,"avatar_url":"https://avatars.githubusercontent.com/u/1125635?","gravatar_id":"b426c42f38b4fef46591a9e4dde562a9","url":"https://api.github.com/users/OpenTreeMap","html_url":"https://github.com/OpenTreeMap","followers_url":"https://api.github.com/users/OpenTreeMap/followers","following_url":"https://api.github.com/users/OpenTreeMap/following{/other_user}","gists_url":"https://api.github.com/users/OpenTreeMap/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenTreeMap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenTreeMap/subscriptions","organizations_url":"https://api.github.com/users/OpenTreeMap/orgs","repos_url":"https://api.github.com/users/OpenTreeMap/repos","events_url":"https://api.github.com/users/OpenTreeMap/events{/privacy}","received_events_url":"https://api.github.com/users/OpenTreeMap/received_events","type":"Organization","site_admin":false},"repo":{"id":11530387,"name":"OpenTreeMap-Android","full_name":"OpenTreeMap/OpenTreeMap-Android","owner":{"login":"OpenTreeMap","id":1125635,"avatar_url":"https://avatars.githubusercontent.com/u/1125635?","gravatar_id":"b426c42f38b4fef46591a9e4dde562a9","url":"https://api.github.com/users/OpenTreeMap","html_url":"https://github.com/OpenTreeMap","followers_url":"https://api.github.com/users/OpenTreeMap/followers","following_url":"https://api.github.com/users/OpenTreeMap/following{/other_user}","gists_url":"https://api.github.com/users/OpenTreeMap/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenTreeMap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenTreeMap/subscriptions","organizations_url":"https://api.github.com/users/OpenTreeMap/orgs","repos_url":"https://api.github.com/users/OpenTreeMap/repos","events_url":"https://api.github.com/users/OpenTreeMap/events{/privacy}","received_events_url":"https://api.github.com/users/OpenTreeMap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenTreeMap/OpenTreeMap-Android","description":"An OpenTreeMap client for Android. The OpenTreeMap code can be downloaded at https://github.com/OpenTreeMap/OpenTreeMap.","fork":false,"url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android","forks_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/forks","keys_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/teams","hooks_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/hooks","issue_events_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/issues/events{/number}","events_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/events","assignees_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/assignees{/user}","branches_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/branches{/branch}","tags_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/tags","blobs_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/languages","stargazers_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/stargazers","contributors_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/contributors","subscribers_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/subscribers","subscription_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/subscription","commits_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/contents/{+path}","compare_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/merges","archive_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/downloads","issues_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/issues{/number}","pulls_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/labels{/name}","releases_url":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/releases{/id}","created_at":"2013-07-19T15:04:38Z","updated_at":"2014-06-17T14:51:42Z","pushed_at":"2014-06-17T14:51:42Z","git_url":"git://github.com/OpenTreeMap/OpenTreeMap-Android.git","ssh_url":"git@github.com:OpenTreeMap/OpenTreeMap-Android.git","clone_url":"https://github.com/OpenTreeMap/OpenTreeMap-Android.git","svn_url":"https://github.com/OpenTreeMap/OpenTreeMap-Android","homepage":"","size":85828,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":20,"forks":7,"open_issues":20,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/86"},"html":{"href":"https://github.com/OpenTreeMap/OpenTreeMap-Android/pull/86"},"issue":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/issues/86"},"comments":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/OpenTreeMap/OpenTreeMap-Android/statuses/1227e6222747fdc1a5ef95e2c398e61735287d2b"}}}}