GitHub PullRequestReviewCommentEvent at 2014-07-21 20:51:37
Repository: generator-angular-fullstack
Actor: remicastaing
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments/15195434","id":15195434,"diff_hunk":"@@ -6,18 +6,14 @@\n // This file should not be tracked by git.\n \n module.exports = {\n-  DOMAIN:           'http://localhost:9000',\n-  SESSION_SECRET:   \"<%= _.slugify(appname) + '-secret' %>\",\n-\n-  FACEBOOK_ID:      'app-id',\n-  FACEBOOK_SECRET:  'secret',\n-\n-  TWITTER_ID:       'app-id',\n-  TWITTER_SECRET:   'secret',\n-\n-  GOOGLE_ID:        'app-id',\n-  GOOGLE_SECRET:    'secret',\n-\n+  DOMAIN: 'http://localhost:9000',\n+  SESSION_SECRET: \"<%= _.slugify(appname) + '-secret' %>\",<% if (filters.facebookAuth) { %>\n+  FACEBOOK_ID: 'app-id',\n+  FACEBOOK_SECRET: 'secret',<% } if (filters.twitterAuth) { %>\n+  TWITTER_ID: 'app-id',\n+  TWITTER_SECRET: 'secret',<% } if (filters.googleAuth) { %>\n+  GOOGLE_ID: 'app-id',\n+  GOOGLE_SECRET: 'secret',<% } %>","path":"app/templates/server/config/_local.env.js","position":23,"original_position":23,"commit_id":"507e45a08a0719d2ccd80d0aa4d288aa8a4f7060","original_commit_id":"507e45a08a0719d2ccd80d0aa4d288aa8a4f7060","user":{"login":"remicastaing","id":1715952,"avatar_url":"https://avatars.githubusercontent.com/u/1715952?","gravatar_id":"1874f0d0e645940a0ac6bef42633d744","url":"https://api.github.com/users/remicastaing","html_url":"https://github.com/remicastaing","followers_url":"https://api.github.com/users/remicastaing/followers","following_url":"https://api.github.com/users/remicastaing/following{/other_user}","gists_url":"https://api.github.com/users/remicastaing/gists{/gist_id}","starred_url":"https://api.github.com/users/remicastaing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remicastaing/subscriptions","organizations_url":"https://api.github.com/users/remicastaing/orgs","repos_url":"https://api.github.com/users/remicastaing/repos","events_url":"https://api.github.com/users/remicastaing/events{/privacy}","received_events_url":"https://api.github.com/users/remicastaing/received_events","type":"User","site_admin":false},"body":"OK. I understand. But, it will work and will not prevent using my \"trick\". I will make a PR to show you.\r\n\r\nPS: Thank for the quote. I was seeking the markdown shortcut and didn't find it immediately, so I passed.","created_at":"2014-07-21T20:51:37Z","updated_at":"2014-07-21T20:51:37Z","html_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/366#discussion_r15195434","pull_request_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/366","_links":{"self":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments/15195434"},"html":{"href":"https://github.com/DaftMonk/generator-angular-fullstack/pull/366#discussion_r15195434"},"pull_request":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/366","id":18557864,"html_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/366","diff_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/366.diff","patch_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/366.patch","issue_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/366","number":366,"state":"open","title":"feat(oauth): remove code according to user prompts","user":{"login":"Apercu","id":6033345,"avatar_url":"https://avatars.githubusercontent.com/u/6033345?","gravatar_id":"81b90f075c42dfb9ae3cc3d3e6256691","url":"https://api.github.com/users/Apercu","html_url":"https://github.com/Apercu","followers_url":"https://api.github.com/users/Apercu/followers","following_url":"https://api.github.com/users/Apercu/following{/other_user}","gists_url":"https://api.github.com/users/Apercu/gists{/gist_id}","starred_url":"https://api.github.com/users/Apercu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apercu/subscriptions","organizations_url":"https://api.github.com/users/Apercu/orgs","repos_url":"https://api.github.com/users/Apercu/repos","events_url":"https://api.github.com/users/Apercu/events{/privacy}","received_events_url":"https://api.github.com/users/Apercu/received_events","type":"User","site_admin":false},"body":"Add one global oauth filter that is set to true when we have at lease one oAuth strategy to simplify some conditions.\r\n\r\nRemove all code that is not necessary depending on what is taken at the initialization.\r\n\r\nApplied in style files, login and signup controllers / views, user model and env config file.","created_at":"2014-07-17T22:11:06Z","updated_at":"2014-07-21T20:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cddc6d847809719beecc7b17f12e6be34765c577","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/366/commits","review_comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/366/comments","review_comment_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/366/comments","statuses_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/507e45a08a0719d2ccd80d0aa4d288aa8a4f7060","head":{"label":"Apercu:fix/remove-oauth-code","ref":"fix/remove-oauth-code","sha":"507e45a08a0719d2ccd80d0aa4d288aa8a4f7060","user":{"login":"Apercu","id":6033345,"avatar_url":"https://avatars.githubusercontent.com/u/6033345?","gravatar_id":"81b90f075c42dfb9ae3cc3d3e6256691","url":"https://api.github.com/users/Apercu","html_url":"https://github.com/Apercu","followers_url":"https://api.github.com/users/Apercu/followers","following_url":"https://api.github.com/users/Apercu/following{/other_user}","gists_url":"https://api.github.com/users/Apercu/gists{/gist_id}","starred_url":"https://api.github.com/users/Apercu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apercu/subscriptions","organizations_url":"https://api.github.com/users/Apercu/orgs","repos_url":"https://api.github.com/users/Apercu/repos","events_url":"https://api.github.com/users/Apercu/events{/privacy}","received_events_url":"https://api.github.com/users/Apercu/received_events","type":"User","site_admin":false},"repo":{"id":17668381,"name":"generator-angular-fullstack","full_name":"Apercu/generator-angular-fullstack","owner":{"login":"Apercu","id":6033345,"avatar_url":"https://avatars.githubusercontent.com/u/6033345?","gravatar_id":"81b90f075c42dfb9ae3cc3d3e6256691","url":"https://api.github.com/users/Apercu","html_url":"https://github.com/Apercu","followers_url":"https://api.github.com/users/Apercu/followers","following_url":"https://api.github.com/users/Apercu/following{/other_user}","gists_url":"https://api.github.com/users/Apercu/gists{/gist_id}","starred_url":"https://api.github.com/users/Apercu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apercu/subscriptions","organizations_url":"https://api.github.com/users/Apercu/orgs","repos_url":"https://api.github.com/users/Apercu/repos","events_url":"https://api.github.com/users/Apercu/events{/privacy}","received_events_url":"https://api.github.com/users/Apercu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Apercu/generator-angular-fullstack","description":"Yeoman generator for AngularJS with an Express server","fork":true,"url":"https://api.github.com/repos/Apercu/generator-angular-fullstack","forks_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/forks","keys_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/teams","hooks_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/hooks","issue_events_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/issues/events{/number}","events_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/events","assignees_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/assignees{/user}","branches_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/branches{/branch}","tags_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/tags","blobs_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/statuses/{sha}","languages_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/languages","stargazers_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/stargazers","contributors_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/contributors","subscribers_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/subscribers","subscription_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/subscription","commits_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/issues/comments/{number}","contents_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/contents/{+path}","compare_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/merges","archive_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/downloads","issues_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/issues{/number}","pulls_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/pulls{/number}","milestones_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/milestones{/number}","notifications_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/labels{/name}","releases_url":"https://api.github.com/repos/Apercu/generator-angular-fullstack/releases{/id}","created_at":"2014-03-12T13:46:45Z","updated_at":"2014-06-29T09:10:22Z","pushed_at":"2014-07-21T07:13:07Z","git_url":"git://github.com/Apercu/generator-angular-fullstack.git","ssh_url":"git@github.com:Apercu/generator-angular-fullstack.git","clone_url":"https://github.com/Apercu/generator-angular-fullstack.git","svn_url":"https://github.com/Apercu/generator-angular-fullstack","homepage":"http://yeoman.io","size":5237,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DaftMonk:master","ref":"master","sha":"cb866d1da150c2bec5c2b4fea52ab50365aa8140","user":{"login":"DaftMonk","id":2505273,"avatar_url":"https://avatars.githubusercontent.com/u/2505273?","gravatar_id":"b80cadb42cceabbdd20fb3e615e7f50e","url":"https://api.github.com/users/DaftMonk","html_url":"https://github.com/DaftMonk","followers_url":"https://api.github.com/users/DaftMonk/followers","following_url":"https://api.github.com/users/DaftMonk/following{/other_user}","gists_url":"https://api.github.com/users/DaftMonk/gists{/gist_id}","starred_url":"https://api.github.com/users/DaftMonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaftMonk/subscriptions","organizations_url":"https://api.github.com/users/DaftMonk/orgs","repos_url":"https://api.github.com/users/DaftMonk/repos","events_url":"https://api.github.com/users/DaftMonk/events{/privacy}","received_events_url":"https://api.github.com/users/DaftMonk/received_events","type":"User","site_admin":false},"repo":{"id":13911118,"name":"generator-angular-fullstack","full_name":"DaftMonk/generator-angular-fullstack","owner":{"login":"DaftMonk","id":2505273,"avatar_url":"https://avatars.githubusercontent.com/u/2505273?","gravatar_id":"b80cadb42cceabbdd20fb3e615e7f50e","url":"https://api.github.com/users/DaftMonk","html_url":"https://github.com/DaftMonk","followers_url":"https://api.github.com/users/DaftMonk/followers","following_url":"https://api.github.com/users/DaftMonk/following{/other_user}","gists_url":"https://api.github.com/users/DaftMonk/gists{/gist_id}","starred_url":"https://api.github.com/users/DaftMonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaftMonk/subscriptions","organizations_url":"https://api.github.com/users/DaftMonk/orgs","repos_url":"https://api.github.com/users/DaftMonk/repos","events_url":"https://api.github.com/users/DaftMonk/events{/privacy}","received_events_url":"https://api.github.com/users/DaftMonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaftMonk/generator-angular-fullstack","description":"Yeoman generator for AngularJS with an Express server","fork":true,"url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack","forks_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/forks","keys_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/teams","hooks_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/hooks","issue_events_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/events{/number}","events_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/events","assignees_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/assignees{/user}","branches_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/branches{/branch}","tags_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/tags","blobs_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/{sha}","languages_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/languages","stargazers_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/stargazers","contributors_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/contributors","subscribers_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/subscribers","subscription_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/subscription","commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/comments/{number}","contents_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/contents/{+path}","compare_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/merges","archive_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/downloads","issues_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues{/number}","pulls_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls{/number}","milestones_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/milestones{/number}","notifications_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/labels{/name}","releases_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/releases{/id}","created_at":"2013-10-27T21:56:18Z","updated_at":"2014-07-21T16:34:02Z","pushed_at":"2014-07-21T02:37:12Z","git_url":"git://github.com/DaftMonk/generator-angular-fullstack.git","ssh_url":"git@github.com:DaftMonk/generator-angular-fullstack.git","clone_url":"https://github.com/DaftMonk/generator-angular-fullstack.git","svn_url":"https://github.com/DaftMonk/generator-angular-fullstack","homepage":"http://yeoman.io","size":8192,"stargazers_count":1485,"watchers_count":1485,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":251,"mirror_url":null,"open_issues_count":42,"forks":251,"open_issues":42,"watchers":1485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/366"},"html":{"href":"https://github.com/DaftMonk/generator-angular-fullstack/pull/366"},"issue":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/366"},"comments":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/507e45a08a0719d2ccd80d0aa4d288aa8a4f7060"}}}}