GitHub PullRequestReviewCommentEvent at 2014-07-13 23:53:42
Repository: junit
Actor: kcooney
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit/pulls/comments/14861019","id":14861019,"diff_hunk":"@@ -81,7 +81,12 @@ public DescriptionBuilder withUniqueId(String uniqueId) {\n      * @param annotations the additional annotations\n      */\n     public DescriptionBuilder withAdditionalAnnotations(List<Annotation> annotations) {\n-        this.annotations.addAll(annotations);\n+        for (Annotation a : annotations) {\n+            if (a == null) {\n+                throw new NullPointerException(\"Cannot add a null annotation\");\n+            }\n+            this.annotations.add(a);","path":"src/main/java/org/junit/runner/DescriptionBuilder.java","position":9,"original_position":9,"commit_id":"e7ebb5be274f644ffa57309e07bbefd0dbc20dfb","original_commit_id":"e7ebb5be274f644ffa57309e07bbefd0dbc20dfb","user":{"login":"kcooney","id":478190,"avatar_url":"https://avatars.githubusercontent.com/u/478190?","gravatar_id":"3e1323e035210af33f94c2d19192c936","url":"https://api.github.com/users/kcooney","html_url":"https://github.com/kcooney","followers_url":"https://api.github.com/users/kcooney/followers","following_url":"https://api.github.com/users/kcooney/following{/other_user}","gists_url":"https://api.github.com/users/kcooney/gists{/gist_id}","starred_url":"https://api.github.com/users/kcooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcooney/subscriptions","organizations_url":"https://api.github.com/users/kcooney/orgs","repos_url":"https://api.github.com/users/kcooney/repos","events_url":"https://api.github.com/users/kcooney/events{/privacy}","received_events_url":"https://api.github.com/users/kcooney/received_events","type":"User","site_admin":false},"body":"@AlexYursha see http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/util/ArrayList.java#499","created_at":"2014-07-13T23:53:42Z","updated_at":"2014-07-13T23:53:42Z","html_url":"https://github.com/junit-team/junit/pull/955#discussion_r14861019","pull_request_url":"https://api.github.com/repos/junit-team/junit/pulls/955","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments/14861019"},"html":{"href":"https://github.com/junit-team/junit/pull/955#discussion_r14861019"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit/pulls/955"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit/pulls/955","id":18324211,"html_url":"https://github.com/junit-team/junit/pull/955","diff_url":"https://github.com/junit-team/junit/pull/955.diff","patch_url":"https://github.com/junit-team/junit/pull/955.patch","issue_url":"https://api.github.com/repos/junit-team/junit/issues/955","number":955,"state":"open","title":"Add null-checking to DescriptionBuilder","user":{"login":"AlexYursha","id":4990557,"avatar_url":"https://avatars.githubusercontent.com/u/4990557?","gravatar_id":"a5f4f3aa0ad5c123cdbf8349dda45279","url":"https://api.github.com/users/AlexYursha","html_url":"https://github.com/AlexYursha","followers_url":"https://api.github.com/users/AlexYursha/followers","following_url":"https://api.github.com/users/AlexYursha/following{/other_user}","gists_url":"https://api.github.com/users/AlexYursha/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexYursha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexYursha/subscriptions","organizations_url":"https://api.github.com/users/AlexYursha/orgs","repos_url":"https://api.github.com/users/AlexYursha/repos","events_url":"https://api.github.com/users/AlexYursha/events{/privacy}","received_events_url":"https://api.github.com/users/AlexYursha/received_events","type":"User","site_admin":false},"body":"Originated from #954","created_at":"2014-07-13T15:24:08Z","updated_at":"2014-07-13T23:53:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"479984be909d8949f7e29dc176010f9924648ae9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit/pulls/955/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit/pulls/955/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/junit-team/junit/issues/955/comments","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/e7ebb5be274f644ffa57309e07bbefd0dbc20dfb","head":{"label":"AlexYursha:add-null-checking-to-description-builder","ref":"add-null-checking-to-description-builder","sha":"e7ebb5be274f644ffa57309e07bbefd0dbc20dfb","user":{"login":"AlexYursha","id":4990557,"avatar_url":"https://avatars.githubusercontent.com/u/4990557?","gravatar_id":"a5f4f3aa0ad5c123cdbf8349dda45279","url":"https://api.github.com/users/AlexYursha","html_url":"https://github.com/AlexYursha","followers_url":"https://api.github.com/users/AlexYursha/followers","following_url":"https://api.github.com/users/AlexYursha/following{/other_user}","gists_url":"https://api.github.com/users/AlexYursha/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexYursha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexYursha/subscriptions","organizations_url":"https://api.github.com/users/AlexYursha/orgs","repos_url":"https://api.github.com/users/AlexYursha/repos","events_url":"https://api.github.com/users/AlexYursha/events{/privacy}","received_events_url":"https://api.github.com/users/AlexYursha/received_events","type":"User","site_admin":false},"repo":{"id":20186675,"name":"junit","full_name":"AlexYursha/junit","owner":{"login":"AlexYursha","id":4990557,"avatar_url":"https://avatars.githubusercontent.com/u/4990557?","gravatar_id":"a5f4f3aa0ad5c123cdbf8349dda45279","url":"https://api.github.com/users/AlexYursha","html_url":"https://github.com/AlexYursha","followers_url":"https://api.github.com/users/AlexYursha/followers","following_url":"https://api.github.com/users/AlexYursha/following{/other_user}","gists_url":"https://api.github.com/users/AlexYursha/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexYursha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexYursha/subscriptions","organizations_url":"https://api.github.com/users/AlexYursha/orgs","repos_url":"https://api.github.com/users/AlexYursha/repos","events_url":"https://api.github.com/users/AlexYursha/events{/privacy}","received_events_url":"https://api.github.com/users/AlexYursha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexYursha/junit","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/AlexYursha/junit","forks_url":"https://api.github.com/repos/AlexYursha/junit/forks","keys_url":"https://api.github.com/repos/AlexYursha/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexYursha/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexYursha/junit/teams","hooks_url":"https://api.github.com/repos/AlexYursha/junit/hooks","issue_events_url":"https://api.github.com/repos/AlexYursha/junit/issues/events{/number}","events_url":"https://api.github.com/repos/AlexYursha/junit/events","assignees_url":"https://api.github.com/repos/AlexYursha/junit/assignees{/user}","branches_url":"https://api.github.com/repos/AlexYursha/junit/branches{/branch}","tags_url":"https://api.github.com/repos/AlexYursha/junit/tags","blobs_url":"https://api.github.com/repos/AlexYursha/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexYursha/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexYursha/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexYursha/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexYursha/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexYursha/junit/languages","stargazers_url":"https://api.github.com/repos/AlexYursha/junit/stargazers","contributors_url":"https://api.github.com/repos/AlexYursha/junit/contributors","subscribers_url":"https://api.github.com/repos/AlexYursha/junit/subscribers","subscription_url":"https://api.github.com/repos/AlexYursha/junit/subscription","commits_url":"https://api.github.com/repos/AlexYursha/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexYursha/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexYursha/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexYursha/junit/issues/comments/{number}","contents_url":"https://api.github.com/repos/AlexYursha/junit/contents/{+path}","compare_url":"https://api.github.com/repos/AlexYursha/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexYursha/junit/merges","archive_url":"https://api.github.com/repos/AlexYursha/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexYursha/junit/downloads","issues_url":"https://api.github.com/repos/AlexYursha/junit/issues{/number}","pulls_url":"https://api.github.com/repos/AlexYursha/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexYursha/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexYursha/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexYursha/junit/labels{/name}","releases_url":"https://api.github.com/repos/AlexYursha/junit/releases{/id}","created_at":"2014-05-26T13:19:58Z","updated_at":"2014-07-13T10:44:36Z","pushed_at":"2014-07-13T17:28:51Z","git_url":"git://github.com/AlexYursha/junit.git","ssh_url":"git@github.com:AlexYursha/junit.git","clone_url":"https://github.com/AlexYursha/junit.git","svn_url":"https://github.com/AlexYursha/junit","homepage":"","size":8718,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:immutable-description","ref":"immutable-description","sha":"a1e618eb06a2ff9b1da56fd976804462aa1bbcfb","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?","gravatar_id":"075328bf957813f5bdb0756dd026f8d7","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit","full_name":"junit-team/junit","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?","gravatar_id":"075328bf957813f5bdb0756dd026f8d7","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit","forks_url":"https://api.github.com/repos/junit-team/junit/forks","keys_url":"https://api.github.com/repos/junit-team/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit/teams","hooks_url":"https://api.github.com/repos/junit-team/junit/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit/events","assignees_url":"https://api.github.com/repos/junit-team/junit/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit/tags","blobs_url":"https://api.github.com/repos/junit-team/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit/subscription","commits_url":"https://api.github.com/repos/junit-team/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit/issues/comments/{number}","contents_url":"https://api.github.com/repos/junit-team/junit/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit/merges","archive_url":"https://api.github.com/repos/junit-team/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit/downloads","issues_url":"https://api.github.com/repos/junit-team/junit/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit/releases{/id}","created_at":"2009-01-13T03:41:26Z","updated_at":"2014-07-13T02:55:15Z","pushed_at":"2014-07-02T17:56:16Z","git_url":"git://github.com/junit-team/junit.git","ssh_url":"git@github.com:junit-team/junit.git","clone_url":"https://github.com/junit-team/junit.git","svn_url":"https://github.com/junit-team/junit","homepage":"","size":26710,"stargazers_count":2720,"watchers_count":2720,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":991,"mirror_url":null,"open_issues_count":146,"forks":991,"open_issues":146,"watchers":2720,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/955"},"html":{"href":"https://github.com/junit-team/junit/pull/955"},"issue":{"href":"https://api.github.com/repos/junit-team/junit/issues/955"},"comments":{"href":"https://api.github.com/repos/junit-team/junit/issues/955/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit/pulls/955/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit/pulls/955/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit/statuses/e7ebb5be274f644ffa57309e07bbefd0dbc20dfb"}}}}