GitHub PullRequestReviewCommentEvent at 2014-11-07 22:35:10
Repository: Markus
Actor: david-yz-liu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/20042288","id":20042288,"diff_hunk":"@@ -0,0 +1,56 @@\n+<div class='section'>\n+  <% if @assignments.empty? %>\n+    <p><%= t(:no_assignments) %></p>\n+  <% else %>\n+    <div class=\"table\">\n+      <table>\n+        <thead>\n+        <tr>\n+          <th><%= t(:name) %></th>\n+          <th><%= t(:due) %></th>\n+        </tr>\n+        </thead>\n+        <tbody>\n+        <% @assignments.each do |assignment| -%>\n+          <tr>\n+            <td>\n+              <% if assignment.is_hidden %>\n+                <%= link_to truncate('assignment.hidden',\n+                                     assignment_text:\n+                                       \"#{h(assignment.short_identifier)}: #{h(assignment.description)}\" ),\n+                            view_summary_main_index_path(assignment_id: assignment.id),\n+                            remote: true %>\n+              <% else %>\n+                <%= link_to assignment.short_identifier + ': ' + assignment.description,\n+                            view_summary_assignment_path(assignment.id),\n+                            remote: true %>\n+              <% end %>\n+            </td>\n+\n+            <td>\n+              <%= l(assignment.due_date, format: :short_date ) %>\n+            </td>\n+\n+\n+          </tr>\n+        <% end %>\n+        </tbody>\n+      </table>\n+    </div>\n+  <% end %>\n+</div>\n+\n+<script>","path":"app/views/main/_dashboard_list.html.erb","position":43,"original_position":43,"commit_id":"bc5bf7f319488e2a7d3372f5ab48664f5975e648","original_commit_id":"bc5bf7f319488e2a7d3372f5ab48664f5975e648","user":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars.githubusercontent.com/u/3333115?v=3","gravatar_id":"","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"body":"@ifung I will double-check with @reidka, but I think you should remove this script.","created_at":"2014-11-07T22:35:10Z","updated_at":"2014-11-07T22:35:10Z","html_url":"https://github.com/MarkUsProject/Markus/pull/1857#discussion_r20042288","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1857","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/20042288"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1857#discussion_r20042288"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1857"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1857","id":23510908,"html_url":"https://github.com/MarkUsProject/Markus/pull/1857","diff_url":"https://github.com/MarkUsProject/Markus/pull/1857.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/1857.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1857","number":1857,"state":"open","locked":false,"title":"Split view on dashboard","user":{"login":"ifung","id":6497466,"avatar_url":"https://avatars.githubusercontent.com/u/6497466?v=3","gravatar_id":"","url":"https://api.github.com/users/ifung","html_url":"https://github.com/ifung","followers_url":"https://api.github.com/users/ifung/followers","following_url":"https://api.github.com/users/ifung/following{/other_user}","gists_url":"https://api.github.com/users/ifung/gists{/gist_id}","starred_url":"https://api.github.com/users/ifung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifung/subscriptions","organizations_url":"https://api.github.com/users/ifung/orgs","repos_url":"https://api.github.com/users/ifung/repos","events_url":"https://api.github.com/users/ifung/events{/privacy}","received_events_url":"https://api.github.com/users/ifung/received_events","type":"User","site_admin":false},"body":"Dashboard has been split into two vertically with list of assignments on the left and the assignment stats on the right. Currently having issue between controller and view where it is sending a nil reference when the link is clicked.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6497466/4821847/f617d768-5f35-11e4-95d9-d9094e943ca2.png)\r\n","created_at":"2014-10-29T06:37:57Z","updated_at":"2014-11-07T22:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5798a44226c4c77472a712e9997222866e5d132","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1857/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1857/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1857/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/bc5bf7f319488e2a7d3372f5ab48664f5975e648","head":{"label":"ifung:dashboard","ref":"dashboard","sha":"bc5bf7f319488e2a7d3372f5ab48664f5975e648","user":{"login":"ifung","id":6497466,"avatar_url":"https://avatars.githubusercontent.com/u/6497466?v=3","gravatar_id":"","url":"https://api.github.com/users/ifung","html_url":"https://github.com/ifung","followers_url":"https://api.github.com/users/ifung/followers","following_url":"https://api.github.com/users/ifung/following{/other_user}","gists_url":"https://api.github.com/users/ifung/gists{/gist_id}","starred_url":"https://api.github.com/users/ifung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifung/subscriptions","organizations_url":"https://api.github.com/users/ifung/orgs","repos_url":"https://api.github.com/users/ifung/repos","events_url":"https://api.github.com/users/ifung/events{/privacy}","received_events_url":"https://api.github.com/users/ifung/received_events","type":"User","site_admin":false},"repo":{"id":24016004,"name":"Markus","full_name":"ifung/Markus","owner":{"login":"ifung","id":6497466,"avatar_url":"https://avatars.githubusercontent.com/u/6497466?v=3","gravatar_id":"","url":"https://api.github.com/users/ifung","html_url":"https://github.com/ifung","followers_url":"https://api.github.com/users/ifung/followers","following_url":"https://api.github.com/users/ifung/following{/other_user}","gists_url":"https://api.github.com/users/ifung/gists{/gist_id}","starred_url":"https://api.github.com/users/ifung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifung/subscriptions","organizations_url":"https://api.github.com/users/ifung/orgs","repos_url":"https://api.github.com/users/ifung/repos","events_url":"https://api.github.com/users/ifung/events{/privacy}","received_events_url":"https://api.github.com/users/ifung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifung/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/ifung/Markus","forks_url":"https://api.github.com/repos/ifung/Markus/forks","keys_url":"https://api.github.com/repos/ifung/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifung/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifung/Markus/teams","hooks_url":"https://api.github.com/repos/ifung/Markus/hooks","issue_events_url":"https://api.github.com/repos/ifung/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/ifung/Markus/events","assignees_url":"https://api.github.com/repos/ifung/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/ifung/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/ifung/Markus/tags","blobs_url":"https://api.github.com/repos/ifung/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifung/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifung/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifung/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifung/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/ifung/Markus/languages","stargazers_url":"https://api.github.com/repos/ifung/Markus/stargazers","contributors_url":"https://api.github.com/repos/ifung/Markus/contributors","subscribers_url":"https://api.github.com/repos/ifung/Markus/subscribers","subscription_url":"https://api.github.com/repos/ifung/Markus/subscription","commits_url":"https://api.github.com/repos/ifung/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifung/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifung/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifung/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/ifung/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/ifung/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifung/Markus/merges","archive_url":"https://api.github.com/repos/ifung/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifung/Markus/downloads","issues_url":"https://api.github.com/repos/ifung/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/ifung/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/ifung/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/ifung/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifung/Markus/labels{/name}","releases_url":"https://api.github.com/repos/ifung/Markus/releases{/id}","created_at":"2014-09-14T07:22:55Z","updated_at":"2014-09-20T13:53:06Z","pushed_at":"2014-11-07T06:12:34Z","git_url":"git://github.com/ifung/Markus.git","ssh_url":"git@github.com:ifung/Markus.git","clone_url":"https://github.com/ifung/Markus.git","svn_url":"https://github.com/ifung/Markus","homepage":"http://www.markusproject.org","size":17193,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:dashboard","ref":"dashboard","sha":"0dc24771891951668df746a53e2c12f5c8114e6a","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","created_at":"2010-09-26T16:18:08Z","updated_at":"2014-11-04T11:44:51Z","pushed_at":"2014-11-07T22:25:35Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":49815,"stargazers_count":115,"watchers_count":115,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":120,"forks":134,"open_issues":120,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1857"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1857"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1857"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1857/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1857/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1857/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/bc5bf7f319488e2a7d3372f5ab48664f5975e648"}}}}