GitHub PullRequestReviewCommentEvent at 2014-06-30 17:22:01
Repository: dmd
Actor: WalterBright
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/14362502","id":14362502,"diff_hunk":"@@ -263,17 +268,56 @@ void deprecation(Loc loc, const char *format, ...)\n     va_end( ap );\n }\n \n+#if _WIN32\n+static CONSOLE_SCREEN_BUFFER_INFO sbi;\n+static const BOOL sbi_inited = GetConsoleScreenBufferInfo(GetStdHandle(STD_ERROR_HANDLE), &sbi);\n+#endif\n+\n+static void setConsoleColorBright()\n+{\n+#if _WIN32\n+    SetConsoleTextAttribute(GetStdHandle(STD_ERROR_HANDLE), sbi.wAttributes | FOREGROUND_INTENSITY);\n+#else\n+    fprintf(stderr, \"\\033[1m\");\n+#endif\n+}\n+\n+static void setConsoleColorBrightRed()","path":"src/mars.c","position":30,"original_position":30,"commit_id":"3ec1b26c32e8f9f47a24bedc4e7c380af987c01b","original_commit_id":"3ec1b26c32e8f9f47a24bedc4e7c380af987c01b","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars.githubusercontent.com/u/568298?","gravatar_id":"06f169620099a320c6d3d27aa78b6dfc","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"body":"By encoding `Red` into the name, it introduces an unnecessary requirement that if `Blue` looks better, the caller would have to be changed. Better to name it `Error` to indicate the color for an error.","created_at":"2014-06-30T17:22:01Z","updated_at":"2014-06-30T17:22:01Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/3705#discussion_r14362502","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3705","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/14362502"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/3705#discussion_r14362502"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3705"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3705","id":17758155,"html_url":"https://github.com/D-Programming-Language/dmd/pull/3705","diff_url":"https://github.com/D-Programming-Language/dmd/pull/3705.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/3705.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/3705","number":3705,"state":"open","title":"Added -color","user":{"login":"lionello","id":591860,"avatar_url":"https://avatars.githubusercontent.com/u/591860?","gravatar_id":"656b036babb249eba85891e5206ac2f4","url":"https://api.github.com/users/lionello","html_url":"https://github.com/lionello","followers_url":"https://api.github.com/users/lionello/followers","following_url":"https://api.github.com/users/lionello/following{/other_user}","gists_url":"https://api.github.com/users/lionello/gists{/gist_id}","starred_url":"https://api.github.com/users/lionello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionello/subscriptions","organizations_url":"https://api.github.com/users/lionello/orgs","repos_url":"https://api.github.com/users/lionello/repos","events_url":"https://api.github.com/users/lionello/events{/privacy}","received_events_url":"https://api.github.com/users/lionello/received_events","type":"User","site_admin":false},"body":"https://issues.dlang.org/show_bug.cgi?id=12273","created_at":"2014-06-30T06:51:42Z","updated_at":"2014-06-30T17:22:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"958491fdc1cad300543b04f6b9525c05568887e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3705/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3705/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/3705/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/3ec1b26c32e8f9f47a24bedc4e7c380af987c01b","head":{"label":"lionello:color","ref":"color","sha":"3ec1b26c32e8f9f47a24bedc4e7c380af987c01b","user":{"login":"lionello","id":591860,"avatar_url":"https://avatars.githubusercontent.com/u/591860?","gravatar_id":"656b036babb249eba85891e5206ac2f4","url":"https://api.github.com/users/lionello","html_url":"https://github.com/lionello","followers_url":"https://api.github.com/users/lionello/followers","following_url":"https://api.github.com/users/lionello/following{/other_user}","gists_url":"https://api.github.com/users/lionello/gists{/gist_id}","starred_url":"https://api.github.com/users/lionello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionello/subscriptions","organizations_url":"https://api.github.com/users/lionello/orgs","repos_url":"https://api.github.com/users/lionello/repos","events_url":"https://api.github.com/users/lionello/events{/privacy}","received_events_url":"https://api.github.com/users/lionello/received_events","type":"User","site_admin":false},"repo":{"id":8106264,"name":"dmd","full_name":"lionello/dmd","owner":{"login":"lionello","id":591860,"avatar_url":"https://avatars.githubusercontent.com/u/591860?","gravatar_id":"656b036babb249eba85891e5206ac2f4","url":"https://api.github.com/users/lionello","html_url":"https://github.com/lionello","followers_url":"https://api.github.com/users/lionello/followers","following_url":"https://api.github.com/users/lionello/following{/other_user}","gists_url":"https://api.github.com/users/lionello/gists{/gist_id}","starred_url":"https://api.github.com/users/lionello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionello/subscriptions","organizations_url":"https://api.github.com/users/lionello/orgs","repos_url":"https://api.github.com/users/lionello/repos","events_url":"https://api.github.com/users/lionello/events{/privacy}","received_events_url":"https://api.github.com/users/lionello/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lionello/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/lionello/dmd","forks_url":"https://api.github.com/repos/lionello/dmd/forks","keys_url":"https://api.github.com/repos/lionello/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lionello/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lionello/dmd/teams","hooks_url":"https://api.github.com/repos/lionello/dmd/hooks","issue_events_url":"https://api.github.com/repos/lionello/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/lionello/dmd/events","assignees_url":"https://api.github.com/repos/lionello/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/lionello/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/lionello/dmd/tags","blobs_url":"https://api.github.com/repos/lionello/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lionello/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lionello/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lionello/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lionello/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/lionello/dmd/languages","stargazers_url":"https://api.github.com/repos/lionello/dmd/stargazers","contributors_url":"https://api.github.com/repos/lionello/dmd/contributors","subscribers_url":"https://api.github.com/repos/lionello/dmd/subscribers","subscription_url":"https://api.github.com/repos/lionello/dmd/subscription","commits_url":"https://api.github.com/repos/lionello/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lionello/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lionello/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lionello/dmd/issues/comments/{number}","contents_url":"https://api.github.com/repos/lionello/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/lionello/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lionello/dmd/merges","archive_url":"https://api.github.com/repos/lionello/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lionello/dmd/downloads","issues_url":"https://api.github.com/repos/lionello/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/lionello/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/lionello/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/lionello/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lionello/dmd/labels{/name}","releases_url":"https://api.github.com/repos/lionello/dmd/releases{/id}","created_at":"2013-02-09T04:54:18Z","updated_at":"2014-06-30T11:09:52Z","pushed_at":"2014-06-30T11:09:51Z","git_url":"git://github.com/lionello/dmd.git","ssh_url":"git@github.com:lionello/dmd.git","clone_url":"https://github.com/lionello/dmd.git","svn_url":"https://github.com/lionello/dmd","homepage":"d-programming-language.org","size":36316,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"59f088f2c52c9aa5bf67e9581450a984b27cb876","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","created_at":"2011-01-15T06:53:53Z","updated_at":"2014-06-25T20:53:49Z","pushed_at":"2014-06-29T20:43:26Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":72616,"stargazers_count":754,"watchers_count":754,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":236,"mirror_url":null,"open_issues_count":87,"forks":236,"open_issues":87,"watchers":754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3705"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/3705"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/3705"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/3705/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3705/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3705/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/3ec1b26c32e8f9f47a24bedc4e7c380af987c01b"}}}}