GitHub PullRequestEvent at 2014-09-03 11:26:26
Repository: rails
Actor: matthewd
Payload: {"action":"closed","number":16785,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/16785","id":20660548,"html_url":"https://github.com/rails/rails/pull/16785","diff_url":"https://github.com/rails/rails/pull/16785.diff","patch_url":"https://github.com/rails/rails/pull/16785.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/16785","number":16785,"state":"closed","locked":false,"title":"Fix for double ActiveJob::DeserializationErorr","user":{"login":"cristianbica","id":150381,"avatar_url":"https://avatars.githubusercontent.com/u/150381?v=2","gravatar_id":"94464371b17302eadec74810ec480aaf","url":"https://api.github.com/users/cristianbica","html_url":"https://github.com/cristianbica","followers_url":"https://api.github.com/users/cristianbica/followers","following_url":"https://api.github.com/users/cristianbica/following{/other_user}","gists_url":"https://api.github.com/users/cristianbica/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianbica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianbica/subscriptions","organizations_url":"https://api.github.com/users/cristianbica/orgs","repos_url":"https://api.github.com/users/cristianbica/repos","events_url":"https://api.github.com/users/cristianbica/events{/privacy}","received_events_url":"https://api.github.com/users/cristianbica/received_events","type":"User","site_admin":false},"body":"If an argument that cannot be serialized is not in the first level of arguments (it's in an array or hash) the error is double wrapped inside DeserializationError. Example:\r\n\r\n```ruby\r\n# enqueueing the Person object from the AJ testing wrapped in an array\r\nRescueJob.enqueue [Person.new(404)]\r\n# will raise \r\n\r\n> puts e.inspect\r\n#<ActiveJob::DeserializationError: Error while trying to deserialize arguments: Error while trying to deserialize arguments: Cannot find person with ID=404>\r\n\r\n> puts e.class.name\r\nActiveJob::DeserializationError\r\n\r\n> puts e.original_exception.class.name\r\nActiveJob::DeserializationError\r\n\r\n> puts e.original_exception.original_exception.class.name\r\nPerson::RecordNotFound\r\n```\r\n","created_at":"2014-09-03T07:50:10Z","updated_at":"2014-09-03T11:26:25Z","closed_at":"2014-09-03T11:26:25Z","merged_at":"2014-09-03T11:26:25Z","merge_commit_sha":"dd603748e76a903451abaf9ce85eab79ea694d45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/16785/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/16785/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/16785/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/56f992fe150f9fc2396e31fe7391b4cf018f55dc","head":{"label":"cristianbica:fix-double-aj-deserialization-error","ref":"fix-double-aj-deserialization-error","sha":"56f992fe150f9fc2396e31fe7391b4cf018f55dc","user":{"login":"cristianbica","id":150381,"avatar_url":"https://avatars.githubusercontent.com/u/150381?v=2","gravatar_id":"94464371b17302eadec74810ec480aaf","url":"https://api.github.com/users/cristianbica","html_url":"https://github.com/cristianbica","followers_url":"https://api.github.com/users/cristianbica/followers","following_url":"https://api.github.com/users/cristianbica/following{/other_user}","gists_url":"https://api.github.com/users/cristianbica/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianbica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianbica/subscriptions","organizations_url":"https://api.github.com/users/cristianbica/orgs","repos_url":"https://api.github.com/users/cristianbica/repos","events_url":"https://api.github.com/users/cristianbica/events{/privacy}","received_events_url":"https://api.github.com/users/cristianbica/received_events","type":"User","site_admin":false},"repo":{"id":22871082,"name":"rails","full_name":"cristianbica/rails","owner":{"login":"cristianbica","id":150381,"avatar_url":"https://avatars.githubusercontent.com/u/150381?v=2","gravatar_id":"94464371b17302eadec74810ec480aaf","url":"https://api.github.com/users/cristianbica","html_url":"https://github.com/cristianbica","followers_url":"https://api.github.com/users/cristianbica/followers","following_url":"https://api.github.com/users/cristianbica/following{/other_user}","gists_url":"https://api.github.com/users/cristianbica/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianbica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianbica/subscriptions","organizations_url":"https://api.github.com/users/cristianbica/orgs","repos_url":"https://api.github.com/users/cristianbica/repos","events_url":"https://api.github.com/users/cristianbica/events{/privacy}","received_events_url":"https://api.github.com/users/cristianbica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cristianbica/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/cristianbica/rails","forks_url":"https://api.github.com/repos/cristianbica/rails/forks","keys_url":"https://api.github.com/repos/cristianbica/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristianbica/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristianbica/rails/teams","hooks_url":"https://api.github.com/repos/cristianbica/rails/hooks","issue_events_url":"https://api.github.com/repos/cristianbica/rails/issues/events{/number}","events_url":"https://api.github.com/repos/cristianbica/rails/events","assignees_url":"https://api.github.com/repos/cristianbica/rails/assignees{/user}","branches_url":"https://api.github.com/repos/cristianbica/rails/branches{/branch}","tags_url":"https://api.github.com/repos/cristianbica/rails/tags","blobs_url":"https://api.github.com/repos/cristianbica/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristianbica/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristianbica/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristianbica/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristianbica/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/cristianbica/rails/languages","stargazers_url":"https://api.github.com/repos/cristianbica/rails/stargazers","contributors_url":"https://api.github.com/repos/cristianbica/rails/contributors","subscribers_url":"https://api.github.com/repos/cristianbica/rails/subscribers","subscription_url":"https://api.github.com/repos/cristianbica/rails/subscription","commits_url":"https://api.github.com/repos/cristianbica/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristianbica/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristianbica/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristianbica/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/cristianbica/rails/contents/{+path}","compare_url":"https://api.github.com/repos/cristianbica/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristianbica/rails/merges","archive_url":"https://api.github.com/repos/cristianbica/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristianbica/rails/downloads","issues_url":"https://api.github.com/repos/cristianbica/rails/issues{/number}","pulls_url":"https://api.github.com/repos/cristianbica/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/cristianbica/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/cristianbica/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristianbica/rails/labels{/name}","releases_url":"https://api.github.com/repos/cristianbica/rails/releases{/id}","created_at":"2014-08-12T08:56:58Z","updated_at":"2014-08-18T19:45:09Z","pushed_at":"2014-09-03T11:24:13Z","git_url":"git://github.com/cristianbica/rails.git","ssh_url":"git@github.com:cristianbica/rails.git","clone_url":"https://github.com/cristianbica/rails.git","svn_url":"https://github.com/cristianbica/rails","homepage":"http://rubyonrails.org","size":119329,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"a4de217ce586740284238d907153750c0ce3e263","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=2","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=2","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2014-09-03T08:39:11Z","pushed_at":"2014-09-03T11:26:25Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":376370,"stargazers_count":23085,"watchers_count":23085,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":8712,"mirror_url":null,"open_issues_count":680,"forks":8712,"open_issues":680,"watchers":23085,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/16785"},"html":{"href":"https://github.com/rails/rails/pull/16785"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/16785"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/16785/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/16785/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/16785/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/56f992fe150f9fc2396e31fe7391b4cf018f55dc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=2","gravatar_id":"e55df1cc7d5fdb4ae9bc2afcb9afe7e4","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":10,"deletions":5,"changed_files":2}}