GitHub PullRequestReviewCommentEvent at 2014-09-05 10:25:02
Repository: machinery
Actor: aduffeck
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/comments/17165802","id":17165802,"diff_hunk":"@@ -27,7 +27,7 @@ def inspect(system, description, options = {})\n     description.remove_file_store(store_name)\n     if options[:extract_changed_managed_files]\n       description.initialize_file_store(store_name)\n-      existing_files = changed_files.reject { |f| f.changes.nil? || f.changes.include?(\"deleted\") }","path":"plugins/inspect/changed_managed_files_inspector.rb","position":4,"original_position":4,"commit_id":"45d317a5bbc4e5bf577218a29a0672480e1bb39f","original_commit_id":"45d317a5bbc4e5bf577218a29a0672480e1bb39f","user":{"login":"aduffeck","id":203813,"avatar_url":"https://avatars.githubusercontent.com/u/203813?v=2","gravatar_id":"557f8019ee95d1745c73900328df7bab","url":"https://api.github.com/users/aduffeck","html_url":"https://github.com/aduffeck","followers_url":"https://api.github.com/users/aduffeck/followers","following_url":"https://api.github.com/users/aduffeck/following{/other_user}","gists_url":"https://api.github.com/users/aduffeck/gists{/gist_id}","starred_url":"https://api.github.com/users/aduffeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduffeck/subscriptions","organizations_url":"https://api.github.com/users/aduffeck/orgs","repos_url":"https://api.github.com/users/aduffeck/repos","events_url":"https://api.github.com/users/aduffeck/events{/privacy}","received_events_url":"https://api.github.com/users/aduffeck/received_events","type":"User","site_admin":false},"body":"This change and the one in line 43 are also necessary because `changes` can be nil in case of errors.","created_at":"2014-09-05T10:25:02Z","updated_at":"2014-09-05T10:25:02Z","html_url":"https://github.com/SUSE/machinery/pull/179#discussion_r17165802","pull_request_url":"https://api.github.com/repos/SUSE/machinery/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments/17165802"},"html":{"href":"https://github.com/SUSE/machinery/pull/179#discussion_r17165802"},"pull_request":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/179","id":20671232,"html_url":"https://github.com/SUSE/machinery/pull/179","diff_url":"https://github.com/SUSE/machinery/pull/179.diff","patch_url":"https://github.com/SUSE/machinery/pull/179.patch","issue_url":"https://api.github.com/repos/SUSE/machinery/issues/179","number":179,"state":"open","locked":false,"title":"Remove obsoleted nil checks.","user":{"login":"greygoo","id":1080430,"avatar_url":"https://avatars.githubusercontent.com/u/1080430?v=2","gravatar_id":"c61a6321333610cd764abb387f19bd8c","url":"https://api.github.com/users/greygoo","html_url":"https://github.com/greygoo","followers_url":"https://api.github.com/users/greygoo/followers","following_url":"https://api.github.com/users/greygoo/following{/other_user}","gists_url":"https://api.github.com/users/greygoo/gists{/gist_id}","starred_url":"https://api.github.com/users/greygoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greygoo/subscriptions","organizations_url":"https://api.github.com/users/greygoo/orgs","repos_url":"https://api.github.com/users/greygoo/repos","events_url":"https://api.github.com/users/greygoo/events{/privacy}","received_events_url":"https://api.github.com/users/greygoo/received_events","type":"User","site_admin":false},"body":"Due to the json validation we can remove previously required nil checks.\n","created_at":"2014-09-03T11:45:55Z","updated_at":"2014-09-05T10:25:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c4a9df0b92dea4a3e1c746962493f0651db6cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/machinery/pulls/179/commits","review_comments_url":"https://api.github.com/repos/SUSE/machinery/pulls/179/comments","review_comment_url":"https://api.github.com/repos/SUSE/machinery/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SUSE/machinery/issues/179/comments","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/45d317a5bbc4e5bf577218a29a0672480e1bb39f","head":{"label":"SUSE:review_140903_remove_obsolete_nil_checks","ref":"review_140903_remove_obsolete_nil_checks","sha":"45d317a5bbc4e5bf577218a29a0672480e1bb39f","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=2","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=2","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2014-09-04T09:10:14Z","pushed_at":"2014-09-05T09:19:57Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":7917,"stargazers_count":32,"watchers_count":32,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":32,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"1e75b80ef9357361425d46754624c7dd63c4d737","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=2","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=2","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2014-09-04T09:10:14Z","pushed_at":"2014-09-05T09:19:57Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":7917,"stargazers_count":32,"watchers_count":32,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/179"},"html":{"href":"https://github.com/SUSE/machinery/pull/179"},"issue":{"href":"https://api.github.com/repos/SUSE/machinery/issues/179"},"comments":{"href":"https://api.github.com/repos/SUSE/machinery/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/machinery/statuses/45d317a5bbc4e5bf577218a29a0672480e1bb39f"}}}}