GitHub PullRequestEvent at 2014-12-19 20:16:28
Repository: react-router
Actor: mjackson
Payload: {"action":"closed","number":625,"pull_request":{"url":"https://api.github.com/repos/rackt/react-router/pulls/625","id":26290319,"html_url":"https://github.com/rackt/react-router/pull/625","diff_url":"https://github.com/rackt/react-router/pull/625.diff","patch_url":"https://github.com/rackt/react-router/pull/625.patch","issue_url":"https://api.github.com/repos/rackt/react-router/issues/625","number":625,"state":"closed","locked":false,"title":"Promote envify to dependencies and add browserify transform config for it","user":{"login":"insin","id":226692,"avatar_url":"https://avatars.githubusercontent.com/u/226692?v=3","gravatar_id":"","url":"https://api.github.com/users/insin","html_url":"https://github.com/insin","followers_url":"https://api.github.com/users/insin/followers","following_url":"https://api.github.com/users/insin/following{/other_user}","gists_url":"https://api.github.com/users/insin/gists{/gist_id}","starred_url":"https://api.github.com/users/insin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insin/subscriptions","organizations_url":"https://api.github.com/users/insin/orgs","repos_url":"https://api.github.com/users/insin/repos","events_url":"https://api.github.com/users/insin/events{/privacy}","received_events_url":"https://api.github.com/users/insin/received_events","type":"User","site_admin":false},"body":"`modules/utils/createRouter.js` now contains a `process.env.NODE_ENV` check, which isn't getting envified when react-router gets bundled as a dependency of an app. This change will make that happen.\r\n\r\n(You can try `--global-transform` to force envification, but it can get a bit... explodey... if not all your dependencies have envify somewhere in their dependencies)","created_at":"2014-12-18T10:29:04Z","updated_at":"2014-12-19T20:16:28Z","closed_at":"2014-12-19T20:16:28Z","merged_at":null,"merge_commit_sha":"0145c59f51e8b411e0942a88e8f17a2967d9bbeb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackt/react-router/pulls/625/commits","review_comments_url":"https://api.github.com/repos/rackt/react-router/pulls/625/comments","review_comment_url":"https://api.github.com/repos/rackt/react-router/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackt/react-router/issues/625/comments","statuses_url":"https://api.github.com/repos/rackt/react-router/statuses/6d8297767169e42949a2f70f5f59860b3559a852","head":{"label":"insin:patch-1","ref":"patch-1","sha":"6d8297767169e42949a2f70f5f59860b3559a852","user":{"login":"insin","id":226692,"avatar_url":"https://avatars.githubusercontent.com/u/226692?v=3","gravatar_id":"","url":"https://api.github.com/users/insin","html_url":"https://github.com/insin","followers_url":"https://api.github.com/users/insin/followers","following_url":"https://api.github.com/users/insin/following{/other_user}","gists_url":"https://api.github.com/users/insin/gists{/gist_id}","starred_url":"https://api.github.com/users/insin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insin/subscriptions","organizations_url":"https://api.github.com/users/insin/orgs","repos_url":"https://api.github.com/users/insin/repos","events_url":"https://api.github.com/users/insin/events{/privacy}","received_events_url":"https://api.github.com/users/insin/received_events","type":"User","site_admin":false},"repo":{"id":28178572,"name":"react-router","full_name":"insin/react-router","owner":{"login":"insin","id":226692,"avatar_url":"https://avatars.githubusercontent.com/u/226692?v=3","gravatar_id":"","url":"https://api.github.com/users/insin","html_url":"https://github.com/insin","followers_url":"https://api.github.com/users/insin/followers","following_url":"https://api.github.com/users/insin/following{/other_user}","gists_url":"https://api.github.com/users/insin/gists{/gist_id}","starred_url":"https://api.github.com/users/insin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insin/subscriptions","organizations_url":"https://api.github.com/users/insin/orgs","repos_url":"https://api.github.com/users/insin/repos","events_url":"https://api.github.com/users/insin/events{/privacy}","received_events_url":"https://api.github.com/users/insin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/insin/react-router","description":"A complete routing solution for React.js","fork":true,"url":"https://api.github.com/repos/insin/react-router","forks_url":"https://api.github.com/repos/insin/react-router/forks","keys_url":"https://api.github.com/repos/insin/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/insin/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/insin/react-router/teams","hooks_url":"https://api.github.com/repos/insin/react-router/hooks","issue_events_url":"https://api.github.com/repos/insin/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/insin/react-router/events","assignees_url":"https://api.github.com/repos/insin/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/insin/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/insin/react-router/tags","blobs_url":"https://api.github.com/repos/insin/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/insin/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/insin/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/insin/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/insin/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/insin/react-router/languages","stargazers_url":"https://api.github.com/repos/insin/react-router/stargazers","contributors_url":"https://api.github.com/repos/insin/react-router/contributors","subscribers_url":"https://api.github.com/repos/insin/react-router/subscribers","subscription_url":"https://api.github.com/repos/insin/react-router/subscription","commits_url":"https://api.github.com/repos/insin/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/insin/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/insin/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/insin/react-router/issues/comments/{number}","contents_url":"https://api.github.com/repos/insin/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/insin/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/insin/react-router/merges","archive_url":"https://api.github.com/repos/insin/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/insin/react-router/downloads","issues_url":"https://api.github.com/repos/insin/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/insin/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/insin/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/insin/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/insin/react-router/labels{/name}","releases_url":"https://api.github.com/repos/insin/react-router/releases{/id}","created_at":"2014-12-18T10:15:27Z","updated_at":"2014-12-18T10:15:27Z","pushed_at":"2014-12-18T10:28:36Z","git_url":"git://github.com/insin/react-router.git","ssh_url":"git@github.com:insin/react-router.git","clone_url":"https://github.com/insin/react-router.git","svn_url":"https://github.com/insin/react-router","homepage":"","size":2812,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackt:master","ref":"master","sha":"6996451e70e8c89e6f339e66b6164a3c948e2922","user":{"login":"rackt","id":8261421,"avatar_url":"https://avatars.githubusercontent.com/u/8261421?v=3","gravatar_id":"","url":"https://api.github.com/users/rackt","html_url":"https://github.com/rackt","followers_url":"https://api.github.com/users/rackt/followers","following_url":"https://api.github.com/users/rackt/following{/other_user}","gists_url":"https://api.github.com/users/rackt/gists{/gist_id}","starred_url":"https://api.github.com/users/rackt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackt/subscriptions","organizations_url":"https://api.github.com/users/rackt/orgs","repos_url":"https://api.github.com/users/rackt/repos","events_url":"https://api.github.com/users/rackt/events{/privacy}","received_events_url":"https://api.github.com/users/rackt/received_events","type":"Organization","site_admin":false},"repo":{"id":19872456,"name":"react-router","full_name":"rackt/react-router","owner":{"login":"rackt","id":8261421,"avatar_url":"https://avatars.githubusercontent.com/u/8261421?v=3","gravatar_id":"","url":"https://api.github.com/users/rackt","html_url":"https://github.com/rackt","followers_url":"https://api.github.com/users/rackt/followers","following_url":"https://api.github.com/users/rackt/following{/other_user}","gists_url":"https://api.github.com/users/rackt/gists{/gist_id}","starred_url":"https://api.github.com/users/rackt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackt/subscriptions","organizations_url":"https://api.github.com/users/rackt/orgs","repos_url":"https://api.github.com/users/rackt/repos","events_url":"https://api.github.com/users/rackt/events{/privacy}","received_events_url":"https://api.github.com/users/rackt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackt/react-router","description":"A complete routing solution for React.js","fork":false,"url":"https://api.github.com/repos/rackt/react-router","forks_url":"https://api.github.com/repos/rackt/react-router/forks","keys_url":"https://api.github.com/repos/rackt/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackt/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackt/react-router/teams","hooks_url":"https://api.github.com/repos/rackt/react-router/hooks","issue_events_url":"https://api.github.com/repos/rackt/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/rackt/react-router/events","assignees_url":"https://api.github.com/repos/rackt/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/rackt/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/rackt/react-router/tags","blobs_url":"https://api.github.com/repos/rackt/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackt/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackt/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackt/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackt/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/rackt/react-router/languages","stargazers_url":"https://api.github.com/repos/rackt/react-router/stargazers","contributors_url":"https://api.github.com/repos/rackt/react-router/contributors","subscribers_url":"https://api.github.com/repos/rackt/react-router/subscribers","subscription_url":"https://api.github.com/repos/rackt/react-router/subscription","commits_url":"https://api.github.com/repos/rackt/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackt/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackt/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackt/react-router/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackt/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/rackt/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackt/react-router/merges","archive_url":"https://api.github.com/repos/rackt/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackt/react-router/downloads","issues_url":"https://api.github.com/repos/rackt/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/rackt/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/rackt/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/rackt/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackt/react-router/labels{/name}","releases_url":"https://api.github.com/repos/rackt/react-router/releases{/id}","created_at":"2014-05-16T22:22:51Z","updated_at":"2014-12-19T20:16:28Z","pushed_at":"2014-12-19T20:16:27Z","git_url":"git://github.com/rackt/react-router.git","ssh_url":"git@github.com:rackt/react-router.git","clone_url":"https://github.com/rackt/react-router.git","svn_url":"https://github.com/rackt/react-router","homepage":"","size":6604,"stargazers_count":1691,"watchers_count":1691,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":204,"mirror_url":null,"open_issues_count":57,"forks":204,"open_issues":57,"watchers":1691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackt/react-router/pulls/625"},"html":{"href":"https://github.com/rackt/react-router/pull/625"},"issue":{"href":"https://api.github.com/repos/rackt/react-router/issues/625"},"comments":{"href":"https://api.github.com/repos/rackt/react-router/issues/625/comments"},"review_comments":{"href":"https://api.github.com/repos/rackt/react-router/pulls/625/comments"},"review_comment":{"href":"https://api.github.com/repos/rackt/react-router/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackt/react-router/pulls/625/commits"},"statuses":{"href":"https://api.github.com/repos/rackt/react-router/statuses/6d8297767169e42949a2f70f5f59860b3559a852"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}