GitHub PullRequestReviewCommentEvent at 2014-11-11 09:55:32
Repository: fels_20
Actor: chuanhtuan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/fels_20/pulls/comments/20140697","id":20140697,"diff_hunk":"@@ -8,9 +11,33 @@ class User < ActiveRecord::Base\n   validates_presence_of :username, :email\n   validates_uniqueness_of :username, :email\n   validates_format_of :email, with: /[^@\\s]+@[\\w\\-_\\.]+\\.\\w{2,4}/i\n+  validates_length_of :password, minimum: 6, unless: :password_not_require\n   \n   has_secure_password\n   \n+  def self.digest(string)\n+    BCrypt::Password.create string\n+  end\n+\n+  def self.new_token\n+    SecureRandom.urlsafe_base64\n+  end\n+\n+  def remember\n+    self.remember_token = User.new_token\n+    self.password_not_require = true\n+    update_attributes! remember_digest: User.digest(remember_token)","path":"app/models/user.rb","position":27,"original_position":27,"commit_id":"6aaf49e3f0c37153aef74c0e95d8834cd1fcbf1d","original_commit_id":"6aaf49e3f0c37153aef74c0e95d8834cd1fcbf1d","user":{"login":"chuanhtuan","id":5590771,"avatar_url":"https://avatars.githubusercontent.com/u/5590771?v=3","gravatar_id":"","url":"https://api.github.com/users/chuanhtuan","html_url":"https://github.com/chuanhtuan","followers_url":"https://api.github.com/users/chuanhtuan/followers","following_url":"https://api.github.com/users/chuanhtuan/following{/other_user}","gists_url":"https://api.github.com/users/chuanhtuan/gists{/gist_id}","starred_url":"https://api.github.com/users/chuanhtuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuanhtuan/subscriptions","organizations_url":"https://api.github.com/users/chuanhtuan/orgs","repos_url":"https://api.github.com/users/chuanhtuan/repos","events_url":"https://api.github.com/users/chuanhtuan/events{/privacy}","received_events_url":"https://api.github.com/users/chuanhtuan/received_events","type":"User","site_admin":false},"body":"please set false after update\r\nself.password_not_require = false","created_at":"2014-11-11T09:55:32Z","updated_at":"2014-11-11T09:55:32Z","html_url":"https://github.com/framgia/fels_20/pull/4#discussion_r20140697","pull_request_url":"https://api.github.com/repos/framgia/fels_20/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/framgia/fels_20/pulls/comments/20140697"},"html":{"href":"https://github.com/framgia/fels_20/pull/4#discussion_r20140697"},"pull_request":{"href":"https://api.github.com/repos/framgia/fels_20/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/fels_20/pulls/4","id":24130220,"html_url":"https://github.com/framgia/fels_20/pull/4","diff_url":"https://github.com/framgia/fels_20/pull/4.diff","patch_url":"https://github.com/framgia/fels_20/pull/4.patch","issue_url":"https://api.github.com/repos/framgia/fels_20/issues/4","number":4,"state":"open","locked":false,"title":"add remember me to sign_in sign_out","user":{"login":"PrinceNorin","id":6435511,"avatar_url":"https://avatars.githubusercontent.com/u/6435511?v=3","gravatar_id":"","url":"https://api.github.com/users/PrinceNorin","html_url":"https://github.com/PrinceNorin","followers_url":"https://api.github.com/users/PrinceNorin/followers","following_url":"https://api.github.com/users/PrinceNorin/following{/other_user}","gists_url":"https://api.github.com/users/PrinceNorin/gists{/gist_id}","starred_url":"https://api.github.com/users/PrinceNorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrinceNorin/subscriptions","organizations_url":"https://api.github.com/users/PrinceNorin/orgs","repos_url":"https://api.github.com/users/PrinceNorin/repos","events_url":"https://api.github.com/users/PrinceNorin/events{/privacy}","received_events_url":"https://api.github.com/users/PrinceNorin/received_events","type":"User","site_admin":false},"body":"I've added the new requirement just like you ask please review.\r\nMake validation pass with update_attributes! in signin and signout","created_at":"2014-11-10T07:16:01Z","updated_at":"2014-11-11T09:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b940bb4c3255064282344e2198254783d26de62e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/framgia/fels_20/pulls/4/commits","review_comments_url":"https://api.github.com/repos/framgia/fels_20/pulls/4/comments","review_comment_url":"https://api.github.com/repos/framgia/fels_20/pulls/comments/{number}","comments_url":"https://api.github.com/repos/framgia/fels_20/issues/4/comments","statuses_url":"https://api.github.com/repos/framgia/fels_20/statuses/6aaf49e3f0c37153aef74c0e95d8834cd1fcbf1d","head":{"label":"PrinceNorin:add-remember-me","ref":"add-remember-me","sha":"6aaf49e3f0c37153aef74c0e95d8834cd1fcbf1d","user":{"login":"PrinceNorin","id":6435511,"avatar_url":"https://avatars.githubusercontent.com/u/6435511?v=3","gravatar_id":"","url":"https://api.github.com/users/PrinceNorin","html_url":"https://github.com/PrinceNorin","followers_url":"https://api.github.com/users/PrinceNorin/followers","following_url":"https://api.github.com/users/PrinceNorin/following{/other_user}","gists_url":"https://api.github.com/users/PrinceNorin/gists{/gist_id}","starred_url":"https://api.github.com/users/PrinceNorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrinceNorin/subscriptions","organizations_url":"https://api.github.com/users/PrinceNorin/orgs","repos_url":"https://api.github.com/users/PrinceNorin/repos","events_url":"https://api.github.com/users/PrinceNorin/events{/privacy}","received_events_url":"https://api.github.com/users/PrinceNorin/received_events","type":"User","site_admin":false},"repo":{"id":26253688,"name":"fels_20","full_name":"PrinceNorin/fels_20","owner":{"login":"PrinceNorin","id":6435511,"avatar_url":"https://avatars.githubusercontent.com/u/6435511?v=3","gravatar_id":"","url":"https://api.github.com/users/PrinceNorin","html_url":"https://github.com/PrinceNorin","followers_url":"https://api.github.com/users/PrinceNorin/followers","following_url":"https://api.github.com/users/PrinceNorin/following{/other_user}","gists_url":"https://api.github.com/users/PrinceNorin/gists{/gist_id}","starred_url":"https://api.github.com/users/PrinceNorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrinceNorin/subscriptions","organizations_url":"https://api.github.com/users/PrinceNorin/orgs","repos_url":"https://api.github.com/users/PrinceNorin/repos","events_url":"https://api.github.com/users/PrinceNorin/events{/privacy}","received_events_url":"https://api.github.com/users/PrinceNorin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PrinceNorin/fels_20","description":"Framgia E-Learning System","fork":true,"url":"https://api.github.com/repos/PrinceNorin/fels_20","forks_url":"https://api.github.com/repos/PrinceNorin/fels_20/forks","keys_url":"https://api.github.com/repos/PrinceNorin/fels_20/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrinceNorin/fels_20/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrinceNorin/fels_20/teams","hooks_url":"https://api.github.com/repos/PrinceNorin/fels_20/hooks","issue_events_url":"https://api.github.com/repos/PrinceNorin/fels_20/issues/events{/number}","events_url":"https://api.github.com/repos/PrinceNorin/fels_20/events","assignees_url":"https://api.github.com/repos/PrinceNorin/fels_20/assignees{/user}","branches_url":"https://api.github.com/repos/PrinceNorin/fels_20/branches{/branch}","tags_url":"https://api.github.com/repos/PrinceNorin/fels_20/tags","blobs_url":"https://api.github.com/repos/PrinceNorin/fels_20/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrinceNorin/fels_20/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrinceNorin/fels_20/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrinceNorin/fels_20/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrinceNorin/fels_20/statuses/{sha}","languages_url":"https://api.github.com/repos/PrinceNorin/fels_20/languages","stargazers_url":"https://api.github.com/repos/PrinceNorin/fels_20/stargazers","contributors_url":"https://api.github.com/repos/PrinceNorin/fels_20/contributors","subscribers_url":"https://api.github.com/repos/PrinceNorin/fels_20/subscribers","subscription_url":"https://api.github.com/repos/PrinceNorin/fels_20/subscription","commits_url":"https://api.github.com/repos/PrinceNorin/fels_20/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrinceNorin/fels_20/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrinceNorin/fels_20/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrinceNorin/fels_20/issues/comments/{number}","contents_url":"https://api.github.com/repos/PrinceNorin/fels_20/contents/{+path}","compare_url":"https://api.github.com/repos/PrinceNorin/fels_20/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrinceNorin/fels_20/merges","archive_url":"https://api.github.com/repos/PrinceNorin/fels_20/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrinceNorin/fels_20/downloads","issues_url":"https://api.github.com/repos/PrinceNorin/fels_20/issues{/number}","pulls_url":"https://api.github.com/repos/PrinceNorin/fels_20/pulls{/number}","milestones_url":"https://api.github.com/repos/PrinceNorin/fels_20/milestones{/number}","notifications_url":"https://api.github.com/repos/PrinceNorin/fels_20/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrinceNorin/fels_20/labels{/name}","releases_url":"https://api.github.com/repos/PrinceNorin/fels_20/releases{/id}","created_at":"2014-11-06T04:24:21Z","updated_at":"2014-11-06T05:55:32Z","pushed_at":"2014-11-11T09:41:09Z","git_url":"git://github.com/PrinceNorin/fels_20.git","ssh_url":"git@github.com:PrinceNorin/fels_20.git","clone_url":"https://github.com/PrinceNorin/fels_20.git","svn_url":"https://github.com/PrinceNorin/fels_20","homepage":null,"size":819,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"framgia:develop","ref":"develop","sha":"218c038541e01d39858cf7f121ed57abdd6e553c","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":26148754,"name":"fels_20","full_name":"framgia/fels_20","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/fels_20","description":"Framgia E-Learning System","fork":false,"url":"https://api.github.com/repos/framgia/fels_20","forks_url":"https://api.github.com/repos/framgia/fels_20/forks","keys_url":"https://api.github.com/repos/framgia/fels_20/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/fels_20/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/fels_20/teams","hooks_url":"https://api.github.com/repos/framgia/fels_20/hooks","issue_events_url":"https://api.github.com/repos/framgia/fels_20/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/fels_20/events","assignees_url":"https://api.github.com/repos/framgia/fels_20/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/fels_20/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/fels_20/tags","blobs_url":"https://api.github.com/repos/framgia/fels_20/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/fels_20/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/fels_20/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/fels_20/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/fels_20/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/fels_20/languages","stargazers_url":"https://api.github.com/repos/framgia/fels_20/stargazers","contributors_url":"https://api.github.com/repos/framgia/fels_20/contributors","subscribers_url":"https://api.github.com/repos/framgia/fels_20/subscribers","subscription_url":"https://api.github.com/repos/framgia/fels_20/subscription","commits_url":"https://api.github.com/repos/framgia/fels_20/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/fels_20/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/fels_20/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/fels_20/issues/comments/{number}","contents_url":"https://api.github.com/repos/framgia/fels_20/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/fels_20/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/fels_20/merges","archive_url":"https://api.github.com/repos/framgia/fels_20/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/fels_20/downloads","issues_url":"https://api.github.com/repos/framgia/fels_20/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/fels_20/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/fels_20/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/fels_20/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/fels_20/labels{/name}","releases_url":"https://api.github.com/repos/framgia/fels_20/releases{/id}","created_at":"2014-11-04T02:14:04Z","updated_at":"2014-11-04T02:14:04Z","pushed_at":"2014-11-10T06:33:15Z","git_url":"git://github.com/framgia/fels_20.git","ssh_url":"git@github.com:framgia/fels_20.git","clone_url":"https://github.com/framgia/fels_20.git","svn_url":"https://github.com/framgia/fels_20","homepage":null,"size":896,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/fels_20/pulls/4"},"html":{"href":"https://github.com/framgia/fels_20/pull/4"},"issue":{"href":"https://api.github.com/repos/framgia/fels_20/issues/4"},"comments":{"href":"https://api.github.com/repos/framgia/fels_20/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/fels_20/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/fels_20/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/framgia/fels_20/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/fels_20/statuses/6aaf49e3f0c37153aef74c0e95d8834cd1fcbf1d"}}}}