GitHub PullRequestReviewCommentEvent at 2014-02-17 15:00:29
Repository: grunt-contrib-concat
Actor: mzgoddard
Payload: {"comment":{"url":"https://api.github.com/repos/gruntjs/grunt-contrib-concat/pulls/comments/9793928","id":9793928,"diff_hunk":"@@ -0,0 +1,213 @@\n+/*\n+ * grunt-contrib-concat\n+ * http://gruntjs.com/\n+ *\n+ * Copyright (c) 2013 \"Cowboy\" Ben Alman, contributors\n+ * Licensed under the MIT license.\n+ */\n+\n+'use strict';\n+\n+exports.init = function(grunt) {\n+  var exports = {};\n+\n+  // Node first party libs\n+  var path = require('path');\n+\n+  // Third party libs\n+  var chalk = require('chalk');\n+  var SourceMapConsumer = require('source-map').SourceMapConsumer;\n+  var SourceMapGenerator = require('source-map').SourceMapGenerator;\n+  var SourceNode = require('source-map').SourceNode;\n+\n+  // Return an object that is used to track sourcemap data between calls.\n+  exports.helper = function(banner, footer, files, options) {\n+    var node = new SourceNode();\n+    node.add(banner);\n+\n+    // Force sourcesContent if the source has been edited.\n+    if (options.stripBanners || options.process) {\n+      if (options.sourceMapStyle === 'link') {\n+        grunt.warn(\n+          'stripBanners or process option is enabled. ' +\n+          'Set sourceMapStyle option to \\'embed\\' or \\'inline\\'.'\n+        );\n+      }\n+\n+      // Continue on, but let the developer know that we are forcing embed.\n+      grunt.log.warn('Executing as if sourceMapStyle was set to \\'embed\\'.');\n+      options.sourceMapStyle = 'embed';","path":"tasks/lib/sourcemap.js","position":39,"original_position":39,"commit_id":"067a77bdbb0a6475128be09ece1d97acdfda1f11","original_commit_id":"067a77bdbb0a6475128be09ece1d97acdfda1f11","user":{"login":"mzgoddard","id":833298,"avatar_url":"https://gravatar.com/avatar/32e13d53c889e901202e8ec1b5b7ff28?d=https%3A%2F%2Fidenticons.github.com%2F57699c10701a9566ed20c4c86522c746.png&r=x","gravatar_id":"32e13d53c889e901202e8ec1b5b7ff28","url":"https://api.github.com/users/mzgoddard","html_url":"https://github.com/mzgoddard","followers_url":"https://api.github.com/users/mzgoddard/followers","following_url":"https://api.github.com/users/mzgoddard/following{/other_user}","gists_url":"https://api.github.com/users/mzgoddard/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgoddard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgoddard/subscriptions","organizations_url":"https://api.github.com/users/mzgoddard/orgs","repos_url":"https://api.github.com/users/mzgoddard/repos","events_url":"https://api.github.com/users/mzgoddard/events{/privacy}","received_events_url":"https://api.github.com/users/mzgoddard/received_events","type":"User","site_admin":false},"body":"That sounds fair. (2) is currently done with grunt's fail unless forced mechanic with `grunt.warn`. But the first sounds better to me if it is forced. I'll have a change up later today.","created_at":"2014-02-17T15:00:29Z","updated_at":"2014-02-17T15:00:29Z","html_url":"https://github.com/gruntjs/grunt-contrib-concat/pull/59#discussion_r9793928","pull_request_url":"https://api.github.com/repos/gruntjs/grunt-contrib-concat/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-concat/pulls/comments/9793928"},"html":{"href":"https://github.com/gruntjs/grunt-contrib-concat/pull/59#discussion_r9793928"},"pull_request":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-concat/pulls/59"}}}}