GitHub PullRequestEvent at 2014-05-02 02:06:18
Repository: concrete5-5.7.0
Actor: KorvinSzanto
Payload: {"action":"opened","number":100,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/100","id":15417001,"html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/100","diff_url":"https://github.com/concrete5/concrete5-5.7.0/pull/100.diff","patch_url":"https://github.com/concrete5/concrete5-5.7.0/pull/100.patch","issue_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/100","number":100,"state":"open","title":"Remove `Router` singleton in favor of a facade.","user":{"login":"KorvinSzanto","id":1007419,"avatar_url":"https://avatars.githubusercontent.com/u/1007419?","gravatar_id":"bddc798b4dba2b3788a3036b47d283af","url":"https://api.github.com/users/KorvinSzanto","html_url":"https://github.com/KorvinSzanto","followers_url":"https://api.github.com/users/KorvinSzanto/followers","following_url":"https://api.github.com/users/KorvinSzanto/following{/other_user}","gists_url":"https://api.github.com/users/KorvinSzanto/gists{/gist_id}","starred_url":"https://api.github.com/users/KorvinSzanto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KorvinSzanto/subscriptions","organizations_url":"https://api.github.com/users/KorvinSzanto/orgs","repos_url":"https://api.github.com/users/KorvinSzanto/repos","events_url":"https://api.github.com/users/KorvinSzanto/events{/privacy}","received_events_url":"https://api.github.com/users/KorvinSzanto/received_events","type":"User","site_admin":false},"body":"Singletons make it difficult to test / extend code, facades remove these concerns while still providing a global instance that can be replaced.\r\n\r\nOld syntax:\r\n\r\n    $router = Router::getInstance();\r\n    $router->register(...);\r\n\r\nNew syntax:\r\n\r\n    Route::register(...);","created_at":"2014-05-02T02:06:16Z","updated_at":"2014-05-02T02:06:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68df30d8d09c70cc6707bcc2f8fdde3ec1b1caa1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/100/commits","review_comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/100/comments","review_comment_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/comments/{number}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/100/comments","statuses_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/ab491d278a7c77df35683c745bc2b0f02d22f432","head":{"label":"KorvinSzanto:router_facade","ref":"router_facade","sha":"ab491d278a7c77df35683c745bc2b0f02d22f432","user":{"login":"KorvinSzanto","id":1007419,"avatar_url":"https://avatars.githubusercontent.com/u/1007419?","gravatar_id":"bddc798b4dba2b3788a3036b47d283af","url":"https://api.github.com/users/KorvinSzanto","html_url":"https://github.com/KorvinSzanto","followers_url":"https://api.github.com/users/KorvinSzanto/followers","following_url":"https://api.github.com/users/KorvinSzanto/following{/other_user}","gists_url":"https://api.github.com/users/KorvinSzanto/gists{/gist_id}","starred_url":"https://api.github.com/users/KorvinSzanto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KorvinSzanto/subscriptions","organizations_url":"https://api.github.com/users/KorvinSzanto/orgs","repos_url":"https://api.github.com/users/KorvinSzanto/repos","events_url":"https://api.github.com/users/KorvinSzanto/events{/privacy}","received_events_url":"https://api.github.com/users/KorvinSzanto/received_events","type":"User","site_admin":false},"repo":{"id":19085991,"name":"concrete5-5.7.0","full_name":"KorvinSzanto/concrete5-5.7.0","owner":{"login":"KorvinSzanto","id":1007419,"avatar_url":"https://avatars.githubusercontent.com/u/1007419?","gravatar_id":"bddc798b4dba2b3788a3036b47d283af","url":"https://api.github.com/users/KorvinSzanto","html_url":"https://github.com/KorvinSzanto","followers_url":"https://api.github.com/users/KorvinSzanto/followers","following_url":"https://api.github.com/users/KorvinSzanto/following{/other_user}","gists_url":"https://api.github.com/users/KorvinSzanto/gists{/gist_id}","starred_url":"https://api.github.com/users/KorvinSzanto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KorvinSzanto/subscriptions","organizations_url":"https://api.github.com/users/KorvinSzanto/orgs","repos_url":"https://api.github.com/users/KorvinSzanto/repos","events_url":"https://api.github.com/users/KorvinSzanto/events{/privacy}","received_events_url":"https://api.github.com/users/KorvinSzanto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KorvinSzanto/concrete5-5.7.0","description":"Official repository for concrete5 5.7 development","fork":true,"url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0","forks_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/forks","keys_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/teams","hooks_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/hooks","issue_events_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/issues/events{/number}","events_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/events","assignees_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/assignees{/user}","branches_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/branches{/branch}","tags_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/tags","blobs_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/statuses/{sha}","languages_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/languages","stargazers_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/stargazers","contributors_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/contributors","subscribers_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/subscribers","subscription_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/subscription","commits_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/issues/comments/{number}","contents_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/contents/{+path}","compare_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/merges","archive_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/downloads","issues_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/issues{/number}","pulls_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/pulls{/number}","milestones_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/milestones{/number}","notifications_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/labels{/name}","releases_url":"https://api.github.com/repos/KorvinSzanto/concrete5-5.7.0/releases{/id}","created_at":"2014-04-23T21:19:18Z","updated_at":"2014-05-02T02:06:16Z","pushed_at":"2014-05-02T02:04:43Z","git_url":"git://github.com/KorvinSzanto/concrete5-5.7.0.git","ssh_url":"git@github.com:KorvinSzanto/concrete5-5.7.0.git","clone_url":"https://github.com/KorvinSzanto/concrete5-5.7.0.git","svn_url":"https://github.com/KorvinSzanto/concrete5-5.7.0","homepage":null,"size":54130,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"concrete5:master","ref":"master","sha":"aea3148c1242788a444d6ad6019a89ecbbc55a1d","user":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?","gravatar_id":"6a1f62d974a8ad8428fb4cc431b96ee7","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"repo":{"id":19040482,"name":"concrete5-5.7.0","full_name":"concrete5/concrete5-5.7.0","owner":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?","gravatar_id":"6a1f62d974a8ad8428fb4cc431b96ee7","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concrete5/concrete5-5.7.0","description":"Official repository for concrete5 5.7 development","fork":false,"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0","forks_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/forks","keys_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/teams","hooks_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/hooks","issue_events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/events{/number}","events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/events","assignees_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/assignees{/user}","branches_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/branches{/branch}","tags_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/tags","blobs_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/{sha}","languages_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/languages","stargazers_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/stargazers","contributors_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/contributors","subscribers_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/subscribers","subscription_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/subscription","commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/comments/{number}","contents_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/contents/{+path}","compare_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/merges","archive_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/downloads","issues_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues{/number}","pulls_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls{/number}","milestones_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/milestones{/number}","notifications_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/labels{/name}","releases_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/releases{/id}","created_at":"2014-04-22T18:12:28Z","updated_at":"2014-05-01T17:31:36Z","pushed_at":"2014-05-01T17:31:35Z","git_url":"git://github.com/concrete5/concrete5-5.7.0.git","ssh_url":"git@github.com:concrete5/concrete5-5.7.0.git","clone_url":"https://github.com/concrete5/concrete5-5.7.0.git","svn_url":"https://github.com/concrete5/concrete5-5.7.0","homepage":null,"size":54913,"stargazers_count":23,"watchers_count":23,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":74,"forks":14,"open_issues":74,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/100"},"html":{"href":"https://github.com/concrete5/concrete5-5.7.0/pull/100"},"issue":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/100"},"comments":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/ab491d278a7c77df35683c745bc2b0f02d22f432"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":165,"deletions":177,"changed_files":9}}