GitHub PullRequestReviewCommentEvent at 2014-07-17 17:43:38
Repository: maven-process-plugin
Actor: fahdsiddiqui
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/comments/15072234","id":15072234,"diff_hunk":"@@ -13,16 +14,22 @@\n     @Override\n     public void execute()\n             throws MojoExecutionException, MojoFailureException {\n-        for(String arg : arguments) {\n-            getLog().info(\"arg: \" + arg);\n-        }\n-        try {\n-            startProcess();\n-            if (waitForInterrupt) {\n-                sleepUntilInterrupted();\n+\n+        if (!skip) {","path":"src/main/java/com/bazaarvoice/maven/plugin/process/ProcessStartMojo.java","position":19,"original_position":19,"commit_id":"9342b335c3369584d01efe47e53f69a612343ea1","original_commit_id":"9342b335c3369584d01efe47e53f69a612343ea1","user":{"login":"fahdsiddiqui","id":1758096,"avatar_url":"https://avatars.githubusercontent.com/u/1758096?","gravatar_id":"9b4c4d7140e491ddc454e492f980b963","url":"https://api.github.com/users/fahdsiddiqui","html_url":"https://github.com/fahdsiddiqui","followers_url":"https://api.github.com/users/fahdsiddiqui/followers","following_url":"https://api.github.com/users/fahdsiddiqui/following{/other_user}","gists_url":"https://api.github.com/users/fahdsiddiqui/gists{/gist_id}","starred_url":"https://api.github.com/users/fahdsiddiqui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fahdsiddiqui/subscriptions","organizations_url":"https://api.github.com/users/fahdsiddiqui/orgs","repos_url":"https://api.github.com/users/fahdsiddiqui/repos","events_url":"https://api.github.com/users/fahdsiddiqui/events{/privacy}","received_events_url":"https://api.github.com/users/fahdsiddiqui/received_events","type":"User","site_admin":false},"body":"Can you invert this condition? No big deal, but would result in prettier code:\r\n`if (!skip) {\r\n               getLog().info(\"Skipping \" + name + \" due to configuration skip=true\");\r\n               return;\r\n}'","created_at":"2014-07-17T17:43:38Z","updated_at":"2014-07-17T17:43:38Z","html_url":"https://github.com/bazaarvoice/maven-process-plugin/pull/4#discussion_r15072234","pull_request_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/comments/15072234"},"html":{"href":"https://github.com/bazaarvoice/maven-process-plugin/pull/4#discussion_r15072234"},"pull_request":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/4","id":18534295,"html_url":"https://github.com/bazaarvoice/maven-process-plugin/pull/4","diff_url":"https://github.com/bazaarvoice/maven-process-plugin/pull/4.diff","patch_url":"https://github.com/bazaarvoice/maven-process-plugin/pull/4.patch","issue_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/issues/4","number":4,"state":"open","title":"Allow configuration to skip starting","user":{"login":"joeslice","id":152573,"avatar_url":"https://avatars.githubusercontent.com/u/152573?","gravatar_id":"1281c903b5a6486cfd3dd3cf9800d3e7","url":"https://api.github.com/users/joeslice","html_url":"https://github.com/joeslice","followers_url":"https://api.github.com/users/joeslice/followers","following_url":"https://api.github.com/users/joeslice/following{/other_user}","gists_url":"https://api.github.com/users/joeslice/gists{/gist_id}","starred_url":"https://api.github.com/users/joeslice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeslice/subscriptions","organizations_url":"https://api.github.com/users/joeslice/orgs","repos_url":"https://api.github.com/users/joeslice/repos","events_url":"https://api.github.com/users/joeslice/events{/privacy}","received_events_url":"https://api.github.com/users/joeslice/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-17T15:13:55Z","updated_at":"2014-07-17T17:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"872820cfda4c2888a59730770cb14d2070a43083","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/4/commits","review_comments_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/4/comments","review_comment_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/issues/4/comments","statuses_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/statuses/9342b335c3369584d01efe47e53f69a612343ea1","head":{"label":"joeslice:skip","ref":"skip","sha":"9342b335c3369584d01efe47e53f69a612343ea1","user":{"login":"joeslice","id":152573,"avatar_url":"https://avatars.githubusercontent.com/u/152573?","gravatar_id":"1281c903b5a6486cfd3dd3cf9800d3e7","url":"https://api.github.com/users/joeslice","html_url":"https://github.com/joeslice","followers_url":"https://api.github.com/users/joeslice/followers","following_url":"https://api.github.com/users/joeslice/following{/other_user}","gists_url":"https://api.github.com/users/joeslice/gists{/gist_id}","starred_url":"https://api.github.com/users/joeslice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeslice/subscriptions","organizations_url":"https://api.github.com/users/joeslice/orgs","repos_url":"https://api.github.com/users/joeslice/repos","events_url":"https://api.github.com/users/joeslice/events{/privacy}","received_events_url":"https://api.github.com/users/joeslice/received_events","type":"User","site_admin":false},"repo":{"id":21918869,"name":"maven-process-plugin","full_name":"joeslice/maven-process-plugin","owner":{"login":"joeslice","id":152573,"avatar_url":"https://avatars.githubusercontent.com/u/152573?","gravatar_id":"1281c903b5a6486cfd3dd3cf9800d3e7","url":"https://api.github.com/users/joeslice","html_url":"https://github.com/joeslice","followers_url":"https://api.github.com/users/joeslice/followers","following_url":"https://api.github.com/users/joeslice/following{/other_user}","gists_url":"https://api.github.com/users/joeslice/gists{/gist_id}","starred_url":"https://api.github.com/users/joeslice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeslice/subscriptions","organizations_url":"https://api.github.com/users/joeslice/orgs","repos_url":"https://api.github.com/users/joeslice/repos","events_url":"https://api.github.com/users/joeslice/events{/privacy}","received_events_url":"https://api.github.com/users/joeslice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joeslice/maven-process-plugin","description":"","fork":true,"url":"https://api.github.com/repos/joeslice/maven-process-plugin","forks_url":"https://api.github.com/repos/joeslice/maven-process-plugin/forks","keys_url":"https://api.github.com/repos/joeslice/maven-process-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joeslice/maven-process-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joeslice/maven-process-plugin/teams","hooks_url":"https://api.github.com/repos/joeslice/maven-process-plugin/hooks","issue_events_url":"https://api.github.com/repos/joeslice/maven-process-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/joeslice/maven-process-plugin/events","assignees_url":"https://api.github.com/repos/joeslice/maven-process-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/joeslice/maven-process-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/joeslice/maven-process-plugin/tags","blobs_url":"https://api.github.com/repos/joeslice/maven-process-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joeslice/maven-process-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joeslice/maven-process-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/joeslice/maven-process-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joeslice/maven-process-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/joeslice/maven-process-plugin/languages","stargazers_url":"https://api.github.com/repos/joeslice/maven-process-plugin/stargazers","contributors_url":"https://api.github.com/repos/joeslice/maven-process-plugin/contributors","subscribers_url":"https://api.github.com/repos/joeslice/maven-process-plugin/subscribers","subscription_url":"https://api.github.com/repos/joeslice/maven-process-plugin/subscription","commits_url":"https://api.github.com/repos/joeslice/maven-process-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/joeslice/maven-process-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/joeslice/maven-process-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/joeslice/maven-process-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/joeslice/maven-process-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/joeslice/maven-process-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joeslice/maven-process-plugin/merges","archive_url":"https://api.github.com/repos/joeslice/maven-process-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joeslice/maven-process-plugin/downloads","issues_url":"https://api.github.com/repos/joeslice/maven-process-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/joeslice/maven-process-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/joeslice/maven-process-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/joeslice/maven-process-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joeslice/maven-process-plugin/labels{/name}","releases_url":"https://api.github.com/repos/joeslice/maven-process-plugin/releases{/id}","created_at":"2014-07-16T21:28:01Z","updated_at":"2014-07-16T21:28:11Z","pushed_at":"2014-07-17T15:13:33Z","git_url":"git://github.com/joeslice/maven-process-plugin.git","ssh_url":"git@github.com:joeslice/maven-process-plugin.git","clone_url":"https://github.com/joeslice/maven-process-plugin.git","svn_url":"https://github.com/joeslice/maven-process-plugin","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazaarvoice:master","ref":"master","sha":"4872416c73cb77f08ea6aab718b811fb72ecb615","user":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?","gravatar_id":"5eb858de823e92d770ea3eac339f880d","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"repo":{"id":19330213,"name":"maven-process-plugin","full_name":"bazaarvoice/maven-process-plugin","owner":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?","gravatar_id":"5eb858de823e92d770ea3eac339f880d","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazaarvoice/maven-process-plugin","description":"","fork":false,"url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin","forks_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/forks","keys_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/teams","hooks_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/hooks","issue_events_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/events","assignees_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/tags","blobs_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/languages","stargazers_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/stargazers","contributors_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/contributors","subscribers_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/subscribers","subscription_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/subscription","commits_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/merges","archive_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/downloads","issues_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/labels{/name}","releases_url":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/releases{/id}","created_at":"2014-04-30T23:19:47Z","updated_at":"2014-07-16T21:28:15Z","pushed_at":"2014-07-16T22:23:47Z","git_url":"git://github.com/bazaarvoice/maven-process-plugin.git","ssh_url":"git@github.com:bazaarvoice/maven-process-plugin.git","clone_url":"https://github.com/bazaarvoice/maven-process-plugin.git","svn_url":"https://github.com/bazaarvoice/maven-process-plugin","homepage":null,"size":377,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/4"},"html":{"href":"https://github.com/bazaarvoice/maven-process-plugin/pull/4"},"issue":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/issues/4"},"comments":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/bazaarvoice/maven-process-plugin/statuses/9342b335c3369584d01efe47e53f69a612343ea1"}}}}