GitHub PullRequestReviewCommentEvent at 2014-08-28 05:59:36
Repository: bem-bl
Actor: restrry
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bem/bem-bl/pulls/comments/16822323","id":16822323,"diff_hunk":"@@ -270,7 +293,7 @@ FastClick.prototype.sendClick = function(targetElement, event) {\n \n     touch = event.changedTouches[0];\n \n-    // Trigger mousedown\n+    // bem-bl - Trigger mousedown","path":"blocks-touch/i-fastclick/i-fastclick.js","position":217,"original_position":217,"commit_id":"f5f4eee1006670726cc92671f1481fa0765cee12","original_commit_id":"53a55fc62cd65e65bf199965844355adb4fa9ce2","user":{"login":"restrry","id":3198181,"avatar_url":"https://avatars.githubusercontent.com/u/3198181?v=2","gravatar_id":"64cd11d35ef34fdb39c4482bc2c9f995","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"body":"ох, упоролся ) http://www.w3.org/TR/touch-events/#mouse-events, но здесь тоже написано, что\r\n`The user agent may dispatch both touch events and mouse events in response to the same user input.`\r\nда и кажется, что триггер mousemove --> mousedown --> mouseup по touchend, это не то, что мы зачастую ожидаем в нашем коде","created_at":"2014-08-28T05:59:36Z","updated_at":"2014-08-28T05:59:36Z","html_url":"https://github.com/bem/bem-bl/pull/536#discussion_r16822323","pull_request_url":"https://api.github.com/repos/bem/bem-bl/pulls/536","_links":{"self":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/comments/16822323"},"html":{"href":"https://github.com/bem/bem-bl/pull/536#discussion_r16822323"},"pull_request":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/536"}}},"pull_request":{"url":"https://api.github.com/repos/bem/bem-bl/pulls/536","id":19964236,"html_url":"https://github.com/bem/bem-bl/pull/536","diff_url":"https://github.com/bem/bem-bl/pull/536.diff","patch_url":"https://github.com/bem/bem-bl/pull/536.patch","issue_url":"https://api.github.com/repos/bem/bem-bl/issues/536","number":536,"state":"closed","locked":false,"title":"ISL-911 — Обновить bem-bl с i-fastclick 1.0.3","user":{"login":"restrry","id":3198181,"avatar_url":"https://avatars.githubusercontent.com/u/3198181?v=2","gravatar_id":"64cd11d35ef34fdb39c4482bc2c9f995","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-19T07:30:58Z","updated_at":"2014-08-28T05:59:36Z","closed_at":"2014-08-27T10:39:14Z","merged_at":"2014-08-27T10:39:14Z","merge_commit_sha":"17e9ad5199aab1c26dd2a6a4dc92f48559e4b432","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bem/bem-bl/pulls/536/commits","review_comments_url":"https://api.github.com/repos/bem/bem-bl/pulls/536/comments","review_comment_url":"https://api.github.com/repos/bem/bem-bl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bem/bem-bl/issues/536/comments","statuses_url":"https://api.github.com/repos/bem/bem-bl/statuses/f5f4eee1006670726cc92671f1481fa0765cee12","head":{"label":"restrry:restrry.ISL-911.up-fastclick","ref":"restrry.ISL-911.up-fastclick","sha":"f5f4eee1006670726cc92671f1481fa0765cee12","user":{"login":"restrry","id":3198181,"avatar_url":"https://avatars.githubusercontent.com/u/3198181?v=2","gravatar_id":"64cd11d35ef34fdb39c4482bc2c9f995","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"repo":{"id":22498673,"name":"bem-bl","full_name":"restrry/bem-bl","owner":{"login":"restrry","id":3198181,"avatar_url":"https://avatars.githubusercontent.com/u/3198181?v=2","gravatar_id":"64cd11d35ef34fdb39c4482bc2c9f995","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/restrry/bem-bl","description":"Base BEM library","fork":true,"url":"https://api.github.com/repos/restrry/bem-bl","forks_url":"https://api.github.com/repos/restrry/bem-bl/forks","keys_url":"https://api.github.com/repos/restrry/bem-bl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/restrry/bem-bl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/restrry/bem-bl/teams","hooks_url":"https://api.github.com/repos/restrry/bem-bl/hooks","issue_events_url":"https://api.github.com/repos/restrry/bem-bl/issues/events{/number}","events_url":"https://api.github.com/repos/restrry/bem-bl/events","assignees_url":"https://api.github.com/repos/restrry/bem-bl/assignees{/user}","branches_url":"https://api.github.com/repos/restrry/bem-bl/branches{/branch}","tags_url":"https://api.github.com/repos/restrry/bem-bl/tags","blobs_url":"https://api.github.com/repos/restrry/bem-bl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/restrry/bem-bl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/restrry/bem-bl/git/refs{/sha}","trees_url":"https://api.github.com/repos/restrry/bem-bl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/restrry/bem-bl/statuses/{sha}","languages_url":"https://api.github.com/repos/restrry/bem-bl/languages","stargazers_url":"https://api.github.com/repos/restrry/bem-bl/stargazers","contributors_url":"https://api.github.com/repos/restrry/bem-bl/contributors","subscribers_url":"https://api.github.com/repos/restrry/bem-bl/subscribers","subscription_url":"https://api.github.com/repos/restrry/bem-bl/subscription","commits_url":"https://api.github.com/repos/restrry/bem-bl/commits{/sha}","git_commits_url":"https://api.github.com/repos/restrry/bem-bl/git/commits{/sha}","comments_url":"https://api.github.com/repos/restrry/bem-bl/comments{/number}","issue_comment_url":"https://api.github.com/repos/restrry/bem-bl/issues/comments/{number}","contents_url":"https://api.github.com/repos/restrry/bem-bl/contents/{+path}","compare_url":"https://api.github.com/repos/restrry/bem-bl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/restrry/bem-bl/merges","archive_url":"https://api.github.com/repos/restrry/bem-bl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/restrry/bem-bl/downloads","issues_url":"https://api.github.com/repos/restrry/bem-bl/issues{/number}","pulls_url":"https://api.github.com/repos/restrry/bem-bl/pulls{/number}","milestones_url":"https://api.github.com/repos/restrry/bem-bl/milestones{/number}","notifications_url":"https://api.github.com/repos/restrry/bem-bl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/restrry/bem-bl/labels{/name}","releases_url":"https://api.github.com/repos/restrry/bem-bl/releases{/id}","created_at":"2014-08-01T06:57:22Z","updated_at":"2014-07-29T16:47:22Z","pushed_at":"2014-08-27T13:58:11Z","git_url":"git://github.com/restrry/bem-bl.git","ssh_url":"git@github.com:restrry/bem-bl.git","clone_url":"https://github.com/restrry/bem-bl.git","svn_url":"https://github.com/restrry/bem-bl","homepage":"http://bem.github.com/bem-bl/","size":4205,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"bem:dev","ref":"dev","sha":"f01032576b63b23e2eb94ba2c2e760dee1f7ca48","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=2","gravatar_id":"18b6e3435ca67fe775d3b21e1a70b25a","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":610292,"name":"bem-bl","full_name":"bem/bem-bl","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=2","gravatar_id":"18b6e3435ca67fe775d3b21e1a70b25a","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/bem-bl","description":"Base BEM library","fork":false,"url":"https://api.github.com/repos/bem/bem-bl","forks_url":"https://api.github.com/repos/bem/bem-bl/forks","keys_url":"https://api.github.com/repos/bem/bem-bl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/bem-bl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/bem-bl/teams","hooks_url":"https://api.github.com/repos/bem/bem-bl/hooks","issue_events_url":"https://api.github.com/repos/bem/bem-bl/issues/events{/number}","events_url":"https://api.github.com/repos/bem/bem-bl/events","assignees_url":"https://api.github.com/repos/bem/bem-bl/assignees{/user}","branches_url":"https://api.github.com/repos/bem/bem-bl/branches{/branch}","tags_url":"https://api.github.com/repos/bem/bem-bl/tags","blobs_url":"https://api.github.com/repos/bem/bem-bl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/bem-bl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/bem-bl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/bem-bl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/bem-bl/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/bem-bl/languages","stargazers_url":"https://api.github.com/repos/bem/bem-bl/stargazers","contributors_url":"https://api.github.com/repos/bem/bem-bl/contributors","subscribers_url":"https://api.github.com/repos/bem/bem-bl/subscribers","subscription_url":"https://api.github.com/repos/bem/bem-bl/subscription","commits_url":"https://api.github.com/repos/bem/bem-bl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/bem-bl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/bem-bl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/bem-bl/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/bem-bl/contents/{+path}","compare_url":"https://api.github.com/repos/bem/bem-bl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/bem-bl/merges","archive_url":"https://api.github.com/repos/bem/bem-bl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/bem-bl/downloads","issues_url":"https://api.github.com/repos/bem/bem-bl/issues{/number}","pulls_url":"https://api.github.com/repos/bem/bem-bl/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/bem-bl/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/bem-bl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/bem-bl/labels{/name}","releases_url":"https://api.github.com/repos/bem/bem-bl/releases{/id}","created_at":"2010-04-14T15:28:16Z","updated_at":"2014-08-27T18:55:56Z","pushed_at":"2014-08-27T13:00:09Z","git_url":"git://github.com/bem/bem-bl.git","ssh_url":"git@github.com:bem/bem-bl.git","clone_url":"https://github.com/bem/bem-bl.git","svn_url":"https://github.com/bem/bem-bl","homepage":"http://bem.github.com/bem-bl/","size":12976,"stargazers_count":187,"watchers_count":187,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":88,"mirror_url":null,"open_issues_count":69,"forks":88,"open_issues":69,"watchers":187,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/536"},"html":{"href":"https://github.com/bem/bem-bl/pull/536"},"issue":{"href":"https://api.github.com/repos/bem/bem-bl/issues/536"},"comments":{"href":"https://api.github.com/repos/bem/bem-bl/issues/536/comments"},"review_comments":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/536/comments"},"review_comment":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/536/commits"},"statuses":{"href":"https://api.github.com/repos/bem/bem-bl/statuses/f5f4eee1006670726cc92671f1481fa0765cee12"}}}}