GitHub PullRequestReviewCommentEvent at 2014-10-15 19:44:19
Repository: SonataPageBundle
Actor: meyerbaptiste
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/18917323","id":18917323,"diff_hunk":"@@ -77,7 +77,7 @@ protected function updateSeoPage(PageInterface $page)\n         }\n \n         if ($page->getTitle()) {\n-            $this->seoPage->setTitle($page->getTitle() ?: $page->getName());\n+           $this->seoPage->setTitle($page->getTitle() ? $page->getTitle() : $page->getName());","path":"Page/Service/DefaultPageService.php","position":5,"original_position":5,"commit_id":"3948d2a46e3e27beda21958e3b72ce41eb3ba07c","original_commit_id":"3948d2a46e3e27beda21958e3b72ce41eb3ba07c","user":{"login":"meyerbaptiste","id":4034907,"avatar_url":"https://avatars.githubusercontent.com/u/4034907?v=2","gravatar_id":"","url":"https://api.github.com/users/meyerbaptiste","html_url":"https://github.com/meyerbaptiste","followers_url":"https://api.github.com/users/meyerbaptiste/followers","following_url":"https://api.github.com/users/meyerbaptiste/following{/other_user}","gists_url":"https://api.github.com/users/meyerbaptiste/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerbaptiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerbaptiste/subscriptions","organizations_url":"https://api.github.com/users/meyerbaptiste/orgs","repos_url":"https://api.github.com/users/meyerbaptiste/repos","events_url":"https://api.github.com/users/meyerbaptiste/events{/privacy}","received_events_url":"https://api.github.com/users/meyerbaptiste/received_events","type":"User","site_admin":false},"body":"I don't understand. What is the goal of this?\r\nSince PHP 5.3 `$a ?: $b` is equivalent to `$a ? $a : $b`.\r\nIn addition this breaks tests and then the indentation is not correct. :-1: ","created_at":"2014-10-15T19:44:19Z","updated_at":"2014-10-15T19:44:19Z","html_url":"https://github.com/sonata-project/SonataPageBundle/pull/406#discussion_r18917323","pull_request_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/406","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/18917323"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/406#discussion_r18917323"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/406"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/406","id":22805002,"html_url":"https://github.com/sonata-project/SonataPageBundle/pull/406","diff_url":"https://github.com/sonata-project/SonataPageBundle/pull/406.diff","patch_url":"https://github.com/sonata-project/SonataPageBundle/pull/406.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/406","number":406,"state":"open","locked":false,"title":"Fix typo seo page title","user":{"login":"kadala","id":988238,"avatar_url":"https://avatars.githubusercontent.com/u/988238?v=2","gravatar_id":"","url":"https://api.github.com/users/kadala","html_url":"https://github.com/kadala","followers_url":"https://api.github.com/users/kadala/followers","following_url":"https://api.github.com/users/kadala/following{/other_user}","gists_url":"https://api.github.com/users/kadala/gists{/gist_id}","starred_url":"https://api.github.com/users/kadala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadala/subscriptions","organizations_url":"https://api.github.com/users/kadala/orgs","repos_url":"https://api.github.com/users/kadala/repos","events_url":"https://api.github.com/users/kadala/events{/privacy}","received_events_url":"https://api.github.com/users/kadala/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-15T18:39:16Z","updated_at":"2014-10-15T19:44:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0460f24b7714aa5666ffe0e08946305cb9e9ea7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/406/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/406/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/406/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/3948d2a46e3e27beda21958e3b72ce41eb3ba07c","head":{"label":"kadala:patch-1","ref":"patch-1","sha":"3948d2a46e3e27beda21958e3b72ce41eb3ba07c","user":{"login":"kadala","id":988238,"avatar_url":"https://avatars.githubusercontent.com/u/988238?v=2","gravatar_id":"","url":"https://api.github.com/users/kadala","html_url":"https://github.com/kadala","followers_url":"https://api.github.com/users/kadala/followers","following_url":"https://api.github.com/users/kadala/following{/other_user}","gists_url":"https://api.github.com/users/kadala/gists{/gist_id}","starred_url":"https://api.github.com/users/kadala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadala/subscriptions","organizations_url":"https://api.github.com/users/kadala/orgs","repos_url":"https://api.github.com/users/kadala/repos","events_url":"https://api.github.com/users/kadala/events{/privacy}","received_events_url":"https://api.github.com/users/kadala/received_events","type":"User","site_admin":false},"repo":{"id":25268121,"name":"SonataPageBundle","full_name":"kadala/SonataPageBundle","owner":{"login":"kadala","id":988238,"avatar_url":"https://avatars.githubusercontent.com/u/988238?v=2","gravatar_id":"","url":"https://api.github.com/users/kadala","html_url":"https://github.com/kadala","followers_url":"https://api.github.com/users/kadala/followers","following_url":"https://api.github.com/users/kadala/following{/other_user}","gists_url":"https://api.github.com/users/kadala/gists{/gist_id}","starred_url":"https://api.github.com/users/kadala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadala/subscriptions","organizations_url":"https://api.github.com/users/kadala/orgs","repos_url":"https://api.github.com/users/kadala/repos","events_url":"https://api.github.com/users/kadala/events{/privacy}","received_events_url":"https://api.github.com/users/kadala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kadala/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":true,"url":"https://api.github.com/repos/kadala/SonataPageBundle","forks_url":"https://api.github.com/repos/kadala/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/kadala/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadala/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadala/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/kadala/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/kadala/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/kadala/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/kadala/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/kadala/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/kadala/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/kadala/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadala/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadala/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadala/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadala/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/kadala/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/kadala/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/kadala/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/kadala/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/kadala/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/kadala/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadala/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadala/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadala/SonataPageBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/kadala/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/kadala/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadala/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/kadala/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadala/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/kadala/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/kadala/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/kadala/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/kadala/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadala/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/kadala/SonataPageBundle/releases{/id}","created_at":"2014-10-15T18:36:57Z","updated_at":"2014-10-03T11:39:10Z","pushed_at":"2014-10-15T18:39:05Z","git_url":"git://github.com/kadala/SonataPageBundle.git","ssh_url":"git@github.com:kadala/SonataPageBundle.git","clone_url":"https://github.com/kadala/SonataPageBundle.git","svn_url":"https://github.com/kadala/SonataPageBundle","homepage":"http://sonata-project.org/bundles/page","size":6558,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"0f88b7383304a09b28c45e48c245171412b2a3d9","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=2","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1141608,"name":"SonataPageBundle","full_name":"sonata-project/SonataPageBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=2","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataPageBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/releases{/id}","created_at":"2010-12-06T00:18:21Z","updated_at":"2014-10-03T11:39:10Z","pushed_at":"2014-10-15T14:09:59Z","git_url":"git://github.com/sonata-project/SonataPageBundle.git","ssh_url":"git@github.com:sonata-project/SonataPageBundle.git","clone_url":"https://github.com/sonata-project/SonataPageBundle.git","svn_url":"https://github.com/sonata-project/SonataPageBundle","homepage":"http://sonata-project.org/bundles/page","size":6558,"stargazers_count":114,"watchers_count":114,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":34,"forks":103,"open_issues":34,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/406"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/406"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/406"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/3948d2a46e3e27beda21958e3b72ce41eb3ba07c"}}}}