GitHub PullRequestReviewCommentEvent at 2014-02-06 11:55:58
Repository: julia
Actor: simonbyrne
Payload: {"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/9497690","id":9497690,"diff_hunk":"@@ -104,17 +113,72 @@ end\n colon(start::Real, step::Real, stop::Real) = colon(promote(start, step, stop)...)\n colon(start::Real, stop::Real) = colon(promote(start, stop)...)\n \n+# float rationalization helper\n+function rat(x)","path":"base/range.jl","position":30,"original_position":30,"commit_id":"db39bda472d485b80f4433e8ce3d696ecc04fdb2","original_commit_id":"db39bda472d485b80f4433e8ce3d696ecc04fdb2","user":{"login":"simonbyrne","id":1692009,"avatar_url":"https://gravatar.com/avatar/5ac7b1da0f2e9107b5020f88023a15e5?d=https%3A%2F%2Fidenticons.github.com%2F78ed96596b5786af9c65360c7fff0624.png&r=x","gravatar_id":"5ac7b1da0f2e9107b5020f88023a15e5","url":"https://api.github.com/users/simonbyrne","html_url":"https://github.com/simonbyrne","followers_url":"https://api.github.com/users/simonbyrne/followers","following_url":"https://api.github.com/users/simonbyrne/following{/other_user}","gists_url":"https://api.github.com/users/simonbyrne/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbyrne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbyrne/subscriptions","organizations_url":"https://api.github.com/users/simonbyrne/orgs","repos_url":"https://api.github.com/users/simonbyrne/repos","events_url":"https://api.github.com/users/simonbyrne/events{/privacy}","received_events_url":"https://api.github.com/users/simonbyrne/received_events","type":"User","site_admin":false},"body":"Out of curiosity, why not just use `rationalize` here?","created_at":"2014-02-06T11:55:58Z","updated_at":"2014-02-06T11:55:58Z","html_url":"https://github.com/JuliaLang/julia/pull/5636#discussion_r9497690","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/5636","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/9497690"},"html":{"href":"https://github.com/JuliaLang/julia/pull/5636#discussion_r9497690"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/5636"}}}}