GitHub PullRequestReviewCommentEvent at 2014-10-10 23:42:48
Repository: druid
Actor: fjy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/metamx/druid/pulls/comments/18736557","id":18736557,"diff_hunk":"@@ -0,0 +1,50 @@\n+/*\n+ * Druid - a distributed column store.\n+ * Copyright (C) 2012, 2013  Metamarkets Group Inc.\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU General Public License\n+ * as published by the Free Software Foundation; either version 2\n+ * of the License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+ */\n+\n+package io.druid.db;\n+\n+import com.google.api.client.repackaged.com.google.common.base.Throwables;\n+import org.skife.jdbi.v2.tweak.ConnectionFactory;\n+\n+import java.sql.Connection;\n+import java.sql.DriverManager;\n+import java.sql.SQLException;\n+\n+public class DerbyConnectionFactory implements ConnectionFactory\n+{\n+  private String dbName;","path":"server/src/main/java/io/druid/db/DerbyConnectionFactory.java","position":31,"original_position":31,"commit_id":"66277ddf2bafeb89482cfda437bd92cd61382174","original_commit_id":"66277ddf2bafeb89482cfda437bd92cd61382174","user":{"login":"fjy","id":428325,"avatar_url":"https://avatars.githubusercontent.com/u/428325?v=2","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"body":"in general make things final\r\nmutability is bad","created_at":"2014-10-10T23:42:48Z","updated_at":"2014-10-10T23:42:48Z","html_url":"https://github.com/metamx/druid/pull/758#discussion_r18736557","pull_request_url":"https://api.github.com/repos/metamx/druid/pulls/758","_links":{"self":{"href":"https://api.github.com/repos/metamx/druid/pulls/comments/18736557"},"html":{"href":"https://github.com/metamx/druid/pull/758#discussion_r18736557"},"pull_request":{"href":"https://api.github.com/repos/metamx/druid/pulls/758"}}},"pull_request":{"url":"https://api.github.com/repos/metamx/druid/pulls/758","id":21877692,"html_url":"https://github.com/metamx/druid/pull/758","diff_url":"https://github.com/metamx/druid/pull/758.diff","patch_url":"https://github.com/metamx/druid/pull/758.patch","issue_url":"https://api.github.com/repos/metamx/druid/issues/758","number":758,"state":"open","locked":false,"title":"initial attempt for abstraction; druid works with Derby as default","user":{"login":"jisookim0513","id":3820496,"avatar_url":"https://avatars.githubusercontent.com/u/3820496?v=2","gravatar_id":"","url":"https://api.github.com/users/jisookim0513","html_url":"https://github.com/jisookim0513","followers_url":"https://api.github.com/users/jisookim0513/followers","following_url":"https://api.github.com/users/jisookim0513/following{/other_user}","gists_url":"https://api.github.com/users/jisookim0513/gists{/gist_id}","starred_url":"https://api.github.com/users/jisookim0513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jisookim0513/subscriptions","organizations_url":"https://api.github.com/users/jisookim0513/orgs","repos_url":"https://api.github.com/users/jisookim0513/repos","events_url":"https://api.github.com/users/jisookim0513/events{/privacy}","received_events_url":"https://api.github.com/users/jisookim0513/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-26T21:48:06Z","updated_at":"2014-10-10T23:42:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"471d6207fd387d0461c6d28ef1ea10e06bd3ddb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/metamx/druid/pulls/758/commits","review_comments_url":"https://api.github.com/repos/metamx/druid/pulls/758/comments","review_comment_url":"https://api.github.com/repos/metamx/druid/pulls/comments/{number}","comments_url":"https://api.github.com/repos/metamx/druid/issues/758/comments","statuses_url":"https://api.github.com/repos/metamx/druid/statuses/66277ddf2bafeb89482cfda437bd92cd61382174","head":{"label":"metamx:jisoo-metadata","ref":"jisoo-metadata","sha":"66277ddf2bafeb89482cfda437bd92cd61382174","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=2","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"metamx/druid","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=2","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":false,"url":"https://api.github.com/repos/metamx/druid","forks_url":"https://api.github.com/repos/metamx/druid/forks","keys_url":"https://api.github.com/repos/metamx/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/druid/teams","hooks_url":"https://api.github.com/repos/metamx/druid/hooks","issue_events_url":"https://api.github.com/repos/metamx/druid/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/druid/events","assignees_url":"https://api.github.com/repos/metamx/druid/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/druid/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/druid/tags","blobs_url":"https://api.github.com/repos/metamx/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/druid/languages","stargazers_url":"https://api.github.com/repos/metamx/druid/stargazers","contributors_url":"https://api.github.com/repos/metamx/druid/contributors","subscribers_url":"https://api.github.com/repos/metamx/druid/subscribers","subscription_url":"https://api.github.com/repos/metamx/druid/subscription","commits_url":"https://api.github.com/repos/metamx/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/druid/issues/comments/{number}","contents_url":"https://api.github.com/repos/metamx/druid/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/druid/merges","archive_url":"https://api.github.com/repos/metamx/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/druid/downloads","issues_url":"https://api.github.com/repos/metamx/druid/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/druid/labels{/name}","releases_url":"https://api.github.com/repos/metamx/druid/releases{/id}","created_at":"2012-10-23T19:08:07Z","updated_at":"2014-10-09T20:11:48Z","pushed_at":"2014-10-10T21:08:21Z","git_url":"git://github.com/metamx/druid.git","ssh_url":"git@github.com:metamx/druid.git","clone_url":"https://github.com/metamx/druid.git","svn_url":"https://github.com/metamx/druid","homepage":"http://druid.io","size":166708,"stargazers_count":1070,"watchers_count":1070,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":116,"forks":217,"open_issues":116,"watchers":1070,"default_branch":"master"}},"base":{"label":"metamx:druid-0.7.x","ref":"druid-0.7.x","sha":"4244accab52d3d3b45ba415b03872676e799b2ac","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=2","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"metamx/druid","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=2","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":false,"url":"https://api.github.com/repos/metamx/druid","forks_url":"https://api.github.com/repos/metamx/druid/forks","keys_url":"https://api.github.com/repos/metamx/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/druid/teams","hooks_url":"https://api.github.com/repos/metamx/druid/hooks","issue_events_url":"https://api.github.com/repos/metamx/druid/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/druid/events","assignees_url":"https://api.github.com/repos/metamx/druid/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/druid/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/druid/tags","blobs_url":"https://api.github.com/repos/metamx/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/druid/languages","stargazers_url":"https://api.github.com/repos/metamx/druid/stargazers","contributors_url":"https://api.github.com/repos/metamx/druid/contributors","subscribers_url":"https://api.github.com/repos/metamx/druid/subscribers","subscription_url":"https://api.github.com/repos/metamx/druid/subscription","commits_url":"https://api.github.com/repos/metamx/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/druid/issues/comments/{number}","contents_url":"https://api.github.com/repos/metamx/druid/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/druid/merges","archive_url":"https://api.github.com/repos/metamx/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/druid/downloads","issues_url":"https://api.github.com/repos/metamx/druid/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/druid/labels{/name}","releases_url":"https://api.github.com/repos/metamx/druid/releases{/id}","created_at":"2012-10-23T19:08:07Z","updated_at":"2014-10-09T20:11:48Z","pushed_at":"2014-10-10T21:08:21Z","git_url":"git://github.com/metamx/druid.git","ssh_url":"git@github.com:metamx/druid.git","clone_url":"https://github.com/metamx/druid.git","svn_url":"https://github.com/metamx/druid","homepage":"http://druid.io","size":166708,"stargazers_count":1070,"watchers_count":1070,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":116,"forks":217,"open_issues":116,"watchers":1070,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metamx/druid/pulls/758"},"html":{"href":"https://github.com/metamx/druid/pull/758"},"issue":{"href":"https://api.github.com/repos/metamx/druid/issues/758"},"comments":{"href":"https://api.github.com/repos/metamx/druid/issues/758/comments"},"review_comments":{"href":"https://api.github.com/repos/metamx/druid/pulls/758/comments"},"review_comment":{"href":"https://api.github.com/repos/metamx/druid/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/metamx/druid/pulls/758/commits"},"statuses":{"href":"https://api.github.com/repos/metamx/druid/statuses/66277ddf2bafeb89482cfda437bd92cd61382174"}}}}