GitHub PullRequestReviewCommentEvent at 2014-11-03 17:52:59
Repository: j2me.js
Actor: mykmelez
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/comments/19750470","id":19750470,"diff_hunk":"@@ -336,14 +338,138 @@ NokiaContactsLocalMsgConnection.prototype.sendMessageToServer = function(message\n   }\n }\n \n+var NokiaFileUILocalMsgConnection = function() {\n+    LocalMsgConnection.call(this);\n+};\n+\n+NokiaFileUILocalMsgConnection.prototype = Object.create(LocalMsgConnection.prototype);\n+\n+NokiaFileUILocalMsgConnection.prototype.sendMessageToServer = function(message) {\n+  var decoder = new DataDecoder(message.data, message.offset, message.length);\n+\n+  decoder.getStart(DataType.STRUCT);\n+  var name = decoder.getValue(DataType.METHOD);\n+\n+  switch (name) {\n+    case \"Common\":\n+      var encoder = new DataEncoder();\n+\n+      encoder.putStart(DataType.STRUCT, \"event\");\n+      encoder.put(DataType.METHOD, \"name\", \"Common\");\n+      encoder.putStart(DataType.STRUCT, \"message\");\n+      encoder.put(DataType.METHOD, \"name\", \"ProtocolVersion\");\n+      encoder.put(DataType.STRING, \"version\", \"1.0\");\n+      encoder.putEnd(DataType.STRUCT, \"message\");\n+      encoder.putEnd(DataType.STRUCT, \"event\");\n+\n+      var data = new TextEncoder().encode(encoder.getData());\n+      this.sendMessageToClient({\n+          data: data,\n+          length: data.length,\n+          offset: 0,\n+      });\n+      break;\n+\n+    case \"FileSelect\":","path":"midp/localmsg.js","position":67,"original_position":67,"commit_id":"f446fd1d996c0918a4b434182f443a4df44a7d4d","original_commit_id":"f446fd1d996c0918a4b434182f443a4df44a7d4d","user":{"login":"mykmelez","id":305455,"avatar_url":"https://avatars.githubusercontent.com/u/305455?v=2","gravatar_id":"","url":"https://api.github.com/users/mykmelez","html_url":"https://github.com/mykmelez","followers_url":"https://api.github.com/users/mykmelez/followers","following_url":"https://api.github.com/users/mykmelez/following{/other_user}","gists_url":"https://api.github.com/users/mykmelez/gists{/gist_id}","starred_url":"https://api.github.com/users/mykmelez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykmelez/subscriptions","organizations_url":"https://api.github.com/users/mykmelez/orgs","repos_url":"https://api.github.com/users/mykmelez/repos","events_url":"https://api.github.com/users/mykmelez/events{/privacy}","received_events_url":"https://api.github.com/users/mykmelez/received_events","type":"User","site_admin":false},"body":"Nit: these long case \"blocks\" are scoping footguns. It'd be better to put them into functions.","created_at":"2014-11-03T17:52:59Z","updated_at":"2014-11-03T17:52:59Z","html_url":"https://github.com/andreasgal/j2me.js/pull/524#discussion_r19750470","pull_request_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/524","_links":{"self":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/comments/19750470"},"html":{"href":"https://github.com/andreasgal/j2me.js/pull/524#discussion_r19750470"},"pull_request":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/524","id":23736331,"html_url":"https://github.com/andreasgal/j2me.js/pull/524","diff_url":"https://github.com/andreasgal/j2me.js/pull/524.diff","patch_url":"https://github.com/andreasgal/j2me.js/pull/524.patch","issue_url":"https://api.github.com/repos/andreasgal/j2me.js/issues/524","number":524,"state":"open","locked":false,"title":"Implement nokia.file-ui localmsg server","user":{"login":"marco-c","id":1616846,"avatar_url":"https://avatars.githubusercontent.com/u/1616846?v=2","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-02T20:59:21Z","updated_at":"2014-11-03T17:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09e0a33ace0d39cfffc5cc97364db6700917fdec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/524/commits","review_comments_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/524/comments","review_comment_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/andreasgal/j2me.js/issues/524/comments","statuses_url":"https://api.github.com/repos/andreasgal/j2me.js/statuses/f446fd1d996c0918a4b434182f443a4df44a7d4d","head":{"label":"marco-c:nokia_fileui","ref":"nokia_fileui","sha":"f446fd1d996c0918a4b434182f443a4df44a7d4d","user":{"login":"marco-c","id":1616846,"avatar_url":"https://avatars.githubusercontent.com/u/1616846?v=2","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"repo":{"id":22527203,"name":"j2me.js","full_name":"marco-c/j2me.js","owner":{"login":"marco-c","id":1616846,"avatar_url":"https://avatars.githubusercontent.com/u/1616846?v=2","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marco-c/j2me.js","description":"J2ME VM in JavaScript","fork":true,"url":"https://api.github.com/repos/marco-c/j2me.js","forks_url":"https://api.github.com/repos/marco-c/j2me.js/forks","keys_url":"https://api.github.com/repos/marco-c/j2me.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marco-c/j2me.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marco-c/j2me.js/teams","hooks_url":"https://api.github.com/repos/marco-c/j2me.js/hooks","issue_events_url":"https://api.github.com/repos/marco-c/j2me.js/issues/events{/number}","events_url":"https://api.github.com/repos/marco-c/j2me.js/events","assignees_url":"https://api.github.com/repos/marco-c/j2me.js/assignees{/user}","branches_url":"https://api.github.com/repos/marco-c/j2me.js/branches{/branch}","tags_url":"https://api.github.com/repos/marco-c/j2me.js/tags","blobs_url":"https://api.github.com/repos/marco-c/j2me.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marco-c/j2me.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marco-c/j2me.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/marco-c/j2me.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marco-c/j2me.js/statuses/{sha}","languages_url":"https://api.github.com/repos/marco-c/j2me.js/languages","stargazers_url":"https://api.github.com/repos/marco-c/j2me.js/stargazers","contributors_url":"https://api.github.com/repos/marco-c/j2me.js/contributors","subscribers_url":"https://api.github.com/repos/marco-c/j2me.js/subscribers","subscription_url":"https://api.github.com/repos/marco-c/j2me.js/subscription","commits_url":"https://api.github.com/repos/marco-c/j2me.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/marco-c/j2me.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/marco-c/j2me.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/marco-c/j2me.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/marco-c/j2me.js/contents/{+path}","compare_url":"https://api.github.com/repos/marco-c/j2me.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marco-c/j2me.js/merges","archive_url":"https://api.github.com/repos/marco-c/j2me.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marco-c/j2me.js/downloads","issues_url":"https://api.github.com/repos/marco-c/j2me.js/issues{/number}","pulls_url":"https://api.github.com/repos/marco-c/j2me.js/pulls{/number}","milestones_url":"https://api.github.com/repos/marco-c/j2me.js/milestones{/number}","notifications_url":"https://api.github.com/repos/marco-c/j2me.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marco-c/j2me.js/labels{/name}","releases_url":"https://api.github.com/repos/marco-c/j2me.js/releases{/id}","created_at":"2014-08-01T20:30:33Z","updated_at":"2014-08-02T02:53:18Z","pushed_at":"2014-11-03T17:40:13Z","git_url":"git://github.com/marco-c/j2me.js.git","ssh_url":"git@github.com:marco-c/j2me.js.git","clone_url":"https://github.com/marco-c/j2me.js.git","svn_url":"https://github.com/marco-c/j2me.js","homepage":null,"size":8898,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andreasgal:master","ref":"master","sha":"a2157b435fbdd29eda2820a4bc375f051e3ed7bc","user":{"login":"andreasgal","id":313748,"avatar_url":"https://avatars.githubusercontent.com/u/313748?v=2","gravatar_id":"","url":"https://api.github.com/users/andreasgal","html_url":"https://github.com/andreasgal","followers_url":"https://api.github.com/users/andreasgal/followers","following_url":"https://api.github.com/users/andreasgal/following{/other_user}","gists_url":"https://api.github.com/users/andreasgal/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasgal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasgal/subscriptions","organizations_url":"https://api.github.com/users/andreasgal/orgs","repos_url":"https://api.github.com/users/andreasgal/repos","events_url":"https://api.github.com/users/andreasgal/events{/privacy}","received_events_url":"https://api.github.com/users/andreasgal/received_events","type":"User","site_admin":false},"repo":{"id":21724513,"name":"j2me.js","full_name":"andreasgal/j2me.js","owner":{"login":"andreasgal","id":313748,"avatar_url":"https://avatars.githubusercontent.com/u/313748?v=2","gravatar_id":"","url":"https://api.github.com/users/andreasgal","html_url":"https://github.com/andreasgal","followers_url":"https://api.github.com/users/andreasgal/followers","following_url":"https://api.github.com/users/andreasgal/following{/other_user}","gists_url":"https://api.github.com/users/andreasgal/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasgal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasgal/subscriptions","organizations_url":"https://api.github.com/users/andreasgal/orgs","repos_url":"https://api.github.com/users/andreasgal/repos","events_url":"https://api.github.com/users/andreasgal/events{/privacy}","received_events_url":"https://api.github.com/users/andreasgal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreasgal/j2me.js","description":"J2ME VM in JavaScript","fork":false,"url":"https://api.github.com/repos/andreasgal/j2me.js","forks_url":"https://api.github.com/repos/andreasgal/j2me.js/forks","keys_url":"https://api.github.com/repos/andreasgal/j2me.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreasgal/j2me.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreasgal/j2me.js/teams","hooks_url":"https://api.github.com/repos/andreasgal/j2me.js/hooks","issue_events_url":"https://api.github.com/repos/andreasgal/j2me.js/issues/events{/number}","events_url":"https://api.github.com/repos/andreasgal/j2me.js/events","assignees_url":"https://api.github.com/repos/andreasgal/j2me.js/assignees{/user}","branches_url":"https://api.github.com/repos/andreasgal/j2me.js/branches{/branch}","tags_url":"https://api.github.com/repos/andreasgal/j2me.js/tags","blobs_url":"https://api.github.com/repos/andreasgal/j2me.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreasgal/j2me.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreasgal/j2me.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreasgal/j2me.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreasgal/j2me.js/statuses/{sha}","languages_url":"https://api.github.com/repos/andreasgal/j2me.js/languages","stargazers_url":"https://api.github.com/repos/andreasgal/j2me.js/stargazers","contributors_url":"https://api.github.com/repos/andreasgal/j2me.js/contributors","subscribers_url":"https://api.github.com/repos/andreasgal/j2me.js/subscribers","subscription_url":"https://api.github.com/repos/andreasgal/j2me.js/subscription","commits_url":"https://api.github.com/repos/andreasgal/j2me.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreasgal/j2me.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreasgal/j2me.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreasgal/j2me.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/andreasgal/j2me.js/contents/{+path}","compare_url":"https://api.github.com/repos/andreasgal/j2me.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreasgal/j2me.js/merges","archive_url":"https://api.github.com/repos/andreasgal/j2me.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreasgal/j2me.js/downloads","issues_url":"https://api.github.com/repos/andreasgal/j2me.js/issues{/number}","pulls_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls{/number}","milestones_url":"https://api.github.com/repos/andreasgal/j2me.js/milestones{/number}","notifications_url":"https://api.github.com/repos/andreasgal/j2me.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreasgal/j2me.js/labels{/name}","releases_url":"https://api.github.com/repos/andreasgal/j2me.js/releases{/id}","created_at":"2014-07-11T06:23:27Z","updated_at":"2014-10-29T19:35:33Z","pushed_at":"2014-11-03T17:19:39Z","git_url":"git://github.com/andreasgal/j2me.js.git","ssh_url":"git@github.com:andreasgal/j2me.js.git","clone_url":"https://github.com/andreasgal/j2me.js.git","svn_url":"https://github.com/andreasgal/j2me.js","homepage":null,"size":13127,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":72,"forks":11,"open_issues":72,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/524"},"html":{"href":"https://github.com/andreasgal/j2me.js/pull/524"},"issue":{"href":"https://api.github.com/repos/andreasgal/j2me.js/issues/524"},"comments":{"href":"https://api.github.com/repos/andreasgal/j2me.js/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/andreasgal/j2me.js/statuses/f446fd1d996c0918a4b434182f443a4df44a7d4d"}}}}