GitHub PushEvent at 2014-07-15 08:40:28
Repository: capstone
Actor: flyingsymbols
Payload: {"shas":[["298d413bbc996b09549067b4acb63ea26cde2d68","341c9144981219cd6466235b683ed7138123cad0@gmail.com","* added a test file to suite for testing invalid and valid instruction sequences\n\n* fixed and added a test for a thumb-2 invalid sequence that was incorrectly allowed before these changes (pop.w with sp argument included)\n* fixed and added a test for a blx from thumb to ARM that had its immediate argument incorrect (misaligned)\n\n* eliminated some warnings by explicitly casting so I could turn on\n  treat warnings as errors locally\n\nGeneral notes:\n*  probably worth turning on treat all warnings as errors in the msvc project files, had a subtle bug that resulted from a missing declaration causing differences in dll and static compilation modes\n\n( code was working incorrectly in dll form because of missing declaration in arch/ARM/ARMMapping.h for new function ARM_blx_to_arm_mode. Something about the linking was confusing ld when making the dll, and the resulting offsets were wonky (e.g. the added ble test would show up as #0x1fc instead of #0x1fe like it should have )\n\n* the invalid pop was being treated as a soft fail which then gets coerced\n  to a success because it is != MCDisassembler_Fail in Thumb_getInstruction\n  what are the semantics of a soft fail? Maybe we should be able to set up\n  whether or not we want a soft fail to be a real fail in the csh struct?","flyingsymbols",true]],"size":1,"ref":"refs/heads/next","head":"298d413bbc996b09549067b4acb63ea26cde2d68"}