GitHub PullRequestReviewCommentEvent at 2014-05-15 08:01:42
Repository: mtwitter
Actor: bpierre
Payload: {"comment":{"url":"https://api.github.com/repos/passcod/mtwitter/pulls/comments/12677782","id":12677782,"diff_hunk":"@@ -19,11 +19,13 @@ module.exports = function Twitter(options) {\n   var rest = new (require('./rest'))(this.options);\n   this.rest = rest;\n \n+  var queueRequestOpts = {skipQueue: options.skipQueue};\n+\n   // ## Convenience functions over rest.queueRequest().\n   //\n   // `params` is _optional_ here.\n   this.get = function(url, params, callback) {\n-    return rest.queueRequest('GET', url, params, callback);\n+    return rest.queueRequest('GET', url, params, callback, queueRequestOpts);","path":"lib/mtwitter.js","position":11,"original_position":11,"commit_id":"41b03fa928582429f0fb4f2afac19c88b0c60476","original_commit_id":"41b03fa928582429f0fb4f2afac19c88b0c60476","user":{"login":"bpierre","id":36158,"avatar_url":"https://avatars.githubusercontent.com/u/36158?","gravatar_id":"e7b539c2cca1ed9a92936fabb0162dfb","url":"https://api.github.com/users/bpierre","html_url":"https://github.com/bpierre","followers_url":"https://api.github.com/users/bpierre/followers","following_url":"https://api.github.com/users/bpierre/following{/other_user}","gists_url":"https://api.github.com/users/bpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/bpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpierre/subscriptions","organizations_url":"https://api.github.com/users/bpierre/orgs","repos_url":"https://api.github.com/users/bpierre/repos","events_url":"https://api.github.com/users/bpierre/events{/privacy}","received_events_url":"https://api.github.com/users/bpierre/received_events","type":"User","site_admin":false},"body":"It would be shorter, but `queueRequest()` would be more difficult to move or test. I try to keep functions not depending on external variables, and I thought it was preferable to let higher-level functions handle this. I don’t really mind though, tell me if you still want to move this in `queueRequest` and I will do it.","created_at":"2014-05-15T08:01:42Z","updated_at":"2014-05-15T08:01:42Z","html_url":"https://github.com/passcod/mtwitter/pull/5#discussion_r12677782","pull_request_url":"https://api.github.com/repos/passcod/mtwitter/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/passcod/mtwitter/pulls/comments/12677782"},"html":{"href":"https://github.com/passcod/mtwitter/pull/5#discussion_r12677782"},"pull_request":{"href":"https://api.github.com/repos/passcod/mtwitter/pulls/5"}}}}