GitHub PullRequestReviewCommentEvent at 2014-10-23 21:29:58
Repository: ffi-vix_disk_lib
Actor: Fryguy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/comments/19309268","id":19309268,"diff_hunk":"@@ -0,0 +1,146 @@\n+class SafeConnectParams","path":"lib/ffi-vix_disk_lib/safe_connect_params.rb","position":1,"original_position":1,"commit_id":"878ec2314bbb76bef121f902493f40b264f34774","original_commit_id":"878ec2314bbb76bef121f902493f40b264f34774","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=2","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"Same on namespacing.","created_at":"2014-10-23T21:29:58Z","updated_at":"2014-10-23T21:29:58Z","html_url":"https://github.com/ManageIQ/ffi-vix_disk_lib/pull/1#discussion_r19309268","pull_request_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/comments/19309268"},"html":{"href":"https://github.com/ManageIQ/ffi-vix_disk_lib/pull/1#discussion_r19309268"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/1","id":23257344,"html_url":"https://github.com/ManageIQ/ffi-vix_disk_lib/pull/1","diff_url":"https://github.com/ManageIQ/ffi-vix_disk_lib/pull/1.diff","patch_url":"https://github.com/ManageIQ/ffi-vix_disk_lib/pull/1.patch","issue_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/issues/1","number":1,"state":"open","locked":false,"title":"Peer Review Comments from Initial Gem Version","user":{"login":"jerryk55","id":6118503,"avatar_url":"https://avatars.githubusercontent.com/u/6118503?v=2","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"body":"Add changes to initial gem version from peer review.\r\nIncludes standard ruby/gem conventions among other changes.\r\n\r\nRemoving miq_wrapper from gem at this point reducing complexity\r\nof remaining interfaces.","created_at":"2014-10-23T20:34:55Z","updated_at":"2014-10-23T21:29:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fe230550473182451d0055a60988adf6c71c0d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/issues/1/comments","statuses_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/statuses/878ec2314bbb76bef121f902493f40b264f34774","head":{"label":"jerryk55:standard_gem_changes","ref":"standard_gem_changes","sha":"878ec2314bbb76bef121f902493f40b264f34774","user":{"login":"jerryk55","id":6118503,"avatar_url":"https://avatars.githubusercontent.com/u/6118503?v=2","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"repo":{"id":25548427,"name":"ffi-vix_disk_lib","full_name":"jerryk55/ffi-vix_disk_lib","owner":{"login":"jerryk55","id":6118503,"avatar_url":"https://avatars.githubusercontent.com/u/6118503?v=2","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerryk55/ffi-vix_disk_lib","description":"Ruby FFI Binding to VMware VixDiskLib with raw api, data structure handling, and ManageIQ API layers.","fork":true,"url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib","forks_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/forks","keys_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/teams","hooks_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/hooks","issue_events_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/issues/events{/number}","events_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/events","assignees_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/assignees{/user}","branches_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/branches{/branch}","tags_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/tags","blobs_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/languages","stargazers_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/stargazers","contributors_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/contributors","subscribers_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/subscribers","subscription_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/subscription","commits_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/contents/{+path}","compare_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/merges","archive_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/downloads","issues_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/issues{/number}","pulls_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/labels{/name}","releases_url":"https://api.github.com/repos/jerryk55/ffi-vix_disk_lib/releases{/id}","created_at":"2014-10-21T22:02:12Z","updated_at":"2014-10-21T20:14:24Z","pushed_at":"2014-10-23T20:33:58Z","git_url":"git://github.com/jerryk55/ffi-vix_disk_lib.git","ssh_url":"git@github.com:jerryk55/ffi-vix_disk_lib.git","clone_url":"https://github.com/jerryk55/ffi-vix_disk_lib.git","svn_url":"https://github.com/jerryk55/ffi-vix_disk_lib","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"7e8526ccb7f9ba652c37798aafc22c5b10f5976f","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":25218758,"name":"ffi-vix_disk_lib","full_name":"ManageIQ/ffi-vix_disk_lib","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/ffi-vix_disk_lib","description":"Ruby FFI Binding to VMware VixDiskLib with raw api, data structure handling, and ManageIQ API layers.","fork":false,"url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib","forks_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/forks","keys_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/teams","hooks_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/events","assignees_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/tags","blobs_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/subscription","commits_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/merges","archive_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/downloads","issues_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/releases{/id}","created_at":"2014-10-14T17:44:47Z","updated_at":"2014-10-21T20:14:24Z","pushed_at":"2014-10-14T19:52:30Z","git_url":"git://github.com/ManageIQ/ffi-vix_disk_lib.git","ssh_url":"git@github.com:ManageIQ/ffi-vix_disk_lib.git","clone_url":"https://github.com/ManageIQ/ffi-vix_disk_lib.git","svn_url":"https://github.com/ManageIQ/ffi-vix_disk_lib","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/1"},"html":{"href":"https://github.com/ManageIQ/ffi-vix_disk_lib/pull/1"},"issue":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/issues/1"},"comments":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/ffi-vix_disk_lib/statuses/878ec2314bbb76bef121f902493f40b264f34774"}}}}