GitHub PullRequestReviewCommentEvent at 2014-10-31 05:11:19
Repository: Baystation12
Actor: Iamgoofball
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/19652360","id":19652360,"diff_hunk":"@@ -222,4 +310,93 @@\n \treturn\r\n \r\n /mob/living/carbon/human/proc/afterattack(atom/target as mob|obj|turf|area, mob/living/user as mob|obj, inrange, params)\r\n-\treturn\n\\ No newline at end of file\n+\treturn\r\n+\r\n+/mob/living/carbon/human/proc/attack_message(mob/living/carbon/human/M as mob, zone, damage)\r\n+\tvar/skill = M.skills[\"combat\"]\r","path":"code/modules/mob/living/carbon/human/human_attackhand.dm","position":152,"original_position":152,"commit_id":"025a05b32c1c9963f18574839c98cfc34c09a33a","original_commit_id":"025a05b32c1c9963f18574839c98cfc34c09a33a","user":{"login":"Iamgoofball","id":4081722,"avatar_url":"https://avatars.githubusercontent.com/u/4081722?v=2","gravatar_id":"","url":"https://api.github.com/users/Iamgoofball","html_url":"https://github.com/Iamgoofball","followers_url":"https://api.github.com/users/Iamgoofball/followers","following_url":"https://api.github.com/users/Iamgoofball/following{/other_user}","gists_url":"https://api.github.com/users/Iamgoofball/gists{/gist_id}","starred_url":"https://api.github.com/users/Iamgoofball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iamgoofball/subscriptions","organizations_url":"https://api.github.com/users/Iamgoofball/orgs","repos_url":"https://api.github.com/users/Iamgoofball/repos","events_url":"https://api.github.com/users/Iamgoofball/events{/privacy}","received_events_url":"https://api.github.com/users/Iamgoofball/received_events","type":"User","site_admin":false},"body":"Remove this shit, skills is horrible and should be removed in the first place.","created_at":"2014-10-31T05:11:19Z","updated_at":"2014-10-31T05:11:19Z","html_url":"https://github.com/Baystation12/Baystation12/pull/6896#discussion_r19652360","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/6896","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/19652360"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/6896#discussion_r19652360"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/6896"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/6896","id":23638811,"html_url":"https://github.com/Baystation12/Baystation12/pull/6896","diff_url":"https://github.com/Baystation12/Baystation12/pull/6896.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/6896.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/6896","number":6896,"state":"open","locked":false,"title":"Context-based Combat Part 1","user":{"login":"Hubblenaut","id":6383576,"avatar_url":"https://avatars.githubusercontent.com/u/6383576?v=2","gravatar_id":"","url":"https://api.github.com/users/Hubblenaut","html_url":"https://github.com/Hubblenaut","followers_url":"https://api.github.com/users/Hubblenaut/followers","following_url":"https://api.github.com/users/Hubblenaut/following{/other_user}","gists_url":"https://api.github.com/users/Hubblenaut/gists{/gist_id}","starred_url":"https://api.github.com/users/Hubblenaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hubblenaut/subscriptions","organizations_url":"https://api.github.com/users/Hubblenaut/orgs","repos_url":"https://api.github.com/users/Hubblenaut/repos","events_url":"https://api.github.com/users/Hubblenaut/events{/privacy}","received_events_url":"https://api.github.com/users/Hubblenaut/received_events","type":"User","site_admin":false},"body":"### Context-based Combat: Part 1 (Unarmed Melee, harm intent)\r\nThe first part of a larger combat overhaul that focuses on more descriptive, narrative logs during combat, more interesting fights and decrease of RNG's influence on combat.\r\nFor more information on the general concept see the [forum page](http://baystation12.net/forums/viewtopic.php?f=5&t=11448).\r\n - [x] Attack logs based on\r\n  - [x] damage received,\r\n  - [x] organ hit,\r\n  - [x] species,\r\n  - [x] combat skill\r\n  - [x] position.\r\n - [x] Magboot stomps: A stomp that can be carried out on a lying person with active boots. Takes two seconds to prepare and deals 20 to 30 points of damage.\r\n - [x] Missing a hit has been subdivided into dodging and blocking, each with their own requirements that must be met.\r\n - [x] Landing a strong hit against a body part has a chance to cause a short effect, i.e. blurryness for the head, dropping an item for arms and hands, getting pushed backward for the chest, getting additional halloss for crotch, legs and feet.\r\n - [x] Target organ is no longer always random. If the victim is unable to move or on help intent, melee punches will hit where the assailant targets.\r\n - [x] Ninjas and Changelings get a similar melee bonus as the one tajaran and unathi get.\r\n - [x] Punching somebody that is on the ground will be displayed in kicks\r\n - [x] Commented, organised code as well as a proc only for attack messages for easy addition and edits.\r\n - [x] Logs, logs, logs, about thirty to fourty diverse messages that pop up on hits and their effects.","created_at":"2014-10-30T21:08:06Z","updated_at":"2014-10-31T05:11:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f78f4bb10debff73296702271da0bc351a7c685","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/6896/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/6896/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/6896/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/025a05b32c1c9963f18574839c98cfc34c09a33a","head":{"label":"Hubblenaut:dev","ref":"dev","sha":"025a05b32c1c9963f18574839c98cfc34c09a33a","user":{"login":"Hubblenaut","id":6383576,"avatar_url":"https://avatars.githubusercontent.com/u/6383576?v=2","gravatar_id":"","url":"https://api.github.com/users/Hubblenaut","html_url":"https://github.com/Hubblenaut","followers_url":"https://api.github.com/users/Hubblenaut/followers","following_url":"https://api.github.com/users/Hubblenaut/following{/other_user}","gists_url":"https://api.github.com/users/Hubblenaut/gists{/gist_id}","starred_url":"https://api.github.com/users/Hubblenaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hubblenaut/subscriptions","organizations_url":"https://api.github.com/users/Hubblenaut/orgs","repos_url":"https://api.github.com/users/Hubblenaut/repos","events_url":"https://api.github.com/users/Hubblenaut/events{/privacy}","received_events_url":"https://api.github.com/users/Hubblenaut/received_events","type":"User","site_admin":false},"repo":{"id":19297757,"name":"Baystation12","full_name":"Hubblenaut/Baystation12","owner":{"login":"Hubblenaut","id":6383576,"avatar_url":"https://avatars.githubusercontent.com/u/6383576?v=2","gravatar_id":"","url":"https://api.github.com/users/Hubblenaut","html_url":"https://github.com/Hubblenaut","followers_url":"https://api.github.com/users/Hubblenaut/followers","following_url":"https://api.github.com/users/Hubblenaut/following{/other_user}","gists_url":"https://api.github.com/users/Hubblenaut/gists{/gist_id}","starred_url":"https://api.github.com/users/Hubblenaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hubblenaut/subscriptions","organizations_url":"https://api.github.com/users/Hubblenaut/orgs","repos_url":"https://api.github.com/users/Hubblenaut/repos","events_url":"https://api.github.com/users/Hubblenaut/events{/privacy}","received_events_url":"https://api.github.com/users/Hubblenaut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hubblenaut/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/Hubblenaut/Baystation12","forks_url":"https://api.github.com/repos/Hubblenaut/Baystation12/forks","keys_url":"https://api.github.com/repos/Hubblenaut/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hubblenaut/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hubblenaut/Baystation12/teams","hooks_url":"https://api.github.com/repos/Hubblenaut/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Hubblenaut/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Hubblenaut/Baystation12/events","assignees_url":"https://api.github.com/repos/Hubblenaut/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Hubblenaut/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Hubblenaut/Baystation12/tags","blobs_url":"https://api.github.com/repos/Hubblenaut/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hubblenaut/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hubblenaut/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hubblenaut/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hubblenaut/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Hubblenaut/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Hubblenaut/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Hubblenaut/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Hubblenaut/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Hubblenaut/Baystation12/subscription","commits_url":"https://api.github.com/repos/Hubblenaut/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hubblenaut/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hubblenaut/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hubblenaut/Baystation12/issues/comments/{number}","contents_url":"https://api.github.com/repos/Hubblenaut/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Hubblenaut/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hubblenaut/Baystation12/merges","archive_url":"https://api.github.com/repos/Hubblenaut/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hubblenaut/Baystation12/downloads","issues_url":"https://api.github.com/repos/Hubblenaut/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Hubblenaut/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Hubblenaut/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Hubblenaut/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hubblenaut/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Hubblenaut/Baystation12/releases{/id}","created_at":"2014-04-30T01:56:30Z","updated_at":"2014-07-02T08:18:08Z","pushed_at":"2014-10-30T19:22:22Z","git_url":"git://github.com/Hubblenaut/Baystation12.git","ssh_url":"git@github.com:Hubblenaut/Baystation12.git","clone_url":"https://github.com/Hubblenaut/Baystation12.git","svn_url":"https://github.com/Hubblenaut/Baystation12","homepage":"http://baystation12.net/","size":509868,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"5404a180455f38a1ffd10aa0e02334b2dfe96206","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=2","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=2","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments/{number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","created_at":"2011-11-05T16:12:41Z","updated_at":"2014-10-16T08:54:05Z","pushed_at":"2014-10-30T21:50:09Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":921217,"stargazers_count":156,"watchers_count":156,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":590,"mirror_url":null,"open_issues_count":129,"forks":590,"open_issues":129,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/6896"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/6896"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/6896"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/6896/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/6896/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/6896/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/025a05b32c1c9963f18574839c98cfc34c09a33a"}}}}