GitHub PullRequestReviewCommentEvent at 2014-07-23 21:40:54
Repository: libcontainer
Actor: crosbymichael
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/comments/15317906","id":15317906,"diff_hunk":"@@ -6,6 +6,6 @@ import (\n )\n \n type ContainerStats struct {\n-\tNetworkStats network.NetworkStats `json:\"network_stats, omitempty\"`\n-\tCgroupStats  *cgroups.Stats       `json:\"cgroup_stats, omitempty\"`\n+\tNetworkStats *network.NetworkStats `json:\"network_stats, omitempty\"`","path":"types.go","position":6,"original_position":6,"commit_id":"8cfe3dee0a2e545ffd11e325bb3ee5c732a2b60d","original_commit_id":"8cfe3dee0a2e545ffd11e325bb3ee5c732a2b60d","user":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?","gravatar_id":"52c79a86e4d1322820e510aabea05a32","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"body":"I don't think there should be a space before the `omitempty`","created_at":"2014-07-23T21:40:54Z","updated_at":"2014-07-23T21:40:54Z","html_url":"https://github.com/docker/libcontainer/pull/119#discussion_r15317906","pull_request_url":"https://api.github.com/repos/docker/libcontainer/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments/15317906"},"html":{"href":"https://github.com/docker/libcontainer/pull/119#discussion_r15317906"},"pull_request":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/119","id":18804964,"html_url":"https://github.com/docker/libcontainer/pull/119","diff_url":"https://github.com/docker/libcontainer/pull/119.diff","patch_url":"https://github.com/docker/libcontainer/pull/119.patch","issue_url":"https://api.github.com/repos/docker/libcontainer/issues/119","number":119,"state":"open","title":"Minor fixes to network stats","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?","gravatar_id":"decde34735ba246594ad6a755becfbf2","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-23T21:38:43Z","updated_at":"2014-07-23T21:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d363760974f953ccd8230de7ea2f2934ab513a45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libcontainer/pulls/119/commits","review_comments_url":"https://api.github.com/repos/docker/libcontainer/pulls/119/comments","review_comment_url":"https://api.github.com/repos/docker/libcontainer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/libcontainer/issues/119/comments","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/8cfe3dee0a2e545ffd11e325bb3ee5c732a2b60d","head":{"label":"vishh:fix_network_stats","ref":"fix_network_stats","sha":"8cfe3dee0a2e545ffd11e325bb3ee5c732a2b60d","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?","gravatar_id":"decde34735ba246594ad6a755becfbf2","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"repo":{"id":20693054,"name":"libcontainer","full_name":"vishh/libcontainer","owner":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?","gravatar_id":"decde34735ba246594ad6a755becfbf2","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vishh/libcontainer","description":"Containers","fork":true,"url":"https://api.github.com/repos/vishh/libcontainer","forks_url":"https://api.github.com/repos/vishh/libcontainer/forks","keys_url":"https://api.github.com/repos/vishh/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vishh/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vishh/libcontainer/teams","hooks_url":"https://api.github.com/repos/vishh/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/vishh/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/vishh/libcontainer/events","assignees_url":"https://api.github.com/repos/vishh/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/vishh/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/vishh/libcontainer/tags","blobs_url":"https://api.github.com/repos/vishh/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vishh/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vishh/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/vishh/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vishh/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/vishh/libcontainer/languages","stargazers_url":"https://api.github.com/repos/vishh/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/vishh/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/vishh/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/vishh/libcontainer/subscription","commits_url":"https://api.github.com/repos/vishh/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/vishh/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/vishh/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/vishh/libcontainer/issues/comments/{number}","contents_url":"https://api.github.com/repos/vishh/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/vishh/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vishh/libcontainer/merges","archive_url":"https://api.github.com/repos/vishh/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vishh/libcontainer/downloads","issues_url":"https://api.github.com/repos/vishh/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/vishh/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/vishh/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/vishh/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vishh/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/vishh/libcontainer/releases{/id}","created_at":"2014-06-10T16:36:42Z","updated_at":"2014-06-25T19:18:00Z","pushed_at":"2014-07-23T21:35:58Z","git_url":"git://github.com/vishh/libcontainer.git","ssh_url":"git@github.com:vishh/libcontainer.git","clone_url":"https://github.com/vishh/libcontainer.git","svn_url":"https://github.com/vishh/libcontainer","homepage":"https://docker.com","size":1125,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"5d39cecc5f354090ed24457cc590dfba98f702e7","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?","gravatar_id":null,"url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":15693680,"name":"libcontainer","full_name":"docker/libcontainer","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?","gravatar_id":null,"url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libcontainer","description":"Linux Containers","fork":false,"url":"https://api.github.com/repos/docker/libcontainer","forks_url":"https://api.github.com/repos/docker/libcontainer/forks","keys_url":"https://api.github.com/repos/docker/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libcontainer/teams","hooks_url":"https://api.github.com/repos/docker/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/docker/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libcontainer/events","assignees_url":"https://api.github.com/repos/docker/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libcontainer/tags","blobs_url":"https://api.github.com/repos/docker/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libcontainer/languages","stargazers_url":"https://api.github.com/repos/docker/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/docker/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/docker/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/docker/libcontainer/subscription","commits_url":"https://api.github.com/repos/docker/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libcontainer/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libcontainer/merges","archive_url":"https://api.github.com/repos/docker/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libcontainer/downloads","issues_url":"https://api.github.com/repos/docker/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/docker/libcontainer/releases{/id}","created_at":"2014-01-07T03:05:05Z","updated_at":"2014-07-23T21:25:01Z","pushed_at":"2014-07-23T20:56:28Z","git_url":"git://github.com/docker/libcontainer.git","ssh_url":"git@github.com:docker/libcontainer.git","clone_url":"https://github.com/docker/libcontainer.git","svn_url":"https://github.com/docker/libcontainer","homepage":"http://www.docker.com/","size":2735,"stargazers_count":378,"watchers_count":378,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":61,"mirror_url":null,"open_issues_count":21,"forks":61,"open_issues":21,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/119"},"html":{"href":"https://github.com/docker/libcontainer/pull/119"},"issue":{"href":"https://api.github.com/repos/docker/libcontainer/issues/119"},"comments":{"href":"https://api.github.com/repos/docker/libcontainer/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libcontainer/statuses/8cfe3dee0a2e545ffd11e325bb3ee5c732a2b60d"}}}}