GitHub PullRequestReviewCommentEvent at 2014-08-04 08:27:42
Repository: fiware-orion-pep
Actor: fgalan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/comments/15744900","id":15744900,"diff_hunk":"@@ -23,6 +23,31 @@\n \n 'use strict';\n \n+function inspectBody(body) {\n+    if (body && body.updateAction) {\n+        var action;\n+\n+        switch(body.updateAction) {","path":"lib/services/orionPlugin.js","position":8,"original_position":8,"commit_id":"7545c3446c9bba42f97f55aded1b322261ec579f","original_commit_id":"7545c3446c9bba42f97f55aded1b322261ec579f","user":{"login":"fgalan","id":1534240,"avatar_url":"https://avatars.githubusercontent.com/u/1534240?v=1","gravatar_id":"1936b0d16210811a2aa8de96295f0693","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"body":"Although NGSI specifies APPEND, UPDATE, DELETE should be in uppercase, Orion doesn't pay attention to case, so probably the PEP proxy should behave the same.\r\n\r\nIn mean, to use `switch(uppercase(body.updateAction))` or similar (not sure about the JavaScript method for uppercasing).","created_at":"2014-08-04T08:27:42Z","updated_at":"2014-08-04T08:27:42Z","html_url":"https://github.com/telefonicaid/fiware-orion-pep/pull/1#discussion_r15744900","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/comments/15744900"},"html":{"href":"https://github.com/telefonicaid/fiware-orion-pep/pull/1#discussion_r15744900"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/1","id":19268750,"html_url":"https://github.com/telefonicaid/fiware-orion-pep/pull/1","diff_url":"https://github.com/telefonicaid/fiware-orion-pep/pull/1.diff","patch_url":"https://github.com/telefonicaid/fiware-orion-pep/pull/1.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues/1","number":1,"state":"open","title":"Task/iotcore 101 check action inside json","user":{"login":"dmoranj","id":1152892,"avatar_url":"https://avatars.githubusercontent.com/u/1152892?v=1","gravatar_id":"dbed55c512d9a31178de8e877815c2b6","url":"https://api.github.com/users/dmoranj","html_url":"https://github.com/dmoranj","followers_url":"https://api.github.com/users/dmoranj/followers","following_url":"https://api.github.com/users/dmoranj/following{/other_user}","gists_url":"https://api.github.com/users/dmoranj/gists{/gist_id}","starred_url":"https://api.github.com/users/dmoranj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmoranj/subscriptions","organizations_url":"https://api.github.com/users/dmoranj/orgs","repos_url":"https://api.github.com/users/dmoranj/repos","events_url":"https://api.github.com/users/dmoranj/events{/privacy}","received_events_url":"https://api.github.com/users/dmoranj/received_events","type":"User","site_admin":false},"body":"Changed the proxy technology (http-proxy is not meant to snoop the request body, so I replaced it with Express+requesT).\r\n\r\nAdded extraction of type of action from the JSON Body.","created_at":"2014-08-04T07:47:07Z","updated_at":"2014-08-04T08:27:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"225812407f10df1fcea527328eba20fef203d665","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/1/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/1/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/comments/{number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues/1/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/statuses/7545c3446c9bba42f97f55aded1b322261ec579f","head":{"label":"telefonicaid:task/IOTCORE-101_Check_Action_Inside_JSON","ref":"task/IOTCORE-101_Check_Action_Inside_JSON","sha":"7545c3446c9bba42f97f55aded1b322261ec579f","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=1","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":22461729,"name":"fiware-orion-pep","full_name":"telefonicaid/fiware-orion-pep","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=1","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-orion-pep","description":"PEP Proxy for Orion Context broker","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep","forks_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues/comments/{number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/releases{/id}","created_at":"2014-07-31T08:14:19Z","updated_at":"2014-08-01T14:13:54Z","pushed_at":"2014-08-04T07:58:14Z","git_url":"git://github.com/telefonicaid/fiware-orion-pep.git","ssh_url":"git@github.com:telefonicaid/fiware-orion-pep.git","clone_url":"https://github.com/telefonicaid/fiware-orion-pep.git","svn_url":"https://github.com/telefonicaid/fiware-orion-pep","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"telefonicaid:develop","ref":"develop","sha":"b212ebff4a0cf16f6867969b3141a79dadfe877d","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=1","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":22461729,"name":"fiware-orion-pep","full_name":"telefonicaid/fiware-orion-pep","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=1","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-orion-pep","description":"PEP Proxy for Orion Context broker","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep","forks_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues/comments/{number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/releases{/id}","created_at":"2014-07-31T08:14:19Z","updated_at":"2014-08-01T14:13:54Z","pushed_at":"2014-08-04T07:58:14Z","git_url":"git://github.com/telefonicaid/fiware-orion-pep.git","ssh_url":"git@github.com:telefonicaid/fiware-orion-pep.git","clone_url":"https://github.com/telefonicaid/fiware-orion-pep.git","svn_url":"https://github.com/telefonicaid/fiware-orion-pep","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/1"},"html":{"href":"https://github.com/telefonicaid/fiware-orion-pep/pull/1"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues/1"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion-pep/statuses/7545c3446c9bba42f97f55aded1b322261ec579f"}}}}