GitHub PullRequestReviewCommentEvent at 2014-11-04 15:26:03
Repository: pim-community-dev
Actor: jjanvier
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/19809286","id":19809286,"diff_hunk":"@@ -30,31 +31,39 @@ class ProductImportValidator extends ImportValidator\n     /**\n      * @var array\n      */\n-    protected $constraints = array();\n+    protected $constraints = [];\n \n     /**\n      * @var array\n      */\n-    protected $uniqueValues = array();\n+    protected $uniqueValues = [];\n+\n+    /**\n+     * @var ProductManager\n+     */\n+    protected $productManager;\n \n     /**\n      * Constructor\n      *\n-     * @param ValidatorInterface         $validator\n+     * @param ValidatorInterface $validator\n      * @param ConstraintGuesserInterface $constraintGuesser\n+     * @param ProductManager $productManager","path":"src/Pim/Bundle/BaseConnectorBundle/Validator/Import/ProductImportValidator.php","position":32,"original_position":32,"commit_id":"e6f0ac9d9ed7de884936c08d10788dbdf9387964","original_commit_id":"a869e746e762edf42b7bbb117834b4004f39ceb6","user":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars.githubusercontent.com/u/3691804?v=2","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"body":"cs fix","created_at":"2014-11-04T15:26:03Z","updated_at":"2014-11-04T15:26:03Z","html_url":"https://github.com/akeneo/pim-community-dev/pull/1727#discussion_r19809286","pull_request_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/1727","_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/19809286"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/1727#discussion_r19809286"},"pull_request":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/1727"}}},"pull_request":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/1727","id":23687044,"html_url":"https://github.com/akeneo/pim-community-dev/pull/1727","diff_url":"https://github.com/akeneo/pim-community-dev/pull/1727.diff","patch_url":"https://github.com/akeneo/pim-community-dev/pull/1727.patch","issue_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/1727","number":1727,"state":"open","locked":false,"title":"[WIP] PIM-3309: Fix check on product unicity","user":{"login":"solivier","id":7210255,"avatar_url":"https://avatars.githubusercontent.com/u/7210255?v=2","gravatar_id":"","url":"https://api.github.com/users/solivier","html_url":"https://github.com/solivier","followers_url":"https://api.github.com/users/solivier/followers","following_url":"https://api.github.com/users/solivier/following{/other_user}","gists_url":"https://api.github.com/users/solivier/gists{/gist_id}","starred_url":"https://api.github.com/users/solivier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solivier/subscriptions","organizations_url":"https://api.github.com/users/solivier/orgs","repos_url":"https://api.github.com/users/solivier/repos","events_url":"https://api.github.com/users/solivier/events{/privacy}","received_events_url":"https://api.github.com/users/solivier/received_events","type":"User","site_admin":false},"body":"This PR fix the issue #1657\r\n\r\n| Q                    | A\r\n| -------------------- | ---\r\n| Bug fix?             | Yes\r\n| New feature?         | No\r\n| BC breaks?           | No\r\n| CI currently passes? | Yes\r\n| Tests pass?          | Yes\r\n| Scenarios pass?      | Yes\r\n| Checkstyle issues?*  | No\r\n| PMD issues?**        | No\r\n| Changelog updated?   | Yes\r\n| Fixed tickets        | PIM-3309\r\n| Doc PR               | No","created_at":"2014-10-31T16:10:45Z","updated_at":"2014-11-04T15:26:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f38708b086f441aea55f21841cf34adac59f3ad4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/1727/commits","review_comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/1727/comments","review_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/{number}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/1727/comments","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/e6f0ac9d9ed7de884936c08d10788dbdf9387964","head":{"label":"akeneo:PIM-3309","ref":"PIM-3309","sha":"e6f0ac9d9ed7de884936c08d10788dbdf9387964","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=2","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=2","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"Akeneo PIM development repository","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments/{number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","created_at":"2012-08-10T09:27:26Z","updated_at":"2014-10-31T22:44:39Z","pushed_at":"2014-11-04T15:22:06Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://akeneo.com","size":175467,"stargazers_count":177,"watchers_count":177,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":40,"forks":70,"open_issues":40,"watchers":177,"default_branch":"master"}},"base":{"label":"akeneo:1.2","ref":"1.2","sha":"8b4dffe7f36b4cfeb53ccbd129a11a2046872b42","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=2","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=2","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"Akeneo PIM development repository","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments/{number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","created_at":"2012-08-10T09:27:26Z","updated_at":"2014-10-31T22:44:39Z","pushed_at":"2014-11-04T15:22:06Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://akeneo.com","size":175467,"stargazers_count":177,"watchers_count":177,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":40,"forks":70,"open_issues":40,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/1727"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/1727"},"issue":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/1727"},"comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/1727/comments"},"review_comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/1727/comments"},"review_comment":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/1727/commits"},"statuses":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/e6f0ac9d9ed7de884936c08d10788dbdf9387964"}}}}