GitHub PullRequestReviewCommentEvent at 2014-07-29 05:39:18
Repository: mindmeld-js-sdk
Actor: jagill
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/comments/15506775","id":15506775,"diff_hunk":"@@ -0,0 +1,48 @@\n+#! /usr/bin/env bash\n+set -x # use + to only \"echo\" results on console (ie turn debugging off)\n+set -e # exit if there are any errors at all (perfect build or none at all).\n+\n+SCRIPT_DIR=`dirname $0`\n+\n+#CIRCLE_PROJECT_USERNAME The username or organization name of the project being tested, i.e. \"expectlabs\"\n+#CIRCLE_PROJECT_REPONAME The repository name of the project being tested, i.e. \"crawler\" in circleci.com/gh/expectlabs/crawler/123","path":"deployScripts/deploy_artifact.sh","position":8,"original_position":8,"commit_id":"ddf8144162292d17fd6b6ccc0faf551d7ad9504c","original_commit_id":"ddf8144162292d17fd6b6ccc0faf551d7ad9504c","user":{"login":"jagill","id":495664,"avatar_url":"https://avatars.githubusercontent.com/u/495664?","gravatar_id":"dc01fefa18c8b60c70f4add37fc9c3f6","url":"https://api.github.com/users/jagill","html_url":"https://github.com/jagill","followers_url":"https://api.github.com/users/jagill/followers","following_url":"https://api.github.com/users/jagill/following{/other_user}","gists_url":"https://api.github.com/users/jagill/gists{/gist_id}","starred_url":"https://api.github.com/users/jagill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagill/subscriptions","organizations_url":"https://api.github.com/users/jagill/orgs","repos_url":"https://api.github.com/users/jagill/repos","events_url":"https://api.github.com/users/jagill/events{/privacy}","received_events_url":"https://api.github.com/users/jagill/received_events","type":"User","site_admin":false},"body":"Fair point.  Access is only granted to those who have GH privileges, but this file also has some other internals that we should discuss.","created_at":"2014-07-29T05:39:18Z","updated_at":"2014-07-29T05:39:18Z","html_url":"https://github.com/expectlabs/mindmeld-js-sdk/pull/8#discussion_r15506775","pull_request_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/comments/15506775"},"html":{"href":"https://github.com/expectlabs/mindmeld-js-sdk/pull/8#discussion_r15506775"},"pull_request":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/8","id":18916649,"html_url":"https://github.com/expectlabs/mindmeld-js-sdk/pull/8","diff_url":"https://github.com/expectlabs/mindmeld-js-sdk/pull/8.diff","patch_url":"https://github.com/expectlabs/mindmeld-js-sdk/pull/8.patch","issue_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues/8","number":8,"state":"open","title":"Feature/testing","user":{"login":"jagill","id":495664,"avatar_url":"https://avatars.githubusercontent.com/u/495664?","gravatar_id":"dc01fefa18c8b60c70f4add37fc9c3f6","url":"https://api.github.com/users/jagill","html_url":"https://github.com/jagill","followers_url":"https://api.github.com/users/jagill/followers","following_url":"https://api.github.com/users/jagill/following{/other_user}","gists_url":"https://api.github.com/users/jagill/gists{/gist_id}","starred_url":"https://api.github.com/users/jagill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagill/subscriptions","organizations_url":"https://api.github.com/users/jagill/orgs","repos_url":"https://api.github.com/users/jagill/repos","events_url":"https://api.github.com/users/jagill/events{/privacy}","received_events_url":"https://api.github.com/users/jagill/received_events","type":"User","site_admin":false},"body":"@jjackson26 @swarajban Take a look.\r\n\r\nThis, unfortunately, spiraled a little out of control.  This PR has both some unit tests, the circle build, and removing jquery from the sdk (still need to reflect this in the docs).  It has only a few unit tests, but the main work was in the infrastructure setup.  It now passes circleCI builds.  Might have to sit down together to talk over some of the bits.","created_at":"2014-07-25T20:13:24Z","updated_at":"2014-07-29T05:39:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdfb13bdd9038b3fd614a1723645efc766f75e73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/8/commits","review_comments_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/8/comments","review_comment_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues/8/comments","statuses_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/statuses/ddf8144162292d17fd6b6ccc0faf551d7ad9504c","head":{"label":"expectlabs:feature/testing","ref":"feature/testing","sha":"ddf8144162292d17fd6b6ccc0faf551d7ad9504c","user":{"login":"expectlabs","id":872709,"avatar_url":"https://avatars.githubusercontent.com/u/872709?","gravatar_id":"b94b34a3f18374467bdcee0ecdb4b4ac","url":"https://api.github.com/users/expectlabs","html_url":"https://github.com/expectlabs","followers_url":"https://api.github.com/users/expectlabs/followers","following_url":"https://api.github.com/users/expectlabs/following{/other_user}","gists_url":"https://api.github.com/users/expectlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/expectlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expectlabs/subscriptions","organizations_url":"https://api.github.com/users/expectlabs/orgs","repos_url":"https://api.github.com/users/expectlabs/repos","events_url":"https://api.github.com/users/expectlabs/events{/privacy}","received_events_url":"https://api.github.com/users/expectlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":18074343,"name":"mindmeld-js-sdk","full_name":"expectlabs/mindmeld-js-sdk","owner":{"login":"expectlabs","id":872709,"avatar_url":"https://avatars.githubusercontent.com/u/872709?","gravatar_id":"b94b34a3f18374467bdcee0ecdb4b4ac","url":"https://api.github.com/users/expectlabs","html_url":"https://github.com/expectlabs","followers_url":"https://api.github.com/users/expectlabs/followers","following_url":"https://api.github.com/users/expectlabs/following{/other_user}","gists_url":"https://api.github.com/users/expectlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/expectlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expectlabs/subscriptions","organizations_url":"https://api.github.com/users/expectlabs/orgs","repos_url":"https://api.github.com/users/expectlabs/repos","events_url":"https://api.github.com/users/expectlabs/events{/privacy}","received_events_url":"https://api.github.com/users/expectlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/expectlabs/mindmeld-js-sdk","description":"This repository holds the bower package for the Expect Labs MindMeld JavaScript SDK, mindmeld-2.0.js","fork":false,"url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk","forks_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/forks","keys_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/teams","hooks_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/events","assignees_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/tags","blobs_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/languages","stargazers_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/subscription","commits_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/merges","archive_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/downloads","issues_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/releases{/id}","created_at":"2014-03-24T18:51:14Z","updated_at":"2014-07-28T17:43:12Z","pushed_at":"2014-07-28T22:45:10Z","git_url":"git://github.com/expectlabs/mindmeld-js-sdk.git","ssh_url":"git@github.com:expectlabs/mindmeld-js-sdk.git","clone_url":"https://github.com/expectlabs/mindmeld-js-sdk.git","svn_url":"https://github.com/expectlabs/mindmeld-js-sdk","homepage":null,"size":25635,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":7,"default_branch":"develop"}},"base":{"label":"expectlabs:develop","ref":"develop","sha":"0c1d73e53c4ab263e42b8e0f4ef044593c1cfcf3","user":{"login":"expectlabs","id":872709,"avatar_url":"https://avatars.githubusercontent.com/u/872709?","gravatar_id":"b94b34a3f18374467bdcee0ecdb4b4ac","url":"https://api.github.com/users/expectlabs","html_url":"https://github.com/expectlabs","followers_url":"https://api.github.com/users/expectlabs/followers","following_url":"https://api.github.com/users/expectlabs/following{/other_user}","gists_url":"https://api.github.com/users/expectlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/expectlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expectlabs/subscriptions","organizations_url":"https://api.github.com/users/expectlabs/orgs","repos_url":"https://api.github.com/users/expectlabs/repos","events_url":"https://api.github.com/users/expectlabs/events{/privacy}","received_events_url":"https://api.github.com/users/expectlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":18074343,"name":"mindmeld-js-sdk","full_name":"expectlabs/mindmeld-js-sdk","owner":{"login":"expectlabs","id":872709,"avatar_url":"https://avatars.githubusercontent.com/u/872709?","gravatar_id":"b94b34a3f18374467bdcee0ecdb4b4ac","url":"https://api.github.com/users/expectlabs","html_url":"https://github.com/expectlabs","followers_url":"https://api.github.com/users/expectlabs/followers","following_url":"https://api.github.com/users/expectlabs/following{/other_user}","gists_url":"https://api.github.com/users/expectlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/expectlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expectlabs/subscriptions","organizations_url":"https://api.github.com/users/expectlabs/orgs","repos_url":"https://api.github.com/users/expectlabs/repos","events_url":"https://api.github.com/users/expectlabs/events{/privacy}","received_events_url":"https://api.github.com/users/expectlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/expectlabs/mindmeld-js-sdk","description":"This repository holds the bower package for the Expect Labs MindMeld JavaScript SDK, mindmeld-2.0.js","fork":false,"url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk","forks_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/forks","keys_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/teams","hooks_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/events","assignees_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/tags","blobs_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/languages","stargazers_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/subscription","commits_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/merges","archive_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/downloads","issues_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/releases{/id}","created_at":"2014-03-24T18:51:14Z","updated_at":"2014-07-28T17:43:12Z","pushed_at":"2014-07-28T22:45:10Z","git_url":"git://github.com/expectlabs/mindmeld-js-sdk.git","ssh_url":"git@github.com:expectlabs/mindmeld-js-sdk.git","clone_url":"https://github.com/expectlabs/mindmeld-js-sdk.git","svn_url":"https://github.com/expectlabs/mindmeld-js-sdk","homepage":null,"size":25635,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/8"},"html":{"href":"https://github.com/expectlabs/mindmeld-js-sdk/pull/8"},"issue":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues/8"},"comments":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/expectlabs/mindmeld-js-sdk/statuses/ddf8144162292d17fd6b6ccc0faf551d7ad9504c"}}}}