GitHub PullRequestReviewCommentEvent at 2014-12-17 16:13:13
Repository: erlang.mk
Actor: essen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/comments/21982062","id":21982062,"diff_hunk":"@@ -954,6 +954,74 @@ escript:: distclean-escript deps app\n distclean-escript:\n \t$(gen_verbose) rm -f $(ESCRIPT_NAME)\n \n+# Copyright (c) 2014, Enrique Fernandez <enrique.fernandez@erlang-solutions.com>\n+# This file is contributed to erlang.mk and subject to the terms of the ISC License.\n+\n+.PHONY: help-eunit build-eunit eunit distclean-eunit\n+\n+# Configuration\n+\n+EUNIT_ERLC_OPTS ?= +debug_info +warn_export_vars +warn_shadow_vars +warn_obsolete_guard -DTEST=1 -DEXTRA=1\n+\n+EUNIT_DIR ?=\n+EUNIT_DIRS = $(sort $(EUNIT_DIR) ebin)\n+\n+# All modules in EUNIT_DIR\n+EUNIT_DIR_MODS = $(notdir $(basename $(shell find $(EUNIT_DIR) -name *.beam)))","path":"erlang.mk","position":17,"original_position":17,"commit_id":"820259e87eabdd183e7aac038e4f133a0b441dc0","original_commit_id":"820259e87eabdd183e7aac038e4f133a0b441dc0","user":{"login":"essen","id":141739,"avatar_url":"https://avatars.githubusercontent.com/u/141739?v=3","gravatar_id":"","url":"https://api.github.com/users/essen","html_url":"https://github.com/essen","followers_url":"https://api.github.com/users/essen/followers","following_url":"https://api.github.com/users/essen/following{/other_user}","gists_url":"https://api.github.com/users/essen/gists{/gist_id}","starred_url":"https://api.github.com/users/essen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/essen/subscriptions","organizations_url":"https://api.github.com/users/essen/orgs","repos_url":"https://api.github.com/users/essen/repos","events_url":"https://api.github.com/users/essen/events{/privacy}","received_events_url":"https://api.github.com/users/essen/received_events","type":"User","site_admin":false},"body":"Apparently on OSX/FreeBSD the issue manifests itself differently: https://dpaste.de/rEfz\r\n\r\nBut same deal, when `$(EUNIT_DIR)` is empty, things go bad.","created_at":"2014-12-17T16:13:13Z","updated_at":"2014-12-17T16:13:13Z","html_url":"https://github.com/ninenines/erlang.mk/pull/154#discussion_r21982062","pull_request_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/comments/21982062"},"html":{"href":"https://github.com/ninenines/erlang.mk/pull/154#discussion_r21982062"},"pull_request":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/154","id":23748333,"html_url":"https://github.com/ninenines/erlang.mk/pull/154","diff_url":"https://github.com/ninenines/erlang.mk/pull/154.diff","patch_url":"https://github.com/ninenines/erlang.mk/pull/154.patch","issue_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/154","number":154,"state":"open","locked":false,"title":"EUnit plugin","user":{"login":"efcasado","id":603610,"avatar_url":"https://avatars.githubusercontent.com/u/603610?v=3","gravatar_id":"","url":"https://api.github.com/users/efcasado","html_url":"https://github.com/efcasado","followers_url":"https://api.github.com/users/efcasado/followers","following_url":"https://api.github.com/users/efcasado/following{/other_user}","gists_url":"https://api.github.com/users/efcasado/gists{/gist_id}","starred_url":"https://api.github.com/users/efcasado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efcasado/subscriptions","organizations_url":"https://api.github.com/users/efcasado/orgs","repos_url":"https://api.github.com/users/efcasado/repos","events_url":"https://api.github.com/users/efcasado/events{/privacy}","received_events_url":"https://api.github.com/users/efcasado/received_events","type":"User","site_admin":false},"body":"Running `make tests` will now also run EUnit tests.\r\n\r\nUsers can set different `ERLC` and `EUNIT` options by providing the `EUNIT_ERLC_OPTS` and `EUNIT_OPTS` variables, respectively.","created_at":"2014-11-03T09:01:52Z","updated_at":"2014-12-17T16:13:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"104d400b4ba503f49045bbddfa49a05531c48f3a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/154/commits","review_comments_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/154/comments","review_comment_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/154/comments","statuses_url":"https://api.github.com/repos/ninenines/erlang.mk/statuses/820259e87eabdd183e7aac038e4f133a0b441dc0","head":{"label":"efcasado:eunit","ref":"eunit","sha":"820259e87eabdd183e7aac038e4f133a0b441dc0","user":{"login":"efcasado","id":603610,"avatar_url":"https://avatars.githubusercontent.com/u/603610?v=3","gravatar_id":"","url":"https://api.github.com/users/efcasado","html_url":"https://github.com/efcasado","followers_url":"https://api.github.com/users/efcasado/followers","following_url":"https://api.github.com/users/efcasado/following{/other_user}","gists_url":"https://api.github.com/users/efcasado/gists{/gist_id}","starred_url":"https://api.github.com/users/efcasado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efcasado/subscriptions","organizations_url":"https://api.github.com/users/efcasado/orgs","repos_url":"https://api.github.com/users/efcasado/repos","events_url":"https://api.github.com/users/efcasado/events{/privacy}","received_events_url":"https://api.github.com/users/efcasado/received_events","type":"User","site_admin":false},"repo":{"id":26012864,"name":"erlang.mk","full_name":"efcasado/erlang.mk","owner":{"login":"efcasado","id":603610,"avatar_url":"https://avatars.githubusercontent.com/u/603610?v=3","gravatar_id":"","url":"https://api.github.com/users/efcasado","html_url":"https://github.com/efcasado","followers_url":"https://api.github.com/users/efcasado/followers","following_url":"https://api.github.com/users/efcasado/following{/other_user}","gists_url":"https://api.github.com/users/efcasado/gists{/gist_id}","starred_url":"https://api.github.com/users/efcasado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efcasado/subscriptions","organizations_url":"https://api.github.com/users/efcasado/orgs","repos_url":"https://api.github.com/users/efcasado/repos","events_url":"https://api.github.com/users/efcasado/events{/privacy}","received_events_url":"https://api.github.com/users/efcasado/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/efcasado/erlang.mk","description":"Common GNU Makefile rules for building and testing Erlang applications.","fork":true,"url":"https://api.github.com/repos/efcasado/erlang.mk","forks_url":"https://api.github.com/repos/efcasado/erlang.mk/forks","keys_url":"https://api.github.com/repos/efcasado/erlang.mk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/efcasado/erlang.mk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/efcasado/erlang.mk/teams","hooks_url":"https://api.github.com/repos/efcasado/erlang.mk/hooks","issue_events_url":"https://api.github.com/repos/efcasado/erlang.mk/issues/events{/number}","events_url":"https://api.github.com/repos/efcasado/erlang.mk/events","assignees_url":"https://api.github.com/repos/efcasado/erlang.mk/assignees{/user}","branches_url":"https://api.github.com/repos/efcasado/erlang.mk/branches{/branch}","tags_url":"https://api.github.com/repos/efcasado/erlang.mk/tags","blobs_url":"https://api.github.com/repos/efcasado/erlang.mk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/efcasado/erlang.mk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/efcasado/erlang.mk/git/refs{/sha}","trees_url":"https://api.github.com/repos/efcasado/erlang.mk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/efcasado/erlang.mk/statuses/{sha}","languages_url":"https://api.github.com/repos/efcasado/erlang.mk/languages","stargazers_url":"https://api.github.com/repos/efcasado/erlang.mk/stargazers","contributors_url":"https://api.github.com/repos/efcasado/erlang.mk/contributors","subscribers_url":"https://api.github.com/repos/efcasado/erlang.mk/subscribers","subscription_url":"https://api.github.com/repos/efcasado/erlang.mk/subscription","commits_url":"https://api.github.com/repos/efcasado/erlang.mk/commits{/sha}","git_commits_url":"https://api.github.com/repos/efcasado/erlang.mk/git/commits{/sha}","comments_url":"https://api.github.com/repos/efcasado/erlang.mk/comments{/number}","issue_comment_url":"https://api.github.com/repos/efcasado/erlang.mk/issues/comments/{number}","contents_url":"https://api.github.com/repos/efcasado/erlang.mk/contents/{+path}","compare_url":"https://api.github.com/repos/efcasado/erlang.mk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/efcasado/erlang.mk/merges","archive_url":"https://api.github.com/repos/efcasado/erlang.mk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/efcasado/erlang.mk/downloads","issues_url":"https://api.github.com/repos/efcasado/erlang.mk/issues{/number}","pulls_url":"https://api.github.com/repos/efcasado/erlang.mk/pulls{/number}","milestones_url":"https://api.github.com/repos/efcasado/erlang.mk/milestones{/number}","notifications_url":"https://api.github.com/repos/efcasado/erlang.mk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/efcasado/erlang.mk/labels{/name}","releases_url":"https://api.github.com/repos/efcasado/erlang.mk/releases{/id}","created_at":"2014-10-31T11:04:15Z","updated_at":"2014-12-15T14:23:14Z","pushed_at":"2014-12-17T15:38:55Z","git_url":"git://github.com/efcasado/erlang.mk.git","ssh_url":"git@github.com:efcasado/erlang.mk.git","clone_url":"https://github.com/efcasado/erlang.mk.git","svn_url":"https://github.com/efcasado/erlang.mk","homepage":"http://ninenines.eu","size":331,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ninenines:master","ref":"master","sha":"eaf673b79b5b9b2c1d3478cde7ae1c22dfb07192","user":{"login":"ninenines","id":1166740,"avatar_url":"https://avatars.githubusercontent.com/u/1166740?v=3","gravatar_id":"","url":"https://api.github.com/users/ninenines","html_url":"https://github.com/ninenines","followers_url":"https://api.github.com/users/ninenines/followers","following_url":"https://api.github.com/users/ninenines/following{/other_user}","gists_url":"https://api.github.com/users/ninenines/gists{/gist_id}","starred_url":"https://api.github.com/users/ninenines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninenines/subscriptions","organizations_url":"https://api.github.com/users/ninenines/orgs","repos_url":"https://api.github.com/users/ninenines/repos","events_url":"https://api.github.com/users/ninenines/events{/privacy}","received_events_url":"https://api.github.com/users/ninenines/received_events","type":"Organization","site_admin":false},"repo":{"id":9777075,"name":"erlang.mk","full_name":"ninenines/erlang.mk","owner":{"login":"ninenines","id":1166740,"avatar_url":"https://avatars.githubusercontent.com/u/1166740?v=3","gravatar_id":"","url":"https://api.github.com/users/ninenines","html_url":"https://github.com/ninenines","followers_url":"https://api.github.com/users/ninenines/followers","following_url":"https://api.github.com/users/ninenines/following{/other_user}","gists_url":"https://api.github.com/users/ninenines/gists{/gist_id}","starred_url":"https://api.github.com/users/ninenines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninenines/subscriptions","organizations_url":"https://api.github.com/users/ninenines/orgs","repos_url":"https://api.github.com/users/ninenines/repos","events_url":"https://api.github.com/users/ninenines/events{/privacy}","received_events_url":"https://api.github.com/users/ninenines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ninenines/erlang.mk","description":"Fast and highly configurable GNU Make build and testing tool for Erlang.","fork":false,"url":"https://api.github.com/repos/ninenines/erlang.mk","forks_url":"https://api.github.com/repos/ninenines/erlang.mk/forks","keys_url":"https://api.github.com/repos/ninenines/erlang.mk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninenines/erlang.mk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninenines/erlang.mk/teams","hooks_url":"https://api.github.com/repos/ninenines/erlang.mk/hooks","issue_events_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/events{/number}","events_url":"https://api.github.com/repos/ninenines/erlang.mk/events","assignees_url":"https://api.github.com/repos/ninenines/erlang.mk/assignees{/user}","branches_url":"https://api.github.com/repos/ninenines/erlang.mk/branches{/branch}","tags_url":"https://api.github.com/repos/ninenines/erlang.mk/tags","blobs_url":"https://api.github.com/repos/ninenines/erlang.mk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninenines/erlang.mk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninenines/erlang.mk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninenines/erlang.mk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninenines/erlang.mk/statuses/{sha}","languages_url":"https://api.github.com/repos/ninenines/erlang.mk/languages","stargazers_url":"https://api.github.com/repos/ninenines/erlang.mk/stargazers","contributors_url":"https://api.github.com/repos/ninenines/erlang.mk/contributors","subscribers_url":"https://api.github.com/repos/ninenines/erlang.mk/subscribers","subscription_url":"https://api.github.com/repos/ninenines/erlang.mk/subscription","commits_url":"https://api.github.com/repos/ninenines/erlang.mk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninenines/erlang.mk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninenines/erlang.mk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/comments/{number}","contents_url":"https://api.github.com/repos/ninenines/erlang.mk/contents/{+path}","compare_url":"https://api.github.com/repos/ninenines/erlang.mk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninenines/erlang.mk/merges","archive_url":"https://api.github.com/repos/ninenines/erlang.mk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninenines/erlang.mk/downloads","issues_url":"https://api.github.com/repos/ninenines/erlang.mk/issues{/number}","pulls_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls{/number}","milestones_url":"https://api.github.com/repos/ninenines/erlang.mk/milestones{/number}","notifications_url":"https://api.github.com/repos/ninenines/erlang.mk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninenines/erlang.mk/labels{/name}","releases_url":"https://api.github.com/repos/ninenines/erlang.mk/releases{/id}","created_at":"2013-04-30T18:18:46Z","updated_at":"2014-12-16T03:34:42Z","pushed_at":"2014-12-13T18:42:58Z","git_url":"git://github.com/ninenines/erlang.mk.git","ssh_url":"git@github.com:ninenines/erlang.mk.git","clone_url":"https://github.com/ninenines/erlang.mk.git","svn_url":"https://github.com/ninenines/erlang.mk","homepage":"http://ninenines.eu","size":1853,"stargazers_count":252,"watchers_count":252,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":13,"forks":101,"open_issues":13,"watchers":252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/154"},"html":{"href":"https://github.com/ninenines/erlang.mk/pull/154"},"issue":{"href":"https://api.github.com/repos/ninenines/erlang.mk/issues/154"},"comments":{"href":"https://api.github.com/repos/ninenines/erlang.mk/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/ninenines/erlang.mk/statuses/820259e87eabdd183e7aac038e4f133a0b441dc0"}}}}