GitHub PullRequestReviewCommentEvent at 2014-10-28 13:03:46
Repository: webpack
Actor: sokra
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack/pulls/comments/19468195","id":19468195,"diff_hunk":"@@ -1,3 +1,6 @@\n-it(\"should compile and run the test\", function () {\n-\n+it(\"should compile and run the test\", function (done) {\n+  require(['./chunk'], function () {\n+    it(\"should load additional chunks\", function () {});","path":"test/configCases/hash-length/output-filename/index.js","position":5,"original_position":5,"commit_id":"97780e1c1621176e4883adfb6c448a652571497f","original_commit_id":"97780e1c1621176e4883adfb6c448a652571497f","user":{"login":"sokra","id":1365881,"avatar_url":"https://avatars.githubusercontent.com/u/1365881?v=2","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"body":"don't use `it` in a async handler... just remove this line...","created_at":"2014-10-28T13:03:46Z","updated_at":"2014-10-28T13:03:46Z","html_url":"https://github.com/webpack/webpack/pull/557#discussion_r19468195","pull_request_url":"https://api.github.com/repos/webpack/webpack/pulls/557","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments/19468195"},"html":{"href":"https://github.com/webpack/webpack/pull/557#discussion_r19468195"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack/pulls/557"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/557","id":23447755,"html_url":"https://github.com/webpack/webpack/pull/557","diff_url":"https://github.com/webpack/webpack/pull/557.diff","patch_url":"https://github.com/webpack/webpack/pull/557.patch","issue_url":"https://api.github.com/repos/webpack/webpack/issues/557","number":557,"state":"open","locked":false,"title":"Fixes issue with hash length and loading external chunks","user":{"login":"diurnalist","id":796413,"avatar_url":"https://avatars.githubusercontent.com/u/796413?v=2","gravatar_id":"","url":"https://api.github.com/users/diurnalist","html_url":"https://github.com/diurnalist","followers_url":"https://api.github.com/users/diurnalist/followers","following_url":"https://api.github.com/users/diurnalist/following{/other_user}","gists_url":"https://api.github.com/users/diurnalist/gists{/gist_id}","starred_url":"https://api.github.com/users/diurnalist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diurnalist/subscriptions","organizations_url":"https://api.github.com/users/diurnalist/orgs","repos_url":"https://api.github.com/users/diurnalist/repos","events_url":"https://api.github.com/users/diurnalist/events{/privacy}","received_events_url":"https://api.github.com/users/diurnalist/received_events","type":"User","site_admin":false},"body":"If the length option on a hash was being used for a file path template\r\n(e.g. '[hash:8].js'), the file would be outputted with the correct name,\r\nbut the reference inside require.ensure would not work, because the length\r\ntruncation would operate on more than just the hash, and would truncate\r\nsome of the characters added to pad the hash value.\r\n\r\nFix is to implement the `hashWithLength` function where this is a problem.\r\nThis doesn't feel like a proper solution, as it adds some redundancies\r\nin a few places, but it's only in the chunk loading blocks that this matters,\r\nso it's small in scope.\r\n\r\nFixes #555 ","created_at":"2014-10-28T10:55:09Z","updated_at":"2014-10-28T13:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a821c518f5aed1a0c3c9e1b55b3229dbda9c625","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack/pulls/557/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack/pulls/557/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack/pulls/comments/{number}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/557/comments","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/97780e1c1621176e4883adfb6c448a652571497f","head":{"label":"diurnalist:feature/fix-555","ref":"feature/fix-555","sha":"97780e1c1621176e4883adfb6c448a652571497f","user":{"login":"diurnalist","id":796413,"avatar_url":"https://avatars.githubusercontent.com/u/796413?v=2","gravatar_id":"","url":"https://api.github.com/users/diurnalist","html_url":"https://github.com/diurnalist","followers_url":"https://api.github.com/users/diurnalist/followers","following_url":"https://api.github.com/users/diurnalist/following{/other_user}","gists_url":"https://api.github.com/users/diurnalist/gists{/gist_id}","starred_url":"https://api.github.com/users/diurnalist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diurnalist/subscriptions","organizations_url":"https://api.github.com/users/diurnalist/orgs","repos_url":"https://api.github.com/users/diurnalist/repos","events_url":"https://api.github.com/users/diurnalist/events{/privacy}","received_events_url":"https://api.github.com/users/diurnalist/received_events","type":"User","site_admin":false},"repo":{"id":22726088,"name":"webpack","full_name":"diurnalist/webpack","owner":{"login":"diurnalist","id":796413,"avatar_url":"https://avatars.githubusercontent.com/u/796413?v=2","gravatar_id":"","url":"https://api.github.com/users/diurnalist","html_url":"https://github.com/diurnalist","followers_url":"https://api.github.com/users/diurnalist/followers","following_url":"https://api.github.com/users/diurnalist/following{/other_user}","gists_url":"https://api.github.com/users/diurnalist/gists{/gist_id}","starred_url":"https://api.github.com/users/diurnalist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diurnalist/subscriptions","organizations_url":"https://api.github.com/users/diurnalist/orgs","repos_url":"https://api.github.com/users/diurnalist/repos","events_url":"https://api.github.com/users/diurnalist/events{/privacy}","received_events_url":"https://api.github.com/users/diurnalist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diurnalist/webpack","description":"Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jade, coffee, css, less, ... and your custom stuff.","fork":true,"url":"https://api.github.com/repos/diurnalist/webpack","forks_url":"https://api.github.com/repos/diurnalist/webpack/forks","keys_url":"https://api.github.com/repos/diurnalist/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diurnalist/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diurnalist/webpack/teams","hooks_url":"https://api.github.com/repos/diurnalist/webpack/hooks","issue_events_url":"https://api.github.com/repos/diurnalist/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/diurnalist/webpack/events","assignees_url":"https://api.github.com/repos/diurnalist/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/diurnalist/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/diurnalist/webpack/tags","blobs_url":"https://api.github.com/repos/diurnalist/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diurnalist/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diurnalist/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/diurnalist/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diurnalist/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/diurnalist/webpack/languages","stargazers_url":"https://api.github.com/repos/diurnalist/webpack/stargazers","contributors_url":"https://api.github.com/repos/diurnalist/webpack/contributors","subscribers_url":"https://api.github.com/repos/diurnalist/webpack/subscribers","subscription_url":"https://api.github.com/repos/diurnalist/webpack/subscription","commits_url":"https://api.github.com/repos/diurnalist/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/diurnalist/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/diurnalist/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/diurnalist/webpack/issues/comments/{number}","contents_url":"https://api.github.com/repos/diurnalist/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/diurnalist/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diurnalist/webpack/merges","archive_url":"https://api.github.com/repos/diurnalist/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diurnalist/webpack/downloads","issues_url":"https://api.github.com/repos/diurnalist/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/diurnalist/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/diurnalist/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/diurnalist/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diurnalist/webpack/labels{/name}","releases_url":"https://api.github.com/repos/diurnalist/webpack/releases{/id}","created_at":"2014-08-07T15:20:25Z","updated_at":"2014-09-01T08:53:25Z","pushed_at":"2014-10-28T11:24:32Z","git_url":"git://github.com/diurnalist/webpack.git","ssh_url":"git@github.com:diurnalist/webpack.git","clone_url":"https://github.com/diurnalist/webpack.git","svn_url":"https://github.com/diurnalist/webpack","homepage":"http://webpack.github.io","size":2722,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"b02ef8b2c386d34441af4b42aab248aeed014214","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=2","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=2","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jade, coffee, css, less, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments/{number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","created_at":"2012-03-10T10:08:14Z","updated_at":"2014-10-28T12:50:42Z","pushed_at":"2014-10-26T10:20:38Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"http://webpack.github.io","size":8769,"stargazers_count":2110,"watchers_count":2110,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":104,"forks":92,"open_issues":104,"watchers":2110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/557"},"html":{"href":"https://github.com/webpack/webpack/pull/557"},"issue":{"href":"https://api.github.com/repos/webpack/webpack/issues/557"},"comments":{"href":"https://api.github.com/repos/webpack/webpack/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack/statuses/97780e1c1621176e4883adfb6c448a652571497f"}}}}