GitHub PullRequestEvent at 2014-11-12 19:39:59
Repository: data
Actor: wecc
Payload: {"action":"opened","number":2467,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/2467","id":24318664,"html_url":"https://github.com/emberjs/data/pull/2467","diff_url":"https://github.com/emberjs/data/pull/2467.diff","patch_url":"https://github.com/emberjs/data/pull/2467.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/2467","number":2467,"state":"open","locked":false,"title":"Dematerialize rejected _find() if record isEmpty","user":{"login":"wecc","id":708205,"avatar_url":"https://avatars.githubusercontent.com/u/708205?v=3","gravatar_id":"","url":"https://api.github.com/users/wecc","html_url":"https://github.com/wecc","followers_url":"https://api.github.com/users/wecc/followers","following_url":"https://api.github.com/users/wecc/following{/other_user}","gists_url":"https://api.github.com/users/wecc/gists{/gist_id}","starred_url":"https://api.github.com/users/wecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wecc/subscriptions","organizations_url":"https://api.github.com/users/wecc/orgs","repos_url":"https://api.github.com/users/wecc/repos","events_url":"https://api.github.com/users/wecc/events{/privacy}","received_events_url":"https://api.github.com/users/wecc/received_events","type":"User","site_admin":false},"body":"This dematerializes records that has been created when doing a `store.find('thing', 1)` and it fails/gets rejected. Not 100% sure if `isEmpty` is the correct condition here though.\r\n\r\nFixes #1747.","created_at":"2014-11-12T19:39:59Z","updated_at":"2014-11-12T19:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/2467/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/2467/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments/{number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/2467/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/650644e2ddffa22427eec804aba617cc7720d1e4","head":{"label":"wecc:dematerialize-rejected-records","ref":"dematerialize-rejected-records","sha":"650644e2ddffa22427eec804aba617cc7720d1e4","user":{"login":"wecc","id":708205,"avatar_url":"https://avatars.githubusercontent.com/u/708205?v=3","gravatar_id":"","url":"https://api.github.com/users/wecc","html_url":"https://github.com/wecc","followers_url":"https://api.github.com/users/wecc/followers","following_url":"https://api.github.com/users/wecc/following{/other_user}","gists_url":"https://api.github.com/users/wecc/gists{/gist_id}","starred_url":"https://api.github.com/users/wecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wecc/subscriptions","organizations_url":"https://api.github.com/users/wecc/orgs","repos_url":"https://api.github.com/users/wecc/repos","events_url":"https://api.github.com/users/wecc/events{/privacy}","received_events_url":"https://api.github.com/users/wecc/received_events","type":"User","site_admin":false},"repo":{"id":23715690,"name":"data","full_name":"wecc/data","owner":{"login":"wecc","id":708205,"avatar_url":"https://avatars.githubusercontent.com/u/708205?v=3","gravatar_id":"","url":"https://api.github.com/users/wecc","html_url":"https://github.com/wecc","followers_url":"https://api.github.com/users/wecc/followers","following_url":"https://api.github.com/users/wecc/following{/other_user}","gists_url":"https://api.github.com/users/wecc/gists{/gist_id}","starred_url":"https://api.github.com/users/wecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wecc/subscriptions","organizations_url":"https://api.github.com/users/wecc/orgs","repos_url":"https://api.github.com/users/wecc/repos","events_url":"https://api.github.com/users/wecc/events{/privacy}","received_events_url":"https://api.github.com/users/wecc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wecc/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/wecc/data","forks_url":"https://api.github.com/repos/wecc/data/forks","keys_url":"https://api.github.com/repos/wecc/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wecc/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wecc/data/teams","hooks_url":"https://api.github.com/repos/wecc/data/hooks","issue_events_url":"https://api.github.com/repos/wecc/data/issues/events{/number}","events_url":"https://api.github.com/repos/wecc/data/events","assignees_url":"https://api.github.com/repos/wecc/data/assignees{/user}","branches_url":"https://api.github.com/repos/wecc/data/branches{/branch}","tags_url":"https://api.github.com/repos/wecc/data/tags","blobs_url":"https://api.github.com/repos/wecc/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wecc/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wecc/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/wecc/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wecc/data/statuses/{sha}","languages_url":"https://api.github.com/repos/wecc/data/languages","stargazers_url":"https://api.github.com/repos/wecc/data/stargazers","contributors_url":"https://api.github.com/repos/wecc/data/contributors","subscribers_url":"https://api.github.com/repos/wecc/data/subscribers","subscription_url":"https://api.github.com/repos/wecc/data/subscription","commits_url":"https://api.github.com/repos/wecc/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/wecc/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/wecc/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/wecc/data/issues/comments/{number}","contents_url":"https://api.github.com/repos/wecc/data/contents/{+path}","compare_url":"https://api.github.com/repos/wecc/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wecc/data/merges","archive_url":"https://api.github.com/repos/wecc/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wecc/data/downloads","issues_url":"https://api.github.com/repos/wecc/data/issues{/number}","pulls_url":"https://api.github.com/repos/wecc/data/pulls{/number}","milestones_url":"https://api.github.com/repos/wecc/data/milestones{/number}","notifications_url":"https://api.github.com/repos/wecc/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wecc/data/labels{/name}","releases_url":"https://api.github.com/repos/wecc/data/releases{/id}","created_at":"2014-09-05T19:30:55Z","updated_at":"2014-09-06T09:06:28Z","pushed_at":"2014-11-12T19:35:06Z","git_url":"git://github.com/wecc/data.git","ssh_url":"git@github.com:wecc/data.git","clone_url":"https://github.com/wecc/data.git","svn_url":"https://github.com/wecc/data","homepage":"","size":7071,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"1ae0692d259f2fc96b79a6ef34929540305b1401","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments/{number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","created_at":"2011-12-20T01:50:40Z","updated_at":"2014-11-12T17:26:16Z","pushed_at":"2014-11-12T19:04:17Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":25714,"stargazers_count":2109,"watchers_count":2109,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":772,"mirror_url":null,"open_issues_count":236,"forks":772,"open_issues":236,"watchers":2109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/2467"},"html":{"href":"https://github.com/emberjs/data/pull/2467"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/2467"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/2467/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/2467/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/2467/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/650644e2ddffa22427eec804aba617cc7720d1e4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":0,"changed_files":2}}