GitHub PullRequestReviewCommentEvent at 2014-09-07 00:09:54
Repository: dolphin
Actor: comex
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/17212094","id":17212094,"diff_hunk":"@@ -566,32 +552,31 @@ u32 PPCAnalyzer::Analyze(u32 address, CodeBlock *block, CodeBuffer *buffer, u32\n \t\t}\n \t}\n \n-\tCodeOp *code = buffer->codebuffer;\n-\n \tbool found_exit = false;\n \tu32 return_address = 0;\n \tu32 numFollows = 0;\n \tu32 num_inst = 0;\n \n-\tfor (u32 i = 0; i < blockSize; ++i)\n+\tfor (size_t i = 0; i < blockSize; ++i)\n \t{\n \t\tUGeckoInstruction inst = JitInterface::Read_Opcode_JIT(address);\n \n \t\tif (inst.hex != 0)\n \t\t{\n \t\t\tnum_inst++;\n-\t\t\tmemset(&code[i], 0, sizeof(CodeOp));\n+\t\t\tCodeOp* op = &code[i];","path":"Source/Core/Core/PowerPC/PPCAnalyst.cpp","position":123,"original_position":72,"commit_id":"42881b31eadef0b5686608220ba391ff99ca4bfc","original_commit_id":"d2f2341ef0ee543d15920d451d368f736a67fca7","user":{"login":"comex","id":47517,"avatar_url":"https://avatars.githubusercontent.com/u/47517?v=2","gravatar_id":"c5edb8ac42268961073ce12297a871f4","url":"https://api.github.com/users/comex","html_url":"https://github.com/comex","followers_url":"https://api.github.com/users/comex/followers","following_url":"https://api.github.com/users/comex/following{/other_user}","gists_url":"https://api.github.com/users/comex/gists{/gist_id}","starred_url":"https://api.github.com/users/comex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comex/subscriptions","organizations_url":"https://api.github.com/users/comex/orgs","repos_url":"https://api.github.com/users/comex/repos","events_url":"https://api.github.com/users/comex/events{/privacy}","received_events_url":"https://api.github.com/users/comex/received_events","type":"User","site_admin":false},"body":"Dunno... I don't trust `clear()` *not* to free the allocation, although perhaps I should.","created_at":"2014-09-07T00:09:54Z","updated_at":"2014-09-07T00:09:54Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/1010#discussion_r17212094","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1010","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/17212094"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1010#discussion_r17212094"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1010"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1010","id":20854870,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1010","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1010.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1010.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1010","number":1010,"state":"open","locked":false,"title":"Remove a silly array wrapper class in factor of std::vector.","user":{"login":"comex","id":47517,"avatar_url":"https://avatars.githubusercontent.com/u/47517?v=2","gravatar_id":"c5edb8ac42268961073ce12297a871f4","url":"https://api.github.com/users/comex","html_url":"https://github.com/comex","followers_url":"https://api.github.com/users/comex/followers","following_url":"https://api.github.com/users/comex/following{/other_user}","gists_url":"https://api.github.com/users/comex/gists{/gist_id}","starred_url":"https://api.github.com/users/comex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comex/subscriptions","organizations_url":"https://api.github.com/users/comex/orgs","repos_url":"https://api.github.com/users/comex/repos","events_url":"https://api.github.com/users/comex/events{/privacy}","received_events_url":"https://api.github.com/users/comex/received_events","type":"User","site_admin":false},"body":"Could be refactored more heavily, but then again I'm scared of bounds checking vector implementations...","created_at":"2014-09-07T00:03:10Z","updated_at":"2014-09-07T00:09:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3069526c0d90e9f425dc02a7252ad647ee9f5ece","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1010/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/42881b31eadef0b5686608220ba391ff99ca4bfc","head":{"label":"comex:remove-code-buffer","ref":"remove-code-buffer","sha":"42881b31eadef0b5686608220ba391ff99ca4bfc","user":{"login":"comex","id":47517,"avatar_url":"https://avatars.githubusercontent.com/u/47517?v=2","gravatar_id":"c5edb8ac42268961073ce12297a871f4","url":"https://api.github.com/users/comex","html_url":"https://github.com/comex","followers_url":"https://api.github.com/users/comex/followers","following_url":"https://api.github.com/users/comex/following{/other_user}","gists_url":"https://api.github.com/users/comex/gists{/gist_id}","starred_url":"https://api.github.com/users/comex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comex/subscriptions","organizations_url":"https://api.github.com/users/comex/orgs","repos_url":"https://api.github.com/users/comex/repos","events_url":"https://api.github.com/users/comex/events{/privacy}","received_events_url":"https://api.github.com/users/comex/received_events","type":"User","site_admin":false},"repo":{"id":18200306,"name":"dolphin","full_name":"comex/dolphin","owner":{"login":"comex","id":47517,"avatar_url":"https://avatars.githubusercontent.com/u/47517?v=2","gravatar_id":"c5edb8ac42268961073ce12297a871f4","url":"https://api.github.com/users/comex","html_url":"https://github.com/comex","followers_url":"https://api.github.com/users/comex/followers","following_url":"https://api.github.com/users/comex/following{/other_user}","gists_url":"https://api.github.com/users/comex/gists{/gist_id}","starred_url":"https://api.github.com/users/comex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comex/subscriptions","organizations_url":"https://api.github.com/users/comex/orgs","repos_url":"https://api.github.com/users/comex/repos","events_url":"https://api.github.com/users/comex/events{/privacy}","received_events_url":"https://api.github.com/users/comex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/comex/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/comex/dolphin","forks_url":"https://api.github.com/repos/comex/dolphin/forks","keys_url":"https://api.github.com/repos/comex/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/comex/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/comex/dolphin/teams","hooks_url":"https://api.github.com/repos/comex/dolphin/hooks","issue_events_url":"https://api.github.com/repos/comex/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/comex/dolphin/events","assignees_url":"https://api.github.com/repos/comex/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/comex/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/comex/dolphin/tags","blobs_url":"https://api.github.com/repos/comex/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/comex/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/comex/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/comex/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/comex/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/comex/dolphin/languages","stargazers_url":"https://api.github.com/repos/comex/dolphin/stargazers","contributors_url":"https://api.github.com/repos/comex/dolphin/contributors","subscribers_url":"https://api.github.com/repos/comex/dolphin/subscribers","subscription_url":"https://api.github.com/repos/comex/dolphin/subscription","commits_url":"https://api.github.com/repos/comex/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/comex/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/comex/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/comex/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/comex/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/comex/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/comex/dolphin/merges","archive_url":"https://api.github.com/repos/comex/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/comex/dolphin/downloads","issues_url":"https://api.github.com/repos/comex/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/comex/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/comex/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/comex/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/comex/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/comex/dolphin/releases{/id}","created_at":"2014-03-28T03:47:13Z","updated_at":"2014-08-23T19:33:32Z","pushed_at":"2014-09-07T00:09:08Z","git_url":"git://github.com/comex/dolphin.git","ssh_url":"git@github.com:comex/dolphin.git","clone_url":"https://github.com/comex/dolphin.git","svn_url":"https://github.com/comex/dolphin","homepage":null,"size":190211,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"562c0d7ad78027dbb26832e3cb9c6d8ad78e278b","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=2","gravatar_id":"889eb5c76644c10900f277bef9b7b516","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=2","gravatar_id":"889eb5c76644c10900f277bef9b7b516","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2014-09-06T14:53:12Z","pushed_at":"2014-09-06T20:10:30Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":243289,"stargazers_count":495,"watchers_count":495,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":185,"mirror_url":null,"open_issues_count":33,"forks":185,"open_issues":33,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1010"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1010"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1010"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/42881b31eadef0b5686608220ba391ff99ca4bfc"}}}}