GitHub PullRequestReviewCommentEvent at 2014-09-05 02:05:00
Repository: tizen-extensions-crosswalk
Actor: halton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/17154012","id":17154012,"diff_hunk":"@@ -758,7 +766,31 @@ BluetoothAdapter.prototype.setChangeListener = function(listener) {\n };\n \n BluetoothAdapter.prototype.unsetChangeListener = function() {\n-  adapter.change_listener = null;\n+  adapter.change_listener = {};\n+};\n+\n+function BluetoothProfileHandler(profileType) {\n+  _addConstProperty(this, 'profileType', profileType);\n+}\n+\n+// BluetoothHealthProfileHandler class inherits from BluetoothProfileHandler class","path":"bluetooth/bluetooth_api.js","position":210,"original_position":210,"commit_id":"b59114a5b717e90053c75577ac458ab00132061b","original_commit_id":"b59114a5b717e90053c75577ac458ab00132061b","user":{"login":"halton","id":433218,"avatar_url":"https://avatars.githubusercontent.com/u/433218?v=2","gravatar_id":"12aa489648dd89d591d6514602d705be","url":"https://api.github.com/users/halton","html_url":"https://github.com/halton","followers_url":"https://api.github.com/users/halton/followers","following_url":"https://api.github.com/users/halton/following{/other_user}","gists_url":"https://api.github.com/users/halton/gists{/gist_id}","starred_url":"https://api.github.com/users/halton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halton/subscriptions","organizations_url":"https://api.github.com/users/halton/orgs","repos_url":"https://api.github.com/users/halton/repos","events_url":"https://api.github.com/users/halton/events{/privacy}","received_events_url":"https://api.github.com/users/halton/received_events","type":"User","site_admin":false},"body":"I do not think this comment is very useful, the .call() is very straight-forward.","created_at":"2014-09-05T02:05:00Z","updated_at":"2014-09-05T02:05:00Z","html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/368#discussion_r17154012","pull_request_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/368","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/17154012"},"html":{"href":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/368#discussion_r17154012"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/368"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/368","id":20627243,"html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/368","diff_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/368.diff","patch_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/368.patch","issue_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/368","number":368,"state":"open","locked":false,"title":"[Bluetooth] Implement health profile API and improve extension","user":{"login":"clecou","id":3442085,"avatar_url":"https://avatars.githubusercontent.com/u/3442085?v=2","gravatar_id":"75d3dcd7d1c45cf71de80ad9a4561ce9","url":"https://api.github.com/users/clecou","html_url":"https://github.com/clecou","followers_url":"https://api.github.com/users/clecou/followers","following_url":"https://api.github.com/users/clecou/following{/other_user}","gists_url":"https://api.github.com/users/clecou/gists{/gist_id}","starred_url":"https://api.github.com/users/clecou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clecou/subscriptions","organizations_url":"https://api.github.com/users/clecou/orgs","repos_url":"https://api.github.com/users/clecou/repos","events_url":"https://api.github.com/users/clecou/events{/privacy}","received_events_url":"https://api.github.com/users/clecou/received_events","type":"User","site_admin":false},"body":"- add Bluetooth Health Profile related API\r\n- use BluetoothInstance::Initialize method\r\n- call missing ondevicedisappeared callback\r\n- improve server and client socket part\r\n- fix many error code returns\r\n- fix some readonly attributes to pass some TCT tests\r\n\r\nBUG related to XWALK-1065","created_at":"2014-09-02T17:23:07Z","updated_at":"2014-09-05T02:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e5c25fb99e9ae9767d841a24095e6cc72af31b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/368/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/368/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/368/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/b59114a5b717e90053c75577ac458ab00132061b","head":{"label":"eurogiciel-oss:bluetooth_health","ref":"bluetooth_health","sha":"b59114a5b717e90053c75577ac458ab00132061b","user":{"login":"eurogiciel-oss","id":5656681,"avatar_url":"https://avatars.githubusercontent.com/u/5656681?v=2","gravatar_id":"bc224ad5d1eaaada13afba882f32b89b","url":"https://api.github.com/users/eurogiciel-oss","html_url":"https://github.com/eurogiciel-oss","followers_url":"https://api.github.com/users/eurogiciel-oss/followers","following_url":"https://api.github.com/users/eurogiciel-oss/following{/other_user}","gists_url":"https://api.github.com/users/eurogiciel-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/eurogiciel-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurogiciel-oss/subscriptions","organizations_url":"https://api.github.com/users/eurogiciel-oss/orgs","repos_url":"https://api.github.com/users/eurogiciel-oss/repos","events_url":"https://api.github.com/users/eurogiciel-oss/events{/privacy}","received_events_url":"https://api.github.com/users/eurogiciel-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":15964946,"name":"tizen-extensions-crosswalk","full_name":"eurogiciel-oss/tizen-extensions-crosswalk","owner":{"login":"eurogiciel-oss","id":5656681,"avatar_url":"https://avatars.githubusercontent.com/u/5656681?v=2","gravatar_id":"bc224ad5d1eaaada13afba882f32b89b","url":"https://api.github.com/users/eurogiciel-oss","html_url":"https://github.com/eurogiciel-oss","followers_url":"https://api.github.com/users/eurogiciel-oss/followers","following_url":"https://api.github.com/users/eurogiciel-oss/following{/other_user}","gists_url":"https://api.github.com/users/eurogiciel-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/eurogiciel-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurogiciel-oss/subscriptions","organizations_url":"https://api.github.com/users/eurogiciel-oss/orgs","repos_url":"https://api.github.com/users/eurogiciel-oss/repos","events_url":"https://api.github.com/users/eurogiciel-oss/events{/privacy}","received_events_url":"https://api.github.com/users/eurogiciel-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eurogiciel-oss/tizen-extensions-crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk","forks_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/forks","keys_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/teams","hooks_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/events","assignees_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/tags","blobs_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/languages","stargazers_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/subscription","commits_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/merges","archive_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/downloads","issues_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/eurogiciel-oss/tizen-extensions-crosswalk/releases{/id}","created_at":"2014-01-16T10:34:29Z","updated_at":"2014-06-25T22:10:42Z","pushed_at":"2014-09-04T10:32:34Z","git_url":"git://github.com/eurogiciel-oss/tizen-extensions-crosswalk.git","ssh_url":"git@github.com:eurogiciel-oss/tizen-extensions-crosswalk.git","clone_url":"https://github.com/eurogiciel-oss/tizen-extensions-crosswalk.git","svn_url":"https://github.com/eurogiciel-oss/tizen-extensions-crosswalk","homepage":null,"size":4931,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"352272a7f910f84f2e8e7995fdaa9fe76b18325f","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=2","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":11259856,"name":"tizen-extensions-crosswalk","full_name":"crosswalk-project/tizen-extensions-crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=2","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/releases{/id}","created_at":"2013-07-08T16:54:26Z","updated_at":"2014-08-25T22:05:55Z","pushed_at":"2014-08-26T22:05:49Z","git_url":"git://github.com/crosswalk-project/tizen-extensions-crosswalk.git","ssh_url":"git@github.com:crosswalk-project/tizen-extensions-crosswalk.git","clone_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk.git","svn_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk","homepage":null,"size":9375,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":47,"mirror_url":null,"open_issues_count":9,"forks":47,"open_issues":9,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/368"},"html":{"href":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/368"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/368"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/b59114a5b717e90053c75577ac458ab00132061b"}}}}