GitHub PullRequestReviewCommentEvent at 2014-05-19 23:36:32
Repository: druid
Actor: gianm
Payload: {"comment":{"url":"https://api.github.com/repos/metamx/druid/pulls/comments/12821991","id":12821991,"diff_hunk":"@@ -791,7 +791,7 @@ private CoordinatorHistoricalManagerRunnable()\n                 public DruidCoordinatorRuntimeParams run(DruidCoordinatorRuntimeParams params)\n                 {\n                   // Display info about all historical servers\n-                  Iterable<DruidServer> servers = FunctionalIterable\n+                  Iterable<ImmutableDruidServer> servers = FunctionalIterable","path":"server/src/main/java/io/druid/server/coordinator/DruidCoordinator.java","position":42,"original_position":42,"commit_id":"7879f38ccc528b28ab7489e78d529ebf18eb5a25","original_commit_id":"7879f38ccc528b28ab7489e78d529ebf18eb5a25","user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars.githubusercontent.com/u/1214075?","gravatar_id":"1913a548e9db93a970aef9faca37b339","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"body":"Wait... UN-NEVERMIND! I think the check is foiled by the fact that currently, the stages are separate helpers, not separate runnables. So the leader session is NOT checked between them.","created_at":"2014-05-19T23:36:32Z","updated_at":"2014-05-19T23:36:32Z","html_url":"https://github.com/metamx/druid/pull/553#discussion_r12821991","pull_request_url":"https://api.github.com/repos/metamx/druid/pulls/553","_links":{"self":{"href":"https://api.github.com/repos/metamx/druid/pulls/comments/12821991"},"html":{"href":"https://github.com/metamx/druid/pull/553#discussion_r12821991"},"pull_request":{"href":"https://api.github.com/repos/metamx/druid/pulls/553"}}}}