GitHub PullRequestReviewCommentEvent at 2014-09-28 19:30:04
Repository: egtaonline3
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/comments/18131842","id":18131842,"diff_hunk":"@@ -1,5 +1,84 @@\n require 'spec_helper'\n \n describe AnalysisScript do\n-  pending \"add some examples to (or delete) #{__FILE__}\"\n+\tbefore(:each) do \n+\t\t@params = {\n+\t\tregret: 0.1, \n+\t\tdist: 0.1,\n+\t\tsupport: 0.1,\n+\t\tconverge: 0.2,\n+\t\titers: 10,\n+\t\tpoints: 6\t\t\n+\t\t}\n+\tend\n+\n+\n+  it 'has makes a valid model' do\n+  \tanalysis = create(:analysis, :running_status)\n+  \t# create(:analysis_script, analysis_id: analysis.id).should be_valid\n+  \tanalysis_script = analysis.create_analysis_script(@params)\n+  \tanalysis_script.should be_valid\n+  end\n+\n+  describe '#get_command' do\n+  \tcontext 'if no verbose' do\n+\t  \tit 'sets up the get scripts command' do\n+\t  \t\tanalysis = create(:analysis, :running_status)\n+\t  \t \tanalysis_script = analysis.create_analysis_script(@params)\n+\t  \t\tcom = \"python AnalysisScript.py -r #{@params[:regret]} \" \\\n+\t  \t\t\"-d #{@params[:dist]} -s #{@params[:support]} -c #{@params[:converge]} \"\\\n+\t  \t\t\"-i #{@params[:iters]} -p #{@params[:points]} #{analysis.game.id}\"\\\n+\t  \t\t\"-analysis-#{analysis.id}.json > ./out/#{analysis.game.id}\"\\","path":"spec/models/analysis_script_spec.rb","position":32,"original_position":32,"commit_id":"50e00f35741ce9a73b13b1592230bf9f63f74af9","original_commit_id":"50e00f35741ce9a73b13b1592230bf9f63f74af9","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Tab detected.","created_at":"2014-09-28T19:30:04Z","updated_at":"2014-09-28T19:30:04Z","html_url":"https://github.com/egtaonline/egtaonline3/pull/1#discussion_r18131842","pull_request_url":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/comments/18131842"},"html":{"href":"https://github.com/egtaonline/egtaonline3/pull/1#discussion_r18131842"},"pull_request":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/1","id":21905419,"html_url":"https://github.com/egtaonline/egtaonline3/pull/1","diff_url":"https://github.com/egtaonline/egtaonline3/pull/1.diff","patch_url":"https://github.com/egtaonline/egtaonline3/pull/1.patch","issue_url":"https://api.github.com/repos/egtaonline/egtaonline3/issues/1","number":1,"state":"open","locked":false,"title":"Database develop","user":{"login":"achintp","id":1408785,"avatar_url":"https://avatars.githubusercontent.com/u/1408785?v=2","gravatar_id":"","url":"https://api.github.com/users/achintp","html_url":"https://github.com/achintp","followers_url":"https://api.github.com/users/achintp/followers","following_url":"https://api.github.com/users/achintp/following{/other_user}","gists_url":"https://api.github.com/users/achintp/gists{/gist_id}","starred_url":"https://api.github.com/users/achintp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achintp/subscriptions","organizations_url":"https://api.github.com/users/achintp/orgs","repos_url":"https://api.github.com/users/achintp/repos","events_url":"https://api.github.com/users/achintp/events{/privacy}","received_events_url":"https://api.github.com/users/achintp/received_events","type":"User","site_admin":false},"body":"Added the model tests. Made change to ensure only id is being passed to sidekiq.","created_at":"2014-09-28T19:29:50Z","updated_at":"2014-09-28T19:30:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9cf331e63c952d7910e94101ea9f64e01be65d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/1/commits","review_comments_url":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/1/comments","review_comment_url":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/comments/{number}","comments_url":"https://api.github.com/repos/egtaonline/egtaonline3/issues/1/comments","statuses_url":"https://api.github.com/repos/egtaonline/egtaonline3/statuses/50e00f35741ce9a73b13b1592230bf9f63f74af9","head":{"label":"achintp:database-develop","ref":"database-develop","sha":"50e00f35741ce9a73b13b1592230bf9f63f74af9","user":{"login":"achintp","id":1408785,"avatar_url":"https://avatars.githubusercontent.com/u/1408785?v=2","gravatar_id":"","url":"https://api.github.com/users/achintp","html_url":"https://github.com/achintp","followers_url":"https://api.github.com/users/achintp/followers","following_url":"https://api.github.com/users/achintp/following{/other_user}","gists_url":"https://api.github.com/users/achintp/gists{/gist_id}","starred_url":"https://api.github.com/users/achintp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achintp/subscriptions","organizations_url":"https://api.github.com/users/achintp/orgs","repos_url":"https://api.github.com/users/achintp/repos","events_url":"https://api.github.com/users/achintp/events{/privacy}","received_events_url":"https://api.github.com/users/achintp/received_events","type":"User","site_admin":false},"repo":{"id":23588890,"name":"egtaonline3","full_name":"achintp/egtaonline3","owner":{"login":"achintp","id":1408785,"avatar_url":"https://avatars.githubusercontent.com/u/1408785?v=2","gravatar_id":"","url":"https://api.github.com/users/achintp","html_url":"https://github.com/achintp","followers_url":"https://api.github.com/users/achintp/followers","following_url":"https://api.github.com/users/achintp/following{/other_user}","gists_url":"https://api.github.com/users/achintp/gists{/gist_id}","starred_url":"https://api.github.com/users/achintp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achintp/subscriptions","organizations_url":"https://api.github.com/users/achintp/orgs","repos_url":"https://api.github.com/users/achintp/repos","events_url":"https://api.github.com/users/achintp/events{/privacy}","received_events_url":"https://api.github.com/users/achintp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achintp/egtaonline3","description":"","fork":true,"url":"https://api.github.com/repos/achintp/egtaonline3","forks_url":"https://api.github.com/repos/achintp/egtaonline3/forks","keys_url":"https://api.github.com/repos/achintp/egtaonline3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achintp/egtaonline3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achintp/egtaonline3/teams","hooks_url":"https://api.github.com/repos/achintp/egtaonline3/hooks","issue_events_url":"https://api.github.com/repos/achintp/egtaonline3/issues/events{/number}","events_url":"https://api.github.com/repos/achintp/egtaonline3/events","assignees_url":"https://api.github.com/repos/achintp/egtaonline3/assignees{/user}","branches_url":"https://api.github.com/repos/achintp/egtaonline3/branches{/branch}","tags_url":"https://api.github.com/repos/achintp/egtaonline3/tags","blobs_url":"https://api.github.com/repos/achintp/egtaonline3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achintp/egtaonline3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achintp/egtaonline3/git/refs{/sha}","trees_url":"https://api.github.com/repos/achintp/egtaonline3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achintp/egtaonline3/statuses/{sha}","languages_url":"https://api.github.com/repos/achintp/egtaonline3/languages","stargazers_url":"https://api.github.com/repos/achintp/egtaonline3/stargazers","contributors_url":"https://api.github.com/repos/achintp/egtaonline3/contributors","subscribers_url":"https://api.github.com/repos/achintp/egtaonline3/subscribers","subscription_url":"https://api.github.com/repos/achintp/egtaonline3/subscription","commits_url":"https://api.github.com/repos/achintp/egtaonline3/commits{/sha}","git_commits_url":"https://api.github.com/repos/achintp/egtaonline3/git/commits{/sha}","comments_url":"https://api.github.com/repos/achintp/egtaonline3/comments{/number}","issue_comment_url":"https://api.github.com/repos/achintp/egtaonline3/issues/comments/{number}","contents_url":"https://api.github.com/repos/achintp/egtaonline3/contents/{+path}","compare_url":"https://api.github.com/repos/achintp/egtaonline3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achintp/egtaonline3/merges","archive_url":"https://api.github.com/repos/achintp/egtaonline3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achintp/egtaonline3/downloads","issues_url":"https://api.github.com/repos/achintp/egtaonline3/issues{/number}","pulls_url":"https://api.github.com/repos/achintp/egtaonline3/pulls{/number}","milestones_url":"https://api.github.com/repos/achintp/egtaonline3/milestones{/number}","notifications_url":"https://api.github.com/repos/achintp/egtaonline3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achintp/egtaonline3/labels{/name}","releases_url":"https://api.github.com/repos/achintp/egtaonline3/releases{/id}","created_at":"2014-09-02T17:44:02Z","updated_at":"2014-08-31T03:41:05Z","pushed_at":"2014-09-28T18:28:34Z","git_url":"git://github.com/achintp/egtaonline3.git","ssh_url":"git@github.com:achintp/egtaonline3.git","clone_url":"https://github.com/achintp/egtaonline3.git","svn_url":"https://github.com/achintp/egtaonline3","homepage":null,"size":3926,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"egtaonline:database","ref":"database","sha":"82185d3e0783a8bc2a6e20b2a07393a17c5bf872","user":{"login":"egtaonline","id":810661,"avatar_url":"https://avatars.githubusercontent.com/u/810661?v=2","gravatar_id":"","url":"https://api.github.com/users/egtaonline","html_url":"https://github.com/egtaonline","followers_url":"https://api.github.com/users/egtaonline/followers","following_url":"https://api.github.com/users/egtaonline/following{/other_user}","gists_url":"https://api.github.com/users/egtaonline/gists{/gist_id}","starred_url":"https://api.github.com/users/egtaonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egtaonline/subscriptions","organizations_url":"https://api.github.com/users/egtaonline/orgs","repos_url":"https://api.github.com/users/egtaonline/repos","events_url":"https://api.github.com/users/egtaonline/events{/privacy}","received_events_url":"https://api.github.com/users/egtaonline/received_events","type":"Organization","site_admin":false},"repo":{"id":9476305,"name":"egtaonline3","full_name":"egtaonline/egtaonline3","owner":{"login":"egtaonline","id":810661,"avatar_url":"https://avatars.githubusercontent.com/u/810661?v=2","gravatar_id":"","url":"https://api.github.com/users/egtaonline","html_url":"https://github.com/egtaonline","followers_url":"https://api.github.com/users/egtaonline/followers","following_url":"https://api.github.com/users/egtaonline/following{/other_user}","gists_url":"https://api.github.com/users/egtaonline/gists{/gist_id}","starred_url":"https://api.github.com/users/egtaonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egtaonline/subscriptions","organizations_url":"https://api.github.com/users/egtaonline/orgs","repos_url":"https://api.github.com/users/egtaonline/repos","events_url":"https://api.github.com/users/egtaonline/events{/privacy}","received_events_url":"https://api.github.com/users/egtaonline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/egtaonline/egtaonline3","description":"","fork":false,"url":"https://api.github.com/repos/egtaonline/egtaonline3","forks_url":"https://api.github.com/repos/egtaonline/egtaonline3/forks","keys_url":"https://api.github.com/repos/egtaonline/egtaonline3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egtaonline/egtaonline3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egtaonline/egtaonline3/teams","hooks_url":"https://api.github.com/repos/egtaonline/egtaonline3/hooks","issue_events_url":"https://api.github.com/repos/egtaonline/egtaonline3/issues/events{/number}","events_url":"https://api.github.com/repos/egtaonline/egtaonline3/events","assignees_url":"https://api.github.com/repos/egtaonline/egtaonline3/assignees{/user}","branches_url":"https://api.github.com/repos/egtaonline/egtaonline3/branches{/branch}","tags_url":"https://api.github.com/repos/egtaonline/egtaonline3/tags","blobs_url":"https://api.github.com/repos/egtaonline/egtaonline3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egtaonline/egtaonline3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egtaonline/egtaonline3/git/refs{/sha}","trees_url":"https://api.github.com/repos/egtaonline/egtaonline3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egtaonline/egtaonline3/statuses/{sha}","languages_url":"https://api.github.com/repos/egtaonline/egtaonline3/languages","stargazers_url":"https://api.github.com/repos/egtaonline/egtaonline3/stargazers","contributors_url":"https://api.github.com/repos/egtaonline/egtaonline3/contributors","subscribers_url":"https://api.github.com/repos/egtaonline/egtaonline3/subscribers","subscription_url":"https://api.github.com/repos/egtaonline/egtaonline3/subscription","commits_url":"https://api.github.com/repos/egtaonline/egtaonline3/commits{/sha}","git_commits_url":"https://api.github.com/repos/egtaonline/egtaonline3/git/commits{/sha}","comments_url":"https://api.github.com/repos/egtaonline/egtaonline3/comments{/number}","issue_comment_url":"https://api.github.com/repos/egtaonline/egtaonline3/issues/comments/{number}","contents_url":"https://api.github.com/repos/egtaonline/egtaonline3/contents/{+path}","compare_url":"https://api.github.com/repos/egtaonline/egtaonline3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egtaonline/egtaonline3/merges","archive_url":"https://api.github.com/repos/egtaonline/egtaonline3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egtaonline/egtaonline3/downloads","issues_url":"https://api.github.com/repos/egtaonline/egtaonline3/issues{/number}","pulls_url":"https://api.github.com/repos/egtaonline/egtaonline3/pulls{/number}","milestones_url":"https://api.github.com/repos/egtaonline/egtaonline3/milestones{/number}","notifications_url":"https://api.github.com/repos/egtaonline/egtaonline3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egtaonline/egtaonline3/labels{/name}","releases_url":"https://api.github.com/repos/egtaonline/egtaonline3/releases{/id}","created_at":"2013-04-16T15:50:30Z","updated_at":"2014-08-31T03:41:05Z","pushed_at":"2014-09-02T22:34:45Z","git_url":"git://github.com/egtaonline/egtaonline3.git","ssh_url":"git@github.com:egtaonline/egtaonline3.git","clone_url":"https://github.com/egtaonline/egtaonline3.git","svn_url":"https://github.com/egtaonline/egtaonline3","homepage":null,"size":5984,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/1"},"html":{"href":"https://github.com/egtaonline/egtaonline3/pull/1"},"issue":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/issues/1"},"comments":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/egtaonline/egtaonline3/statuses/50e00f35741ce9a73b13b1592230bf9f63f74af9"}}}}