GitHub PullRequestReviewCommentEvent at 2014-01-06 17:29:28
Repository: HPCC-Platform
Actor: ghalliday
Payload: {"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/8670867","id":8670867,"diff_hunk":"@@ -392,7 +406,9 @@ class CRoxiePackageNode : extends CPackageNode, implements IRoxiePackage\n         if (traceLevel > 5)\n             DBGLOG(\"lookupFileName %s\", fileName.str());\n \n-        const IResolvedFile *result = lookupFile(fileName, cache, false, false);\n+        const IResolvedFile *result = lookupExpandedFileName(fileName, cache, false, false);\n+        if (!result)\n+            result = resolveLFNusingDaliOrLocal(fileName, cache, false, false);","path":"roxie/ccd/ccdstate.cpp","position":213,"original_position":213,"commit_id":"4d3116e1293eb2de61039b96803ec6662c41a0b3","original_commit_id":"4d3116e1293eb2de61039b96803ec6662c41a0b3","user":{"login":"ghalliday","id":902490,"avatar_url":"https://gravatar.com/avatar/402dddc31c0e131326457e9ffd436352?d=https%3A%2F%2Fidenticons.github.com%2Ffe5515252d652398f3855425ad2a507e.png&r=x","gravatar_id":"402dddc31c0e131326457e9ffd436352","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"Hasn't this already been done by the lookupExpandedFileName function?\r\n","created_at":"2014-01-06T17:29:28Z","updated_at":"2014-01-06T17:29:28Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/5232#discussion_r8670867","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/5232","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/8670867"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/5232#discussion_r8670867"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/5232"}}}}