GitHub PullRequestReviewCommentEvent at 2014-08-03 14:47:16
Repository: phpbb
Actor: nickvergessen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/15734772","id":15734772,"diff_hunk":"@@ -18,9 +18,17 @@ class type_googleplus extends type_string\n \t/**\n \t* {@inheritDoc}\n \t*/\n-\tpublic function get_service_name()","path":"phpBB/phpbb/profilefields/type/type_googleplus.php","position":4,"original_position":4,"commit_id":"f66cb27ed04933ee7253085c29aeefc89ce9b7db","original_commit_id":"f66cb27ed04933ee7253085c29aeefc89ce9b7db","user":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=1","gravatar_id":"3723085d78dfb1a565e063a49f69a987","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"body":"service name is still required","created_at":"2014-08-03T14:47:16Z","updated_at":"2014-08-03T14:47:16Z","html_url":"https://github.com/phpbb/phpbb/pull/2795#discussion_r15734772","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2795","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/15734772"},"html":{"href":"https://github.com/phpbb/phpbb/pull/2795#discussion_r15734772"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2795"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/2795","id":19255438,"html_url":"https://github.com/phpbb/phpbb/pull/2795","diff_url":"https://github.com/phpbb/phpbb/pull/2795.diff","patch_url":"https://github.com/phpbb/phpbb/pull/2795.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/2795","number":2795,"state":"open","title":"[ticket/12910] Set get_name_short for Google+ fields","user":{"login":"Dragooon","id":551634,"avatar_url":"https://avatars.githubusercontent.com/u/551634?v=1","gravatar_id":"288fa9e50e7eadbdcfad1997eaac255b","url":"https://api.github.com/users/Dragooon","html_url":"https://github.com/Dragooon","followers_url":"https://api.github.com/users/Dragooon/followers","following_url":"https://api.github.com/users/Dragooon/following{/other_user}","gists_url":"https://api.github.com/users/Dragooon/gists{/gist_id}","starred_url":"https://api.github.com/users/Dragooon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dragooon/subscriptions","organizations_url":"https://api.github.com/users/Dragooon/orgs","repos_url":"https://api.github.com/users/Dragooon/repos","events_url":"https://api.github.com/users/Dragooon/events{/privacy}","received_events_url":"https://api.github.com/users/Dragooon/received_events","type":"User","site_admin":false},"body":"Using get_service name would confuse the ACP dropdowns while fetching the field's type's name, causing it to list 2 \"Single text field\". Instead specify the template filename instead\r\n\r\n[PHPBB3-12910](https://tracker.phpbb.com/browse/PHPBB3-12910)","created_at":"2014-08-03T12:57:59Z","updated_at":"2014-08-03T14:47:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea147c4613990bed6b18886da651c89815ed61d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2795/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2795/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/2795/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/f66cb27ed04933ee7253085c29aeefc89ce9b7db","head":{"label":"Dragooon:ticket/12910","ref":"ticket/12910","sha":"f66cb27ed04933ee7253085c29aeefc89ce9b7db","user":{"login":"Dragooon","id":551634,"avatar_url":"https://avatars.githubusercontent.com/u/551634?v=1","gravatar_id":"288fa9e50e7eadbdcfad1997eaac255b","url":"https://api.github.com/users/Dragooon","html_url":"https://github.com/Dragooon","followers_url":"https://api.github.com/users/Dragooon/followers","following_url":"https://api.github.com/users/Dragooon/following{/other_user}","gists_url":"https://api.github.com/users/Dragooon/gists{/gist_id}","starred_url":"https://api.github.com/users/Dragooon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dragooon/subscriptions","organizations_url":"https://api.github.com/users/Dragooon/orgs","repos_url":"https://api.github.com/users/Dragooon/repos","events_url":"https://api.github.com/users/Dragooon/events{/privacy}","received_events_url":"https://api.github.com/users/Dragooon/received_events","type":"User","site_admin":false},"repo":{"id":17819923,"name":"phpbb","full_name":"Dragooon/phpbb","owner":{"login":"Dragooon","id":551634,"avatar_url":"https://avatars.githubusercontent.com/u/551634?v=1","gravatar_id":"288fa9e50e7eadbdcfad1997eaac255b","url":"https://api.github.com/users/Dragooon","html_url":"https://github.com/Dragooon","followers_url":"https://api.github.com/users/Dragooon/followers","following_url":"https://api.github.com/users/Dragooon/following{/other_user}","gists_url":"https://api.github.com/users/Dragooon/gists{/gist_id}","starred_url":"https://api.github.com/users/Dragooon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dragooon/subscriptions","organizations_url":"https://api.github.com/users/Dragooon/orgs","repos_url":"https://api.github.com/users/Dragooon/repos","events_url":"https://api.github.com/users/Dragooon/events{/privacy}","received_events_url":"https://api.github.com/users/Dragooon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dragooon/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/Dragooon/phpbb","forks_url":"https://api.github.com/repos/Dragooon/phpbb/forks","keys_url":"https://api.github.com/repos/Dragooon/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dragooon/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dragooon/phpbb/teams","hooks_url":"https://api.github.com/repos/Dragooon/phpbb/hooks","issue_events_url":"https://api.github.com/repos/Dragooon/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/Dragooon/phpbb/events","assignees_url":"https://api.github.com/repos/Dragooon/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/Dragooon/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/Dragooon/phpbb/tags","blobs_url":"https://api.github.com/repos/Dragooon/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dragooon/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dragooon/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dragooon/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dragooon/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/Dragooon/phpbb/languages","stargazers_url":"https://api.github.com/repos/Dragooon/phpbb/stargazers","contributors_url":"https://api.github.com/repos/Dragooon/phpbb/contributors","subscribers_url":"https://api.github.com/repos/Dragooon/phpbb/subscribers","subscription_url":"https://api.github.com/repos/Dragooon/phpbb/subscription","commits_url":"https://api.github.com/repos/Dragooon/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dragooon/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dragooon/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dragooon/phpbb/issues/comments/{number}","contents_url":"https://api.github.com/repos/Dragooon/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/Dragooon/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dragooon/phpbb/merges","archive_url":"https://api.github.com/repos/Dragooon/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dragooon/phpbb/downloads","issues_url":"https://api.github.com/repos/Dragooon/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/Dragooon/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/Dragooon/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/Dragooon/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dragooon/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/Dragooon/phpbb/releases{/id}","created_at":"2014-03-17T07:04:25Z","updated_at":"2014-06-24T17:16:57Z","pushed_at":"2014-08-03T13:21:18Z","git_url":"git://github.com/Dragooon/phpbb.git","ssh_url":"git@github.com:Dragooon/phpbb.git","clone_url":"https://github.com/Dragooon/phpbb.git","svn_url":"https://github.com/Dragooon/phpbb","homepage":"http://www.phpbb.com","size":47263,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"phpbb:develop-ascraeus","ref":"develop-ascraeus","sha":"c991b1d587e8ab3b080e2e6762646efe00e05bc5","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=1","gravatar_id":"cf23934d15908c132f1c236369262eb6","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=1","gravatar_id":"cf23934d15908c132f1c236369262eb6","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments/{number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","created_at":"2010-03-01T22:33:17Z","updated_at":"2014-08-01T21:19:48Z","pushed_at":"2014-08-02T11:56:59Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":103490,"stargazers_count":645,"watchers_count":645,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":376,"mirror_url":null,"open_issues_count":78,"forks":376,"open_issues":78,"watchers":645,"default_branch":"develop-ascraeus"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2795"},"html":{"href":"https://github.com/phpbb/phpbb/pull/2795"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/2795"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/2795/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2795/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2795/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/f66cb27ed04933ee7253085c29aeefc89ce9b7db"}}}}