GitHub PullRequestEvent at 2014-05-14 17:49:02
Repository: kc
Actor: blackcathacker
Payload: {"action":"closed","number":214,"pull_request":{"url":"https://api.github.com/repos/kuali/kc/pulls/214","id":15516884,"html_url":"https://github.com/kuali/kc/pull/214","diff_url":"https://github.com/kuali/kc/pull/214.diff","patch_url":"https://github.com/kuali/kc/pull/214.patch","issue_url":"https://api.github.com/repos/kuali/kc/issues/214","number":214,"state":"closed","title":"KCINFR-979: establishing a configuration api.  Removing code that isn't ...","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?","gravatar_id":"73607818dbb47aea2b3f9a925084a3a7","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"body":"This pull request is mainly designed to create an configuration api for S2S to consume.  I have a few goals in mind with this design:\r\n\r\n1) Search for parameters and easily get a complete list of what the S2S library uses\r\n2) The S2S library should ONLY use parameters in the S2S namespace.\r\n3) Insulate the S2S library from parameter changes\r\n4) Simplify the S2S Configuration Service such that is doesn't need to know the difference between xml parameters and DB parameters and the rice concepts of app id, namespace, and component.  None of these complexities are useful to the S2S library\r\n\r\nPlease pay special attention to the parameter replacement syntax.  Any parameter that isn't specifically for S2S uses a parameter replacement syntax in the parameter value.  This allows S2S parameters to easily reference other parameters inside of KC.  I believe this feature could be useful to rice as a whole.  We should consider donating the code.\r\n\r\nAlso, I pretty extensively unit testing this thing but the replacement syntax is a little strict so far.  Do you thinking it should be improved so that @p{ns = \"KC-PD\", c = \"Document\", n = \"proposaldevelopment.proposaltype.resubmission\"} would work?","created_at":"2014-05-05T22:12:09Z","updated_at":"2014-05-14T17:49:02Z","closed_at":"2014-05-14T17:49:02Z","merged_at":"2014-05-14T17:49:02Z","merge_commit_sha":"03e1e2047694750f4e95a0a21b5af9c78d1f4127","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kuali/kc/pulls/214/commits","review_comments_url":"https://api.github.com/repos/kuali/kc/pulls/214/comments","review_comment_url":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kuali/kc/issues/214/comments","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/4f535befed27f373e97af527412e2b113c3fe3b6","head":{"label":"leoherbie:s2s_config_service2","ref":"s2s_config_service2","sha":"4f535befed27f373e97af527412e2b113c3fe3b6","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?","gravatar_id":"73607818dbb47aea2b3f9a925084a3a7","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"repo":{"id":16319639,"name":"kc","full_name":"leoherbie/kc","owner":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?","gravatar_id":"73607818dbb47aea2b3f9a925084a3a7","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leoherbie/kc","description":"Kuali Coeus","fork":true,"url":"https://api.github.com/repos/leoherbie/kc","forks_url":"https://api.github.com/repos/leoherbie/kc/forks","keys_url":"https://api.github.com/repos/leoherbie/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leoherbie/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leoherbie/kc/teams","hooks_url":"https://api.github.com/repos/leoherbie/kc/hooks","issue_events_url":"https://api.github.com/repos/leoherbie/kc/issues/events{/number}","events_url":"https://api.github.com/repos/leoherbie/kc/events","assignees_url":"https://api.github.com/repos/leoherbie/kc/assignees{/user}","branches_url":"https://api.github.com/repos/leoherbie/kc/branches{/branch}","tags_url":"https://api.github.com/repos/leoherbie/kc/tags","blobs_url":"https://api.github.com/repos/leoherbie/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leoherbie/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leoherbie/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/leoherbie/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leoherbie/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/leoherbie/kc/languages","stargazers_url":"https://api.github.com/repos/leoherbie/kc/stargazers","contributors_url":"https://api.github.com/repos/leoherbie/kc/contributors","subscribers_url":"https://api.github.com/repos/leoherbie/kc/subscribers","subscription_url":"https://api.github.com/repos/leoherbie/kc/subscription","commits_url":"https://api.github.com/repos/leoherbie/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/leoherbie/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/leoherbie/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/leoherbie/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/leoherbie/kc/contents/{+path}","compare_url":"https://api.github.com/repos/leoherbie/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leoherbie/kc/merges","archive_url":"https://api.github.com/repos/leoherbie/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leoherbie/kc/downloads","issues_url":"https://api.github.com/repos/leoherbie/kc/issues{/number}","pulls_url":"https://api.github.com/repos/leoherbie/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/leoherbie/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/leoherbie/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leoherbie/kc/labels{/name}","releases_url":"https://api.github.com/repos/leoherbie/kc/releases{/id}","created_at":"2014-01-28T17:33:17Z","updated_at":"2014-05-14T17:49:02Z","pushed_at":"2014-05-14T17:14:04Z","git_url":"git://github.com/leoherbie/kc.git","ssh_url":"git@github.com:leoherbie/kc.git","clone_url":"https://github.com/leoherbie/kc.git","svn_url":"https://github.com/leoherbie/kc","homepage":"http://www.kuali.org/kc","size":559623,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kuali:master","ref":"master","sha":"9a0877d61ffa8440b9c3348f2d815d9883948844","user":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?","gravatar_id":"c2e9cf7cb10aab4497c85f81a4188869","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"repo":{"id":16106733,"name":"kc","full_name":"kuali/kc","owner":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?","gravatar_id":"c2e9cf7cb10aab4497c85f81a4188869","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuali/kc","description":"Kuali Coeus","fork":false,"url":"https://api.github.com/repos/kuali/kc","forks_url":"https://api.github.com/repos/kuali/kc/forks","keys_url":"https://api.github.com/repos/kuali/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuali/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuali/kc/teams","hooks_url":"https://api.github.com/repos/kuali/kc/hooks","issue_events_url":"https://api.github.com/repos/kuali/kc/issues/events{/number}","events_url":"https://api.github.com/repos/kuali/kc/events","assignees_url":"https://api.github.com/repos/kuali/kc/assignees{/user}","branches_url":"https://api.github.com/repos/kuali/kc/branches{/branch}","tags_url":"https://api.github.com/repos/kuali/kc/tags","blobs_url":"https://api.github.com/repos/kuali/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuali/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuali/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuali/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/kuali/kc/languages","stargazers_url":"https://api.github.com/repos/kuali/kc/stargazers","contributors_url":"https://api.github.com/repos/kuali/kc/contributors","subscribers_url":"https://api.github.com/repos/kuali/kc/subscribers","subscription_url":"https://api.github.com/repos/kuali/kc/subscription","commits_url":"https://api.github.com/repos/kuali/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuali/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuali/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuali/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/kuali/kc/contents/{+path}","compare_url":"https://api.github.com/repos/kuali/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuali/kc/merges","archive_url":"https://api.github.com/repos/kuali/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuali/kc/downloads","issues_url":"https://api.github.com/repos/kuali/kc/issues{/number}","pulls_url":"https://api.github.com/repos/kuali/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/kuali/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/kuali/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuali/kc/labels{/name}","releases_url":"https://api.github.com/repos/kuali/kc/releases{/id}","created_at":"2014-01-21T15:32:22Z","updated_at":"2014-05-14T17:49:02Z","pushed_at":"2014-05-14T17:49:02Z","git_url":"git://github.com/kuali/kc.git","ssh_url":"git@github.com:kuali/kc.git","clone_url":"https://github.com/kuali/kc.git","svn_url":"https://github.com/kuali/kc","homepage":"http://www.kuali.org/kc","size":644634,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":29,"mirror_url":null,"open_issues_count":8,"forks":29,"open_issues":8,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/214"},"html":{"href":"https://github.com/kuali/kc/pull/214"},"issue":{"href":"https://api.github.com/repos/kuali/kc/issues/214"},"comments":{"href":"https://api.github.com/repos/kuali/kc/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/kuali/kc/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kuali/kc/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/kuali/kc/statuses/4f535befed27f373e97af527412e2b113c3fe3b6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"blackcathacker","id":3145921,"avatar_url":"https://avatars.githubusercontent.com/u/3145921?","gravatar_id":"49b4427bf232addddf27a4e4e5dae134","url":"https://api.github.com/users/blackcathacker","html_url":"https://github.com/blackcathacker","followers_url":"https://api.github.com/users/blackcathacker/followers","following_url":"https://api.github.com/users/blackcathacker/following{/other_user}","gists_url":"https://api.github.com/users/blackcathacker/gists{/gist_id}","starred_url":"https://api.github.com/users/blackcathacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackcathacker/subscriptions","organizations_url":"https://api.github.com/users/blackcathacker/orgs","repos_url":"https://api.github.com/users/blackcathacker/repos","events_url":"https://api.github.com/users/blackcathacker/events{/privacy}","received_events_url":"https://api.github.com/users/blackcathacker/received_events","type":"User","site_admin":false},"comments":11,"review_comments":5,"commits":4,"additions":1687,"deletions":2526,"changed_files":146}}