GitHub PullRequestReviewCommentEvent at 2014-07-25 22:27:20
Repository: api
Actor: benogle
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/atom/api/pulls/comments/15427585","id":15427585,"diff_hunk":"@@ -17,36 +17,37 @@ Editor (Extended)                                            called packages ato\n ::selectMarker(marker)                                       1      1        0\n ::decorationsForScreenRowRange(startScreenRow, endScreenRow) 0      0        0\n \n-::getCursor()                                                103    43       6\n ::getCursors()                                               35     19       4\n+::getCursor(index)                                           103    43       6\n+::getLastCursor()                                            new    new    new\n ::getCursorScreenRow()                                       4      4        1\n ::getCursorScopes()                                          11     11       2\n ::bufferRangeForScopeAtCursor(selector)                      4      4        0\n-::moveCursorToBottom()                                       4      1        0\n-::moveCursorToBeginningOfNextParagraph()                     0      0        0\n-::moveCursorToBeginningOfNextWord()                          1      1        1\n-::moveCursorToFirstCharacterOfLine()                         8      7        5\n+::moveToTop()                                                new    new    new\n+::moveToBottom()                                             4      1        0\n+::moveToFirstCharacterOfLine()                               8      7        5\n+::moveToScreenPosition(position)                             new    new    new\n+::moveToBeginningOfNextWord()                                1      1        1\n+::moveToBeginningOfNextParagraph()                           0      0        0\n+::moveToBeginningOfPreviousParagraph()                       new    new    new\n \n ::getSelections()                                            34     20       1\n ::getSelection(index)                                        114    71       6\n ::getLastSelection()                                         2      2        0\n-::getLastSelectionInBuffer()                                 0      0        0\n ::getSelectionsOrderedByBufferPosition()                     2      1        0\n-::addSelectionBelow()                                        0      0        0\n-::addSelectionAbove()                                        0      0        0\n-::splitSelectionsIntoLines()                                 0      0        0","path":"extended-api.txt","position":30,"original_position":30,"commit_id":"35d61aa99dd20fa2a7dc9dbf5d664137777f2e77","original_commit_id":"35d61aa99dd20fa2a7dc9dbf5d664137777f2e77","user":{"login":"benogle","id":69169,"avatar_url":"https://avatars.githubusercontent.com/u/69169?","gravatar_id":"cab0a3e4258a50447357832c922c956b","url":"https://api.github.com/users/benogle","html_url":"https://github.com/benogle","followers_url":"https://api.github.com/users/benogle/followers","following_url":"https://api.github.com/users/benogle/following{/other_user}","gists_url":"https://api.github.com/users/benogle/gists{/gist_id}","starred_url":"https://api.github.com/users/benogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benogle/subscriptions","organizations_url":"https://api.github.com/users/benogle/orgs","repos_url":"https://api.github.com/users/benogle/repos","events_url":"https://api.github.com/users/benogle/events{/privacy}","received_events_url":"https://api.github.com/users/benogle/received_events","type":"User","site_admin":true},"body":"Sure. I just dont think this is well used enough to warrant a delegate.","created_at":"2014-07-25T22:27:20Z","updated_at":"2014-07-25T22:27:20Z","html_url":"https://github.com/atom/api/pull/7#discussion_r15427585","pull_request_url":"https://api.github.com/repos/atom/api/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/atom/api/pulls/comments/15427585"},"html":{"href":"https://github.com/atom/api/pull/7#discussion_r15427585"},"pull_request":{"href":"https://api.github.com/repos/atom/api/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/atom/api/pulls/7","id":18919016,"html_url":"https://github.com/atom/api/pull/7","diff_url":"https://github.com/atom/api/pull/7.diff","patch_url":"https://github.com/atom/api/pull/7.patch","issue_url":"https://api.github.com/repos/atom/api/issues/7","number":7,"state":"open","title":"Cursor / Selection API changes in Editor","user":{"login":"benogle","id":69169,"avatar_url":"https://avatars.githubusercontent.com/u/69169?","gravatar_id":"cab0a3e4258a50447357832c922c956b","url":"https://api.github.com/users/benogle","html_url":"https://github.com/benogle","followers_url":"https://api.github.com/users/benogle/followers","following_url":"https://api.github.com/users/benogle/following{/other_user}","gists_url":"https://api.github.com/users/benogle/gists{/gist_id}","starred_url":"https://api.github.com/users/benogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benogle/subscriptions","organizations_url":"https://api.github.com/users/benogle/orgs","repos_url":"https://api.github.com/users/benogle/repos","events_url":"https://api.github.com/users/benogle/events{/privacy}","received_events_url":"https://api.github.com/users/benogle/received_events","type":"User","site_admin":true},"body":"Here are my suggestions for editing the cursor and selection API. My main goal is consistency and symmetry. I'll pepper with inline comments explaining my decisions.","created_at":"2014-07-25T21:02:35Z","updated_at":"2014-07-25T22:27:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd416a3310c48bba0b2ed1d37e11a43207f9dd87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/api/pulls/7/commits","review_comments_url":"https://api.github.com/repos/atom/api/pulls/7/comments","review_comment_url":"https://api.github.com/repos/atom/api/pulls/comments/{number}","comments_url":"https://api.github.com/repos/atom/api/issues/7/comments","statuses_url":"https://api.github.com/repos/atom/api/statuses/35d61aa99dd20fa2a7dc9dbf5d664137777f2e77","head":{"label":"atom:bo-cursors","ref":"bo-cursors","sha":"35d61aa99dd20fa2a7dc9dbf5d664137777f2e77","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?","gravatar_id":"c3e589b1d091e50d6d9daf5d41287b17","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":22083770,"name":"api","full_name":"atom/api","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?","gravatar_id":"c3e589b1d091e50d6d9daf5d41287b17","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/api","description":"Textual representation of the Atom API","fork":false,"url":"https://api.github.com/repos/atom/api","forks_url":"https://api.github.com/repos/atom/api/forks","keys_url":"https://api.github.com/repos/atom/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/api/teams","hooks_url":"https://api.github.com/repos/atom/api/hooks","issue_events_url":"https://api.github.com/repos/atom/api/issues/events{/number}","events_url":"https://api.github.com/repos/atom/api/events","assignees_url":"https://api.github.com/repos/atom/api/assignees{/user}","branches_url":"https://api.github.com/repos/atom/api/branches{/branch}","tags_url":"https://api.github.com/repos/atom/api/tags","blobs_url":"https://api.github.com/repos/atom/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/api/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/api/languages","stargazers_url":"https://api.github.com/repos/atom/api/stargazers","contributors_url":"https://api.github.com/repos/atom/api/contributors","subscribers_url":"https://api.github.com/repos/atom/api/subscribers","subscription_url":"https://api.github.com/repos/atom/api/subscription","commits_url":"https://api.github.com/repos/atom/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/api/issues/comments/{number}","contents_url":"https://api.github.com/repos/atom/api/contents/{+path}","compare_url":"https://api.github.com/repos/atom/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/api/merges","archive_url":"https://api.github.com/repos/atom/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/api/downloads","issues_url":"https://api.github.com/repos/atom/api/issues{/number}","pulls_url":"https://api.github.com/repos/atom/api/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/api/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/api/labels{/name}","releases_url":"https://api.github.com/repos/atom/api/releases{/id}","created_at":"2014-07-21T23:24:08Z","updated_at":"2014-07-23T02:05:58Z","pushed_at":"2014-07-25T21:01:08Z","git_url":"git://github.com/atom/api.git","ssh_url":"git@github.com:atom/api.git","clone_url":"https://github.com/atom/api.git","svn_url":"https://github.com/atom/api","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"c54f00fad4058eff6c2f1f221c205483a01c986a","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?","gravatar_id":"c3e589b1d091e50d6d9daf5d41287b17","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":22083770,"name":"api","full_name":"atom/api","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?","gravatar_id":"c3e589b1d091e50d6d9daf5d41287b17","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/api","description":"Textual representation of the Atom API","fork":false,"url":"https://api.github.com/repos/atom/api","forks_url":"https://api.github.com/repos/atom/api/forks","keys_url":"https://api.github.com/repos/atom/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/api/teams","hooks_url":"https://api.github.com/repos/atom/api/hooks","issue_events_url":"https://api.github.com/repos/atom/api/issues/events{/number}","events_url":"https://api.github.com/repos/atom/api/events","assignees_url":"https://api.github.com/repos/atom/api/assignees{/user}","branches_url":"https://api.github.com/repos/atom/api/branches{/branch}","tags_url":"https://api.github.com/repos/atom/api/tags","blobs_url":"https://api.github.com/repos/atom/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/api/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/api/languages","stargazers_url":"https://api.github.com/repos/atom/api/stargazers","contributors_url":"https://api.github.com/repos/atom/api/contributors","subscribers_url":"https://api.github.com/repos/atom/api/subscribers","subscription_url":"https://api.github.com/repos/atom/api/subscription","commits_url":"https://api.github.com/repos/atom/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/api/issues/comments/{number}","contents_url":"https://api.github.com/repos/atom/api/contents/{+path}","compare_url":"https://api.github.com/repos/atom/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/api/merges","archive_url":"https://api.github.com/repos/atom/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/api/downloads","issues_url":"https://api.github.com/repos/atom/api/issues{/number}","pulls_url":"https://api.github.com/repos/atom/api/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/api/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/api/labels{/name}","releases_url":"https://api.github.com/repos/atom/api/releases{/id}","created_at":"2014-07-21T23:24:08Z","updated_at":"2014-07-23T02:05:58Z","pushed_at":"2014-07-25T21:01:08Z","git_url":"git://github.com/atom/api.git","ssh_url":"git@github.com:atom/api.git","clone_url":"https://github.com/atom/api.git","svn_url":"https://github.com/atom/api","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/api/pulls/7"},"html":{"href":"https://github.com/atom/api/pull/7"},"issue":{"href":"https://api.github.com/repos/atom/api/issues/7"},"comments":{"href":"https://api.github.com/repos/atom/api/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/api/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/api/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/atom/api/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/atom/api/statuses/35d61aa99dd20fa2a7dc9dbf5d664137777f2e77"}}}}