GitHub PullRequestEvent at 2014-11-20 20:43:44
Repository: java-cas-client
Actor: battags
Payload: {"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/69","id":14585103,"html_url":"https://github.com/Jasig/java-cas-client/pull/69","diff_url":"https://github.com/Jasig/java-cas-client/pull/69.diff","patch_url":"https://github.com/Jasig/java-cas-client/pull/69.patch","issue_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/69","number":69,"state":"closed","locked":false,"title":"CASC-200 Pluggable Configuration Strategy","user":{"login":"battags","id":58269,"avatar_url":"https://avatars.githubusercontent.com/u/58269?v=3","gravatar_id":"","url":"https://api.github.com/users/battags","html_url":"https://github.com/battags","followers_url":"https://api.github.com/users/battags/followers","following_url":"https://api.github.com/users/battags/following{/other_user}","gists_url":"https://api.github.com/users/battags/gists{/gist_id}","starred_url":"https://api.github.com/users/battags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/battags/subscriptions","organizations_url":"https://api.github.com/users/battags/orgs","repos_url":"https://api.github.com/users/battags/repos","events_url":"https://api.github.com/users/battags/events{/privacy}","received_events_url":"https://api.github.com/users/battags/received_events","type":"User","site_admin":false},"body":"First pass at cleaning up configuration.  Some notes/thoughts:\r\n1. No unit tests yet (beyond cleaning up existing). Was waiting until design got the \"ok\".\r\n2. I like using an enum for keys though I'm not 100% sure I like everything being in one enum (though we may have to since some keys are shared)\r\n3. Tried to think of a way to associate the default value with the key definition rather than passed in but couldn't think of a way since they are all different class types.\r\n\r\nThere may be some additional configuration clean up we could do (i.e. writing out retrieved property value in config code versus in each filter, etc.) but I figured let's get this par refactored first :-)  I think this would lend itself nicely to a new type for reading from a property value. (though I didn't implement it yet)","created_at":"2014-04-10T02:41:26Z","updated_at":"2014-11-20T20:43:44Z","closed_at":"2014-11-20T20:43:44Z","merged_at":null,"merge_commit_sha":"f3fbf5bfd5a4e6f1575156ecf4b54e18b99b540e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/69/commits","review_comments_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/69/comments","review_comment_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/69/comments","statuses_url":"https://api.github.com/repos/Jasig/java-cas-client/statuses/b300ffa2feef414ef92db4c91846e9827bc2e12d","head":{"label":"battags:CASC-200","ref":"CASC-200","sha":"b300ffa2feef414ef92db4c91846e9827bc2e12d","user":{"login":"battags","id":58269,"avatar_url":"https://avatars.githubusercontent.com/u/58269?v=3","gravatar_id":"","url":"https://api.github.com/users/battags","html_url":"https://github.com/battags","followers_url":"https://api.github.com/users/battags/followers","following_url":"https://api.github.com/users/battags/following{/other_user}","gists_url":"https://api.github.com/users/battags/gists{/gist_id}","starred_url":"https://api.github.com/users/battags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/battags/subscriptions","organizations_url":"https://api.github.com/users/battags/orgs","repos_url":"https://api.github.com/users/battags/repos","events_url":"https://api.github.com/users/battags/events{/privacy}","received_events_url":"https://api.github.com/users/battags/received_events","type":"User","site_admin":false},"repo":{"id":16935812,"name":"java-cas-client","full_name":"battags/java-cas-client","owner":{"login":"battags","id":58269,"avatar_url":"https://avatars.githubusercontent.com/u/58269?v=3","gravatar_id":"","url":"https://api.github.com/users/battags","html_url":"https://github.com/battags","followers_url":"https://api.github.com/users/battags/followers","following_url":"https://api.github.com/users/battags/following{/other_user}","gists_url":"https://api.github.com/users/battags/gists{/gist_id}","starred_url":"https://api.github.com/users/battags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/battags/subscriptions","organizations_url":"https://api.github.com/users/battags/orgs","repos_url":"https://api.github.com/users/battags/repos","events_url":"https://api.github.com/users/battags/events{/privacy}","received_events_url":"https://api.github.com/users/battags/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/battags/java-cas-client","description":"Jasig Java CAS Client","fork":true,"url":"https://api.github.com/repos/battags/java-cas-client","forks_url":"https://api.github.com/repos/battags/java-cas-client/forks","keys_url":"https://api.github.com/repos/battags/java-cas-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/battags/java-cas-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/battags/java-cas-client/teams","hooks_url":"https://api.github.com/repos/battags/java-cas-client/hooks","issue_events_url":"https://api.github.com/repos/battags/java-cas-client/issues/events{/number}","events_url":"https://api.github.com/repos/battags/java-cas-client/events","assignees_url":"https://api.github.com/repos/battags/java-cas-client/assignees{/user}","branches_url":"https://api.github.com/repos/battags/java-cas-client/branches{/branch}","tags_url":"https://api.github.com/repos/battags/java-cas-client/tags","blobs_url":"https://api.github.com/repos/battags/java-cas-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/battags/java-cas-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/battags/java-cas-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/battags/java-cas-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/battags/java-cas-client/statuses/{sha}","languages_url":"https://api.github.com/repos/battags/java-cas-client/languages","stargazers_url":"https://api.github.com/repos/battags/java-cas-client/stargazers","contributors_url":"https://api.github.com/repos/battags/java-cas-client/contributors","subscribers_url":"https://api.github.com/repos/battags/java-cas-client/subscribers","subscription_url":"https://api.github.com/repos/battags/java-cas-client/subscription","commits_url":"https://api.github.com/repos/battags/java-cas-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/battags/java-cas-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/battags/java-cas-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/battags/java-cas-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/battags/java-cas-client/contents/{+path}","compare_url":"https://api.github.com/repos/battags/java-cas-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/battags/java-cas-client/merges","archive_url":"https://api.github.com/repos/battags/java-cas-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/battags/java-cas-client/downloads","issues_url":"https://api.github.com/repos/battags/java-cas-client/issues{/number}","pulls_url":"https://api.github.com/repos/battags/java-cas-client/pulls{/number}","milestones_url":"https://api.github.com/repos/battags/java-cas-client/milestones{/number}","notifications_url":"https://api.github.com/repos/battags/java-cas-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/battags/java-cas-client/labels{/name}","releases_url":"https://api.github.com/repos/battags/java-cas-client/releases{/id}","created_at":"2014-02-18T03:32:54Z","updated_at":"2014-08-12T01:40:39Z","pushed_at":"2014-11-20T20:36:06Z","git_url":"git://github.com/battags/java-cas-client.git","ssh_url":"git@github.com:battags/java-cas-client.git","clone_url":"https://github.com/battags/java-cas-client.git","svn_url":"https://github.com/battags/java-cas-client","homepage":"https://wiki.jasig.org/display/CASC/CAS+Client+for+Java+3.1","size":1961,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Jasig:master","ref":"master","sha":"88af0917415addfd326b72030a6d9c2598ac2822","user":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"repo":{"id":3645037,"name":"java-cas-client","full_name":"Jasig/java-cas-client","owner":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jasig/java-cas-client","description":"Jasig Java CAS Client","fork":false,"url":"https://api.github.com/repos/Jasig/java-cas-client","forks_url":"https://api.github.com/repos/Jasig/java-cas-client/forks","keys_url":"https://api.github.com/repos/Jasig/java-cas-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jasig/java-cas-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jasig/java-cas-client/teams","hooks_url":"https://api.github.com/repos/Jasig/java-cas-client/hooks","issue_events_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/events{/number}","events_url":"https://api.github.com/repos/Jasig/java-cas-client/events","assignees_url":"https://api.github.com/repos/Jasig/java-cas-client/assignees{/user}","branches_url":"https://api.github.com/repos/Jasig/java-cas-client/branches{/branch}","tags_url":"https://api.github.com/repos/Jasig/java-cas-client/tags","blobs_url":"https://api.github.com/repos/Jasig/java-cas-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jasig/java-cas-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jasig/java-cas-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jasig/java-cas-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jasig/java-cas-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Jasig/java-cas-client/languages","stargazers_url":"https://api.github.com/repos/Jasig/java-cas-client/stargazers","contributors_url":"https://api.github.com/repos/Jasig/java-cas-client/contributors","subscribers_url":"https://api.github.com/repos/Jasig/java-cas-client/subscribers","subscription_url":"https://api.github.com/repos/Jasig/java-cas-client/subscription","commits_url":"https://api.github.com/repos/Jasig/java-cas-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jasig/java-cas-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jasig/java-cas-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/Jasig/java-cas-client/contents/{+path}","compare_url":"https://api.github.com/repos/Jasig/java-cas-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jasig/java-cas-client/merges","archive_url":"https://api.github.com/repos/Jasig/java-cas-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jasig/java-cas-client/downloads","issues_url":"https://api.github.com/repos/Jasig/java-cas-client/issues{/number}","pulls_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Jasig/java-cas-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Jasig/java-cas-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jasig/java-cas-client/labels{/name}","releases_url":"https://api.github.com/repos/Jasig/java-cas-client/releases{/id}","created_at":"2012-03-07T02:29:34Z","updated_at":"2014-11-12T08:01:39Z","pushed_at":"2014-09-06T03:54:46Z","git_url":"git://github.com/Jasig/java-cas-client.git","ssh_url":"git@github.com:Jasig/java-cas-client.git","clone_url":"https://github.com/Jasig/java-cas-client.git","svn_url":"https://github.com/Jasig/java-cas-client","homepage":"https://wiki.jasig.org/display/CASC/CAS+Client+for+Java+3.1","size":3319,"stargazers_count":72,"watchers_count":72,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":11,"forks":78,"open_issues":11,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/69"},"html":{"href":"https://github.com/Jasig/java-cas-client/pull/69"},"issue":{"href":"https://api.github.com/repos/Jasig/java-cas-client/issues/69"},"comments":{"href":"https://api.github.com/repos/Jasig/java-cas-client/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/Jasig/java-cas-client/statuses/b300ffa2feef414ef92db4c91846e9827bc2e12d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":15,"review_comments":0,"commits":2,"additions":590,"deletions":177,"changed_files":20}}