GitHub PullRequestReviewCommentEvent at 2014-10-14 20:09:10
Repository: nit
Actor: Morriar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/privat/nit/pulls/comments/18854771","id":18854771,"diff_hunk":"@@ -177,4 +178,26 @@ redef extern class JavaObject\n \tprivate fun pop_from_local_frame_with_env(jni_env: JniEnv): SELF `{\n \t\treturn (*jni_env)->PopLocalFrame(jni_env, recv);\n \t`}\n+\n+\t# Is `self` null in Java?\n+\t#\n+\t# Since Java type system doesn't have the same `nullable` concept as Nit's,\n+\t# the two system are not directly compatible. Any Nit instances of\n+\t# `JavaObject` may hold a Java `null`.\n+\t#\n+\t# To benefit from the safer type system of Nit, it is recommended to check\n+\t# the return of all extern methods implemented in Java to ensure the value\n+\t# is not a Java null. In case it is, you should replace it by a normal Nit\n+\t# `null`.","path":"lib/java/java.nit","position":56,"original_position":56,"commit_id":"5f05d0c3335cb6b8022f535230de8d4e221ef723","original_commit_id":"5f05d0c3335cb6b8022f535230de8d4e221ef723","user":{"login":"Morriar","id":583144,"avatar_url":"https://avatars.githubusercontent.com/u/583144?v=2","gravatar_id":"","url":"https://api.github.com/users/Morriar","html_url":"https://github.com/Morriar","followers_url":"https://api.github.com/users/Morriar/followers","following_url":"https://api.github.com/users/Morriar/following{/other_user}","gists_url":"https://api.github.com/users/Morriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Morriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morriar/subscriptions","organizations_url":"https://api.github.com/users/Morriar/orgs","repos_url":"https://api.github.com/users/Morriar/repos","events_url":"https://api.github.com/users/Morriar/events{/privacy}","received_events_url":"https://api.github.com/users/Morriar/received_events","type":"User","site_admin":false},"body":"Nit `null` prend des backquotes mais pas Java null?","created_at":"2014-10-14T20:09:10Z","updated_at":"2014-10-14T20:09:10Z","html_url":"https://github.com/privat/nit/pull/821#discussion_r18854771","pull_request_url":"https://api.github.com/repos/privat/nit/pulls/821","_links":{"self":{"href":"https://api.github.com/repos/privat/nit/pulls/comments/18854771"},"html":{"href":"https://github.com/privat/nit/pull/821#discussion_r18854771"},"pull_request":{"href":"https://api.github.com/repos/privat/nit/pulls/821"}}},"pull_request":{"url":"https://api.github.com/repos/privat/nit/pulls/821","id":22709883,"html_url":"https://github.com/privat/nit/pull/821","diff_url":"https://github.com/privat/nit/pull/821.diff","patch_url":"https://github.com/privat/nit/pull/821.patch","issue_url":"https://api.github.com/repos/privat/nit/issues/821","number":821,"state":"open","locked":false,"title":"Useful Java services: redef `JavaObject::to_s` and intro `JavaObject::is_java_null` with doc","user":{"login":"xymus","id":208057,"avatar_url":"https://avatars.githubusercontent.com/u/208057?v=2","gravatar_id":"","url":"https://api.github.com/users/xymus","html_url":"https://github.com/xymus","followers_url":"https://api.github.com/users/xymus/followers","following_url":"https://api.github.com/users/xymus/following{/other_user}","gists_url":"https://api.github.com/users/xymus/gists{/gist_id}","starred_url":"https://api.github.com/users/xymus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymus/subscriptions","organizations_url":"https://api.github.com/users/xymus/orgs","repos_url":"https://api.github.com/users/xymus/repos","events_url":"https://api.github.com/users/xymus/events{/privacy}","received_events_url":"https://api.github.com/users/xymus/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-14T13:10:31Z","updated_at":"2014-10-14T20:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f24d488a9aad261e60a71a669397fea0210b86f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/privat/nit/pulls/821/commits","review_comments_url":"https://api.github.com/repos/privat/nit/pulls/821/comments","review_comment_url":"https://api.github.com/repos/privat/nit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/privat/nit/issues/821/comments","statuses_url":"https://api.github.com/repos/privat/nit/statuses/5f05d0c3335cb6b8022f535230de8d4e221ef723","head":{"label":"xymus:java","ref":"java","sha":"5f05d0c3335cb6b8022f535230de8d4e221ef723","user":{"login":"xymus","id":208057,"avatar_url":"https://avatars.githubusercontent.com/u/208057?v=2","gravatar_id":"","url":"https://api.github.com/users/xymus","html_url":"https://github.com/xymus","followers_url":"https://api.github.com/users/xymus/followers","following_url":"https://api.github.com/users/xymus/following{/other_user}","gists_url":"https://api.github.com/users/xymus/gists{/gist_id}","starred_url":"https://api.github.com/users/xymus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymus/subscriptions","organizations_url":"https://api.github.com/users/xymus/orgs","repos_url":"https://api.github.com/users/xymus/repos","events_url":"https://api.github.com/users/xymus/events{/privacy}","received_events_url":"https://api.github.com/users/xymus/received_events","type":"User","site_admin":false},"repo":{"id":1275771,"name":"nit","full_name":"xymus/nit","owner":{"login":"xymus","id":208057,"avatar_url":"https://avatars.githubusercontent.com/u/208057?v=2","gravatar_id":"","url":"https://api.github.com/users/xymus","html_url":"https://github.com/xymus","followers_url":"https://api.github.com/users/xymus/followers","following_url":"https://api.github.com/users/xymus/following{/other_user}","gists_url":"https://api.github.com/users/xymus/gists{/gist_id}","starred_url":"https://api.github.com/users/xymus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymus/subscriptions","organizations_url":"https://api.github.com/users/xymus/orgs","repos_url":"https://api.github.com/users/xymus/repos","events_url":"https://api.github.com/users/xymus/events{/privacy}","received_events_url":"https://api.github.com/users/xymus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xymus/nit","description":"Nit language","fork":true,"url":"https://api.github.com/repos/xymus/nit","forks_url":"https://api.github.com/repos/xymus/nit/forks","keys_url":"https://api.github.com/repos/xymus/nit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xymus/nit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xymus/nit/teams","hooks_url":"https://api.github.com/repos/xymus/nit/hooks","issue_events_url":"https://api.github.com/repos/xymus/nit/issues/events{/number}","events_url":"https://api.github.com/repos/xymus/nit/events","assignees_url":"https://api.github.com/repos/xymus/nit/assignees{/user}","branches_url":"https://api.github.com/repos/xymus/nit/branches{/branch}","tags_url":"https://api.github.com/repos/xymus/nit/tags","blobs_url":"https://api.github.com/repos/xymus/nit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xymus/nit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xymus/nit/git/refs{/sha}","trees_url":"https://api.github.com/repos/xymus/nit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xymus/nit/statuses/{sha}","languages_url":"https://api.github.com/repos/xymus/nit/languages","stargazers_url":"https://api.github.com/repos/xymus/nit/stargazers","contributors_url":"https://api.github.com/repos/xymus/nit/contributors","subscribers_url":"https://api.github.com/repos/xymus/nit/subscribers","subscription_url":"https://api.github.com/repos/xymus/nit/subscription","commits_url":"https://api.github.com/repos/xymus/nit/commits{/sha}","git_commits_url":"https://api.github.com/repos/xymus/nit/git/commits{/sha}","comments_url":"https://api.github.com/repos/xymus/nit/comments{/number}","issue_comment_url":"https://api.github.com/repos/xymus/nit/issues/comments/{number}","contents_url":"https://api.github.com/repos/xymus/nit/contents/{+path}","compare_url":"https://api.github.com/repos/xymus/nit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xymus/nit/merges","archive_url":"https://api.github.com/repos/xymus/nit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xymus/nit/downloads","issues_url":"https://api.github.com/repos/xymus/nit/issues{/number}","pulls_url":"https://api.github.com/repos/xymus/nit/pulls{/number}","milestones_url":"https://api.github.com/repos/xymus/nit/milestones{/number}","notifications_url":"https://api.github.com/repos/xymus/nit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xymus/nit/labels{/name}","releases_url":"https://api.github.com/repos/xymus/nit/releases{/id}","created_at":"2011-01-20T19:43:31Z","updated_at":"2014-08-27T15:54:20Z","pushed_at":"2014-10-14T13:02:52Z","git_url":"git://github.com/xymus/nit.git","ssh_url":"git@github.com:xymus/nit.git","clone_url":"https://github.com/xymus/nit.git","svn_url":"https://github.com/xymus/nit","homepage":"http://nitlanguage.org","size":54800,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"privat:master","ref":"master","sha":"e43a2bf0b8d43cc6fb23c1247da303fd39c89bfe","user":{"login":"privat","id":135828,"avatar_url":"https://avatars.githubusercontent.com/u/135828?v=2","gravatar_id":"","url":"https://api.github.com/users/privat","html_url":"https://github.com/privat","followers_url":"https://api.github.com/users/privat/followers","following_url":"https://api.github.com/users/privat/following{/other_user}","gists_url":"https://api.github.com/users/privat/gists{/gist_id}","starred_url":"https://api.github.com/users/privat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privat/subscriptions","organizations_url":"https://api.github.com/users/privat/orgs","repos_url":"https://api.github.com/users/privat/repos","events_url":"https://api.github.com/users/privat/events{/privacy}","received_events_url":"https://api.github.com/users/privat/received_events","type":"User","site_admin":false},"repo":{"id":328597,"name":"nit","full_name":"privat/nit","owner":{"login":"privat","id":135828,"avatar_url":"https://avatars.githubusercontent.com/u/135828?v=2","gravatar_id":"","url":"https://api.github.com/users/privat","html_url":"https://github.com/privat","followers_url":"https://api.github.com/users/privat/followers","following_url":"https://api.github.com/users/privat/following{/other_user}","gists_url":"https://api.github.com/users/privat/gists{/gist_id}","starred_url":"https://api.github.com/users/privat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privat/subscriptions","organizations_url":"https://api.github.com/users/privat/orgs","repos_url":"https://api.github.com/users/privat/repos","events_url":"https://api.github.com/users/privat/events{/privacy}","received_events_url":"https://api.github.com/users/privat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/privat/nit","description":"Nit language","fork":false,"url":"https://api.github.com/repos/privat/nit","forks_url":"https://api.github.com/repos/privat/nit/forks","keys_url":"https://api.github.com/repos/privat/nit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/privat/nit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/privat/nit/teams","hooks_url":"https://api.github.com/repos/privat/nit/hooks","issue_events_url":"https://api.github.com/repos/privat/nit/issues/events{/number}","events_url":"https://api.github.com/repos/privat/nit/events","assignees_url":"https://api.github.com/repos/privat/nit/assignees{/user}","branches_url":"https://api.github.com/repos/privat/nit/branches{/branch}","tags_url":"https://api.github.com/repos/privat/nit/tags","blobs_url":"https://api.github.com/repos/privat/nit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/privat/nit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/privat/nit/git/refs{/sha}","trees_url":"https://api.github.com/repos/privat/nit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/privat/nit/statuses/{sha}","languages_url":"https://api.github.com/repos/privat/nit/languages","stargazers_url":"https://api.github.com/repos/privat/nit/stargazers","contributors_url":"https://api.github.com/repos/privat/nit/contributors","subscribers_url":"https://api.github.com/repos/privat/nit/subscribers","subscription_url":"https://api.github.com/repos/privat/nit/subscription","commits_url":"https://api.github.com/repos/privat/nit/commits{/sha}","git_commits_url":"https://api.github.com/repos/privat/nit/git/commits{/sha}","comments_url":"https://api.github.com/repos/privat/nit/comments{/number}","issue_comment_url":"https://api.github.com/repos/privat/nit/issues/comments/{number}","contents_url":"https://api.github.com/repos/privat/nit/contents/{+path}","compare_url":"https://api.github.com/repos/privat/nit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/privat/nit/merges","archive_url":"https://api.github.com/repos/privat/nit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/privat/nit/downloads","issues_url":"https://api.github.com/repos/privat/nit/issues{/number}","pulls_url":"https://api.github.com/repos/privat/nit/pulls{/number}","milestones_url":"https://api.github.com/repos/privat/nit/milestones{/number}","notifications_url":"https://api.github.com/repos/privat/nit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/privat/nit/labels{/name}","releases_url":"https://api.github.com/repos/privat/nit/releases{/id}","created_at":"2009-10-06T15:03:00Z","updated_at":"2014-09-04T16:55:14Z","pushed_at":"2014-10-13T22:28:52Z","git_url":"git://github.com/privat/nit.git","ssh_url":"git@github.com:privat/nit.git","clone_url":"https://github.com/privat/nit.git","svn_url":"https://github.com/privat/nit","homepage":"http://nitlanguage.org","size":76496,"stargazers_count":23,"watchers_count":23,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":70,"forks":29,"open_issues":70,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/privat/nit/pulls/821"},"html":{"href":"https://github.com/privat/nit/pull/821"},"issue":{"href":"https://api.github.com/repos/privat/nit/issues/821"},"comments":{"href":"https://api.github.com/repos/privat/nit/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/privat/nit/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/privat/nit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/privat/nit/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/privat/nit/statuses/5f05d0c3335cb6b8022f535230de8d4e221ef723"}}}}