GitHub PullRequestEvent at 2014-02-18 15:48:21
Repository: libmesh
Actor: jwpeterson
Payload: {"action":"opened","number":205,"pull_request":{"url":"https://api.github.com/repos/libMesh/libmesh/pulls/205","id":12656278,"html_url":"https://github.com/libMesh/libmesh/pull/205","diff_url":"https://github.com/libMesh/libmesh/pull/205.diff","patch_url":"https://github.com/libMesh/libmesh/pull/205.patch","issue_url":"https://api.github.com/repos/libMesh/libmesh/issues/205","number":205,"state":"open","title":"Move all enumerations into the libMesh namespace","user":{"login":"jwpeterson","id":1775907,"avatar_url":"https://gravatar.com/avatar/18dacf1f48a070308405a4465517ef26?d=https%3A%2F%2Fidenticons.github.com%2Fc2a383de2776c75a984367c5c5255f68.png&r=x","gravatar_id":"18dacf1f48a070308405a4465517ef26","url":"https://api.github.com/users/jwpeterson","html_url":"https://github.com/jwpeterson","followers_url":"https://api.github.com/users/jwpeterson/followers","following_url":"https://api.github.com/users/jwpeterson/following{/other_user}","gists_url":"https://api.github.com/users/jwpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jwpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwpeterson/subscriptions","organizations_url":"https://api.github.com/users/jwpeterson/orgs","repos_url":"https://api.github.com/users/jwpeterson/repos","events_url":"https://api.github.com/users/jwpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jwpeterson/received_events","type":"User","site_admin":false},"body":"We've been doing something kind of bad for a while now: all of our enumeration header files had\r\n```\r\nusing namespace libMeshEnums;\r\n```\r\nin them, violating the general rule of not putting `using` declarations in headers.  We actually ran into a namespace collision while trying to create a class called \"VTK\", which collided with one of the IOPackage enumerations.\r\n\r\nThis patch moves the enumerations into the libMesh namespace and cleanses the rest of the library of the libMeshEnums namespace.  It's possible that this change will affect applications, but the fix is trivial: just remove `libMeshEnums::` wherever it appears in your code.\r\n\r\nThis was actually Roy's idea so I've discussed it with him already, but I wanted to give others the chance to comment... for example, does anyone know why we had this separate namespace in the first place?","created_at":"2014-02-18T15:48:21Z","updated_at":"2014-02-18T15:48:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libMesh/libmesh/pulls/205/commits","review_comments_url":"https://api.github.com/repos/libMesh/libmesh/pulls/205/comments","review_comment_url":"https://api.github.com/repos/libMesh/libmesh/pulls/comments/{number}","comments_url":"https://api.github.com/repos/libMesh/libmesh/issues/205/comments","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/703107ef1f6496f6472e80e6e601c8c83119564e","head":{"label":"libMesh:enum_move","ref":"enum_move","sha":"703107ef1f6496f6472e80e6e601c8c83119564e","user":{"login":"libMesh","id":2366757,"avatar_url":"https://gravatar.com/avatar/b7aebe1b0528b6a1c6e87fec4902e805?d=https%3A%2F%2Fidenticons.github.com%2Fbfccf3d55860b4c897647bc0200d2f74.png&r=x","gravatar_id":"b7aebe1b0528b6a1c6e87fec4902e805","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"repo":{"id":5850234,"name":"libmesh","full_name":"libMesh/libmesh","owner":{"login":"libMesh","id":2366757,"avatar_url":"https://gravatar.com/avatar/b7aebe1b0528b6a1c6e87fec4902e805?d=https%3A%2F%2Fidenticons.github.com%2Fbfccf3d55860b4c897647bc0200d2f74.png&r=x","gravatar_id":"b7aebe1b0528b6a1c6e87fec4902e805","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libMesh/libmesh","description":"libMesh github repository","fork":false,"url":"https://api.github.com/repos/libMesh/libmesh","forks_url":"https://api.github.com/repos/libMesh/libmesh/forks","keys_url":"https://api.github.com/repos/libMesh/libmesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libMesh/libmesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libMesh/libmesh/teams","hooks_url":"https://api.github.com/repos/libMesh/libmesh/hooks","issue_events_url":"https://api.github.com/repos/libMesh/libmesh/issues/events{/number}","events_url":"https://api.github.com/repos/libMesh/libmesh/events","assignees_url":"https://api.github.com/repos/libMesh/libmesh/assignees{/user}","branches_url":"https://api.github.com/repos/libMesh/libmesh/branches{/branch}","tags_url":"https://api.github.com/repos/libMesh/libmesh/tags","blobs_url":"https://api.github.com/repos/libMesh/libmesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libMesh/libmesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libMesh/libmesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/libMesh/libmesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/{sha}","languages_url":"https://api.github.com/repos/libMesh/libmesh/languages","stargazers_url":"https://api.github.com/repos/libMesh/libmesh/stargazers","contributors_url":"https://api.github.com/repos/libMesh/libmesh/contributors","subscribers_url":"https://api.github.com/repos/libMesh/libmesh/subscribers","subscription_url":"https://api.github.com/repos/libMesh/libmesh/subscription","commits_url":"https://api.github.com/repos/libMesh/libmesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/libMesh/libmesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/libMesh/libmesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/libMesh/libmesh/issues/comments/{number}","contents_url":"https://api.github.com/repos/libMesh/libmesh/contents/{+path}","compare_url":"https://api.github.com/repos/libMesh/libmesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libMesh/libmesh/merges","archive_url":"https://api.github.com/repos/libMesh/libmesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libMesh/libmesh/downloads","issues_url":"https://api.github.com/repos/libMesh/libmesh/issues{/number}","pulls_url":"https://api.github.com/repos/libMesh/libmesh/pulls{/number}","milestones_url":"https://api.github.com/repos/libMesh/libmesh/milestones{/number}","notifications_url":"https://api.github.com/repos/libMesh/libmesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libMesh/libmesh/labels{/name}","releases_url":"https://api.github.com/repos/libMesh/libmesh/releases{/id}","created_at":"2012-09-18T02:12:18Z","updated_at":"2014-02-18T15:48:21Z","pushed_at":"2014-02-18T15:42:56Z","git_url":"git://github.com/libMesh/libmesh.git","ssh_url":"git@github.com:libMesh/libmesh.git","clone_url":"https://github.com/libMesh/libmesh.git","svn_url":"https://github.com/libMesh/libmesh","homepage":"http://libmesh.sourceforge.net","size":141403,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":31,"mirror_url":null,"open_issues_count":31,"forks":31,"open_issues":31,"watchers":37,"default_branch":"master","master_branch":"master"}},"base":{"label":"libMesh:master","ref":"master","sha":"d750e8c1586bf71f776f671403c4e8a077aafd9a","user":{"login":"libMesh","id":2366757,"avatar_url":"https://gravatar.com/avatar/b7aebe1b0528b6a1c6e87fec4902e805?d=https%3A%2F%2Fidenticons.github.com%2Fbfccf3d55860b4c897647bc0200d2f74.png&r=x","gravatar_id":"b7aebe1b0528b6a1c6e87fec4902e805","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"repo":{"id":5850234,"name":"libmesh","full_name":"libMesh/libmesh","owner":{"login":"libMesh","id":2366757,"avatar_url":"https://gravatar.com/avatar/b7aebe1b0528b6a1c6e87fec4902e805?d=https%3A%2F%2Fidenticons.github.com%2Fbfccf3d55860b4c897647bc0200d2f74.png&r=x","gravatar_id":"b7aebe1b0528b6a1c6e87fec4902e805","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libMesh/libmesh","description":"libMesh github repository","fork":false,"url":"https://api.github.com/repos/libMesh/libmesh","forks_url":"https://api.github.com/repos/libMesh/libmesh/forks","keys_url":"https://api.github.com/repos/libMesh/libmesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libMesh/libmesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libMesh/libmesh/teams","hooks_url":"https://api.github.com/repos/libMesh/libmesh/hooks","issue_events_url":"https://api.github.com/repos/libMesh/libmesh/issues/events{/number}","events_url":"https://api.github.com/repos/libMesh/libmesh/events","assignees_url":"https://api.github.com/repos/libMesh/libmesh/assignees{/user}","branches_url":"https://api.github.com/repos/libMesh/libmesh/branches{/branch}","tags_url":"https://api.github.com/repos/libMesh/libmesh/tags","blobs_url":"https://api.github.com/repos/libMesh/libmesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libMesh/libmesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libMesh/libmesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/libMesh/libmesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/{sha}","languages_url":"https://api.github.com/repos/libMesh/libmesh/languages","stargazers_url":"https://api.github.com/repos/libMesh/libmesh/stargazers","contributors_url":"https://api.github.com/repos/libMesh/libmesh/contributors","subscribers_url":"https://api.github.com/repos/libMesh/libmesh/subscribers","subscription_url":"https://api.github.com/repos/libMesh/libmesh/subscription","commits_url":"https://api.github.com/repos/libMesh/libmesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/libMesh/libmesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/libMesh/libmesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/libMesh/libmesh/issues/comments/{number}","contents_url":"https://api.github.com/repos/libMesh/libmesh/contents/{+path}","compare_url":"https://api.github.com/repos/libMesh/libmesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libMesh/libmesh/merges","archive_url":"https://api.github.com/repos/libMesh/libmesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libMesh/libmesh/downloads","issues_url":"https://api.github.com/repos/libMesh/libmesh/issues{/number}","pulls_url":"https://api.github.com/repos/libMesh/libmesh/pulls{/number}","milestones_url":"https://api.github.com/repos/libMesh/libmesh/milestones{/number}","notifications_url":"https://api.github.com/repos/libMesh/libmesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libMesh/libmesh/labels{/name}","releases_url":"https://api.github.com/repos/libMesh/libmesh/releases{/id}","created_at":"2012-09-18T02:12:18Z","updated_at":"2014-02-18T15:48:21Z","pushed_at":"2014-02-18T15:42:56Z","git_url":"git://github.com/libMesh/libmesh.git","ssh_url":"git@github.com:libMesh/libmesh.git","clone_url":"https://github.com/libMesh/libmesh.git","svn_url":"https://github.com/libMesh/libmesh","homepage":"http://libmesh.sourceforge.net","size":141403,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":31,"mirror_url":null,"open_issues_count":31,"forks":31,"open_issues":31,"watchers":37,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/205"},"html":{"href":"https://github.com/libMesh/libmesh/pull/205"},"issue":{"href":"https://api.github.com/repos/libMesh/libmesh/issues/205"},"comments":{"href":"https://api.github.com/repos/libMesh/libmesh/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/libMesh/libmesh/statuses/703107ef1f6496f6472e80e6e601c8c83119564e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":113,"deletions":195,"changed_files":35}}