GitHub PullRequestReviewCommentEvent at 2014-10-27 16:15:56
Repository: debrief
Actor: pecko
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/debrief/debrief/pulls/comments/19415745","id":19415745,"diff_hunk":"@@ -251,4 +256,20 @@ public void stop(final BundleContext context) throws Exception\n \t\tplugin = null;\r\n \t\tresourceBundle = null;\r\n \t}\r\n+\t\r\n+\tpublic long getResetPerspectivePreference() {\r\n+\t\treturn getDefault().getPreferenceStore().getLong(RESET_PERSPECTIVE);\r\n+\t}\r\n+\t\r","path":"org.mwc.debrief.core/src/org/mwc/debrief/core/DebriefPlugin.java","position":27,"original_position":27,"commit_id":"449900b1570d923a903189d1813c0dd1c19ed1c4","original_commit_id":"449900b1570d923a903189d1813c0dd1c19ed1c4","user":{"login":"pecko","id":534584,"avatar_url":"https://avatars.githubusercontent.com/u/534584?v=2","gravatar_id":"","url":"https://api.github.com/users/pecko","html_url":"https://github.com/pecko","followers_url":"https://api.github.com/users/pecko/followers","following_url":"https://api.github.com/users/pecko/following{/other_user}","gists_url":"https://api.github.com/users/pecko/gists{/gist_id}","starred_url":"https://api.github.com/users/pecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecko/subscriptions","organizations_url":"https://api.github.com/users/pecko/orgs","repos_url":"https://api.github.com/users/pecko/repos","events_url":"https://api.github.com/users/pecko/events{/privacy}","received_events_url":"https://api.github.com/users/pecko/received_events","type":"User","site_admin":false},"body":"> in the next method you use two very different ways of deciding if a string contains true/false.\r\n\r\nI just add the system property and don't look at how it done before.\r\nFirst case - we check if it's added from command line (for tests and tycho build only). We just test if it's set to false. \r\nIn another case we check standard Debrief preferences (default=true)\r\n\r\n> Could you also insert a comment to explain what is happening in the separate getProperty() and getString() calls?\r\n\r\nThe system property has been used for test in order to suppress showing the dialog while testing. See pom.xml in root where it is added as -DcreateProject=false\r\n\r\nWill add comment in the code.","created_at":"2014-10-27T16:15:56Z","updated_at":"2014-10-27T16:15:56Z","html_url":"https://github.com/debrief/debrief/pull/894#discussion_r19415745","pull_request_url":"https://api.github.com/repos/debrief/debrief/pulls/894","_links":{"self":{"href":"https://api.github.com/repos/debrief/debrief/pulls/comments/19415745"},"html":{"href":"https://github.com/debrief/debrief/pull/894#discussion_r19415745"},"pull_request":{"href":"https://api.github.com/repos/debrief/debrief/pulls/894"}}},"pull_request":{"url":"https://api.github.com/repos/debrief/debrief/pulls/894","id":23312645,"html_url":"https://github.com/debrief/debrief/pull/894","diff_url":"https://github.com/debrief/debrief/pull/894.diff","patch_url":"https://github.com/debrief/debrief/pull/894.patch","issue_url":"https://api.github.com/repos/debrief/debrief/issues/894","number":894,"state":"open","locked":false,"title":"Issue #887/#888","user":{"login":"pecko","id":534584,"avatar_url":"https://avatars.githubusercontent.com/u/534584?v=2","gravatar_id":"","url":"https://api.github.com/users/pecko","html_url":"https://github.com/pecko","followers_url":"https://api.github.com/users/pecko/followers","following_url":"https://api.github.com/users/pecko/following{/other_user}","gists_url":"https://api.github.com/users/pecko/gists{/gist_id}","starred_url":"https://api.github.com/users/pecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecko/subscriptions","organizations_url":"https://api.github.com/users/pecko/orgs","repos_url":"https://api.github.com/users/pecko/repos","events_url":"https://api.github.com/users/pecko/events{/privacy}","received_events_url":"https://api.github.com/users/pecko/received_events","type":"User","site_admin":false},"body":"The PR includes fixes for #887 and #888 (file vesron).","created_at":"2014-10-24T17:50:08Z","updated_at":"2014-10-27T16:15:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0010598dd14306e7c0ceb217276a8f2be5781bc8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/debrief/debrief/pulls/894/commits","review_comments_url":"https://api.github.com/repos/debrief/debrief/pulls/894/comments","review_comment_url":"https://api.github.com/repos/debrief/debrief/pulls/comments/{number}","comments_url":"https://api.github.com/repos/debrief/debrief/issues/894/comments","statuses_url":"https://api.github.com/repos/debrief/debrief/statuses/449900b1570d923a903189d1813c0dd1c19ed1c4","head":{"label":"pecko:issue888","ref":"issue888","sha":"449900b1570d923a903189d1813c0dd1c19ed1c4","user":{"login":"pecko","id":534584,"avatar_url":"https://avatars.githubusercontent.com/u/534584?v=2","gravatar_id":"","url":"https://api.github.com/users/pecko","html_url":"https://github.com/pecko","followers_url":"https://api.github.com/users/pecko/followers","following_url":"https://api.github.com/users/pecko/following{/other_user}","gists_url":"https://api.github.com/users/pecko/gists{/gist_id}","starred_url":"https://api.github.com/users/pecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecko/subscriptions","organizations_url":"https://api.github.com/users/pecko/orgs","repos_url":"https://api.github.com/users/pecko/repos","events_url":"https://api.github.com/users/pecko/events{/privacy}","received_events_url":"https://api.github.com/users/pecko/received_events","type":"User","site_admin":false},"repo":{"id":19978491,"name":"debrief","full_name":"pecko/debrief","owner":{"login":"pecko","id":534584,"avatar_url":"https://avatars.githubusercontent.com/u/534584?v=2","gravatar_id":"","url":"https://api.github.com/users/pecko","html_url":"https://github.com/pecko","followers_url":"https://api.github.com/users/pecko/followers","following_url":"https://api.github.com/users/pecko/following{/other_user}","gists_url":"https://api.github.com/users/pecko/gists{/gist_id}","starred_url":"https://api.github.com/users/pecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecko/subscriptions","organizations_url":"https://api.github.com/users/pecko/orgs","repos_url":"https://api.github.com/users/pecko/repos","events_url":"https://api.github.com/users/pecko/events{/privacy}","received_events_url":"https://api.github.com/users/pecko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pecko/debrief","description":"Maritime Analysis Tool","fork":true,"url":"https://api.github.com/repos/pecko/debrief","forks_url":"https://api.github.com/repos/pecko/debrief/forks","keys_url":"https://api.github.com/repos/pecko/debrief/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pecko/debrief/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pecko/debrief/teams","hooks_url":"https://api.github.com/repos/pecko/debrief/hooks","issue_events_url":"https://api.github.com/repos/pecko/debrief/issues/events{/number}","events_url":"https://api.github.com/repos/pecko/debrief/events","assignees_url":"https://api.github.com/repos/pecko/debrief/assignees{/user}","branches_url":"https://api.github.com/repos/pecko/debrief/branches{/branch}","tags_url":"https://api.github.com/repos/pecko/debrief/tags","blobs_url":"https://api.github.com/repos/pecko/debrief/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pecko/debrief/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pecko/debrief/git/refs{/sha}","trees_url":"https://api.github.com/repos/pecko/debrief/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pecko/debrief/statuses/{sha}","languages_url":"https://api.github.com/repos/pecko/debrief/languages","stargazers_url":"https://api.github.com/repos/pecko/debrief/stargazers","contributors_url":"https://api.github.com/repos/pecko/debrief/contributors","subscribers_url":"https://api.github.com/repos/pecko/debrief/subscribers","subscription_url":"https://api.github.com/repos/pecko/debrief/subscription","commits_url":"https://api.github.com/repos/pecko/debrief/commits{/sha}","git_commits_url":"https://api.github.com/repos/pecko/debrief/git/commits{/sha}","comments_url":"https://api.github.com/repos/pecko/debrief/comments{/number}","issue_comment_url":"https://api.github.com/repos/pecko/debrief/issues/comments/{number}","contents_url":"https://api.github.com/repos/pecko/debrief/contents/{+path}","compare_url":"https://api.github.com/repos/pecko/debrief/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pecko/debrief/merges","archive_url":"https://api.github.com/repos/pecko/debrief/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pecko/debrief/downloads","issues_url":"https://api.github.com/repos/pecko/debrief/issues{/number}","pulls_url":"https://api.github.com/repos/pecko/debrief/pulls{/number}","milestones_url":"https://api.github.com/repos/pecko/debrief/milestones{/number}","notifications_url":"https://api.github.com/repos/pecko/debrief/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pecko/debrief/labels{/name}","releases_url":"https://api.github.com/repos/pecko/debrief/releases{/id}","created_at":"2014-05-20T11:33:47Z","updated_at":"2014-06-27T09:01:25Z","pushed_at":"2014-10-27T15:51:19Z","git_url":"git://github.com/pecko/debrief.git","ssh_url":"git@github.com:pecko/debrief.git","clone_url":"https://github.com/pecko/debrief.git","svn_url":"https://github.com/pecko/debrief","homepage":null,"size":214680,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"debrief:master","ref":"master","sha":"adca53577412b6e340ae3150d3df7edb7986b910","user":{"login":"debrief","id":7665856,"avatar_url":"https://avatars.githubusercontent.com/u/7665856?v=2","gravatar_id":"","url":"https://api.github.com/users/debrief","html_url":"https://github.com/debrief","followers_url":"https://api.github.com/users/debrief/followers","following_url":"https://api.github.com/users/debrief/following{/other_user}","gists_url":"https://api.github.com/users/debrief/gists{/gist_id}","starred_url":"https://api.github.com/users/debrief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debrief/subscriptions","organizations_url":"https://api.github.com/users/debrief/orgs","repos_url":"https://api.github.com/users/debrief/repos","events_url":"https://api.github.com/users/debrief/events{/privacy}","received_events_url":"https://api.github.com/users/debrief/received_events","type":"Organization","site_admin":false},"repo":{"id":19954711,"name":"debrief","full_name":"debrief/debrief","owner":{"login":"debrief","id":7665856,"avatar_url":"https://avatars.githubusercontent.com/u/7665856?v=2","gravatar_id":"","url":"https://api.github.com/users/debrief","html_url":"https://github.com/debrief","followers_url":"https://api.github.com/users/debrief/followers","following_url":"https://api.github.com/users/debrief/following{/other_user}","gists_url":"https://api.github.com/users/debrief/gists{/gist_id}","starred_url":"https://api.github.com/users/debrief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debrief/subscriptions","organizations_url":"https://api.github.com/users/debrief/orgs","repos_url":"https://api.github.com/users/debrief/repos","events_url":"https://api.github.com/users/debrief/events{/privacy}","received_events_url":"https://api.github.com/users/debrief/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/debrief/debrief","description":"The Open Source workbench for Maritime Analysis","fork":false,"url":"https://api.github.com/repos/debrief/debrief","forks_url":"https://api.github.com/repos/debrief/debrief/forks","keys_url":"https://api.github.com/repos/debrief/debrief/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debrief/debrief/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debrief/debrief/teams","hooks_url":"https://api.github.com/repos/debrief/debrief/hooks","issue_events_url":"https://api.github.com/repos/debrief/debrief/issues/events{/number}","events_url":"https://api.github.com/repos/debrief/debrief/events","assignees_url":"https://api.github.com/repos/debrief/debrief/assignees{/user}","branches_url":"https://api.github.com/repos/debrief/debrief/branches{/branch}","tags_url":"https://api.github.com/repos/debrief/debrief/tags","blobs_url":"https://api.github.com/repos/debrief/debrief/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debrief/debrief/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debrief/debrief/git/refs{/sha}","trees_url":"https://api.github.com/repos/debrief/debrief/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debrief/debrief/statuses/{sha}","languages_url":"https://api.github.com/repos/debrief/debrief/languages","stargazers_url":"https://api.github.com/repos/debrief/debrief/stargazers","contributors_url":"https://api.github.com/repos/debrief/debrief/contributors","subscribers_url":"https://api.github.com/repos/debrief/debrief/subscribers","subscription_url":"https://api.github.com/repos/debrief/debrief/subscription","commits_url":"https://api.github.com/repos/debrief/debrief/commits{/sha}","git_commits_url":"https://api.github.com/repos/debrief/debrief/git/commits{/sha}","comments_url":"https://api.github.com/repos/debrief/debrief/comments{/number}","issue_comment_url":"https://api.github.com/repos/debrief/debrief/issues/comments/{number}","contents_url":"https://api.github.com/repos/debrief/debrief/contents/{+path}","compare_url":"https://api.github.com/repos/debrief/debrief/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debrief/debrief/merges","archive_url":"https://api.github.com/repos/debrief/debrief/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debrief/debrief/downloads","issues_url":"https://api.github.com/repos/debrief/debrief/issues{/number}","pulls_url":"https://api.github.com/repos/debrief/debrief/pulls{/number}","milestones_url":"https://api.github.com/repos/debrief/debrief/milestones{/number}","notifications_url":"https://api.github.com/repos/debrief/debrief/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debrief/debrief/labels{/name}","releases_url":"https://api.github.com/repos/debrief/debrief/releases{/id}","created_at":"2014-05-19T19:27:32Z","updated_at":"2014-09-05T07:47:51Z","pushed_at":"2014-10-27T14:44:37Z","git_url":"git://github.com/debrief/debrief.git","ssh_url":"git@github.com:debrief/debrief.git","clone_url":"https://github.com/debrief/debrief.git","svn_url":"https://github.com/debrief/debrief","homepage":"www.debrief.info","size":217857,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":100,"forks":4,"open_issues":100,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/debrief/debrief/pulls/894"},"html":{"href":"https://github.com/debrief/debrief/pull/894"},"issue":{"href":"https://api.github.com/repos/debrief/debrief/issues/894"},"comments":{"href":"https://api.github.com/repos/debrief/debrief/issues/894/comments"},"review_comments":{"href":"https://api.github.com/repos/debrief/debrief/pulls/894/comments"},"review_comment":{"href":"https://api.github.com/repos/debrief/debrief/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/debrief/debrief/pulls/894/commits"},"statuses":{"href":"https://api.github.com/repos/debrief/debrief/statuses/449900b1570d923a903189d1813c0dd1c19ed1c4"}}}}