GitHub PullRequestReviewCommentEvent at 2014-07-29 20:26:49
Repository: chef-rfc
Actor: lamont-granquist
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/chef-rfc/pulls/comments/15549804","id":15549804,"diff_hunk":"@@ -0,0 +1,81 @@\n+---\n+RFC:\n+Author: Serdar Sutay <serdar@getchef.com>\n+Status: Draft\n+Type: Process\n+---\n+\n+# Chef Github Issues Workflow\n+\n+Here at Chef, we track our issues and contributions using [Github Issues](https://github.com/opscode/chef/issues). This RFC codifies the workflow we're using while maintaining our projects in order to make a few things clear:\n+\n+* State of a contribution (pull request - PR) is visible when a user checks it out.\n+* Chef maintainers can see the list of PRs which needs review.\n+* Chef maintainers can see the list of issues to investigate.\n+\n+## Workflow\n+\n+![Chef Github Issues Workflow](./GithubIssuesWorkflow.png)\n+\n+\n+### Common Steps for Issues & PRs\n+\n+The first step is to identify the subcomponent for which the issue or PR belongs to. This step is the responsibility of **Core Chef** Maintainers.\n+\n+Once the subcomponent is identified, the rest of the workflow is the responsibility of the maintainers of the identified subcomponent.\n+\n+### Issues Workflow\n+\n+Issues workflow can be broken down into these high level steps:\n+\n+1. Understand the issue and determine the resolution.\n+1. Identify the major version the issue should be fixed in.\n+1. Label the issue to indicate completeness of **Triage** process.\n+\n+After this point any fix for an issue should follow the contribution workflow.\n+\n+#### Additional Policy\n+\n+* If an issue is not updated for more than a year, the issue is retired by closing.","path":"rfcXXX-github-issues-workflow.md","position":39,"original_position":39,"commit_id":"2ab101a59bccbc3dbf0cf07e5b710f35f8f7ed76","original_commit_id":"5dc153552b1823d1a3c109246da423c31c0fe3de","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?","gravatar_id":"84c874984f69ef596764255efcd79113","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"body":"One problem I have with this is that bugs and issues don't fix themselves.  Clearly if a bug has lingered for a year its either not valid, not super-important or else its very hard to fix or requires breaking changes -- but those are all very different things.","created_at":"2014-07-29T20:26:49Z","updated_at":"2014-07-29T20:26:49Z","html_url":"https://github.com/opscode/chef-rfc/pull/36#discussion_r15549804","pull_request_url":"https://api.github.com/repos/opscode/chef-rfc/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/opscode/chef-rfc/pulls/comments/15549804"},"html":{"href":"https://github.com/opscode/chef-rfc/pull/36#discussion_r15549804"},"pull_request":{"href":"https://api.github.com/repos/opscode/chef-rfc/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/chef-rfc/pulls/36","id":19044688,"html_url":"https://github.com/opscode/chef-rfc/pull/36","diff_url":"https://github.com/opscode/chef-rfc/pull/36.diff","patch_url":"https://github.com/opscode/chef-rfc/pull/36.patch","issue_url":"https://api.github.com/repos/opscode/chef-rfc/issues/36","number":36,"state":"open","title":"GitHub Issues Workflow for Chef","user":{"login":"sersut","id":1695955,"avatar_url":"https://avatars.githubusercontent.com/u/1695955?","gravatar_id":"96f67e1f6270e46bfc95c323d4e53fff","url":"https://api.github.com/users/sersut","html_url":"https://github.com/sersut","followers_url":"https://api.github.com/users/sersut/followers","following_url":"https://api.github.com/users/sersut/following{/other_user}","gists_url":"https://api.github.com/users/sersut/gists{/gist_id}","starred_url":"https://api.github.com/users/sersut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sersut/subscriptions","organizations_url":"https://api.github.com/users/sersut/orgs","repos_url":"https://api.github.com/users/sersut/repos","events_url":"https://api.github.com/users/sersut/events{/privacy}","received_events_url":"https://api.github.com/users/sersut/received_events","type":"User","site_admin":false},"body":"This RFC codifies the workflow of Chef maintainers while maintaining issues and contributions for Chef.\r\n\r\nSpecial thanks to @btm / @lamont-granquist / @danielsdeleo / @mcquin / @adamedx / @jdmundrawala  who has helped put the first version come together.","created_at":"2014-07-29T18:22:40Z","updated_at":"2014-07-29T20:26:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75dd17a6a95a8c58e11046dbb502dfc8fe0a9e89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/chef-rfc/pulls/36/commits","review_comments_url":"https://api.github.com/repos/opscode/chef-rfc/pulls/36/comments","review_comment_url":"https://api.github.com/repos/opscode/chef-rfc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/chef-rfc/issues/36/comments","statuses_url":"https://api.github.com/repos/opscode/chef-rfc/statuses/2ab101a59bccbc3dbf0cf07e5b710f35f8f7ed76","head":{"label":"opscode:sersut/github-workflow","ref":"sersut/github-workflow","sha":"2ab101a59bccbc3dbf0cf07e5b710f35f8f7ed76","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":15090814,"name":"chef-rfc","full_name":"opscode/chef-rfc","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/chef-rfc","description":"Public RFCs for Chef and related projects","fork":false,"url":"https://api.github.com/repos/opscode/chef-rfc","forks_url":"https://api.github.com/repos/opscode/chef-rfc/forks","keys_url":"https://api.github.com/repos/opscode/chef-rfc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/chef-rfc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/chef-rfc/teams","hooks_url":"https://api.github.com/repos/opscode/chef-rfc/hooks","issue_events_url":"https://api.github.com/repos/opscode/chef-rfc/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/chef-rfc/events","assignees_url":"https://api.github.com/repos/opscode/chef-rfc/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/chef-rfc/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/chef-rfc/tags","blobs_url":"https://api.github.com/repos/opscode/chef-rfc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/chef-rfc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/chef-rfc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/chef-rfc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/chef-rfc/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/chef-rfc/languages","stargazers_url":"https://api.github.com/repos/opscode/chef-rfc/stargazers","contributors_url":"https://api.github.com/repos/opscode/chef-rfc/contributors","subscribers_url":"https://api.github.com/repos/opscode/chef-rfc/subscribers","subscription_url":"https://api.github.com/repos/opscode/chef-rfc/subscription","commits_url":"https://api.github.com/repos/opscode/chef-rfc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/chef-rfc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/chef-rfc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/chef-rfc/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/chef-rfc/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/chef-rfc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/chef-rfc/merges","archive_url":"https://api.github.com/repos/opscode/chef-rfc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/chef-rfc/downloads","issues_url":"https://api.github.com/repos/opscode/chef-rfc/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/chef-rfc/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/chef-rfc/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/chef-rfc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/chef-rfc/labels{/name}","releases_url":"https://api.github.com/repos/opscode/chef-rfc/releases{/id}","created_at":"2013-12-10T22:10:56Z","updated_at":"2014-07-29T18:53:59Z","pushed_at":"2014-07-29T18:29:06Z","git_url":"git://github.com/opscode/chef-rfc.git","ssh_url":"git@github.com:opscode/chef-rfc.git","clone_url":"https://github.com/opscode/chef-rfc.git","svn_url":"https://github.com/opscode/chef-rfc","homepage":null,"size":1310,"stargazers_count":35,"watchers_count":35,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":26,"forks":14,"open_issues":26,"watchers":35,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"782a92dc4fa69dd311cbb4a9741515c6c0af1e3b","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":15090814,"name":"chef-rfc","full_name":"opscode/chef-rfc","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/chef-rfc","description":"Public RFCs for Chef and related projects","fork":false,"url":"https://api.github.com/repos/opscode/chef-rfc","forks_url":"https://api.github.com/repos/opscode/chef-rfc/forks","keys_url":"https://api.github.com/repos/opscode/chef-rfc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/chef-rfc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/chef-rfc/teams","hooks_url":"https://api.github.com/repos/opscode/chef-rfc/hooks","issue_events_url":"https://api.github.com/repos/opscode/chef-rfc/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/chef-rfc/events","assignees_url":"https://api.github.com/repos/opscode/chef-rfc/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/chef-rfc/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/chef-rfc/tags","blobs_url":"https://api.github.com/repos/opscode/chef-rfc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/chef-rfc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/chef-rfc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/chef-rfc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/chef-rfc/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/chef-rfc/languages","stargazers_url":"https://api.github.com/repos/opscode/chef-rfc/stargazers","contributors_url":"https://api.github.com/repos/opscode/chef-rfc/contributors","subscribers_url":"https://api.github.com/repos/opscode/chef-rfc/subscribers","subscription_url":"https://api.github.com/repos/opscode/chef-rfc/subscription","commits_url":"https://api.github.com/repos/opscode/chef-rfc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/chef-rfc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/chef-rfc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/chef-rfc/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/chef-rfc/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/chef-rfc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/chef-rfc/merges","archive_url":"https://api.github.com/repos/opscode/chef-rfc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/chef-rfc/downloads","issues_url":"https://api.github.com/repos/opscode/chef-rfc/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/chef-rfc/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/chef-rfc/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/chef-rfc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/chef-rfc/labels{/name}","releases_url":"https://api.github.com/repos/opscode/chef-rfc/releases{/id}","created_at":"2013-12-10T22:10:56Z","updated_at":"2014-07-29T18:53:59Z","pushed_at":"2014-07-29T18:29:06Z","git_url":"git://github.com/opscode/chef-rfc.git","ssh_url":"git@github.com:opscode/chef-rfc.git","clone_url":"https://github.com/opscode/chef-rfc.git","svn_url":"https://github.com/opscode/chef-rfc","homepage":null,"size":1310,"stargazers_count":35,"watchers_count":35,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":26,"forks":14,"open_issues":26,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/chef-rfc/pulls/36"},"html":{"href":"https://github.com/opscode/chef-rfc/pull/36"},"issue":{"href":"https://api.github.com/repos/opscode/chef-rfc/issues/36"},"comments":{"href":"https://api.github.com/repos/opscode/chef-rfc/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/chef-rfc/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/chef-rfc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/chef-rfc/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/chef-rfc/statuses/2ab101a59bccbc3dbf0cf07e5b710f35f8f7ed76"}}}}