GitHub PullRequestEvent at 2014-08-11 21:37:03
Repository: incubator-parquet-mr
Actor: dcw-netflix
Payload: {"action":"opened","number":36,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/36","id":19629526,"html_url":"https://github.com/apache/incubator-parquet-mr/pull/36","diff_url":"https://github.com/apache/incubator-parquet-mr/pull/36.diff","patch_url":"https://github.com/apache/incubator-parquet-mr/pull/36.patch","issue_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/36","number":36,"state":"open","title":"Fixed storing pig schema to udfcontext for non projection case and moved...","user":{"login":"dcw-netflix","id":4925077,"avatar_url":"https://avatars.githubusercontent.com/u/4925077?v=2","gravatar_id":"1a5a070851caaa868ebade16eb0be230","url":"https://api.github.com/users/dcw-netflix","html_url":"https://github.com/dcw-netflix","followers_url":"https://api.github.com/users/dcw-netflix/followers","following_url":"https://api.github.com/users/dcw-netflix/following{/other_user}","gists_url":"https://api.github.com/users/dcw-netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/dcw-netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcw-netflix/subscriptions","organizations_url":"https://api.github.com/users/dcw-netflix/orgs","repos_url":"https://api.github.com/users/dcw-netflix/repos","events_url":"https://api.github.com/users/dcw-netflix/events{/privacy}","received_events_url":"https://api.github.com/users/dcw-netflix/received_events","type":"User","site_admin":false},"body":"... column index access setting to udfcontext so as not to affect other loaders.\r\n\r\nI found an problem that affects both the Column name access and column index access due to the way the pig schema is stored by the loader.\r\n\r\n##Column Name Access:\r\nThe ParquetLoader was only storing the pig schema in the UDFContext when push projection is applied.  In the full load case, the schema was not stored which triggered a full reload of the schema during task execution.  You can see in initSchema references the UDFContext for the schema, but that is only set in push projection.  However, the schema needs to be set in both the job context (so the TupleReadSupport can access the schema) and the UDFContext (so the task side loader can access it), which is why it is set in both locations.  This also meant the requested schema was never set to the task side either, which could cause other problems as well.\r\n\r\n##Column Index Access:\r\nFor index based access, the problem was that the column index access setting and the requested schema were not stored in the udfcontext and sent to the task side (unless pushProjection was called).  The schema was stored in the job context, but this would be overwritten if another loader was executed first.  Also, the property to use column index access was only being set at the job context level, so subsequent loaders would use column index access even if they didn't request it.\r\n\r\nThis fix now ensures that both the schema and column index access are set in the udfcontext and loaded in the initSchema method.\r\n\r\n-Dan","created_at":"2014-08-11T21:37:02Z","updated_at":"2014-08-11T21:37:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/36/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/36/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/36/comments","statuses_url":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/b7ef96ac58d751d7d7a3e00a238526efb3ef7981","head":{"label":"dcw-netflix:pig-schema-context","ref":"pig-schema-context","sha":"b7ef96ac58d751d7d7a3e00a238526efb3ef7981","user":{"login":"dcw-netflix","id":4925077,"avatar_url":"https://avatars.githubusercontent.com/u/4925077?v=2","gravatar_id":"1a5a070851caaa868ebade16eb0be230","url":"https://api.github.com/users/dcw-netflix","html_url":"https://github.com/dcw-netflix","followers_url":"https://api.github.com/users/dcw-netflix/followers","following_url":"https://api.github.com/users/dcw-netflix/following{/other_user}","gists_url":"https://api.github.com/users/dcw-netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/dcw-netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcw-netflix/subscriptions","organizations_url":"https://api.github.com/users/dcw-netflix/orgs","repos_url":"https://api.github.com/users/dcw-netflix/repos","events_url":"https://api.github.com/users/dcw-netflix/events{/privacy}","received_events_url":"https://api.github.com/users/dcw-netflix/received_events","type":"User","site_admin":false},"repo":{"id":21009481,"name":"incubator-parquet-mr","full_name":"dcw-netflix/incubator-parquet-mr","owner":{"login":"dcw-netflix","id":4925077,"avatar_url":"https://avatars.githubusercontent.com/u/4925077?v=2","gravatar_id":"1a5a070851caaa868ebade16eb0be230","url":"https://api.github.com/users/dcw-netflix","html_url":"https://github.com/dcw-netflix","followers_url":"https://api.github.com/users/dcw-netflix/followers","following_url":"https://api.github.com/users/dcw-netflix/following{/other_user}","gists_url":"https://api.github.com/users/dcw-netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/dcw-netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcw-netflix/subscriptions","organizations_url":"https://api.github.com/users/dcw-netflix/orgs","repos_url":"https://api.github.com/users/dcw-netflix/repos","events_url":"https://api.github.com/users/dcw-netflix/events{/privacy}","received_events_url":"https://api.github.com/users/dcw-netflix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcw-netflix/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr","forks_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/issues/comments/{number}","contents_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/dcw-netflix/incubator-parquet-mr/releases{/id}","created_at":"2014-06-19T17:34:54Z","updated_at":"2014-08-11T15:58:32Z","pushed_at":"2014-08-11T21:24:37Z","git_url":"git://github.com/dcw-netflix/incubator-parquet-mr.git","ssh_url":"git@github.com:dcw-netflix/incubator-parquet-mr.git","clone_url":"https://github.com/dcw-netflix/incubator-parquet-mr.git","svn_url":"https://github.com/dcw-netflix/incubator-parquet-mr","homepage":null,"size":11351,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3a396d3a4000bd2575e5314cdea0ba1e2367804c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675636,"name":"incubator-parquet-mr","full_name":"apache/incubator-parquet-mr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/incubator-parquet-mr","forks_url":"https://api.github.com/repos/apache/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/apache/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/apache/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/apache/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/apache/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-parquet-mr/releases{/id}","created_at":"2014-06-10T07:00:07Z","updated_at":"2014-08-08T16:36:25Z","pushed_at":"2014-08-05T02:24:35Z","git_url":"git://github.com/apache/incubator-parquet-mr.git","ssh_url":"git@github.com:apache/incubator-parquet-mr.git","clone_url":"https://github.com/apache/incubator-parquet-mr.git","svn_url":"https://github.com/apache/incubator-parquet-mr","homepage":null,"size":156654,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":32,"mirror_url":"git://git.apache.org/incubator-parquet-mr.git","open_issues_count":16,"forks":32,"open_issues":16,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/36"},"html":{"href":"https://github.com/apache/incubator-parquet-mr/pull/36"},"issue":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/36"},"comments":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/b7ef96ac58d751d7d7a3e00a238526efb3ef7981"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":8,"changed_files":1}}