GitHub PullRequestEvent at 2014-02-26 20:55:34
Repository: zippy
Actor: muffinresearch
Payload: {"action":"opened","number":114,"pull_request":{"url":"https://api.github.com/repos/mozilla/zippy/pulls/114","id":12972388,"html_url":"https://github.com/mozilla/zippy/pull/114","diff_url":"https://github.com/mozilla/zippy/pull/114.diff","patch_url":"https://github.com/mozilla/zippy/pull/114.patch","issue_url":"https://api.github.com/repos/mozilla/zippy/issues/114","number":114,"state":"open","title":"Fix l10n display issues","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://gravatar.com/avatar/86cf2c38bd61ffc99251cbd5d6ec2dfd?d=https%3A%2F%2Fidenticons.github.com%2F83f2550373f2f19492aa30fbd5b57512.png&r=x","gravatar_id":"86cf2c38bd61ffc99251cbd5d6ec2dfd","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"Some small fix-ups for l10n so that things are accessible/readable. \r\n\r\nMain issue was checkbox was gone with truncated string because it was inside the label. This moves it out.\r\nSecondly there were some small rtl issues.\r\n\r\nSome long strings are still truncated assuming the trusted-ui width of 275x346 (I made a page to report the trusted-ui width so we are actually dealing with the correct width (that's with an inari on b2g 1.2)) so we might need to consider dropping text size programmatically to accommodate it if we want to avoid an ellipsis (desirable).","created_at":"2014-02-26T20:55:34Z","updated_at":"2014-02-26T20:55:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/zippy/pulls/114/commits","review_comments_url":"https://api.github.com/repos/mozilla/zippy/pulls/114/comments","review_comment_url":"https://api.github.com/repos/mozilla/zippy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/zippy/issues/114/comments","statuses_url":"https://api.github.com/repos/mozilla/zippy/statuses/dd34cffd598f23aa26ef28fb6cdbc9f4eba6ba45","head":{"label":"muffinresearch:fix-10n-display-issues","ref":"fix-10n-display-issues","sha":"dd34cffd598f23aa26ef28fb6cdbc9f4eba6ba45","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://gravatar.com/avatar/86cf2c38bd61ffc99251cbd5d6ec2dfd?d=https%3A%2F%2Fidenticons.github.com%2F83f2550373f2f19492aa30fbd5b57512.png&r=x","gravatar_id":"86cf2c38bd61ffc99251cbd5d6ec2dfd","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"repo":{"id":13070667,"name":"zippy","full_name":"muffinresearch/zippy","owner":{"login":"muffinresearch","id":1514,"avatar_url":"https://gravatar.com/avatar/86cf2c38bd61ffc99251cbd5d6ec2dfd?d=https%3A%2F%2Fidenticons.github.com%2F83f2550373f2f19492aa30fbd5b57512.png&r=x","gravatar_id":"86cf2c38bd61ffc99251cbd5d6ec2dfd","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muffinresearch/zippy","description":"","fork":true,"url":"https://api.github.com/repos/muffinresearch/zippy","forks_url":"https://api.github.com/repos/muffinresearch/zippy/forks","keys_url":"https://api.github.com/repos/muffinresearch/zippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muffinresearch/zippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muffinresearch/zippy/teams","hooks_url":"https://api.github.com/repos/muffinresearch/zippy/hooks","issue_events_url":"https://api.github.com/repos/muffinresearch/zippy/issues/events{/number}","events_url":"https://api.github.com/repos/muffinresearch/zippy/events","assignees_url":"https://api.github.com/repos/muffinresearch/zippy/assignees{/user}","branches_url":"https://api.github.com/repos/muffinresearch/zippy/branches{/branch}","tags_url":"https://api.github.com/repos/muffinresearch/zippy/tags","blobs_url":"https://api.github.com/repos/muffinresearch/zippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muffinresearch/zippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muffinresearch/zippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/muffinresearch/zippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muffinresearch/zippy/statuses/{sha}","languages_url":"https://api.github.com/repos/muffinresearch/zippy/languages","stargazers_url":"https://api.github.com/repos/muffinresearch/zippy/stargazers","contributors_url":"https://api.github.com/repos/muffinresearch/zippy/contributors","subscribers_url":"https://api.github.com/repos/muffinresearch/zippy/subscribers","subscription_url":"https://api.github.com/repos/muffinresearch/zippy/subscription","commits_url":"https://api.github.com/repos/muffinresearch/zippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/muffinresearch/zippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/muffinresearch/zippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/muffinresearch/zippy/issues/comments/{number}","contents_url":"https://api.github.com/repos/muffinresearch/zippy/contents/{+path}","compare_url":"https://api.github.com/repos/muffinresearch/zippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muffinresearch/zippy/merges","archive_url":"https://api.github.com/repos/muffinresearch/zippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muffinresearch/zippy/downloads","issues_url":"https://api.github.com/repos/muffinresearch/zippy/issues{/number}","pulls_url":"https://api.github.com/repos/muffinresearch/zippy/pulls{/number}","milestones_url":"https://api.github.com/repos/muffinresearch/zippy/milestones{/number}","notifications_url":"https://api.github.com/repos/muffinresearch/zippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muffinresearch/zippy/labels{/name}","releases_url":"https://api.github.com/repos/muffinresearch/zippy/releases{/id}","created_at":"2013-09-24T16:42:36Z","updated_at":"2014-02-26T20:55:34Z","pushed_at":"2014-02-26T20:46:00Z","git_url":"git://github.com/muffinresearch/zippy.git","ssh_url":"git@github.com:muffinresearch/zippy.git","clone_url":"https://github.com/muffinresearch/zippy.git","svn_url":"https://github.com/muffinresearch/zippy","homepage":null,"size":18718,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"97339ae00b8e4bb15da04a8f1a3be2317369ea68","user":{"login":"mozilla","id":131524,"avatar_url":"https://gravatar.com/avatar/9ba739c8f3288e256b13553e4d257b5e?d=https%3A%2F%2Fidenticons.github.com%2Fe19b38694c8cd24cb8a5ff704c8d9ae1.png&r=x","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":13070234,"name":"zippy","full_name":"mozilla/zippy","owner":{"login":"mozilla","id":131524,"avatar_url":"https://gravatar.com/avatar/9ba739c8f3288e256b13553e4d257b5e?d=https%3A%2F%2Fidenticons.github.com%2Fe19b38694c8cd24cb8a5ff704c8d9ae1.png&r=x","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/zippy","description":"A reference implementation for payment providers for the Firefox Marketplace.","fork":false,"url":"https://api.github.com/repos/mozilla/zippy","forks_url":"https://api.github.com/repos/mozilla/zippy/forks","keys_url":"https://api.github.com/repos/mozilla/zippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/zippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/zippy/teams","hooks_url":"https://api.github.com/repos/mozilla/zippy/hooks","issue_events_url":"https://api.github.com/repos/mozilla/zippy/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/zippy/events","assignees_url":"https://api.github.com/repos/mozilla/zippy/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/zippy/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/zippy/tags","blobs_url":"https://api.github.com/repos/mozilla/zippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/zippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/zippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/zippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/zippy/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/zippy/languages","stargazers_url":"https://api.github.com/repos/mozilla/zippy/stargazers","contributors_url":"https://api.github.com/repos/mozilla/zippy/contributors","subscribers_url":"https://api.github.com/repos/mozilla/zippy/subscribers","subscription_url":"https://api.github.com/repos/mozilla/zippy/subscription","commits_url":"https://api.github.com/repos/mozilla/zippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/zippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/zippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/zippy/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/zippy/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/zippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/zippy/merges","archive_url":"https://api.github.com/repos/mozilla/zippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/zippy/downloads","issues_url":"https://api.github.com/repos/mozilla/zippy/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/zippy/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/zippy/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/zippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/zippy/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/zippy/releases{/id}","created_at":"2013-09-24T16:24:04Z","updated_at":"2014-02-26T20:23:36Z","pushed_at":"2014-02-26T20:23:36Z","git_url":"git://github.com/mozilla/zippy.git","ssh_url":"git@github.com:mozilla/zippy.git","clone_url":"https://github.com/mozilla/zippy.git","svn_url":"https://github.com/mozilla/zippy","homepage":"http://zippypayments.readthedocs.org/","size":25056,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":5,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/zippy/pulls/114"},"html":{"href":"https://github.com/mozilla/zippy/pull/114"},"issue":{"href":"https://api.github.com/repos/mozilla/zippy/issues/114"},"comments":{"href":"https://api.github.com/repos/mozilla/zippy/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/zippy/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/zippy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/zippy/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/zippy/statuses/dd34cffd598f23aa26ef28fb6cdbc9f4eba6ba45"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":46,"deletions":8,"changed_files":3}}