GitHub PullRequestReviewCommentEvent at 2014-06-14 18:45:52
Repository: distributed-extraction-framework
Actor: jcsahnwaldt
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/comments/13782237","id":13782237,"diff_hunk":"@@ -29,13 +34,23 @@ object DistRedirects\n {\n   private val logger = Logger.getLogger(classOf[DistRedirects].getName)\n \n+  private implicit var hadoopConfImpl: Configuration = null","path":"distributed/src/main/scala/org/dbpedia/extraction/mappings/DistRedirects.scala","position":26,"original_position":26,"commit_id":"d08417fb84f9cc79a1c985b9bcaad4179f339678","original_commit_id":"d08417fb84f9cc79a1c985b9bcaad4179f339678","user":{"login":"jcsahnwaldt","id":607468,"avatar_url":"https://avatars.githubusercontent.com/u/607468?","gravatar_id":"8353c161a81f235f16a946af90e0d21a","url":"https://api.github.com/users/jcsahnwaldt","html_url":"https://github.com/jcsahnwaldt","followers_url":"https://api.github.com/users/jcsahnwaldt/followers","following_url":"https://api.github.com/users/jcsahnwaldt/following{/other_user}","gists_url":"https://api.github.com/users/jcsahnwaldt/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsahnwaldt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsahnwaldt/subscriptions","organizations_url":"https://api.github.com/users/jcsahnwaldt/orgs","repos_url":"https://api.github.com/users/jcsahnwaldt/repos","events_url":"https://api.github.com/users/jcsahnwaldt/events{/privacy}","received_events_url":"https://api.github.com/users/jcsahnwaldt/received_events","type":"User","site_admin":false},"body":"Same problem as in DistRedirects. A class with stateful instance fields is not thread-safe.","created_at":"2014-06-14T18:45:52Z","updated_at":"2014-06-14T18:45:52Z","html_url":"https://github.com/dbpedia/distributed-extraction-framework/pull/22#discussion_r13782237","pull_request_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/comments/13782237"},"html":{"href":"https://github.com/dbpedia/distributed-extraction-framework/pull/22#discussion_r13782237"},"pull_request":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/22","id":17108604,"html_url":"https://github.com/dbpedia/distributed-extraction-framework/pull/22","diff_url":"https://github.com/dbpedia/distributed-extraction-framework/pull/22.diff","patch_url":"https://github.com/dbpedia/distributed-extraction-framework/pull/22.patch","issue_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues/22","number":22,"state":"open","title":"Many code changes to make everything work with Path and XmlInputFormat. Completes milestone 2.","user":{"login":"nilesh-c","id":1786561,"avatar_url":"https://avatars.githubusercontent.com/u/1786561?","gravatar_id":"41db49261c0e522bccc415d1cf913d6c","url":"https://api.github.com/users/nilesh-c","html_url":"https://github.com/nilesh-c","followers_url":"https://api.github.com/users/nilesh-c/followers","following_url":"https://api.github.com/users/nilesh-c/following{/other_user}","gists_url":"https://api.github.com/users/nilesh-c/gists{/gist_id}","starred_url":"https://api.github.com/users/nilesh-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilesh-c/subscriptions","organizations_url":"https://api.github.com/users/nilesh-c/orgs","repos_url":"https://api.github.com/users/nilesh-c/repos","events_url":"https://api.github.com/users/nilesh-c/events{/privacy}","received_events_url":"https://api.github.com/users/nilesh-c/received_events","type":"User","site_admin":false},"body":"The existing code works with Files. Hadoop works with [Paths](http://hadoop.apache.org/docs/r2.3.0/api/org/apache/hadoop/fs/Path.html) and [FileSystem](http://hadoop.apache.org/docs/r2.3.0/api/org/apache/hadoop/fs/FileSystem.html) which provide an abstraction over files and file systems. That is to say, Hadoop encapsulates the stuff about distributed or local files and files systems and lets us work with Paths and InputFormats. This pretty much sums up most of the stuff in the commits.\r\n\r\nOther than that, I added the XmlInputFormat. I tested with run-extraction-test and everything works. DistRedirectsTest passes. I added some docs too.\r\n\r\nPlease note that I have taken care to make the commits in a specific sequence. If you make your way from commit 4b9745f to commit d08417f it'll be easier to understand what's going on.\r\n\r\nAlso, it's worth a mention that you'll need to clone https://github.com/nilesh-c/extraction-framework , switch to the **fromxml** branch and run `mvn install` before building this repo on this branch. I've made a PR to extraction-framework with the changes in **fromxml**.","created_at":"2014-06-13T13:20:38Z","updated_at":"2014-06-14T18:45:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b2b04737ab3f7cc53671390811fdc8397ad4fb9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/22/commits","review_comments_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/22/comments","review_comment_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues/22/comments","statuses_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/statuses/d08417fb84f9cc79a1c985b9bcaad4179f339678","head":{"label":"dbpedia:milestone2","ref":"milestone2","sha":"d08417fb84f9cc79a1c985b9bcaad4179f339678","user":{"login":"dbpedia","id":2864602,"avatar_url":"https://avatars.githubusercontent.com/u/2864602?","gravatar_id":"02666e518ae84a3853702c12d07f1941","url":"https://api.github.com/users/dbpedia","html_url":"https://github.com/dbpedia","followers_url":"https://api.github.com/users/dbpedia/followers","following_url":"https://api.github.com/users/dbpedia/following{/other_user}","gists_url":"https://api.github.com/users/dbpedia/gists{/gist_id}","starred_url":"https://api.github.com/users/dbpedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbpedia/subscriptions","organizations_url":"https://api.github.com/users/dbpedia/orgs","repos_url":"https://api.github.com/users/dbpedia/repos","events_url":"https://api.github.com/users/dbpedia/events{/privacy}","received_events_url":"https://api.github.com/users/dbpedia/received_events","type":"Organization","site_admin":false},"repo":{"id":19536778,"name":"distributed-extraction-framework","full_name":"dbpedia/distributed-extraction-framework","owner":{"login":"dbpedia","id":2864602,"avatar_url":"https://avatars.githubusercontent.com/u/2864602?","gravatar_id":"02666e518ae84a3853702c12d07f1941","url":"https://api.github.com/users/dbpedia","html_url":"https://github.com/dbpedia","followers_url":"https://api.github.com/users/dbpedia/followers","following_url":"https://api.github.com/users/dbpedia/following{/other_user}","gists_url":"https://api.github.com/users/dbpedia/gists{/gist_id}","starred_url":"https://api.github.com/users/dbpedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbpedia/subscriptions","organizations_url":"https://api.github.com/users/dbpedia/orgs","repos_url":"https://api.github.com/users/dbpedia/repos","events_url":"https://api.github.com/users/dbpedia/events{/privacy}","received_events_url":"https://api.github.com/users/dbpedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dbpedia/distributed-extraction-framework","description":"","fork":false,"url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework","forks_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/forks","keys_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/teams","hooks_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/hooks","issue_events_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues/events{/number}","events_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/events","assignees_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/assignees{/user}","branches_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/branches{/branch}","tags_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/tags","blobs_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/languages","stargazers_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/stargazers","contributors_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/contributors","subscribers_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/subscribers","subscription_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/subscription","commits_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/contents/{+path}","compare_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/merges","archive_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/downloads","issues_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues{/number}","pulls_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/labels{/name}","releases_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/releases{/id}","created_at":"2014-05-07T14:04:01Z","updated_at":"2014-06-13T13:20:38Z","pushed_at":"2014-06-13T13:09:57Z","git_url":"git://github.com/dbpedia/distributed-extraction-framework.git","ssh_url":"git@github.com:dbpedia/distributed-extraction-framework.git","clone_url":"https://github.com/dbpedia/distributed-extraction-framework.git","svn_url":"https://github.com/dbpedia/distributed-extraction-framework","homepage":null,"size":1063,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":4,"default_branch":"master"}},"base":{"label":"dbpedia:nildev2","ref":"nildev2","sha":"f34085aeaae77e922daa786047cbcf94c8ba855d","user":{"login":"dbpedia","id":2864602,"avatar_url":"https://avatars.githubusercontent.com/u/2864602?","gravatar_id":"02666e518ae84a3853702c12d07f1941","url":"https://api.github.com/users/dbpedia","html_url":"https://github.com/dbpedia","followers_url":"https://api.github.com/users/dbpedia/followers","following_url":"https://api.github.com/users/dbpedia/following{/other_user}","gists_url":"https://api.github.com/users/dbpedia/gists{/gist_id}","starred_url":"https://api.github.com/users/dbpedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbpedia/subscriptions","organizations_url":"https://api.github.com/users/dbpedia/orgs","repos_url":"https://api.github.com/users/dbpedia/repos","events_url":"https://api.github.com/users/dbpedia/events{/privacy}","received_events_url":"https://api.github.com/users/dbpedia/received_events","type":"Organization","site_admin":false},"repo":{"id":19536778,"name":"distributed-extraction-framework","full_name":"dbpedia/distributed-extraction-framework","owner":{"login":"dbpedia","id":2864602,"avatar_url":"https://avatars.githubusercontent.com/u/2864602?","gravatar_id":"02666e518ae84a3853702c12d07f1941","url":"https://api.github.com/users/dbpedia","html_url":"https://github.com/dbpedia","followers_url":"https://api.github.com/users/dbpedia/followers","following_url":"https://api.github.com/users/dbpedia/following{/other_user}","gists_url":"https://api.github.com/users/dbpedia/gists{/gist_id}","starred_url":"https://api.github.com/users/dbpedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbpedia/subscriptions","organizations_url":"https://api.github.com/users/dbpedia/orgs","repos_url":"https://api.github.com/users/dbpedia/repos","events_url":"https://api.github.com/users/dbpedia/events{/privacy}","received_events_url":"https://api.github.com/users/dbpedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dbpedia/distributed-extraction-framework","description":"","fork":false,"url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework","forks_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/forks","keys_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/teams","hooks_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/hooks","issue_events_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues/events{/number}","events_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/events","assignees_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/assignees{/user}","branches_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/branches{/branch}","tags_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/tags","blobs_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/languages","stargazers_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/stargazers","contributors_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/contributors","subscribers_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/subscribers","subscription_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/subscription","commits_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/contents/{+path}","compare_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/merges","archive_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/downloads","issues_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues{/number}","pulls_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/labels{/name}","releases_url":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/releases{/id}","created_at":"2014-05-07T14:04:01Z","updated_at":"2014-06-13T13:20:38Z","pushed_at":"2014-06-13T13:09:57Z","git_url":"git://github.com/dbpedia/distributed-extraction-framework.git","ssh_url":"git@github.com:dbpedia/distributed-extraction-framework.git","clone_url":"https://github.com/dbpedia/distributed-extraction-framework.git","svn_url":"https://github.com/dbpedia/distributed-extraction-framework","homepage":null,"size":1063,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/22"},"html":{"href":"https://github.com/dbpedia/distributed-extraction-framework/pull/22"},"issue":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues/22"},"comments":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/dbpedia/distributed-extraction-framework/statuses/d08417fb84f9cc79a1c985b9bcaad4179f339678"}}}}