GitHub PullRequestReviewCommentEvent at 2014-03-21 11:48:20
Repository: LMIS-Chrome
Actor: futuresandwich
Payload: {"comment":{"url":"https://api.github.com/repos/eHealthAfrica/LMIS-Chrome/pulls/comments/10833402","id":10833402,"diff_hunk":"@@ -14,6 +14,10 @@ angular.module('lmisChromeApp')\n           currentFacility: function(facilityFactory){\n             return facilityFactory.getCurrentFacility();\n           }\n+          ,\n+          productType: function(stockCountFactory){\n+            return stockCountFactory.productType();","path":"app/scripts/controllers/stockcount.js","position":6,"original_position":6,"commit_id":"5d4938f385dfd9bca1826d1882173bd584bc7d5b","original_commit_id":"5d4938f385dfd9bca1826d1882173bd584bc7d5b","user":{"login":"futuresandwich","id":58843,"avatar_url":"https://avatars.githubusercontent.com/u/58843?","gravatar_id":"4f1be8bf0af396ad928265abcc148680","url":"https://api.github.com/users/futuresandwich","html_url":"https://github.com/futuresandwich","followers_url":"https://api.github.com/users/futuresandwich/followers","following_url":"https://api.github.com/users/futuresandwich/following{/other_user}","gists_url":"https://api.github.com/users/futuresandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/futuresandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futuresandwich/subscriptions","organizations_url":"https://api.github.com/users/futuresandwich/orgs","repos_url":"https://api.github.com/users/futuresandwich/repos","events_url":"https://api.github.com/users/futuresandwich/events{/privacy}","received_events_url":"https://api.github.com/users/futuresandwich/received_events","type":"User","site_admin":false},"body":"question: is direct calls on the scope a good idea or do we want to try and only put resolved data there? putting calls on the scope means you don't have as much control over lifecycle, and possible side effects. not sure what is best practice in angular though.","created_at":"2014-03-21T11:48:20Z","updated_at":"2014-03-21T11:48:20Z","html_url":"https://github.com/eHealthAfrica/LMIS-Chrome/pull/135#discussion_r10833402","pull_request_url":"https://api.github.com/repos/eHealthAfrica/LMIS-Chrome/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/eHealthAfrica/LMIS-Chrome/pulls/comments/10833402"},"html":{"href":"https://github.com/eHealthAfrica/LMIS-Chrome/pull/135#discussion_r10833402"},"pull_request":{"href":"https://api.github.com/repos/eHealthAfrica/LMIS-Chrome/pulls/135"}}}}