GitHub PullRequestReviewCommentEvent at 2014-11-19 10:57:38
Repository: ralph
Actor: andrzej-jankowski
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/allegro/ralph/pulls/comments/20568330","id":20568330,"diff_hunk":"@@ -39,45 +39,63 @@\n ENGINES = {}\n \n \n+class PuppetConfigurationError(Exception):\n+    pass\n+\n+\n class PuppetBaseProvider(object):\n \n     def get_facts(self, ip_addresses, hostnames, messages=[]):\n         raise NotImplementedError()\n \n \n-class PuppetAPIProvider(PuppetBaseProvider):\n+class PuppetAPIJsonProvider(PuppetBaseProvider):\n \n     def __init__(self, api_url):\n         self.api_url = api_url\n+        self._set_certs_from_config()\n+\n+    def _set_certs_from_config(self):\n+        puppet_api_json_certs = getattr(settings, 'PUPPET_API_JSON_CERTS', None)\n+        for attr in ['local_cert', 'local_cert_key', 'ca_cert']:\n+            value = puppet_api_json_certs[attr]","path":"src/ralph/scan/plugins/puppet.py","position":40,"original_position":40,"commit_id":"11e604aebfeba47535e8e5d48ca1225b4aef225c","original_commit_id":"11e604aebfeba47535e8e5d48ca1225b4aef225c","user":{"login":"andrzej-jankowski","id":2079944,"avatar_url":"https://avatars.githubusercontent.com/u/2079944?v=3","gravatar_id":"","url":"https://api.github.com/users/andrzej-jankowski","html_url":"https://github.com/andrzej-jankowski","followers_url":"https://api.github.com/users/andrzej-jankowski/followers","following_url":"https://api.github.com/users/andrzej-jankowski/following{/other_user}","gists_url":"https://api.github.com/users/andrzej-jankowski/gists{/gist_id}","starred_url":"https://api.github.com/users/andrzej-jankowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrzej-jankowski/subscriptions","organizations_url":"https://api.github.com/users/andrzej-jankowski/orgs","repos_url":"https://api.github.com/users/andrzej-jankowski/repos","events_url":"https://api.github.com/users/andrzej-jankowski/events{/privacy}","received_events_url":"https://api.github.com/users/andrzej-jankowski/received_events","type":"User","site_admin":false},"body":"KeyError?","created_at":"2014-11-19T10:57:38Z","updated_at":"2014-11-19T10:57:38Z","html_url":"https://github.com/allegro/ralph/pull/1189#discussion_r20568330","pull_request_url":"https://api.github.com/repos/allegro/ralph/pulls/1189","_links":{"self":{"href":"https://api.github.com/repos/allegro/ralph/pulls/comments/20568330"},"html":{"href":"https://github.com/allegro/ralph/pull/1189#discussion_r20568330"},"pull_request":{"href":"https://api.github.com/repos/allegro/ralph/pulls/1189"}}},"pull_request":{"url":"https://api.github.com/repos/allegro/ralph/pulls/1189","id":24371640,"html_url":"https://github.com/allegro/ralph/pull/1189","diff_url":"https://github.com/allegro/ralph/pull/1189.diff","patch_url":"https://github.com/allegro/ralph/pull/1189.patch","issue_url":"https://api.github.com/repos/allegro/ralph/issues/1189","number":1189,"state":"open","locked":false,"title":"[REVIEW-ONLY] puppet api extension","user":{"login":"xliiv","id":298994,"avatar_url":"https://avatars.githubusercontent.com/u/298994?v=3","gravatar_id":"","url":"https://api.github.com/users/xliiv","html_url":"https://github.com/xliiv","followers_url":"https://api.github.com/users/xliiv/followers","following_url":"https://api.github.com/users/xliiv/following{/other_user}","gists_url":"https://api.github.com/users/xliiv/gists{/gist_id}","starred_url":"https://api.github.com/users/xliiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xliiv/subscriptions","organizations_url":"https://api.github.com/users/xliiv/orgs","repos_url":"https://api.github.com/users/xliiv/repos","events_url":"https://api.github.com/users/xliiv/events{/privacy}","received_events_url":"https://api.github.com/users/xliiv/received_events","type":"User","site_admin":false},"body":"Changed puppet data source from ralph-db to defined chain, which is this:\r\nThe chain:\r\n- try get data from puppetdb-api\r\n- then try get data from ralph-db\r\n\r\n@andrzej-jankowski \r\nCould you review it, please?","created_at":"2014-11-13T14:32:15Z","updated_at":"2014-11-19T10:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/allegro/ralph/pulls/1189/commits","review_comments_url":"https://api.github.com/repos/allegro/ralph/pulls/1189/comments","review_comment_url":"https://api.github.com/repos/allegro/ralph/pulls/comments/{number}","comments_url":"https://api.github.com/repos/allegro/ralph/issues/1189/comments","statuses_url":"https://api.github.com/repos/allegro/ralph/statuses/11e604aebfeba47535e8e5d48ca1225b4aef225c","head":{"label":"xliiv:puppet-facts-by-api","ref":"puppet-facts-by-api","sha":"11e604aebfeba47535e8e5d48ca1225b4aef225c","user":{"login":"xliiv","id":298994,"avatar_url":"https://avatars.githubusercontent.com/u/298994?v=3","gravatar_id":"","url":"https://api.github.com/users/xliiv","html_url":"https://github.com/xliiv","followers_url":"https://api.github.com/users/xliiv/followers","following_url":"https://api.github.com/users/xliiv/following{/other_user}","gists_url":"https://api.github.com/users/xliiv/gists{/gist_id}","starred_url":"https://api.github.com/users/xliiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xliiv/subscriptions","organizations_url":"https://api.github.com/users/xliiv/orgs","repos_url":"https://api.github.com/users/xliiv/repos","events_url":"https://api.github.com/users/xliiv/events{/privacy}","received_events_url":"https://api.github.com/users/xliiv/received_events","type":"User","site_admin":false},"repo":{"id":16946165,"name":"ralph","full_name":"xliiv/ralph","owner":{"login":"xliiv","id":298994,"avatar_url":"https://avatars.githubusercontent.com/u/298994?v=3","gravatar_id":"","url":"https://api.github.com/users/xliiv","html_url":"https://github.com/xliiv","followers_url":"https://api.github.com/users/xliiv/followers","following_url":"https://api.github.com/users/xliiv/following{/other_user}","gists_url":"https://api.github.com/users/xliiv/gists{/gist_id}","starred_url":"https://api.github.com/users/xliiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xliiv/subscriptions","organizations_url":"https://api.github.com/users/xliiv/orgs","repos_url":"https://api.github.com/users/xliiv/repos","events_url":"https://api.github.com/users/xliiv/events{/privacy}","received_events_url":"https://api.github.com/users/xliiv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xliiv/ralph","description":"Ralph is an asset management system for your data center.","fork":true,"url":"https://api.github.com/repos/xliiv/ralph","forks_url":"https://api.github.com/repos/xliiv/ralph/forks","keys_url":"https://api.github.com/repos/xliiv/ralph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xliiv/ralph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xliiv/ralph/teams","hooks_url":"https://api.github.com/repos/xliiv/ralph/hooks","issue_events_url":"https://api.github.com/repos/xliiv/ralph/issues/events{/number}","events_url":"https://api.github.com/repos/xliiv/ralph/events","assignees_url":"https://api.github.com/repos/xliiv/ralph/assignees{/user}","branches_url":"https://api.github.com/repos/xliiv/ralph/branches{/branch}","tags_url":"https://api.github.com/repos/xliiv/ralph/tags","blobs_url":"https://api.github.com/repos/xliiv/ralph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xliiv/ralph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xliiv/ralph/git/refs{/sha}","trees_url":"https://api.github.com/repos/xliiv/ralph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xliiv/ralph/statuses/{sha}","languages_url":"https://api.github.com/repos/xliiv/ralph/languages","stargazers_url":"https://api.github.com/repos/xliiv/ralph/stargazers","contributors_url":"https://api.github.com/repos/xliiv/ralph/contributors","subscribers_url":"https://api.github.com/repos/xliiv/ralph/subscribers","subscription_url":"https://api.github.com/repos/xliiv/ralph/subscription","commits_url":"https://api.github.com/repos/xliiv/ralph/commits{/sha}","git_commits_url":"https://api.github.com/repos/xliiv/ralph/git/commits{/sha}","comments_url":"https://api.github.com/repos/xliiv/ralph/comments{/number}","issue_comment_url":"https://api.github.com/repos/xliiv/ralph/issues/comments/{number}","contents_url":"https://api.github.com/repos/xliiv/ralph/contents/{+path}","compare_url":"https://api.github.com/repos/xliiv/ralph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xliiv/ralph/merges","archive_url":"https://api.github.com/repos/xliiv/ralph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xliiv/ralph/downloads","issues_url":"https://api.github.com/repos/xliiv/ralph/issues{/number}","pulls_url":"https://api.github.com/repos/xliiv/ralph/pulls{/number}","milestones_url":"https://api.github.com/repos/xliiv/ralph/milestones{/number}","notifications_url":"https://api.github.com/repos/xliiv/ralph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xliiv/ralph/labels{/name}","releases_url":"https://api.github.com/repos/xliiv/ralph/releases{/id}","created_at":"2014-02-18T11:03:52Z","updated_at":"2014-06-16T13:10:34Z","pushed_at":"2014-11-17T10:25:03Z","git_url":"git://github.com/xliiv/ralph.git","ssh_url":"git@github.com:xliiv/ralph.git","clone_url":"https://github.com/xliiv/ralph.git","svn_url":"https://github.com/xliiv/ralph","homepage":"http://ralph.allegrogroup.com/","size":15468,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"allegro:develop","ref":"develop","sha":"7a43dcc1781fe3a410536298cb6466dded4df966","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":4359038,"name":"ralph","full_name":"allegro/ralph","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/ralph","description":"Ralph is an asset management system for your data center.","fork":false,"url":"https://api.github.com/repos/allegro/ralph","forks_url":"https://api.github.com/repos/allegro/ralph/forks","keys_url":"https://api.github.com/repos/allegro/ralph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/ralph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/ralph/teams","hooks_url":"https://api.github.com/repos/allegro/ralph/hooks","issue_events_url":"https://api.github.com/repos/allegro/ralph/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/ralph/events","assignees_url":"https://api.github.com/repos/allegro/ralph/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/ralph/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/ralph/tags","blobs_url":"https://api.github.com/repos/allegro/ralph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/ralph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/ralph/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/ralph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/ralph/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/ralph/languages","stargazers_url":"https://api.github.com/repos/allegro/ralph/stargazers","contributors_url":"https://api.github.com/repos/allegro/ralph/contributors","subscribers_url":"https://api.github.com/repos/allegro/ralph/subscribers","subscription_url":"https://api.github.com/repos/allegro/ralph/subscription","commits_url":"https://api.github.com/repos/allegro/ralph/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/ralph/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/ralph/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/ralph/issues/comments/{number}","contents_url":"https://api.github.com/repos/allegro/ralph/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/ralph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/ralph/merges","archive_url":"https://api.github.com/repos/allegro/ralph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/ralph/downloads","issues_url":"https://api.github.com/repos/allegro/ralph/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/ralph/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/ralph/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/ralph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/ralph/labels{/name}","releases_url":"https://api.github.com/repos/allegro/ralph/releases{/id}","created_at":"2012-05-17T14:04:57Z","updated_at":"2014-11-12T05:56:03Z","pushed_at":"2014-11-17T10:42:16Z","git_url":"git://github.com/allegro/ralph.git","ssh_url":"git@github.com:allegro/ralph.git","clone_url":"https://github.com/allegro/ralph.git","svn_url":"https://github.com/allegro/ralph","homepage":"http://ralph.allegrogroup.com/","size":25885,"stargazers_count":218,"watchers_count":218,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":16,"forks":50,"open_issues":16,"watchers":218,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/allegro/ralph/pulls/1189"},"html":{"href":"https://github.com/allegro/ralph/pull/1189"},"issue":{"href":"https://api.github.com/repos/allegro/ralph/issues/1189"},"comments":{"href":"https://api.github.com/repos/allegro/ralph/issues/1189/comments"},"review_comments":{"href":"https://api.github.com/repos/allegro/ralph/pulls/1189/comments"},"review_comment":{"href":"https://api.github.com/repos/allegro/ralph/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/allegro/ralph/pulls/1189/commits"},"statuses":{"href":"https://api.github.com/repos/allegro/ralph/statuses/11e604aebfeba47535e8e5d48ca1225b4aef225c"}}}}