GitHub PullRequestEvent at 2014-12-20 22:09:15
Repository: este-watch
Actor: menssen
Payload: {"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/steida/este-watch/pulls/5","id":26421470,"html_url":"https://github.com/steida/este-watch/pull/5","diff_url":"https://github.com/steida/este-watch/pull/5.diff","patch_url":"https://github.com/steida/este-watch/pull/5.patch","issue_url":"https://api.github.com/repos/steida/este-watch/issues/5","number":5,"state":"open","locked":false,"title":"Fix failing tests for ignore/filter patterns","user":{"login":"menssen","id":591967,"avatar_url":"https://avatars.githubusercontent.com/u/591967?v=3","gravatar_id":"","url":"https://api.github.com/users/menssen","html_url":"https://github.com/menssen","followers_url":"https://api.github.com/users/menssen/followers","following_url":"https://api.github.com/users/menssen/following{/other_user}","gists_url":"https://api.github.com/users/menssen/gists{/gist_id}","starred_url":"https://api.github.com/users/menssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menssen/subscriptions","organizations_url":"https://api.github.com/users/menssen/orgs","repos_url":"https://api.github.com/users/menssen/repos","events_url":"https://api.github.com/users/menssen/events{/privacy}","received_events_url":"https://api.github.com/users/menssen/received_events","type":"User","site_admin":false},"body":"Finally had some time to look into this. Four things.\r\n\r\n1. Mysteriously, I started to see more failures when trying to run with a newer version of the gulp cli installed globally. This is probably just coincidence, but I went ahead and went through the dependencies and bumped versions of everything to try to keep things fresh.\r\n\r\n2. I had the file creation for two of the tests in a beforeEach hook, but nothing explicitly waited for that time to pass, so if the test failed quickly I think those files were getting created while the *next* test was running. Or something like that. Point is, things were happening out of order.\r\n\r\n3. I had the \"watcher.dispose()\" call after the assertions, so if one of the assertions failed with an exception, I don't think the watcher was being stopped, interfering with the next test.\r\n\r\n4. After fixing all of the above, I was still seeing intermittent failures, but bumping all the time intervals to half a second seems to have fixed it.\r\n\r\nBoth #4 above and the setTimeout nesting are gross stylistically, but it seems to be the easiest way to see that everything is happening in the correct order.","created_at":"2014-12-20T22:09:15Z","updated_at":"2014-12-20T22:09:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"056610e7bad86df7b7905942fe2e6855b47b555e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/steida/este-watch/pulls/5/commits","review_comments_url":"https://api.github.com/repos/steida/este-watch/pulls/5/comments","review_comment_url":"https://api.github.com/repos/steida/este-watch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/steida/este-watch/issues/5/comments","statuses_url":"https://api.github.com/repos/steida/este-watch/statuses/db19df91321ca16974c79f75aaa1634133b9f854","head":{"label":"menssen:master","ref":"master","sha":"db19df91321ca16974c79f75aaa1634133b9f854","user":{"login":"menssen","id":591967,"avatar_url":"https://avatars.githubusercontent.com/u/591967?v=3","gravatar_id":"","url":"https://api.github.com/users/menssen","html_url":"https://github.com/menssen","followers_url":"https://api.github.com/users/menssen/followers","following_url":"https://api.github.com/users/menssen/following{/other_user}","gists_url":"https://api.github.com/users/menssen/gists{/gist_id}","starred_url":"https://api.github.com/users/menssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menssen/subscriptions","organizations_url":"https://api.github.com/users/menssen/orgs","repos_url":"https://api.github.com/users/menssen/repos","events_url":"https://api.github.com/users/menssen/events{/privacy}","received_events_url":"https://api.github.com/users/menssen/received_events","type":"User","site_admin":false},"repo":{"id":28099729,"name":"este-watch","full_name":"menssen/este-watch","owner":{"login":"menssen","id":591967,"avatar_url":"https://avatars.githubusercontent.com/u/591967?v=3","gravatar_id":"","url":"https://api.github.com/users/menssen","html_url":"https://github.com/menssen","followers_url":"https://api.github.com/users/menssen/followers","following_url":"https://api.github.com/users/menssen/following{/other_user}","gists_url":"https://api.github.com/users/menssen/gists{/gist_id}","starred_url":"https://api.github.com/users/menssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menssen/subscriptions","organizations_url":"https://api.github.com/users/menssen/orgs","repos_url":"https://api.github.com/users/menssen/repos","events_url":"https://api.github.com/users/menssen/events{/privacy}","received_events_url":"https://api.github.com/users/menssen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/menssen/este-watch","description":"Fast and reliable Node.js files watcher.","fork":true,"url":"https://api.github.com/repos/menssen/este-watch","forks_url":"https://api.github.com/repos/menssen/este-watch/forks","keys_url":"https://api.github.com/repos/menssen/este-watch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menssen/este-watch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menssen/este-watch/teams","hooks_url":"https://api.github.com/repos/menssen/este-watch/hooks","issue_events_url":"https://api.github.com/repos/menssen/este-watch/issues/events{/number}","events_url":"https://api.github.com/repos/menssen/este-watch/events","assignees_url":"https://api.github.com/repos/menssen/este-watch/assignees{/user}","branches_url":"https://api.github.com/repos/menssen/este-watch/branches{/branch}","tags_url":"https://api.github.com/repos/menssen/este-watch/tags","blobs_url":"https://api.github.com/repos/menssen/este-watch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menssen/este-watch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menssen/este-watch/git/refs{/sha}","trees_url":"https://api.github.com/repos/menssen/este-watch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menssen/este-watch/statuses/{sha}","languages_url":"https://api.github.com/repos/menssen/este-watch/languages","stargazers_url":"https://api.github.com/repos/menssen/este-watch/stargazers","contributors_url":"https://api.github.com/repos/menssen/este-watch/contributors","subscribers_url":"https://api.github.com/repos/menssen/este-watch/subscribers","subscription_url":"https://api.github.com/repos/menssen/este-watch/subscription","commits_url":"https://api.github.com/repos/menssen/este-watch/commits{/sha}","git_commits_url":"https://api.github.com/repos/menssen/este-watch/git/commits{/sha}","comments_url":"https://api.github.com/repos/menssen/este-watch/comments{/number}","issue_comment_url":"https://api.github.com/repos/menssen/este-watch/issues/comments/{number}","contents_url":"https://api.github.com/repos/menssen/este-watch/contents/{+path}","compare_url":"https://api.github.com/repos/menssen/este-watch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menssen/este-watch/merges","archive_url":"https://api.github.com/repos/menssen/este-watch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menssen/este-watch/downloads","issues_url":"https://api.github.com/repos/menssen/este-watch/issues{/number}","pulls_url":"https://api.github.com/repos/menssen/este-watch/pulls{/number}","milestones_url":"https://api.github.com/repos/menssen/este-watch/milestones{/number}","notifications_url":"https://api.github.com/repos/menssen/este-watch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menssen/este-watch/labels{/name}","releases_url":"https://api.github.com/repos/menssen/este-watch/releases{/id}","created_at":"2014-12-16T18:13:10Z","updated_at":"2014-12-20T22:00:34Z","pushed_at":"2014-12-20T22:00:34Z","git_url":"git://github.com/menssen/este-watch.git","ssh_url":"git@github.com:menssen/este-watch.git","clone_url":"https://github.com/menssen/este-watch.git","svn_url":"https://github.com/menssen/este-watch","homepage":"","size":107,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"steida:master","ref":"master","sha":"20ca00b0384edc1fd1984f9e014366108f695193","user":{"login":"steida","id":66249,"avatar_url":"https://avatars.githubusercontent.com/u/66249?v=3","gravatar_id":"","url":"https://api.github.com/users/steida","html_url":"https://github.com/steida","followers_url":"https://api.github.com/users/steida/followers","following_url":"https://api.github.com/users/steida/following{/other_user}","gists_url":"https://api.github.com/users/steida/gists{/gist_id}","starred_url":"https://api.github.com/users/steida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steida/subscriptions","organizations_url":"https://api.github.com/users/steida/orgs","repos_url":"https://api.github.com/users/steida/repos","events_url":"https://api.github.com/users/steida/events{/privacy}","received_events_url":"https://api.github.com/users/steida/received_events","type":"User","site_admin":false},"repo":{"id":16121300,"name":"este-watch","full_name":"steida/este-watch","owner":{"login":"steida","id":66249,"avatar_url":"https://avatars.githubusercontent.com/u/66249?v=3","gravatar_id":"","url":"https://api.github.com/users/steida","html_url":"https://github.com/steida","followers_url":"https://api.github.com/users/steida/followers","following_url":"https://api.github.com/users/steida/following{/other_user}","gists_url":"https://api.github.com/users/steida/gists{/gist_id}","starred_url":"https://api.github.com/users/steida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steida/subscriptions","organizations_url":"https://api.github.com/users/steida/orgs","repos_url":"https://api.github.com/users/steida/repos","events_url":"https://api.github.com/users/steida/events{/privacy}","received_events_url":"https://api.github.com/users/steida/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steida/este-watch","description":"Fast and reliable Node.js files watcher.","fork":false,"url":"https://api.github.com/repos/steida/este-watch","forks_url":"https://api.github.com/repos/steida/este-watch/forks","keys_url":"https://api.github.com/repos/steida/este-watch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steida/este-watch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steida/este-watch/teams","hooks_url":"https://api.github.com/repos/steida/este-watch/hooks","issue_events_url":"https://api.github.com/repos/steida/este-watch/issues/events{/number}","events_url":"https://api.github.com/repos/steida/este-watch/events","assignees_url":"https://api.github.com/repos/steida/este-watch/assignees{/user}","branches_url":"https://api.github.com/repos/steida/este-watch/branches{/branch}","tags_url":"https://api.github.com/repos/steida/este-watch/tags","blobs_url":"https://api.github.com/repos/steida/este-watch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steida/este-watch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steida/este-watch/git/refs{/sha}","trees_url":"https://api.github.com/repos/steida/este-watch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steida/este-watch/statuses/{sha}","languages_url":"https://api.github.com/repos/steida/este-watch/languages","stargazers_url":"https://api.github.com/repos/steida/este-watch/stargazers","contributors_url":"https://api.github.com/repos/steida/este-watch/contributors","subscribers_url":"https://api.github.com/repos/steida/este-watch/subscribers","subscription_url":"https://api.github.com/repos/steida/este-watch/subscription","commits_url":"https://api.github.com/repos/steida/este-watch/commits{/sha}","git_commits_url":"https://api.github.com/repos/steida/este-watch/git/commits{/sha}","comments_url":"https://api.github.com/repos/steida/este-watch/comments{/number}","issue_comment_url":"https://api.github.com/repos/steida/este-watch/issues/comments/{number}","contents_url":"https://api.github.com/repos/steida/este-watch/contents/{+path}","compare_url":"https://api.github.com/repos/steida/este-watch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steida/este-watch/merges","archive_url":"https://api.github.com/repos/steida/este-watch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steida/este-watch/downloads","issues_url":"https://api.github.com/repos/steida/este-watch/issues{/number}","pulls_url":"https://api.github.com/repos/steida/este-watch/pulls{/number}","milestones_url":"https://api.github.com/repos/steida/este-watch/milestones{/number}","notifications_url":"https://api.github.com/repos/steida/este-watch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steida/este-watch/labels{/name}","releases_url":"https://api.github.com/repos/steida/este-watch/releases{/id}","created_at":"2014-01-21T22:36:53Z","updated_at":"2014-12-17T04:22:02Z","pushed_at":"2014-12-17T04:22:02Z","git_url":"git://github.com/steida/este-watch.git","ssh_url":"git@github.com:steida/este-watch.git","clone_url":"https://github.com/steida/este-watch.git","svn_url":"https://github.com/steida/este-watch","homepage":"","size":176,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/steida/este-watch/pulls/5"},"html":{"href":"https://github.com/steida/este-watch/pull/5"},"issue":{"href":"https://api.github.com/repos/steida/este-watch/issues/5"},"comments":{"href":"https://api.github.com/repos/steida/este-watch/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/steida/este-watch/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/steida/este-watch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/steida/este-watch/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/steida/este-watch/statuses/db19df91321ca16974c79f75aaa1634133b9f854"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":49,"deletions":47,"changed_files":2}}