GitHub PullRequestReviewCommentEvent at 2014-10-02 21:10:52
Repository: mne-python
Actor: Eric89GXL
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/18368218","id":18368218,"diff_hunk":"@@ -282,13 +286,13 @@ def _read_segment(self, start=0, stop=None, sel=None, verbose=None,\n                             mult = max_samp / samp\n                             chan_data = resample(x=chan_data, up=mult,\n                                                  down=1, npad=0)\n-                        stop_pt = chan_data.shape[1]\n+                        stop_pt = chan_data.shape[0]","path":"mne/io/edf/edf.py","position":69,"original_position":69,"commit_id":"c23c3950aff86f89ae68cc8ef66f73f300cd1092","original_commit_id":"c23c3950aff86f89ae68cc8ef66f73f300cd1092","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=2","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"This must have been an un-caught bug before, right? Any way to add a test that ensures it's working properly? If it's not easy and you're confident this is correct, don't sweat it.","created_at":"2014-10-02T21:10:52Z","updated_at":"2014-10-02T21:10:52Z","html_url":"https://github.com/mne-tools/mne-python/pull/1574#discussion_r18368218","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1574","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/18368218"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/1574#discussion_r18368218"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1574"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1574","id":21727254,"html_url":"https://github.com/mne-tools/mne-python/pull/1574","diff_url":"https://github.com/mne-tools/mne-python/pull/1574.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/1574.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1574","number":1574,"state":"open","locked":false,"title":"FIX bug related to loading datablocks.","user":{"login":"t3on","id":1578674,"avatar_url":"https://avatars.githubusercontent.com/u/1578674?v=2","gravatar_id":"","url":"https://api.github.com/users/t3on","html_url":"https://github.com/t3on","followers_url":"https://api.github.com/users/t3on/followers","following_url":"https://api.github.com/users/t3on/following{/other_user}","gists_url":"https://api.github.com/users/t3on/gists{/gist_id}","starred_url":"https://api.github.com/users/t3on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3on/subscriptions","organizations_url":"https://api.github.com/users/t3on/orgs","repos_url":"https://api.github.com/users/t3on/repos","events_url":"https://api.github.com/users/t3on/events{/privacy}","received_events_url":"https://api.github.com/users/t3on/received_events","type":"User","site_admin":false},"body":"datablocks can have a length different than the sampling frequency. The current code assumes that the sampling frequency and the number of samples per block are the same. This turns out to be a bad assumption.\r\n\r\naddresses issue: https://github.com/mne-tools/mne-python/issues/1324\r\n\r\n@herrlich10 or someone else, could you test this to see if this resolves the issue. I would do so but my Matlab is not compatible with the beta Yosemite I installed (a bit impulsively).","created_at":"2014-09-24T16:38:37Z","updated_at":"2014-10-02T21:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68bf373471b70561469e98be2012768acc17b29f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1574/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1574/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1574/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/c23c3950aff86f89ae68cc8ef66f73f300cd1092","head":{"label":"t3on:tb-edf-FIX","ref":"tb-edf-FIX","sha":"c23c3950aff86f89ae68cc8ef66f73f300cd1092","user":{"login":"t3on","id":1578674,"avatar_url":"https://avatars.githubusercontent.com/u/1578674?v=2","gravatar_id":"","url":"https://api.github.com/users/t3on","html_url":"https://github.com/t3on","followers_url":"https://api.github.com/users/t3on/followers","following_url":"https://api.github.com/users/t3on/following{/other_user}","gists_url":"https://api.github.com/users/t3on/gists{/gist_id}","starred_url":"https://api.github.com/users/t3on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3on/subscriptions","organizations_url":"https://api.github.com/users/t3on/orgs","repos_url":"https://api.github.com/users/t3on/repos","events_url":"https://api.github.com/users/t3on/events{/privacy}","received_events_url":"https://api.github.com/users/t3on/received_events","type":"User","site_admin":false},"repo":{"id":6598396,"name":"mne-python","full_name":"t3on/mne-python","owner":{"login":"t3on","id":1578674,"avatar_url":"https://avatars.githubusercontent.com/u/1578674?v=2","gravatar_id":"","url":"https://api.github.com/users/t3on","html_url":"https://github.com/t3on","followers_url":"https://api.github.com/users/t3on/followers","following_url":"https://api.github.com/users/t3on/following{/other_user}","gists_url":"https://api.github.com/users/t3on/gists{/gist_id}","starred_url":"https://api.github.com/users/t3on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3on/subscriptions","organizations_url":"https://api.github.com/users/t3on/orgs","repos_url":"https://api.github.com/users/t3on/repos","events_url":"https://api.github.com/users/t3on/events{/privacy}","received_events_url":"https://api.github.com/users/t3on/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/t3on/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/t3on/mne-python","forks_url":"https://api.github.com/repos/t3on/mne-python/forks","keys_url":"https://api.github.com/repos/t3on/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/t3on/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/t3on/mne-python/teams","hooks_url":"https://api.github.com/repos/t3on/mne-python/hooks","issue_events_url":"https://api.github.com/repos/t3on/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/t3on/mne-python/events","assignees_url":"https://api.github.com/repos/t3on/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/t3on/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/t3on/mne-python/tags","blobs_url":"https://api.github.com/repos/t3on/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/t3on/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/t3on/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/t3on/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/t3on/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/t3on/mne-python/languages","stargazers_url":"https://api.github.com/repos/t3on/mne-python/stargazers","contributors_url":"https://api.github.com/repos/t3on/mne-python/contributors","subscribers_url":"https://api.github.com/repos/t3on/mne-python/subscribers","subscription_url":"https://api.github.com/repos/t3on/mne-python/subscription","commits_url":"https://api.github.com/repos/t3on/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/t3on/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/t3on/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/t3on/mne-python/issues/comments/{number}","contents_url":"https://api.github.com/repos/t3on/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/t3on/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/t3on/mne-python/merges","archive_url":"https://api.github.com/repos/t3on/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/t3on/mne-python/downloads","issues_url":"https://api.github.com/repos/t3on/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/t3on/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/t3on/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/t3on/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/t3on/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/t3on/mne-python/releases{/id}","created_at":"2012-11-08T15:32:25Z","updated_at":"2014-07-24T13:00:37Z","pushed_at":"2014-10-02T17:12:29Z","git_url":"git://github.com/t3on/mne-python.git","ssh_url":"git@github.com:t3on/mne-python.git","clone_url":"https://github.com/t3on/mne-python.git","svn_url":"https://github.com/t3on/mne-python","homepage":"http://martinos.org/mne/","size":105216,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"20e09e59f0d9dbd90df66448c0d4ba66260cbc00","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=2","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=2","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/{number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2014-09-29T08:40:47Z","pushed_at":"2014-10-02T12:45:08Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":164557,"stargazers_count":100,"watchers_count":100,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":145,"forks":89,"open_issues":145,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1574"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/1574"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/1574"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/1574/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1574/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1574/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/c23c3950aff86f89ae68cc8ef66f73f300cd1092"}}}}