GitHub PullRequestReviewCommentEvent at 2014-07-25 13:31:07
Repository: ec-metal
Actor: jmink
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/ec-metal/pulls/comments/15400208","id":15400208,"diff_hunk":"@@ -9,6 +9,40 @@ def initialize(params = {})\n     @region = params[:region] || 'us-east-1'\n   end\n \n+  def get_root_blockdevice\n+    ami_desc = describe_ami.first\n+    ami_desc['blockDeviceMapping'].\n+      select { |dev| dev['deviceName'] =~ /sda/ }.\n+      first['deviceName']\n+  end\n+\n+  def describe_ami\n+    aws = get_aws\n+    aws.describe_images('ImageId' => @ami).body['imagesSet']\n+  end\n+\n+  # refactor me\n+  def self.aws_vpc_assign_secondary_ip(provider, region, aws_access_key_id, aws_secret_access_key, server_id, ipaddress)\n+    require 'fog'","path":"cookbooks/ec-common/libraries/fog_helper.rb","position":18,"original_position":18,"commit_id":"377bbcf0a6fa290f3d1b3f632613658b288c52e9","original_commit_id":"377bbcf0a6fa290f3d1b3f632613658b288c52e9","user":{"login":"jmink","id":575198,"avatar_url":"https://avatars.githubusercontent.com/u/575198?","gravatar_id":"ae63208e69679b1e876e1c5c637b3094","url":"https://api.github.com/users/jmink","html_url":"https://github.com/jmink","followers_url":"https://api.github.com/users/jmink/followers","following_url":"https://api.github.com/users/jmink/following{/other_user}","gists_url":"https://api.github.com/users/jmink/gists{/gist_id}","starred_url":"https://api.github.com/users/jmink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmink/subscriptions","organizations_url":"https://api.github.com/users/jmink/orgs","repos_url":"https://api.github.com/users/jmink/repos","events_url":"https://api.github.com/users/jmink/events{/privacy}","received_events_url":"https://api.github.com/users/jmink/received_events","type":"User","site_admin":false},"body":"Why not require it at a file level?","created_at":"2014-07-25T13:31:07Z","updated_at":"2014-07-25T13:31:07Z","html_url":"https://github.com/opscode/ec-metal/pull/42#discussion_r15400208","pull_request_url":"https://api.github.com/repos/opscode/ec-metal/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/comments/15400208"},"html":{"href":"https://github.com/opscode/ec-metal/pull/42#discussion_r15400208"},"pull_request":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/ec-metal/pulls/42","id":18615805,"html_url":"https://github.com/opscode/ec-metal/pull/42","diff_url":"https://github.com/opscode/ec-metal/pull/42.diff","patch_url":"https://github.com/opscode/ec-metal/pull/42.patch","issue_url":"https://api.github.com/repos/opscode/ec-metal/issues/42","number":42,"state":"open","title":"Topology refactor / Standalone mode","user":{"login":"irvingpop","id":1616328,"avatar_url":"https://avatars.githubusercontent.com/u/1616328?","gravatar_id":"2ab9646154934c38afccb1ef7ea2bdc6","url":"https://api.github.com/users/irvingpop","html_url":"https://github.com/irvingpop","followers_url":"https://api.github.com/users/irvingpop/followers","following_url":"https://api.github.com/users/irvingpop/following{/other_user}","gists_url":"https://api.github.com/users/irvingpop/gists{/gist_id}","starred_url":"https://api.github.com/users/irvingpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvingpop/subscriptions","organizations_url":"https://api.github.com/users/irvingpop/orgs","repos_url":"https://api.github.com/users/irvingpop/repos","events_url":"https://api.github.com/users/irvingpop/events{/privacy}","received_events_url":"https://api.github.com/users/irvingpop/received_events","type":"User","site_admin":false},"body":"* Centralizes as much of the topology logic as possible into the `TopoHelper` class (in `ec-common/libraries/topo_helper.rb`)\r\n* Enables standalone topology (actually works)\r\n* Support Analytics node in a much less hacky way","created_at":"2014-07-19T00:56:15Z","updated_at":"2014-07-25T13:31:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9eeb3ead73a14dfe2041923346623716279e82c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/ec-metal/pulls/42/commits","review_comments_url":"https://api.github.com/repos/opscode/ec-metal/pulls/42/comments","review_comment_url":"https://api.github.com/repos/opscode/ec-metal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/ec-metal/issues/42/comments","statuses_url":"https://api.github.com/repos/opscode/ec-metal/statuses/377bbcf0a6fa290f3d1b3f632613658b288c52e9","head":{"label":"opscode:irving/factor-out-commonalities","ref":"irving/factor-out-commonalities","sha":"377bbcf0a6fa290f3d1b3f632613658b288c52e9","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":18124922,"name":"ec-metal","full_name":"opscode/ec-metal","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/ec-metal","description":"Chef-metal based tool for creating, managing and testing Enterprise Chef HA clusters","fork":false,"url":"https://api.github.com/repos/opscode/ec-metal","forks_url":"https://api.github.com/repos/opscode/ec-metal/forks","keys_url":"https://api.github.com/repos/opscode/ec-metal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/ec-metal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/ec-metal/teams","hooks_url":"https://api.github.com/repos/opscode/ec-metal/hooks","issue_events_url":"https://api.github.com/repos/opscode/ec-metal/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/ec-metal/events","assignees_url":"https://api.github.com/repos/opscode/ec-metal/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/ec-metal/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/ec-metal/tags","blobs_url":"https://api.github.com/repos/opscode/ec-metal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/ec-metal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/ec-metal/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/ec-metal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/ec-metal/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/ec-metal/languages","stargazers_url":"https://api.github.com/repos/opscode/ec-metal/stargazers","contributors_url":"https://api.github.com/repos/opscode/ec-metal/contributors","subscribers_url":"https://api.github.com/repos/opscode/ec-metal/subscribers","subscription_url":"https://api.github.com/repos/opscode/ec-metal/subscription","commits_url":"https://api.github.com/repos/opscode/ec-metal/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/ec-metal/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/ec-metal/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/ec-metal/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/ec-metal/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/ec-metal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/ec-metal/merges","archive_url":"https://api.github.com/repos/opscode/ec-metal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/ec-metal/downloads","issues_url":"https://api.github.com/repos/opscode/ec-metal/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/ec-metal/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/ec-metal/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/ec-metal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/ec-metal/labels{/name}","releases_url":"https://api.github.com/repos/opscode/ec-metal/releases{/id}","created_at":"2014-03-26T02:49:47Z","updated_at":"2014-07-18T19:24:25Z","pushed_at":"2014-07-25T00:29:07Z","git_url":"git://github.com/opscode/ec-metal.git","ssh_url":"git@github.com:opscode/ec-metal.git","clone_url":"https://github.com/opscode/ec-metal.git","svn_url":"https://github.com/opscode/ec-metal","homepage":null,"size":2419,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"4ad92f05c373f8363c957b23b48a2c1fbb691615","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":18124922,"name":"ec-metal","full_name":"opscode/ec-metal","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/ec-metal","description":"Chef-metal based tool for creating, managing and testing Enterprise Chef HA clusters","fork":false,"url":"https://api.github.com/repos/opscode/ec-metal","forks_url":"https://api.github.com/repos/opscode/ec-metal/forks","keys_url":"https://api.github.com/repos/opscode/ec-metal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/ec-metal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/ec-metal/teams","hooks_url":"https://api.github.com/repos/opscode/ec-metal/hooks","issue_events_url":"https://api.github.com/repos/opscode/ec-metal/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/ec-metal/events","assignees_url":"https://api.github.com/repos/opscode/ec-metal/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/ec-metal/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/ec-metal/tags","blobs_url":"https://api.github.com/repos/opscode/ec-metal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/ec-metal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/ec-metal/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/ec-metal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/ec-metal/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/ec-metal/languages","stargazers_url":"https://api.github.com/repos/opscode/ec-metal/stargazers","contributors_url":"https://api.github.com/repos/opscode/ec-metal/contributors","subscribers_url":"https://api.github.com/repos/opscode/ec-metal/subscribers","subscription_url":"https://api.github.com/repos/opscode/ec-metal/subscription","commits_url":"https://api.github.com/repos/opscode/ec-metal/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/ec-metal/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/ec-metal/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/ec-metal/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/ec-metal/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/ec-metal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/ec-metal/merges","archive_url":"https://api.github.com/repos/opscode/ec-metal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/ec-metal/downloads","issues_url":"https://api.github.com/repos/opscode/ec-metal/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/ec-metal/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/ec-metal/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/ec-metal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/ec-metal/labels{/name}","releases_url":"https://api.github.com/repos/opscode/ec-metal/releases{/id}","created_at":"2014-03-26T02:49:47Z","updated_at":"2014-07-18T19:24:25Z","pushed_at":"2014-07-25T00:29:07Z","git_url":"git://github.com/opscode/ec-metal.git","ssh_url":"git@github.com:opscode/ec-metal.git","clone_url":"https://github.com/opscode/ec-metal.git","svn_url":"https://github.com/opscode/ec-metal","homepage":null,"size":2419,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/42"},"html":{"href":"https://github.com/opscode/ec-metal/pull/42"},"issue":{"href":"https://api.github.com/repos/opscode/ec-metal/issues/42"},"comments":{"href":"https://api.github.com/repos/opscode/ec-metal/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/ec-metal/statuses/377bbcf0a6fa290f3d1b3f632613658b288c52e9"}}}}