GitHub PullRequestReviewCommentEvent at 2014-10-15 07:46:45
Repository: scikit-learn
Actor: arjoly
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/18878733","id":18878733,"diff_hunk":"@@ -625,6 +631,13 @@ class OutputCodeClassifier(BaseEstimator, ClassifierMixin, MetaEstimatorMixin):\n         If 1 is given, no parallel computing code is used at all, which is\n         useful for debugging. For n_jobs below -1, (n_cpus + 1 + n_jobs) are\n         used. Thus for n_jobs = -2, all CPUs but one are used.\n+    coding_strategy : str, optional, default: None\n+        The strategy to generate a code book for all classes. Two options are\n+        avalable currently: (1) \"random\": randomly generate a\n+        n_class x int(n_class*code_size) matrix, and set entries > 0.5 to be 1,\n+        the rest to be 0 or -1; (2) \"opt_column_selection\": select subset of","path":"sklearn/multiclass.py","position":21,"original_position":21,"commit_id":"9d98ccac4df859e9267e1df7894e09e58496d5bf","original_commit_id":"9d98ccac4df859e9267e1df7894e09e58496d5bf","user":{"login":"arjoly","id":1274722,"avatar_url":"https://avatars.githubusercontent.com/u/1274722?v=2","gravatar_id":"","url":"https://api.github.com/users/arjoly","html_url":"https://github.com/arjoly","followers_url":"https://api.github.com/users/arjoly/followers","following_url":"https://api.github.com/users/arjoly/following{/other_user}","gists_url":"https://api.github.com/users/arjoly/gists{/gist_id}","starred_url":"https://api.github.com/users/arjoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjoly/subscriptions","organizations_url":"https://api.github.com/users/arjoly/orgs","repos_url":"https://api.github.com/users/arjoly/repos","events_url":"https://api.github.com/users/arjoly/events{/privacy}","received_events_url":"https://api.github.com/users/arjoly/received_events","type":"User","site_admin":false},"body":"`opt_column_selection` =>  I would try to find a better name that tells to the user what is done. Maybe something like `hamming` . If I have understood correctly, it subsamples a [hamming code](http://en.wikipedia.org/wiki/Hamming_code)","created_at":"2014-10-15T07:46:45Z","updated_at":"2014-10-15T07:46:45Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/3768#discussion_r18878733","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3768","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/18878733"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3768#discussion_r18878733"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3768"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3768","id":22670604,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/3768","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/3768.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/3768.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3768","number":3768,"state":"open","locked":false,"title":"Fix the issue #3745, the code book generation for OutputCodeClassifier","user":{"login":"queqichao","id":8002406,"avatar_url":"https://avatars.githubusercontent.com/u/8002406?v=2","gravatar_id":"","url":"https://api.github.com/users/queqichao","html_url":"https://github.com/queqichao","followers_url":"https://api.github.com/users/queqichao/followers","following_url":"https://api.github.com/users/queqichao/following{/other_user}","gists_url":"https://api.github.com/users/queqichao/gists{/gist_id}","starred_url":"https://api.github.com/users/queqichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/queqichao/subscriptions","organizations_url":"https://api.github.com/users/queqichao/orgs","repos_url":"https://api.github.com/users/queqichao/repos","events_url":"https://api.github.com/users/queqichao/events{/privacy}","received_events_url":"https://api.github.com/users/queqichao/received_events","type":"User","site_admin":false},"body":"+ Change the process of generating output code for OutputCodeClassifier. The process is to draw subsets of the exhaustive code book, see [1], multiple times and pick the one that give largest hamming distances between classes.\r\n+ Change the default value of code_size from 1.5 to 1. 1.5 is problematic. For example when n_classes = 3, the size of exhaustive code book is 3, so 1.5 for code_size is not possible.\r\n+ Add test case.\r\n+ Update the document.\r\n\r\n[1] Thomas G. Dietterich, Ghulum Bakiri. Solving Multiclass Learning Problems via Error-Correcting Output Codes","created_at":"2014-10-13T20:37:41Z","updated_at":"2014-10-15T07:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0de3af264707f07e5392ccff1e495e821f76a43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3768/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3768/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3768/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/9d98ccac4df859e9267e1df7894e09e58496d5bf","head":{"label":"queqichao:multiclass_code_book_fix","ref":"multiclass_code_book_fix","sha":"9d98ccac4df859e9267e1df7894e09e58496d5bf","user":{"login":"queqichao","id":8002406,"avatar_url":"https://avatars.githubusercontent.com/u/8002406?v=2","gravatar_id":"","url":"https://api.github.com/users/queqichao","html_url":"https://github.com/queqichao","followers_url":"https://api.github.com/users/queqichao/followers","following_url":"https://api.github.com/users/queqichao/following{/other_user}","gists_url":"https://api.github.com/users/queqichao/gists{/gist_id}","starred_url":"https://api.github.com/users/queqichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/queqichao/subscriptions","organizations_url":"https://api.github.com/users/queqichao/orgs","repos_url":"https://api.github.com/users/queqichao/repos","events_url":"https://api.github.com/users/queqichao/events{/privacy}","received_events_url":"https://api.github.com/users/queqichao/received_events","type":"User","site_admin":false},"repo":{"id":24345904,"name":"scikit-learn","full_name":"queqichao/scikit-learn","owner":{"login":"queqichao","id":8002406,"avatar_url":"https://avatars.githubusercontent.com/u/8002406?v=2","gravatar_id":"","url":"https://api.github.com/users/queqichao","html_url":"https://github.com/queqichao","followers_url":"https://api.github.com/users/queqichao/followers","following_url":"https://api.github.com/users/queqichao/following{/other_user}","gists_url":"https://api.github.com/users/queqichao/gists{/gist_id}","starred_url":"https://api.github.com/users/queqichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/queqichao/subscriptions","organizations_url":"https://api.github.com/users/queqichao/orgs","repos_url":"https://api.github.com/users/queqichao/repos","events_url":"https://api.github.com/users/queqichao/events{/privacy}","received_events_url":"https://api.github.com/users/queqichao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/queqichao/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/queqichao/scikit-learn","forks_url":"https://api.github.com/repos/queqichao/scikit-learn/forks","keys_url":"https://api.github.com/repos/queqichao/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/queqichao/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/queqichao/scikit-learn/teams","hooks_url":"https://api.github.com/repos/queqichao/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/queqichao/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/queqichao/scikit-learn/events","assignees_url":"https://api.github.com/repos/queqichao/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/queqichao/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/queqichao/scikit-learn/tags","blobs_url":"https://api.github.com/repos/queqichao/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/queqichao/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/queqichao/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/queqichao/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/queqichao/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/queqichao/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/queqichao/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/queqichao/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/queqichao/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/queqichao/scikit-learn/subscription","commits_url":"https://api.github.com/repos/queqichao/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/queqichao/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/queqichao/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/queqichao/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/queqichao/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/queqichao/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/queqichao/scikit-learn/merges","archive_url":"https://api.github.com/repos/queqichao/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/queqichao/scikit-learn/downloads","issues_url":"https://api.github.com/repos/queqichao/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/queqichao/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/queqichao/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/queqichao/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/queqichao/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/queqichao/scikit-learn/releases{/id}","created_at":"2014-09-22T21:16:38Z","updated_at":"2014-10-02T19:10:23Z","pushed_at":"2014-10-14T16:30:04Z","git_url":"git://github.com/queqichao/scikit-learn.git","ssh_url":"git@github.com:queqichao/scikit-learn.git","clone_url":"https://github.com/queqichao/scikit-learn.git","svn_url":"https://github.com/queqichao/scikit-learn","homepage":"http://scikit-learn.org","size":54455,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"031a3fc3714a9c3c6a64d654e8ea3774e471d6c8","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=2","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=2","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2014-10-15T07:45:19Z","pushed_at":"2014-10-15T07:30:13Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":121368,"stargazers_count":4063,"watchers_count":4063,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2301,"mirror_url":null,"open_issues_count":513,"forks":2301,"open_issues":513,"watchers":4063,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3768"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3768"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3768"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3768/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3768/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3768/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/9d98ccac4df859e9267e1df7894e09e58496d5bf"}}}}