GitHub PullRequestReviewCommentEvent at 2014-02-24 17:01:49
Repository: xdzk
Actor: markfisher
Payload: {"comment":{"url":"https://api.github.com/repos/markfisher/xdzk/pulls/comments/9999261","id":9999261,"diff_hunk":"@@ -21,6 +23,6 @@\n \t// metadata extracted from the stream deployment manifest, such as the number of instances.\n \t// Also, the String return and collection element type should be Container instances\n \t// where ultimately matching will take Container attributes and metrics into consideration.\n-\tString match(String module, Set<String> candidates);\n+\tContainer match(String module, Iterator<Container> candidates);","path":"src/main/java/xdzk/ContainerMatcher.java","position":15,"original_position":15,"commit_id":"be2c4212146ba70804b5abb0748c752c0e8040dc","original_commit_id":"be2c4212146ba70804b5abb0748c752c0e8040dc","user":{"login":"markfisher","id":140784,"avatar_url":"https://gravatar.com/avatar/443e6ec0242c3f54001dae34374780e2?d=https%3A%2F%2Fidenticons.github.com%2Fb1f759106c20c03b7d9974ceca81a2b4.png&r=x","gravatar_id":"443e6ec0242c3f54001dae34374780e2","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"I was thinking the SpEL expressions would be part of the deployment descriptor and that the Container attributes and metrics would simply be properties of the EvaluationContext for those SpEL expressions.","created_at":"2014-02-24T17:01:49Z","updated_at":"2014-02-24T17:01:49Z","html_url":"https://github.com/markfisher/xdzk/pull/9#discussion_r9999261","pull_request_url":"https://api.github.com/repos/markfisher/xdzk/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/markfisher/xdzk/pulls/comments/9999261"},"html":{"href":"https://github.com/markfisher/xdzk/pull/9#discussion_r9999261"},"pull_request":{"href":"https://api.github.com/repos/markfisher/xdzk/pulls/9"}}}}