GitHub PushEvent at 2014-09-02 20:28:58
Repository: llvm-project-submodule
Actor: chapuni
Payload: {"shas":[["e729a9614b13c6af8e309e93c2b00fca52df4268","7932f6f8e186182cc51861f7d8587062b8d9ffdb@google.com","Fix MemoryDependenceAnalysis in cases where QueryInstr is a CmpXchg or a AtomicRMW\n\nSummary:\nMemoryDependenceAnalysis is currently cautious when the QueryInstr is an atomic\nload or store, but I forgot to check for atomic cmpxchg/atomicrmw. This patch\nis a way of fixing that, and making it less brittle (i.e. no risk that I forget\nanother possible kind of atomic, even if the IR ends up changing in the future),\nby adding a fallback checking mayReadOrWriteFromMemory.\n\nThanks to Philip Reames for finding this bug and suggesting this solution in\nhttp://reviews.llvm.org/D4845\n\nSadly, I don't see how to add a test for this, since the passes depending on\nMemoryDependenceAnalysis won't trigger for an atomic rmw anyway. Does anyone\nsee a way for testing it?\n\nTest Plan: none possible at first sight\n\nReviewers: jfb, reames\n\nSubscribers: llvm-commits\n\nDifferential Revision: http://reviews.llvm.org/D5019","Robin Morisset",true]],"size":1,"ref":"refs/heads/master","head":"e729a9614b13c6af8e309e93c2b00fca52df4268"}