GitHub PullRequestReviewCommentEvent at 2014-02-01 03:07:36
Repository: rust
Actor: huonw
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/rust/pulls/comments/9364156","id":9364156,"diff_hunk":"@@ -867,11 +874,14 @@ impl Clean<PathSegment> for ast::PathSegment {\n }\n \n fn path_to_str(p: &ast::Path) -> ~str {\n-    use syntax::parse::token::interner_get;\n+    use syntax::parse::token;\n \n     let mut s = ~\"\";\n     let mut first = true;\n-    for i in p.segments.iter().map(|x| interner_get(x.identifier.name)) {\n+    for i in p.segments.iter().map(|x| {","path":"src/librustdoc/clean.rs","position":76,"original_position":76,"commit_id":"8544cb2ee6d8dc45edc9734822dd303920a11e11","original_commit_id":"8544cb2ee6d8dc45edc9734822dd303920a11e11","user":{"login":"huonw","id":1203825,"avatar_url":"https://gravatar.com/avatar/365f3c2704e4744e237651f3c2a7c411?d=https%3A%2F%2Fidenticons.github.com%2Ffd04754df99d685827696fc1e66db286.png&r=x","gravatar_id":"365f3c2704e4744e237651f3c2a7c411","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"This will be much slower; it would be better to put the `string.get()` below in the `s.push_str(i);` call, to avoid the `.to_str()` allocation.","created_at":"2014-02-01T03:07:36Z","updated_at":"2014-02-01T03:07:36Z","html_url":"https://github.com/mozilla/rust/pull/11967#discussion_r9364156","pull_request_url":"https://api.github.com/repos/mozilla/rust/pulls/11967","_links":{"self":{"href":"https://api.github.com/repos/mozilla/rust/pulls/comments/9364156"},"html":{"href":"https://github.com/mozilla/rust/pull/11967#discussion_r9364156"},"pull_request":{"href":"https://api.github.com/repos/mozilla/rust/pulls/11967"}}}}