GitHub PullRequestReviewCommentEvent at 2014-05-14 02:00:43
Repository: data
Actor: pixelhandler
Payload: {"comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/12618228","id":12618228,"diff_hunk":"@@ -30,17 +30,24 @@ DS.EmbeddedRecordsMixin = Ember.Mixin.create({\n   serializeHasMany: function(record, json, relationship) {\n     var key   = relationship.key,\n         attrs = get(this, 'attrs'),\n-        embed = attrs && attrs[key] && attrs[key].embedded === 'always';\n+        embed = attrs && attrs[key] && attrs[key].embedded === 'always',\n+        jsonKey = this.keyForAttribute(key),\n+        promises;\n \n     if (embed) {","path":"packages/activemodel-adapter/lib/system/embedded_records_mixin.js","position":9,"original_position":9,"commit_id":"7f05c4840b052b88ac2247c1d5ed786c8f99f0e2","original_commit_id":"fae851ca19b5399a94fdf516a8ec1463bb6466fa","user":{"login":"pixelhandler","id":17178,"avatar_url":"https://avatars.githubusercontent.com/u/17178?","gravatar_id":"f5c7fcc9fcd5548dcec85fdef9f0b2c7","url":"https://api.github.com/users/pixelhandler","html_url":"https://github.com/pixelhandler","followers_url":"https://api.github.com/users/pixelhandler/followers","following_url":"https://api.github.com/users/pixelhandler/following{/other_user}","gists_url":"https://api.github.com/users/pixelhandler/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelhandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelhandler/subscriptions","organizations_url":"https://api.github.com/users/pixelhandler/orgs","repos_url":"https://api.github.com/users/pixelhandler/repos","events_url":"https://api.github.com/users/pixelhandler/events{/privacy}","received_events_url":"https://api.github.com/users/pixelhandler/received_events","type":"User","site_admin":false},"body":"@stefanpenner @jherdman embedded asyc does not make sense the embedded records mixin primary work is extracting (sync) records from an embedded payload so those records should be sync not asyc. Also has this been rebased since https://github.com/emberjs/data/pull/1637 was merged?","created_at":"2014-05-14T02:00:43Z","updated_at":"2014-05-14T02:00:43Z","html_url":"https://github.com/emberjs/data/pull/1535#discussion_r12618228","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/1535","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/12618228"},"html":{"href":"https://github.com/emberjs/data/pull/1535#discussion_r12618228"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/1535"}}}}