GitHub PullRequestReviewCommentEvent at 2014-07-11 12:24:07
Repository: hazelcast
Actor: mdogan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/14817789","id":14817789,"diff_hunk":"@@ -0,0 +1,189 @@\n+/*\n+ * Copyright (c) 2008-2014, Hazelcast, Inc. All Rights Reserved.\n+ *\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\");\n+ *  you may not use this file except in compliance with the License.\n+ *  You may obtain a copy of the License at\n+ *\n+ *  http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *  Unless required by applicable law or agreed to in writing, software\n+ *  distributed under the License is distributed on an \"AS IS\" BASIS,\n+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ *  See the License for the specific language governing permissions and\n+ *  limitations under the License.\n+ */\n+\n+package com.hazelcast.partition;\n+\n+import com.hazelcast.config.Config;\n+import com.hazelcast.config.MapConfig;\n+import com.hazelcast.core.Hazelcast;\n+import com.hazelcast.core.HazelcastInstance;\n+import com.hazelcast.core.IMap;\n+import com.hazelcast.core.PartitionService;\n+import com.hazelcast.map.AbstractEntryProcessor;\n+import com.hazelcast.test.HazelcastSerialClassRunner;\n+import com.hazelcast.test.TestHazelcastInstanceFactory;\n+import com.hazelcast.test.annotation.QuickTest;\n+import java.util.ArrayList;\n+import java.util.Collections;\n+import java.util.List;\n+import java.util.Map;\n+import java.util.concurrent.CountDownLatch;\n+import java.util.concurrent.atomic.AtomicBoolean;\n+import org.junit.After;\n+import org.junit.Test;\n+import org.junit.experimental.categories.Category;\n+import org.junit.runner.RunWith;\n+\n+import static org.junit.Assert.assertEquals;\n+\n+@RunWith(HazelcastSerialClassRunner.class)\n+@Category(QuickTest.class)\n+public class RebalancingPartitionTest {\n+\n+    private static final int ENTRIES = 10;\n+    private static final long ITERATIONS = 50;\n+    private static String MAP_NAME = \"test-map\";\n+    private static TestHazelcastInstanceFactory instanceFactory = new TestHazelcastInstanceFactory(50);\n+\n+    @After\n+    public void teardown() {\n+        Hazelcast.shutdownAll();","path":"hazelcast/src/test/java/com/hazelcast/partition/RebalancingPartitionTest.java","position":53,"original_position":53,"commit_id":"4a236c1ab792916699ac6211633e61601a78f31c","original_commit_id":"4a236c1ab792916699ac6211633e61601a78f31c","user":{"login":"mdogan","id":1201712,"avatar_url":"https://avatars.githubusercontent.com/u/1201712?","gravatar_id":"f7b173060d46c52e0288d1d1905e258b","url":"https://api.github.com/users/mdogan","html_url":"https://github.com/mdogan","followers_url":"https://api.github.com/users/mdogan/followers","following_url":"https://api.github.com/users/mdogan/following{/other_user}","gists_url":"https://api.github.com/users/mdogan/gists{/gist_id}","starred_url":"https://api.github.com/users/mdogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdogan/subscriptions","organizations_url":"https://api.github.com/users/mdogan/orgs","repos_url":"https://api.github.com/users/mdogan/repos","events_url":"https://api.github.com/users/mdogan/events{/privacy}","received_events_url":"https://api.github.com/users/mdogan/received_events","type":"User","site_admin":false},"body":"you need to call `instanceFactory.shutdownAll()` here. Better extend `HazelcastTestSupport` and use `HazelcastTestSupport.createHazelcastInstanceFactory()`...","created_at":"2014-07-11T12:24:07Z","updated_at":"2014-07-11T12:24:07Z","html_url":"https://github.com/hazelcast/hazelcast/pull/2973#discussion_r14817789","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/2973","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/14817789"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/2973#discussion_r14817789"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/2973"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/2973","id":18214641,"html_url":"https://github.com/hazelcast/hazelcast/pull/2973","diff_url":"https://github.com/hazelcast/hazelcast/pull/2973.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/2973.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/2973","number":2973,"state":"open","title":"prevent data loss while promoting from second replica to owner.","user":{"login":"eminn","id":378108,"avatar_url":"https://avatars.githubusercontent.com/u/378108?","gravatar_id":"e7fd281e80167cd7e89811636a0b4db5","url":"https://api.github.com/users/eminn","html_url":"https://github.com/eminn","followers_url":"https://api.github.com/users/eminn/followers","following_url":"https://api.github.com/users/eminn/following{/other_user}","gists_url":"https://api.github.com/users/eminn/gists{/gist_id}","starred_url":"https://api.github.com/users/eminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eminn/subscriptions","organizations_url":"https://api.github.com/users/eminn/orgs","repos_url":"https://api.github.com/users/eminn/repos","events_url":"https://api.github.com/users/eminn/events{/privacy}","received_events_url":"https://api.github.com/users/eminn/received_events","type":"User","site_admin":false},"body":"Fixes #2785","created_at":"2014-07-10T11:48:56Z","updated_at":"2014-07-11T12:24:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7006d9b6c38790f598bc0051b571de5e2a2e48c","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/44","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/44/labels","id":605363,"number":44,"title":"3.3","description":"","creator":{"login":"mdogan","id":1201712,"avatar_url":"https://avatars.githubusercontent.com/u/1201712?","gravatar_id":"f7b173060d46c52e0288d1d1905e258b","url":"https://api.github.com/users/mdogan","html_url":"https://github.com/mdogan","followers_url":"https://api.github.com/users/mdogan/followers","following_url":"https://api.github.com/users/mdogan/following{/other_user}","gists_url":"https://api.github.com/users/mdogan/gists{/gist_id}","starred_url":"https://api.github.com/users/mdogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdogan/subscriptions","organizations_url":"https://api.github.com/users/mdogan/orgs","repos_url":"https://api.github.com/users/mdogan/repos","events_url":"https://api.github.com/users/mdogan/events{/privacy}","received_events_url":"https://api.github.com/users/mdogan/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":363,"state":"open","created_at":"2014-03-21T19:24:44Z","updated_at":"2014-07-11T12:17:18Z","due_on":"2014-08-01T07:00:00Z"},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/2973/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/2973/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/2973/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/4a236c1ab792916699ac6211633e61601a78f31c","head":{"label":"eminn:fix/data-loss-while-promoting-from-backup","ref":"fix/data-loss-while-promoting-from-backup","sha":"4a236c1ab792916699ac6211633e61601a78f31c","user":{"login":"eminn","id":378108,"avatar_url":"https://avatars.githubusercontent.com/u/378108?","gravatar_id":"e7fd281e80167cd7e89811636a0b4db5","url":"https://api.github.com/users/eminn","html_url":"https://github.com/eminn","followers_url":"https://api.github.com/users/eminn/followers","following_url":"https://api.github.com/users/eminn/following{/other_user}","gists_url":"https://api.github.com/users/eminn/gists{/gist_id}","starred_url":"https://api.github.com/users/eminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eminn/subscriptions","organizations_url":"https://api.github.com/users/eminn/orgs","repos_url":"https://api.github.com/users/eminn/repos","events_url":"https://api.github.com/users/eminn/events{/privacy}","received_events_url":"https://api.github.com/users/eminn/received_events","type":"User","site_admin":false},"repo":{"id":6697413,"name":"hazelcast","full_name":"eminn/hazelcast","owner":{"login":"eminn","id":378108,"avatar_url":"https://avatars.githubusercontent.com/u/378108?","gravatar_id":"e7fd281e80167cd7e89811636a0b4db5","url":"https://api.github.com/users/eminn","html_url":"https://github.com/eminn","followers_url":"https://api.github.com/users/eminn/followers","following_url":"https://api.github.com/users/eminn/following{/other_user}","gists_url":"https://api.github.com/users/eminn/gists{/gist_id}","starred_url":"https://api.github.com/users/eminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eminn/subscriptions","organizations_url":"https://api.github.com/users/eminn/orgs","repos_url":"https://api.github.com/users/eminn/repos","events_url":"https://api.github.com/users/eminn/events{/privacy}","received_events_url":"https://api.github.com/users/eminn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eminn/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/eminn/hazelcast","forks_url":"https://api.github.com/repos/eminn/hazelcast/forks","keys_url":"https://api.github.com/repos/eminn/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eminn/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eminn/hazelcast/teams","hooks_url":"https://api.github.com/repos/eminn/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/eminn/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/eminn/hazelcast/events","assignees_url":"https://api.github.com/repos/eminn/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/eminn/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/eminn/hazelcast/tags","blobs_url":"https://api.github.com/repos/eminn/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eminn/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eminn/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/eminn/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eminn/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/eminn/hazelcast/languages","stargazers_url":"https://api.github.com/repos/eminn/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/eminn/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/eminn/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/eminn/hazelcast/subscription","commits_url":"https://api.github.com/repos/eminn/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/eminn/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/eminn/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/eminn/hazelcast/issues/comments/{number}","contents_url":"https://api.github.com/repos/eminn/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/eminn/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eminn/hazelcast/merges","archive_url":"https://api.github.com/repos/eminn/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eminn/hazelcast/downloads","issues_url":"https://api.github.com/repos/eminn/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/eminn/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/eminn/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/eminn/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eminn/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/eminn/hazelcast/releases{/id}","created_at":"2012-11-15T00:39:03Z","updated_at":"2014-06-24T12:36:16Z","pushed_at":"2014-07-11T11:40:07Z","git_url":"git://github.com/eminn/hazelcast.git","ssh_url":"git@github.com:eminn/hazelcast.git","clone_url":"https://github.com/eminn/hazelcast.git","svn_url":"https://github.com/eminn/hazelcast","homepage":"www.hazelcast.com","size":47378,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"87d0edf233cf8ec5f58cb37675db51b6f833cb6c","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?","gravatar_id":"9bbb2c780bf7972b79c8a54804eb5837","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?","gravatar_id":"9bbb2c780bf7972b79c8a54804eb5837","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/{number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2014-07-11T10:00:58Z","pushed_at":"2014-07-11T12:17:19Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":97308,"stargazers_count":814,"watchers_count":814,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":327,"mirror_url":null,"open_issues_count":244,"forks":327,"open_issues":244,"watchers":814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/2973"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/2973"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/2973"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/2973/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/2973/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/2973/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/4a236c1ab792916699ac6211633e61601a78f31c"}}}}