GitHub PullRequestReviewCommentEvent at 2014-09-16 15:48:28
Repository: diagrams-contrib
Actor: bergey
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/comments/17609888","id":17609888,"diff_hunk":"@@ -101,8 +99,8 @@ data Q236 = Q236 Rational Rational Rational Rational\n   deriving (Eq, Ord, Show, Read)","path":"src/Diagrams/TwoD/Tilings.hs","position":24,"original_position":24,"commit_id":"fddafd3ff9cdea8c3f963418db829a9c2b26f1c2","original_commit_id":"fddafd3ff9cdea8c3f963418db829a9c2b26f1c2","user":{"login":"bergey","id":251106,"avatar_url":"https://avatars.githubusercontent.com/u/251106?v=2","gravatar_id":"c321c5241605255cae9ecf3fb2dffc0b","url":"https://api.github.com/users/bergey","html_url":"https://github.com/bergey","followers_url":"https://api.github.com/users/bergey/followers","following_url":"https://api.github.com/users/bergey/following{/other_user}","gists_url":"https://api.github.com/users/bergey/gists{/gist_id}","starred_url":"https://api.github.com/users/bergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergey/subscriptions","organizations_url":"https://api.github.com/users/bergey/orgs","repos_url":"https://api.github.com/users/bergey/repos","events_url":"https://api.github.com/users/bergey/events{/privacy}","received_events_url":"https://api.github.com/users/bergey/received_events","type":"User","site_admin":false},"body":"That `Ord` instance has been there longer than I've been involved, so I hadn't really thought about it.  I agree, it doesn't do what I'd expect (though it's adequate for `Map` and the like).  Does `Grid` care which behavior is used?","created_at":"2014-09-16T15:48:28Z","updated_at":"2014-09-16T15:48:28Z","html_url":"https://github.com/diagrams/diagrams-contrib/pull/40#discussion_r17609888","pull_request_url":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/comments/17609888"},"html":{"href":"https://github.com/diagrams/diagrams-contrib/pull/40#discussion_r17609888"},"pull_request":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/40","id":21194469,"html_url":"https://github.com/diagrams/diagrams-contrib/pull/40","diff_url":"https://github.com/diagrams/diagrams-contrib/pull/40.diff","patch_url":"https://github.com/diagrams/diagrams-contrib/pull/40.patch","issue_url":"https://api.github.com/repos/diagrams/diagrams-contrib/issues/40","number":40,"state":"open","locked":false,"title":"update for linear","user":{"login":"bergey","id":251106,"avatar_url":"https://avatars.githubusercontent.com/u/251106?v=2","gravatar_id":"c321c5241605255cae9ecf3fb2dffc0b","url":"https://api.github.com/users/bergey","html_url":"https://github.com/bergey","followers_url":"https://api.github.com/users/bergey/followers","following_url":"https://api.github.com/users/bergey/following{/other_user}","gists_url":"https://api.github.com/users/bergey/gists{/gist_id}","starred_url":"https://api.github.com/users/bergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergey/subscriptions","organizations_url":"https://api.github.com/users/bergey/orgs","repos_url":"https://api.github.com/users/bergey/repos","events_url":"https://api.github.com/users/bergey/events{/privacy}","received_events_url":"https://api.github.com/users/bergey/received_events","type":"User","site_admin":false},"body":"Accompanies https://github.com/diagrams/diagrams-lib/pull/212\r\n\r\nThis is nearly done; it remains to decide what to do about `force-layout`, and the minor name collision of `size`.  I think the choices with `force-layout` are port it to linear (it has [no revdeps but `diagrams-contrib`](http://packdeps.haskellers.com/reverse/force-layout)) or create `vector-space` class instances for `V2` and other types, in `diagrams-contrib`.","created_at":"2014-09-13T16:10:07Z","updated_at":"2014-09-16T15:48:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18c74ec65f40efd5dcb190446d0a9211e932b1b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/40/commits","review_comments_url":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/40/comments","review_comment_url":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/diagrams/diagrams-contrib/issues/40/comments","statuses_url":"https://api.github.com/repos/diagrams/diagrams-contrib/statuses/fddafd3ff9cdea8c3f963418db829a9c2b26f1c2","head":{"label":"diagrams:linear","ref":"linear","sha":"fddafd3ff9cdea8c3f963418db829a9c2b26f1c2","user":{"login":"diagrams","id":2036567,"avatar_url":"https://avatars.githubusercontent.com/u/2036567?v=2","gravatar_id":"2778bd14f90ecd480ed74b5da1493088","url":"https://api.github.com/users/diagrams","html_url":"https://github.com/diagrams","followers_url":"https://api.github.com/users/diagrams/followers","following_url":"https://api.github.com/users/diagrams/following{/other_user}","gists_url":"https://api.github.com/users/diagrams/gists{/gist_id}","starred_url":"https://api.github.com/users/diagrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diagrams/subscriptions","organizations_url":"https://api.github.com/users/diagrams/orgs","repos_url":"https://api.github.com/users/diagrams/repos","events_url":"https://api.github.com/users/diagrams/events{/privacy}","received_events_url":"https://api.github.com/users/diagrams/received_events","type":"Organization","site_admin":false},"repo":{"id":5172452,"name":"diagrams-contrib","full_name":"diagrams/diagrams-contrib","owner":{"login":"diagrams","id":2036567,"avatar_url":"https://avatars.githubusercontent.com/u/2036567?v=2","gravatar_id":"2778bd14f90ecd480ed74b5da1493088","url":"https://api.github.com/users/diagrams","html_url":"https://github.com/diagrams","followers_url":"https://api.github.com/users/diagrams/followers","following_url":"https://api.github.com/users/diagrams/following{/other_user}","gists_url":"https://api.github.com/users/diagrams/gists{/gist_id}","starred_url":"https://api.github.com/users/diagrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diagrams/subscriptions","organizations_url":"https://api.github.com/users/diagrams/orgs","repos_url":"https://api.github.com/users/diagrams/repos","events_url":"https://api.github.com/users/diagrams/events{/privacy}","received_events_url":"https://api.github.com/users/diagrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diagrams/diagrams-contrib","description":"User-contributed extensions to diagrams","fork":false,"url":"https://api.github.com/repos/diagrams/diagrams-contrib","forks_url":"https://api.github.com/repos/diagrams/diagrams-contrib/forks","keys_url":"https://api.github.com/repos/diagrams/diagrams-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diagrams/diagrams-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diagrams/diagrams-contrib/teams","hooks_url":"https://api.github.com/repos/diagrams/diagrams-contrib/hooks","issue_events_url":"https://api.github.com/repos/diagrams/diagrams-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/diagrams/diagrams-contrib/events","assignees_url":"https://api.github.com/repos/diagrams/diagrams-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/diagrams/diagrams-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/diagrams/diagrams-contrib/tags","blobs_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diagrams/diagrams-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/diagrams/diagrams-contrib/languages","stargazers_url":"https://api.github.com/repos/diagrams/diagrams-contrib/stargazers","contributors_url":"https://api.github.com/repos/diagrams/diagrams-contrib/contributors","subscribers_url":"https://api.github.com/repos/diagrams/diagrams-contrib/subscribers","subscription_url":"https://api.github.com/repos/diagrams/diagrams-contrib/subscription","commits_url":"https://api.github.com/repos/diagrams/diagrams-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/diagrams/diagrams-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/diagrams/diagrams-contrib/issues/comments/{number}","contents_url":"https://api.github.com/repos/diagrams/diagrams-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/diagrams/diagrams-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diagrams/diagrams-contrib/merges","archive_url":"https://api.github.com/repos/diagrams/diagrams-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diagrams/diagrams-contrib/downloads","issues_url":"https://api.github.com/repos/diagrams/diagrams-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/diagrams/diagrams-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/diagrams/diagrams-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diagrams/diagrams-contrib/labels{/name}","releases_url":"https://api.github.com/repos/diagrams/diagrams-contrib/releases{/id}","created_at":"2012-07-24T23:15:14Z","updated_at":"2014-09-11T14:18:26Z","pushed_at":"2014-09-16T13:47:24Z","git_url":"git://github.com/diagrams/diagrams-contrib.git","ssh_url":"git@github.com:diagrams/diagrams-contrib.git","clone_url":"https://github.com/diagrams/diagrams-contrib.git","svn_url":"https://github.com/diagrams/diagrams-contrib","homepage":null,"size":8561,"stargazers_count":5,"watchers_count":5,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"diagrams:master","ref":"master","sha":"4769ea6cc0824765cd72cc0e5670c39966482b58","user":{"login":"diagrams","id":2036567,"avatar_url":"https://avatars.githubusercontent.com/u/2036567?v=2","gravatar_id":"2778bd14f90ecd480ed74b5da1493088","url":"https://api.github.com/users/diagrams","html_url":"https://github.com/diagrams","followers_url":"https://api.github.com/users/diagrams/followers","following_url":"https://api.github.com/users/diagrams/following{/other_user}","gists_url":"https://api.github.com/users/diagrams/gists{/gist_id}","starred_url":"https://api.github.com/users/diagrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diagrams/subscriptions","organizations_url":"https://api.github.com/users/diagrams/orgs","repos_url":"https://api.github.com/users/diagrams/repos","events_url":"https://api.github.com/users/diagrams/events{/privacy}","received_events_url":"https://api.github.com/users/diagrams/received_events","type":"Organization","site_admin":false},"repo":{"id":5172452,"name":"diagrams-contrib","full_name":"diagrams/diagrams-contrib","owner":{"login":"diagrams","id":2036567,"avatar_url":"https://avatars.githubusercontent.com/u/2036567?v=2","gravatar_id":"2778bd14f90ecd480ed74b5da1493088","url":"https://api.github.com/users/diagrams","html_url":"https://github.com/diagrams","followers_url":"https://api.github.com/users/diagrams/followers","following_url":"https://api.github.com/users/diagrams/following{/other_user}","gists_url":"https://api.github.com/users/diagrams/gists{/gist_id}","starred_url":"https://api.github.com/users/diagrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diagrams/subscriptions","organizations_url":"https://api.github.com/users/diagrams/orgs","repos_url":"https://api.github.com/users/diagrams/repos","events_url":"https://api.github.com/users/diagrams/events{/privacy}","received_events_url":"https://api.github.com/users/diagrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diagrams/diagrams-contrib","description":"User-contributed extensions to diagrams","fork":false,"url":"https://api.github.com/repos/diagrams/diagrams-contrib","forks_url":"https://api.github.com/repos/diagrams/diagrams-contrib/forks","keys_url":"https://api.github.com/repos/diagrams/diagrams-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diagrams/diagrams-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diagrams/diagrams-contrib/teams","hooks_url":"https://api.github.com/repos/diagrams/diagrams-contrib/hooks","issue_events_url":"https://api.github.com/repos/diagrams/diagrams-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/diagrams/diagrams-contrib/events","assignees_url":"https://api.github.com/repos/diagrams/diagrams-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/diagrams/diagrams-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/diagrams/diagrams-contrib/tags","blobs_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diagrams/diagrams-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/diagrams/diagrams-contrib/languages","stargazers_url":"https://api.github.com/repos/diagrams/diagrams-contrib/stargazers","contributors_url":"https://api.github.com/repos/diagrams/diagrams-contrib/contributors","subscribers_url":"https://api.github.com/repos/diagrams/diagrams-contrib/subscribers","subscription_url":"https://api.github.com/repos/diagrams/diagrams-contrib/subscription","commits_url":"https://api.github.com/repos/diagrams/diagrams-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/diagrams/diagrams-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/diagrams/diagrams-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/diagrams/diagrams-contrib/issues/comments/{number}","contents_url":"https://api.github.com/repos/diagrams/diagrams-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/diagrams/diagrams-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diagrams/diagrams-contrib/merges","archive_url":"https://api.github.com/repos/diagrams/diagrams-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diagrams/diagrams-contrib/downloads","issues_url":"https://api.github.com/repos/diagrams/diagrams-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/diagrams/diagrams-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/diagrams/diagrams-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diagrams/diagrams-contrib/labels{/name}","releases_url":"https://api.github.com/repos/diagrams/diagrams-contrib/releases{/id}","created_at":"2012-07-24T23:15:14Z","updated_at":"2014-09-11T14:18:26Z","pushed_at":"2014-09-16T13:47:24Z","git_url":"git://github.com/diagrams/diagrams-contrib.git","ssh_url":"git@github.com:diagrams/diagrams-contrib.git","clone_url":"https://github.com/diagrams/diagrams-contrib.git","svn_url":"https://github.com/diagrams/diagrams-contrib","homepage":null,"size":8561,"stargazers_count":5,"watchers_count":5,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/40"},"html":{"href":"https://github.com/diagrams/diagrams-contrib/pull/40"},"issue":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/issues/40"},"comments":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/diagrams/diagrams-contrib/statuses/fddafd3ff9cdea8c3f963418db829a9c2b26f1c2"}}}}