GitHub PullRequestEvent at 2014-09-18 15:10:16
Repository: positron
Actor: dzucconi
Payload: {"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/artsy/positron/pulls/3","id":21396693,"html_url":"https://github.com/artsy/positron/pull/3","diff_url":"https://github.com/artsy/positron/pull/3.diff","patch_url":"https://github.com/artsy/positron/pull/3.patch","issue_url":"https://api.github.com/repos/artsy/positron/issues/3","number":3,"state":"closed","locked":false,"title":"@dzucconi (cc @dylanfareed): Initial wire up to Spooky","user":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars.githubusercontent.com/u/555859?v=2","gravatar_id":"22eaa51cd23d3f179c685b0b84b7cb54","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"body":"This starts to wire up Positron to Spooky. I've copy & pasted a lot of code from your [Force PR](https://github.com/artsy/force/pull/1272), so thanks for that.\r\n\r\nI don't think I know enough about HAL yet to understand how to take advantage of it. Right now it seems like we're just going through the extra effort to override parse to ignore the `_links` and such. Maybe there's a way to write an adapter that better takes advantage of the automatic-crawling/not-hardcoded-urls ideas of HAL. Lemme know if you have any thoughts.\r\n\r\nAs a side note I've briefly looked at these which may be of use:\r\nhttps://github.com/mikekelly/backbone.hal\r\nhttps://github.com/basti1302/traverson\r\nhttps://github.com/weluse/hyperagent\r\n\r\nStill TODO: Write tests for the article/section models, which I will try to loop into my next PR.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/555859/4311152/6d0e3042-3eac-11e4-986c-029834e37a2a.png)","created_at":"2014-09-17T21:14:22Z","updated_at":"2014-09-18T15:10:15Z","closed_at":"2014-09-18T15:10:15Z","merged_at":"2014-09-18T15:10:15Z","merge_commit_sha":"34d9d13ed8ae7ecf0cd1ed92b024d52123e20270","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/positron/pulls/3/commits","review_comments_url":"https://api.github.com/repos/artsy/positron/pulls/3/comments","review_comment_url":"https://api.github.com/repos/artsy/positron/pulls/comments/{number}","comments_url":"https://api.github.com/repos/artsy/positron/issues/3/comments","statuses_url":"https://api.github.com/repos/artsy/positron/statuses/41cc2222bf1fb810455fc6306517903874e57034","head":{"label":"craigspaeth:master","ref":"master","sha":"41cc2222bf1fb810455fc6306517903874e57034","user":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars.githubusercontent.com/u/555859?v=2","gravatar_id":"22eaa51cd23d3f179c685b0b84b7cb54","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"repo":{"id":23811183,"name":"positron","full_name":"craigspaeth/positron","owner":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars.githubusercontent.com/u/555859?v=2","gravatar_id":"22eaa51cd23d3f179c685b0b84b7cb54","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craigspaeth/positron","description":"Otherwise known as Artsy Writer. The back-end posting tool for publishing on Artsy.","fork":true,"url":"https://api.github.com/repos/craigspaeth/positron","forks_url":"https://api.github.com/repos/craigspaeth/positron/forks","keys_url":"https://api.github.com/repos/craigspaeth/positron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craigspaeth/positron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craigspaeth/positron/teams","hooks_url":"https://api.github.com/repos/craigspaeth/positron/hooks","issue_events_url":"https://api.github.com/repos/craigspaeth/positron/issues/events{/number}","events_url":"https://api.github.com/repos/craigspaeth/positron/events","assignees_url":"https://api.github.com/repos/craigspaeth/positron/assignees{/user}","branches_url":"https://api.github.com/repos/craigspaeth/positron/branches{/branch}","tags_url":"https://api.github.com/repos/craigspaeth/positron/tags","blobs_url":"https://api.github.com/repos/craigspaeth/positron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craigspaeth/positron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craigspaeth/positron/git/refs{/sha}","trees_url":"https://api.github.com/repos/craigspaeth/positron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craigspaeth/positron/statuses/{sha}","languages_url":"https://api.github.com/repos/craigspaeth/positron/languages","stargazers_url":"https://api.github.com/repos/craigspaeth/positron/stargazers","contributors_url":"https://api.github.com/repos/craigspaeth/positron/contributors","subscribers_url":"https://api.github.com/repos/craigspaeth/positron/subscribers","subscription_url":"https://api.github.com/repos/craigspaeth/positron/subscription","commits_url":"https://api.github.com/repos/craigspaeth/positron/commits{/sha}","git_commits_url":"https://api.github.com/repos/craigspaeth/positron/git/commits{/sha}","comments_url":"https://api.github.com/repos/craigspaeth/positron/comments{/number}","issue_comment_url":"https://api.github.com/repos/craigspaeth/positron/issues/comments/{number}","contents_url":"https://api.github.com/repos/craigspaeth/positron/contents/{+path}","compare_url":"https://api.github.com/repos/craigspaeth/positron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craigspaeth/positron/merges","archive_url":"https://api.github.com/repos/craigspaeth/positron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craigspaeth/positron/downloads","issues_url":"https://api.github.com/repos/craigspaeth/positron/issues{/number}","pulls_url":"https://api.github.com/repos/craigspaeth/positron/pulls{/number}","milestones_url":"https://api.github.com/repos/craigspaeth/positron/milestones{/number}","notifications_url":"https://api.github.com/repos/craigspaeth/positron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craigspaeth/positron/labels{/name}","releases_url":"https://api.github.com/repos/craigspaeth/positron/releases{/id}","created_at":"2014-09-08T22:43:13Z","updated_at":"2014-09-08T22:44:31Z","pushed_at":"2014-09-17T21:04:36Z","git_url":"git://github.com/craigspaeth/positron.git","ssh_url":"git@github.com:craigspaeth/positron.git","clone_url":"https://github.com/craigspaeth/positron.git","svn_url":"https://github.com/craigspaeth/positron","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"7dc47ca129e82f9144de83370f35f3ea3e0f03db","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=2","gravatar_id":"b220e837a1f803e7e25a06cc8f551251","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":23808195,"name":"positron","full_name":"artsy/positron","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=2","gravatar_id":"b220e837a1f803e7e25a06cc8f551251","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/positron","description":"Otherwise known as Artsy Writer. The back-end posting tool for publishing articles on Artsy.","fork":false,"url":"https://api.github.com/repos/artsy/positron","forks_url":"https://api.github.com/repos/artsy/positron/forks","keys_url":"https://api.github.com/repos/artsy/positron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/positron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/positron/teams","hooks_url":"https://api.github.com/repos/artsy/positron/hooks","issue_events_url":"https://api.github.com/repos/artsy/positron/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/positron/events","assignees_url":"https://api.github.com/repos/artsy/positron/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/positron/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/positron/tags","blobs_url":"https://api.github.com/repos/artsy/positron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/positron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/positron/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/positron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/positron/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/positron/languages","stargazers_url":"https://api.github.com/repos/artsy/positron/stargazers","contributors_url":"https://api.github.com/repos/artsy/positron/contributors","subscribers_url":"https://api.github.com/repos/artsy/positron/subscribers","subscription_url":"https://api.github.com/repos/artsy/positron/subscription","commits_url":"https://api.github.com/repos/artsy/positron/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/positron/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/positron/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/positron/issues/comments/{number}","contents_url":"https://api.github.com/repos/artsy/positron/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/positron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/positron/merges","archive_url":"https://api.github.com/repos/artsy/positron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/positron/downloads","issues_url":"https://api.github.com/repos/artsy/positron/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/positron/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/positron/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/positron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/positron/labels{/name}","releases_url":"https://api.github.com/repos/artsy/positron/releases{/id}","created_at":"2014-09-08T21:02:13Z","updated_at":"2014-09-17T18:24:41Z","pushed_at":"2014-09-18T15:10:16Z","git_url":"git://github.com/artsy/positron.git","ssh_url":"git@github.com:artsy/positron.git","clone_url":"https://github.com/artsy/positron.git","svn_url":"https://github.com/artsy/positron","homepage":"","size":117,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/positron/pulls/3"},"html":{"href":"https://github.com/artsy/positron/pull/3"},"issue":{"href":"https://api.github.com/repos/artsy/positron/issues/3"},"comments":{"href":"https://api.github.com/repos/artsy/positron/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/positron/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/positron/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/artsy/positron/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/positron/statuses/41cc2222bf1fb810455fc6306517903874e57034"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dzucconi","id":112297,"avatar_url":"https://avatars.githubusercontent.com/u/112297?v=2","gravatar_id":"5be8b67566d1a252f64b7bba3b021258","url":"https://api.github.com/users/dzucconi","html_url":"https://github.com/dzucconi","followers_url":"https://api.github.com/users/dzucconi/followers","following_url":"https://api.github.com/users/dzucconi/following{/other_user}","gists_url":"https://api.github.com/users/dzucconi/gists{/gist_id}","starred_url":"https://api.github.com/users/dzucconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzucconi/subscriptions","organizations_url":"https://api.github.com/users/dzucconi/orgs","repos_url":"https://api.github.com/users/dzucconi/repos","events_url":"https://api.github.com/users/dzucconi/events{/privacy}","received_events_url":"https://api.github.com/users/dzucconi/received_events","type":"User","site_admin":false},"comments":3,"review_comments":11,"commits":1,"additions":299,"deletions":52,"changed_files":24}}