GitHub PullRequestReviewCommentEvent at 2014-09-26 06:38:48
Repository: txircd
Actor: Heufneutje
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/comments/18075536","id":18075536,"diff_hunk":"@@ -1,2 +1,409 @@\n-# This will become the default config file\n-# For now, it is blank\n+\n+# This is an example config file with most optional features enabled by default.\n+# You should review this file and comment out or tweak what you want.\n+\n+\n+# BASICS: These keys are required. It is highly reccomended you change them.\n+\n+# server_name: string  - The name this server should go by.\n+# server_description: string  - A short sentence describing this server.\n+# network_name: string  - The name of the irc network to connect to. This must match other servers. Max 32 chars.\n+server_name: \"test\"\n+server_description: \"An example config\"\n+network_name: \"test_net\"\n+\n+# bind_client: list of strings\n+# The bind_client key specifies what network sockets to listen on.\n+# Each string in the list describes a \"transport endpoint\".\n+# A quick guide:\n+#    \"tcp:port=PORT\"\n+#        Listen on an IPv4 TCP socket on the given port. Example: \"tcp:port=6667\"\n+#    \"tcp:port=PORT:interface=IP\"\n+#        As above, but only bind to one network interface,\n+#        eg. loopback for a local-only connection. Example: \"tcp:port=6667:interface=127.0.0.1\"\n+#    \"tcp6:port=PORT:interface=IP\"\n+#        As per tcp, but uses an IPv6 socket instead. Note that IP (if interface is given)\n+#        must be an IPv6 address, and : characters must be escaped with a backslash.\n+#        Example: \"tcp6:port=6667:interface=\\:\\:1\"\n+#    \"ssl:port=PORT:interface=IP:certKey=PATH:privateKey=PATH:sslmethod:METHOD\"\n+#        Port and interface options are as per tcp. privateKey should point to a PEM file containing your\n+#        server's private key. If this same file contains your certificate, certKey may be omitted.\n+#        sslmethod must contain SSLv3_METHOD, SSLv23_METHOD, or TLSv1_METHOD. TLSv1_METHOD is reccomended.\n+#        Example: \"ssl:port=443:privateKey=/path/to/file.pem:sslmethod=TLSv1_METHOD\"\n+# This default value will bind to port 6667 on loopback only (for safety). It does not enable SSL.\n+# Remove the interface clause to bind to all interfaces.\n+bind_client:\n+    - \"tcp:port=6667:interface=127.0.0.1\"\n+    - \"tcp6:port=6667:interface=\\:\\:1\"\n+\n+# bind_server: As per bind_client, but specifies listen sockets for server to server connections,\n+# instead of incoming users.\n+# The default is not to allow incoming server to server connections.\n+bind_server: []\n+\n+# modules: list of strings","path":"txircd-example.yaml","position":46,"original_position":46,"commit_id":"ddcdab0a28dc810ed543e21af0292539e92836c7","original_commit_id":"ddcdab0a28dc810ed543e21af0292539e92836c7","user":{"login":"Heufneutje","id":1357231,"avatar_url":"https://avatars.githubusercontent.com/u/1357231?v=2","gravatar_id":"","url":"https://api.github.com/users/Heufneutje","html_url":"https://github.com/Heufneutje","followers_url":"https://api.github.com/users/Heufneutje/followers","following_url":"https://api.github.com/users/Heufneutje/following{/other_user}","gists_url":"https://api.github.com/users/Heufneutje/gists{/gist_id}","starred_url":"https://api.github.com/users/Heufneutje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heufneutje/subscriptions","organizations_url":"https://api.github.com/users/Heufneutje/orgs","repos_url":"https://api.github.com/users/Heufneutje/repos","events_url":"https://api.github.com/users/Heufneutje/events{/privacy}","received_events_url":"https://api.github.com/users/Heufneutje/received_events","type":"User","site_admin":false},"body":"I agree that a short summary is good, but I do think we should include \"implements the XXXXXX command\" or \"implements user/channel mode +x\" in there along with the short summary.","created_at":"2014-09-26T06:38:48Z","updated_at":"2014-09-26T06:38:48Z","html_url":"https://github.com/ElementalAlchemist/txircd/pull/78#discussion_r18075536","pull_request_url":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/comments/18075536"},"html":{"href":"https://github.com/ElementalAlchemist/txircd/pull/78#discussion_r18075536"},"pull_request":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/78","id":21827061,"html_url":"https://github.com/ElementalAlchemist/txircd/pull/78","diff_url":"https://github.com/ElementalAlchemist/txircd/pull/78.diff","patch_url":"https://github.com/ElementalAlchemist/txircd/pull/78.patch","issue_url":"https://api.github.com/repos/ElementalAlchemist/txircd/issues/78","number":78,"state":"open","locked":false,"title":"Write the example config, including every current config option for every module","user":{"login":"ekimekim","id":570052,"avatar_url":"https://avatars.githubusercontent.com/u/570052?v=2","gravatar_id":"","url":"https://api.github.com/users/ekimekim","html_url":"https://github.com/ekimekim","followers_url":"https://api.github.com/users/ekimekim/followers","following_url":"https://api.github.com/users/ekimekim/following{/other_user}","gists_url":"https://api.github.com/users/ekimekim/gists{/gist_id}","starred_url":"https://api.github.com/users/ekimekim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekimekim/subscriptions","organizations_url":"https://api.github.com/users/ekimekim/orgs","repos_url":"https://api.github.com/users/ekimekim/repos","events_url":"https://api.github.com/users/ekimekim/events{/privacy}","received_events_url":"https://api.github.com/users/ekimekim/received_events","type":"User","site_admin":false},"body":"We will need to keep this file up to date every time we add a config option or change a default.\r\n\r\nI wrote this specifically because Ashton wanted to play around with the server but there was no docs on the config options.","created_at":"2014-09-26T03:41:40Z","updated_at":"2014-09-26T06:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecccab5b7a6979fafb3b6ee4a7f1097ad82e199b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/78/commits","review_comments_url":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/78/comments","review_comment_url":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ElementalAlchemist/txircd/issues/78/comments","statuses_url":"https://api.github.com/repos/ElementalAlchemist/txircd/statuses/ddcdab0a28dc810ed543e21af0292539e92836c7","head":{"label":"ekimekim:example-config","ref":"example-config","sha":"ddcdab0a28dc810ed543e21af0292539e92836c7","user":{"login":"ekimekim","id":570052,"avatar_url":"https://avatars.githubusercontent.com/u/570052?v=2","gravatar_id":"","url":"https://api.github.com/users/ekimekim","html_url":"https://github.com/ekimekim","followers_url":"https://api.github.com/users/ekimekim/followers","following_url":"https://api.github.com/users/ekimekim/following{/other_user}","gists_url":"https://api.github.com/users/ekimekim/gists{/gist_id}","starred_url":"https://api.github.com/users/ekimekim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekimekim/subscriptions","organizations_url":"https://api.github.com/users/ekimekim/orgs","repos_url":"https://api.github.com/users/ekimekim/repos","events_url":"https://api.github.com/users/ekimekim/events{/privacy}","received_events_url":"https://api.github.com/users/ekimekim/received_events","type":"User","site_admin":false},"repo":{"id":22979592,"name":"txircd","full_name":"ekimekim/txircd","owner":{"login":"ekimekim","id":570052,"avatar_url":"https://avatars.githubusercontent.com/u/570052?v=2","gravatar_id":"","url":"https://api.github.com/users/ekimekim","html_url":"https://github.com/ekimekim","followers_url":"https://api.github.com/users/ekimekim/followers","following_url":"https://api.github.com/users/ekimekim/following{/other_user}","gists_url":"https://api.github.com/users/ekimekim/gists{/gist_id}","starred_url":"https://api.github.com/users/ekimekim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekimekim/subscriptions","organizations_url":"https://api.github.com/users/ekimekim/orgs","repos_url":"https://api.github.com/users/ekimekim/repos","events_url":"https://api.github.com/users/ekimekim/events{/privacy}","received_events_url":"https://api.github.com/users/ekimekim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekimekim/txircd","description":"Twisted IRC Daemon","fork":true,"url":"https://api.github.com/repos/ekimekim/txircd","forks_url":"https://api.github.com/repos/ekimekim/txircd/forks","keys_url":"https://api.github.com/repos/ekimekim/txircd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekimekim/txircd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekimekim/txircd/teams","hooks_url":"https://api.github.com/repos/ekimekim/txircd/hooks","issue_events_url":"https://api.github.com/repos/ekimekim/txircd/issues/events{/number}","events_url":"https://api.github.com/repos/ekimekim/txircd/events","assignees_url":"https://api.github.com/repos/ekimekim/txircd/assignees{/user}","branches_url":"https://api.github.com/repos/ekimekim/txircd/branches{/branch}","tags_url":"https://api.github.com/repos/ekimekim/txircd/tags","blobs_url":"https://api.github.com/repos/ekimekim/txircd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekimekim/txircd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekimekim/txircd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekimekim/txircd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekimekim/txircd/statuses/{sha}","languages_url":"https://api.github.com/repos/ekimekim/txircd/languages","stargazers_url":"https://api.github.com/repos/ekimekim/txircd/stargazers","contributors_url":"https://api.github.com/repos/ekimekim/txircd/contributors","subscribers_url":"https://api.github.com/repos/ekimekim/txircd/subscribers","subscription_url":"https://api.github.com/repos/ekimekim/txircd/subscription","commits_url":"https://api.github.com/repos/ekimekim/txircd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekimekim/txircd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekimekim/txircd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekimekim/txircd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ekimekim/txircd/contents/{+path}","compare_url":"https://api.github.com/repos/ekimekim/txircd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekimekim/txircd/merges","archive_url":"https://api.github.com/repos/ekimekim/txircd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekimekim/txircd/downloads","issues_url":"https://api.github.com/repos/ekimekim/txircd/issues{/number}","pulls_url":"https://api.github.com/repos/ekimekim/txircd/pulls{/number}","milestones_url":"https://api.github.com/repos/ekimekim/txircd/milestones{/number}","notifications_url":"https://api.github.com/repos/ekimekim/txircd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekimekim/txircd/labels{/name}","releases_url":"https://api.github.com/repos/ekimekim/txircd/releases{/id}","created_at":"2014-08-15T05:31:48Z","updated_at":"2014-08-15T05:32:45Z","pushed_at":"2014-09-26T03:40:37Z","git_url":"git://github.com/ekimekim/txircd.git","ssh_url":"git@github.com:ekimekim/txircd.git","clone_url":"https://github.com/ekimekim/txircd.git","svn_url":"https://github.com/ekimekim/txircd","homepage":null,"size":3901,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev/0.3"}},"base":{"label":"ElementalAlchemist:dev/0.3","ref":"dev/0.3","sha":"29113a694d4eac743c481b82ef490549182b032b","user":{"login":"ElementalAlchemist","id":115662,"avatar_url":"https://avatars.githubusercontent.com/u/115662?v=2","gravatar_id":"","url":"https://api.github.com/users/ElementalAlchemist","html_url":"https://github.com/ElementalAlchemist","followers_url":"https://api.github.com/users/ElementalAlchemist/followers","following_url":"https://api.github.com/users/ElementalAlchemist/following{/other_user}","gists_url":"https://api.github.com/users/ElementalAlchemist/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementalAlchemist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementalAlchemist/subscriptions","organizations_url":"https://api.github.com/users/ElementalAlchemist/orgs","repos_url":"https://api.github.com/users/ElementalAlchemist/repos","events_url":"https://api.github.com/users/ElementalAlchemist/events{/privacy}","received_events_url":"https://api.github.com/users/ElementalAlchemist/received_events","type":"User","site_admin":false},"repo":{"id":6614056,"name":"txircd","full_name":"ElementalAlchemist/txircd","owner":{"login":"ElementalAlchemist","id":115662,"avatar_url":"https://avatars.githubusercontent.com/u/115662?v=2","gravatar_id":"","url":"https://api.github.com/users/ElementalAlchemist","html_url":"https://github.com/ElementalAlchemist","followers_url":"https://api.github.com/users/ElementalAlchemist/followers","following_url":"https://api.github.com/users/ElementalAlchemist/following{/other_user}","gists_url":"https://api.github.com/users/ElementalAlchemist/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementalAlchemist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementalAlchemist/subscriptions","organizations_url":"https://api.github.com/users/ElementalAlchemist/orgs","repos_url":"https://api.github.com/users/ElementalAlchemist/repos","events_url":"https://api.github.com/users/ElementalAlchemist/events{/privacy}","received_events_url":"https://api.github.com/users/ElementalAlchemist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ElementalAlchemist/txircd","description":"Twisted IRC Daemon","fork":true,"url":"https://api.github.com/repos/ElementalAlchemist/txircd","forks_url":"https://api.github.com/repos/ElementalAlchemist/txircd/forks","keys_url":"https://api.github.com/repos/ElementalAlchemist/txircd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElementalAlchemist/txircd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElementalAlchemist/txircd/teams","hooks_url":"https://api.github.com/repos/ElementalAlchemist/txircd/hooks","issue_events_url":"https://api.github.com/repos/ElementalAlchemist/txircd/issues/events{/number}","events_url":"https://api.github.com/repos/ElementalAlchemist/txircd/events","assignees_url":"https://api.github.com/repos/ElementalAlchemist/txircd/assignees{/user}","branches_url":"https://api.github.com/repos/ElementalAlchemist/txircd/branches{/branch}","tags_url":"https://api.github.com/repos/ElementalAlchemist/txircd/tags","blobs_url":"https://api.github.com/repos/ElementalAlchemist/txircd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElementalAlchemist/txircd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElementalAlchemist/txircd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElementalAlchemist/txircd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElementalAlchemist/txircd/statuses/{sha}","languages_url":"https://api.github.com/repos/ElementalAlchemist/txircd/languages","stargazers_url":"https://api.github.com/repos/ElementalAlchemist/txircd/stargazers","contributors_url":"https://api.github.com/repos/ElementalAlchemist/txircd/contributors","subscribers_url":"https://api.github.com/repos/ElementalAlchemist/txircd/subscribers","subscription_url":"https://api.github.com/repos/ElementalAlchemist/txircd/subscription","commits_url":"https://api.github.com/repos/ElementalAlchemist/txircd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElementalAlchemist/txircd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElementalAlchemist/txircd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElementalAlchemist/txircd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ElementalAlchemist/txircd/contents/{+path}","compare_url":"https://api.github.com/repos/ElementalAlchemist/txircd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElementalAlchemist/txircd/merges","archive_url":"https://api.github.com/repos/ElementalAlchemist/txircd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElementalAlchemist/txircd/downloads","issues_url":"https://api.github.com/repos/ElementalAlchemist/txircd/issues{/number}","pulls_url":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls{/number}","milestones_url":"https://api.github.com/repos/ElementalAlchemist/txircd/milestones{/number}","notifications_url":"https://api.github.com/repos/ElementalAlchemist/txircd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElementalAlchemist/txircd/labels{/name}","releases_url":"https://api.github.com/repos/ElementalAlchemist/txircd/releases{/id}","created_at":"2012-11-09T13:49:39Z","updated_at":"2014-08-20T05:10:24Z","pushed_at":"2014-09-25T13:25:26Z","git_url":"git://github.com/ElementalAlchemist/txircd.git","ssh_url":"git@github.com:ElementalAlchemist/txircd.git","clone_url":"https://github.com/ElementalAlchemist/txircd.git","svn_url":"https://github.com/ElementalAlchemist/txircd","homepage":null,"size":8547,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":3,"default_branch":"dev/0.3"}},"_links":{"self":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/78"},"html":{"href":"https://github.com/ElementalAlchemist/txircd/pull/78"},"issue":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/issues/78"},"comments":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/ElementalAlchemist/txircd/statuses/ddcdab0a28dc810ed543e21af0292539e92836c7"}}}}