GitHub PullRequestReviewCommentEvent at 2014-08-21 04:35:15
Repository: padrino-framework
Actor: ujifgc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/padrino/padrino-framework/pulls/comments/16520137","id":16520137,"diff_hunk":"@@ -223,6 +223,7 @@ def files_for_rotation\n       files = Set.new\n       files += Dir.glob(\"#{Padrino.root}/{lib,models,shared}/**/*.rb\")\n       reloadable_apps.each do |app|\n+        next unless app.app_file.start_with?(Padrino.root)","path":"padrino-core/lib/padrino-core/reloader.rb","position":4,"original_position":4,"commit_id":"80277da1d85c922316e26f4c0a88f856fa36a9d7","original_commit_id":"80277da1d85c922316e26f4c0a88f856fa36a9d7","user":{"login":"ujifgc","id":108798,"avatar_url":"https://avatars.githubusercontent.com/u/108798?v=2","gravatar_id":"14413f74e824380e57acdb63a7f446e4","url":"https://api.github.com/users/ujifgc","html_url":"https://github.com/ujifgc","followers_url":"https://api.github.com/users/ujifgc/followers","following_url":"https://api.github.com/users/ujifgc/following{/other_user}","gists_url":"https://api.github.com/users/ujifgc/gists{/gist_id}","starred_url":"https://api.github.com/users/ujifgc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ujifgc/subscriptions","organizations_url":"https://api.github.com/users/ujifgc/orgs","repos_url":"https://api.github.com/users/ujifgc/repos","events_url":"https://api.github.com/users/ujifgc/events{/privacy}","received_events_url":"https://api.github.com/users/ujifgc/received_events","type":"User","site_admin":false},"body":"Do you think this could work if this condition is inside `#reloadable_apps`?","created_at":"2014-08-21T04:35:15Z","updated_at":"2014-08-21T04:35:15Z","html_url":"https://github.com/padrino/padrino-framework/pull/1747#discussion_r16520137","pull_request_url":"https://api.github.com/repos/padrino/padrino-framework/pulls/1747","_links":{"self":{"href":"https://api.github.com/repos/padrino/padrino-framework/pulls/comments/16520137"},"html":{"href":"https://github.com/padrino/padrino-framework/pull/1747#discussion_r16520137"},"pull_request":{"href":"https://api.github.com/repos/padrino/padrino-framework/pulls/1747"}}},"pull_request":{"url":"https://api.github.com/repos/padrino/padrino-framework/pulls/1747","id":20086327,"html_url":"https://github.com/padrino/padrino-framework/pull/1747","diff_url":"https://github.com/padrino/padrino-framework/pull/1747.diff","patch_url":"https://github.com/padrino/padrino-framework/pull/1747.patch","issue_url":"https://api.github.com/repos/padrino/padrino-framework/issues/1747","number":1747,"state":"open","locked":false,"title":"Avoid reloading the file if its path is not started with Padrino.root, fixes #1746","user":{"login":"namusyaka","id":309329,"avatar_url":"https://avatars.githubusercontent.com/u/309329?v=2","gravatar_id":"0d1cf45095971fe360ce275c65ecec4c","url":"https://api.github.com/users/namusyaka","html_url":"https://github.com/namusyaka","followers_url":"https://api.github.com/users/namusyaka/followers","following_url":"https://api.github.com/users/namusyaka/following{/other_user}","gists_url":"https://api.github.com/users/namusyaka/gists{/gist_id}","starred_url":"https://api.github.com/users/namusyaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namusyaka/subscriptions","organizations_url":"https://api.github.com/users/namusyaka/orgs","repos_url":"https://api.github.com/users/namusyaka/repos","events_url":"https://api.github.com/users/namusyaka/events{/privacy}","received_events_url":"https://api.github.com/users/namusyaka/received_events","type":"User","site_admin":false},"body":"ref #1746 \r\nThis fixes that bug.","created_at":"2014-08-21T02:17:54Z","updated_at":"2014-08-21T04:35:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7886cf8417ccb71d3b8d9a882c23e649d12fe621","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/padrino/padrino-framework/pulls/1747/commits","review_comments_url":"https://api.github.com/repos/padrino/padrino-framework/pulls/1747/comments","review_comment_url":"https://api.github.com/repos/padrino/padrino-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/padrino/padrino-framework/issues/1747/comments","statuses_url":"https://api.github.com/repos/padrino/padrino-framework/statuses/80277da1d85c922316e26f4c0a88f856fa36a9d7","head":{"label":"padrino:fix-reloader","ref":"fix-reloader","sha":"80277da1d85c922316e26f4c0a88f856fa36a9d7","user":{"login":"padrino","id":153006,"avatar_url":"https://avatars.githubusercontent.com/u/153006?v=2","gravatar_id":"9e5ca20ceab16f80e57bf6f99fd3ecc5","url":"https://api.github.com/users/padrino","html_url":"https://github.com/padrino","followers_url":"https://api.github.com/users/padrino/followers","following_url":"https://api.github.com/users/padrino/following{/other_user}","gists_url":"https://api.github.com/users/padrino/gists{/gist_id}","starred_url":"https://api.github.com/users/padrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padrino/subscriptions","organizations_url":"https://api.github.com/users/padrino/orgs","repos_url":"https://api.github.com/users/padrino/repos","events_url":"https://api.github.com/users/padrino/events{/privacy}","received_events_url":"https://api.github.com/users/padrino/received_events","type":"Organization","site_admin":false},"repo":{"id":376635,"name":"padrino-framework","full_name":"padrino/padrino-framework","owner":{"login":"padrino","id":153006,"avatar_url":"https://avatars.githubusercontent.com/u/153006?v=2","gravatar_id":"9e5ca20ceab16f80e57bf6f99fd3ecc5","url":"https://api.github.com/users/padrino","html_url":"https://github.com/padrino","followers_url":"https://api.github.com/users/padrino/followers","following_url":"https://api.github.com/users/padrino/following{/other_user}","gists_url":"https://api.github.com/users/padrino/gists{/gist_id}","starred_url":"https://api.github.com/users/padrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padrino/subscriptions","organizations_url":"https://api.github.com/users/padrino/orgs","repos_url":"https://api.github.com/users/padrino/repos","events_url":"https://api.github.com/users/padrino/events{/privacy}","received_events_url":"https://api.github.com/users/padrino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/padrino/padrino-framework","description":"Padrino is a full-stack ruby framework built upon Sinatra. ","fork":false,"url":"https://api.github.com/repos/padrino/padrino-framework","forks_url":"https://api.github.com/repos/padrino/padrino-framework/forks","keys_url":"https://api.github.com/repos/padrino/padrino-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/padrino/padrino-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/padrino/padrino-framework/teams","hooks_url":"https://api.github.com/repos/padrino/padrino-framework/hooks","issue_events_url":"https://api.github.com/repos/padrino/padrino-framework/issues/events{/number}","events_url":"https://api.github.com/repos/padrino/padrino-framework/events","assignees_url":"https://api.github.com/repos/padrino/padrino-framework/assignees{/user}","branches_url":"https://api.github.com/repos/padrino/padrino-framework/branches{/branch}","tags_url":"https://api.github.com/repos/padrino/padrino-framework/tags","blobs_url":"https://api.github.com/repos/padrino/padrino-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/padrino/padrino-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/padrino/padrino-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/padrino/padrino-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/padrino/padrino-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/padrino/padrino-framework/languages","stargazers_url":"https://api.github.com/repos/padrino/padrino-framework/stargazers","contributors_url":"https://api.github.com/repos/padrino/padrino-framework/contributors","subscribers_url":"https://api.github.com/repos/padrino/padrino-framework/subscribers","subscription_url":"https://api.github.com/repos/padrino/padrino-framework/subscription","commits_url":"https://api.github.com/repos/padrino/padrino-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/padrino/padrino-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/padrino/padrino-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/padrino/padrino-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/padrino/padrino-framework/contents/{+path}","compare_url":"https://api.github.com/repos/padrino/padrino-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/padrino/padrino-framework/merges","archive_url":"https://api.github.com/repos/padrino/padrino-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/padrino/padrino-framework/downloads","issues_url":"https://api.github.com/repos/padrino/padrino-framework/issues{/number}","pulls_url":"https://api.github.com/repos/padrino/padrino-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/padrino/padrino-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/padrino/padrino-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/padrino/padrino-framework/labels{/name}","releases_url":"https://api.github.com/repos/padrino/padrino-framework/releases{/id}","created_at":"2009-11-18T00:33:56Z","updated_at":"2014-08-20T17:43:47Z","pushed_at":"2014-08-21T02:16:42Z","git_url":"git://github.com/padrino/padrino-framework.git","ssh_url":"git@github.com:padrino/padrino-framework.git","clone_url":"https://github.com/padrino/padrino-framework.git","svn_url":"https://github.com/padrino/padrino-framework","homepage":"http://www.padrinorb.com","size":23178,"stargazers_count":2256,"watchers_count":2256,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":397,"mirror_url":null,"open_issues_count":35,"forks":397,"open_issues":35,"watchers":2256,"default_branch":"master"}},"base":{"label":"padrino:master","ref":"master","sha":"14869a9cc28f80f0a95a4cf0ae145e8d31549cc9","user":{"login":"padrino","id":153006,"avatar_url":"https://avatars.githubusercontent.com/u/153006?v=2","gravatar_id":"9e5ca20ceab16f80e57bf6f99fd3ecc5","url":"https://api.github.com/users/padrino","html_url":"https://github.com/padrino","followers_url":"https://api.github.com/users/padrino/followers","following_url":"https://api.github.com/users/padrino/following{/other_user}","gists_url":"https://api.github.com/users/padrino/gists{/gist_id}","starred_url":"https://api.github.com/users/padrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padrino/subscriptions","organizations_url":"https://api.github.com/users/padrino/orgs","repos_url":"https://api.github.com/users/padrino/repos","events_url":"https://api.github.com/users/padrino/events{/privacy}","received_events_url":"https://api.github.com/users/padrino/received_events","type":"Organization","site_admin":false},"repo":{"id":376635,"name":"padrino-framework","full_name":"padrino/padrino-framework","owner":{"login":"padrino","id":153006,"avatar_url":"https://avatars.githubusercontent.com/u/153006?v=2","gravatar_id":"9e5ca20ceab16f80e57bf6f99fd3ecc5","url":"https://api.github.com/users/padrino","html_url":"https://github.com/padrino","followers_url":"https://api.github.com/users/padrino/followers","following_url":"https://api.github.com/users/padrino/following{/other_user}","gists_url":"https://api.github.com/users/padrino/gists{/gist_id}","starred_url":"https://api.github.com/users/padrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padrino/subscriptions","organizations_url":"https://api.github.com/users/padrino/orgs","repos_url":"https://api.github.com/users/padrino/repos","events_url":"https://api.github.com/users/padrino/events{/privacy}","received_events_url":"https://api.github.com/users/padrino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/padrino/padrino-framework","description":"Padrino is a full-stack ruby framework built upon Sinatra. ","fork":false,"url":"https://api.github.com/repos/padrino/padrino-framework","forks_url":"https://api.github.com/repos/padrino/padrino-framework/forks","keys_url":"https://api.github.com/repos/padrino/padrino-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/padrino/padrino-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/padrino/padrino-framework/teams","hooks_url":"https://api.github.com/repos/padrino/padrino-framework/hooks","issue_events_url":"https://api.github.com/repos/padrino/padrino-framework/issues/events{/number}","events_url":"https://api.github.com/repos/padrino/padrino-framework/events","assignees_url":"https://api.github.com/repos/padrino/padrino-framework/assignees{/user}","branches_url":"https://api.github.com/repos/padrino/padrino-framework/branches{/branch}","tags_url":"https://api.github.com/repos/padrino/padrino-framework/tags","blobs_url":"https://api.github.com/repos/padrino/padrino-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/padrino/padrino-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/padrino/padrino-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/padrino/padrino-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/padrino/padrino-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/padrino/padrino-framework/languages","stargazers_url":"https://api.github.com/repos/padrino/padrino-framework/stargazers","contributors_url":"https://api.github.com/repos/padrino/padrino-framework/contributors","subscribers_url":"https://api.github.com/repos/padrino/padrino-framework/subscribers","subscription_url":"https://api.github.com/repos/padrino/padrino-framework/subscription","commits_url":"https://api.github.com/repos/padrino/padrino-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/padrino/padrino-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/padrino/padrino-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/padrino/padrino-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/padrino/padrino-framework/contents/{+path}","compare_url":"https://api.github.com/repos/padrino/padrino-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/padrino/padrino-framework/merges","archive_url":"https://api.github.com/repos/padrino/padrino-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/padrino/padrino-framework/downloads","issues_url":"https://api.github.com/repos/padrino/padrino-framework/issues{/number}","pulls_url":"https://api.github.com/repos/padrino/padrino-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/padrino/padrino-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/padrino/padrino-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/padrino/padrino-framework/labels{/name}","releases_url":"https://api.github.com/repos/padrino/padrino-framework/releases{/id}","created_at":"2009-11-18T00:33:56Z","updated_at":"2014-08-20T17:43:47Z","pushed_at":"2014-08-21T02:16:42Z","git_url":"git://github.com/padrino/padrino-framework.git","ssh_url":"git@github.com:padrino/padrino-framework.git","clone_url":"https://github.com/padrino/padrino-framework.git","svn_url":"https://github.com/padrino/padrino-framework","homepage":"http://www.padrinorb.com","size":23178,"stargazers_count":2256,"watchers_count":2256,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":397,"mirror_url":null,"open_issues_count":35,"forks":397,"open_issues":35,"watchers":2256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/padrino/padrino-framework/pulls/1747"},"html":{"href":"https://github.com/padrino/padrino-framework/pull/1747"},"issue":{"href":"https://api.github.com/repos/padrino/padrino-framework/issues/1747"},"comments":{"href":"https://api.github.com/repos/padrino/padrino-framework/issues/1747/comments"},"review_comments":{"href":"https://api.github.com/repos/padrino/padrino-framework/pulls/1747/comments"},"review_comment":{"href":"https://api.github.com/repos/padrino/padrino-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/padrino/padrino-framework/pulls/1747/commits"},"statuses":{"href":"https://api.github.com/repos/padrino/padrino-framework/statuses/80277da1d85c922316e26f4c0a88f856fa36a9d7"}}}}