GitHub PullRequestReviewCommentEvent at 2014-07-21 11:13:41
Repository: fh-js-sdk
Actor: jasonmadigan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/comments/15163306","id":15163306,"diff_hunk":"@@ -60,14 +60,35 @@ FieldFileView = FieldView.extend({\n             button_remove.show();\n         }\n \n-        button.off(\"click\");\n-        button.on(\"click\", function() {\n-            var index = $(this).data().index;\n-            fileEle.click();\n-        });\n+        if (this.readonly) {\n+            button_remove.hide();\n+        }\n+\n+        //Some operating systems do not support opening a file select browser\n+        //http://viljamis.com/blog/2012/file-upload-support-on-mobile/\n+        if (navigator.userAgent.match(/(Android (1.0|1.1|1.5|1.6|2.0|2.1))|(Windows Phone (OS 7|8.0))|(XBLWP)|(ZuneWP)|(w(eb)?OSBrowser)|(webOS)|(Kindle\\/(1.0|2.0|2.5|3.0))/)) {\n+            //If not supported, show a warning on-device. There is also a warning in the studio when creating the form.\n+           $(button).text(\"File upload not supported\");\n+           $(button).attr(\"disabled\", true);\n+           button.off(\"click\");\n+         }\n+\n+        \n+        // button.on(\"click\", function() {\n+        //     var index = $(this).data().index;\n+        //     console.log(\"FILE Button Click\", index);\n+        //     var wrapper = self.getWrapper(index);\n+        //     wrapper = $(wrapper);\n+        //     var fileEle = wrapper.find(\".fh_appform_field_input\");\n+\n+        //     console.log(\"File ELE \", fileEle);\n+\n+        //     $(fileEle).trigger('click');\n+        // }); \n \n         button_remove.off(\"click\");\n         button_remove.on(\"click\", function() {\n+            console.log(\"button_remove Click\");","path":"src/appforms/src/backbone/040-view02field10field_file.js","position":64,"original_position":64,"commit_id":"4ef9466ccd2df9f960ff3f149910dcd453f92f19","original_commit_id":"4ef9466ccd2df9f960ff3f149910dcd453f92f19","user":{"login":"jasonmadigan","id":4467,"avatar_url":"https://avatars.githubusercontent.com/u/4467?","gravatar_id":"2a22f6fe7725ea219af8242e7bc2dbd6","url":"https://api.github.com/users/jasonmadigan","html_url":"https://github.com/jasonmadigan","followers_url":"https://api.github.com/users/jasonmadigan/followers","following_url":"https://api.github.com/users/jasonmadigan/following{/other_user}","gists_url":"https://api.github.com/users/jasonmadigan/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmadigan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmadigan/subscriptions","organizations_url":"https://api.github.com/users/jasonmadigan/orgs","repos_url":"https://api.github.com/users/jasonmadigan/repos","events_url":"https://api.github.com/users/jasonmadigan/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmadigan/received_events","type":"User","site_admin":false},"body":"may want to remove","created_at":"2014-07-21T11:13:41Z","updated_at":"2014-07-21T11:13:41Z","html_url":"https://github.com/feedhenry/fh-js-sdk/pull/95#discussion_r15163306","pull_request_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/comments/15163306"},"html":{"href":"https://github.com/feedhenry/fh-js-sdk/pull/95#discussion_r15163306"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/95","id":18586369,"html_url":"https://github.com/feedhenry/fh-js-sdk/pull/95","diff_url":"https://github.com/feedhenry/fh-js-sdk/pull/95.diff","patch_url":"https://github.com/feedhenry/fh-js-sdk/pull/95.patch","issue_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/95","number":95,"state":"open","title":"7414 add bootstrap to forms template app","user":{"login":"nialldonnellyfh","id":5014661,"avatar_url":"https://avatars.githubusercontent.com/u/5014661?","gravatar_id":"378040a048549a8be444b8bb4819d4c7","url":"https://api.github.com/users/nialldonnellyfh","html_url":"https://github.com/nialldonnellyfh","followers_url":"https://api.github.com/users/nialldonnellyfh/followers","following_url":"https://api.github.com/users/nialldonnellyfh/following{/other_user}","gists_url":"https://api.github.com/users/nialldonnellyfh/gists{/gist_id}","starred_url":"https://api.github.com/users/nialldonnellyfh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nialldonnellyfh/subscriptions","organizations_url":"https://api.github.com/users/nialldonnellyfh/orgs","repos_url":"https://api.github.com/users/nialldonnellyfh/repos","events_url":"https://api.github.com/users/nialldonnellyfh/events{/privacy}","received_events_url":"https://api.github.com/users/nialldonnellyfh/received_events","type":"User","site_admin":false},"body":"Refactor of the forms rendering logic to use bootstrap 3 styling.\r\n\r\nTo be included in the new template app, fh-ngui and fh-studio.","created_at":"2014-07-18T13:48:16Z","updated_at":"2014-07-21T11:13:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1afab357ac16afc0d2275dc28be973abd50d6d09","assignee":{"login":"jasonmadigan","id":4467,"avatar_url":"https://avatars.githubusercontent.com/u/4467?","gravatar_id":"2a22f6fe7725ea219af8242e7bc2dbd6","url":"https://api.github.com/users/jasonmadigan","html_url":"https://github.com/jasonmadigan","followers_url":"https://api.github.com/users/jasonmadigan/followers","following_url":"https://api.github.com/users/jasonmadigan/following{/other_user}","gists_url":"https://api.github.com/users/jasonmadigan/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmadigan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmadigan/subscriptions","organizations_url":"https://api.github.com/users/jasonmadigan/orgs","repos_url":"https://api.github.com/users/jasonmadigan/repos","events_url":"https://api.github.com/users/jasonmadigan/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmadigan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/95/commits","review_comments_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/95/comments","review_comment_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/95/comments","statuses_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/statuses/4ef9466ccd2df9f960ff3f149910dcd453f92f19","head":{"label":"feedhenry:7414_add_bootstrap_to_forms_template_app","ref":"7414_add_bootstrap_to_forms_template_app","sha":"4ef9466ccd2df9f960ff3f149910dcd453f92f19","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?","gravatar_id":"489aa0e677e77411c1f2241fb22c48a2","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":5498786,"name":"fh-js-sdk","full_name":"feedhenry/fh-js-sdk","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?","gravatar_id":"489aa0e677e77411c1f2241fb22c48a2","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/fh-js-sdk","description":"FeedHenry Javascript SDK","fork":false,"url":"https://api.github.com/repos/feedhenry/fh-js-sdk","forks_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/forks","keys_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/teams","hooks_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/events","assignees_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/tags","blobs_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/languages","stargazers_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/subscription","commits_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/merges","archive_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/downloads","issues_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/releases{/id}","created_at":"2012-08-21T18:03:39Z","updated_at":"2014-06-30T11:23:11Z","pushed_at":"2014-07-18T16:22:02Z","git_url":"git://github.com/feedhenry/fh-js-sdk.git","ssh_url":"git@github.com:feedhenry/fh-js-sdk.git","clone_url":"https://github.com/feedhenry/fh-js-sdk.git","svn_url":"https://github.com/feedhenry/fh-js-sdk","homepage":null,"size":22227,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"8d03150a8bc63c47841f959fd9ae89a29e79282b","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?","gravatar_id":"489aa0e677e77411c1f2241fb22c48a2","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":5498786,"name":"fh-js-sdk","full_name":"feedhenry/fh-js-sdk","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?","gravatar_id":"489aa0e677e77411c1f2241fb22c48a2","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/fh-js-sdk","description":"FeedHenry Javascript SDK","fork":false,"url":"https://api.github.com/repos/feedhenry/fh-js-sdk","forks_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/forks","keys_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/teams","hooks_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/events","assignees_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/tags","blobs_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/languages","stargazers_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/subscription","commits_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/merges","archive_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/downloads","issues_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/releases{/id}","created_at":"2012-08-21T18:03:39Z","updated_at":"2014-06-30T11:23:11Z","pushed_at":"2014-07-18T16:22:02Z","git_url":"git://github.com/feedhenry/fh-js-sdk.git","ssh_url":"git@github.com:feedhenry/fh-js-sdk.git","clone_url":"https://github.com/feedhenry/fh-js-sdk.git","svn_url":"https://github.com/feedhenry/fh-js-sdk","homepage":null,"size":22227,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/95"},"html":{"href":"https://github.com/feedhenry/fh-js-sdk/pull/95"},"issue":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/95"},"comments":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/statuses/4ef9466ccd2df9f960ff3f149910dcd453f92f19"}}}}