GitHub PullRequestReviewCommentEvent at 2014-07-15 23:51:11
Repository: naarad
Actor: RiteshMaheshwari
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/naarad/pulls/comments/14975038","id":14975038,"diff_hunk":"@@ -0,0 +1,64 @@\n+\"\"\"\n+API for Detector Module\n+\"\"\"\n+import settings\n+from algorithm import detector_algorithms\n+import utils\n+\n+class detector(object):","path":"lib/RCA/src/RCA/detector.py","position":8,"original_position":8,"commit_id":"7ca17bc19de612bd95cf7c900087a8a892a79947","original_commit_id":"7ca17bc19de612bd95cf7c900087a8a892a79947","user":{"login":"RiteshMaheshwari","id":2993448,"avatar_url":"https://avatars.githubusercontent.com/u/2993448?","gravatar_id":"3187e124e2828159192a19fea9dabc49","url":"https://api.github.com/users/RiteshMaheshwari","html_url":"https://github.com/RiteshMaheshwari","followers_url":"https://api.github.com/users/RiteshMaheshwari/followers","following_url":"https://api.github.com/users/RiteshMaheshwari/following{/other_user}","gists_url":"https://api.github.com/users/RiteshMaheshwari/gists{/gist_id}","starred_url":"https://api.github.com/users/RiteshMaheshwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RiteshMaheshwari/subscriptions","organizations_url":"https://api.github.com/users/RiteshMaheshwari/orgs","repos_url":"https://api.github.com/users/RiteshMaheshwari/repos","events_url":"https://api.github.com/users/RiteshMaheshwari/events{/privacy}","received_events_url":"https://api.github.com/users/RiteshMaheshwari/received_events","type":"User","site_admin":false},"body":"I suggest explicit name like \"anomaly_detector\" instead of just \"detector\". Same thing for the file name as well.","created_at":"2014-07-15T23:51:11Z","updated_at":"2014-07-15T23:51:11Z","html_url":"https://github.com/linkedin/naarad/pull/263#discussion_r14975038","pull_request_url":"https://api.github.com/repos/linkedin/naarad/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/comments/14975038"},"html":{"href":"https://github.com/linkedin/naarad/pull/263#discussion_r14975038"},"pull_request":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/naarad/pulls/263","id":18188534,"html_url":"https://github.com/linkedin/naarad/pull/263","diff_url":"https://github.com/linkedin/naarad/pull/263.diff","patch_url":"https://github.com/linkedin/naarad/pull/263.patch","issue_url":"https://api.github.com/repos/linkedin/naarad/issues/263","number":263,"state":"open","title":"RCA framework initial","user":{"login":"yarongguo","id":3403372,"avatar_url":"https://avatars.githubusercontent.com/u/3403372?","gravatar_id":"2a197d265c752069f7822fc4394bbc03","url":"https://api.github.com/users/yarongguo","html_url":"https://github.com/yarongguo","followers_url":"https://api.github.com/users/yarongguo/followers","following_url":"https://api.github.com/users/yarongguo/following{/other_user}","gists_url":"https://api.github.com/users/yarongguo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarongguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarongguo/subscriptions","organizations_url":"https://api.github.com/users/yarongguo/orgs","repos_url":"https://api.github.com/users/yarongguo/repos","events_url":"https://api.github.com/users/yarongguo/events{/privacy}","received_events_url":"https://api.github.com/users/yarongguo/received_events","type":"User","site_admin":false},"body":"1.framework major components included\r\n2.major components interface definitions\r\n3.correlator module implemented\r\n4.detector module initial design implemented(using bitmap to get a time period and ema to get the exact point)","created_at":"2014-07-09T21:40:29Z","updated_at":"2014-07-15T23:51:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbdb2714452fee819d75d28503e4e6ee1f74189c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/naarad/pulls/263/commits","review_comments_url":"https://api.github.com/repos/linkedin/naarad/pulls/263/comments","review_comment_url":"https://api.github.com/repos/linkedin/naarad/pulls/comments/{number}","comments_url":"https://api.github.com/repos/linkedin/naarad/issues/263/comments","statuses_url":"https://api.github.com/repos/linkedin/naarad/statuses/7ca17bc19de612bd95cf7c900087a8a892a79947","head":{"label":"yarongguo:master","ref":"master","sha":"7ca17bc19de612bd95cf7c900087a8a892a79947","user":{"login":"yarongguo","id":3403372,"avatar_url":"https://avatars.githubusercontent.com/u/3403372?","gravatar_id":"2a197d265c752069f7822fc4394bbc03","url":"https://api.github.com/users/yarongguo","html_url":"https://github.com/yarongguo","followers_url":"https://api.github.com/users/yarongguo/followers","following_url":"https://api.github.com/users/yarongguo/following{/other_user}","gists_url":"https://api.github.com/users/yarongguo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarongguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarongguo/subscriptions","organizations_url":"https://api.github.com/users/yarongguo/orgs","repos_url":"https://api.github.com/users/yarongguo/repos","events_url":"https://api.github.com/users/yarongguo/events{/privacy}","received_events_url":"https://api.github.com/users/yarongguo/received_events","type":"User","site_admin":false},"repo":{"id":21257922,"name":"naarad","full_name":"yarongguo/naarad","owner":{"login":"yarongguo","id":3403372,"avatar_url":"https://avatars.githubusercontent.com/u/3403372?","gravatar_id":"2a197d265c752069f7822fc4394bbc03","url":"https://api.github.com/users/yarongguo","html_url":"https://github.com/yarongguo","followers_url":"https://api.github.com/users/yarongguo/followers","following_url":"https://api.github.com/users/yarongguo/following{/other_user}","gists_url":"https://api.github.com/users/yarongguo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarongguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarongguo/subscriptions","organizations_url":"https://api.github.com/users/yarongguo/orgs","repos_url":"https://api.github.com/users/yarongguo/repos","events_url":"https://api.github.com/users/yarongguo/events{/privacy}","received_events_url":"https://api.github.com/users/yarongguo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yarongguo/naarad","description":"Naarad is a highly configurable system analysis tool that parses and plots timeseries data for better visual correlation. Naarad was built to help in performance analysis and investigations.","fork":true,"url":"https://api.github.com/repos/yarongguo/naarad","forks_url":"https://api.github.com/repos/yarongguo/naarad/forks","keys_url":"https://api.github.com/repos/yarongguo/naarad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarongguo/naarad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarongguo/naarad/teams","hooks_url":"https://api.github.com/repos/yarongguo/naarad/hooks","issue_events_url":"https://api.github.com/repos/yarongguo/naarad/issues/events{/number}","events_url":"https://api.github.com/repos/yarongguo/naarad/events","assignees_url":"https://api.github.com/repos/yarongguo/naarad/assignees{/user}","branches_url":"https://api.github.com/repos/yarongguo/naarad/branches{/branch}","tags_url":"https://api.github.com/repos/yarongguo/naarad/tags","blobs_url":"https://api.github.com/repos/yarongguo/naarad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarongguo/naarad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarongguo/naarad/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarongguo/naarad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarongguo/naarad/statuses/{sha}","languages_url":"https://api.github.com/repos/yarongguo/naarad/languages","stargazers_url":"https://api.github.com/repos/yarongguo/naarad/stargazers","contributors_url":"https://api.github.com/repos/yarongguo/naarad/contributors","subscribers_url":"https://api.github.com/repos/yarongguo/naarad/subscribers","subscription_url":"https://api.github.com/repos/yarongguo/naarad/subscription","commits_url":"https://api.github.com/repos/yarongguo/naarad/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarongguo/naarad/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarongguo/naarad/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarongguo/naarad/issues/comments/{number}","contents_url":"https://api.github.com/repos/yarongguo/naarad/contents/{+path}","compare_url":"https://api.github.com/repos/yarongguo/naarad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarongguo/naarad/merges","archive_url":"https://api.github.com/repos/yarongguo/naarad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarongguo/naarad/downloads","issues_url":"https://api.github.com/repos/yarongguo/naarad/issues{/number}","pulls_url":"https://api.github.com/repos/yarongguo/naarad/pulls{/number}","milestones_url":"https://api.github.com/repos/yarongguo/naarad/milestones{/number}","notifications_url":"https://api.github.com/repos/yarongguo/naarad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarongguo/naarad/labels{/name}","releases_url":"https://api.github.com/repos/yarongguo/naarad/releases{/id}","created_at":"2014-06-26T23:19:51Z","updated_at":"2014-06-19T23:26:22Z","pushed_at":"2014-07-15T23:36:32Z","git_url":"git://github.com/yarongguo/naarad.git","ssh_url":"git@github.com:yarongguo/naarad.git","clone_url":"https://github.com/yarongguo/naarad.git","svn_url":"https://github.com/yarongguo/naarad","homepage":"","size":23051,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"ae34ab810dc408f2e206d705096b13d55b625112","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?","gravatar_id":"344449f21a57e790db8361d7970b731a","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":14056753,"name":"naarad","full_name":"linkedin/naarad","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?","gravatar_id":"344449f21a57e790db8361d7970b731a","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/naarad","description":"Naarad is a highly configurable system analysis tool that parses and plots timeseries data for better visual correlation. Naarad was built to help in performance analysis and investigations.","fork":false,"url":"https://api.github.com/repos/linkedin/naarad","forks_url":"https://api.github.com/repos/linkedin/naarad/forks","keys_url":"https://api.github.com/repos/linkedin/naarad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/naarad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/naarad/teams","hooks_url":"https://api.github.com/repos/linkedin/naarad/hooks","issue_events_url":"https://api.github.com/repos/linkedin/naarad/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/naarad/events","assignees_url":"https://api.github.com/repos/linkedin/naarad/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/naarad/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/naarad/tags","blobs_url":"https://api.github.com/repos/linkedin/naarad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/naarad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/naarad/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/naarad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/naarad/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/naarad/languages","stargazers_url":"https://api.github.com/repos/linkedin/naarad/stargazers","contributors_url":"https://api.github.com/repos/linkedin/naarad/contributors","subscribers_url":"https://api.github.com/repos/linkedin/naarad/subscribers","subscription_url":"https://api.github.com/repos/linkedin/naarad/subscription","commits_url":"https://api.github.com/repos/linkedin/naarad/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/naarad/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/naarad/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/naarad/issues/comments/{number}","contents_url":"https://api.github.com/repos/linkedin/naarad/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/naarad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/naarad/merges","archive_url":"https://api.github.com/repos/linkedin/naarad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/naarad/downloads","issues_url":"https://api.github.com/repos/linkedin/naarad/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/naarad/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/naarad/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/naarad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/naarad/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/naarad/releases{/id}","created_at":"2013-11-01T23:34:54Z","updated_at":"2014-07-08T08:37:03Z","pushed_at":"2014-07-15T19:55:29Z","git_url":"git://github.com/linkedin/naarad.git","ssh_url":"git@github.com:linkedin/naarad.git","clone_url":"https://github.com/linkedin/naarad.git","svn_url":"https://github.com/linkedin/naarad","homepage":"","size":28532,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":42,"forks":14,"open_issues":42,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/263"},"html":{"href":"https://github.com/linkedin/naarad/pull/263"},"issue":{"href":"https://api.github.com/repos/linkedin/naarad/issues/263"},"comments":{"href":"https://api.github.com/repos/linkedin/naarad/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/naarad/statuses/7ca17bc19de612bd95cf7c900087a8a892a79947"}}}}