GitHub PullRequestReviewCommentEvent at 2014-11-02 19:54:31
Repository: mumble
Actor: mkrautz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments/19714390","id":19714390,"diff_hunk":"@@ -479,6 +479,17 @@ void OverlayClient::readyRead() {\n \n \t\t\t\t\t\tOverlayMsgPid *omp = & omMsg.omp;\n \t\t\t\t\t\tuiPid = omp->pid;\n+#ifdef Q_OS_WIN\n+\t\t\t\t\t\tHANDLE h = OpenProcess(PROCESS_QUERY_INFORMATION | PROCESS_VM_READ, FALSE, (DWORD)uiPid);\n+\t\t\t\t\t\tif (h) {\n+\t\t\t\t\t\t\tTCHAR buf[MAX_PATH];\n+\t\t\t\t\t\t\tif (GetModuleFileNameEx(h, 0, buf, MAX_PATH)) {\n+\t\t\t\t\t\t\t\tstatic_assert(sizeof(TCHAR) == sizeof(wchar_t), \"Unicode build required\");","path":"src/mumble/OverlayClient.cpp","position":9,"original_position":9,"commit_id":"071b61835eef4e10862b45d874f12907aeadac1d","original_commit_id":"071b61835eef4e10862b45d874f12907aeadac1d","user":{"login":"mkrautz","id":36527,"avatar_url":"https://avatars.githubusercontent.com/u/36527?v=2","gravatar_id":"","url":"https://api.github.com/users/mkrautz","html_url":"https://github.com/mkrautz","followers_url":"https://api.github.com/users/mkrautz/followers","following_url":"https://api.github.com/users/mkrautz/following{/other_user}","gists_url":"https://api.github.com/users/mkrautz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrautz/subscriptions","organizations_url":"https://api.github.com/users/mkrautz/orgs","repos_url":"https://api.github.com/users/mkrautz/repos","events_url":"https://api.github.com/users/mkrautz/events{/privacy}","received_events_url":"https://api.github.com/users/mkrautz/received_events","type":"User","site_admin":false},"body":"On Windows, static_assert is backwards compatible to VS2010, and enabled by default (no flags required).\r\n\r\nHowever, we do require -DUNICODE.  If anything, we should probably just add\r\n\r\n`#ifndef UNICODE\r\n#error Mumble can only be built with -DUNICODE\r\n#endif`\r\n\r\nto mumble_pch.hpp (and maybe Murmur's as well.).\r\n\r\nShelving this.\r\n\r\n\r\n","created_at":"2014-11-02T19:54:31Z","updated_at":"2014-11-02T19:54:31Z","html_url":"https://github.com/mumble-voip/mumble/pull/1456#discussion_r19714390","pull_request_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1456","_links":{"self":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments/19714390"},"html":{"href":"https://github.com/mumble-voip/mumble/pull/1456#discussion_r19714390"},"pull_request":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/1456"}}},"pull_request":{"url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1456","id":23719909,"html_url":"https://github.com/mumble-voip/mumble/pull/1456","diff_url":"https://github.com/mumble-voip/mumble/pull/1456.diff","patch_url":"https://github.com/mumble-voip/mumble/pull/1456.patch","issue_url":"https://api.github.com/repos/mumble-voip/mumble/issues/1456","number":1456,"state":"open","locked":false,"title":"Overlay, OverlayClient: add PID and process name diagnostics to 'Dead client detected' notice.","user":{"login":"mkrautz","id":36527,"avatar_url":"https://avatars.githubusercontent.com/u/36527?v=2","gravatar_id":"","url":"https://api.github.com/users/mkrautz","html_url":"https://github.com/mkrautz","followers_url":"https://api.github.com/users/mkrautz/followers","following_url":"https://api.github.com/users/mkrautz/following{/other_user}","gists_url":"https://api.github.com/users/mkrautz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrautz/subscriptions","organizations_url":"https://api.github.com/users/mkrautz/orgs","repos_url":"https://api.github.com/users/mkrautz/repos","events_url":"https://api.github.com/users/mkrautz/events{/privacy}","received_events_url":"https://api.github.com/users/mkrautz/received_events","type":"User","site_admin":false},"body":"I'm going to use this to diagnose some regular client freezes I've been experiencing on Windows.\r\n\r\nMy own client is running with this patched in as we speak.  I think the culprit of the freezes/hangs are Spotify, but I'll need to run with the patch some more to be sure.\r\n\r\nI think these extra diagnostics make sense to have upstream as well.  Thoughts?","created_at":"2014-11-01T14:27:57Z","updated_at":"2014-11-02T19:54:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf74996f24f99ef2065a253e70228625193cd1ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1456/commits","review_comments_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1456/comments","review_comment_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mumble-voip/mumble/issues/1456/comments","statuses_url":"https://api.github.com/repos/mumble-voip/mumble/statuses/071b61835eef4e10862b45d874f12907aeadac1d","head":{"label":"mkrautz:overlay-client-dead-hang-diagnostics","ref":"overlay-client-dead-hang-diagnostics","sha":"071b61835eef4e10862b45d874f12907aeadac1d","user":{"login":"mkrautz","id":36527,"avatar_url":"https://avatars.githubusercontent.com/u/36527?v=2","gravatar_id":"","url":"https://api.github.com/users/mkrautz","html_url":"https://github.com/mkrautz","followers_url":"https://api.github.com/users/mkrautz/followers","following_url":"https://api.github.com/users/mkrautz/following{/other_user}","gists_url":"https://api.github.com/users/mkrautz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrautz/subscriptions","organizations_url":"https://api.github.com/users/mkrautz/orgs","repos_url":"https://api.github.com/users/mkrautz/repos","events_url":"https://api.github.com/users/mkrautz/events{/privacy}","received_events_url":"https://api.github.com/users/mkrautz/received_events","type":"User","site_admin":false},"repo":{"id":3210109,"name":"mumble","full_name":"mkrautz/mumble","owner":{"login":"mkrautz","id":36527,"avatar_url":"https://avatars.githubusercontent.com/u/36527?v=2","gravatar_id":"","url":"https://api.github.com/users/mkrautz","html_url":"https://github.com/mkrautz","followers_url":"https://api.github.com/users/mkrautz/followers","following_url":"https://api.github.com/users/mkrautz/following{/other_user}","gists_url":"https://api.github.com/users/mkrautz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrautz/subscriptions","organizations_url":"https://api.github.com/users/mkrautz/orgs","repos_url":"https://api.github.com/users/mkrautz/repos","events_url":"https://api.github.com/users/mkrautz/events{/privacy}","received_events_url":"https://api.github.com/users/mkrautz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkrautz/mumble","description":"Mumble VoIP Client/Server","fork":true,"url":"https://api.github.com/repos/mkrautz/mumble","forks_url":"https://api.github.com/repos/mkrautz/mumble/forks","keys_url":"https://api.github.com/repos/mkrautz/mumble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkrautz/mumble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkrautz/mumble/teams","hooks_url":"https://api.github.com/repos/mkrautz/mumble/hooks","issue_events_url":"https://api.github.com/repos/mkrautz/mumble/issues/events{/number}","events_url":"https://api.github.com/repos/mkrautz/mumble/events","assignees_url":"https://api.github.com/repos/mkrautz/mumble/assignees{/user}","branches_url":"https://api.github.com/repos/mkrautz/mumble/branches{/branch}","tags_url":"https://api.github.com/repos/mkrautz/mumble/tags","blobs_url":"https://api.github.com/repos/mkrautz/mumble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkrautz/mumble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkrautz/mumble/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkrautz/mumble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkrautz/mumble/statuses/{sha}","languages_url":"https://api.github.com/repos/mkrautz/mumble/languages","stargazers_url":"https://api.github.com/repos/mkrautz/mumble/stargazers","contributors_url":"https://api.github.com/repos/mkrautz/mumble/contributors","subscribers_url":"https://api.github.com/repos/mkrautz/mumble/subscribers","subscription_url":"https://api.github.com/repos/mkrautz/mumble/subscription","commits_url":"https://api.github.com/repos/mkrautz/mumble/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkrautz/mumble/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkrautz/mumble/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkrautz/mumble/issues/comments/{number}","contents_url":"https://api.github.com/repos/mkrautz/mumble/contents/{+path}","compare_url":"https://api.github.com/repos/mkrautz/mumble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkrautz/mumble/merges","archive_url":"https://api.github.com/repos/mkrautz/mumble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkrautz/mumble/downloads","issues_url":"https://api.github.com/repos/mkrautz/mumble/issues{/number}","pulls_url":"https://api.github.com/repos/mkrautz/mumble/pulls{/number}","milestones_url":"https://api.github.com/repos/mkrautz/mumble/milestones{/number}","notifications_url":"https://api.github.com/repos/mkrautz/mumble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkrautz/mumble/labels{/name}","releases_url":"https://api.github.com/repos/mkrautz/mumble/releases{/id}","created_at":"2012-01-18T16:24:06Z","updated_at":"2014-02-24T20:58:09Z","pushed_at":"2014-11-01T14:26:07Z","git_url":"git://github.com/mkrautz/mumble.git","ssh_url":"git@github.com:mkrautz/mumble.git","clone_url":"https://github.com/mkrautz/mumble.git","svn_url":"https://github.com/mkrautz/mumble","homepage":"http://mumble.info","size":24379,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"mumble-voip:master","ref":"master","sha":"7d434bbfa5df0024c021d2647eb603a5947c6ec7","user":{"login":"mumble-voip","id":639008,"avatar_url":"https://avatars.githubusercontent.com/u/639008?v=2","gravatar_id":"","url":"https://api.github.com/users/mumble-voip","html_url":"https://github.com/mumble-voip","followers_url":"https://api.github.com/users/mumble-voip/followers","following_url":"https://api.github.com/users/mumble-voip/following{/other_user}","gists_url":"https://api.github.com/users/mumble-voip/gists{/gist_id}","starred_url":"https://api.github.com/users/mumble-voip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumble-voip/subscriptions","organizations_url":"https://api.github.com/users/mumble-voip/orgs","repos_url":"https://api.github.com/users/mumble-voip/repos","events_url":"https://api.github.com/users/mumble-voip/events{/privacy}","received_events_url":"https://api.github.com/users/mumble-voip/received_events","type":"Organization","site_admin":false},"repo":{"id":1413319,"name":"mumble","full_name":"mumble-voip/mumble","owner":{"login":"mumble-voip","id":639008,"avatar_url":"https://avatars.githubusercontent.com/u/639008?v=2","gravatar_id":"","url":"https://api.github.com/users/mumble-voip","html_url":"https://github.com/mumble-voip","followers_url":"https://api.github.com/users/mumble-voip/followers","following_url":"https://api.github.com/users/mumble-voip/following{/other_user}","gists_url":"https://api.github.com/users/mumble-voip/gists{/gist_id}","starred_url":"https://api.github.com/users/mumble-voip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumble-voip/subscriptions","organizations_url":"https://api.github.com/users/mumble-voip/orgs","repos_url":"https://api.github.com/users/mumble-voip/repos","events_url":"https://api.github.com/users/mumble-voip/events{/privacy}","received_events_url":"https://api.github.com/users/mumble-voip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mumble-voip/mumble","description":"Mumble VoIP Client/Server","fork":false,"url":"https://api.github.com/repos/mumble-voip/mumble","forks_url":"https://api.github.com/repos/mumble-voip/mumble/forks","keys_url":"https://api.github.com/repos/mumble-voip/mumble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mumble-voip/mumble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mumble-voip/mumble/teams","hooks_url":"https://api.github.com/repos/mumble-voip/mumble/hooks","issue_events_url":"https://api.github.com/repos/mumble-voip/mumble/issues/events{/number}","events_url":"https://api.github.com/repos/mumble-voip/mumble/events","assignees_url":"https://api.github.com/repos/mumble-voip/mumble/assignees{/user}","branches_url":"https://api.github.com/repos/mumble-voip/mumble/branches{/branch}","tags_url":"https://api.github.com/repos/mumble-voip/mumble/tags","blobs_url":"https://api.github.com/repos/mumble-voip/mumble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mumble-voip/mumble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mumble-voip/mumble/git/refs{/sha}","trees_url":"https://api.github.com/repos/mumble-voip/mumble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mumble-voip/mumble/statuses/{sha}","languages_url":"https://api.github.com/repos/mumble-voip/mumble/languages","stargazers_url":"https://api.github.com/repos/mumble-voip/mumble/stargazers","contributors_url":"https://api.github.com/repos/mumble-voip/mumble/contributors","subscribers_url":"https://api.github.com/repos/mumble-voip/mumble/subscribers","subscription_url":"https://api.github.com/repos/mumble-voip/mumble/subscription","commits_url":"https://api.github.com/repos/mumble-voip/mumble/commits{/sha}","git_commits_url":"https://api.github.com/repos/mumble-voip/mumble/git/commits{/sha}","comments_url":"https://api.github.com/repos/mumble-voip/mumble/comments{/number}","issue_comment_url":"https://api.github.com/repos/mumble-voip/mumble/issues/comments/{number}","contents_url":"https://api.github.com/repos/mumble-voip/mumble/contents/{+path}","compare_url":"https://api.github.com/repos/mumble-voip/mumble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mumble-voip/mumble/merges","archive_url":"https://api.github.com/repos/mumble-voip/mumble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mumble-voip/mumble/downloads","issues_url":"https://api.github.com/repos/mumble-voip/mumble/issues{/number}","pulls_url":"https://api.github.com/repos/mumble-voip/mumble/pulls{/number}","milestones_url":"https://api.github.com/repos/mumble-voip/mumble/milestones{/number}","notifications_url":"https://api.github.com/repos/mumble-voip/mumble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mumble-voip/mumble/labels{/name}","releases_url":"https://api.github.com/repos/mumble-voip/mumble/releases{/id}","created_at":"2011-02-26T01:30:08Z","updated_at":"2014-11-01T19:32:19Z","pushed_at":"2014-11-01T20:32:20Z","git_url":"git://github.com/mumble-voip/mumble.git","ssh_url":"git@github.com:mumble-voip/mumble.git","clone_url":"https://github.com/mumble-voip/mumble.git","svn_url":"https://github.com/mumble-voip/mumble","homepage":"http://www.mumble.info","size":34834,"stargazers_count":584,"watchers_count":584,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":262,"forks":239,"open_issues":262,"watchers":584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/1456"},"html":{"href":"https://github.com/mumble-voip/mumble/pull/1456"},"issue":{"href":"https://api.github.com/repos/mumble-voip/mumble/issues/1456"},"comments":{"href":"https://api.github.com/repos/mumble-voip/mumble/issues/1456/comments"},"review_comments":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/1456/comments"},"review_comment":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/1456/commits"},"statuses":{"href":"https://api.github.com/repos/mumble-voip/mumble/statuses/071b61835eef4e10862b45d874f12907aeadac1d"}}}}