GitHub PullRequestReviewCommentEvent at 2014-06-20 14:02:11
Repository: xtuple
Actor: shackbarth
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xtuple/xtuple/pulls/comments/14020673","id":14020673,"diff_hunk":"@@ -112,10 +110,7 @@\n         });\n       });\n       it('Supply list should have action to open Item Workbench', function (done) {\n-        if (!XT.extensions.inventory) {\n-          done();\n-          return;\n-        }\n+        if (!XT.extensions.inventory) {return done(); }","path":"test/extensions/sales/sales_order_workspace.js","position":24,"original_position":24,"commit_id":"62e67560243cb0ba8278386a07bd8b1aa8a8ed84","original_commit_id":"62e67560243cb0ba8278386a07bd8b1aa8a8ed84","user":{"login":"shackbarth","id":1056617,"avatar_url":"https://avatars.githubusercontent.com/u/1056617?","gravatar_id":"fd02953a3d31d71dd3a9a4e6ff24137a","url":"https://api.github.com/users/shackbarth","html_url":"https://github.com/shackbarth","followers_url":"https://api.github.com/users/shackbarth/followers","following_url":"https://api.github.com/users/shackbarth/following{/other_user}","gists_url":"https://api.github.com/users/shackbarth/gists{/gist_id}","starred_url":"https://api.github.com/users/shackbarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shackbarth/subscriptions","organizations_url":"https://api.github.com/users/shackbarth/orgs","repos_url":"https://api.github.com/users/shackbarth/repos","events_url":"https://api.github.com/users/shackbarth/events{/privacy}","received_events_url":"https://api.github.com/users/shackbarth/received_events","type":"User","site_admin":false},"body":"This `it()` should really be in `private-extensions/test/inventory`","created_at":"2014-06-20T14:02:11Z","updated_at":"2014-06-20T14:02:11Z","html_url":"https://github.com/xtuple/xtuple/pull/1592#discussion_r14020673","pull_request_url":"https://api.github.com/repos/xtuple/xtuple/pulls/1592","_links":{"self":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/comments/14020673"},"html":{"href":"https://github.com/xtuple/xtuple/pull/1592#discussion_r14020673"},"pull_request":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/1592"}}},"pull_request":{"url":"https://api.github.com/repos/xtuple/xtuple/pulls/1592","id":17314857,"html_url":"https://github.com/xtuple/xtuple/pull/1592","diff_url":"https://github.com/xtuple/xtuple/pull/1592.diff","patch_url":"https://github.com/xtuple/xtuple/pull/1592.patch","issue_url":"https://api.github.com/repos/xtuple/xtuple/issues/1592","number":1592,"state":"open","title":"23382 can edit item site","user":{"login":"julesstp","id":1823527,"avatar_url":"https://avatars.githubusercontent.com/u/1823527?","gravatar_id":"a18e2ae9f9c57219a5df12ffed42b0ae","url":"https://api.github.com/users/julesstp","html_url":"https://github.com/julesstp","followers_url":"https://api.github.com/users/julesstp/followers","following_url":"https://api.github.com/users/julesstp/following{/other_user}","gists_url":"https://api.github.com/users/julesstp/gists{/gist_id}","starred_url":"https://api.github.com/users/julesstp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julesstp/subscriptions","organizations_url":"https://api.github.com/users/julesstp/orgs","repos_url":"https://api.github.com/users/julesstp/repos","events_url":"https://api.github.com/users/julesstp/events{/privacy}","received_events_url":"https://api.github.com/users/julesstp/received_events","type":"User","site_admin":false},"body":"Dependent on: https://github.com/xtuple/private-extensions/pull/336","created_at":"2014-06-18T19:45:02Z","updated_at":"2014-06-20T14:02:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9887f6b4e97e867bf2f8b49c6bdb6e2adfa65392","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xtuple/xtuple/pulls/1592/commits","review_comments_url":"https://api.github.com/repos/xtuple/xtuple/pulls/1592/comments","review_comment_url":"https://api.github.com/repos/xtuple/xtuple/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xtuple/xtuple/issues/1592/comments","statuses_url":"https://api.github.com/repos/xtuple/xtuple/statuses/62e67560243cb0ba8278386a07bd8b1aa8a8ed84","head":{"label":"julesstp:23382-CanEditItemSite","ref":"23382-CanEditItemSite","sha":"62e67560243cb0ba8278386a07bd8b1aa8a8ed84","user":{"login":"julesstp","id":1823527,"avatar_url":"https://avatars.githubusercontent.com/u/1823527?","gravatar_id":"a18e2ae9f9c57219a5df12ffed42b0ae","url":"https://api.github.com/users/julesstp","html_url":"https://github.com/julesstp","followers_url":"https://api.github.com/users/julesstp/followers","following_url":"https://api.github.com/users/julesstp/following{/other_user}","gists_url":"https://api.github.com/users/julesstp/gists{/gist_id}","starred_url":"https://api.github.com/users/julesstp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julesstp/subscriptions","organizations_url":"https://api.github.com/users/julesstp/orgs","repos_url":"https://api.github.com/users/julesstp/repos","events_url":"https://api.github.com/users/julesstp/events{/privacy}","received_events_url":"https://api.github.com/users/julesstp/received_events","type":"User","site_admin":false},"repo":{"id":8245618,"name":"xtuple","full_name":"julesstp/xtuple","owner":{"login":"julesstp","id":1823527,"avatar_url":"https://avatars.githubusercontent.com/u/1823527?","gravatar_id":"a18e2ae9f9c57219a5df12ffed42b0ae","url":"https://api.github.com/users/julesstp","html_url":"https://github.com/julesstp","followers_url":"https://api.github.com/users/julesstp/followers","following_url":"https://api.github.com/users/julesstp/following{/other_user}","gists_url":"https://api.github.com/users/julesstp/gists{/gist_id}","starred_url":"https://api.github.com/users/julesstp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julesstp/subscriptions","organizations_url":"https://api.github.com/users/julesstp/orgs","repos_url":"https://api.github.com/users/julesstp/repos","events_url":"https://api.github.com/users/julesstp/events{/privacy}","received_events_url":"https://api.github.com/users/julesstp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julesstp/xtuple","description":"xTuple Enterprise Resource Planning","fork":true,"url":"https://api.github.com/repos/julesstp/xtuple","forks_url":"https://api.github.com/repos/julesstp/xtuple/forks","keys_url":"https://api.github.com/repos/julesstp/xtuple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julesstp/xtuple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julesstp/xtuple/teams","hooks_url":"https://api.github.com/repos/julesstp/xtuple/hooks","issue_events_url":"https://api.github.com/repos/julesstp/xtuple/issues/events{/number}","events_url":"https://api.github.com/repos/julesstp/xtuple/events","assignees_url":"https://api.github.com/repos/julesstp/xtuple/assignees{/user}","branches_url":"https://api.github.com/repos/julesstp/xtuple/branches{/branch}","tags_url":"https://api.github.com/repos/julesstp/xtuple/tags","blobs_url":"https://api.github.com/repos/julesstp/xtuple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julesstp/xtuple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julesstp/xtuple/git/refs{/sha}","trees_url":"https://api.github.com/repos/julesstp/xtuple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julesstp/xtuple/statuses/{sha}","languages_url":"https://api.github.com/repos/julesstp/xtuple/languages","stargazers_url":"https://api.github.com/repos/julesstp/xtuple/stargazers","contributors_url":"https://api.github.com/repos/julesstp/xtuple/contributors","subscribers_url":"https://api.github.com/repos/julesstp/xtuple/subscribers","subscription_url":"https://api.github.com/repos/julesstp/xtuple/subscription","commits_url":"https://api.github.com/repos/julesstp/xtuple/commits{/sha}","git_commits_url":"https://api.github.com/repos/julesstp/xtuple/git/commits{/sha}","comments_url":"https://api.github.com/repos/julesstp/xtuple/comments{/number}","issue_comment_url":"https://api.github.com/repos/julesstp/xtuple/issues/comments/{number}","contents_url":"https://api.github.com/repos/julesstp/xtuple/contents/{+path}","compare_url":"https://api.github.com/repos/julesstp/xtuple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julesstp/xtuple/merges","archive_url":"https://api.github.com/repos/julesstp/xtuple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julesstp/xtuple/downloads","issues_url":"https://api.github.com/repos/julesstp/xtuple/issues{/number}","pulls_url":"https://api.github.com/repos/julesstp/xtuple/pulls{/number}","milestones_url":"https://api.github.com/repos/julesstp/xtuple/milestones{/number}","notifications_url":"https://api.github.com/repos/julesstp/xtuple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julesstp/xtuple/labels{/name}","releases_url":"https://api.github.com/repos/julesstp/xtuple/releases{/id}","created_at":"2013-02-17T03:51:28Z","updated_at":"2014-06-20T02:39:48Z","pushed_at":"2014-06-20T02:39:47Z","git_url":"git://github.com/julesstp/xtuple.git","ssh_url":"git@github.com:julesstp/xtuple.git","clone_url":"https://github.com/julesstp/xtuple.git","svn_url":"https://github.com/julesstp/xtuple","homepage":null,"size":73124,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xtuple:4_5_x","ref":"4_5_x","sha":"73d904854d3d50ed1e1b09e0a1263ed9321555e8","user":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?","gravatar_id":"50375c477e5e16ff431a203c64fc9c38","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"repo":{"id":8138568,"name":"xtuple","full_name":"xtuple/xtuple","owner":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?","gravatar_id":"50375c477e5e16ff431a203c64fc9c38","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xtuple/xtuple","description":"xTuple Web Services and Client","fork":false,"url":"https://api.github.com/repos/xtuple/xtuple","forks_url":"https://api.github.com/repos/xtuple/xtuple/forks","keys_url":"https://api.github.com/repos/xtuple/xtuple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xtuple/xtuple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xtuple/xtuple/teams","hooks_url":"https://api.github.com/repos/xtuple/xtuple/hooks","issue_events_url":"https://api.github.com/repos/xtuple/xtuple/issues/events{/number}","events_url":"https://api.github.com/repos/xtuple/xtuple/events","assignees_url":"https://api.github.com/repos/xtuple/xtuple/assignees{/user}","branches_url":"https://api.github.com/repos/xtuple/xtuple/branches{/branch}","tags_url":"https://api.github.com/repos/xtuple/xtuple/tags","blobs_url":"https://api.github.com/repos/xtuple/xtuple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xtuple/xtuple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xtuple/xtuple/git/refs{/sha}","trees_url":"https://api.github.com/repos/xtuple/xtuple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xtuple/xtuple/statuses/{sha}","languages_url":"https://api.github.com/repos/xtuple/xtuple/languages","stargazers_url":"https://api.github.com/repos/xtuple/xtuple/stargazers","contributors_url":"https://api.github.com/repos/xtuple/xtuple/contributors","subscribers_url":"https://api.github.com/repos/xtuple/xtuple/subscribers","subscription_url":"https://api.github.com/repos/xtuple/xtuple/subscription","commits_url":"https://api.github.com/repos/xtuple/xtuple/commits{/sha}","git_commits_url":"https://api.github.com/repos/xtuple/xtuple/git/commits{/sha}","comments_url":"https://api.github.com/repos/xtuple/xtuple/comments{/number}","issue_comment_url":"https://api.github.com/repos/xtuple/xtuple/issues/comments/{number}","contents_url":"https://api.github.com/repos/xtuple/xtuple/contents/{+path}","compare_url":"https://api.github.com/repos/xtuple/xtuple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xtuple/xtuple/merges","archive_url":"https://api.github.com/repos/xtuple/xtuple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xtuple/xtuple/downloads","issues_url":"https://api.github.com/repos/xtuple/xtuple/issues{/number}","pulls_url":"https://api.github.com/repos/xtuple/xtuple/pulls{/number}","milestones_url":"https://api.github.com/repos/xtuple/xtuple/milestones{/number}","notifications_url":"https://api.github.com/repos/xtuple/xtuple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xtuple/xtuple/labels{/name}","releases_url":"https://api.github.com/repos/xtuple/xtuple/releases{/id}","created_at":"2013-02-11T13:33:14Z","updated_at":"2014-06-18T01:04:58Z","pushed_at":"2014-06-18T01:04:58Z","git_url":"git://github.com/xtuple/xtuple.git","ssh_url":"git@github.com:xtuple/xtuple.git","clone_url":"https://github.com/xtuple/xtuple.git","svn_url":"https://github.com/xtuple/xtuple","homepage":"","size":92926,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":109,"mirror_url":null,"open_issues_count":33,"forks":109,"open_issues":33,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/1592"},"html":{"href":"https://github.com/xtuple/xtuple/pull/1592"},"issue":{"href":"https://api.github.com/repos/xtuple/xtuple/issues/1592"},"comments":{"href":"https://api.github.com/repos/xtuple/xtuple/issues/1592/comments"},"review_comments":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/1592/comments"},"review_comment":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/1592/commits"},"statuses":{"href":"https://api.github.com/repos/xtuple/xtuple/statuses/62e67560243cb0ba8278386a07bd8b1aa8a8ed84"}}}}