GitHub PullRequestReviewCommentEvent at 2014-05-28 13:17:44
Repository: WebODF
Actor: kossebau
Payload: {"comment":{"url":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/13130051","id":13130051,"diff_hunk":"@@ -503,13 +502,14 @@ gui.SelectionController = function SelectionController(session, inputMemberId) {\n     this.extendSelectionDown = extendSelectionDown;\n \n     /**\n-     * @param {!number} direction PREVIOUS (-1) or NEXT (1)\n+     * @param {!core.StepDirection} direction\n      * @param {!boolean} extend","path":"webodf/lib/gui/SelectionController.js","position":164,"original_position":164,"commit_id":"4c28ce91a0c81c2414e9c47af1cca0f98a5d7030","original_commit_id":"4c28ce91a0c81c2414e9c47af1cca0f98a5d7030","user":{"login":"kossebau","id":4068037,"avatar_url":"https://avatars.githubusercontent.com/u/4068037?","gravatar_id":"6ec9d5b4b917b38c571b568766c59bf4","url":"https://api.github.com/users/kossebau","html_url":"https://github.com/kossebau","followers_url":"https://api.github.com/users/kossebau/followers","following_url":"https://api.github.com/users/kossebau/following{/other_user}","gists_url":"https://api.github.com/users/kossebau/gists{/gist_id}","starred_url":"https://api.github.com/users/kossebau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kossebau/subscriptions","organizations_url":"https://api.github.com/users/kossebau/orgs","repos_url":"https://api.github.com/users/kossebau/repos","events_url":"https://api.github.com/users/kossebau/events{/privacy}","received_events_url":"https://api.github.com/users/kossebau/received_events","type":"User","site_admin":false},"body":"While reading this: In a next step perhaps all the `true` and `false` passed for the `extend` parameters could be replaced by some descriptive const names, e.g. `EXTENDSELECTION` and `COLLAPSESELECTION`.","created_at":"2014-05-28T13:17:44Z","updated_at":"2014-05-28T13:17:44Z","html_url":"https://github.com/kogmbh/WebODF/pull/617#discussion_r13130051","pull_request_url":"https://api.github.com/repos/kogmbh/WebODF/pulls/617","_links":{"self":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/13130051"},"html":{"href":"https://github.com/kogmbh/WebODF/pull/617#discussion_r13130051"},"pull_request":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/617"}}}}