GitHub PullRequestReviewCommentEvent at 2014-08-06 12:26:02
Repository: university-android-task5
Actor: 0legg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/comments/15869884","id":15869884,"diff_hunk":"@@ -5,12 +5,17 @@\n import android.graphics.BitmapFactory;\r\n import android.os.Bundle;\r\n import android.util.Log;\r\n+import android.view.View;\r\n+import android.widget.AdapterView;\r\n+import android.widget.ListView;\r\n \r\n import java.util.ArrayList;\r\n import java.util.List;\r\n \r\n public class MimimiActivity extends ListActivity {\r\n \r\n+    private static final int MAX_HEIGHT = 300;\r","path":"app/src/main/java/com/noveogroup/task5/MimimiActivity.java","position":13,"original_position":13,"commit_id":"a5ce60d2db00998fb95d31fe47dd6fe3f3e48be3","original_commit_id":"a5ce60d2db00998fb95d31fe47dd6fe3f3e48be3","user":{"login":"0legg","id":2427681,"avatar_url":"https://avatars.githubusercontent.com/u/2427681?v=2","gravatar_id":"f3f1f30a06d13ab1b009b9afc1ef563a","url":"https://api.github.com/users/0legg","html_url":"https://github.com/0legg","followers_url":"https://api.github.com/users/0legg/followers","following_url":"https://api.github.com/users/0legg/following{/other_user}","gists_url":"https://api.github.com/users/0legg/gists{/gist_id}","starred_url":"https://api.github.com/users/0legg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0legg/subscriptions","organizations_url":"https://api.github.com/users/0legg/orgs","repos_url":"https://api.github.com/users/0legg/repos","events_url":"https://api.github.com/users/0legg/events{/privacy}","received_events_url":"https://api.github.com/users/0legg/received_events","type":"User","site_admin":false},"body":"Для размеров лучше использовать ресурсы и метрику вести в dp","created_at":"2014-08-06T12:26:02Z","updated_at":"2014-08-06T12:26:02Z","html_url":"https://github.com/noveogroup/university-android-task5/pull/4#discussion_r15869884","pull_request_url":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/comments/15869884"},"html":{"href":"https://github.com/noveogroup/university-android-task5/pull/4#discussion_r15869884"},"pull_request":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/4","id":19392447,"html_url":"https://github.com/noveogroup/university-android-task5/pull/4","diff_url":"https://github.com/noveogroup/university-android-task5/pull/4.diff","patch_url":"https://github.com/noveogroup/university-android-task5/pull/4.patch","issue_url":"https://api.github.com/repos/noveogroup/university-android-task5/issues/4","number":4,"state":"open","title":"Done","user":{"login":"chechulinYuri","id":2786589,"avatar_url":"https://avatars.githubusercontent.com/u/2786589?v=2","gravatar_id":"0f4ca974f26c8129d3b2827787000772","url":"https://api.github.com/users/chechulinYuri","html_url":"https://github.com/chechulinYuri","followers_url":"https://api.github.com/users/chechulinYuri/followers","following_url":"https://api.github.com/users/chechulinYuri/following{/other_user}","gists_url":"https://api.github.com/users/chechulinYuri/gists{/gist_id}","starred_url":"https://api.github.com/users/chechulinYuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chechulinYuri/subscriptions","organizations_url":"https://api.github.com/users/chechulinYuri/orgs","repos_url":"https://api.github.com/users/chechulinYuri/repos","events_url":"https://api.github.com/users/chechulinYuri/events{/privacy}","received_events_url":"https://api.github.com/users/chechulinYuri/received_events","type":"User","site_admin":false},"body":"Не знаю только правильно ли сделал с загрузкой. Я сначала искал inSampleSize, с которым размер картинки будет максимально близок к нужному мне размеру. Грузил картинку с ним, и потом уже уменьшал до точно нужного мне размера. Не нашел как грузить в точно нужном мне размере.","created_at":"2014-08-06T09:10:50Z","updated_at":"2014-08-06T12:26:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d02559e5585d78c38d4c4fa814cb21d6ab9d6578","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/4/commits","review_comments_url":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/4/comments","review_comment_url":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/comments/{number}","comments_url":"https://api.github.com/repos/noveogroup/university-android-task5/issues/4/comments","statuses_url":"https://api.github.com/repos/noveogroup/university-android-task5/statuses/a5ce60d2db00998fb95d31fe47dd6fe3f3e48be3","head":{"label":"chechulinYuri:master","ref":"master","sha":"a5ce60d2db00998fb95d31fe47dd6fe3f3e48be3","user":{"login":"chechulinYuri","id":2786589,"avatar_url":"https://avatars.githubusercontent.com/u/2786589?v=2","gravatar_id":"0f4ca974f26c8129d3b2827787000772","url":"https://api.github.com/users/chechulinYuri","html_url":"https://github.com/chechulinYuri","followers_url":"https://api.github.com/users/chechulinYuri/followers","following_url":"https://api.github.com/users/chechulinYuri/following{/other_user}","gists_url":"https://api.github.com/users/chechulinYuri/gists{/gist_id}","starred_url":"https://api.github.com/users/chechulinYuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chechulinYuri/subscriptions","organizations_url":"https://api.github.com/users/chechulinYuri/orgs","repos_url":"https://api.github.com/users/chechulinYuri/repos","events_url":"https://api.github.com/users/chechulinYuri/events{/privacy}","received_events_url":"https://api.github.com/users/chechulinYuri/received_events","type":"User","site_admin":false},"repo":{"id":22591976,"name":"university-android-task5","full_name":"chechulinYuri/university-android-task5","owner":{"login":"chechulinYuri","id":2786589,"avatar_url":"https://avatars.githubusercontent.com/u/2786589?v=2","gravatar_id":"0f4ca974f26c8129d3b2827787000772","url":"https://api.github.com/users/chechulinYuri","html_url":"https://github.com/chechulinYuri","followers_url":"https://api.github.com/users/chechulinYuri/followers","following_url":"https://api.github.com/users/chechulinYuri/following{/other_user}","gists_url":"https://api.github.com/users/chechulinYuri/gists{/gist_id}","starred_url":"https://api.github.com/users/chechulinYuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chechulinYuri/subscriptions","organizations_url":"https://api.github.com/users/chechulinYuri/orgs","repos_url":"https://api.github.com/users/chechulinYuri/repos","events_url":"https://api.github.com/users/chechulinYuri/events{/privacy}","received_events_url":"https://api.github.com/users/chechulinYuri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chechulinYuri/university-android-task5","description":"university-android-task5","fork":true,"url":"https://api.github.com/repos/chechulinYuri/university-android-task5","forks_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/forks","keys_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/teams","hooks_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/hooks","issue_events_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/issues/events{/number}","events_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/events","assignees_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/assignees{/user}","branches_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/branches{/branch}","tags_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/tags","blobs_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/git/refs{/sha}","trees_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/statuses/{sha}","languages_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/languages","stargazers_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/stargazers","contributors_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/contributors","subscribers_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/subscribers","subscription_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/subscription","commits_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/commits{/sha}","git_commits_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/git/commits{/sha}","comments_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/comments{/number}","issue_comment_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/issues/comments/{number}","contents_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/contents/{+path}","compare_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/merges","archive_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/downloads","issues_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/issues{/number}","pulls_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/pulls{/number}","milestones_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/milestones{/number}","notifications_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/labels{/name}","releases_url":"https://api.github.com/repos/chechulinYuri/university-android-task5/releases{/id}","created_at":"2014-08-04T04:30:00Z","updated_at":"2014-08-04T09:25:17Z","pushed_at":"2014-08-06T09:06:56Z","git_url":"git://github.com/chechulinYuri/university-android-task5.git","ssh_url":"git@github.com:chechulinYuri/university-android-task5.git","clone_url":"https://github.com/chechulinYuri/university-android-task5.git","svn_url":"https://github.com/chechulinYuri/university-android-task5","homepage":null,"size":1783,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"noveogroup:master","ref":"master","sha":"0d7b4f9e5f2526c7f229583fe8c83036c0a16e6e","user":{"login":"noveogroup","id":3395790,"avatar_url":"https://avatars.githubusercontent.com/u/3395790?v=2","gravatar_id":"f40c16d871f85820bc5a813c5ea750e0","url":"https://api.github.com/users/noveogroup","html_url":"https://github.com/noveogroup","followers_url":"https://api.github.com/users/noveogroup/followers","following_url":"https://api.github.com/users/noveogroup/following{/other_user}","gists_url":"https://api.github.com/users/noveogroup/gists{/gist_id}","starred_url":"https://api.github.com/users/noveogroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noveogroup/subscriptions","organizations_url":"https://api.github.com/users/noveogroup/orgs","repos_url":"https://api.github.com/users/noveogroup/repos","events_url":"https://api.github.com/users/noveogroup/events{/privacy}","received_events_url":"https://api.github.com/users/noveogroup/received_events","type":"Organization","site_admin":false},"repo":{"id":22411146,"name":"university-android-task5","full_name":"noveogroup/university-android-task5","owner":{"login":"noveogroup","id":3395790,"avatar_url":"https://avatars.githubusercontent.com/u/3395790?v=2","gravatar_id":"f40c16d871f85820bc5a813c5ea750e0","url":"https://api.github.com/users/noveogroup","html_url":"https://github.com/noveogroup","followers_url":"https://api.github.com/users/noveogroup/followers","following_url":"https://api.github.com/users/noveogroup/following{/other_user}","gists_url":"https://api.github.com/users/noveogroup/gists{/gist_id}","starred_url":"https://api.github.com/users/noveogroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noveogroup/subscriptions","organizations_url":"https://api.github.com/users/noveogroup/orgs","repos_url":"https://api.github.com/users/noveogroup/repos","events_url":"https://api.github.com/users/noveogroup/events{/privacy}","received_events_url":"https://api.github.com/users/noveogroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/noveogroup/university-android-task5","description":"university-android-task5","fork":false,"url":"https://api.github.com/repos/noveogroup/university-android-task5","forks_url":"https://api.github.com/repos/noveogroup/university-android-task5/forks","keys_url":"https://api.github.com/repos/noveogroup/university-android-task5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noveogroup/university-android-task5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noveogroup/university-android-task5/teams","hooks_url":"https://api.github.com/repos/noveogroup/university-android-task5/hooks","issue_events_url":"https://api.github.com/repos/noveogroup/university-android-task5/issues/events{/number}","events_url":"https://api.github.com/repos/noveogroup/university-android-task5/events","assignees_url":"https://api.github.com/repos/noveogroup/university-android-task5/assignees{/user}","branches_url":"https://api.github.com/repos/noveogroup/university-android-task5/branches{/branch}","tags_url":"https://api.github.com/repos/noveogroup/university-android-task5/tags","blobs_url":"https://api.github.com/repos/noveogroup/university-android-task5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noveogroup/university-android-task5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noveogroup/university-android-task5/git/refs{/sha}","trees_url":"https://api.github.com/repos/noveogroup/university-android-task5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noveogroup/university-android-task5/statuses/{sha}","languages_url":"https://api.github.com/repos/noveogroup/university-android-task5/languages","stargazers_url":"https://api.github.com/repos/noveogroup/university-android-task5/stargazers","contributors_url":"https://api.github.com/repos/noveogroup/university-android-task5/contributors","subscribers_url":"https://api.github.com/repos/noveogroup/university-android-task5/subscribers","subscription_url":"https://api.github.com/repos/noveogroup/university-android-task5/subscription","commits_url":"https://api.github.com/repos/noveogroup/university-android-task5/commits{/sha}","git_commits_url":"https://api.github.com/repos/noveogroup/university-android-task5/git/commits{/sha}","comments_url":"https://api.github.com/repos/noveogroup/university-android-task5/comments{/number}","issue_comment_url":"https://api.github.com/repos/noveogroup/university-android-task5/issues/comments/{number}","contents_url":"https://api.github.com/repos/noveogroup/university-android-task5/contents/{+path}","compare_url":"https://api.github.com/repos/noveogroup/university-android-task5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noveogroup/university-android-task5/merges","archive_url":"https://api.github.com/repos/noveogroup/university-android-task5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noveogroup/university-android-task5/downloads","issues_url":"https://api.github.com/repos/noveogroup/university-android-task5/issues{/number}","pulls_url":"https://api.github.com/repos/noveogroup/university-android-task5/pulls{/number}","milestones_url":"https://api.github.com/repos/noveogroup/university-android-task5/milestones{/number}","notifications_url":"https://api.github.com/repos/noveogroup/university-android-task5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noveogroup/university-android-task5/labels{/name}","releases_url":"https://api.github.com/repos/noveogroup/university-android-task5/releases{/id}","created_at":"2014-07-30T06:04:18Z","updated_at":"2014-07-30T09:51:07Z","pushed_at":"2014-07-30T09:51:07Z","git_url":"git://github.com/noveogroup/university-android-task5.git","ssh_url":"git@github.com:noveogroup/university-android-task5.git","clone_url":"https://github.com/noveogroup/university-android-task5.git","svn_url":"https://github.com/noveogroup/university-android-task5","homepage":null,"size":2905,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/4"},"html":{"href":"https://github.com/noveogroup/university-android-task5/pull/4"},"issue":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/issues/4"},"comments":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/noveogroup/university-android-task5/statuses/a5ce60d2db00998fb95d31fe47dd6fe3f3e48be3"}}}}