GitHub PullRequestReviewCommentEvent at 2014-12-22 10:51:10
Repository: inapp-ios
Actor: grozen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/comments/22161699","id":22161699,"diff_hunk":"@@ -8,13 +9,21 @@\n   it(@\"should return a playground registration url when token is for playground\", ^{\n     [[KIAContext class] stub:@selector(getApiKey) andReturn:@\"test_skadoo\"];\n     \n-    [[[KIAUrl registrationUrl].absoluteString should] equal:@\"https://inapp.playground.klarna.com/registration/new?api_key=test_skadoo&locale=en\"];\n+    NSURL *url = [KIAUrl registrationUrl];\n+    NSURL *urlWithoutQueryString = [[NSURL alloc] initWithScheme:[url scheme]","path":"InappTests/KIAUrlSpec.m","position":13,"original_position":13,"commit_id":"6cc5fcd75872349cce80975f5df9ce9b71ce197a","original_commit_id":"6cc5fcd75872349cce80975f5df9ce9b71ce197a","user":{"login":"grozen","id":1166903,"avatar_url":"https://avatars.githubusercontent.com/u/1166903?v=3","gravatar_id":"","url":"https://api.github.com/users/grozen","html_url":"https://github.com/grozen","followers_url":"https://api.github.com/users/grozen/followers","following_url":"https://api.github.com/users/grozen/following{/other_user}","gists_url":"https://api.github.com/users/grozen/gists{/gist_id}","starred_url":"https://api.github.com/users/grozen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grozen/subscriptions","organizations_url":"https://api.github.com/users/grozen/orgs","repos_url":"https://api.github.com/users/grozen/repos","events_url":"https://api.github.com/users/grozen/events{/privacy}","received_events_url":"https://api.github.com/users/grozen/received_events","type":"User","site_admin":false},"body":"Isn't there a string equivalent of ruby's `starts_with` that we can use instead of creating this additional URL?","created_at":"2014-12-22T10:51:10Z","updated_at":"2014-12-22T10:51:10Z","html_url":"https://github.com/yuval-netanel/inapp-ios/pull/12#discussion_r22161699","pull_request_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/comments/22161699"},"html":{"href":"https://github.com/yuval-netanel/inapp-ios/pull/12#discussion_r22161699"},"pull_request":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/12","id":26429063,"html_url":"https://github.com/yuval-netanel/inapp-ios/pull/12","diff_url":"https://github.com/yuval-netanel/inapp-ios/pull/12.diff","patch_url":"https://github.com/yuval-netanel/inapp-ios/pull/12.patch","issue_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues/12","number":12,"state":"open","locked":false,"title":"Iaco 468 origin proof","user":{"login":"tomerlevi444","id":7806514,"avatar_url":"https://avatars.githubusercontent.com/u/7806514?v=3","gravatar_id":"","url":"https://api.github.com/users/tomerlevi444","html_url":"https://github.com/tomerlevi444","followers_url":"https://api.github.com/users/tomerlevi444/followers","following_url":"https://api.github.com/users/tomerlevi444/following{/other_user}","gists_url":"https://api.github.com/users/tomerlevi444/gists{/gist_id}","starred_url":"https://api.github.com/users/tomerlevi444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomerlevi444/subscriptions","organizations_url":"https://api.github.com/users/tomerlevi444/orgs","repos_url":"https://api.github.com/users/tomerlevi444/repos","events_url":"https://api.github.com/users/tomerlevi444/events{/privacy}","received_events_url":"https://api.github.com/users/tomerlevi444/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-21T15:39:43Z","updated_at":"2014-12-22T10:51:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"675ab7bc2dab19842aa2e5538eaffffa221e3e3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/12/commits","review_comments_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/12/comments","review_comment_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues/12/comments","statuses_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/statuses/6cc5fcd75872349cce80975f5df9ce9b71ce197a","head":{"label":"yuval-netanel:iaco-468-origin-proof","ref":"iaco-468-origin-proof","sha":"6cc5fcd75872349cce80975f5df9ce9b71ce197a","user":{"login":"yuval-netanel","id":2931327,"avatar_url":"https://avatars.githubusercontent.com/u/2931327?v=3","gravatar_id":"","url":"https://api.github.com/users/yuval-netanel","html_url":"https://github.com/yuval-netanel","followers_url":"https://api.github.com/users/yuval-netanel/followers","following_url":"https://api.github.com/users/yuval-netanel/following{/other_user}","gists_url":"https://api.github.com/users/yuval-netanel/gists{/gist_id}","starred_url":"https://api.github.com/users/yuval-netanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuval-netanel/subscriptions","organizations_url":"https://api.github.com/users/yuval-netanel/orgs","repos_url":"https://api.github.com/users/yuval-netanel/repos","events_url":"https://api.github.com/users/yuval-netanel/events{/privacy}","received_events_url":"https://api.github.com/users/yuval-netanel/received_events","type":"User","site_admin":false},"repo":{"id":27024863,"name":"inapp-ios","full_name":"yuval-netanel/inapp-ios","owner":{"login":"yuval-netanel","id":2931327,"avatar_url":"https://avatars.githubusercontent.com/u/2931327?v=3","gravatar_id":"","url":"https://api.github.com/users/yuval-netanel","html_url":"https://github.com/yuval-netanel","followers_url":"https://api.github.com/users/yuval-netanel/followers","following_url":"https://api.github.com/users/yuval-netanel/following{/other_user}","gists_url":"https://api.github.com/users/yuval-netanel/gists{/gist_id}","starred_url":"https://api.github.com/users/yuval-netanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuval-netanel/subscriptions","organizations_url":"https://api.github.com/users/yuval-netanel/orgs","repos_url":"https://api.github.com/users/yuval-netanel/repos","events_url":"https://api.github.com/users/yuval-netanel/events{/privacy}","received_events_url":"https://api.github.com/users/yuval-netanel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuval-netanel/inapp-ios","description":"","fork":false,"url":"https://api.github.com/repos/yuval-netanel/inapp-ios","forks_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/forks","keys_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/teams","hooks_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/hooks","issue_events_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues/events{/number}","events_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/events","assignees_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/assignees{/user}","branches_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/branches{/branch}","tags_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/tags","blobs_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/languages","stargazers_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/stargazers","contributors_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/contributors","subscribers_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/subscribers","subscription_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/subscription","commits_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues/comments/{number}","contents_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/contents/{+path}","compare_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/merges","archive_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/downloads","issues_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues{/number}","pulls_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/labels{/name}","releases_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/releases{/id}","created_at":"2014-11-23T07:04:44Z","updated_at":"2014-12-18T12:26:50Z","pushed_at":"2014-12-22T09:47:01Z","git_url":"git://github.com/yuval-netanel/inapp-ios.git","ssh_url":"git@github.com:yuval-netanel/inapp-ios.git","clone_url":"https://github.com/yuval-netanel/inapp-ios.git","svn_url":"https://github.com/yuval-netanel/inapp-ios","homepage":null,"size":1892,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"yuval-netanel:master","ref":"master","sha":"0b68e20cd62e87e50582fa3abcc63d268f29f7a8","user":{"login":"yuval-netanel","id":2931327,"avatar_url":"https://avatars.githubusercontent.com/u/2931327?v=3","gravatar_id":"","url":"https://api.github.com/users/yuval-netanel","html_url":"https://github.com/yuval-netanel","followers_url":"https://api.github.com/users/yuval-netanel/followers","following_url":"https://api.github.com/users/yuval-netanel/following{/other_user}","gists_url":"https://api.github.com/users/yuval-netanel/gists{/gist_id}","starred_url":"https://api.github.com/users/yuval-netanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuval-netanel/subscriptions","organizations_url":"https://api.github.com/users/yuval-netanel/orgs","repos_url":"https://api.github.com/users/yuval-netanel/repos","events_url":"https://api.github.com/users/yuval-netanel/events{/privacy}","received_events_url":"https://api.github.com/users/yuval-netanel/received_events","type":"User","site_admin":false},"repo":{"id":27024863,"name":"inapp-ios","full_name":"yuval-netanel/inapp-ios","owner":{"login":"yuval-netanel","id":2931327,"avatar_url":"https://avatars.githubusercontent.com/u/2931327?v=3","gravatar_id":"","url":"https://api.github.com/users/yuval-netanel","html_url":"https://github.com/yuval-netanel","followers_url":"https://api.github.com/users/yuval-netanel/followers","following_url":"https://api.github.com/users/yuval-netanel/following{/other_user}","gists_url":"https://api.github.com/users/yuval-netanel/gists{/gist_id}","starred_url":"https://api.github.com/users/yuval-netanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuval-netanel/subscriptions","organizations_url":"https://api.github.com/users/yuval-netanel/orgs","repos_url":"https://api.github.com/users/yuval-netanel/repos","events_url":"https://api.github.com/users/yuval-netanel/events{/privacy}","received_events_url":"https://api.github.com/users/yuval-netanel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuval-netanel/inapp-ios","description":"","fork":false,"url":"https://api.github.com/repos/yuval-netanel/inapp-ios","forks_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/forks","keys_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/teams","hooks_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/hooks","issue_events_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues/events{/number}","events_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/events","assignees_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/assignees{/user}","branches_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/branches{/branch}","tags_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/tags","blobs_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/languages","stargazers_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/stargazers","contributors_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/contributors","subscribers_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/subscribers","subscription_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/subscription","commits_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues/comments/{number}","contents_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/contents/{+path}","compare_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/merges","archive_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/downloads","issues_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues{/number}","pulls_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/labels{/name}","releases_url":"https://api.github.com/repos/yuval-netanel/inapp-ios/releases{/id}","created_at":"2014-11-23T07:04:44Z","updated_at":"2014-12-18T12:26:50Z","pushed_at":"2014-12-22T09:47:01Z","git_url":"git://github.com/yuval-netanel/inapp-ios.git","ssh_url":"git@github.com:yuval-netanel/inapp-ios.git","clone_url":"https://github.com/yuval-netanel/inapp-ios.git","svn_url":"https://github.com/yuval-netanel/inapp-ios","homepage":null,"size":1892,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/12"},"html":{"href":"https://github.com/yuval-netanel/inapp-ios/pull/12"},"issue":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues/12"},"comments":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/yuval-netanel/inapp-ios/statuses/6cc5fcd75872349cce80975f5df9ce9b71ce197a"}}}}