GitHub PullRequestReviewCommentEvent at 2014-06-02 19:20:36
Repository: gulp-git
Actor: fearphage
Payload: {"comment":{"url":"https://api.github.com/repos/stevelacy/gulp-git/pulls/comments/13302025","id":13302025,"diff_hunk":"@@ -7,15 +7,17 @@ module.exports = function (opt) {\n   if(!opt) opt = {};\n   if(!opt.args) opt.args = ' ';\n \n-  function add(file, cb) {\n-    var cmd = \"git add \" + escape([file.path]) + \" \" + opt.args;\n+  function add(file, enc, cb) {","path":"lib/add.js","position":12,"original_position":12,"commit_id":"3117c5a24769bb11acc7ff6a582cbbc95f734016","original_commit_id":"3117c5a24769bb11acc7ff6a582cbbc95f734016","user":{"login":"fearphage","id":23887,"avatar_url":"https://avatars.githubusercontent.com/u/23887?","gravatar_id":"35ebcc3523674307917d1aa38933c3ca","url":"https://api.github.com/users/fearphage","html_url":"https://github.com/fearphage","followers_url":"https://api.github.com/users/fearphage/followers","following_url":"https://api.github.com/users/fearphage/following{/other_user}","gists_url":"https://api.github.com/users/fearphage/gists{/gist_id}","starred_url":"https://api.github.com/users/fearphage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearphage/subscriptions","organizations_url":"https://api.github.com/users/fearphage/orgs","repos_url":"https://api.github.com/users/fearphage/repos","events_url":"https://api.github.com/users/fearphage/events{/privacy}","received_events_url":"https://api.github.com/users/fearphage/received_events","type":"User","site_admin":false},"body":"Why'd you add a new parameter (`enc`) that you aren't using?","created_at":"2014-06-02T19:20:36Z","updated_at":"2014-06-02T19:20:36Z","html_url":"https://github.com/stevelacy/gulp-git/pull/27#discussion_r13302025","pull_request_url":"https://api.github.com/repos/stevelacy/gulp-git/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/stevelacy/gulp-git/pulls/comments/13302025"},"html":{"href":"https://github.com/stevelacy/gulp-git/pull/27#discussion_r13302025"},"pull_request":{"href":"https://api.github.com/repos/stevelacy/gulp-git/pulls/27"}}}}