GitHub PushEvent at 2014-06-12 21:37:28
Repository: rack
Actor: MichalBryxi
Payload: {"shas":[["241ce2d1338fda38fc229e18244af9c51430a51f","cf228dd6953d4fb5c35bb9a087dd3b030d34057a@gmail.com","max-age settings forces Set-Cookie parameter\n\nWith patch https://github.com/rack/rack/commit/74e0acd36353cf619bf56fce17bcb9ef1ab30547, there is ability on rack to set max-age parameter. Which is fine. Unfortunately this parameter is sent to browser only when the session cookie is created. Which is afaik wrong. You usually want to refresh the cookie with each page request. And setting 'expires' parameter behaves in this way as well. So this patch doest:\n\n1) When max-age parameter is present, the Set-Cookie HTTP header is sent with each request\n2) When both max-age and expires parameter are set, max-age has precedence\n3) Added max-age conversion to string where aplicable, because user might not want to use string for \"time interval\"","Michal Bryxí",true]],"size":1,"ref":"refs/heads/master","head":"241ce2d1338fda38fc229e18244af9c51430a51f"}