GitHub PullRequestReviewCommentEvent at 2014-11-11 01:17:46
Repository: doctrine2
Actor: Ocramius
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/20126686","id":20126686,"diff_hunk":"@@ -238,7 +240,7 @@ public function testDuplicateColumnName_DiscriminatorColumn2_ThrowsMappingExcept\n         $cm->mapField(array('fieldName' => 'name', 'columnName' => 'name'));\n     }\n \n-    public function testDuplicateFieldAndAssociationMapping1_ThrowsException()\n+    public function testDuplicateFieldAndAssociationMapping1ThrowsException()","path":"tests/Doctrine/Tests/ORM/Mapping/ClassMetadataTest.php","position":87,"original_position":87,"commit_id":"0692a099563ffc8353e3c3872836b427b362e5c0","original_commit_id":"0692a099563ffc8353e3c3872836b427b362e5c0","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":"Please do not change existing tests","created_at":"2014-11-11T01:17:46Z","updated_at":"2014-11-11T01:17:46Z","html_url":"https://github.com/doctrine/doctrine2/pull/1179#discussion_r20126686","pull_request_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/1179","_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/20126686"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/1179#discussion_r20126686"},"pull_request":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/1179"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/1179","id":24184430,"html_url":"https://github.com/doctrine/doctrine2/pull/1179","diff_url":"https://github.com/doctrine/doctrine2/pull/1179.diff","patch_url":"https://github.com/doctrine/doctrine2/pull/1179.patch","issue_url":"https://api.github.com/repos/doctrine/doctrine2/issues/1179","number":1179,"state":"open","locked":false,"title":"Fix embeddables class metadata (work-in-progress)","user":{"login":"fabiocarneiro","id":1375034,"avatar_url":"https://avatars.githubusercontent.com/u/1375034?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiocarneiro","html_url":"https://github.com/fabiocarneiro","followers_url":"https://api.github.com/users/fabiocarneiro/followers","following_url":"https://api.github.com/users/fabiocarneiro/following{/other_user}","gists_url":"https://api.github.com/users/fabiocarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocarneiro/subscriptions","organizations_url":"https://api.github.com/users/fabiocarneiro/orgs","repos_url":"https://api.github.com/users/fabiocarneiro/repos","events_url":"https://api.github.com/users/fabiocarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocarneiro/received_events","type":"User","site_admin":false},"body":"ClassMetadataInfo is returning more than one result in getFieldNames() for the embeddables properties. This method is used by DoctrineModule\\Stdlib\\Hydrator\\DoctrineObject in the extraction process. \r\n\r\nSince its returning a number of results equal the number of properties of the embedded object, it will never find the correct setter for the extraction and that causes that property to be removed from the extracted array.\r\n\r\nI was able to solve the issue by hacking into the getFieldNames() for testing and merging the duplicated entries, and then the object was successfully extracted. \r\n\r\nBy digging into the code, i found out that there is a mapEmbedded(), but instead of using that for embeddeds, its using the default mapField, which may be the root cause of the problem.\r\n\r\n- [x] Hack into the getFieldNames() method to see if the expected solution would work\r\n- [x] Remove multiple class declaration in the same file from the files i'll work with\r\n- [x] Create a failing testcase\r\n- [ ] Create a solution","created_at":"2014-11-10T22:50:36Z","updated_at":"2014-11-11T01:17:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e5cebe347f609338e9ed2ca543c0397b0fd820f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/1179/commits","review_comments_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/1179/comments","review_comment_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/issues/1179/comments","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/0692a099563ffc8353e3c3872836b427b362e5c0","head":{"label":"fabiocarneiro:hotfix-duplicate-embeddable-mappings","ref":"hotfix-duplicate-embeddable-mappings","sha":"0692a099563ffc8353e3c3872836b427b362e5c0","user":{"login":"fabiocarneiro","id":1375034,"avatar_url":"https://avatars.githubusercontent.com/u/1375034?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiocarneiro","html_url":"https://github.com/fabiocarneiro","followers_url":"https://api.github.com/users/fabiocarneiro/followers","following_url":"https://api.github.com/users/fabiocarneiro/following{/other_user}","gists_url":"https://api.github.com/users/fabiocarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocarneiro/subscriptions","organizations_url":"https://api.github.com/users/fabiocarneiro/orgs","repos_url":"https://api.github.com/users/fabiocarneiro/repos","events_url":"https://api.github.com/users/fabiocarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocarneiro/received_events","type":"User","site_admin":false},"repo":{"id":26459058,"name":"doctrine2","full_name":"fabiocarneiro/doctrine2","owner":{"login":"fabiocarneiro","id":1375034,"avatar_url":"https://avatars.githubusercontent.com/u/1375034?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiocarneiro","html_url":"https://github.com/fabiocarneiro","followers_url":"https://api.github.com/users/fabiocarneiro/followers","following_url":"https://api.github.com/users/fabiocarneiro/following{/other_user}","gists_url":"https://api.github.com/users/fabiocarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocarneiro/subscriptions","organizations_url":"https://api.github.com/users/fabiocarneiro/orgs","repos_url":"https://api.github.com/users/fabiocarneiro/repos","events_url":"https://api.github.com/users/fabiocarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocarneiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabiocarneiro/doctrine2","description":"Doctrine 2 Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/fabiocarneiro/doctrine2","forks_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/forks","keys_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/teams","hooks_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/events","assignees_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/tags","blobs_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/languages","stargazers_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/subscription","commits_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/issues/comments/{number}","contents_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/merges","archive_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/downloads","issues_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/fabiocarneiro/doctrine2/releases{/id}","created_at":"2014-11-10T22:34:19Z","updated_at":"2014-11-10T22:36:00Z","pushed_at":"2014-11-10T22:38:19Z","git_url":"git://github.com/fabiocarneiro/doctrine2.git","ssh_url":"git@github.com:fabiocarneiro/doctrine2.git","clone_url":"https://github.com/fabiocarneiro/doctrine2.git","svn_url":"https://github.com/fabiocarneiro/doctrine2","homepage":"http://www.doctrine-project.org","size":44711,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"76e1a469ef3c4af4ef9d60c769822d4283809217","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":597887,"name":"doctrine2","full_name":"doctrine/doctrine2","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/doctrine2","description":"Doctrine 2 Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/doctrine/doctrine2","forks_url":"https://api.github.com/repos/doctrine/doctrine2/forks","keys_url":"https://api.github.com/repos/doctrine/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/doctrine2/teams","hooks_url":"https://api.github.com/repos/doctrine/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/doctrine/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/doctrine2/events","assignees_url":"https://api.github.com/repos/doctrine/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/doctrine2/tags","blobs_url":"https://api.github.com/repos/doctrine/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/doctrine2/languages","stargazers_url":"https://api.github.com/repos/doctrine/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/doctrine/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/doctrine/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/doctrine/doctrine2/subscription","commits_url":"https://api.github.com/repos/doctrine/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/doctrine2/issues/comments/{number}","contents_url":"https://api.github.com/repos/doctrine/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/doctrine2/merges","archive_url":"https://api.github.com/repos/doctrine/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/doctrine2/downloads","issues_url":"https://api.github.com/repos/doctrine/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/doctrine2/releases{/id}","created_at":"2010-04-06T21:42:59Z","updated_at":"2014-11-07T15:50:24Z","pushed_at":"2014-11-05T12:19:31Z","git_url":"git://github.com/doctrine/doctrine2.git","ssh_url":"git@github.com:doctrine/doctrine2.git","clone_url":"https://github.com/doctrine/doctrine2.git","svn_url":"https://github.com/doctrine/doctrine2","homepage":"http://www.doctrine-project.org","size":44711,"stargazers_count":2321,"watchers_count":2321,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1125,"mirror_url":null,"open_issues_count":56,"forks":1125,"open_issues":56,"watchers":2321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/1179"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/1179"},"issue":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/1179"},"comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/1179/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/1179/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/1179/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/doctrine2/statuses/0692a099563ffc8353e3c3872836b427b362e5c0"}}}}