GitHub PullRequestReviewCommentEvent at 2014-05-28 02:21:49
Repository: gaia
Actor: steveck-chung
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/13113408","id":13113408,"diff_hunk":"@@ -206,15 +209,24 @@ var VIEWS = {\n         localize(this.status, 'message-status-' + message.delivery);\n \n         // Set different layout/value for received and sent message\n-        if (message.delivery === 'received' ||\n-            message.delivery === 'not-downloaded') {\n-          this.container.classList.add('received');\n-          localize(this.contactTitle, 'report-from');\n+        this.container.classList.toggle('received', isIncoming);\n+\n+        // If incoming message is migrated from the database where sentTimestamp\n+        // hadn't been supported yet then we won't have valid value for it.\n+        this.container.classList.toggle(\n+          'no-valid-sent-timestamp',\n+          isIncoming && !message.sentTimestamp\n+        );\n+\n+        localize(\n+          this.contactTitle,\n+          isIncoming ? 'report-from' : 'report-recipients'","path":"apps/sms/js/information.js","position":29,"original_position":29,"commit_id":"d22cfec7aa8b0fe148dcfd72860ab09c484f08a2","original_commit_id":"d22cfec7aa8b0fe148dcfd72860ab09c484f08a2","user":{"login":"steveck-chung","id":1704452,"avatar_url":"https://avatars.githubusercontent.com/u/1704452?","gravatar_id":"0e719389c6f6e17e5693819fc9a5722a","url":"https://api.github.com/users/steveck-chung","html_url":"https://github.com/steveck-chung","followers_url":"https://api.github.com/users/steveck-chung/followers","following_url":"https://api.github.com/users/steveck-chung/following{/other_user}","gists_url":"https://api.github.com/users/steveck-chung/gists{/gist_id}","starred_url":"https://api.github.com/users/steveck-chung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveck-chung/subscriptions","organizations_url":"https://api.github.com/users/steveck-chung/orgs","repos_url":"https://api.github.com/users/steveck-chung/repos","events_url":"https://api.github.com/users/steveck-chung/events{/privacy}","received_events_url":"https://api.github.com/users/steveck-chung/received_events","type":"User","site_admin":false},"body":"ok, it's really just matter of syntax here, and I'm fine with this :) If this block would be executed frequently, maybe less statement would be better(but definitely not this case)","created_at":"2014-05-28T02:21:49Z","updated_at":"2014-05-28T02:21:49Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/19556#discussion_r13113408","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/19556","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/13113408"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/19556#discussion_r13113408"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/19556"}}}}