GitHub PullRequestReviewCommentEvent at 2014-03-20 21:30:09
Repository: postpone
Actor: lsvx
Payload: {"comment":{"url":"https://api.github.com/repos/lsvx/postpone/pulls/comments/10817482","id":10817482,"diff_hunk":"@@ -446,6 +446,15 @@\n             }\n         }\n \n+        else if ( el.tagName.toLowerCase() === \"object\" && el.getAttribute( \"data-data\" )) {\n+            el.setAttribute( \"data\", el.getAttribute( \"data-data\" ));\n+\n+            // This is necessary to make Safari (and, apparently, old versions of Chrome)\n+            // re-render the new content; see:\n+            // stackoverflow.com/questions/11245385/object-works-in-every-browser-except-google-chrome\n+            el.innerHTML = el.innerHTML;","path":"index.js","position":19,"original_position":19,"commit_id":"56d8ef2ab34b3d69bfe5d608e058eca26b176837","original_commit_id":"56d8ef2ab34b3d69bfe5d608e058eca26b176837","user":{"login":"lsvx","id":1369275,"avatar_url":"https://avatars.githubusercontent.com/u/1369275?","gravatar_id":"e902a66c879e7186354b303a5521218f","url":"https://api.github.com/users/lsvx","html_url":"https://github.com/lsvx","followers_url":"https://api.github.com/users/lsvx/followers","following_url":"https://api.github.com/users/lsvx/following{/other_user}","gists_url":"https://api.github.com/users/lsvx/gists{/gist_id}","starred_url":"https://api.github.com/users/lsvx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsvx/subscriptions","organizations_url":"https://api.github.com/users/lsvx/orgs","repos_url":"https://api.github.com/users/lsvx/repos","events_url":"https://api.github.com/users/lsvx/events{/privacy}","received_events_url":"https://api.github.com/users/lsvx/received_events","type":"User","site_admin":false},"body":"@pabloz-globant,\r\nThis looks great. The only suggestion I have is if you could please change the commenting style to look as follows:\r\n````javascript\r\n/**\r\n * This is necessary to make Safari (and, apparently, old versions of Chrome)\r\n * re-render the new content; see:\r\n * stackoverflow.com/questions/11245385/object-works-in-every-browser-except-google-chrome\r\n */\r\n````","created_at":"2014-03-20T21:30:09Z","updated_at":"2014-03-20T21:30:09Z","html_url":"https://github.com/lsvx/postpone/pull/4#discussion_r10817482","pull_request_url":"https://api.github.com/repos/lsvx/postpone/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/lsvx/postpone/pulls/comments/10817482"},"html":{"href":"https://github.com/lsvx/postpone/pull/4#discussion_r10817482"},"pull_request":{"href":"https://api.github.com/repos/lsvx/postpone/pulls/4"}}}}