GitHub PullRequestReviewCommentEvent at 2014-07-21 15:00:29
Repository: clearance
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments/15173217","id":15173217,"diff_hunk":"@@ -1,28 +1,28 @@\n-require 'spec_helper'\n+require \"spec_helper\"\n \n-feature 'Visitor signs up' do\n-  scenario 'by navigating to the page' do\n+feature \"Visitor signs up\" do\n+  scenario \"by navigating to the page\" do\n     visit sign_in_path\n \n-    click_link I18n.t('sessions.form.sign_up')\n+    click_link I18n.t(\"sessions.form.sign_up\")\n \n-    current_path.should eq sign_up_path\n+    expect(current_path).to eq sign_up_path\n   end\n \n-  scenario 'with valid email and password' do\n-    sign_up_with 'valid@example.com', 'password'\n+  scenario \"with valid email and password\" do\n+    sign_up_with \"valid@example.com\", \"password\"\n \n     user_should_be_signed_in\n   end\n \n-  scenario 'tries with invalid email' do\n-    sign_up_with 'invalid_email', 'password'\n+  scenario \"tries with invalid email\" do","path":"lib/generators/clearance/specs/templates/features/clearance/visitor_signs_up_spec.rb","position":27,"original_position":27,"commit_id":"deb08058f1e1c696d38d417ed1657f41a023808a","original_commit_id":"deb08058f1e1c696d38d417ed1657f41a023808a","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer single-quoted strings when you don't need string interpolation or special symbols.","created_at":"2014-07-21T15:00:29Z","updated_at":"2014-07-21T15:00:29Z","html_url":"https://github.com/thoughtbot/clearance/pull/445#discussion_r15173217","pull_request_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/445","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments/15173217"},"html":{"href":"https://github.com/thoughtbot/clearance/pull/445#discussion_r15173217"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/clearance/pulls/445","id":18651350,"html_url":"https://github.com/thoughtbot/clearance/pull/445","diff_url":"https://github.com/thoughtbot/clearance/pull/445.diff","patch_url":"https://github.com/thoughtbot/clearance/pull/445.patch","issue_url":"https://api.github.com/repos/thoughtbot/clearance/issues/445","number":445,"state":"open","title":"Improve generated code","user":{"login":"georgebrock","id":35861,"avatar_url":"https://avatars.githubusercontent.com/u/35861?","gravatar_id":"46caf38e6cbc74005d6c643fd9186ef7","url":"https://api.github.com/users/georgebrock","html_url":"https://github.com/georgebrock","followers_url":"https://api.github.com/users/georgebrock/followers","following_url":"https://api.github.com/users/georgebrock/following{/other_user}","gists_url":"https://api.github.com/users/georgebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebrock/subscriptions","organizations_url":"https://api.github.com/users/georgebrock/orgs","repos_url":"https://api.github.com/users/georgebrock/repos","events_url":"https://api.github.com/users/georgebrock/events{/privacy}","received_events_url":"https://api.github.com/users/georgebrock/received_events","type":"User","site_admin":false},"body":"As discussed on #439, the thoughtbot style guide has changed since the clearance generators were written, so the generated code no longer follows the guide and causes a lot of warnings from @houndci.\r\n\r\nThis PR fixes three categories of style guide violations, and means the generators can be run without any complaints from our faithful hound:\r\n\r\n* Single quoted strings, where we now prefer double quoted strings.\r\n* Missing blank lines at the end of files.\r\n* Using RSpec's `should` syntax, where we now prefer the `expect` syntax (hound doesn't pick this up yet).\r\n\r\nI used these PRs to check hound's reaction to the changes:\r\n\r\n* From master (currently b2f4b240a8ee2dbb1e8679274aa188629f2e3796): https://github.com/georgebrock/clearancetest/pull/2\r\n* From this branch: https://github.com/georgebrock/clearancetest/pull/3","created_at":"2014-07-21T12:39:47Z","updated_at":"2014-07-21T15:00:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c272cec34a37bc54c0cadaf8d2220f4f91ce3037","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/445/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/445/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thoughtbot/clearance/issues/445/comments","statuses_url":"https://api.github.com/repos/thoughtbot/clearance/statuses/deb08058f1e1c696d38d417ed1657f41a023808a","head":{"label":"thoughtbot:gb-improve-generated-code","ref":"gb-improve-generated-code","sha":"deb08058f1e1c696d38d417ed1657f41a023808a","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?","gravatar_id":"a95a04df2dae60397c38c9bd04492c53","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":56125,"name":"clearance","full_name":"thoughtbot/clearance","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?","gravatar_id":"a95a04df2dae60397c38c9bd04492c53","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/clearance","description":"Rails authentication with email & password.","fork":false,"url":"https://api.github.com/repos/thoughtbot/clearance","forks_url":"https://api.github.com/repos/thoughtbot/clearance/forks","keys_url":"https://api.github.com/repos/thoughtbot/clearance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/clearance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/clearance/teams","hooks_url":"https://api.github.com/repos/thoughtbot/clearance/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/clearance/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/clearance/events","assignees_url":"https://api.github.com/repos/thoughtbot/clearance/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/clearance/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/clearance/tags","blobs_url":"https://api.github.com/repos/thoughtbot/clearance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/clearance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/clearance/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/clearance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/clearance/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/clearance/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/clearance/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/clearance/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/clearance/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/clearance/subscription","commits_url":"https://api.github.com/repos/thoughtbot/clearance/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/clearance/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/clearance/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/clearance/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/clearance/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/clearance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/clearance/merges","archive_url":"https://api.github.com/repos/thoughtbot/clearance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/clearance/downloads","issues_url":"https://api.github.com/repos/thoughtbot/clearance/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/clearance/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/clearance/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/clearance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/clearance/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/clearance/releases{/id}","created_at":"2008-09-24T19:57:58Z","updated_at":"2014-07-18T05:56:03Z","pushed_at":"2014-07-21T15:00:13Z","git_url":"git://github.com/thoughtbot/clearance.git","ssh_url":"git@github.com:thoughtbot/clearance.git","clone_url":"https://github.com/thoughtbot/clearance.git","svn_url":"https://github.com/thoughtbot/clearance","homepage":"","size":12810,"stargazers_count":1503,"watchers_count":1503,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":222,"mirror_url":null,"open_issues_count":11,"forks":222,"open_issues":11,"watchers":1503,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"b2f4b240a8ee2dbb1e8679274aa188629f2e3796","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?","gravatar_id":"a95a04df2dae60397c38c9bd04492c53","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":56125,"name":"clearance","full_name":"thoughtbot/clearance","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?","gravatar_id":"a95a04df2dae60397c38c9bd04492c53","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/clearance","description":"Rails authentication with email & password.","fork":false,"url":"https://api.github.com/repos/thoughtbot/clearance","forks_url":"https://api.github.com/repos/thoughtbot/clearance/forks","keys_url":"https://api.github.com/repos/thoughtbot/clearance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/clearance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/clearance/teams","hooks_url":"https://api.github.com/repos/thoughtbot/clearance/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/clearance/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/clearance/events","assignees_url":"https://api.github.com/repos/thoughtbot/clearance/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/clearance/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/clearance/tags","blobs_url":"https://api.github.com/repos/thoughtbot/clearance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/clearance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/clearance/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/clearance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/clearance/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/clearance/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/clearance/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/clearance/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/clearance/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/clearance/subscription","commits_url":"https://api.github.com/repos/thoughtbot/clearance/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/clearance/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/clearance/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/clearance/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/clearance/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/clearance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/clearance/merges","archive_url":"https://api.github.com/repos/thoughtbot/clearance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/clearance/downloads","issues_url":"https://api.github.com/repos/thoughtbot/clearance/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/clearance/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/clearance/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/clearance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/clearance/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/clearance/releases{/id}","created_at":"2008-09-24T19:57:58Z","updated_at":"2014-07-18T05:56:03Z","pushed_at":"2014-07-21T15:00:13Z","git_url":"git://github.com/thoughtbot/clearance.git","ssh_url":"git@github.com:thoughtbot/clearance.git","clone_url":"https://github.com/thoughtbot/clearance.git","svn_url":"https://github.com/thoughtbot/clearance","homepage":"","size":12810,"stargazers_count":1503,"watchers_count":1503,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":222,"mirror_url":null,"open_issues_count":11,"forks":222,"open_issues":11,"watchers":1503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/445"},"html":{"href":"https://github.com/thoughtbot/clearance/pull/445"},"issue":{"href":"https://api.github.com/repos/thoughtbot/clearance/issues/445"},"comments":{"href":"https://api.github.com/repos/thoughtbot/clearance/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/clearance/statuses/deb08058f1e1c696d38d417ed1657f41a023808a"}}}}