GitHub PullRequestReviewCommentEvent at 2014-12-18 16:58:51
Repository: bitters
Actor: kylefiedler
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/bitters/pulls/comments/22054695","id":22054695,"diff_hunk":"@@ -26,29 +21,14 @@ $dark-gray: #333;\n $medium-gray: #999;\n $light-gray: #DDD;\n \n-// Background Color\n-$base-background-color: white;\n-\n // Font Colors\n $base-font-color: $dark-gray;\n $base-accent-color: $blue;\n \n-// Link Colors\n-$base-link-color: $base-accent-color;","path":"app/assets/stylesheets/_variables.scss","position":33,"original_position":33,"commit_id":"dfaa3e4d9d8129402b5adc3a5b25010184ad5b89","original_commit_id":"dfaa3e4d9d8129402b5adc3a5b25010184ad5b89","user":{"login":"kylefiedler","id":223180,"avatar_url":"https://avatars.githubusercontent.com/u/223180?v=3","gravatar_id":"","url":"https://api.github.com/users/kylefiedler","html_url":"https://github.com/kylefiedler","followers_url":"https://api.github.com/users/kylefiedler/followers","following_url":"https://api.github.com/users/kylefiedler/following{/other_user}","gists_url":"https://api.github.com/users/kylefiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/kylefiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylefiedler/subscriptions","organizations_url":"https://api.github.com/users/kylefiedler/orgs","repos_url":"https://api.github.com/users/kylefiedler/repos","events_url":"https://api.github.com/users/kylefiedler/events{/privacy}","received_events_url":"https://api.github.com/users/kylefiedler/received_events","type":"User","site_admin":false},"body":"Ok I can get behind that. I think we should then introduce a new color then so that the meaning behind them is clear. I think since blue is the universal link color it should become the action color. Is there another color that would be good for `$base-accent-color`? If there isn't is there a reason we shouldn't do what @whmii said and drop `$base-accent-color`? ","created_at":"2014-12-18T16:58:51Z","updated_at":"2014-12-18T16:58:51Z","html_url":"https://github.com/thoughtbot/bitters/pull/141#discussion_r22054695","pull_request_url":"https://api.github.com/repos/thoughtbot/bitters/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/comments/22054695"},"html":{"href":"https://github.com/thoughtbot/bitters/pull/141#discussion_r22054695"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/bitters/pulls/141","id":26309408,"html_url":"https://github.com/thoughtbot/bitters/pull/141","diff_url":"https://github.com/thoughtbot/bitters/pull/141.diff","patch_url":"https://github.com/thoughtbot/bitters/pull/141.patch","issue_url":"https://api.github.com/repos/thoughtbot/bitters/issues/141","number":141,"state":"open","locked":false,"title":"Remove a bunch of redundancy in variables and header text styles","user":{"login":"kylefiedler","id":223180,"avatar_url":"https://avatars.githubusercontent.com/u/223180?v=3","gravatar_id":"","url":"https://api.github.com/users/kylefiedler","html_url":"https://github.com/kylefiedler","followers_url":"https://api.github.com/users/kylefiedler/followers","following_url":"https://api.github.com/users/kylefiedler/following{/other_user}","gists_url":"https://api.github.com/users/kylefiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/kylefiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylefiedler/subscriptions","organizations_url":"https://api.github.com/users/kylefiedler/orgs","repos_url":"https://api.github.com/users/kylefiedler/repos","events_url":"https://api.github.com/users/kylefiedler/events{/privacy}","received_events_url":"https://api.github.com/users/kylefiedler/received_events","type":"User","site_admin":false},"body":"These changes are to  simplify bitters and are opinionated based on building web applications and not web sites.\r\n\r\n* Remove header styles because they always get changed. The initial styles just add overhead to be changed. \r\n* Remove `blockquote` and `cite` styles. I've hardly ever used them and changed them when I have.\r\n* Create `$base-spacing-small` for all the places where we were using `$base-spacing / 2`\r\n* Remove unnecessary duplication in form variables.\r\n* Remove unnecessary duplication in link and button variables.\r\n* Remove `$base-background-color` as it rarely is used more than once.\r\n","created_at":"2014-12-18T15:50:01Z","updated_at":"2014-12-18T16:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13a23b3842275f12562c687cee82c04ef8d8216e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/bitters/pulls/141/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/bitters/pulls/141/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/bitters/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thoughtbot/bitters/issues/141/comments","statuses_url":"https://api.github.com/repos/thoughtbot/bitters/statuses/dfaa3e4d9d8129402b5adc3a5b25010184ad5b89","head":{"label":"thoughtbot:kf-remove-things","ref":"kf-remove-things","sha":"dfaa3e4d9d8129402b5adc3a5b25010184ad5b89","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":8143643,"name":"bitters","full_name":"thoughtbot/bitters","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/bitters","description":"Add a dash of pre-defined style to your Bourbon.","fork":false,"url":"https://api.github.com/repos/thoughtbot/bitters","forks_url":"https://api.github.com/repos/thoughtbot/bitters/forks","keys_url":"https://api.github.com/repos/thoughtbot/bitters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/bitters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/bitters/teams","hooks_url":"https://api.github.com/repos/thoughtbot/bitters/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/bitters/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/bitters/events","assignees_url":"https://api.github.com/repos/thoughtbot/bitters/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/bitters/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/bitters/tags","blobs_url":"https://api.github.com/repos/thoughtbot/bitters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/bitters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/bitters/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/bitters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/bitters/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/bitters/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/bitters/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/bitters/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/bitters/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/bitters/subscription","commits_url":"https://api.github.com/repos/thoughtbot/bitters/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/bitters/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/bitters/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/bitters/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/bitters/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/bitters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/bitters/merges","archive_url":"https://api.github.com/repos/thoughtbot/bitters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/bitters/downloads","issues_url":"https://api.github.com/repos/thoughtbot/bitters/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/bitters/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/bitters/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/bitters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/bitters/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/bitters/releases{/id}","created_at":"2013-02-11T18:24:43Z","updated_at":"2014-12-18T14:36:20Z","pushed_at":"2014-12-18T15:38:33Z","git_url":"git://github.com/thoughtbot/bitters.git","ssh_url":"git@github.com:thoughtbot/bitters.git","clone_url":"https://github.com/thoughtbot/bitters.git","svn_url":"https://github.com/thoughtbot/bitters","homepage":"http://bitters.bourbon.io","size":6531,"stargazers_count":761,"watchers_count":761,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":9,"forks":92,"open_issues":9,"watchers":761,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"b801e05efafc64ec0abf88800e30d82320e71deb","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":8143643,"name":"bitters","full_name":"thoughtbot/bitters","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/bitters","description":"Add a dash of pre-defined style to your Bourbon.","fork":false,"url":"https://api.github.com/repos/thoughtbot/bitters","forks_url":"https://api.github.com/repos/thoughtbot/bitters/forks","keys_url":"https://api.github.com/repos/thoughtbot/bitters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/bitters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/bitters/teams","hooks_url":"https://api.github.com/repos/thoughtbot/bitters/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/bitters/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/bitters/events","assignees_url":"https://api.github.com/repos/thoughtbot/bitters/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/bitters/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/bitters/tags","blobs_url":"https://api.github.com/repos/thoughtbot/bitters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/bitters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/bitters/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/bitters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/bitters/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/bitters/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/bitters/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/bitters/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/bitters/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/bitters/subscription","commits_url":"https://api.github.com/repos/thoughtbot/bitters/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/bitters/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/bitters/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/bitters/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/bitters/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/bitters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/bitters/merges","archive_url":"https://api.github.com/repos/thoughtbot/bitters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/bitters/downloads","issues_url":"https://api.github.com/repos/thoughtbot/bitters/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/bitters/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/bitters/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/bitters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/bitters/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/bitters/releases{/id}","created_at":"2013-02-11T18:24:43Z","updated_at":"2014-12-18T14:36:20Z","pushed_at":"2014-12-18T15:38:33Z","git_url":"git://github.com/thoughtbot/bitters.git","ssh_url":"git@github.com:thoughtbot/bitters.git","clone_url":"https://github.com/thoughtbot/bitters.git","svn_url":"https://github.com/thoughtbot/bitters","homepage":"http://bitters.bourbon.io","size":6531,"stargazers_count":761,"watchers_count":761,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":9,"forks":92,"open_issues":9,"watchers":761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/141"},"html":{"href":"https://github.com/thoughtbot/bitters/pull/141"},"issue":{"href":"https://api.github.com/repos/thoughtbot/bitters/issues/141"},"comments":{"href":"https://api.github.com/repos/thoughtbot/bitters/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/bitters/statuses/dfaa3e4d9d8129402b5adc3a5b25010184ad5b89"}}}}