GitHub PushEvent at 2014-04-07 19:45:34
Repository: liferay-portal
Actor: jhinkey
Payload: {"shas":[["1a3925f067ac2b9ff7cd1a8957a295561e2ca24d","87097d8a63a44cdeea44e8e9d70ad9a5c80173c1@liferay.com","LPS-45424 - macros","Ken Duenwald",false],["5e974fa20d2cf133e9f67cd6f1b86808db71dd68","87097d8a63a44cdeea44e8e9d70ad9a5c80173c1@liferay.com","LPS-45424 - tests","Ken Duenwald",false],["e848604e34cd45f7801c8f5ee2f491bdaa223bf4","5b4070af037257fd9c8192d7c85210e8c0d59ede@liferay.com","LPS-45400 - Message Boards missing language key for \"add-subcategory\"","Marc Lundgren",false],["beb68ecfa91bde32ba501e344a2d60db00bf84bb","19d87895fd866a870172ad2efba03013e296358f@liferay.com","LPS-45400 Lang keys","Brian Chan",false],["7750719235cb058039e8bb07e323a6a6cd9b0232","dd3d6ac69f865cb358666bc401542b10e4a98a1c@liferay.com","LPS-45107 Edit Breaking Change","Cody Hoag",false],["a85467604355256c4ab89a78963fcf942242c3a7","904dbb43dc55c827788b3abc62853148f1497e69@liferay.com","LPS-45107 Put change in ascending chronological order","Jim Hinkey",false],["0eec2d924947bf8f2aced7c8949c244f2682a168","d64d45fa76bc3a5749d7de1e386f9d418203753f@liferay.com","Test Fixes - ApplicationdisplaytemplateUsecase - actions, functions, paths","Evan Nagayama",false],["a3be086bd05c192e6a737c1ff9518b6b2b6d53e8","c7d0d843833f5711ba376020299f86bd12f1ae7f@liferay.com","LPS-45439 - macros","rsrisamang",false],["d776b6187ec99bd8b8f3f5999a7affa722cc5227","bfee8d13161ff1925345ccf6c0ed8fce7ec33424@liferay.com","Test Fixes - WebContent - macros","Koor Gai",false],["40526dff999666946fba06b879f840d215aacfcd","15597d1a58c88427bb8c8dfa5f004a1a41bb1c0c@liferay.com","SourceFormatter - fix incorrect line breaks","Hugo Huijser",false],["e72f13dea3de87971ad231ad247052dec0074339","15597d1a58c88427bb8c8dfa5f004a1a41bb1c0c@liferay.com","Source formatting - fix incorrect line breaks","Hugo Huijser",false],["2cc65d31e6092dd889f6823b91f43fead81befd6","e08cbd79395195632e44b8b8a687989f7caaa427@liferay.com","LPS-45322 Detect empty list of servlets","Igor Spasic",false],["8a5b9531658b759225ae4cddaa602c7769358af6","2dd881ad5c7d074428c71d1bec0484927ca65fc2@liferay.com","LPS-45365 Add ImageTool to TemplateContextHelper","Laszlo Csontos",false],["e69c80aa43be32a0cce169bbc825450d8d391c8a","4afa6c2cbdbd98b91ea1e6e35d8b301fb84ef364@liferay.com","LPS-44010 We need to deprecate this method because it's protected and there are plugins that are extending this class and overriding this method.","Sergio Gonzalez",false],["15d86a09686b29f340c7486726d2d4095688a7aa","4afa6c2cbdbd98b91ea1e6e35d8b301fb84ef364@liferay.com","LPS-44593 We don't need to infer the className and classPK for doing the permission checking based on the order of the method addPersistedSubscriber because that's ugly and very fragile. We should do the permission check based on the className and classPK attributes of the SubscriptionSender object. In order to keep backwards compatibility we have deprecated some methods by extracting the logic to a private method and in the future we can just get rid of the deprecated methods and replace them with the code in the private methods.","Sergio Gonzalez",false],["6d73622b843f1516590555bab08e574404588bf3","703d558a8bd8342b1c49b530d41b2232e8900138@liferay.com","LPS-44593 In wiki and message boards we are checking the containers permission (The subscribe permission). Should it be done in all entities with containers such DL, DLFET, Journal or Bookmarks??","Roberto Díaz",false],["0ac497ddb3898d078bae291709cd6943bd02f8b0","4afa6c2cbdbd98b91ea1e6e35d8b301fb84ef364@liferay.com","LPS-44593 Use get* instead of fetch* because if the entity doesn't exist it should throw an exception","Sergio Gonzalez",false],["b436155ef578c13b816d702dd73aa4fd48ede3f3","4afa6c2cbdbd98b91ea1e6e35d8b301fb84ef364@liferay.com","LPS-44593 Pass the object to avoid one extra query","Sergio Gonzalez",false],["50ef04ad5a9ab81a0c0a622355fbf9035f30d7a4","4afa6c2cbdbd98b91ea1e6e35d8b301fb84ef364@liferay.com","LPS-44593 I don't see in which case we may have a fileVersionId as a classPK","Sergio Gonzalez",false],["62cc5599d2e6abe7377aeaece2c43ee0681019fc","4afa6c2cbdbd98b91ea1e6e35d8b301fb84ef364@liferay.com","LPS-44593 We don't need to do permission checking on DLFileEntryType because it would only check for the Subscribe permission and this is not supported (we don't have any SUBSCRIBE permission on DLFileEntryType)","Sergio Gonzalez",false]],"size":748,"ref":"refs/heads/master","head":"4d39c26812dd0a6b521ae464f0f6db81d8e73c11"}