GitHub PushEvent at 2014-10-16 16:00:12
Repository: Koha
Actor: KohaAloha
Payload: {"shas":[["400b538078f9485afcbf4c4fcc4b40e59ec644d5","fcb656771c05194acd098372516da61a157bdf64@biblibre.com","BUG8446: Adds Shibboleth authentication\n\n - Use the shibbolethAuthentication syspref to enable Shibboleth authentication\n - Configure the shibbolethLoginAttribute to specify which shibboleth user\n   attribute matches the koha login\n - Make sure the OPACBaseURL is correctly set\n\nBUG8446, Follow-up: Adds Shibboleth authentication\n\n - Fix logout bug: shibboleth logout now occurs only when\n   the session is a shibboleth one.\n - Do some refactoring: getting shibboleth username is now\n   done in C4::Auth_with_Shibboleth.pm (get_login_shib function)\n\nBUG8446, Follow-up: Adds Shibboleth authentication\n\n - Adds redirect to opac after logout\n\nBUG8446, Follow-up: Adds Shibboleth authentication\n\n - Shibboleth is not compatible with basic http authentication\n   in C4/Auth.pm. This patch fixes that.\n\nBUG8446, Follow-up: Adds Shibboleth authentication\n\n - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with\n   multiple vhosts.\n\nBUG8446, Follow-up: Adds Shibboleth authentication\n\n - Adds missing protocol for $ENV{'SERVER_NAME'}\n\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Jesse Weaver <pianohacker@gmail.com>\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nTested with the feide idp.\n- LDAP login and logout are working\n- local login/logout are still working\n- CAS login/logout are still working\n\nInstructions for setup can be found on the wiki:\nhttp://wiki.koha-community.org/wiki/Shibboleth_Configuration\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Matthias Meusburger",true],["8e09a48e8cc38ced5263ad65d8287a8bb619e5dc","e328553c8782de72a55cb4ac905938926e626fa1@ptfs-europe.com","BUG8446, Follow up: Adds Shibboleth authentication\n\n- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont\n  work if koha is behind a reverse proxy.\n  - To use multiple vhosts, set OpacBaseURL per vhost explicitly with\n    'SetEnv OpacBaseURL Value' as per Bug 10325\n\nBUG8446, Follow up: Adds Shibboleth authentication\n\n- Ensure user is returned to requested page after authentication\n  - Added querystring to the target path in shibboleth URL so\n    that when a user is authenticated he/she is returned to the\n    correct page they requested before authentication.\n    Example where this is important: When a user clicks a direct\n    biblio link of the form - /opac-detail.pl?biblionumber=12345\n\nBUG8446, Follow up: Remove unused imports from scripts\n\n- Remove import of deprecated C4::Utils module from shibboleth\n  authentication module: Auth_with_shibboleth.pm\n\nSigned-off-by: Jesse Weaver <pianohacker@gmail.com>\nSigned-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Martin Renvoize",true],["244cfaba71223f1861e7e6efdc3ada0b8fef0af0","a28c0920e01f695d6ba5d30bfe030d9bb3a12af2@gmail.com","BUG8446, Follow up: Remove unnecessary sysprefs, move to config\n\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Jesse Weaver",true],["3c9004357d48944ce36d3964f7e6f1ba15702b71","e328553c8782de72a55cb4ac905938926e626fa1@ptfs-europe.com","BUG8446, Follow up: Improve local login fallback\n\n- Local fallback was not very well implemented, this patch adds\n  better handling for such cases allowing clearer failure messages\n- This patch also adds the ability to use single sign on via the\n  top bar menu in the bootstrap theme.\n\nBUG8446, Follow up: Adds perldoc documentation\n\n- Add some documentation to the Auth_with_Shibboleth module\n  including some guidance as to configuration.\n\nBUG8446, Follow up: Correct filenames to match guidlines\n\n- Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match\n  other files present on the system.\n\nBUG8446, Follow up: Correct paths after file rename\n\nBUG8446, Follow up: Implemented single sign out\n\n- This follow up rebases the code against 3.16+ which managed to break\n  some of the original logic.\n- As a side effect of the rebasing, we've also implemented the single\n  sign out element. Upon logout, koha will request that the shibboleth\n  session is destroyed, and then clear the local koha session upon\n  return to koha.  Due to the nature of shibboleth however, you will\n  only truly be signed out of the IdP if they properly support Single\n  Sign Out (which many do not). As a consequence, although you may\n  appear to be logged out in koha, you might find that upon clicking\n  'login' the IdP does NOT request your login details again, but instead\n  logs you silently back into your koha session. This is NOT a koha bug,\n  but a shibboleth implementation issue that is well known.\n\nBUG8446, Follow up: Fixed bootstrap login via modal\n\n- The bootstrap theme enable login from any opac page via modal. To\n  enable this with shibboleth we had to make some template parameters\n  globally accessible when shibboleth is enabled.\n\nBUG8446, Follow up: Add template rules for Shibboleth and CAS\n\n- Add template rules so that CAS and Shibboleth can coexist.\n\nBUG8446, Follow up: Added default config to config file\n\nBUG8446, Follow up: Embellished perldoc documentation\n\n- Updated perldoc to correct detail about configuring shibboleth\n  authentication.\n- Updated perldoc to include subroutines and their respective functions.\n\nBUG8446, Follow up: Enable configuration of match field\n\n- Added clearer, more flexible, configuration of shibboleth attribute to\n  koha borrower field matching for authentication\n- Correcting of documentation to make it more clear to the current\n  implementation\n- Minor refactoring of code to reduce some code duplication\n\nSigned-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Martin Renvoize",true],["ca86375872b1cc605918c33eb6c07ef85026ad4b","e328553c8782de72a55cb4ac905938926e626fa1@ptfs-europe.com","BUG8446, Follow up: Refactor to clean up bad practice\n\n- A number of issues were highlighted whilst writing sensible unit tests\n  for this module.\n  - Removed unnessesary call to context->new();\n  - Global variables are BAD!\n  - Croaking is a wimps way out, we should handle errors early and\n    properly.\n\nSigned-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Martin Renvoize",true],["e8240f8c2b256bca4f7b6557a788db6ae541c563","e328553c8782de72a55cb4ac905938926e626fa1@ptfs-europe.com","BUG8446, Follow up: Add Unit Tests\n\nSigned-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Martin Renvoize",true],["89ee1aeab745a27000f6f897e2c727391e29b851","e328553c8782de72a55cb4ac905938926e626fa1@ptfs-europe.com","BUG8446, QA Followup: Cleanup tabs and license\n\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Martin Renvoize",true],["31878e1973caa15b309001da8754a5d134f15513","e328553c8782de72a55cb4ac905938926e626fa1@ptfs-europe.com","BUG8446, QA Followup: Minor Code Tidies\n\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Martin Renvoize",true],["fb90f71f717e7adc39c4d6d0f6bdb100f05e4695","e328553c8782de72a55cb4ac905938926e626fa1@ptfs-europe.com","BUG8446, QA Followup: Use DBIx::Class\n\n- Convert Auth_with_shibboleth to use dbic stanzas.\n\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Martin Renvoize",true],["6d3f1c1caf1ff8bcc320684ff737ea03df921eb0","e328553c8782de72a55cb4ac905938926e626fa1@ptfs-europe.com","BUG8446, QA Followup: Add Test::DBIx::Class to dependancies\n\n- To correct tests after converting module to dbic, we need to add the\n  Test::DBIx::Class module as a dependancy.\n\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nThe dependency will probably need to be packaged by us until\nit can get into Debian proper.\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Martin Renvoize",true],["2d8362773069cda4d82e94827141a83c1843db4a","63ac9f6777fb741d62c33cd73a438a8ce82c7d4a@gmail.com","Bug 8446: (qa followup) Tests should be conditional on Test::DBIx::Class\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Tomas Cohen Arazi",true],["0df1c58f872679785b4f94fbb79ce4ec501070ec","63ac9f6777fb741d62c33cd73a438a8ce82c7d4a@gmail.com","Bug 8446: (qa followup) Patch reintroduces SolR stuff\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Tomas Cohen Arazi",true],["9b9b057c77ce982bf32ac797abfdd00f87102d75","9b6fec8bcc6d5cf17f097cbf67de7eafb364397f@gmail.com","Bug 12927: Problems with item information tab on acq order from staged page\n\nThis patch fixes a regression introduced (by me)\non Bug 12673.\n\nI adds the code needed to display properly all fields\n\nTo test:\n1) Check that 'AcqCreateItem' syspref is set to 'placing an order'\n2) Satage a file with some items\n3) Go to a Vendor, create a basket, clic add from staged file, select your file\n4) On 'Item information' tab fields are displayed wrong\n\n5) Apply the patch\n\n6) Reload, display must now be fixed\n\nSigned-off-by: Paola Rossi <paola.rossi@cineca.it>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Bernardo Gonzalez Kriegel",true],["e3099d7c597c4b8d1dc7b61bd9d0d0484cbb77a1","90effa772b5c8a7a3420e6b7ea56e265888c5743@biblibre.com","Bug 12646: Display all invoices on the same page\n\nOnly first 20 invoices were displayed on the page. Without pagination, DT\ndid not allow to show others.\nThis page explicitely removes the pagination option in order to display\nall invoices on the page.\n\nTest plan:\n1/ Create 21+ invoices\n2/ Go on acqui/invoices\n3/ Verify all invoices are displayed.\n\nSigned-off-by: Paola Rossi <paola.rossi@cineca.it>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>","Jonathan Druart",true]],"size":14,"ref":"refs/heads/master","head":"e3099d7c597c4b8d1dc7b61bd9d0d0484cbb77a1"}