GitHub PullRequestReviewCommentEvent at 2014-08-04 19:14:44
Repository: puppetdb
Actor: kbarber
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/15774777","id":15774777,"diff_hunk":"@@ -66,13 +74,13 @@\n   (case version\n     :v1 (throw (IllegalArgumentException. \"No support for v1 for facts end-point\"))\n     :v2 (build-facts-app\n-         (-> (query-app version)\n-             (validate-query-params\n-              {:optional [\"query\"]})))\n+          (-> (query-app version)","path":"src/com/puppetlabs/puppetdb/http/facts.clj","position":45,"original_position":45,"commit_id":"bac38bd0f2ac78200da933f1a2941d1ff4ca141f","original_commit_id":"bac38bd0f2ac78200da933f1a2941d1ff4ca141f","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=2","gravatar_id":"9accebe46504a4777d7b3c9707549dc6","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"body":"Wait, are our editors competing here? My editor indents this 1 space not 2.","created_at":"2014-08-04T19:14:44Z","updated_at":"2014-08-04T19:14:44Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1031#discussion_r15774777","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1031","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/15774777"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1031#discussion_r15774777"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1031"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1031","id":19229382,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1031","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1031.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1031.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1031","number":1031,"state":"open","title":"(PDB-772) Modify the facts endpoint to return structured facts","user":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=2","gravatar_id":"146e81d7436fbd540671823d5352efdc","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"body":"This pull request causes the v4 facts endpoint to return typed and structured\r\nfacts while leaving the v3 responses stringified as before.  It also adds a\r\n\"name\" column to the fact_paths table representing the first element of a\r\nfact's path.  This column should be renamed to \"fact\" in the future to avoid\r\nconfusion with the many references to 'certname' as name.","created_at":"2014-08-01T19:33:27Z","updated_at":"2014-08-04T19:14:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d92b7a432c03c9455da22ce251347cbfdae385a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1031/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1031/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1031/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/bac38bd0f2ac78200da933f1a2941d1ff4ca141f","head":{"label":"wkalt:ticket/master/pdb-772-change-facts","ref":"ticket/master/pdb-772-change-facts","sha":"bac38bd0f2ac78200da933f1a2941d1ff4ca141f","user":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=2","gravatar_id":"146e81d7436fbd540671823d5352efdc","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"repo":{"id":20931903,"name":"puppetdb","full_name":"wkalt/puppetdb","owner":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=2","gravatar_id":"146e81d7436fbd540671823d5352efdc","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkalt/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/wkalt/puppetdb","forks_url":"https://api.github.com/repos/wkalt/puppetdb/forks","keys_url":"https://api.github.com/repos/wkalt/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkalt/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkalt/puppetdb/teams","hooks_url":"https://api.github.com/repos/wkalt/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/wkalt/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/wkalt/puppetdb/events","assignees_url":"https://api.github.com/repos/wkalt/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/wkalt/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/wkalt/puppetdb/tags","blobs_url":"https://api.github.com/repos/wkalt/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkalt/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkalt/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkalt/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkalt/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/wkalt/puppetdb/languages","stargazers_url":"https://api.github.com/repos/wkalt/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/wkalt/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/wkalt/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/wkalt/puppetdb/subscription","commits_url":"https://api.github.com/repos/wkalt/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkalt/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkalt/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkalt/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/wkalt/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/wkalt/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkalt/puppetdb/merges","archive_url":"https://api.github.com/repos/wkalt/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkalt/puppetdb/downloads","issues_url":"https://api.github.com/repos/wkalt/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/wkalt/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/wkalt/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/wkalt/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkalt/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/wkalt/puppetdb/releases{/id}","created_at":"2014-06-17T16:54:41Z","updated_at":"2014-06-24T19:27:44Z","pushed_at":"2014-08-04T18:14:04Z","git_url":"git://github.com/wkalt/puppetdb.git","ssh_url":"git@github.com:wkalt/puppetdb.git","clone_url":"https://github.com/wkalt/puppetdb.git","svn_url":"https://github.com/wkalt/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":10737,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"3aa1083e2cfd09c5d190af91d6f66b5b547c2e1f","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2014-06-30T10:53:36Z","pushed_at":"2014-08-01T16:54:09Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":17611,"stargazers_count":141,"watchers_count":141,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":104,"mirror_url":null,"open_issues_count":3,"forks":104,"open_issues":3,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1031"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1031"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1031"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1031/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1031/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1031/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/bac38bd0f2ac78200da933f1a2941d1ff4ca141f"}}}}