GitHub PullRequestReviewCommentEvent at 2014-10-29 17:26:29
Repository: puppet-rjil
Actor: bodepd
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/19555494","id":19555494,"diff_hunk":"@@ -0,0 +1,128 @@\n+#\n+# Class: rjil::nova::controller\n+#   To setup nova controller\n+class rjil::nova::controller (\n+  $rpc_backend          = 'zmq',\n+  $rpc_zmq_bind_address = '*',\n+  $rpc_zmq_contexts     = 1,\n+  $rpc_zmq_matchmaker   = 'oslo.messaging._drivers.matchmaker_ring.MatchMakerRing',\n+  $rpc_zmq_port         = 9501,\n+  $api_bind_port        = 8774,\n+  $vncproxy_bind_port   = 6080,\n+) {\n+\n+# Tests\n+  include rjil::test::nova_controller\n+\n+  ##\n+  # Adding service blocker for mysql which make sure mysql is avaiable before\n+  # database configuration.\n+  ##\n+\n+  ensure_resource( 'rjil::service_blocker', 'mysql', {})\n+  Rjil::Service_blocker['mysql'] ->\n+  Nova_config<| title == 'database/connection' |>\n+\n+  ##\n+  # db_sync fail if nova-manage.log is writable by nova user, so making the file\n+  # with appropriate ownership before setup database configuration.\n+  ##\n+\n+  File['/var/log/nova/nova-manage.log'] ->\n+  Nova_config<| title == 'database/connection' |>","path":"manifests/nova/controller.pp","position":32,"original_position":32,"commit_id":"29fe237d14d974c5fcb769e4278f1bae71d3ce50","original_commit_id":"29fe237d14d974c5fcb769e4278f1bae71d3ce50","user":{"login":"bodepd","id":97123,"avatar_url":"https://avatars.githubusercontent.com/u/97123?v=2","gravatar_id":"","url":"https://api.github.com/users/bodepd","html_url":"https://github.com/bodepd","followers_url":"https://api.github.com/users/bodepd/followers","following_url":"https://api.github.com/users/bodepd/following{/other_user}","gists_url":"https://api.github.com/users/bodepd/gists{/gist_id}","starred_url":"https://api.github.com/users/bodepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodepd/subscriptions","organizations_url":"https://api.github.com/users/bodepd/orgs","repos_url":"https://api.github.com/users/bodepd/repos","events_url":"https://api.github.com/users/bodepd/events{/privacy}","received_events_url":"https://api.github.com/users/bodepd/received_events","type":"User","site_admin":false},"body":"it would be great to also see an upstream issue and perhaps a patch for this.","created_at":"2014-10-29T17:26:29Z","updated_at":"2014-10-29T17:26:29Z","html_url":"https://github.com/JioCloud/puppet-rjil/pull/139#discussion_r19555494","pull_request_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/19555494"},"html":{"href":"https://github.com/JioCloud/puppet-rjil/pull/139#discussion_r19555494"},"pull_request":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/139","id":23525584,"html_url":"https://github.com/JioCloud/puppet-rjil/pull/139","diff_url":"https://github.com/JioCloud/puppet-rjil/pull/139.diff","patch_url":"https://github.com/JioCloud/puppet-rjil/pull/139.patch","issue_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/139","number":139,"state":"open","locked":false,"title":"Nova","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=2","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"body":"WIP .. all nova controller code works on single node (single OC) for now.","created_at":"2014-10-29T12:11:03Z","updated_at":"2014-10-29T17:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7fba3ed994f3bfabf00272e851f987c72a61a0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/139/commits","review_comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/139/comments","review_comment_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/139/comments","statuses_url":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/29fe237d14d974c5fcb769e4278f1bae71d3ce50","head":{"label":"hkumarmk:nova","ref":"nova","sha":"29fe237d14d974c5fcb769e4278f1bae71d3ce50","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=2","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"repo":{"id":23566380,"name":"puppet-rjil","full_name":"hkumarmk/puppet-rjil","owner":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=2","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkumarmk/puppet-rjil","description":"","fork":true,"url":"https://api.github.com/repos/hkumarmk/puppet-rjil","forks_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/forks","keys_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/teams","hooks_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/hooks","issue_events_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/issues/events{/number}","events_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/events","assignees_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/assignees{/user}","branches_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/branches{/branch}","tags_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/tags","blobs_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/statuses/{sha}","languages_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/languages","stargazers_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/stargazers","contributors_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/contributors","subscribers_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/subscribers","subscription_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/subscription","commits_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/issues/comments/{number}","contents_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/contents/{+path}","compare_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/merges","archive_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/downloads","issues_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/issues{/number}","pulls_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/pulls{/number}","milestones_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/milestones{/number}","notifications_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/labels{/name}","releases_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/releases{/id}","created_at":"2014-09-02T05:36:38Z","updated_at":"2014-08-14T10:22:52Z","pushed_at":"2014-10-29T12:09:49Z","git_url":"git://github.com/hkumarmk/puppet-rjil.git","ssh_url":"git@github.com:hkumarmk/puppet-rjil.git","clone_url":"https://github.com/hkumarmk/puppet-rjil.git","svn_url":"https://github.com/hkumarmk/puppet-rjil","homepage":null,"size":1111,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JioCloud:master","ref":"master","sha":"867fbb8c068b31301f8186bf77863b0a1684c14d","user":{"login":"JioCloud","id":5500757,"avatar_url":"https://avatars.githubusercontent.com/u/5500757?v=2","gravatar_id":"","url":"https://api.github.com/users/JioCloud","html_url":"https://github.com/JioCloud","followers_url":"https://api.github.com/users/JioCloud/followers","following_url":"https://api.github.com/users/JioCloud/following{/other_user}","gists_url":"https://api.github.com/users/JioCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/JioCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JioCloud/subscriptions","organizations_url":"https://api.github.com/users/JioCloud/orgs","repos_url":"https://api.github.com/users/JioCloud/repos","events_url":"https://api.github.com/users/JioCloud/events{/privacy}","received_events_url":"https://api.github.com/users/JioCloud/received_events","type":"Organization","site_admin":false},"repo":{"id":16161513,"name":"puppet-rjil","full_name":"JioCloud/puppet-rjil","owner":{"login":"JioCloud","id":5500757,"avatar_url":"https://avatars.githubusercontent.com/u/5500757?v=2","gravatar_id":"","url":"https://api.github.com/users/JioCloud","html_url":"https://github.com/JioCloud","followers_url":"https://api.github.com/users/JioCloud/followers","following_url":"https://api.github.com/users/JioCloud/following{/other_user}","gists_url":"https://api.github.com/users/JioCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/JioCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JioCloud/subscriptions","organizations_url":"https://api.github.com/users/JioCloud/orgs","repos_url":"https://api.github.com/users/JioCloud/repos","events_url":"https://api.github.com/users/JioCloud/events{/privacy}","received_events_url":"https://api.github.com/users/JioCloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JioCloud/puppet-rjil","description":"","fork":false,"url":"https://api.github.com/repos/JioCloud/puppet-rjil","forks_url":"https://api.github.com/repos/JioCloud/puppet-rjil/forks","keys_url":"https://api.github.com/repos/JioCloud/puppet-rjil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JioCloud/puppet-rjil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JioCloud/puppet-rjil/teams","hooks_url":"https://api.github.com/repos/JioCloud/puppet-rjil/hooks","issue_events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/events{/number}","events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/events","assignees_url":"https://api.github.com/repos/JioCloud/puppet-rjil/assignees{/user}","branches_url":"https://api.github.com/repos/JioCloud/puppet-rjil/branches{/branch}","tags_url":"https://api.github.com/repos/JioCloud/puppet-rjil/tags","blobs_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/refs{/sha}","trees_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/{sha}","languages_url":"https://api.github.com/repos/JioCloud/puppet-rjil/languages","stargazers_url":"https://api.github.com/repos/JioCloud/puppet-rjil/stargazers","contributors_url":"https://api.github.com/repos/JioCloud/puppet-rjil/contributors","subscribers_url":"https://api.github.com/repos/JioCloud/puppet-rjil/subscribers","subscription_url":"https://api.github.com/repos/JioCloud/puppet-rjil/subscription","commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/commits{/sha}","git_commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/commits{/sha}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/comments{/number}","issue_comment_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/comments/{number}","contents_url":"https://api.github.com/repos/JioCloud/puppet-rjil/contents/{+path}","compare_url":"https://api.github.com/repos/JioCloud/puppet-rjil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JioCloud/puppet-rjil/merges","archive_url":"https://api.github.com/repos/JioCloud/puppet-rjil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JioCloud/puppet-rjil/downloads","issues_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues{/number}","pulls_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls{/number}","milestones_url":"https://api.github.com/repos/JioCloud/puppet-rjil/milestones{/number}","notifications_url":"https://api.github.com/repos/JioCloud/puppet-rjil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JioCloud/puppet-rjil/labels{/name}","releases_url":"https://api.github.com/repos/JioCloud/puppet-rjil/releases{/id}","created_at":"2014-01-23T03:45:55Z","updated_at":"2014-09-19T11:28:56Z","pushed_at":"2014-10-29T10:28:30Z","git_url":"git://github.com/JioCloud/puppet-rjil.git","ssh_url":"git@github.com:JioCloud/puppet-rjil.git","clone_url":"https://github.com/JioCloud/puppet-rjil.git","svn_url":"https://github.com/JioCloud/puppet-rjil","homepage":null,"size":2750,"stargazers_count":1,"watchers_count":1,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/139"},"html":{"href":"https://github.com/JioCloud/puppet-rjil/pull/139"},"issue":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/139"},"comments":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/29fe237d14d974c5fcb769e4278f1bae71d3ce50"}}}}