GitHub PullRequestEvent at 2014-11-13 15:07:18
Repository: qucs
Actor: yodalee
Payload: {"action":"closed","number":113,"pull_request":{"url":"https://api.github.com/repos/Qucs/qucs/pulls/113","id":24226168,"html_url":"https://github.com/Qucs/qucs/pull/113","diff_url":"https://github.com/Qucs/qucs/pull/113.diff","patch_url":"https://github.com/Qucs/qucs/pull/113.patch","issue_url":"https://api.github.com/repos/Qucs/qucs/issues/113","number":113,"state":"closed","locked":false,"title":"Move qucssetting to singleton","user":{"login":"yodalee","id":1913143,"avatar_url":"https://avatars.githubusercontent.com/u/1913143?v=3","gravatar_id":"","url":"https://api.github.com/users/yodalee","html_url":"https://github.com/yodalee","followers_url":"https://api.github.com/users/yodalee/followers","following_url":"https://api.github.com/users/yodalee/following{/other_user}","gists_url":"https://api.github.com/users/yodalee/gists{/gist_id}","starred_url":"https://api.github.com/users/yodalee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodalee/subscriptions","organizations_url":"https://api.github.com/users/yodalee/orgs","repos_url":"https://api.github.com/users/yodalee/repos","events_url":"https://api.github.com/users/yodalee/events{/privacy}","received_events_url":"https://api.github.com/users/yodalee/received_events","type":"User","site_admin":false},"body":"This is a big modification.\r\nThe QucsSettings is actually quite annoying, and is not a good implementation.\r\nHere I move setting to a singleton class, all the property is saved in QVariant.\r\n(IT TOOK ME SO MANY TIME TO EXTRACT ALL THE QUCSSETTINGS AND CHANGE THEM TO SINGLETON CLASS, the qucs is a horrible mess I think O口O)\r\nYou can use:\r\n```\r\nset(section, key, value)\r\nget(section, key)\r\ntestSet(section, key)\r\n```\r\nto access the data.\r\nSince the data stored in QVariant, so after you call get, you have to cast it to the datatype you want, like:\r\n```\r\nget(\"a\", \"b\").toString()\r\n```\r\nSetting will be initialized in main.cpp and other require setting just include setting.h, every time you call `set`, the change will write to file directly, so savesetting at end is no more needed.\r\n******\r\nSince this is a large modification, I suggest to make it a branch for a while and accept comment and patch from everyone.","created_at":"2014-11-11T15:25:19Z","updated_at":"2014-11-13T15:07:17Z","closed_at":"2014-11-13T15:07:17Z","merged_at":null,"merge_commit_sha":"6fe3017e98ae3b46f7edefdb775e69141672adee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Qucs/qucs/pulls/113/commits","review_comments_url":"https://api.github.com/repos/Qucs/qucs/pulls/113/comments","review_comment_url":"https://api.github.com/repos/Qucs/qucs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Qucs/qucs/issues/113/comments","statuses_url":"https://api.github.com/repos/Qucs/qucs/statuses/9d5efa136bcb2d9b68996cec433a66f59571e6e8","head":{"label":"yodalee:move-qucssetting-to-singleton","ref":"move-qucssetting-to-singleton","sha":"9d5efa136bcb2d9b68996cec433a66f59571e6e8","user":{"login":"yodalee","id":1913143,"avatar_url":"https://avatars.githubusercontent.com/u/1913143?v=3","gravatar_id":"","url":"https://api.github.com/users/yodalee","html_url":"https://github.com/yodalee","followers_url":"https://api.github.com/users/yodalee/followers","following_url":"https://api.github.com/users/yodalee/following{/other_user}","gists_url":"https://api.github.com/users/yodalee/gists{/gist_id}","starred_url":"https://api.github.com/users/yodalee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodalee/subscriptions","organizations_url":"https://api.github.com/users/yodalee/orgs","repos_url":"https://api.github.com/users/yodalee/repos","events_url":"https://api.github.com/users/yodalee/events{/privacy}","received_events_url":"https://api.github.com/users/yodalee/received_events","type":"User","site_admin":false},"repo":{"id":19541807,"name":"qucs","full_name":"yodalee/qucs","owner":{"login":"yodalee","id":1913143,"avatar_url":"https://avatars.githubusercontent.com/u/1913143?v=3","gravatar_id":"","url":"https://api.github.com/users/yodalee","html_url":"https://github.com/yodalee","followers_url":"https://api.github.com/users/yodalee/followers","following_url":"https://api.github.com/users/yodalee/following{/other_user}","gists_url":"https://api.github.com/users/yodalee/gists{/gist_id}","starred_url":"https://api.github.com/users/yodalee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodalee/subscriptions","organizations_url":"https://api.github.com/users/yodalee/orgs","repos_url":"https://api.github.com/users/yodalee/repos","events_url":"https://api.github.com/users/yodalee/events{/privacy}","received_events_url":"https://api.github.com/users/yodalee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yodalee/qucs","description":"Qucs Project mirror repository","fork":true,"url":"https://api.github.com/repos/yodalee/qucs","forks_url":"https://api.github.com/repos/yodalee/qucs/forks","keys_url":"https://api.github.com/repos/yodalee/qucs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yodalee/qucs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yodalee/qucs/teams","hooks_url":"https://api.github.com/repos/yodalee/qucs/hooks","issue_events_url":"https://api.github.com/repos/yodalee/qucs/issues/events{/number}","events_url":"https://api.github.com/repos/yodalee/qucs/events","assignees_url":"https://api.github.com/repos/yodalee/qucs/assignees{/user}","branches_url":"https://api.github.com/repos/yodalee/qucs/branches{/branch}","tags_url":"https://api.github.com/repos/yodalee/qucs/tags","blobs_url":"https://api.github.com/repos/yodalee/qucs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yodalee/qucs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yodalee/qucs/git/refs{/sha}","trees_url":"https://api.github.com/repos/yodalee/qucs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yodalee/qucs/statuses/{sha}","languages_url":"https://api.github.com/repos/yodalee/qucs/languages","stargazers_url":"https://api.github.com/repos/yodalee/qucs/stargazers","contributors_url":"https://api.github.com/repos/yodalee/qucs/contributors","subscribers_url":"https://api.github.com/repos/yodalee/qucs/subscribers","subscription_url":"https://api.github.com/repos/yodalee/qucs/subscription","commits_url":"https://api.github.com/repos/yodalee/qucs/commits{/sha}","git_commits_url":"https://api.github.com/repos/yodalee/qucs/git/commits{/sha}","comments_url":"https://api.github.com/repos/yodalee/qucs/comments{/number}","issue_comment_url":"https://api.github.com/repos/yodalee/qucs/issues/comments/{number}","contents_url":"https://api.github.com/repos/yodalee/qucs/contents/{+path}","compare_url":"https://api.github.com/repos/yodalee/qucs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yodalee/qucs/merges","archive_url":"https://api.github.com/repos/yodalee/qucs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yodalee/qucs/downloads","issues_url":"https://api.github.com/repos/yodalee/qucs/issues{/number}","pulls_url":"https://api.github.com/repos/yodalee/qucs/pulls{/number}","milestones_url":"https://api.github.com/repos/yodalee/qucs/milestones{/number}","notifications_url":"https://api.github.com/repos/yodalee/qucs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yodalee/qucs/labels{/name}","releases_url":"https://api.github.com/repos/yodalee/qucs/releases{/id}","created_at":"2014-05-07T16:29:23Z","updated_at":"2014-09-03T11:50:09Z","pushed_at":"2014-11-13T15:06:28Z","git_url":"git://github.com/yodalee/qucs.git","ssh_url":"git@github.com:yodalee/qucs.git","clone_url":"https://github.com/yodalee/qucs.git","svn_url":"https://github.com/yodalee/qucs","homepage":"http://qucs.sourceforge.net/","size":54854,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Qucs:master","ref":"master","sha":"c221262b8261081177b582a260de0599148a4f30","user":{"login":"Qucs","id":5776398,"avatar_url":"https://avatars.githubusercontent.com/u/5776398?v=3","gravatar_id":"","url":"https://api.github.com/users/Qucs","html_url":"https://github.com/Qucs","followers_url":"https://api.github.com/users/Qucs/followers","following_url":"https://api.github.com/users/Qucs/following{/other_user}","gists_url":"https://api.github.com/users/Qucs/gists{/gist_id}","starred_url":"https://api.github.com/users/Qucs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qucs/subscriptions","organizations_url":"https://api.github.com/users/Qucs/orgs","repos_url":"https://api.github.com/users/Qucs/repos","events_url":"https://api.github.com/users/Qucs/events{/privacy}","received_events_url":"https://api.github.com/users/Qucs/received_events","type":"Organization","site_admin":false},"repo":{"id":16213441,"name":"qucs","full_name":"Qucs/qucs","owner":{"login":"Qucs","id":5776398,"avatar_url":"https://avatars.githubusercontent.com/u/5776398?v=3","gravatar_id":"","url":"https://api.github.com/users/Qucs","html_url":"https://github.com/Qucs","followers_url":"https://api.github.com/users/Qucs/followers","following_url":"https://api.github.com/users/Qucs/following{/other_user}","gists_url":"https://api.github.com/users/Qucs/gists{/gist_id}","starred_url":"https://api.github.com/users/Qucs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qucs/subscriptions","organizations_url":"https://api.github.com/users/Qucs/orgs","repos_url":"https://api.github.com/users/Qucs/repos","events_url":"https://api.github.com/users/Qucs/events{/privacy}","received_events_url":"https://api.github.com/users/Qucs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Qucs/qucs","description":"Qucs Project official mirror","fork":false,"url":"https://api.github.com/repos/Qucs/qucs","forks_url":"https://api.github.com/repos/Qucs/qucs/forks","keys_url":"https://api.github.com/repos/Qucs/qucs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qucs/qucs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qucs/qucs/teams","hooks_url":"https://api.github.com/repos/Qucs/qucs/hooks","issue_events_url":"https://api.github.com/repos/Qucs/qucs/issues/events{/number}","events_url":"https://api.github.com/repos/Qucs/qucs/events","assignees_url":"https://api.github.com/repos/Qucs/qucs/assignees{/user}","branches_url":"https://api.github.com/repos/Qucs/qucs/branches{/branch}","tags_url":"https://api.github.com/repos/Qucs/qucs/tags","blobs_url":"https://api.github.com/repos/Qucs/qucs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qucs/qucs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qucs/qucs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qucs/qucs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qucs/qucs/statuses/{sha}","languages_url":"https://api.github.com/repos/Qucs/qucs/languages","stargazers_url":"https://api.github.com/repos/Qucs/qucs/stargazers","contributors_url":"https://api.github.com/repos/Qucs/qucs/contributors","subscribers_url":"https://api.github.com/repos/Qucs/qucs/subscribers","subscription_url":"https://api.github.com/repos/Qucs/qucs/subscription","commits_url":"https://api.github.com/repos/Qucs/qucs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qucs/qucs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qucs/qucs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qucs/qucs/issues/comments/{number}","contents_url":"https://api.github.com/repos/Qucs/qucs/contents/{+path}","compare_url":"https://api.github.com/repos/Qucs/qucs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qucs/qucs/merges","archive_url":"https://api.github.com/repos/Qucs/qucs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qucs/qucs/downloads","issues_url":"https://api.github.com/repos/Qucs/qucs/issues{/number}","pulls_url":"https://api.github.com/repos/Qucs/qucs/pulls{/number}","milestones_url":"https://api.github.com/repos/Qucs/qucs/milestones{/number}","notifications_url":"https://api.github.com/repos/Qucs/qucs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qucs/qucs/labels{/name}","releases_url":"https://api.github.com/repos/Qucs/qucs/releases{/id}","created_at":"2014-01-24T18:48:36Z","updated_at":"2014-10-21T23:25:21Z","pushed_at":"2014-11-12T13:00:14Z","git_url":"git://github.com/Qucs/qucs.git","ssh_url":"git@github.com:Qucs/qucs.git","clone_url":"https://github.com/Qucs/qucs.git","svn_url":"https://github.com/Qucs/qucs","homepage":"http://qucs.sourceforge.net/","size":61655,"stargazers_count":36,"watchers_count":36,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":16,"forks":11,"open_issues":16,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qucs/qucs/pulls/113"},"html":{"href":"https://github.com/Qucs/qucs/pull/113"},"issue":{"href":"https://api.github.com/repos/Qucs/qucs/issues/113"},"comments":{"href":"https://api.github.com/repos/Qucs/qucs/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/Qucs/qucs/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/Qucs/qucs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Qucs/qucs/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/Qucs/qucs/statuses/9d5efa136bcb2d9b68996cec433a66f59571e6e8"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":21,"additions":565,"deletions":605,"changed_files":50}}