GitHub PullRequestReviewCommentEvent at 2014-12-05 21:42:36
Repository: kc
Actor: blackcathacker
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kuali/kc/pulls/comments/21402415","id":21402415,"diff_hunk":"@@ -107,10 +107,16 @@ public boolean canEditView(View view, ViewModel model, Person user) {\n     public boolean userHasLock(Person user, ProposalDevelopmentDocumentForm form) {\n         String pageRegion = ((ProposalDevelopmentViewHelperServiceImpl)form.getViewHelperService()).getLockRegionFromPage(form.getPageId());\n         for (PessimisticLock lock : form.getDocument().getPessimisticLocks()) {\n-           String lockRegion = StringUtils.split(lock.getLockDescriptor(), \"-\")[1];\n-           if (lock.isOwnedByUser(user) && lockRegion.equals(pageRegion)) {\n-               return true;\n-           }\n+            if (lock.getLockDescriptor() == null) {","path":"coeus-impl/src/main/java/org/kuali/coeus/propdev/impl/auth/ProposalDevelopmentDocumentViewAuthorizer.java","position":8,"original_position":8,"commit_id":"0f217580cb3446e39cfeaa28b2a0a588d5899223","original_commit_id":"bfd85eae5e244d28e3c1be7b1852f2419e11a070","user":{"login":"blackcathacker","id":3145921,"avatar_url":"https://avatars.githubusercontent.com/u/3145921?v=3","gravatar_id":"","url":"https://api.github.com/users/blackcathacker","html_url":"https://github.com/blackcathacker","followers_url":"https://api.github.com/users/blackcathacker/followers","following_url":"https://api.github.com/users/blackcathacker/following{/other_user}","gists_url":"https://api.github.com/users/blackcathacker/gists{/gist_id}","starred_url":"https://api.github.com/users/blackcathacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackcathacker/subscriptions","organizations_url":"https://api.github.com/users/blackcathacker/orgs","repos_url":"https://api.github.com/users/blackcathacker/repos","events_url":"https://api.github.com/users/blackcathacker/events{/privacy}","received_events_url":"https://api.github.com/users/blackcathacker/received_events","type":"User","site_admin":false},"body":"Yeah. That is super weird and not good. As long as we do fix this at some point I'm ok with this to get the transactional stuff in.","created_at":"2014-12-05T21:42:36Z","updated_at":"2014-12-05T21:42:36Z","html_url":"https://github.com/kuali/kc/pull/1239#discussion_r21402415","pull_request_url":"https://api.github.com/repos/kuali/kc/pulls/1239","_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/21402415"},"html":{"href":"https://github.com/kuali/kc/pull/1239#discussion_r21402415"},"pull_request":{"href":"https://api.github.com/repos/kuali/kc/pulls/1239"}}},"pull_request":{"url":"https://api.github.com/repos/kuali/kc/pulls/1239","id":25595151,"html_url":"https://github.com/kuali/kc/pull/1239","diff_url":"https://github.com/kuali/kc/pull/1239.diff","patch_url":"https://github.com/kuali/kc/pull/1239.patch","issue_url":"https://api.github.com/repos/kuali/kc/issues/1239","number":1239,"state":"open","locked":false,"title":"KRACOEUS-8443: adding transactions to controllers, fixing pessimistic loc...","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=3","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"body":"...k service for jpa\r\n\r\nHere is another shot at putting @Transactional on Controllers.  In testing this locally the only issue I ran into was with pessimistic locks, which I have fixed.  I haven't ran into any white screens or other similar issues.","created_at":"2014-12-05T19:49:14Z","updated_at":"2014-12-05T21:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9de6c3cd97b8e3de1bbe9f3faa2f2c6f3a30bf6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kuali/kc/pulls/1239/commits","review_comments_url":"https://api.github.com/repos/kuali/kc/pulls/1239/comments","review_comment_url":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kuali/kc/issues/1239/comments","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/0f217580cb3446e39cfeaa28b2a0a588d5899223","head":{"label":"leoherbie:transactional","ref":"transactional","sha":"0f217580cb3446e39cfeaa28b2a0a588d5899223","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=3","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"repo":{"id":16319639,"name":"kc","full_name":"leoherbie/kc","owner":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=3","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leoherbie/kc","description":"Kuali Coeus","fork":true,"url":"https://api.github.com/repos/leoherbie/kc","forks_url":"https://api.github.com/repos/leoherbie/kc/forks","keys_url":"https://api.github.com/repos/leoherbie/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leoherbie/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leoherbie/kc/teams","hooks_url":"https://api.github.com/repos/leoherbie/kc/hooks","issue_events_url":"https://api.github.com/repos/leoherbie/kc/issues/events{/number}","events_url":"https://api.github.com/repos/leoherbie/kc/events","assignees_url":"https://api.github.com/repos/leoherbie/kc/assignees{/user}","branches_url":"https://api.github.com/repos/leoherbie/kc/branches{/branch}","tags_url":"https://api.github.com/repos/leoherbie/kc/tags","blobs_url":"https://api.github.com/repos/leoherbie/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leoherbie/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leoherbie/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/leoherbie/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leoherbie/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/leoherbie/kc/languages","stargazers_url":"https://api.github.com/repos/leoherbie/kc/stargazers","contributors_url":"https://api.github.com/repos/leoherbie/kc/contributors","subscribers_url":"https://api.github.com/repos/leoherbie/kc/subscribers","subscription_url":"https://api.github.com/repos/leoherbie/kc/subscription","commits_url":"https://api.github.com/repos/leoherbie/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/leoherbie/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/leoherbie/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/leoherbie/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/leoherbie/kc/contents/{+path}","compare_url":"https://api.github.com/repos/leoherbie/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leoherbie/kc/merges","archive_url":"https://api.github.com/repos/leoherbie/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leoherbie/kc/downloads","issues_url":"https://api.github.com/repos/leoherbie/kc/issues{/number}","pulls_url":"https://api.github.com/repos/leoherbie/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/leoherbie/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/leoherbie/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leoherbie/kc/labels{/name}","releases_url":"https://api.github.com/repos/leoherbie/kc/releases{/id}","created_at":"2014-01-28T17:33:17Z","updated_at":"2014-12-05T17:05:50Z","pushed_at":"2014-12-05T21:07:56Z","git_url":"git://github.com/leoherbie/kc.git","ssh_url":"git@github.com:leoherbie/kc.git","clone_url":"https://github.com/leoherbie/kc.git","svn_url":"https://github.com/leoherbie/kc","homepage":"http://www.kuali.org/kc","size":596705,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kuali:master","ref":"master","sha":"44857bca3f0de175bdbc65fa254f823294769eae","user":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=3","gravatar_id":"","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"repo":{"id":16106733,"name":"kc","full_name":"kuali/kc","owner":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=3","gravatar_id":"","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuali/kc","description":"Kuali Coeus","fork":false,"url":"https://api.github.com/repos/kuali/kc","forks_url":"https://api.github.com/repos/kuali/kc/forks","keys_url":"https://api.github.com/repos/kuali/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuali/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuali/kc/teams","hooks_url":"https://api.github.com/repos/kuali/kc/hooks","issue_events_url":"https://api.github.com/repos/kuali/kc/issues/events{/number}","events_url":"https://api.github.com/repos/kuali/kc/events","assignees_url":"https://api.github.com/repos/kuali/kc/assignees{/user}","branches_url":"https://api.github.com/repos/kuali/kc/branches{/branch}","tags_url":"https://api.github.com/repos/kuali/kc/tags","blobs_url":"https://api.github.com/repos/kuali/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuali/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuali/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuali/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/kuali/kc/languages","stargazers_url":"https://api.github.com/repos/kuali/kc/stargazers","contributors_url":"https://api.github.com/repos/kuali/kc/contributors","subscribers_url":"https://api.github.com/repos/kuali/kc/subscribers","subscription_url":"https://api.github.com/repos/kuali/kc/subscription","commits_url":"https://api.github.com/repos/kuali/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuali/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuali/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuali/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/kuali/kc/contents/{+path}","compare_url":"https://api.github.com/repos/kuali/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuali/kc/merges","archive_url":"https://api.github.com/repos/kuali/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuali/kc/downloads","issues_url":"https://api.github.com/repos/kuali/kc/issues{/number}","pulls_url":"https://api.github.com/repos/kuali/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/kuali/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/kuali/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuali/kc/labels{/name}","releases_url":"https://api.github.com/repos/kuali/kc/releases{/id}","created_at":"2014-01-21T15:32:22Z","updated_at":"2014-12-05T21:16:42Z","pushed_at":"2014-12-05T21:16:42Z","git_url":"git://github.com/kuali/kc.git","ssh_url":"git@github.com:kuali/kc.git","clone_url":"https://github.com/kuali/kc.git","svn_url":"https://github.com/kuali/kc","homepage":"http://www.kuali.org/kc","size":692055,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":9,"forks":46,"open_issues":9,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/1239"},"html":{"href":"https://github.com/kuali/kc/pull/1239"},"issue":{"href":"https://api.github.com/repos/kuali/kc/issues/1239"},"comments":{"href":"https://api.github.com/repos/kuali/kc/issues/1239/comments"},"review_comments":{"href":"https://api.github.com/repos/kuali/kc/pulls/1239/comments"},"review_comment":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kuali/kc/pulls/1239/commits"},"statuses":{"href":"https://api.github.com/repos/kuali/kc/statuses/0f217580cb3446e39cfeaa28b2a0a588d5899223"}}}}