GitHub PullRequestReviewCommentEvent at 2014-08-12 18:51:40
Repository: osem
Actor: kalabiyau
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/comments/16134112","id":16134112,"diff_hunk":"@@ -173,5 +177,48 @@ def edit\n         format.json { render json: @conference.to_json }\n       end\n     end\n+\n+    def roles\n+      @user = User.new\n+      @roles = Role::ACTIONABLES + Role::LABELS\n+\n+      params[:user] ? (@selected = params[:user][:roles]) : (@selected = 'Organizer')\n+      @selection = @selected.parameterize.underscore","path":"app/controllers/admin/conference_controller.rb","position":38,"original_position":38,"commit_id":"8efb4bab08090de006886b4380d6727eb63cfc70","original_commit_id":"8efb4bab08090de006886b4380d6727eb63cfc70","user":{"login":"kalabiyau","id":294998,"avatar_url":"https://avatars.githubusercontent.com/u/294998?v=2","gravatar_id":"abc326a22518dfaa478dd9a1240d2898","url":"https://api.github.com/users/kalabiyau","html_url":"https://github.com/kalabiyau","followers_url":"https://api.github.com/users/kalabiyau/followers","following_url":"https://api.github.com/users/kalabiyau/following{/other_user}","gists_url":"https://api.github.com/users/kalabiyau/gists{/gist_id}","starred_url":"https://api.github.com/users/kalabiyau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalabiyau/subscriptions","organizations_url":"https://api.github.com/users/kalabiyau/orgs","repos_url":"https://api.github.com/users/kalabiyau/repos","events_url":"https://api.github.com/users/kalabiyau/events{/privacy}","received_events_url":"https://api.github.com/users/kalabiyau/received_events","type":"User","site_admin":false},"body":"could be probably extracted as repeated (i will mark 'em as [dup])","created_at":"2014-08-12T18:51:40Z","updated_at":"2014-08-12T18:51:40Z","html_url":"https://github.com/openSUSE/osem/pull/441#discussion_r16134112","pull_request_url":"https://api.github.com/repos/openSUSE/osem/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments/16134112"},"html":{"href":"https://github.com/openSUSE/osem/pull/441#discussion_r16134112"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/441","id":19662565,"html_url":"https://github.com/openSUSE/osem/pull/441","diff_url":"https://github.com/openSUSE/osem/pull/441.diff","patch_url":"https://github.com/openSUSE/osem/pull/441.patch","issue_url":"https://api.github.com/repos/openSUSE/osem/issues/441","number":441,"state":"open","title":"Cancancan","user":{"login":"differentreality","id":4322737,"avatar_url":"https://avatars.githubusercontent.com/u/4322737?v=2","gravatar_id":"5e8cbdbca030c5b5cbebaad531c95d11","url":"https://api.github.com/users/differentreality","html_url":"https://github.com/differentreality","followers_url":"https://api.github.com/users/differentreality/followers","following_url":"https://api.github.com/users/differentreality/following{/other_user}","gists_url":"https://api.github.com/users/differentreality/gists{/gist_id}","starred_url":"https://api.github.com/users/differentreality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/differentreality/subscriptions","organizations_url":"https://api.github.com/users/differentreality/orgs","repos_url":"https://api.github.com/users/differentreality/repos","events_url":"https://api.github.com/users/differentreality/events{/privacy}","received_events_url":"https://api.github.com/users/differentreality/received_events","type":"User","site_admin":false},"body":"https://github.com/openSUSE/osem/issues/23\r\n\r\nSome issues that I have not been able to solve yet are:\r\n\r\n* Ability is not applied(?)\r\nhttps://github.com/differentreality/osem/blob/cancancan/app/models/ability.rb#L103\r\nBrowser shows the new commercial page, test fails: \r\nhttps://github.com/differentreality/osem/blob/cancancan/spec/features/commercials_spec.rb#L22\r\n\r\nFailures:\r\n  1) Commercial organizer behaves like adds and updates a commercial of a conference\r\n     Failure/Error: select('SlideShare', from: 'commercial_commercial_type')\r\n     Capybara::ElementNotFound:\r\n       Unable to find select box \"commercial_commercial_type\"\r\n     Shared Example Group: \"adds and updates a commercial\" called from ./spec/features/commercials_spec.rb:65\r\n     # ./spec/features/commercials_spec.rb:23:in `block (3 levels) in <top (required)>'\r\n     # ./spec/spec_helper.rb:60:in `block (3 levels) in <top (required)>'\r\n     # ./spec/spec_helper.rb:59:in `block (2 levels) in <top (required)>'\r\n\r\n* I got failing tests which I cannot reproduce in browser with commented lines in:\r\nhttps://github.com/differentreality/osem/blob/cancancan/spec/features/ability_spec.rb#L86\r\n","created_at":"2014-08-12T13:52:33Z","updated_at":"2014-08-12T18:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4a530949870f52293081ecf0a0862e26c8efa85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/osem/pulls/441/commits","review_comments_url":"https://api.github.com/repos/openSUSE/osem/pulls/441/comments","review_comment_url":"https://api.github.com/repos/openSUSE/osem/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openSUSE/osem/issues/441/comments","statuses_url":"https://api.github.com/repos/openSUSE/osem/statuses/8efb4bab08090de006886b4380d6727eb63cfc70","head":{"label":"differentreality:cancancan","ref":"cancancan","sha":"8efb4bab08090de006886b4380d6727eb63cfc70","user":{"login":"differentreality","id":4322737,"avatar_url":"https://avatars.githubusercontent.com/u/4322737?v=2","gravatar_id":"5e8cbdbca030c5b5cbebaad531c95d11","url":"https://api.github.com/users/differentreality","html_url":"https://github.com/differentreality","followers_url":"https://api.github.com/users/differentreality/followers","following_url":"https://api.github.com/users/differentreality/following{/other_user}","gists_url":"https://api.github.com/users/differentreality/gists{/gist_id}","starred_url":"https://api.github.com/users/differentreality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/differentreality/subscriptions","organizations_url":"https://api.github.com/users/differentreality/orgs","repos_url":"https://api.github.com/users/differentreality/repos","events_url":"https://api.github.com/users/differentreality/events{/privacy}","received_events_url":"https://api.github.com/users/differentreality/received_events","type":"User","site_admin":false},"repo":{"id":9815207,"name":"osem","full_name":"differentreality/osem","owner":{"login":"differentreality","id":4322737,"avatar_url":"https://avatars.githubusercontent.com/u/4322737?v=2","gravatar_id":"5e8cbdbca030c5b5cbebaad531c95d11","url":"https://api.github.com/users/differentreality","html_url":"https://github.com/differentreality","followers_url":"https://api.github.com/users/differentreality/followers","following_url":"https://api.github.com/users/differentreality/following{/other_user}","gists_url":"https://api.github.com/users/differentreality/gists{/gist_id}","starred_url":"https://api.github.com/users/differentreality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/differentreality/subscriptions","organizations_url":"https://api.github.com/users/differentreality/orgs","repos_url":"https://api.github.com/users/differentreality/repos","events_url":"https://api.github.com/users/differentreality/events{/privacy}","received_events_url":"https://api.github.com/users/differentreality/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/differentreality/osem","description":"Open Source Event Manager","fork":true,"url":"https://api.github.com/repos/differentreality/osem","forks_url":"https://api.github.com/repos/differentreality/osem/forks","keys_url":"https://api.github.com/repos/differentreality/osem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/differentreality/osem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/differentreality/osem/teams","hooks_url":"https://api.github.com/repos/differentreality/osem/hooks","issue_events_url":"https://api.github.com/repos/differentreality/osem/issues/events{/number}","events_url":"https://api.github.com/repos/differentreality/osem/events","assignees_url":"https://api.github.com/repos/differentreality/osem/assignees{/user}","branches_url":"https://api.github.com/repos/differentreality/osem/branches{/branch}","tags_url":"https://api.github.com/repos/differentreality/osem/tags","blobs_url":"https://api.github.com/repos/differentreality/osem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/differentreality/osem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/differentreality/osem/git/refs{/sha}","trees_url":"https://api.github.com/repos/differentreality/osem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/differentreality/osem/statuses/{sha}","languages_url":"https://api.github.com/repos/differentreality/osem/languages","stargazers_url":"https://api.github.com/repos/differentreality/osem/stargazers","contributors_url":"https://api.github.com/repos/differentreality/osem/contributors","subscribers_url":"https://api.github.com/repos/differentreality/osem/subscribers","subscription_url":"https://api.github.com/repos/differentreality/osem/subscription","commits_url":"https://api.github.com/repos/differentreality/osem/commits{/sha}","git_commits_url":"https://api.github.com/repos/differentreality/osem/git/commits{/sha}","comments_url":"https://api.github.com/repos/differentreality/osem/comments{/number}","issue_comment_url":"https://api.github.com/repos/differentreality/osem/issues/comments/{number}","contents_url":"https://api.github.com/repos/differentreality/osem/contents/{+path}","compare_url":"https://api.github.com/repos/differentreality/osem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/differentreality/osem/merges","archive_url":"https://api.github.com/repos/differentreality/osem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/differentreality/osem/downloads","issues_url":"https://api.github.com/repos/differentreality/osem/issues{/number}","pulls_url":"https://api.github.com/repos/differentreality/osem/pulls{/number}","milestones_url":"https://api.github.com/repos/differentreality/osem/milestones{/number}","notifications_url":"https://api.github.com/repos/differentreality/osem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/differentreality/osem/labels{/name}","releases_url":"https://api.github.com/repos/differentreality/osem/releases{/id}","created_at":"2013-05-02T14:46:10Z","updated_at":"2014-06-24T10:23:14Z","pushed_at":"2014-08-12T17:24:29Z","git_url":"git://github.com/differentreality/osem.git","ssh_url":"git@github.com:differentreality/osem.git","clone_url":"https://github.com/differentreality/osem.git","svn_url":"https://github.com/differentreality/osem","homepage":null,"size":6772,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"ac255615233a423bb14b78b27b604090e676ba2b","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=2","gravatar_id":"eba8b10e96bfc815a8b7fa8d819e8de1","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":5911225,"name":"osem","full_name":"openSUSE/osem","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=2","gravatar_id":"eba8b10e96bfc815a8b7fa8d819e8de1","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/osem","description":"Open Source Event Manager","fork":false,"url":"https://api.github.com/repos/openSUSE/osem","forks_url":"https://api.github.com/repos/openSUSE/osem/forks","keys_url":"https://api.github.com/repos/openSUSE/osem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/osem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/osem/teams","hooks_url":"https://api.github.com/repos/openSUSE/osem/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/osem/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/osem/events","assignees_url":"https://api.github.com/repos/openSUSE/osem/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/osem/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/osem/tags","blobs_url":"https://api.github.com/repos/openSUSE/osem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/osem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/osem/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/osem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/osem/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/osem/languages","stargazers_url":"https://api.github.com/repos/openSUSE/osem/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/osem/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/osem/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/osem/subscription","commits_url":"https://api.github.com/repos/openSUSE/osem/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/osem/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/osem/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/osem/issues/comments/{number}","contents_url":"https://api.github.com/repos/openSUSE/osem/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/osem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/osem/merges","archive_url":"https://api.github.com/repos/openSUSE/osem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/osem/downloads","issues_url":"https://api.github.com/repos/openSUSE/osem/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/osem/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/osem/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/osem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/osem/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/osem/releases{/id}","created_at":"2012-09-22T07:40:18Z","updated_at":"2014-08-04T19:24:04Z","pushed_at":"2014-08-12T15:25:40Z","git_url":"git://github.com/openSUSE/osem.git","ssh_url":"git@github.com:openSUSE/osem.git","clone_url":"https://github.com/openSUSE/osem.git","svn_url":"https://github.com/openSUSE/osem","homepage":null,"size":12042,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":21,"mirror_url":null,"open_issues_count":79,"forks":21,"open_issues":79,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/441"},"html":{"href":"https://github.com/openSUSE/osem/pull/441"},"issue":{"href":"https://api.github.com/repos/openSUSE/osem/issues/441"},"comments":{"href":"https://api.github.com/repos/openSUSE/osem/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/osem/statuses/8efb4bab08090de006886b4380d6727eb63cfc70"}}}}