GitHub PullRequestReviewCommentEvent at 2014-12-09 19:38:01
Repository: monologue
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jipiboily/monologue/pulls/comments/21555784","id":21555784,"diff_hunk":"@@ -4,10 +4,33 @@\n   before(:each) do\n     Factory(:post, url: \"url/to/post\")\n   end\n-  \n+\n   # test to prevent regression for issue #72\n   it \"should contain full\" do\n     visit feed_path\n     page.should have_content \"/monologue/url/to/post\"\n   end\n+\n+  context 'with tags param' do\n+    before do\n+      create(:post, title: 'Feed Post').tag!(['feed'])\n+      create(:post, title: 'Rss Post').tag!(['rss'])\n+    end\n+\n+    context 'with tags' do\n+      it 'returns posts tagged with tags' do\n+        visit feed_path(tags: 'feed,rss')\n+        page.should have_content 'Feed Post'\n+        page.should have_content 'Rss Post'\n+      end\n+    end\n+\n+    context 'without tags' do\n+      it 'returns all posts' do","path":"spec/requests/feed_spec.rb","position":27,"original_position":27,"commit_id":"c32f7e1e2f222e38c6cdc46820e0b98404900ad5","original_commit_id":"c32f7e1e2f222e38c6cdc46820e0b98404900ad5","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-12-09T19:38:01Z","updated_at":"2014-12-09T19:38:01Z","html_url":"https://github.com/jipiboily/monologue/pull/226#discussion_r21555784","pull_request_url":"https://api.github.com/repos/jipiboily/monologue/pulls/226","_links":{"self":{"href":"https://api.github.com/repos/jipiboily/monologue/pulls/comments/21555784"},"html":{"href":"https://github.com/jipiboily/monologue/pull/226#discussion_r21555784"},"pull_request":{"href":"https://api.github.com/repos/jipiboily/monologue/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/jipiboily/monologue/pulls/226","id":25770332,"html_url":"https://github.com/jipiboily/monologue/pull/226","diff_url":"https://github.com/jipiboily/monologue/pull/226.diff","patch_url":"https://github.com/jipiboily/monologue/pull/226.patch","issue_url":"https://api.github.com/repos/jipiboily/monologue/issues/226","number":226,"state":"open","locked":false,"title":"Add support for tag oriented feeds #213","user":{"login":"astephenb","id":3619060,"avatar_url":"https://avatars.githubusercontent.com/u/3619060?v=3","gravatar_id":"","url":"https://api.github.com/users/astephenb","html_url":"https://github.com/astephenb","followers_url":"https://api.github.com/users/astephenb/followers","following_url":"https://api.github.com/users/astephenb/following{/other_user}","gists_url":"https://api.github.com/users/astephenb/gists{/gist_id}","starred_url":"https://api.github.com/users/astephenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astephenb/subscriptions","organizations_url":"https://api.github.com/users/astephenb/orgs","repos_url":"https://api.github.com/users/astephenb/repos","events_url":"https://api.github.com/users/astephenb/events{/privacy}","received_events_url":"https://api.github.com/users/astephenb/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-09T19:37:53Z","updated_at":"2014-12-09T19:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3bb91f57e4b9e43cadc07f459e535b542353c8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jipiboily/monologue/pulls/226/commits","review_comments_url":"https://api.github.com/repos/jipiboily/monologue/pulls/226/comments","review_comment_url":"https://api.github.com/repos/jipiboily/monologue/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jipiboily/monologue/issues/226/comments","statuses_url":"https://api.github.com/repos/jipiboily/monologue/statuses/c32f7e1e2f222e38c6cdc46820e0b98404900ad5","head":{"label":"astephenb:213-tag-oriented-feeds","ref":"213-tag-oriented-feeds","sha":"c32f7e1e2f222e38c6cdc46820e0b98404900ad5","user":{"login":"astephenb","id":3619060,"avatar_url":"https://avatars.githubusercontent.com/u/3619060?v=3","gravatar_id":"","url":"https://api.github.com/users/astephenb","html_url":"https://github.com/astephenb","followers_url":"https://api.github.com/users/astephenb/followers","following_url":"https://api.github.com/users/astephenb/following{/other_user}","gists_url":"https://api.github.com/users/astephenb/gists{/gist_id}","starred_url":"https://api.github.com/users/astephenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astephenb/subscriptions","organizations_url":"https://api.github.com/users/astephenb/orgs","repos_url":"https://api.github.com/users/astephenb/repos","events_url":"https://api.github.com/users/astephenb/events{/privacy}","received_events_url":"https://api.github.com/users/astephenb/received_events","type":"User","site_admin":false},"repo":{"id":27611161,"name":"monologue","full_name":"astephenb/monologue","owner":{"login":"astephenb","id":3619060,"avatar_url":"https://avatars.githubusercontent.com/u/3619060?v=3","gravatar_id":"","url":"https://api.github.com/users/astephenb","html_url":"https://github.com/astephenb","followers_url":"https://api.github.com/users/astephenb/followers","following_url":"https://api.github.com/users/astephenb/following{/other_user}","gists_url":"https://api.github.com/users/astephenb/gists{/gist_id}","starred_url":"https://api.github.com/users/astephenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astephenb/subscriptions","organizations_url":"https://api.github.com/users/astephenb/orgs","repos_url":"https://api.github.com/users/astephenb/repos","events_url":"https://api.github.com/users/astephenb/events{/privacy}","received_events_url":"https://api.github.com/users/astephenb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astephenb/monologue","description":"Monologue is a basic blogging engine. It is a Rails mountable engine you can mount in your already existing Rails app, or a in a new one! Enjoy.","fork":true,"url":"https://api.github.com/repos/astephenb/monologue","forks_url":"https://api.github.com/repos/astephenb/monologue/forks","keys_url":"https://api.github.com/repos/astephenb/monologue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astephenb/monologue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astephenb/monologue/teams","hooks_url":"https://api.github.com/repos/astephenb/monologue/hooks","issue_events_url":"https://api.github.com/repos/astephenb/monologue/issues/events{/number}","events_url":"https://api.github.com/repos/astephenb/monologue/events","assignees_url":"https://api.github.com/repos/astephenb/monologue/assignees{/user}","branches_url":"https://api.github.com/repos/astephenb/monologue/branches{/branch}","tags_url":"https://api.github.com/repos/astephenb/monologue/tags","blobs_url":"https://api.github.com/repos/astephenb/monologue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astephenb/monologue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astephenb/monologue/git/refs{/sha}","trees_url":"https://api.github.com/repos/astephenb/monologue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astephenb/monologue/statuses/{sha}","languages_url":"https://api.github.com/repos/astephenb/monologue/languages","stargazers_url":"https://api.github.com/repos/astephenb/monologue/stargazers","contributors_url":"https://api.github.com/repos/astephenb/monologue/contributors","subscribers_url":"https://api.github.com/repos/astephenb/monologue/subscribers","subscription_url":"https://api.github.com/repos/astephenb/monologue/subscription","commits_url":"https://api.github.com/repos/astephenb/monologue/commits{/sha}","git_commits_url":"https://api.github.com/repos/astephenb/monologue/git/commits{/sha}","comments_url":"https://api.github.com/repos/astephenb/monologue/comments{/number}","issue_comment_url":"https://api.github.com/repos/astephenb/monologue/issues/comments/{number}","contents_url":"https://api.github.com/repos/astephenb/monologue/contents/{+path}","compare_url":"https://api.github.com/repos/astephenb/monologue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astephenb/monologue/merges","archive_url":"https://api.github.com/repos/astephenb/monologue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astephenb/monologue/downloads","issues_url":"https://api.github.com/repos/astephenb/monologue/issues{/number}","pulls_url":"https://api.github.com/repos/astephenb/monologue/pulls{/number}","milestones_url":"https://api.github.com/repos/astephenb/monologue/milestones{/number}","notifications_url":"https://api.github.com/repos/astephenb/monologue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astephenb/monologue/labels{/name}","releases_url":"https://api.github.com/repos/astephenb/monologue/releases{/id}","created_at":"2014-12-05T21:36:57Z","updated_at":"2014-12-05T21:36:57Z","pushed_at":"2014-12-09T19:37:26Z","git_url":"git://github.com/astephenb/monologue.git","ssh_url":"git@github.com:astephenb/monologue.git","clone_url":"https://github.com/astephenb/monologue.git","svn_url":"https://github.com/astephenb/monologue","homepage":"http://jipiboily.com/2013/monologue-0-3-0-released-and-monologue-markdown","size":1650,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jipiboily:master","ref":"master","sha":"0ef9ed3f7ae12e5c71fa2d53505ebdc94ab8b4d6","user":{"login":"jipiboily","id":232993,"avatar_url":"https://avatars.githubusercontent.com/u/232993?v=3","gravatar_id":"","url":"https://api.github.com/users/jipiboily","html_url":"https://github.com/jipiboily","followers_url":"https://api.github.com/users/jipiboily/followers","following_url":"https://api.github.com/users/jipiboily/following{/other_user}","gists_url":"https://api.github.com/users/jipiboily/gists{/gist_id}","starred_url":"https://api.github.com/users/jipiboily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jipiboily/subscriptions","organizations_url":"https://api.github.com/users/jipiboily/orgs","repos_url":"https://api.github.com/users/jipiboily/repos","events_url":"https://api.github.com/users/jipiboily/events{/privacy}","received_events_url":"https://api.github.com/users/jipiboily/received_events","type":"User","site_admin":false},"repo":{"id":3345605,"name":"monologue","full_name":"jipiboily/monologue","owner":{"login":"jipiboily","id":232993,"avatar_url":"https://avatars.githubusercontent.com/u/232993?v=3","gravatar_id":"","url":"https://api.github.com/users/jipiboily","html_url":"https://github.com/jipiboily","followers_url":"https://api.github.com/users/jipiboily/followers","following_url":"https://api.github.com/users/jipiboily/following{/other_user}","gists_url":"https://api.github.com/users/jipiboily/gists{/gist_id}","starred_url":"https://api.github.com/users/jipiboily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jipiboily/subscriptions","organizations_url":"https://api.github.com/users/jipiboily/orgs","repos_url":"https://api.github.com/users/jipiboily/repos","events_url":"https://api.github.com/users/jipiboily/events{/privacy}","received_events_url":"https://api.github.com/users/jipiboily/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jipiboily/monologue","description":"Monologue is a basic blogging engine. It is a Rails mountable engine you can mount in your already existing Rails app, or a in a new one! Enjoy.","fork":false,"url":"https://api.github.com/repos/jipiboily/monologue","forks_url":"https://api.github.com/repos/jipiboily/monologue/forks","keys_url":"https://api.github.com/repos/jipiboily/monologue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jipiboily/monologue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jipiboily/monologue/teams","hooks_url":"https://api.github.com/repos/jipiboily/monologue/hooks","issue_events_url":"https://api.github.com/repos/jipiboily/monologue/issues/events{/number}","events_url":"https://api.github.com/repos/jipiboily/monologue/events","assignees_url":"https://api.github.com/repos/jipiboily/monologue/assignees{/user}","branches_url":"https://api.github.com/repos/jipiboily/monologue/branches{/branch}","tags_url":"https://api.github.com/repos/jipiboily/monologue/tags","blobs_url":"https://api.github.com/repos/jipiboily/monologue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jipiboily/monologue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jipiboily/monologue/git/refs{/sha}","trees_url":"https://api.github.com/repos/jipiboily/monologue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jipiboily/monologue/statuses/{sha}","languages_url":"https://api.github.com/repos/jipiboily/monologue/languages","stargazers_url":"https://api.github.com/repos/jipiboily/monologue/stargazers","contributors_url":"https://api.github.com/repos/jipiboily/monologue/contributors","subscribers_url":"https://api.github.com/repos/jipiboily/monologue/subscribers","subscription_url":"https://api.github.com/repos/jipiboily/monologue/subscription","commits_url":"https://api.github.com/repos/jipiboily/monologue/commits{/sha}","git_commits_url":"https://api.github.com/repos/jipiboily/monologue/git/commits{/sha}","comments_url":"https://api.github.com/repos/jipiboily/monologue/comments{/number}","issue_comment_url":"https://api.github.com/repos/jipiboily/monologue/issues/comments/{number}","contents_url":"https://api.github.com/repos/jipiboily/monologue/contents/{+path}","compare_url":"https://api.github.com/repos/jipiboily/monologue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jipiboily/monologue/merges","archive_url":"https://api.github.com/repos/jipiboily/monologue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jipiboily/monologue/downloads","issues_url":"https://api.github.com/repos/jipiboily/monologue/issues{/number}","pulls_url":"https://api.github.com/repos/jipiboily/monologue/pulls{/number}","milestones_url":"https://api.github.com/repos/jipiboily/monologue/milestones{/number}","notifications_url":"https://api.github.com/repos/jipiboily/monologue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jipiboily/monologue/labels{/name}","releases_url":"https://api.github.com/repos/jipiboily/monologue/releases{/id}","created_at":"2012-02-03T15:44:06Z","updated_at":"2014-12-07T10:31:24Z","pushed_at":"2014-12-05T02:25:46Z","git_url":"git://github.com/jipiboily/monologue.git","ssh_url":"git@github.com:jipiboily/monologue.git","clone_url":"https://github.com/jipiboily/monologue.git","svn_url":"https://github.com/jipiboily/monologue","homepage":"http://jipiboily.com/2013/monologue-0-3-0-released-and-monologue-markdown","size":3933,"stargazers_count":329,"watchers_count":329,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":10,"forks":120,"open_issues":10,"watchers":329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jipiboily/monologue/pulls/226"},"html":{"href":"https://github.com/jipiboily/monologue/pull/226"},"issue":{"href":"https://api.github.com/repos/jipiboily/monologue/issues/226"},"comments":{"href":"https://api.github.com/repos/jipiboily/monologue/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/jipiboily/monologue/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/jipiboily/monologue/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jipiboily/monologue/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/jipiboily/monologue/statuses/c32f7e1e2f222e38c6cdc46820e0b98404900ad5"}}}}