GitHub PullRequestReviewCommentEvent at 2014-06-23 11:38:30
Repository: ontohub
Actor: 0robustus1
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ontohub/ontohub/pulls/comments/14070811","id":14070811,"diff_hunk":"@@ -0,0 +1,42 @@\n+require 'spec_helper'\n+\n+describe 'git mv', :process_jobs_synchronously do\n+  let(:userinfo) { {","path":"spec/models/repository/git_mv_spec.rb","position":4,"original_position":4,"commit_id":"7130e2fca7fc7d8c52c1234977954592c12cdbd0","original_commit_id":"7130e2fca7fc7d8c52c1234977954592c12cdbd0","user":{"login":"0robustus1","id":697338,"avatar_url":"https://avatars.githubusercontent.com/u/697338?","gravatar_id":"36546341a11683a7c804ca7787433996","url":"https://api.github.com/users/0robustus1","html_url":"https://github.com/0robustus1","followers_url":"https://api.github.com/users/0robustus1/followers","following_url":"https://api.github.com/users/0robustus1/following{/other_user}","gists_url":"https://api.github.com/users/0robustus1/gists{/gist_id}","starred_url":"https://api.github.com/users/0robustus1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0robustus1/subscriptions","organizations_url":"https://api.github.com/users/0robustus1/orgs","repos_url":"https://api.github.com/users/0robustus1/repos","events_url":"https://api.github.com/users/0robustus1/events{/privacy}","received_events_url":"https://api.github.com/users/0robustus1/received_events","type":"User","site_admin":false},"body":"please use `do...end` on multiline blocks.","created_at":"2014-06-23T11:38:30Z","updated_at":"2014-06-23T11:38:30Z","html_url":"https://github.com/ontohub/ontohub/pull/911#discussion_r14070811","pull_request_url":"https://api.github.com/repos/ontohub/ontohub/pulls/911","_links":{"self":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/comments/14070811"},"html":{"href":"https://github.com/ontohub/ontohub/pull/911#discussion_r14070811"},"pull_request":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/911"}}},"pull_request":{"url":"https://api.github.com/repos/ontohub/ontohub/pulls/911","id":16647727,"html_url":"https://github.com/ontohub/ontohub/pull/911","diff_url":"https://github.com/ontohub/ontohub/pull/911.diff","patch_url":"https://github.com/ontohub/ontohub/pull/911.patch","issue_url":"https://api.github.com/repos/ontohub/ontohub/issues/911","number":911,"state":"open","title":"641 git mv handling","user":{"login":"eugenk","id":339751,"avatar_url":"https://avatars.githubusercontent.com/u/339751?","gravatar_id":"1b777dd0f315bb88d60e3a62fc7348f1","url":"https://api.github.com/users/eugenk","html_url":"https://github.com/eugenk","followers_url":"https://api.github.com/users/eugenk/followers","following_url":"https://api.github.com/users/eugenk/following{/other_user}","gists_url":"https://api.github.com/users/eugenk/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenk/subscriptions","organizations_url":"https://api.github.com/users/eugenk/orgs","repos_url":"https://api.github.com/users/eugenk/repos","events_url":"https://api.github.com/users/eugenk/events{/privacy}","received_events_url":"https://api.github.com/users/eugenk/received_events","type":"User","site_admin":false},"body":"This branch is quite huge. The main changes are: \r\n* Update rugged to a state on their develop branch\r\n* Add `basepath` and `file_extension` to `ontology_version`\r\n  * Leave `basepath` and `file_extension` in `ontology` because there are cases when we don't have any versions in an `ontology`, but need the `path`. In the future, this will be removed.\r\n  * Replace method `ontology.find_by_file` by `ontology.find_with_path`\r\n  * Add method `ontology.find_with_basepath`\r\n  * Those `ontology.find_with_*path` methods search for the path at the current version of an ontology, if there are any versions. Otherwise, the path of the ontology itself will be taken into account. It is crucial that `ontology.ontology_version_id` is always up to date.\r\n* Diffs **and deltas** are computed in a lazy way in `GitRepository::GetDiff::FileChange` by rugged/libgit2.\r\n  * A delta contains the information what kind of change has been made to a file (add, modify, delete, rename)\r\n* Add max diff-size to config. Diffs larger than that are not shown (but a notice is shown).\r\n  * Diffy is not used any more for computing diffs. The gem will be removed as soon as we decide how to display them. Maybe diffy will be handy for that.\r\n* Add `GitRepository::History::Commit` class to represent commits in the history. Before, we used `Hash` for that task. Objects of this class are passed to the block given to `repository.commits`.\r\n* Move some tests to rspec while re-adjusting them to the changes.\r\n\r\nFixes #641, #570, #537","created_at":"2014-06-03T11:34:58Z","updated_at":"2014-06-23T11:38:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8c993dc78366915e30a4702113ce7eb05cd04b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ontohub/ontohub/pulls/911/commits","review_comments_url":"https://api.github.com/repos/ontohub/ontohub/pulls/911/comments","review_comment_url":"https://api.github.com/repos/ontohub/ontohub/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ontohub/ontohub/issues/911/comments","statuses_url":"https://api.github.com/repos/ontohub/ontohub/statuses/7130e2fca7fc7d8c52c1234977954592c12cdbd0","head":{"label":"ontohub:641-git_mv_handling","ref":"641-git_mv_handling","sha":"7130e2fca7fc7d8c52c1234977954592c12cdbd0","user":{"login":"ontohub","id":1575984,"avatar_url":"https://avatars.githubusercontent.com/u/1575984?","gravatar_id":"a7f409f3674b52f44a0c6aa8dbef61d1","url":"https://api.github.com/users/ontohub","html_url":"https://github.com/ontohub","followers_url":"https://api.github.com/users/ontohub/followers","following_url":"https://api.github.com/users/ontohub/following{/other_user}","gists_url":"https://api.github.com/users/ontohub/gists{/gist_id}","starred_url":"https://api.github.com/users/ontohub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ontohub/subscriptions","organizations_url":"https://api.github.com/users/ontohub/orgs","repos_url":"https://api.github.com/users/ontohub/repos","events_url":"https://api.github.com/users/ontohub/events{/privacy}","received_events_url":"https://api.github.com/users/ontohub/received_events","type":"Organization","site_admin":false},"repo":{"id":3643206,"name":"ontohub","full_name":"ontohub/ontohub","owner":{"login":"ontohub","id":1575984,"avatar_url":"https://avatars.githubusercontent.com/u/1575984?","gravatar_id":"a7f409f3674b52f44a0c6aa8dbef61d1","url":"https://api.github.com/users/ontohub","html_url":"https://github.com/ontohub","followers_url":"https://api.github.com/users/ontohub/followers","following_url":"https://api.github.com/users/ontohub/following{/other_user}","gists_url":"https://api.github.com/users/ontohub/gists{/gist_id}","starred_url":"https://api.github.com/users/ontohub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ontohub/subscriptions","organizations_url":"https://api.github.com/users/ontohub/orgs","repos_url":"https://api.github.com/users/ontohub/repos","events_url":"https://api.github.com/users/ontohub/events{/privacy}","received_events_url":"https://api.github.com/users/ontohub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ontohub/ontohub","description":"A web-based repository for distributed ontologies.","fork":false,"url":"https://api.github.com/repos/ontohub/ontohub","forks_url":"https://api.github.com/repos/ontohub/ontohub/forks","keys_url":"https://api.github.com/repos/ontohub/ontohub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ontohub/ontohub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ontohub/ontohub/teams","hooks_url":"https://api.github.com/repos/ontohub/ontohub/hooks","issue_events_url":"https://api.github.com/repos/ontohub/ontohub/issues/events{/number}","events_url":"https://api.github.com/repos/ontohub/ontohub/events","assignees_url":"https://api.github.com/repos/ontohub/ontohub/assignees{/user}","branches_url":"https://api.github.com/repos/ontohub/ontohub/branches{/branch}","tags_url":"https://api.github.com/repos/ontohub/ontohub/tags","blobs_url":"https://api.github.com/repos/ontohub/ontohub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ontohub/ontohub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ontohub/ontohub/git/refs{/sha}","trees_url":"https://api.github.com/repos/ontohub/ontohub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ontohub/ontohub/statuses/{sha}","languages_url":"https://api.github.com/repos/ontohub/ontohub/languages","stargazers_url":"https://api.github.com/repos/ontohub/ontohub/stargazers","contributors_url":"https://api.github.com/repos/ontohub/ontohub/contributors","subscribers_url":"https://api.github.com/repos/ontohub/ontohub/subscribers","subscription_url":"https://api.github.com/repos/ontohub/ontohub/subscription","commits_url":"https://api.github.com/repos/ontohub/ontohub/commits{/sha}","git_commits_url":"https://api.github.com/repos/ontohub/ontohub/git/commits{/sha}","comments_url":"https://api.github.com/repos/ontohub/ontohub/comments{/number}","issue_comment_url":"https://api.github.com/repos/ontohub/ontohub/issues/comments/{number}","contents_url":"https://api.github.com/repos/ontohub/ontohub/contents/{+path}","compare_url":"https://api.github.com/repos/ontohub/ontohub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ontohub/ontohub/merges","archive_url":"https://api.github.com/repos/ontohub/ontohub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ontohub/ontohub/downloads","issues_url":"https://api.github.com/repos/ontohub/ontohub/issues{/number}","pulls_url":"https://api.github.com/repos/ontohub/ontohub/pulls{/number}","milestones_url":"https://api.github.com/repos/ontohub/ontohub/milestones{/number}","notifications_url":"https://api.github.com/repos/ontohub/ontohub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ontohub/ontohub/labels{/name}","releases_url":"https://api.github.com/repos/ontohub/ontohub/releases{/id}","created_at":"2012-03-06T22:05:27Z","updated_at":"2014-06-22T12:58:34Z","pushed_at":"2014-06-22T12:58:33Z","git_url":"git://github.com/ontohub/ontohub.git","ssh_url":"git@github.com:ontohub/ontohub.git","clone_url":"https://github.com/ontohub/ontohub.git","svn_url":"https://github.com/ontohub/ontohub","homepage":"","size":34623,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":310,"forks":4,"open_issues":310,"watchers":13,"default_branch":"staging"}},"base":{"label":"ontohub:staging","ref":"staging","sha":"cff4154d53f25b5d31ef04b3cb7dee9e3e0f439a","user":{"login":"ontohub","id":1575984,"avatar_url":"https://avatars.githubusercontent.com/u/1575984?","gravatar_id":"a7f409f3674b52f44a0c6aa8dbef61d1","url":"https://api.github.com/users/ontohub","html_url":"https://github.com/ontohub","followers_url":"https://api.github.com/users/ontohub/followers","following_url":"https://api.github.com/users/ontohub/following{/other_user}","gists_url":"https://api.github.com/users/ontohub/gists{/gist_id}","starred_url":"https://api.github.com/users/ontohub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ontohub/subscriptions","organizations_url":"https://api.github.com/users/ontohub/orgs","repos_url":"https://api.github.com/users/ontohub/repos","events_url":"https://api.github.com/users/ontohub/events{/privacy}","received_events_url":"https://api.github.com/users/ontohub/received_events","type":"Organization","site_admin":false},"repo":{"id":3643206,"name":"ontohub","full_name":"ontohub/ontohub","owner":{"login":"ontohub","id":1575984,"avatar_url":"https://avatars.githubusercontent.com/u/1575984?","gravatar_id":"a7f409f3674b52f44a0c6aa8dbef61d1","url":"https://api.github.com/users/ontohub","html_url":"https://github.com/ontohub","followers_url":"https://api.github.com/users/ontohub/followers","following_url":"https://api.github.com/users/ontohub/following{/other_user}","gists_url":"https://api.github.com/users/ontohub/gists{/gist_id}","starred_url":"https://api.github.com/users/ontohub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ontohub/subscriptions","organizations_url":"https://api.github.com/users/ontohub/orgs","repos_url":"https://api.github.com/users/ontohub/repos","events_url":"https://api.github.com/users/ontohub/events{/privacy}","received_events_url":"https://api.github.com/users/ontohub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ontohub/ontohub","description":"A web-based repository for distributed ontologies.","fork":false,"url":"https://api.github.com/repos/ontohub/ontohub","forks_url":"https://api.github.com/repos/ontohub/ontohub/forks","keys_url":"https://api.github.com/repos/ontohub/ontohub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ontohub/ontohub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ontohub/ontohub/teams","hooks_url":"https://api.github.com/repos/ontohub/ontohub/hooks","issue_events_url":"https://api.github.com/repos/ontohub/ontohub/issues/events{/number}","events_url":"https://api.github.com/repos/ontohub/ontohub/events","assignees_url":"https://api.github.com/repos/ontohub/ontohub/assignees{/user}","branches_url":"https://api.github.com/repos/ontohub/ontohub/branches{/branch}","tags_url":"https://api.github.com/repos/ontohub/ontohub/tags","blobs_url":"https://api.github.com/repos/ontohub/ontohub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ontohub/ontohub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ontohub/ontohub/git/refs{/sha}","trees_url":"https://api.github.com/repos/ontohub/ontohub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ontohub/ontohub/statuses/{sha}","languages_url":"https://api.github.com/repos/ontohub/ontohub/languages","stargazers_url":"https://api.github.com/repos/ontohub/ontohub/stargazers","contributors_url":"https://api.github.com/repos/ontohub/ontohub/contributors","subscribers_url":"https://api.github.com/repos/ontohub/ontohub/subscribers","subscription_url":"https://api.github.com/repos/ontohub/ontohub/subscription","commits_url":"https://api.github.com/repos/ontohub/ontohub/commits{/sha}","git_commits_url":"https://api.github.com/repos/ontohub/ontohub/git/commits{/sha}","comments_url":"https://api.github.com/repos/ontohub/ontohub/comments{/number}","issue_comment_url":"https://api.github.com/repos/ontohub/ontohub/issues/comments/{number}","contents_url":"https://api.github.com/repos/ontohub/ontohub/contents/{+path}","compare_url":"https://api.github.com/repos/ontohub/ontohub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ontohub/ontohub/merges","archive_url":"https://api.github.com/repos/ontohub/ontohub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ontohub/ontohub/downloads","issues_url":"https://api.github.com/repos/ontohub/ontohub/issues{/number}","pulls_url":"https://api.github.com/repos/ontohub/ontohub/pulls{/number}","milestones_url":"https://api.github.com/repos/ontohub/ontohub/milestones{/number}","notifications_url":"https://api.github.com/repos/ontohub/ontohub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ontohub/ontohub/labels{/name}","releases_url":"https://api.github.com/repos/ontohub/ontohub/releases{/id}","created_at":"2012-03-06T22:05:27Z","updated_at":"2014-06-22T12:58:34Z","pushed_at":"2014-06-22T12:58:33Z","git_url":"git://github.com/ontohub/ontohub.git","ssh_url":"git@github.com:ontohub/ontohub.git","clone_url":"https://github.com/ontohub/ontohub.git","svn_url":"https://github.com/ontohub/ontohub","homepage":"","size":34623,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":310,"forks":4,"open_issues":310,"watchers":13,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/911"},"html":{"href":"https://github.com/ontohub/ontohub/pull/911"},"issue":{"href":"https://api.github.com/repos/ontohub/ontohub/issues/911"},"comments":{"href":"https://api.github.com/repos/ontohub/ontohub/issues/911/comments"},"review_comments":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/911/comments"},"review_comment":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/911/commits"},"statuses":{"href":"https://api.github.com/repos/ontohub/ontohub/statuses/7130e2fca7fc7d8c52c1234977954592c12cdbd0"}}}}