GitHub PullRequestReviewCommentEvent at 2014-05-04 23:23:22
Repository: rspec-core
Actor: myronmarston
Payload: {"comment":{"url":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/12264958","id":12264958,"diff_hunk":"@@ -0,0 +1,65 @@\n+require 'spec_helper'\n+require 'rspec/core/notifications'\n+\n+RSpec.describe \"FailedExampleNotification\" do\n+  # ported from `base_formatter_spec` should be refactored by final\n+  describe \"#read_failed_line\" do\n+    let(:example) { double(:Example, :file_path => __FILE__, :execution_result => double(:exception => exception)) }\n+    let(:notification) { ::RSpec::Core::Notifications::FailedExampleNotification.new(example) }\n+\n+    context \"when backtrace is a heterogeneous language stack trace\" do\n+      let(:exception) do\n+        double(:Exception, :backtrace => [\n+          \"at Object.prototypeMethod (foo:331:18)\",\n+          \"at Array.forEach (native)\",\n+          \"at a_named_javascript_function (/some/javascript/file.js:39:5)\",\n+          \"/some/line/of/ruby.rb:14\"\n+        ])\n+      end\n+\n+      it \"is handled gracefully\" do\n+        expect { notification.send(:read_failed_line) }.not_to raise_error\n+      end\n+    end\n+\n+    context \"when backtrace will generate a security error\" do","path":"spec/rspec/core/notifications_spec.rb","position":25,"original_position":25,"commit_id":"bac8e9d678a3f378cd57acf2e3e9d3104dfdd8ce","original_commit_id":"bac8e9d678a3f378cd57acf2e3e9d3104dfdd8ce","user":{"login":"myronmarston","id":49391,"avatar_url":"https://avatars.githubusercontent.com/u/49391?","gravatar_id":"42d4590355a1404230fbc9aff4dd377b","url":"https://api.github.com/users/myronmarston","html_url":"https://github.com/myronmarston","followers_url":"https://api.github.com/users/myronmarston/followers","following_url":"https://api.github.com/users/myronmarston/following{/other_user}","gists_url":"https://api.github.com/users/myronmarston/gists{/gist_id}","starred_url":"https://api.github.com/users/myronmarston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myronmarston/subscriptions","organizations_url":"https://api.github.com/users/myronmarston/orgs","repos_url":"https://api.github.com/users/myronmarston/repos","events_url":"https://api.github.com/users/myronmarston/events{/privacy}","received_events_url":"https://api.github.com/users/myronmarston/received_events","type":"User","site_admin":false},"body":"I'm confused...how will the backtrace generate a security error?","created_at":"2014-05-04T23:23:22Z","updated_at":"2014-05-04T23:23:22Z","html_url":"https://github.com/rspec/rspec-core/pull/1510#discussion_r12264958","pull_request_url":"https://api.github.com/repos/rspec/rspec-core/pulls/1510","_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/12264958"},"html":{"href":"https://github.com/rspec/rspec-core/pull/1510#discussion_r12264958"},"pull_request":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/1510"}}}}