GitHub PullRequestReviewCommentEvent at 2014-09-14 09:53:12
Repository: phpcheckstyle
Actor: anorakci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/comments/17518399","id":17518399,"diff_hunk":"@@ -564,30 +580,39 @@ private function _processFile($filename) {\n \t\t\t\t$this->_writeError('noFileCloseTag', $this->_getMessage('END_FILE_CLOSE_TAG'));\n \t\t\t}\n \t\t}\n-\t\t\n+\n \t\t// Inner HTML is OK for views but not for other classes (controllers, models, ...)\n \t\tif ($this->_isActive('noFileFinishHTML') && !$this->_isView) {\n \t\t\tif ($this->tokenizer->checkPreviousToken(T_INLINE_HTML)) {\n \t\t\t\t$this->_writeError('noFileFinishHTML', $this->_getMessage('END_FILE_INLINE_HTML'));\n \t\t\t}\n \t\t}\n-\t\t\n+\n \t\t// Check for unused private functions\n \t\t$this->_checkUnusedPrivateFunctions();\n-\t\t\n+\n \t\t// Check for unused variables\n \t\t$this->_checkUnusedVariables();\n-\t\t\n+\n \t\tif ($this->_ncssFileClasses > 0 || $this->_ncssFileInterfaces > 0) {\n \t\t\t// Test the file name, only if it contains a class or interface\n \t\t\t$this->_checkFileNaming();\n \t\t}\n-\t\t\n+\n \t\t// Write the count of lines for this file\n \t\tif ($this->_lineCountReporter != null) {\n-\t\t\t$this->_lineCountReporter->writeFileCount($this->_packageName, $this->_ncssFileClasses, $this->_ncssFileInterfaces, $this->_ncssFileFunctions, $this->_ncssFileLinesOfCode, $this->_ncssFilePhpdoc, $this->_ncssFileLinesPhpdoc, $this->_ncssFileSingleComment, $this->_ncssFileMultiComment);\n+\t\t\t$this->_lineCountReporter->writeFileCount(\n+\t\t\t\t$this->_packageName,\n+\t\t\t\t$this->_ncssFileClasses,\n+\t\t\t\t$this->_ncssFileInterfaces,\n+\t\t\t\t$this->_ncssFileFunctions,\n+\t\t\t\t$this->_ncssFileLinesOfCode,\n+\t\t\t\t$this->_ncssFilePhpdoc,\n+\t\t\t\t$this->_ncssFileLinesPhpdoc,\n+\t\t\t\t$this->_ncssFileSingleComment,\n+\t\t\t\t$this->_ncssFileMultiComment);","path":"src/PHPCheckstyle/PHPCheckstyle.php","position":433,"original_position":433,"commit_id":"603d77801dfb9c34acb2f32982b3b1e658e507fa","original_commit_id":"603d77801dfb9c34acb2f32982b3b1e658e507fa","user":{"login":"anorakci","id":8274616,"avatar_url":"https://avatars.githubusercontent.com/u/8274616?v=2","gravatar_id":"d9d27fd67b00804bb2df0ab2f0ec6466","url":"https://api.github.com/users/anorakci","html_url":"https://github.com/anorakci","followers_url":"https://api.github.com/users/anorakci/followers","following_url":"https://api.github.com/users/anorakci/following{/other_user}","gists_url":"https://api.github.com/users/anorakci/gists{/gist_id}","starred_url":"https://api.github.com/users/anorakci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anorakci/subscriptions","organizations_url":"https://api.github.com/users/anorakci/orgs","repos_url":"https://api.github.com/users/anorakci/repos","events_url":"https://api.github.com/users/anorakci/events{/privacy}","received_events_url":"https://api.github.com/users/anorakci/received_events","type":"User","site_admin":false},"body":"Consider using a strict comparison operator instead of !=.","created_at":"2014-09-14T09:53:12Z","updated_at":"2014-09-14T09:53:12Z","html_url":"https://github.com/PHPCheckstyle/phpcheckstyle/pull/37#discussion_r17518399","pull_request_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/comments/17518399"},"html":{"href":"https://github.com/PHPCheckstyle/phpcheckstyle/pull/37#discussion_r17518399"},"pull_request":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/37","id":21202134,"html_url":"https://github.com/PHPCheckstyle/phpcheckstyle/pull/37","diff_url":"https://github.com/PHPCheckstyle/phpcheckstyle/pull/37.diff","patch_url":"https://github.com/PHPCheckstyle/phpcheckstyle/pull/37.patch","issue_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/issues/37","number":37,"state":"open","locked":false,"title":"Improved whitespace","user":{"login":"rr-","id":1045476,"avatar_url":"https://avatars.githubusercontent.com/u/1045476?v=2","gravatar_id":"e84f1d0ef6fe58cc471a14d11fa81a24","url":"https://api.github.com/users/rr-","html_url":"https://github.com/rr-","followers_url":"https://api.github.com/users/rr-/followers","following_url":"https://api.github.com/users/rr-/following{/other_user}","gists_url":"https://api.github.com/users/rr-/gists{/gist_id}","starred_url":"https://api.github.com/users/rr-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rr-/subscriptions","organizations_url":"https://api.github.com/users/rr-/orgs","repos_url":"https://api.github.com/users/rr-/repos","events_url":"https://api.github.com/users/rr-/events{/privacy}","received_events_url":"https://api.github.com/users/rr-/received_events","type":"User","site_admin":false},"body":"There were lots of trailing spaces and mixed tabs/spaces in .XML, which looked really ugly in my editor.","created_at":"2014-09-14T09:10:53Z","updated_at":"2014-09-14T09:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76dee32e6cd73a0b8a15da28c9c832281dda5cc2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/37/commits","review_comments_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/37/comments","review_comment_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/issues/37/comments","statuses_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/statuses/603d77801dfb9c34acb2f32982b3b1e658e507fa","head":{"label":"rr-:whitespace","ref":"whitespace","sha":"603d77801dfb9c34acb2f32982b3b1e658e507fa","user":{"login":"rr-","id":1045476,"avatar_url":"https://avatars.githubusercontent.com/u/1045476?v=2","gravatar_id":"e84f1d0ef6fe58cc471a14d11fa81a24","url":"https://api.github.com/users/rr-","html_url":"https://github.com/rr-","followers_url":"https://api.github.com/users/rr-/followers","following_url":"https://api.github.com/users/rr-/following{/other_user}","gists_url":"https://api.github.com/users/rr-/gists{/gist_id}","starred_url":"https://api.github.com/users/rr-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rr-/subscriptions","organizations_url":"https://api.github.com/users/rr-/orgs","repos_url":"https://api.github.com/users/rr-/repos","events_url":"https://api.github.com/users/rr-/events{/privacy}","received_events_url":"https://api.github.com/users/rr-/received_events","type":"User","site_admin":false},"repo":{"id":24017054,"name":"phpcheckstyle","full_name":"rr-/phpcheckstyle","owner":{"login":"rr-","id":1045476,"avatar_url":"https://avatars.githubusercontent.com/u/1045476?v=2","gravatar_id":"e84f1d0ef6fe58cc471a14d11fa81a24","url":"https://api.github.com/users/rr-","html_url":"https://github.com/rr-","followers_url":"https://api.github.com/users/rr-/followers","following_url":"https://api.github.com/users/rr-/following{/other_user}","gists_url":"https://api.github.com/users/rr-/gists{/gist_id}","starred_url":"https://api.github.com/users/rr-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rr-/subscriptions","organizations_url":"https://api.github.com/users/rr-/orgs","repos_url":"https://api.github.com/users/rr-/repos","events_url":"https://api.github.com/users/rr-/events{/privacy}","received_events_url":"https://api.github.com/users/rr-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rr-/phpcheckstyle","description":"PHPCheckstyle is an open-source tool that helps PHP programmers adhere to certain coding conventions.","fork":true,"url":"https://api.github.com/repos/rr-/phpcheckstyle","forks_url":"https://api.github.com/repos/rr-/phpcheckstyle/forks","keys_url":"https://api.github.com/repos/rr-/phpcheckstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rr-/phpcheckstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rr-/phpcheckstyle/teams","hooks_url":"https://api.github.com/repos/rr-/phpcheckstyle/hooks","issue_events_url":"https://api.github.com/repos/rr-/phpcheckstyle/issues/events{/number}","events_url":"https://api.github.com/repos/rr-/phpcheckstyle/events","assignees_url":"https://api.github.com/repos/rr-/phpcheckstyle/assignees{/user}","branches_url":"https://api.github.com/repos/rr-/phpcheckstyle/branches{/branch}","tags_url":"https://api.github.com/repos/rr-/phpcheckstyle/tags","blobs_url":"https://api.github.com/repos/rr-/phpcheckstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rr-/phpcheckstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rr-/phpcheckstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rr-/phpcheckstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rr-/phpcheckstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/rr-/phpcheckstyle/languages","stargazers_url":"https://api.github.com/repos/rr-/phpcheckstyle/stargazers","contributors_url":"https://api.github.com/repos/rr-/phpcheckstyle/contributors","subscribers_url":"https://api.github.com/repos/rr-/phpcheckstyle/subscribers","subscription_url":"https://api.github.com/repos/rr-/phpcheckstyle/subscription","commits_url":"https://api.github.com/repos/rr-/phpcheckstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rr-/phpcheckstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rr-/phpcheckstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rr-/phpcheckstyle/issues/comments/{number}","contents_url":"https://api.github.com/repos/rr-/phpcheckstyle/contents/{+path}","compare_url":"https://api.github.com/repos/rr-/phpcheckstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rr-/phpcheckstyle/merges","archive_url":"https://api.github.com/repos/rr-/phpcheckstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rr-/phpcheckstyle/downloads","issues_url":"https://api.github.com/repos/rr-/phpcheckstyle/issues{/number}","pulls_url":"https://api.github.com/repos/rr-/phpcheckstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/rr-/phpcheckstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/rr-/phpcheckstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rr-/phpcheckstyle/labels{/name}","releases_url":"https://api.github.com/repos/rr-/phpcheckstyle/releases{/id}","created_at":"2014-09-14T08:20:19Z","updated_at":"2014-09-14T08:53:57Z","pushed_at":"2014-09-14T09:53:03Z","git_url":"git://github.com/rr-/phpcheckstyle.git","ssh_url":"git@github.com:rr-/phpcheckstyle.git","clone_url":"https://github.com/rr-/phpcheckstyle.git","svn_url":"https://github.com/rr-/phpcheckstyle","homepage":"https://code.google.com/p/phpcheckstyle/","size":2116,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PHPCheckstyle:master","ref":"master","sha":"7935d2270c442b5dd9db4e3800f404874c9fd08e","user":{"login":"PHPCheckstyle","id":8709693,"avatar_url":"https://avatars.githubusercontent.com/u/8709693?v=2","gravatar_id":null,"url":"https://api.github.com/users/PHPCheckstyle","html_url":"https://github.com/PHPCheckstyle","followers_url":"https://api.github.com/users/PHPCheckstyle/followers","following_url":"https://api.github.com/users/PHPCheckstyle/following{/other_user}","gists_url":"https://api.github.com/users/PHPCheckstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPCheckstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPCheckstyle/subscriptions","organizations_url":"https://api.github.com/users/PHPCheckstyle/orgs","repos_url":"https://api.github.com/users/PHPCheckstyle/repos","events_url":"https://api.github.com/users/PHPCheckstyle/events{/privacy}","received_events_url":"https://api.github.com/users/PHPCheckstyle/received_events","type":"Organization","site_admin":false},"repo":{"id":23109512,"name":"phpcheckstyle","full_name":"PHPCheckstyle/phpcheckstyle","owner":{"login":"PHPCheckstyle","id":8709693,"avatar_url":"https://avatars.githubusercontent.com/u/8709693?v=2","gravatar_id":null,"url":"https://api.github.com/users/PHPCheckstyle","html_url":"https://github.com/PHPCheckstyle","followers_url":"https://api.github.com/users/PHPCheckstyle/followers","following_url":"https://api.github.com/users/PHPCheckstyle/following{/other_user}","gists_url":"https://api.github.com/users/PHPCheckstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPCheckstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPCheckstyle/subscriptions","organizations_url":"https://api.github.com/users/PHPCheckstyle/orgs","repos_url":"https://api.github.com/users/PHPCheckstyle/repos","events_url":"https://api.github.com/users/PHPCheckstyle/events{/privacy}","received_events_url":"https://api.github.com/users/PHPCheckstyle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PHPCheckstyle/phpcheckstyle","description":"PHPCheckstyle is an open-source tool that helps PHP programmers adhere to certain coding conventions.","fork":false,"url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle","forks_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/forks","keys_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/teams","hooks_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/hooks","issue_events_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/issues/events{/number}","events_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/events","assignees_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/assignees{/user}","branches_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/branches{/branch}","tags_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/tags","blobs_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/languages","stargazers_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/stargazers","contributors_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/contributors","subscribers_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/subscribers","subscription_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/subscription","commits_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/issues/comments/{number}","contents_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/contents/{+path}","compare_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/merges","archive_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/downloads","issues_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/issues{/number}","pulls_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/labels{/name}","releases_url":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/releases{/id}","created_at":"2014-08-19T12:39:34Z","updated_at":"2014-09-09T13:10:03Z","pushed_at":"2014-09-14T09:19:02Z","git_url":"git://github.com/PHPCheckstyle/phpcheckstyle.git","ssh_url":"git@github.com:PHPCheckstyle/phpcheckstyle.git","clone_url":"https://github.com/PHPCheckstyle/phpcheckstyle.git","svn_url":"https://github.com/PHPCheckstyle/phpcheckstyle","homepage":"https://code.google.com/p/phpcheckstyle/","size":2116,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/37"},"html":{"href":"https://github.com/PHPCheckstyle/phpcheckstyle/pull/37"},"issue":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/issues/37"},"comments":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/PHPCheckstyle/phpcheckstyle/statuses/603d77801dfb9c34acb2f32982b3b1e658e507fa"}}}}