GitHub PullRequestReviewCommentEvent at 2014-08-15 15:12:22
Repository: cmssw
Actor: Dr15Jones
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/16296945","id":16296945,"diff_hunk":"@@ -42,14 +42,15 @@ namespace fwlite\n \n    edm::BasicHandle\n    LuminosityBlockBase::getByLabelImpl(std::type_info const& iWrapperInfo, std::type_info const& /*iProductInfo*/, const edm::InputTag& iTag) const {\n-      edm::WrapperHolder edp;\n+      edm::EDProduct* prod = nullptr;\n+      void* prodPtr = &prod;\n       getByLabel(iWrapperInfo,\n                  iTag.label().c_str(),\n                  iTag.instance().empty()?static_cast<char const*>(0):iTag.instance().c_str(),\n                  iTag.process().empty()?static_cast<char const*> (0):iTag.process().c_str(),\n-                 edp);\n-      if(!edp.isValid() || !edp.isPresent()) {\n-         edm::TypeID productType(iWrapperInfo);\n+                 prodPtr);\n+      if(prod == nullptr) {","path":"DataFormats/FWLite/src/LuminosityBlockBase.cc","position":15,"original_position":15,"commit_id":"ea81374d77786a2490f647952aed9fe8d52aef5a","original_commit_id":"ea81374d77786a2490f647952aed9fe8d52aef5a","user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?v=2","gravatar_id":"77cceb256cbe19359ed41d214beab6e9","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"body":"no ```isPresent``` check?","created_at":"2014-08-15T15:12:22Z","updated_at":"2014-08-15T15:12:22Z","html_url":"https://github.com/cms-sw/cmssw/pull/4958#discussion_r16296945","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/4958","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/16296945"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/4958#discussion_r16296945"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/4958"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/4958","id":19847381,"html_url":"https://github.com/cms-sw/cmssw/pull/4958","diff_url":"https://github.com/cms-sw/cmssw/pull/4958.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/4958.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/4958","number":4958,"state":"open","locked":false,"title":"Don't check dictionaries unnecessarily","user":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=2","gravatar_id":"7aedf822be990e83c1a6fe96cf5b0d13","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"body":"This is the fix for the problem discussed at the Core Software meeting on Tuesday.  Dictionaries were read for every object that was ever in the file, rather than as needed.\r\nTechnically, what this pull request does is reverse what was done in April 2011, which removed EDProduct as a base class of Wrapper.  This was done because the presence of the base class caused an extra ROOT subbranch for each EDProduct.  It turns out that the extra subbranch was due to a ROOT bug, which has now been fixed.  Restoring EDProduct as a base class does not change the format of persistent files, or cause backward compatibility issues.  What it does do is remove a lot of unnecessary dictionary processing, and also reduces the amount of source code by 571 lines.  It is also absolutely necessary for ROOT 6.\r\nI ran all framework unit tests and the short relval matrix on this request, and everything passed.\r\nThe very small changes outside the framework are the minimal necessary adaptations to the framework change.","created_at":"2014-08-15T14:43:46Z","updated_at":"2014-08-15T15:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5200996145abf59c78651ccbc323cbc4c9652a0c","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/48","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/48/labels","id":703278,"number":48,"title":"Next CMSSW_7_2_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=2","gravatar_id":"c37878ac7a56b492e4f8df2a94abbd49","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":280,"state":"open","created_at":"2014-06-27T09:05:00Z","updated_at":"2014-08-15T15:07:43Z","due_on":"2014-07-29T07:00:00Z"},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/4958/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/4958/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/4958/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/ea81374d77786a2490f647952aed9fe8d52aef5a","head":{"label":"wmtan:AvoidReadingDictionariesUnnecessarily","ref":"AvoidReadingDictionariesUnnecessarily","sha":"ea81374d77786a2490f647952aed9fe8d52aef5a","user":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=2","gravatar_id":"7aedf822be990e83c1a6fe96cf5b0d13","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"repo":{"id":10977262,"name":"cmssw","full_name":"wmtan/cmssw","owner":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=2","gravatar_id":"7aedf822be990e83c1a6fe96cf5b0d13","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmtan/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/wmtan/cmssw","forks_url":"https://api.github.com/repos/wmtan/cmssw/forks","keys_url":"https://api.github.com/repos/wmtan/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmtan/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmtan/cmssw/teams","hooks_url":"https://api.github.com/repos/wmtan/cmssw/hooks","issue_events_url":"https://api.github.com/repos/wmtan/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/wmtan/cmssw/events","assignees_url":"https://api.github.com/repos/wmtan/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/wmtan/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/wmtan/cmssw/tags","blobs_url":"https://api.github.com/repos/wmtan/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmtan/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmtan/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmtan/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmtan/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/wmtan/cmssw/languages","stargazers_url":"https://api.github.com/repos/wmtan/cmssw/stargazers","contributors_url":"https://api.github.com/repos/wmtan/cmssw/contributors","subscribers_url":"https://api.github.com/repos/wmtan/cmssw/subscribers","subscription_url":"https://api.github.com/repos/wmtan/cmssw/subscription","commits_url":"https://api.github.com/repos/wmtan/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmtan/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmtan/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmtan/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmtan/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/wmtan/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmtan/cmssw/merges","archive_url":"https://api.github.com/repos/wmtan/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmtan/cmssw/downloads","issues_url":"https://api.github.com/repos/wmtan/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/wmtan/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/wmtan/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/wmtan/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmtan/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/wmtan/cmssw/releases{/id}","created_at":"2013-06-26T19:44:14Z","updated_at":"2014-06-24T22:32:58Z","pushed_at":"2014-08-15T14:28:19Z","git_url":"git://github.com/wmtan/cmssw.git","ssh_url":"git@github.com:wmtan/cmssw.git","clone_url":"https://github.com/wmtan/cmssw.git","svn_url":"https://github.com/wmtan/cmssw","homepage":null,"size":451809,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_2_X","ref":"CMSSW_7_2_X","sha":"df9f1232bc8a4d6b40c79efd7f554ec8ef9fa2f7","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=2","gravatar_id":"d5b5dd8d1e3a16502b38562e08e0635c","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=2","gravatar_id":"d5b5dd8d1e3a16502b38562e08e0635c","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2014-08-06T15:54:45Z","pushed_at":"2014-08-15T13:03:15Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"cms-sw.github.io/cmssw","size":687407,"stargazers_count":360,"watchers_count":360,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":955,"mirror_url":null,"open_issues_count":66,"forks":955,"open_issues":66,"watchers":360,"default_branch":"CMSSW_7_2_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/4958"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/4958"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/4958"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/4958/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/4958/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/4958/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/ea81374d77786a2490f647952aed9fe8d52aef5a"}}}}