GitHub PullRequestReviewCommentEvent at 2014-02-26 10:26:35
Repository: ServiceControl
Actor: andreasohlund
Payload: {"comment":{"url":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments/10074599","id":10074599,"diff_hunk":"@@ -0,0 +1,17 @@\n+﻿namespace ServiceControl.EventLog.Definitions\n+{\n+    using Contracts.HeartbeatMonitoring;\n+\n+    public class EndpointStartedDefinition : EventLogMappingDefinition<EndpointStarted>\n+    {\n+        public EndpointStartedDefinition()\n+        {\n+            Description(m => string.Format(\"Endpoint '{0}' started at: {1} Host: {2}\", m.Endpoint, m.StartedAt,m.HostDisplayName));\n+\n+            RelatesToEndpoint(m => m.Endpoint);\n+            RelatesToHost(m => m.HostId.ToString());","path":"src/ServiceControl/EventLog/Definitions/EndpointStartedDefinition.cs","position":12,"original_position":12,"commit_id":"8760a4fccf1c6d0a35bf4fdbf787ebcc8122aa7f","original_commit_id":"8760a4fccf1c6d0a35bf4fdbf787ebcc8122aa7f","user":{"login":"andreasohlund","id":125028,"avatar_url":"https://gravatar.com/avatar/fcf0ae49d7c8ea7aa4beb23645c7ae4a?d=https%3A%2F%2Fidenticons.github.com%2Fb62b25801a53795cb2fe1ede7067f0de.png&r=x","gravatar_id":"fcf0ae49d7c8ea7aa4beb23645c7ae4a","url":"https://api.github.com/users/andreasohlund","html_url":"https://github.com/andreasohlund","followers_url":"https://api.github.com/users/andreasohlund/followers","following_url":"https://api.github.com/users/andreasohlund/following{/other_user}","gists_url":"https://api.github.com/users/andreasohlund/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasohlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasohlund/subscriptions","organizations_url":"https://api.github.com/users/andreasohlund/orgs","repos_url":"https://api.github.com/users/andreasohlund/repos","events_url":"https://api.github.com/users/andreasohlund/events{/privacy}","received_events_url":"https://api.github.com/users/andreasohlund/received_events","type":"User","site_admin":false},"body":"Think we need both, since the plan is to later link to a \"hostdetails\"\nusing that id as key. Since we have the  HostDisplayName in the description\nI think we're good?\n\n\nOn Wed, Feb 26, 2014 at 11:03 AM, John Simons <notifications@github.com>wrote:\n\n> In src/ServiceControl/EventLog/Definitions/EndpointStartedDefinition.cs:\n>\n> > @@ -0,0 +1,17 @@\n> > +namespace ServiceControl.EventLog.Definitions\n> > +{\n> > +    using Contracts.HeartbeatMonitoring;\n> > +\n> > +    public class EndpointStartedDefinition : EventLogMappingDefinition<EndpointStarted>\n> > +    {\n> > +        public EndpointStartedDefinition()\n> > +        {\n> > +            Description(m => string.Format(\"Endpoint '{0}' started at: {1} Host: {2}\", m.Endpoint, m.StartedAt,m.HostDisplayName));\n> > +\n> > +            RelatesToEndpoint(m => m.Endpoint);\n> > +            RelatesToHost(m => m.HostId.ToString());\n>\n> Should this be the hostdisplayname?\n>\n> --\n> Reply to this email directly or view it on GitHub<https://github.com/Particular/ServiceControl/pull/196/files#r10073849>\n> .\n>","created_at":"2014-02-26T10:26:35Z","updated_at":"2014-02-26T10:26:35Z","html_url":"https://github.com/Particular/ServiceControl/pull/196#discussion_r10074599","pull_request_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments/10074599"},"html":{"href":"https://github.com/Particular/ServiceControl/pull/196#discussion_r10074599"},"pull_request":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/196"}}}}