GitHub PullRequestEvent at 2014-03-25 22:32:13
Repository: three.js
Actor: eric79
Payload: {"action":"opened","number":4608,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/4608","id":13980956,"html_url":"https://github.com/mrdoob/three.js/pull/4608","diff_url":"https://github.com/mrdoob/three.js/pull/4608.diff","patch_url":"https://github.com/mrdoob/three.js/pull/4608.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/4608","number":4608,"state":"open","title":"Differentiate between heightfields and normalmaps and treat each appropriately","user":{"login":"eric79","id":3160246,"avatar_url":"https://avatars.githubusercontent.com/u/3160246?","gravatar_id":"4415aa6694e175736b82fc39ae6f1e5e","url":"https://api.github.com/users/eric79","html_url":"https://github.com/eric79","followers_url":"https://api.github.com/users/eric79/followers","following_url":"https://api.github.com/users/eric79/following{/other_user}","gists_url":"https://api.github.com/users/eric79/gists{/gist_id}","starred_url":"https://api.github.com/users/eric79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric79/subscriptions","organizations_url":"https://api.github.com/users/eric79/orgs","repos_url":"https://api.github.com/users/eric79/repos","events_url":"https://api.github.com/users/eric79/events{/privacy}","received_events_url":"https://api.github.com/users/eric79/received_events","type":"User","site_admin":false},"body":"Right now the code assumes that any `bump` property is a normal map, which might not be a good assumption (it turns out not to be for some of our models).  This change reads the attribute from the collada model and reacts appropriately (treating it as a height field or normal map).\r\n\r\n@BrettASwift, thank you for your help with this fix.","created_at":"2014-03-25T22:32:12Z","updated_at":"2014-03-25T22:32:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/4608/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/4608/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/4608/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/ae02c24c4f57ebd2303e80cd2f60c29d9f7fd354","head":{"label":"virtual-world-framework:heightfields-and-normalmaps","ref":"heightfields-and-normalmaps","sha":"ae02c24c4f57ebd2303e80cd2f60c29d9f7fd354","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":8609109,"name":"three.js","full_name":"virtual-world-framework/three.js","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/virtual-world-framework/three.js","forks_url":"https://api.github.com/repos/virtual-world-framework/three.js/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/three.js/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/three.js/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/three.js/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/three.js/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/three.js/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/three.js/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/three.js/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/three.js/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/three.js/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/three.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/three.js/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/three.js/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/three.js/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/three.js/releases{/id}","created_at":"2013-03-06T17:33:33Z","updated_at":"2014-03-25T22:32:12Z","pushed_at":"2014-03-25T22:28:30Z","git_url":"git://github.com/virtual-world-framework/three.js.git","ssh_url":"git@github.com:virtual-world-framework/three.js.git","clone_url":"https://github.com/virtual-world-framework/three.js.git","svn_url":"https://github.com/virtual-world-framework/three.js","homepage":"http://threejs.org/","size":227627,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"eabdc8968641fe3f903ee2d637f33530c48be078","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?","gravatar_id":"a00211a1e1aa4fe920302e7b76da0d91","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?","gravatar_id":"a00211a1e1aa4fe920302e7b76da0d91","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","created_at":"2010-03-23T18:58:01Z","updated_at":"2014-03-25T07:31:17Z","pushed_at":"2014-03-25T07:31:19Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":269983,"stargazers_count":14640,"watchers_count":14640,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":3718,"mirror_url":null,"open_issues_count":437,"forks":3718,"open_issues":437,"watchers":14640,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/4608"},"html":{"href":"https://github.com/mrdoob/three.js/pull/4608"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/4608"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/4608/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/4608/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/4608/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/ae02c24c4f57ebd2303e80cd2f60c29d9f7fd354"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":3,"changed_files":1}}