GitHub PullRequestReviewCommentEvent at 2014-09-26 10:35:43
Repository: ogs
Actor: rinkk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/18082892","id":18082892,"diff_hunk":"@@ -111,7 +115,7 @@ class Element\n \t * @param all (default = false)\n \t * @return the number of nodes with respect to the parameter.\n \t */\n-\tvirtual unsigned getNNodes(bool all = false) const = 0;\n+\tvirtual unsigned getNNodes(bool all = true) const = 0;","path":"MeshLib/Elements/Element.h","position":null,"original_position":34,"commit_id":"7fff62499a5d4b35f20b3ae9f857a98b9169edbf","original_commit_id":"cbe3a6b9fbafc5f907562325f325296b69870830","user":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=2","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"body":"some examples that come to mind:\r\n* in I/O this is needed to know how many nodes to read/write for each element (GMSInterface, VTKInterface/Source-object-generation/GMSH/probably also FEFLOW)\r\n* in element-neighbour-computation the dimension of the element signifies the number of (1st order nodes) nodes that need to match so two elements are neighbours\r\n* in element volume computation elements are subdivided based on 1st order nodes (the isPntInElement-test uses this as well)\r\n* in layered mesh generation we need to specify the number of nodes for 3D elements from 2D elements, also we need to specify which nodes are identical to find outcroppings (all of these things either don't work with higher order nodes or would need to be completely re-written)\r\n* MeshRevision subdivides elements based on 1st order nodes\r\n* all element validity tests (coplanar faces, node order, etc.) are based on 1st order nodes\r\n* all element quality metrics are based on 1st order nodes\r\n* mesh to raster mappings or raster to mesh conversion works only on 1st order nodes\r\n* i suppose bounding box tests should only handle 1st order nodes\r\n* mesh to geometry conversion (e.g. for creation of surfaces for boundary condition) can only handle 1st order nodes\r\n* several algorithm would still work but run slower (e.g. testing which nodes are not used in a mesh, property interpolation, etc.)\r\n* for some algorithms I don't know: removal or translation of mesh nodes would probably need to be re-written, for example.\r\n\r\nI suppose there's more, this is mostly what I gathered from looking at the MeshLib file list. I assume the Data Explorer also has its fair share of testing the number of mesh nodes of an element (certainly for displaying things in various dialogs, maybe also some functionality)\r\n","created_at":"2014-09-26T10:35:43Z","updated_at":"2014-09-26T10:35:43Z","html_url":"https://github.com/ufz/ogs/pull/477#discussion_r18082892","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/477","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/18082892"},"html":{"href":"https://github.com/ufz/ogs/pull/477#discussion_r18082892"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/477"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/477","id":21494323,"html_url":"https://github.com/ufz/ogs/pull/477","diff_url":"https://github.com/ufz/ogs/pull/477.diff","patch_url":"https://github.com/ufz/ogs/pull/477.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/477","number":477,"state":"open","locked":false,"title":"[WIP] Supporting higher order nodes","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=2","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE THIS PR! It's not completed yet.\r\n\r\nA list of what to be changed for higher order elements\r\n- Default behavior of `getNNodes()` is changed to return the number of all nodes. currently it returns only base nodes.\r\n- Edge and face nodes are different from linear elements\r\n- Content calculations (i.e. length, area, volume) become different from linear one\r\n- Edge length cannot be used as a search length anymore\r\n- BoostVtuInterface\r\n- We need to somehow be able to get a vector of linear nodes or quadratic nodes or cubic nodes, which will be passed to `MeshSubset`\r\n- Converter from a linear mesh to a higher order one\r\n- some more?\r\n","created_at":"2014-09-19T12:27:43Z","updated_at":"2014-09-26T10:35:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a3c86e1eba8280bd2d3319d94375abe8390b726","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/477/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/477/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/477/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/7fff62499a5d4b35f20b3ae9f857a98b9169edbf","head":{"label":"norihiro-w:support-higher-order","ref":"support-higher-order","sha":"7fff62499a5d4b35f20b3ae9f857a98b9169edbf","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=2","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"repo":{"id":2612310,"name":"ogs","full_name":"norihiro-w/ogs","owner":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=2","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/norihiro-w/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/norihiro-w/ogs","forks_url":"https://api.github.com/repos/norihiro-w/ogs/forks","keys_url":"https://api.github.com/repos/norihiro-w/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norihiro-w/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norihiro-w/ogs/teams","hooks_url":"https://api.github.com/repos/norihiro-w/ogs/hooks","issue_events_url":"https://api.github.com/repos/norihiro-w/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/norihiro-w/ogs/events","assignees_url":"https://api.github.com/repos/norihiro-w/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/norihiro-w/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/norihiro-w/ogs/tags","blobs_url":"https://api.github.com/repos/norihiro-w/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norihiro-w/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norihiro-w/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/norihiro-w/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norihiro-w/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/norihiro-w/ogs/languages","stargazers_url":"https://api.github.com/repos/norihiro-w/ogs/stargazers","contributors_url":"https://api.github.com/repos/norihiro-w/ogs/contributors","subscribers_url":"https://api.github.com/repos/norihiro-w/ogs/subscribers","subscription_url":"https://api.github.com/repos/norihiro-w/ogs/subscription","commits_url":"https://api.github.com/repos/norihiro-w/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/norihiro-w/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/norihiro-w/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/norihiro-w/ogs/issues/comments/{number}","contents_url":"https://api.github.com/repos/norihiro-w/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/norihiro-w/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norihiro-w/ogs/merges","archive_url":"https://api.github.com/repos/norihiro-w/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norihiro-w/ogs/downloads","issues_url":"https://api.github.com/repos/norihiro-w/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/norihiro-w/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/norihiro-w/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/norihiro-w/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norihiro-w/ogs/labels{/name}","releases_url":"https://api.github.com/repos/norihiro-w/ogs/releases{/id}","created_at":"2011-10-20T10:16:18Z","updated_at":"2014-06-06T13:22:49Z","pushed_at":"2014-09-26T09:06:32Z","git_url":"git://github.com/norihiro-w/ogs.git","ssh_url":"git@github.com:norihiro-w/ogs.git","clone_url":"https://github.com/norihiro-w/ogs.git","svn_url":"https://github.com/norihiro-w/ogs","homepage":"www.opengeosys.org","size":31562,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":3,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"b4609ad045b9bde14181ec767c170e7e9001ae71","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=2","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=2","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"OGS source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments/{number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","created_at":"2011-05-04T14:09:57Z","updated_at":"2014-09-02T11:52:00Z","pushed_at":"2014-09-26T05:16:52Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":15212,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":58,"forks":28,"open_issues":58,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/477"},"html":{"href":"https://github.com/ufz/ogs/pull/477"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/477"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/7fff62499a5d4b35f20b3ae9f857a98b9169edbf"}}}}