GitHub PullRequestReviewCommentEvent at 2014-09-29 10:06:45
Repository: mce
Actor: spiiroin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nemomobile/mce/pulls/comments/18145825","id":18145825,"diff_hunk":"@@ -2367,10 +2456,18 @@ static void mdy_brightness_set_fade_target_ex(gint new_brightness,\n      * the short time window we have available during unblanking. */\n     const int delay_min = 4;\n \n-    mce_log(LL_DEBUG, \"fade from %d to %d in %d ms\",\n+    mce_log(LL_DEBUG, \"type %s fade from %d to %d in %d ms\",\n+            fader_type_name(type),\n             mdy_brightness_level_cached,\n             new_brightness, transition_time);\n \n+    if( !mdy_brightness_is_fade_allowed(type) ) {","path":"modules/display.c","position":172,"original_position":172,"commit_id":"9b4a7c2e204d98635ee5b53a7783c0619b4055a9","original_commit_id":"9b4a7c2e204d98635ee5b53a7783c0619b4055a9","user":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=2","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"body":"Not really. Except for ALS tuning, the rest of the fading happens in direct response to display state transitions. And those are always driven to completion by the display state machine. Basically at the moment it would have been sufficient to just tweak the start als fading routine, but doing a bit more generic fade type identification helps debugging hairy bits.\r\n\r\nHmm... which reminds me that I was supposed to add off-tree managed display state machine diagram to sources...","created_at":"2014-09-29T10:06:45Z","updated_at":"2014-09-29T10:06:45Z","html_url":"https://github.com/nemomobile/mce/pull/218#discussion_r18145825","pull_request_url":"https://api.github.com/repos/nemomobile/mce/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/comments/18145825"},"html":{"href":"https://github.com/nemomobile/mce/pull/218#discussion_r18145825"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/nemomobile/mce/pulls/218","id":21916383,"html_url":"https://github.com/nemomobile/mce/pull/218","diff_url":"https://github.com/nemomobile/mce/pull/218.diff","patch_url":"https://github.com/nemomobile/mce/pull/218.patch","issue_url":"https://api.github.com/repos/nemomobile/mce/issues/218","number":218,"state":"open","locked":false,"title":"Tune brightness handling during display power up/down","user":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=2","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-29T06:59:07Z","updated_at":"2014-09-29T10:06:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e741629418eeb1b22ded2847e4d18b4edd7720f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile/mce/pulls/218/commits","review_comments_url":"https://api.github.com/repos/nemomobile/mce/pulls/218/comments","review_comment_url":"https://api.github.com/repos/nemomobile/mce/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nemomobile/mce/issues/218/comments","statuses_url":"https://api.github.com/repos/nemomobile/mce/statuses/9b4a7c2e204d98635ee5b53a7783c0619b4055a9","head":{"label":"spiiroin:jb21833_brightness_and_compositor","ref":"jb21833_brightness_and_compositor","sha":"9b4a7c2e204d98635ee5b53a7783c0619b4055a9","user":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=2","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"repo":{"id":6487031,"name":"mce","full_name":"spiiroin/mce","owner":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=2","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spiiroin/mce","description":"","fork":true,"url":"https://api.github.com/repos/spiiroin/mce","forks_url":"https://api.github.com/repos/spiiroin/mce/forks","keys_url":"https://api.github.com/repos/spiiroin/mce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiiroin/mce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiiroin/mce/teams","hooks_url":"https://api.github.com/repos/spiiroin/mce/hooks","issue_events_url":"https://api.github.com/repos/spiiroin/mce/issues/events{/number}","events_url":"https://api.github.com/repos/spiiroin/mce/events","assignees_url":"https://api.github.com/repos/spiiroin/mce/assignees{/user}","branches_url":"https://api.github.com/repos/spiiroin/mce/branches{/branch}","tags_url":"https://api.github.com/repos/spiiroin/mce/tags","blobs_url":"https://api.github.com/repos/spiiroin/mce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiiroin/mce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiiroin/mce/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiiroin/mce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiiroin/mce/statuses/{sha}","languages_url":"https://api.github.com/repos/spiiroin/mce/languages","stargazers_url":"https://api.github.com/repos/spiiroin/mce/stargazers","contributors_url":"https://api.github.com/repos/spiiroin/mce/contributors","subscribers_url":"https://api.github.com/repos/spiiroin/mce/subscribers","subscription_url":"https://api.github.com/repos/spiiroin/mce/subscription","commits_url":"https://api.github.com/repos/spiiroin/mce/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiiroin/mce/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiiroin/mce/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiiroin/mce/issues/comments/{number}","contents_url":"https://api.github.com/repos/spiiroin/mce/contents/{+path}","compare_url":"https://api.github.com/repos/spiiroin/mce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiiroin/mce/merges","archive_url":"https://api.github.com/repos/spiiroin/mce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiiroin/mce/downloads","issues_url":"https://api.github.com/repos/spiiroin/mce/issues{/number}","pulls_url":"https://api.github.com/repos/spiiroin/mce/pulls{/number}","milestones_url":"https://api.github.com/repos/spiiroin/mce/milestones{/number}","notifications_url":"https://api.github.com/repos/spiiroin/mce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiiroin/mce/labels{/name}","releases_url":"https://api.github.com/repos/spiiroin/mce/releases{/id}","created_at":"2012-11-01T09:06:03Z","updated_at":"2014-07-20T18:43:15Z","pushed_at":"2014-09-29T06:41:15Z","git_url":"git://github.com/spiiroin/mce.git","ssh_url":"git@github.com:spiiroin/mce.git","clone_url":"https://github.com/spiiroin/mce.git","svn_url":"https://github.com/spiiroin/mce","homepage":null,"size":6319,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nemomobile:master","ref":"master","sha":"7a13278113a60bffa23a36bd4917e243d255db6e","user":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=2","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"repo":{"id":6041894,"name":"mce","full_name":"nemomobile/mce","owner":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=2","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile/mce","description":"","fork":false,"url":"https://api.github.com/repos/nemomobile/mce","forks_url":"https://api.github.com/repos/nemomobile/mce/forks","keys_url":"https://api.github.com/repos/nemomobile/mce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile/mce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile/mce/teams","hooks_url":"https://api.github.com/repos/nemomobile/mce/hooks","issue_events_url":"https://api.github.com/repos/nemomobile/mce/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile/mce/events","assignees_url":"https://api.github.com/repos/nemomobile/mce/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile/mce/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile/mce/tags","blobs_url":"https://api.github.com/repos/nemomobile/mce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile/mce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile/mce/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile/mce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile/mce/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile/mce/languages","stargazers_url":"https://api.github.com/repos/nemomobile/mce/stargazers","contributors_url":"https://api.github.com/repos/nemomobile/mce/contributors","subscribers_url":"https://api.github.com/repos/nemomobile/mce/subscribers","subscription_url":"https://api.github.com/repos/nemomobile/mce/subscription","commits_url":"https://api.github.com/repos/nemomobile/mce/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile/mce/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile/mce/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile/mce/issues/comments/{number}","contents_url":"https://api.github.com/repos/nemomobile/mce/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile/mce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile/mce/merges","archive_url":"https://api.github.com/repos/nemomobile/mce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile/mce/downloads","issues_url":"https://api.github.com/repos/nemomobile/mce/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile/mce/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile/mce/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile/mce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile/mce/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile/mce/releases{/id}","created_at":"2012-10-02T08:09:10Z","updated_at":"2014-09-02T05:23:35Z","pushed_at":"2014-09-26T05:32:53Z","git_url":"git://github.com/nemomobile/mce.git","ssh_url":"git@github.com:nemomobile/mce.git","clone_url":"https://github.com/nemomobile/mce.git","svn_url":"https://github.com/nemomobile/mce","homepage":null,"size":6367,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":1,"forks":15,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/218"},"html":{"href":"https://github.com/nemomobile/mce/pull/218"},"issue":{"href":"https://api.github.com/repos/nemomobile/mce/issues/218"},"comments":{"href":"https://api.github.com/repos/nemomobile/mce/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile/mce/statuses/9b4a7c2e204d98635ee5b53a7783c0619b4055a9"}}}}