GitHub PullRequestReviewCommentEvent at 2014-07-09 21:00:00
Repository: gamgee
Actor: MauricioCarneiro
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/comments/14735663","id":14735663,"diff_hunk":"@@ -219,6 +223,68 @@ BOOST_AUTO_TEST_CASE( sam_read_tags ) {\n   BOOST_CHECK_EQUAL(read2_xs_tag.value(), 0);\n   BOOST_CHECK_EQUAL(read2_xs_tag.is_present(), true);\n \n-  const auto read2_nonexistent_tag = read2.integer_tag(\"FB\");\n-  BOOST_CHECK_EQUAL(read2_nonexistent_tag.is_present(), false);\n+  // check integer, char and float tags\n+  const auto read1_za_tag = read1.double_tag(\"ZA\");\n+  BOOST_CHECK_EQUAL(read1_za_tag.name(), \"ZA\");\n+  BOOST_CHECK(read1_za_tag.value() >= 2.3 - 0.001 && read1_za_tag.value() <= 2.3 + 0.001);\n+  BOOST_CHECK_EQUAL(read1_za_tag.is_present(), true);\n+  const auto read1_zb_tag = read1.integer_tag(\"ZB\");\n+  BOOST_CHECK_EQUAL(read1_zb_tag.name(), \"ZB\");\n+  BOOST_CHECK_EQUAL(read1_zb_tag.value(), 23);\n+  BOOST_CHECK_EQUAL(read1_zb_tag.is_present(), true);\n+  const auto read1_zc_tag = read1.char_tag(\"ZC\");\n+  BOOST_CHECK_EQUAL(read1_zc_tag.name(), \"ZC\");\n+  BOOST_CHECK_EQUAL(read1_zc_tag.value(), 't');\n+  BOOST_CHECK_EQUAL(read1_zc_tag.is_present(), true);\n+\n+  // check is_missing functionality on missing tags\n+  const auto read2_nonexistent_string_tag = read2.string_tag(\"PP\");\n+  BOOST_CHECK_EQUAL(read2_nonexistent_string_tag.is_present(), false);\n+  BOOST_CHECK(is_missing(read2_nonexistent_string_tag));\n+  const auto read2_nonexistent_integer_tag = read2.integer_tag(\"PP\");\n+  BOOST_CHECK_EQUAL(read2_nonexistent_integer_tag.is_present(), false);\n+  BOOST_CHECK(is_missing(read2_nonexistent_integer_tag));\n+  const auto read2_nonexistent_double_tag = read2.double_tag(\"PP\");\n+  BOOST_CHECK_EQUAL(read2_nonexistent_double_tag.is_present(), false);\n+  BOOST_CHECK(is_missing(read2_nonexistent_double_tag));\n+  const auto read2_nonexistent_char_tag = read2.char_tag(\"PP\");\n+  BOOST_CHECK_EQUAL(read2_nonexistent_char_tag.is_present(), false);\n+  BOOST_CHECK(is_missing(read2_nonexistent_string_tag));\n+\n+  const auto not_a_char_tag = read1.char_tag(\"ZB\");     // ZB is an integer tag\n+  BOOST_CHECK(is_missing(not_a_char_tag));              // this should yield \"not a char\" which is equal to a missing value\n+  const auto not_a_string_tag = read1.string_tag(\"ZB\"); // ZB is an integer tag\n+  BOOST_CHECK(is_missing(not_a_string_tag));            // this should yield \"not a char\" which is equal to a missing value","path":"test/sam_test.cpp","position":50,"original_position":50,"commit_id":"df3b63f00a1719aaf15170849b7e1a68b91387bd","original_commit_id":"df3b63f00a1719aaf15170849b7e1a68b91387bd","user":{"login":"MauricioCarneiro","id":1843628,"avatar_url":"https://avatars.githubusercontent.com/u/1843628?","gravatar_id":"33e009132b1bc3c5bd7be7e0762d4c46","url":"https://api.github.com/users/MauricioCarneiro","html_url":"https://github.com/MauricioCarneiro","followers_url":"https://api.github.com/users/MauricioCarneiro/followers","following_url":"https://api.github.com/users/MauricioCarneiro/following{/other_user}","gists_url":"https://api.github.com/users/MauricioCarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/MauricioCarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MauricioCarneiro/subscriptions","organizations_url":"https://api.github.com/users/MauricioCarneiro/orgs","repos_url":"https://api.github.com/users/MauricioCarneiro/repos","events_url":"https://api.github.com/users/MauricioCarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/MauricioCarneiro/received_events","type":"User","site_admin":false},"body":"we'll do it when we have it.","created_at":"2014-07-09T21:00:00Z","updated_at":"2014-07-09T21:00:00Z","html_url":"https://github.com/broadinstitute/gamgee/pull/116#discussion_r14735663","pull_request_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/comments/14735663"},"html":{"href":"https://github.com/broadinstitute/gamgee/pull/116#discussion_r14735663"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/116","id":18141095,"html_url":"https://github.com/broadinstitute/gamgee/pull/116","diff_url":"https://github.com/broadinstitute/gamgee/pull/116.diff","patch_url":"https://github.com/broadinstitute/gamgee/pull/116.patch","issue_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/116","number":116,"state":"open","title":"Sam: add tests to the public API","user":{"login":"MauricioCarneiro","id":1843628,"avatar_url":"https://avatars.githubusercontent.com/u/1843628?","gravatar_id":"33e009132b1bc3c5bd7be7e0762d4c46","url":"https://api.github.com/users/MauricioCarneiro","html_url":"https://github.com/MauricioCarneiro","followers_url":"https://api.github.com/users/MauricioCarneiro/followers","following_url":"https://api.github.com/users/MauricioCarneiro/following{/other_user}","gists_url":"https://api.github.com/users/MauricioCarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/MauricioCarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MauricioCarneiro/subscriptions","organizations_url":"https://api.github.com/users/MauricioCarneiro/orgs","repos_url":"https://api.github.com/users/MauricioCarneiro/repos","events_url":"https://api.github.com/users/MauricioCarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/MauricioCarneiro/received_events","type":"User","site_admin":false},"body":"**Added the following tests**:\r\n\r\n* unclipped start and stop\r\n* copy constructor tests\r\n* copy assignment test\r\n* tags of types char, int and double\r\n* char_tag when tag is not a char\r\n* string_tag when tag is not a string\r\n* is_missing support for tags\r\n\r\nmajor strides towards addressing issue #4","created_at":"2014-07-09T04:04:38Z","updated_at":"2014-07-09T21:00:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d53c476de44bb0da1258d8301436edc4db824b5","assignee":{"login":"droazen","id":798637,"avatar_url":"https://avatars.githubusercontent.com/u/798637?","gravatar_id":"7543dd289857531c35a8eec21e9db31a","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/116/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/116/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/comments/{number}","comments_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/116/comments","statuses_url":"https://api.github.com/repos/broadinstitute/gamgee/statuses/df3b63f00a1719aaf15170849b7e1a68b91387bd","head":{"label":"broadinstitute:mc_add_sam_tests","ref":"mc_add_sam_tests","sha":"df3b63f00a1719aaf15170849b7e1a68b91387bd","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?","gravatar_id":"15796050d34835c57c1cf412d45b9c0c","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":17992711,"name":"gamgee","full_name":"broadinstitute/gamgee","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?","gravatar_id":"15796050d34835c57c1cf412d45b9c0c","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/gamgee","description":"A C++ interface for HTSLIB (samtools/htslib)","fork":false,"url":"https://api.github.com/repos/broadinstitute/gamgee","forks_url":"https://api.github.com/repos/broadinstitute/gamgee/forks","keys_url":"https://api.github.com/repos/broadinstitute/gamgee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gamgee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gamgee/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gamgee/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gamgee/events","assignees_url":"https://api.github.com/repos/broadinstitute/gamgee/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gamgee/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gamgee/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gamgee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gamgee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gamgee/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gamgee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gamgee/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gamgee/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gamgee/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gamgee/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gamgee/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gamgee/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gamgee/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gamgee/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gamgee/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/comments/{number}","contents_url":"https://api.github.com/repos/broadinstitute/gamgee/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gamgee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gamgee/merges","archive_url":"https://api.github.com/repos/broadinstitute/gamgee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gamgee/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gamgee/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gamgee/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gamgee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gamgee/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gamgee/releases{/id}","created_at":"2014-03-21T20:04:04Z","updated_at":"2014-06-28T01:38:52Z","pushed_at":"2014-07-09T18:06:21Z","git_url":"git://github.com/broadinstitute/gamgee.git","ssh_url":"git@github.com:broadinstitute/gamgee.git","clone_url":"https://github.com/broadinstitute/gamgee.git","svn_url":"https://github.com/broadinstitute/gamgee","homepage":null,"size":23043,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":32,"forks":3,"open_issues":32,"watchers":2,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"f999766d1cf39c6f01d3232b1ab0377f1339d96e","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?","gravatar_id":"15796050d34835c57c1cf412d45b9c0c","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":17992711,"name":"gamgee","full_name":"broadinstitute/gamgee","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?","gravatar_id":"15796050d34835c57c1cf412d45b9c0c","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/gamgee","description":"A C++ interface for HTSLIB (samtools/htslib)","fork":false,"url":"https://api.github.com/repos/broadinstitute/gamgee","forks_url":"https://api.github.com/repos/broadinstitute/gamgee/forks","keys_url":"https://api.github.com/repos/broadinstitute/gamgee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gamgee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gamgee/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gamgee/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gamgee/events","assignees_url":"https://api.github.com/repos/broadinstitute/gamgee/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gamgee/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gamgee/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gamgee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gamgee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gamgee/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gamgee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gamgee/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gamgee/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gamgee/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gamgee/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gamgee/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gamgee/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gamgee/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gamgee/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gamgee/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/comments/{number}","contents_url":"https://api.github.com/repos/broadinstitute/gamgee/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gamgee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gamgee/merges","archive_url":"https://api.github.com/repos/broadinstitute/gamgee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gamgee/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gamgee/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gamgee/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gamgee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gamgee/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gamgee/releases{/id}","created_at":"2014-03-21T20:04:04Z","updated_at":"2014-06-28T01:38:52Z","pushed_at":"2014-07-09T18:06:21Z","git_url":"git://github.com/broadinstitute/gamgee.git","ssh_url":"git@github.com:broadinstitute/gamgee.git","clone_url":"https://github.com/broadinstitute/gamgee.git","svn_url":"https://github.com/broadinstitute/gamgee","homepage":null,"size":23043,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":32,"forks":3,"open_issues":32,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/116"},"html":{"href":"https://github.com/broadinstitute/gamgee/pull/116"},"issue":{"href":"https://api.github.com/repos/broadinstitute/gamgee/issues/116"},"comments":{"href":"https://api.github.com/repos/broadinstitute/gamgee/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/gamgee/statuses/df3b63f00a1719aaf15170849b7e1a68b91387bd"}}}}