GitHub PullRequestReviewCommentEvent at 2014-10-29 11:59:37
Repository: supervisor
Actor: gjcarneiro
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Supervisor/supervisor/pulls/comments/19532760","id":19532760,"diff_hunk":"@@ -116,7 +116,11 @@ def get_execv_args(self):\n             raise BadCommand(\"command is empty\")\n \n         if \"/\" in program:\n-            filename = program\n+            if program.startswith('/'):\n+                filename = program\n+            else:\n+                filename = os.path.join(self.config.directory, program)","path":"supervisor/process.py","position":8,"original_position":8,"commit_id":"84b5a2fad51e7f7f230f5ee7a717280912d10472","original_commit_id":"84b5a2fad51e7f7f230f5ee7a717280912d10472","user":{"login":"gjcarneiro","id":2197096,"avatar_url":"https://avatars.githubusercontent.com/u/2197096?v=2","gravatar_id":"","url":"https://api.github.com/users/gjcarneiro","html_url":"https://github.com/gjcarneiro","followers_url":"https://api.github.com/users/gjcarneiro/followers","following_url":"https://api.github.com/users/gjcarneiro/following{/other_user}","gists_url":"https://api.github.com/users/gjcarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/gjcarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjcarneiro/subscriptions","organizations_url":"https://api.github.com/users/gjcarneiro/orgs","repos_url":"https://api.github.com/users/gjcarneiro/repos","events_url":"https://api.github.com/users/gjcarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/gjcarneiro/received_events","type":"User","site_admin":false},"body":"Ah, you're right, my bad.  Sorry.  Indeed `self.config.directory` is the \"directory\" program config option, not the directory of the config file.  I withdraw my objection!\r\n+1","created_at":"2014-10-29T11:59:37Z","updated_at":"2014-10-29T11:59:37Z","html_url":"https://github.com/Supervisor/supervisor/pull/508#discussion_r19532760","pull_request_url":"https://api.github.com/repos/Supervisor/supervisor/pulls/508","_links":{"self":{"href":"https://api.github.com/repos/Supervisor/supervisor/pulls/comments/19532760"},"html":{"href":"https://github.com/Supervisor/supervisor/pull/508#discussion_r19532760"},"pull_request":{"href":"https://api.github.com/repos/Supervisor/supervisor/pulls/508"}}},"pull_request":{"url":"https://api.github.com/repos/Supervisor/supervisor/pulls/508","id":23394267,"html_url":"https://github.com/Supervisor/supervisor/pull/508","diff_url":"https://github.com/Supervisor/supervisor/pull/508.diff","patch_url":"https://github.com/Supervisor/supervisor/pull/508.patch","issue_url":"https://api.github.com/repos/Supervisor/supervisor/issues/508","number":508,"state":"open","locked":false,"title":"Fix #369 relative command path","user":{"login":"schemacs","id":434358,"avatar_url":"https://avatars.githubusercontent.com/u/434358?v=2","gravatar_id":"","url":"https://api.github.com/users/schemacs","html_url":"https://github.com/schemacs","followers_url":"https://api.github.com/users/schemacs/followers","following_url":"https://api.github.com/users/schemacs/following{/other_user}","gists_url":"https://api.github.com/users/schemacs/gists{/gist_id}","starred_url":"https://api.github.com/users/schemacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schemacs/subscriptions","organizations_url":"https://api.github.com/users/schemacs/orgs","repos_url":"https://api.github.com/users/schemacs/repos","events_url":"https://api.github.com/users/schemacs/events{/privacy}","received_events_url":"https://api.github.com/users/schemacs/received_events","type":"User","site_admin":false},"body":"The docs say:\r\n\r\n    The command can be either absolute (e.g. /path/to/programname) or relative (e.g. programname). \r\n    If it is relative, the supervisord’s environment $PATH will be searched for the executable.\r\n\r\nThis fixes relative path like to/programname as stated in #369 .","created_at":"2014-10-27T16:07:38Z","updated_at":"2014-10-29T11:59:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"224cba80a5a15ac88de6ddcf9cf53ae3af1f7499","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Supervisor/supervisor/pulls/508/commits","review_comments_url":"https://api.github.com/repos/Supervisor/supervisor/pulls/508/comments","review_comment_url":"https://api.github.com/repos/Supervisor/supervisor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Supervisor/supervisor/issues/508/comments","statuses_url":"https://api.github.com/repos/Supervisor/supervisor/statuses/84b5a2fad51e7f7f230f5ee7a717280912d10472","head":{"label":"schemacs:relative-cmd","ref":"relative-cmd","sha":"84b5a2fad51e7f7f230f5ee7a717280912d10472","user":{"login":"schemacs","id":434358,"avatar_url":"https://avatars.githubusercontent.com/u/434358?v=2","gravatar_id":"","url":"https://api.github.com/users/schemacs","html_url":"https://github.com/schemacs","followers_url":"https://api.github.com/users/schemacs/followers","following_url":"https://api.github.com/users/schemacs/following{/other_user}","gists_url":"https://api.github.com/users/schemacs/gists{/gist_id}","starred_url":"https://api.github.com/users/schemacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schemacs/subscriptions","organizations_url":"https://api.github.com/users/schemacs/orgs","repos_url":"https://api.github.com/users/schemacs/repos","events_url":"https://api.github.com/users/schemacs/events{/privacy}","received_events_url":"https://api.github.com/users/schemacs/received_events","type":"User","site_admin":false},"repo":{"id":25823357,"name":"supervisor","full_name":"schemacs/supervisor","owner":{"login":"schemacs","id":434358,"avatar_url":"https://avatars.githubusercontent.com/u/434358?v=2","gravatar_id":"","url":"https://api.github.com/users/schemacs","html_url":"https://github.com/schemacs","followers_url":"https://api.github.com/users/schemacs/followers","following_url":"https://api.github.com/users/schemacs/following{/other_user}","gists_url":"https://api.github.com/users/schemacs/gists{/gist_id}","starred_url":"https://api.github.com/users/schemacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schemacs/subscriptions","organizations_url":"https://api.github.com/users/schemacs/orgs","repos_url":"https://api.github.com/users/schemacs/repos","events_url":"https://api.github.com/users/schemacs/events{/privacy}","received_events_url":"https://api.github.com/users/schemacs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schemacs/supervisor","description":"Supervisor process control system for UNIX","fork":true,"url":"https://api.github.com/repos/schemacs/supervisor","forks_url":"https://api.github.com/repos/schemacs/supervisor/forks","keys_url":"https://api.github.com/repos/schemacs/supervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schemacs/supervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schemacs/supervisor/teams","hooks_url":"https://api.github.com/repos/schemacs/supervisor/hooks","issue_events_url":"https://api.github.com/repos/schemacs/supervisor/issues/events{/number}","events_url":"https://api.github.com/repos/schemacs/supervisor/events","assignees_url":"https://api.github.com/repos/schemacs/supervisor/assignees{/user}","branches_url":"https://api.github.com/repos/schemacs/supervisor/branches{/branch}","tags_url":"https://api.github.com/repos/schemacs/supervisor/tags","blobs_url":"https://api.github.com/repos/schemacs/supervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schemacs/supervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schemacs/supervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/schemacs/supervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schemacs/supervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/schemacs/supervisor/languages","stargazers_url":"https://api.github.com/repos/schemacs/supervisor/stargazers","contributors_url":"https://api.github.com/repos/schemacs/supervisor/contributors","subscribers_url":"https://api.github.com/repos/schemacs/supervisor/subscribers","subscription_url":"https://api.github.com/repos/schemacs/supervisor/subscription","commits_url":"https://api.github.com/repos/schemacs/supervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/schemacs/supervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/schemacs/supervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/schemacs/supervisor/issues/comments/{number}","contents_url":"https://api.github.com/repos/schemacs/supervisor/contents/{+path}","compare_url":"https://api.github.com/repos/schemacs/supervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schemacs/supervisor/merges","archive_url":"https://api.github.com/repos/schemacs/supervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schemacs/supervisor/downloads","issues_url":"https://api.github.com/repos/schemacs/supervisor/issues{/number}","pulls_url":"https://api.github.com/repos/schemacs/supervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/schemacs/supervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/schemacs/supervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schemacs/supervisor/labels{/name}","releases_url":"https://api.github.com/repos/schemacs/supervisor/releases{/id}","created_at":"2014-10-27T14:37:57Z","updated_at":"2014-10-27T12:31:13Z","pushed_at":"2014-10-27T16:05:26Z","git_url":"git://github.com/schemacs/supervisor.git","ssh_url":"git@github.com:schemacs/supervisor.git","clone_url":"https://github.com/schemacs/supervisor.git","svn_url":"https://github.com/schemacs/supervisor","homepage":"http://supervisord.org","size":5134,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Supervisor:master","ref":"master","sha":"c3cf30bc209893ee39c90b1dbfbeeb8f09dac553","user":{"login":"Supervisor","id":513914,"avatar_url":"https://avatars.githubusercontent.com/u/513914?v=2","gravatar_id":"","url":"https://api.github.com/users/Supervisor","html_url":"https://github.com/Supervisor","followers_url":"https://api.github.com/users/Supervisor/followers","following_url":"https://api.github.com/users/Supervisor/following{/other_user}","gists_url":"https://api.github.com/users/Supervisor/gists{/gist_id}","starred_url":"https://api.github.com/users/Supervisor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Supervisor/subscriptions","organizations_url":"https://api.github.com/users/Supervisor/orgs","repos_url":"https://api.github.com/users/Supervisor/repos","events_url":"https://api.github.com/users/Supervisor/events{/privacy}","received_events_url":"https://api.github.com/users/Supervisor/received_events","type":"Organization","site_admin":false},"repo":{"id":1148352,"name":"supervisor","full_name":"Supervisor/supervisor","owner":{"login":"Supervisor","id":513914,"avatar_url":"https://avatars.githubusercontent.com/u/513914?v=2","gravatar_id":"","url":"https://api.github.com/users/Supervisor","html_url":"https://github.com/Supervisor","followers_url":"https://api.github.com/users/Supervisor/followers","following_url":"https://api.github.com/users/Supervisor/following{/other_user}","gists_url":"https://api.github.com/users/Supervisor/gists{/gist_id}","starred_url":"https://api.github.com/users/Supervisor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Supervisor/subscriptions","organizations_url":"https://api.github.com/users/Supervisor/orgs","repos_url":"https://api.github.com/users/Supervisor/repos","events_url":"https://api.github.com/users/Supervisor/events{/privacy}","received_events_url":"https://api.github.com/users/Supervisor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Supervisor/supervisor","description":"Supervisor process control system for UNIX","fork":false,"url":"https://api.github.com/repos/Supervisor/supervisor","forks_url":"https://api.github.com/repos/Supervisor/supervisor/forks","keys_url":"https://api.github.com/repos/Supervisor/supervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Supervisor/supervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Supervisor/supervisor/teams","hooks_url":"https://api.github.com/repos/Supervisor/supervisor/hooks","issue_events_url":"https://api.github.com/repos/Supervisor/supervisor/issues/events{/number}","events_url":"https://api.github.com/repos/Supervisor/supervisor/events","assignees_url":"https://api.github.com/repos/Supervisor/supervisor/assignees{/user}","branches_url":"https://api.github.com/repos/Supervisor/supervisor/branches{/branch}","tags_url":"https://api.github.com/repos/Supervisor/supervisor/tags","blobs_url":"https://api.github.com/repos/Supervisor/supervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Supervisor/supervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Supervisor/supervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Supervisor/supervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Supervisor/supervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/Supervisor/supervisor/languages","stargazers_url":"https://api.github.com/repos/Supervisor/supervisor/stargazers","contributors_url":"https://api.github.com/repos/Supervisor/supervisor/contributors","subscribers_url":"https://api.github.com/repos/Supervisor/supervisor/subscribers","subscription_url":"https://api.github.com/repos/Supervisor/supervisor/subscription","commits_url":"https://api.github.com/repos/Supervisor/supervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Supervisor/supervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Supervisor/supervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Supervisor/supervisor/issues/comments/{number}","contents_url":"https://api.github.com/repos/Supervisor/supervisor/contents/{+path}","compare_url":"https://api.github.com/repos/Supervisor/supervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Supervisor/supervisor/merges","archive_url":"https://api.github.com/repos/Supervisor/supervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Supervisor/supervisor/downloads","issues_url":"https://api.github.com/repos/Supervisor/supervisor/issues{/number}","pulls_url":"https://api.github.com/repos/Supervisor/supervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/Supervisor/supervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/Supervisor/supervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Supervisor/supervisor/labels{/name}","releases_url":"https://api.github.com/repos/Supervisor/supervisor/releases{/id}","created_at":"2010-12-08T00:48:48Z","updated_at":"2014-10-29T08:27:45Z","pushed_at":"2014-10-28T18:56:35Z","git_url":"git://github.com/Supervisor/supervisor.git","ssh_url":"git@github.com:Supervisor/supervisor.git","clone_url":"https://github.com/Supervisor/supervisor.git","svn_url":"https://github.com/Supervisor/supervisor","homepage":"http://supervisord.org","size":10932,"stargazers_count":1301,"watchers_count":1301,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":108,"forks":288,"open_issues":108,"watchers":1301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Supervisor/supervisor/pulls/508"},"html":{"href":"https://github.com/Supervisor/supervisor/pull/508"},"issue":{"href":"https://api.github.com/repos/Supervisor/supervisor/issues/508"},"comments":{"href":"https://api.github.com/repos/Supervisor/supervisor/issues/508/comments"},"review_comments":{"href":"https://api.github.com/repos/Supervisor/supervisor/pulls/508/comments"},"review_comment":{"href":"https://api.github.com/repos/Supervisor/supervisor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Supervisor/supervisor/pulls/508/commits"},"statuses":{"href":"https://api.github.com/repos/Supervisor/supervisor/statuses/84b5a2fad51e7f7f230f5ee7a717280912d10472"}}}}