GitHub PullRequestReviewCommentEvent at 2014-03-02 20:51:41
Repository: boardrules
Actor: EXreaction
Payload: {"comment":{"url":"https://api.github.com/repos/phpbb-extensions/boardrules/pulls/comments/10197409","id":10197409,"diff_hunk":"@@ -171,6 +171,32 @@ public function display_rules($language = 0, $parent_id = 0)\n \t}\n \n \t/**\n+\t* Delete a rule\n+\t*\n+\t* @param int $rule_id The rule identifier to delete\n+\t* @return null\n+\t* @access public\n+\t*/\n+\tpublic function delete_rule($rule_id)\n+\t{\n+\t\t$this->rule_operator->delete_rule($rule_id);","path":"controller/admin_controller.php","position":12,"original_position":12,"commit_id":"5234c08bb412ec8c69ab2561df058df2f60c3417","original_commit_id":"88efd36bdf9105a349fb8eb56d5ca48bae2b998d","user":{"login":"EXreaction","id":214383,"avatar_url":"https://avatars.githubusercontent.com/u/214383","gravatar_id":"e6a9c7bc69530add787ed2c9175931cb","url":"https://api.github.com/users/EXreaction","html_url":"https://github.com/EXreaction","followers_url":"https://api.github.com/users/EXreaction/followers","following_url":"https://api.github.com/users/EXreaction/following{/other_user}","gists_url":"https://api.github.com/users/EXreaction/gists{/gist_id}","starred_url":"https://api.github.com/users/EXreaction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EXreaction/subscriptions","organizations_url":"https://api.github.com/users/EXreaction/orgs","repos_url":"https://api.github.com/users/EXreaction/repos","events_url":"https://api.github.com/users/EXreaction/events{/privacy}","received_events_url":"https://api.github.com/users/EXreaction/received_events","type":"User","site_admin":false},"body":"Here, the acp module should not have much of any code\nOn Mar 2, 2014 1:31 PM, \"Pico88\" <notifications@github.com> wrote:\n\n> In controller/admin_controller.php:\n>\n> > @@ -171,6 +171,32 @@ public function display_rules($language = 0, $parent_id = 0)\n> >  \t}\n> >\n> >  \t/**\n> > +\t* Delete a rule\n> > +\t*\n> > +\t* @param int $rule_id The rule identifier to delete\n> > +\t* @return null\n> > +\t* @access public\n> > +\t*/\n> > +\tpublic function delete_rule($rule_id)\n> > +\t{\n> > +\t\t$this->rule_operator->delete_rule($rule_id);\n>\n> Do we want it here or in acp module?\n>\n> --\n> Reply to this email directly or view it on GitHub<https://github.com/phpbb-extensions/boardrules/pull/67/files#r10197011>\n> .\n>","created_at":"2014-03-02T20:51:41Z","updated_at":"2014-03-02T20:51:41Z","html_url":"https://github.com/phpbb-extensions/boardrules/pull/67#discussion_r10197409","pull_request_url":"https://api.github.com/repos/phpbb-extensions/boardrules/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/phpbb-extensions/boardrules/pulls/comments/10197409"},"html":{"href":"https://github.com/phpbb-extensions/boardrules/pull/67#discussion_r10197409"},"pull_request":{"href":"https://api.github.com/repos/phpbb-extensions/boardrules/pulls/67"}}}}