GitHub PullRequestReviewCommentEvent at 2014-11-21 15:31:06
Repository: composer
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/composer/composer/pulls/comments/20720875","id":20720875,"diff_hunk":"@@ -697,10 +698,14 @@ private function createPolicy()\n         // old lock file without prefer stable will return null\n         // so in this case we use the composer.json info\n         if (null === $preferStable) {\n-            $preferStable = $this->package->getPreferStable();\n+            if (getenv('COMPOSER_PREFER_LOWEST_STABLE')) {\n+                $preferStable = $preferLowest = true;","path":"src/Composer/Installer.php","position":14,"original_position":14,"commit_id":"c632c7f1b34ba4d222725c5753f23a74435f825a","original_commit_id":"c632c7f1b34ba4d222725c5753f23a74435f825a","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"are you sure about ``$preferStable`` being true ? this would prefer a 2.4.0 over a 2.4.0-beta release, while 2.4.0 is lowest.\r\nI think it should rather force ``$preferStable`` to false, so that only the version ordering is used to find the selected version","created_at":"2014-11-21T15:31:06Z","updated_at":"2014-11-21T15:31:06Z","html_url":"https://github.com/composer/composer/pull/3450#discussion_r20720875","pull_request_url":"https://api.github.com/repos/composer/composer/pulls/3450","_links":{"self":{"href":"https://api.github.com/repos/composer/composer/pulls/comments/20720875"},"html":{"href":"https://github.com/composer/composer/pull/3450#discussion_r20720875"},"pull_request":{"href":"https://api.github.com/repos/composer/composer/pulls/3450"}}},"pull_request":{"url":"https://api.github.com/repos/composer/composer/pulls/3450","id":24838350,"html_url":"https://github.com/composer/composer/pull/3450","diff_url":"https://github.com/composer/composer/pull/3450.diff","patch_url":"https://github.com/composer/composer/pull/3450.patch","issue_url":"https://api.github.com/repos/composer/composer/issues/3450","number":3450,"state":"open","locked":false,"title":"add COMPOSER_PREFER_LOWEST_STABLE","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"Run `COMPOSER_PREFER_LOWEST_STABLE=1 composer update` and get all the deps installed to their lowest (pretended) supported version\r\n\r\nFixes #3440\r\nFixes #1902","created_at":"2014-11-21T13:04:10Z","updated_at":"2014-11-21T15:31:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b34de09182c549f47a35627a66c11405df6feb80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/composer/composer/pulls/3450/commits","review_comments_url":"https://api.github.com/repos/composer/composer/pulls/3450/comments","review_comment_url":"https://api.github.com/repos/composer/composer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/composer/composer/issues/3450/comments","statuses_url":"https://api.github.com/repos/composer/composer/statuses/c632c7f1b34ba4d222725c5753f23a74435f825a","head":{"label":"nicolas-grekas:prefer-lowest-stable","ref":"prefer-lowest-stable","sha":"c632c7f1b34ba4d222725c5753f23a74435f825a","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"repo":{"id":16522834,"name":"composer","full_name":"nicolas-grekas/composer","owner":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolas-grekas/composer","description":"Dependency Manager for PHP","fork":true,"url":"https://api.github.com/repos/nicolas-grekas/composer","forks_url":"https://api.github.com/repos/nicolas-grekas/composer/forks","keys_url":"https://api.github.com/repos/nicolas-grekas/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolas-grekas/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolas-grekas/composer/teams","hooks_url":"https://api.github.com/repos/nicolas-grekas/composer/hooks","issue_events_url":"https://api.github.com/repos/nicolas-grekas/composer/issues/events{/number}","events_url":"https://api.github.com/repos/nicolas-grekas/composer/events","assignees_url":"https://api.github.com/repos/nicolas-grekas/composer/assignees{/user}","branches_url":"https://api.github.com/repos/nicolas-grekas/composer/branches{/branch}","tags_url":"https://api.github.com/repos/nicolas-grekas/composer/tags","blobs_url":"https://api.github.com/repos/nicolas-grekas/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolas-grekas/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolas-grekas/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolas-grekas/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolas-grekas/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolas-grekas/composer/languages","stargazers_url":"https://api.github.com/repos/nicolas-grekas/composer/stargazers","contributors_url":"https://api.github.com/repos/nicolas-grekas/composer/contributors","subscribers_url":"https://api.github.com/repos/nicolas-grekas/composer/subscribers","subscription_url":"https://api.github.com/repos/nicolas-grekas/composer/subscription","commits_url":"https://api.github.com/repos/nicolas-grekas/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolas-grekas/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolas-grekas/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolas-grekas/composer/issues/comments/{number}","contents_url":"https://api.github.com/repos/nicolas-grekas/composer/contents/{+path}","compare_url":"https://api.github.com/repos/nicolas-grekas/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolas-grekas/composer/merges","archive_url":"https://api.github.com/repos/nicolas-grekas/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolas-grekas/composer/downloads","issues_url":"https://api.github.com/repos/nicolas-grekas/composer/issues{/number}","pulls_url":"https://api.github.com/repos/nicolas-grekas/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolas-grekas/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolas-grekas/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolas-grekas/composer/labels{/name}","releases_url":"https://api.github.com/repos/nicolas-grekas/composer/releases{/id}","created_at":"2014-02-04T19:26:50Z","updated_at":"2014-02-06T11:11:42Z","pushed_at":"2014-11-21T13:01:56Z","git_url":"git://github.com/nicolas-grekas/composer.git","ssh_url":"git@github.com:nicolas-grekas/composer.git","clone_url":"https://github.com/nicolas-grekas/composer.git","svn_url":"https://github.com/nicolas-grekas/composer","homepage":"http://getcomposer.org/","size":9406,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"composer:master","ref":"master","sha":"edd4b2f984821fa696f1be848f9d5b5aea449537","user":{"login":"composer","id":837015,"avatar_url":"https://avatars.githubusercontent.com/u/837015?v=3","gravatar_id":"","url":"https://api.github.com/users/composer","html_url":"https://github.com/composer","followers_url":"https://api.github.com/users/composer/followers","following_url":"https://api.github.com/users/composer/following{/other_user}","gists_url":"https://api.github.com/users/composer/gists{/gist_id}","starred_url":"https://api.github.com/users/composer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composer/subscriptions","organizations_url":"https://api.github.com/users/composer/orgs","repos_url":"https://api.github.com/users/composer/repos","events_url":"https://api.github.com/users/composer/events{/privacy}","received_events_url":"https://api.github.com/users/composer/received_events","type":"Organization","site_admin":false},"repo":{"id":1864363,"name":"composer","full_name":"composer/composer","owner":{"login":"composer","id":837015,"avatar_url":"https://avatars.githubusercontent.com/u/837015?v=3","gravatar_id":"","url":"https://api.github.com/users/composer","html_url":"https://github.com/composer","followers_url":"https://api.github.com/users/composer/followers","following_url":"https://api.github.com/users/composer/following{/other_user}","gists_url":"https://api.github.com/users/composer/gists{/gist_id}","starred_url":"https://api.github.com/users/composer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composer/subscriptions","organizations_url":"https://api.github.com/users/composer/orgs","repos_url":"https://api.github.com/users/composer/repos","events_url":"https://api.github.com/users/composer/events{/privacy}","received_events_url":"https://api.github.com/users/composer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/composer/composer","description":"Dependency Manager for PHP","fork":false,"url":"https://api.github.com/repos/composer/composer","forks_url":"https://api.github.com/repos/composer/composer/forks","keys_url":"https://api.github.com/repos/composer/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/composer/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/composer/composer/teams","hooks_url":"https://api.github.com/repos/composer/composer/hooks","issue_events_url":"https://api.github.com/repos/composer/composer/issues/events{/number}","events_url":"https://api.github.com/repos/composer/composer/events","assignees_url":"https://api.github.com/repos/composer/composer/assignees{/user}","branches_url":"https://api.github.com/repos/composer/composer/branches{/branch}","tags_url":"https://api.github.com/repos/composer/composer/tags","blobs_url":"https://api.github.com/repos/composer/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/composer/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/composer/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/composer/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/composer/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/composer/composer/languages","stargazers_url":"https://api.github.com/repos/composer/composer/stargazers","contributors_url":"https://api.github.com/repos/composer/composer/contributors","subscribers_url":"https://api.github.com/repos/composer/composer/subscribers","subscription_url":"https://api.github.com/repos/composer/composer/subscription","commits_url":"https://api.github.com/repos/composer/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/composer/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/composer/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/composer/composer/issues/comments/{number}","contents_url":"https://api.github.com/repos/composer/composer/contents/{+path}","compare_url":"https://api.github.com/repos/composer/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/composer/composer/merges","archive_url":"https://api.github.com/repos/composer/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/composer/composer/downloads","issues_url":"https://api.github.com/repos/composer/composer/issues{/number}","pulls_url":"https://api.github.com/repos/composer/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/composer/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/composer/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/composer/composer/labels{/name}","releases_url":"https://api.github.com/repos/composer/composer/releases{/id}","created_at":"2011-06-08T08:53:00Z","updated_at":"2014-11-21T14:58:32Z","pushed_at":"2014-11-21T14:57:16Z","git_url":"git://github.com/composer/composer.git","ssh_url":"git@github.com:composer/composer.git","clone_url":"https://github.com/composer/composer.git","svn_url":"https://github.com/composer/composer","homepage":"http://getcomposer.org/","size":25833,"stargazers_count":4613,"watchers_count":4613,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1264,"mirror_url":null,"open_issues_count":484,"forks":1264,"open_issues":484,"watchers":4613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/composer/composer/pulls/3450"},"html":{"href":"https://github.com/composer/composer/pull/3450"},"issue":{"href":"https://api.github.com/repos/composer/composer/issues/3450"},"comments":{"href":"https://api.github.com/repos/composer/composer/issues/3450/comments"},"review_comments":{"href":"https://api.github.com/repos/composer/composer/pulls/3450/comments"},"review_comment":{"href":"https://api.github.com/repos/composer/composer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/composer/composer/pulls/3450/commits"},"statuses":{"href":"https://api.github.com/repos/composer/composer/statuses/c632c7f1b34ba4d222725c5753f23a74435f825a"}}}}