GitHub PullRequestEvent at 2014-05-05 00:06:47
Repository: thrift
Actor: cristiancavalli
Payload: {"action":"closed","number":107,"pull_request":{"url":"https://api.github.com/repos/apache/thrift/pulls/107","id":15048456,"html_url":"https://github.com/apache/thrift/pull/107","diff_url":"https://github.com/apache/thrift/pull/107.diff","patch_url":"https://github.com/apache/thrift/pull/107.patch","issue_url":"https://api.github.com/repos/apache/thrift/issues/107","number":107,"state":"closed","title":"String Generation With Nested Single Quotes","user":{"login":"cristiancavalli","id":4976075,"avatar_url":"https://avatars.githubusercontent.com/u/4976075?","gravatar_id":"27cf1cdf63267f5bb7910e9034b5053c","url":"https://api.github.com/users/cristiancavalli","html_url":"https://github.com/cristiancavalli","followers_url":"https://api.github.com/users/cristiancavalli/followers","following_url":"https://api.github.com/users/cristiancavalli/following{/other_user}","gists_url":"https://api.github.com/users/cristiancavalli/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiancavalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiancavalli/subscriptions","organizations_url":"https://api.github.com/users/cristiancavalli/orgs","repos_url":"https://api.github.com/users/cristiancavalli/repos","events_url":"https://api.github.com/users/cristiancavalli/events{/privacy}","received_events_url":"https://api.github.com/users/cristiancavalli/received_events","type":"User","site_admin":false},"body":"If I have a string in a struct with an apostrophe, string generation in the thrift js compiler will generate a malformed and un-escaped string, this wraps the outputted string in double quotes rather than single quotes.","created_at":"2014-04-23T04:14:00Z","updated_at":"2014-05-05T00:06:47Z","closed_at":"2014-05-05T00:06:47Z","merged_at":null,"merge_commit_sha":"2a11087438f8beeb020ca1d326ce3fab73be8396","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/thrift/pulls/107/commits","review_comments_url":"https://api.github.com/repos/apache/thrift/pulls/107/comments","review_comment_url":"https://api.github.com/repos/apache/thrift/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/thrift/issues/107/comments","statuses_url":"https://api.github.com/repos/apache/thrift/statuses/386cd111fdd6c977ca5dd0adf635b7594eeaacf9","head":{"label":"cristiancavalli:master","ref":"master","sha":"386cd111fdd6c977ca5dd0adf635b7594eeaacf9","user":{"login":"cristiancavalli","id":4976075,"avatar_url":"https://avatars.githubusercontent.com/u/4976075?","gravatar_id":"27cf1cdf63267f5bb7910e9034b5053c","url":"https://api.github.com/users/cristiancavalli","html_url":"https://github.com/cristiancavalli","followers_url":"https://api.github.com/users/cristiancavalli/followers","following_url":"https://api.github.com/users/cristiancavalli/following{/other_user}","gists_url":"https://api.github.com/users/cristiancavalli/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiancavalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiancavalli/subscriptions","organizations_url":"https://api.github.com/users/cristiancavalli/orgs","repos_url":"https://api.github.com/users/cristiancavalli/repos","events_url":"https://api.github.com/users/cristiancavalli/events{/privacy}","received_events_url":"https://api.github.com/users/cristiancavalli/received_events","type":"User","site_admin":false},"repo":{"id":19056507,"name":"thrift","full_name":"cristiancavalli/thrift","owner":{"login":"cristiancavalli","id":4976075,"avatar_url":"https://avatars.githubusercontent.com/u/4976075?","gravatar_id":"27cf1cdf63267f5bb7910e9034b5053c","url":"https://api.github.com/users/cristiancavalli","html_url":"https://github.com/cristiancavalli","followers_url":"https://api.github.com/users/cristiancavalli/followers","following_url":"https://api.github.com/users/cristiancavalli/following{/other_user}","gists_url":"https://api.github.com/users/cristiancavalli/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiancavalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiancavalli/subscriptions","organizations_url":"https://api.github.com/users/cristiancavalli/orgs","repos_url":"https://api.github.com/users/cristiancavalli/repos","events_url":"https://api.github.com/users/cristiancavalli/events{/privacy}","received_events_url":"https://api.github.com/users/cristiancavalli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cristiancavalli/thrift","description":"Mirror of Apache Thrift","fork":true,"url":"https://api.github.com/repos/cristiancavalli/thrift","forks_url":"https://api.github.com/repos/cristiancavalli/thrift/forks","keys_url":"https://api.github.com/repos/cristiancavalli/thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristiancavalli/thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristiancavalli/thrift/teams","hooks_url":"https://api.github.com/repos/cristiancavalli/thrift/hooks","issue_events_url":"https://api.github.com/repos/cristiancavalli/thrift/issues/events{/number}","events_url":"https://api.github.com/repos/cristiancavalli/thrift/events","assignees_url":"https://api.github.com/repos/cristiancavalli/thrift/assignees{/user}","branches_url":"https://api.github.com/repos/cristiancavalli/thrift/branches{/branch}","tags_url":"https://api.github.com/repos/cristiancavalli/thrift/tags","blobs_url":"https://api.github.com/repos/cristiancavalli/thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristiancavalli/thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristiancavalli/thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristiancavalli/thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristiancavalli/thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/cristiancavalli/thrift/languages","stargazers_url":"https://api.github.com/repos/cristiancavalli/thrift/stargazers","contributors_url":"https://api.github.com/repos/cristiancavalli/thrift/contributors","subscribers_url":"https://api.github.com/repos/cristiancavalli/thrift/subscribers","subscription_url":"https://api.github.com/repos/cristiancavalli/thrift/subscription","commits_url":"https://api.github.com/repos/cristiancavalli/thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristiancavalli/thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristiancavalli/thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristiancavalli/thrift/issues/comments/{number}","contents_url":"https://api.github.com/repos/cristiancavalli/thrift/contents/{+path}","compare_url":"https://api.github.com/repos/cristiancavalli/thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristiancavalli/thrift/merges","archive_url":"https://api.github.com/repos/cristiancavalli/thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristiancavalli/thrift/downloads","issues_url":"https://api.github.com/repos/cristiancavalli/thrift/issues{/number}","pulls_url":"https://api.github.com/repos/cristiancavalli/thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/cristiancavalli/thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/cristiancavalli/thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristiancavalli/thrift/labels{/name}","releases_url":"https://api.github.com/repos/cristiancavalli/thrift/releases{/id}","created_at":"2014-04-23T04:06:43Z","updated_at":"2014-04-23T04:14:00Z","pushed_at":"2014-04-23T04:12:54Z","git_url":"git://github.com/cristiancavalli/thrift.git","ssh_url":"git@github.com:cristiancavalli/thrift.git","clone_url":"https://github.com/cristiancavalli/thrift.git","svn_url":"https://github.com/cristiancavalli/thrift","homepage":"","size":9029,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"751c97c2df228ab7d73f7add3a7b3f187aa5326a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":310611,"name":"thrift","full_name":"apache/thrift","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/thrift","description":"Mirror of Apache Thrift","fork":false,"url":"https://api.github.com/repos/apache/thrift","forks_url":"https://api.github.com/repos/apache/thrift/forks","keys_url":"https://api.github.com/repos/apache/thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/thrift/teams","hooks_url":"https://api.github.com/repos/apache/thrift/hooks","issue_events_url":"https://api.github.com/repos/apache/thrift/issues/events{/number}","events_url":"https://api.github.com/repos/apache/thrift/events","assignees_url":"https://api.github.com/repos/apache/thrift/assignees{/user}","branches_url":"https://api.github.com/repos/apache/thrift/branches{/branch}","tags_url":"https://api.github.com/repos/apache/thrift/tags","blobs_url":"https://api.github.com/repos/apache/thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/thrift/languages","stargazers_url":"https://api.github.com/repos/apache/thrift/stargazers","contributors_url":"https://api.github.com/repos/apache/thrift/contributors","subscribers_url":"https://api.github.com/repos/apache/thrift/subscribers","subscription_url":"https://api.github.com/repos/apache/thrift/subscription","commits_url":"https://api.github.com/repos/apache/thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/thrift/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/thrift/contents/{+path}","compare_url":"https://api.github.com/repos/apache/thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/thrift/merges","archive_url":"https://api.github.com/repos/apache/thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/thrift/downloads","issues_url":"https://api.github.com/repos/apache/thrift/issues{/number}","pulls_url":"https://api.github.com/repos/apache/thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/thrift/labels{/name}","releases_url":"https://api.github.com/repos/apache/thrift/releases{/id}","created_at":"2009-09-18T08:00:17Z","updated_at":"2014-05-04T21:41:08Z","pushed_at":"2014-05-04T21:41:07Z","git_url":"git://github.com/apache/thrift.git","ssh_url":"git@github.com:apache/thrift.git","clone_url":"https://github.com/apache/thrift.git","svn_url":"https://github.com/apache/thrift","homepage":"","size":15585,"stargazers_count":931,"watchers_count":931,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":551,"mirror_url":"git://git.apache.org/thrift.git","open_issues_count":17,"forks":551,"open_issues":17,"watchers":931,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/thrift/pulls/107"},"html":{"href":"https://github.com/apache/thrift/pull/107"},"issue":{"href":"https://api.github.com/repos/apache/thrift/issues/107"},"comments":{"href":"https://api.github.com/repos/apache/thrift/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/thrift/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/thrift/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/thrift/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/apache/thrift/statuses/386cd111fdd6c977ca5dd0adf635b7594eeaacf9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}