GitHub PullRequestReviewCommentEvent at 2014-12-29 17:02:55
Repository: dolphin
Actor: magumagu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/22318894","id":22318894,"diff_hunk":"@@ -143,11 +143,12 @@ using namespace Gen;\n \n \t\t// Convert the logical address to a physical address for the block map\n \t\tu32 pAddr = b.originalAddress & 0x1FFFFFFF;\n+\t\tu32 pAddrEnd = pAddr + (b.originalSize ? b.originalSize - 1 : 0) * 4;\n \n-\t\tfor (u32 block = pAddr / 32; block <= (pAddr + (b.originalSize - 1) * 4) / 32; ++block)\n+\t\tfor (u32 block = pAddr / 32; block <= pAddrEnd / 32; ++block)\n \t\t\tvalid_block.Set(block);\n \n-\t\tblock_map[std::make_pair(pAddr + 4 * b.originalSize - 1, pAddr)] = block_num;\n+\t\tblock_map[std::make_pair(pAddrEnd, pAddr)] = block_num;","path":"Source/Core/Core/PowerPC/JitCommon/JitCache.cpp","position":11,"original_position":11,"commit_id":"02f9c58cddd01adfe74b5f99ab87c372d7aa98e6","original_commit_id":"02f9c58cddd01adfe74b5f99ab87c372d7aa98e6","user":{"login":"magumagu","id":7026757,"avatar_url":"https://avatars.githubusercontent.com/u/7026757?v=3","gravatar_id":"","url":"https://api.github.com/users/magumagu","html_url":"https://github.com/magumagu","followers_url":"https://api.github.com/users/magumagu/followers","following_url":"https://api.github.com/users/magumagu/following{/other_user}","gists_url":"https://api.github.com/users/magumagu/gists{/gist_id}","starred_url":"https://api.github.com/users/magumagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magumagu/subscriptions","organizations_url":"https://api.github.com/users/magumagu/orgs","repos_url":"https://api.github.com/users/magumagu/repos","events_url":"https://api.github.com/users/magumagu/events{/privacy}","received_events_url":"https://api.github.com/users/magumagu/received_events","type":"User","site_admin":false},"body":"I think the difference doesn't actually affect the algorithm, given that instruction addresses are divisible by 4.  I'll double-check later.","created_at":"2014-12-29T17:02:55Z","updated_at":"2014-12-29T17:02:55Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/1772#discussion_r22318894","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1772","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/22318894"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1772#discussion_r22318894"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1772"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1772","id":26603796,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1772","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1772.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1772.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1772","number":1772,"state":"open","locked":false,"title":"JIT: fix possible block map crash with ISI blocks","user":{"login":"FioraAeterna","id":7761472,"avatar_url":"https://avatars.githubusercontent.com/u/7761472?v=3","gravatar_id":"","url":"https://api.github.com/users/FioraAeterna","html_url":"https://github.com/FioraAeterna","followers_url":"https://api.github.com/users/FioraAeterna/followers","following_url":"https://api.github.com/users/FioraAeterna/following{/other_user}","gists_url":"https://api.github.com/users/FioraAeterna/gists{/gist_id}","starred_url":"https://api.github.com/users/FioraAeterna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FioraAeterna/subscriptions","organizations_url":"https://api.github.com/users/FioraAeterna/orgs","repos_url":"https://api.github.com/users/FioraAeterna/repos","events_url":"https://api.github.com/users/FioraAeterna/events{/privacy}","received_events_url":"https://api.github.com/users/FioraAeterna/received_events","type":"User","site_admin":false},"body":"If a block ISIs at the start (zero instructions) the logic here can fail and\r\ncause a crash.","created_at":"2014-12-26T17:47:53Z","updated_at":"2014-12-29T17:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bd7bb0fdcb84231486714b1b91f670a6e4bbc63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1772/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1772/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1772/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/02f9c58cddd01adfe74b5f99ab87c372d7aa98e6","head":{"label":"FioraAeterna:fixblockmapcrash","ref":"fixblockmapcrash","sha":"02f9c58cddd01adfe74b5f99ab87c372d7aa98e6","user":{"login":"FioraAeterna","id":7761472,"avatar_url":"https://avatars.githubusercontent.com/u/7761472?v=3","gravatar_id":"","url":"https://api.github.com/users/FioraAeterna","html_url":"https://github.com/FioraAeterna","followers_url":"https://api.github.com/users/FioraAeterna/followers","following_url":"https://api.github.com/users/FioraAeterna/following{/other_user}","gists_url":"https://api.github.com/users/FioraAeterna/gists{/gist_id}","starred_url":"https://api.github.com/users/FioraAeterna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FioraAeterna/subscriptions","organizations_url":"https://api.github.com/users/FioraAeterna/orgs","repos_url":"https://api.github.com/users/FioraAeterna/repos","events_url":"https://api.github.com/users/FioraAeterna/events{/privacy}","received_events_url":"https://api.github.com/users/FioraAeterna/received_events","type":"User","site_admin":false},"repo":{"id":22325428,"name":"dolphin","full_name":"FioraAeterna/dolphin","owner":{"login":"FioraAeterna","id":7761472,"avatar_url":"https://avatars.githubusercontent.com/u/7761472?v=3","gravatar_id":"","url":"https://api.github.com/users/FioraAeterna","html_url":"https://github.com/FioraAeterna","followers_url":"https://api.github.com/users/FioraAeterna/followers","following_url":"https://api.github.com/users/FioraAeterna/following{/other_user}","gists_url":"https://api.github.com/users/FioraAeterna/gists{/gist_id}","starred_url":"https://api.github.com/users/FioraAeterna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FioraAeterna/subscriptions","organizations_url":"https://api.github.com/users/FioraAeterna/orgs","repos_url":"https://api.github.com/users/FioraAeterna/repos","events_url":"https://api.github.com/users/FioraAeterna/events{/privacy}","received_events_url":"https://api.github.com/users/FioraAeterna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FioraAeterna/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/FioraAeterna/dolphin","forks_url":"https://api.github.com/repos/FioraAeterna/dolphin/forks","keys_url":"https://api.github.com/repos/FioraAeterna/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FioraAeterna/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FioraAeterna/dolphin/teams","hooks_url":"https://api.github.com/repos/FioraAeterna/dolphin/hooks","issue_events_url":"https://api.github.com/repos/FioraAeterna/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/FioraAeterna/dolphin/events","assignees_url":"https://api.github.com/repos/FioraAeterna/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/FioraAeterna/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/FioraAeterna/dolphin/tags","blobs_url":"https://api.github.com/repos/FioraAeterna/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FioraAeterna/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FioraAeterna/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/FioraAeterna/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FioraAeterna/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/FioraAeterna/dolphin/languages","stargazers_url":"https://api.github.com/repos/FioraAeterna/dolphin/stargazers","contributors_url":"https://api.github.com/repos/FioraAeterna/dolphin/contributors","subscribers_url":"https://api.github.com/repos/FioraAeterna/dolphin/subscribers","subscription_url":"https://api.github.com/repos/FioraAeterna/dolphin/subscription","commits_url":"https://api.github.com/repos/FioraAeterna/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/FioraAeterna/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/FioraAeterna/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/FioraAeterna/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/FioraAeterna/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/FioraAeterna/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FioraAeterna/dolphin/merges","archive_url":"https://api.github.com/repos/FioraAeterna/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FioraAeterna/dolphin/downloads","issues_url":"https://api.github.com/repos/FioraAeterna/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/FioraAeterna/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/FioraAeterna/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/FioraAeterna/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FioraAeterna/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/FioraAeterna/dolphin/releases{/id}","created_at":"2014-07-27T23:36:14Z","updated_at":"2014-12-27T17:51:38Z","pushed_at":"2014-12-28T07:19:56Z","git_url":"git://github.com/FioraAeterna/dolphin.git","ssh_url":"git@github.com:FioraAeterna/dolphin.git","clone_url":"https://github.com/FioraAeterna/dolphin.git","svn_url":"https://github.com/FioraAeterna/dolphin","homepage":null,"size":202831,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"339383b8dd44dc6f196fbb16d55b72a4882d2a7f","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2014-12-29T16:27:02Z","pushed_at":"2014-12-29T12:19:47Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":247949,"stargazers_count":886,"watchers_count":886,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":282,"mirror_url":null,"open_issues_count":56,"forks":282,"open_issues":56,"watchers":886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1772"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1772"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1772"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1772/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1772/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1772/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/02f9c58cddd01adfe74b5f99ab87c372d7aa98e6"}}}}