GitHub PullRequestReviewCommentEvent at 2014-09-25 11:11:35
Repository: sm
Actor: germanop
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/sm/pulls/comments/18025854","id":18025854,"diff_hunk":"@@ -57,8 +57,20 @@ def type(self, sr_uuid):\n \n     def vdi(self, uuid):\n         util.SMlog(\"params = %s\" % (self.srcmd.params.keys()))\n-        return udevVDI(self, self.srcmd.params['vdi_location'])\n-    \n+\n+        if 'vdi_location' in self.srcmd.params:\n+            vdi_location = self.srcmd.params['vdi_location']\n+        else:\n+            vdi_location = self.get_vdi_location(uuid)\n+\n+        return udevVDI(self, vdi_location)\n+\n+    def get_vdi_location(self, uuid):","path":"drivers/udevSR.py","position":14,"original_position":14,"commit_id":"be6785ded6856cc8f8b1fc53905deeb158636c4e","original_commit_id":"be6785ded6856cc8f8b1fc53905deeb158636c4e","user":{"login":"germanop","id":3437428,"avatar_url":"https://avatars.githubusercontent.com/u/3437428?v=2","gravatar_id":"","url":"https://api.github.com/users/germanop","html_url":"https://github.com/germanop","followers_url":"https://api.github.com/users/germanop/followers","following_url":"https://api.github.com/users/germanop/following{/other_user}","gists_url":"https://api.github.com/users/germanop/gists{/gist_id}","starred_url":"https://api.github.com/users/germanop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanop/subscriptions","organizations_url":"https://api.github.com/users/germanop/orgs","repos_url":"https://api.github.com/users/germanop/repos","events_url":"https://api.github.com/users/germanop/events{/privacy}","received_events_url":"https://api.github.com/users/germanop/received_events","type":"User","site_admin":false},"body":"Can this function throw exception?","created_at":"2014-09-25T11:11:35Z","updated_at":"2014-09-25T11:11:35Z","html_url":"https://github.com/xapi-project/sm/pull/223#discussion_r18025854","pull_request_url":"https://api.github.com/repos/xapi-project/sm/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/sm/pulls/comments/18025854"},"html":{"href":"https://github.com/xapi-project/sm/pull/223#discussion_r18025854"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/sm/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/sm/pulls/223","id":21596475,"html_url":"https://github.com/xapi-project/sm/pull/223","diff_url":"https://github.com/xapi-project/sm/pull/223.diff","patch_url":"https://github.com/xapi-project/sm/pull/223.patch","issue_url":"https://api.github.com/repos/xapi-project/sm/issues/223","number":223,"state":"open","locked":false,"title":"CA-145685: Create a tap disk to pass the host DVD drive to a PV guest","user":{"login":"fquesnel","id":4571600,"avatar_url":"https://avatars.githubusercontent.com/u/4571600?v=2","gravatar_id":"","url":"https://api.github.com/users/fquesnel","html_url":"https://github.com/fquesnel","followers_url":"https://api.github.com/users/fquesnel/followers","following_url":"https://api.github.com/users/fquesnel/following{/other_user}","gists_url":"https://api.github.com/users/fquesnel/gists{/gist_id}","starred_url":"https://api.github.com/users/fquesnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fquesnel/subscriptions","organizations_url":"https://api.github.com/users/fquesnel/orgs","repos_url":"https://api.github.com/users/fquesnel/repos","events_url":"https://api.github.com/users/fquesnel/events{/privacy}","received_events_url":"https://api.github.com/users/fquesnel/received_events","type":"User","site_admin":false},"body":"First draft to create a tap disk, to pass the host DVD drive to a PV guest.\r\n\r\nBefore testing this patch, the following modifications must be applied to blktap first:\r\nhttps://github.com/xapi-project/blktap/pull/133\r\n\r\nConsidering several ways to improve this PR:\r\n-Provide two distinct commits, one for production code and another one for unit tests\r\n-Avoid relying on string \"/dev/xapi/cd\", since a change in this path would break SM\r\n\r\nThanks\r\n\r\nSigned-off-by: Flavien Quesnel <flavien.quesnel@citrix.com>","created_at":"2014-09-22T17:53:49Z","updated_at":"2014-09-25T11:11:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b3a1173d8496588ed4da3ba355355a381fb5c59","assignee":{"login":"germanop","id":3437428,"avatar_url":"https://avatars.githubusercontent.com/u/3437428?v=2","gravatar_id":"","url":"https://api.github.com/users/germanop","html_url":"https://github.com/germanop","followers_url":"https://api.github.com/users/germanop/followers","following_url":"https://api.github.com/users/germanop/following{/other_user}","gists_url":"https://api.github.com/users/germanop/gists{/gist_id}","starred_url":"https://api.github.com/users/germanop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanop/subscriptions","organizations_url":"https://api.github.com/users/germanop/orgs","repos_url":"https://api.github.com/users/germanop/repos","events_url":"https://api.github.com/users/germanop/events{/privacy}","received_events_url":"https://api.github.com/users/germanop/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/sm/pulls/223/commits","review_comments_url":"https://api.github.com/repos/xapi-project/sm/pulls/223/comments","review_comment_url":"https://api.github.com/repos/xapi-project/sm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xapi-project/sm/issues/223/comments","statuses_url":"https://api.github.com/repos/xapi-project/sm/statuses/be6785ded6856cc8f8b1fc53905deeb158636c4e","head":{"label":"fquesnel:CA-145685","ref":"CA-145685","sha":"be6785ded6856cc8f8b1fc53905deeb158636c4e","user":{"login":"fquesnel","id":4571600,"avatar_url":"https://avatars.githubusercontent.com/u/4571600?v=2","gravatar_id":"","url":"https://api.github.com/users/fquesnel","html_url":"https://github.com/fquesnel","followers_url":"https://api.github.com/users/fquesnel/followers","following_url":"https://api.github.com/users/fquesnel/following{/other_user}","gists_url":"https://api.github.com/users/fquesnel/gists{/gist_id}","starred_url":"https://api.github.com/users/fquesnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fquesnel/subscriptions","organizations_url":"https://api.github.com/users/fquesnel/orgs","repos_url":"https://api.github.com/users/fquesnel/repos","events_url":"https://api.github.com/users/fquesnel/events{/privacy}","received_events_url":"https://api.github.com/users/fquesnel/received_events","type":"User","site_admin":false},"repo":{"id":23153611,"name":"sm","full_name":"fquesnel/sm","owner":{"login":"fquesnel","id":4571600,"avatar_url":"https://avatars.githubusercontent.com/u/4571600?v=2","gravatar_id":"","url":"https://api.github.com/users/fquesnel","html_url":"https://github.com/fquesnel","followers_url":"https://api.github.com/users/fquesnel/followers","following_url":"https://api.github.com/users/fquesnel/following{/other_user}","gists_url":"https://api.github.com/users/fquesnel/gists{/gist_id}","starred_url":"https://api.github.com/users/fquesnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fquesnel/subscriptions","organizations_url":"https://api.github.com/users/fquesnel/orgs","repos_url":"https://api.github.com/users/fquesnel/repos","events_url":"https://api.github.com/users/fquesnel/events{/privacy}","received_events_url":"https://api.github.com/users/fquesnel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fquesnel/sm","description":"Xapi Project storage managers","fork":true,"url":"https://api.github.com/repos/fquesnel/sm","forks_url":"https://api.github.com/repos/fquesnel/sm/forks","keys_url":"https://api.github.com/repos/fquesnel/sm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fquesnel/sm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fquesnel/sm/teams","hooks_url":"https://api.github.com/repos/fquesnel/sm/hooks","issue_events_url":"https://api.github.com/repos/fquesnel/sm/issues/events{/number}","events_url":"https://api.github.com/repos/fquesnel/sm/events","assignees_url":"https://api.github.com/repos/fquesnel/sm/assignees{/user}","branches_url":"https://api.github.com/repos/fquesnel/sm/branches{/branch}","tags_url":"https://api.github.com/repos/fquesnel/sm/tags","blobs_url":"https://api.github.com/repos/fquesnel/sm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fquesnel/sm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fquesnel/sm/git/refs{/sha}","trees_url":"https://api.github.com/repos/fquesnel/sm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fquesnel/sm/statuses/{sha}","languages_url":"https://api.github.com/repos/fquesnel/sm/languages","stargazers_url":"https://api.github.com/repos/fquesnel/sm/stargazers","contributors_url":"https://api.github.com/repos/fquesnel/sm/contributors","subscribers_url":"https://api.github.com/repos/fquesnel/sm/subscribers","subscription_url":"https://api.github.com/repos/fquesnel/sm/subscription","commits_url":"https://api.github.com/repos/fquesnel/sm/commits{/sha}","git_commits_url":"https://api.github.com/repos/fquesnel/sm/git/commits{/sha}","comments_url":"https://api.github.com/repos/fquesnel/sm/comments{/number}","issue_comment_url":"https://api.github.com/repos/fquesnel/sm/issues/comments/{number}","contents_url":"https://api.github.com/repos/fquesnel/sm/contents/{+path}","compare_url":"https://api.github.com/repos/fquesnel/sm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fquesnel/sm/merges","archive_url":"https://api.github.com/repos/fquesnel/sm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fquesnel/sm/downloads","issues_url":"https://api.github.com/repos/fquesnel/sm/issues{/number}","pulls_url":"https://api.github.com/repos/fquesnel/sm/pulls{/number}","milestones_url":"https://api.github.com/repos/fquesnel/sm/milestones{/number}","notifications_url":"https://api.github.com/repos/fquesnel/sm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fquesnel/sm/labels{/name}","releases_url":"https://api.github.com/repos/fquesnel/sm/releases{/id}","created_at":"2014-08-20T15:25:01Z","updated_at":"2014-07-07T09:22:37Z","pushed_at":"2014-09-24T16:47:36Z","git_url":"git://github.com/fquesnel/sm.git","ssh_url":"git@github.com:fquesnel/sm.git","clone_url":"https://github.com/fquesnel/sm.git","svn_url":"https://github.com/fquesnel/sm","homepage":null,"size":1178,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:xs64bit","ref":"xs64bit","sha":"ad3bc91bbb8dc96adfde6c84da0a23abcee4135b","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=2","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10689273,"name":"sm","full_name":"xapi-project/sm","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=2","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/sm","description":"Xapi Project storage managers","fork":false,"url":"https://api.github.com/repos/xapi-project/sm","forks_url":"https://api.github.com/repos/xapi-project/sm/forks","keys_url":"https://api.github.com/repos/xapi-project/sm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/sm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/sm/teams","hooks_url":"https://api.github.com/repos/xapi-project/sm/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/sm/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/sm/events","assignees_url":"https://api.github.com/repos/xapi-project/sm/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/sm/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/sm/tags","blobs_url":"https://api.github.com/repos/xapi-project/sm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/sm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/sm/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/sm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/sm/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/sm/languages","stargazers_url":"https://api.github.com/repos/xapi-project/sm/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/sm/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/sm/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/sm/subscription","commits_url":"https://api.github.com/repos/xapi-project/sm/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/sm/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/sm/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/sm/issues/comments/{number}","contents_url":"https://api.github.com/repos/xapi-project/sm/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/sm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/sm/merges","archive_url":"https://api.github.com/repos/xapi-project/sm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/sm/downloads","issues_url":"https://api.github.com/repos/xapi-project/sm/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/sm/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/sm/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/sm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/sm/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/sm/releases{/id}","created_at":"2013-06-14T13:17:00Z","updated_at":"2014-08-28T10:01:30Z","pushed_at":"2014-09-23T11:51:29Z","git_url":"git://github.com/xapi-project/sm.git","ssh_url":"git@github.com:xapi-project/sm.git","clone_url":"https://github.com/xapi-project/sm.git","svn_url":"https://github.com/xapi-project/sm","homepage":null,"size":5247,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":12,"forks":30,"open_issues":12,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/sm/pulls/223"},"html":{"href":"https://github.com/xapi-project/sm/pull/223"},"issue":{"href":"https://api.github.com/repos/xapi-project/sm/issues/223"},"comments":{"href":"https://api.github.com/repos/xapi-project/sm/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/sm/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/sm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/sm/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/sm/statuses/be6785ded6856cc8f8b1fc53905deeb158636c4e"}}}}