GitHub PushEvent at 2014-12-11 00:27:36
Repository: phabricator
Actor: epriestley
Payload: {"shas":[["7d96870570567054a2f5be99d245ead812d4be20","3abdeb20bbfaf7f3efaf2a217619f0ce681d08bb@phacility.com","Maniphest - use subscribers framework properly\n\nSummary: Fixes T5604. This should fix some random bugs, lets us move forward more easily, and all that good stuff about killing code debt.\n\nTest Plan:\n- Conduit method maniphest.createtask\n  - verified creating user subscribed\n  - verified subscription transaction\n- Conduit method maniphest.update\n  - verified subscribers set as specified to ccPHIDs parameter\n  - verified subscription transaction\n- Herald\n  - verified herald rule to add subscriber worked\n  - verified no subscribers removed accidentally\n- edit controller\n  - test create and verify author gets added IFF they put themselves in subscribers control box\n  - test update gets set to exactly what user enters\n- lipsum generator'd tasks work\n- bulk add subscribers works\n- bulk remove subscriber works\n- detail controller\n  - added myself by leaving a comment\n  - added another user via explicit action\n  - added another user via implicit mention\n- task merge via search attach controller\n- mail reply handler\n  - add subscriber via ./bin/mail receive-test\n  - unsubscribe via ./bin/mail receive-test\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T5604\n\nDifferential Revision: https://secure.phabricator.com/D10965","Bob Trahan",true]],"size":1,"ref":"refs/heads/master","head":"7d96870570567054a2f5be99d245ead812d4be20"}