GitHub PullRequestReviewCommentEvent at 2014-12-10 04:08:27
Repository: spark
Actor: andrewor14
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/21583427","id":21583427,"diff_hunk":"@@ -221,33 +238,87 @@ private[history] class FsHistoryProvider(conf: SparkConf) extends ApplicationHis\n     }\n   }\n \n-  private def createReplayBus(logDir: FileStatus): (ReplayListenerBus, ApplicationEventListener) = {\n-    val path = logDir.getPath()\n-    val elogInfo = EventLoggingListener.parseLoggingInfo(path, fs)\n-    val replayBus = new ReplayListenerBus(elogInfo.logPaths, fs, elogInfo.compressionCodec)\n-    val appListener = new ApplicationEventListener\n-    replayBus.addListener(appListener)\n-    (replayBus, appListener)\n+  /**\n+   * Replays the event data in the given log, and returns the application information.\n+   */\n+  private def replay(logPath: FileStatus, bus: ReplayListenerBus): FsApplicationHistoryInfo = {\n+    val (logInput, sparkVersion) =\n+      if (isLegacyLogDirectory(logPath)) {\n+        openOldLog(logPath.getPath())\n+      } else {\n+        EventLoggingListener.openEventLog(logPath.getPath(), fs)\n+      }\n+    try {\n+      val appListener = new ApplicationEventListener\n+      bus.addListener(appListener)\n+      bus.replay(logInput, sparkVersion)\n+      new FsApplicationHistoryInfo(\n+        logPath.getPath().getName(),\n+        appListener.appId.getOrElse(logPath.getPath().getName()),\n+        appListener.appName.getOrElse(NOT_STARTED),\n+        appListener.startTime.getOrElse(-1L),\n+        appListener.endTime.getOrElse(-1L),\n+        getModificationTime(logPath),\n+        appListener.sparkUser.getOrElse(NOT_STARTED))\n+    } finally {\n+      logInput.close()\n+    }\n   }\n \n-  /** Return when this directory was last modified. */\n-  private def getModificationTime(dir: FileStatus): Long = {\n-    try {\n-      val logFiles = fs.listStatus(dir.getPath)\n-      if (logFiles != null && !logFiles.isEmpty) {\n-        logFiles.map(_.getModificationTime).max\n-      } else {\n-        dir.getModificationTime\n+  /**\n+   * Load the a legacy log directory. This assumes that the log directory contains a single event\n+   * log file, which is the case for directories generated by the code in previous releases.","path":"core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala","position":197,"original_position":197,"commit_id":"ed0023e3bf8d0ab37063f006f75177a7245ddf8d","original_commit_id":"ed0023e3bf8d0ab37063f006f75177a7245ddf8d","user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"body":"you should add `single event log file, along with other files containing application meta data`. From this description alone it's not clear how the legacy directory is different from the new structure.","created_at":"2014-12-10T04:08:27Z","updated_at":"2014-12-10T04:08:27Z","html_url":"https://github.com/apache/spark/pull/1222#discussion_r21583427","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/1222","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/21583427"},"html":{"href":"https://github.com/apache/spark/pull/1222#discussion_r21583427"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/1222"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/1222","id":17623659,"html_url":"https://github.com/apache/spark/pull/1222","diff_url":"https://github.com/apache/spark/pull/1222.diff","patch_url":"https://github.com/apache/spark/pull/1222.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/1222","number":1222,"state":"open","locked":false,"title":"[SPARK-2261] Make event logger use a single file.","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars.githubusercontent.com/u/1694083?v=3","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"body":"Currently the event logger uses a directory and several files to\r\ndescribe an app's event log, all but one of which are empty. This\r\nis not very HDFS-friendly, since creating lots of nodes in HDFS\r\n(especially when they don't contain any data) is frowned upon due\r\nto the node metadata being kept in the NameNode's memory.\r\n\r\nInstead, add a header section to the event log file that contains metadata\r\nneeded to read the events. This metadata includes things like the Spark\r\nversion (for future code that may need it for backwards compatibility) and\r\nthe compression codec used for the event data.\r\n\r\nWith the new approach, aside from reducing the load on the NN, there's\r\nalso a lot less remote calls needed when reading the log directory.","created_at":"2014-06-25T23:51:15Z","updated_at":"2014-12-10T04:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e801955af003784f78caa426173b66a652d2ec63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/1222/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/1222/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/1222/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/ed0023e3bf8d0ab37063f006f75177a7245ddf8d","head":{"label":"vanzin:hist-server-single-log","ref":"hist-server-single-log","sha":"ed0023e3bf8d0ab37063f006f75177a7245ddf8d","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars.githubusercontent.com/u/1694083?v=3","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"repo":{"id":18302272,"name":"spark","full_name":"vanzin/spark","owner":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars.githubusercontent.com/u/1694083?v=3","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanzin/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/vanzin/spark","forks_url":"https://api.github.com/repos/vanzin/spark/forks","keys_url":"https://api.github.com/repos/vanzin/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanzin/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanzin/spark/teams","hooks_url":"https://api.github.com/repos/vanzin/spark/hooks","issue_events_url":"https://api.github.com/repos/vanzin/spark/issues/events{/number}","events_url":"https://api.github.com/repos/vanzin/spark/events","assignees_url":"https://api.github.com/repos/vanzin/spark/assignees{/user}","branches_url":"https://api.github.com/repos/vanzin/spark/branches{/branch}","tags_url":"https://api.github.com/repos/vanzin/spark/tags","blobs_url":"https://api.github.com/repos/vanzin/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanzin/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanzin/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanzin/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanzin/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/vanzin/spark/languages","stargazers_url":"https://api.github.com/repos/vanzin/spark/stargazers","contributors_url":"https://api.github.com/repos/vanzin/spark/contributors","subscribers_url":"https://api.github.com/repos/vanzin/spark/subscribers","subscription_url":"https://api.github.com/repos/vanzin/spark/subscription","commits_url":"https://api.github.com/repos/vanzin/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanzin/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanzin/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanzin/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/vanzin/spark/contents/{+path}","compare_url":"https://api.github.com/repos/vanzin/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanzin/spark/merges","archive_url":"https://api.github.com/repos/vanzin/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanzin/spark/downloads","issues_url":"https://api.github.com/repos/vanzin/spark/issues{/number}","pulls_url":"https://api.github.com/repos/vanzin/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/vanzin/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/vanzin/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanzin/spark/labels{/name}","releases_url":"https://api.github.com/repos/vanzin/spark/releases{/id}","created_at":"2014-03-31T17:49:25Z","updated_at":"2014-06-25T00:58:09Z","pushed_at":"2014-12-10T02:03:35Z","git_url":"git://github.com/vanzin/spark.git","ssh_url":"git@github.com:vanzin/spark.git","clone_url":"https://github.com/vanzin/spark.git","svn_url":"https://github.com/vanzin/spark","homepage":null,"size":84564,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"61f1a7022767e64ab092aa91c0c5aa1b2fdbef7c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-12-10T03:29:36Z","pushed_at":"2014-12-10T03:29:47Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1022723,"stargazers_count":2271,"watchers_count":2271,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2029,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":329,"forks":2029,"open_issues":329,"watchers":2271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/1222"},"html":{"href":"https://github.com/apache/spark/pull/1222"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/1222"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/1222/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/1222/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/1222/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/ed0023e3bf8d0ab37063f006f75177a7245ddf8d"}}}}