GitHub PullRequestReviewCommentEvent at 2014-04-10 12:20:45
Repository: scikit-learn
Actor: eickenberg
Payload: {"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/11481631","id":11481631,"diff_hunk":"@@ -526,3 +528,215 @@ def test_ridgecv_store_cv_values():\n     y = rng.randn(n_samples, n_responses)\n     r.fit(x, y)\n     assert_equal(r.cv_values_.shape, (n_samples, n_responses, n_alphas))\n+\n+\n+def test_ridge_sample_weights_in_feature_space():\n+    \"\"\"Check that Cholesky solver in feature space applies sample_weights\n+    correctly.\n+    \"\"\"\n+\n+    rng = np.random.RandomState(42)\n+\n+    n_sampless = [5, 6, 7] * 2\n+    n_featuress = [7, 6, 5] * 2\n+    n_targetss = [1, 1, 1, 2, 2, 2]","path":"sklearn/linear_model/tests/test_ridge.py","position":103,"original_position":103,"commit_id":"69e8e631f7c105dc7ea6dcb94daa3fdecf35b736","original_commit_id":"69e8e631f7c105dc7ea6dcb94daa3fdecf35b736","user":{"login":"eickenberg","id":1306635,"avatar_url":"https://avatars.githubusercontent.com/u/1306635?","gravatar_id":"232401446c8124a02a4ab131acede084","url":"https://api.github.com/users/eickenberg","html_url":"https://github.com/eickenberg","followers_url":"https://api.github.com/users/eickenberg/followers","following_url":"https://api.github.com/users/eickenberg/following{/other_user}","gists_url":"https://api.github.com/users/eickenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/eickenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eickenberg/subscriptions","organizations_url":"https://api.github.com/users/eickenberg/orgs","repos_url":"https://api.github.com/users/eickenberg/repos","events_url":"https://api.github.com/users/eickenberg/events{/privacy}","received_events_url":"https://api.github.com/users/eickenberg/received_events","type":"User","site_admin":false},"body":"These are actually plurals of n_samples, n_features, n_targets. Sorry for the idiosyncracy.","created_at":"2014-04-10T12:20:45Z","updated_at":"2014-04-10T12:20:45Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/3034#discussion_r11481631","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3034","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/11481631"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3034#discussion_r11481631"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3034"}}}}