GitHub PullRequestReviewCommentEvent at 2014-11-13 13:19:49
Repository: yast-fonts
Actor: jreidinger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-fonts/pulls/comments/20289695","id":20289695,"diff_hunk":"@@ -287,10 +305,144 @@ def handle_presets_button(widget, event)\n           initialize_searchmc_checkbox(\"\")\n           initialize_noother_checkbox(\"\")\n         end\n+        subpixel_freetype_warning\n+        installation_summary_check\n       end\n       return nil\n     end\n \n+    def graphic_match_preview(script, generic_alias)\n+        unless (script.nil?)\n+          text = \"<p><b>Family:</b> #{@current_families[generic_alias]}</b></p>\" +\n+                 \"<p><b>Specimen for #{script}</b></p>\" +\n+                 \"<center>\" + \n+                 \"<img src=\\\"#{@tmp_dir}/#{generic_alias}.png\\\"/>\" + \n+                 \"</center>\"\n+        else\n+          text = \"<b>No script found for \" +\n+                 \"#{@current_families[generic_alias]}.</b>\"\n+        end\n+        UI.ChangeWidget(Id(\"rt_specimen_#{generic_alias}\"), :Value, text)\n+    end\n+\n+    def text_match_preview(family, generic_alias)\n+      scripts = font_scripts(family);\n+      text = \"<p><b>Family:</b> #{family}</p>\" +\n+             \"<p><b>Scripts</b><ul>\"\n+      scripts.each do |script, coverage|\n+        text += \"<li>#{script} (#{coverage})</li>\"","path":"src/lib/fonts/fonts-dialog.rb","position":97,"original_position":97,"commit_id":"a321b2bea968de2c2cc0212c560cf0e5aa19b6e2","original_commit_id":"a321b2bea968de2c2cc0212c560cf0e5aa19b6e2","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?v=3","gravatar_id":"","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"better and more efficient ` text << \"<li>#{script} (#{coverage})</li>\"`","created_at":"2014-11-13T13:19:49Z","updated_at":"2014-11-13T13:19:49Z","html_url":"https://github.com/yast/yast-fonts/pull/9#discussion_r20289695","pull_request_url":"https://api.github.com/repos/yast/yast-fonts/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-fonts/pulls/comments/20289695"},"html":{"href":"https://github.com/yast/yast-fonts/pull/9#discussion_r20289695"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-fonts/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-fonts/pulls/9","id":24363889,"html_url":"https://github.com/yast/yast-fonts/pull/9","diff_url":"https://github.com/yast/yast-fonts/pull/9.diff","patch_url":"https://github.com/yast/yast-fonts/pull/9.patch","issue_url":"https://api.github.com/repos/yast/yast-fonts/issues/9","number":9,"state":"open","locked":false,"title":"add match preview tab 2","user":{"login":"pgajdos","id":4067843,"avatar_url":"https://avatars.githubusercontent.com/u/4067843?v=3","gravatar_id":"","url":"https://api.github.com/users/pgajdos","html_url":"https://github.com/pgajdos","followers_url":"https://api.github.com/users/pgajdos/followers","following_url":"https://api.github.com/users/pgajdos/following{/other_user}","gists_url":"https://api.github.com/users/pgajdos/gists{/gist_id}","starred_url":"https://api.github.com/users/pgajdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgajdos/subscriptions","organizations_url":"https://api.github.com/users/pgajdos/orgs","repos_url":"https://api.github.com/users/pgajdos/repos","events_url":"https://api.github.com/users/pgajdos/events{/privacy}","received_events_url":"https://api.github.com/users/pgajdos/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-13T12:10:40Z","updated_at":"2014-11-13T13:19:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79f848cd69731b35eb21687fec45c31df0412ef0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-fonts/pulls/9/commits","review_comments_url":"https://api.github.com/repos/yast/yast-fonts/pulls/9/comments","review_comment_url":"https://api.github.com/repos/yast/yast-fonts/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yast/yast-fonts/issues/9/comments","statuses_url":"https://api.github.com/repos/yast/yast-fonts/statuses/a321b2bea968de2c2cc0212c560cf0e5aa19b6e2","head":{"label":"pgajdos:master","ref":"master","sha":"a321b2bea968de2c2cc0212c560cf0e5aa19b6e2","user":{"login":"pgajdos","id":4067843,"avatar_url":"https://avatars.githubusercontent.com/u/4067843?v=3","gravatar_id":"","url":"https://api.github.com/users/pgajdos","html_url":"https://github.com/pgajdos","followers_url":"https://api.github.com/users/pgajdos/followers","following_url":"https://api.github.com/users/pgajdos/following{/other_user}","gists_url":"https://api.github.com/users/pgajdos/gists{/gist_id}","starred_url":"https://api.github.com/users/pgajdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgajdos/subscriptions","organizations_url":"https://api.github.com/users/pgajdos/orgs","repos_url":"https://api.github.com/users/pgajdos/repos","events_url":"https://api.github.com/users/pgajdos/events{/privacy}","received_events_url":"https://api.github.com/users/pgajdos/received_events","type":"User","site_admin":false},"repo":{"id":23179755,"name":"yast-fonts","full_name":"pgajdos/yast-fonts","owner":{"login":"pgajdos","id":4067843,"avatar_url":"https://avatars.githubusercontent.com/u/4067843?v=3","gravatar_id":"","url":"https://api.github.com/users/pgajdos","html_url":"https://github.com/pgajdos","followers_url":"https://api.github.com/users/pgajdos/followers","following_url":"https://api.github.com/users/pgajdos/following{/other_user}","gists_url":"https://api.github.com/users/pgajdos/gists{/gist_id}","starred_url":"https://api.github.com/users/pgajdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgajdos/subscriptions","organizations_url":"https://api.github.com/users/pgajdos/orgs","repos_url":"https://api.github.com/users/pgajdos/repos","events_url":"https://api.github.com/users/pgajdos/events{/privacy}","received_events_url":"https://api.github.com/users/pgajdos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgajdos/yast-fonts","description":"","fork":true,"url":"https://api.github.com/repos/pgajdos/yast-fonts","forks_url":"https://api.github.com/repos/pgajdos/yast-fonts/forks","keys_url":"https://api.github.com/repos/pgajdos/yast-fonts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgajdos/yast-fonts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgajdos/yast-fonts/teams","hooks_url":"https://api.github.com/repos/pgajdos/yast-fonts/hooks","issue_events_url":"https://api.github.com/repos/pgajdos/yast-fonts/issues/events{/number}","events_url":"https://api.github.com/repos/pgajdos/yast-fonts/events","assignees_url":"https://api.github.com/repos/pgajdos/yast-fonts/assignees{/user}","branches_url":"https://api.github.com/repos/pgajdos/yast-fonts/branches{/branch}","tags_url":"https://api.github.com/repos/pgajdos/yast-fonts/tags","blobs_url":"https://api.github.com/repos/pgajdos/yast-fonts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgajdos/yast-fonts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgajdos/yast-fonts/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgajdos/yast-fonts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgajdos/yast-fonts/statuses/{sha}","languages_url":"https://api.github.com/repos/pgajdos/yast-fonts/languages","stargazers_url":"https://api.github.com/repos/pgajdos/yast-fonts/stargazers","contributors_url":"https://api.github.com/repos/pgajdos/yast-fonts/contributors","subscribers_url":"https://api.github.com/repos/pgajdos/yast-fonts/subscribers","subscription_url":"https://api.github.com/repos/pgajdos/yast-fonts/subscription","commits_url":"https://api.github.com/repos/pgajdos/yast-fonts/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgajdos/yast-fonts/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgajdos/yast-fonts/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgajdos/yast-fonts/issues/comments/{number}","contents_url":"https://api.github.com/repos/pgajdos/yast-fonts/contents/{+path}","compare_url":"https://api.github.com/repos/pgajdos/yast-fonts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgajdos/yast-fonts/merges","archive_url":"https://api.github.com/repos/pgajdos/yast-fonts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgajdos/yast-fonts/downloads","issues_url":"https://api.github.com/repos/pgajdos/yast-fonts/issues{/number}","pulls_url":"https://api.github.com/repos/pgajdos/yast-fonts/pulls{/number}","milestones_url":"https://api.github.com/repos/pgajdos/yast-fonts/milestones{/number}","notifications_url":"https://api.github.com/repos/pgajdos/yast-fonts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgajdos/yast-fonts/labels{/name}","releases_url":"https://api.github.com/repos/pgajdos/yast-fonts/releases{/id}","created_at":"2014-08-21T08:28:11Z","updated_at":"2014-10-20T13:08:01Z","pushed_at":"2014-11-13T12:09:24Z","git_url":"git://github.com/pgajdos/yast-fonts.git","ssh_url":"git@github.com:pgajdos/yast-fonts.git","clone_url":"https://github.com/pgajdos/yast-fonts.git","svn_url":"https://github.com/pgajdos/yast-fonts","homepage":null,"size":419,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"e17a06293f1758c267a03b4829aa8aa89c99cb3a","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":20726474,"name":"yast-fonts","full_name":"yast/yast-fonts","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-fonts","description":"","fork":false,"url":"https://api.github.com/repos/yast/yast-fonts","forks_url":"https://api.github.com/repos/yast/yast-fonts/forks","keys_url":"https://api.github.com/repos/yast/yast-fonts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-fonts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-fonts/teams","hooks_url":"https://api.github.com/repos/yast/yast-fonts/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-fonts/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-fonts/events","assignees_url":"https://api.github.com/repos/yast/yast-fonts/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-fonts/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-fonts/tags","blobs_url":"https://api.github.com/repos/yast/yast-fonts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-fonts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-fonts/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-fonts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-fonts/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-fonts/languages","stargazers_url":"https://api.github.com/repos/yast/yast-fonts/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-fonts/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-fonts/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-fonts/subscription","commits_url":"https://api.github.com/repos/yast/yast-fonts/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-fonts/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-fonts/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-fonts/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-fonts/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-fonts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-fonts/merges","archive_url":"https://api.github.com/repos/yast/yast-fonts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-fonts/downloads","issues_url":"https://api.github.com/repos/yast/yast-fonts/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-fonts/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-fonts/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-fonts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-fonts/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-fonts/releases{/id}","created_at":"2014-06-11T13:38:12Z","updated_at":"2014-10-23T12:24:45Z","pushed_at":"2014-11-12T16:38:05Z","git_url":"git://github.com/yast/yast-fonts.git","ssh_url":"git@github.com:yast/yast-fonts.git","clone_url":"https://github.com/yast/yast-fonts.git","svn_url":"https://github.com/yast/yast-fonts","homepage":null,"size":402,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-fonts/pulls/9"},"html":{"href":"https://github.com/yast/yast-fonts/pull/9"},"issue":{"href":"https://api.github.com/repos/yast/yast-fonts/issues/9"},"comments":{"href":"https://api.github.com/repos/yast/yast-fonts/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-fonts/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-fonts/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-fonts/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-fonts/statuses/a321b2bea968de2c2cc0212c560cf0e5aa19b6e2"}}}}