GitHub PushEvent at 2014-05-05 12:08:54
Repository: core
Actor: maciejmrowiec
Payload: {"shas":[["7472e2016626481558f0922e5e8101bc8f26e569","63cb38ad5f6492ce71f0ee7bde78bea92e0cb873@linux.gr","cf-serverd: free getaddrinfo() result, on error of OpenReceiverChannel()\n\ngetaddrinfo() may allocate the 'result' struct even in cases where it\nwill return an error. Take care to free memory, although we would exit\nthe server process anyway.","P. Christeas",false],["5fe15aeca4ccd7c8a8100bfa9dce552b4eedafe1","63cb38ad5f6492ce71f0ee7bde78bea92e0cb873@linux.gr","cf-serverd: getaddrinfo() will use a numeric port, no lookup\n\nThis `AI_NUMERICSERV` flag avoids looking up the \"services\" table for\na string port resolution, according to the manual.","P. Christeas",false],["cbff1c1afb04ae5fa84ab2dd170c901e7fdb732b","63cb38ad5f6492ce71f0ee7bde78bea92e0cb873@linux.gr","cf-serverd: getaddrinfo() will NOT set \"errno\" upon failure\n\nIt has its own `gai_strerror()` function to resolve its (reentrant)\nresult code.","P. Christeas",false],["39788ff4d628ecc330dce0dbc2d3d6586259c964","63cb38ad5f6492ce71f0ee7bde78bea92e0cb873@linux.gr","cf-serverd: fix typo for addrinfo constant\n\nAs spotted by Dimitrios Apostolou","P. Christeas",false],["5ec9a6cc16a421497a1f702658135ba82820d147","f1497fa2045027e1383e4101420059be31f86c81@cfengine.com","Fix subindexing for maparray function\n\nClose #5452","Sigurd Teigen",false],["9f36a7d053e7038a19b3146ca4f934bf11a6ca8b","505e66ae45028a0596c853559221f0b72c1cee21@cfengine.com","Redmine #5557: Fix files promises having wrong status report.\n\nIn functions where we invoke sub promises, we need to start with the\nassumption that the promise will be skipped, instead of it being a\nkept promise. The reason is that the skipped status has the lowest\npriority, so if we end up skipping a promise, the status will still be\nkept if that's what we started with.","Kristian Amlie",false],["37e5102f550e7b827022796158fe2cd04eb741c6","b50cc3eaabafa5d6a674791b88fde911ae6278bd@cfengine.com","Merge pull request #1668 from kacfengine/files_compliance\n\nRedmine #5557: Fix files promises having wrong status report.","Volker Hilsheimer",false],["3f3c3a4471ef7a4e4cb98fe97e2f5d3bf2c6a267","b50cc3eaabafa5d6a674791b88fde911ae6278bd@cfengine.com","Correctly report repaired compliance for commands promises.\n\nFor compliance, commands promises are interpreted to have been KEPT\nfor 0 returns status, and NOTKEPT for non-zero. In order to maintain\ncompatibility with repaired classes set via body classes, a REPAIRED\nstate from VerifyCommandRetcode is overwritten with KEPT.\n\nIf the body classes also defines return codes for which the compliance\nshould be REPAIRED, then honour this and don't overwrite with KEPT.\n\nFixes: #5489","Volker Hilsheimer",false],["5ca689d9cd181131c6cbf77e6dc11dde2b701da7","b50cc3eaabafa5d6a674791b88fde911ae6278bd@cfengine.com","Merge pull request #1669 from vohi/commands_compliance\n\nCorrectly report repaired compliance for commands promises.","Volker Hilsheimer",false],["f3a217a893f6959bd62e8b8aa1d3e25489dd78cc","b50cc3eaabafa5d6a674791b88fde911ae6278bd@cfengine.com","Merge pull request #1231 from xrg/fix-getaddrinfo\n\nFix getaddrinfo() usage","Volker Hilsheimer",false],["48bbcdcae07dd82bf2fd9e170658ff6ed94da2c2","505e66ae45028a0596c853559221f0b72c1cee21@cfengine.com","Redmine #5621: Fix failing safe_open in create race.\n\nOn single core systems with certain kernel versions (CentOS), the\nordering of open calls is deterministic, and if two threads try to\nopen the same file with O_CREAT, one will fail because the other\nthread creates it at the same moment.\n\nThis is actually the very thing that safe_open was designed to protect\nagainst, but since it can happen even in daily operation when there is\nno foul play, we need to be a bit more tolerant. So if we find that we\nhave hit a race condition, instead of failing immediately, retry the\noperation to see if we hit the race condition again. Only after a few\nattempts do we give up.\n\nThis changes the expected result of one of the unit tests from\nsafe_open returning -1, to returning a file descriptor.","Kristian Amlie",false],["e8bdd736216b13fa9d8d45d830b1380ea4314a0b","505e66ae45028a0596c853559221f0b72c1cee21@cfengine.com","Add an additional test for opening a dangling symlink, not just creating","Kristian Amlie",false],["b50f4aea68caa739b93e9a133f7f90c19bdbb431","505e66ae45028a0596c853559221f0b72c1cee21@cfengine.com","Fix possible file open race condition on platforms without openat().\n\nWhen opening a relative path, the first path component opened is the\ncurrent directory. However, this is opened using normal open(). This\nis fine on most platforms, but on those where we emulate openat(), we\ndo not protect the open() call using the lock inside generic_at.c,\nwhich means we can potentially be in a different directory at the time\nof the call.\n\nThe fix is to switch to openat() with the AT_FDCWD flag, so that we\nrun the emulation code with the lock also for the first file open.","Kristian Amlie",false],["67f2747a60e597021401f563b30df446b1970471","505e66ae45028a0596c853559221f0b72c1cee21@cfengine.com","Remove AI_NUMERICSERV from getaddrinfo() call.\n\nOn Windows, although defined, it is not supported by Microsoft's\nnetwork stack.","Kristian Amlie",false],["02a2245eb131c5f048e5c7d9a7abbc6ce7697b6b","505e66ae45028a0596c853559221f0b72c1cee21@cfengine.com","Rename internal test hook to make it clear that it itself isn't a test","Kristian Amlie",false],["1e413fb77dd2114a7a9c9ef95de593c5ef3a35a6","505e66ae45028a0596c853559221f0b72c1cee21@cfengine.com","Merge pull request #1670 from kacfengine/safe_open_fixes\n\nRedmine #5621: Safe open fixes","Kristian Amlie",false],["d2033f2554c743f60bf64301cb35773578543fd3","f1497fa2045027e1383e4101420059be31f86c81@cfengine.com","Attempt expansion of naked nested scalars in ExpandListEntry\n\nClose #5480","Sigurd Teigen",false],["8bd3a6c688be21f2ed33cf37873b124c1592f916","8fd8c51e9550535d055e58483e99cdb1c44a5609@lifelogs.com","libcfnet/tls_client.c: mention 3.5.x protocol incompatibility","Ted Zlatanov",false],["35af26d560dcd3fcdfaa60e7787c97a0dd04ef6d","8fd8c51e9550535d055e58483e99cdb1c44a5609@lifelogs.com","Merge pull request #1671 from tzz/tls-mention-3.5.x\n\nlibcfnet/tls_client.c: mention 3.5.x protocol incompatibility","Ted Zlatanov",false],["427655840caef2bec20b6e64d8786dce22e9f71e","8fd8c51e9550535d055e58483e99cdb1c44a5609@lifelogs.com","Redmine#5486: disable db_test and db_concurrent_test temporarily","Ted Zlatanov",false]],"size":28,"ref":"refs/heads/master","head":"482f1d240c1f304733eeaf1e710498ae24eb67f0"}