GitHub PullRequestEvent at 2014-09-06 19:55:53
Repository: python-manhole
Actor: ionelmc
Payload: {"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/ionelmc/python-manhole/pulls/20","id":20852314,"html_url":"https://github.com/ionelmc/python-manhole/pull/20","diff_url":"https://github.com/ionelmc/python-manhole/pull/20.diff","patch_url":"https://github.com/ionelmc/python-manhole/pull/20.patch","issue_url":"https://api.github.com/repos/ionelmc/python-manhole/issues/20","number":20,"state":"closed","locked":false,"title":"Fix leftover /tmp/manhole-pid sockets in the tests","user":{"login":"nirs","id":395026,"avatar_url":"https://avatars.githubusercontent.com/u/395026?v=2","gravatar_id":"98a2e40a4dd07c9ddd599f6183885abd","url":"https://api.github.com/users/nirs","html_url":"https://github.com/nirs","followers_url":"https://api.github.com/users/nirs/followers","following_url":"https://api.github.com/users/nirs/following{/other_user}","gists_url":"https://api.github.com/users/nirs/gists{/gist_id}","starred_url":"https://api.github.com/users/nirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirs/subscriptions","organizations_url":"https://api.github.com/users/nirs/orgs","repos_url":"https://api.github.com/users/nirs/repos","events_url":"https://api.github.com/users/nirs/events{/privacy}","received_events_url":"https://api.github.com/users/nirs/received_events","type":"User","site_admin":false},"body":"manhole.install() registers an exit function removing the manhole\r\nsocket, but atexit function do not run when process is terminated by an\r\nunhandled signal.\r\n\r\nIn the fork tests, we avoid this issue by terminating child processes\r\nwith SIGINT, however the test child processes, created by the\r\nprocess_tests library, are terminate using SIGTERM in\r\n``TestProcess.__exit__``.\r\n\r\nAdding SIGTERM signal handler fixed this issue.\r\n\r\nWe probably need to document this as a workaround for issue #8","created_at":"2014-09-06T19:32:22Z","updated_at":"2014-09-06T19:55:53Z","closed_at":"2014-09-06T19:55:53Z","merged_at":"2014-09-06T19:55:53Z","merge_commit_sha":"18f0f64d250722ebee612a21d3bcef8d024c8d93","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ionelmc/python-manhole/pulls/20/commits","review_comments_url":"https://api.github.com/repos/ionelmc/python-manhole/pulls/20/comments","review_comment_url":"https://api.github.com/repos/ionelmc/python-manhole/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ionelmc/python-manhole/issues/20/comments","statuses_url":"https://api.github.com/repos/ionelmc/python-manhole/statuses/8ac2c1fe68f3830bbe4cd07d08e04009fd4b10eb","head":{"label":"nirs:tests-cleanup","ref":"tests-cleanup","sha":"8ac2c1fe68f3830bbe4cd07d08e04009fd4b10eb","user":{"login":"nirs","id":395026,"avatar_url":"https://avatars.githubusercontent.com/u/395026?v=2","gravatar_id":"98a2e40a4dd07c9ddd599f6183885abd","url":"https://api.github.com/users/nirs","html_url":"https://github.com/nirs","followers_url":"https://api.github.com/users/nirs/followers","following_url":"https://api.github.com/users/nirs/following{/other_user}","gists_url":"https://api.github.com/users/nirs/gists{/gist_id}","starred_url":"https://api.github.com/users/nirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirs/subscriptions","organizations_url":"https://api.github.com/users/nirs/orgs","repos_url":"https://api.github.com/users/nirs/repos","events_url":"https://api.github.com/users/nirs/events{/privacy}","received_events_url":"https://api.github.com/users/nirs/received_events","type":"User","site_admin":false},"repo":{"id":23468509,"name":"python-manhole","full_name":"nirs/python-manhole","owner":{"login":"nirs","id":395026,"avatar_url":"https://avatars.githubusercontent.com/u/395026?v=2","gravatar_id":"98a2e40a4dd07c9ddd599f6183885abd","url":"https://api.github.com/users/nirs","html_url":"https://github.com/nirs","followers_url":"https://api.github.com/users/nirs/followers","following_url":"https://api.github.com/users/nirs/following{/other_user}","gists_url":"https://api.github.com/users/nirs/gists{/gist_id}","starred_url":"https://api.github.com/users/nirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirs/subscriptions","organizations_url":"https://api.github.com/users/nirs/orgs","repos_url":"https://api.github.com/users/nirs/repos","events_url":"https://api.github.com/users/nirs/events{/privacy}","received_events_url":"https://api.github.com/users/nirs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nirs/python-manhole","description":"Debugging manhole for python applications","fork":true,"url":"https://api.github.com/repos/nirs/python-manhole","forks_url":"https://api.github.com/repos/nirs/python-manhole/forks","keys_url":"https://api.github.com/repos/nirs/python-manhole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nirs/python-manhole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nirs/python-manhole/teams","hooks_url":"https://api.github.com/repos/nirs/python-manhole/hooks","issue_events_url":"https://api.github.com/repos/nirs/python-manhole/issues/events{/number}","events_url":"https://api.github.com/repos/nirs/python-manhole/events","assignees_url":"https://api.github.com/repos/nirs/python-manhole/assignees{/user}","branches_url":"https://api.github.com/repos/nirs/python-manhole/branches{/branch}","tags_url":"https://api.github.com/repos/nirs/python-manhole/tags","blobs_url":"https://api.github.com/repos/nirs/python-manhole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nirs/python-manhole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nirs/python-manhole/git/refs{/sha}","trees_url":"https://api.github.com/repos/nirs/python-manhole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nirs/python-manhole/statuses/{sha}","languages_url":"https://api.github.com/repos/nirs/python-manhole/languages","stargazers_url":"https://api.github.com/repos/nirs/python-manhole/stargazers","contributors_url":"https://api.github.com/repos/nirs/python-manhole/contributors","subscribers_url":"https://api.github.com/repos/nirs/python-manhole/subscribers","subscription_url":"https://api.github.com/repos/nirs/python-manhole/subscription","commits_url":"https://api.github.com/repos/nirs/python-manhole/commits{/sha}","git_commits_url":"https://api.github.com/repos/nirs/python-manhole/git/commits{/sha}","comments_url":"https://api.github.com/repos/nirs/python-manhole/comments{/number}","issue_comment_url":"https://api.github.com/repos/nirs/python-manhole/issues/comments/{number}","contents_url":"https://api.github.com/repos/nirs/python-manhole/contents/{+path}","compare_url":"https://api.github.com/repos/nirs/python-manhole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nirs/python-manhole/merges","archive_url":"https://api.github.com/repos/nirs/python-manhole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nirs/python-manhole/downloads","issues_url":"https://api.github.com/repos/nirs/python-manhole/issues{/number}","pulls_url":"https://api.github.com/repos/nirs/python-manhole/pulls{/number}","milestones_url":"https://api.github.com/repos/nirs/python-manhole/milestones{/number}","notifications_url":"https://api.github.com/repos/nirs/python-manhole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nirs/python-manhole/labels{/name}","releases_url":"https://api.github.com/repos/nirs/python-manhole/releases{/id}","created_at":"2014-08-29T15:30:02Z","updated_at":"2014-08-30T01:32:10Z","pushed_at":"2014-09-06T19:31:34Z","git_url":"git://github.com/nirs/python-manhole.git","ssh_url":"git@github.com:nirs/python-manhole.git","clone_url":"https://github.com/nirs/python-manhole.git","svn_url":"https://github.com/nirs/python-manhole","homepage":"https://pypi.python.org/pypi/manhole","size":406,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ionelmc:master","ref":"master","sha":"e2ff0b168e8bd2b923dc135997d8b274cf076cad","user":{"login":"ionelmc","id":129501,"avatar_url":"https://avatars.githubusercontent.com/u/129501?v=2","gravatar_id":"4e190b0a42ef9aea59a7a1ebfc426d6e","url":"https://api.github.com/users/ionelmc","html_url":"https://github.com/ionelmc","followers_url":"https://api.github.com/users/ionelmc/followers","following_url":"https://api.github.com/users/ionelmc/following{/other_user}","gists_url":"https://api.github.com/users/ionelmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ionelmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionelmc/subscriptions","organizations_url":"https://api.github.com/users/ionelmc/orgs","repos_url":"https://api.github.com/users/ionelmc/repos","events_url":"https://api.github.com/users/ionelmc/events{/privacy}","received_events_url":"https://api.github.com/users/ionelmc/received_events","type":"User","site_admin":false},"repo":{"id":10980048,"name":"python-manhole","full_name":"ionelmc/python-manhole","owner":{"login":"ionelmc","id":129501,"avatar_url":"https://avatars.githubusercontent.com/u/129501?v=2","gravatar_id":"4e190b0a42ef9aea59a7a1ebfc426d6e","url":"https://api.github.com/users/ionelmc","html_url":"https://github.com/ionelmc","followers_url":"https://api.github.com/users/ionelmc/followers","following_url":"https://api.github.com/users/ionelmc/following{/other_user}","gists_url":"https://api.github.com/users/ionelmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ionelmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionelmc/subscriptions","organizations_url":"https://api.github.com/users/ionelmc/orgs","repos_url":"https://api.github.com/users/ionelmc/repos","events_url":"https://api.github.com/users/ionelmc/events{/privacy}","received_events_url":"https://api.github.com/users/ionelmc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ionelmc/python-manhole","description":"Debugging manhole for python applications","fork":false,"url":"https://api.github.com/repos/ionelmc/python-manhole","forks_url":"https://api.github.com/repos/ionelmc/python-manhole/forks","keys_url":"https://api.github.com/repos/ionelmc/python-manhole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ionelmc/python-manhole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ionelmc/python-manhole/teams","hooks_url":"https://api.github.com/repos/ionelmc/python-manhole/hooks","issue_events_url":"https://api.github.com/repos/ionelmc/python-manhole/issues/events{/number}","events_url":"https://api.github.com/repos/ionelmc/python-manhole/events","assignees_url":"https://api.github.com/repos/ionelmc/python-manhole/assignees{/user}","branches_url":"https://api.github.com/repos/ionelmc/python-manhole/branches{/branch}","tags_url":"https://api.github.com/repos/ionelmc/python-manhole/tags","blobs_url":"https://api.github.com/repos/ionelmc/python-manhole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ionelmc/python-manhole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ionelmc/python-manhole/git/refs{/sha}","trees_url":"https://api.github.com/repos/ionelmc/python-manhole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ionelmc/python-manhole/statuses/{sha}","languages_url":"https://api.github.com/repos/ionelmc/python-manhole/languages","stargazers_url":"https://api.github.com/repos/ionelmc/python-manhole/stargazers","contributors_url":"https://api.github.com/repos/ionelmc/python-manhole/contributors","subscribers_url":"https://api.github.com/repos/ionelmc/python-manhole/subscribers","subscription_url":"https://api.github.com/repos/ionelmc/python-manhole/subscription","commits_url":"https://api.github.com/repos/ionelmc/python-manhole/commits{/sha}","git_commits_url":"https://api.github.com/repos/ionelmc/python-manhole/git/commits{/sha}","comments_url":"https://api.github.com/repos/ionelmc/python-manhole/comments{/number}","issue_comment_url":"https://api.github.com/repos/ionelmc/python-manhole/issues/comments/{number}","contents_url":"https://api.github.com/repos/ionelmc/python-manhole/contents/{+path}","compare_url":"https://api.github.com/repos/ionelmc/python-manhole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ionelmc/python-manhole/merges","archive_url":"https://api.github.com/repos/ionelmc/python-manhole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ionelmc/python-manhole/downloads","issues_url":"https://api.github.com/repos/ionelmc/python-manhole/issues{/number}","pulls_url":"https://api.github.com/repos/ionelmc/python-manhole/pulls{/number}","milestones_url":"https://api.github.com/repos/ionelmc/python-manhole/milestones{/number}","notifications_url":"https://api.github.com/repos/ionelmc/python-manhole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ionelmc/python-manhole/labels{/name}","releases_url":"https://api.github.com/repos/ionelmc/python-manhole/releases{/id}","created_at":"2013-06-26T21:49:34Z","updated_at":"2014-09-06T16:19:52Z","pushed_at":"2014-09-06T19:55:53Z","git_url":"git://github.com/ionelmc/python-manhole.git","ssh_url":"git@github.com:ionelmc/python-manhole.git","clone_url":"https://github.com/ionelmc/python-manhole.git","svn_url":"https://github.com/ionelmc/python-manhole","homepage":"https://pypi.python.org/pypi/manhole","size":1346,"stargazers_count":86,"watchers_count":86,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ionelmc/python-manhole/pulls/20"},"html":{"href":"https://github.com/ionelmc/python-manhole/pull/20"},"issue":{"href":"https://api.github.com/repos/ionelmc/python-manhole/issues/20"},"comments":{"href":"https://api.github.com/repos/ionelmc/python-manhole/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/ionelmc/python-manhole/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/ionelmc/python-manhole/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ionelmc/python-manhole/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/ionelmc/python-manhole/statuses/8ac2c1fe68f3830bbe4cd07d08e04009fd4b10eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ionelmc","id":129501,"avatar_url":"https://avatars.githubusercontent.com/u/129501?v=2","gravatar_id":"4e190b0a42ef9aea59a7a1ebfc426d6e","url":"https://api.github.com/users/ionelmc","html_url":"https://github.com/ionelmc","followers_url":"https://api.github.com/users/ionelmc/followers","following_url":"https://api.github.com/users/ionelmc/following{/other_user}","gists_url":"https://api.github.com/users/ionelmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ionelmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionelmc/subscriptions","organizations_url":"https://api.github.com/users/ionelmc/orgs","repos_url":"https://api.github.com/users/ionelmc/repos","events_url":"https://api.github.com/users/ionelmc/events{/privacy}","received_events_url":"https://api.github.com/users/ionelmc/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":0,"changed_files":1}}