GitHub PullRequestReviewCommentEvent at 2014-07-14 11:47:38
Repository: juju
Actor: TheMue
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/14874105","id":14874105,"diff_hunk":"@@ -89,7 +92,8 @@ type HookContext struct {\n \n func NewHookContext(unit *uniter.Unit, id, uuid, envName string,","path":"worker/uniter/context.go","position":12,"original_position":12,"commit_id":"3019a4b3692e08198be53d017715543db871a91d","original_commit_id":"3019a4b3692e08198be53d017715543db871a91d","user":{"login":"TheMue","id":1633981,"avatar_url":"https://avatars.githubusercontent.com/u/1633981?","gravatar_id":"b11645e09683360c0849df16c77e9980","url":"https://api.github.com/users/TheMue","html_url":"https://github.com/TheMue","followers_url":"https://api.github.com/users/TheMue/followers","following_url":"https://api.github.com/users/TheMue/following{/other_user}","gists_url":"https://api.github.com/users/TheMue/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMue/subscriptions","organizations_url":"https://api.github.com/users/TheMue/orgs","repos_url":"https://api.github.com/users/TheMue/repos","events_url":"https://api.github.com/users/TheMue/events{/privacy}","received_events_url":"https://api.github.com/users/TheMue/received_events","type":"User","site_admin":false},"body":"Wow, what a large number of args. Maybe better use the notation\r\n\r\n```\r\nfunc NewHookContext(\r\n    unit *uniter.Unit,\r\n    id string,\r\n    ...\r\n) (*HookContext, error) { ...\r\n```\r\n\r\nRoger uses it in case of larger numbers of arguments and it helps to keep the overview.","created_at":"2014-07-14T11:47:38Z","updated_at":"2014-07-14T11:47:38Z","html_url":"https://github.com/juju/juju/pull/301#discussion_r14874105","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/301","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/14874105"},"html":{"href":"https://github.com/juju/juju/pull/301#discussion_r14874105"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/301","id":18299077,"html_url":"https://github.com/juju/juju/pull/301","diff_url":"https://github.com/juju/juju/pull/301.diff","patch_url":"https://github.com/juju/juju/pull/301.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/301","number":301,"state":"open","title":"Actions on worker","user":{"login":"binary132","id":936243,"avatar_url":"https://avatars.githubusercontent.com/u/936243?","gravatar_id":"3013ba3c262656cd06c6405e23d026ff","url":"https://api.github.com/users/binary132","html_url":"https://github.com/binary132","followers_url":"https://api.github.com/users/binary132/followers","following_url":"https://api.github.com/users/binary132/following{/other_user}","gists_url":"https://api.github.com/users/binary132/gists{/gist_id}","starred_url":"https://api.github.com/users/binary132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary132/subscriptions","organizations_url":"https://api.github.com/users/binary132/orgs","repos_url":"https://api.github.com/users/binary132/repos","events_url":"https://api.github.com/users/binary132/events{/privacy}","received_events_url":"https://api.github.com/users/binary132/received_events","type":"User","site_admin":false},"body":"This change adds the ability for Actions to be run on a charm using the\r\nsame logic used for Hooks.  The Action is run in the \"actions\" location on the\r\ncharm.\r\n\r\nA second PR will address Action param Validate.","created_at":"2014-07-11T20:10:41Z","updated_at":"2014-07-14T11:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e43dc07108ee932b94f8685a062fc07577de599c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/301/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/301/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/301/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/3019a4b3692e08198be53d017715543db871a91d","head":{"label":"binary132:actions-runhook-basic","ref":"actions-runhook-basic","sha":"3019a4b3692e08198be53d017715543db871a91d","user":{"login":"binary132","id":936243,"avatar_url":"https://avatars.githubusercontent.com/u/936243?","gravatar_id":"3013ba3c262656cd06c6405e23d026ff","url":"https://api.github.com/users/binary132","html_url":"https://github.com/binary132","followers_url":"https://api.github.com/users/binary132/followers","following_url":"https://api.github.com/users/binary132/following{/other_user}","gists_url":"https://api.github.com/users/binary132/gists{/gist_id}","starred_url":"https://api.github.com/users/binary132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary132/subscriptions","organizations_url":"https://api.github.com/users/binary132/orgs","repos_url":"https://api.github.com/users/binary132/repos","events_url":"https://api.github.com/users/binary132/events{/privacy}","received_events_url":"https://api.github.com/users/binary132/received_events","type":"User","site_admin":false},"repo":{"id":20457767,"name":"juju","full_name":"binary132/juju","owner":{"login":"binary132","id":936243,"avatar_url":"https://avatars.githubusercontent.com/u/936243?","gravatar_id":"3013ba3c262656cd06c6405e23d026ff","url":"https://api.github.com/users/binary132","html_url":"https://github.com/binary132","followers_url":"https://api.github.com/users/binary132/followers","following_url":"https://api.github.com/users/binary132/following{/other_user}","gists_url":"https://api.github.com/users/binary132/gists{/gist_id}","starred_url":"https://api.github.com/users/binary132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary132/subscriptions","organizations_url":"https://api.github.com/users/binary132/orgs","repos_url":"https://api.github.com/users/binary132/repos","events_url":"https://api.github.com/users/binary132/events{/privacy}","received_events_url":"https://api.github.com/users/binary132/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binary132/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/binary132/juju","forks_url":"https://api.github.com/repos/binary132/juju/forks","keys_url":"https://api.github.com/repos/binary132/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binary132/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binary132/juju/teams","hooks_url":"https://api.github.com/repos/binary132/juju/hooks","issue_events_url":"https://api.github.com/repos/binary132/juju/issues/events{/number}","events_url":"https://api.github.com/repos/binary132/juju/events","assignees_url":"https://api.github.com/repos/binary132/juju/assignees{/user}","branches_url":"https://api.github.com/repos/binary132/juju/branches{/branch}","tags_url":"https://api.github.com/repos/binary132/juju/tags","blobs_url":"https://api.github.com/repos/binary132/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binary132/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binary132/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/binary132/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binary132/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/binary132/juju/languages","stargazers_url":"https://api.github.com/repos/binary132/juju/stargazers","contributors_url":"https://api.github.com/repos/binary132/juju/contributors","subscribers_url":"https://api.github.com/repos/binary132/juju/subscribers","subscription_url":"https://api.github.com/repos/binary132/juju/subscription","commits_url":"https://api.github.com/repos/binary132/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/binary132/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/binary132/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/binary132/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/binary132/juju/contents/{+path}","compare_url":"https://api.github.com/repos/binary132/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binary132/juju/merges","archive_url":"https://api.github.com/repos/binary132/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binary132/juju/downloads","issues_url":"https://api.github.com/repos/binary132/juju/issues{/number}","pulls_url":"https://api.github.com/repos/binary132/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/binary132/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/binary132/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binary132/juju/labels{/name}","releases_url":"https://api.github.com/repos/binary132/juju/releases{/id}","created_at":"2014-06-03T20:10:23Z","updated_at":"2014-06-25T16:57:32Z","pushed_at":"2014-07-12T02:57:24Z","git_url":"git://github.com/binary132/juju.git","ssh_url":"git@github.com:binary132/juju.git","clone_url":"https://github.com/binary132/juju.git","svn_url":"https://github.com/binary132/juju","homepage":null,"size":26610,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"92aee75b124aefe5df758158c65d270b3aca3c4d","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-07-14T03:41:27Z","pushed_at":"2014-07-14T04:44:59Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":32411,"stargazers_count":177,"watchers_count":177,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":41,"mirror_url":null,"open_issues_count":42,"forks":41,"open_issues":42,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/301"},"html":{"href":"https://github.com/juju/juju/pull/301"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/301"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/3019a4b3692e08198be53d017715543db871a91d"}}}}