GitHub PullRequestReviewCommentEvent at 2014-09-29 23:25:25
Repository: zanata-spa
Actor: davidmason
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zanata/zanata-spa/pulls/comments/18190785","id":18190785,"diff_hunk":"@@ -5,19 +5,33 @@\n    * TransUnitCtrl.js\n    * @ngInject\n    */\n-  function TransUnitCtrl($scope, $element, $stateParams,\n-                         TransUnitService, EventService) {\n+  function TransUnitCtrl($scope, $element, $stateParams, $filter, _,\n+      TransUnitService, EventService, LocaleService) {\n+\n     var transUnitCtrl = this;\n+\n     transUnitCtrl.selected = false;\n+    transUnitCtrl.saveStatus = TransUnitService.getSaveStatus($scope.phrase);\n+    transUnitCtrl.saveOptions =\n+      TransUnitService.getSaveOptions(transUnitCtrl.saveStatus);\n+\n+\n+    transUnitCtrl.isTranslationModified = function(phrase) {\n+      return TransUnitService.isTranslationModified(phrase);\n+    };","path":"app/components/transUnit/TransUnitCtrl.js","position":19,"original_position":19,"commit_id":"d1bca0c14f94c8c2699c697efdecec7d8e457f70","original_commit_id":"d1bca0c14f94c8c2699c697efdecec7d8e457f70","user":{"login":"davidmason","id":482026,"avatar_url":"https://avatars.githubusercontent.com/u/482026?v=2","gravatar_id":"","url":"https://api.github.com/users/davidmason","html_url":"https://github.com/davidmason","followers_url":"https://api.github.com/users/davidmason/followers","following_url":"https://api.github.com/users/davidmason/following{/other_user}","gists_url":"https://api.github.com/users/davidmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmason/subscriptions","organizations_url":"https://api.github.com/users/davidmason/orgs","repos_url":"https://api.github.com/users/davidmason/repos","events_url":"https://api.github.com/users/davidmason/events{/privacy}","received_events_url":"https://api.github.com/users/davidmason/received_events","type":"User","site_admin":false},"body":"Could this be simplified to `transUnitCtrl.isTranslationModified = TransUnitService.isTranslationModified;`? It might not work if it is counting on the `this` binding in the function.","created_at":"2014-09-29T23:25:25Z","updated_at":"2014-09-29T23:25:25Z","html_url":"https://github.com/zanata/zanata-spa/pull/67#discussion_r18190785","pull_request_url":"https://api.github.com/repos/zanata/zanata-spa/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/zanata/zanata-spa/pulls/comments/18190785"},"html":{"href":"https://github.com/zanata/zanata-spa/pull/67#discussion_r18190785"},"pull_request":{"href":"https://api.github.com/repos/zanata/zanata-spa/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-spa/pulls/67","id":21914442,"html_url":"https://github.com/zanata/zanata-spa/pull/67","diff_url":"https://github.com/zanata/zanata-spa/pull/67.diff","patch_url":"https://github.com/zanata/zanata-spa/pull/67.patch","issue_url":"https://api.github.com/repos/zanata/zanata-spa/issues/67","number":67,"state":"open","locked":false,"title":"Basic save state functionality, no loading.","user":{"login":"lukebrooker","id":1305265,"avatar_url":"https://avatars.githubusercontent.com/u/1305265?v=2","gravatar_id":"","url":"https://api.github.com/users/lukebrooker","html_url":"https://github.com/lukebrooker","followers_url":"https://api.github.com/users/lukebrooker/followers","following_url":"https://api.github.com/users/lukebrooker/following{/other_user}","gists_url":"https://api.github.com/users/lukebrooker/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebrooker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebrooker/subscriptions","organizations_url":"https://api.github.com/users/lukebrooker/orgs","repos_url":"https://api.github.com/users/lukebrooker/repos","events_url":"https://api.github.com/users/lukebrooker/events{/privacy}","received_events_url":"https://api.github.com/users/lukebrooker/received_events","type":"User","site_admin":false},"body":null,"created_at":"2014-09-29T05:42:25Z","updated_at":"2014-09-29T23:25:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"059a5d15ebeb6765ade5630a612d796c6b80933e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zanata/zanata-spa/pulls/67/commits","review_comments_url":"https://api.github.com/repos/zanata/zanata-spa/pulls/67/comments","review_comment_url":"https://api.github.com/repos/zanata/zanata-spa/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zanata/zanata-spa/issues/67/comments","statuses_url":"https://api.github.com/repos/zanata/zanata-spa/statuses/d1bca0c14f94c8c2699c697efdecec7d8e457f70","head":{"label":"zanata:translation-save-states","ref":"translation-save-states","sha":"d1bca0c14f94c8c2699c697efdecec7d8e457f70","user":{"login":"zanata","id":637455,"avatar_url":"https://avatars.githubusercontent.com/u/637455?v=2","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"repo":{"id":22827941,"name":"zanata-spa","full_name":"zanata/zanata-spa","owner":{"login":"zanata","id":637455,"avatar_url":"https://avatars.githubusercontent.com/u/637455?v=2","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zanata/zanata-spa","description":"Community Powered Translation","fork":false,"url":"https://api.github.com/repos/zanata/zanata-spa","forks_url":"https://api.github.com/repos/zanata/zanata-spa/forks","keys_url":"https://api.github.com/repos/zanata/zanata-spa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanata/zanata-spa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanata/zanata-spa/teams","hooks_url":"https://api.github.com/repos/zanata/zanata-spa/hooks","issue_events_url":"https://api.github.com/repos/zanata/zanata-spa/issues/events{/number}","events_url":"https://api.github.com/repos/zanata/zanata-spa/events","assignees_url":"https://api.github.com/repos/zanata/zanata-spa/assignees{/user}","branches_url":"https://api.github.com/repos/zanata/zanata-spa/branches{/branch}","tags_url":"https://api.github.com/repos/zanata/zanata-spa/tags","blobs_url":"https://api.github.com/repos/zanata/zanata-spa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanata/zanata-spa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanata/zanata-spa/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanata/zanata-spa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanata/zanata-spa/statuses/{sha}","languages_url":"https://api.github.com/repos/zanata/zanata-spa/languages","stargazers_url":"https://api.github.com/repos/zanata/zanata-spa/stargazers","contributors_url":"https://api.github.com/repos/zanata/zanata-spa/contributors","subscribers_url":"https://api.github.com/repos/zanata/zanata-spa/subscribers","subscription_url":"https://api.github.com/repos/zanata/zanata-spa/subscription","commits_url":"https://api.github.com/repos/zanata/zanata-spa/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanata/zanata-spa/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanata/zanata-spa/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanata/zanata-spa/issues/comments/{number}","contents_url":"https://api.github.com/repos/zanata/zanata-spa/contents/{+path}","compare_url":"https://api.github.com/repos/zanata/zanata-spa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanata/zanata-spa/merges","archive_url":"https://api.github.com/repos/zanata/zanata-spa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanata/zanata-spa/downloads","issues_url":"https://api.github.com/repos/zanata/zanata-spa/issues{/number}","pulls_url":"https://api.github.com/repos/zanata/zanata-spa/pulls{/number}","milestones_url":"https://api.github.com/repos/zanata/zanata-spa/milestones{/number}","notifications_url":"https://api.github.com/repos/zanata/zanata-spa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanata/zanata-spa/labels{/name}","releases_url":"https://api.github.com/repos/zanata/zanata-spa/releases{/id}","created_at":"2014-08-11T05:28:44Z","updated_at":"2014-09-22T04:26:44Z","pushed_at":"2014-09-29T05:55:09Z","git_url":"git://github.com/zanata/zanata-spa.git","ssh_url":"git@github.com:zanata/zanata-spa.git","clone_url":"https://github.com/zanata/zanata-spa.git","svn_url":"https://github.com/zanata/zanata-spa","homepage":"http://zanata.org","size":2168,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":0,"default_branch":"master"}},"base":{"label":"zanata:master","ref":"master","sha":"97cc32f056f1456c22b526be96b4075748b718f1","user":{"login":"zanata","id":637455,"avatar_url":"https://avatars.githubusercontent.com/u/637455?v=2","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"repo":{"id":22827941,"name":"zanata-spa","full_name":"zanata/zanata-spa","owner":{"login":"zanata","id":637455,"avatar_url":"https://avatars.githubusercontent.com/u/637455?v=2","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zanata/zanata-spa","description":"Community Powered Translation","fork":false,"url":"https://api.github.com/repos/zanata/zanata-spa","forks_url":"https://api.github.com/repos/zanata/zanata-spa/forks","keys_url":"https://api.github.com/repos/zanata/zanata-spa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanata/zanata-spa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanata/zanata-spa/teams","hooks_url":"https://api.github.com/repos/zanata/zanata-spa/hooks","issue_events_url":"https://api.github.com/repos/zanata/zanata-spa/issues/events{/number}","events_url":"https://api.github.com/repos/zanata/zanata-spa/events","assignees_url":"https://api.github.com/repos/zanata/zanata-spa/assignees{/user}","branches_url":"https://api.github.com/repos/zanata/zanata-spa/branches{/branch}","tags_url":"https://api.github.com/repos/zanata/zanata-spa/tags","blobs_url":"https://api.github.com/repos/zanata/zanata-spa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanata/zanata-spa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanata/zanata-spa/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanata/zanata-spa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanata/zanata-spa/statuses/{sha}","languages_url":"https://api.github.com/repos/zanata/zanata-spa/languages","stargazers_url":"https://api.github.com/repos/zanata/zanata-spa/stargazers","contributors_url":"https://api.github.com/repos/zanata/zanata-spa/contributors","subscribers_url":"https://api.github.com/repos/zanata/zanata-spa/subscribers","subscription_url":"https://api.github.com/repos/zanata/zanata-spa/subscription","commits_url":"https://api.github.com/repos/zanata/zanata-spa/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanata/zanata-spa/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanata/zanata-spa/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanata/zanata-spa/issues/comments/{number}","contents_url":"https://api.github.com/repos/zanata/zanata-spa/contents/{+path}","compare_url":"https://api.github.com/repos/zanata/zanata-spa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanata/zanata-spa/merges","archive_url":"https://api.github.com/repos/zanata/zanata-spa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanata/zanata-spa/downloads","issues_url":"https://api.github.com/repos/zanata/zanata-spa/issues{/number}","pulls_url":"https://api.github.com/repos/zanata/zanata-spa/pulls{/number}","milestones_url":"https://api.github.com/repos/zanata/zanata-spa/milestones{/number}","notifications_url":"https://api.github.com/repos/zanata/zanata-spa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanata/zanata-spa/labels{/name}","releases_url":"https://api.github.com/repos/zanata/zanata-spa/releases{/id}","created_at":"2014-08-11T05:28:44Z","updated_at":"2014-09-22T04:26:44Z","pushed_at":"2014-09-29T05:55:09Z","git_url":"git://github.com/zanata/zanata-spa.git","ssh_url":"git@github.com:zanata/zanata-spa.git","clone_url":"https://github.com/zanata/zanata-spa.git","svn_url":"https://github.com/zanata/zanata-spa","homepage":"http://zanata.org","size":2168,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zanata/zanata-spa/pulls/67"},"html":{"href":"https://github.com/zanata/zanata-spa/pull/67"},"issue":{"href":"https://api.github.com/repos/zanata/zanata-spa/issues/67"},"comments":{"href":"https://api.github.com/repos/zanata/zanata-spa/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/zanata/zanata-spa/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/zanata/zanata-spa/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zanata/zanata-spa/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/zanata/zanata-spa/statuses/d1bca0c14f94c8c2699c697efdecec7d8e457f70"}}}}