GitHub PullRequestReviewCommentEvent at 2014-08-20 14:31:07
Repository: qt-client
Actor: garyhgohoos
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xtuple/qt-client/pulls/comments/16479284","id":16479284,"diff_hunk":"@@ -480,6 +483,26 @@ void reconcileBankaccount::populate()\n   qApp->restoreOverrideCursor();\n }\n \n+void reconcileBankaccount::sImport()\n+{\n+  XSqlQuery reconcileImport;\n+\n+  // set the metric\n+  reconcileImport.prepare(\"SELECT setMetric('ImportBankRecId', :bankrecid::TEXT) AS result; \");","path":"guiclient/reconcileBankaccount.cpp","position":43,"original_position":43,"commit_id":"1b1542b4cd8f0be8199bddf904eac87bc9b5c6fa","original_commit_id":"1b1542b4cd8f0be8199bddf904eac87bc9b5c6fa","user":{"login":"garyhgohoos","id":706654,"avatar_url":"https://avatars.githubusercontent.com/u/706654?v=2","gravatar_id":"ef839613092a06f702049a2e4cc2e27d","url":"https://api.github.com/users/garyhgohoos","html_url":"https://github.com/garyhgohoos","followers_url":"https://api.github.com/users/garyhgohoos/followers","following_url":"https://api.github.com/users/garyhgohoos/following{/other_user}","gists_url":"https://api.github.com/users/garyhgohoos/gists{/gist_id}","starred_url":"https://api.github.com/users/garyhgohoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyhgohoos/subscriptions","organizations_url":"https://api.github.com/users/garyhgohoos/orgs","repos_url":"https://api.github.com/users/garyhgohoos/repos","events_url":"https://api.github.com/users/garyhgohoos/events{/privacy}","received_events_url":"https://api.github.com/users/garyhgohoos/received_events","type":"User","site_admin":false},"body":"the method for associating a set of import records with a bankaccnt/bankrec is an open issue posed to Alfredo.  the sample file provided by Alfredo did not appear to have an identifier.\r\n\r\nthe ImportBankRecId metric is used to communicate to the importBankRecCleared function (which is defined as the postSQL process in the CSV atlas)","created_at":"2014-08-20T14:31:07Z","updated_at":"2014-08-20T14:31:07Z","html_url":"https://github.com/xtuple/qt-client/pull/441#discussion_r16479284","pull_request_url":"https://api.github.com/repos/xtuple/qt-client/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/comments/16479284"},"html":{"href":"https://github.com/xtuple/qt-client/pull/441#discussion_r16479284"},"pull_request":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/xtuple/qt-client/pulls/441","id":19685757,"html_url":"https://github.com/xtuple/qt-client/pull/441","diff_url":"https://github.com/xtuple/qt-client/pull/441.diff","patch_url":"https://github.com/xtuple/qt-client/pull/441.patch","issue_url":"https://api.github.com/repos/xtuple/qt-client/issues/441","number":441,"state":"open","locked":false,"title":"Issue #23255:initial commit for bank reconciliation import","user":{"login":"garyhgohoos","id":706654,"avatar_url":"https://avatars.githubusercontent.com/u/706654?v=2","gravatar_id":"ef839613092a06f702049a2e4cc2e27d","url":"https://api.github.com/users/garyhgohoos","html_url":"https://github.com/garyhgohoos","followers_url":"https://api.github.com/users/garyhgohoos/followers","following_url":"https://api.github.com/users/garyhgohoos/following{/other_user}","gists_url":"https://api.github.com/users/garyhgohoos/gists{/gist_id}","starred_url":"https://api.github.com/users/garyhgohoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyhgohoos/subscriptions","organizations_url":"https://api.github.com/users/garyhgohoos/orgs","repos_url":"https://api.github.com/users/garyhgohoos/repos","events_url":"https://api.github.com/users/garyhgohoos/events{/privacy}","received_events_url":"https://api.github.com/users/garyhgohoos/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-12T20:00:16Z","updated_at":"2014-08-20T14:31:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a9eba048a4cdd3b5214be0adc7576ef47424b4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xtuple/qt-client/pulls/441/commits","review_comments_url":"https://api.github.com/repos/xtuple/qt-client/pulls/441/comments","review_comment_url":"https://api.github.com/repos/xtuple/qt-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xtuple/qt-client/issues/441/comments","statuses_url":"https://api.github.com/repos/xtuple/qt-client/statuses/1b1542b4cd8f0be8199bddf904eac87bc9b5c6fa","head":{"label":"garyhgohoos:23255","ref":"23255","sha":"1b1542b4cd8f0be8199bddf904eac87bc9b5c6fa","user":{"login":"garyhgohoos","id":706654,"avatar_url":"https://avatars.githubusercontent.com/u/706654?v=2","gravatar_id":"ef839613092a06f702049a2e4cc2e27d","url":"https://api.github.com/users/garyhgohoos","html_url":"https://github.com/garyhgohoos","followers_url":"https://api.github.com/users/garyhgohoos/followers","following_url":"https://api.github.com/users/garyhgohoos/following{/other_user}","gists_url":"https://api.github.com/users/garyhgohoos/gists{/gist_id}","starred_url":"https://api.github.com/users/garyhgohoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyhgohoos/subscriptions","organizations_url":"https://api.github.com/users/garyhgohoos/orgs","repos_url":"https://api.github.com/users/garyhgohoos/repos","events_url":"https://api.github.com/users/garyhgohoos/events{/privacy}","received_events_url":"https://api.github.com/users/garyhgohoos/received_events","type":"User","site_admin":false},"repo":{"id":10606770,"name":"qt-client","full_name":"garyhgohoos/qt-client","owner":{"login":"garyhgohoos","id":706654,"avatar_url":"https://avatars.githubusercontent.com/u/706654?v=2","gravatar_id":"ef839613092a06f702049a2e4cc2e27d","url":"https://api.github.com/users/garyhgohoos","html_url":"https://github.com/garyhgohoos","followers_url":"https://api.github.com/users/garyhgohoos/followers","following_url":"https://api.github.com/users/garyhgohoos/following{/other_user}","gists_url":"https://api.github.com/users/garyhgohoos/gists{/gist_id}","starred_url":"https://api.github.com/users/garyhgohoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyhgohoos/subscriptions","organizations_url":"https://api.github.com/users/garyhgohoos/orgs","repos_url":"https://api.github.com/users/garyhgohoos/repos","events_url":"https://api.github.com/users/garyhgohoos/events{/privacy}","received_events_url":"https://api.github.com/users/garyhgohoos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garyhgohoos/qt-client","description":"Desktop Client and Database","fork":true,"url":"https://api.github.com/repos/garyhgohoos/qt-client","forks_url":"https://api.github.com/repos/garyhgohoos/qt-client/forks","keys_url":"https://api.github.com/repos/garyhgohoos/qt-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garyhgohoos/qt-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garyhgohoos/qt-client/teams","hooks_url":"https://api.github.com/repos/garyhgohoos/qt-client/hooks","issue_events_url":"https://api.github.com/repos/garyhgohoos/qt-client/issues/events{/number}","events_url":"https://api.github.com/repos/garyhgohoos/qt-client/events","assignees_url":"https://api.github.com/repos/garyhgohoos/qt-client/assignees{/user}","branches_url":"https://api.github.com/repos/garyhgohoos/qt-client/branches{/branch}","tags_url":"https://api.github.com/repos/garyhgohoos/qt-client/tags","blobs_url":"https://api.github.com/repos/garyhgohoos/qt-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garyhgohoos/qt-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garyhgohoos/qt-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/garyhgohoos/qt-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garyhgohoos/qt-client/statuses/{sha}","languages_url":"https://api.github.com/repos/garyhgohoos/qt-client/languages","stargazers_url":"https://api.github.com/repos/garyhgohoos/qt-client/stargazers","contributors_url":"https://api.github.com/repos/garyhgohoos/qt-client/contributors","subscribers_url":"https://api.github.com/repos/garyhgohoos/qt-client/subscribers","subscription_url":"https://api.github.com/repos/garyhgohoos/qt-client/subscription","commits_url":"https://api.github.com/repos/garyhgohoos/qt-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/garyhgohoos/qt-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/garyhgohoos/qt-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/garyhgohoos/qt-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/garyhgohoos/qt-client/contents/{+path}","compare_url":"https://api.github.com/repos/garyhgohoos/qt-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garyhgohoos/qt-client/merges","archive_url":"https://api.github.com/repos/garyhgohoos/qt-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garyhgohoos/qt-client/downloads","issues_url":"https://api.github.com/repos/garyhgohoos/qt-client/issues{/number}","pulls_url":"https://api.github.com/repos/garyhgohoos/qt-client/pulls{/number}","milestones_url":"https://api.github.com/repos/garyhgohoos/qt-client/milestones{/number}","notifications_url":"https://api.github.com/repos/garyhgohoos/qt-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garyhgohoos/qt-client/labels{/name}","releases_url":"https://api.github.com/repos/garyhgohoos/qt-client/releases{/id}","created_at":"2013-06-10T18:37:26Z","updated_at":"2014-06-25T15:27:36Z","pushed_at":"2014-08-18T20:45:17Z","git_url":"git://github.com/garyhgohoos/qt-client.git","ssh_url":"git@github.com:garyhgohoos/qt-client.git","clone_url":"https://github.com/garyhgohoos/qt-client.git","svn_url":"https://github.com/garyhgohoos/qt-client","homepage":null,"size":60382,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xtuple:4_7_x","ref":"4_7_x","sha":"0f21c2fdcce2d8728695427f56b0122379c883ad","user":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?v=2","gravatar_id":"50375c477e5e16ff431a203c64fc9c38","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"repo":{"id":10383821,"name":"qt-client","full_name":"xtuple/qt-client","owner":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?v=2","gravatar_id":"50375c477e5e16ff431a203c64fc9c38","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xtuple/qt-client","description":"Desktop Client","fork":false,"url":"https://api.github.com/repos/xtuple/qt-client","forks_url":"https://api.github.com/repos/xtuple/qt-client/forks","keys_url":"https://api.github.com/repos/xtuple/qt-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xtuple/qt-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xtuple/qt-client/teams","hooks_url":"https://api.github.com/repos/xtuple/qt-client/hooks","issue_events_url":"https://api.github.com/repos/xtuple/qt-client/issues/events{/number}","events_url":"https://api.github.com/repos/xtuple/qt-client/events","assignees_url":"https://api.github.com/repos/xtuple/qt-client/assignees{/user}","branches_url":"https://api.github.com/repos/xtuple/qt-client/branches{/branch}","tags_url":"https://api.github.com/repos/xtuple/qt-client/tags","blobs_url":"https://api.github.com/repos/xtuple/qt-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xtuple/qt-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xtuple/qt-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/xtuple/qt-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xtuple/qt-client/statuses/{sha}","languages_url":"https://api.github.com/repos/xtuple/qt-client/languages","stargazers_url":"https://api.github.com/repos/xtuple/qt-client/stargazers","contributors_url":"https://api.github.com/repos/xtuple/qt-client/contributors","subscribers_url":"https://api.github.com/repos/xtuple/qt-client/subscribers","subscription_url":"https://api.github.com/repos/xtuple/qt-client/subscription","commits_url":"https://api.github.com/repos/xtuple/qt-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/xtuple/qt-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/xtuple/qt-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/xtuple/qt-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/xtuple/qt-client/contents/{+path}","compare_url":"https://api.github.com/repos/xtuple/qt-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xtuple/qt-client/merges","archive_url":"https://api.github.com/repos/xtuple/qt-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xtuple/qt-client/downloads","issues_url":"https://api.github.com/repos/xtuple/qt-client/issues{/number}","pulls_url":"https://api.github.com/repos/xtuple/qt-client/pulls{/number}","milestones_url":"https://api.github.com/repos/xtuple/qt-client/milestones{/number}","notifications_url":"https://api.github.com/repos/xtuple/qt-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xtuple/qt-client/labels{/name}","releases_url":"https://api.github.com/repos/xtuple/qt-client/releases{/id}","created_at":"2013-05-30T13:54:04Z","updated_at":"2014-07-02T17:28:32Z","pushed_at":"2014-08-20T12:09:37Z","git_url":"git://github.com/xtuple/qt-client.git","ssh_url":"git@github.com:xtuple/qt-client.git","clone_url":"https://github.com/xtuple/qt-client.git","svn_url":"https://github.com/xtuple/qt-client","homepage":"","size":71031,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":59,"mirror_url":null,"open_issues_count":23,"forks":59,"open_issues":23,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/441"},"html":{"href":"https://github.com/xtuple/qt-client/pull/441"},"issue":{"href":"https://api.github.com/repos/xtuple/qt-client/issues/441"},"comments":{"href":"https://api.github.com/repos/xtuple/qt-client/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/xtuple/qt-client/statuses/1b1542b4cd8f0be8199bddf904eac87bc9b5c6fa"}}}}