GitHub PullRequestEvent at 2014-12-20 21:09:59
Repository: jquery.pwstrength.bootstrap
Actor: javierholguera
Payload: {"action":"opened","number":48,"pull_request":{"url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls/48","id":26420896,"html_url":"https://github.com/ablanco/jquery.pwstrength.bootstrap/pull/48","diff_url":"https://github.com/ablanco/jquery.pwstrength.bootstrap/pull/48.diff","patch_url":"https://github.com/ablanco/jquery.pwstrength.bootstrap/pull/48.patch","issue_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/issues/48","number":48,"state":"open","locked":false,"title":"Adding a UI option to customize error list displayed when showPopover is true","user":{"login":"javierholguera","id":7188578,"avatar_url":"https://avatars.githubusercontent.com/u/7188578?v=3","gravatar_id":"","url":"https://api.github.com/users/javierholguera","html_url":"https://github.com/javierholguera","followers_url":"https://api.github.com/users/javierholguera/followers","following_url":"https://api.github.com/users/javierholguera/following{/other_user}","gists_url":"https://api.github.com/users/javierholguera/gists{/gist_id}","starred_url":"https://api.github.com/users/javierholguera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierholguera/subscriptions","organizations_url":"https://api.github.com/users/javierholguera/orgs","repos_url":"https://api.github.com/users/javierholguera/repos","events_url":"https://api.github.com/users/javierholguera/events{/privacy}","received_events_url":"https://api.github.com/users/javierholguera/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThis is my first pull request ever so I'm not sure if I'll following the right procedures, so please excuse me if I'm not.\r\n\r\nI've been using your library to visually enhance some password textboxes and it's been extremely useful. Almost every scenario that we had in mind before implementing anything have been covered by your library seamlessly. Thanks a lot for the great work! \r\n\r\nHowever there was a minor requirement that I didn't manage to satisfy with the library as it was: getting rid of the word \"Errors\" in the list shown in the popover. That's the reason for this pull request, I'm sending you the small change that I did to add another UI option that allows to insert your own function for the list generation.\r\n\r\nI hope you'll consider it useful. I'm not a seasoned JavaScript developer, so if you like the idea but you think there is a better way to implement it, please let me know what changes you think that are necessary before including this in the library.\r\n\r\nThanks again for the library.\r\n\r\nLooking forward to hearing from you.\r\n\r\nJavier.","created_at":"2014-12-20T21:09:59Z","updated_at":"2014-12-20T21:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls/48/commits","review_comments_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls/48/comments","review_comment_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/issues/48/comments","statuses_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/statuses/652bffdd34bb3bf2e71f45fdc29e15df3e5485b2","head":{"label":"javierholguera:custom-error-list-popover","ref":"custom-error-list-popover","sha":"652bffdd34bb3bf2e71f45fdc29e15df3e5485b2","user":{"login":"javierholguera","id":7188578,"avatar_url":"https://avatars.githubusercontent.com/u/7188578?v=3","gravatar_id":"","url":"https://api.github.com/users/javierholguera","html_url":"https://github.com/javierholguera","followers_url":"https://api.github.com/users/javierholguera/followers","following_url":"https://api.github.com/users/javierholguera/following{/other_user}","gists_url":"https://api.github.com/users/javierholguera/gists{/gist_id}","starred_url":"https://api.github.com/users/javierholguera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierholguera/subscriptions","organizations_url":"https://api.github.com/users/javierholguera/orgs","repos_url":"https://api.github.com/users/javierholguera/repos","events_url":"https://api.github.com/users/javierholguera/events{/privacy}","received_events_url":"https://api.github.com/users/javierholguera/received_events","type":"User","site_admin":false},"repo":{"id":28060868,"name":"jquery.pwstrength.bootstrap","full_name":"javierholguera/jquery.pwstrength.bootstrap","owner":{"login":"javierholguera","id":7188578,"avatar_url":"https://avatars.githubusercontent.com/u/7188578?v=3","gravatar_id":"","url":"https://api.github.com/users/javierholguera","html_url":"https://github.com/javierholguera","followers_url":"https://api.github.com/users/javierholguera/followers","following_url":"https://api.github.com/users/javierholguera/following{/other_user}","gists_url":"https://api.github.com/users/javierholguera/gists{/gist_id}","starred_url":"https://api.github.com/users/javierholguera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierholguera/subscriptions","organizations_url":"https://api.github.com/users/javierholguera/orgs","repos_url":"https://api.github.com/users/javierholguera/repos","events_url":"https://api.github.com/users/javierholguera/events{/privacy}","received_events_url":"https://api.github.com/users/javierholguera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierholguera/jquery.pwstrength.bootstrap","description":"jQuery Password Strength Meter for Twitter Bootstrap","fork":true,"url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap","forks_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/forks","keys_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/teams","hooks_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/hooks","issue_events_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/events","assignees_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/tags","blobs_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/languages","stargazers_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/stargazers","contributors_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/contributors","subscribers_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/subscribers","subscription_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/subscription","commits_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/merges","archive_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/downloads","issues_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/javierholguera/jquery.pwstrength.bootstrap/releases{/id}","created_at":"2014-12-15T23:15:30Z","updated_at":"2014-12-15T23:15:31Z","pushed_at":"2014-12-20T20:54:58Z","git_url":"git://github.com/javierholguera/jquery.pwstrength.bootstrap.git","ssh_url":"git@github.com:javierholguera/jquery.pwstrength.bootstrap.git","clone_url":"https://github.com/javierholguera/jquery.pwstrength.bootstrap.git","svn_url":"https://github.com/javierholguera/jquery.pwstrength.bootstrap","homepage":"","size":810,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ablanco:master","ref":"master","sha":"b927312b5dd22d1575c32fb34c717a71007470c3","user":{"login":"ablanco","id":535478,"avatar_url":"https://avatars.githubusercontent.com/u/535478?v=3","gravatar_id":"","url":"https://api.github.com/users/ablanco","html_url":"https://github.com/ablanco","followers_url":"https://api.github.com/users/ablanco/followers","following_url":"https://api.github.com/users/ablanco/following{/other_user}","gists_url":"https://api.github.com/users/ablanco/gists{/gist_id}","starred_url":"https://api.github.com/users/ablanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ablanco/subscriptions","organizations_url":"https://api.github.com/users/ablanco/orgs","repos_url":"https://api.github.com/users/ablanco/repos","events_url":"https://api.github.com/users/ablanco/events{/privacy}","received_events_url":"https://api.github.com/users/ablanco/received_events","type":"User","site_admin":false},"repo":{"id":7389507,"name":"jquery.pwstrength.bootstrap","full_name":"ablanco/jquery.pwstrength.bootstrap","owner":{"login":"ablanco","id":535478,"avatar_url":"https://avatars.githubusercontent.com/u/535478?v=3","gravatar_id":"","url":"https://api.github.com/users/ablanco","html_url":"https://github.com/ablanco","followers_url":"https://api.github.com/users/ablanco/followers","following_url":"https://api.github.com/users/ablanco/following{/other_user}","gists_url":"https://api.github.com/users/ablanco/gists{/gist_id}","starred_url":"https://api.github.com/users/ablanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ablanco/subscriptions","organizations_url":"https://api.github.com/users/ablanco/orgs","repos_url":"https://api.github.com/users/ablanco/repos","events_url":"https://api.github.com/users/ablanco/events{/privacy}","received_events_url":"https://api.github.com/users/ablanco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ablanco/jquery.pwstrength.bootstrap","description":"jQuery Password Strength Meter for Twitter Bootstrap","fork":true,"url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap","forks_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/forks","keys_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/teams","hooks_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/hooks","issue_events_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/events","assignees_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/tags","blobs_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/languages","stargazers_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/stargazers","contributors_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/contributors","subscribers_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/subscribers","subscription_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/subscription","commits_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/merges","archive_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/downloads","issues_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/releases{/id}","created_at":"2012-12-31T17:40:24Z","updated_at":"2014-12-12T15:52:20Z","pushed_at":"2014-09-11T18:43:50Z","git_url":"git://github.com/ablanco/jquery.pwstrength.bootstrap.git","ssh_url":"git@github.com:ablanco/jquery.pwstrength.bootstrap.git","clone_url":"https://github.com/ablanco/jquery.pwstrength.bootstrap.git","svn_url":"https://github.com/ablanco/jquery.pwstrength.bootstrap","homepage":"","size":1549,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":2,"forks":55,"open_issues":2,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls/48"},"html":{"href":"https://github.com/ablanco/jquery.pwstrength.bootstrap/pull/48"},"issue":{"href":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/issues/48"},"comments":{"href":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/ablanco/jquery.pwstrength.bootstrap/statuses/652bffdd34bb3bf2e71f45fdc29e15df3e5485b2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":136,"deletions":42,"changed_files":9}}