GitHub PullRequestReviewCommentEvent at 2014-12-01 22:47:24
Repository: pulp
Actor: asmacdo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/21126399","id":21126399,"diff_hunk":"@@ -407,13 +409,21 @@ def test_wrong_distributor(self, mock_get_distributor):\n         u'last_run_at': u'2013-12-17T00:35:53Z',\n         u'last_updated': 1387218500.598727,\n         u'next_run': u'2013-12-17T00:36:53Z',\n-        u'principal': u\"(dp0\\nV_id\\np1\\nccopy_reg\\n_reconstructor\\np2\\n(cbson.objectid\\nObjectId\\np3\\nc__builtin__\\nobject\\np4\\nNtp5\\nRp6\\nS'R \\\\xab\\\\x06\\\\xe1\\\\x9a\\\\x00\\\\x10\\\\xe1i\\\\x05\\\\x89'\\np7\\nbsVname\\np8\\nVadmin\\np9\\nsVroles\\np10\\n(lp11\\nVsuper-users\\np12\\nasV_ns\\np13\\nVusers\\np14\\nsVlogin\\np15\\nVadmin\\np16\\nsVpassword\\np17\\nVV76Yol1XYgM=,S/G6o5UyMrn0xAwbQCqFcrXnfXTh84RWhunanCDkSCo=\\np18\\nsVid\\np19\\nV5220ab06e19a0010e1690589\\np20\\ns.\",\n+        u'principal': u\"(dp0\\nV_id\\np1\\nccopy_reg\\n_reconstructor\\np2\\n(cbson.objectid\\n\" +\n+                      u\"ObjectId\\np3\\nc__builtin__\\nobject\\np4\\nNtp5\\nRp6\\nS'R \\\\xab\\\\x06\\\\xe1\" +\n+                      u\"\\\\x9a\\\\x00\\\\x10\\\\xe1i\\\\x05\\\\x89'\\np7\\nbsVname\\np8\\nVadmin\\np9\\nsVroles\\n\" +\n+                      u\"p10\\n(lp11\\nVsuper-users\\np12\\nasV_ns\\np13\\nVusers\\np14\\nsVlogin\\np15\\n\" +\n+                      u\"Vadmin\\np16\\nsVpassword\\np17\\n\" +\n+                      u\"VV76Yol1XYgM=,S/G6o5UyMrn0xAwbQCqFcrXnfXTh84RWhunanCDkSCo=\\np18\\nsVid\\n\" +\n+                      u\"p19\\nV5220ab06e19a0010e1690589\\np20\\ns.\",\n         u'remaining_runs': None,\n         u'resource': u'pulp:distributor:demo:puppet_distributor',\n-        u'schedule': u\"ccopy_reg\\n_reconstructor\\np0\\n(ccelery.schedules\\nschedule\\np1\\nc__builtin__\\nobject\\np2\\nNtp3\\nRp4\\n(dp5\\nS'relative'\\np6\\nI00\\nsS'nowfun'\\np7\\nNsS'run_every'\\np8\\ncdatetime\\ntimedelta\\np9\\n(I0\\nI60\\nI0\\ntp10\\nRp11\\nsb.\",\n+        u'schedule': u\"ccopy_reg\\n_reconstructor\\np0\\n(ccelery.schedules\\nschedule\\np1\\n\" +\n+                     u\"c__builtin__\\nobject\\np2\\nNtp3\\nRp4\\n(dp5\\nS'relative'\\np6\\nI00\\n\" +\n+                     u\"sS'nowfun'\\np7\\nNsS'run_every'\\np8\\ncdatetime\\ntimedelta\\np9\\n(I0\\nI60\\n\" +\n+                     u\"I0\\ntp10\\nRp11\\nsb.\",\n         u'task': u'pulp.server.tasks.repository.publish',\n-        u'total_run_count': 1087,\n-        },\n+        u'total_run_count': 1087},","path":"server/test/unit/server/managers/schedule/test_repo.py","position":130,"original_position":130,"commit_id":"2060a714bca9a48dc0223d49d00f3e9c2ce0ea61","original_commit_id":"2060a714bca9a48dc0223d49d00f3e9c2ce0ea61","user":{"login":"asmacdo","id":1028657,"avatar_url":"https://avatars.githubusercontent.com/u/1028657?v=3","gravatar_id":"","url":"https://api.github.com/users/asmacdo","html_url":"https://github.com/asmacdo","followers_url":"https://api.github.com/users/asmacdo/followers","following_url":"https://api.github.com/users/asmacdo/following{/other_user}","gists_url":"https://api.github.com/users/asmacdo/gists{/gist_id}","starred_url":"https://api.github.com/users/asmacdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmacdo/subscriptions","organizations_url":"https://api.github.com/users/asmacdo/orgs","repos_url":"https://api.github.com/users/asmacdo/repos","events_url":"https://api.github.com/users/asmacdo/events{/privacy}","received_events_url":"https://api.github.com/users/asmacdo/received_events","type":"User","site_admin":false},"body":"I think the `}` really needs its own line (aligned with the opening curly) for readability.","created_at":"2014-12-01T22:47:24Z","updated_at":"2014-12-01T22:47:24Z","html_url":"https://github.com/pulp/pulp/pull/1378#discussion_r21126399","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/1378","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/21126399"},"html":{"href":"https://github.com/pulp/pulp/pull/1378#discussion_r21126399"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1378"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/1378","id":25291229,"html_url":"https://github.com/pulp/pulp/pull/1378","diff_url":"https://github.com/pulp/pulp/pull/1378.diff","patch_url":"https://github.com/pulp/pulp/pull/1378.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/1378","number":1378,"state":"open","locked":false,"title":"PEP-8 tests for server.managers.schedule.repo.","user":{"login":"rbarlow","id":354506,"avatar_url":"https://avatars.githubusercontent.com/u/354506?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarlow","html_url":"https://github.com/rbarlow","followers_url":"https://api.github.com/users/rbarlow/followers","following_url":"https://api.github.com/users/rbarlow/following{/other_user}","gists_url":"https://api.github.com/users/rbarlow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarlow/subscriptions","organizations_url":"https://api.github.com/users/rbarlow/orgs","repos_url":"https://api.github.com/users/rbarlow/repos","events_url":"https://api.github.com/users/rbarlow/events{/privacy}","received_events_url":"https://api.github.com/users/rbarlow/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-01T19:13:04Z","updated_at":"2014-12-01T22:47:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ecc81c195395f587d4f552aa6cdc501f4c8ff37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/1378/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/1378/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/1378/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/2060a714bca9a48dc0223d49d00f3e9c2ce0ea61","head":{"label":"rbarlow:pep8-schedule_repo","ref":"pep8-schedule_repo","sha":"2060a714bca9a48dc0223d49d00f3e9c2ce0ea61","user":{"login":"rbarlow","id":354506,"avatar_url":"https://avatars.githubusercontent.com/u/354506?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarlow","html_url":"https://github.com/rbarlow","followers_url":"https://api.github.com/users/rbarlow/followers","following_url":"https://api.github.com/users/rbarlow/following{/other_user}","gists_url":"https://api.github.com/users/rbarlow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarlow/subscriptions","organizations_url":"https://api.github.com/users/rbarlow/orgs","repos_url":"https://api.github.com/users/rbarlow/repos","events_url":"https://api.github.com/users/rbarlow/events{/privacy}","received_events_url":"https://api.github.com/users/rbarlow/received_events","type":"User","site_admin":false},"repo":{"id":24110007,"name":"pulp","full_name":"rbarlow/pulp","owner":{"login":"rbarlow","id":354506,"avatar_url":"https://avatars.githubusercontent.com/u/354506?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarlow","html_url":"https://github.com/rbarlow","followers_url":"https://api.github.com/users/rbarlow/followers","following_url":"https://api.github.com/users/rbarlow/following{/other_user}","gists_url":"https://api.github.com/users/rbarlow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarlow/subscriptions","organizations_url":"https://api.github.com/users/rbarlow/orgs","repos_url":"https://api.github.com/users/rbarlow/repos","events_url":"https://api.github.com/users/rbarlow/events{/privacy}","received_events_url":"https://api.github.com/users/rbarlow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbarlow/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/rbarlow/pulp","forks_url":"https://api.github.com/repos/rbarlow/pulp/forks","keys_url":"https://api.github.com/repos/rbarlow/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbarlow/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbarlow/pulp/teams","hooks_url":"https://api.github.com/repos/rbarlow/pulp/hooks","issue_events_url":"https://api.github.com/repos/rbarlow/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/rbarlow/pulp/events","assignees_url":"https://api.github.com/repos/rbarlow/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/rbarlow/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/rbarlow/pulp/tags","blobs_url":"https://api.github.com/repos/rbarlow/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbarlow/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbarlow/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbarlow/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbarlow/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/rbarlow/pulp/languages","stargazers_url":"https://api.github.com/repos/rbarlow/pulp/stargazers","contributors_url":"https://api.github.com/repos/rbarlow/pulp/contributors","subscribers_url":"https://api.github.com/repos/rbarlow/pulp/subscribers","subscription_url":"https://api.github.com/repos/rbarlow/pulp/subscription","commits_url":"https://api.github.com/repos/rbarlow/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbarlow/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbarlow/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbarlow/pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/rbarlow/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/rbarlow/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbarlow/pulp/merges","archive_url":"https://api.github.com/repos/rbarlow/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbarlow/pulp/downloads","issues_url":"https://api.github.com/repos/rbarlow/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/rbarlow/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/rbarlow/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/rbarlow/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbarlow/pulp/labels{/name}","releases_url":"https://api.github.com/repos/rbarlow/pulp/releases{/id}","created_at":"2014-09-16T17:30:02Z","updated_at":"2014-11-21T15:09:17Z","pushed_at":"2014-12-01T19:12:39Z","git_url":"git://github.com/rbarlow/pulp.git","ssh_url":"git@github.com:rbarlow/pulp.git","clone_url":"https://github.com/rbarlow/pulp.git","svn_url":"https://github.com/rbarlow/pulp","homepage":"","size":77963,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"b9fac3f6fc005aa0d777318ae63bbb7d5ba25090","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","created_at":"2012-08-06T13:49:20Z","updated_at":"2014-12-01T21:41:05Z","pushed_at":"2014-12-01T21:41:05Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":210176,"stargazers_count":154,"watchers_count":154,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":25,"forks":71,"open_issues":25,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1378"},"html":{"href":"https://github.com/pulp/pulp/pull/1378"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/1378"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/1378/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1378/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1378/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/2060a714bca9a48dc0223d49d00f3e9c2ce0ea61"}}}}