GitHub PullRequestReviewCommentEvent at 2014-07-14 11:44:21
Repository: mantisbt
Actor: dregad
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/14874010","id":14874010,"diff_hunk":"@@ -40,15 +40,12 @@\n  * @return boolean\n  */\n function mci_is_webservice_call() {\n-\tglobal $QUERY_STRING;\n \tglobal $_SERVER;","path":"api/soap/mantisconnect.php","position":5,"original_position":5,"commit_id":"6a08fff457807a720647ec0688068b5872771643","original_commit_id":"6a08fff457807a720647ec0688068b5872771643","user":{"login":"dregad","id":449891,"avatar_url":"https://avatars.githubusercontent.com/u/449891?","gravatar_id":"1dd257ccd6d364a12ba89bcc68bfe911","url":"https://api.github.com/users/dregad","html_url":"https://github.com/dregad","followers_url":"https://api.github.com/users/dregad/followers","following_url":"https://api.github.com/users/dregad/following{/other_user}","gists_url":"https://api.github.com/users/dregad/gists{/gist_id}","starred_url":"https://api.github.com/users/dregad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dregad/subscriptions","organizations_url":"https://api.github.com/users/dregad/orgs","repos_url":"https://api.github.com/users/dregad/repos","events_url":"https://api.github.com/users/dregad/events{/privacy}","received_events_url":"https://api.github.com/users/dregad/received_events","type":"User","site_admin":false},"body":"Superglobals don't need to be declared with `global` - suggest you remove that line too.","created_at":"2014-07-14T11:44:21Z","updated_at":"2014-07-14T11:44:21Z","html_url":"https://github.com/mantisbt/mantisbt/pull/218#discussion_r14874010","pull_request_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/14874010"},"html":{"href":"https://github.com/mantisbt/mantisbt/pull/218#discussion_r14874010"},"pull_request":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/218","id":18327942,"html_url":"https://github.com/mantisbt/mantisbt/pull/218","diff_url":"https://github.com/mantisbt/mantisbt/pull/218.diff","patch_url":"https://github.com/mantisbt/mantisbt/pull/218.patch","issue_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/218","number":218,"state":"open","title":"Remove inbuilt php long arrays","user":{"login":"grangeway","id":434241,"avatar_url":"https://avatars.githubusercontent.com/u/434241?","gravatar_id":"5f44ee7199ca8f08e82c46e104f768f6","url":"https://api.github.com/users/grangeway","html_url":"https://github.com/grangeway","followers_url":"https://api.github.com/users/grangeway/followers","following_url":"https://api.github.com/users/grangeway/following{/other_user}","gists_url":"https://api.github.com/users/grangeway/gists{/gist_id}","starred_url":"https://api.github.com/users/grangeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grangeway/subscriptions","organizations_url":"https://api.github.com/users/grangeway/orgs","repos_url":"https://api.github.com/users/grangeway/repos","events_url":"https://api.github.com/users/grangeway/events{/privacy}","received_events_url":"https://api.github.com/users/grangeway/received_events","type":"User","site_admin":false},"body":"PHP Long arrays are deprecated and removed in php 5.4.\r\n\r\nWe already check both $_SERVER and $GLOBALS\r\nso there's no need to check for $QUERY_STRING itself.","created_at":"2014-07-13T23:37:15Z","updated_at":"2014-07-14T11:44:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e811d1e2ce85c9f68988eb073d2397cbd0c3ecc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/218/commits","review_comments_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/218/comments","review_comment_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/218/comments","statuses_url":"https://api.github.com/repos/mantisbt/mantisbt/statuses/6a08fff457807a720647ec0688068b5872771643","head":{"label":"grangeway:long_arrays","ref":"long_arrays","sha":"6a08fff457807a720647ec0688068b5872771643","user":{"login":"grangeway","id":434241,"avatar_url":"https://avatars.githubusercontent.com/u/434241?","gravatar_id":"5f44ee7199ca8f08e82c46e104f768f6","url":"https://api.github.com/users/grangeway","html_url":"https://github.com/grangeway","followers_url":"https://api.github.com/users/grangeway/followers","following_url":"https://api.github.com/users/grangeway/following{/other_user}","gists_url":"https://api.github.com/users/grangeway/gists{/gist_id}","starred_url":"https://api.github.com/users/grangeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grangeway/subscriptions","organizations_url":"https://api.github.com/users/grangeway/orgs","repos_url":"https://api.github.com/users/grangeway/repos","events_url":"https://api.github.com/users/grangeway/events{/privacy}","received_events_url":"https://api.github.com/users/grangeway/received_events","type":"User","site_admin":false},"repo":{"id":20504653,"name":"mantisbt","full_name":"grangeway/mantisbt","owner":{"login":"grangeway","id":434241,"avatar_url":"https://avatars.githubusercontent.com/u/434241?","gravatar_id":"5f44ee7199ca8f08e82c46e104f768f6","url":"https://api.github.com/users/grangeway","html_url":"https://github.com/grangeway","followers_url":"https://api.github.com/users/grangeway/followers","following_url":"https://api.github.com/users/grangeway/following{/other_user}","gists_url":"https://api.github.com/users/grangeway/gists{/gist_id}","starred_url":"https://api.github.com/users/grangeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grangeway/subscriptions","organizations_url":"https://api.github.com/users/grangeway/orgs","repos_url":"https://api.github.com/users/grangeway/repos","events_url":"https://api.github.com/users/grangeway/events{/privacy}","received_events_url":"https://api.github.com/users/grangeway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grangeway/mantisbt","description":"Mantis Bug Tracker (MantisBT)","fork":true,"url":"https://api.github.com/repos/grangeway/mantisbt","forks_url":"https://api.github.com/repos/grangeway/mantisbt/forks","keys_url":"https://api.github.com/repos/grangeway/mantisbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grangeway/mantisbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grangeway/mantisbt/teams","hooks_url":"https://api.github.com/repos/grangeway/mantisbt/hooks","issue_events_url":"https://api.github.com/repos/grangeway/mantisbt/issues/events{/number}","events_url":"https://api.github.com/repos/grangeway/mantisbt/events","assignees_url":"https://api.github.com/repos/grangeway/mantisbt/assignees{/user}","branches_url":"https://api.github.com/repos/grangeway/mantisbt/branches{/branch}","tags_url":"https://api.github.com/repos/grangeway/mantisbt/tags","blobs_url":"https://api.github.com/repos/grangeway/mantisbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grangeway/mantisbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grangeway/mantisbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/grangeway/mantisbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grangeway/mantisbt/statuses/{sha}","languages_url":"https://api.github.com/repos/grangeway/mantisbt/languages","stargazers_url":"https://api.github.com/repos/grangeway/mantisbt/stargazers","contributors_url":"https://api.github.com/repos/grangeway/mantisbt/contributors","subscribers_url":"https://api.github.com/repos/grangeway/mantisbt/subscribers","subscription_url":"https://api.github.com/repos/grangeway/mantisbt/subscription","commits_url":"https://api.github.com/repos/grangeway/mantisbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/grangeway/mantisbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/grangeway/mantisbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/grangeway/mantisbt/issues/comments/{number}","contents_url":"https://api.github.com/repos/grangeway/mantisbt/contents/{+path}","compare_url":"https://api.github.com/repos/grangeway/mantisbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grangeway/mantisbt/merges","archive_url":"https://api.github.com/repos/grangeway/mantisbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grangeway/mantisbt/downloads","issues_url":"https://api.github.com/repos/grangeway/mantisbt/issues{/number}","pulls_url":"https://api.github.com/repos/grangeway/mantisbt/pulls{/number}","milestones_url":"https://api.github.com/repos/grangeway/mantisbt/milestones{/number}","notifications_url":"https://api.github.com/repos/grangeway/mantisbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grangeway/mantisbt/labels{/name}","releases_url":"https://api.github.com/repos/grangeway/mantisbt/releases{/id}","created_at":"2014-06-04T23:26:13Z","updated_at":"2014-06-23T23:24:15Z","pushed_at":"2014-07-13T23:42:06Z","git_url":"git://github.com/grangeway/mantisbt.git","ssh_url":"git@github.com:grangeway/mantisbt.git","clone_url":"https://github.com/grangeway/mantisbt.git","svn_url":"https://github.com/grangeway/mantisbt","homepage":"http://www.mantisbt.org","size":59521,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mantisbt:master","ref":"master","sha":"07c6605bc49c74b1571d42f5be8cf0a43f43ed53","user":{"login":"mantisbt","id":318027,"avatar_url":"https://avatars.githubusercontent.com/u/318027?","gravatar_id":"0c60963f631fca9a4ebe69a2f634bccc","url":"https://api.github.com/users/mantisbt","html_url":"https://github.com/mantisbt","followers_url":"https://api.github.com/users/mantisbt/followers","following_url":"https://api.github.com/users/mantisbt/following{/other_user}","gists_url":"https://api.github.com/users/mantisbt/gists{/gist_id}","starred_url":"https://api.github.com/users/mantisbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantisbt/subscriptions","organizations_url":"https://api.github.com/users/mantisbt/orgs","repos_url":"https://api.github.com/users/mantisbt/repos","events_url":"https://api.github.com/users/mantisbt/events{/privacy}","received_events_url":"https://api.github.com/users/mantisbt/received_events","type":"Organization","site_admin":false},"repo":{"id":747755,"name":"mantisbt","full_name":"mantisbt/mantisbt","owner":{"login":"mantisbt","id":318027,"avatar_url":"https://avatars.githubusercontent.com/u/318027?","gravatar_id":"0c60963f631fca9a4ebe69a2f634bccc","url":"https://api.github.com/users/mantisbt","html_url":"https://github.com/mantisbt","followers_url":"https://api.github.com/users/mantisbt/followers","following_url":"https://api.github.com/users/mantisbt/following{/other_user}","gists_url":"https://api.github.com/users/mantisbt/gists{/gist_id}","starred_url":"https://api.github.com/users/mantisbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantisbt/subscriptions","organizations_url":"https://api.github.com/users/mantisbt/orgs","repos_url":"https://api.github.com/users/mantisbt/repos","events_url":"https://api.github.com/users/mantisbt/events{/privacy}","received_events_url":"https://api.github.com/users/mantisbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantisbt/mantisbt","description":"Mantis Bug Tracker (MantisBT)","fork":false,"url":"https://api.github.com/repos/mantisbt/mantisbt","forks_url":"https://api.github.com/repos/mantisbt/mantisbt/forks","keys_url":"https://api.github.com/repos/mantisbt/mantisbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantisbt/mantisbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantisbt/mantisbt/teams","hooks_url":"https://api.github.com/repos/mantisbt/mantisbt/hooks","issue_events_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/events{/number}","events_url":"https://api.github.com/repos/mantisbt/mantisbt/events","assignees_url":"https://api.github.com/repos/mantisbt/mantisbt/assignees{/user}","branches_url":"https://api.github.com/repos/mantisbt/mantisbt/branches{/branch}","tags_url":"https://api.github.com/repos/mantisbt/mantisbt/tags","blobs_url":"https://api.github.com/repos/mantisbt/mantisbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantisbt/mantisbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantisbt/mantisbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantisbt/mantisbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantisbt/mantisbt/statuses/{sha}","languages_url":"https://api.github.com/repos/mantisbt/mantisbt/languages","stargazers_url":"https://api.github.com/repos/mantisbt/mantisbt/stargazers","contributors_url":"https://api.github.com/repos/mantisbt/mantisbt/contributors","subscribers_url":"https://api.github.com/repos/mantisbt/mantisbt/subscribers","subscription_url":"https://api.github.com/repos/mantisbt/mantisbt/subscription","commits_url":"https://api.github.com/repos/mantisbt/mantisbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantisbt/mantisbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantisbt/mantisbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/comments/{number}","contents_url":"https://api.github.com/repos/mantisbt/mantisbt/contents/{+path}","compare_url":"https://api.github.com/repos/mantisbt/mantisbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantisbt/mantisbt/merges","archive_url":"https://api.github.com/repos/mantisbt/mantisbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantisbt/mantisbt/downloads","issues_url":"https://api.github.com/repos/mantisbt/mantisbt/issues{/number}","pulls_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls{/number}","milestones_url":"https://api.github.com/repos/mantisbt/mantisbt/milestones{/number}","notifications_url":"https://api.github.com/repos/mantisbt/mantisbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantisbt/mantisbt/labels{/name}","releases_url":"https://api.github.com/repos/mantisbt/mantisbt/releases{/id}","created_at":"2010-06-29T21:42:07Z","updated_at":"2014-07-11T14:39:22Z","pushed_at":"2014-07-14T09:45:54Z","git_url":"git://github.com/mantisbt/mantisbt.git","ssh_url":"git@github.com:mantisbt/mantisbt.git","clone_url":"https://github.com/mantisbt/mantisbt.git","svn_url":"https://github.com/mantisbt/mantisbt","homepage":"http://www.mantisbt.org","size":70275,"stargazers_count":369,"watchers_count":369,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":203,"mirror_url":null,"open_issues_count":36,"forks":203,"open_issues":36,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/218"},"html":{"href":"https://github.com/mantisbt/mantisbt/pull/218"},"issue":{"href":"https://api.github.com/repos/mantisbt/mantisbt/issues/218"},"comments":{"href":"https://api.github.com/repos/mantisbt/mantisbt/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/mantisbt/mantisbt/statuses/6a08fff457807a720647ec0688068b5872771643"}}}}