GitHub PullRequestEvent at 2014-12-09 01:19:19
Repository: uribeacon
Actor: schilit
Payload: {"action":"closed","number":59,"pull_request":{"url":"https://api.github.com/repos/google/uribeacon/pulls/59","id":25189897,"html_url":"https://github.com/google/uribeacon/pull/59","diff_url":"https://github.com/google/uribeacon/pull/59.diff","patch_url":"https://github.com/google/uribeacon/pull/59.patch","issue_url":"https://api.github.com/repos/google/uribeacon/issues/59","number":59,"state":"closed","locked":false,"title":"Change initial offset of byte parsing to account for URI Beacon ID","user":{"login":"ryanbateman","id":1236394,"avatar_url":"https://avatars.githubusercontent.com/u/1236394?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbateman","html_url":"https://github.com/ryanbateman","followers_url":"https://api.github.com/users/ryanbateman/followers","following_url":"https://api.github.com/users/ryanbateman/following{/other_user}","gists_url":"https://api.github.com/users/ryanbateman/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbateman/subscriptions","organizations_url":"https://api.github.com/users/ryanbateman/orgs","repos_url":"https://api.github.com/users/ryanbateman/repos","events_url":"https://api.github.com/users/ryanbateman/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbateman/received_events","type":"User","site_admin":false},"body":"**Problem:** The Android UriBeacon client was incorrectly parsing the advertisementData format, failing to take into account the initial two bytes consisting of the URI Beacon ID.  This led to an incorrect parsing of the URI and strange data being displayed.  (See UriBeaconAdvertiserActivity, line 59/60 for the reference.)\r\n\r\n**Solution:** Specify the offset in the parser code.  \r\n\r\n**Before:**\r\n\r\n![before](https://cloud.githubusercontent.com/assets/1236394/5227029/e396c9d0-76ed-11e4-8c7c-e9c214474f70.png)\r\n\r\n**After:**  \r\n\r\n![after](https://cloud.githubusercontent.com/assets/1236394/5227042/008a6006-76ee-11e4-95f4-4fe6019c0d9d.png)\r\n","created_at":"2014-11-28T11:02:33Z","updated_at":"2014-12-09T01:19:18Z","closed_at":"2014-12-09T01:19:18Z","merged_at":null,"merge_commit_sha":"2987ae2ac94da35c3667962938f6bb0a9eaeb303","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/uribeacon/pulls/59/commits","review_comments_url":"https://api.github.com/repos/google/uribeacon/pulls/59/comments","review_comment_url":"https://api.github.com/repos/google/uribeacon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/google/uribeacon/issues/59/comments","statuses_url":"https://api.github.com/repos/google/uribeacon/statuses/a2cc7d00204cc9392df84ec5365612d87f2bcd4a","head":{"label":"ryanbateman:invalid_beacondata_parse_fix","ref":"invalid_beacondata_parse_fix","sha":"a2cc7d00204cc9392df84ec5365612d87f2bcd4a","user":{"login":"ryanbateman","id":1236394,"avatar_url":"https://avatars.githubusercontent.com/u/1236394?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbateman","html_url":"https://github.com/ryanbateman","followers_url":"https://api.github.com/users/ryanbateman/followers","following_url":"https://api.github.com/users/ryanbateman/following{/other_user}","gists_url":"https://api.github.com/users/ryanbateman/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbateman/subscriptions","organizations_url":"https://api.github.com/users/ryanbateman/orgs","repos_url":"https://api.github.com/users/ryanbateman/repos","events_url":"https://api.github.com/users/ryanbateman/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbateman/received_events","type":"User","site_admin":false},"repo":{"id":27262576,"name":"uribeacon","full_name":"ryanbateman/uribeacon","owner":{"login":"ryanbateman","id":1236394,"avatar_url":"https://avatars.githubusercontent.com/u/1236394?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbateman","html_url":"https://github.com/ryanbateman","followers_url":"https://api.github.com/users/ryanbateman/followers","following_url":"https://api.github.com/users/ryanbateman/following{/other_user}","gists_url":"https://api.github.com/users/ryanbateman/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbateman/subscriptions","organizations_url":"https://api.github.com/users/ryanbateman/orgs","repos_url":"https://api.github.com/users/ryanbateman/repos","events_url":"https://api.github.com/users/ryanbateman/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbateman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanbateman/uribeacon","description":"The Web Uri Open Beacon for the Internet of Things","fork":true,"url":"https://api.github.com/repos/ryanbateman/uribeacon","forks_url":"https://api.github.com/repos/ryanbateman/uribeacon/forks","keys_url":"https://api.github.com/repos/ryanbateman/uribeacon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanbateman/uribeacon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanbateman/uribeacon/teams","hooks_url":"https://api.github.com/repos/ryanbateman/uribeacon/hooks","issue_events_url":"https://api.github.com/repos/ryanbateman/uribeacon/issues/events{/number}","events_url":"https://api.github.com/repos/ryanbateman/uribeacon/events","assignees_url":"https://api.github.com/repos/ryanbateman/uribeacon/assignees{/user}","branches_url":"https://api.github.com/repos/ryanbateman/uribeacon/branches{/branch}","tags_url":"https://api.github.com/repos/ryanbateman/uribeacon/tags","blobs_url":"https://api.github.com/repos/ryanbateman/uribeacon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanbateman/uribeacon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanbateman/uribeacon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanbateman/uribeacon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanbateman/uribeacon/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanbateman/uribeacon/languages","stargazers_url":"https://api.github.com/repos/ryanbateman/uribeacon/stargazers","contributors_url":"https://api.github.com/repos/ryanbateman/uribeacon/contributors","subscribers_url":"https://api.github.com/repos/ryanbateman/uribeacon/subscribers","subscription_url":"https://api.github.com/repos/ryanbateman/uribeacon/subscription","commits_url":"https://api.github.com/repos/ryanbateman/uribeacon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanbateman/uribeacon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanbateman/uribeacon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanbateman/uribeacon/issues/comments/{number}","contents_url":"https://api.github.com/repos/ryanbateman/uribeacon/contents/{+path}","compare_url":"https://api.github.com/repos/ryanbateman/uribeacon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanbateman/uribeacon/merges","archive_url":"https://api.github.com/repos/ryanbateman/uribeacon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanbateman/uribeacon/downloads","issues_url":"https://api.github.com/repos/ryanbateman/uribeacon/issues{/number}","pulls_url":"https://api.github.com/repos/ryanbateman/uribeacon/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanbateman/uribeacon/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanbateman/uribeacon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanbateman/uribeacon/labels{/name}","releases_url":"https://api.github.com/repos/ryanbateman/uribeacon/releases{/id}","created_at":"2014-11-28T10:36:36Z","updated_at":"2014-11-28T10:36:37Z","pushed_at":"2014-11-28T10:40:18Z","git_url":"git://github.com/ryanbateman/uribeacon.git","ssh_url":"git@github.com:ryanbateman/uribeacon.git","clone_url":"https://github.com/ryanbateman/uribeacon.git","svn_url":"https://github.com/ryanbateman/uribeacon","homepage":"","size":1897,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a995e731f36e45b00b5816e1b1270b8e2fb8a53e","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":24507314,"name":"uribeacon","full_name":"google/uribeacon","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/uribeacon","description":"The Web Uri Open Beacon for the Internet of Things","fork":false,"url":"https://api.github.com/repos/google/uribeacon","forks_url":"https://api.github.com/repos/google/uribeacon/forks","keys_url":"https://api.github.com/repos/google/uribeacon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/uribeacon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/uribeacon/teams","hooks_url":"https://api.github.com/repos/google/uribeacon/hooks","issue_events_url":"https://api.github.com/repos/google/uribeacon/issues/events{/number}","events_url":"https://api.github.com/repos/google/uribeacon/events","assignees_url":"https://api.github.com/repos/google/uribeacon/assignees{/user}","branches_url":"https://api.github.com/repos/google/uribeacon/branches{/branch}","tags_url":"https://api.github.com/repos/google/uribeacon/tags","blobs_url":"https://api.github.com/repos/google/uribeacon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/uribeacon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/uribeacon/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/uribeacon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/uribeacon/statuses/{sha}","languages_url":"https://api.github.com/repos/google/uribeacon/languages","stargazers_url":"https://api.github.com/repos/google/uribeacon/stargazers","contributors_url":"https://api.github.com/repos/google/uribeacon/contributors","subscribers_url":"https://api.github.com/repos/google/uribeacon/subscribers","subscription_url":"https://api.github.com/repos/google/uribeacon/subscription","commits_url":"https://api.github.com/repos/google/uribeacon/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/uribeacon/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/uribeacon/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/uribeacon/issues/comments/{number}","contents_url":"https://api.github.com/repos/google/uribeacon/contents/{+path}","compare_url":"https://api.github.com/repos/google/uribeacon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/uribeacon/merges","archive_url":"https://api.github.com/repos/google/uribeacon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/uribeacon/downloads","issues_url":"https://api.github.com/repos/google/uribeacon/issues{/number}","pulls_url":"https://api.github.com/repos/google/uribeacon/pulls{/number}","milestones_url":"https://api.github.com/repos/google/uribeacon/milestones{/number}","notifications_url":"https://api.github.com/repos/google/uribeacon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/uribeacon/labels{/name}","releases_url":"https://api.github.com/repos/google/uribeacon/releases{/id}","created_at":"2014-09-26T16:44:12Z","updated_at":"2014-12-08T22:04:26Z","pushed_at":"2014-12-08T21:45:23Z","git_url":"git://github.com/google/uribeacon.git","ssh_url":"git@github.com:google/uribeacon.git","clone_url":"https://github.com/google/uribeacon.git","svn_url":"https://github.com/google/uribeacon","homepage":"","size":3753,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":25,"mirror_url":null,"open_issues_count":12,"forks":25,"open_issues":12,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/uribeacon/pulls/59"},"html":{"href":"https://github.com/google/uribeacon/pull/59"},"issue":{"href":"https://api.github.com/repos/google/uribeacon/issues/59"},"comments":{"href":"https://api.github.com/repos/google/uribeacon/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/google/uribeacon/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/google/uribeacon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/google/uribeacon/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/google/uribeacon/statuses/a2cc7d00204cc9392df84ec5365612d87f2bcd4a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":1,"commits":1,"additions":4,"deletions":1,"changed_files":1}}