GitHub PullRequestReviewCommentEvent at 2014-11-03 06:20:49
Repository: qutip
Actor: jrjohansson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/qutip/qutip/pulls/comments/19719938","id":19719938,"diff_hunk":"@@ -240,3 +240,9 @@\n from qutip.utilities import *\n from qutip.fileio import *\n from qutip.about import *\n+# try to load utilities dependent on Matplotlib\n+try:","path":"qutip/__init__.py","position":null,"original_position":5,"commit_id":"d4b3291ad0e5e1c39511a73b6dc6c2dd3db78d29","original_commit_id":"8a170f60e0ca815ca77a6a53c7dca18f46a7d290","user":{"login":"jrjohansson","id":1198183,"avatar_url":"https://avatars.githubusercontent.com/u/1198183?v=2","gravatar_id":"","url":"https://api.github.com/users/jrjohansson","html_url":"https://github.com/jrjohansson","followers_url":"https://api.github.com/users/jrjohansson/followers","following_url":"https://api.github.com/users/jrjohansson/following{/other_user}","gists_url":"https://api.github.com/users/jrjohansson/gists{/gist_id}","starred_url":"https://api.github.com/users/jrjohansson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrjohansson/subscriptions","organizations_url":"https://api.github.com/users/jrjohansson/orgs","repos_url":"https://api.github.com/users/jrjohansson/repos","events_url":"https://api.github.com/users/jrjohansson/events{/privacy}","received_events_url":"https://api.github.com/users/jrjohansson/received_events","type":"User","site_admin":false},"body":"How about just making a local dummy class called Normalize if matplotlib is not available then, just to make the definition of the class pass? i think if is nicer if the the presence of absence of optional dependencies does not change what symbols qutip provide, so that at least the functions and their docstrings etc are available. but in this case maybe its not worth it.. ","created_at":"2014-11-03T06:20:49Z","updated_at":"2014-11-03T06:20:49Z","html_url":"https://github.com/qutip/qutip/pull/249#discussion_r19719938","pull_request_url":"https://api.github.com/repos/qutip/qutip/pulls/249","_links":{"self":{"href":"https://api.github.com/repos/qutip/qutip/pulls/comments/19719938"},"html":{"href":"https://github.com/qutip/qutip/pull/249#discussion_r19719938"},"pull_request":{"href":"https://api.github.com/repos/qutip/qutip/pulls/249"}}},"pull_request":{"url":"https://api.github.com/repos/qutip/qutip/pulls/249","id":23743623,"html_url":"https://github.com/qutip/qutip/pull/249","diff_url":"https://github.com/qutip/qutip/pull/249.diff","patch_url":"https://github.com/qutip/qutip/pull/249.patch","issue_url":"https://api.github.com/repos/qutip/qutip/issues/249","number":249,"state":"open","locked":false,"title":"ADDED: matplotlib_utilities module","user":{"login":"nonhermitian","id":1249193,"avatar_url":"https://avatars.githubusercontent.com/u/1249193?v=2","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},"body":"- Moved functions that enhance matplotlib (colormaps, normalizations\r\netc.) to new module. Module is imported with try-except statement since\r\nfunctions require matplotlib which may or may not be present.\r\n\r\n- Updated wigner_cmap to allow for custom colors that can be defined in\r\nany format acceptable to the Matplotib.colors.ColorConverter.","created_at":"2014-11-03T05:30:45Z","updated_at":"2014-11-03T06:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"267748bd1d9841581f370d75a49117986ddff35b","assignee":{"login":"nonhermitian","id":1249193,"avatar_url":"https://avatars.githubusercontent.com/u/1249193?v=2","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/qutip/qutip/milestones/2","labels_url":"https://api.github.com/repos/qutip/qutip/milestones/2/labels","id":599646,"number":2,"title":"qutip-3.1.0","description":"","creator":{"login":"jrjohansson","id":1198183,"avatar_url":"https://avatars.githubusercontent.com/u/1198183?v=2","gravatar_id":"","url":"https://api.github.com/users/jrjohansson","html_url":"https://github.com/jrjohansson","followers_url":"https://api.github.com/users/jrjohansson/followers","following_url":"https://api.github.com/users/jrjohansson/following{/other_user}","gists_url":"https://api.github.com/users/jrjohansson/gists{/gist_id}","starred_url":"https://api.github.com/users/jrjohansson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrjohansson/subscriptions","organizations_url":"https://api.github.com/users/jrjohansson/orgs","repos_url":"https://api.github.com/users/jrjohansson/repos","events_url":"https://api.github.com/users/jrjohansson/events{/privacy}","received_events_url":"https://api.github.com/users/jrjohansson/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":24,"state":"open","created_at":"2014-03-17T08:27:29Z","updated_at":"2014-11-03T05:36:57Z","due_on":"2014-10-01T07:00:00Z"},"commits_url":"https://api.github.com/repos/qutip/qutip/pulls/249/commits","review_comments_url":"https://api.github.com/repos/qutip/qutip/pulls/249/comments","review_comment_url":"https://api.github.com/repos/qutip/qutip/pulls/comments/{number}","comments_url":"https://api.github.com/repos/qutip/qutip/issues/249/comments","statuses_url":"https://api.github.com/repos/qutip/qutip/statuses/d4b3291ad0e5e1c39511a73b6dc6c2dd3db78d29","head":{"label":"nonhermitian:matplotlib_utils","ref":"matplotlib_utils","sha":"d4b3291ad0e5e1c39511a73b6dc6c2dd3db78d29","user":{"login":"nonhermitian","id":1249193,"avatar_url":"https://avatars.githubusercontent.com/u/1249193?v=2","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},"repo":{"id":26103700,"name":"qutip","full_name":"nonhermitian/qutip","owner":{"login":"nonhermitian","id":1249193,"avatar_url":"https://avatars.githubusercontent.com/u/1249193?v=2","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nonhermitian/qutip","description":"QuTiP: Quantum Toolbox in Python","fork":true,"url":"https://api.github.com/repos/nonhermitian/qutip","forks_url":"https://api.github.com/repos/nonhermitian/qutip/forks","keys_url":"https://api.github.com/repos/nonhermitian/qutip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nonhermitian/qutip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nonhermitian/qutip/teams","hooks_url":"https://api.github.com/repos/nonhermitian/qutip/hooks","issue_events_url":"https://api.github.com/repos/nonhermitian/qutip/issues/events{/number}","events_url":"https://api.github.com/repos/nonhermitian/qutip/events","assignees_url":"https://api.github.com/repos/nonhermitian/qutip/assignees{/user}","branches_url":"https://api.github.com/repos/nonhermitian/qutip/branches{/branch}","tags_url":"https://api.github.com/repos/nonhermitian/qutip/tags","blobs_url":"https://api.github.com/repos/nonhermitian/qutip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nonhermitian/qutip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nonhermitian/qutip/git/refs{/sha}","trees_url":"https://api.github.com/repos/nonhermitian/qutip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nonhermitian/qutip/statuses/{sha}","languages_url":"https://api.github.com/repos/nonhermitian/qutip/languages","stargazers_url":"https://api.github.com/repos/nonhermitian/qutip/stargazers","contributors_url":"https://api.github.com/repos/nonhermitian/qutip/contributors","subscribers_url":"https://api.github.com/repos/nonhermitian/qutip/subscribers","subscription_url":"https://api.github.com/repos/nonhermitian/qutip/subscription","commits_url":"https://api.github.com/repos/nonhermitian/qutip/commits{/sha}","git_commits_url":"https://api.github.com/repos/nonhermitian/qutip/git/commits{/sha}","comments_url":"https://api.github.com/repos/nonhermitian/qutip/comments{/number}","issue_comment_url":"https://api.github.com/repos/nonhermitian/qutip/issues/comments/{number}","contents_url":"https://api.github.com/repos/nonhermitian/qutip/contents/{+path}","compare_url":"https://api.github.com/repos/nonhermitian/qutip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nonhermitian/qutip/merges","archive_url":"https://api.github.com/repos/nonhermitian/qutip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nonhermitian/qutip/downloads","issues_url":"https://api.github.com/repos/nonhermitian/qutip/issues{/number}","pulls_url":"https://api.github.com/repos/nonhermitian/qutip/pulls{/number}","milestones_url":"https://api.github.com/repos/nonhermitian/qutip/milestones{/number}","notifications_url":"https://api.github.com/repos/nonhermitian/qutip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nonhermitian/qutip/labels{/name}","releases_url":"https://api.github.com/repos/nonhermitian/qutip/releases{/id}","created_at":"2014-11-03T04:20:36Z","updated_at":"2014-10-27T04:50:34Z","pushed_at":"2014-11-03T06:15:40Z","git_url":"git://github.com/nonhermitian/qutip.git","ssh_url":"git@github.com:nonhermitian/qutip.git","clone_url":"https://github.com/nonhermitian/qutip.git","svn_url":"https://github.com/nonhermitian/qutip","homepage":null,"size":24384,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qutip:master","ref":"master","sha":"dc39944f17f5ed6b80e546c472ebca814537bf70","user":{"login":"qutip","id":2517630,"avatar_url":"https://avatars.githubusercontent.com/u/2517630?v=2","gravatar_id":"","url":"https://api.github.com/users/qutip","html_url":"https://github.com/qutip","followers_url":"https://api.github.com/users/qutip/followers","following_url":"https://api.github.com/users/qutip/following{/other_user}","gists_url":"https://api.github.com/users/qutip/gists{/gist_id}","starred_url":"https://api.github.com/users/qutip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutip/subscriptions","organizations_url":"https://api.github.com/users/qutip/orgs","repos_url":"https://api.github.com/users/qutip/repos","events_url":"https://api.github.com/users/qutip/events{/privacy}","received_events_url":"https://api.github.com/users/qutip/received_events","type":"Organization","site_admin":false},"repo":{"id":6136261,"name":"qutip","full_name":"qutip/qutip","owner":{"login":"qutip","id":2517630,"avatar_url":"https://avatars.githubusercontent.com/u/2517630?v=2","gravatar_id":"","url":"https://api.github.com/users/qutip","html_url":"https://github.com/qutip","followers_url":"https://api.github.com/users/qutip/followers","following_url":"https://api.github.com/users/qutip/following{/other_user}","gists_url":"https://api.github.com/users/qutip/gists{/gist_id}","starred_url":"https://api.github.com/users/qutip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutip/subscriptions","organizations_url":"https://api.github.com/users/qutip/orgs","repos_url":"https://api.github.com/users/qutip/repos","events_url":"https://api.github.com/users/qutip/events{/privacy}","received_events_url":"https://api.github.com/users/qutip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qutip/qutip","description":"QuTiP: Quantum Toolbox in Python","fork":false,"url":"https://api.github.com/repos/qutip/qutip","forks_url":"https://api.github.com/repos/qutip/qutip/forks","keys_url":"https://api.github.com/repos/qutip/qutip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qutip/qutip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qutip/qutip/teams","hooks_url":"https://api.github.com/repos/qutip/qutip/hooks","issue_events_url":"https://api.github.com/repos/qutip/qutip/issues/events{/number}","events_url":"https://api.github.com/repos/qutip/qutip/events","assignees_url":"https://api.github.com/repos/qutip/qutip/assignees{/user}","branches_url":"https://api.github.com/repos/qutip/qutip/branches{/branch}","tags_url":"https://api.github.com/repos/qutip/qutip/tags","blobs_url":"https://api.github.com/repos/qutip/qutip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qutip/qutip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qutip/qutip/git/refs{/sha}","trees_url":"https://api.github.com/repos/qutip/qutip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qutip/qutip/statuses/{sha}","languages_url":"https://api.github.com/repos/qutip/qutip/languages","stargazers_url":"https://api.github.com/repos/qutip/qutip/stargazers","contributors_url":"https://api.github.com/repos/qutip/qutip/contributors","subscribers_url":"https://api.github.com/repos/qutip/qutip/subscribers","subscription_url":"https://api.github.com/repos/qutip/qutip/subscription","commits_url":"https://api.github.com/repos/qutip/qutip/commits{/sha}","git_commits_url":"https://api.github.com/repos/qutip/qutip/git/commits{/sha}","comments_url":"https://api.github.com/repos/qutip/qutip/comments{/number}","issue_comment_url":"https://api.github.com/repos/qutip/qutip/issues/comments/{number}","contents_url":"https://api.github.com/repos/qutip/qutip/contents/{+path}","compare_url":"https://api.github.com/repos/qutip/qutip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qutip/qutip/merges","archive_url":"https://api.github.com/repos/qutip/qutip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qutip/qutip/downloads","issues_url":"https://api.github.com/repos/qutip/qutip/issues{/number}","pulls_url":"https://api.github.com/repos/qutip/qutip/pulls{/number}","milestones_url":"https://api.github.com/repos/qutip/qutip/milestones{/number}","notifications_url":"https://api.github.com/repos/qutip/qutip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qutip/qutip/labels{/name}","releases_url":"https://api.github.com/repos/qutip/qutip/releases{/id}","created_at":"2012-10-09T06:20:46Z","updated_at":"2014-10-27T04:50:34Z","pushed_at":"2014-11-03T04:08:12Z","git_url":"git://github.com/qutip/qutip.git","ssh_url":"git@github.com:qutip/qutip.git","clone_url":"https://github.com/qutip/qutip.git","svn_url":"https://github.com/qutip/qutip","homepage":null,"size":24384,"stargazers_count":67,"watchers_count":67,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":23,"forks":47,"open_issues":23,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qutip/qutip/pulls/249"},"html":{"href":"https://github.com/qutip/qutip/pull/249"},"issue":{"href":"https://api.github.com/repos/qutip/qutip/issues/249"},"comments":{"href":"https://api.github.com/repos/qutip/qutip/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/qutip/qutip/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/qutip/qutip/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/qutip/qutip/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/qutip/qutip/statuses/d4b3291ad0e5e1c39511a73b6dc6c2dd3db78d29"}}}}