GitHub PullRequestEvent at 2014-07-04 22:41:31
Repository: Markus
Actor: david-yz-liu
Payload: {"action":"closed","number":1562,"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1562","id":17977789,"html_url":"https://github.com/MarkUsProject/Markus/pull/1562","diff_url":"https://github.com/MarkUsProject/Markus/pull/1562.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/1562.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1562","number":1562,"state":"closed","title":"Exclude inactive students from assignment stats","user":{"login":"zhangsu","id":743034,"avatar_url":"https://avatars.githubusercontent.com/u/743034?","gravatar_id":"b668cd93f5eadfa3a7b39ea479f3c532","url":"https://api.github.com/users/zhangsu","html_url":"https://github.com/zhangsu","followers_url":"https://api.github.com/users/zhangsu/followers","following_url":"https://api.github.com/users/zhangsu/following{/other_user}","gists_url":"https://api.github.com/users/zhangsu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangsu/subscriptions","organizations_url":"https://api.github.com/users/zhangsu/orgs","repos_url":"https://api.github.com/users/zhangsu/repos","events_url":"https://api.github.com/users/zhangsu/events{/privacy}","received_events_url":"https://api.github.com/users/zhangsu/received_events","type":"User","site_admin":false},"body":"Inactive students should not be included when calculating the mean and\r\nthe median of the students' marks for an assignment.\r\n\r\nThis also improves the performance of the method, as it no longer\r\nqueries for a list of ActiveRecords (without eagerly loading the\r\nassociations as the current code does) objects but only a list of\r\nintegers.\r\n\r\nThis fixes #1551 partially fixes #1467.\r\n\r\nTested:\r\n- rspec\r\n- rake test:unit\r\n- rake test:functionals\r\n- local server eyeballing","created_at":"2014-07-04T03:01:54Z","updated_at":"2014-07-04T22:41:31Z","closed_at":"2014-07-04T22:41:31Z","merged_at":"2014-07-04T22:41:30Z","merge_commit_sha":"390e3b38dcb9a99f33fe926a3d43f90681ac0cf2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1562/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1562/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1562/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/240258fee8b8855e1f9eab3389df7352fb179731","head":{"label":"zhangsu:inactive_students_mean_median","ref":"inactive_students_mean_median","sha":"240258fee8b8855e1f9eab3389df7352fb179731","user":{"login":"zhangsu","id":743034,"avatar_url":"https://avatars.githubusercontent.com/u/743034?","gravatar_id":"b668cd93f5eadfa3a7b39ea479f3c532","url":"https://api.github.com/users/zhangsu","html_url":"https://github.com/zhangsu","followers_url":"https://api.github.com/users/zhangsu/followers","following_url":"https://api.github.com/users/zhangsu/following{/other_user}","gists_url":"https://api.github.com/users/zhangsu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangsu/subscriptions","organizations_url":"https://api.github.com/users/zhangsu/orgs","repos_url":"https://api.github.com/users/zhangsu/repos","events_url":"https://api.github.com/users/zhangsu/events{/privacy}","received_events_url":"https://api.github.com/users/zhangsu/received_events","type":"User","site_admin":false},"repo":{"id":19521189,"name":"Markus","full_name":"zhangsu/Markus","owner":{"login":"zhangsu","id":743034,"avatar_url":"https://avatars.githubusercontent.com/u/743034?","gravatar_id":"b668cd93f5eadfa3a7b39ea479f3c532","url":"https://api.github.com/users/zhangsu","html_url":"https://github.com/zhangsu","followers_url":"https://api.github.com/users/zhangsu/followers","following_url":"https://api.github.com/users/zhangsu/following{/other_user}","gists_url":"https://api.github.com/users/zhangsu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangsu/subscriptions","organizations_url":"https://api.github.com/users/zhangsu/orgs","repos_url":"https://api.github.com/users/zhangsu/repos","events_url":"https://api.github.com/users/zhangsu/events{/privacy}","received_events_url":"https://api.github.com/users/zhangsu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhangsu/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/zhangsu/Markus","forks_url":"https://api.github.com/repos/zhangsu/Markus/forks","keys_url":"https://api.github.com/repos/zhangsu/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhangsu/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhangsu/Markus/teams","hooks_url":"https://api.github.com/repos/zhangsu/Markus/hooks","issue_events_url":"https://api.github.com/repos/zhangsu/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/zhangsu/Markus/events","assignees_url":"https://api.github.com/repos/zhangsu/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/zhangsu/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/zhangsu/Markus/tags","blobs_url":"https://api.github.com/repos/zhangsu/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhangsu/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhangsu/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhangsu/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhangsu/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/zhangsu/Markus/languages","stargazers_url":"https://api.github.com/repos/zhangsu/Markus/stargazers","contributors_url":"https://api.github.com/repos/zhangsu/Markus/contributors","subscribers_url":"https://api.github.com/repos/zhangsu/Markus/subscribers","subscription_url":"https://api.github.com/repos/zhangsu/Markus/subscription","commits_url":"https://api.github.com/repos/zhangsu/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhangsu/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhangsu/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhangsu/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/zhangsu/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/zhangsu/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhangsu/Markus/merges","archive_url":"https://api.github.com/repos/zhangsu/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhangsu/Markus/downloads","issues_url":"https://api.github.com/repos/zhangsu/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/zhangsu/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/zhangsu/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/zhangsu/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhangsu/Markus/labels{/name}","releases_url":"https://api.github.com/repos/zhangsu/Markus/releases{/id}","created_at":"2014-05-07T04:27:18Z","updated_at":"2014-06-21T18:35:01Z","pushed_at":"2014-07-04T03:32:15Z","git_url":"git://github.com/zhangsu/Markus.git","ssh_url":"git@github.com:zhangsu/Markus.git","clone_url":"https://github.com/zhangsu/Markus.git","svn_url":"https://github.com/zhangsu/Markus","homepage":"http://www.markusproject.org","size":16091,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"cb88585cba16f3c6b99e06b2fb800976aaf0e0b9","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?","gravatar_id":"7fd5c1f7357ff6089fd2ea12640529ab","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?","gravatar_id":"7fd5c1f7357ff6089fd2ea12640529ab","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","created_at":"2010-09-26T16:18:08Z","updated_at":"2014-07-02T05:14:34Z","pushed_at":"2014-07-04T22:41:30Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":41965,"stargazers_count":103,"watchers_count":103,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":124,"mirror_url":null,"open_issues_count":106,"forks":124,"open_issues":106,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1562"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1562"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1562"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1562/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1562/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1562/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/240258fee8b8855e1f9eab3389df7352fb179731"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars.githubusercontent.com/u/3333115?","gravatar_id":"a4ce96e30f6ce10f5935e96666fc9f54","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":55,"commits":9,"additions":344,"deletions":168,"changed_files":19}}