GitHub PullRequestReviewCommentEvent at 2014-05-21 10:09:51
Repository: vsc-base
Actor: JensTimmerman
Payload: {"comment":{"url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/12889047","id":12889047,"diff_hunk":"@@ -154,6 +154,9 @@ def test_deprecated(self):\n         # test whether deprecation works\n         msgre_tpl_error = r\"DEPRECATED\\s*\\(since v%s\\).*%s\" % (max_ver, MSG)\n         self.assertErrorRegex(Exception, msgre_tpl_error, logger.deprecated, MSG, \"1.1\", max_ver)\n+        self.assertErrorRegex(Exception, msgre_tpl_error, logger.deprecated, MSG, \"1.0\", max_ver)\n+        # no deprecation if current version is lower than max version\n+        logger.deprecated(MSG, \"0.9\", max_ver)","path":"test/fancylogger.py","position":6,"original_position":6,"commit_id":"55b361596df753df4f0f6a54b2d395dc3dc082c8","original_commit_id":"55b361596df753df4f0f6a54b2d395dc3dc082c8","user":{"login":"JensTimmerman","id":281523,"avatar_url":"https://avatars.githubusercontent.com/u/281523?","gravatar_id":"bbdebf9137340dfb14f7482c14246844","url":"https://api.github.com/users/JensTimmerman","html_url":"https://github.com/JensTimmerman","followers_url":"https://api.github.com/users/JensTimmerman/followers","following_url":"https://api.github.com/users/JensTimmerman/following{/other_user}","gists_url":"https://api.github.com/users/JensTimmerman/gists{/gist_id}","starred_url":"https://api.github.com/users/JensTimmerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JensTimmerman/subscriptions","organizations_url":"https://api.github.com/users/JensTimmerman/orgs","repos_url":"https://api.github.com/users/JensTimmerman/repos","events_url":"https://api.github.com/users/JensTimmerman/events{/privacy}","received_events_url":"https://api.github.com/users/JensTimmerman/received_events","type":"User","site_admin":false},"body":"how is this different then the line below?","created_at":"2014-05-21T10:09:51Z","updated_at":"2014-05-21T10:09:51Z","html_url":"https://github.com/hpcugent/vsc-base/pull/121#discussion_r12889047","pull_request_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/12889047"},"html":{"href":"https://github.com/hpcugent/vsc-base/pull/121#discussion_r12889047"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/121"}}}}