GitHub PullRequestReviewCommentEvent at 2014-12-26 18:15:42
Repository: framework
Actor: JosephSilber
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/22286397","id":22286397,"diff_hunk":"@@ -1287,20 +1287,18 @@ public function pluck($column)\n \t * Execute the query and get the first result.\n \t *\n \t * @param  array   $columns\n-\t * @return mixed|static\n+\t * @return mixed","path":"src/Illuminate/Database/Query/Builder.php","position":5,"original_position":5,"commit_id":"22772825a16d53bc0c528ec85df6936ad82e9896","original_commit_id":"22772825a16d53bc0c528ec85df6936ad82e9896","user":{"login":"JosephSilber","id":1403741,"avatar_url":"https://avatars.githubusercontent.com/u/1403741?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephSilber","html_url":"https://github.com/JosephSilber","followers_url":"https://api.github.com/users/JosephSilber/followers","following_url":"https://api.github.com/users/JosephSilber/following{/other_user}","gists_url":"https://api.github.com/users/JosephSilber/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSilber/subscriptions","organizations_url":"https://api.github.com/users/JosephSilber/orgs","repos_url":"https://api.github.com/users/JosephSilber/repos","events_url":"https://api.github.com/users/JosephSilber/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSilber/received_events","type":"User","site_admin":false},"body":"I don't think we can. I mean, maybe `stdClass`, but who knows","created_at":"2014-12-26T18:15:42Z","updated_at":"2014-12-26T18:15:42Z","html_url":"https://github.com/laravel/framework/pull/6803#discussion_r22286397","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/6803","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/22286397"},"html":{"href":"https://github.com/laravel/framework/pull/6803#discussion_r22286397"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/6803"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/6803","id":26603330,"html_url":"https://github.com/laravel/framework/pull/6803","diff_url":"https://github.com/laravel/framework/pull/6803.diff","patch_url":"https://github.com/laravel/framework/pull/6803.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/6803","number":6803,"state":"open","locked":false,"title":"[5.0] Return collection from query builder","user":{"login":"JosephSilber","id":1403741,"avatar_url":"https://avatars.githubusercontent.com/u/1403741?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephSilber","html_url":"https://github.com/JosephSilber","followers_url":"https://api.github.com/users/JosephSilber/followers","following_url":"https://api.github.com/users/JosephSilber/following{/other_user}","gists_url":"https://api.github.com/users/JosephSilber/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSilber/subscriptions","organizations_url":"https://api.github.com/users/JosephSilber/orgs","repos_url":"https://api.github.com/users/JosephSilber/repos","events_url":"https://api.github.com/users/JosephSilber/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSilber/received_events","type":"User","site_admin":false},"body":"Eloquent's query builder already returns an Eloquent collection.\r\n\r\nThis change has the query builder itself return an instance of `Illuminate\\Support\\Collection`, so that you can get all of the collection's goodness when doing simple DB queries. Example:\r\n\r\n```php\r\n    DB::table('user')->all()->groupBy('age');\r\n```\r\n\r\n\r\nThe next step would be to pass around the collection object in eloquent's eager loading and relation matching. Right now a simple array is being passed around all over the place, which is extremely inefficient (since arrays are passed by value).\r\n\r\nI didn't want this to be one humongous change, so I've left that for a subsequent PR. I'm really looking forward to that though.","created_at":"2014-12-26T17:18:08Z","updated_at":"2014-12-26T18:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53ca68080098b833d5a17b0b2b623c7fe1358cde","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/6803/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/6803/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/6803/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/22772825a16d53bc0c528ec85df6936ad82e9896","head":{"label":"JosephSilber:query-builder-collection","ref":"query-builder-collection","sha":"22772825a16d53bc0c528ec85df6936ad82e9896","user":{"login":"JosephSilber","id":1403741,"avatar_url":"https://avatars.githubusercontent.com/u/1403741?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephSilber","html_url":"https://github.com/JosephSilber","followers_url":"https://api.github.com/users/JosephSilber/followers","following_url":"https://api.github.com/users/JosephSilber/following{/other_user}","gists_url":"https://api.github.com/users/JosephSilber/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSilber/subscriptions","organizations_url":"https://api.github.com/users/JosephSilber/orgs","repos_url":"https://api.github.com/users/JosephSilber/repos","events_url":"https://api.github.com/users/JosephSilber/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSilber/received_events","type":"User","site_admin":false},"repo":{"id":10986597,"name":"framework","full_name":"JosephSilber/framework","owner":{"login":"JosephSilber","id":1403741,"avatar_url":"https://avatars.githubusercontent.com/u/1403741?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephSilber","html_url":"https://github.com/JosephSilber","followers_url":"https://api.github.com/users/JosephSilber/followers","following_url":"https://api.github.com/users/JosephSilber/following{/other_user}","gists_url":"https://api.github.com/users/JosephSilber/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSilber/subscriptions","organizations_url":"https://api.github.com/users/JosephSilber/orgs","repos_url":"https://api.github.com/users/JosephSilber/repos","events_url":"https://api.github.com/users/JosephSilber/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSilber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosephSilber/framework","description":"","fork":true,"url":"https://api.github.com/repos/JosephSilber/framework","forks_url":"https://api.github.com/repos/JosephSilber/framework/forks","keys_url":"https://api.github.com/repos/JosephSilber/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosephSilber/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosephSilber/framework/teams","hooks_url":"https://api.github.com/repos/JosephSilber/framework/hooks","issue_events_url":"https://api.github.com/repos/JosephSilber/framework/issues/events{/number}","events_url":"https://api.github.com/repos/JosephSilber/framework/events","assignees_url":"https://api.github.com/repos/JosephSilber/framework/assignees{/user}","branches_url":"https://api.github.com/repos/JosephSilber/framework/branches{/branch}","tags_url":"https://api.github.com/repos/JosephSilber/framework/tags","blobs_url":"https://api.github.com/repos/JosephSilber/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosephSilber/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosephSilber/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosephSilber/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosephSilber/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/JosephSilber/framework/languages","stargazers_url":"https://api.github.com/repos/JosephSilber/framework/stargazers","contributors_url":"https://api.github.com/repos/JosephSilber/framework/contributors","subscribers_url":"https://api.github.com/repos/JosephSilber/framework/subscribers","subscription_url":"https://api.github.com/repos/JosephSilber/framework/subscription","commits_url":"https://api.github.com/repos/JosephSilber/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosephSilber/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosephSilber/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosephSilber/framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/JosephSilber/framework/contents/{+path}","compare_url":"https://api.github.com/repos/JosephSilber/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosephSilber/framework/merges","archive_url":"https://api.github.com/repos/JosephSilber/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosephSilber/framework/downloads","issues_url":"https://api.github.com/repos/JosephSilber/framework/issues{/number}","pulls_url":"https://api.github.com/repos/JosephSilber/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/JosephSilber/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/JosephSilber/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosephSilber/framework/labels{/name}","releases_url":"https://api.github.com/repos/JosephSilber/framework/releases{/id}","created_at":"2013-06-27T03:50:55Z","updated_at":"2014-12-26T04:09:19Z","pushed_at":"2014-12-26T17:10:23Z","git_url":"git://github.com/JosephSilber/framework.git","ssh_url":"git@github.com:JosephSilber/framework.git","clone_url":"https://github.com/JosephSilber/framework.git","svn_url":"https://github.com/JosephSilber/framework","homepage":null,"size":13017,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laravel:master","ref":"master","sha":"1500be417d72017d30fc8dd61a0f641e4dad3743","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2014-12-26T17:12:50Z","pushed_at":"2014-12-25T17:40:26Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":47637,"stargazers_count":2894,"watchers_count":2894,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1614,"mirror_url":null,"open_issues_count":234,"forks":1614,"open_issues":234,"watchers":2894,"default_branch":"4.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/6803"},"html":{"href":"https://github.com/laravel/framework/pull/6803"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/6803"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/6803/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/6803/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/6803/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/22772825a16d53bc0c528ec85df6936ad82e9896"}}}}