GitHub PullRequestReviewCommentEvent at 2014-06-11 02:26:18
Repository: expyfun
Actor: Eric89GXL
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/LABSN/expyfun/pulls/comments/13631224","id":13631224,"diff_hunk":"@@ -146,18 +146,18 @@ def _voc_similarity(orig, voc):\n \n \n def test_vocoder():\n-    \"\"\"Test noise and tone vocoding\n+    \"\"\"Test noise, tone, and click vocoding\n     \"\"\"\n     data = np.random.randn(10000)\n     env = np.random.randn(10000)\n     b, a = butter(4, 0.001, 'lowpass')\n     data *= lfilter(b, a, env)\n     # bad limits\n-    assert_raises(ValueError, vocode_ci, data, 44100, freq_lims=(200, 30000))\n+    assert_raises(ValueError, vocode, data, 44100, freq_lims=(200, 30000))\n     # bad mode\n-    assert_raises(ValueError, vocode_ci, data, 44100, mode='foo')\n-    voc1 = vocode_ci(data, 20000, mode='noise', order=2)\n-    voc2 = vocode_ci(data, 20000, mode='tone', order=4, rand_seed=0)\n+    assert_raises(ValueError, vocode, data, 44100, mode='foo')\n+    voc1 = vocode(data, 20000, mode='noise', order=2)\n+    voc2 = vocode(data, 20000, mode='tone', order=4, seed=0)\n     # XXX This is about the best we can do for now...","path":"expyfun/stimuli/tests/test_stimuli.py","position":30,"original_position":30,"commit_id":"7f0d97e24a4546ff1d4db13f36df6876042bd40b","original_commit_id":"7f0d97e24a4546ff1d4db13f36df6876042bd40b","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?","gravatar_id":"bfd1a4884c9621f28ee42e38f652db99","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"Looks okay to me, it's difficult to debug any way other than by ear. I assume you've given them a listen? I was going to suggest you modify an example to make it easy, but then saw you already did it -- should make it easy for me to test!","created_at":"2014-06-11T02:26:18Z","updated_at":"2014-06-11T02:26:18Z","html_url":"https://github.com/LABSN/expyfun/pull/142#discussion_r13631224","pull_request_url":"https://api.github.com/repos/LABSN/expyfun/pulls/142","_links":{"self":{"href":"https://api.github.com/repos/LABSN/expyfun/pulls/comments/13631224"},"html":{"href":"https://github.com/LABSN/expyfun/pull/142#discussion_r13631224"},"pull_request":{"href":"https://api.github.com/repos/LABSN/expyfun/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/LABSN/expyfun/pulls/142","id":16342337,"html_url":"https://github.com/LABSN/expyfun/pull/142","diff_url":"https://github.com/LABSN/expyfun/pull/142.diff","patch_url":"https://github.com/LABSN/expyfun/pull/142.patch","issue_url":"https://api.github.com/repos/LABSN/expyfun/issues/142","number":142,"state":"open","title":"Vocoder 2.0","user":{"login":"drammock","id":1810515,"avatar_url":"https://avatars.githubusercontent.com/u/1810515?","gravatar_id":"dc8b43faadb6b025ad652ebb5c866e5b","url":"https://api.github.com/users/drammock","html_url":"https://github.com/drammock","followers_url":"https://api.github.com/users/drammock/followers","following_url":"https://api.github.com/users/drammock/following{/other_user}","gists_url":"https://api.github.com/users/drammock/gists{/gist_id}","starred_url":"https://api.github.com/users/drammock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drammock/subscriptions","organizations_url":"https://api.github.com/users/drammock/orgs","repos_url":"https://api.github.com/users/drammock/repos","events_url":"https://api.github.com/users/drammock/events{/privacy}","received_events_url":"https://api.github.com/users/drammock/received_events","type":"User","site_admin":false},"body":"The main innovations are twofold: decoupling the vocoder code into several steps (calcuate freq bands, bandpass the signal, generate envelopes, generate carriers, reconstruct), and adding a poisson click train as a built-in option for the carrier.  Have a look, @rkmaddox, and see if (1) it works as expected, and (2) it is organized in a sensible way.  I'm happy to do some refactoring to make this optimally useable.  @Eric89GXL feel free to chime in too.  \r\n\r\nNo new tests as yet, and since I changed the name from vocode_ci to just vocode, the old tests will fail at the moment.","created_at":"2014-05-26T16:28:33Z","updated_at":"2014-06-11T02:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3d68e27cb022aaea917ab4fa18450e8b75989e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LABSN/expyfun/pulls/142/commits","review_comments_url":"https://api.github.com/repos/LABSN/expyfun/pulls/142/comments","review_comment_url":"https://api.github.com/repos/LABSN/expyfun/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LABSN/expyfun/issues/142/comments","statuses_url":"https://api.github.com/repos/LABSN/expyfun/statuses/7f0d97e24a4546ff1d4db13f36df6876042bd40b","head":{"label":"drammock:vocoder-two-point-oh","ref":"vocoder-two-point-oh","sha":"7f0d97e24a4546ff1d4db13f36df6876042bd40b","user":{"login":"drammock","id":1810515,"avatar_url":"https://avatars.githubusercontent.com/u/1810515?","gravatar_id":"dc8b43faadb6b025ad652ebb5c866e5b","url":"https://api.github.com/users/drammock","html_url":"https://github.com/drammock","followers_url":"https://api.github.com/users/drammock/followers","following_url":"https://api.github.com/users/drammock/following{/other_user}","gists_url":"https://api.github.com/users/drammock/gists{/gist_id}","starred_url":"https://api.github.com/users/drammock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drammock/subscriptions","organizations_url":"https://api.github.com/users/drammock/orgs","repos_url":"https://api.github.com/users/drammock/repos","events_url":"https://api.github.com/users/drammock/events{/privacy}","received_events_url":"https://api.github.com/users/drammock/received_events","type":"User","site_admin":false},"repo":{"id":11750256,"name":"expyfun","full_name":"drammock/expyfun","owner":{"login":"drammock","id":1810515,"avatar_url":"https://avatars.githubusercontent.com/u/1810515?","gravatar_id":"dc8b43faadb6b025ad652ebb5c866e5b","url":"https://api.github.com/users/drammock","html_url":"https://github.com/drammock","followers_url":"https://api.github.com/users/drammock/followers","following_url":"https://api.github.com/users/drammock/following{/other_user}","gists_url":"https://api.github.com/users/drammock/gists{/gist_id}","starred_url":"https://api.github.com/users/drammock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drammock/subscriptions","organizations_url":"https://api.github.com/users/drammock/orgs","repos_url":"https://api.github.com/users/drammock/repos","events_url":"https://api.github.com/users/drammock/events{/privacy}","received_events_url":"https://api.github.com/users/drammock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drammock/expyfun","description":"Experimental paradigm functions.","fork":true,"url":"https://api.github.com/repos/drammock/expyfun","forks_url":"https://api.github.com/repos/drammock/expyfun/forks","keys_url":"https://api.github.com/repos/drammock/expyfun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drammock/expyfun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drammock/expyfun/teams","hooks_url":"https://api.github.com/repos/drammock/expyfun/hooks","issue_events_url":"https://api.github.com/repos/drammock/expyfun/issues/events{/number}","events_url":"https://api.github.com/repos/drammock/expyfun/events","assignees_url":"https://api.github.com/repos/drammock/expyfun/assignees{/user}","branches_url":"https://api.github.com/repos/drammock/expyfun/branches{/branch}","tags_url":"https://api.github.com/repos/drammock/expyfun/tags","blobs_url":"https://api.github.com/repos/drammock/expyfun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drammock/expyfun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drammock/expyfun/git/refs{/sha}","trees_url":"https://api.github.com/repos/drammock/expyfun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drammock/expyfun/statuses/{sha}","languages_url":"https://api.github.com/repos/drammock/expyfun/languages","stargazers_url":"https://api.github.com/repos/drammock/expyfun/stargazers","contributors_url":"https://api.github.com/repos/drammock/expyfun/contributors","subscribers_url":"https://api.github.com/repos/drammock/expyfun/subscribers","subscription_url":"https://api.github.com/repos/drammock/expyfun/subscription","commits_url":"https://api.github.com/repos/drammock/expyfun/commits{/sha}","git_commits_url":"https://api.github.com/repos/drammock/expyfun/git/commits{/sha}","comments_url":"https://api.github.com/repos/drammock/expyfun/comments{/number}","issue_comment_url":"https://api.github.com/repos/drammock/expyfun/issues/comments/{number}","contents_url":"https://api.github.com/repos/drammock/expyfun/contents/{+path}","compare_url":"https://api.github.com/repos/drammock/expyfun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drammock/expyfun/merges","archive_url":"https://api.github.com/repos/drammock/expyfun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drammock/expyfun/downloads","issues_url":"https://api.github.com/repos/drammock/expyfun/issues{/number}","pulls_url":"https://api.github.com/repos/drammock/expyfun/pulls{/number}","milestones_url":"https://api.github.com/repos/drammock/expyfun/milestones{/number}","notifications_url":"https://api.github.com/repos/drammock/expyfun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drammock/expyfun/labels{/name}","releases_url":"https://api.github.com/repos/drammock/expyfun/releases{/id}","created_at":"2013-07-29T21:30:54Z","updated_at":"2014-06-11T01:47:47Z","pushed_at":"2014-06-11T01:47:47Z","git_url":"git://github.com/drammock/expyfun.git","ssh_url":"git@github.com:drammock/expyfun.git","clone_url":"https://github.com/drammock/expyfun.git","svn_url":"https://github.com/drammock/expyfun","homepage":null,"size":1898,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LABSN:master","ref":"master","sha":"df43b9cbd6f0b4f61345664b4f2266ebff0ba111","user":{"login":"LABSN","id":3766097,"avatar_url":"https://avatars.githubusercontent.com/u/3766097?","gravatar_id":"06744a9ac7927c43d7721b1bcfdb6188","url":"https://api.github.com/users/LABSN","html_url":"https://github.com/LABSN","followers_url":"https://api.github.com/users/LABSN/followers","following_url":"https://api.github.com/users/LABSN/following{/other_user}","gists_url":"https://api.github.com/users/LABSN/gists{/gist_id}","starred_url":"https://api.github.com/users/LABSN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LABSN/subscriptions","organizations_url":"https://api.github.com/users/LABSN/orgs","repos_url":"https://api.github.com/users/LABSN/repos","events_url":"https://api.github.com/users/LABSN/events{/privacy}","received_events_url":"https://api.github.com/users/LABSN/received_events","type":"Organization","site_admin":false},"repo":{"id":11614571,"name":"expyfun","full_name":"LABSN/expyfun","owner":{"login":"LABSN","id":3766097,"avatar_url":"https://avatars.githubusercontent.com/u/3766097?","gravatar_id":"06744a9ac7927c43d7721b1bcfdb6188","url":"https://api.github.com/users/LABSN","html_url":"https://github.com/LABSN","followers_url":"https://api.github.com/users/LABSN/followers","following_url":"https://api.github.com/users/LABSN/following{/other_user}","gists_url":"https://api.github.com/users/LABSN/gists{/gist_id}","starred_url":"https://api.github.com/users/LABSN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LABSN/subscriptions","organizations_url":"https://api.github.com/users/LABSN/orgs","repos_url":"https://api.github.com/users/LABSN/repos","events_url":"https://api.github.com/users/LABSN/events{/privacy}","received_events_url":"https://api.github.com/users/LABSN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LABSN/expyfun","description":"Experimental paradigm functions.","fork":false,"url":"https://api.github.com/repos/LABSN/expyfun","forks_url":"https://api.github.com/repos/LABSN/expyfun/forks","keys_url":"https://api.github.com/repos/LABSN/expyfun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LABSN/expyfun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LABSN/expyfun/teams","hooks_url":"https://api.github.com/repos/LABSN/expyfun/hooks","issue_events_url":"https://api.github.com/repos/LABSN/expyfun/issues/events{/number}","events_url":"https://api.github.com/repos/LABSN/expyfun/events","assignees_url":"https://api.github.com/repos/LABSN/expyfun/assignees{/user}","branches_url":"https://api.github.com/repos/LABSN/expyfun/branches{/branch}","tags_url":"https://api.github.com/repos/LABSN/expyfun/tags","blobs_url":"https://api.github.com/repos/LABSN/expyfun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LABSN/expyfun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LABSN/expyfun/git/refs{/sha}","trees_url":"https://api.github.com/repos/LABSN/expyfun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LABSN/expyfun/statuses/{sha}","languages_url":"https://api.github.com/repos/LABSN/expyfun/languages","stargazers_url":"https://api.github.com/repos/LABSN/expyfun/stargazers","contributors_url":"https://api.github.com/repos/LABSN/expyfun/contributors","subscribers_url":"https://api.github.com/repos/LABSN/expyfun/subscribers","subscription_url":"https://api.github.com/repos/LABSN/expyfun/subscription","commits_url":"https://api.github.com/repos/LABSN/expyfun/commits{/sha}","git_commits_url":"https://api.github.com/repos/LABSN/expyfun/git/commits{/sha}","comments_url":"https://api.github.com/repos/LABSN/expyfun/comments{/number}","issue_comment_url":"https://api.github.com/repos/LABSN/expyfun/issues/comments/{number}","contents_url":"https://api.github.com/repos/LABSN/expyfun/contents/{+path}","compare_url":"https://api.github.com/repos/LABSN/expyfun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LABSN/expyfun/merges","archive_url":"https://api.github.com/repos/LABSN/expyfun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LABSN/expyfun/downloads","issues_url":"https://api.github.com/repos/LABSN/expyfun/issues{/number}","pulls_url":"https://api.github.com/repos/LABSN/expyfun/pulls{/number}","milestones_url":"https://api.github.com/repos/LABSN/expyfun/milestones{/number}","notifications_url":"https://api.github.com/repos/LABSN/expyfun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LABSN/expyfun/labels{/name}","releases_url":"https://api.github.com/repos/LABSN/expyfun/releases{/id}","created_at":"2013-07-23T17:28:02Z","updated_at":"2014-06-10T16:12:27Z","pushed_at":"2014-06-10T16:12:27Z","git_url":"git://github.com/LABSN/expyfun.git","ssh_url":"git@github.com:LABSN/expyfun.git","clone_url":"https://github.com/LABSN/expyfun.git","svn_url":"https://github.com/LABSN/expyfun","homepage":null,"size":3049,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LABSN/expyfun/pulls/142"},"html":{"href":"https://github.com/LABSN/expyfun/pull/142"},"issue":{"href":"https://api.github.com/repos/LABSN/expyfun/issues/142"},"comments":{"href":"https://api.github.com/repos/LABSN/expyfun/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/LABSN/expyfun/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/LABSN/expyfun/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LABSN/expyfun/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/LABSN/expyfun/statuses/7f0d97e24a4546ff1d4db13f36df6876042bd40b"}}}}