GitHub PullRequestReviewCommentEvent at 2014-01-22 07:40:06
Repository: beego
Actor: pengfei-xue
Payload: {"comment":{"url":"https://api.github.com/repos/astaxie/beego/pulls/comments/9067169","id":9067169,"diff_hunk":"@@ -60,13 +60,15 @@ func (rs *RedisSessionStore) SessionID() string {\n }\n \n func (rs *RedisSessionStore) SessionRelease(w http.ResponseWriter) {\n-\tdefer rs.c.Close()\n+\tc := rs.p.Get()\n+\tdefer c.Close()\n+\n \tb, err := encodeGob(rs.values)\n \tif err != nil {\n \t\treturn\n \t}\n-\trs.c.Do(\"SET\", rs.sid, string(b))\n-\trs.c.Do(\"EXPIRE\", rs.sid, rs.maxlifetime)","path":"session/sess_redis.go","position":22,"original_position":22,"commit_id":"1509a6b681950ff4ee215c83b3207ce281b8e978","original_commit_id":"1509a6b681950ff4ee215c83b3207ce281b8e978","user":{"login":"pengfei-xue","id":1533151,"avatar_url":"https://gravatar.com/avatar/21d42617fab1590b40b81d6353560e2b?d=https%3A%2F%2Fidenticons.github.com%2F6cf584bc488075d9cfdbfab87ecbb868.png&r=x","gravatar_id":"21d42617fab1590b40b81d6353560e2b","url":"https://api.github.com/users/pengfei-xue","html_url":"https://github.com/pengfei-xue","followers_url":"https://api.github.com/users/pengfei-xue/followers","following_url":"https://api.github.com/users/pengfei-xue/following{/other_user}","gists_url":"https://api.github.com/users/pengfei-xue/gists{/gist_id}","starred_url":"https://api.github.com/users/pengfei-xue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengfei-xue/subscriptions","organizations_url":"https://api.github.com/users/pengfei-xue/orgs","repos_url":"https://api.github.com/users/pengfei-xue/repos","events_url":"https://api.github.com/users/pengfei-xue/events{/privacy}","received_events_url":"https://api.github.com/users/pengfei-xue/received_events","type":"User","site_admin":false},"body":"actually, the line behind this can do this, redis command set has parameters to set key's live time.","created_at":"2014-01-22T07:40:06Z","updated_at":"2014-01-22T07:40:06Z","html_url":"https://github.com/astaxie/beego/pull/474#discussion_r9067169","pull_request_url":"https://api.github.com/repos/astaxie/beego/pulls/474","_links":{"self":{"href":"https://api.github.com/repos/astaxie/beego/pulls/comments/9067169"},"html":{"href":"https://github.com/astaxie/beego/pull/474#discussion_r9067169"},"pull_request":{"href":"https://api.github.com/repos/astaxie/beego/pulls/474"}}}}