GitHub PullRequestReviewCommentEvent at 2014-01-03 21:55:33
Repository: WordPress-iOS
Actor: aerych
Payload: {"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/comments/8646206","id":8646206,"diff_hunk":"@@ -202,6 +202,7 @@ - (void)showAddPostView {\n     _addingNewPost = YES;\n     Post *post = [Post newDraftForBlog:self.blog];\n     [self editPost:post];\n+    [self setEditing:NO];","path":"WordPress/Classes/PostsViewController.m","position":4,"original_position":4,"commit_id":"31d626082fbaac620dc6de043f25005cae466b81","original_commit_id":"31d626082fbaac620dc6de043f25005cae466b81","user":{"login":"aerych","id":1435271,"avatar_url":"https://gravatar.com/avatar/e5affa0d045548bb4e46bdd38ee16219?d=https%3A%2F%2Fidenticons.github.com%2Fe7fe5cee4bcff47cd41bdd2a5c48df99.png&r=x","gravatar_id":"e5affa0d045548bb4e46bdd38ee16219","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},"body":"I think `[self setEditing:NO];` is what we want to do. \r\nHowever, `showAddPostView` is only called when the user taps the right navbar button.  The post editor can also be launched via the tab bar.  I'd suggest making this call from `viewWillDisappear:` instead.  That would take care of both situations.  As a bonus, it would also reset editing mode whenever the use changed tabs. ","created_at":"2014-01-03T21:55:33Z","updated_at":"2014-01-03T21:55:33Z","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/998#discussion_r8646206","pull_request_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/998","_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/comments/8646206"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-iOS/pull/998#discussion_r8646206"},"pull_request":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/998"}}}}