GitHub PullRequestReviewCommentEvent at 2014-08-19 18:04:53
Repository: puppet
Actor: hlindberg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/16432018","id":16432018,"diff_hunk":"@@ -28,8 +27,14 @@ def self.default_format\n   end\n \n   def initialize(contents, options = {})\n-    raise ArgumentError.new(\"contents must be a String, got a #{contents.class}\") unless contents.is_a?(String)\n-    @contents = contents\n+    case contents\n+    when String\n+      @contents = StringContents.new(contents);","path":"lib/puppet/file_bucket/file.rb","position":16,"original_position":16,"commit_id":"a6faa072af65d286d977fb9beb579d2eff927042","original_commit_id":"a6faa072af65d286d977fb9beb579d2eff927042","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?v=2","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"body":"parens should be ok even if not needed, semicolon dropped","created_at":"2014-08-19T18:04:53Z","updated_at":"2014-08-19T18:04:53Z","html_url":"https://github.com/puppetlabs/puppet/pull/2982#discussion_r16432018","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2982","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/16432018"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2982#discussion_r16432018"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2982"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2982","id":19869153,"html_url":"https://github.com/puppetlabs/puppet/pull/2982","diff_url":"https://github.com/puppetlabs/puppet/pull/2982.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/2982.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2982","number":2982,"state":"closed","locked":false,"title":"(PUP-1044) Make FileBucket::File use a file when possible","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?v=2","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"body":"This replaces the usage of binread of the entire file contents whenever possible (for computation of checksums, or for returning the size of the data).","created_at":"2014-08-15T21:41:40Z","updated_at":"2014-08-19T18:04:53Z","closed_at":"2014-08-19T16:51:18Z","merged_at":"2014-08-19T16:51:18Z","merge_commit_sha":"990f4988985e3df4a3d76a029ccdd362ace2106a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2982/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2982/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2982/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/a6faa072af65d286d977fb9beb579d2eff927042","head":{"label":"hlindberg:PUP-1044_filebucket-less-memory","ref":"PUP-1044_filebucket-less-memory","sha":"a6faa072af65d286d977fb9beb579d2eff927042","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?v=2","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"repo":{"id":5693635,"name":"puppet","full_name":"hlindberg/puppet","owner":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?v=2","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlindberg/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/hlindberg/puppet","forks_url":"https://api.github.com/repos/hlindberg/puppet/forks","keys_url":"https://api.github.com/repos/hlindberg/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlindberg/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlindberg/puppet/teams","hooks_url":"https://api.github.com/repos/hlindberg/puppet/hooks","issue_events_url":"https://api.github.com/repos/hlindberg/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/hlindberg/puppet/events","assignees_url":"https://api.github.com/repos/hlindberg/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/hlindberg/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/hlindberg/puppet/tags","blobs_url":"https://api.github.com/repos/hlindberg/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlindberg/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlindberg/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlindberg/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlindberg/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/hlindberg/puppet/languages","stargazers_url":"https://api.github.com/repos/hlindberg/puppet/stargazers","contributors_url":"https://api.github.com/repos/hlindberg/puppet/contributors","subscribers_url":"https://api.github.com/repos/hlindberg/puppet/subscribers","subscription_url":"https://api.github.com/repos/hlindberg/puppet/subscription","commits_url":"https://api.github.com/repos/hlindberg/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlindberg/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlindberg/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlindberg/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/hlindberg/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/hlindberg/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlindberg/puppet/merges","archive_url":"https://api.github.com/repos/hlindberg/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlindberg/puppet/downloads","issues_url":"https://api.github.com/repos/hlindberg/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/hlindberg/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/hlindberg/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/hlindberg/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlindberg/puppet/labels{/name}","releases_url":"https://api.github.com/repos/hlindberg/puppet/releases{/id}","created_at":"2012-09-05T21:08:12Z","updated_at":"2014-06-25T01:27:30Z","pushed_at":"2014-08-18T22:48:35Z","git_url":"git://github.com/hlindberg/puppet.git","ssh_url":"git@github.com:hlindberg/puppet.git","clone_url":"https://github.com/hlindberg/puppet.git","svn_url":"https://github.com/hlindberg/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":45687,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"9953b2c67009013894dcd0bcd5fb11409be16f02","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-08-19T10:18:06Z","pushed_at":"2014-08-19T17:50:47Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":107914,"stargazers_count":2558,"watchers_count":2558,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1102,"mirror_url":null,"open_issues_count":36,"forks":1102,"open_issues":36,"watchers":2558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2982"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2982"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2982"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2982/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2982/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2982/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/a6faa072af65d286d977fb9beb579d2eff927042"}}}}