GitHub PullRequestEvent at 2014-12-14 20:32:52
Repository: parse-srcset
Actor: aFarkas
Payload: {"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls/6","id":26038716,"html_url":"https://github.com/baloneysandwiches/parse-srcset/pull/6","diff_url":"https://github.com/baloneysandwiches/parse-srcset/pull/6.diff","patch_url":"https://github.com/baloneysandwiches/parse-srcset/pull/6.patch","issue_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/issues/6","number":6,"state":"open","locked":false,"title":"1x normalization and has1x or hasW flag","user":{"login":"aFarkas","id":188254,"avatar_url":"https://avatars.githubusercontent.com/u/188254?v=3","gravatar_id":"","url":"https://api.github.com/users/aFarkas","html_url":"https://github.com/aFarkas","followers_url":"https://api.github.com/users/aFarkas/followers","following_url":"https://api.github.com/users/aFarkas/following{/other_user}","gists_url":"https://api.github.com/users/aFarkas/gists{/gist_id}","starred_url":"https://api.github.com/users/aFarkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aFarkas/subscriptions","organizations_url":"https://api.github.com/users/aFarkas/orgs","repos_url":"https://api.github.com/users/aFarkas/repos","events_url":"https://api.github.com/users/aFarkas/events{/privacy}","received_events_url":"https://api.github.com/users/aFarkas/received_events","type":"User","site_admin":false},"body":"Although this is not a direct part of the srcset parsing logic, it would help to do some normalization:\r\n\r\n1. Normalize no descriptor to \"1x\"\r\n2. If a srcset uses x descriptors (has no w descriptor), but has no 1x descriptor declared, the normal src attribute should be added to the list of candidates (as 1x).","created_at":"2014-12-14T20:32:51Z","updated_at":"2014-12-14T20:32:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls/6/commits","review_comments_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls/6/comments","review_comment_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls/comments/{number}","comments_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/issues/6/comments","statuses_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/statuses/8798dfa0421e8d3421262a5f054ccf54489764fa","head":{"label":"aFarkas:normalisations","ref":"normalisations","sha":"8798dfa0421e8d3421262a5f054ccf54489764fa","user":{"login":"aFarkas","id":188254,"avatar_url":"https://avatars.githubusercontent.com/u/188254?v=3","gravatar_id":"","url":"https://api.github.com/users/aFarkas","html_url":"https://github.com/aFarkas","followers_url":"https://api.github.com/users/aFarkas/followers","following_url":"https://api.github.com/users/aFarkas/following{/other_user}","gists_url":"https://api.github.com/users/aFarkas/gists{/gist_id}","starred_url":"https://api.github.com/users/aFarkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aFarkas/subscriptions","organizations_url":"https://api.github.com/users/aFarkas/orgs","repos_url":"https://api.github.com/users/aFarkas/repos","events_url":"https://api.github.com/users/aFarkas/events{/privacy}","received_events_url":"https://api.github.com/users/aFarkas/received_events","type":"User","site_admin":false},"repo":{"id":28006427,"name":"parse-srcset","full_name":"aFarkas/parse-srcset","owner":{"login":"aFarkas","id":188254,"avatar_url":"https://avatars.githubusercontent.com/u/188254?v=3","gravatar_id":"","url":"https://api.github.com/users/aFarkas","html_url":"https://github.com/aFarkas","followers_url":"https://api.github.com/users/aFarkas/followers","following_url":"https://api.github.com/users/aFarkas/following{/other_user}","gists_url":"https://api.github.com/users/aFarkas/gists{/gist_id}","starred_url":"https://api.github.com/users/aFarkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aFarkas/subscriptions","organizations_url":"https://api.github.com/users/aFarkas/orgs","repos_url":"https://api.github.com/users/aFarkas/repos","events_url":"https://api.github.com/users/aFarkas/events{/privacy}","received_events_url":"https://api.github.com/users/aFarkas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aFarkas/parse-srcset","description":"javascript parser for the html5 srcset attribute","fork":true,"url":"https://api.github.com/repos/aFarkas/parse-srcset","forks_url":"https://api.github.com/repos/aFarkas/parse-srcset/forks","keys_url":"https://api.github.com/repos/aFarkas/parse-srcset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aFarkas/parse-srcset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aFarkas/parse-srcset/teams","hooks_url":"https://api.github.com/repos/aFarkas/parse-srcset/hooks","issue_events_url":"https://api.github.com/repos/aFarkas/parse-srcset/issues/events{/number}","events_url":"https://api.github.com/repos/aFarkas/parse-srcset/events","assignees_url":"https://api.github.com/repos/aFarkas/parse-srcset/assignees{/user}","branches_url":"https://api.github.com/repos/aFarkas/parse-srcset/branches{/branch}","tags_url":"https://api.github.com/repos/aFarkas/parse-srcset/tags","blobs_url":"https://api.github.com/repos/aFarkas/parse-srcset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aFarkas/parse-srcset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aFarkas/parse-srcset/git/refs{/sha}","trees_url":"https://api.github.com/repos/aFarkas/parse-srcset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aFarkas/parse-srcset/statuses/{sha}","languages_url":"https://api.github.com/repos/aFarkas/parse-srcset/languages","stargazers_url":"https://api.github.com/repos/aFarkas/parse-srcset/stargazers","contributors_url":"https://api.github.com/repos/aFarkas/parse-srcset/contributors","subscribers_url":"https://api.github.com/repos/aFarkas/parse-srcset/subscribers","subscription_url":"https://api.github.com/repos/aFarkas/parse-srcset/subscription","commits_url":"https://api.github.com/repos/aFarkas/parse-srcset/commits{/sha}","git_commits_url":"https://api.github.com/repos/aFarkas/parse-srcset/git/commits{/sha}","comments_url":"https://api.github.com/repos/aFarkas/parse-srcset/comments{/number}","issue_comment_url":"https://api.github.com/repos/aFarkas/parse-srcset/issues/comments/{number}","contents_url":"https://api.github.com/repos/aFarkas/parse-srcset/contents/{+path}","compare_url":"https://api.github.com/repos/aFarkas/parse-srcset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aFarkas/parse-srcset/merges","archive_url":"https://api.github.com/repos/aFarkas/parse-srcset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aFarkas/parse-srcset/downloads","issues_url":"https://api.github.com/repos/aFarkas/parse-srcset/issues{/number}","pulls_url":"https://api.github.com/repos/aFarkas/parse-srcset/pulls{/number}","milestones_url":"https://api.github.com/repos/aFarkas/parse-srcset/milestones{/number}","notifications_url":"https://api.github.com/repos/aFarkas/parse-srcset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aFarkas/parse-srcset/labels{/name}","releases_url":"https://api.github.com/repos/aFarkas/parse-srcset/releases{/id}","created_at":"2014-12-14T20:11:56Z","updated_at":"2014-12-14T20:11:56Z","pushed_at":"2014-12-14T20:17:35Z","git_url":"git://github.com/aFarkas/parse-srcset.git","ssh_url":"git@github.com:aFarkas/parse-srcset.git","clone_url":"https://github.com/aFarkas/parse-srcset.git","svn_url":"https://github.com/aFarkas/parse-srcset","homepage":"","size":208,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"baloneysandwiches:master","ref":"master","sha":"5265a7955e4d0dc433741b7e44a775e5ea205c55","user":{"login":"baloneysandwiches","id":1142025,"avatar_url":"https://avatars.githubusercontent.com/u/1142025?v=3","gravatar_id":"","url":"https://api.github.com/users/baloneysandwiches","html_url":"https://github.com/baloneysandwiches","followers_url":"https://api.github.com/users/baloneysandwiches/followers","following_url":"https://api.github.com/users/baloneysandwiches/following{/other_user}","gists_url":"https://api.github.com/users/baloneysandwiches/gists{/gist_id}","starred_url":"https://api.github.com/users/baloneysandwiches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baloneysandwiches/subscriptions","organizations_url":"https://api.github.com/users/baloneysandwiches/orgs","repos_url":"https://api.github.com/users/baloneysandwiches/repos","events_url":"https://api.github.com/users/baloneysandwiches/events{/privacy}","received_events_url":"https://api.github.com/users/baloneysandwiches/received_events","type":"User","site_admin":false},"repo":{"id":26983706,"name":"parse-srcset","full_name":"baloneysandwiches/parse-srcset","owner":{"login":"baloneysandwiches","id":1142025,"avatar_url":"https://avatars.githubusercontent.com/u/1142025?v=3","gravatar_id":"","url":"https://api.github.com/users/baloneysandwiches","html_url":"https://github.com/baloneysandwiches","followers_url":"https://api.github.com/users/baloneysandwiches/followers","following_url":"https://api.github.com/users/baloneysandwiches/following{/other_user}","gists_url":"https://api.github.com/users/baloneysandwiches/gists{/gist_id}","starred_url":"https://api.github.com/users/baloneysandwiches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baloneysandwiches/subscriptions","organizations_url":"https://api.github.com/users/baloneysandwiches/orgs","repos_url":"https://api.github.com/users/baloneysandwiches/repos","events_url":"https://api.github.com/users/baloneysandwiches/events{/privacy}","received_events_url":"https://api.github.com/users/baloneysandwiches/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baloneysandwiches/parse-srcset","description":"javascript parser for the html5 srcset attribute","fork":false,"url":"https://api.github.com/repos/baloneysandwiches/parse-srcset","forks_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/forks","keys_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/teams","hooks_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/hooks","issue_events_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/issues/events{/number}","events_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/events","assignees_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/assignees{/user}","branches_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/branches{/branch}","tags_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/tags","blobs_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/git/refs{/sha}","trees_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/statuses/{sha}","languages_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/languages","stargazers_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/stargazers","contributors_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/contributors","subscribers_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/subscribers","subscription_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/subscription","commits_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/commits{/sha}","git_commits_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/git/commits{/sha}","comments_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/comments{/number}","issue_comment_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/issues/comments/{number}","contents_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/contents/{+path}","compare_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/merges","archive_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/downloads","issues_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/issues{/number}","pulls_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls{/number}","milestones_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/milestones{/number}","notifications_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/labels{/name}","releases_url":"https://api.github.com/repos/baloneysandwiches/parse-srcset/releases{/id}","created_at":"2014-11-22T00:29:21Z","updated_at":"2014-12-11T00:12:11Z","pushed_at":"2014-12-11T00:06:54Z","git_url":"git://github.com/baloneysandwiches/parse-srcset.git","ssh_url":"git@github.com:baloneysandwiches/parse-srcset.git","clone_url":"https://github.com/baloneysandwiches/parse-srcset.git","svn_url":"https://github.com/baloneysandwiches/parse-srcset","homepage":"","size":208,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls/6"},"html":{"href":"https://github.com/baloneysandwiches/parse-srcset/pull/6"},"issue":{"href":"https://api.github.com/repos/baloneysandwiches/parse-srcset/issues/6"},"comments":{"href":"https://api.github.com/repos/baloneysandwiches/parse-srcset/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/baloneysandwiches/parse-srcset/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/baloneysandwiches/parse-srcset/statuses/8798dfa0421e8d3421262a5f054ccf54489764fa"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":1}}