GitHub PullRequestReviewCommentEvent at 2014-11-21 16:03:15
Repository: Theano
Actor: nouiz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/20722961","id":20722961,"diff_hunk":"@@ -42,6 +42,7 @@ def ind(self, elem):\n \n     ttype = property(lambda self: self.type.ttype)\n     dtype = property(lambda self: self.type.ttype.dtype)\n+    ndim = property(lambda self: self.type.ttype.ndim)","path":"theano/typed_list/basic.py","position":4,"original_position":4,"commit_id":"1d556413082a37bf13026f5a07a9fdd0bc16f134","original_commit_id":"1d556413082a37bf13026f5a07a9fdd0bc16f134","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"Personally, I would +1. Do this case is needed in scan now? It wasn't when\r\nI made that example.\r\n\r\n@lamblin @abergeron what do you think?\r\n\r\nOn Fri, Nov 21, 2014 at 11:00 AM, carriepl <notifications@github.com> wrote:\r\n\r\n> In theano/typed_list/basic.py:\r\n>\r\n> > @@ -42,6 +42,7 @@ def ind(self, elem):\r\n> >\r\n> >      ttype = property(lambda self: self.type.ttype)\r\n> >      dtype = property(lambda self: self.type.ttype.dtype)\r\n> > +    ndim = property(lambda self: self.type.ttype.ndim)\r\n>\r\n> It is needed to have a consistent interface with other types and avoid\r\n> TypedList-specific code every time we need to get the ndim of a variable.\r\n> Can we just return the internal ndim + 1 or would that cause other issues?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/Theano/Theano/pull/2275/files#r20722758>.\r\n>","created_at":"2014-11-21T16:03:15Z","updated_at":"2014-11-21T16:03:15Z","html_url":"https://github.com/Theano/Theano/pull/2275#discussion_r20722961","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/2275","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/20722961"},"html":{"href":"https://github.com/Theano/Theano/pull/2275#discussion_r20722961"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2275"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2275","id":24842702,"html_url":"https://github.com/Theano/Theano/pull/2275","diff_url":"https://github.com/Theano/Theano/pull/2275.diff","patch_url":"https://github.com/Theano/Theano/pull/2275.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2275","number":2275,"state":"open","locked":false,"title":"Fixed bug with TypedList example","user":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"body":"Fixes TypedList example that was failing in /doc/library/typed_list.txt. Also added unit tests for the 2 TypedLists example to prevent this in the future.\r\n\r\nIssue was raised on mailing list : https://groups.google.com/forum/#!topic/theano-users/orib7a6ew-A","created_at":"2014-11-21T14:25:51Z","updated_at":"2014-11-21T16:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29e173b9568036d58021378a2bd421b4b301be17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2275/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2275/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2275/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/1d556413082a37bf13026f5a07a9fdd0bc16f134","head":{"label":"carriepl:TypedList_example","ref":"TypedList_example","sha":"1d556413082a37bf13026f5a07a9fdd0bc16f134","user":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"repo":{"id":18150468,"name":"Theano","full_name":"carriepl/Theano","owner":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carriepl/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/carriepl/Theano","forks_url":"https://api.github.com/repos/carriepl/Theano/forks","keys_url":"https://api.github.com/repos/carriepl/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carriepl/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carriepl/Theano/teams","hooks_url":"https://api.github.com/repos/carriepl/Theano/hooks","issue_events_url":"https://api.github.com/repos/carriepl/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/carriepl/Theano/events","assignees_url":"https://api.github.com/repos/carriepl/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/carriepl/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/carriepl/Theano/tags","blobs_url":"https://api.github.com/repos/carriepl/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carriepl/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carriepl/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/carriepl/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carriepl/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/carriepl/Theano/languages","stargazers_url":"https://api.github.com/repos/carriepl/Theano/stargazers","contributors_url":"https://api.github.com/repos/carriepl/Theano/contributors","subscribers_url":"https://api.github.com/repos/carriepl/Theano/subscribers","subscription_url":"https://api.github.com/repos/carriepl/Theano/subscription","commits_url":"https://api.github.com/repos/carriepl/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/carriepl/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/carriepl/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/carriepl/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/carriepl/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/carriepl/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carriepl/Theano/merges","archive_url":"https://api.github.com/repos/carriepl/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carriepl/Theano/downloads","issues_url":"https://api.github.com/repos/carriepl/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/carriepl/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/carriepl/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/carriepl/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carriepl/Theano/labels{/name}","releases_url":"https://api.github.com/repos/carriepl/Theano/releases{/id}","created_at":"2014-03-26T19:13:49Z","updated_at":"2014-09-10T14:19:14Z","pushed_at":"2014-11-21T14:14:18Z","git_url":"git://github.com/carriepl/Theano.git","ssh_url":"git@github.com:carriepl/Theano.git","clone_url":"https://github.com/carriepl/Theano.git","svn_url":"https://github.com/carriepl/Theano","homepage":"http://www.deeplearning.net/software/theano","size":23415,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"447ab32d9179668eab119749c8ab05384b44c26c","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2014-11-21T14:56:46Z","pushed_at":"2014-11-21T14:56:46Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":42998,"stargazers_count":921,"watchers_count":921,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":346,"mirror_url":null,"open_issues_count":291,"forks":346,"open_issues":291,"watchers":921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2275"},"html":{"href":"https://github.com/Theano/Theano/pull/2275"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2275"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2275/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2275/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2275/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/1d556413082a37bf13026f5a07a9fdd0bc16f134"}}}}