GitHub PullRequestReviewCommentEvent at 2014-09-05 18:11:52
Repository: cmssw
Actor: bendavid
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/17188047","id":17188047,"diff_hunk":"@@ -0,0 +1,25 @@\n+#include \"RecoLocalCalo/EcalRecAlgos/interface/TDecompCholFast.h\"","path":"RecoLocalCalo/EcalRecAlgos/src/TDecompCholFast.cc","position":1,"original_position":1,"commit_id":"69720c9ab25e632140b2bb10d123cd59c9403043","original_commit_id":"69720c9ab25e632140b2bb10d123cd59c9403043","user":{"login":"bendavid","id":4920798,"avatar_url":"https://avatars.githubusercontent.com/u/4920798?v=2","gravatar_id":"51a6a77234d4df53f9d6d25919139f55","url":"https://api.github.com/users/bendavid","html_url":"https://github.com/bendavid","followers_url":"https://api.github.com/users/bendavid/followers","following_url":"https://api.github.com/users/bendavid/following{/other_user}","gists_url":"https://api.github.com/users/bendavid/gists{/gist_id}","starred_url":"https://api.github.com/users/bendavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendavid/subscriptions","organizations_url":"https://api.github.com/users/bendavid/orgs","repos_url":"https://api.github.com/users/bendavid/repos","events_url":"https://api.github.com/users/bendavid/events{/privacy}","received_events_url":"https://api.github.com/users/bendavid/received_events","type":"User","site_admin":false},"body":"The addition of this class is just to allow TDecompChol to be used without reallocating memory when the matrix size changes (again because we need to decompose matrices with all possible sizes <= npulse x npulse) ","created_at":"2014-09-05T18:11:52Z","updated_at":"2014-09-05T18:11:52Z","html_url":"https://github.com/cms-sw/cmssw/pull/5197#discussion_r17188047","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/5197","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/17188047"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/5197#discussion_r17188047"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/5197"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/5197","id":20822405,"html_url":"https://github.com/cms-sw/cmssw/pull/5197","diff_url":"https://github.com/cms-sw/cmssw/pull/5197.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/5197.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/5197","number":5197,"state":"open","locked":false,"title":"New Ecal Local Reconstruction with Multifit","user":{"login":"bendavid","id":4920798,"avatar_url":"https://avatars.githubusercontent.com/u/4920798?v=2","gravatar_id":"51a6a77234d4df53f9d6d25919139f55","url":"https://api.github.com/users/bendavid","html_url":"https://github.com/bendavid","followers_url":"https://api.github.com/users/bendavid/followers","following_url":"https://api.github.com/users/bendavid/following{/other_user}","gists_url":"https://api.github.com/users/bendavid/gists{/gist_id}","starred_url":"https://api.github.com/users/bendavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendavid/subscriptions","organizations_url":"https://api.github.com/users/bendavid/orgs","repos_url":"https://api.github.com/users/bendavid/repos","events_url":"https://api.github.com/users/bendavid/events{/privacy}","received_events_url":"https://api.github.com/users/bendavid/received_events","type":"User","site_admin":false},"body":"Adds additional EcalUncalibRecHitWorker for MultiFit (using Fast NNLS algorithm) and modifies appropriate sequences to activate it by default.\r\n\r\n@argiro @emanueledimarco","created_at":"2014-09-05T17:32:52Z","updated_at":"2014-09-05T18:11:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbcbdede998ee309c43deba2151e09e18079eff9","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/48","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/48/labels","id":703278,"number":48,"title":"Next CMSSW_7_2_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=2","gravatar_id":"c37878ac7a56b492e4f8df2a94abbd49","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":404,"state":"open","created_at":"2014-06-27T09:05:00Z","updated_at":"2014-09-05T17:37:48Z","due_on":"2014-07-29T07:00:00Z"},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/5197/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/5197/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/5197/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/69720c9ab25e632140b2bb10d123cd59c9403043","head":{"label":"bendavid:ecalMultifit_minimal720p4","ref":"ecalMultifit_minimal720p4","sha":"69720c9ab25e632140b2bb10d123cd59c9403043","user":{"login":"bendavid","id":4920798,"avatar_url":"https://avatars.githubusercontent.com/u/4920798?v=2","gravatar_id":"51a6a77234d4df53f9d6d25919139f55","url":"https://api.github.com/users/bendavid","html_url":"https://github.com/bendavid","followers_url":"https://api.github.com/users/bendavid/followers","following_url":"https://api.github.com/users/bendavid/following{/other_user}","gists_url":"https://api.github.com/users/bendavid/gists{/gist_id}","starred_url":"https://api.github.com/users/bendavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendavid/subscriptions","organizations_url":"https://api.github.com/users/bendavid/orgs","repos_url":"https://api.github.com/users/bendavid/repos","events_url":"https://api.github.com/users/bendavid/events{/privacy}","received_events_url":"https://api.github.com/users/bendavid/received_events","type":"User","site_admin":false},"repo":{"id":11927470,"name":"cmssw","full_name":"bendavid/cmssw","owner":{"login":"bendavid","id":4920798,"avatar_url":"https://avatars.githubusercontent.com/u/4920798?v=2","gravatar_id":"51a6a77234d4df53f9d6d25919139f55","url":"https://api.github.com/users/bendavid","html_url":"https://github.com/bendavid","followers_url":"https://api.github.com/users/bendavid/followers","following_url":"https://api.github.com/users/bendavid/following{/other_user}","gists_url":"https://api.github.com/users/bendavid/gists{/gist_id}","starred_url":"https://api.github.com/users/bendavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendavid/subscriptions","organizations_url":"https://api.github.com/users/bendavid/orgs","repos_url":"https://api.github.com/users/bendavid/repos","events_url":"https://api.github.com/users/bendavid/events{/privacy}","received_events_url":"https://api.github.com/users/bendavid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bendavid/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/bendavid/cmssw","forks_url":"https://api.github.com/repos/bendavid/cmssw/forks","keys_url":"https://api.github.com/repos/bendavid/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bendavid/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bendavid/cmssw/teams","hooks_url":"https://api.github.com/repos/bendavid/cmssw/hooks","issue_events_url":"https://api.github.com/repos/bendavid/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/bendavid/cmssw/events","assignees_url":"https://api.github.com/repos/bendavid/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/bendavid/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/bendavid/cmssw/tags","blobs_url":"https://api.github.com/repos/bendavid/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bendavid/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bendavid/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/bendavid/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bendavid/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/bendavid/cmssw/languages","stargazers_url":"https://api.github.com/repos/bendavid/cmssw/stargazers","contributors_url":"https://api.github.com/repos/bendavid/cmssw/contributors","subscribers_url":"https://api.github.com/repos/bendavid/cmssw/subscribers","subscription_url":"https://api.github.com/repos/bendavid/cmssw/subscription","commits_url":"https://api.github.com/repos/bendavid/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/bendavid/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/bendavid/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/bendavid/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/bendavid/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/bendavid/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bendavid/cmssw/merges","archive_url":"https://api.github.com/repos/bendavid/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bendavid/cmssw/downloads","issues_url":"https://api.github.com/repos/bendavid/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/bendavid/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/bendavid/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/bendavid/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bendavid/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/bendavid/cmssw/releases{/id}","created_at":"2013-08-06T15:27:02Z","updated_at":"2014-06-18T22:53:47Z","pushed_at":"2014-09-05T17:16:03Z","git_url":"git://github.com/bendavid/cmssw.git","ssh_url":"git@github.com:bendavid/cmssw.git","clone_url":"https://github.com/bendavid/cmssw.git","svn_url":"https://github.com/bendavid/cmssw","homepage":"cms-sw.github.io/cmssw","size":469316,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_2_X","ref":"CMSSW_7_2_X","sha":"6dcc154d65ca487e4ed15e44b253780412ebfd59","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=2","gravatar_id":"d5b5dd8d1e3a16502b38562e08e0635c","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=2","gravatar_id":"d5b5dd8d1e3a16502b38562e08e0635c","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2014-09-04T23:25:34Z","pushed_at":"2014-09-05T17:33:03Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"cms-sw.github.io/cmssw","size":729824,"stargazers_count":372,"watchers_count":372,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":999,"mirror_url":null,"open_issues_count":99,"forks":999,"open_issues":99,"watchers":372,"default_branch":"CMSSW_7_2_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/5197"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/5197"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/5197"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/5197/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/5197/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/5197/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/69720c9ab25e632140b2bb10d123cd59c9403043"}}}}