GitHub PullRequestReviewCommentEvent at 2014-08-18 14:40:40
Repository: Theano
Actor: nouiz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/16356638","id":16356638,"diff_hunk":"@@ -574,6 +575,14 @@ def fill(self, value):\n class TensorVariable(_tensor_py_operators, Variable):\n     \"\"\"Subclass to add the tensor operators to the basic `Variable` class.\"\"\"\n \n+    def __init__(self, type, name=None):\n+        if (config.warn_float64 and type == 'float64'):","path":"theano/tensor/var.py","position":13,"original_position":13,"commit_id":"e8a626dbb2b49d4ada6a70263faab7f9bfa798b5","original_commit_id":"e8a626dbb2b49d4ada6a70263faab7f9bfa798b5","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=2","gravatar_id":"082c34b6c1544c177cb7a66609360089","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"need to call: `super(TensorVariable, self).__init__(type, owner=owner, index=index, name=name)`\r\n\r\nand change fct signature to:\r\n`    def __init__(self, type, owner=None, index=None, name=None):`\r\n","created_at":"2014-08-18T14:40:40Z","updated_at":"2014-08-18T14:40:40Z","html_url":"https://github.com/Theano/Theano/pull/2036#discussion_r16356638","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/2036","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/16356638"},"html":{"href":"https://github.com/Theano/Theano/pull/2036#discussion_r16356638"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2036"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2036","id":19816748,"html_url":"https://github.com/Theano/Theano/pull/2036","diff_url":"https://github.com/Theano/Theano/pull/2036.diff","patch_url":"https://github.com/Theano/Theano/pull/2036.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2036","number":2036,"state":"open","locked":false,"title":"warn float64 variables.","user":{"login":"Tanjay94","id":7513923,"avatar_url":"https://avatars.githubusercontent.com/u/7513923?v=2","gravatar_id":"dcce93a99462cdc70ff7e95273c30250","url":"https://api.github.com/users/Tanjay94","html_url":"https://github.com/Tanjay94","followers_url":"https://api.github.com/users/Tanjay94/followers","following_url":"https://api.github.com/users/Tanjay94/following{/other_user}","gists_url":"https://api.github.com/users/Tanjay94/gists{/gist_id}","starred_url":"https://api.github.com/users/Tanjay94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tanjay94/subscriptions","organizations_url":"https://api.github.com/users/Tanjay94/orgs","repos_url":"https://api.github.com/users/Tanjay94/repos","events_url":"https://api.github.com/users/Tanjay94/events{/privacy}","received_events_url":"https://api.github.com/users/Tanjay94/received_events","type":"User","site_admin":false},"body":"Added float64 warning to TensorVariable class.","created_at":"2014-08-14T21:34:35Z","updated_at":"2014-08-18T14:40:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6ed0b48ac4924ccb81ed5988be28d53c3c31a05","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2036/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2036/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2036/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/e8a626dbb2b49d4ada6a70263faab7f9bfa798b5","head":{"label":"Tanjay94:TV","ref":"TV","sha":"e8a626dbb2b49d4ada6a70263faab7f9bfa798b5","user":{"login":"Tanjay94","id":7513923,"avatar_url":"https://avatars.githubusercontent.com/u/7513923?v=2","gravatar_id":"dcce93a99462cdc70ff7e95273c30250","url":"https://api.github.com/users/Tanjay94","html_url":"https://github.com/Tanjay94","followers_url":"https://api.github.com/users/Tanjay94/followers","following_url":"https://api.github.com/users/Tanjay94/following{/other_user}","gists_url":"https://api.github.com/users/Tanjay94/gists{/gist_id}","starred_url":"https://api.github.com/users/Tanjay94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tanjay94/subscriptions","organizations_url":"https://api.github.com/users/Tanjay94/orgs","repos_url":"https://api.github.com/users/Tanjay94/repos","events_url":"https://api.github.com/users/Tanjay94/events{/privacy}","received_events_url":"https://api.github.com/users/Tanjay94/received_events","type":"User","site_admin":false},"repo":{"id":19622558,"name":"Theano","full_name":"Tanjay94/Theano","owner":{"login":"Tanjay94","id":7513923,"avatar_url":"https://avatars.githubusercontent.com/u/7513923?v=2","gravatar_id":"dcce93a99462cdc70ff7e95273c30250","url":"https://api.github.com/users/Tanjay94","html_url":"https://github.com/Tanjay94","followers_url":"https://api.github.com/users/Tanjay94/followers","following_url":"https://api.github.com/users/Tanjay94/following{/other_user}","gists_url":"https://api.github.com/users/Tanjay94/gists{/gist_id}","starred_url":"https://api.github.com/users/Tanjay94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tanjay94/subscriptions","organizations_url":"https://api.github.com/users/Tanjay94/orgs","repos_url":"https://api.github.com/users/Tanjay94/repos","events_url":"https://api.github.com/users/Tanjay94/events{/privacy}","received_events_url":"https://api.github.com/users/Tanjay94/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tanjay94/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/Tanjay94/Theano","forks_url":"https://api.github.com/repos/Tanjay94/Theano/forks","keys_url":"https://api.github.com/repos/Tanjay94/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tanjay94/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tanjay94/Theano/teams","hooks_url":"https://api.github.com/repos/Tanjay94/Theano/hooks","issue_events_url":"https://api.github.com/repos/Tanjay94/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Tanjay94/Theano/events","assignees_url":"https://api.github.com/repos/Tanjay94/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Tanjay94/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Tanjay94/Theano/tags","blobs_url":"https://api.github.com/repos/Tanjay94/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tanjay94/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tanjay94/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tanjay94/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tanjay94/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Tanjay94/Theano/languages","stargazers_url":"https://api.github.com/repos/Tanjay94/Theano/stargazers","contributors_url":"https://api.github.com/repos/Tanjay94/Theano/contributors","subscribers_url":"https://api.github.com/repos/Tanjay94/Theano/subscribers","subscription_url":"https://api.github.com/repos/Tanjay94/Theano/subscription","commits_url":"https://api.github.com/repos/Tanjay94/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tanjay94/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tanjay94/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tanjay94/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/Tanjay94/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Tanjay94/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tanjay94/Theano/merges","archive_url":"https://api.github.com/repos/Tanjay94/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tanjay94/Theano/downloads","issues_url":"https://api.github.com/repos/Tanjay94/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Tanjay94/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Tanjay94/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Tanjay94/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tanjay94/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Tanjay94/Theano/releases{/id}","created_at":"2014-05-09T19:17:47Z","updated_at":"2014-06-18T19:00:39Z","pushed_at":"2014-08-18T14:11:03Z","git_url":"git://github.com/Tanjay94/Theano.git","ssh_url":"git@github.com:Tanjay94/Theano.git","clone_url":"https://github.com/Tanjay94/Theano.git","svn_url":"https://github.com/Tanjay94/Theano","homepage":"http://www.deeplearning.net/software/theano","size":22392,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"0037c724e09c805e634e454942cf3386ce75c938","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=2","gravatar_id":"f2c9cd1d69fe2fb37115161c5b1e1708","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=2","gravatar_id":"f2c9cd1d69fe2fb37115161c5b1e1708","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2014-08-17T06:39:04Z","pushed_at":"2014-08-15T03:20:00Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":37505,"stargazers_count":748,"watchers_count":748,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":272,"mirror_url":null,"open_issues_count":250,"forks":272,"open_issues":250,"watchers":748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2036"},"html":{"href":"https://github.com/Theano/Theano/pull/2036"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2036"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2036/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2036/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2036/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/e8a626dbb2b49d4ada6a70263faab7f9bfa798b5"}}}}