GitHub PushEvent at 2014-11-03 20:02:52
Repository: webkit
Actor: hubot
Payload: {"shas":[["22eed481350859d12092df26d78ec33cd1dbb6c4","bafa56cbbb9983b1da0b7baeb46608360c3b7cbe@apple.com","Persist the page's muted state across web process crashes.\nhttps://bugs.webkit.org/show_bug.cgi?id=138195\n\nReviewed by Anders Carlsson.\n\nStore the Page's muted state in WebPageCreationParameters so that state can be properly\nrestored after recovering from a crash in the web process.\n\n* Shared/WebPageCreationParameters.cpp:\n(WebKit::WebPageCreationParameters::encode):\n(WebKit::WebPageCreationParameters::decode):\n* Shared/WebPageCreationParameters.h:\n* UIProcess/WebPageProxy.cpp:\n(WebKit::WebPageProxy::WebPageProxy):\nInitialize m_muted.\n(WebKit::WebPageProxy::setMuted):\nUpdate m_muted.\n(WebKit::WebPageProxy::creationParameters):\nSet the muted data member in WebPageCreationParameters.\n* UIProcess/WebPageProxy.h:\n* WebProcess/WebPage/WebPage.cpp:\n(WebKit::WebPage::WebPage):\nInitialize the page's muted state with the muted value from WebPageCreationParameters.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175473 268f45cc-cd09-0410-ab3c-d52691b4dbfc","adachan@apple.com",true],["d6164e0fc7738cd26bcb37e67896d43d98730e1e","fdaf4f444665d7fe9551ea4df3463be25e3fb623@apple.com","Implement action menus for editable text\nhttps://bugs.webkit.org/show_bug.cgi?id=138284\n-and corresponding-\nrdar://problem/18742323\n\nReviewed by Tim Horton.\n\nNew item type for paste.\n* Shared/API/c/WKActionMenuItemTypes.h:\n\nNew menu type for editable text.\n* Shared/API/c/WKActionMenuTypes.h:\n* UIProcess/mac/WKActionMenuController.mm:\n\nwillOpenMenu should select text for both regular text menus and editable text \nmenus. \n(-[WKActionMenuController willOpenMenu:withEvent:]):\n\nDefault items for editable text.\n(-[WKActionMenuController _defaultMenuItemsForEditableText]):\n(-[WKActionMenuController _paste:]):\n(-[WKActionMenuController _createActionMenuItemForTag:]):\n\nNew method _hitTestResultForStage:(MenuUpdateStage)stage will figure out whether \nwe can use the WebHitTestResult from the ActionMenuHitTestResult or if we have to \nuse the potentially out-of-date WebHitTestResult that is cached on WebPageProxy. \nAn important difference between these results is that the ActionMenuHitTest \nresult, in addition to being more recent and accurate, also now includes shadow \ncontent, which affects some editable regions on important sites such as \nbugs.webkit.org and nytimes.com.\n(-[WKActionMenuController _defaultMenuItems:]):\n(-[WKActionMenuController _updateActionMenuItemsForStage:]):\n(imageForResource:name::if): Deleted.\n\nAllow shadow content in action menu hit testing.\n* WebProcess/WebPage/mac/WebPageMac.mm:\n(WebKit::WebPage::performActionMenuHitTestAtLocation):\n(WebKit::WebPage::selectLookupTextAtLocation):\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175474 268f45cc-cd09-0410-ab3c-d52691b4dbfc","bdakin@apple.com",true],["65b85eb7ad8d1a46ff2a02193bf6818b70bb62d6","8f3a129bc83673565f000899a2a2ef93d9111231@apple.com","RenderLayerModelObject shouldn't need a pre-destructor hook.\n<https://webkit.org/b/138314>\n\nReviewed by Antti Koivisto.\n\nMove code from the willBeDestroyed() pre-destructor hook to the regular\n~RenderLayerModelObject() destructor.\n\nWe just need to unregister the renderer from the FrameView's set of\nviewport-constrained objects. That doesn't require being able to walk\nthe render tree or call virtuals, which is the main reason you'd use\nwillBeDestroyed().\n\n* rendering/RenderLayerModelObject.cpp:\n(WebCore::RenderLayerModelObject::~RenderLayerModelObject):\n(WebCore::RenderLayerModelObject::willBeDestroyed): Deleted.\n* rendering/RenderLayerModelObject.h:\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175475 268f45cc-cd09-0410-ab3c-d52691b4dbfc","akling@apple.com",true],["0c33052e7b1980851ba1fccb901bd1e06a67dc1e","f6a40302e70d3875826ddafd7e450bcee2d7be56@apple.com","Rename FindIndicator{Window} to TextIndicator{Window}\nhttps://bugs.webkit.org/show_bug.cgi?id=138302\n<rdar://problem/18855190>\n\nReviewed by Anders Carlsson.\n\nRename FindIndicator{Window} to TextIndicator{Window} (and related),\nbecause it will soon be used to indicate ranges of text that are not\nnecessarily find-in-page results.\n\nFindController still has things named 'findIndicator' internally,\nand I left the API alone (because all the API bits are actually find-specific),\nbut the actual FindIndicator/Window and the message to set it up, etc. are all\nnow called Text*.\n\n* CMakeLists.txt:\n* UIProcess/API/mac/WKView.mm:\n* UIProcess/API/mac/WKViewInternal.h:\n* UIProcess/PageClient.h:\n* UIProcess/TextIndicator.cpp: Renamed from Source/WebKit2/UIProcess/FindIndicator.cpp.\n* UIProcess/TextIndicator.h: Renamed from Source/WebKit2/UIProcess/FindIndicator.h.\n* UIProcess/WebPageProxy.cpp:\n* UIProcess/WebPageProxy.h:\n* UIProcess/WebPageProxy.messages.in:\n* UIProcess/ios/PageClientImplIOS.h:\n* UIProcess/ios/PageClientImplIOS.mm:\n* UIProcess/ios/WKContentView.h:\n* UIProcess/mac/PageClientImpl.h:\n* UIProcess/mac/PageClientImpl.mm:\n* UIProcess/mac/TextIndicatorWindow.h: Renamed from Source/WebKit2/UIProcess/mac/FindIndicatorWindow.h.\n* UIProcess/mac/TextIndicatorWindow.mm: Renamed from Source/WebKit2/UIProcess/mac/FindIndicatorWindow.mm.\n* WebKit2.xcodeproj/project.pbxproj:\n* WebProcess/WebPage/FindController.cpp:\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175476 268f45cc-cd09-0410-ab3c-d52691b4dbfc","timothy_horton@apple.com",true],["35a97b4640339e22510fda04a1e80d03f3406555","ac78b022715c5b8357b4dca8045e8463b4de2124@apple.com","REGRESSION: Using a media element changes window.name\nhttps://bugs.webkit.org/show_bug.cgi?id=138278\nrdar://problem/18704134\n\nApply the same fix to mediaControlsBase.js. I do not know who uses this file, but\nthere is no reason to have the bug there.\n\n* Modules/mediacontrols/mediaControlsBase.js:\n(Controller.prototype.addVideoListeners):\n(Controller.prototype.removeVideoListeners):\n(Controller.prototype.disconnectControls):\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175477 268f45cc-cd09-0410-ab3c-d52691b4dbfc","ap@apple.com",true],["0d18c2fcd1ba0eb6abb68bb82fe73212344a82c1","10e9cf00654b96e207b0048d60c4681488a29178@webkit.org","Web Inspector: ALTERNATE_DISPATCHERS Let the frontend know about extra agents\nhttps://bugs.webkit.org/show_bug.cgi?id=138236\n\nReviewed by Brian Burg.\n\nSource/JavaScriptCore:\n\nInform the frontend about any extra domains the backend may have\nabove and beyond the default list of domains for the debuggable type.\nThis approach means there is almost no cost to normal debugging.\nWhen a JSContext is debugged with extra agents, a message is sent\nto the frontend letting it know which domains to then activate,\nand perform any initialization work that may be required.\n\n* inspector/InspectorAgentBase.h:\n(Inspector::InspectorAgentBase::domainName):\n* inspector/InspectorAgentRegistry.cpp:\n(Inspector::InspectorAgentRegistry::appendExtraAgent):\n* inspector/InspectorAgentRegistry.h:\n* inspector/scripts/codegen/generator_templates.py:\nProvide a way to get a list of just the extra domains.\nTo aggregate this list provide a different \"append\"\nspecifically for extra agents.\n\n* inspector/JSGlobalObjectInspectorController.h:\n* inspector/JSGlobalObjectInspectorController.cpp:\n(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):\n(Inspector::JSGlobalObjectInspectorController::connectFrontend):\nWhen a frontend connects, inform it of the extra domains.\n\n* inspector/protocol/Inspector.json:\n* inspector/agents/InspectorAgent.h:\n* inspector/agents/InspectorAgent.cpp:\n(Inspector::InspectorAgent::enable):\n(Inspector::InspectorAgent::activateExtraDomains):\nSend an event with the extra domains to activate.\n\nSource/WebInspectorUI:\n\n* UserInterface/Protocol/InspectorBackend.js:\n(InspectorBackendClass.prototype.activateDomain):\n* UserInterface/Protocol/InspectorObserver.js:\n(WebInspector.InspectorObserver.prototype.activateExtraDomains):\n* UserInterface/Base/Object.js:\n* UserInterface/Base/Test.js:\n* UserInterface/Base/Main.js:\n(WebInspector.activateExtraDomains):\nDefault state is that there are no extra domains. When extra domains\nare activated, some agents need to be re-initialized. Dispatch a\nmodel event so views also know to re-initialize.\n\n* UserInterface/Controllers/ApplicationCacheManager.js:\n(WebInspector.ApplicationCacheManager.prototype._mainResourceDidChange):\n* UserInterface/Controllers/DOMTreeManager.js:\nBe more careful about direct agent use during main resource changes.\nThat can happen with a JSContext extended with a Page agent.\n\n* UserInterface/Controllers/FrameResourceManager.js:\n(WebInspector.FrameResourceManager):\n(WebInspector.FrameResourceManager.prototype._mainFrameDidChange):\n(WebInspector.FrameResourceManager.prototype._extraDomainsActivated):\n* UserInterface/Controllers/StorageManager.js:\n(WebInspector.StorageManager):\n(WebInspector.StorageManager.prototype._databaseForIdentifier):\n(WebInspector.StorageManager.prototype._extraDomainsActivated):\nIt is possible new window.FooAgent's are available. Perform expected\ninitialization re-checking if the agents are now available.\n\n* UserInterface/Models/CSSCompletions.js:\nAvoid re-initialization if we already did it. This should never\nhappen but this is just to be safe.\n\n* UserInterface/Views/ResourceSidebarPanel.js:\n(WebInspector.ResourceSidebarPanel):\n(WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):\nDon't disallow expandable tree elements if this is a JSContext with\nextra domains. If that JSContext has resources, we would have been\nunable to see child resources.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175478 268f45cc-cd09-0410-ab3c-d52691b4dbfc","joepeck@webkit.org",true],["fd26593ba264a78f21784deed7f81efab2884f03","10e9cf00654b96e207b0048d60c4681488a29178@webkit.org","Web Inspector: ObjC Protocol Interfaces should throw exceptions for nil arguments\nhttps://bugs.webkit.org/show_bug.cgi?id=138221\n\nReviewed by Timothy Hatcher.\n\nThe RWIProtocol APIs will now raise exceptions when:\n\n  - any properties are set on a type with a nil value or key (handled by RWIProtocolJSONObject)\n  - required parameters in type constructors have nil value\n  - required or optional command return parameters have nil values\n  - required or optional event parameters have nil values\n\nThe exceptions include the name of the field when possible.\n\n* inspector/scripts/codegen/generate_objective_c.py:\n(ObjCGenerator.is_type_objc_pointer_type):\nProvide a quick check to see if type would be a pointer or not\nin the ObjC API. Enums for example are not pointers in the API\nbecause we manage converting them to/from strings.\n\n* inspector/scripts/codegen/generate_objective_c_backend_dispatcher_implementation.py:\n(ObjectiveCConfigurationImplementationGenerator._generate_success_block_for_command):\n* inspector/scripts/codegen/generate_objective_c_frontend_dispatcher_implementation.py:\n(ObjectiveCFrontendDispatcherImplementationGenerator._generate_event):\n* inspector/scripts/codegen/generate_objective_c_types_implementation.py:\n(ObjectiveCTypesImplementationGenerator._generate_init_method_for_required_members):\n(ObjectiveCTypesImplementationGenerator._generate_setter_for_member):\nThrow exceptions when nil values are disallowed.\n\n* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:\n* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:\n* inspector/scripts/tests/expected/events-with-optional-parameters.json-result:\n* inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:\n* inspector/scripts/tests/expected/type-declaration-object-type.json-result:\n* inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:\nRebaseline tests which include the exception raise calls.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175479 268f45cc-cd09-0410-ab3c-d52691b4dbfc","joepeck@webkit.org",true],["ad73485e1889a9b49e4f1cf7661f63c6503b5853","a82ad16292c9f3b890b7b13c336ff95f6bd02623@webkit.org","[GTK] Unreviewed gardening. Rebaseline after r175259.\nhttps://bugs.webkit.org/show_bug.cgi?id=138317\n\nRebaseline pending test expectations affected by r175259.\n\nPatch by Lorenzo Tilve <ltilve@igalia.com> on 2014-11-03\n\n* platform/gtk/css1/box_properties/border_bottom-expected.txt:\n* platform/gtk/css1/box_properties/border_top-expected.txt:\n* platform/gtk/css1/formatting_model/inline_elements-expected.txt:\n* platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:\n* platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:\n* platform/gtk/svg/custom/bug45331-expected.txt:\n* platform/gtk/svg/custom/path-bad-data-expected.txt:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175480 268f45cc-cd09-0410-ab3c-d52691b4dbfc","commit-queue@webkit.org",true],["9050a599255e93e937d4d6d58fca23237a3499f3","083d44ce61b1f946a3aa6fbd704954e0195d0658@apple.com","Move -webkit-shape-outside to the new StyleBuilder\nhttps://bugs.webkit.org/show_bug.cgi?id=138296\n\nReviewed by Zoltan Horvath.\n\nMove -webkit-shape-outside to the new StyleBuilder, using custom\ncode as it does not always call setShapeOutside().\n\nNo new tests, no behavior change.\n\n* css/CSSPropertyNames.in:\n* css/DeprecatedStyleBuilder.cpp:\n(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):\n(WebCore::ApplyPropertyShape::setValue): Deleted.\n(WebCore::ApplyPropertyShape::applyValue): Deleted.\n(WebCore::ApplyPropertyShape::createHandler): Deleted.\n* css/StyleBuilderCustom.h:\n(WebCore::StyleBuilderFunctions::applyValueWebkitShapeOutside):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175481 268f45cc-cd09-0410-ab3c-d52691b4dbfc","cdumez@apple.com",true],["5607dd335cd47779e63e330ce25bd00803e5167c","b0adc04ab6a535a1bcaa5c698b10e7c7d6f012d7@webkit.org","URTBF after r175476 to make GTK and EFL build happy.\n\n* UIProcess/API/gtk/PageClientImpl.cpp:\n(WebKit::PageClientImpl::setTextIndicator):\n(WebKit::PageClientImpl::setFindIndicator): Deleted.\n* UIProcess/API/gtk/PageClientImpl.h:\n* UIProcess/CoordinatedGraphics/WebView.cpp:\n(WebKit::WebView::setTextIndicator):\n(WebKit::WebView::setFindIndicator): Deleted.\n* UIProcess/CoordinatedGraphics/WebView.h:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@175482 268f45cc-cd09-0410-ab3c-d52691b4dbfc","ossy@webkit.org",true]],"size":10,"ref":"refs/heads/master","head":"5607dd335cd47779e63e330ce25bd00803e5167c"}