GitHub PullRequestReviewCommentEvent at 2014-12-18 23:48:24
Repository: news-publisher
Actor: adamcrown
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/biola/news-publisher/pulls/comments/22080857","id":22080857,"diff_hunk":"@@ -2,10 +2,13 @@\n   .panel-heading\n     strong Relationships\n   .panel-body\n-    = form_for @event do |f|\n+    = permitted_form_for @event do |f|\n       .form-group\n         = label_tag :related_objects_string\n-        = text_field_tag :related_objects_string, @event.related_object_tags.join('|'), class: 'form-control tags-input'\n+        - if @event.ws_source.downcase == 'wcms' || @event.ws_source.blank?","path":"app/views/events/pages/_relationships.html.slim","position":9,"original_position":9,"commit_id":"9f384f6fac704130f35fffaad3a83ea9c3555899","original_commit_id":"9f384f6fac704130f35fffaad3a83ea9c3555899","user":{"login":"adamcrown","id":277306,"avatar_url":"https://avatars.githubusercontent.com/u/277306?v=3","gravatar_id":"","url":"https://api.github.com/users/adamcrown","html_url":"https://github.com/adamcrown","followers_url":"https://api.github.com/users/adamcrown/followers","following_url":"https://api.github.com/users/adamcrown/following{/other_user}","gists_url":"https://api.github.com/users/adamcrown/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcrown/subscriptions","organizations_url":"https://api.github.com/users/adamcrown/orgs","repos_url":"https://api.github.com/users/adamcrown/repos","events_url":"https://api.github.com/users/adamcrown/events{/privacy}","received_events_url":"https://api.github.com/users/adamcrown/received_events","type":"User","site_admin":false},"body":"`event.ws_source == 'WCMS'` is getting used a lot. Sometimes downcasing, sometimes not. It's probably good to make this reusable. We could reopen the Event class and add a method or maybe just create a helper for where it's being used in the views. Or even an Event presenter.","created_at":"2014-12-18T23:48:24Z","updated_at":"2014-12-18T23:48:24Z","html_url":"https://github.com/biola/news-publisher/pull/22#discussion_r22080857","pull_request_url":"https://api.github.com/repos/biola/news-publisher/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/biola/news-publisher/pulls/comments/22080857"},"html":{"href":"https://github.com/biola/news-publisher/pull/22#discussion_r22080857"},"pull_request":{"href":"https://api.github.com/repos/biola/news-publisher/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/biola/news-publisher/pulls/22","id":26338513,"html_url":"https://github.com/biola/news-publisher/pull/22","diff_url":"https://github.com/biola/news-publisher/pull/22.diff","patch_url":"https://github.com/biola/news-publisher/pull/22.patch","issue_url":"https://api.github.com/repos/biola/news-publisher/issues/22","number":22,"state":"open","locked":false,"title":"Ws event worker","user":{"login":"rift137","id":1801619,"avatar_url":"https://avatars.githubusercontent.com/u/1801619?v=3","gravatar_id":"","url":"https://api.github.com/users/rift137","html_url":"https://github.com/rift137","followers_url":"https://api.github.com/users/rift137/followers","following_url":"https://api.github.com/users/rift137/following{/other_user}","gists_url":"https://api.github.com/users/rift137/gists{/gist_id}","starred_url":"https://api.github.com/users/rift137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rift137/subscriptions","organizations_url":"https://api.github.com/users/rift137/orgs","repos_url":"https://api.github.com/users/rift137/repos","events_url":"https://api.github.com/users/rift137/events{/privacy}","received_events_url":"https://api.github.com/users/rift137/received_events","type":"User","site_admin":false},"body":"Admin can now import events from web services. Once imported events cannot be changed in any way other that from the app that they were originally created on. An initial event will need to be manually fired to import all events. Otherwise events will be imported according to the modified date of the event in ws and will be rerun every hour. \r\n\r\nAdmin can now export events to web services. Once exported they cannot be reimported and should not be altered by any other apps [pending notification and response form Jimmy]. ","created_at":"2014-12-18T22:51:20Z","updated_at":"2014-12-18T23:48:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63a28d16201609f7e568f43a76d6d9af149ff2fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biola/news-publisher/pulls/22/commits","review_comments_url":"https://api.github.com/repos/biola/news-publisher/pulls/22/comments","review_comment_url":"https://api.github.com/repos/biola/news-publisher/pulls/comments/{number}","comments_url":"https://api.github.com/repos/biola/news-publisher/issues/22/comments","statuses_url":"https://api.github.com/repos/biola/news-publisher/statuses/9f384f6fac704130f35fffaad3a83ea9c3555899","head":{"label":"biola:ws_event_worker","ref":"ws_event_worker","sha":"9f384f6fac704130f35fffaad3a83ea9c3555899","user":{"login":"biola","id":395114,"avatar_url":"https://avatars.githubusercontent.com/u/395114?v=3","gravatar_id":"","url":"https://api.github.com/users/biola","html_url":"https://github.com/biola","followers_url":"https://api.github.com/users/biola/followers","following_url":"https://api.github.com/users/biola/following{/other_user}","gists_url":"https://api.github.com/users/biola/gists{/gist_id}","starred_url":"https://api.github.com/users/biola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biola/subscriptions","organizations_url":"https://api.github.com/users/biola/orgs","repos_url":"https://api.github.com/users/biola/repos","events_url":"https://api.github.com/users/biola/events{/privacy}","received_events_url":"https://api.github.com/users/biola/received_events","type":"Organization","site_admin":false},"repo":{"id":21878120,"name":"news-publisher","full_name":"biola/news-publisher","owner":{"login":"biola","id":395114,"avatar_url":"https://avatars.githubusercontent.com/u/395114?v=3","gravatar_id":"","url":"https://api.github.com/users/biola","html_url":"https://github.com/biola","followers_url":"https://api.github.com/users/biola/followers","following_url":"https://api.github.com/users/biola/following{/other_user}","gists_url":"https://api.github.com/users/biola/gists{/gist_id}","starred_url":"https://api.github.com/users/biola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biola/subscriptions","organizations_url":"https://api.github.com/users/biola/orgs","repos_url":"https://api.github.com/users/biola/repos","events_url":"https://api.github.com/users/biola/events{/privacy}","received_events_url":"https://api.github.com/users/biola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biola/news-publisher","description":"Biola News Publisher","fork":false,"url":"https://api.github.com/repos/biola/news-publisher","forks_url":"https://api.github.com/repos/biola/news-publisher/forks","keys_url":"https://api.github.com/repos/biola/news-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biola/news-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biola/news-publisher/teams","hooks_url":"https://api.github.com/repos/biola/news-publisher/hooks","issue_events_url":"https://api.github.com/repos/biola/news-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/biola/news-publisher/events","assignees_url":"https://api.github.com/repos/biola/news-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/biola/news-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/biola/news-publisher/tags","blobs_url":"https://api.github.com/repos/biola/news-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biola/news-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biola/news-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/biola/news-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biola/news-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/biola/news-publisher/languages","stargazers_url":"https://api.github.com/repos/biola/news-publisher/stargazers","contributors_url":"https://api.github.com/repos/biola/news-publisher/contributors","subscribers_url":"https://api.github.com/repos/biola/news-publisher/subscribers","subscription_url":"https://api.github.com/repos/biola/news-publisher/subscription","commits_url":"https://api.github.com/repos/biola/news-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/biola/news-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/biola/news-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/biola/news-publisher/issues/comments/{number}","contents_url":"https://api.github.com/repos/biola/news-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/biola/news-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biola/news-publisher/merges","archive_url":"https://api.github.com/repos/biola/news-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biola/news-publisher/downloads","issues_url":"https://api.github.com/repos/biola/news-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/biola/news-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/biola/news-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/biola/news-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biola/news-publisher/labels{/name}","releases_url":"https://api.github.com/repos/biola/news-publisher/releases{/id}","created_at":"2014-07-15T22:27:51Z","updated_at":"2014-12-09T22:02:03Z","pushed_at":"2014-12-18T22:45:04Z","git_url":"git://github.com/biola/news-publisher.git","ssh_url":"git@github.com:biola/news-publisher.git","clone_url":"https://github.com/biola/news-publisher.git","svn_url":"https://github.com/biola/news-publisher","homepage":null,"size":1500,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"biola:master","ref":"master","sha":"ea39d86da061f1187ea7e35ab63aaed2565174b3","user":{"login":"biola","id":395114,"avatar_url":"https://avatars.githubusercontent.com/u/395114?v=3","gravatar_id":"","url":"https://api.github.com/users/biola","html_url":"https://github.com/biola","followers_url":"https://api.github.com/users/biola/followers","following_url":"https://api.github.com/users/biola/following{/other_user}","gists_url":"https://api.github.com/users/biola/gists{/gist_id}","starred_url":"https://api.github.com/users/biola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biola/subscriptions","organizations_url":"https://api.github.com/users/biola/orgs","repos_url":"https://api.github.com/users/biola/repos","events_url":"https://api.github.com/users/biola/events{/privacy}","received_events_url":"https://api.github.com/users/biola/received_events","type":"Organization","site_admin":false},"repo":{"id":21878120,"name":"news-publisher","full_name":"biola/news-publisher","owner":{"login":"biola","id":395114,"avatar_url":"https://avatars.githubusercontent.com/u/395114?v=3","gravatar_id":"","url":"https://api.github.com/users/biola","html_url":"https://github.com/biola","followers_url":"https://api.github.com/users/biola/followers","following_url":"https://api.github.com/users/biola/following{/other_user}","gists_url":"https://api.github.com/users/biola/gists{/gist_id}","starred_url":"https://api.github.com/users/biola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biola/subscriptions","organizations_url":"https://api.github.com/users/biola/orgs","repos_url":"https://api.github.com/users/biola/repos","events_url":"https://api.github.com/users/biola/events{/privacy}","received_events_url":"https://api.github.com/users/biola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biola/news-publisher","description":"Biola News Publisher","fork":false,"url":"https://api.github.com/repos/biola/news-publisher","forks_url":"https://api.github.com/repos/biola/news-publisher/forks","keys_url":"https://api.github.com/repos/biola/news-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biola/news-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biola/news-publisher/teams","hooks_url":"https://api.github.com/repos/biola/news-publisher/hooks","issue_events_url":"https://api.github.com/repos/biola/news-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/biola/news-publisher/events","assignees_url":"https://api.github.com/repos/biola/news-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/biola/news-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/biola/news-publisher/tags","blobs_url":"https://api.github.com/repos/biola/news-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biola/news-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biola/news-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/biola/news-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biola/news-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/biola/news-publisher/languages","stargazers_url":"https://api.github.com/repos/biola/news-publisher/stargazers","contributors_url":"https://api.github.com/repos/biola/news-publisher/contributors","subscribers_url":"https://api.github.com/repos/biola/news-publisher/subscribers","subscription_url":"https://api.github.com/repos/biola/news-publisher/subscription","commits_url":"https://api.github.com/repos/biola/news-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/biola/news-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/biola/news-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/biola/news-publisher/issues/comments/{number}","contents_url":"https://api.github.com/repos/biola/news-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/biola/news-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biola/news-publisher/merges","archive_url":"https://api.github.com/repos/biola/news-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biola/news-publisher/downloads","issues_url":"https://api.github.com/repos/biola/news-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/biola/news-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/biola/news-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/biola/news-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biola/news-publisher/labels{/name}","releases_url":"https://api.github.com/repos/biola/news-publisher/releases{/id}","created_at":"2014-07-15T22:27:51Z","updated_at":"2014-12-09T22:02:03Z","pushed_at":"2014-12-18T22:45:04Z","git_url":"git://github.com/biola/news-publisher.git","ssh_url":"git@github.com:biola/news-publisher.git","clone_url":"https://github.com/biola/news-publisher.git","svn_url":"https://github.com/biola/news-publisher","homepage":null,"size":1500,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biola/news-publisher/pulls/22"},"html":{"href":"https://github.com/biola/news-publisher/pull/22"},"issue":{"href":"https://api.github.com/repos/biola/news-publisher/issues/22"},"comments":{"href":"https://api.github.com/repos/biola/news-publisher/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/biola/news-publisher/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/biola/news-publisher/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/biola/news-publisher/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/biola/news-publisher/statuses/9f384f6fac704130f35fffaad3a83ea9c3555899"}}}}