GitHub PullRequestReviewCommentEvent at 2014-12-23 19:54:38
Repository: xtuple-server-core
Actor: shackbarth
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/comments/22231642","id":22231642,"diff_hunk":"@@ -0,0 +1,53 @@\n+global.log  = require('npmlog');\n+log.heading = 'xtuple-server-local-paths';\n+log.level   = 'verbose';\n+\n+var assert = require('assert'),\n+    fs     = require('fs'),\n+    paths  = require('..');\n+\n+describe('local-paths', function () {\n+  it('should fail to find xtuple in a bad dir', function () {\n+    var result, err;\n+    try       { result = paths.options.workspace.validate('xtupleee'); }\n+    catch (e) { err = e; }\n+    assert.ok(!result);","path":"tasks/local/paths/spec/index.js","position":14,"original_position":14,"commit_id":"2b754525492cb815968c1c99e78c1a6ba3ca89bc","original_commit_id":"2b754525492cb815968c1c99e78c1a6ba3ca89bc","user":{"login":"shackbarth","id":1056617,"avatar_url":"https://avatars.githubusercontent.com/u/1056617?v=3","gravatar_id":"","url":"https://api.github.com/users/shackbarth","html_url":"https://github.com/shackbarth","followers_url":"https://api.github.com/users/shackbarth/followers","following_url":"https://api.github.com/users/shackbarth/following{/other_user}","gists_url":"https://api.github.com/users/shackbarth/gists{/gist_id}","starred_url":"https://api.github.com/users/shackbarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shackbarth/subscriptions","organizations_url":"https://api.github.com/users/shackbarth/orgs","repos_url":"https://api.github.com/users/shackbarth/repos","events_url":"https://api.github.com/users/shackbarth/events{/privacy}","received_events_url":"https://api.github.com/users/shackbarth/received_events","type":"User","site_admin":false},"body":"Seems a bit sloppy. What about `assert.isUndefined(result)` or `assert.isNull(result)` ?","created_at":"2014-12-23T19:54:38Z","updated_at":"2014-12-23T19:54:38Z","html_url":"https://github.com/xtuple/xtuple-server-core/pull/495#discussion_r22231642","pull_request_url":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/495","_links":{"self":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/comments/22231642"},"html":{"href":"https://github.com/xtuple/xtuple-server-core/pull/495#discussion_r22231642"},"pull_request":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/495"}}},"pull_request":{"url":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/495","id":26324777,"html_url":"https://github.com/xtuple/xtuple-server-core/pull/495","diff_url":"https://github.com/xtuple/xtuple-server-core/pull/495.diff","patch_url":"https://github.com/xtuple/xtuple-server-core/pull/495.patch","issue_url":"https://api.github.com/repos/xtuple/xtuple-server-core/issues/495","number":495,"state":"open","locked":false,"title":"Robust clone","user":{"login":"gilmoskowitz","id":704111,"avatar_url":"https://avatars.githubusercontent.com/u/704111?v=3","gravatar_id":"","url":"https://api.github.com/users/gilmoskowitz","html_url":"https://github.com/gilmoskowitz","followers_url":"https://api.github.com/users/gilmoskowitz/followers","following_url":"https://api.github.com/users/gilmoskowitz/following{/other_user}","gists_url":"https://api.github.com/users/gilmoskowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/gilmoskowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilmoskowitz/subscriptions","organizations_url":"https://api.github.com/users/gilmoskowitz/orgs","repos_url":"https://api.github.com/users/gilmoskowitz/repos","events_url":"https://api.github.com/users/gilmoskowitz/events{/privacy}","received_events_url":"https://api.github.com/users/gilmoskowitz/received_events","type":"User","site_admin":false},"body":"Try to make `install-*` plans a bit more robust:\r\n- give a helpful message if `xtuple` hasn't been checked out yet\r\n- be more forgiving of the state of other repositories\r\n- be smarter about `config.js` over multiple runs\r\n\r\nThis will not work nor pass CI until #494 is merged and `npm publish`ed.\r\n[ edit - the #494 changes originated on this branch and were pulled out to allow separate merge/test/publication ]","created_at":"2014-12-18T19:21:50Z","updated_at":"2014-12-23T19:54:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f266232b27df1782a3406d631f1f226480d15d4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/495/commits","review_comments_url":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/495/comments","review_comment_url":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xtuple/xtuple-server-core/issues/495/comments","statuses_url":"https://api.github.com/repos/xtuple/xtuple-server-core/statuses/2b754525492cb815968c1c99e78c1a6ba3ca89bc","head":{"label":"gilmoskowitz:robustClone","ref":"robustClone","sha":"2b754525492cb815968c1c99e78c1a6ba3ca89bc","user":{"login":"gilmoskowitz","id":704111,"avatar_url":"https://avatars.githubusercontent.com/u/704111?v=3","gravatar_id":"","url":"https://api.github.com/users/gilmoskowitz","html_url":"https://github.com/gilmoskowitz","followers_url":"https://api.github.com/users/gilmoskowitz/followers","following_url":"https://api.github.com/users/gilmoskowitz/following{/other_user}","gists_url":"https://api.github.com/users/gilmoskowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/gilmoskowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilmoskowitz/subscriptions","organizations_url":"https://api.github.com/users/gilmoskowitz/orgs","repos_url":"https://api.github.com/users/gilmoskowitz/repos","events_url":"https://api.github.com/users/gilmoskowitz/events{/privacy}","received_events_url":"https://api.github.com/users/gilmoskowitz/received_events","type":"User","site_admin":false},"repo":{"id":26768350,"name":"xtuple-server-core","full_name":"gilmoskowitz/xtuple-server-core","owner":{"login":"gilmoskowitz","id":704111,"avatar_url":"https://avatars.githubusercontent.com/u/704111?v=3","gravatar_id":"","url":"https://api.github.com/users/gilmoskowitz","html_url":"https://github.com/gilmoskowitz","followers_url":"https://api.github.com/users/gilmoskowitz/followers","following_url":"https://api.github.com/users/gilmoskowitz/following{/other_user}","gists_url":"https://api.github.com/users/gilmoskowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/gilmoskowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilmoskowitz/subscriptions","organizations_url":"https://api.github.com/users/gilmoskowitz/orgs","repos_url":"https://api.github.com/users/gilmoskowitz/repos","events_url":"https://api.github.com/users/gilmoskowitz/events{/privacy}","received_events_url":"https://api.github.com/users/gilmoskowitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gilmoskowitz/xtuple-server-core","description":"This repository contains the source code for the xTuple Server core, a component of the xTuple Server. Includes the command line interface to the xTuple Server, as well as the associated commands.","fork":true,"url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core","forks_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/forks","keys_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/teams","hooks_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/hooks","issue_events_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/issues/events{/number}","events_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/events","assignees_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/assignees{/user}","branches_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/branches{/branch}","tags_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/tags","blobs_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/statuses/{sha}","languages_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/languages","stargazers_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/stargazers","contributors_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/contributors","subscribers_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/subscribers","subscription_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/subscription","commits_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/contents/{+path}","compare_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/merges","archive_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/downloads","issues_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/issues{/number}","pulls_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/pulls{/number}","milestones_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/milestones{/number}","notifications_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/labels{/name}","releases_url":"https://api.github.com/repos/gilmoskowitz/xtuple-server-core/releases{/id}","created_at":"2014-11-17T17:31:39Z","updated_at":"2014-11-17T17:31:40Z","pushed_at":"2014-12-22T21:20:21Z","git_url":"git://github.com/gilmoskowitz/xtuple-server-core.git","ssh_url":"git@github.com:gilmoskowitz/xtuple-server-core.git","clone_url":"https://github.com/gilmoskowitz/xtuple-server-core.git","svn_url":"https://github.com/gilmoskowitz/xtuple-server-core","homepage":"https://www.npmjs.org/package/xtuple-server","size":1526,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xtuple:master","ref":"master","sha":"8b8a0935c9deddfb061f0b3ba90e2e497b56a36a","user":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?v=3","gravatar_id":"","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"repo":{"id":9697885,"name":"xtuple-server-core","full_name":"xtuple/xtuple-server-core","owner":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?v=3","gravatar_id":"","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xtuple/xtuple-server-core","description":"This repository contains the source code for the xTuple Server core, a component of the xTuple Server. Includes the command line interface to the xTuple Server, as well as the associated commands.","fork":false,"url":"https://api.github.com/repos/xtuple/xtuple-server-core","forks_url":"https://api.github.com/repos/xtuple/xtuple-server-core/forks","keys_url":"https://api.github.com/repos/xtuple/xtuple-server-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xtuple/xtuple-server-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xtuple/xtuple-server-core/teams","hooks_url":"https://api.github.com/repos/xtuple/xtuple-server-core/hooks","issue_events_url":"https://api.github.com/repos/xtuple/xtuple-server-core/issues/events{/number}","events_url":"https://api.github.com/repos/xtuple/xtuple-server-core/events","assignees_url":"https://api.github.com/repos/xtuple/xtuple-server-core/assignees{/user}","branches_url":"https://api.github.com/repos/xtuple/xtuple-server-core/branches{/branch}","tags_url":"https://api.github.com/repos/xtuple/xtuple-server-core/tags","blobs_url":"https://api.github.com/repos/xtuple/xtuple-server-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xtuple/xtuple-server-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xtuple/xtuple-server-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xtuple/xtuple-server-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xtuple/xtuple-server-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xtuple/xtuple-server-core/languages","stargazers_url":"https://api.github.com/repos/xtuple/xtuple-server-core/stargazers","contributors_url":"https://api.github.com/repos/xtuple/xtuple-server-core/contributors","subscribers_url":"https://api.github.com/repos/xtuple/xtuple-server-core/subscribers","subscription_url":"https://api.github.com/repos/xtuple/xtuple-server-core/subscription","commits_url":"https://api.github.com/repos/xtuple/xtuple-server-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xtuple/xtuple-server-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xtuple/xtuple-server-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xtuple/xtuple-server-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/xtuple/xtuple-server-core/contents/{+path}","compare_url":"https://api.github.com/repos/xtuple/xtuple-server-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xtuple/xtuple-server-core/merges","archive_url":"https://api.github.com/repos/xtuple/xtuple-server-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xtuple/xtuple-server-core/downloads","issues_url":"https://api.github.com/repos/xtuple/xtuple-server-core/issues{/number}","pulls_url":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xtuple/xtuple-server-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xtuple/xtuple-server-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xtuple/xtuple-server-core/labels{/name}","releases_url":"https://api.github.com/repos/xtuple/xtuple-server-core/releases{/id}","created_at":"2013-04-26T15:03:41Z","updated_at":"2014-12-22T17:09:14Z","pushed_at":"2014-12-22T17:09:13Z","git_url":"git://github.com/xtuple/xtuple-server-core.git","ssh_url":"git@github.com:xtuple/xtuple-server-core.git","clone_url":"https://github.com/xtuple/xtuple-server-core.git","svn_url":"https://github.com/xtuple/xtuple-server-core","homepage":"https://www.npmjs.org/package/xtuple-server","size":11697,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":24,"forks":18,"open_issues":24,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/495"},"html":{"href":"https://github.com/xtuple/xtuple-server-core/pull/495"},"issue":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/issues/495"},"comments":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/xtuple/xtuple-server-core/statuses/2b754525492cb815968c1c99e78c1a6ba3ca89bc"}}}}