GitHub PullRequestReviewCommentEvent at 2014-04-14 10:24:03
Repository: shogun
Actor: karlnapf
Payload: {"comment":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/11578039","id":11578039,"diff_hunk":"@@ -440,11 +443,15 @@ void CNeuralNetwork::set_batch_size(int32_t batch_size)\n \n float64_t* CNeuralNetwork::features_to_raw(CFeatures* features)\n {\n-\tASSERT(features->get_feature_type() == F_DREAL);\n-\tASSERT(features->get_feature_class() == C_DENSE);\n+\tREQUIRE(features->get_feature_type() == F_DREAL,","path":"src/shogun/neuralnets/NeuralNetwork.cpp","position":281,"original_position":281,"commit_id":"947f3e9790afdb9dc3c59f8849cd6333e0374359","original_commit_id":"947f3e9790afdb9dc3c59f8849cd6333e0374359","user":{"login":"karlnapf","id":699071,"avatar_url":"https://avatars.githubusercontent.com/u/699071?","gravatar_id":"5dd0cd1feee1624c281cdd1801b9ea81","url":"https://api.github.com/users/karlnapf","html_url":"https://github.com/karlnapf","followers_url":"https://api.github.com/users/karlnapf/followers","following_url":"https://api.github.com/users/karlnapf/following{/other_user}","gists_url":"https://api.github.com/users/karlnapf/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnapf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnapf/subscriptions","organizations_url":"https://api.github.com/users/karlnapf/orgs","repos_url":"https://api.github.com/users/karlnapf/repos","events_url":"https://api.github.com/users/karlnapf/events{/privacy}","received_events_url":"https://api.github.com/users/karlnapf/received_events","type":"User","site_admin":false},"body":"pls do NULL checks for the features here, you will get segfaults in the REQUIRE calls if they are.\r\nSame for labels below\r\n","created_at":"2014-04-14T10:24:03Z","updated_at":"2014-04-14T10:24:03Z","html_url":"https://github.com/shogun-toolbox/shogun/pull/2135#discussion_r11578039","pull_request_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2135","_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/11578039"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/2135#discussion_r11578039"},"pull_request":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2135"}}}}