GitHub PullRequestReviewCommentEvent at 2014-08-26 03:19:07
Repository: gaia
Actor: crh0716
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/16694013","id":16694013,"diff_hunk":"@@ -39,6 +42,9 @@ require.config({\n     'shared/settings_listener': {\n       exports: 'SettingsListener'\n     },\n+    'shared/toaster': {\n+      exports: 'Toaster'\n+    },","path":"apps/settings/js/config/require.js","position":16,"original_position":16,"commit_id":"270204fa3ef1bdc6df54f2a86d2370527de34064","original_commit_id":"270204fa3ef1bdc6df54f2a86d2370527de34064","user":{"login":"crh0716","id":2899280,"avatar_url":"https://avatars.githubusercontent.com/u/2899280?v=2","gravatar_id":"ab20989d946f4bd31c590b5a6ef73f7a","url":"https://api.github.com/users/crh0716","html_url":"https://github.com/crh0716","followers_url":"https://api.github.com/users/crh0716/followers","following_url":"https://api.github.com/users/crh0716/following{/other_user}","gists_url":"https://api.github.com/users/crh0716/gists{/gist_id}","starred_url":"https://api.github.com/users/crh0716/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crh0716/subscriptions","organizations_url":"https://api.github.com/users/crh0716/orgs","repos_url":"https://api.github.com/users/crh0716/repos","events_url":"https://api.github.com/users/crh0716/events{/privacy}","received_events_url":"https://api.github.com/users/crh0716/received_events","type":"User","site_admin":false},"body":"Nice catch! I did not notice it when rebasing.","created_at":"2014-08-26T03:19:07Z","updated_at":"2014-08-26T03:19:07Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/21876#discussion_r16694013","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/21876","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/16694013"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/21876#discussion_r16694013"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/21876"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/21876","id":18533735,"html_url":"https://github.com/mozilla-b2g/gaia/pull/21876","diff_url":"https://github.com/mozilla-b2g/gaia/pull/21876.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/21876.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/21876","number":21876,"state":"open","locked":false,"title":"Bug 1032629 - APN Settings UX refresh","user":{"login":"crh0716","id":2899280,"avatar_url":"https://avatars.githubusercontent.com/u/2899280?v=2","gravatar_id":"ab20989d946f4bd31c590b5a6ef73f7a","url":"https://api.github.com/users/crh0716","html_url":"https://github.com/crh0716","followers_url":"https://api.github.com/users/crh0716/followers","following_url":"https://api.github.com/users/crh0716/following{/other_user}","gists_url":"https://api.github.com/users/crh0716/gists{/gist_id}","starred_url":"https://api.github.com/users/crh0716/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crh0716/subscriptions","organizations_url":"https://api.github.com/users/crh0716/orgs","repos_url":"https://api.github.com/users/crh0716/repos","events_url":"https://api.github.com/users/crh0716/events{/privacy}","received_events_url":"https://api.github.com/users/crh0716/received_events","type":"User","site_admin":false},"body":"https://bugzilla.mozilla.org/show_bug.cgi?id=1032629","created_at":"2014-07-17T15:04:56Z","updated_at":"2014-08-26T03:19:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b985212aeea57400d385d90dc3bbb7a4277370ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/21876/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/21876/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/21876/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/270204fa3ef1bdc6df54f2a86d2370527de34064","head":{"label":"crh0716:1032629","ref":"1032629","sha":"270204fa3ef1bdc6df54f2a86d2370527de34064","user":{"login":"crh0716","id":2899280,"avatar_url":"https://avatars.githubusercontent.com/u/2899280?v=2","gravatar_id":"ab20989d946f4bd31c590b5a6ef73f7a","url":"https://api.github.com/users/crh0716","html_url":"https://github.com/crh0716","followers_url":"https://api.github.com/users/crh0716/followers","following_url":"https://api.github.com/users/crh0716/following{/other_user}","gists_url":"https://api.github.com/users/crh0716/gists{/gist_id}","starred_url":"https://api.github.com/users/crh0716/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crh0716/subscriptions","organizations_url":"https://api.github.com/users/crh0716/orgs","repos_url":"https://api.github.com/users/crh0716/repos","events_url":"https://api.github.com/users/crh0716/events{/privacy}","received_events_url":"https://api.github.com/users/crh0716/received_events","type":"User","site_admin":false},"repo":{"id":7014877,"name":"gaia","full_name":"crh0716/gaia","owner":{"login":"crh0716","id":2899280,"avatar_url":"https://avatars.githubusercontent.com/u/2899280?v=2","gravatar_id":"ab20989d946f4bd31c590b5a6ef73f7a","url":"https://api.github.com/users/crh0716","html_url":"https://github.com/crh0716","followers_url":"https://api.github.com/users/crh0716/followers","following_url":"https://api.github.com/users/crh0716/following{/other_user}","gists_url":"https://api.github.com/users/crh0716/gists{/gist_id}","starred_url":"https://api.github.com/users/crh0716/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crh0716/subscriptions","organizations_url":"https://api.github.com/users/crh0716/orgs","repos_url":"https://api.github.com/users/crh0716/repos","events_url":"https://api.github.com/users/crh0716/events{/privacy}","received_events_url":"https://api.github.com/users/crh0716/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crh0716/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/crh0716/gaia","forks_url":"https://api.github.com/repos/crh0716/gaia/forks","keys_url":"https://api.github.com/repos/crh0716/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crh0716/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crh0716/gaia/teams","hooks_url":"https://api.github.com/repos/crh0716/gaia/hooks","issue_events_url":"https://api.github.com/repos/crh0716/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/crh0716/gaia/events","assignees_url":"https://api.github.com/repos/crh0716/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/crh0716/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/crh0716/gaia/tags","blobs_url":"https://api.github.com/repos/crh0716/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crh0716/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crh0716/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/crh0716/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crh0716/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/crh0716/gaia/languages","stargazers_url":"https://api.github.com/repos/crh0716/gaia/stargazers","contributors_url":"https://api.github.com/repos/crh0716/gaia/contributors","subscribers_url":"https://api.github.com/repos/crh0716/gaia/subscribers","subscription_url":"https://api.github.com/repos/crh0716/gaia/subscription","commits_url":"https://api.github.com/repos/crh0716/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/crh0716/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/crh0716/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/crh0716/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/crh0716/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/crh0716/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crh0716/gaia/merges","archive_url":"https://api.github.com/repos/crh0716/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crh0716/gaia/downloads","issues_url":"https://api.github.com/repos/crh0716/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/crh0716/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/crh0716/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/crh0716/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crh0716/gaia/labels{/name}","releases_url":"https://api.github.com/repos/crh0716/gaia/releases{/id}","created_at":"2012-12-05T09:36:53Z","updated_at":"2014-06-25T09:34:00Z","pushed_at":"2014-08-25T06:32:45Z","git_url":"git://github.com/crh0716/gaia.git","ssh_url":"git@github.com:crh0716/gaia.git","clone_url":"https://github.com/crh0716/gaia.git","svn_url":"https://github.com/crh0716/gaia","homepage":"https://wiki.mozilla.org/B2G","size":825659,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"5fae8a02bc31d28a4a76371bd9b0c8ef98a4b4f4","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-08-25T20:32:34Z","pushed_at":"2014-08-26T01:19:27Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1388458,"stargazers_count":1711,"watchers_count":1711,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1850,"mirror_url":null,"open_issues_count":1987,"forks":1850,"open_issues":1987,"watchers":1711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/21876"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/21876"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/21876"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/21876/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/21876/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/21876/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/270204fa3ef1bdc6df54f2a86d2370527de34064"}}}}