GitHub PullRequestReviewCommentEvent at 2014-11-05 19:45:12
Repository: pop
Actor: grp
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/pop/pulls/comments/19899565","id":19899565,"diff_hunk":"@@ -61,6 +61,6 @@\n  @abstract The reversed velocity.\n  @discussion The reversed velocity based on the originalVelocity when the animation was set up.\n  */\n-- (id)reversedVelocity;\n+- (instancetype)reversedVelocity;","path":"pop/POPDecayAnimation.h","position":5,"original_position":5,"commit_id":"e437e476cbc3c6d8bfa442c9cc87436d339babf1","original_commit_id":"e437e476cbc3c6d8bfa442c9cc87436d339babf1","user":{"login":"grp","id":163390,"avatar_url":"https://avatars.githubusercontent.com/u/163390?v=2","gravatar_id":"","url":"https://api.github.com/users/grp","html_url":"https://github.com/grp","followers_url":"https://api.github.com/users/grp/followers","following_url":"https://api.github.com/users/grp/following{/other_user}","gists_url":"https://api.github.com/users/grp/gists{/gist_id}","starred_url":"https://api.github.com/users/grp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grp/subscriptions","organizations_url":"https://api.github.com/users/grp/orgs","repos_url":"https://api.github.com/users/grp/repos","events_url":"https://api.github.com/users/grp/events{/privacy}","received_events_url":"https://api.github.com/users/grp/received_events","type":"User","site_admin":false},"body":"Not sure if this one is correct either — the velocity is generally a value type, not an animation type.","created_at":"2014-11-05T19:45:12Z","updated_at":"2014-11-05T19:45:12Z","html_url":"https://github.com/facebook/pop/pull/186#discussion_r19899565","pull_request_url":"https://api.github.com/repos/facebook/pop/pulls/186","_links":{"self":{"href":"https://api.github.com/repos/facebook/pop/pulls/comments/19899565"},"html":{"href":"https://github.com/facebook/pop/pull/186#discussion_r19899565"},"pull_request":{"href":"https://api.github.com/repos/facebook/pop/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/pop/pulls/186","id":23842513,"html_url":"https://github.com/facebook/pop/pull/186","diff_url":"https://github.com/facebook/pop/pull/186.diff","patch_url":"https://github.com/facebook/pop/pull/186.patch","issue_url":"https://api.github.com/repos/facebook/pop/issues/186","number":186,"state":"open","locked":false,"title":"Changes return value of id to instancetype","user":{"login":"westerlund","id":359712,"avatar_url":"https://avatars.githubusercontent.com/u/359712?v=2","gravatar_id":"","url":"https://api.github.com/users/westerlund","html_url":"https://github.com/westerlund","followers_url":"https://api.github.com/users/westerlund/followers","following_url":"https://api.github.com/users/westerlund/following{/other_user}","gists_url":"https://api.github.com/users/westerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/westerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westerlund/subscriptions","organizations_url":"https://api.github.com/users/westerlund/orgs","repos_url":"https://api.github.com/users/westerlund/repos","events_url":"https://api.github.com/users/westerlund/events{/privacy}","received_events_url":"https://api.github.com/users/westerlund/received_events","type":"User","site_admin":false},"body":"Uses the `instancetype` instead of vague `id`so that the Swift compiler can use these methods without ugly downcasting.","created_at":"2014-11-04T16:13:36Z","updated_at":"2014-11-05T19:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"525ce53414ea125cdd9d9c7bd5b03093dc141cc1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/pop/pulls/186/commits","review_comments_url":"https://api.github.com/repos/facebook/pop/pulls/186/comments","review_comment_url":"https://api.github.com/repos/facebook/pop/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/pop/issues/186/comments","statuses_url":"https://api.github.com/repos/facebook/pop/statuses/e437e476cbc3c6d8bfa442c9cc87436d339babf1","head":{"label":"westerlund:master","ref":"master","sha":"e437e476cbc3c6d8bfa442c9cc87436d339babf1","user":{"login":"westerlund","id":359712,"avatar_url":"https://avatars.githubusercontent.com/u/359712?v=2","gravatar_id":"","url":"https://api.github.com/users/westerlund","html_url":"https://github.com/westerlund","followers_url":"https://api.github.com/users/westerlund/followers","following_url":"https://api.github.com/users/westerlund/following{/other_user}","gists_url":"https://api.github.com/users/westerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/westerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westerlund/subscriptions","organizations_url":"https://api.github.com/users/westerlund/orgs","repos_url":"https://api.github.com/users/westerlund/repos","events_url":"https://api.github.com/users/westerlund/events{/privacy}","received_events_url":"https://api.github.com/users/westerlund/received_events","type":"User","site_admin":false},"repo":{"id":26176330,"name":"pop","full_name":"westerlund/pop","owner":{"login":"westerlund","id":359712,"avatar_url":"https://avatars.githubusercontent.com/u/359712?v=2","gravatar_id":"","url":"https://api.github.com/users/westerlund","html_url":"https://github.com/westerlund","followers_url":"https://api.github.com/users/westerlund/followers","following_url":"https://api.github.com/users/westerlund/following{/other_user}","gists_url":"https://api.github.com/users/westerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/westerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westerlund/subscriptions","organizations_url":"https://api.github.com/users/westerlund/orgs","repos_url":"https://api.github.com/users/westerlund/repos","events_url":"https://api.github.com/users/westerlund/events{/privacy}","received_events_url":"https://api.github.com/users/westerlund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/westerlund/pop","description":"Extensible iOS and OS X animation library.","fork":true,"url":"https://api.github.com/repos/westerlund/pop","forks_url":"https://api.github.com/repos/westerlund/pop/forks","keys_url":"https://api.github.com/repos/westerlund/pop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/westerlund/pop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/westerlund/pop/teams","hooks_url":"https://api.github.com/repos/westerlund/pop/hooks","issue_events_url":"https://api.github.com/repos/westerlund/pop/issues/events{/number}","events_url":"https://api.github.com/repos/westerlund/pop/events","assignees_url":"https://api.github.com/repos/westerlund/pop/assignees{/user}","branches_url":"https://api.github.com/repos/westerlund/pop/branches{/branch}","tags_url":"https://api.github.com/repos/westerlund/pop/tags","blobs_url":"https://api.github.com/repos/westerlund/pop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/westerlund/pop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/westerlund/pop/git/refs{/sha}","trees_url":"https://api.github.com/repos/westerlund/pop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/westerlund/pop/statuses/{sha}","languages_url":"https://api.github.com/repos/westerlund/pop/languages","stargazers_url":"https://api.github.com/repos/westerlund/pop/stargazers","contributors_url":"https://api.github.com/repos/westerlund/pop/contributors","subscribers_url":"https://api.github.com/repos/westerlund/pop/subscribers","subscription_url":"https://api.github.com/repos/westerlund/pop/subscription","commits_url":"https://api.github.com/repos/westerlund/pop/commits{/sha}","git_commits_url":"https://api.github.com/repos/westerlund/pop/git/commits{/sha}","comments_url":"https://api.github.com/repos/westerlund/pop/comments{/number}","issue_comment_url":"https://api.github.com/repos/westerlund/pop/issues/comments/{number}","contents_url":"https://api.github.com/repos/westerlund/pop/contents/{+path}","compare_url":"https://api.github.com/repos/westerlund/pop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/westerlund/pop/merges","archive_url":"https://api.github.com/repos/westerlund/pop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/westerlund/pop/downloads","issues_url":"https://api.github.com/repos/westerlund/pop/issues{/number}","pulls_url":"https://api.github.com/repos/westerlund/pop/pulls{/number}","milestones_url":"https://api.github.com/repos/westerlund/pop/milestones{/number}","notifications_url":"https://api.github.com/repos/westerlund/pop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/westerlund/pop/labels{/name}","releases_url":"https://api.github.com/repos/westerlund/pop/releases{/id}","created_at":"2014-11-04T15:58:39Z","updated_at":"2014-11-04T16:07:48Z","pushed_at":"2014-11-04T16:07:48Z","git_url":"git://github.com/westerlund/pop.git","ssh_url":"git@github.com:westerlund/pop.git","clone_url":"https://github.com/westerlund/pop.git","svn_url":"https://github.com/westerlund/pop","homepage":"","size":3494,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"776814eae20a027e3c5dfdce847751399a35bb44","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=2","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":18275356,"name":"pop","full_name":"facebook/pop","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=2","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/pop","description":"Extensible iOS and OS X animation library.","fork":false,"url":"https://api.github.com/repos/facebook/pop","forks_url":"https://api.github.com/repos/facebook/pop/forks","keys_url":"https://api.github.com/repos/facebook/pop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/pop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/pop/teams","hooks_url":"https://api.github.com/repos/facebook/pop/hooks","issue_events_url":"https://api.github.com/repos/facebook/pop/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/pop/events","assignees_url":"https://api.github.com/repos/facebook/pop/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/pop/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/pop/tags","blobs_url":"https://api.github.com/repos/facebook/pop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/pop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/pop/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/pop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/pop/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/pop/languages","stargazers_url":"https://api.github.com/repos/facebook/pop/stargazers","contributors_url":"https://api.github.com/repos/facebook/pop/contributors","subscribers_url":"https://api.github.com/repos/facebook/pop/subscribers","subscription_url":"https://api.github.com/repos/facebook/pop/subscription","commits_url":"https://api.github.com/repos/facebook/pop/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/pop/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/pop/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/pop/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/pop/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/pop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/pop/merges","archive_url":"https://api.github.com/repos/facebook/pop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/pop/downloads","issues_url":"https://api.github.com/repos/facebook/pop/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/pop/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/pop/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/pop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/pop/labels{/name}","releases_url":"https://api.github.com/repos/facebook/pop/releases{/id}","created_at":"2014-03-30T22:29:12Z","updated_at":"2014-11-05T15:30:16Z","pushed_at":"2014-11-03T06:50:07Z","git_url":"git://github.com/facebook/pop.git","ssh_url":"git@github.com:facebook/pop.git","clone_url":"https://github.com/facebook/pop.git","svn_url":"https://github.com/facebook/pop","homepage":"","size":3494,"stargazers_count":8923,"watchers_count":8923,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1150,"mirror_url":null,"open_issues_count":27,"forks":1150,"open_issues":27,"watchers":8923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/pop/pulls/186"},"html":{"href":"https://github.com/facebook/pop/pull/186"},"issue":{"href":"https://api.github.com/repos/facebook/pop/issues/186"},"comments":{"href":"https://api.github.com/repos/facebook/pop/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/pop/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/pop/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/pop/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/pop/statuses/e437e476cbc3c6d8bfa442c9cc87436d339babf1"}}}}