GitHub PullRequestReviewCommentEvent at 2014-12-08 10:50:29
Repository: barclamp-crowbar
Actor: tboerger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments/21445787","id":21445787,"diff_hunk":"@@ -1330,6 +1330,29 @@ def apply_role(role, inst, in_queue)\n     # XXX: This should not be done this way.  Something else should request this.\n     system(\"sudo\", \"-i\", Rails.root.join(\"..\", \"bin\", \"single_chef_client.sh\").expand_path) if !ran_admin\n \n+    # delete #{role_name}_remove role from runlist as it is not needed anymore","path":"crowbar_framework/app/models/service_object.rb","position":4,"original_position":4,"commit_id":"09bf8c9d38a104091d1f6a5fb5bf97379271b859","original_commit_id":"09bf8c9d38a104091d1f6a5fb5bf97379271b859","user":{"login":"tboerger","id":156964,"avatar_url":"https://avatars.githubusercontent.com/u/156964?v=3","gravatar_id":"","url":"https://api.github.com/users/tboerger","html_url":"https://github.com/tboerger","followers_url":"https://api.github.com/users/tboerger/followers","following_url":"https://api.github.com/users/tboerger/following{/other_user}","gists_url":"https://api.github.com/users/tboerger/gists{/gist_id}","starred_url":"https://api.github.com/users/tboerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tboerger/subscriptions","organizations_url":"https://api.github.com/users/tboerger/orgs","repos_url":"https://api.github.com/users/tboerger/repos","events_url":"https://api.github.com/users/tboerger/events{/privacy}","received_events_url":"https://api.github.com/users/tboerger/received_events","type":"User","site_admin":false},"body":"Sounds good to me, especially because we get test coverage for that.","created_at":"2014-12-08T10:50:29Z","updated_at":"2014-12-08T10:50:29Z","html_url":"https://github.com/crowbar/barclamp-crowbar/pull/1162#discussion_r21445787","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1162","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments/21445787"},"html":{"href":"https://github.com/crowbar/barclamp-crowbar/pull/1162#discussion_r21445787"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1162"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1162","id":25581051,"html_url":"https://github.com/crowbar/barclamp-crowbar/pull/1162","diff_url":"https://github.com/crowbar/barclamp-crowbar/pull/1162.diff","patch_url":"https://github.com/crowbar/barclamp-crowbar/pull/1162.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1162","number":1162,"state":"open","locked":false,"title":"delete _remove roles from the run_list","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"When a `$barclamp-$role_remove` role (and its removal recipe) has successfully finished, delete it from the node's run_list.","created_at":"2014-12-05T16:13:55Z","updated_at":"2014-12-08T10:50:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5263dc7c04e60cd4e3f4f647d8acc9c5eb86d529","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1162/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1162/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1162/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/09bf8c9d38a104091d1f6a5fb5bf97379271b859","head":{"label":"MaximilianMeister:delete_remove_role","ref":"delete_remove_role","sha":"09bf8c9d38a104091d1f6a5fb5bf97379271b859","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"repo":{"id":21192705,"name":"barclamp-crowbar","full_name":"MaximilianMeister/barclamp-crowbar","owner":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximilianMeister/barclamp-crowbar","description":"Crowbar Core: Core application","fork":true,"url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar","forks_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/forks","keys_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/teams","hooks_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/hooks","issue_events_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/events","assignees_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/tags","blobs_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/languages","stargazers_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/stargazers","contributors_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/contributors","subscribers_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/subscribers","subscription_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/subscription","commits_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/issues/comments/{number}","contents_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/merges","archive_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/downloads","issues_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/labels{/name}","releases_url":"https://api.github.com/repos/MaximilianMeister/barclamp-crowbar/releases{/id}","created_at":"2014-06-25T06:25:21Z","updated_at":"2014-06-25T09:29:58Z","pushed_at":"2014-12-05T16:12:22Z","git_url":"git://github.com/MaximilianMeister/barclamp-crowbar.git","ssh_url":"git@github.com:MaximilianMeister/barclamp-crowbar.git","clone_url":"https://github.com/MaximilianMeister/barclamp-crowbar.git","svn_url":"https://github.com/MaximilianMeister/barclamp-crowbar","homepage":"https://github.com/crowbar/crowbar","size":33573,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"399e409f8513988fab93551261d5eb463ca3845f","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2351384,"name":"barclamp-crowbar","full_name":"crowbar/barclamp-crowbar","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-crowbar","description":"Crowbar Core: Core Application","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-crowbar","forks_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/comments/{number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/releases{/id}","created_at":"2011-09-08T20:47:56Z","updated_at":"2014-12-03T23:16:37Z","pushed_at":"2014-12-03T23:16:36Z","git_url":"git://github.com/crowbar/barclamp-crowbar.git","ssh_url":"git@github.com:crowbar/barclamp-crowbar.git","clone_url":"https://github.com/crowbar/barclamp-crowbar.git","svn_url":"https://github.com/crowbar/barclamp-crowbar","homepage":"https://github.com/crowbar/crowbar","size":38827,"stargazers_count":73,"watchers_count":73,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"open_issues_count":17,"forks":199,"open_issues":17,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1162"},"html":{"href":"https://github.com/crowbar/barclamp-crowbar/pull/1162"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1162"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1162/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1162/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1162/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/09bf8c9d38a104091d1f6a5fb5bf97379271b859"}}}}