GitHub PullRequestReviewCommentEvent at 2014-07-01 01:05:48
Repository: kubernetes
Actor: monnand
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/14384788","id":14384788,"diff_hunk":"@@ -29,6 +30,9 @@ type EtcdResponseWithError struct {\n }\n \n type FakeEtcdClient struct {\n+\tcondChannelsReady *sync.Cond","path":"pkg/util/fake_etcd_client.go","position":null,"original_position":12,"commit_id":"7b432eac5c6530c60c0cca3fc74698af44e3c87e","original_commit_id":"905c6dcb1053bef3a29cf6bd9c94e825cbd68e35","user":{"login":"monnand","id":379562,"avatar_url":"https://avatars.githubusercontent.com/u/379562?","gravatar_id":"1f261a013b6a32e6d80a3c3d7cae1586","url":"https://api.github.com/users/monnand","html_url":"https://github.com/monnand","followers_url":"https://api.github.com/users/monnand/followers","following_url":"https://api.github.com/users/monnand/following{/other_user}","gists_url":"https://api.github.com/users/monnand/gists{/gist_id}","starred_url":"https://api.github.com/users/monnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monnand/subscriptions","organizations_url":"https://api.github.com/users/monnand/orgs","repos_url":"https://api.github.com/users/monnand/repos","events_url":"https://api.github.com/users/monnand/events{/privacy}","received_events_url":"https://api.github.com/users/monnand/received_events","type":"User","site_admin":false},"body":"Done. Thanks!","created_at":"2014-07-01T01:05:48Z","updated_at":"2014-07-01T01:05:48Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/309#discussion_r14384788","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/309","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/14384788"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/309#discussion_r14384788"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/309","id":17800541,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/309","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/309.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/309.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/309","number":309,"state":"open","title":"fix data races in controller","user":{"login":"monnand","id":379562,"avatar_url":"https://avatars.githubusercontent.com/u/379562?","gravatar_id":"1f261a013b6a32e6d80a3c3d7cae1586","url":"https://api.github.com/users/monnand","html_url":"https://github.com/monnand","followers_url":"https://api.github.com/users/monnand/followers","following_url":"https://api.github.com/users/monnand/following{/other_user}","gists_url":"https://api.github.com/users/monnand/gists{/gist_id}","starred_url":"https://api.github.com/users/monnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monnand/subscriptions","organizations_url":"https://api.github.com/users/monnand/orgs","repos_url":"https://api.github.com/users/monnand/repos","events_url":"https://api.github.com/users/monnand/events{/privacy}","received_events_url":"https://api.github.com/users/monnand/received_events","type":"User","site_admin":false},"body":"Fix #305","created_at":"2014-06-30T21:51:46Z","updated_at":"2014-07-01T01:05:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad44510bd9f452bdf1eb4b4c78ca3dee14a4527a","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?","gravatar_id":"1a843544abcf9f764d28e3427a4a9610","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/309/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/309/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/309/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/7b432eac5c6530c60c0cca3fc74698af44e3c87e","head":{"label":"monnand:race-controller","ref":"race-controller","sha":"7b432eac5c6530c60c0cca3fc74698af44e3c87e","user":{"login":"monnand","id":379562,"avatar_url":"https://avatars.githubusercontent.com/u/379562?","gravatar_id":"1f261a013b6a32e6d80a3c3d7cae1586","url":"https://api.github.com/users/monnand","html_url":"https://github.com/monnand","followers_url":"https://api.github.com/users/monnand/followers","following_url":"https://api.github.com/users/monnand/following{/other_user}","gists_url":"https://api.github.com/users/monnand/gists{/gist_id}","starred_url":"https://api.github.com/users/monnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monnand/subscriptions","organizations_url":"https://api.github.com/users/monnand/orgs","repos_url":"https://api.github.com/users/monnand/repos","events_url":"https://api.github.com/users/monnand/events{/privacy}","received_events_url":"https://api.github.com/users/monnand/received_events","type":"User","site_admin":false},"repo":{"id":20695122,"name":"kubernetes","full_name":"monnand/kubernetes","owner":{"login":"monnand","id":379562,"avatar_url":"https://avatars.githubusercontent.com/u/379562?","gravatar_id":"1f261a013b6a32e6d80a3c3d7cae1586","url":"https://api.github.com/users/monnand","html_url":"https://github.com/monnand","followers_url":"https://api.github.com/users/monnand/followers","following_url":"https://api.github.com/users/monnand/following{/other_user}","gists_url":"https://api.github.com/users/monnand/gists{/gist_id}","starred_url":"https://api.github.com/users/monnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monnand/subscriptions","organizations_url":"https://api.github.com/users/monnand/orgs","repos_url":"https://api.github.com/users/monnand/repos","events_url":"https://api.github.com/users/monnand/events{/privacy}","received_events_url":"https://api.github.com/users/monnand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monnand/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/monnand/kubernetes","forks_url":"https://api.github.com/repos/monnand/kubernetes/forks","keys_url":"https://api.github.com/repos/monnand/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monnand/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monnand/kubernetes/teams","hooks_url":"https://api.github.com/repos/monnand/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/monnand/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/monnand/kubernetes/events","assignees_url":"https://api.github.com/repos/monnand/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/monnand/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/monnand/kubernetes/tags","blobs_url":"https://api.github.com/repos/monnand/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monnand/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monnand/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/monnand/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monnand/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/monnand/kubernetes/languages","stargazers_url":"https://api.github.com/repos/monnand/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/monnand/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/monnand/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/monnand/kubernetes/subscription","commits_url":"https://api.github.com/repos/monnand/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/monnand/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/monnand/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/monnand/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/monnand/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/monnand/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monnand/kubernetes/merges","archive_url":"https://api.github.com/repos/monnand/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monnand/kubernetes/downloads","issues_url":"https://api.github.com/repos/monnand/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/monnand/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/monnand/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/monnand/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monnand/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/monnand/kubernetes/releases{/id}","created_at":"2014-06-10T17:41:28Z","updated_at":"2014-06-30T19:16:37Z","pushed_at":"2014-07-01T01:05:33Z","git_url":"git://github.com/monnand/kubernetes.git","ssh_url":"git@github.com:monnand/kubernetes.git","clone_url":"https://github.com/monnand/kubernetes.git","svn_url":"https://github.com/monnand/kubernetes","homepage":null,"size":5624,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"655bca7e55a232368da51ea7c03b5404f5e57633","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-07-01T00:43:23Z","pushed_at":"2014-07-01T00:13:25Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":9734,"stargazers_count":1664,"watchers_count":1664,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":186,"mirror_url":null,"open_issues_count":82,"forks":186,"open_issues":82,"watchers":1664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/309"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/309"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/309"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/7b432eac5c6530c60c0cca3fc74698af44e3c87e"}}}}