GitHub PullRequestReviewCommentEvent at 2014-06-30 17:22:40
Repository: cjdns
Actor: sj4nz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/comments/14362525","id":14362525,"diff_hunk":"@@ -28,12 +28,15 @@\n \n #define __USE_MISC // for MAP_ANONYMOUS\n #include <sys/mman.h>\n+#include <stdio.h>\n \n // Apple\n #ifndef MAP_ANONYMOUS\n     #define MAP_ANONYMOUS MAP_ANON\n #endif\n \n+static const unsigned long cfgMaxMemoryBytes = 100000000;","path":"util/Security.c","position":11,"original_position":11,"commit_id":"1cb6a13df70939b0254b9cc6cc72b6ec3bfdf1e2","original_commit_id":"1cb6a13df70939b0254b9cc6cc72b6ec3bfdf1e2","user":{"login":"sj4nz","id":1007905,"avatar_url":"https://avatars.githubusercontent.com/u/1007905?","gravatar_id":"6b9880683eb73a6d1c0c9941e8fa07eb","url":"https://api.github.com/users/sj4nz","html_url":"https://github.com/sj4nz","followers_url":"https://api.github.com/users/sj4nz/followers","following_url":"https://api.github.com/users/sj4nz/following{/other_user}","gists_url":"https://api.github.com/users/sj4nz/gists{/gist_id}","starred_url":"https://api.github.com/users/sj4nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sj4nz/subscriptions","organizations_url":"https://api.github.com/users/sj4nz/orgs","repos_url":"https://api.github.com/users/sj4nz/repos","events_url":"https://api.github.com/users/sj4nz/events{/privacy}","received_events_url":"https://api.github.com/users/sj4nz/received_events","type":"User","site_admin":false},"body":"Still reading lots of code to get a handle of how cjdns works internally. :) A different light went on for the core/angel split when I understood that core dropped permissions to talk to the network and angel keeps them to configure the network. \r\n\r\nAlso, Exhuberant Ctags is an absolute must-learn if you live inside of Vim. That's helping a lot.","created_at":"2014-06-30T17:22:40Z","updated_at":"2014-06-30T17:22:40Z","html_url":"https://github.com/cjdelisle/cjdns/pull/577#discussion_r14362525","pull_request_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/577","_links":{"self":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/comments/14362525"},"html":{"href":"https://github.com/cjdelisle/cjdns/pull/577#discussion_r14362525"},"pull_request":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/577"}}},"pull_request":{"url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/577","id":17757451,"html_url":"https://github.com/cjdelisle/cjdns/pull/577","diff_url":"https://github.com/cjdelisle/cjdns/pull/577.diff","patch_url":"https://github.com/cjdelisle/cjdns/pull/577.patch","issue_url":"https://api.github.com/repos/cjdelisle/cjdns/issues/577","number":577,"state":"closed","title":"Freebsd10 memlimit check and overlength-strings error workaround.","user":{"login":"sj4nz","id":1007905,"avatar_url":"https://avatars.githubusercontent.com/u/1007905?","gravatar_id":"6b9880683eb73a6d1c0c9941e8fa07eb","url":"https://api.github.com/users/sj4nz","html_url":"https://github.com/sj4nz","followers_url":"https://api.github.com/users/sj4nz/followers","following_url":"https://api.github.com/users/sj4nz/following{/other_user}","gists_url":"https://api.github.com/users/sj4nz/gists{/gist_id}","starred_url":"https://api.github.com/users/sj4nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sj4nz/subscriptions","organizations_url":"https://api.github.com/users/sj4nz/orgs","repos_url":"https://api.github.com/users/sj4nz/repos","events_url":"https://api.github.com/users/sj4nz/events{/privacy}","received_events_url":"https://api.github.com/users/sj4nz/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-30T06:19:23Z","updated_at":"2014-06-30T17:22:40Z","closed_at":"2014-06-30T07:06:24Z","merged_at":"2014-06-30T07:06:24Z","merge_commit_sha":"c916c0d97df9138fc59b7c103d59c152f0f0ffe5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/577/commits","review_comments_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/577/comments","review_comment_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cjdelisle/cjdns/issues/577/comments","statuses_url":"https://api.github.com/repos/cjdelisle/cjdns/statuses/1cb6a13df70939b0254b9cc6cc72b6ec3bfdf1e2","head":{"label":"sj4nz:memlimit-check","ref":"memlimit-check","sha":"1cb6a13df70939b0254b9cc6cc72b6ec3bfdf1e2","user":{"login":"sj4nz","id":1007905,"avatar_url":"https://avatars.githubusercontent.com/u/1007905?","gravatar_id":"6b9880683eb73a6d1c0c9941e8fa07eb","url":"https://api.github.com/users/sj4nz","html_url":"https://github.com/sj4nz","followers_url":"https://api.github.com/users/sj4nz/followers","following_url":"https://api.github.com/users/sj4nz/following{/other_user}","gists_url":"https://api.github.com/users/sj4nz/gists{/gist_id}","starred_url":"https://api.github.com/users/sj4nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sj4nz/subscriptions","organizations_url":"https://api.github.com/users/sj4nz/orgs","repos_url":"https://api.github.com/users/sj4nz/repos","events_url":"https://api.github.com/users/sj4nz/events{/privacy}","received_events_url":"https://api.github.com/users/sj4nz/received_events","type":"User","site_admin":false},"repo":{"id":3243887,"name":"cjdns","full_name":"sj4nz/cjdns","owner":{"login":"sj4nz","id":1007905,"avatar_url":"https://avatars.githubusercontent.com/u/1007905?","gravatar_id":"6b9880683eb73a6d1c0c9941e8fa07eb","url":"https://api.github.com/users/sj4nz","html_url":"https://github.com/sj4nz","followers_url":"https://api.github.com/users/sj4nz/followers","following_url":"https://api.github.com/users/sj4nz/following{/other_user}","gists_url":"https://api.github.com/users/sj4nz/gists{/gist_id}","starred_url":"https://api.github.com/users/sj4nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sj4nz/subscriptions","organizations_url":"https://api.github.com/users/sj4nz/orgs","repos_url":"https://api.github.com/users/sj4nz/repos","events_url":"https://api.github.com/users/sj4nz/events{/privacy}","received_events_url":"https://api.github.com/users/sj4nz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sj4nz/cjdns","description":"","fork":true,"url":"https://api.github.com/repos/sj4nz/cjdns","forks_url":"https://api.github.com/repos/sj4nz/cjdns/forks","keys_url":"https://api.github.com/repos/sj4nz/cjdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sj4nz/cjdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sj4nz/cjdns/teams","hooks_url":"https://api.github.com/repos/sj4nz/cjdns/hooks","issue_events_url":"https://api.github.com/repos/sj4nz/cjdns/issues/events{/number}","events_url":"https://api.github.com/repos/sj4nz/cjdns/events","assignees_url":"https://api.github.com/repos/sj4nz/cjdns/assignees{/user}","branches_url":"https://api.github.com/repos/sj4nz/cjdns/branches{/branch}","tags_url":"https://api.github.com/repos/sj4nz/cjdns/tags","blobs_url":"https://api.github.com/repos/sj4nz/cjdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sj4nz/cjdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sj4nz/cjdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/sj4nz/cjdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sj4nz/cjdns/statuses/{sha}","languages_url":"https://api.github.com/repos/sj4nz/cjdns/languages","stargazers_url":"https://api.github.com/repos/sj4nz/cjdns/stargazers","contributors_url":"https://api.github.com/repos/sj4nz/cjdns/contributors","subscribers_url":"https://api.github.com/repos/sj4nz/cjdns/subscribers","subscription_url":"https://api.github.com/repos/sj4nz/cjdns/subscription","commits_url":"https://api.github.com/repos/sj4nz/cjdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/sj4nz/cjdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/sj4nz/cjdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/sj4nz/cjdns/issues/comments/{number}","contents_url":"https://api.github.com/repos/sj4nz/cjdns/contents/{+path}","compare_url":"https://api.github.com/repos/sj4nz/cjdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sj4nz/cjdns/merges","archive_url":"https://api.github.com/repos/sj4nz/cjdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sj4nz/cjdns/downloads","issues_url":"https://api.github.com/repos/sj4nz/cjdns/issues{/number}","pulls_url":"https://api.github.com/repos/sj4nz/cjdns/pulls{/number}","milestones_url":"https://api.github.com/repos/sj4nz/cjdns/milestones{/number}","notifications_url":"https://api.github.com/repos/sj4nz/cjdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sj4nz/cjdns/labels{/name}","releases_url":"https://api.github.com/repos/sj4nz/cjdns/releases{/id}","created_at":"2012-01-23T02:59:34Z","updated_at":"2014-06-26T03:38:35Z","pushed_at":"2014-06-30T15:41:33Z","git_url":"git://github.com/sj4nz/cjdns.git","ssh_url":"git@github.com:sj4nz/cjdns.git","clone_url":"https://github.com/sj4nz/cjdns.git","svn_url":"https://github.com/sj4nz/cjdns","homepage":"","size":7388,"stargazers_count":2,"watchers_count":2,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cjdelisle:crashey","ref":"crashey","sha":"19b60e0dcabb7ade57fc47f56be0d2da4f3ca5c7","user":{"login":"cjdelisle","id":509047,"avatar_url":"https://avatars.githubusercontent.com/u/509047?","gravatar_id":"3a8fb5954ff45e40b0964c174df97ae0","url":"https://api.github.com/users/cjdelisle","html_url":"https://github.com/cjdelisle","followers_url":"https://api.github.com/users/cjdelisle/followers","following_url":"https://api.github.com/users/cjdelisle/following{/other_user}","gists_url":"https://api.github.com/users/cjdelisle/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdelisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdelisle/subscriptions","organizations_url":"https://api.github.com/users/cjdelisle/orgs","repos_url":"https://api.github.com/users/cjdelisle/repos","events_url":"https://api.github.com/users/cjdelisle/events{/privacy}","received_events_url":"https://api.github.com/users/cjdelisle/received_events","type":"User","site_admin":false},"repo":{"id":1376101,"name":"cjdns","full_name":"cjdelisle/cjdns","owner":{"login":"cjdelisle","id":509047,"avatar_url":"https://avatars.githubusercontent.com/u/509047?","gravatar_id":"3a8fb5954ff45e40b0964c174df97ae0","url":"https://api.github.com/users/cjdelisle","html_url":"https://github.com/cjdelisle","followers_url":"https://api.github.com/users/cjdelisle/followers","following_url":"https://api.github.com/users/cjdelisle/following{/other_user}","gists_url":"https://api.github.com/users/cjdelisle/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdelisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdelisle/subscriptions","organizations_url":"https://api.github.com/users/cjdelisle/orgs","repos_url":"https://api.github.com/users/cjdelisle/repos","events_url":"https://api.github.com/users/cjdelisle/events{/privacy}","received_events_url":"https://api.github.com/users/cjdelisle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjdelisle/cjdns","description":"","fork":false,"url":"https://api.github.com/repos/cjdelisle/cjdns","forks_url":"https://api.github.com/repos/cjdelisle/cjdns/forks","keys_url":"https://api.github.com/repos/cjdelisle/cjdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjdelisle/cjdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjdelisle/cjdns/teams","hooks_url":"https://api.github.com/repos/cjdelisle/cjdns/hooks","issue_events_url":"https://api.github.com/repos/cjdelisle/cjdns/issues/events{/number}","events_url":"https://api.github.com/repos/cjdelisle/cjdns/events","assignees_url":"https://api.github.com/repos/cjdelisle/cjdns/assignees{/user}","branches_url":"https://api.github.com/repos/cjdelisle/cjdns/branches{/branch}","tags_url":"https://api.github.com/repos/cjdelisle/cjdns/tags","blobs_url":"https://api.github.com/repos/cjdelisle/cjdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjdelisle/cjdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjdelisle/cjdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjdelisle/cjdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjdelisle/cjdns/statuses/{sha}","languages_url":"https://api.github.com/repos/cjdelisle/cjdns/languages","stargazers_url":"https://api.github.com/repos/cjdelisle/cjdns/stargazers","contributors_url":"https://api.github.com/repos/cjdelisle/cjdns/contributors","subscribers_url":"https://api.github.com/repos/cjdelisle/cjdns/subscribers","subscription_url":"https://api.github.com/repos/cjdelisle/cjdns/subscription","commits_url":"https://api.github.com/repos/cjdelisle/cjdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjdelisle/cjdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjdelisle/cjdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjdelisle/cjdns/issues/comments/{number}","contents_url":"https://api.github.com/repos/cjdelisle/cjdns/contents/{+path}","compare_url":"https://api.github.com/repos/cjdelisle/cjdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjdelisle/cjdns/merges","archive_url":"https://api.github.com/repos/cjdelisle/cjdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjdelisle/cjdns/downloads","issues_url":"https://api.github.com/repos/cjdelisle/cjdns/issues{/number}","pulls_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls{/number}","milestones_url":"https://api.github.com/repos/cjdelisle/cjdns/milestones{/number}","notifications_url":"https://api.github.com/repos/cjdelisle/cjdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjdelisle/cjdns/labels{/name}","releases_url":"https://api.github.com/repos/cjdelisle/cjdns/releases{/id}","created_at":"2011-02-16T23:03:45Z","updated_at":"2014-06-29T00:51:32Z","pushed_at":"2014-06-30T07:16:43Z","git_url":"git://github.com/cjdelisle/cjdns.git","ssh_url":"git@github.com:cjdelisle/cjdns.git","clone_url":"https://github.com/cjdelisle/cjdns.git","svn_url":"https://github.com/cjdelisle/cjdns","homepage":"","size":24819,"stargazers_count":1264,"watchers_count":1264,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":196,"mirror_url":null,"open_issues_count":79,"forks":196,"open_issues":79,"watchers":1264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/577"},"html":{"href":"https://github.com/cjdelisle/cjdns/pull/577"},"issue":{"href":"https://api.github.com/repos/cjdelisle/cjdns/issues/577"},"comments":{"href":"https://api.github.com/repos/cjdelisle/cjdns/issues/577/comments"},"review_comments":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/577/comments"},"review_comment":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/577/commits"},"statuses":{"href":"https://api.github.com/repos/cjdelisle/cjdns/statuses/1cb6a13df70939b0254b9cc6cc72b6ec3bfdf1e2"}}}}