GitHub PullRequestEvent at 2014-10-13 11:37:51
Repository: connectionagent
Actor: monich
Payload: {"action":"closed","number":90,"pull_request":{"url":"https://api.github.com/repos/nemomobile/connectionagent/pulls/90","id":22560205,"html_url":"https://github.com/nemomobile/connectionagent/pull/90","diff_url":"https://github.com/nemomobile/connectionagent/pull/90.diff","patch_url":"https://github.com/nemomobile/connectionagent/pull/90.patch","issue_url":"https://api.github.com/repos/nemomobile/connectionagent/issues/90","number":90,"state":"closed","locked":false,"title":"Tweak connection dialog behavior","user":{"login":"monich","id":5909522,"avatar_url":"https://avatars.githubusercontent.com/u/5909522?v=2","gravatar_id":"","url":"https://api.github.com/users/monich","html_url":"https://github.com/monich","followers_url":"https://api.github.com/users/monich/followers","following_url":"https://api.github.com/users/monich/following{/other_user}","gists_url":"https://api.github.com/users/monich/gists{/gist_id}","starred_url":"https://api.github.com/users/monich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monich/subscriptions","organizations_url":"https://api.github.com/users/monich/orgs","repos_url":"https://api.github.com/users/monich/repos","events_url":"https://api.github.com/users/monich/events{/privacy}","received_events_url":"https://api.github.com/users/monich/received_events","type":"User","site_admin":false},"body":"Silently fail the request if no services of the requested type is found. Particularly, this fixes the following scenario:\r\n\r\n1. Mobile data is not available; and\r\n2. Mobile data connection is explicitly requested (for AGPS)\r\n\r\nThat would pop up a connection selector with WiFi as the only option regardless of whether or not WiFi is currently connected. That makes no sense.","created_at":"2014-10-10T13:30:48Z","updated_at":"2014-10-13T11:37:51Z","closed_at":"2014-10-13T11:37:51Z","merged_at":"2014-10-13T11:37:51Z","merge_commit_sha":"57b205ca3318bff0430ac0a53a55c1812f24da45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile/connectionagent/pulls/90/commits","review_comments_url":"https://api.github.com/repos/nemomobile/connectionagent/pulls/90/comments","review_comment_url":"https://api.github.com/repos/nemomobile/connectionagent/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nemomobile/connectionagent/issues/90/comments","statuses_url":"https://api.github.com/repos/nemomobile/connectionagent/statuses/3dee8034d2565400b8f14c2ac7e6371e422770ef","head":{"label":"monich:connectToType","ref":"connectToType","sha":"3dee8034d2565400b8f14c2ac7e6371e422770ef","user":{"login":"monich","id":5909522,"avatar_url":"https://avatars.githubusercontent.com/u/5909522?v=2","gravatar_id":"","url":"https://api.github.com/users/monich","html_url":"https://github.com/monich","followers_url":"https://api.github.com/users/monich/followers","following_url":"https://api.github.com/users/monich/following{/other_user}","gists_url":"https://api.github.com/users/monich/gists{/gist_id}","starred_url":"https://api.github.com/users/monich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monich/subscriptions","organizations_url":"https://api.github.com/users/monich/orgs","repos_url":"https://api.github.com/users/monich/repos","events_url":"https://api.github.com/users/monich/events{/privacy}","received_events_url":"https://api.github.com/users/monich/received_events","type":"User","site_admin":false},"repo":{"id":20642417,"name":"connectionagent","full_name":"monich/connectionagent","owner":{"login":"monich","id":5909522,"avatar_url":"https://avatars.githubusercontent.com/u/5909522?v=2","gravatar_id":"","url":"https://api.github.com/users/monich","html_url":"https://github.com/monich","followers_url":"https://api.github.com/users/monich/followers","following_url":"https://api.github.com/users/monich/following{/other_user}","gists_url":"https://api.github.com/users/monich/gists{/gist_id}","starred_url":"https://api.github.com/users/monich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monich/subscriptions","organizations_url":"https://api.github.com/users/monich/orgs","repos_url":"https://api.github.com/users/monich/repos","events_url":"https://api.github.com/users/monich/events{/privacy}","received_events_url":"https://api.github.com/users/monich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monich/connectionagent","description":"","fork":true,"url":"https://api.github.com/repos/monich/connectionagent","forks_url":"https://api.github.com/repos/monich/connectionagent/forks","keys_url":"https://api.github.com/repos/monich/connectionagent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monich/connectionagent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monich/connectionagent/teams","hooks_url":"https://api.github.com/repos/monich/connectionagent/hooks","issue_events_url":"https://api.github.com/repos/monich/connectionagent/issues/events{/number}","events_url":"https://api.github.com/repos/monich/connectionagent/events","assignees_url":"https://api.github.com/repos/monich/connectionagent/assignees{/user}","branches_url":"https://api.github.com/repos/monich/connectionagent/branches{/branch}","tags_url":"https://api.github.com/repos/monich/connectionagent/tags","blobs_url":"https://api.github.com/repos/monich/connectionagent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monich/connectionagent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monich/connectionagent/git/refs{/sha}","trees_url":"https://api.github.com/repos/monich/connectionagent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monich/connectionagent/statuses/{sha}","languages_url":"https://api.github.com/repos/monich/connectionagent/languages","stargazers_url":"https://api.github.com/repos/monich/connectionagent/stargazers","contributors_url":"https://api.github.com/repos/monich/connectionagent/contributors","subscribers_url":"https://api.github.com/repos/monich/connectionagent/subscribers","subscription_url":"https://api.github.com/repos/monich/connectionagent/subscription","commits_url":"https://api.github.com/repos/monich/connectionagent/commits{/sha}","git_commits_url":"https://api.github.com/repos/monich/connectionagent/git/commits{/sha}","comments_url":"https://api.github.com/repos/monich/connectionagent/comments{/number}","issue_comment_url":"https://api.github.com/repos/monich/connectionagent/issues/comments/{number}","contents_url":"https://api.github.com/repos/monich/connectionagent/contents/{+path}","compare_url":"https://api.github.com/repos/monich/connectionagent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monich/connectionagent/merges","archive_url":"https://api.github.com/repos/monich/connectionagent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monich/connectionagent/downloads","issues_url":"https://api.github.com/repos/monich/connectionagent/issues{/number}","pulls_url":"https://api.github.com/repos/monich/connectionagent/pulls{/number}","milestones_url":"https://api.github.com/repos/monich/connectionagent/milestones{/number}","notifications_url":"https://api.github.com/repos/monich/connectionagent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monich/connectionagent/labels{/name}","releases_url":"https://api.github.com/repos/monich/connectionagent/releases{/id}","created_at":"2014-06-09T10:18:03Z","updated_at":"2014-07-22T12:47:54Z","pushed_at":"2014-10-10T19:03:57Z","git_url":"git://github.com/monich/connectionagent.git","ssh_url":"git@github.com:monich/connectionagent.git","clone_url":"https://github.com/monich/connectionagent.git","svn_url":"https://github.com/monich/connectionagent","homepage":null,"size":518,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nemomobile:master","ref":"master","sha":"fd5262e78a9478a1e093c8b6680ea6930f274240","user":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=2","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9354503,"name":"connectionagent","full_name":"nemomobile/connectionagent","owner":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=2","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile/connectionagent","description":"","fork":false,"url":"https://api.github.com/repos/nemomobile/connectionagent","forks_url":"https://api.github.com/repos/nemomobile/connectionagent/forks","keys_url":"https://api.github.com/repos/nemomobile/connectionagent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile/connectionagent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile/connectionagent/teams","hooks_url":"https://api.github.com/repos/nemomobile/connectionagent/hooks","issue_events_url":"https://api.github.com/repos/nemomobile/connectionagent/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile/connectionagent/events","assignees_url":"https://api.github.com/repos/nemomobile/connectionagent/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile/connectionagent/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile/connectionagent/tags","blobs_url":"https://api.github.com/repos/nemomobile/connectionagent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile/connectionagent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile/connectionagent/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile/connectionagent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile/connectionagent/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile/connectionagent/languages","stargazers_url":"https://api.github.com/repos/nemomobile/connectionagent/stargazers","contributors_url":"https://api.github.com/repos/nemomobile/connectionagent/contributors","subscribers_url":"https://api.github.com/repos/nemomobile/connectionagent/subscribers","subscription_url":"https://api.github.com/repos/nemomobile/connectionagent/subscription","commits_url":"https://api.github.com/repos/nemomobile/connectionagent/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile/connectionagent/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile/connectionagent/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile/connectionagent/issues/comments/{number}","contents_url":"https://api.github.com/repos/nemomobile/connectionagent/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile/connectionagent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile/connectionagent/merges","archive_url":"https://api.github.com/repos/nemomobile/connectionagent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile/connectionagent/downloads","issues_url":"https://api.github.com/repos/nemomobile/connectionagent/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile/connectionagent/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile/connectionagent/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile/connectionagent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile/connectionagent/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile/connectionagent/releases{/id}","created_at":"2013-04-10T19:48:41Z","updated_at":"2014-09-09T19:05:15Z","pushed_at":"2014-10-13T11:37:51Z","git_url":"git://github.com/nemomobile/connectionagent.git","ssh_url":"git@github.com:nemomobile/connectionagent.git","clone_url":"https://github.com/nemomobile/connectionagent.git","svn_url":"https://github.com/nemomobile/connectionagent","homepage":null,"size":2483,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":0,"forks":16,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile/connectionagent/pulls/90"},"html":{"href":"https://github.com/nemomobile/connectionagent/pull/90"},"issue":{"href":"https://api.github.com/repos/nemomobile/connectionagent/issues/90"},"comments":{"href":"https://api.github.com/repos/nemomobile/connectionagent/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile/connectionagent/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile/connectionagent/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nemomobile/connectionagent/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile/connectionagent/statuses/3dee8034d2565400b8f14c2ac7e6371e422770ef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"monich","id":5909522,"avatar_url":"https://avatars.githubusercontent.com/u/5909522?v=2","gravatar_id":"","url":"https://api.github.com/users/monich","html_url":"https://github.com/monich","followers_url":"https://api.github.com/users/monich/followers","following_url":"https://api.github.com/users/monich/following{/other_user}","gists_url":"https://api.github.com/users/monich/gists{/gist_id}","starred_url":"https://api.github.com/users/monich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monich/subscriptions","organizations_url":"https://api.github.com/users/monich/orgs","repos_url":"https://api.github.com/users/monich/repos","events_url":"https://api.github.com/users/monich/events{/privacy}","received_events_url":"https://api.github.com/users/monich/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":12,"deletions":8,"changed_files":1}}