GitHub PullRequestReviewCommentEvent at 2014-05-15 12:44:28
Repository: hellolily
Actor: ptouset
Payload: {"comment":{"url":"https://api.github.com/repos/HelloLily/hellolily/pulls/comments/12686309","id":12686309,"diff_hunk":"@@ -1,79 +1,79 @@\n {% load i18n bootstrap3 formset_tags %}\n \n <div class=\"address_formset_wrapper\" id=\"addresses\">\n-    <div class=\"form-group\">\n-        <label class=\"col-md-2 control-label\">{{ label }}</label>\n-        <div class=\"col-md-10 formset\" data-formset-prefix=\"{{ formset.prefix }}\">\n-            {{ formset.management_form }}\n+    <div class=\"formset\" data-formset-prefix=\"{{ formset.prefix }}\">\n+        {{ formset.management_form }}\n \n-            <div data-formset-body>\n-                <!-- New forms will be inserted in here -->\n-                {% for form in formset %}\n-                    <div data-formset-form>\n-                        {% for field in form.hidden_fields %}\n-                            {{ field }}\n-                        {% endfor %}\n-                        <div class=\"form-group\">\n-                            {% bootstrap_field form.street layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n-                            {% bootstrap_field form.street_number layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-2\" show_label=False %}\n-                            {% bootstrap_field form.complement layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-2\" show_label=False %}\n-\n-                            {% if formset.can_delete %}\n-                                <div class=\"col-md-1\">\n-                                    <a href=\"javascript:void(0)\" data-formset-undo-delete class=\"btn btn-sm green hidden\">\n-                                        <i class=\"icon-undo\"></i>\n-                                    </a>\n-                                    <a href=\"javascript:void(0)\" data-formset-delete-button class=\"btn btn-sm red\">\n-                                        <i class=\"icon-trash\"></i>\n-                                    </a>\n-                                    {% bootstrap_field form.DELETE form_group_class=\"form-group-inline hidden\" %}\n-                                </div>\n-                            {% endif %}\n-                        </div>\n-                        <div class=\"form-group\">\n-                            {% bootstrap_field form.postal_code layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n-                            {% bootstrap_field form.city layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n-                        </div>\n-                        <div class=\"form-group\">\n-                            {% bootstrap_field form.country layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n-                            {% bootstrap_field form.type layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n-                        </div>\n-                    </div>\n-                {% endfor %}\n-            </div>\n-            <div class=\"form-group\">\n-                <div class=\"col-md-12 form-control-static\">\n-                    <a href=\"javascript:;\" data-formset-add>{% trans 'Add an address' %}</a>\n-                </div>\n-            </div>\n-            <!-- The empty form template. By wrapping this in a <script> tag, the __prefix__ placeholder can easily be replaced in both attributes and any scripts -->\n-            <script type=\"form-template\" data-formset-empty-form>\n+        <div data-formset-body>\n+            <!-- New forms will be inserted in here -->\n+            {% for form in formset %}\n                 <div data-formset-form>\n+                    {% for field in form.hidden_fields %}\n+                        {{ field }}\n+                    {% endfor %}\n                     <div class=\"form-group\">\n-                        {% bootstrap_field formset.empty_form.street layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n-                        {% bootstrap_field formset.empty_form.street_number layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-2\" show_label=False %}\n-                        {% bootstrap_field formset.empty_form.complement layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-2\" show_label=False %}\n+                        {% bootstrap_field form.street layout=\"horizontal\" form_group_class=\"form-group-inline\" %}\n+                        {% bootstrap_field form.street_number layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-2\" show_label=False %}\n+                        {% bootstrap_field form.complement layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-1\" show_label=False %}\n \n-                        <div class=\"col-md-1\">\n-                            <a href=\"javascript:void(0)\" data-formset-undo-delete class=\"btn btn-sm green hidden\">\n-                                <i class=\"icon-undo\"></i>\n-                            </a>\n-                            <a href=\"javascript:void(0)\" data-formset-delete-button class=\"btn btn-sm red\" title=\"\">\n-                                <i class=\"icon-trash\"></i>\n-                            </a>\n-                            {% bootstrap_field formset.empty_form.DELETE form_group_class=\"form-group-inline hidden\" %}\n-                        </div>\n+                        {% if formset.can_delete %}\n+                            <div class=\"col-md-1\">\n+                                <a href=\"javascript:void(0)\" data-formset-undo-delete class=\"btn btn-sm default hidden\">\n+                                    <i class=\"icon-undo\"></i>\n+                                </a>\n+                                <a href=\"javascript:void(0)\" data-formset-delete-button class=\"btn btn-sm default\">\n+                                    <i class=\"icon-trash\"></i>\n+                                </a>\n+                                {% bootstrap_field form.DELETE form_group_class=\"form-group-inline hidden\" %}\n+                            </div>\n+                        {% endif %}\n                     </div>\n                     <div class=\"form-group\">\n-                        {% bootstrap_field formset.empty_form.postal_code layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n-                        {% bootstrap_field formset.empty_form.city layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n+                        {% bootstrap_field form.postal_code layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-4 col-md-offset-2\" show_label=False %}\n+                        {% bootstrap_field form.city layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-3\" show_label=False %}\n                     </div>\n                     <div class=\"form-group\">\n-                        {% bootstrap_field formset.empty_form.country layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n-                        {% bootstrap_field formset.empty_form.type layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n+                        {% bootstrap_field form.country layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-4 col-md-offset-2\" show_label=False %}\n+                        {% bootstrap_field form.type layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-3\" show_label=False %}\n                     </div>\n                 </div>\n-            </script>\n+            {% endfor %}\n         </div>\n+         <div class=\"form-group add-link\">\n+             <label class=\"col-md-2 control-label{% if formset|length %} hide{% endif %}\">\n+                 {{ formset.empty_form.street.label }}\n+             </label>\n+             <div class=\"col-md-10 form-control-static{% if formset|length %} col-md-offset-2{% endif %}\">\n+                 <a href=\"javascript:;\" data-formset-add>{% trans 'Add an address' %}</a>\n+             </div>\n+         </div>\n+        <!-- The empty form template. By wrapping this in a <script> tag, the __prefix__ placeholder can easily be replaced in both attributes and any scripts -->\n+        <script type=\"form-template\" data-formset-empty-form>\n+            <div data-formset-form>\n+                <div class=\"form-group\">\n+                    {% bootstrap_field formset.empty_form.street layout=\"horizontal\" form_group_class=\"form-group-inline\" %}\n+                    {% bootstrap_field formset.empty_form.street_number layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-2\" show_label=False %}\n+                    {% bootstrap_field formset.empty_form.complement layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-2\" show_label=False %}\n+\n+                    <div class=\"col-md-1\">\n+                        <a href=\"javascript:void(0)\" data-formset-undo-delete class=\"btn btn-sm default hidden\">\n+                            <i class=\"icon-undo\"></i>\n+                        </a>\n+                        <a href=\"javascript:void(0)\" data-formset-delete-button class=\"btn btn-sm default\" title=\"\">\n+                            <i class=\"icon-trash\"></i>\n+                        </a>\n+                        {% bootstrap_field formset.empty_form.DELETE form_group_class=\"form-group-inline hidden\" %}\n+                    </div>\n+                </div>\n+                <div class=\"form-group\">\n+                    {% bootstrap_field formset.empty_form.postal_code layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-4 col-md-offset-2\" show_label=False %}\n+                    {% bootstrap_field formset.empty_form.city layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n+                </div>\n+                <div class=\"form-group\">\n+                    {% bootstrap_field formset.empty_form.country layout=\"horizontal\" form_group_class=\"form-group-inline\" field_class=\"col-md-4 col-md-offset-2\" show_label=False %}\n+                    {% bootstrap_field formset.empty_form.type layout=\"horizontal\" form_group_class=\"form-group-inline\" show_label=False %}\n+                </div>\n+            </div>\n+        </script>\n     </div>\n-</div>\n+</div>","path":"lily/utils/templates/utils/formset_address.html","position":143,"original_position":143,"commit_id":"feb97b826ed3fc1a35bdc84e605ed3f06af479ce","original_commit_id":"feb97b826ed3fc1a35bdc84e605ed3f06af479ce","user":{"login":"ptouset","id":939569,"avatar_url":"https://avatars.githubusercontent.com/u/939569?","gravatar_id":"e0bca5568268ff00ce613216f4c3dd73","url":"https://api.github.com/users/ptouset","html_url":"https://github.com/ptouset","followers_url":"https://api.github.com/users/ptouset/followers","following_url":"https://api.github.com/users/ptouset/following{/other_user}","gists_url":"https://api.github.com/users/ptouset/gists{/gist_id}","starred_url":"https://api.github.com/users/ptouset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptouset/subscriptions","organizations_url":"https://api.github.com/users/ptouset/orgs","repos_url":"https://api.github.com/users/ptouset/repos","events_url":"https://api.github.com/users/ptouset/events{/privacy}","received_events_url":"https://api.github.com/users/ptouset/received_events","type":"User","site_admin":false},"body":"Laatste newline is weggehaald, ook in andere files in deze pull request. Ik vind het persoonlijk geen probleem, maar ik weet niet wat onze standaard hierin is.","created_at":"2014-05-15T12:44:28Z","updated_at":"2014-05-15T12:44:28Z","html_url":"https://github.com/HelloLily/hellolily/pull/13#discussion_r12686309","pull_request_url":"https://api.github.com/repos/HelloLily/hellolily/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/HelloLily/hellolily/pulls/comments/12686309"},"html":{"href":"https://github.com/HelloLily/hellolily/pull/13#discussion_r12686309"},"pull_request":{"href":"https://api.github.com/repos/HelloLily/hellolily/pulls/13"}}}}