GitHub PullRequestReviewCommentEvent at 2014-11-03 23:07:19
Repository: tritium
Actor: xanthousphoenix
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/moovweb/tritium/pulls/comments/19774546","id":19774546,"diff_hunk":"@@ -340,67 +341,147 @@ func convert_encoding_Text_Text(ctx *EngineContext, scope *Scope, ins protoface.\n }\n \n func xml_Text_Text(ctx *EngineContext, scope *Scope, ins protoface.Instruction, args []interface{}) (returnValue interface{}) {\n+\treturn xml_libxml_legacy_Text_Text(ctx, scope, ins, args)\n+}\n+\n+func xml_libxml_legacy_Text_Text(ctx *EngineContext, scope *Scope, ins protoface.Instruction, args []interface{}) (returnValue interface{}) {\n \tinput := scope.Value.(string)\n-\tdoc, err := xml.Parse([]byte(input), nil, nil, xml.DefaultParseOption, nil)\n+\n+\txform := goku_legacy.NewXForm()\n+\terr := xform.ParseXML([]byte(input), nil, nil, nil)\n \tif err != nil {\n-\t\tLogEngineError(ctx, \"xml err: \"+err.Error())\n+\t\tLogEngineError(ctx, \"html_doc err: \"+err.Error())\n \t\treturnValue = \"false\"\n \t\treturn\n \t}\n \n-\tif doc == nil {\n-\t\tLogEngineError(ctx, \"xml err: nil doc\")\n+\tctx.AddMemoryObject(xform)\n+\tprevxform := ctx.HtmlTransformer\n+\tctx.HtmlTransformer = xform\n+\n+\txmldoc, _ := xform.Root()\n+\n+\tns := &Scope{Value: xmldoc}\n+\n+\tfor i := 0; i < ins.INumChildren(); i++ {\n+\t\tchild := ins.IGetNthChild(i)\n+\t\tctx.RunInstruction(ns, child)\n+\t}\n+\n+\tscope.Value = xform.String()\n+\t// ctx.CurrentDoc = nil","path":"whale/functions.go","position":57,"original_position":57,"commit_id":"0a965095dad1f2b530cbe64cd8dc159c433a4228","original_commit_id":"0a965095dad1f2b530cbe64cd8dc159c433a4228","user":{"login":"xanthousphoenix","id":4483846,"avatar_url":"https://avatars.githubusercontent.com/u/4483846?v=2","gravatar_id":"","url":"https://api.github.com/users/xanthousphoenix","html_url":"https://github.com/xanthousphoenix","followers_url":"https://api.github.com/users/xanthousphoenix/followers","following_url":"https://api.github.com/users/xanthousphoenix/following{/other_user}","gists_url":"https://api.github.com/users/xanthousphoenix/gists{/gist_id}","starred_url":"https://api.github.com/users/xanthousphoenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xanthousphoenix/subscriptions","organizations_url":"https://api.github.com/users/xanthousphoenix/orgs","repos_url":"https://api.github.com/users/xanthousphoenix/repos","events_url":"https://api.github.com/users/xanthousphoenix/events{/privacy}","received_events_url":"https://api.github.com/users/xanthousphoenix/received_events","type":"User","site_admin":false},"body":"This'll be the last comment on it, but there's more commented out code in the PR. Cruft, though non-functional, adds to the upkeep cost of the code. We want it removed.","created_at":"2014-11-03T23:07:19Z","updated_at":"2014-11-03T23:07:19Z","html_url":"https://github.com/moovweb/tritium/pull/45#discussion_r19774546","pull_request_url":"https://api.github.com/repos/moovweb/tritium/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/moovweb/tritium/pulls/comments/19774546"},"html":{"href":"https://github.com/moovweb/tritium/pull/45#discussion_r19774546"},"pull_request":{"href":"https://api.github.com/repos/moovweb/tritium/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/moovweb/tritium/pulls/45","id":23797694,"html_url":"https://github.com/moovweb/tritium/pull/45","diff_url":"https://github.com/moovweb/tritium/pull/45.diff","patch_url":"https://github.com/moovweb/tritium/pull/45.patch","issue_url":"https://api.github.com/repos/moovweb/tritium/issues/45","number":45,"state":"open","locked":false,"title":"Libxml upgrade","user":{"login":"wonja","id":464799,"avatar_url":"https://avatars.githubusercontent.com/u/464799?v=2","gravatar_id":"","url":"https://api.github.com/users/wonja","html_url":"https://github.com/wonja","followers_url":"https://api.github.com/users/wonja/followers","following_url":"https://api.github.com/users/wonja/following{/other_user}","gists_url":"https://api.github.com/users/wonja/gists{/gist_id}","starred_url":"https://api.github.com/users/wonja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonja/subscriptions","organizations_url":"https://api.github.com/users/wonja/orgs","repos_url":"https://api.github.com/users/wonja/repos","events_url":"https://api.github.com/users/wonja/events{/privacy}","received_events_url":"https://api.github.com/users/wonja/received_events","type":"User","site_admin":false},"body":"Creating a generic interface between Tritium and Gokogiri (https://moovweb.atlassian.net/browse/PFST-49)","created_at":"2014-11-03T22:43:07Z","updated_at":"2014-11-03T23:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"607117b2278aecee4ca3936d8b539f0a28262fd0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moovweb/tritium/pulls/45/commits","review_comments_url":"https://api.github.com/repos/moovweb/tritium/pulls/45/comments","review_comment_url":"https://api.github.com/repos/moovweb/tritium/pulls/comments/{number}","comments_url":"https://api.github.com/repos/moovweb/tritium/issues/45/comments","statuses_url":"https://api.github.com/repos/moovweb/tritium/statuses/0a965095dad1f2b530cbe64cd8dc159c433a4228","head":{"label":"moovweb:libxml_upgrade","ref":"libxml_upgrade","sha":"0a965095dad1f2b530cbe64cd8dc159c433a4228","user":{"login":"moovweb","id":78455,"avatar_url":"https://avatars.githubusercontent.com/u/78455?v=2","gravatar_id":"","url":"https://api.github.com/users/moovweb","html_url":"https://github.com/moovweb","followers_url":"https://api.github.com/users/moovweb/followers","following_url":"https://api.github.com/users/moovweb/following{/other_user}","gists_url":"https://api.github.com/users/moovweb/gists{/gist_id}","starred_url":"https://api.github.com/users/moovweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moovweb/subscriptions","organizations_url":"https://api.github.com/users/moovweb/orgs","repos_url":"https://api.github.com/users/moovweb/repos","events_url":"https://api.github.com/users/moovweb/events{/privacy}","received_events_url":"https://api.github.com/users/moovweb/received_events","type":"Organization","site_admin":false},"repo":{"id":1730088,"name":"tritium","full_name":"moovweb/tritium","owner":{"login":"moovweb","id":78455,"avatar_url":"https://avatars.githubusercontent.com/u/78455?v=2","gravatar_id":"","url":"https://api.github.com/users/moovweb","html_url":"https://github.com/moovweb","followers_url":"https://api.github.com/users/moovweb/followers","following_url":"https://api.github.com/users/moovweb/following{/other_user}","gists_url":"https://api.github.com/users/moovweb/gists{/gist_id}","starred_url":"https://api.github.com/users/moovweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moovweb/subscriptions","organizations_url":"https://api.github.com/users/moovweb/orgs","repos_url":"https://api.github.com/users/moovweb/repos","events_url":"https://api.github.com/users/moovweb/events{/privacy}","received_events_url":"https://api.github.com/users/moovweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moovweb/tritium","description":"Tritium is a magical document modifying language. It's JavaScript-like and simple to learn. Think XSLT without the nightmare. It was designed by Hampton Catlin (@hcatlin), and has been heavily influenced by Aaron Leung (@akhleung).","fork":false,"url":"https://api.github.com/repos/moovweb/tritium","forks_url":"https://api.github.com/repos/moovweb/tritium/forks","keys_url":"https://api.github.com/repos/moovweb/tritium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moovweb/tritium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moovweb/tritium/teams","hooks_url":"https://api.github.com/repos/moovweb/tritium/hooks","issue_events_url":"https://api.github.com/repos/moovweb/tritium/issues/events{/number}","events_url":"https://api.github.com/repos/moovweb/tritium/events","assignees_url":"https://api.github.com/repos/moovweb/tritium/assignees{/user}","branches_url":"https://api.github.com/repos/moovweb/tritium/branches{/branch}","tags_url":"https://api.github.com/repos/moovweb/tritium/tags","blobs_url":"https://api.github.com/repos/moovweb/tritium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moovweb/tritium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moovweb/tritium/git/refs{/sha}","trees_url":"https://api.github.com/repos/moovweb/tritium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moovweb/tritium/statuses/{sha}","languages_url":"https://api.github.com/repos/moovweb/tritium/languages","stargazers_url":"https://api.github.com/repos/moovweb/tritium/stargazers","contributors_url":"https://api.github.com/repos/moovweb/tritium/contributors","subscribers_url":"https://api.github.com/repos/moovweb/tritium/subscribers","subscription_url":"https://api.github.com/repos/moovweb/tritium/subscription","commits_url":"https://api.github.com/repos/moovweb/tritium/commits{/sha}","git_commits_url":"https://api.github.com/repos/moovweb/tritium/git/commits{/sha}","comments_url":"https://api.github.com/repos/moovweb/tritium/comments{/number}","issue_comment_url":"https://api.github.com/repos/moovweb/tritium/issues/comments/{number}","contents_url":"https://api.github.com/repos/moovweb/tritium/contents/{+path}","compare_url":"https://api.github.com/repos/moovweb/tritium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moovweb/tritium/merges","archive_url":"https://api.github.com/repos/moovweb/tritium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moovweb/tritium/downloads","issues_url":"https://api.github.com/repos/moovweb/tritium/issues{/number}","pulls_url":"https://api.github.com/repos/moovweb/tritium/pulls{/number}","milestones_url":"https://api.github.com/repos/moovweb/tritium/milestones{/number}","notifications_url":"https://api.github.com/repos/moovweb/tritium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moovweb/tritium/labels{/name}","releases_url":"https://api.github.com/repos/moovweb/tritium/releases{/id}","created_at":"2011-05-10T20:55:27Z","updated_at":"2014-10-22T02:22:05Z","pushed_at":"2014-11-03T22:48:36Z","git_url":"git://github.com/moovweb/tritium.git","ssh_url":"git@github.com:moovweb/tritium.git","clone_url":"https://github.com/moovweb/tritium.git","svn_url":"https://github.com/moovweb/tritium","homepage":"http://tritium.io","size":23082,"stargazers_count":27,"watchers_count":27,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":27,"default_branch":"master"}},"base":{"label":"moovweb:master","ref":"master","sha":"d8a370fdc8b6942d0de2c69662f137d77657e83f","user":{"login":"moovweb","id":78455,"avatar_url":"https://avatars.githubusercontent.com/u/78455?v=2","gravatar_id":"","url":"https://api.github.com/users/moovweb","html_url":"https://github.com/moovweb","followers_url":"https://api.github.com/users/moovweb/followers","following_url":"https://api.github.com/users/moovweb/following{/other_user}","gists_url":"https://api.github.com/users/moovweb/gists{/gist_id}","starred_url":"https://api.github.com/users/moovweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moovweb/subscriptions","organizations_url":"https://api.github.com/users/moovweb/orgs","repos_url":"https://api.github.com/users/moovweb/repos","events_url":"https://api.github.com/users/moovweb/events{/privacy}","received_events_url":"https://api.github.com/users/moovweb/received_events","type":"Organization","site_admin":false},"repo":{"id":1730088,"name":"tritium","full_name":"moovweb/tritium","owner":{"login":"moovweb","id":78455,"avatar_url":"https://avatars.githubusercontent.com/u/78455?v=2","gravatar_id":"","url":"https://api.github.com/users/moovweb","html_url":"https://github.com/moovweb","followers_url":"https://api.github.com/users/moovweb/followers","following_url":"https://api.github.com/users/moovweb/following{/other_user}","gists_url":"https://api.github.com/users/moovweb/gists{/gist_id}","starred_url":"https://api.github.com/users/moovweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moovweb/subscriptions","organizations_url":"https://api.github.com/users/moovweb/orgs","repos_url":"https://api.github.com/users/moovweb/repos","events_url":"https://api.github.com/users/moovweb/events{/privacy}","received_events_url":"https://api.github.com/users/moovweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moovweb/tritium","description":"Tritium is a magical document modifying language. It's JavaScript-like and simple to learn. Think XSLT without the nightmare. It was designed by Hampton Catlin (@hcatlin), and has been heavily influenced by Aaron Leung (@akhleung).","fork":false,"url":"https://api.github.com/repos/moovweb/tritium","forks_url":"https://api.github.com/repos/moovweb/tritium/forks","keys_url":"https://api.github.com/repos/moovweb/tritium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moovweb/tritium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moovweb/tritium/teams","hooks_url":"https://api.github.com/repos/moovweb/tritium/hooks","issue_events_url":"https://api.github.com/repos/moovweb/tritium/issues/events{/number}","events_url":"https://api.github.com/repos/moovweb/tritium/events","assignees_url":"https://api.github.com/repos/moovweb/tritium/assignees{/user}","branches_url":"https://api.github.com/repos/moovweb/tritium/branches{/branch}","tags_url":"https://api.github.com/repos/moovweb/tritium/tags","blobs_url":"https://api.github.com/repos/moovweb/tritium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moovweb/tritium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moovweb/tritium/git/refs{/sha}","trees_url":"https://api.github.com/repos/moovweb/tritium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moovweb/tritium/statuses/{sha}","languages_url":"https://api.github.com/repos/moovweb/tritium/languages","stargazers_url":"https://api.github.com/repos/moovweb/tritium/stargazers","contributors_url":"https://api.github.com/repos/moovweb/tritium/contributors","subscribers_url":"https://api.github.com/repos/moovweb/tritium/subscribers","subscription_url":"https://api.github.com/repos/moovweb/tritium/subscription","commits_url":"https://api.github.com/repos/moovweb/tritium/commits{/sha}","git_commits_url":"https://api.github.com/repos/moovweb/tritium/git/commits{/sha}","comments_url":"https://api.github.com/repos/moovweb/tritium/comments{/number}","issue_comment_url":"https://api.github.com/repos/moovweb/tritium/issues/comments/{number}","contents_url":"https://api.github.com/repos/moovweb/tritium/contents/{+path}","compare_url":"https://api.github.com/repos/moovweb/tritium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moovweb/tritium/merges","archive_url":"https://api.github.com/repos/moovweb/tritium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moovweb/tritium/downloads","issues_url":"https://api.github.com/repos/moovweb/tritium/issues{/number}","pulls_url":"https://api.github.com/repos/moovweb/tritium/pulls{/number}","milestones_url":"https://api.github.com/repos/moovweb/tritium/milestones{/number}","notifications_url":"https://api.github.com/repos/moovweb/tritium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moovweb/tritium/labels{/name}","releases_url":"https://api.github.com/repos/moovweb/tritium/releases{/id}","created_at":"2011-05-10T20:55:27Z","updated_at":"2014-10-22T02:22:05Z","pushed_at":"2014-11-03T22:48:36Z","git_url":"git://github.com/moovweb/tritium.git","ssh_url":"git@github.com:moovweb/tritium.git","clone_url":"https://github.com/moovweb/tritium.git","svn_url":"https://github.com/moovweb/tritium","homepage":"http://tritium.io","size":23082,"stargazers_count":27,"watchers_count":27,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moovweb/tritium/pulls/45"},"html":{"href":"https://github.com/moovweb/tritium/pull/45"},"issue":{"href":"https://api.github.com/repos/moovweb/tritium/issues/45"},"comments":{"href":"https://api.github.com/repos/moovweb/tritium/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/moovweb/tritium/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/moovweb/tritium/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/moovweb/tritium/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/moovweb/tritium/statuses/0a965095dad1f2b530cbe64cd8dc159c433a4228"}}}}