GitHub PullRequestReviewCommentEvent at 2014-11-30 18:19:56
Repository: elasticsearch
Actor: dadoonet
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/21062183","id":21062183,"diff_hunk":"@@ -621,6 +624,15 @@ public boolean docAsUpsert() {\n     public void docAsUpsert(boolean shouldUpsertDoc) {\n         this.docAsUpsert = shouldUpsertDoc;\n     }\n+    \n+    public boolean scriptedUpsert(){\n+        return this.scriptedUpsert;\n+    }\n+    \n+    public void scriptedUpsert(boolean scriptedUpsert) {","path":"src/main/java/org/elasticsearch/action/update/UpdateRequest.java","position":26,"original_position":26,"commit_id":"ea4ad178ec808d77c0a827ad988e07b54fc514a9","original_commit_id":"ea4ad178ec808d77c0a827ad988e07b54fc514a9","user":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"body":"This should `return this;`","created_at":"2014-11-30T18:19:56Z","updated_at":"2014-11-30T18:19:56Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/7144#discussion_r21062183","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7144","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/21062183"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/7144#discussion_r21062183"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7144"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7144","id":19273519,"html_url":"https://github.com/elasticsearch/elasticsearch/pull/7144","diff_url":"https://github.com/elasticsearch/elasticsearch/pull/7144.diff","patch_url":"https://github.com/elasticsearch/elasticsearch/pull/7144.patch","issue_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7144","number":7144,"state":"closed","locked":false,"title":"Update API: Add support for scripted upserts.","user":{"login":"markharwood","id":170925,"avatar_url":"https://avatars.githubusercontent.com/u/170925?v=3","gravatar_id":"","url":"https://api.github.com/users/markharwood","html_url":"https://github.com/markharwood","followers_url":"https://api.github.com/users/markharwood/followers","following_url":"https://api.github.com/users/markharwood/following{/other_user}","gists_url":"https://api.github.com/users/markharwood/gists{/gist_id}","starred_url":"https://api.github.com/users/markharwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markharwood/subscriptions","organizations_url":"https://api.github.com/users/markharwood/orgs","repos_url":"https://api.github.com/users/markharwood/repos","events_url":"https://api.github.com/users/markharwood/events{/privacy}","received_events_url":"https://api.github.com/users/markharwood/received_events","type":"User","site_admin":false},"body":"In the case of inserts the UpdateHelper class will now allow the script used to apply updates to run on the upsert doc provided by clients. This allows the logic for managing the internal state of the data item to be managed by the script and is not reliant on clients performing the initialisation of data structures managed by the script.\r\nAssociated issue: https://github.com/elasticsearch/elasticsearch/issues/7143","created_at":"2014-08-04T09:55:48Z","updated_at":"2014-11-30T18:19:56Z","closed_at":"2014-08-05T16:24:55Z","merged_at":null,"merge_commit_sha":"6e1a74a6055db166c792ac0dc9bc8941c12a4a19","assignee":{"login":"markharwood","id":170925,"avatar_url":"https://avatars.githubusercontent.com/u/170925?v=3","gravatar_id":"","url":"https://api.github.com/users/markharwood","html_url":"https://github.com/markharwood","followers_url":"https://api.github.com/users/markharwood/followers","following_url":"https://api.github.com/users/markharwood/following{/other_user}","gists_url":"https://api.github.com/users/markharwood/gists{/gist_id}","starred_url":"https://api.github.com/users/markharwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markharwood/subscriptions","organizations_url":"https://api.github.com/users/markharwood/orgs","repos_url":"https://api.github.com/users/markharwood/repos","events_url":"https://api.github.com/users/markharwood/events{/privacy}","received_events_url":"https://api.github.com/users/markharwood/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7144/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7144/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7144/comments","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/ea4ad178ec808d77c0a827ad988e07b54fc514a9","head":{"label":"markharwood:feature/scriptedupsert","ref":"feature/scriptedupsert","sha":"ea4ad178ec808d77c0a827ad988e07b54fc514a9","user":{"login":"markharwood","id":170925,"avatar_url":"https://avatars.githubusercontent.com/u/170925?v=3","gravatar_id":"","url":"https://api.github.com/users/markharwood","html_url":"https://github.com/markharwood","followers_url":"https://api.github.com/users/markharwood/followers","following_url":"https://api.github.com/users/markharwood/following{/other_user}","gists_url":"https://api.github.com/users/markharwood/gists{/gist_id}","starred_url":"https://api.github.com/users/markharwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markharwood/subscriptions","organizations_url":"https://api.github.com/users/markharwood/orgs","repos_url":"https://api.github.com/users/markharwood/repos","events_url":"https://api.github.com/users/markharwood/events{/privacy}","received_events_url":"https://api.github.com/users/markharwood/received_events","type":"User","site_admin":false},"repo":{"id":14551524,"name":"elasticsearch","full_name":"markharwood/elasticsearch","owner":{"login":"markharwood","id":170925,"avatar_url":"https://avatars.githubusercontent.com/u/170925?v=3","gravatar_id":"","url":"https://api.github.com/users/markharwood","html_url":"https://github.com/markharwood","followers_url":"https://api.github.com/users/markharwood/followers","following_url":"https://api.github.com/users/markharwood/following{/other_user}","gists_url":"https://api.github.com/users/markharwood/gists{/gist_id}","starred_url":"https://api.github.com/users/markharwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markharwood/subscriptions","organizations_url":"https://api.github.com/users/markharwood/orgs","repos_url":"https://api.github.com/users/markharwood/repos","events_url":"https://api.github.com/users/markharwood/events{/privacy}","received_events_url":"https://api.github.com/users/markharwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markharwood/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/markharwood/elasticsearch","forks_url":"https://api.github.com/repos/markharwood/elasticsearch/forks","keys_url":"https://api.github.com/repos/markharwood/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markharwood/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markharwood/elasticsearch/teams","hooks_url":"https://api.github.com/repos/markharwood/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/markharwood/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/markharwood/elasticsearch/events","assignees_url":"https://api.github.com/repos/markharwood/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/markharwood/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/markharwood/elasticsearch/tags","blobs_url":"https://api.github.com/repos/markharwood/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markharwood/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markharwood/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/markharwood/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markharwood/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/markharwood/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/markharwood/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/markharwood/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/markharwood/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/markharwood/elasticsearch/subscription","commits_url":"https://api.github.com/repos/markharwood/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/markharwood/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/markharwood/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/markharwood/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/markharwood/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/markharwood/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markharwood/elasticsearch/merges","archive_url":"https://api.github.com/repos/markharwood/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markharwood/elasticsearch/downloads","issues_url":"https://api.github.com/repos/markharwood/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/markharwood/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/markharwood/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/markharwood/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markharwood/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/markharwood/elasticsearch/releases{/id}","created_at":"2013-11-20T09:01:55Z","updated_at":"2014-06-06T15:20:19Z","pushed_at":"2014-11-19T10:58:38Z","git_url":"git://github.com/markharwood/elasticsearch.git","ssh_url":"git@github.com:markharwood/elasticsearch.git","clone_url":"https://github.com/markharwood/elasticsearch.git","svn_url":"https://github.com/markharwood/elasticsearch","homepage":"http://elasticsearch.org","size":69409,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"c8cc59df57c0334902acd72cb0926ddba7185c08","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elasticsearch/elasticsearch","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elasticsearch/elasticsearch","forks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/forks","keys_url":"https://api.github.com/repos/elasticsearch/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/events","assignees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/elasticsearch/merges","archive_url":"https://api.github.com/repos/elasticsearch/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2014-11-30T16:25:03Z","pushed_at":"2014-11-30T15:32:02Z","git_url":"git://github.com/elasticsearch/elasticsearch.git","ssh_url":"git@github.com:elasticsearch/elasticsearch.git","clone_url":"https://github.com/elasticsearch/elasticsearch.git","svn_url":"https://github.com/elasticsearch/elasticsearch","homepage":"http://elasticsearch.org","size":310127,"stargazers_count":9078,"watchers_count":9078,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2755,"mirror_url":null,"open_issues_count":903,"forks":2755,"open_issues":903,"watchers":9078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7144"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/7144"},"issue":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7144"},"comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7144/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7144/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7144/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/ea4ad178ec808d77c0a827ad988e07b54fc514a9"}}}}