GitHub PullRequestEvent at 2014-12-21 21:20:05
Repository: FrameworkBenchmarks
Actor: hamiltont
Payload: {"action":"closed","number":1279,"pull_request":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1279","id":26420391,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/1279","diff_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/1279.diff","patch_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/1279.patch","issue_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/1279","number":1279,"state":"closed","locked":false,"title":"Warn if no default test is defined in benchmark_config","user":{"login":"hamiltont","id":305380,"avatar_url":"https://avatars.githubusercontent.com/u/305380?v=3","gravatar_id":"","url":"https://api.github.com/users/hamiltont","html_url":"https://github.com/hamiltont","followers_url":"https://api.github.com/users/hamiltont/followers","following_url":"https://api.github.com/users/hamiltont/following{/other_user}","gists_url":"https://api.github.com/users/hamiltont/gists{/gist_id}","starred_url":"https://api.github.com/users/hamiltont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamiltont/subscriptions","organizations_url":"https://api.github.com/users/hamiltont/orgs","repos_url":"https://api.github.com/users/hamiltont/repos","events_url":"https://api.github.com/users/hamiltont/events{/privacy}","received_events_url":"https://api.github.com/users/hamiltont/received_events","type":"User","site_admin":false},"body":"If there is no test named \"default\" this prints a warning. `pstef` reported this on freenode, because he/she was having problems with `toolset/run-tests.py --test hhvm`. Turned out that HHVM only defines a test raw, so you had to say  `toolset/run-tests.py --test hhvm-raw`. It seems to me that there should always be a default you can run by referring to the framework by name. \r\n\r\nList of current offenders: \r\n```\r\nWARNING:root:Framework lwan does not define a default test in benchmark_config\r\nWARNING:root:Framework ULib does not define a default test in benchmark_config\r\nWARNING:root:Framework servicestack does not define a default test in benchmark_config\r\nWARNING:root:Framework redstone does not define a default test in benchmark_config\r\nWARNING:root:Framework start does not define a default test in benchmark_config\r\nWARNING:root:Framework stream does not define a default test in benchmark_config\r\nWARNING:root:Framework play2 does not define a default test in benchmark_config\r\nWARNING:root:Framework wildfly-ee7 does not define a default test in benchmark_config\r\nWARNING:root:Framework silica does not define a default test in benchmark_config\r\nWARNING:root:Framework yaf does not define a default test in benchmark_config\r\nWARNING:root:Framework pyramid does not define a default test in benchmark_config\r\nWARNING:root:Framework grape does not define a default test in benchmark_config\r\nWARNING:root:Framework padrino does not define a default test in benchmark_config\r\nWARNING:root:Framework rack does not define a default test in benchmark_config\r\nWARNING:root:Framework rails does not define a default test in benchmark_config\r\nWARNING:root:Framework rails-stripped does not define a default test in benchmark_config\r\nWARNING:root:Framework sinatra does not define a default test in benchmark_config\r\nWARNING:root:Framework play2 does not define a default test in benchmark_config\r\n```","created_at":"2014-12-20T20:17:33Z","updated_at":"2014-12-21T21:20:05Z","closed_at":"2014-12-21T21:20:05Z","merged_at":"2014-12-21T21:20:05Z","merge_commit_sha":"eaa20d8d006a1152eccf1c07cad2c33eb12b2d16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1279/commits","review_comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1279/comments","review_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/1279/comments","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/3ca44ce1122f9aad0aa7f899dd10d01b779c1cc3","head":{"label":"hamiltont:check-for-default","ref":"check-for-default","sha":"3ca44ce1122f9aad0aa7f899dd10d01b779c1cc3","user":{"login":"hamiltont","id":305380,"avatar_url":"https://avatars.githubusercontent.com/u/305380?v=3","gravatar_id":"","url":"https://api.github.com/users/hamiltont","html_url":"https://github.com/hamiltont","followers_url":"https://api.github.com/users/hamiltont/followers","following_url":"https://api.github.com/users/hamiltont/following{/other_user}","gists_url":"https://api.github.com/users/hamiltont/gists{/gist_id}","starred_url":"https://api.github.com/users/hamiltont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamiltont/subscriptions","organizations_url":"https://api.github.com/users/hamiltont/orgs","repos_url":"https://api.github.com/users/hamiltont/repos","events_url":"https://api.github.com/users/hamiltont/events{/privacy}","received_events_url":"https://api.github.com/users/hamiltont/received_events","type":"User","site_admin":false},"repo":{"id":13425840,"name":"FrameworkBenchmarks","full_name":"hamiltont/FrameworkBenchmarks","owner":{"login":"hamiltont","id":305380,"avatar_url":"https://avatars.githubusercontent.com/u/305380?v=3","gravatar_id":"","url":"https://api.github.com/users/hamiltont","html_url":"https://github.com/hamiltont","followers_url":"https://api.github.com/users/hamiltont/followers","following_url":"https://api.github.com/users/hamiltont/following{/other_user}","gists_url":"https://api.github.com/users/hamiltont/gists{/gist_id}","starred_url":"https://api.github.com/users/hamiltont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamiltont/subscriptions","organizations_url":"https://api.github.com/users/hamiltont/orgs","repos_url":"https://api.github.com/users/hamiltont/repos","events_url":"https://api.github.com/users/hamiltont/events{/privacy}","received_events_url":"https://api.github.com/users/hamiltont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hamiltont/FrameworkBenchmarks","description":"Source code for the framework benchmarking project","fork":true,"url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/issues/comments/{number}","contents_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/hamiltont/FrameworkBenchmarks/releases{/id}","created_at":"2013-10-08T21:17:49Z","updated_at":"2014-12-21T04:20:32Z","pushed_at":"2014-12-21T21:19:29Z","git_url":"git://github.com/hamiltont/FrameworkBenchmarks.git","ssh_url":"git@github.com:hamiltont/FrameworkBenchmarks.git","clone_url":"https://github.com/hamiltont/FrameworkBenchmarks.git","svn_url":"https://github.com/hamiltont/FrameworkBenchmarks","homepage":"http://www.techempower.com/benchmarks/","size":126268,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"TechEmpower:master","ref":"master","sha":"5c48efddd32401389061b776e3e3b9cb815a4e23","user":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars.githubusercontent.com/u/3910062?v=3","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"User","site_admin":false},"repo":{"id":8957264,"name":"FrameworkBenchmarks","full_name":"TechEmpower/FrameworkBenchmarks","owner":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars.githubusercontent.com/u/3910062?v=3","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks","description":"Source code for the framework benchmarking project","fork":false,"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/comments/{number}","contents_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/releases{/id}","created_at":"2013-03-22T17:33:54Z","updated_at":"2014-12-21T17:45:01Z","pushed_at":"2014-12-21T21:20:05Z","git_url":"git://github.com/TechEmpower/FrameworkBenchmarks.git","ssh_url":"git@github.com:TechEmpower/FrameworkBenchmarks.git","clone_url":"https://github.com/TechEmpower/FrameworkBenchmarks.git","svn_url":"https://github.com/TechEmpower/FrameworkBenchmarks","homepage":"http://www.techempower.com/benchmarks/","size":164314,"stargazers_count":1469,"watchers_count":1469,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":545,"mirror_url":null,"open_issues_count":241,"forks":545,"open_issues":241,"watchers":1469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1279"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/1279"},"issue":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/1279"},"comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/1279/comments"},"review_comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1279/comments"},"review_comment":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/1279/commits"},"statuses":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/3ca44ce1122f9aad0aa7f899dd10d01b779c1cc3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hamiltont","id":305380,"avatar_url":"https://avatars.githubusercontent.com/u/305380?v=3","gravatar_id":"","url":"https://api.github.com/users/hamiltont","html_url":"https://github.com/hamiltont","followers_url":"https://api.github.com/users/hamiltont/followers","following_url":"https://api.github.com/users/hamiltont/following{/other_user}","gists_url":"https://api.github.com/users/hamiltont/gists{/gist_id}","starred_url":"https://api.github.com/users/hamiltont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamiltont/subscriptions","organizations_url":"https://api.github.com/users/hamiltont/orgs","repos_url":"https://api.github.com/users/hamiltont/repos","events_url":"https://api.github.com/users/hamiltont/events{/privacy}","received_events_url":"https://api.github.com/users/hamiltont/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":45,"deletions":26,"changed_files":3}}