GitHub PushEvent at 2014-09-12 17:08:36
Repository: phabricator
Actor: epriestley
Payload: {"shas":[["e8985fc9e72394d9af1affd07ec9267a59751c86","3abdeb20bbfaf7f3efaf2a217619f0ce681d08bb@phacility.com","Differential - change \"closed by commit\" comment to real transaction\n\nSummary:\nImplements a new transaction - still TYPE_ACTION - but using a new DifferentialAction::ACTION_COMMIT_CLOSE. Augment rendering as necessary to display this new transaction. Saves enough information so T3686 is possible but stops short of implementing a popup to display this information. Fixes T5875. Ref T3686.\n\nOne small display oddity - this new transaction now renders at the top of the transaction group whereas when it was a comment it was on the bottom. I think this is basically okay but if not how fix? (Playing with the \"strength\" of these actions will mess up the email too?)\n\nTest Plan: made a diff X that fixed task Y. committed. checked diff X, task Y, and the commit pages for proper transactions and all looked good.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: epriestley, Korvin\n\nManiphest Tasks: T3686, T5875\n\nDifferential Revision: https://secure.phabricator.com/D10485","Bob Trahan",true]],"size":1,"ref":"refs/heads/master","head":"e8985fc9e72394d9af1affd07ec9267a59751c86"}