GitHub PullRequestReviewCommentEvent at 2014-09-02 12:42:32
Repository: banana-rdf
Actor: bblfish
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/w3c/banana-rdf/pulls/comments/16984207","id":16984207,"diff_hunk":"@@ -1,15 +1,23 @@\n package org.w3.banana.jena\n \n-import org.w3.banana._\n-import com.hp.hpl.jena.graph.{ Graph => JenaGraph }\n-import com.hp.hpl.jena.rdf.model._\n+import com.hp.hpl.jena.graph.{Graph => JenaGraph}\n import com.hp.hpl.jena.query._\n-import scala.concurrent.Future\n-import org.w3.banana.util._\n+import com.hp.hpl.jena.rdf.model._\n+import org.w3.banana._\n \n-class JenaGraphSparqlEngine(implicit ops: RDFOps[Jena])\n-    extends SparqlEngine[Jena, Jena#Graph] {\n+import scala.concurrent.{ExecutionContext, Future}\n \n+/**\n+ * Treat a Graph as a Sparql Engine\n+ * @param ec execution context to use. If not specified this will\n+ *           be run on the same thread. If you want to use a different execution context\n+ *           you must specify it explicitly. (it makes most sense usually to run this on the same thread, as the\n+ *           data is local ).\n+ */\n+class JenaGraphSparqlEngine(ec: ExecutionContext=sameThreadExecutionContext)\n+                           (implicit ops: RDFOps[Jena])\n+    extends SparqlEngine[Jena, Jena#Graph] {","path":"jena/src/main/scala/jena/JenaGraphSparqlEngine.scala","position":null,"original_position":26,"commit_id":"9553865af556a08b382e1a669059b8326437e4d0","original_commit_id":"3a89aec8ae150bc1fa52317ccf455fc4a2268331","user":{"login":"bblfish","id":124506,"avatar_url":"https://avatars.githubusercontent.com/u/124506?v=2","gravatar_id":"5d537347eb54566c1b9d975a30fc0147","url":"https://api.github.com/users/bblfish","html_url":"https://github.com/bblfish","followers_url":"https://api.github.com/users/bblfish/followers","following_url":"https://api.github.com/users/bblfish/following{/other_user}","gists_url":"https://api.github.com/users/bblfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfish/subscriptions","organizations_url":"https://api.github.com/users/bblfish/orgs","repos_url":"https://api.github.com/users/bblfish/repos","events_url":"https://api.github.com/users/bblfish/events{/privacy}","received_events_url":"https://api.github.com/users/bblfish/received_events","type":"User","site_admin":false},"body":"it is immutable, no? `SparqlEngine does not implement `SparqlUpdate`...","created_at":"2014-09-02T12:42:32Z","updated_at":"2014-09-02T12:42:32Z","html_url":"https://github.com/w3c/banana-rdf/pull/116#discussion_r16984207","pull_request_url":"https://api.github.com/repos/w3c/banana-rdf/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/comments/16984207"},"html":{"href":"https://github.com/w3c/banana-rdf/pull/116#discussion_r16984207"},"pull_request":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/banana-rdf/pulls/116","id":20606270,"html_url":"https://github.com/w3c/banana-rdf/pull/116","diff_url":"https://github.com/w3c/banana-rdf/pull/116.diff","patch_url":"https://github.com/w3c/banana-rdf/pull/116.patch","issue_url":"https://api.github.com/repos/w3c/banana-rdf/issues/116","number":116,"state":"open","locked":false,"title":"make Topic/more consistency more consistent","user":{"login":"bblfish","id":124506,"avatar_url":"https://avatars.githubusercontent.com/u/124506?v=2","gravatar_id":"5d537347eb54566c1b9d975a30fc0147","url":"https://api.github.com/users/bblfish","html_url":"https://github.com/bblfish","followers_url":"https://api.github.com/users/bblfish/followers","following_url":"https://api.github.com/users/bblfish/following{/other_user}","gists_url":"https://api.github.com/users/bblfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfish/subscriptions","organizations_url":"https://api.github.com/users/bblfish/orgs","repos_url":"https://api.github.com/users/bblfish/repos","events_url":"https://api.github.com/users/bblfish/events{/privacy}","received_events_url":"https://api.github.com/users/bblfish/received_events","type":"User","site_admin":false},"body":"made Jena and sesame sparql updates more consistent. Also fixed a few things along the way. ","created_at":"2014-09-02T11:27:33Z","updated_at":"2014-09-02T12:42:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"462db4d86ad5a8ad2c2d2cf36c4cfeadba3c1631","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/banana-rdf/pulls/116/commits","review_comments_url":"https://api.github.com/repos/w3c/banana-rdf/pulls/116/comments","review_comment_url":"https://api.github.com/repos/w3c/banana-rdf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/w3c/banana-rdf/issues/116/comments","statuses_url":"https://api.github.com/repos/w3c/banana-rdf/statuses/9553865af556a08b382e1a669059b8326437e4d0","head":{"label":"read-write-web:topic/more-consistency","ref":"topic/more-consistency","sha":"9553865af556a08b382e1a669059b8326437e4d0","user":{"login":"read-write-web","id":1773488,"avatar_url":"https://avatars.githubusercontent.com/u/1773488?v=2","gravatar_id":null,"url":"https://api.github.com/users/read-write-web","html_url":"https://github.com/read-write-web","followers_url":"https://api.github.com/users/read-write-web/followers","following_url":"https://api.github.com/users/read-write-web/following{/other_user}","gists_url":"https://api.github.com/users/read-write-web/gists{/gist_id}","starred_url":"https://api.github.com/users/read-write-web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/read-write-web/subscriptions","organizations_url":"https://api.github.com/users/read-write-web/orgs","repos_url":"https://api.github.com/users/read-write-web/repos","events_url":"https://api.github.com/users/read-write-web/events{/privacy}","received_events_url":"https://api.github.com/users/read-write-web/received_events","type":"Organization","site_admin":false},"repo":{"id":4726293,"name":"banana-rdf","full_name":"read-write-web/banana-rdf","owner":{"login":"read-write-web","id":1773488,"avatar_url":"https://avatars.githubusercontent.com/u/1773488?v=2","gravatar_id":null,"url":"https://api.github.com/users/read-write-web","html_url":"https://github.com/read-write-web","followers_url":"https://api.github.com/users/read-write-web/followers","following_url":"https://api.github.com/users/read-write-web/following{/other_user}","gists_url":"https://api.github.com/users/read-write-web/gists{/gist_id}","starred_url":"https://api.github.com/users/read-write-web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/read-write-web/subscriptions","organizations_url":"https://api.github.com/users/read-write-web/orgs","repos_url":"https://api.github.com/users/read-write-web/repos","events_url":"https://api.github.com/users/read-write-web/events{/privacy}","received_events_url":"https://api.github.com/users/read-write-web/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/read-write-web/banana-rdf","description":"Banana RDF","fork":true,"url":"https://api.github.com/repos/read-write-web/banana-rdf","forks_url":"https://api.github.com/repos/read-write-web/banana-rdf/forks","keys_url":"https://api.github.com/repos/read-write-web/banana-rdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/read-write-web/banana-rdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/read-write-web/banana-rdf/teams","hooks_url":"https://api.github.com/repos/read-write-web/banana-rdf/hooks","issue_events_url":"https://api.github.com/repos/read-write-web/banana-rdf/issues/events{/number}","events_url":"https://api.github.com/repos/read-write-web/banana-rdf/events","assignees_url":"https://api.github.com/repos/read-write-web/banana-rdf/assignees{/user}","branches_url":"https://api.github.com/repos/read-write-web/banana-rdf/branches{/branch}","tags_url":"https://api.github.com/repos/read-write-web/banana-rdf/tags","blobs_url":"https://api.github.com/repos/read-write-web/banana-rdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/read-write-web/banana-rdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/read-write-web/banana-rdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/read-write-web/banana-rdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/read-write-web/banana-rdf/statuses/{sha}","languages_url":"https://api.github.com/repos/read-write-web/banana-rdf/languages","stargazers_url":"https://api.github.com/repos/read-write-web/banana-rdf/stargazers","contributors_url":"https://api.github.com/repos/read-write-web/banana-rdf/contributors","subscribers_url":"https://api.github.com/repos/read-write-web/banana-rdf/subscribers","subscription_url":"https://api.github.com/repos/read-write-web/banana-rdf/subscription","commits_url":"https://api.github.com/repos/read-write-web/banana-rdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/read-write-web/banana-rdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/read-write-web/banana-rdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/read-write-web/banana-rdf/issues/comments/{number}","contents_url":"https://api.github.com/repos/read-write-web/banana-rdf/contents/{+path}","compare_url":"https://api.github.com/repos/read-write-web/banana-rdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/read-write-web/banana-rdf/merges","archive_url":"https://api.github.com/repos/read-write-web/banana-rdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/read-write-web/banana-rdf/downloads","issues_url":"https://api.github.com/repos/read-write-web/banana-rdf/issues{/number}","pulls_url":"https://api.github.com/repos/read-write-web/banana-rdf/pulls{/number}","milestones_url":"https://api.github.com/repos/read-write-web/banana-rdf/milestones{/number}","notifications_url":"https://api.github.com/repos/read-write-web/banana-rdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/read-write-web/banana-rdf/labels{/name}","releases_url":"https://api.github.com/repos/read-write-web/banana-rdf/releases{/id}","created_at":"2012-06-20T13:03:15Z","updated_at":"2014-08-29T11:02:26Z","pushed_at":"2014-09-02T12:37:39Z","git_url":"git://github.com/read-write-web/banana-rdf.git","ssh_url":"git@github.com:read-write-web/banana-rdf.git","clone_url":"https://github.com/read-write-web/banana-rdf.git","svn_url":"https://github.com/read-write-web/banana-rdf","homepage":null,"size":4950,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:topic/more-consistency","ref":"topic/more-consistency","sha":"d42248107fdfa0a4c410c617a05e5c232c553261","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=2","gravatar_id":"85dfda2c583d777a50eb433f6aab289f","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":4179427,"name":"banana-rdf","full_name":"w3c/banana-rdf","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=2","gravatar_id":"85dfda2c583d777a50eb433f6aab289f","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/banana-rdf","description":"Banana RDF","fork":false,"url":"https://api.github.com/repos/w3c/banana-rdf","forks_url":"https://api.github.com/repos/w3c/banana-rdf/forks","keys_url":"https://api.github.com/repos/w3c/banana-rdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/banana-rdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/banana-rdf/teams","hooks_url":"https://api.github.com/repos/w3c/banana-rdf/hooks","issue_events_url":"https://api.github.com/repos/w3c/banana-rdf/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/banana-rdf/events","assignees_url":"https://api.github.com/repos/w3c/banana-rdf/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/banana-rdf/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/banana-rdf/tags","blobs_url":"https://api.github.com/repos/w3c/banana-rdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/banana-rdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/banana-rdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/banana-rdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/banana-rdf/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/banana-rdf/languages","stargazers_url":"https://api.github.com/repos/w3c/banana-rdf/stargazers","contributors_url":"https://api.github.com/repos/w3c/banana-rdf/contributors","subscribers_url":"https://api.github.com/repos/w3c/banana-rdf/subscribers","subscription_url":"https://api.github.com/repos/w3c/banana-rdf/subscription","commits_url":"https://api.github.com/repos/w3c/banana-rdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/banana-rdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/banana-rdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/banana-rdf/issues/comments/{number}","contents_url":"https://api.github.com/repos/w3c/banana-rdf/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/banana-rdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/banana-rdf/merges","archive_url":"https://api.github.com/repos/w3c/banana-rdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/banana-rdf/downloads","issues_url":"https://api.github.com/repos/w3c/banana-rdf/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/banana-rdf/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/banana-rdf/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/banana-rdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/banana-rdf/labels{/name}","releases_url":"https://api.github.com/repos/w3c/banana-rdf/releases{/id}","created_at":"2012-04-30T03:02:56Z","updated_at":"2014-09-01T13:05:43Z","pushed_at":"2014-09-01T22:33:08Z","git_url":"git://github.com/w3c/banana-rdf.git","ssh_url":"git@github.com:w3c/banana-rdf.git","clone_url":"https://github.com/w3c/banana-rdf.git","svn_url":"https://github.com/w3c/banana-rdf","homepage":null,"size":5542,"stargazers_count":86,"watchers_count":86,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":23,"mirror_url":null,"open_issues_count":40,"forks":23,"open_issues":40,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/116"},"html":{"href":"https://github.com/w3c/banana-rdf/pull/116"},"issue":{"href":"https://api.github.com/repos/w3c/banana-rdf/issues/116"},"comments":{"href":"https://api.github.com/repos/w3c/banana-rdf/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/banana-rdf/statuses/9553865af556a08b382e1a669059b8326437e4d0"}}}}