GitHub PullRequestEvent at 2014-11-02 00:24:59
Repository: symfony
Actor: fabpot
Payload: {"action":"closed","number":12326,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/12326","id":23359081,"html_url":"https://github.com/symfony/symfony/pull/12326","diff_url":"https://github.com/symfony/symfony/pull/12326.diff","patch_url":"https://github.com/symfony/symfony/pull/12326.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/12326","number":12326,"state":"closed","locked":false,"title":"[Session] remove invalid hack in session regenerate","user":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=2","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nThe original issue #7380 was just caused because the developer missed to save the session before doing the redirect. That's all. Such mistakes won't happen anymore with #12341\r\n\r\nThis reverts #8270 and following. Also it makes absolutely no sense to do this only for the `files` save handler which creates huge inconsistencies. All save handlers are affected and it's more a documentation thing.","created_at":"2014-10-27T00:58:45Z","updated_at":"2014-11-02T00:24:56Z","closed_at":"2014-11-02T00:24:56Z","merged_at":"2014-11-02T00:24:56Z","merge_commit_sha":"cb662a9eb3401262dc65cce44c2a04c09ed9e4cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/12326/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/12326/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/12326/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/703d9067589c595228670b07fce9578bb707c82f","head":{"label":"Tobion:revert-8270","ref":"revert-8270","sha":"703d9067589c595228670b07fce9578bb707c82f","user":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=2","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"repo":{"id":2967822,"name":"symfony","full_name":"Tobion/symfony","owner":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=2","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tobion/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/Tobion/symfony","forks_url":"https://api.github.com/repos/Tobion/symfony/forks","keys_url":"https://api.github.com/repos/Tobion/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tobion/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tobion/symfony/teams","hooks_url":"https://api.github.com/repos/Tobion/symfony/hooks","issue_events_url":"https://api.github.com/repos/Tobion/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Tobion/symfony/events","assignees_url":"https://api.github.com/repos/Tobion/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Tobion/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Tobion/symfony/tags","blobs_url":"https://api.github.com/repos/Tobion/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tobion/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tobion/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tobion/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tobion/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Tobion/symfony/languages","stargazers_url":"https://api.github.com/repos/Tobion/symfony/stargazers","contributors_url":"https://api.github.com/repos/Tobion/symfony/contributors","subscribers_url":"https://api.github.com/repos/Tobion/symfony/subscribers","subscription_url":"https://api.github.com/repos/Tobion/symfony/subscription","commits_url":"https://api.github.com/repos/Tobion/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tobion/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tobion/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tobion/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/Tobion/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Tobion/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tobion/symfony/merges","archive_url":"https://api.github.com/repos/Tobion/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tobion/symfony/downloads","issues_url":"https://api.github.com/repos/Tobion/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Tobion/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Tobion/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Tobion/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tobion/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Tobion/symfony/releases{/id}","created_at":"2011-12-12T22:04:13Z","updated_at":"2014-10-03T10:02:29Z","pushed_at":"2014-10-30T16:08:53Z","git_url":"git://github.com/Tobion/symfony.git","ssh_url":"git@github.com:Tobion/symfony.git","clone_url":"https://github.com/Tobion/symfony.git","svn_url":"https://github.com/Tobion/symfony","homepage":"symfony.com","size":46684,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"9a8ac524dfab3e126b4f7f5d4bf5ef28192f6a7a","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-11-01T21:30:19Z","pushed_at":"2014-11-02T00:24:54Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":189786,"stargazers_count":9117,"watchers_count":9117,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3492,"mirror_url":null,"open_issues_count":760,"forks":3492,"open_issues":760,"watchers":9117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12326"},"html":{"href":"https://github.com/symfony/symfony/pull/12326"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/12326"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/12326/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12326/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12326/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/703d9067589c595228670b07fce9578bb707c82f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=2","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":9,"deletions":17,"changed_files":2}}