GitHub PullRequestReviewCommentEvent at 2014-12-19 21:42:07
Repository: eos-metrics
Actor: BlackVegetable
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-metrics/pulls/comments/22130702","id":22130702,"diff_hunk":"@@ -476,6 +491,10 @@ emtr_event_recorder_record_event (EmtrEventRecorder *self,\n   g_return_if_fail (event_id != NULL);\n   g_return_if_fail (auxiliary_payload == NULL || _IS_VARIANT(auxiliary_payload));\n \n+  if (contains_maybe_variant (auxiliary_payload))\n+    g_critical (\"Maybe type found in auxiliary payload. These are not \"","path":"eosmetrics/emtr-event-recorder.c","position":45,"original_position":45,"commit_id":"62b7a384e963927a22d157b5bb77a5bb1bf25cb0","original_commit_id":"62b7a384e963927a22d157b5bb77a5bb1bf25cb0","user":{"login":"BlackVegetable","id":2665839,"avatar_url":"https://avatars.githubusercontent.com/u/2665839?v=3","gravatar_id":"","url":"https://api.github.com/users/BlackVegetable","html_url":"https://github.com/BlackVegetable","followers_url":"https://api.github.com/users/BlackVegetable/followers","following_url":"https://api.github.com/users/BlackVegetable/following{/other_user}","gists_url":"https://api.github.com/users/BlackVegetable/gists{/gist_id}","starred_url":"https://api.github.com/users/BlackVegetable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlackVegetable/subscriptions","organizations_url":"https://api.github.com/users/BlackVegetable/orgs","repos_url":"https://api.github.com/users/BlackVegetable/repos","events_url":"https://api.github.com/users/BlackVegetable/events{/privacy}","received_events_url":"https://api.github.com/users/BlackVegetable/received_events","type":"User","site_admin":false},"body":"Good plan.","created_at":"2014-12-19T21:42:07Z","updated_at":"2014-12-19T21:42:07Z","html_url":"https://github.com/endlessm/eos-metrics/pull/5#discussion_r22130702","pull_request_url":"https://api.github.com/repos/endlessm/eos-metrics/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-metrics/pulls/comments/22130702"},"html":{"href":"https://github.com/endlessm/eos-metrics/pull/5#discussion_r22130702"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-metrics/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-metrics/pulls/5","id":25590994,"html_url":"https://github.com/endlessm/eos-metrics/pull/5","diff_url":"https://github.com/endlessm/eos-metrics/pull/5.diff","patch_url":"https://github.com/endlessm/eos-metrics/pull/5.patch","issue_url":"https://api.github.com/repos/endlessm/eos-metrics/issues/5","number":5,"state":"open","locked":false,"title":"Disallow maybe types","user":{"login":"ptomato","id":459371,"avatar_url":"https://avatars.githubusercontent.com/u/459371?v=3","gravatar_id":"","url":"https://api.github.com/users/ptomato","html_url":"https://github.com/ptomato","followers_url":"https://api.github.com/users/ptomato/followers","following_url":"https://api.github.com/users/ptomato/following{/other_user}","gists_url":"https://api.github.com/users/ptomato/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomato/subscriptions","organizations_url":"https://api.github.com/users/ptomato/orgs","repos_url":"https://api.github.com/users/ptomato/repos","events_url":"https://api.github.com/users/ptomato/events{/privacy}","received_events_url":"https://api.github.com/users/ptomato/received_events","type":"User","site_admin":false},"body":"[endlessm/eos-sdk#2281]","created_at":"2014-12-05T18:46:42Z","updated_at":"2014-12-19T21:42:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6952bb15eb97329b882166a8b2fd812d0262449c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-metrics/pulls/5/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-metrics/pulls/5/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-metrics/pulls/comments/{number}","comments_url":"https://api.github.com/repos/endlessm/eos-metrics/issues/5/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-metrics/statuses/62b7a384e963927a22d157b5bb77a5bb1bf25cb0","head":{"label":"endlessm:sdk/2281","ref":"sdk/2281","sha":"62b7a384e963927a22d157b5bb77a5bb1bf25cb0","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":24855052,"name":"eos-metrics","full_name":"endlessm/eos-metrics","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-metrics","description":"Endless OS metrics","fork":false,"url":"https://api.github.com/repos/endlessm/eos-metrics","forks_url":"https://api.github.com/repos/endlessm/eos-metrics/forks","keys_url":"https://api.github.com/repos/endlessm/eos-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-metrics/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-metrics/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-metrics/events","assignees_url":"https://api.github.com/repos/endlessm/eos-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-metrics/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-metrics/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-metrics/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-metrics/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-metrics/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-metrics/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-metrics/issues/comments/{number}","contents_url":"https://api.github.com/repos/endlessm/eos-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-metrics/merges","archive_url":"https://api.github.com/repos/endlessm/eos-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-metrics/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-metrics/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-metrics/releases{/id}","created_at":"2014-10-06T16:56:51Z","updated_at":"2014-12-19T17:50:37Z","pushed_at":"2014-12-19T20:48:30Z","git_url":"git://github.com/endlessm/eos-metrics.git","ssh_url":"git@github.com:endlessm/eos-metrics.git","clone_url":"https://github.com/endlessm/eos-metrics.git","svn_url":"https://github.com/endlessm/eos-metrics","homepage":null,"size":1268,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"849d16187497cf0122ab171a754b87a1587d5d54","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":24855052,"name":"eos-metrics","full_name":"endlessm/eos-metrics","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-metrics","description":"Endless OS metrics","fork":false,"url":"https://api.github.com/repos/endlessm/eos-metrics","forks_url":"https://api.github.com/repos/endlessm/eos-metrics/forks","keys_url":"https://api.github.com/repos/endlessm/eos-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-metrics/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-metrics/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-metrics/events","assignees_url":"https://api.github.com/repos/endlessm/eos-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-metrics/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-metrics/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-metrics/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-metrics/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-metrics/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-metrics/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-metrics/issues/comments/{number}","contents_url":"https://api.github.com/repos/endlessm/eos-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-metrics/merges","archive_url":"https://api.github.com/repos/endlessm/eos-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-metrics/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-metrics/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-metrics/releases{/id}","created_at":"2014-10-06T16:56:51Z","updated_at":"2014-12-19T17:50:37Z","pushed_at":"2014-12-19T20:48:30Z","git_url":"git://github.com/endlessm/eos-metrics.git","ssh_url":"git@github.com:endlessm/eos-metrics.git","clone_url":"https://github.com/endlessm/eos-metrics.git","svn_url":"https://github.com/endlessm/eos-metrics","homepage":null,"size":1268,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-metrics/pulls/5"},"html":{"href":"https://github.com/endlessm/eos-metrics/pull/5"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-metrics/issues/5"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-metrics/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-metrics/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-metrics/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-metrics/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-metrics/statuses/62b7a384e963927a22d157b5bb77a5bb1bf25cb0"}}}}