GitHub PullRequestReviewCommentEvent at 2014-07-08 18:49:03
Repository: socorro
Actor: bramwelt
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/socorro/pulls/comments/14672840","id":14672840,"diff_hunk":"@@ -0,0 +1,29 @@\n+\"\"\"bug 1035957 - use literal NOW() for received_at, do not evaluate at migration time\n+\n+\n+Revision ID: 391e42da94dd\n+Revises: 495bf3fcdb63\n+Create Date: 2014-07-08 10:55:04.115932\n+\n+\"\"\"\n+\n+# revision identifiers, used by Alembic.\n+revision = '391e42da94dd'\n+down_revision = '495bf3fcdb63'\n+\n+from alembic import op\n+from socorro.lib import citexttype, jsontype, buildtype\n+from socorro.lib.migrations import fix_permissions, load_stored_proc\n+\n+import sqlalchemy as sa\n+from sqlalchemy import types\n+from sqlalchemy.dialects import postgresql\n+from sqlalchemy.sql import table, column\n+\n+\n+def upgrade():\n+    op.alter_column(u'raw_adi', u'received_at', server_default=sa.text('NOW()')),\n+\n+\n+def downgrade():\n+    op.alter_column(u'raw_adi', u'received_at', server_default='2014-06-24 00:29:17.218147+00'),","path":"alembic/versions/391e42da94dd_bug_1035957_use_literal_now_for_.py","position":29,"original_position":29,"commit_id":"1dc795fcf3e6c09a9a77fb008ee3b5fe5c7c3719","original_commit_id":"1dc795fcf3e6c09a9a77fb008ee3b5fe5c7c3719","user":{"login":"bramwelt","id":324567,"avatar_url":"https://avatars.githubusercontent.com/u/324567?","gravatar_id":"eaee71e72ad00885dd9a4fd8b3b8b80d","url":"https://api.github.com/users/bramwelt","html_url":"https://github.com/bramwelt","followers_url":"https://api.github.com/users/bramwelt/followers","following_url":"https://api.github.com/users/bramwelt/following{/other_user}","gists_url":"https://api.github.com/users/bramwelt/gists{/gist_id}","starred_url":"https://api.github.com/users/bramwelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramwelt/subscriptions","organizations_url":"https://api.github.com/users/bramwelt/orgs","repos_url":"https://api.github.com/users/bramwelt/repos","events_url":"https://api.github.com/users/bramwelt/events{/privacy}","received_events_url":"https://api.github.com/users/bramwelt/received_events","type":"User","site_admin":false},"body":"Should this be `u'2014-06...'` as well?","created_at":"2014-07-08T18:49:03Z","updated_at":"2014-07-08T18:49:03Z","html_url":"https://github.com/mozilla/socorro/pull/2175#discussion_r14672840","pull_request_url":"https://api.github.com/repos/mozilla/socorro/pulls/2175","_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/comments/14672840"},"html":{"href":"https://github.com/mozilla/socorro/pull/2175#discussion_r14672840"},"pull_request":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/2175"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/socorro/pulls/2175","id":18118490,"html_url":"https://github.com/mozilla/socorro/pull/2175","diff_url":"https://github.com/mozilla/socorro/pull/2175.diff","patch_url":"https://github.com/mozilla/socorro/pull/2175.patch","issue_url":"https://api.github.com/repos/mozilla/socorro/issues/2175","number":2175,"state":"open","title":"fix bug 1035957 - correct received_at column","user":{"login":"rhelmer","id":61412,"avatar_url":"https://avatars.githubusercontent.com/u/61412?","gravatar_id":"aedfcfd22f63c0f0a6b3ce6b9024df9e","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-08T18:07:24Z","updated_at":"2014-07-08T18:49:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d51da4cdb0855e9d20a2dcfc87d059f15ff5031b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/socorro/pulls/2175/commits","review_comments_url":"https://api.github.com/repos/mozilla/socorro/pulls/2175/comments","review_comment_url":"https://api.github.com/repos/mozilla/socorro/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/socorro/issues/2175/comments","statuses_url":"https://api.github.com/repos/mozilla/socorro/statuses/1dc795fcf3e6c09a9a77fb008ee3b5fe5c7c3719","head":{"label":"rhelmer:bug1035957-raw_adi-received_at-column-wrong","ref":"bug1035957-raw_adi-received_at-column-wrong","sha":"1dc795fcf3e6c09a9a77fb008ee3b5fe5c7c3719","user":{"login":"rhelmer","id":61412,"avatar_url":"https://avatars.githubusercontent.com/u/61412?","gravatar_id":"aedfcfd22f63c0f0a6b3ce6b9024df9e","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"repo":{"id":4216256,"name":"socorro","full_name":"rhelmer/socorro","owner":{"login":"rhelmer","id":61412,"avatar_url":"https://avatars.githubusercontent.com/u/61412?","gravatar_id":"aedfcfd22f63c0f0a6b3ce6b9024df9e","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhelmer/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":true,"url":"https://api.github.com/repos/rhelmer/socorro","forks_url":"https://api.github.com/repos/rhelmer/socorro/forks","keys_url":"https://api.github.com/repos/rhelmer/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhelmer/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhelmer/socorro/teams","hooks_url":"https://api.github.com/repos/rhelmer/socorro/hooks","issue_events_url":"https://api.github.com/repos/rhelmer/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/rhelmer/socorro/events","assignees_url":"https://api.github.com/repos/rhelmer/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/rhelmer/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/rhelmer/socorro/tags","blobs_url":"https://api.github.com/repos/rhelmer/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhelmer/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhelmer/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhelmer/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhelmer/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/rhelmer/socorro/languages","stargazers_url":"https://api.github.com/repos/rhelmer/socorro/stargazers","contributors_url":"https://api.github.com/repos/rhelmer/socorro/contributors","subscribers_url":"https://api.github.com/repos/rhelmer/socorro/subscribers","subscription_url":"https://api.github.com/repos/rhelmer/socorro/subscription","commits_url":"https://api.github.com/repos/rhelmer/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhelmer/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhelmer/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhelmer/socorro/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhelmer/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/rhelmer/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhelmer/socorro/merges","archive_url":"https://api.github.com/repos/rhelmer/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhelmer/socorro/downloads","issues_url":"https://api.github.com/repos/rhelmer/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/rhelmer/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/rhelmer/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/rhelmer/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhelmer/socorro/labels{/name}","releases_url":"https://api.github.com/repos/rhelmer/socorro/releases{/id}","created_at":"2012-05-03T16:46:07Z","updated_at":"2014-07-08T17:49:17Z","pushed_at":"2014-07-08T18:04:54Z","git_url":"git://github.com/rhelmer/socorro.git","ssh_url":"git@github.com:rhelmer/socorro.git","clone_url":"https://github.com/rhelmer/socorro.git","svn_url":"https://github.com/rhelmer/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":235167,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"27a25b540f4c9740f9af69daf429dd6875c74a9e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2263742,"name":"socorro","full_name":"mozilla/socorro","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":false,"url":"https://api.github.com/repos/mozilla/socorro","forks_url":"https://api.github.com/repos/mozilla/socorro/forks","keys_url":"https://api.github.com/repos/mozilla/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/socorro/teams","hooks_url":"https://api.github.com/repos/mozilla/socorro/hooks","issue_events_url":"https://api.github.com/repos/mozilla/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/socorro/events","assignees_url":"https://api.github.com/repos/mozilla/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/socorro/tags","blobs_url":"https://api.github.com/repos/mozilla/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/socorro/languages","stargazers_url":"https://api.github.com/repos/mozilla/socorro/stargazers","contributors_url":"https://api.github.com/repos/mozilla/socorro/contributors","subscribers_url":"https://api.github.com/repos/mozilla/socorro/subscribers","subscription_url":"https://api.github.com/repos/mozilla/socorro/subscription","commits_url":"https://api.github.com/repos/mozilla/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/socorro/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/socorro/merges","archive_url":"https://api.github.com/repos/mozilla/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/socorro/downloads","issues_url":"https://api.github.com/repos/mozilla/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/socorro/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/socorro/releases{/id}","created_at":"2011-08-24T19:21:49Z","updated_at":"2014-07-03T17:53:02Z","pushed_at":"2014-07-08T05:58:18Z","git_url":"git://github.com/mozilla/socorro.git","ssh_url":"git@github.com:mozilla/socorro.git","clone_url":"https://github.com/mozilla/socorro.git","svn_url":"https://github.com/mozilla/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":185083,"stargazers_count":178,"watchers_count":178,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":95,"mirror_url":null,"open_issues_count":11,"forks":95,"open_issues":11,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/2175"},"html":{"href":"https://github.com/mozilla/socorro/pull/2175"},"issue":{"href":"https://api.github.com/repos/mozilla/socorro/issues/2175"},"comments":{"href":"https://api.github.com/repos/mozilla/socorro/issues/2175/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/2175/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/2175/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/socorro/statuses/1dc795fcf3e6c09a9a77fb008ee3b5fe5c7c3719"}}}}