GitHub PullRequestReviewCommentEvent at 2014-05-27 21:19:39
Repository: FieldWorks
Actor: JohnThomson
Payload: {"comment":{"url":"https://api.github.com/repos/sillsdev/FieldWorks/pulls/comments/13103198","id":13103198,"diff_hunk":"@@ -86,19 +86,20 @@ public RegFreeCreator(XmlDocument doc, TaskLoggingHelper Log): this(doc)\n \n \t\t#endregion\n \n-\t\t/// ------------------------------------------------------------------------------------\n-\t\t/// <summary>\n-\t\t/// Creates the info for the executable. The info consist of:\n-\t\t/// <list type=\"bullet\">\n-\t\t///\t\t<item>name (from file name)</item>\n-\t\t///\t\t<item>version info (from assembly)</item>\n-\t\t///\t\t<item>type (hard coded as \"win32\" for now)</item>\n-\t\t/// </list>\n-\t\t/// This method also adds the root element with all necessary namespaces.\n-\t\t/// </summary>\n-\t\t/// <param name=\"pathName\">pathname of the file.</param>\n-\t\t/// ------------------------------------------------------------------------------------\n-\t\tpublic XmlElement CreateExeInfo(string pathName)\n+\t\t///  ------------------------------------------------------------------------------------\n+\t\t///  <summary>\n+\t\t///  Creates the info for the executable. The info consist of:\n+\t\t///  <list type=\"bullet\">\n+\t\t/// \t\t<item>name (from file name)</item>\n+\t\t/// \t\t<item>version info (from assembly)</item>\n+\t\t/// \t\t<item>type (hard coded as \"win32\" for now)</item>\n+\t\t///  </list>\n+\t\t///  This method also adds the root element with all necessary namespaces.\n+\t\t///  </summary>\n+\t\t///  <param name=\"pathName\">pathname of the file.</param>\n+\t\t/// <param name=\"isSxs\"></param>\n+\t\t/// ------------------------------------------------------------------------------------\n+\t\tpublic XmlElement CreateExeInfo(string pathName, bool isSxs)","path":"Build/Src/FwBuildTasks/RegFreeCreator.cs","position":30,"original_position":30,"commit_id":"8c72edf6a6ba385262664e1dd0e7d062b0556037","original_commit_id":"8c72edf6a6ba385262664e1dd0e7d062b0556037","user":{"login":"JohnThomson","id":1360521,"avatar_url":"https://avatars.githubusercontent.com/u/1360521?","gravatar_id":"160a6c294ee361f9a3a873bc3f1cfadc","url":"https://api.github.com/users/JohnThomson","html_url":"https://github.com/JohnThomson","followers_url":"https://api.github.com/users/JohnThomson/followers","following_url":"https://api.github.com/users/JohnThomson/following{/other_user}","gists_url":"https://api.github.com/users/JohnThomson/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnThomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnThomson/subscriptions","organizations_url":"https://api.github.com/users/JohnThomson/orgs","repos_url":"https://api.github.com/users/JohnThomson/repos","events_url":"https://api.github.com/users/JohnThomson/events{/privacy}","received_events_url":"https://api.github.com/users/JohnThomson/received_events","type":"User","site_admin":false},"body":"I think some comment is called for here. I don't know what an sxs file is, so others likely won't either. The first hit on google says it is a \"SAS Stat Studio Module Source Code file\". That's probably wrong. If it isn't some kind of (Linux?) executable then the method name itself has become dubious with this new responsibility.\r\n\r\nBut, the code above seems to indicate that isSxs will be true if there's only one file we are getting manifest info from and it's the executable. Why would that be reason to change the extension??","created_at":"2014-05-27T21:19:39Z","updated_at":"2014-05-27T21:19:39Z","html_url":"https://github.com/sillsdev/FieldWorks/pull/2#discussion_r13103198","pull_request_url":"https://api.github.com/repos/sillsdev/FieldWorks/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/sillsdev/FieldWorks/pulls/comments/13103198"},"html":{"href":"https://github.com/sillsdev/FieldWorks/pull/2#discussion_r13103198"},"pull_request":{"href":"https://api.github.com/repos/sillsdev/FieldWorks/pulls/2"}}}}