GitHub PullRequestReviewCommentEvent at 2014-07-19 05:11:54
Repository: django
Actor: loic
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/15142010","id":15142010,"diff_hunk":"@@ -204,6 +207,30 @@ def iri_to_uri(iri):\n     return quote(force_bytes(iri), safe=b\"/#%[]=:;$&()+,!?*@'~\")\n \n \n+def uri_to_iri(uri):","path":"django/utils/encoding.py","position":19,"original_position":19,"commit_id":"0c98714a560387e61c07a734c016219a7a393a23","original_commit_id":"0c98714a560387e61c07a734c016219a7a393a23","user":{"login":"loic","id":36160,"avatar_url":"https://avatars.githubusercontent.com/u/36160?","gravatar_id":"38f0074996f0e2db5710693707e770d7","url":"https://api.github.com/users/loic","html_url":"https://github.com/loic","followers_url":"https://api.github.com/users/loic/followers","following_url":"https://api.github.com/users/loic/following{/other_user}","gists_url":"https://api.github.com/users/loic/gists{/gist_id}","starred_url":"https://api.github.com/users/loic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loic/subscriptions","organizations_url":"https://api.github.com/users/loic/orgs","repos_url":"https://api.github.com/users/loic/repos","events_url":"https://api.github.com/users/loic/events{/privacy}","received_events_url":"https://api.github.com/users/loic/received_events","type":"User","site_admin":false},"body":"I would have been interested in something closer to werkezeug's. That takes encoding as a parameter, etc.","created_at":"2014-07-19T05:11:54Z","updated_at":"2014-07-19T05:11:54Z","html_url":"https://github.com/django/django/pull/2932#discussion_r15142010","pull_request_url":"https://api.github.com/repos/django/django/pulls/2932","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/15142010"},"html":{"href":"https://github.com/django/django/pull/2932#discussion_r15142010"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/2932"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/2932","id":18617602,"html_url":"https://github.com/django/django/pull/2932","diff_url":"https://github.com/django/django/pull/2932.diff","patch_url":"https://github.com/django/django/pull/2932.patch","issue_url":"https://api.github.com/repos/django/django/issues/2932","number":2932,"state":"open","title":"Fixed #19508 -- Used uri_to_iri.","user":{"login":"coder9042","id":5247374,"avatar_url":"https://avatars.githubusercontent.com/u/5247374?","gravatar_id":"a7b7e3784e7f6299def696779aba819f","url":"https://api.github.com/users/coder9042","html_url":"https://github.com/coder9042","followers_url":"https://api.github.com/users/coder9042/followers","following_url":"https://api.github.com/users/coder9042/following{/other_user}","gists_url":"https://api.github.com/users/coder9042/gists{/gist_id}","starred_url":"https://api.github.com/users/coder9042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coder9042/subscriptions","organizations_url":"https://api.github.com/users/coder9042/orgs","repos_url":"https://api.github.com/users/coder9042/repos","events_url":"https://api.github.com/users/coder9042/events{/privacy}","received_events_url":"https://api.github.com/users/coder9042/received_events","type":"User","site_admin":false},"body":"This is a PR for ticket #19508 for which another PR #2919 was opened by me a few days ago.\r\nThis PR implements `uri_to_iri` as per RFC and changes the `PATH_INFO` at the very time when `environ` is being set contrary to the previous one which corrected the received url from `environ`.","created_at":"2014-07-19T04:35:06Z","updated_at":"2014-07-19T05:11:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e584525ac3d046977489db0063a2be419eeba9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/2932/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/2932/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments/{number}","comments_url":"https://api.github.com/repos/django/django/issues/2932/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/0c98714a560387e61c07a734c016219a7a393a23","head":{"label":"coder9042:gsoc_19508#2","ref":"gsoc_19508#2","sha":"0c98714a560387e61c07a734c016219a7a393a23","user":{"login":"coder9042","id":5247374,"avatar_url":"https://avatars.githubusercontent.com/u/5247374?","gravatar_id":"a7b7e3784e7f6299def696779aba819f","url":"https://api.github.com/users/coder9042","html_url":"https://github.com/coder9042","followers_url":"https://api.github.com/users/coder9042/followers","following_url":"https://api.github.com/users/coder9042/following{/other_user}","gists_url":"https://api.github.com/users/coder9042/gists{/gist_id}","starred_url":"https://api.github.com/users/coder9042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coder9042/subscriptions","organizations_url":"https://api.github.com/users/coder9042/orgs","repos_url":"https://api.github.com/users/coder9042/repos","events_url":"https://api.github.com/users/coder9042/events{/privacy}","received_events_url":"https://api.github.com/users/coder9042/received_events","type":"User","site_admin":false},"repo":{"id":15231768,"name":"django","full_name":"coder9042/django","owner":{"login":"coder9042","id":5247374,"avatar_url":"https://avatars.githubusercontent.com/u/5247374?","gravatar_id":"a7b7e3784e7f6299def696779aba819f","url":"https://api.github.com/users/coder9042","html_url":"https://github.com/coder9042","followers_url":"https://api.github.com/users/coder9042/followers","following_url":"https://api.github.com/users/coder9042/following{/other_user}","gists_url":"https://api.github.com/users/coder9042/gists{/gist_id}","starred_url":"https://api.github.com/users/coder9042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coder9042/subscriptions","organizations_url":"https://api.github.com/users/coder9042/orgs","repos_url":"https://api.github.com/users/coder9042/repos","events_url":"https://api.github.com/users/coder9042/events{/privacy}","received_events_url":"https://api.github.com/users/coder9042/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coder9042/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/coder9042/django","forks_url":"https://api.github.com/repos/coder9042/django/forks","keys_url":"https://api.github.com/repos/coder9042/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coder9042/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coder9042/django/teams","hooks_url":"https://api.github.com/repos/coder9042/django/hooks","issue_events_url":"https://api.github.com/repos/coder9042/django/issues/events{/number}","events_url":"https://api.github.com/repos/coder9042/django/events","assignees_url":"https://api.github.com/repos/coder9042/django/assignees{/user}","branches_url":"https://api.github.com/repos/coder9042/django/branches{/branch}","tags_url":"https://api.github.com/repos/coder9042/django/tags","blobs_url":"https://api.github.com/repos/coder9042/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coder9042/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coder9042/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/coder9042/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coder9042/django/statuses/{sha}","languages_url":"https://api.github.com/repos/coder9042/django/languages","stargazers_url":"https://api.github.com/repos/coder9042/django/stargazers","contributors_url":"https://api.github.com/repos/coder9042/django/contributors","subscribers_url":"https://api.github.com/repos/coder9042/django/subscribers","subscription_url":"https://api.github.com/repos/coder9042/django/subscription","commits_url":"https://api.github.com/repos/coder9042/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/coder9042/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/coder9042/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/coder9042/django/issues/comments/{number}","contents_url":"https://api.github.com/repos/coder9042/django/contents/{+path}","compare_url":"https://api.github.com/repos/coder9042/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coder9042/django/merges","archive_url":"https://api.github.com/repos/coder9042/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coder9042/django/downloads","issues_url":"https://api.github.com/repos/coder9042/django/issues{/number}","pulls_url":"https://api.github.com/repos/coder9042/django/pulls{/number}","milestones_url":"https://api.github.com/repos/coder9042/django/milestones{/number}","notifications_url":"https://api.github.com/repos/coder9042/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coder9042/django/labels{/name}","releases_url":"https://api.github.com/repos/coder9042/django/releases{/id}","created_at":"2013-12-16T17:05:03Z","updated_at":"2014-07-02T05:13:33Z","pushed_at":"2014-07-19T04:34:23Z","git_url":"git://github.com/coder9042/django.git","ssh_url":"git@github.com:coder9042/django.git","clone_url":"https://github.com/coder9042/django.git","svn_url":"https://github.com/coder9042/django","homepage":"http://www.djangoproject.com/","size":105529,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"70c54a3694975c43a2e0e22c4a90c3cbe1eb54e4","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?","gravatar_id":"fd542381031aa84dca86628ece84fc07","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?","gravatar_id":"fd542381031aa84dca86628ece84fc07","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments/{number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2014-07-19T03:52:44Z","pushed_at":"2014-07-18T16:11:20Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"http://www.djangoproject.com/","size":217505,"stargazers_count":10512,"watchers_count":10512,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":4025,"mirror_url":null,"open_issues_count":111,"forks":4025,"open_issues":111,"watchers":10512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/2932"},"html":{"href":"https://github.com/django/django/pull/2932"},"issue":{"href":"https://api.github.com/repos/django/django/issues/2932"},"comments":{"href":"https://api.github.com/repos/django/django/issues/2932/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/2932/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/2932/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/0c98714a560387e61c07a734c016219a7a393a23"}}}}