GitHub PullRequestReviewCommentEvent at 2014-05-05 13:02:48
Repository: libcloud
Actor: benoit-canet
Payload: {"comment":{"url":"https://api.github.com/repos/apache/libcloud/pulls/comments/12277434","id":12277434,"diff_hunk":"@@ -622,6 +629,340 @@\n     }\n }\n \n+\n+\"\"\"\n+Sizes must be hardcoded because Outscale doesn't provide an API to fetch them.\n+Outscale cloud instances share some names with EC2 but have differents\n+specifications so declare them in another constant.\n+\"\"\"\n+OUTSCALE_INSTANCE_TYPES = {\n+    't1.micro': {\n+        'id': 't1.micro',\n+        'name': 'Micro Instance',\n+        'ram': 615,\n+        'disk': 0,\n+        'bandwidth': None\n+    },\n+    'm1.small': {\n+        'id': 'm1.small',\n+        'name': 'Standard Small Instance',\n+        'ram': 1740,\n+        'disk': 150,\n+        'bandwidth': None\n+    },\n+    'm1.medium': {\n+        'id': 'm1.medium',\n+        'name': 'Standard Medium Instance',\n+        'ram': 3840,\n+        'disk': 420,\n+        'bandwidth': None\n+    },\n+    'm1.large': {\n+        'id': 'm1.large',\n+        'name': 'Standard Large Instance',\n+        'ram': 7680,\n+        'disk': 840,\n+        'bandwidth': None\n+    },\n+    'm1.xlarge': {\n+        'id': 'm1.xlarge',\n+        'name': 'Standard Extra Large Instance',\n+        'ram': 15360,\n+        'disk': 1680,\n+        'bandwidth': None\n+    },\n+    'c1.medium': {\n+        'id': 'c1.medium',\n+        'name': 'Compute Optimized Medium Instance',\n+        'ram': 1740,\n+        'disk': 340,\n+        'bandwidth': None\n+    },\n+    'c1.xlarge': {\n+        'id': 'c1.xlarge',\n+        'name': 'Compute Optimized Extra Large Instance',\n+        'ram': 7168,\n+        'disk': 1680,\n+        'bandwidth': None\n+    },\n+    'c3.large': {\n+        'id': 'c3.large',\n+        'name': 'Compute Optimized Large Instance',\n+        'ram': 3840,\n+        'disk': 32,\n+        'bandwidth': None\n+    },\n+    'c3.xlarge': {\n+        'id': 'c3.xlarge',\n+        'name': 'Compute Optimized Extra Large Instance',\n+        'ram': 7168,\n+        'disk': 80,\n+        'bandwidth': None\n+    },\n+    'c3.2xlarge': {\n+        'id': 'c3.2xlarge',\n+        'name': 'Compute Optimized Double Extra Large Instance',\n+        'ram': 15359,\n+        'disk': 160,\n+        'bandwidth': None\n+    },\n+    'c3.4xlarge': {\n+        'id': 'c3.4xlarge',\n+        'name': 'Compute Optimized Quadruple Extra Large Instance',\n+        'ram': 30720,\n+        'disk': 320,\n+        'bandwidth': None\n+    },\n+    'c3.8xlarge': {\n+        'id': 'c3.8xlarge',\n+        'name': 'Compute Optimized Eight Extra Large Instance',\n+        'ram': 61440,\n+        'disk': 640,\n+        'bandwidth': None\n+    },\n+    'm2.xlarge': {\n+        'id': 'm2.xlarge',\n+        'name': 'High Memory Extra Large Instance',\n+        'ram': 17510,\n+        'disk': 420,\n+        'bandwidth': None\n+    },\n+    'm2.2xlarge': {\n+        'id': 'm2.2xlarge',\n+        'name': 'High Memory Double Extra Large Instance',\n+        'ram': 35020,\n+        'disk': 840,\n+        'bandwidth': None\n+    },\n+    'm2.4xlarge': {\n+        'id': 'm2.4xlarge',\n+        'name': 'High Memory Quadruple Extra Large Instance',\n+        'ram': 70042,\n+        'disk': 1680,\n+        'bandwidth': None\n+    },\n+    'nv1.small': {\n+        'id': 'nv1.small',\n+        'name': 'GPU Small Instance',\n+        'ram': 1739,\n+        'disk': 150,\n+        'bandwidth': None\n+    },\n+    'nv1.medium': {\n+        'id': 'nv1.medium',\n+        'name': 'GPU Medium Instance',\n+        'ram': 3839,\n+        'disk': 420,\n+        'bandwidth': None\n+    },\n+    'nv1.large': {\n+        'id': 'nv1.large',\n+        'name': 'GPU Large Instance',\n+        'ram': 7679,\n+        'disk': 840,\n+        'bandwidth': None\n+    },\n+    'nv1.xlarge': {\n+        'id': 'nv1.xlarge',\n+        'name': 'GPU Extra Large Instance',\n+        'ram': 15358,\n+        'disk': 1680,\n+        'bandwidth': None\n+    },\n+    'g2.2xlarge': {\n+        'id': 'g2.2xlarge',\n+        'name': 'GPU Double Extra Large Instance',\n+        'ram': 15360,\n+        'disk': 60,\n+        'bandwidth': None\n+    },\n+    'cc1.4xlarge': {\n+        'id': 'cc1.4xlarge',\n+        'name': 'Cluster Compute Quadruple Extra Large Instance',\n+        'ram': 24576,\n+        'disk': 1680,\n+        'bandwidth': None\n+    },\n+    'cc2.8xlarge': {\n+        'id': 'cc2.8xlarge',\n+        'name': 'Cluster Compute Eight Extra Large Instance',\n+        'ram': 65536,\n+        'disk': 3360,\n+        'bandwidth': None\n+    },\n+    'hi1.xlarge': {\n+        'id': 'hi1.xlarge',\n+        'name': 'High Storage Extra Large Instance',\n+        'ram': 15361,\n+        'disk': 1680,\n+        'bandwidth': None\n+    },\n+    'm3.xlarge': {\n+        'id': 'm3.xlarge',\n+        'name': 'High Storage Optimized Extra Large Instance',\n+        'ram': 15357,\n+        'disk': 0,\n+        'bandwidth': None\n+    },\n+    'm3.2xlarge': {\n+        'id': 'm3.2xlarge',\n+        'name': 'High Storage Optimized Double Extra Large Instance',\n+        'ram': 30720,\n+        'disk': 0,\n+        'bandwidth': None\n+    },\n+    'm3s.xlarge': {\n+        'id': 'm3s.xlarge',\n+        'name': 'High Storage Optimized Extra Large Instance',\n+        'ram': 15359,\n+        'disk': 0,\n+        'bandwidth': None\n+    },\n+    'm3s.2xlarge': {\n+        'id': 'm3s.2xlarge',\n+        'name': 'High Storage Optimized Double Extra Large Instance',\n+        'ram': 30719,\n+        'disk': 0,\n+        'bandwidth': None\n+    },\n+    'cr1.8xlarge': {\n+        'id': 'cr1.8xlarge',\n+        'name': 'Memory Optimized Eight Extra Large Instance',\n+        'ram': 249855,\n+        'disk': 240,\n+        'bandwidth': None\n+    },\n+    'os1.2xlarge': {\n+        'id': 'os1.2xlarge',\n+        'name': 'Memory Optimized, High Storage, Passthrough NIC Double Extra '\n+                'Large Instance',\n+        'ram': 65536,\n+        'disk': 60,\n+        'bandwidth': None\n+    },\n+    'os1.4xlarge': {\n+        'id': 'os1.4xlarge',\n+        'name': 'Memory Optimized, High Storage, Passthrough NIC Quadruple Ext'\n+                'ra Large Instance',\n+        'ram': 131072,\n+        'disk': 120,\n+        'bandwidth': None\n+    },\n+    'os1.8xlarge': {\n+        'id': 'os1.8xlarge',\n+        'name': 'Memory Optimized, High Storage, Passthrough NIC Eight Extra L'\n+                'arge Instance',\n+        'ram': 249856,\n+        'disk': 500,\n+        'bandwidth': None\n+    },\n+    'oc1.4xlarge': {\n+        'id': 'oc1.4xlarge',\n+        'name': 'Outscale Quadruple Extra Large Instance',\n+        'ram': 24575,\n+        'disk': 1680,\n+        'bandwidth': None\n+    },\n+    'oc2.8xlarge': {\n+        'id': 'oc2.8xlarge',\n+        'name': 'Outscale Eight Extra Large Instance',\n+        'ram': 65535,\n+        'disk': 3360,\n+        'bandwidth': None\n+    }\n+}\n+\n+\n+\"\"\"\n+The function manipulating Outscale cloud regions will be overriden because\n+Outscale instances types are in a separate dict so also declare Outscale cloud\n+regions in another constant.\n+\"\"\"\n+OUTSCALE_REGION_DETAILS = {\n+    'osc-sas-eu-west-3': {","path":"libcloud/compute/drivers/ec2.py","position":284,"original_position":284,"commit_id":"aa4a2b9f8c9adfcb1a3f7ea82340f8f26f952fdc","original_commit_id":"aa4a2b9f8c9adfcb1a3f7ea82340f8f26f952fdc","user":{"login":"benoit-canet","id":14625,"avatar_url":"https://avatars.githubusercontent.com/u/14625?","gravatar_id":"d586cd8a7a195e1598bcb927b312b5c4","url":"https://api.github.com/users/benoit-canet","html_url":"https://github.com/benoit-canet","followers_url":"https://api.github.com/users/benoit-canet/followers","following_url":"https://api.github.com/users/benoit-canet/following{/other_user}","gists_url":"https://api.github.com/users/benoit-canet/gists{/gist_id}","starred_url":"https://api.github.com/users/benoit-canet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoit-canet/subscriptions","organizations_url":"https://api.github.com/users/benoit-canet/orgs","repos_url":"https://api.github.com/users/benoit-canet/repos","events_url":"https://api.github.com/users/benoit-canet/events{/privacy}","received_events_url":"https://api.github.com/users/benoit-canet/received_events","type":"User","site_admin":false},"body":"Also Outscale SAS prices are in euros and Outscale INC prices in $","created_at":"2014-05-05T13:02:48Z","updated_at":"2014-05-05T13:02:48Z","html_url":"https://github.com/apache/libcloud/pull/285#discussion_r12277434","pull_request_url":"https://api.github.com/repos/apache/libcloud/pulls/285","_links":{"self":{"href":"https://api.github.com/repos/apache/libcloud/pulls/comments/12277434"},"html":{"href":"https://github.com/apache/libcloud/pull/285#discussion_r12277434"},"pull_request":{"href":"https://api.github.com/repos/apache/libcloud/pulls/285"}}}}