GitHub PullRequestReviewCommentEvent at 2014-03-03 13:21:15
Repository: tester
Actor: Majkl578
Payload: {"comment":{"url":"https://api.github.com/repos/nette/tester/pulls/comments/10209499","id":10209499,"diff_hunk":"@@ -0,0 +1,91 @@\n+<?php\n+\n+/**\n+ * This file is part of the Nette Tester.\n+ *\n+ * Copyright (c) 2009 David Grudl (http://davidgrudl.com)\n+ *\n+ * For the full copyright and license information, please view\n+ * the file license.txt that was distributed with this source code.\n+ */\n+\n+namespace Tester\\Runner;\n+\n+use Tester\\Helpers;\n+\n+/**\n+ * HHVM executable command-line.\n+ *\n+ * @author     Michael Moravec\n+ */\n+class HhvmExecutable implements IPhpInterpreter\n+{\n+\t/** @var string  PHP arguments */\n+\tprivate $arguments = '';\n+\n+\t/** @var string  PHP executable */\n+\tprivate $path;\n+\n+\t/** @var string  PHP version */\n+\tprivate $version;\n+\n+\n+\tpublic function __construct($path, $version, $args = NULL)\n+\t{\n+\t\t$this->path = $path;\n+\t\t$this->version = $version;\n+\t\t$this->arguments = (string) $args;\n+\t\t$this->addArgument('--php');\n+\t}\n+\n+\n+\t/**\n+\t * @return string\n+\t */\n+\tpublic function getCommandLine()\n+\t{\n+\t\treturn Helpers::escapeArg($this->path) . ($this->arguments !== '' ? ' ' . $this->arguments : '');\n+\t}\n+\n+\n+\t/**\n+\t * @return string\n+\t */\n+\tpublic function getVersion()\n+\t{\n+\t\treturn $this->version;\n+\t}\n+\n+\n+\t/**\n+\t * @return bool\n+\t */\n+\tpublic function isCgi()\n+\t{\n+\t\treturn FALSE;\n+\t}\n+\n+\n+\t/**\n+\t * @return string\n+\t */\n+\tpublic function getArguments()\n+\t{\n+\t\treturn $this->arguments;\n+\t}\n+\n+\n+\t/**\n+\t * @param string\n+\t * @param mixed\n+\t */\n+\tpublic function addArgument($name, $value = NULL)\n+\t{\n+\t\tif ($this->arguments !== '') {\n+\t\t\t$this->arguments .= ' ';\n+\t\t}\n+\n+\t\t$this->arguments .= $name;\n+\t\t$this->arguments .= ($value !== NULL ? '=' . Helpers::escapeArg($value) : '');","path":"Tester/Runner/HhvmExecutable.php","position":89,"original_position":89,"commit_id":"49063c714d30db5fe4ff061f49a3cc909e4e928b","original_commit_id":"49063c714d30db5fe4ff061f49a3cc909e4e928b","user":{"login":"Majkl578","id":144181,"avatar_url":"https://avatars.githubusercontent.com/u/144181","gravatar_id":"401f5aa2871542fa5563606af5df2a36","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"body":"This is not entirely correct, it will create e.g. `-d=max_execution_time=23` (which is apparently valid anyway), do we care or not?","created_at":"2014-03-03T13:21:15Z","updated_at":"2014-03-03T13:21:15Z","html_url":"https://github.com/nette/tester/pull/104#discussion_r10209499","pull_request_url":"https://api.github.com/repos/nette/tester/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/nette/tester/pulls/comments/10209499"},"html":{"href":"https://github.com/nette/tester/pull/104#discussion_r10209499"},"pull_request":{"href":"https://api.github.com/repos/nette/tester/pulls/104"}}}}