GitHub PullRequestReviewCommentEvent at 2014-11-10 17:05:41
Repository: XBlock
Actor: cpennington
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/XBlock/pulls/comments/20095538","id":20095538,"diff_hunk":"@@ -277,6 +279,9 @@ class will want to refer to.\n             possible to convert it. This provides a guarantee on the stored\n             value type.\n \n+        serialize_as_node: if set, the field will be serialized as a","path":"xblock/fields.py","position":13,"original_position":13,"commit_id":"d77a6cae5c53c321d774a1605b24f117a4995513","original_commit_id":"d77a6cae5c53c321d774a1605b24f117a4995513","user":{"login":"cpennington","id":30236,"avatar_url":"https://avatars.githubusercontent.com/u/30236?v=3","gravatar_id":"","url":"https://api.github.com/users/cpennington","html_url":"https://github.com/cpennington","followers_url":"https://api.github.com/users/cpennington/followers","following_url":"https://api.github.com/users/cpennington/following{/other_user}","gists_url":"https://api.github.com/users/cpennington/gists{/gist_id}","starred_url":"https://api.github.com/users/cpennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpennington/subscriptions","organizations_url":"https://api.github.com/users/cpennington/orgs","repos_url":"https://api.github.com/users/cpennington/repos","events_url":"https://api.github.com/users/cpennington/events{/privacy}","received_events_url":"https://api.github.com/users/cpennington/received_events","type":"User","site_admin":false},"body":"Yeah, a shorter name might be nice. Although: `xml_attribute=False`? `xml_type=True`? Neither of those seem that obvious to me.","created_at":"2014-11-10T17:05:41Z","updated_at":"2014-11-10T17:05:41Z","html_url":"https://github.com/edx/XBlock/pull/244#discussion_r20095538","pull_request_url":"https://api.github.com/repos/edx/XBlock/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/edx/XBlock/pulls/comments/20095538"},"html":{"href":"https://github.com/edx/XBlock/pull/244#discussion_r20095538"},"pull_request":{"href":"https://api.github.com/repos/edx/XBlock/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/edx/XBlock/pulls/244","id":21990013,"html_url":"https://github.com/edx/XBlock/pull/244","diff_url":"https://github.com/edx/XBlock/pull/244.diff","patch_url":"https://github.com/edx/XBlock/pull/244.patch","issue_url":"https://api.github.com/repos/edx/XBlock/issues/244","number":244,"state":"open","locked":false,"title":"Support for json-encoded strings for Dict field","user":{"login":"e-kolpakov","id":3330048,"avatar_url":"https://avatars.githubusercontent.com/u/3330048?v=3","gravatar_id":"","url":"https://api.github.com/users/e-kolpakov","html_url":"https://github.com/e-kolpakov","followers_url":"https://api.github.com/users/e-kolpakov/followers","following_url":"https://api.github.com/users/e-kolpakov/following{/other_user}","gists_url":"https://api.github.com/users/e-kolpakov/gists{/gist_id}","starred_url":"https://api.github.com/users/e-kolpakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-kolpakov/subscriptions","organizations_url":"https://api.github.com/users/e-kolpakov/orgs","repos_url":"https://api.github.com/users/e-kolpakov/repos","events_url":"https://api.github.com/users/e-kolpakov/events{/privacy}","received_events_url":"https://api.github.com/users/e-kolpakov/received_events","type":"User","site_admin":false},"body":"This patch allows setting a json-encoded `dict` to Dict fields, e.g. via data attributes in workbench scenarios.\r\n\r\n* Motivation: Dict field only allows setting `dict` instances or None. This makes integration and manual testing with workbench problematic, as fields of this type can't be set using XML format.\r\n* Affected components: all XBlocks using `Dict` fields, backward compatible with existing setups.\r\n* Affected users: all\r\n* Testing guidelines: run unittests\r\n* Partner information: 3rd party-hosted open edX instance, for an edX solutions client (so will need to get some sort of solution merged in)\r\n* Merge deadline: Oct 21 (soft requirement to minimize code drift, we maintain it on the client fork in the meantime)","created_at":"2014-09-30T08:59:00Z","updated_at":"2014-11-10T17:05:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc497a53237b17e2c1b60b3d9ae48bf01efd5834","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/XBlock/pulls/244/commits","review_comments_url":"https://api.github.com/repos/edx/XBlock/pulls/244/comments","review_comment_url":"https://api.github.com/repos/edx/XBlock/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/XBlock/issues/244/comments","statuses_url":"https://api.github.com/repos/edx/XBlock/statuses/d77a6cae5c53c321d774a1605b24f117a4995513","head":{"label":"open-craft:eugeny/dict-json-encoded","ref":"eugeny/dict-json-encoded","sha":"d77a6cae5c53c321d774a1605b24f117a4995513","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":24224879,"name":"XBlock","full_name":"open-craft/XBlock","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/XBlock","description":"XBlock courseware component architecture","fork":true,"url":"https://api.github.com/repos/open-craft/XBlock","forks_url":"https://api.github.com/repos/open-craft/XBlock/forks","keys_url":"https://api.github.com/repos/open-craft/XBlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/XBlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/XBlock/teams","hooks_url":"https://api.github.com/repos/open-craft/XBlock/hooks","issue_events_url":"https://api.github.com/repos/open-craft/XBlock/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/XBlock/events","assignees_url":"https://api.github.com/repos/open-craft/XBlock/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/XBlock/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/XBlock/tags","blobs_url":"https://api.github.com/repos/open-craft/XBlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/XBlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/XBlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/XBlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/XBlock/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/XBlock/languages","stargazers_url":"https://api.github.com/repos/open-craft/XBlock/stargazers","contributors_url":"https://api.github.com/repos/open-craft/XBlock/contributors","subscribers_url":"https://api.github.com/repos/open-craft/XBlock/subscribers","subscription_url":"https://api.github.com/repos/open-craft/XBlock/subscription","commits_url":"https://api.github.com/repos/open-craft/XBlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/XBlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/XBlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/XBlock/issues/comments/{number}","contents_url":"https://api.github.com/repos/open-craft/XBlock/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/XBlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/XBlock/merges","archive_url":"https://api.github.com/repos/open-craft/XBlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/XBlock/downloads","issues_url":"https://api.github.com/repos/open-craft/XBlock/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/XBlock/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/XBlock/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/XBlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/XBlock/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/XBlock/releases{/id}","created_at":"2014-09-19T09:51:14Z","updated_at":"2014-09-30T07:57:53Z","pushed_at":"2014-11-10T04:03:14Z","git_url":"git://github.com/open-craft/XBlock.git","ssh_url":"git@github.com:open-craft/XBlock.git","clone_url":"https://github.com/open-craft/XBlock.git","svn_url":"https://github.com/open-craft/XBlock","homepage":null,"size":2329,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"fdd4b2bb9aa15aa7c217a8cfca6c5c7d5b602688","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":8710321,"name":"XBlock","full_name":"edx/XBlock","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/XBlock","description":"XBlock courseware component architecture","fork":false,"url":"https://api.github.com/repos/edx/XBlock","forks_url":"https://api.github.com/repos/edx/XBlock/forks","keys_url":"https://api.github.com/repos/edx/XBlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/XBlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/XBlock/teams","hooks_url":"https://api.github.com/repos/edx/XBlock/hooks","issue_events_url":"https://api.github.com/repos/edx/XBlock/issues/events{/number}","events_url":"https://api.github.com/repos/edx/XBlock/events","assignees_url":"https://api.github.com/repos/edx/XBlock/assignees{/user}","branches_url":"https://api.github.com/repos/edx/XBlock/branches{/branch}","tags_url":"https://api.github.com/repos/edx/XBlock/tags","blobs_url":"https://api.github.com/repos/edx/XBlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/XBlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/XBlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/XBlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/XBlock/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/XBlock/languages","stargazers_url":"https://api.github.com/repos/edx/XBlock/stargazers","contributors_url":"https://api.github.com/repos/edx/XBlock/contributors","subscribers_url":"https://api.github.com/repos/edx/XBlock/subscribers","subscription_url":"https://api.github.com/repos/edx/XBlock/subscription","commits_url":"https://api.github.com/repos/edx/XBlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/XBlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/XBlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/XBlock/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/XBlock/contents/{+path}","compare_url":"https://api.github.com/repos/edx/XBlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/XBlock/merges","archive_url":"https://api.github.com/repos/edx/XBlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/XBlock/downloads","issues_url":"https://api.github.com/repos/edx/XBlock/issues{/number}","pulls_url":"https://api.github.com/repos/edx/XBlock/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/XBlock/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/XBlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/XBlock/labels{/name}","releases_url":"https://api.github.com/repos/edx/XBlock/releases{/id}","created_at":"2013-03-11T18:35:36Z","updated_at":"2014-11-08T08:31:31Z","pushed_at":"2014-11-07T21:26:43Z","git_url":"git://github.com/edx/XBlock.git","ssh_url":"git@github.com:edx/XBlock.git","clone_url":"https://github.com/edx/XBlock.git","svn_url":"https://github.com/edx/XBlock","homepage":null,"size":9329,"stargazers_count":365,"watchers_count":365,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":30,"forks":161,"open_issues":30,"watchers":365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/XBlock/pulls/244"},"html":{"href":"https://github.com/edx/XBlock/pull/244"},"issue":{"href":"https://api.github.com/repos/edx/XBlock/issues/244"},"comments":{"href":"https://api.github.com/repos/edx/XBlock/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/XBlock/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/XBlock/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/XBlock/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/edx/XBlock/statuses/d77a6cae5c53c321d774a1605b24f117a4995513"}}}}