GitHub PullRequestReviewCommentEvent at 2014-11-19 18:03:27
Repository: iris
Actor: rhattersley
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/20594225","id":20594225,"diff_hunk":"@@ -22,45 +22,53 @@\n # importing anything else.\n import iris.tests as tests\n \n-from iris.experimental.um import Field, Field3, FieldsFileVariant\n+import shutil\n \n+import numpy as np\n \n+from iris.experimental.um import (Field, Field2, Field3, FieldsFileVariant,\n+                                  FixedLengthHeader)\n+\n+\n+IMDI = -32768\n+RMDI = -1073741824.0\n+\n+\n+@tests.skip_data","path":"lib/iris/tests/integration/test_FieldsFileVariant.py","position":17,"original_position":17,"commit_id":"1e627d416d8d35815815f4fc93b2e013740c7077","original_commit_id":"1e627d416d8d35815815f4fc93b2e013740c7077","user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"body":"Me too. :stuck_out_tongue: ","created_at":"2014-11-19T18:03:27Z","updated_at":"2014-11-19T18:03:27Z","html_url":"https://github.com/SciTools/iris/pull/1443#discussion_r20594225","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/1443","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/20594225"},"html":{"href":"https://github.com/SciTools/iris/pull/1443#discussion_r20594225"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1443"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/1443","id":24679517,"html_url":"https://github.com/SciTools/iris/pull/1443","diff_url":"https://github.com/SciTools/iris/pull/1443.diff","patch_url":"https://github.com/SciTools/iris/pull/1443.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/1443","number":1443,"state":"open","locked":false,"title":"Low-level write access to UM FieldsFile variants.","user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"body":"This PR intends to be a reasonable first stab at providing the ability to modify/create UM FieldsFile variants.\r\n\r\nAs a low-level API it does not guarantee that modified/created files are strictly compliant with the official format documentation. However, it does perform a bare minimum of consistency checks/updates for metadata elements which dictate the locations of the various sections within the file, and which would be tedious and error prone to perform \"by hand\". The elements affected are the start and dimension length elements within the fixed length header, and the LBEGIN and LBNREC elements within the LOOKUP entries.\r\n\r\nNB.\r\n 1. No support is provided for packing data. Unless the \"N1\" digit of `field.lbpack` is zero the file will not be valid.\r\n 2. This PR requires SciTools/iris-test-data#32 to be merged for the tests to pass to without \"naughty\" modifications to .travis.yml.\r\n\r\n - [ ] Update .travis.yml once test data has been merged.","created_at":"2014-11-19T10:46:50Z","updated_at":"2014-11-19T18:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54b922ebfec599ac78369705c2813b8f9840ecec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/1443/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/1443/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/1443/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/1e627d416d8d35815815f4fc93b2e013740c7077","head":{"label":"rhattersley:ff-save","ref":"ff-save","sha":"1e627d416d8d35815815f4fc93b2e013740c7077","user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"repo":{"id":5312787,"name":"iris","full_name":"rhattersley/iris","owner":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhattersley/iris","description":"","fork":true,"url":"https://api.github.com/repos/rhattersley/iris","forks_url":"https://api.github.com/repos/rhattersley/iris/forks","keys_url":"https://api.github.com/repos/rhattersley/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhattersley/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhattersley/iris/teams","hooks_url":"https://api.github.com/repos/rhattersley/iris/hooks","issue_events_url":"https://api.github.com/repos/rhattersley/iris/issues/events{/number}","events_url":"https://api.github.com/repos/rhattersley/iris/events","assignees_url":"https://api.github.com/repos/rhattersley/iris/assignees{/user}","branches_url":"https://api.github.com/repos/rhattersley/iris/branches{/branch}","tags_url":"https://api.github.com/repos/rhattersley/iris/tags","blobs_url":"https://api.github.com/repos/rhattersley/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhattersley/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhattersley/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhattersley/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhattersley/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/rhattersley/iris/languages","stargazers_url":"https://api.github.com/repos/rhattersley/iris/stargazers","contributors_url":"https://api.github.com/repos/rhattersley/iris/contributors","subscribers_url":"https://api.github.com/repos/rhattersley/iris/subscribers","subscription_url":"https://api.github.com/repos/rhattersley/iris/subscription","commits_url":"https://api.github.com/repos/rhattersley/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhattersley/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhattersley/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhattersley/iris/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhattersley/iris/contents/{+path}","compare_url":"https://api.github.com/repos/rhattersley/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhattersley/iris/merges","archive_url":"https://api.github.com/repos/rhattersley/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhattersley/iris/downloads","issues_url":"https://api.github.com/repos/rhattersley/iris/issues{/number}","pulls_url":"https://api.github.com/repos/rhattersley/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/rhattersley/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/rhattersley/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhattersley/iris/labels{/name}","releases_url":"https://api.github.com/repos/rhattersley/iris/releases{/id}","created_at":"2012-08-06T10:24:45Z","updated_at":"2014-10-10T10:10:10Z","pushed_at":"2014-11-19T15:33:25Z","git_url":"git://github.com/rhattersley/iris.git","ssh_url":"git@github.com:rhattersley/iris.git","clone_url":"https://github.com/rhattersley/iris.git","svn_url":"https://github.com/rhattersley/iris","homepage":null,"size":99714,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"84abba51bdc341e6ff8d29afbfbfa732f69031e8","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments/{number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","created_at":"2012-08-06T10:09:14Z","updated_at":"2014-11-18T15:36:09Z","pushed_at":"2014-11-18T15:36:09Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":148147,"stargazers_count":75,"watchers_count":75,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":154,"forks":65,"open_issues":154,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1443"},"html":{"href":"https://github.com/SciTools/iris/pull/1443"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/1443"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/1443/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1443/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1443/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/1e627d416d8d35815815f4fc93b2e013740c7077"}}}}