GitHub PullRequestReviewCommentEvent at 2014-07-30 07:40:17
Repository: service-sphinxsearch
Actor: loicgasser
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/comments/15569875","id":15569875,"diff_hunk":"@@ -81,27 +89,18 @@ then\n     sudo -u sphinxsearch python -u $PGTRIGGER -i $INDEXPATTERN -c update    \n else\n     echo \"no sphinx indexes will be updated ...\"\n+    # reload new sphinx configuration\n+    echo \"trying to load new sphinx config ...\"\n+    sudo -u sphinxsearch /etc/init.d/sphinxsearch reload | grep -i \"WARNING\\|ERROR\"\n fi\n \n-# Check service status\n-echo \"Sphinx is running with pid $(pgrep searchd) ...\"\n-if [ $(pgrep searchd) ]; then\n-    status=$(sudo -u sphinxsearch /etc/init.d/sphinxsearch status)\n-    if [ $? -eq 0 ]; then\n-        echo \"  service has been started with $ /etc/init.d/sphinxsearch start\"\n-        echo -e \"  ${red}stopping service ...${NC}\"\n-        sudo -u sphinxsearch /etc/init.d/sphinxsearch stop\n-    else\n-        echo \"  service has been started with $ searchd\"\n-        echo -e \"  ${red}stopping service ...${NC}\"\n-        sudo -u sphinxsearch searchd --stop\n-    fi\n-else\n-    echo -e \"    ${red}WARNING: service was not running${NC}\"\n-fi\n-\n-# wait 5 seconds for sphinxsearch to stop completely\n-sleep 5\n+COUNTER=1\n+while [ $(find $SPHINXINDEX -name \"*.new.*\" | wc -l) -ne 0  ]","path":"deploy/hooks_conf_only/post-restore-code","position":52,"original_position":52,"commit_id":"e9249e9a278901f2ebf80fb1dc1cd574f080c564","original_commit_id":"e9249e9a278901f2ebf80fb1dc1cd574f080c564","user":{"login":"loicgasser","id":3306154,"avatar_url":"https://avatars.githubusercontent.com/u/3306154?v=1","gravatar_id":"e858a26f888d21f374924d564aaca6a5","url":"https://api.github.com/users/loicgasser","html_url":"https://github.com/loicgasser","followers_url":"https://api.github.com/users/loicgasser/followers","following_url":"https://api.github.com/users/loicgasser/following{/other_user}","gists_url":"https://api.github.com/users/loicgasser/gists{/gist_id}","starred_url":"https://api.github.com/users/loicgasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loicgasser/subscriptions","organizations_url":"https://api.github.com/users/loicgasser/orgs","repos_url":"https://api.github.com/users/loicgasser/repos","events_url":"https://api.github.com/users/loicgasser/events{/privacy}","received_events_url":"https://api.github.com/users/loicgasser/received_events","type":"User","site_admin":false},"body":"Good idea!","created_at":"2014-07-30T07:40:17Z","updated_at":"2014-07-30T07:40:17Z","html_url":"https://github.com/geoadmin/service-sphinxsearch/pull/134#discussion_r15569875","pull_request_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/comments/15569875"},"html":{"href":"https://github.com/geoadmin/service-sphinxsearch/pull/134#discussion_r15569875"},"pull_request":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/134","id":18532866,"html_url":"https://github.com/geoadmin/service-sphinxsearch/pull/134","diff_url":"https://github.com/geoadmin/service-sphinxsearch/pull/134.diff","patch_url":"https://github.com/geoadmin/service-sphinxsearch/pull/134.patch","issue_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues/134","number":134,"state":"open","title":"wait for indexer to finish index rotation before deleting orphaned","user":{"login":"ltclm","id":5286659,"avatar_url":"https://avatars.githubusercontent.com/u/5286659?v=1","gravatar_id":"672a798e4c85f73580d8b5c7bafb46b3","url":"https://api.github.com/users/ltclm","html_url":"https://github.com/ltclm","followers_url":"https://api.github.com/users/ltclm/followers","following_url":"https://api.github.com/users/ltclm/following{/other_user}","gists_url":"https://api.github.com/users/ltclm/gists{/gist_id}","starred_url":"https://api.github.com/users/ltclm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltclm/subscriptions","organizations_url":"https://api.github.com/users/ltclm/orgs","repos_url":"https://api.github.com/users/ltclm/repos","events_url":"https://api.github.com/users/ltclm/events{/privacy}","received_events_url":"https://api.github.com/users/ltclm/received_events","type":"User","site_admin":false},"body":"improve stability of deploy \r\nthe rotation of the indexes takes a few seconds, the clean_index function (remove orphaned indexes) has to wait for the rotation to be finished.\r\n","created_at":"2014-07-17T14:52:42Z","updated_at":"2014-07-30T07:40:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5db811195aca27889fcbd82c7c358897c935425","assignee":{"login":"gjn","id":2572317,"avatar_url":"https://avatars.githubusercontent.com/u/2572317?v=1","gravatar_id":"6856d9511ef090dc14eb7d14bcd19ffc","url":"https://api.github.com/users/gjn","html_url":"https://github.com/gjn","followers_url":"https://api.github.com/users/gjn/followers","following_url":"https://api.github.com/users/gjn/following{/other_user}","gists_url":"https://api.github.com/users/gjn/gists{/gist_id}","starred_url":"https://api.github.com/users/gjn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjn/subscriptions","organizations_url":"https://api.github.com/users/gjn/orgs","repos_url":"https://api.github.com/users/gjn/repos","events_url":"https://api.github.com/users/gjn/events{/privacy}","received_events_url":"https://api.github.com/users/gjn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/134/commits","review_comments_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/134/comments","review_comment_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues/134/comments","statuses_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/statuses/e9249e9a278901f2ebf80fb1dc1cd574f080c564","head":{"label":"geoadmin:dev_ltclm_improve_deploy","ref":"dev_ltclm_improve_deploy","sha":"e9249e9a278901f2ebf80fb1dc1cd574f080c564","user":{"login":"geoadmin","id":3369793,"avatar_url":"https://avatars.githubusercontent.com/u/3369793?v=1","gravatar_id":"09b2643b75739dfe879abfbb69d3c593","url":"https://api.github.com/users/geoadmin","html_url":"https://github.com/geoadmin","followers_url":"https://api.github.com/users/geoadmin/followers","following_url":"https://api.github.com/users/geoadmin/following{/other_user}","gists_url":"https://api.github.com/users/geoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/geoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoadmin/subscriptions","organizations_url":"https://api.github.com/users/geoadmin/orgs","repos_url":"https://api.github.com/users/geoadmin/repos","events_url":"https://api.github.com/users/geoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/geoadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":12296583,"name":"service-sphinxsearch","full_name":"geoadmin/service-sphinxsearch","owner":{"login":"geoadmin","id":3369793,"avatar_url":"https://avatars.githubusercontent.com/u/3369793?v=1","gravatar_id":"09b2643b75739dfe879abfbb69d3c593","url":"https://api.github.com/users/geoadmin","html_url":"https://github.com/geoadmin","followers_url":"https://api.github.com/users/geoadmin/followers","following_url":"https://api.github.com/users/geoadmin/following{/other_user}","gists_url":"https://api.github.com/users/geoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/geoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoadmin/subscriptions","organizations_url":"https://api.github.com/users/geoadmin/orgs","repos_url":"https://api.github.com/users/geoadmin/repos","events_url":"https://api.github.com/users/geoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/geoadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoadmin/service-sphinxsearch","description":"Sphinx Search service for RE3","fork":false,"url":"https://api.github.com/repos/geoadmin/service-sphinxsearch","forks_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/forks","keys_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/teams","hooks_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/hooks","issue_events_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues/events{/number}","events_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/events","assignees_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/assignees{/user}","branches_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/branches{/branch}","tags_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/tags","blobs_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/languages","stargazers_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/stargazers","contributors_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/contributors","subscribers_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/subscribers","subscription_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/subscription","commits_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/contents/{+path}","compare_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/merges","archive_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/downloads","issues_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues{/number}","pulls_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/labels{/name}","releases_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/releases{/id}","created_at":"2013-08-22T12:40:38Z","updated_at":"2014-07-02T07:52:49Z","pushed_at":"2014-07-29T12:58:40Z","git_url":"git://github.com/geoadmin/service-sphinxsearch.git","ssh_url":"git@github.com:geoadmin/service-sphinxsearch.git","clone_url":"https://github.com/geoadmin/service-sphinxsearch.git","svn_url":"https://github.com/geoadmin/service-sphinxsearch","homepage":null,"size":4532,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"geoadmin:master","ref":"master","sha":"17710e75aa8f6aab91b92ae83649403287f3871a","user":{"login":"geoadmin","id":3369793,"avatar_url":"https://avatars.githubusercontent.com/u/3369793?v=1","gravatar_id":"09b2643b75739dfe879abfbb69d3c593","url":"https://api.github.com/users/geoadmin","html_url":"https://github.com/geoadmin","followers_url":"https://api.github.com/users/geoadmin/followers","following_url":"https://api.github.com/users/geoadmin/following{/other_user}","gists_url":"https://api.github.com/users/geoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/geoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoadmin/subscriptions","organizations_url":"https://api.github.com/users/geoadmin/orgs","repos_url":"https://api.github.com/users/geoadmin/repos","events_url":"https://api.github.com/users/geoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/geoadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":12296583,"name":"service-sphinxsearch","full_name":"geoadmin/service-sphinxsearch","owner":{"login":"geoadmin","id":3369793,"avatar_url":"https://avatars.githubusercontent.com/u/3369793?v=1","gravatar_id":"09b2643b75739dfe879abfbb69d3c593","url":"https://api.github.com/users/geoadmin","html_url":"https://github.com/geoadmin","followers_url":"https://api.github.com/users/geoadmin/followers","following_url":"https://api.github.com/users/geoadmin/following{/other_user}","gists_url":"https://api.github.com/users/geoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/geoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoadmin/subscriptions","organizations_url":"https://api.github.com/users/geoadmin/orgs","repos_url":"https://api.github.com/users/geoadmin/repos","events_url":"https://api.github.com/users/geoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/geoadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoadmin/service-sphinxsearch","description":"Sphinx Search service for RE3","fork":false,"url":"https://api.github.com/repos/geoadmin/service-sphinxsearch","forks_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/forks","keys_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/teams","hooks_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/hooks","issue_events_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues/events{/number}","events_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/events","assignees_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/assignees{/user}","branches_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/branches{/branch}","tags_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/tags","blobs_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/languages","stargazers_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/stargazers","contributors_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/contributors","subscribers_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/subscribers","subscription_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/subscription","commits_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/contents/{+path}","compare_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/merges","archive_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/downloads","issues_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues{/number}","pulls_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/labels{/name}","releases_url":"https://api.github.com/repos/geoadmin/service-sphinxsearch/releases{/id}","created_at":"2013-08-22T12:40:38Z","updated_at":"2014-07-02T07:52:49Z","pushed_at":"2014-07-29T12:58:40Z","git_url":"git://github.com/geoadmin/service-sphinxsearch.git","ssh_url":"git@github.com:geoadmin/service-sphinxsearch.git","clone_url":"https://github.com/geoadmin/service-sphinxsearch.git","svn_url":"https://github.com/geoadmin/service-sphinxsearch","homepage":null,"size":4532,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/134"},"html":{"href":"https://github.com/geoadmin/service-sphinxsearch/pull/134"},"issue":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues/134"},"comments":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/geoadmin/service-sphinxsearch/statuses/e9249e9a278901f2ebf80fb1dc1cd574f080c564"}}}}