GitHub PullRequestReviewCommentEvent at 2014-05-11 07:28:16
Repository: flixel
Actor: Gama11
Payload: {"comment":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/12507751","id":12507751,"diff_hunk":"@@ -58,10 +58,10 @@ class FlxMath\n \t * @param\tMax\t\tAny number.\n \t * @return\tThe bounded value of the number.\n \t */\n-\tpublic static inline function bound(Value:Float, Min:Float, Max:Float):Float\n+\tpublic static inline function bound(Value:Float, Min:Null<Float>, Max:Null<Float>):Float","path":"flixel/util/FlxMath.hx","position":5,"original_position":5,"commit_id":"95c4273e1ae3cc6b3f866242bc993c24b75786ee","original_commit_id":"95c4273e1ae3cc6b3f866242bc993c24b75786ee","user":{"login":"Gama11","id":2620907,"avatar_url":"https://avatars.githubusercontent.com/u/2620907?","gravatar_id":"faf350239a4a63b2ba97d90e51860c79","url":"https://api.github.com/users/Gama11","html_url":"https://github.com/Gama11","followers_url":"https://api.github.com/users/Gama11/followers","following_url":"https://api.github.com/users/Gama11/following{/other_user}","gists_url":"https://api.github.com/users/Gama11/gists{/gist_id}","starred_url":"https://api.github.com/users/Gama11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gama11/subscriptions","organizations_url":"https://api.github.com/users/Gama11/orgs","repos_url":"https://api.github.com/users/Gama11/repos","events_url":"https://api.github.com/users/Gama11/events{/privacy}","received_events_url":"https://api.github.com/users/Gama11/received_events","type":"User","site_admin":false},"body":"This function's description now needs a comment about the meaning of `null`. Also, `inBounds()` should probably behave the same way for consistency.","created_at":"2014-05-11T07:28:16Z","updated_at":"2014-05-11T07:28:16Z","html_url":"https://github.com/HaxeFlixel/flixel/pull/1070#discussion_r12507751","pull_request_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1070","_links":{"self":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/12507751"},"html":{"href":"https://github.com/HaxeFlixel/flixel/pull/1070#discussion_r12507751"},"pull_request":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1070"}}}}