GitHub PullRequestEvent at 2014-06-21 20:22:11
Repository: WikibaseQueryEngine
Actor: JeroenDeDauw
Payload: {"action":"closed","number":60,"pull_request":{"url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/60","id":17362717,"html_url":"https://github.com/wmde/WikibaseQueryEngine/pull/60","diff_url":"https://github.com/wmde/WikibaseQueryEngine/pull/60.diff","patch_url":"https://github.com/wmde/WikibaseQueryEngine/pull/60.patch","issue_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues/60","number":60,"state":"closed","title":"Drop \"value field\", make \"sort fields\" abstract","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?","gravatar_id":"37a5d7555c26958a623057f5937bbe05","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"1. Drop pointless value field. It just doesn't make sense to have a single value field. Think of a LatLong value. It's stored in two numeric columns. You need both to get the full value. Why should we store the exact same a second time in a serialized string? And who is responsible for deserializing this string? _(FIXME: Introduce a method that returns a DataValue object.)_\r\n2. Default label field to null. _(FIXME: Drop this in favor of a method that returns a string suitable for previewing purposes.)_\r\n3. Default equality and sort fields to `'hash'`. So it fits the equality value which also defaults to `getHash`.\r\n\r\nAlso:\r\n* Drop pointless JSON field from monolingual handler. It just repeats what's in the other two fields. See point 1. above.\r\n* Add some missing indexes.\r\n* Add type hints.\r\n\r\nI would like to split this in multiple patches but can't since GitHub doesn't support patches that depend on each other. That would be a much bigger mess than it is now.","created_at":"2014-06-19T16:57:58Z","updated_at":"2014-06-21T20:22:11Z","closed_at":"2014-06-21T20:22:11Z","merged_at":"2014-06-21T20:22:11Z","merge_commit_sha":"0c12a1155d6806b2f12fbdc1aa1c42c3a41e922f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/60/commits","review_comments_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/60/comments","review_comment_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues/60/comments","statuses_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/statuses/8634b1c3f4fcee1a2f9336f138096c06715eb2a2","head":{"label":"wmde:drop-value","ref":"drop-value","sha":"8634b1c3f4fcee1a2f9336f138096c06715eb2a2","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?","gravatar_id":"33863e1474a6affda4657e60bd5914fd","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":16121892,"name":"WikibaseQueryEngine","full_name":"wmde/WikibaseQueryEngine","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?","gravatar_id":"33863e1474a6affda4657e60bd5914fd","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseQueryEngine","description":"Answers Ask queries against a collection of Wikibase entities","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseQueryEngine","forks_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/releases{/id}","created_at":"2014-01-21T23:02:24Z","updated_at":"2014-06-21T20:22:11Z","pushed_at":"2014-06-21T20:22:11Z","git_url":"git://github.com/wmde/WikibaseQueryEngine.git","ssh_url":"git@github.com:wmde/WikibaseQueryEngine.git","clone_url":"https://github.com/wmde/WikibaseQueryEngine.git","svn_url":"https://github.com/wmde/WikibaseQueryEngine","homepage":null,"size":2214,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"417a9ebc33fe610f0f18fb72d100ccba63baebcd","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?","gravatar_id":"33863e1474a6affda4657e60bd5914fd","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":16121892,"name":"WikibaseQueryEngine","full_name":"wmde/WikibaseQueryEngine","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?","gravatar_id":"33863e1474a6affda4657e60bd5914fd","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseQueryEngine","description":"Answers Ask queries against a collection of Wikibase entities","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseQueryEngine","forks_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/releases{/id}","created_at":"2014-01-21T23:02:24Z","updated_at":"2014-06-21T20:22:11Z","pushed_at":"2014-06-21T20:22:11Z","git_url":"git://github.com/wmde/WikibaseQueryEngine.git","ssh_url":"git@github.com:wmde/WikibaseQueryEngine.git","clone_url":"https://github.com/wmde/WikibaseQueryEngine.git","svn_url":"https://github.com/wmde/WikibaseQueryEngine","homepage":null,"size":2214,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/60"},"html":{"href":"https://github.com/wmde/WikibaseQueryEngine/pull/60"},"issue":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues/60"},"comments":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/statuses/8634b1c3f4fcee1a2f9336f138096c06715eb2a2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JeroenDeDauw","id":146040,"avatar_url":"https://avatars.githubusercontent.com/u/146040?","gravatar_id":"b6af5e35644a712550f678d5e6403850","url":"https://api.github.com/users/JeroenDeDauw","html_url":"https://github.com/JeroenDeDauw","followers_url":"https://api.github.com/users/JeroenDeDauw/followers","following_url":"https://api.github.com/users/JeroenDeDauw/following{/other_user}","gists_url":"https://api.github.com/users/JeroenDeDauw/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenDeDauw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenDeDauw/subscriptions","organizations_url":"https://api.github.com/users/JeroenDeDauw/orgs","repos_url":"https://api.github.com/users/JeroenDeDauw/repos","events_url":"https://api.github.com/users/JeroenDeDauw/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenDeDauw/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":58,"deletions":93,"changed_files":10}}