GitHub PullRequestReviewCommentEvent at 2014-12-30 06:57:13
Repository: buildbot
Actor: sa2ajj
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/22340295","id":22340295,"diff_hunk":"@@ -87,24 +88,73 @@ def tearDown(self):\n         self.tearDownDirs()\n \n     @defer.inlineCallbacks\n-    def doForceBuild(self, wantSteps=False, wantProperties=False):\n+    def doForceBuild(self, wantSteps=False, wantProperties=False,\n+                     wantLogs=False, useChange=False):\n \n         # force a build, and wait until it is finished\n         d = defer.Deferred()\n-        consumer = yield self.master.mq.startConsuming(\n-            lambda e, data: d.callback(data),\n+\n+        # in order to allow trigger based integration tests\n+        # we wait until the first started build is finished\n+        self.firstBuildId = None\n+\n+        def newCallback(e, data):","path":"master/buildbot/test/util/integration.py","position":25,"original_position":25,"commit_id":"9068ca8f5099a0dc66cb4361234c9a342a50d93d","original_commit_id":"9068ca8f5099a0dc66cb4361234c9a342a50d93d","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"body":"If parameter `e` is not use, can `_` be used instead?","created_at":"2014-12-30T06:57:13Z","updated_at":"2014-12-30T06:57:13Z","html_url":"https://github.com/buildbot/buildbot/pull/1471#discussion_r22340295","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1471","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/22340295"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1471#discussion_r22340295"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1471"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1471","id":26660602,"html_url":"https://github.com/buildbot/buildbot/pull/1471","diff_url":"https://github.com/buildbot/buildbot/pull/1471.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1471.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1471","number":1471,"state":"open","locked":false,"title":"Integration base test improvements","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"body":"- add possibility of forcing a build with a change\r\n- fix issue with forcing a build that triggers other builds\r\n- add printBuild method for debugging in console\r\n\r\n\r\nanother improvement for buildbot_travis","created_at":"2014-12-29T20:39:37Z","updated_at":"2014-12-30T06:57:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7598a73fb03562785c8d5310e9a94a313323daf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1471/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1471/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1471/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/9068ca8f5099a0dc66cb4361234c9a342a50d93d","head":{"label":"tardyp:integration","ref":"integration","sha":"9068ca8f5099a0dc66cb4361234c9a342a50d93d","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"repo":{"id":930175,"name":"buildbot","full_name":"tardyp/buildbot","owner":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tardyp/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/tardyp/buildbot","forks_url":"https://api.github.com/repos/tardyp/buildbot/forks","keys_url":"https://api.github.com/repos/tardyp/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tardyp/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tardyp/buildbot/teams","hooks_url":"https://api.github.com/repos/tardyp/buildbot/hooks","issue_events_url":"https://api.github.com/repos/tardyp/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/tardyp/buildbot/events","assignees_url":"https://api.github.com/repos/tardyp/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/tardyp/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/tardyp/buildbot/tags","blobs_url":"https://api.github.com/repos/tardyp/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tardyp/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tardyp/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/tardyp/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tardyp/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/tardyp/buildbot/languages","stargazers_url":"https://api.github.com/repos/tardyp/buildbot/stargazers","contributors_url":"https://api.github.com/repos/tardyp/buildbot/contributors","subscribers_url":"https://api.github.com/repos/tardyp/buildbot/subscribers","subscription_url":"https://api.github.com/repos/tardyp/buildbot/subscription","commits_url":"https://api.github.com/repos/tardyp/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/tardyp/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/tardyp/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/tardyp/buildbot/issues/comments/{number}","contents_url":"https://api.github.com/repos/tardyp/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/tardyp/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tardyp/buildbot/merges","archive_url":"https://api.github.com/repos/tardyp/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tardyp/buildbot/downloads","issues_url":"https://api.github.com/repos/tardyp/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/tardyp/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/tardyp/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/tardyp/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tardyp/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/tardyp/buildbot/releases{/id}","created_at":"2010-09-22T09:33:50Z","updated_at":"2014-06-24T21:37:41Z","pushed_at":"2014-12-29T22:00:42Z","git_url":"git://github.com/tardyp/buildbot.git","ssh_url":"git@github.com:tardyp/buildbot.git","clone_url":"https://github.com/tardyp/buildbot.git","svn_url":"https://github.com/tardyp/buildbot","homepage":"http://buildbot.net","size":34609,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"nine"}},"base":{"label":"buildbot:master","ref":"master","sha":"33ed29b8ea9e743b6e64eaf97ee97b8488eeb002","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/{number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","created_at":"2010-07-06T17:56:53Z","updated_at":"2014-12-30T06:55:55Z","pushed_at":"2014-12-30T06:55:54Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":46473,"stargazers_count":1287,"watchers_count":1287,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":630,"mirror_url":null,"open_issues_count":9,"forks":630,"open_issues":9,"watchers":1287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1471"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1471"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1471"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1471/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1471/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1471/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/9068ca8f5099a0dc66cb4361234c9a342a50d93d"}}}}