GitHub PullRequestEvent at 2014-07-03 13:00:27
Repository: mapbox-gl-style-spec
Actor: ansis
Payload: {"action":"closed","number":70,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls/70","id":17731823,"html_url":"https://github.com/mapbox/mapbox-gl-style-spec/pull/70","diff_url":"https://github.com/mapbox/mapbox-gl-style-spec/pull/70.diff","patch_url":"https://github.com/mapbox/mapbox-gl-style-spec/pull/70.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues/70","number":70,"state":"closed","title":"merge icon and text render types into symbol type","user":{"login":"ansis","id":1421652,"avatar_url":"https://avatars.githubusercontent.com/u/1421652?","gravatar_id":"62074048fbdb2f83c3b19d038f051e43","url":"https://api.github.com/users/ansis","html_url":"https://github.com/ansis","followers_url":"https://api.github.com/users/ansis/followers","following_url":"https://api.github.com/users/ansis/following{/other_user}","gists_url":"https://api.github.com/users/ansis/gists{/gist_id}","starred_url":"https://api.github.com/users/ansis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansis/subscriptions","organizations_url":"https://api.github.com/users/ansis/orgs","repos_url":"https://api.github.com/users/ansis/repos","events_url":"https://api.github.com/users/ansis/events{/privacy}","received_events_url":"https://api.github.com/users/ansis/received_events","type":"User","site_admin":false},"body":"Text and icon render types are merged into the symbol render type. With the types combined, we can place points + text together which means better placement and support for shields. #67.\r\n\r\nA layer with the symbol render type can specify both text and icon properties. Some properties, those prefixed with symbol-, affect both.\r\n\r\n- `symbol-placement` controls whether placement happens at a point or along a line\r\n- `symbol-min-distance` replaces `icon-spacing` and `text-min-distance`\r\n- `symbol-allow-overlap` and `symbol-ignore-placement` replace the text- and icon- versions\r\n- `text-upright` and `icon-upright` control whether the symbols can get flipped\r\n- `symbol-rotation-alignment` controls whether the symbol rotates with the map, replacing `text-path` and `icon-rotate-anchor`\r\n\r\nIf this looks ok I'll update the conversion script.\r\n\r\n@mourner @kkaefer @yhahn ","created_at":"2014-06-27T23:46:43Z","updated_at":"2014-07-03T13:00:27Z","closed_at":"2014-07-03T13:00:27Z","merged_at":null,"merge_commit_sha":"6e886a0623bbc2d370936005becccfcfd8b2b658","assignee":null,"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/milestones/1","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/milestones/1/labels","id":706845,"number":1,"title":"v3","description":"","creator":{"login":"mourner","id":25395,"avatar_url":"https://avatars.githubusercontent.com/u/25395?","gravatar_id":"6d07e6d95a43357254698ce9723350e6","url":"https://api.github.com/users/mourner","html_url":"https://github.com/mourner","followers_url":"https://api.github.com/users/mourner/followers","following_url":"https://api.github.com/users/mourner/following{/other_user}","gists_url":"https://api.github.com/users/mourner/gists{/gist_id}","starred_url":"https://api.github.com/users/mourner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourner/subscriptions","organizations_url":"https://api.github.com/users/mourner/orgs","repos_url":"https://api.github.com/users/mourner/repos","events_url":"https://api.github.com/users/mourner/events{/privacy}","received_events_url":"https://api.github.com/users/mourner/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":1,"state":"open","created_at":"2014-07-01T13:45:00Z","updated_at":"2014-07-03T13:00:27Z","due_on":null},"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls/70/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls/70/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues/70/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/statuses/094fc75361176ad5f765203afd06530760b5b43e","head":{"label":"mapbox:render-symbol","ref":"render-symbol","sha":"094fc75361176ad5f765203afd06530760b5b43e","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?","gravatar_id":"29f0667ed68eab9113d8e58f94c24a9e","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":18402447,"name":"mapbox-gl-style-spec","full_name":"mapbox/mapbox-gl-style-spec","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?","gravatar_id":"29f0667ed68eab9113d8e58f94c24a9e","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-style-spec","description":"Mapbox GL map style specification","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/releases{/id}","created_at":"2014-04-03T12:37:39Z","updated_at":"2014-06-25T13:23:45Z","pushed_at":"2014-07-03T12:59:45Z","git_url":"git://github.com/mapbox/mapbox-gl-style-spec.git","ssh_url":"git@github.com:mapbox/mapbox-gl-style-spec.git","clone_url":"https://github.com/mapbox/mapbox-gl-style-spec.git","svn_url":"https://github.com/mapbox/mapbox-gl-style-spec","homepage":"","size":2060,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":26,"forks":0,"open_issues":26,"watchers":10,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"941be9f59a666a9d2e894be5959e970f2caae7b8","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?","gravatar_id":"29f0667ed68eab9113d8e58f94c24a9e","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":18402447,"name":"mapbox-gl-style-spec","full_name":"mapbox/mapbox-gl-style-spec","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?","gravatar_id":"29f0667ed68eab9113d8e58f94c24a9e","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-style-spec","description":"Mapbox GL map style specification","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/releases{/id}","created_at":"2014-04-03T12:37:39Z","updated_at":"2014-06-25T13:23:45Z","pushed_at":"2014-07-03T12:59:45Z","git_url":"git://github.com/mapbox/mapbox-gl-style-spec.git","ssh_url":"git@github.com:mapbox/mapbox-gl-style-spec.git","clone_url":"https://github.com/mapbox/mapbox-gl-style-spec.git","svn_url":"https://github.com/mapbox/mapbox-gl-style-spec","homepage":"","size":2060,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":26,"forks":0,"open_issues":26,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls/70"},"html":{"href":"https://github.com/mapbox/mapbox-gl-style-spec/pull/70"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues/70"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-style-spec/statuses/094fc75361176ad5f765203afd06530760b5b43e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":15,"review_comments":0,"commits":12,"additions":108,"deletions":54,"changed_files":1}}