GitHub PullRequestReviewCommentEvent at 2014-06-11 04:37:18
Repository: gaia
Actor: gasolin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/13633545","id":13633545,"diff_hunk":"@@ -139,6 +139,15 @@ suite('system/AppWindowManager', function() {\n   }\n \n   suite('Handle events', function() {\n+    test('When permission dialog is closed, we need to focus the active app',\n+      function() {\n+        var stubFocus = this.sinon.stub(app1, 'broadcast');\n+        AppWindowManager._activeApp = app1;\n+        AppWindowManager.handleEvent({\n+          type: 'permissiondialoghide'\n+        });\n+        assert.isTrue(stubFocus.calledWith('focus'));\n+      });","path":"apps/system/test/unit/app_window_manager_test.js","position":12,"original_position":12,"commit_id":"7f8f4c8433c12d8e0cf727ffd8c28c5bdd1c91f4","original_commit_id":"7f8f4c8433c12d8e0cf727ffd8c28c5bdd1c91f4","user":{"login":"gasolin","id":748808,"avatar_url":"https://avatars.githubusercontent.com/u/748808?","gravatar_id":"84460b786102047f6b74522ef62d7ac3","url":"https://api.github.com/users/gasolin","html_url":"https://github.com/gasolin","followers_url":"https://api.github.com/users/gasolin/followers","following_url":"https://api.github.com/users/gasolin/following{/other_user}","gists_url":"https://api.github.com/users/gasolin/gists{/gist_id}","starred_url":"https://api.github.com/users/gasolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasolin/subscriptions","organizations_url":"https://api.github.com/users/gasolin/orgs","repos_url":"https://api.github.com/users/gasolin/repos","events_url":"https://api.github.com/users/gasolin/events{/privacy}","received_events_url":"https://api.github.com/users/gasolin/received_events","type":"User","site_admin":false},"body":"nit: add a bottom line between test cases","created_at":"2014-06-11T04:37:18Z","updated_at":"2014-06-11T04:37:18Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/20332#discussion_r13633545","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/20332","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/13633545"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/20332#discussion_r13633545"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/20332"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/20332","id":16978836,"html_url":"https://github.com/mozilla-b2g/gaia/pull/20332","diff_url":"https://github.com/mozilla-b2g/gaia/pull/20332.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/20332.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/20332","number":20332,"state":"open","title":"Bug 1021270 - Focus the top active window while permission dialog hide","user":{"login":"alivedise","id":546519,"avatar_url":"https://avatars.githubusercontent.com/u/546519?","gravatar_id":"2200ce74246a04126cf04cfa39ff0c37","url":"https://api.github.com/users/alivedise","html_url":"https://github.com/alivedise","followers_url":"https://api.github.com/users/alivedise/followers","following_url":"https://api.github.com/users/alivedise/following{/other_user}","gists_url":"https://api.github.com/users/alivedise/gists{/gist_id}","starred_url":"https://api.github.com/users/alivedise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivedise/subscriptions","organizations_url":"https://api.github.com/users/alivedise/orgs","repos_url":"https://api.github.com/users/alivedise/repos","events_url":"https://api.github.com/users/alivedise/events{/privacy}","received_events_url":"https://api.github.com/users/alivedise/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-11T04:17:59Z","updated_at":"2014-06-11T04:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef10632c795cc42fdb2ab4a62b4b40c472c0d54f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/20332/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/20332/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/20332/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/7f8f4c8433c12d8e0cf727ffd8c28c5bdd1c91f4","head":{"label":"alivedise:bugzilla/1021270/smart-collection","ref":"bugzilla/1021270/smart-collection","sha":"7f8f4c8433c12d8e0cf727ffd8c28c5bdd1c91f4","user":{"login":"alivedise","id":546519,"avatar_url":"https://avatars.githubusercontent.com/u/546519?","gravatar_id":"2200ce74246a04126cf04cfa39ff0c37","url":"https://api.github.com/users/alivedise","html_url":"https://github.com/alivedise","followers_url":"https://api.github.com/users/alivedise/followers","following_url":"https://api.github.com/users/alivedise/following{/other_user}","gists_url":"https://api.github.com/users/alivedise/gists{/gist_id}","starred_url":"https://api.github.com/users/alivedise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivedise/subscriptions","organizations_url":"https://api.github.com/users/alivedise/orgs","repos_url":"https://api.github.com/users/alivedise/repos","events_url":"https://api.github.com/users/alivedise/events{/privacy}","received_events_url":"https://api.github.com/users/alivedise/received_events","type":"User","site_admin":false},"repo":{"id":4659245,"name":"gaia","full_name":"alivedise/gaia","owner":{"login":"alivedise","id":546519,"avatar_url":"https://avatars.githubusercontent.com/u/546519?","gravatar_id":"2200ce74246a04126cf04cfa39ff0c37","url":"https://api.github.com/users/alivedise","html_url":"https://github.com/alivedise","followers_url":"https://api.github.com/users/alivedise/followers","following_url":"https://api.github.com/users/alivedise/following{/other_user}","gists_url":"https://api.github.com/users/alivedise/gists{/gist_id}","starred_url":"https://api.github.com/users/alivedise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivedise/subscriptions","organizations_url":"https://api.github.com/users/alivedise/orgs","repos_url":"https://api.github.com/users/alivedise/repos","events_url":"https://api.github.com/users/alivedise/events{/privacy}","received_events_url":"https://api.github.com/users/alivedise/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alivedise/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/alivedise/gaia","forks_url":"https://api.github.com/repos/alivedise/gaia/forks","keys_url":"https://api.github.com/repos/alivedise/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alivedise/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alivedise/gaia/teams","hooks_url":"https://api.github.com/repos/alivedise/gaia/hooks","issue_events_url":"https://api.github.com/repos/alivedise/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/alivedise/gaia/events","assignees_url":"https://api.github.com/repos/alivedise/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/alivedise/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/alivedise/gaia/tags","blobs_url":"https://api.github.com/repos/alivedise/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alivedise/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alivedise/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/alivedise/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alivedise/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/alivedise/gaia/languages","stargazers_url":"https://api.github.com/repos/alivedise/gaia/stargazers","contributors_url":"https://api.github.com/repos/alivedise/gaia/contributors","subscribers_url":"https://api.github.com/repos/alivedise/gaia/subscribers","subscription_url":"https://api.github.com/repos/alivedise/gaia/subscription","commits_url":"https://api.github.com/repos/alivedise/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/alivedise/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/alivedise/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/alivedise/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/alivedise/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/alivedise/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alivedise/gaia/merges","archive_url":"https://api.github.com/repos/alivedise/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alivedise/gaia/downloads","issues_url":"https://api.github.com/repos/alivedise/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/alivedise/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/alivedise/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/alivedise/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alivedise/gaia/labels{/name}","releases_url":"https://api.github.com/repos/alivedise/gaia/releases{/id}","created_at":"2012-06-14T04:21:54Z","updated_at":"2014-06-11T04:17:59Z","pushed_at":"2014-06-11T04:17:42Z","git_url":"git://github.com/alivedise/gaia.git","ssh_url":"git@github.com:alivedise/gaia.git","clone_url":"https://github.com/alivedise/gaia.git","svn_url":"https://github.com/alivedise/gaia","homepage":"https://wiki.mozilla.org/B2G","size":797277,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"bfc48b690164b89dededb8ccf74f4a4f3ae02977","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-06-11T04:24:46Z","pushed_at":"2014-06-11T04:24:45Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1193746,"stargazers_count":1623,"watchers_count":1623,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1598,"mirror_url":null,"open_issues_count":1592,"forks":1598,"open_issues":1592,"watchers":1623,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/20332"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/20332"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/20332"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/20332/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/20332/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/20332/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/7f8f4c8433c12d8e0cf727ffd8c28c5bdd1c91f4"}}}}