GitHub PullRequestEvent at 2014-01-10 16:02:46
Repository: asset-pipeline
Actor: kdocki
Payload: {"action":"closed","number":93,"pull_request":{"url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/pulls/93","id":11131021,"html_url":"https://github.com/CodeSleeve/asset-pipeline/pull/93","diff_url":"https://github.com/CodeSleeve/asset-pipeline/pull/93.diff","patch_url":"https://github.com/CodeSleeve/asset-pipeline/pull/93.patch","issue_url":"https://github.com/CodeSleeve/asset-pipeline/pull/93","number":93,"state":"closed","title":"URLRewrite doesn't rewrite assets in the same directory","user":{"login":"davejamesmiller","id":236616,"avatar_url":"https://gravatar.com/avatar/602e61997bb45d5854b6f955b87329b4?d=https%3A%2F%2Fidenticons.github.com%2F13ee5c5c623ee4266b867d7ef53969c5.png&r=x","gravatar_id":"602e61997bb45d5854b6f955b87329b4","url":"https://api.github.com/users/davejamesmiller","html_url":"https://github.com/davejamesmiller","followers_url":"https://api.github.com/users/davejamesmiller/followers","following_url":"https://api.github.com/users/davejamesmiller/following{/other_user}","gists_url":"https://api.github.com/users/davejamesmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/davejamesmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davejamesmiller/subscriptions","organizations_url":"https://api.github.com/users/davejamesmiller/orgs","repos_url":"https://api.github.com/users/davejamesmiller/repos","events_url":"https://api.github.com/users/davejamesmiller/events{/privacy}","received_events_url":"https://api.github.com/users/davejamesmiller/received_events","type":"User","site_admin":false},"body":"The sprite URL in the Chosen library was not being rewritten, for example:\r\n\r\n```css\r\nbackground: url('chosen-sprite.png') -42px 1px no-repeat;\r\n```\r\n\r\nLooks like it's because of this line in the URLRewrite filter:\r\n\r\n```php\r\nif (strpos($url, '/') != 0 && $this->fileExists($this->root . $url)) {\r\n```\r\n\r\n`strpos()` returns `false` in this case, so the whole if condition fails.\r\n\r\nI think it was supposed to ignore URLs that start with a `/`, so I've changed it to just check the first character instead of searching the whole string.\r\n\r\n(I also removed some unused variables - looks like they were copied from `relative_match()` further up.)","created_at":"2013-12-29T16:36:40Z","updated_at":"2014-01-10T16:02:45Z","closed_at":"2014-01-10T16:02:45Z","merged_at":"2014-01-10T16:02:45Z","merge_commit_sha":"c51e0babee2962f6c181aa68f89871a9001b9633","assignee":null,"milestone":null,"commits_url":"https://github.com/CodeSleeve/asset-pipeline/pull/93/commits","review_comments_url":"https://github.com/CodeSleeve/asset-pipeline/pull/93/comments","review_comment_url":"/repos/CodeSleeve/asset-pipeline/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/issues/93/comments","statuses_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/statuses/4bb9984cb77e6b15d994ccad8a006ad8fe61b2eb","head":{"label":"davejamesmiller:urlrewrite-fix","ref":"urlrewrite-fix","sha":"4bb9984cb77e6b15d994ccad8a006ad8fe61b2eb","user":{"login":"davejamesmiller","id":236616,"avatar_url":"https://gravatar.com/avatar/602e61997bb45d5854b6f955b87329b4?d=https%3A%2F%2Fidenticons.github.com%2F13ee5c5c623ee4266b867d7ef53969c5.png&r=x","gravatar_id":"602e61997bb45d5854b6f955b87329b4","url":"https://api.github.com/users/davejamesmiller","html_url":"https://github.com/davejamesmiller","followers_url":"https://api.github.com/users/davejamesmiller/followers","following_url":"https://api.github.com/users/davejamesmiller/following{/other_user}","gists_url":"https://api.github.com/users/davejamesmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/davejamesmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davejamesmiller/subscriptions","organizations_url":"https://api.github.com/users/davejamesmiller/orgs","repos_url":"https://api.github.com/users/davejamesmiller/repos","events_url":"https://api.github.com/users/davejamesmiller/events{/privacy}","received_events_url":"https://api.github.com/users/davejamesmiller/received_events","type":"User","site_admin":false},"repo":{"id":15511011,"name":"asset-pipeline","full_name":"davejamesmiller/asset-pipeline","owner":{"login":"davejamesmiller","id":236616,"avatar_url":"https://gravatar.com/avatar/602e61997bb45d5854b6f955b87329b4?d=https%3A%2F%2Fidenticons.github.com%2F13ee5c5c623ee4266b867d7ef53969c5.png&r=x","gravatar_id":"602e61997bb45d5854b6f955b87329b4","url":"https://api.github.com/users/davejamesmiller","html_url":"https://github.com/davejamesmiller","followers_url":"https://api.github.com/users/davejamesmiller/followers","following_url":"https://api.github.com/users/davejamesmiller/following{/other_user}","gists_url":"https://api.github.com/users/davejamesmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/davejamesmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davejamesmiller/subscriptions","organizations_url":"https://api.github.com/users/davejamesmiller/orgs","repos_url":"https://api.github.com/users/davejamesmiller/repos","events_url":"https://api.github.com/users/davejamesmiller/events{/privacy}","received_events_url":"https://api.github.com/users/davejamesmiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davejamesmiller/asset-pipeline","description":"This Laravel 4 package provides a very simple and easy to use asset pipeline. It was heavily inspired by the Rails asset pipeline. We make use of the wonderful Assetic package to help with pre-compliation!","fork":true,"url":"https://api.github.com/repos/davejamesmiller/asset-pipeline","forks_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/forks","keys_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/teams","hooks_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/hooks","issue_events_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/events","assignees_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/tags","blobs_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/languages","stargazers_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/stargazers","contributors_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/contributors","subscribers_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/subscribers","subscription_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/subscription","commits_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/issues/comments/{number}","contents_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/merges","archive_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/downloads","issues_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/davejamesmiller/asset-pipeline/releases{/id}","created_at":"2013-12-29T16:12:02Z","updated_at":"2014-01-10T16:02:45Z","pushed_at":"2013-12-29T16:29:47Z","git_url":"git://github.com/davejamesmiller/asset-pipeline.git","ssh_url":"git@github.com:davejamesmiller/asset-pipeline.git","clone_url":"https://github.com/davejamesmiller/asset-pipeline.git","svn_url":"https://github.com/davejamesmiller/asset-pipeline","homepage":"http://www.codesleeve.com","size":1056,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"CodeSleeve:master","ref":"master","sha":"179594c346cf4169730e41006a13ffa18cabd0de","user":{"login":"CodeSleeve","id":4665042,"avatar_url":"https://gravatar.com/avatar/1c3062b4f01769632d5abcde844e0621?d=https%3A%2F%2Fidenticons.github.com%2F44696a0724f107bc8bf04ff5efc7c9f0.png&r=x","gravatar_id":"1c3062b4f01769632d5abcde844e0621","url":"https://api.github.com/users/CodeSleeve","html_url":"https://github.com/CodeSleeve","followers_url":"https://api.github.com/users/CodeSleeve/followers","following_url":"https://api.github.com/users/CodeSleeve/following{/other_user}","gists_url":"https://api.github.com/users/CodeSleeve/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeSleeve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeSleeve/subscriptions","organizations_url":"https://api.github.com/users/CodeSleeve/orgs","repos_url":"https://api.github.com/users/CodeSleeve/repos","events_url":"https://api.github.com/users/CodeSleeve/events{/privacy}","received_events_url":"https://api.github.com/users/CodeSleeve/received_events","type":"Organization","site_admin":false},"repo":{"id":10659803,"name":"asset-pipeline","full_name":"CodeSleeve/asset-pipeline","owner":{"login":"CodeSleeve","id":4665042,"avatar_url":"https://gravatar.com/avatar/1c3062b4f01769632d5abcde844e0621?d=https%3A%2F%2Fidenticons.github.com%2F44696a0724f107bc8bf04ff5efc7c9f0.png&r=x","gravatar_id":"1c3062b4f01769632d5abcde844e0621","url":"https://api.github.com/users/CodeSleeve","html_url":"https://github.com/CodeSleeve","followers_url":"https://api.github.com/users/CodeSleeve/followers","following_url":"https://api.github.com/users/CodeSleeve/following{/other_user}","gists_url":"https://api.github.com/users/CodeSleeve/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeSleeve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeSleeve/subscriptions","organizations_url":"https://api.github.com/users/CodeSleeve/orgs","repos_url":"https://api.github.com/users/CodeSleeve/repos","events_url":"https://api.github.com/users/CodeSleeve/events{/privacy}","received_events_url":"https://api.github.com/users/CodeSleeve/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeSleeve/asset-pipeline","description":"This Laravel 4 package provides a very simple and easy to use asset pipeline. It was heavily inspired by the Rails asset pipeline. We make use of the wonderful Assetic package to help with pre-compliation!","fork":false,"url":"https://api.github.com/repos/CodeSleeve/asset-pipeline","forks_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/forks","keys_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/teams","hooks_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/hooks","issue_events_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/events","assignees_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/tags","blobs_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/languages","stargazers_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/stargazers","contributors_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/contributors","subscribers_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/subscribers","subscription_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/subscription","commits_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/issues/comments/{number}","contents_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/merges","archive_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/downloads","issues_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/CodeSleeve/asset-pipeline/releases{/id}","created_at":"2013-06-13T05:57:32Z","updated_at":"2014-01-10T16:02:45Z","pushed_at":"2014-01-10T16:02:45Z","git_url":"git://github.com/CodeSleeve/asset-pipeline.git","ssh_url":"git@github.com:CodeSleeve/asset-pipeline.git","clone_url":"https://github.com/CodeSleeve/asset-pipeline.git","svn_url":"https://github.com/CodeSleeve/asset-pipeline","homepage":"http://www.codesleeve.com","size":1686,"stargazers_count":212,"watchers_count":212,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":17,"mirror_url":null,"open_issues_count":7,"forks":17,"open_issues":7,"watchers":212,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeSleeve/asset-pipeline/pulls/93"},"html":{"href":"https://github.com/CodeSleeve/asset-pipeline/pull/93"},"issue":{"href":"https://api.github.com/repos/CodeSleeve/asset-pipeline/issues/93"},"comments":{"href":"https://api.github.com/repos/CodeSleeve/asset-pipeline/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeSleeve/asset-pipeline/pulls/93/comments"},"statuses":{"href":"https://api.github.com/repos/CodeSleeve/asset-pipeline/statuses/4bb9984cb77e6b15d994ccad8a006ad8fe61b2eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kdocki","id":772706,"avatar_url":"https://gravatar.com/avatar/771c5ddcc12ab746ea103e822405e377?d=https%3A%2F%2Fidenticons.github.com%2F7b868cd3cbccb473d6afd09b24d7086d.png&r=x","gravatar_id":"771c5ddcc12ab746ea103e822405e377","url":"https://api.github.com/users/kdocki","html_url":"https://github.com/kdocki","followers_url":"https://api.github.com/users/kdocki/followers","following_url":"https://api.github.com/users/kdocki/following{/other_user}","gists_url":"https://api.github.com/users/kdocki/gists{/gist_id}","starred_url":"https://api.github.com/users/kdocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdocki/subscriptions","organizations_url":"https://api.github.com/users/kdocki/orgs","repos_url":"https://api.github.com/users/kdocki/repos","events_url":"https://api.github.com/users/kdocki/events{/privacy}","received_events_url":"https://api.github.com/users/kdocki/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":2,"deletions":6,"changed_files":1}}