GitHub PullRequestReviewCommentEvent at 2014-09-30 17:24:31
Repository: thunder
Actor: freeman-lab
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/freeman-lab/thunder/pulls/comments/18232511","id":18232511,"diff_hunk":"@@ -240,18 +263,27 @@ def __loadParametersAndDefaults(datafile, conffilename, nkeys, nvalues, keytype,\n \n         Priority order is as follows:\n         1. parameters specified as keyword arguments;\n-        2. parameters specified in a conf.json file;\n+        2. parameters specified in a conf.json file on the local filesystem;","path":"python/thunder/rdds/series.py","position":71,"original_position":71,"commit_id":"c2396261506a7a1e20ab15e8a97fc75661ad3a8d","original_commit_id":"c2396261506a7a1e20ab15e8a97fc75661ad3a8d","user":{"login":"freeman-lab","id":3387500,"avatar_url":"https://avatars.githubusercontent.com/u/3387500?v=2","gravatar_id":"","url":"https://api.github.com/users/freeman-lab","html_url":"https://github.com/freeman-lab","followers_url":"https://api.github.com/users/freeman-lab/followers","following_url":"https://api.github.com/users/freeman-lab/following{/other_user}","gists_url":"https://api.github.com/users/freeman-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/freeman-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeman-lab/subscriptions","organizations_url":"https://api.github.com/users/freeman-lab/orgs","repos_url":"https://api.github.com/users/freeman-lab/repos","events_url":"https://api.github.com/users/freeman-lab/events{/privacy}","received_events_url":"https://api.github.com/users/freeman-lab/received_events","type":"User","site_admin":false},"body":"We also want to handle conf files on S3, one simple option would be to use sc.textFile to load the contents of the conf file, which will work regardless of origin. That's how we load a json parameter file in ``context.loadExampleEC2``:\r\n\r\n    paramfile = sc.textFile(\"s3n://\" + path + \"params.json\")\r\n    params = json.loads(paramfile.first())\r\n","created_at":"2014-09-30T17:24:31Z","updated_at":"2014-09-30T17:24:31Z","html_url":"https://github.com/freeman-lab/thunder/pull/30#discussion_r18232511","pull_request_url":"https://api.github.com/repos/freeman-lab/thunder/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/comments/18232511"},"html":{"href":"https://github.com/freeman-lab/thunder/pull/30#discussion_r18232511"},"pull_request":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/freeman-lab/thunder/pulls/30","id":21971619,"html_url":"https://github.com/freeman-lab/thunder/pull/30","diff_url":"https://github.com/freeman-lab/thunder/pull/30.diff","patch_url":"https://github.com/freeman-lab/thunder/pull/30.patch","issue_url":"https://api.github.com/repos/freeman-lab/thunder/issues/30","number":30,"state":"open","locked":false,"title":"Custom rdds: s3 reader","user":{"login":"industrial-sloth","id":8592708,"avatar_url":"https://avatars.githubusercontent.com/u/8592708?v=2","gravatar_id":"","url":"https://api.github.com/users/industrial-sloth","html_url":"https://github.com/industrial-sloth","followers_url":"https://api.github.com/users/industrial-sloth/followers","following_url":"https://api.github.com/users/industrial-sloth/following{/other_user}","gists_url":"https://api.github.com/users/industrial-sloth/gists{/gist_id}","starred_url":"https://api.github.com/users/industrial-sloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/industrial-sloth/subscriptions","organizations_url":"https://api.github.com/users/industrial-sloth/orgs","repos_url":"https://api.github.com/users/industrial-sloth/repos","events_url":"https://api.github.com/users/industrial-sloth/events{/privacy}","received_events_url":"https://api.github.com/users/industrial-sloth/received_events","type":"User","site_admin":false},"body":"Moving towards a unified i/o architecture. This PR adds a \"readers\" module, which currently provides an abstraction layer over access to the local filesystem and to s3 via boto. \r\n\r\nOther changes:\r\n* disable a failing test in test_series - not immediately clear what the cause is, but should get fixed\r\n* expose a couple options from the spark ec2 script in the thunder ec2 script\r\n* start moving towards more standardized handling of data paths in the series module\r\n* add subsample and exportAsPngs methods in Images","created_at":"2014-09-29T23:09:39Z","updated_at":"2014-09-30T17:24:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9661b76e80a3dd3219c18781de2dac791325251e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/freeman-lab/thunder/pulls/30/commits","review_comments_url":"https://api.github.com/repos/freeman-lab/thunder/pulls/30/comments","review_comment_url":"https://api.github.com/repos/freeman-lab/thunder/pulls/comments/{number}","comments_url":"https://api.github.com/repos/freeman-lab/thunder/issues/30/comments","statuses_url":"https://api.github.com/repos/freeman-lab/thunder/statuses/c2396261506a7a1e20ab15e8a97fc75661ad3a8d","head":{"label":"industrial-sloth:custom-rdds","ref":"custom-rdds","sha":"c2396261506a7a1e20ab15e8a97fc75661ad3a8d","user":{"login":"industrial-sloth","id":8592708,"avatar_url":"https://avatars.githubusercontent.com/u/8592708?v=2","gravatar_id":"","url":"https://api.github.com/users/industrial-sloth","html_url":"https://github.com/industrial-sloth","followers_url":"https://api.github.com/users/industrial-sloth/followers","following_url":"https://api.github.com/users/industrial-sloth/following{/other_user}","gists_url":"https://api.github.com/users/industrial-sloth/gists{/gist_id}","starred_url":"https://api.github.com/users/industrial-sloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/industrial-sloth/subscriptions","organizations_url":"https://api.github.com/users/industrial-sloth/orgs","repos_url":"https://api.github.com/users/industrial-sloth/repos","events_url":"https://api.github.com/users/industrial-sloth/events{/privacy}","received_events_url":"https://api.github.com/users/industrial-sloth/received_events","type":"User","site_admin":false},"repo":{"id":23590305,"name":"thunder","full_name":"industrial-sloth/thunder","owner":{"login":"industrial-sloth","id":8592708,"avatar_url":"https://avatars.githubusercontent.com/u/8592708?v=2","gravatar_id":"","url":"https://api.github.com/users/industrial-sloth","html_url":"https://github.com/industrial-sloth","followers_url":"https://api.github.com/users/industrial-sloth/followers","following_url":"https://api.github.com/users/industrial-sloth/following{/other_user}","gists_url":"https://api.github.com/users/industrial-sloth/gists{/gist_id}","starred_url":"https://api.github.com/users/industrial-sloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/industrial-sloth/subscriptions","organizations_url":"https://api.github.com/users/industrial-sloth/orgs","repos_url":"https://api.github.com/users/industrial-sloth/repos","events_url":"https://api.github.com/users/industrial-sloth/events{/privacy}","received_events_url":"https://api.github.com/users/industrial-sloth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/industrial-sloth/thunder","description":"Large-scale neural data analysis with Spark","fork":true,"url":"https://api.github.com/repos/industrial-sloth/thunder","forks_url":"https://api.github.com/repos/industrial-sloth/thunder/forks","keys_url":"https://api.github.com/repos/industrial-sloth/thunder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/industrial-sloth/thunder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/industrial-sloth/thunder/teams","hooks_url":"https://api.github.com/repos/industrial-sloth/thunder/hooks","issue_events_url":"https://api.github.com/repos/industrial-sloth/thunder/issues/events{/number}","events_url":"https://api.github.com/repos/industrial-sloth/thunder/events","assignees_url":"https://api.github.com/repos/industrial-sloth/thunder/assignees{/user}","branches_url":"https://api.github.com/repos/industrial-sloth/thunder/branches{/branch}","tags_url":"https://api.github.com/repos/industrial-sloth/thunder/tags","blobs_url":"https://api.github.com/repos/industrial-sloth/thunder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/industrial-sloth/thunder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/industrial-sloth/thunder/git/refs{/sha}","trees_url":"https://api.github.com/repos/industrial-sloth/thunder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/industrial-sloth/thunder/statuses/{sha}","languages_url":"https://api.github.com/repos/industrial-sloth/thunder/languages","stargazers_url":"https://api.github.com/repos/industrial-sloth/thunder/stargazers","contributors_url":"https://api.github.com/repos/industrial-sloth/thunder/contributors","subscribers_url":"https://api.github.com/repos/industrial-sloth/thunder/subscribers","subscription_url":"https://api.github.com/repos/industrial-sloth/thunder/subscription","commits_url":"https://api.github.com/repos/industrial-sloth/thunder/commits{/sha}","git_commits_url":"https://api.github.com/repos/industrial-sloth/thunder/git/commits{/sha}","comments_url":"https://api.github.com/repos/industrial-sloth/thunder/comments{/number}","issue_comment_url":"https://api.github.com/repos/industrial-sloth/thunder/issues/comments/{number}","contents_url":"https://api.github.com/repos/industrial-sloth/thunder/contents/{+path}","compare_url":"https://api.github.com/repos/industrial-sloth/thunder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/industrial-sloth/thunder/merges","archive_url":"https://api.github.com/repos/industrial-sloth/thunder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/industrial-sloth/thunder/downloads","issues_url":"https://api.github.com/repos/industrial-sloth/thunder/issues{/number}","pulls_url":"https://api.github.com/repos/industrial-sloth/thunder/pulls{/number}","milestones_url":"https://api.github.com/repos/industrial-sloth/thunder/milestones{/number}","notifications_url":"https://api.github.com/repos/industrial-sloth/thunder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/industrial-sloth/thunder/labels{/name}","releases_url":"https://api.github.com/repos/industrial-sloth/thunder/releases{/id}","created_at":"2014-09-02T18:23:57Z","updated_at":"2014-09-05T13:32:06Z","pushed_at":"2014-09-30T16:56:45Z","git_url":"git://github.com/industrial-sloth/thunder.git","ssh_url":"git@github.com:industrial-sloth/thunder.git","clone_url":"https://github.com/industrial-sloth/thunder.git","svn_url":"https://github.com/industrial-sloth/thunder","homepage":"","size":15952,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeman-lab:custom-rdds","ref":"custom-rdds","sha":"d5f4ca4857e2f7ade6abd0a519ac81276cf8f6da","user":{"login":"freeman-lab","id":3387500,"avatar_url":"https://avatars.githubusercontent.com/u/3387500?v=2","gravatar_id":"","url":"https://api.github.com/users/freeman-lab","html_url":"https://github.com/freeman-lab","followers_url":"https://api.github.com/users/freeman-lab/followers","following_url":"https://api.github.com/users/freeman-lab/following{/other_user}","gists_url":"https://api.github.com/users/freeman-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/freeman-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeman-lab/subscriptions","organizations_url":"https://api.github.com/users/freeman-lab/orgs","repos_url":"https://api.github.com/users/freeman-lab/repos","events_url":"https://api.github.com/users/freeman-lab/events{/privacy}","received_events_url":"https://api.github.com/users/freeman-lab/received_events","type":"User","site_admin":false},"repo":{"id":10616272,"name":"thunder","full_name":"freeman-lab/thunder","owner":{"login":"freeman-lab","id":3387500,"avatar_url":"https://avatars.githubusercontent.com/u/3387500?v=2","gravatar_id":"","url":"https://api.github.com/users/freeman-lab","html_url":"https://github.com/freeman-lab","followers_url":"https://api.github.com/users/freeman-lab/followers","following_url":"https://api.github.com/users/freeman-lab/following{/other_user}","gists_url":"https://api.github.com/users/freeman-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/freeman-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeman-lab/subscriptions","organizations_url":"https://api.github.com/users/freeman-lab/orgs","repos_url":"https://api.github.com/users/freeman-lab/repos","events_url":"https://api.github.com/users/freeman-lab/events{/privacy}","received_events_url":"https://api.github.com/users/freeman-lab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freeman-lab/thunder","description":"Large-scale neural data analysis with Spark","fork":false,"url":"https://api.github.com/repos/freeman-lab/thunder","forks_url":"https://api.github.com/repos/freeman-lab/thunder/forks","keys_url":"https://api.github.com/repos/freeman-lab/thunder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeman-lab/thunder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeman-lab/thunder/teams","hooks_url":"https://api.github.com/repos/freeman-lab/thunder/hooks","issue_events_url":"https://api.github.com/repos/freeman-lab/thunder/issues/events{/number}","events_url":"https://api.github.com/repos/freeman-lab/thunder/events","assignees_url":"https://api.github.com/repos/freeman-lab/thunder/assignees{/user}","branches_url":"https://api.github.com/repos/freeman-lab/thunder/branches{/branch}","tags_url":"https://api.github.com/repos/freeman-lab/thunder/tags","blobs_url":"https://api.github.com/repos/freeman-lab/thunder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeman-lab/thunder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeman-lab/thunder/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeman-lab/thunder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeman-lab/thunder/statuses/{sha}","languages_url":"https://api.github.com/repos/freeman-lab/thunder/languages","stargazers_url":"https://api.github.com/repos/freeman-lab/thunder/stargazers","contributors_url":"https://api.github.com/repos/freeman-lab/thunder/contributors","subscribers_url":"https://api.github.com/repos/freeman-lab/thunder/subscribers","subscription_url":"https://api.github.com/repos/freeman-lab/thunder/subscription","commits_url":"https://api.github.com/repos/freeman-lab/thunder/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeman-lab/thunder/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeman-lab/thunder/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeman-lab/thunder/issues/comments/{number}","contents_url":"https://api.github.com/repos/freeman-lab/thunder/contents/{+path}","compare_url":"https://api.github.com/repos/freeman-lab/thunder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeman-lab/thunder/merges","archive_url":"https://api.github.com/repos/freeman-lab/thunder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeman-lab/thunder/downloads","issues_url":"https://api.github.com/repos/freeman-lab/thunder/issues{/number}","pulls_url":"https://api.github.com/repos/freeman-lab/thunder/pulls{/number}","milestones_url":"https://api.github.com/repos/freeman-lab/thunder/milestones{/number}","notifications_url":"https://api.github.com/repos/freeman-lab/thunder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeman-lab/thunder/labels{/name}","releases_url":"https://api.github.com/repos/freeman-lab/thunder/releases{/id}","created_at":"2013-06-11T07:00:47Z","updated_at":"2014-09-26T00:32:12Z","pushed_at":"2014-09-26T16:37:10Z","git_url":"git://github.com/freeman-lab/thunder.git","ssh_url":"git@github.com:freeman-lab/thunder.git","clone_url":"https://github.com/freeman-lab/thunder.git","svn_url":"https://github.com/freeman-lab/thunder","homepage":"","size":22401,"stargazers_count":188,"watchers_count":188,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":3,"forks":41,"open_issues":3,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/30"},"html":{"href":"https://github.com/freeman-lab/thunder/pull/30"},"issue":{"href":"https://api.github.com/repos/freeman-lab/thunder/issues/30"},"comments":{"href":"https://api.github.com/repos/freeman-lab/thunder/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/freeman-lab/thunder/statuses/c2396261506a7a1e20ab15e8a97fc75661ad3a8d"}}}}