GitHub PullRequestReviewCommentEvent at 2014-05-09 12:15:12
Repository: sconsProject
Actor: fabiencastan
Payload: {"comment":{"url":"https://api.github.com/repos/tuttleofx/sconsProject/pulls/comments/12472829","id":12472829,"diff_hunk":"@@ -270,6 +293,10 @@ def generate(env):\n \t\tQT_MOCCXXPREFIX = '',\n \t\tQT_MOCCXXSUFFIX = '.moc',\n \t\tQT_UISUFFIX = '.ui',\n+                QT4_LUPDATE = os.path.join('$QT_BINPATH','lupdate'),","path":"tools/qt.py","position":78,"original_position":78,"commit_id":"e1e0713c1eda0f5e5b3e731d084d247177f41b9a","original_commit_id":"e1e0713c1eda0f5e5b3e731d084d247177f41b9a","user":{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?","gravatar_id":"cd70a4662e438a715e32a155df3f4f2c","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"body":"This file is common for Qt4 and Qt5.\r\nSo the name should be QT_LUPDATE instead of QT4_LUPDATE, no?","created_at":"2014-05-09T12:15:12Z","updated_at":"2014-05-09T12:15:12Z","html_url":"https://github.com/tuttleofx/sconsProject/pull/5#discussion_r12472829","pull_request_url":"https://api.github.com/repos/tuttleofx/sconsProject/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/tuttleofx/sconsProject/pulls/comments/12472829"},"html":{"href":"https://github.com/tuttleofx/sconsProject/pull/5#discussion_r12472829"},"pull_request":{"href":"https://api.github.com/repos/tuttleofx/sconsProject/pulls/5"}}}}