GitHub PullRequestReviewCommentEvent at 2014-12-05 16:00:28
Repository: fcrepo4-oaiprovider
Actor: awoods
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/comments/21379862","id":21379862,"diff_hunk":"@@ -274,18 +340,37 @@ public OAIProviderService() throws DatatypeConfigurationException, JAXBException\n      */\n     public JAXBElement<OAIPMHtype> identify(final Session session, final UriInfo uriInfo) throws RepositoryException,\n             JAXBException {\n+        final HttpResourceConverter converter = new HttpResourceConverter(session, uriInfo.getBaseUriBuilder()\n+                .clone().path(FedoraNodes.class));\n \n-        final FedoraResource root = this.nodeService.find(session, \"/\");\n+        final FedoraResource root = this.nodeService.find(session, setsRootPath);\n \n-        final IdentifyType id = this.oaiFactory.createIdentifyType();\n+        final IdentifyType id = oaiFactory.createIdentifyType();\n         // TODO: Need real values here from the root node?\n         id.setBaseURL(uriInfo.getBaseUri().toASCIIString());\n-        id.setEarliestDatestamp(\"INSTALL_DATE\");\n-        id.setProtocolVersion(\"2.0\");\n-        id.setRepositoryName(\"Fedora 4\");\n-        id.getAdminEmail().add(0,\"admin@example.com\");\n-        final DescriptionType desc = this.oaiFactory.createDescriptionType();\n-        desc.setAny(new JAXBElement<String>(new QName(\"general\"), String.class, \"An example repository description\"));\n+\n+        id.setEarliestDatestamp(dateFormat.print(root.getCreatedDate().getTime()));\n+\n+        id.setProtocolVersion(System.getProperty(\"2.0\"));\n+\n+        // repository name, project version\n+        RdfStream triples = root.getTriples(converter, PropertiesRdfContext.class).filter(\n+                new PropertyPredicate(propertyOaiRepositoryName));\n+        id.setRepositoryName(triples.next().getObject().getLiteralValue().toString()\n+                + \", Version \" + System.getProperty(\"project.version\"));","path":"src/main/java/org/fcrepo/oai/service/OAIProviderService.java","position":132,"original_position":132,"commit_id":"0a85a721cd3ed3a1bb8d6908c1167da72b7d2f0e","original_commit_id":"0a85a721cd3ed3a1bb8d6908c1167da72b7d2f0e","user":{"login":"awoods","id":149283,"avatar_url":"https://avatars.githubusercontent.com/u/149283?v=3","gravatar_id":"","url":"https://api.github.com/users/awoods","html_url":"https://github.com/awoods","followers_url":"https://api.github.com/users/awoods/followers","following_url":"https://api.github.com/users/awoods/following{/other_user}","gists_url":"https://api.github.com/users/awoods/gists{/gist_id}","starred_url":"https://api.github.com/users/awoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awoods/subscriptions","organizations_url":"https://api.github.com/users/awoods/orgs","repos_url":"https://api.github.com/users/awoods/repos","events_url":"https://api.github.com/users/awoods/events{/privacy}","received_events_url":"https://api.github.com/users/awoods/received_events","type":"User","site_admin":false},"body":"The \"project.version\" is available at build-time in the maven environment. Ideally, you would be able to have the build resource filtering populate the \"project.version\" in the oai.xml file, instead of expecting a runtime System property.","created_at":"2014-12-05T16:00:28Z","updated_at":"2014-12-05T16:00:28Z","html_url":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider/pull/10#discussion_r21379862","pull_request_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/comments/21379862"},"html":{"href":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider/pull/10#discussion_r21379862"},"pull_request":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/10","id":25540047,"html_url":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider/pull/10","diff_url":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider/pull/10.diff","patch_url":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider/pull/10.patch","issue_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/issues/10","number":10,"state":"open","locked":false,"title":"Added support to allow admins to manage descriptive content about the repository and make the content available.","user":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars.githubusercontent.com/u/2430784?v=3","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"body":"https://jira.duraspace.org/browse/FCREPO-1238","created_at":"2014-12-05T00:09:57Z","updated_at":"2014-12-05T16:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f78f1800753cf5da1af01069c31b23d5c4fd6971","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/10/commits","review_comments_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/10/comments","review_comment_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/issues/10/comments","statuses_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/statuses/0a85a721cd3ed3a1bb8d6908c1167da72b7d2f0e","head":{"label":"lsitu:feature/descriptive-content","ref":"feature/descriptive-content","sha":"0a85a721cd3ed3a1bb8d6908c1167da72b7d2f0e","user":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars.githubusercontent.com/u/2430784?v=3","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"repo":{"id":26342090,"name":"fcrepo4-oaiprovider","full_name":"lsitu/fcrepo4-oaiprovider","owner":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars.githubusercontent.com/u/2430784?v=3","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lsitu/fcrepo4-oaiprovider","description":"Fedora 4 OAI Provider implementation","fork":true,"url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider","forks_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/forks","keys_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/teams","hooks_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/hooks","issue_events_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/issues/events{/number}","events_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/events","assignees_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/assignees{/user}","branches_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/branches{/branch}","tags_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/tags","blobs_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/statuses/{sha}","languages_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/languages","stargazers_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/stargazers","contributors_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/contributors","subscribers_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/subscribers","subscription_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/subscription","commits_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/issues/comments/{number}","contents_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/contents/{+path}","compare_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/merges","archive_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/downloads","issues_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/issues{/number}","pulls_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/pulls{/number}","milestones_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/milestones{/number}","notifications_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/labels{/name}","releases_url":"https://api.github.com/repos/lsitu/fcrepo4-oaiprovider/releases{/id}","created_at":"2014-11-07T23:00:15Z","updated_at":"2014-12-03T22:11:09Z","pushed_at":"2014-12-05T00:06:07Z","git_url":"git://github.com/lsitu/fcrepo4-oaiprovider.git","ssh_url":"git@github.com:lsitu/fcrepo4-oaiprovider.git","clone_url":"https://github.com/lsitu/fcrepo4-oaiprovider.git","svn_url":"https://github.com/lsitu/fcrepo4-oaiprovider","homepage":null,"size":214,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4-labs:master","ref":"master","sha":"efdd064fe8761bbd203122b9e9621132e4b2f394","user":{"login":"fcrepo4-labs","id":7586101,"avatar_url":"https://avatars.githubusercontent.com/u/7586101?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4-labs","html_url":"https://github.com/fcrepo4-labs","followers_url":"https://api.github.com/users/fcrepo4-labs/followers","following_url":"https://api.github.com/users/fcrepo4-labs/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4-labs/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4-labs/orgs","repos_url":"https://api.github.com/users/fcrepo4-labs/repos","events_url":"https://api.github.com/users/fcrepo4-labs/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":25468429,"name":"fcrepo4-oaiprovider","full_name":"fcrepo4-labs/fcrepo4-oaiprovider","owner":{"login":"fcrepo4-labs","id":7586101,"avatar_url":"https://avatars.githubusercontent.com/u/7586101?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4-labs","html_url":"https://github.com/fcrepo4-labs","followers_url":"https://api.github.com/users/fcrepo4-labs/followers","following_url":"https://api.github.com/users/fcrepo4-labs/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4-labs/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4-labs/orgs","repos_url":"https://api.github.com/users/fcrepo4-labs/repos","events_url":"https://api.github.com/users/fcrepo4-labs/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider","description":"Fedora 4 OAI Provider implementation","fork":false,"url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider","forks_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/forks","keys_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/teams","hooks_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/events","assignees_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/tags","blobs_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/languages","stargazers_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/subscription","commits_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/issues/comments/{number}","contents_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/merges","archive_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/downloads","issues_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/releases{/id}","created_at":"2014-10-20T13:47:14Z","updated_at":"2014-12-03T20:56:31Z","pushed_at":"2014-12-03T20:56:31Z","git_url":"git://github.com/fcrepo4-labs/fcrepo4-oaiprovider.git","ssh_url":"git@github.com:fcrepo4-labs/fcrepo4-oaiprovider.git","clone_url":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider.git","svn_url":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider","homepage":null,"size":447,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/10"},"html":{"href":"https://github.com/fcrepo4-labs/fcrepo4-oaiprovider/pull/10"},"issue":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/issues/10"},"comments":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4-labs/fcrepo4-oaiprovider/statuses/0a85a721cd3ed3a1bb8d6908c1167da72b7d2f0e"}}}}