GitHub PullRequestReviewCommentEvent at 2014-11-19 10:10:36
Repository: shae
Actor: qingfeng
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/borngods/shae/pulls/comments/20566364","id":20566364,"diff_hunk":"@@ -72,6 +71,34 @@ def disappear_animations(self):\n         return enumerate(WIDGET_DISAPPEAR_ANIMATIONS)\n \n     @property\n+    def delay(self):\n+        return int(self.props.get('delay') or 0)\n+\n+    @property\n+    def disappear_delay(self):\n+        return int(self.props.get('disappear_delay') or 0)","path":"models/widget.py","position":42,"original_position":42,"commit_id":"413c77b701152bce0c02c9bc11ee932a3c277c1b","original_commit_id":"413c77b701152bce0c02c9bc11ee932a3c277c1b","user":{"login":"qingfeng","id":18495,"avatar_url":"https://avatars.githubusercontent.com/u/18495?v=3","gravatar_id":"","url":"https://api.github.com/users/qingfeng","html_url":"https://github.com/qingfeng","followers_url":"https://api.github.com/users/qingfeng/followers","following_url":"https://api.github.com/users/qingfeng/following{/other_user}","gists_url":"https://api.github.com/users/qingfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/qingfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qingfeng/subscriptions","organizations_url":"https://api.github.com/users/qingfeng/orgs","repos_url":"https://api.github.com/users/qingfeng/repos","events_url":"https://api.github.com/users/qingfeng/events{/privacy}","received_events_url":"https://api.github.com/users/qingfeng/received_events","type":"User","site_admin":false},"body":"这个props.get不能提供默认参返回吗？类似 `props.get('disappear_delay', 0)` 这样？","created_at":"2014-11-19T10:10:36Z","updated_at":"2014-11-19T10:10:36Z","html_url":"https://github.com/borngods/shae/pull/39#discussion_r20566364","pull_request_url":"https://api.github.com/repos/borngods/shae/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/borngods/shae/pulls/comments/20566364"},"html":{"href":"https://github.com/borngods/shae/pull/39#discussion_r20566364"},"pull_request":{"href":"https://api.github.com/repos/borngods/shae/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/borngods/shae/pulls/39","id":24664838,"html_url":"https://github.com/borngods/shae/pull/39","diff_url":"https://github.com/borngods/shae/pull/39.diff","patch_url":"https://github.com/borngods/shae/pull/39.patch","issue_url":"https://api.github.com/repos/borngods/shae/issues/39","number":39,"state":"closed","locked":false,"title":"增加自定义动画时长和时间曲线","user":{"login":"bingwen","id":1501364,"avatar_url":"https://avatars.githubusercontent.com/u/1501364?v=3","gravatar_id":"","url":"https://api.github.com/users/bingwen","html_url":"https://github.com/bingwen","followers_url":"https://api.github.com/users/bingwen/followers","following_url":"https://api.github.com/users/bingwen/following{/other_user}","gists_url":"https://api.github.com/users/bingwen/gists{/gist_id}","starred_url":"https://api.github.com/users/bingwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingwen/subscriptions","organizations_url":"https://api.github.com/users/bingwen/orgs","repos_url":"https://api.github.com/users/bingwen/repos","events_url":"https://api.github.com/users/bingwen/events{/privacy}","received_events_url":"https://api.github.com/users/bingwen/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-19T04:12:25Z","updated_at":"2014-11-19T10:10:36Z","closed_at":"2014-11-19T04:12:29Z","merged_at":"2014-11-19T04:12:29Z","merge_commit_sha":"16d308776ff2166f1c05cf36c7543c773c85107b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/borngods/shae/pulls/39/commits","review_comments_url":"https://api.github.com/repos/borngods/shae/pulls/39/comments","review_comment_url":"https://api.github.com/repos/borngods/shae/pulls/comments/{number}","comments_url":"https://api.github.com/repos/borngods/shae/issues/39/comments","statuses_url":"https://api.github.com/repos/borngods/shae/statuses/413c77b701152bce0c02c9bc11ee932a3c277c1b","head":{"label":"bingwen:mobile","ref":"mobile","sha":"413c77b701152bce0c02c9bc11ee932a3c277c1b","user":{"login":"bingwen","id":1501364,"avatar_url":"https://avatars.githubusercontent.com/u/1501364?v=3","gravatar_id":"","url":"https://api.github.com/users/bingwen","html_url":"https://github.com/bingwen","followers_url":"https://api.github.com/users/bingwen/followers","following_url":"https://api.github.com/users/bingwen/following{/other_user}","gists_url":"https://api.github.com/users/bingwen/gists{/gist_id}","starred_url":"https://api.github.com/users/bingwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingwen/subscriptions","organizations_url":"https://api.github.com/users/bingwen/orgs","repos_url":"https://api.github.com/users/bingwen/repos","events_url":"https://api.github.com/users/bingwen/events{/privacy}","received_events_url":"https://api.github.com/users/bingwen/received_events","type":"User","site_admin":false},"repo":{"id":26208152,"name":"shae","full_name":"bingwen/shae","owner":{"login":"bingwen","id":1501364,"avatar_url":"https://avatars.githubusercontent.com/u/1501364?v=3","gravatar_id":"","url":"https://api.github.com/users/bingwen","html_url":"https://github.com/bingwen","followers_url":"https://api.github.com/users/bingwen/followers","following_url":"https://api.github.com/users/bingwen/following{/other_user}","gists_url":"https://api.github.com/users/bingwen/gists{/gist_id}","starred_url":"https://api.github.com/users/bingwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingwen/subscriptions","organizations_url":"https://api.github.com/users/bingwen/orgs","repos_url":"https://api.github.com/users/bingwen/repos","events_url":"https://api.github.com/users/bingwen/events{/privacy}","received_events_url":"https://api.github.com/users/bingwen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bingwen/shae","description":"一些移动端网页小项目","fork":true,"url":"https://api.github.com/repos/bingwen/shae","forks_url":"https://api.github.com/repos/bingwen/shae/forks","keys_url":"https://api.github.com/repos/bingwen/shae/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bingwen/shae/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bingwen/shae/teams","hooks_url":"https://api.github.com/repos/bingwen/shae/hooks","issue_events_url":"https://api.github.com/repos/bingwen/shae/issues/events{/number}","events_url":"https://api.github.com/repos/bingwen/shae/events","assignees_url":"https://api.github.com/repos/bingwen/shae/assignees{/user}","branches_url":"https://api.github.com/repos/bingwen/shae/branches{/branch}","tags_url":"https://api.github.com/repos/bingwen/shae/tags","blobs_url":"https://api.github.com/repos/bingwen/shae/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bingwen/shae/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bingwen/shae/git/refs{/sha}","trees_url":"https://api.github.com/repos/bingwen/shae/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bingwen/shae/statuses/{sha}","languages_url":"https://api.github.com/repos/bingwen/shae/languages","stargazers_url":"https://api.github.com/repos/bingwen/shae/stargazers","contributors_url":"https://api.github.com/repos/bingwen/shae/contributors","subscribers_url":"https://api.github.com/repos/bingwen/shae/subscribers","subscription_url":"https://api.github.com/repos/bingwen/shae/subscription","commits_url":"https://api.github.com/repos/bingwen/shae/commits{/sha}","git_commits_url":"https://api.github.com/repos/bingwen/shae/git/commits{/sha}","comments_url":"https://api.github.com/repos/bingwen/shae/comments{/number}","issue_comment_url":"https://api.github.com/repos/bingwen/shae/issues/comments/{number}","contents_url":"https://api.github.com/repos/bingwen/shae/contents/{+path}","compare_url":"https://api.github.com/repos/bingwen/shae/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bingwen/shae/merges","archive_url":"https://api.github.com/repos/bingwen/shae/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bingwen/shae/downloads","issues_url":"https://api.github.com/repos/bingwen/shae/issues{/number}","pulls_url":"https://api.github.com/repos/bingwen/shae/pulls{/number}","milestones_url":"https://api.github.com/repos/bingwen/shae/milestones{/number}","notifications_url":"https://api.github.com/repos/bingwen/shae/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bingwen/shae/labels{/name}","releases_url":"https://api.github.com/repos/bingwen/shae/releases{/id}","created_at":"2014-11-05T07:22:58Z","updated_at":"2014-11-18T04:12:50Z","pushed_at":"2014-11-19T07:35:38Z","git_url":"git://github.com/bingwen/shae.git","ssh_url":"git@github.com:bingwen/shae.git","clone_url":"https://github.com/bingwen/shae.git","svn_url":"https://github.com/bingwen/shae","homepage":null,"size":2987,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borngods:master","ref":"master","sha":"2e1dd0ff4e0f5b8be3bdc6c898e68701e7e88ed7","user":{"login":"borngods","id":7072000,"avatar_url":"https://avatars.githubusercontent.com/u/7072000?v=3","gravatar_id":"","url":"https://api.github.com/users/borngods","html_url":"https://github.com/borngods","followers_url":"https://api.github.com/users/borngods/followers","following_url":"https://api.github.com/users/borngods/following{/other_user}","gists_url":"https://api.github.com/users/borngods/gists{/gist_id}","starred_url":"https://api.github.com/users/borngods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borngods/subscriptions","organizations_url":"https://api.github.com/users/borngods/orgs","repos_url":"https://api.github.com/users/borngods/repos","events_url":"https://api.github.com/users/borngods/events{/privacy}","received_events_url":"https://api.github.com/users/borngods/received_events","type":"Organization","site_admin":false},"repo":{"id":23858707,"name":"shae","full_name":"borngods/shae","owner":{"login":"borngods","id":7072000,"avatar_url":"https://avatars.githubusercontent.com/u/7072000?v=3","gravatar_id":"","url":"https://api.github.com/users/borngods","html_url":"https://github.com/borngods","followers_url":"https://api.github.com/users/borngods/followers","following_url":"https://api.github.com/users/borngods/following{/other_user}","gists_url":"https://api.github.com/users/borngods/gists{/gist_id}","starred_url":"https://api.github.com/users/borngods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borngods/subscriptions","organizations_url":"https://api.github.com/users/borngods/orgs","repos_url":"https://api.github.com/users/borngods/repos","events_url":"https://api.github.com/users/borngods/events{/privacy}","received_events_url":"https://api.github.com/users/borngods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/borngods/shae","description":"一些移动端网页小项目","fork":false,"url":"https://api.github.com/repos/borngods/shae","forks_url":"https://api.github.com/repos/borngods/shae/forks","keys_url":"https://api.github.com/repos/borngods/shae/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borngods/shae/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borngods/shae/teams","hooks_url":"https://api.github.com/repos/borngods/shae/hooks","issue_events_url":"https://api.github.com/repos/borngods/shae/issues/events{/number}","events_url":"https://api.github.com/repos/borngods/shae/events","assignees_url":"https://api.github.com/repos/borngods/shae/assignees{/user}","branches_url":"https://api.github.com/repos/borngods/shae/branches{/branch}","tags_url":"https://api.github.com/repos/borngods/shae/tags","blobs_url":"https://api.github.com/repos/borngods/shae/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borngods/shae/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borngods/shae/git/refs{/sha}","trees_url":"https://api.github.com/repos/borngods/shae/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borngods/shae/statuses/{sha}","languages_url":"https://api.github.com/repos/borngods/shae/languages","stargazers_url":"https://api.github.com/repos/borngods/shae/stargazers","contributors_url":"https://api.github.com/repos/borngods/shae/contributors","subscribers_url":"https://api.github.com/repos/borngods/shae/subscribers","subscription_url":"https://api.github.com/repos/borngods/shae/subscription","commits_url":"https://api.github.com/repos/borngods/shae/commits{/sha}","git_commits_url":"https://api.github.com/repos/borngods/shae/git/commits{/sha}","comments_url":"https://api.github.com/repos/borngods/shae/comments{/number}","issue_comment_url":"https://api.github.com/repos/borngods/shae/issues/comments/{number}","contents_url":"https://api.github.com/repos/borngods/shae/contents/{+path}","compare_url":"https://api.github.com/repos/borngods/shae/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borngods/shae/merges","archive_url":"https://api.github.com/repos/borngods/shae/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borngods/shae/downloads","issues_url":"https://api.github.com/repos/borngods/shae/issues{/number}","pulls_url":"https://api.github.com/repos/borngods/shae/pulls{/number}","milestones_url":"https://api.github.com/repos/borngods/shae/milestones{/number}","notifications_url":"https://api.github.com/repos/borngods/shae/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borngods/shae/labels{/name}","releases_url":"https://api.github.com/repos/borngods/shae/releases{/id}","created_at":"2014-09-10T03:02:17Z","updated_at":"2014-11-19T08:30:05Z","pushed_at":"2014-11-19T08:30:05Z","git_url":"git://github.com/borngods/shae.git","ssh_url":"git@github.com:borngods/shae.git","clone_url":"https://github.com/borngods/shae.git","svn_url":"https://github.com/borngods/shae","homepage":null,"size":3565,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borngods/shae/pulls/39"},"html":{"href":"https://github.com/borngods/shae/pull/39"},"issue":{"href":"https://api.github.com/repos/borngods/shae/issues/39"},"comments":{"href":"https://api.github.com/repos/borngods/shae/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/borngods/shae/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/borngods/shae/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/borngods/shae/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/borngods/shae/statuses/413c77b701152bce0c02c9bc11ee932a3c277c1b"}}}}