GitHub PullRequestEvent at 2014-04-19 15:12:36
Repository: Cataclysm-DDA
Actor: cSep
Payload: {"action":"closed","number":7274,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7274","id":14897673,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7274","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7274.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7274.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/7274","number":7274,"state":"closed","title":"Targeting fix (now targets last or nearest) #7091","user":{"login":"cSep","id":7228321,"avatar_url":"https://avatars.githubusercontent.com/u/7228321?","gravatar_id":"815d54da4344b430c467471a1d677e89","url":"https://api.github.com/users/cSep","html_url":"https://github.com/cSep","followers_url":"https://api.github.com/users/cSep/followers","following_url":"https://api.github.com/users/cSep/following{/other_user}","gists_url":"https://api.github.com/users/cSep/gists{/gist_id}","starred_url":"https://api.github.com/users/cSep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cSep/subscriptions","organizations_url":"https://api.github.com/users/cSep/orgs","repos_url":"https://api.github.com/users/cSep/repos","events_url":"https://api.github.com/users/cSep/events{/privacy}","received_events_url":"https://api.github.com/users/cSep/received_events","type":"User","site_admin":false},"body":"Trying my hand at #7091 I'm noticing how #6015 fixed a lot of stuff. so that's all good.\r\n\r\nAs the demo code included below shows, we have a new problem with aiming.  Fire something, Esc and retarget. you will likely also see the sudden emergence of a few phantom entries in the target list.\r\n\r\nWill fix and ammend, but I thought I'd show the in progress work first since it documents the error first.","created_at":"2014-04-17T21:21:27Z","updated_at":"2014-04-19T15:12:34Z","closed_at":"2014-04-19T15:12:34Z","merged_at":null,"merge_commit_sha":"765c7467226db426eaa2c906a92c142a9396eef3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7274/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7274/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/7274/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/3ccc4b105ce4e637f4eebde6aa4957891699e8bb","head":{"label":"cSep:targeting","ref":"targeting","sha":"3ccc4b105ce4e637f4eebde6aa4957891699e8bb","user":{"login":"cSep","id":7228321,"avatar_url":"https://avatars.githubusercontent.com/u/7228321?","gravatar_id":"815d54da4344b430c467471a1d677e89","url":"https://api.github.com/users/cSep","html_url":"https://github.com/cSep","followers_url":"https://api.github.com/users/cSep/followers","following_url":"https://api.github.com/users/cSep/following{/other_user}","gists_url":"https://api.github.com/users/cSep/gists{/gist_id}","starred_url":"https://api.github.com/users/cSep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cSep/subscriptions","organizations_url":"https://api.github.com/users/cSep/orgs","repos_url":"https://api.github.com/users/cSep/repos","events_url":"https://api.github.com/users/cSep/events{/privacy}","received_events_url":"https://api.github.com/users/cSep/received_events","type":"User","site_admin":false},"repo":{"id":18593739,"name":"Cataclysm-DDA","full_name":"cSep/Cataclysm-DDA","owner":{"login":"cSep","id":7228321,"avatar_url":"https://avatars.githubusercontent.com/u/7228321?","gravatar_id":"815d54da4344b430c467471a1d677e89","url":"https://api.github.com/users/cSep","html_url":"https://github.com/cSep","followers_url":"https://api.github.com/users/cSep/followers","following_url":"https://api.github.com/users/cSep/following{/other_user}","gists_url":"https://api.github.com/users/cSep/gists{/gist_id}","starred_url":"https://api.github.com/users/cSep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cSep/subscriptions","organizations_url":"https://api.github.com/users/cSep/orgs","repos_url":"https://api.github.com/users/cSep/repos","events_url":"https://api.github.com/users/cSep/events{/privacy}","received_events_url":"https://api.github.com/users/cSep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cSep/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/cSep/Cataclysm-DDA","forks_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/cSep/Cataclysm-DDA/releases{/id}","created_at":"2014-04-09T10:34:27Z","updated_at":"2014-04-19T15:11:50Z","pushed_at":"2014-04-19T15:10:05Z","git_url":"git://github.com/cSep/Cataclysm-DDA.git","ssh_url":"git@github.com:cSep/Cataclysm-DDA.git","clone_url":"https://github.com/cSep/Cataclysm-DDA.git","svn_url":"https://github.com/cSep/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":124882,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"77671bd704948dfd11a83277414e9e4d17eca526","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?","gravatar_id":null,"url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?","gravatar_id":null,"url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2014-04-19T06:15:40Z","pushed_at":"2014-04-19T06:15:39Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":191548,"stargazers_count":388,"watchers_count":388,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":451,"mirror_url":null,"open_issues_count":653,"forks":451,"open_issues":653,"watchers":388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7274"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7274"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/7274"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/7274/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7274/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7274/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/3ccc4b105ce4e637f4eebde6aa4957891699e8bb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":17,"commits":27,"additions":35,"deletions":21,"changed_files":4}}