GitHub PullRequestReviewCommentEvent at 2014-11-11 12:30:35
Repository: crosswalk-android-extensions
Actor: deqing
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/comments/20146716","id":20146716,"diff_hunk":"@@ -0,0 +1,17 @@\n+function {{class}}() {\n+    {% for member in members if member.default_value %}\n+    this.{{member.name}} = {{member.default_value}};\n+    {% endfor %}\n+\n+    var msg = {\n+        'cmd': 'init_dictionary',\n+        'class_name': '{{class}}',\n+        'option': this,","path":"build/idl-generator/third_party/WebKit/Source/bindings/templates/dictionary.js","position":9,"original_position":9,"commit_id":"9966708f068ec6aec747f4e46d7c0aeef324d597","original_commit_id":"9966708f068ec6aec747f4e46d7c0aeef324d597","user":{"login":"deqing","id":1152174,"avatar_url":"https://avatars.githubusercontent.com/u/1152174?v=3","gravatar_id":"","url":"https://api.github.com/users/deqing","html_url":"https://github.com/deqing","followers_url":"https://api.github.com/users/deqing/followers","following_url":"https://api.github.com/users/deqing/following{/other_user}","gists_url":"https://api.github.com/users/deqing/gists{/gist_id}","starred_url":"https://api.github.com/users/deqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deqing/subscriptions","organizations_url":"https://api.github.com/users/deqing/orgs","repos_url":"https://api.github.com/users/deqing/repos","events_url":"https://api.github.com/users/deqing/events{/privacy}","received_events_url":"https://api.github.com/users/deqing/received_events","type":"User","site_admin":false},"body":"What does \"option\" mean? What about call it \"data\" or \"members\"?","created_at":"2014-11-11T12:30:35Z","updated_at":"2014-11-11T12:30:35Z","html_url":"https://github.com/crosswalk-project/crosswalk-android-extensions/pull/26#discussion_r20146716","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/comments/20146716"},"html":{"href":"https://github.com/crosswalk-project/crosswalk-android-extensions/pull/26#discussion_r20146716"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/26","id":24129639,"html_url":"https://github.com/crosswalk-project/crosswalk-android-extensions/pull/26","diff_url":"https://github.com/crosswalk-project/crosswalk-android-extensions/pull/26.diff","patch_url":"https://github.com/crosswalk-project/crosswalk-android-extensions/pull/26.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/issues/26","number":26,"state":"open","locked":false,"title":"[idl-generator] Add support for Dictionary","user":{"login":"d0ngjun","id":3346718,"avatar_url":"https://avatars.githubusercontent.com/u/3346718?v=3","gravatar_id":"","url":"https://api.github.com/users/d0ngjun","html_url":"https://github.com/d0ngjun","followers_url":"https://api.github.com/users/d0ngjun/followers","following_url":"https://api.github.com/users/d0ngjun/following{/other_user}","gists_url":"https://api.github.com/users/d0ngjun/gists{/gist_id}","starred_url":"https://api.github.com/users/d0ngjun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d0ngjun/subscriptions","organizations_url":"https://api.github.com/users/d0ngjun/orgs","repos_url":"https://api.github.com/users/d0ngjun/repos","events_url":"https://api.github.com/users/d0ngjun/events{/privacy}","received_events_url":"https://api.github.com/users/d0ngjun/received_events","type":"User","site_admin":false},"body":"1) add support for dictionary.\r\n2) add support for multiple idl files(one definition per file).\r\n3) add code in idl_demo for demonstrating how to use dictionary.","created_at":"2014-11-10T06:55:41Z","updated_at":"2014-11-11T12:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2846ebeca9dd5b21e122b465ed86f9c135a2f2db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/26/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/26/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/issues/26/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/statuses/9966708f068ec6aec747f4e46d7c0aeef324d597","head":{"label":"d0ngjun:idl_generator_dictionary_support","ref":"idl_generator_dictionary_support","sha":"9966708f068ec6aec747f4e46d7c0aeef324d597","user":{"login":"d0ngjun","id":3346718,"avatar_url":"https://avatars.githubusercontent.com/u/3346718?v=3","gravatar_id":"","url":"https://api.github.com/users/d0ngjun","html_url":"https://github.com/d0ngjun","followers_url":"https://api.github.com/users/d0ngjun/followers","following_url":"https://api.github.com/users/d0ngjun/following{/other_user}","gists_url":"https://api.github.com/users/d0ngjun/gists{/gist_id}","starred_url":"https://api.github.com/users/d0ngjun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d0ngjun/subscriptions","organizations_url":"https://api.github.com/users/d0ngjun/orgs","repos_url":"https://api.github.com/users/d0ngjun/repos","events_url":"https://api.github.com/users/d0ngjun/events{/privacy}","received_events_url":"https://api.github.com/users/d0ngjun/received_events","type":"User","site_admin":false},"repo":{"id":26424466,"name":"crosswalk-android-extensions","full_name":"d0ngjun/crosswalk-android-extensions","owner":{"login":"d0ngjun","id":3346718,"avatar_url":"https://avatars.githubusercontent.com/u/3346718?v=3","gravatar_id":"","url":"https://api.github.com/users/d0ngjun","html_url":"https://github.com/d0ngjun","followers_url":"https://api.github.com/users/d0ngjun/followers","following_url":"https://api.github.com/users/d0ngjun/following{/other_user}","gists_url":"https://api.github.com/users/d0ngjun/gists{/gist_id}","starred_url":"https://api.github.com/users/d0ngjun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d0ngjun/subscriptions","organizations_url":"https://api.github.com/users/d0ngjun/orgs","repos_url":"https://api.github.com/users/d0ngjun/repos","events_url":"https://api.github.com/users/d0ngjun/events{/privacy}","received_events_url":"https://api.github.com/users/d0ngjun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d0ngjun/crosswalk-android-extensions","description":"Repo for external crosswalk extensions for Android port","fork":true,"url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions","forks_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/forks","keys_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/teams","hooks_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/hooks","issue_events_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/events","assignees_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/tags","blobs_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/languages","stargazers_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/stargazers","contributors_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/contributors","subscribers_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/subscribers","subscription_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/subscription","commits_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/issues/comments/{number}","contents_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/merges","archive_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/downloads","issues_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/labels{/name}","releases_url":"https://api.github.com/repos/d0ngjun/crosswalk-android-extensions/releases{/id}","created_at":"2014-11-10T06:47:30Z","updated_at":"2014-11-09T02:47:12Z","pushed_at":"2014-11-10T06:49:35Z","git_url":"git://github.com/d0ngjun/crosswalk-android-extensions.git","ssh_url":"git@github.com:d0ngjun/crosswalk-android-extensions.git","clone_url":"https://github.com/d0ngjun/crosswalk-android-extensions.git","svn_url":"https://github.com/d0ngjun/crosswalk-android-extensions","homepage":null,"size":5801,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"9da18b8e3e72c3b3d00edf2f05a1089829b699cb","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":19067692,"name":"crosswalk-android-extensions","full_name":"crosswalk-project/crosswalk-android-extensions","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk-android-extensions","description":"Repo for external crosswalk extensions for Android port","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/releases{/id}","created_at":"2014-04-23T11:48:51Z","updated_at":"2014-11-09T02:47:12Z","pushed_at":"2014-10-31T10:32:14Z","git_url":"git://github.com/crosswalk-project/crosswalk-android-extensions.git","ssh_url":"git@github.com:crosswalk-project/crosswalk-android-extensions.git","clone_url":"https://github.com/crosswalk-project/crosswalk-android-extensions.git","svn_url":"https://github.com/crosswalk-project/crosswalk-android-extensions","homepage":null,"size":5801,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/26"},"html":{"href":"https://github.com/crosswalk-project/crosswalk-android-extensions/pull/26"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/issues/26"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-android-extensions/statuses/9966708f068ec6aec747f4e46d7c0aeef324d597"}}}}