GitHub PullRequestReviewCommentEvent at 2014-10-07 10:24:21
Repository: ft-origami
Actor: triblondon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/comments/18510629","id":18510629,"diff_hunk":"@@ -180,6 +180,53 @@ Component authors *may* include a `demos` folder to provide examples.  Demos *mu\n \n When choosing content for a demo, and deciding on the composition of a demo, component developers *must* craft realistic examples using real use cases.  If it's necessary to make demos contrived in order to demonstrate the full range of features of the component, multiple demos *should* be created, so that at least one demo (which *should* be the default-expanded demo) shows a realistic use case.\n \n+### Demo config file\n+\n+The demo config file tells the Build Service and the [origami-build-tools](https://github.com/Financial-Times/origami-build-tools) what demo files to build. It has two properties:\n+\n+* `options`: __Object__ configuration to apply to all demos (unless overridden for a specific demo)\n+* `demos`: __Array__ list of demos to build\n+\n+Options, and individual demos, can have the following properties:\n+\n+* `template`: __String__ The mustache template to render. (_Required_)\n+* `sass`: __String__ The SASS file to compile. (_Optional_)\n+* `js`: __String__ The JS file to build with Browserify. (_Optional_)\n+* `data`: __String__ Data to pass to the mustache template. (_Optional_)\n+* `bodyClasses`: __String__ CSS classes to set on the body. (_Optional_)\n+* `expanded`: __Boolean__ (default: `true`) Whether the demo should be shown in expanded form in the [Registry](registry.origami.ft.com). (_Optional_)\n+* `description`: __String__ Explanation of the purpose of the demo. (_Optional_)\n+\n+Individual demos also has another property:","path":"docs/component-spec/modules.md","position":21,"original_position":21,"commit_id":"2ff7128ad9db48a5d598be1ba0cfcb9fcc2fe10e","original_commit_id":"2ff7128ad9db48a5d598be1ba0cfcb9fcc2fe10e","user":{"login":"triblondon","id":1735391,"avatar_url":"https://avatars.githubusercontent.com/u/1735391?v=2","gravatar_id":"","url":"https://api.github.com/users/triblondon","html_url":"https://github.com/triblondon","followers_url":"https://api.github.com/users/triblondon/followers","following_url":"https://api.github.com/users/triblondon/following{/other_user}","gists_url":"https://api.github.com/users/triblondon/gists{/gist_id}","starred_url":"https://api.github.com/users/triblondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triblondon/subscriptions","organizations_url":"https://api.github.com/users/triblondon/orgs","repos_url":"https://api.github.com/users/triblondon/repos","events_url":"https://api.github.com/users/triblondon/events{/privacy}","received_events_url":"https://api.github.com/users/triblondon/received_events","type":"User","site_admin":false},"body":"have","created_at":"2014-10-07T10:24:21Z","updated_at":"2014-10-07T10:24:21Z","html_url":"https://github.com/Financial-Times/ft-origami/pull/248#discussion_r18510629","pull_request_url":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/248","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/comments/18510629"},"html":{"href":"https://github.com/Financial-Times/ft-origami/pull/248#discussion_r18510629"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/248","id":22206515,"html_url":"https://github.com/Financial-Times/ft-origami/pull/248","diff_url":"https://github.com/Financial-Times/ft-origami/pull/248.diff","patch_url":"https://github.com/Financial-Times/ft-origami/pull/248.patch","issue_url":"https://api.github.com/repos/Financial-Times/ft-origami/issues/248","number":248,"state":"open","locked":false,"title":"Moved demo config file documentation from the build tools readme to the ...","user":{"login":"AlbertoElias","id":913117,"avatar_url":"https://avatars.githubusercontent.com/u/913117?v=2","gravatar_id":"","url":"https://api.github.com/users/AlbertoElias","html_url":"https://github.com/AlbertoElias","followers_url":"https://api.github.com/users/AlbertoElias/followers","following_url":"https://api.github.com/users/AlbertoElias/following{/other_user}","gists_url":"https://api.github.com/users/AlbertoElias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbertoElias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbertoElias/subscriptions","organizations_url":"https://api.github.com/users/AlbertoElias/orgs","repos_url":"https://api.github.com/users/AlbertoElias/repos","events_url":"https://api.github.com/users/AlbertoElias/events{/privacy}","received_events_url":"https://api.github.com/users/AlbertoElias/received_events","type":"User","site_admin":false},"body":"...origami spec","created_at":"2014-10-03T14:31:21Z","updated_at":"2014-10-07T10:24:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e0cc6e906dfbd83f642c25f1ef50f6698279316","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/248/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/248/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Financial-Times/ft-origami/issues/248/comments","statuses_url":"https://api.github.com/repos/Financial-Times/ft-origami/statuses/2ff7128ad9db48a5d598be1ba0cfcb9fcc2fe10e","head":{"label":"Financial-Times:build-tools","ref":"build-tools","sha":"2ff7128ad9db48a5d598be1ba0cfcb9fcc2fe10e","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=2","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":11848885,"name":"ft-origami","full_name":"Financial-Times/ft-origami","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=2","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/ft-origami","description":"Universal front end component standards for FT web products","fork":false,"url":"https://api.github.com/repos/Financial-Times/ft-origami","forks_url":"https://api.github.com/repos/Financial-Times/ft-origami/forks","keys_url":"https://api.github.com/repos/Financial-Times/ft-origami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/ft-origami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/ft-origami/teams","hooks_url":"https://api.github.com/repos/Financial-Times/ft-origami/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/ft-origami/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/ft-origami/events","assignees_url":"https://api.github.com/repos/Financial-Times/ft-origami/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/ft-origami/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/ft-origami/tags","blobs_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/ft-origami/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/ft-origami/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/ft-origami/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/ft-origami/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/ft-origami/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/ft-origami/subscription","commits_url":"https://api.github.com/repos/Financial-Times/ft-origami/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/ft-origami/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/ft-origami/issues/comments/{number}","contents_url":"https://api.github.com/repos/Financial-Times/ft-origami/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/ft-origami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/ft-origami/merges","archive_url":"https://api.github.com/repos/Financial-Times/ft-origami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/ft-origami/downloads","issues_url":"https://api.github.com/repos/Financial-Times/ft-origami/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/ft-origami/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/ft-origami/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/ft-origami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/ft-origami/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/ft-origami/releases{/id}","created_at":"2013-08-02T17:36:44Z","updated_at":"2014-09-12T18:02:49Z","pushed_at":"2014-10-07T10:21:42Z","git_url":"git://github.com/Financial-Times/ft-origami.git","ssh_url":"git@github.com:Financial-Times/ft-origami.git","clone_url":"https://github.com/Financial-Times/ft-origami.git","svn_url":"https://github.com/Financial-Times/ft-origami","homepage":"http://origami.ft.com/","size":5711,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":13,"default_branch":"gh-pages"}},"base":{"label":"Financial-Times:gh-pages","ref":"gh-pages","sha":"66d0a1b7bff717c0188d426482d6d703c603e0cf","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=2","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":11848885,"name":"ft-origami","full_name":"Financial-Times/ft-origami","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=2","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/ft-origami","description":"Universal front end component standards for FT web products","fork":false,"url":"https://api.github.com/repos/Financial-Times/ft-origami","forks_url":"https://api.github.com/repos/Financial-Times/ft-origami/forks","keys_url":"https://api.github.com/repos/Financial-Times/ft-origami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/ft-origami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/ft-origami/teams","hooks_url":"https://api.github.com/repos/Financial-Times/ft-origami/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/ft-origami/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/ft-origami/events","assignees_url":"https://api.github.com/repos/Financial-Times/ft-origami/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/ft-origami/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/ft-origami/tags","blobs_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/ft-origami/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/ft-origami/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/ft-origami/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/ft-origami/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/ft-origami/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/ft-origami/subscription","commits_url":"https://api.github.com/repos/Financial-Times/ft-origami/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/ft-origami/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/ft-origami/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/ft-origami/issues/comments/{number}","contents_url":"https://api.github.com/repos/Financial-Times/ft-origami/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/ft-origami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/ft-origami/merges","archive_url":"https://api.github.com/repos/Financial-Times/ft-origami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/ft-origami/downloads","issues_url":"https://api.github.com/repos/Financial-Times/ft-origami/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/ft-origami/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/ft-origami/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/ft-origami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/ft-origami/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/ft-origami/releases{/id}","created_at":"2013-08-02T17:36:44Z","updated_at":"2014-09-12T18:02:49Z","pushed_at":"2014-10-07T10:21:42Z","git_url":"git://github.com/Financial-Times/ft-origami.git","ssh_url":"git@github.com:Financial-Times/ft-origami.git","clone_url":"https://github.com/Financial-Times/ft-origami.git","svn_url":"https://github.com/Financial-Times/ft-origami","homepage":"http://origami.ft.com/","size":5711,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":13,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/248"},"html":{"href":"https://github.com/Financial-Times/ft-origami/pull/248"},"issue":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/issues/248"},"comments":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/ft-origami/statuses/2ff7128ad9db48a5d598be1ba0cfcb9fcc2fe10e"}}}}