GitHub PullRequestEvent at 2014-12-19 01:58:44
Repository: Sponge
Actor: bloodmc
Payload: {"action":"closed","number":84,"pull_request":{"url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/84","id":26346448,"html_url":"https://github.com/SpongePowered/Sponge/pull/84","diff_url":"https://github.com/SpongePowered/Sponge/pull/84.diff","patch_url":"https://github.com/SpongePowered/Sponge/pull/84.patch","issue_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/84","number":84,"state":"closed","locked":false,"title":"Implement getTranslation for MixinBlockType and MixinItemType.","user":{"login":"Hidendra","id":499650,"avatar_url":"https://avatars.githubusercontent.com/u/499650?v=3","gravatar_id":"","url":"https://api.github.com/users/Hidendra","html_url":"https://github.com/Hidendra","followers_url":"https://api.github.com/users/Hidendra/followers","following_url":"https://api.github.com/users/Hidendra/following{/other_user}","gists_url":"https://api.github.com/users/Hidendra/gists{/gist_id}","starred_url":"https://api.github.com/users/Hidendra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hidendra/subscriptions","organizations_url":"https://api.github.com/users/Hidendra/orgs","repos_url":"https://api.github.com/users/Hidendra/repos","events_url":"https://api.github.com/users/Hidendra/events{/privacy}","received_events_url":"https://api.github.com/users/Hidendra/received_events","type":"User","site_admin":false},"body":"`getTranslation` (part of `Translatable`) is currently not implemented for `MixinBlockType` and `MixinItemType`. This implements both by simply creating a static `Translation` object. This'll probably change in the future when something is done with the factories, but works for now.\r\n\r\n**Note**: `MixinItemType` calls `StatCollector.translateToLocal` directly at the moment because MC's `Item` only offers the method `getItemStackDisplayName(ItemStack)`. No `ItemStack` is available, and it does not seem right to pass null to it because mods assume it's not null :-).","created_at":"2014-12-19T01:49:23Z","updated_at":"2014-12-19T01:58:44Z","closed_at":"2014-12-19T01:58:44Z","merged_at":"2014-12-19T01:58:44Z","merge_commit_sha":"74d5f5e43580799822c1b9a41baad65c6e0c9db4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/84/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/84/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/84/comments","statuses_url":"https://api.github.com/repos/SpongePowered/Sponge/statuses/385da7f91eb85dc16d8e4135945773c42b561491","head":{"label":"Hidendra:feature/type-translation","ref":"feature/type-translation","sha":"385da7f91eb85dc16d8e4135945773c42b561491","user":{"login":"Hidendra","id":499650,"avatar_url":"https://avatars.githubusercontent.com/u/499650?v=3","gravatar_id":"","url":"https://api.github.com/users/Hidendra","html_url":"https://github.com/Hidendra","followers_url":"https://api.github.com/users/Hidendra/followers","following_url":"https://api.github.com/users/Hidendra/following{/other_user}","gists_url":"https://api.github.com/users/Hidendra/gists{/gist_id}","starred_url":"https://api.github.com/users/Hidendra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hidendra/subscriptions","organizations_url":"https://api.github.com/users/Hidendra/orgs","repos_url":"https://api.github.com/users/Hidendra/repos","events_url":"https://api.github.com/users/Hidendra/events{/privacy}","received_events_url":"https://api.github.com/users/Hidendra/received_events","type":"User","site_admin":false},"repo":{"id":28208808,"name":"Sponge","full_name":"Hidendra/Sponge","owner":{"login":"Hidendra","id":499650,"avatar_url":"https://avatars.githubusercontent.com/u/499650?v=3","gravatar_id":"","url":"https://api.github.com/users/Hidendra","html_url":"https://github.com/Hidendra","followers_url":"https://api.github.com/users/Hidendra/followers","following_url":"https://api.github.com/users/Hidendra/following{/other_user}","gists_url":"https://api.github.com/users/Hidendra/gists{/gist_id}","starred_url":"https://api.github.com/users/Hidendra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hidendra/subscriptions","organizations_url":"https://api.github.com/users/Hidendra/orgs","repos_url":"https://api.github.com/users/Hidendra/repos","events_url":"https://api.github.com/users/Hidendra/events{/privacy}","received_events_url":"https://api.github.com/users/Hidendra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hidendra/Sponge","description":"A Forge mod that implements SpongeAPI","fork":true,"url":"https://api.github.com/repos/Hidendra/Sponge","forks_url":"https://api.github.com/repos/Hidendra/Sponge/forks","keys_url":"https://api.github.com/repos/Hidendra/Sponge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hidendra/Sponge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hidendra/Sponge/teams","hooks_url":"https://api.github.com/repos/Hidendra/Sponge/hooks","issue_events_url":"https://api.github.com/repos/Hidendra/Sponge/issues/events{/number}","events_url":"https://api.github.com/repos/Hidendra/Sponge/events","assignees_url":"https://api.github.com/repos/Hidendra/Sponge/assignees{/user}","branches_url":"https://api.github.com/repos/Hidendra/Sponge/branches{/branch}","tags_url":"https://api.github.com/repos/Hidendra/Sponge/tags","blobs_url":"https://api.github.com/repos/Hidendra/Sponge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hidendra/Sponge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hidendra/Sponge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hidendra/Sponge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hidendra/Sponge/statuses/{sha}","languages_url":"https://api.github.com/repos/Hidendra/Sponge/languages","stargazers_url":"https://api.github.com/repos/Hidendra/Sponge/stargazers","contributors_url":"https://api.github.com/repos/Hidendra/Sponge/contributors","subscribers_url":"https://api.github.com/repos/Hidendra/Sponge/subscribers","subscription_url":"https://api.github.com/repos/Hidendra/Sponge/subscription","commits_url":"https://api.github.com/repos/Hidendra/Sponge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hidendra/Sponge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hidendra/Sponge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hidendra/Sponge/issues/comments/{number}","contents_url":"https://api.github.com/repos/Hidendra/Sponge/contents/{+path}","compare_url":"https://api.github.com/repos/Hidendra/Sponge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hidendra/Sponge/merges","archive_url":"https://api.github.com/repos/Hidendra/Sponge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hidendra/Sponge/downloads","issues_url":"https://api.github.com/repos/Hidendra/Sponge/issues{/number}","pulls_url":"https://api.github.com/repos/Hidendra/Sponge/pulls{/number}","milestones_url":"https://api.github.com/repos/Hidendra/Sponge/milestones{/number}","notifications_url":"https://api.github.com/repos/Hidendra/Sponge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hidendra/Sponge/labels{/name}","releases_url":"https://api.github.com/repos/Hidendra/Sponge/releases{/id}","created_at":"2014-12-19T01:15:42Z","updated_at":"2014-12-19T01:15:42Z","pushed_at":"2014-12-19T01:48:26Z","git_url":"git://github.com/Hidendra/Sponge.git","ssh_url":"git@github.com:Hidendra/Sponge.git","clone_url":"https://github.com/Hidendra/Sponge.git","svn_url":"https://github.com/Hidendra/Sponge","homepage":"http://www.spongepowered.org/","size":2263,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"23d1e9dd23fbc873c0fbf3b3ebcb2c9da40a4768","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23774298,"name":"Sponge","full_name":"SpongePowered/Sponge","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/Sponge","description":"A Forge mod that implements SpongeAPI","fork":false,"url":"https://api.github.com/repos/SpongePowered/Sponge","forks_url":"https://api.github.com/repos/SpongePowered/Sponge/forks","keys_url":"https://api.github.com/repos/SpongePowered/Sponge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/Sponge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/Sponge/teams","hooks_url":"https://api.github.com/repos/SpongePowered/Sponge/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/Sponge/events","assignees_url":"https://api.github.com/repos/SpongePowered/Sponge/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/Sponge/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/Sponge/tags","blobs_url":"https://api.github.com/repos/SpongePowered/Sponge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/Sponge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/Sponge/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/Sponge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/Sponge/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/Sponge/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/Sponge/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/Sponge/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/Sponge/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/Sponge/subscription","commits_url":"https://api.github.com/repos/SpongePowered/Sponge/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/Sponge/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/Sponge/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/comments/{number}","contents_url":"https://api.github.com/repos/SpongePowered/Sponge/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/Sponge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/Sponge/merges","archive_url":"https://api.github.com/repos/SpongePowered/Sponge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/Sponge/downloads","issues_url":"https://api.github.com/repos/SpongePowered/Sponge/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/Sponge/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/Sponge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/Sponge/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/Sponge/releases{/id}","created_at":"2014-09-08T00:01:33Z","updated_at":"2014-12-18T11:36:47Z","pushed_at":"2014-12-19T01:58:44Z","git_url":"git://github.com/SpongePowered/Sponge.git","ssh_url":"git@github.com:SpongePowered/Sponge.git","clone_url":"https://github.com/SpongePowered/Sponge.git","svn_url":"https://github.com/SpongePowered/Sponge","homepage":"http://www.spongepowered.org/","size":2263,"stargazers_count":682,"watchers_count":682,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":268,"mirror_url":null,"open_issues_count":4,"forks":268,"open_issues":4,"watchers":682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/84"},"html":{"href":"https://github.com/SpongePowered/Sponge/pull/84"},"issue":{"href":"https://api.github.com/repos/SpongePowered/Sponge/issues/84"},"comments":{"href":"https://api.github.com/repos/SpongePowered/Sponge/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/Sponge/statuses/385da7f91eb85dc16d8e4135945773c42b561491"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bloodmc","id":2998171,"avatar_url":"https://avatars.githubusercontent.com/u/2998171?v=3","gravatar_id":"","url":"https://api.github.com/users/bloodmc","html_url":"https://github.com/bloodmc","followers_url":"https://api.github.com/users/bloodmc/followers","following_url":"https://api.github.com/users/bloodmc/following{/other_user}","gists_url":"https://api.github.com/users/bloodmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bloodmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloodmc/subscriptions","organizations_url":"https://api.github.com/users/bloodmc/orgs","repos_url":"https://api.github.com/users/bloodmc/repos","events_url":"https://api.github.com/users/bloodmc/events{/privacy}","received_events_url":"https://api.github.com/users/bloodmc/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":84,"deletions":0,"changed_files":3}}