GitHub PullRequestReviewCommentEvent at 2014-09-15 13:44:24
Repository: gitlabhq
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/17541955","id":17541955,"diff_hunk":"@@ -131,4 +131,58 @@\n       post api(\"/projects/#{project.id}/issues/#{issue.id}/notes\", user), body: 'hi!'\n     end\n   end\n+\n+\n+  describe \"PATCH /projects/:id/noteable/:noteable_id/notes/:note_id\" do\n+    context \"when noteable is an Issue\" do\n+      it \"should return patched note\" do\n+        patch api(\"/projects/#{project.id}/issues/#{issue.id}/notes/#{issue_note.id}\", user),\n+              body: 'Hello!'\n+        response.status.should == 200\n+        json_response['body'].should == 'Hello!'\n+      end\n+\n+      it \"should return a 404 error when note id not found\" do\n+        patch api(\"/projects/#{project.id}/issues/#{issue.id}/notes/123\", user),\n+              body: 'Hello!'\n+        response.status.should == 404\n+      end\n+\n+      it \"should return a 400 bad request error if body not given\" do\n+        patch api(\"/projects/#{project.id}/issues/#{issue.id}/notes/#{issue_note.id}\", user)\n+        response.status.should == 400\n+      end\n+    end\n+\n+    context \"when noteable is a Snippet\" do\n+      it \"should return patched note\" do\n+        patch api(\"/projects/#{project.id}/snippets/#{snippet.id}/notes/#{snippet_note.id}\", user),\n+              body: 'Hello!'\n+        response.status.should == 200\n+        json_response['body'].should == 'Hello!'\n+      end\n+\n+      it \"should return a 404 error when note id not found\" do\n+        patch api(\"/projects/#{project.id}/snippets/#{snippet.id}/notes/123\", user),\n+              body: \"Hello!\"\n+        response.status.should == 404\n+      end\n+    end\n+\n+    context \"when noteable is a Merge Request\" do\n+      it \"should return patched note\" do\n+        patch api(\"/projects/#{project.id}/merge_requests/#{merge_request.id}/notes/#{merge_request_note.id}\", user),\n+              body: 'Hello!'\n+        response.status.should == 200\n+        json_response['body'].should == 'Hello!'\n+      end\n+\n+      it \"should return a 404 error when note id not found\" do\n+        patch api(\"/projects/#{project.id}/merge_requests/#{merge_request.id}/notes/123\", user),","path":"spec/requests/api/notes_spec.rb","position":51,"original_position":51,"commit_id":"e076c88d3487e05ac102d3a8bd28451de85daafe","original_commit_id":"e076c88d3487e05ac102d3a8bd28451de85daafe","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [96/80]","created_at":"2014-09-15T13:44:24Z","updated_at":"2014-09-15T13:44:24Z","html_url":"https://github.com/gitlabhq/gitlabhq/pull/7675#discussion_r17541955","pull_request_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7675","_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/17541955"},"html":{"href":"https://github.com/gitlabhq/gitlabhq/pull/7675#discussion_r17541955"},"pull_request":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7675"}}},"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7675","id":20619151,"html_url":"https://github.com/gitlabhq/gitlabhq/pull/7675","diff_url":"https://github.com/gitlabhq/gitlabhq/pull/7675.diff","patch_url":"https://github.com/gitlabhq/gitlabhq/pull/7675.patch","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7675","number":7675,"state":"open","locked":false,"title":"Implemented notes (body) patching in API.","user":{"login":"yglukhov","id":6962409,"avatar_url":"https://avatars.githubusercontent.com/u/6962409?v=2","gravatar_id":"71b7b08fbc2f989a8246913ac608cca9","url":"https://api.github.com/users/yglukhov","html_url":"https://github.com/yglukhov","followers_url":"https://api.github.com/users/yglukhov/followers","following_url":"https://api.github.com/users/yglukhov/following{/other_user}","gists_url":"https://api.github.com/users/yglukhov/gists{/gist_id}","starred_url":"https://api.github.com/users/yglukhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yglukhov/subscriptions","organizations_url":"https://api.github.com/users/yglukhov/orgs","repos_url":"https://api.github.com/users/yglukhov/repos","events_url":"https://api.github.com/users/yglukhov/events{/privacy}","received_events_url":"https://api.github.com/users/yglukhov/received_events","type":"User","site_admin":false},"body":"I'm not 100% sure if this is the correct approach to do it, but this solution works for me. Please, review. Thanx!","created_at":"2014-09-02T15:15:13Z","updated_at":"2014-09-15T13:44:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2ab99e21010c6363b2d965ac346951cd0086a86","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7675/commits","review_comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7675/comments","review_comment_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7675/comments","statuses_url":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/e076c88d3487e05ac102d3a8bd28451de85daafe","head":{"label":"yglukhov:patch_notes_api","ref":"patch_notes_api","sha":"e076c88d3487e05ac102d3a8bd28451de85daafe","user":{"login":"yglukhov","id":6962409,"avatar_url":"https://avatars.githubusercontent.com/u/6962409?v=2","gravatar_id":"71b7b08fbc2f989a8246913ac608cca9","url":"https://api.github.com/users/yglukhov","html_url":"https://github.com/yglukhov","followers_url":"https://api.github.com/users/yglukhov/followers","following_url":"https://api.github.com/users/yglukhov/following{/other_user}","gists_url":"https://api.github.com/users/yglukhov/gists{/gist_id}","starred_url":"https://api.github.com/users/yglukhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yglukhov/subscriptions","organizations_url":"https://api.github.com/users/yglukhov/orgs","repos_url":"https://api.github.com/users/yglukhov/repos","events_url":"https://api.github.com/users/yglukhov/events{/privacy}","received_events_url":"https://api.github.com/users/yglukhov/received_events","type":"User","site_admin":false},"repo":{"id":22912298,"name":"gitlabhq","full_name":"yglukhov/gitlabhq","owner":{"login":"yglukhov","id":6962409,"avatar_url":"https://avatars.githubusercontent.com/u/6962409?v=2","gravatar_id":"71b7b08fbc2f989a8246913ac608cca9","url":"https://api.github.com/users/yglukhov","html_url":"https://github.com/yglukhov","followers_url":"https://api.github.com/users/yglukhov/followers","following_url":"https://api.github.com/users/yglukhov/following{/other_user}","gists_url":"https://api.github.com/users/yglukhov/gists{/gist_id}","starred_url":"https://api.github.com/users/yglukhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yglukhov/subscriptions","organizations_url":"https://api.github.com/users/yglukhov/orgs","repos_url":"https://api.github.com/users/yglukhov/repos","events_url":"https://api.github.com/users/yglukhov/events{/privacy}","received_events_url":"https://api.github.com/users/yglukhov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yglukhov/gitlabhq","description":"Open source software to collaborate on code. Follow us on twitter @gitlabhq","fork":true,"url":"https://api.github.com/repos/yglukhov/gitlabhq","forks_url":"https://api.github.com/repos/yglukhov/gitlabhq/forks","keys_url":"https://api.github.com/repos/yglukhov/gitlabhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yglukhov/gitlabhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yglukhov/gitlabhq/teams","hooks_url":"https://api.github.com/repos/yglukhov/gitlabhq/hooks","issue_events_url":"https://api.github.com/repos/yglukhov/gitlabhq/issues/events{/number}","events_url":"https://api.github.com/repos/yglukhov/gitlabhq/events","assignees_url":"https://api.github.com/repos/yglukhov/gitlabhq/assignees{/user}","branches_url":"https://api.github.com/repos/yglukhov/gitlabhq/branches{/branch}","tags_url":"https://api.github.com/repos/yglukhov/gitlabhq/tags","blobs_url":"https://api.github.com/repos/yglukhov/gitlabhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yglukhov/gitlabhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yglukhov/gitlabhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/yglukhov/gitlabhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yglukhov/gitlabhq/statuses/{sha}","languages_url":"https://api.github.com/repos/yglukhov/gitlabhq/languages","stargazers_url":"https://api.github.com/repos/yglukhov/gitlabhq/stargazers","contributors_url":"https://api.github.com/repos/yglukhov/gitlabhq/contributors","subscribers_url":"https://api.github.com/repos/yglukhov/gitlabhq/subscribers","subscription_url":"https://api.github.com/repos/yglukhov/gitlabhq/subscription","commits_url":"https://api.github.com/repos/yglukhov/gitlabhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/yglukhov/gitlabhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/yglukhov/gitlabhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/yglukhov/gitlabhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/yglukhov/gitlabhq/contents/{+path}","compare_url":"https://api.github.com/repos/yglukhov/gitlabhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yglukhov/gitlabhq/merges","archive_url":"https://api.github.com/repos/yglukhov/gitlabhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yglukhov/gitlabhq/downloads","issues_url":"https://api.github.com/repos/yglukhov/gitlabhq/issues{/number}","pulls_url":"https://api.github.com/repos/yglukhov/gitlabhq/pulls{/number}","milestones_url":"https://api.github.com/repos/yglukhov/gitlabhq/milestones{/number}","notifications_url":"https://api.github.com/repos/yglukhov/gitlabhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yglukhov/gitlabhq/labels{/name}","releases_url":"https://api.github.com/repos/yglukhov/gitlabhq/releases{/id}","created_at":"2014-08-13T10:47:28Z","updated_at":"2014-08-13T11:04:14Z","pushed_at":"2014-09-15T13:44:16Z","git_url":"git://github.com/yglukhov/gitlabhq.git","ssh_url":"git@github.com:yglukhov/gitlabhq.git","clone_url":"https://github.com/yglukhov/gitlabhq.git","svn_url":"https://github.com/yglukhov/gitlabhq","homepage":"https://about.gitlab.com/","size":82291,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitlabhq:master","ref":"master","sha":"09b23228dfa2242e4123e10091f8a0194ecdc3de","user":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=2","gravatar_id":"95b7f387358639ec09184a76151bc690","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"repo":{"id":2500088,"name":"gitlabhq","full_name":"gitlabhq/gitlabhq","owner":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=2","gravatar_id":"95b7f387358639ec09184a76151bc690","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitlabhq/gitlabhq","description":"Open source software to collaborate on code. Follow us on twitter @gitlabhq","fork":false,"url":"https://api.github.com/repos/gitlabhq/gitlabhq","forks_url":"https://api.github.com/repos/gitlabhq/gitlabhq/forks","keys_url":"https://api.github.com/repos/gitlabhq/gitlabhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitlabhq/gitlabhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitlabhq/gitlabhq/teams","hooks_url":"https://api.github.com/repos/gitlabhq/gitlabhq/hooks","issue_events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/events{/number}","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/events","assignees_url":"https://api.github.com/repos/gitlabhq/gitlabhq/assignees{/user}","branches_url":"https://api.github.com/repos/gitlabhq/gitlabhq/branches{/branch}","tags_url":"https://api.github.com/repos/gitlabhq/gitlabhq/tags","blobs_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/{sha}","languages_url":"https://api.github.com/repos/gitlabhq/gitlabhq/languages","stargazers_url":"https://api.github.com/repos/gitlabhq/gitlabhq/stargazers","contributors_url":"https://api.github.com/repos/gitlabhq/gitlabhq/contributors","subscribers_url":"https://api.github.com/repos/gitlabhq/gitlabhq/subscribers","subscription_url":"https://api.github.com/repos/gitlabhq/gitlabhq/subscription","commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/gitlabhq/gitlabhq/contents/{+path}","compare_url":"https://api.github.com/repos/gitlabhq/gitlabhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitlabhq/gitlabhq/merges","archive_url":"https://api.github.com/repos/gitlabhq/gitlabhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitlabhq/gitlabhq/downloads","issues_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues{/number}","pulls_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls{/number}","milestones_url":"https://api.github.com/repos/gitlabhq/gitlabhq/milestones{/number}","notifications_url":"https://api.github.com/repos/gitlabhq/gitlabhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/labels{/name}","releases_url":"https://api.github.com/repos/gitlabhq/gitlabhq/releases{/id}","created_at":"2011-10-02T16:25:27Z","updated_at":"2014-09-15T12:48:46Z","pushed_at":"2014-09-15T07:21:03Z","git_url":"git://github.com/gitlabhq/gitlabhq.git","ssh_url":"git@github.com:gitlabhq/gitlabhq.git","clone_url":"https://github.com/gitlabhq/gitlabhq.git","svn_url":"https://github.com/gitlabhq/gitlabhq","homepage":"https://about.gitlab.com/","size":147325,"stargazers_count":13886,"watchers_count":13886,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3605,"mirror_url":null,"open_issues_count":533,"forks":3605,"open_issues":533,"watchers":13886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7675"},"html":{"href":"https://github.com/gitlabhq/gitlabhq/pull/7675"},"issue":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7675"},"comments":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7675/comments"},"review_comments":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7675/comments"},"review_comment":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7675/commits"},"statuses":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/e076c88d3487e05ac102d3a8bd28451de85daafe"}}}}