GitHub PullRequestReviewCommentEvent at 2014-10-14 23:03:16
Repository: plottable
Actor: danmane
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/palantir/plottable/pulls/comments/18865372","id":18865372,"diff_hunk":"@@ -0,0 +1,43 @@\n+///<reference path=\"../reference.ts\" />\n+\n+module Plottable {\n+export module TickGenerators {\n+  /**\n+   * Creates a tick generator using the specified interval.\n+   *\n+   * Generates ticks at multiples of the interval while also including the domain boundaries.\n+   *\n+   * @param {number} interval The interval between two ticks (not including the end ticks).\n+   *\n+   * @returns {TickGenerator} A tick generator using the specified interval.\n+   */\n+  export function intervalTickGenerator(interval: number) : Scale.TickGenerator<number> {\n+    if(interval <= 0) {\n+       throw new Error(\"interval must be positive number\");\n+    }","path":"src/utils/tickGenerators.ts","position":17,"original_position":17,"commit_id":"4d403e10fb0df1536e2a39c30a37a1581a6e092c","original_commit_id":"4d403e10fb0df1536e2a39c30a37a1581a6e092c","user":{"login":"danmane","id":1400023,"avatar_url":"https://avatars.githubusercontent.com/u/1400023?v=2","gravatar_id":"","url":"https://api.github.com/users/danmane","html_url":"https://github.com/danmane","followers_url":"https://api.github.com/users/danmane/followers","following_url":"https://api.github.com/users/danmane/following{/other_user}","gists_url":"https://api.github.com/users/danmane/gists{/gist_id}","starred_url":"https://api.github.com/users/danmane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmane/subscriptions","organizations_url":"https://api.github.com/users/danmane/orgs","repos_url":"https://api.github.com/users/danmane/repos","events_url":"https://api.github.com/users/danmane/events{/privacy}","received_events_url":"https://api.github.com/users/danmane/received_events","type":"User","site_admin":false},"body":"cool, except teh whitespace is wrong `if (interval` not `if(interval`... i feel like tslint should have caught this, hmm","created_at":"2014-10-14T23:03:16Z","updated_at":"2014-10-14T23:03:16Z","html_url":"https://github.com/palantir/plottable/pull/1173#discussion_r18865372","pull_request_url":"https://api.github.com/repos/palantir/plottable/pulls/1173","_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/18865372"},"html":{"href":"https://github.com/palantir/plottable/pull/1173#discussion_r18865372"},"pull_request":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1173"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/1173","id":22398051,"html_url":"https://github.com/palantir/plottable/pull/1173","diff_url":"https://github.com/palantir/plottable/pull/1173.diff","patch_url":"https://github.com/palantir/plottable/pull/1173.patch","issue_url":"https://api.github.com/repos/palantir/plottable/issues/1173","number":1173,"state":"open","locked":false,"title":"Tick generator using interval.","user":{"login":"endrjuskr","id":2611549,"avatar_url":"https://avatars.githubusercontent.com/u/2611549?v=2","gravatar_id":"","url":"https://api.github.com/users/endrjuskr","html_url":"https://github.com/endrjuskr","followers_url":"https://api.github.com/users/endrjuskr/followers","following_url":"https://api.github.com/users/endrjuskr/following{/other_user}","gists_url":"https://api.github.com/users/endrjuskr/gists{/gist_id}","starred_url":"https://api.github.com/users/endrjuskr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endrjuskr/subscriptions","organizations_url":"https://api.github.com/users/endrjuskr/orgs","repos_url":"https://api.github.com/users/endrjuskr/repos","events_url":"https://api.github.com/users/endrjuskr/events{/privacy}","received_events_url":"https://api.github.com/users/endrjuskr/received_events","type":"User","site_admin":false},"body":"Close #1166.","created_at":"2014-10-08T02:56:17Z","updated_at":"2014-10-14T23:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dd8ca3d1c63aa040e4f1750734849aada736ad6","assignee":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=2","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/palantir/plottable/pulls/1173/commits","review_comments_url":"https://api.github.com/repos/palantir/plottable/pulls/1173/comments","review_comment_url":"https://api.github.com/repos/palantir/plottable/pulls/comments/{number}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/1173/comments","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/4d403e10fb0df1536e2a39c30a37a1581a6e092c","head":{"label":"palantir:interval_tick_gen","ref":"interval_tick_gen","sha":"4d403e10fb0df1536e2a39c30a37a1581a6e092c","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=2","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=2","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library of modular chart components, built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2014-10-13T17:01:21Z","pushed_at":"2014-10-14T23:00:39Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"plottablejs.org","size":55995,"stargazers_count":129,"watchers_count":129,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":150,"forks":21,"open_issues":150,"watchers":129,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"8b797a20e59b8a38e322711d06bd370e82df453c","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=2","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=2","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library of modular chart components, built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2014-10-13T17:01:21Z","pushed_at":"2014-10-14T23:00:39Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"plottablejs.org","size":55995,"stargazers_count":129,"watchers_count":129,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":150,"forks":21,"open_issues":150,"watchers":129,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1173"},"html":{"href":"https://github.com/palantir/plottable/pull/1173"},"issue":{"href":"https://api.github.com/repos/palantir/plottable/issues/1173"},"comments":{"href":"https://api.github.com/repos/palantir/plottable/issues/1173/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1173/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1173/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/plottable/statuses/4d403e10fb0df1536e2a39c30a37a1581a6e092c"}}}}