GitHub PullRequestReviewCommentEvent at 2014-08-18 16:57:38
Repository: image
Actor: Achal-Aggarwal
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/joomla-framework/image/pulls/comments/16366245","id":16366245,"diff_hunk":"@@ -896,11 +896,10 @@ public function toFile($path, $type = IMAGETYPE_JPEG, array $options = array())\n \t\t\tcase IMAGETYPE_PNG:\n \t\t\t\treturn imagepng($this->handle, $path, (array_key_exists('quality', $options)) ? $options['quality'] : 0);\n \t\t\t\tbreak;\n-\n-\t\t\tcase IMAGETYPE_JPEG:\n-\t\t\tdefault:\n-\t\t\t\treturn imagejpeg($this->handle, $path, (array_key_exists('quality', $options)) ? $options['quality'] : 100);\n \t\t}\n+\n+\t\t// Case IMAGETYPE_JPEG & default","path":"src/Image.php","position":19,"original_position":19,"commit_id":"a23d923c151f50cb2fe18ac2f1a0408a482be409","original_commit_id":"a23d923c151f50cb2fe18ac2f1a0408a482be409","user":{"login":"Achal-Aggarwal","id":3330262,"avatar_url":"https://avatars.githubusercontent.com/u/3330262?v=2","gravatar_id":"b69389c6bf157742b308f6ce98446fd9","url":"https://api.github.com/users/Achal-Aggarwal","html_url":"https://github.com/Achal-Aggarwal","followers_url":"https://api.github.com/users/Achal-Aggarwal/followers","following_url":"https://api.github.com/users/Achal-Aggarwal/following{/other_user}","gists_url":"https://api.github.com/users/Achal-Aggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/Achal-Aggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Achal-Aggarwal/subscriptions","organizations_url":"https://api.github.com/users/Achal-Aggarwal/orgs","repos_url":"https://api.github.com/users/Achal-Aggarwal/repos","events_url":"https://api.github.com/users/Achal-Aggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/Achal-Aggarwal/received_events","type":"User","site_admin":false},"body":"Nice :)\r\n\r\n\r\nOn Mon, Aug 18, 2014 at 10:26 PM, Michael Babker <notifications@github.com>\r\nwrote:\r\n\r\n> In src/Image.php:\r\n>\r\n> >  \t\t}\r\n> > +\r\n> > +\t\t// Case IMAGETYPE_JPEG & default\r\n>\r\n> No issue to me, just curious is all.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/joomla-framework/image/pull/8/files#r16366178>.\r\n>\r\n\r\n\r\n\r\n-- \r\nAchal","created_at":"2014-08-18T16:57:38Z","updated_at":"2014-08-18T16:57:38Z","html_url":"https://github.com/joomla-framework/image/pull/8#discussion_r16366245","pull_request_url":"https://api.github.com/repos/joomla-framework/image/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/joomla-framework/image/pulls/comments/16366245"},"html":{"href":"https://github.com/joomla-framework/image/pull/8#discussion_r16366245"},"pull_request":{"href":"https://api.github.com/repos/joomla-framework/image/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/joomla-framework/image/pulls/8","id":19467331,"html_url":"https://github.com/joomla-framework/image/pull/8","diff_url":"https://github.com/joomla-framework/image/pull/8.diff","patch_url":"https://github.com/joomla-framework/image/pull/8.patch","issue_url":"https://api.github.com/repos/joomla-framework/image/issues/8","number":8,"state":"open","locked":false,"title":"Adds some tests.","user":{"login":"Achal-Aggarwal","id":3330262,"avatar_url":"https://avatars.githubusercontent.com/u/3330262?v=2","gravatar_id":"b69389c6bf157742b308f6ce98446fd9","url":"https://api.github.com/users/Achal-Aggarwal","html_url":"https://github.com/Achal-Aggarwal","followers_url":"https://api.github.com/users/Achal-Aggarwal/followers","following_url":"https://api.github.com/users/Achal-Aggarwal/following{/other_user}","gists_url":"https://api.github.com/users/Achal-Aggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/Achal-Aggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Achal-Aggarwal/subscriptions","organizations_url":"https://api.github.com/users/Achal-Aggarwal/orgs","repos_url":"https://api.github.com/users/Achal-Aggarwal/repos","events_url":"https://api.github.com/users/Achal-Aggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/Achal-Aggarwal/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-07T13:43:49Z","updated_at":"2014-08-18T16:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a19a4a56ed6fa4876a6cc2f9c3590a6e135fe51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla-framework/image/pulls/8/commits","review_comments_url":"https://api.github.com/repos/joomla-framework/image/pulls/8/comments","review_comment_url":"https://api.github.com/repos/joomla-framework/image/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joomla-framework/image/issues/8/comments","statuses_url":"https://api.github.com/repos/joomla-framework/image/statuses/a23d923c151f50cb2fe18ac2f1a0408a482be409","head":{"label":"Achal-Aggarwal:unit-tests","ref":"unit-tests","sha":"a23d923c151f50cb2fe18ac2f1a0408a482be409","user":{"login":"Achal-Aggarwal","id":3330262,"avatar_url":"https://avatars.githubusercontent.com/u/3330262?v=2","gravatar_id":"b69389c6bf157742b308f6ce98446fd9","url":"https://api.github.com/users/Achal-Aggarwal","html_url":"https://github.com/Achal-Aggarwal","followers_url":"https://api.github.com/users/Achal-Aggarwal/followers","following_url":"https://api.github.com/users/Achal-Aggarwal/following{/other_user}","gists_url":"https://api.github.com/users/Achal-Aggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/Achal-Aggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Achal-Aggarwal/subscriptions","organizations_url":"https://api.github.com/users/Achal-Aggarwal/orgs","repos_url":"https://api.github.com/users/Achal-Aggarwal/repos","events_url":"https://api.github.com/users/Achal-Aggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/Achal-Aggarwal/received_events","type":"User","site_admin":false},"repo":{"id":19250403,"name":"image","full_name":"Achal-Aggarwal/image","owner":{"login":"Achal-Aggarwal","id":3330262,"avatar_url":"https://avatars.githubusercontent.com/u/3330262?v=2","gravatar_id":"b69389c6bf157742b308f6ce98446fd9","url":"https://api.github.com/users/Achal-Aggarwal","html_url":"https://github.com/Achal-Aggarwal","followers_url":"https://api.github.com/users/Achal-Aggarwal/followers","following_url":"https://api.github.com/users/Achal-Aggarwal/following{/other_user}","gists_url":"https://api.github.com/users/Achal-Aggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/Achal-Aggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Achal-Aggarwal/subscriptions","organizations_url":"https://api.github.com/users/Achal-Aggarwal/orgs","repos_url":"https://api.github.com/users/Achal-Aggarwal/repos","events_url":"https://api.github.com/users/Achal-Aggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/Achal-Aggarwal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Achal-Aggarwal/image","description":"Joomla Framework Image Package","fork":true,"url":"https://api.github.com/repos/Achal-Aggarwal/image","forks_url":"https://api.github.com/repos/Achal-Aggarwal/image/forks","keys_url":"https://api.github.com/repos/Achal-Aggarwal/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Achal-Aggarwal/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Achal-Aggarwal/image/teams","hooks_url":"https://api.github.com/repos/Achal-Aggarwal/image/hooks","issue_events_url":"https://api.github.com/repos/Achal-Aggarwal/image/issues/events{/number}","events_url":"https://api.github.com/repos/Achal-Aggarwal/image/events","assignees_url":"https://api.github.com/repos/Achal-Aggarwal/image/assignees{/user}","branches_url":"https://api.github.com/repos/Achal-Aggarwal/image/branches{/branch}","tags_url":"https://api.github.com/repos/Achal-Aggarwal/image/tags","blobs_url":"https://api.github.com/repos/Achal-Aggarwal/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Achal-Aggarwal/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Achal-Aggarwal/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/Achal-Aggarwal/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Achal-Aggarwal/image/statuses/{sha}","languages_url":"https://api.github.com/repos/Achal-Aggarwal/image/languages","stargazers_url":"https://api.github.com/repos/Achal-Aggarwal/image/stargazers","contributors_url":"https://api.github.com/repos/Achal-Aggarwal/image/contributors","subscribers_url":"https://api.github.com/repos/Achal-Aggarwal/image/subscribers","subscription_url":"https://api.github.com/repos/Achal-Aggarwal/image/subscription","commits_url":"https://api.github.com/repos/Achal-Aggarwal/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/Achal-Aggarwal/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/Achal-Aggarwal/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/Achal-Aggarwal/image/issues/comments/{number}","contents_url":"https://api.github.com/repos/Achal-Aggarwal/image/contents/{+path}","compare_url":"https://api.github.com/repos/Achal-Aggarwal/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Achal-Aggarwal/image/merges","archive_url":"https://api.github.com/repos/Achal-Aggarwal/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Achal-Aggarwal/image/downloads","issues_url":"https://api.github.com/repos/Achal-Aggarwal/image/issues{/number}","pulls_url":"https://api.github.com/repos/Achal-Aggarwal/image/pulls{/number}","milestones_url":"https://api.github.com/repos/Achal-Aggarwal/image/milestones{/number}","notifications_url":"https://api.github.com/repos/Achal-Aggarwal/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Achal-Aggarwal/image/labels{/name}","releases_url":"https://api.github.com/repos/Achal-Aggarwal/image/releases{/id}","created_at":"2014-04-28T19:05:46Z","updated_at":"2014-07-14T13:27:19Z","pushed_at":"2014-08-07T13:43:06Z","git_url":"git://github.com/Achal-Aggarwal/image.git","ssh_url":"git@github.com:Achal-Aggarwal/image.git","clone_url":"https://github.com/Achal-Aggarwal/image.git","svn_url":"https://github.com/Achal-Aggarwal/image","homepage":"","size":945,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joomla-framework:master","ref":"master","sha":"3b6d0a35aadecaf66a7d3418866441286e3d0372","user":{"login":"joomla-framework","id":6124926,"avatar_url":"https://avatars.githubusercontent.com/u/6124926?v=2","gravatar_id":"da48bef30611e1bdac3f707bdddb99a8","url":"https://api.github.com/users/joomla-framework","html_url":"https://github.com/joomla-framework","followers_url":"https://api.github.com/users/joomla-framework/followers","following_url":"https://api.github.com/users/joomla-framework/following{/other_user}","gists_url":"https://api.github.com/users/joomla-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-framework/subscriptions","organizations_url":"https://api.github.com/users/joomla-framework/orgs","repos_url":"https://api.github.com/users/joomla-framework/repos","events_url":"https://api.github.com/users/joomla-framework/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":8385804,"name":"image","full_name":"joomla-framework/image","owner":{"login":"joomla-framework","id":6124926,"avatar_url":"https://avatars.githubusercontent.com/u/6124926?v=2","gravatar_id":"da48bef30611e1bdac3f707bdddb99a8","url":"https://api.github.com/users/joomla-framework","html_url":"https://github.com/joomla-framework","followers_url":"https://api.github.com/users/joomla-framework/followers","following_url":"https://api.github.com/users/joomla-framework/following{/other_user}","gists_url":"https://api.github.com/users/joomla-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-framework/subscriptions","organizations_url":"https://api.github.com/users/joomla-framework/orgs","repos_url":"https://api.github.com/users/joomla-framework/repos","events_url":"https://api.github.com/users/joomla-framework/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla-framework/image","description":"Joomla Framework Image Package","fork":false,"url":"https://api.github.com/repos/joomla-framework/image","forks_url":"https://api.github.com/repos/joomla-framework/image/forks","keys_url":"https://api.github.com/repos/joomla-framework/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla-framework/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla-framework/image/teams","hooks_url":"https://api.github.com/repos/joomla-framework/image/hooks","issue_events_url":"https://api.github.com/repos/joomla-framework/image/issues/events{/number}","events_url":"https://api.github.com/repos/joomla-framework/image/events","assignees_url":"https://api.github.com/repos/joomla-framework/image/assignees{/user}","branches_url":"https://api.github.com/repos/joomla-framework/image/branches{/branch}","tags_url":"https://api.github.com/repos/joomla-framework/image/tags","blobs_url":"https://api.github.com/repos/joomla-framework/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla-framework/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla-framework/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla-framework/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla-framework/image/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla-framework/image/languages","stargazers_url":"https://api.github.com/repos/joomla-framework/image/stargazers","contributors_url":"https://api.github.com/repos/joomla-framework/image/contributors","subscribers_url":"https://api.github.com/repos/joomla-framework/image/subscribers","subscription_url":"https://api.github.com/repos/joomla-framework/image/subscription","commits_url":"https://api.github.com/repos/joomla-framework/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla-framework/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla-framework/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla-framework/image/issues/comments/{number}","contents_url":"https://api.github.com/repos/joomla-framework/image/contents/{+path}","compare_url":"https://api.github.com/repos/joomla-framework/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla-framework/image/merges","archive_url":"https://api.github.com/repos/joomla-framework/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla-framework/image/downloads","issues_url":"https://api.github.com/repos/joomla-framework/image/issues{/number}","pulls_url":"https://api.github.com/repos/joomla-framework/image/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla-framework/image/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla-framework/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla-framework/image/labels{/name}","releases_url":"https://api.github.com/repos/joomla-framework/image/releases{/id}","created_at":"2013-02-24T03:23:27Z","updated_at":"2014-06-27T14:27:42Z","pushed_at":"2014-08-03T18:31:57Z","git_url":"git://github.com/joomla-framework/image.git","ssh_url":"git@github.com:joomla-framework/image.git","clone_url":"https://github.com/joomla-framework/image.git","svn_url":"https://github.com/joomla-framework/image","homepage":"","size":1136,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla-framework/image/pulls/8"},"html":{"href":"https://github.com/joomla-framework/image/pull/8"},"issue":{"href":"https://api.github.com/repos/joomla-framework/image/issues/8"},"comments":{"href":"https://api.github.com/repos/joomla-framework/image/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla-framework/image/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla-framework/image/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joomla-framework/image/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/joomla-framework/image/statuses/a23d923c151f50cb2fe18ac2f1a0408a482be409"}}}}