GitHub PullRequestReviewCommentEvent at 2014-10-04 21:12:47
Repository: homebrew
Actor: tdsmith
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/18431710","id":18431710,"diff_hunk":"@@ -2,19 +2,23 @@\n \n class BashGitPrompt < Formula\n   homepage \"https://github.com/magicmonty/bash-git-prompt\"\n-  url \"https://github.com/magicmonty/bash-git-prompt/archive/2.1.tar.gz\"\n-  sha1 \"9bd29dc2aa4859d2f4c0736cb26cc177de9c1274\"\n+  url \"https://github.com/magicmonty/bash-git-prompt/archive/2.2.tar.gz\"\n+  sha1 \"392d430b87639e7f85fde02f2b4a37cb43be9aaf\"\n   head \"https://github.com/magicmonty/bash-git-prompt.git\"\n \n   def install\n     share.install \"./gitprompt.sh\", \"./gitprompt.fish\", \"./git-prompt-help.sh\",\n-                  \"./git-prompt-colors.sh\", \"gitstatus.sh\", \"prompt-colors.sh\"\n+                  \"gitstatus.sh\", \"prompt-colors.sh\"\n+\n+    (share/'themes').install Dir[\"themes/*.bgptheme\"]","path":"Library/Formula/bash-git-prompt.rb","position":15,"original_position":15,"commit_id":"69a03fa4c56031f849a0a47da4420c662795857b","original_commit_id":"69a03fa4c56031f849a0a47da4420c662795857b","user":{"login":"tdsmith","id":173889,"avatar_url":"https://avatars.githubusercontent.com/u/173889?v=2","gravatar_id":"","url":"https://api.github.com/users/tdsmith","html_url":"https://github.com/tdsmith","followers_url":"https://api.github.com/users/tdsmith/followers","following_url":"https://api.github.com/users/tdsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdsmith/subscriptions","organizations_url":"https://api.github.com/users/tdsmith/orgs","repos_url":"https://api.github.com/users/tdsmith/repos","events_url":"https://api.github.com/users/tdsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdsmith/received_events","type":"User","site_admin":false},"body":"Style nit: can you use double quotes instead of ' here? We follow the [Github Ruby style guide](https://github.com/styleguide/ruby).","created_at":"2014-10-04T21:12:47Z","updated_at":"2014-10-04T21:12:47Z","html_url":"https://github.com/Homebrew/homebrew/pull/32934#discussion_r18431710","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/32934","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/18431710"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/32934#discussion_r18431710"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/32934"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/32934","id":22247553,"html_url":"https://github.com/Homebrew/homebrew/pull/32934","diff_url":"https://github.com/Homebrew/homebrew/pull/32934.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/32934.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/32934","number":32934,"state":"open","locked":false,"title":"Updated bash-git-prompt to Version 2.2","user":{"login":"magicmonty","id":315639,"avatar_url":"https://avatars.githubusercontent.com/u/315639?v=2","gravatar_id":"","url":"https://api.github.com/users/magicmonty","html_url":"https://github.com/magicmonty","followers_url":"https://api.github.com/users/magicmonty/followers","following_url":"https://api.github.com/users/magicmonty/following{/other_user}","gists_url":"https://api.github.com/users/magicmonty/gists{/gist_id}","starred_url":"https://api.github.com/users/magicmonty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicmonty/subscriptions","organizations_url":"https://api.github.com/users/magicmonty/orgs","repos_url":"https://api.github.com/users/magicmonty/repos","events_url":"https://api.github.com/users/magicmonty/events{/privacy}","received_events_url":"https://api.github.com/users/magicmonty/received_events","type":"User","site_admin":false},"body":"New version with themes support","created_at":"2014-10-04T20:16:14Z","updated_at":"2014-10-04T21:12:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"222971049ca86f78cdb85bd8bf75753510317974","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/32934/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/32934/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/32934/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/69a03fa4c56031f849a0a47da4420c662795857b","head":{"label":"magicmonty:bash-git-prompt","ref":"bash-git-prompt","sha":"69a03fa4c56031f849a0a47da4420c662795857b","user":{"login":"magicmonty","id":315639,"avatar_url":"https://avatars.githubusercontent.com/u/315639?v=2","gravatar_id":"","url":"https://api.github.com/users/magicmonty","html_url":"https://github.com/magicmonty","followers_url":"https://api.github.com/users/magicmonty/followers","following_url":"https://api.github.com/users/magicmonty/following{/other_user}","gists_url":"https://api.github.com/users/magicmonty/gists{/gist_id}","starred_url":"https://api.github.com/users/magicmonty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicmonty/subscriptions","organizations_url":"https://api.github.com/users/magicmonty/orgs","repos_url":"https://api.github.com/users/magicmonty/repos","events_url":"https://api.github.com/users/magicmonty/events{/privacy}","received_events_url":"https://api.github.com/users/magicmonty/received_events","type":"User","site_admin":false},"repo":{"id":23461739,"name":"homebrew","full_name":"magicmonty/homebrew","owner":{"login":"magicmonty","id":315639,"avatar_url":"https://avatars.githubusercontent.com/u/315639?v=2","gravatar_id":"","url":"https://api.github.com/users/magicmonty","html_url":"https://github.com/magicmonty","followers_url":"https://api.github.com/users/magicmonty/followers","following_url":"https://api.github.com/users/magicmonty/following{/other_user}","gists_url":"https://api.github.com/users/magicmonty/gists{/gist_id}","starred_url":"https://api.github.com/users/magicmonty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicmonty/subscriptions","organizations_url":"https://api.github.com/users/magicmonty/orgs","repos_url":"https://api.github.com/users/magicmonty/repos","events_url":"https://api.github.com/users/magicmonty/events{/privacy}","received_events_url":"https://api.github.com/users/magicmonty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magicmonty/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/magicmonty/homebrew","forks_url":"https://api.github.com/repos/magicmonty/homebrew/forks","keys_url":"https://api.github.com/repos/magicmonty/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magicmonty/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magicmonty/homebrew/teams","hooks_url":"https://api.github.com/repos/magicmonty/homebrew/hooks","issue_events_url":"https://api.github.com/repos/magicmonty/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/magicmonty/homebrew/events","assignees_url":"https://api.github.com/repos/magicmonty/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/magicmonty/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/magicmonty/homebrew/tags","blobs_url":"https://api.github.com/repos/magicmonty/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magicmonty/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magicmonty/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/magicmonty/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magicmonty/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/magicmonty/homebrew/languages","stargazers_url":"https://api.github.com/repos/magicmonty/homebrew/stargazers","contributors_url":"https://api.github.com/repos/magicmonty/homebrew/contributors","subscribers_url":"https://api.github.com/repos/magicmonty/homebrew/subscribers","subscription_url":"https://api.github.com/repos/magicmonty/homebrew/subscription","commits_url":"https://api.github.com/repos/magicmonty/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/magicmonty/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/magicmonty/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/magicmonty/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/magicmonty/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/magicmonty/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magicmonty/homebrew/merges","archive_url":"https://api.github.com/repos/magicmonty/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magicmonty/homebrew/downloads","issues_url":"https://api.github.com/repos/magicmonty/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/magicmonty/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/magicmonty/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/magicmonty/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magicmonty/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/magicmonty/homebrew/releases{/id}","created_at":"2014-08-29T11:18:28Z","updated_at":"2014-08-29T10:38:09Z","pushed_at":"2014-10-04T20:15:36Z","git_url":"git://github.com/magicmonty/homebrew.git","ssh_url":"git@github.com:magicmonty/homebrew.git","clone_url":"https://github.com/magicmonty/homebrew.git","svn_url":"https://github.com/magicmonty/homebrew","homepage":"http://brew.sh","size":41599,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"aa63ffe8dae7d549b428003f6e2e1275f277146d","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=2","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=2","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2014-10-04T19:15:44Z","pushed_at":"2014-10-04T21:06:21Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1220552,"stargazers_count":19350,"watchers_count":19350,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":9622,"mirror_url":null,"open_issues_count":212,"forks":9622,"open_issues":212,"watchers":19350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/32934"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/32934"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/32934"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/32934/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/32934/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/32934/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/69a03fa4c56031f849a0a47da4420c662795857b"}}}}