GitHub PullRequestReviewCommentEvent at 2014-07-21 06:00:01
Repository: frontend
Actor: gklopper
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/15155778","id":15155778,"diff_hunk":"@@ -34,10 +41,19 @@ object Frontend extends Build with Prototypes {\n \n       \"org.xerial.snappy\" % \"snappy-java\" % \"1.0.5.1\",\n \n-      filters\n+      filters,\n+      ws\n     )\n+  ).settings(\n+      mappings in TestAssets ~= filterAssets\n   )\n-  val paVersion = \"5.0.0\"\n+\n+  private def filterAssets(testAssets: Seq[(File, String)]) = testAssets.filterNot{ case (file, fileName) =>\n+    // built in sbt plugins did not like the bower files\n+    fileName.endsWith(\"bower.json\")\n+  }\n+\n+  val paVersion = \"5.0.1-NG\"","path":"project/Frontend.scala","position":45,"original_position":45,"commit_id":"8ac1fbe6da5aa690631e089d696262585076dddf","original_commit_id":"8ac1fbe6da5aa690631e089d696262585076dddf","user":{"login":"gklopper","id":76709,"avatar_url":"https://avatars.githubusercontent.com/u/76709?","gravatar_id":"312bababa25300e6d8bb79423a6be986","url":"https://api.github.com/users/gklopper","html_url":"https://github.com/gklopper","followers_url":"https://api.github.com/users/gklopper/followers","following_url":"https://api.github.com/users/gklopper/following{/other_user}","gists_url":"https://api.github.com/users/gklopper/gists{/gist_id}","starred_url":"https://api.github.com/users/gklopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gklopper/subscriptions","organizations_url":"https://api.github.com/users/gklopper/orgs","repos_url":"https://api.github.com/users/gklopper/repos","events_url":"https://api.github.com/users/gklopper/events{/privacy}","received_events_url":"https://api.github.com/users/gklopper/received_events","type":"User","site_admin":false},"body":"Published our own version of this, it is no different to the \"actual\" version, except I do not have deploy keys for the maven repo, so popped it in our own repo. We can simply update the number here once it is out the door.","created_at":"2014-07-21T06:00:01Z","updated_at":"2014-07-21T06:00:01Z","html_url":"https://github.com/guardian/frontend/pull/5128#discussion_r15155778","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/5128","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/15155778"},"html":{"href":"https://github.com/guardian/frontend/pull/5128#discussion_r15155778"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5128"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/5128","id":18630612,"html_url":"https://github.com/guardian/frontend/pull/5128","diff_url":"https://github.com/guardian/frontend/pull/5128.diff","patch_url":"https://github.com/guardian/frontend/pull/5128.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/5128","number":5128,"state":"open","title":"Converted project to Play 2.3.2","user":{"login":"gklopper","id":76709,"avatar_url":"https://avatars.githubusercontent.com/u/76709?","gravatar_id":"312bababa25300e6d8bb79423a6be986","url":"https://api.github.com/users/gklopper","html_url":"https://github.com/gklopper","followers_url":"https://api.github.com/users/gklopper/followers","following_url":"https://api.github.com/users/gklopper/following{/other_user}","gists_url":"https://api.github.com/users/gklopper/gists{/gist_id}","starred_url":"https://api.github.com/users/gklopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gklopper/subscriptions","organizations_url":"https://api.github.com/users/gklopper/orgs","repos_url":"https://api.github.com/users/gklopper/repos","events_url":"https://api.github.com/users/gklopper/events{/privacy}","received_events_url":"https://api.github.com/users/gklopper/received_events","type":"User","site_admin":false},"body":"~~Going with a release candidate due to a [bug](https://github.com/playframework/playframework/pull/3073)~~ (Play released 2.3.2 with perfect timing...)\r\n\r\nRead the [changelog](http://www.playframework.com/changelog)\r\n\r\nLots of changes, mostly around...\r\n\r\n`SimpleResult` now becomes `Result`\r\n\r\n`Response` now becomes `WSResponse`\r\n\r\nThe `WebServices` api is split into its own project and now needs an `ExecutionContext`\r\n\r\nThe newer version of Joda Time has deprecated `DateMidnight` which we used a lot and replaced it with `LocalDate`\r\n\r\nChanges to `Agent` e.g. there is no longer a `Agent.close()` method\r\n\r\nTwirl is now its own project, so `Html` needs different imports\r\n\r\nEnjoy the long pull request","created_at":"2014-07-20T15:30:24Z","updated_at":"2014-07-21T06:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3aa2ba36626b6f26c44f412106a43578cae82c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/5128/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/5128/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/5128/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/8ac1fbe6da5aa690631e089d696262585076dddf","head":{"label":"guardian:play-2.3.0","ref":"play-2.3.0","sha":"8ac1fbe6da5aa690631e089d696262585076dddf","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-07-21T00:16:08Z","pushed_at":"2014-07-21T05:48:51Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":397637,"stargazers_count":2158,"watchers_count":2158,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":180,"mirror_url":null,"open_issues_count":52,"forks":180,"open_issues":52,"watchers":2158,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"1133e6f5725dd341974cf0412fc497906071950b","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-07-21T00:16:08Z","pushed_at":"2014-07-21T05:48:51Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":397637,"stargazers_count":2158,"watchers_count":2158,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":180,"mirror_url":null,"open_issues_count":52,"forks":180,"open_issues":52,"watchers":2158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5128"},"html":{"href":"https://github.com/guardian/frontend/pull/5128"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/5128"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/5128/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5128/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5128/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/8ac1fbe6da5aa690631e089d696262585076dddf"}}}}