GitHub PullRequestReviewCommentEvent at 2014-07-21 20:59:44
Repository: EntityFramework
Actor: ajcvickers
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/15196017","id":15196017,"diff_hunk":"@@ -13,12 +13,15 @@ public class DefaultModelSource : IModelSource\n         private readonly ThreadSafeDictionaryCache<Type, IModel> _models = new ThreadSafeDictionaryCache<Type, IModel>();\n \n         private readonly DbSetFinder _setFinder;\n+        private readonly ModelBuilderSelector _modelBuilderSelector;\n \n-        public DefaultModelSource([NotNull] DbSetFinder setFinder)\n+        public DefaultModelSource([NotNull] DbSetFinder setFinder, [NotNull] ModelBuilderSelector modelBuilderSelector)","path":"src/EntityFramework/Infrastructure/DefaultModelSource.cs","position":7,"original_position":7,"commit_id":"33205c84238381eede1f6dc63a8dd9720bf38618","original_commit_id":"33205c84238381eede1f6dc63a8dd9720bf38618","user":{"login":"ajcvickers","id":1430078,"avatar_url":"https://avatars.githubusercontent.com/u/1430078?","gravatar_id":"312a748a245808ac851b3b7f346a90ce","url":"https://api.github.com/users/ajcvickers","html_url":"https://github.com/ajcvickers","followers_url":"https://api.github.com/users/ajcvickers/followers","following_url":"https://api.github.com/users/ajcvickers/following{/other_user}","gists_url":"https://api.github.com/users/ajcvickers/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcvickers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcvickers/subscriptions","organizations_url":"https://api.github.com/users/ajcvickers/orgs","repos_url":"https://api.github.com/users/ajcvickers/repos","events_url":"https://api.github.com/users/ajcvickers/events{/privacy}","received_events_url":"https://api.github.com/users/ajcvickers/received_events","type":"User","site_admin":false},"body":"What will this resolve to in cases where multiple ModelBuilderSelector classes are registered?","created_at":"2014-07-21T20:59:44Z","updated_at":"2014-07-21T20:59:44Z","html_url":"https://github.com/aspnet/EntityFramework/pull/438#discussion_r15196017","pull_request_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/438","_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/15196017"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/438#discussion_r15196017"},"pull_request":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/438","id":18564182,"html_url":"https://github.com/aspnet/EntityFramework/pull/438","diff_url":"https://github.com/aspnet/EntityFramework/pull/438.diff","patch_url":"https://github.com/aspnet/EntityFramework/pull/438.patch","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/438","number":438,"state":"open","title":"Convention over convention: enabling provider conventions","user":{"login":"natemcmaster","id":2696087,"avatar_url":"https://avatars.githubusercontent.com/u/2696087?","gravatar_id":"692c58f37a3704944bd31c4cbcb287e7","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"body":"Enable provider-specific conventions by allowing override of ConventionModelBuilder.\r\nAdd ModelBuilderSelector so that the convention model builder used can be determined by DI.","created_at":"2014-07-18T01:31:29Z","updated_at":"2014-07-21T20:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"642d9e99df4b1d5625f12c729f1c906a50df721b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/438/commits","review_comments_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/438/comments","review_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/438/comments","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/33205c84238381eede1f6dc63a8dd9720bf38618","head":{"label":"natemcmaster:metadata","ref":"metadata","sha":"33205c84238381eede1f6dc63a8dd9720bf38618","user":{"login":"natemcmaster","id":2696087,"avatar_url":"https://avatars.githubusercontent.com/u/2696087?","gravatar_id":"692c58f37a3704944bd31c4cbcb287e7","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"repo":{"id":19757095,"name":"EntityFramework","full_name":"natemcmaster/EntityFramework","owner":{"login":"natemcmaster","id":2696087,"avatar_url":"https://avatars.githubusercontent.com/u/2696087?","gravatar_id":"692c58f37a3704944bd31c4cbcb287e7","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natemcmaster/EntityFramework","description":"","fork":true,"url":"https://api.github.com/repos/natemcmaster/EntityFramework","forks_url":"https://api.github.com/repos/natemcmaster/EntityFramework/forks","keys_url":"https://api.github.com/repos/natemcmaster/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natemcmaster/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natemcmaster/EntityFramework/teams","hooks_url":"https://api.github.com/repos/natemcmaster/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/natemcmaster/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/natemcmaster/EntityFramework/events","assignees_url":"https://api.github.com/repos/natemcmaster/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/natemcmaster/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/natemcmaster/EntityFramework/tags","blobs_url":"https://api.github.com/repos/natemcmaster/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natemcmaster/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natemcmaster/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/natemcmaster/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natemcmaster/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/natemcmaster/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/natemcmaster/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/natemcmaster/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/natemcmaster/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/natemcmaster/EntityFramework/subscription","commits_url":"https://api.github.com/repos/natemcmaster/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/natemcmaster/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/natemcmaster/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/natemcmaster/EntityFramework/issues/comments/{number}","contents_url":"https://api.github.com/repos/natemcmaster/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/natemcmaster/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natemcmaster/EntityFramework/merges","archive_url":"https://api.github.com/repos/natemcmaster/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natemcmaster/EntityFramework/downloads","issues_url":"https://api.github.com/repos/natemcmaster/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/natemcmaster/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/natemcmaster/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/natemcmaster/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natemcmaster/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/natemcmaster/EntityFramework/releases{/id}","created_at":"2014-05-13T21:47:53Z","updated_at":"2014-06-25T23:16:04Z","pushed_at":"2014-07-19T01:06:36Z","git_url":"git://github.com/natemcmaster/EntityFramework.git","ssh_url":"git@github.com:natemcmaster/EntityFramework.git","clone_url":"https://github.com/natemcmaster/EntityFramework.git","svn_url":"https://github.com/natemcmaster/EntityFramework","homepage":null,"size":5500,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"219410fc244b3aab69fe6ade1f0e795b49940d48","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?","gravatar_id":null,"url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16157746,"name":"EntityFramework","full_name":"aspnet/EntityFramework","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?","gravatar_id":null,"url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/EntityFramework","description":"","fork":false,"url":"https://api.github.com/repos/aspnet/EntityFramework","forks_url":"https://api.github.com/repos/aspnet/EntityFramework/forks","keys_url":"https://api.github.com/repos/aspnet/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/EntityFramework/teams","hooks_url":"https://api.github.com/repos/aspnet/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/EntityFramework/events","assignees_url":"https://api.github.com/repos/aspnet/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/EntityFramework/tags","blobs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/aspnet/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/aspnet/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/aspnet/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/aspnet/EntityFramework/subscription","commits_url":"https://api.github.com/repos/aspnet/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/EntityFramework/merges","archive_url":"https://api.github.com/repos/aspnet/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/EntityFramework/downloads","issues_url":"https://api.github.com/repos/aspnet/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/EntityFramework/releases{/id}","created_at":"2014-01-23T00:52:01Z","updated_at":"2014-07-21T16:37:38Z","pushed_at":"2014-07-21T18:56:23Z","git_url":"git://github.com/aspnet/EntityFramework.git","ssh_url":"git@github.com:aspnet/EntityFramework.git","clone_url":"https://github.com/aspnet/EntityFramework.git","svn_url":"https://github.com/aspnet/EntityFramework","homepage":null,"size":17570,"stargazers_count":478,"watchers_count":478,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":122,"mirror_url":null,"open_issues_count":113,"forks":122,"open_issues":113,"watchers":478,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/438"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/438"},"issue":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/438"},"comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/EntityFramework/statuses/33205c84238381eede1f6dc63a8dd9720bf38618"}}}}