GitHub PullRequestReviewCommentEvent at 2014-12-04 22:23:47
Repository: rippled
Actor: ximinez
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/21341559","id":21341559,"diff_hunk":"@@ -419,8 +419,12 @@ class Ledger\n \n     static std::set<std::uint32_t> getPendingSaves();\n \n-    Json::Value getJson (int options) const;\n-    void addJson (Json::Value&, int options);\n+    /** Const version of getHash() which gets the current value without calling\n+        updateHash(). */\n+    uint256 const& getRawHash () const\n+    {\n+        return mHash;","path":"src/ripple/app/ledger/Ledger.h","position":10,"original_position":10,"commit_id":"5616fad1076371e60f3492c4f022b66de188933c","original_commit_id":"5616fad1076371e60f3492c4f022b66de188933c","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"Is there any concern if `!mValidHash`?","created_at":"2014-12-04T22:23:47Z","updated_at":"2014-12-04T22:23:47Z","html_url":"https://github.com/ripple/rippled/pull/750#discussion_r21341559","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/750","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/21341559"},"html":{"href":"https://github.com/ripple/rippled/pull/750#discussion_r21341559"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/750"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/750","id":25511961,"html_url":"https://github.com/ripple/rippled/pull/750","diff_url":"https://github.com/ripple/rippled/pull/750.diff","patch_url":"https://github.com/ripple/rippled/pull/750.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/750","number":750,"state":"open","locked":false,"title":"Streaming rpc","user":{"login":"rec","id":253362,"avatar_url":"https://avatars.githubusercontent.com/u/253362?v=3","gravatar_id":"","url":"https://api.github.com/users/rec","html_url":"https://github.com/rec","followers_url":"https://api.github.com/users/rec/followers","following_url":"https://api.github.com/users/rec/following{/other_user}","gists_url":"https://api.github.com/users/rec/gists{/gist_id}","starred_url":"https://api.github.com/users/rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rec/subscriptions","organizations_url":"https://api.github.com/users/rec/orgs","repos_url":"https://api.github.com/users/rec/repos","events_url":"https://api.github.com/users/rec/events{/privacy}","received_events_url":"https://api.github.com/users/rec/received_events","type":"User","site_admin":false},"body":"Here it is, the streaming RPC changelist!\r\n\r\nI spent a long time cleaning it up into as few independent changelists as possible, and I hope it's readable for you.\r\n","created_at":"2014-12-04T17:12:00Z","updated_at":"2014-12-04T22:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9ec5a716771e067fa5164f7035f9a6e4dc15835","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/750/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/750/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/750/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/5616fad1076371e60f3492c4f022b66de188933c","head":{"label":"rec:streaming-rpc","ref":"streaming-rpc","sha":"5616fad1076371e60f3492c4f022b66de188933c","user":{"login":"rec","id":253362,"avatar_url":"https://avatars.githubusercontent.com/u/253362?v=3","gravatar_id":"","url":"https://api.github.com/users/rec","html_url":"https://github.com/rec","followers_url":"https://api.github.com/users/rec/followers","following_url":"https://api.github.com/users/rec/following{/other_user}","gists_url":"https://api.github.com/users/rec/gists{/gist_id}","starred_url":"https://api.github.com/users/rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rec/subscriptions","organizations_url":"https://api.github.com/users/rec/orgs","repos_url":"https://api.github.com/users/rec/repos","events_url":"https://api.github.com/users/rec/events{/privacy}","received_events_url":"https://api.github.com/users/rec/received_events","type":"User","site_admin":false},"repo":{"id":18302070,"name":"rippled","full_name":"rec/rippled","owner":{"login":"rec","id":253362,"avatar_url":"https://avatars.githubusercontent.com/u/253362?v=3","gravatar_id":"","url":"https://api.github.com/users/rec","html_url":"https://github.com/rec","followers_url":"https://api.github.com/users/rec/followers","following_url":"https://api.github.com/users/rec/following{/other_user}","gists_url":"https://api.github.com/users/rec/gists{/gist_id}","starred_url":"https://api.github.com/users/rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rec/subscriptions","organizations_url":"https://api.github.com/users/rec/orgs","repos_url":"https://api.github.com/users/rec/repos","events_url":"https://api.github.com/users/rec/events{/privacy}","received_events_url":"https://api.github.com/users/rec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rec/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/rec/rippled","forks_url":"https://api.github.com/repos/rec/rippled/forks","keys_url":"https://api.github.com/repos/rec/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rec/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rec/rippled/teams","hooks_url":"https://api.github.com/repos/rec/rippled/hooks","issue_events_url":"https://api.github.com/repos/rec/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/rec/rippled/events","assignees_url":"https://api.github.com/repos/rec/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/rec/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/rec/rippled/tags","blobs_url":"https://api.github.com/repos/rec/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rec/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rec/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/rec/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rec/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/rec/rippled/languages","stargazers_url":"https://api.github.com/repos/rec/rippled/stargazers","contributors_url":"https://api.github.com/repos/rec/rippled/contributors","subscribers_url":"https://api.github.com/repos/rec/rippled/subscribers","subscription_url":"https://api.github.com/repos/rec/rippled/subscription","commits_url":"https://api.github.com/repos/rec/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/rec/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/rec/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/rec/rippled/issues/comments/{number}","contents_url":"https://api.github.com/repos/rec/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/rec/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rec/rippled/merges","archive_url":"https://api.github.com/repos/rec/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rec/rippled/downloads","issues_url":"https://api.github.com/repos/rec/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/rec/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/rec/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/rec/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rec/rippled/labels{/name}","releases_url":"https://api.github.com/repos/rec/rippled/releases{/id}","created_at":"2014-03-31T17:41:21Z","updated_at":"2014-12-01T15:54:51Z","pushed_at":"2014-12-04T20:07:16Z","git_url":"git://github.com/rec/rippled.git","ssh_url":"git@github.com:rec/rippled.git","clone_url":"https://github.com/rec/rippled.git","svn_url":"https://github.com/rec/rippled","homepage":"https://ripple.com","size":48110,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"86df4828420dbe31b842bed8a618fcc3ebbfcada","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments/{number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2014-12-02T16:41:20Z","pushed_at":"2014-12-04T20:17:27Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":94506,"stargazers_count":878,"watchers_count":878,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":139,"forks":239,"open_issues":139,"watchers":878,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/750"},"html":{"href":"https://github.com/ripple/rippled/pull/750"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/750"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/750/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/750/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/750/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/5616fad1076371e60f3492c4f022b66de188933c"}}}}