GitHub PullRequestReviewCommentEvent at 2014-12-23 16:02:33
Repository: Firmware
Actor: dagar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/22220612","id":22220612,"diff_hunk":"@@ -801,7 +801,7 @@ MavlinkFTP::_return_request(Request *req)\n \n /// @brief Copy file (with limited space)\n int\n-MavlinkFTP::_copy_file(const char *src_path, const char *dst_path, ssize_t length)\n+MavlinkFTP::_copy_file(const char *src_path, const char *dst_path, size_t length)","path":"src/modules/mavlink/mavlink_ftp.cpp","position":5,"original_position":5,"commit_id":"825b54f211c5f48945df7d386592221d70de188c","original_commit_id":"d511e39ea7a3f1e0cb672b14598e18a7df18156a","user":{"login":"dagar","id":84712,"avatar_url":"https://avatars.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"body":"The only uses of MavlinkFTP::_copy_file() I found were passing the uint32_t offset in the PayloadHeader as the length.\r\n\r\nIf the length is negative then MavlinkFTP::_copy_file() returns -1. I could remove that or do something else just to silence the warning.","created_at":"2014-12-23T16:02:33Z","updated_at":"2014-12-23T16:02:33Z","html_url":"https://github.com/PX4/Firmware/pull/1527#discussion_r22220612","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/1527","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/22220612"},"html":{"href":"https://github.com/PX4/Firmware/pull/1527#discussion_r22220612"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/1527"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/1527","id":26486457,"html_url":"https://github.com/PX4/Firmware/pull/1527","diff_url":"https://github.com/PX4/Firmware/pull/1527.diff","patch_url":"https://github.com/PX4/Firmware/pull/1527.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/1527","number":1527,"state":"open","locked":false,"title":"turn on -Werror and fix resulting errors","user":{"login":"dagar","id":84712,"avatar_url":"https://avatars.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-22T22:58:28Z","updated_at":"2014-12-23T16:02:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31fa9498dd27ee45e3b17bb633c029bb0d52f693","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/1527/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/1527/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/1527/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/825b54f211c5f48945df7d386592221d70de188c","head":{"label":"dagar:Werror","ref":"Werror","sha":"825b54f211c5f48945df7d386592221d70de188c","user":{"login":"dagar","id":84712,"avatar_url":"https://avatars.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"repo":{"id":28361311,"name":"Firmware","full_name":"dagar/Firmware","owner":{"login":"dagar","id":84712,"avatar_url":"https://avatars.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dagar/Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":true,"url":"https://api.github.com/repos/dagar/Firmware","forks_url":"https://api.github.com/repos/dagar/Firmware/forks","keys_url":"https://api.github.com/repos/dagar/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagar/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagar/Firmware/teams","hooks_url":"https://api.github.com/repos/dagar/Firmware/hooks","issue_events_url":"https://api.github.com/repos/dagar/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/dagar/Firmware/events","assignees_url":"https://api.github.com/repos/dagar/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/dagar/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/dagar/Firmware/tags","blobs_url":"https://api.github.com/repos/dagar/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagar/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagar/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagar/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagar/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/dagar/Firmware/languages","stargazers_url":"https://api.github.com/repos/dagar/Firmware/stargazers","contributors_url":"https://api.github.com/repos/dagar/Firmware/contributors","subscribers_url":"https://api.github.com/repos/dagar/Firmware/subscribers","subscription_url":"https://api.github.com/repos/dagar/Firmware/subscription","commits_url":"https://api.github.com/repos/dagar/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagar/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagar/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagar/Firmware/issues/comments/{number}","contents_url":"https://api.github.com/repos/dagar/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/dagar/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagar/Firmware/merges","archive_url":"https://api.github.com/repos/dagar/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagar/Firmware/downloads","issues_url":"https://api.github.com/repos/dagar/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/dagar/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/dagar/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/dagar/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagar/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/dagar/Firmware/releases{/id}","created_at":"2014-12-22T21:54:11Z","updated_at":"2014-12-22T21:54:15Z","pushed_at":"2014-12-23T15:56:44Z","git_url":"git://github.com/dagar/Firmware.git","ssh_url":"git@github.com:dagar/Firmware.git","clone_url":"https://github.com/dagar/Firmware.git","svn_url":"https://github.com/dagar/Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":63004,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"d54b46355ce0f8c128a5e7fce94564c7cb338987","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments/{number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","created_at":"2012-08-04T21:19:36Z","updated_at":"2014-12-23T14:19:48Z","pushed_at":"2014-12-23T14:20:07Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":122163,"stargazers_count":223,"watchers_count":223,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":709,"mirror_url":null,"open_issues_count":110,"forks":709,"open_issues":110,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/1527"},"html":{"href":"https://github.com/PX4/Firmware/pull/1527"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/1527"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/1527/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/1527/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/1527/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/825b54f211c5f48945df7d386592221d70de188c"}}}}