GitHub PullRequestEvent at 2014-06-11 11:29:56
Repository: astropy-helpers
Actor: astrofrog
Payload: {"action":"opened","number":42,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/42","id":16992207,"html_url":"https://github.com/astropy/astropy-helpers/pull/42","diff_url":"https://github.com/astropy/astropy-helpers/pull/42.diff","patch_url":"https://github.com/astropy/astropy-helpers/pull/42.patch","issue_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/42","number":42,"state":"open","title":"Added a new ``list_data_files`` function that can be used to search for files recursively","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?","gravatar_id":"f586e2a9879fe0a55fd1e3ea529c664f","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"body":"In the package-template, we currently search for c files manually:\r\n\r\n```\r\nc_files = []\r\nfor root, dirs, files in os.walk(PACKAGENAME):\r\n    for filename in files:\r\n        if filename.endswith('.c'):\r\n            c_files.append(\r\n                os.path.join(\r\n                    os.path.relpath(root, PACKAGENAME), filename))\r\n```\r\n\r\nwe now also need to search for all files in ``packagename/data/`` recursively, so I thought it would be more convenient to write a function to do this.\r\n\r\nI can add tests if we think this is a good idea.\r\n\r\ncc @embray @mdboom","created_at":"2014-06-11T11:29:56Z","updated_at":"2014-06-11T11:29:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/42/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/42/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/comments/{number}","comments_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/42/comments","statuses_url":"https://api.github.com/repos/astropy/astropy-helpers/statuses/a0fddff2e63f2967d1953dd212b02305b393d975","head":{"label":"astrofrog:recursive-glob","ref":"recursive-glob","sha":"a0fddff2e63f2967d1953dd212b02305b393d975","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?","gravatar_id":"f586e2a9879fe0a55fd1e3ea529c664f","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"repo":{"id":15879735,"name":"astropy-helpers","full_name":"astrofrog/astropy-helpers","owner":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?","gravatar_id":"f586e2a9879fe0a55fd1e3ea529c664f","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astrofrog/astropy-helpers","description":"Helpers for Astropy and Affiliated packages","fork":true,"url":"https://api.github.com/repos/astrofrog/astropy-helpers","forks_url":"https://api.github.com/repos/astrofrog/astropy-helpers/forks","keys_url":"https://api.github.com/repos/astrofrog/astropy-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astrofrog/astropy-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astrofrog/astropy-helpers/teams","hooks_url":"https://api.github.com/repos/astrofrog/astropy-helpers/hooks","issue_events_url":"https://api.github.com/repos/astrofrog/astropy-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/astrofrog/astropy-helpers/events","assignees_url":"https://api.github.com/repos/astrofrog/astropy-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/astrofrog/astropy-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/astrofrog/astropy-helpers/tags","blobs_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astrofrog/astropy-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/astrofrog/astropy-helpers/languages","stargazers_url":"https://api.github.com/repos/astrofrog/astropy-helpers/stargazers","contributors_url":"https://api.github.com/repos/astrofrog/astropy-helpers/contributors","subscribers_url":"https://api.github.com/repos/astrofrog/astropy-helpers/subscribers","subscription_url":"https://api.github.com/repos/astrofrog/astropy-helpers/subscription","commits_url":"https://api.github.com/repos/astrofrog/astropy-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/astrofrog/astropy-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/astrofrog/astropy-helpers/issues/comments/{number}","contents_url":"https://api.github.com/repos/astrofrog/astropy-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/astrofrog/astropy-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astrofrog/astropy-helpers/merges","archive_url":"https://api.github.com/repos/astrofrog/astropy-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astrofrog/astropy-helpers/downloads","issues_url":"https://api.github.com/repos/astrofrog/astropy-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/astrofrog/astropy-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/astrofrog/astropy-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/astrofrog/astropy-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astrofrog/astropy-helpers/labels{/name}","releases_url":"https://api.github.com/repos/astrofrog/astropy-helpers/releases{/id}","created_at":"2014-01-13T19:51:48Z","updated_at":"2014-06-11T11:29:56Z","pushed_at":"2014-06-11T11:28:32Z","git_url":"git://github.com/astrofrog/astropy-helpers.git","ssh_url":"git@github.com:astrofrog/astropy-helpers.git","clone_url":"https://github.com/astrofrog/astropy-helpers.git","svn_url":"https://github.com/astrofrog/astropy-helpers","homepage":null,"size":710,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"3bb39bdc735eb5ac52490a4e3d5e0b05b077d3fd","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?","gravatar_id":"df333e02889464493106cdf6de217066","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":14448779,"name":"astropy-helpers","full_name":"astropy/astropy-helpers","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?","gravatar_id":"df333e02889464493106cdf6de217066","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy-helpers","description":"Helpers for Astropy and Affiliated packages","fork":false,"url":"https://api.github.com/repos/astropy/astropy-helpers","forks_url":"https://api.github.com/repos/astropy/astropy-helpers/forks","keys_url":"https://api.github.com/repos/astropy/astropy-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy-helpers/teams","hooks_url":"https://api.github.com/repos/astropy/astropy-helpers/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy-helpers/events","assignees_url":"https://api.github.com/repos/astropy/astropy-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy-helpers/tags","blobs_url":"https://api.github.com/repos/astropy/astropy-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy-helpers/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy-helpers/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy-helpers/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy-helpers/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy-helpers/subscription","commits_url":"https://api.github.com/repos/astropy/astropy-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/comments/{number}","contents_url":"https://api.github.com/repos/astropy/astropy-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy-helpers/merges","archive_url":"https://api.github.com/repos/astropy/astropy-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy-helpers/downloads","issues_url":"https://api.github.com/repos/astropy/astropy-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy-helpers/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy-helpers/releases{/id}","created_at":"2013-11-16T15:01:42Z","updated_at":"2014-06-10T19:15:38Z","pushed_at":"2014-06-10T19:15:38Z","git_url":"git://github.com/astropy/astropy-helpers.git","ssh_url":"git@github.com:astropy/astropy-helpers.git","clone_url":"https://github.com/astropy/astropy-helpers.git","svn_url":"https://github.com/astropy/astropy-helpers","homepage":null,"size":1128,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/42"},"html":{"href":"https://github.com/astropy/astropy-helpers/pull/42"},"issue":{"href":"https://api.github.com/repos/astropy/astropy-helpers/issues/42"},"comments":{"href":"https://api.github.com/repos/astropy/astropy-helpers/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy-helpers/statuses/a0fddff2e63f2967d1953dd212b02305b393d975"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":26,"deletions":0,"changed_files":1}}