GitHub PullRequestEvent at 2014-04-06 14:33:24
Repository: waartaa
Actor: desouradeep
Payload: {"action":"opened","number":82,"pull_request":{"url":"https://api.github.com/repos/waartaa/waartaa/pulls/82","id":14424809,"html_url":"https://github.com/waartaa/waartaa/pull/82","diff_url":"https://github.com/waartaa/waartaa/pull/82.diff","patch_url":"https://github.com/waartaa/waartaa/pull/82.patch","issue_url":"https://api.github.com/repos/waartaa/waartaa/issues/82","number":82,"state":"open","title":"navbar_collapse: hide the navbar-collapse button","user":{"login":"desouradeep","id":1932760,"avatar_url":"https://avatars.githubusercontent.com/u/1932760?","gravatar_id":"6825536f85f2e40b3c63fdd8f6491b2e","url":"https://api.github.com/users/desouradeep","html_url":"https://github.com/desouradeep","followers_url":"https://api.github.com/users/desouradeep/followers","following_url":"https://api.github.com/users/desouradeep/following{/other_user}","gists_url":"https://api.github.com/users/desouradeep/gists{/gist_id}","starred_url":"https://api.github.com/users/desouradeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desouradeep/subscriptions","organizations_url":"https://api.github.com/users/desouradeep/orgs","repos_url":"https://api.github.com/users/desouradeep/repos","events_url":"https://api.github.com/users/desouradeep/events{/privacy}","received_events_url":"https://api.github.com/users/desouradeep/received_events","type":"User","site_admin":false},"body":"On the event of navbar collapse, when no li items are present, the navbar still shows the dropdown button, but with no links. In this commit, I have disabled the button if no items are present.\r\nAttached some screenshots exposing the bug.\r\nBefore clicking dropdown button:\r\n![screenshot from 2014-04-06 19 50 20](https://cloud.githubusercontent.com/assets/1932760/2625454/235c3010-bd98-11e3-881a-7c1f4530f838.png)\r\nAfter clicking dropdown button:\r\n![screenshot from 2014-04-06 19 49 52](https://cloud.githubusercontent.com/assets/1932760/2625456/37d6e4cc-bd98-11e3-8352-96eac1141c41.png)\r\n\r\n","created_at":"2014-04-06T14:33:24Z","updated_at":"2014-04-06T14:33:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/waartaa/waartaa/pulls/82/commits","review_comments_url":"https://api.github.com/repos/waartaa/waartaa/pulls/82/comments","review_comment_url":"https://api.github.com/repos/waartaa/waartaa/pulls/comments/{number}","comments_url":"https://api.github.com/repos/waartaa/waartaa/issues/82/comments","statuses_url":"https://api.github.com/repos/waartaa/waartaa/statuses/d70112941e2ad147e4f9e4ae109391664457ba08","head":{"label":"desouradeep:navbar_collapse","ref":"navbar_collapse","sha":"d70112941e2ad147e4f9e4ae109391664457ba08","user":{"login":"desouradeep","id":1932760,"avatar_url":"https://avatars.githubusercontent.com/u/1932760?","gravatar_id":"6825536f85f2e40b3c63fdd8f6491b2e","url":"https://api.github.com/users/desouradeep","html_url":"https://github.com/desouradeep","followers_url":"https://api.github.com/users/desouradeep/followers","following_url":"https://api.github.com/users/desouradeep/following{/other_user}","gists_url":"https://api.github.com/users/desouradeep/gists{/gist_id}","starred_url":"https://api.github.com/users/desouradeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desouradeep/subscriptions","organizations_url":"https://api.github.com/users/desouradeep/orgs","repos_url":"https://api.github.com/users/desouradeep/repos","events_url":"https://api.github.com/users/desouradeep/events{/privacy}","received_events_url":"https://api.github.com/users/desouradeep/received_events","type":"User","site_admin":false},"repo":{"id":15840985,"name":"waartaa","full_name":"desouradeep/waartaa","owner":{"login":"desouradeep","id":1932760,"avatar_url":"https://avatars.githubusercontent.com/u/1932760?","gravatar_id":"6825536f85f2e40b3c63fdd8f6491b2e","url":"https://api.github.com/users/desouradeep","html_url":"https://github.com/desouradeep","followers_url":"https://api.github.com/users/desouradeep/followers","following_url":"https://api.github.com/users/desouradeep/following{/other_user}","gists_url":"https://api.github.com/users/desouradeep/gists{/gist_id}","starred_url":"https://api.github.com/users/desouradeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desouradeep/subscriptions","organizations_url":"https://api.github.com/users/desouradeep/orgs","repos_url":"https://api.github.com/users/desouradeep/repos","events_url":"https://api.github.com/users/desouradeep/events{/privacy}","received_events_url":"https://api.github.com/users/desouradeep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/desouradeep/waartaa","description":"A modern web based communication service on top IRC.","fork":true,"url":"https://api.github.com/repos/desouradeep/waartaa","forks_url":"https://api.github.com/repos/desouradeep/waartaa/forks","keys_url":"https://api.github.com/repos/desouradeep/waartaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desouradeep/waartaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desouradeep/waartaa/teams","hooks_url":"https://api.github.com/repos/desouradeep/waartaa/hooks","issue_events_url":"https://api.github.com/repos/desouradeep/waartaa/issues/events{/number}","events_url":"https://api.github.com/repos/desouradeep/waartaa/events","assignees_url":"https://api.github.com/repos/desouradeep/waartaa/assignees{/user}","branches_url":"https://api.github.com/repos/desouradeep/waartaa/branches{/branch}","tags_url":"https://api.github.com/repos/desouradeep/waartaa/tags","blobs_url":"https://api.github.com/repos/desouradeep/waartaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desouradeep/waartaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desouradeep/waartaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/desouradeep/waartaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desouradeep/waartaa/statuses/{sha}","languages_url":"https://api.github.com/repos/desouradeep/waartaa/languages","stargazers_url":"https://api.github.com/repos/desouradeep/waartaa/stargazers","contributors_url":"https://api.github.com/repos/desouradeep/waartaa/contributors","subscribers_url":"https://api.github.com/repos/desouradeep/waartaa/subscribers","subscription_url":"https://api.github.com/repos/desouradeep/waartaa/subscription","commits_url":"https://api.github.com/repos/desouradeep/waartaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/desouradeep/waartaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/desouradeep/waartaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/desouradeep/waartaa/issues/comments/{number}","contents_url":"https://api.github.com/repos/desouradeep/waartaa/contents/{+path}","compare_url":"https://api.github.com/repos/desouradeep/waartaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desouradeep/waartaa/merges","archive_url":"https://api.github.com/repos/desouradeep/waartaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desouradeep/waartaa/downloads","issues_url":"https://api.github.com/repos/desouradeep/waartaa/issues{/number}","pulls_url":"https://api.github.com/repos/desouradeep/waartaa/pulls{/number}","milestones_url":"https://api.github.com/repos/desouradeep/waartaa/milestones{/number}","notifications_url":"https://api.github.com/repos/desouradeep/waartaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desouradeep/waartaa/labels{/name}","releases_url":"https://api.github.com/repos/desouradeep/waartaa/releases{/id}","created_at":"2014-01-12T11:26:21Z","updated_at":"2014-04-06T14:33:24Z","pushed_at":"2014-04-06T14:17:59Z","git_url":"git://github.com/desouradeep/waartaa.git","ssh_url":"git@github.com:desouradeep/waartaa.git","clone_url":"https://github.com/desouradeep/waartaa.git","svn_url":"https://github.com/desouradeep/waartaa","homepage":null,"size":4793,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"waartaa:master","ref":"master","sha":"36cc657b061b7ac8af32630c803b11551d73b08b","user":{"login":"waartaa","id":6017112,"avatar_url":"https://avatars.githubusercontent.com/u/6017112?","gravatar_id":null,"url":"https://api.github.com/users/waartaa","html_url":"https://github.com/waartaa","followers_url":"https://api.github.com/users/waartaa/followers","following_url":"https://api.github.com/users/waartaa/following{/other_user}","gists_url":"https://api.github.com/users/waartaa/gists{/gist_id}","starred_url":"https://api.github.com/users/waartaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waartaa/subscriptions","organizations_url":"https://api.github.com/users/waartaa/orgs","repos_url":"https://api.github.com/users/waartaa/repos","events_url":"https://api.github.com/users/waartaa/events{/privacy}","received_events_url":"https://api.github.com/users/waartaa/received_events","type":"Organization","site_admin":false},"repo":{"id":14659205,"name":"waartaa","full_name":"waartaa/waartaa","owner":{"login":"waartaa","id":6017112,"avatar_url":"https://avatars.githubusercontent.com/u/6017112?","gravatar_id":null,"url":"https://api.github.com/users/waartaa","html_url":"https://github.com/waartaa","followers_url":"https://api.github.com/users/waartaa/followers","following_url":"https://api.github.com/users/waartaa/following{/other_user}","gists_url":"https://api.github.com/users/waartaa/gists{/gist_id}","starred_url":"https://api.github.com/users/waartaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waartaa/subscriptions","organizations_url":"https://api.github.com/users/waartaa/orgs","repos_url":"https://api.github.com/users/waartaa/repos","events_url":"https://api.github.com/users/waartaa/events{/privacy}","received_events_url":"https://api.github.com/users/waartaa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/waartaa/waartaa","description":"A modern web based communication service on top IRC.","fork":false,"url":"https://api.github.com/repos/waartaa/waartaa","forks_url":"https://api.github.com/repos/waartaa/waartaa/forks","keys_url":"https://api.github.com/repos/waartaa/waartaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waartaa/waartaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waartaa/waartaa/teams","hooks_url":"https://api.github.com/repos/waartaa/waartaa/hooks","issue_events_url":"https://api.github.com/repos/waartaa/waartaa/issues/events{/number}","events_url":"https://api.github.com/repos/waartaa/waartaa/events","assignees_url":"https://api.github.com/repos/waartaa/waartaa/assignees{/user}","branches_url":"https://api.github.com/repos/waartaa/waartaa/branches{/branch}","tags_url":"https://api.github.com/repos/waartaa/waartaa/tags","blobs_url":"https://api.github.com/repos/waartaa/waartaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waartaa/waartaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waartaa/waartaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/waartaa/waartaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waartaa/waartaa/statuses/{sha}","languages_url":"https://api.github.com/repos/waartaa/waartaa/languages","stargazers_url":"https://api.github.com/repos/waartaa/waartaa/stargazers","contributors_url":"https://api.github.com/repos/waartaa/waartaa/contributors","subscribers_url":"https://api.github.com/repos/waartaa/waartaa/subscribers","subscription_url":"https://api.github.com/repos/waartaa/waartaa/subscription","commits_url":"https://api.github.com/repos/waartaa/waartaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/waartaa/waartaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/waartaa/waartaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/waartaa/waartaa/issues/comments/{number}","contents_url":"https://api.github.com/repos/waartaa/waartaa/contents/{+path}","compare_url":"https://api.github.com/repos/waartaa/waartaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waartaa/waartaa/merges","archive_url":"https://api.github.com/repos/waartaa/waartaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waartaa/waartaa/downloads","issues_url":"https://api.github.com/repos/waartaa/waartaa/issues{/number}","pulls_url":"https://api.github.com/repos/waartaa/waartaa/pulls{/number}","milestones_url":"https://api.github.com/repos/waartaa/waartaa/milestones{/number}","notifications_url":"https://api.github.com/repos/waartaa/waartaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waartaa/waartaa/labels{/name}","releases_url":"https://api.github.com/repos/waartaa/waartaa/releases{/id}","created_at":"2013-11-24T10:13:58Z","updated_at":"2014-04-05T08:21:04Z","pushed_at":"2014-04-05T08:21:04Z","git_url":"git://github.com/waartaa/waartaa.git","ssh_url":"git@github.com:waartaa/waartaa.git","clone_url":"https://github.com/waartaa/waartaa.git","svn_url":"https://github.com/waartaa/waartaa","homepage":"https://www.waartaa.com/","size":10525,"stargazers_count":48,"watchers_count":48,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":38,"mirror_url":null,"open_issues_count":30,"forks":38,"open_issues":30,"watchers":48,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/waartaa/waartaa/pulls/82"},"html":{"href":"https://github.com/waartaa/waartaa/pull/82"},"issue":{"href":"https://api.github.com/repos/waartaa/waartaa/issues/82"},"comments":{"href":"https://api.github.com/repos/waartaa/waartaa/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/waartaa/waartaa/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/waartaa/waartaa/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/waartaa/waartaa/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/waartaa/waartaa/statuses/d70112941e2ad147e4f9e4ae109391664457ba08"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":0,"changed_files":1}}