GitHub PullRequestReviewCommentEvent at 2014-07-18 14:09:38
Repository: drupal-quickstart
Actor: vbalazs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/comments/15112525","id":15112525,"diff_hunk":"@@ -6,11 +6,13 @@\n \n set -e\n \n+source $OPENSHIFT_CARTRIDGE_SDK_BASH\n+\n DRUPAL_SITE_DIR=${OPENSHIFT_DATA_DIR}sites\n DRUPAL_PRIVATE_DIR=${OPENSHIFT_DATA_DIR}private\n DRUPAL_SETTINGS=${DRUPAL_SITE_DIR}/default/settings.php\n-DEFAULT_PASSWORD=openshift_changeme\n \n+# NOTE: possibly this won't work when it's a scaled build","path":".openshift/action_hooks/deploy","position":11,"original_position":11,"commit_id":"44b424fa58394fb93816971597b5c8208ebea3cc","original_commit_id":"44b424fa58394fb93816971597b5c8208ebea3cc","user":{"login":"vbalazs","id":281883,"avatar_url":"https://avatars.githubusercontent.com/u/281883?","gravatar_id":"bf739e2caa630cd8c97289ad9b8e7b2f","url":"https://api.github.com/users/vbalazs","html_url":"https://github.com/vbalazs","followers_url":"https://api.github.com/users/vbalazs/followers","following_url":"https://api.github.com/users/vbalazs/following{/other_user}","gists_url":"https://api.github.com/users/vbalazs/gists{/gist_id}","starred_url":"https://api.github.com/users/vbalazs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbalazs/subscriptions","organizations_url":"https://api.github.com/users/vbalazs/orgs","repos_url":"https://api.github.com/users/vbalazs/repos","events_url":"https://api.github.com/users/vbalazs/events{/privacy}","received_events_url":"https://api.github.com/users/vbalazs/received_events","type":"User","site_admin":false},"body":"If I understood correctly, the problem is not with the password distribution itself, rather than touching the files under the build process. We are doing it when check then create for an existing site. Theoretically, we could support a case when the build happens on a different gear (?) // cc @danmcp \r\n\r\nIt's just a default password for the admin account on the created drupal site which the user should change after the first login. Besides that it would over-complicate things, I don't see how the user could set an environment variable before create an application from a quickstart. He can just fill the form on the online UI and press create... no previous app create there.","created_at":"2014-07-18T14:09:38Z","updated_at":"2014-07-18T14:09:38Z","html_url":"https://github.com/openshift/drupal-quickstart/pull/21#discussion_r15112525","pull_request_url":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/comments/15112525"},"html":{"href":"https://github.com/openshift/drupal-quickstart/pull/21#discussion_r15112525"},"pull_request":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/21","id":18477147,"html_url":"https://github.com/openshift/drupal-quickstart/pull/21","diff_url":"https://github.com/openshift/drupal-quickstart/pull/21.diff","patch_url":"https://github.com/openshift/drupal-quickstart/pull/21.patch","issue_url":"https://api.github.com/repos/openshift/drupal-quickstart/issues/21","number":21,"state":"open","title":"Bug 1012981 - Generate unique password and show it to the user","user":{"login":"vbalazs","id":281883,"avatar_url":"https://avatars.githubusercontent.com/u/281883?","gravatar_id":"bf739e2caa630cd8c97289ad9b8e7b2f","url":"https://api.github.com/users/vbalazs","html_url":"https://github.com/vbalazs","followers_url":"https://api.github.com/users/vbalazs/followers","following_url":"https://api.github.com/users/vbalazs/following{/other_user}","gists_url":"https://api.github.com/users/vbalazs/gists{/gist_id}","starred_url":"https://api.github.com/users/vbalazs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbalazs/subscriptions","organizations_url":"https://api.github.com/users/vbalazs/orgs","repos_url":"https://api.github.com/users/vbalazs/repos","events_url":"https://api.github.com/users/vbalazs/events{/privacy}","received_events_url":"https://api.github.com/users/vbalazs/received_events","type":"User","site_admin":false},"body":"Replaces the static password to more secure unique, generated password and shows it to the user:\r\n* when creates the application from the web ui\r\n* when creates the app with `rhc app create --from-app [...]`\r\n* when creates the cartridges and pushes the quickstart via git\r\n\r\nAlso add instructions in case of web ui timeout\r\n\r\n[Bug 1012981](https://bugzilla.redhat.com/show_bug.cgi?id=1012981) (and also [related](https://bugzilla.redhat.com/show_bug.cgi?id=1013684))\r\n\r\n[Trello card](https://trello.com/c/RsENlXNV/257-5-fix-5-existing-bugs)","created_at":"2014-07-16T15:59:20Z","updated_at":"2014-07-18T14:09:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1967ec31dae8500820642e4db21dd7fa10888601","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/21/commits","review_comments_url":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/21/comments","review_comment_url":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openshift/drupal-quickstart/issues/21/comments","statuses_url":"https://api.github.com/repos/openshift/drupal-quickstart/statuses/44b424fa58394fb93816971597b5c8208ebea3cc","head":{"label":"vbalazs:bvarga/bug_1012981_drupal_quickstart_generate_and_show_password","ref":"bvarga/bug_1012981_drupal_quickstart_generate_and_show_password","sha":"44b424fa58394fb93816971597b5c8208ebea3cc","user":{"login":"vbalazs","id":281883,"avatar_url":"https://avatars.githubusercontent.com/u/281883?","gravatar_id":"bf739e2caa630cd8c97289ad9b8e7b2f","url":"https://api.github.com/users/vbalazs","html_url":"https://github.com/vbalazs","followers_url":"https://api.github.com/users/vbalazs/followers","following_url":"https://api.github.com/users/vbalazs/following{/other_user}","gists_url":"https://api.github.com/users/vbalazs/gists{/gist_id}","starred_url":"https://api.github.com/users/vbalazs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbalazs/subscriptions","organizations_url":"https://api.github.com/users/vbalazs/orgs","repos_url":"https://api.github.com/users/vbalazs/repos","events_url":"https://api.github.com/users/vbalazs/events{/privacy}","received_events_url":"https://api.github.com/users/vbalazs/received_events","type":"User","site_admin":false},"repo":{"id":21814315,"name":"drupal-quickstart","full_name":"vbalazs/drupal-quickstart","owner":{"login":"vbalazs","id":281883,"avatar_url":"https://avatars.githubusercontent.com/u/281883?","gravatar_id":"bf739e2caa630cd8c97289ad9b8e7b2f","url":"https://api.github.com/users/vbalazs","html_url":"https://github.com/vbalazs","followers_url":"https://api.github.com/users/vbalazs/followers","following_url":"https://api.github.com/users/vbalazs/following{/other_user}","gists_url":"https://api.github.com/users/vbalazs/gists{/gist_id}","starred_url":"https://api.github.com/users/vbalazs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbalazs/subscriptions","organizations_url":"https://api.github.com/users/vbalazs/orgs","repos_url":"https://api.github.com/users/vbalazs/repos","events_url":"https://api.github.com/users/vbalazs/events{/privacy}","received_events_url":"https://api.github.com/users/vbalazs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vbalazs/drupal-quickstart","description":"A simple easy to use Drupal installation on OpenShift that will do it all for you!","fork":true,"url":"https://api.github.com/repos/vbalazs/drupal-quickstart","forks_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/forks","keys_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/teams","hooks_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/hooks","issue_events_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/issues/events{/number}","events_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/events","assignees_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/assignees{/user}","branches_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/branches{/branch}","tags_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/tags","blobs_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/git/refs{/sha}","trees_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/statuses/{sha}","languages_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/languages","stargazers_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/stargazers","contributors_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/contributors","subscribers_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/subscribers","subscription_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/subscription","commits_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/commits{/sha}","git_commits_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/git/commits{/sha}","comments_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/comments{/number}","issue_comment_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/issues/comments/{number}","contents_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/contents/{+path}","compare_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/merges","archive_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/downloads","issues_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/issues{/number}","pulls_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/pulls{/number}","milestones_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/milestones{/number}","notifications_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/labels{/name}","releases_url":"https://api.github.com/repos/vbalazs/drupal-quickstart/releases{/id}","created_at":"2014-07-14T09:30:48Z","updated_at":"2014-06-24T08:28:53Z","pushed_at":"2014-07-18T13:35:41Z","git_url":"git://github.com/vbalazs/drupal-quickstart.git","ssh_url":"git@github.com:vbalazs/drupal-quickstart.git","clone_url":"https://github.com/vbalazs/drupal-quickstart.git","svn_url":"https://github.com/vbalazs/drupal-quickstart","homepage":"https://www.openshift.com","size":132,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f2fb2b54a6f53a245943a2d4918ed01afd51ab32","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?","gravatar_id":"e1dc239e6684a7249770e95cafbb8f0a","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":7723134,"name":"drupal-quickstart","full_name":"openshift/drupal-quickstart","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?","gravatar_id":"e1dc239e6684a7249770e95cafbb8f0a","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/drupal-quickstart","description":"A simple easy to use Drupal installation on OpenShift that will do it all for you!","fork":false,"url":"https://api.github.com/repos/openshift/drupal-quickstart","forks_url":"https://api.github.com/repos/openshift/drupal-quickstart/forks","keys_url":"https://api.github.com/repos/openshift/drupal-quickstart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/drupal-quickstart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/drupal-quickstart/teams","hooks_url":"https://api.github.com/repos/openshift/drupal-quickstart/hooks","issue_events_url":"https://api.github.com/repos/openshift/drupal-quickstart/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/drupal-quickstart/events","assignees_url":"https://api.github.com/repos/openshift/drupal-quickstart/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/drupal-quickstart/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/drupal-quickstart/tags","blobs_url":"https://api.github.com/repos/openshift/drupal-quickstart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/drupal-quickstart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/drupal-quickstart/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/drupal-quickstart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/drupal-quickstart/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/drupal-quickstart/languages","stargazers_url":"https://api.github.com/repos/openshift/drupal-quickstart/stargazers","contributors_url":"https://api.github.com/repos/openshift/drupal-quickstart/contributors","subscribers_url":"https://api.github.com/repos/openshift/drupal-quickstart/subscribers","subscription_url":"https://api.github.com/repos/openshift/drupal-quickstart/subscription","commits_url":"https://api.github.com/repos/openshift/drupal-quickstart/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/drupal-quickstart/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/drupal-quickstart/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/drupal-quickstart/issues/comments/{number}","contents_url":"https://api.github.com/repos/openshift/drupal-quickstart/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/drupal-quickstart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/drupal-quickstart/merges","archive_url":"https://api.github.com/repos/openshift/drupal-quickstart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/drupal-quickstart/downloads","issues_url":"https://api.github.com/repos/openshift/drupal-quickstart/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/drupal-quickstart/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/drupal-quickstart/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/drupal-quickstart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/drupal-quickstart/labels{/name}","releases_url":"https://api.github.com/repos/openshift/drupal-quickstart/releases{/id}","created_at":"2013-01-20T22:56:51Z","updated_at":"2014-06-24T08:28:53Z","pushed_at":"2014-03-14T14:15:36Z","git_url":"git://github.com/openshift/drupal-quickstart.git","ssh_url":"git@github.com:openshift/drupal-quickstart.git","clone_url":"https://github.com/openshift/drupal-quickstart.git","svn_url":"https://github.com/openshift/drupal-quickstart","homepage":"https://www.openshift.com","size":295,"stargazers_count":31,"watchers_count":31,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":62,"mirror_url":null,"open_issues_count":3,"forks":62,"open_issues":3,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/21"},"html":{"href":"https://github.com/openshift/drupal-quickstart/pull/21"},"issue":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/issues/21"},"comments":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/drupal-quickstart/statuses/44b424fa58394fb93816971597b5c8208ebea3cc"}}}}