GitHub PullRequestReviewCommentEvent at 2014-06-20 14:04:46
Repository: Ghost
Actor: jaswilli
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/14020784","id":14020784,"diff_hunk":"@@ -2,15 +2,17 @@\n var UploadController = Ember.Controller.extend({\n     acceptEncoding: 'image/*',\n     actions: {\n-        confirmReject: function () {\n-            return true;\n-        }\n-    },\n+        confirmAccept: function () {\n+            var self = this;\n \n-    confirm: {\n-        reject: {\n-            buttonClass: true,\n-            text: 'Cancel' // The reject button text\n+            this.get('model').save().then(function (model) {\n+                self.notifications.showSuccess('Saved');","path":"core/client/controllers/modals/upload.js","position":16,"original_position":16,"commit_id":"1453a1d04ef01b4a6a30ffd9cf80726072c6a662","original_commit_id":"1453a1d04ef01b4a6a30ffd9cf80726072c6a662","user":{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?","gravatar_id":"6938cd29229817beeac9a4f5c20ddd43","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},"body":"It could, but \"Saved\" is what the existing admin client uses.  There are a lot of functional tests for the admin client that check the text output of notifications, so it's best to try and make the output from Ember admin match.\r\n\r\nThings like this can change once Ember admin has settled and is backed by tests.","created_at":"2014-06-20T14:04:46Z","updated_at":"2014-06-20T14:04:46Z","html_url":"https://github.com/TryGhost/Ghost/pull/3003#discussion_r14020784","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/3003","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/14020784"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/3003#discussion_r14020784"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/3003"}}},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/3003","id":17389124,"html_url":"https://github.com/TryGhost/Ghost/pull/3003","diff_url":"https://github.com/TryGhost/Ghost/pull/3003.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/3003.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/3003","number":3003,"state":"open","title":"Convert general settings page to ember data","user":{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?","gravatar_id":"6938cd29229817beeac9a4f5c20ddd43","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},"body":"Issue #2846\r\n-Implement custom RESTAdapter and serializer for settings data.\r\n-Convert theme selector to Ember.Select.\r\n-Finish upload modal and wire into settings page.","created_at":"2014-06-20T04:41:45Z","updated_at":"2014-06-20T14:04:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e192d9de0bb94e654cba0ea2426c4e7f34da0746","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/3003/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/3003/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/3003/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/1453a1d04ef01b4a6a30ffd9cf80726072c6a662","head":{"label":"jaswilli:issue-2846-settings","ref":"issue-2846-settings","sha":"1453a1d04ef01b4a6a30ffd9cf80726072c6a662","user":{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?","gravatar_id":"6938cd29229817beeac9a4f5c20ddd43","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},"repo":{"id":17843863,"name":"Ghost","full_name":"jaswilli/Ghost","owner":{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?","gravatar_id":"6938cd29229817beeac9a4f5c20ddd43","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaswilli/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/jaswilli/Ghost","forks_url":"https://api.github.com/repos/jaswilli/Ghost/forks","keys_url":"https://api.github.com/repos/jaswilli/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaswilli/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaswilli/Ghost/teams","hooks_url":"https://api.github.com/repos/jaswilli/Ghost/hooks","issue_events_url":"https://api.github.com/repos/jaswilli/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/jaswilli/Ghost/events","assignees_url":"https://api.github.com/repos/jaswilli/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/jaswilli/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/jaswilli/Ghost/tags","blobs_url":"https://api.github.com/repos/jaswilli/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaswilli/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaswilli/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaswilli/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaswilli/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/jaswilli/Ghost/languages","stargazers_url":"https://api.github.com/repos/jaswilli/Ghost/stargazers","contributors_url":"https://api.github.com/repos/jaswilli/Ghost/contributors","subscribers_url":"https://api.github.com/repos/jaswilli/Ghost/subscribers","subscription_url":"https://api.github.com/repos/jaswilli/Ghost/subscription","commits_url":"https://api.github.com/repos/jaswilli/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaswilli/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaswilli/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaswilli/Ghost/issues/comments/{number}","contents_url":"https://api.github.com/repos/jaswilli/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/jaswilli/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaswilli/Ghost/merges","archive_url":"https://api.github.com/repos/jaswilli/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaswilli/Ghost/downloads","issues_url":"https://api.github.com/repos/jaswilli/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/jaswilli/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/jaswilli/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/jaswilli/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaswilli/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/jaswilli/Ghost/releases{/id}","created_at":"2014-03-17T21:23:46Z","updated_at":"2014-06-20T04:41:45Z","pushed_at":"2014-06-20T04:39:41Z","git_url":"git://github.com/jaswilli/Ghost.git","ssh_url":"git@github.com:jaswilli/Ghost.git","clone_url":"https://github.com/jaswilli/Ghost.git","svn_url":"https://github.com/jaswilli/Ghost","homepage":"https://ghost.org","size":11538,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"0c006927995669656bd8fbb76ba2f8bc5d764810","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?","gravatar_id":"238913f75ec6bb96e5a02f96ac50c9d8","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?","gravatar_id":"238913f75ec6bb96e5a02f96ac50c9d8","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"Just a blogging platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments/{number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","created_at":"2013-05-04T11:09:13Z","updated_at":"2014-06-20T13:01:12Z","pushed_at":"2014-06-20T13:01:12Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":42723,"stargazers_count":11082,"watchers_count":11082,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2235,"mirror_url":null,"open_issues_count":271,"forks":2235,"open_issues":271,"watchers":11082,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/3003"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/3003"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/3003"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/3003/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/3003/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/3003/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/1453a1d04ef01b4a6a30ffd9cf80726072c6a662"}}}}