GitHub PullRequestReviewCommentEvent at 2014-02-23 14:16:56
Repository: kloxo
Actor: dterweij
Payload: {"comment":{"url":"https://api.github.com/repos/lxcenter/kloxo/pulls/comments/9975884","id":9975884,"diff_hunk":"@@ -35,23 +35,39 @@ echo \"################################\"\n echo \"### Start packaging\"\n echo \"### read version...\"\n # Read version\n-# Please note, this must be a running machine with SVN version!\n-if ! [ -f /script/version ] ; then\n-        echo \"## Packaging failed. No /script/version found.\"\n-\techo \"## Are you sure you are running a development version?\"\n-\techo \"### Aborted.\"\n-\techo \"################################\"\n-        exit\n+# Please note, this must be a running machine with SVN version (SUURE need to change that)!\n+if [ ! -d '../.git' ]; then\n+\techo \"### read version...\"\n+\tif ! [ -f /script/version ] ; then\n+\t\techo \"## Packaging failed. No /script/version found.\"\n+\t\techo \"## Are you sure you are running a development version?\"\n+\t\techo \"### Aborted.\"\n+\t\techo \"################################\"\n+        \texit\n+\tfi\n+      buildtype=0\n+\tversion=`/script/version`\n+\tbuild=`git log --pretty=format:'' | wc -l`\n+\trm -f kloxo-$version.$build.zip\t\n+else\n+\tbuildtype=1\n+    \t  version='current'\n+ \t  build=''\n+\t  rm -f kloxo-$version.zip","path":"kloxo/make-distribution.sh","position":29,"original_position":29,"commit_id":"32e78f44dbb3f5aea8472be43529826c7fa80f8f","original_commit_id":"32e78f44dbb3f5aea8472be43529826c7fa80f8f","user":{"login":"dterweij","id":1059028,"avatar_url":"https://gravatar.com/avatar/a262d2ef96ea969e4974dc98a48e0ba9?d=https%3A%2F%2Fidenticons.github.com%2F936d7eeb19c4309e45cb7a0b3e313f86.png&r=x","gravatar_id":"a262d2ef96ea969e4974dc98a48e0ba9","url":"https://api.github.com/users/dterweij","html_url":"https://github.com/dterweij","followers_url":"https://api.github.com/users/dterweij/followers","following_url":"https://api.github.com/users/dterweij/following{/other_user}","gists_url":"https://api.github.com/users/dterweij/gists{/gist_id}","starred_url":"https://api.github.com/users/dterweij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dterweij/subscriptions","organizations_url":"https://api.github.com/users/dterweij/orgs","repos_url":"https://api.github.com/users/dterweij/repos","events_url":"https://api.github.com/users/dterweij/events{/privacy}","received_events_url":"https://api.github.com/users/dterweij/received_events","type":"User","site_admin":false},"body":"Reached here when found .git. So need kloxo-$version.$build.zip here.","created_at":"2014-02-23T14:16:56Z","updated_at":"2014-02-23T14:16:56Z","html_url":"https://github.com/lxcenter/kloxo/pull/102#discussion_r9975884","pull_request_url":"https://api.github.com/repos/lxcenter/kloxo/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/lxcenter/kloxo/pulls/comments/9975884"},"html":{"href":"https://github.com/lxcenter/kloxo/pull/102#discussion_r9975884"},"pull_request":{"href":"https://api.github.com/repos/lxcenter/kloxo/pulls/102"}}}}