GitHub PullRequestReviewCommentEvent at 2014-07-30 22:05:01
Repository: core
Actor: bantu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/15615716","id":15615716,"diff_hunk":"@@ -135,7 +135,7 @@ public static function initPaths() {\n \t\tOC::$THIRDPARTYROOT = OC_Config::getValue('3rdpartyroot', null);\n \t\tOC::$THIRDPARTYWEBROOT = OC_Config::getValue('3rdpartyurl', null);\n \t\t\n-\t\tif (is_null(OC::$THIRDPARTYROOT) && is_null(OC::$THIRDPARTYWEBROOT)) {\n+\t\tif (empty(OC::$THIRDPARTYROOT) && empty(OC::$THIRDPARTYWEBROOT)) {","path":"lib/base.php","position":5,"original_position":5,"commit_id":"f2e20757f6198bc49e139c62acdb965a11767093","original_commit_id":"f2e20757f6198bc49e139c62acdb965a11767093","user":{"login":"bantu","id":189375,"avatar_url":"https://avatars.githubusercontent.com/u/189375?v=1","gravatar_id":"88483d87947219efecfc570465c753b2","url":"https://api.github.com/users/bantu","html_url":"https://github.com/bantu","followers_url":"https://api.github.com/users/bantu/followers","following_url":"https://api.github.com/users/bantu/following{/other_user}","gists_url":"https://api.github.com/users/bantu/gists{/gist_id}","starred_url":"https://api.github.com/users/bantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantu/subscriptions","organizations_url":"https://api.github.com/users/bantu/orgs","repos_url":"https://api.github.com/users/bantu/repos","events_url":"https://api.github.com/users/bantu/events{/privacy}","received_events_url":"https://api.github.com/users/bantu/received_events","type":"User","site_admin":false},"body":"`OC::$THIRDPARTYROOT` is a variable, so this is fine?","created_at":"2014-07-30T22:05:01Z","updated_at":"2014-07-30T22:05:01Z","html_url":"https://github.com/owncloud/core/pull/10066#discussion_r15615716","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/10066","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/15615716"},"html":{"href":"https://github.com/owncloud/core/pull/10066#discussion_r15615716"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/10066"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/10066","id":19118715,"html_url":"https://github.com/owncloud/core/pull/10066","diff_url":"https://github.com/owncloud/core/pull/10066.diff","patch_url":"https://github.com/owncloud/core/pull/10066.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/10066","number":10066,"state":"open","title":"Fix checking of NULL or empty OC::$THIRDPARTYROOT/OC::$THIRDPARTYWEBROOT","user":{"login":"marc0s","id":273769,"avatar_url":"https://avatars.githubusercontent.com/u/273769?v=1","gravatar_id":"a7731e6040c81b44f241f2d6ca811d4f","url":"https://api.github.com/users/marc0s","html_url":"https://github.com/marc0s","followers_url":"https://api.github.com/users/marc0s/followers","following_url":"https://api.github.com/users/marc0s/following{/other_user}","gists_url":"https://api.github.com/users/marc0s/gists{/gist_id}","starred_url":"https://api.github.com/users/marc0s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc0s/subscriptions","organizations_url":"https://api.github.com/users/marc0s/orgs","repos_url":"https://api.github.com/users/marc0s/repos","events_url":"https://api.github.com/users/marc0s/events{/privacy}","received_events_url":"https://api.github.com/users/marc0s/received_events","type":"User","site_admin":false},"body":"Fixes #10065\r\n\r\nSee issue for details.","created_at":"2014-07-30T21:26:24Z","updated_at":"2014-07-30T22:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53ed4c9c8287bd7b59b08930fd4d1f44d96ca136","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/core/pulls/10066/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/10066/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/10066/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/f2e20757f6198bc49e139c62acdb965a11767093","head":{"label":"marc0s:issues/10065-fix-null-check","ref":"issues/10065-fix-null-check","sha":"f2e20757f6198bc49e139c62acdb965a11767093","user":{"login":"marc0s","id":273769,"avatar_url":"https://avatars.githubusercontent.com/u/273769?v=1","gravatar_id":"a7731e6040c81b44f241f2d6ca811d4f","url":"https://api.github.com/users/marc0s","html_url":"https://github.com/marc0s","followers_url":"https://api.github.com/users/marc0s/followers","following_url":"https://api.github.com/users/marc0s/following{/other_user}","gists_url":"https://api.github.com/users/marc0s/gists{/gist_id}","starred_url":"https://api.github.com/users/marc0s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc0s/subscriptions","organizations_url":"https://api.github.com/users/marc0s/orgs","repos_url":"https://api.github.com/users/marc0s/repos","events_url":"https://api.github.com/users/marc0s/events{/privacy}","received_events_url":"https://api.github.com/users/marc0s/received_events","type":"User","site_admin":false},"repo":{"id":22444961,"name":"core","full_name":"marc0s/core","owner":{"login":"marc0s","id":273769,"avatar_url":"https://avatars.githubusercontent.com/u/273769?v=1","gravatar_id":"a7731e6040c81b44f241f2d6ca811d4f","url":"https://api.github.com/users/marc0s","html_url":"https://github.com/marc0s","followers_url":"https://api.github.com/users/marc0s/followers","following_url":"https://api.github.com/users/marc0s/following{/other_user}","gists_url":"https://api.github.com/users/marc0s/gists{/gist_id}","starred_url":"https://api.github.com/users/marc0s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc0s/subscriptions","organizations_url":"https://api.github.com/users/marc0s/orgs","repos_url":"https://api.github.com/users/marc0s/repos","events_url":"https://api.github.com/users/marc0s/events{/privacy}","received_events_url":"https://api.github.com/users/marc0s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marc0s/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/marc0s/core","forks_url":"https://api.github.com/repos/marc0s/core/forks","keys_url":"https://api.github.com/repos/marc0s/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marc0s/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marc0s/core/teams","hooks_url":"https://api.github.com/repos/marc0s/core/hooks","issue_events_url":"https://api.github.com/repos/marc0s/core/issues/events{/number}","events_url":"https://api.github.com/repos/marc0s/core/events","assignees_url":"https://api.github.com/repos/marc0s/core/assignees{/user}","branches_url":"https://api.github.com/repos/marc0s/core/branches{/branch}","tags_url":"https://api.github.com/repos/marc0s/core/tags","blobs_url":"https://api.github.com/repos/marc0s/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marc0s/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marc0s/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/marc0s/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marc0s/core/statuses/{sha}","languages_url":"https://api.github.com/repos/marc0s/core/languages","stargazers_url":"https://api.github.com/repos/marc0s/core/stargazers","contributors_url":"https://api.github.com/repos/marc0s/core/contributors","subscribers_url":"https://api.github.com/repos/marc0s/core/subscribers","subscription_url":"https://api.github.com/repos/marc0s/core/subscription","commits_url":"https://api.github.com/repos/marc0s/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/marc0s/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/marc0s/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/marc0s/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/marc0s/core/contents/{+path}","compare_url":"https://api.github.com/repos/marc0s/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marc0s/core/merges","archive_url":"https://api.github.com/repos/marc0s/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marc0s/core/downloads","issues_url":"https://api.github.com/repos/marc0s/core/issues{/number}","pulls_url":"https://api.github.com/repos/marc0s/core/pulls{/number}","milestones_url":"https://api.github.com/repos/marc0s/core/milestones{/number}","notifications_url":"https://api.github.com/repos/marc0s/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marc0s/core/labels{/name}","releases_url":"https://api.github.com/repos/marc0s/core/releases{/id}","created_at":"2014-07-30T21:13:37Z","updated_at":"2014-07-30T20:43:14Z","pushed_at":"2014-07-30T21:25:09Z","git_url":"git://github.com/marc0s/core.git","ssh_url":"git@github.com:marc0s/core.git","clone_url":"https://github.com/marc0s/core.git","svn_url":"https://github.com/marc0s/core","homepage":null,"size":624427,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"fd1bb688f9ad84bd04d38323a0f78aab79a2a59f","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=1","gravatar_id":"021e207e86fe81a7d81c67ef1ff38a0c","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=1","gravatar_id":"021e207e86fe81a7d81c67ef1ff38a0c","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2014-07-30T20:43:14Z","pushed_at":"2014-07-30T21:46:21Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":null,"size":624427,"stargazers_count":2400,"watchers_count":2400,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":790,"mirror_url":null,"open_issues_count":1176,"forks":790,"open_issues":1176,"watchers":2400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/10066"},"html":{"href":"https://github.com/owncloud/core/pull/10066"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/10066"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/10066/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/10066/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/10066/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/f2e20757f6198bc49e139c62acdb965a11767093"}}}}