GitHub PullRequestReviewCommentEvent at 2014-12-04 15:25:32
Repository: spark
Actor: WangTaoTheTonic
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/21310507","id":21310507,"diff_hunk":"@@ -107,6 +108,10 @@ private[spark] class SparkSubmitArguments(args: Seq[String], env: Map[String, St\n       .orElse(sparkProperties.get(\"spark.driver.memory\"))\n       .orElse(env.get(\"SPARK_DRIVER_MEMORY\"))\n       .orNull\n+    amMemory = Option(amMemory)\n+        .orElse(sparkProperties.get(\"spark.yarn.appMaster.memory\"))\n+        .orElse(env.get(\"SPARK_YARN_AM_MEMORY\"))","path":"core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala","position":14,"original_position":14,"commit_id":"0566bb89318a848ee6d2f551430d9fd135a22c7d","original_commit_id":"0566bb89318a848ee6d2f551430d9fd135a22c7d","user":{"login":"WangTaoTheTonic","id":5276001,"avatar_url":"https://avatars.githubusercontent.com/u/5276001?v=3","gravatar_id":"","url":"https://api.github.com/users/WangTaoTheTonic","html_url":"https://github.com/WangTaoTheTonic","followers_url":"https://api.github.com/users/WangTaoTheTonic/followers","following_url":"https://api.github.com/users/WangTaoTheTonic/following{/other_user}","gists_url":"https://api.github.com/users/WangTaoTheTonic/gists{/gist_id}","starred_url":"https://api.github.com/users/WangTaoTheTonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangTaoTheTonic/subscriptions","organizations_url":"https://api.github.com/users/WangTaoTheTonic/orgs","repos_url":"https://api.github.com/users/WangTaoTheTonic/repos","events_url":"https://api.github.com/users/WangTaoTheTonic/events{/privacy}","received_events_url":"https://api.github.com/users/WangTaoTheTonic/received_events","type":"User","site_admin":false},"body":"Got it. ","created_at":"2014-12-04T15:25:32Z","updated_at":"2014-12-04T15:25:32Z","html_url":"https://github.com/apache/spark/pull/3607#discussion_r21310507","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/3607","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/21310507"},"html":{"href":"https://github.com/apache/spark/pull/3607#discussion_r21310507"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/3607"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3607","id":25497118,"html_url":"https://github.com/apache/spark/pull/3607","diff_url":"https://github.com/apache/spark/pull/3607.diff","patch_url":"https://github.com/apache/spark/pull/3607.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3607","number":3607,"state":"open","locked":false,"title":"[SPARK-1953]yarn client mode Application Master memory size is same as driver memory...","user":{"login":"WangTaoTheTonic","id":5276001,"avatar_url":"https://avatars.githubusercontent.com/u/5276001?v=3","gravatar_id":"","url":"https://api.github.com/users/WangTaoTheTonic","html_url":"https://github.com/WangTaoTheTonic","followers_url":"https://api.github.com/users/WangTaoTheTonic/followers","following_url":"https://api.github.com/users/WangTaoTheTonic/following{/other_user}","gists_url":"https://api.github.com/users/WangTaoTheTonic/gists{/gist_id}","starred_url":"https://api.github.com/users/WangTaoTheTonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangTaoTheTonic/subscriptions","organizations_url":"https://api.github.com/users/WangTaoTheTonic/orgs","repos_url":"https://api.github.com/users/WangTaoTheTonic/repos","events_url":"https://api.github.com/users/WangTaoTheTonic/events{/privacy}","received_events_url":"https://api.github.com/users/WangTaoTheTonic/received_events","type":"User","site_admin":false},"body":"... size\r\n\r\nWays to set Application Master's memory on yarn-client mode:\r\n1.  `--am-memory MEM` in SparkSubmit args\r\n2.  `spark.yarn.appMaster.memory` in SparkConf or System Properties\r\n3.  `SPARK_YARN_AM_MEMORY` in System env\r\n4.  default value 512m\r\n\r\nNote: this arguments is only available in yarn-client mode.\r\n\r\n","created_at":"2014-12-04T13:58:16Z","updated_at":"2014-12-04T15:25:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40a04927acfe5bf85b94a7aa527ca1d19d7fc4d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3607/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3607/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3607/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0566bb89318a848ee6d2f551430d9fd135a22c7d","head":{"label":"WangTaoTheTonic:SPARK4181","ref":"SPARK4181","sha":"0566bb89318a848ee6d2f551430d9fd135a22c7d","user":{"login":"WangTaoTheTonic","id":5276001,"avatar_url":"https://avatars.githubusercontent.com/u/5276001?v=3","gravatar_id":"","url":"https://api.github.com/users/WangTaoTheTonic","html_url":"https://github.com/WangTaoTheTonic","followers_url":"https://api.github.com/users/WangTaoTheTonic/followers","following_url":"https://api.github.com/users/WangTaoTheTonic/following{/other_user}","gists_url":"https://api.github.com/users/WangTaoTheTonic/gists{/gist_id}","starred_url":"https://api.github.com/users/WangTaoTheTonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangTaoTheTonic/subscriptions","organizations_url":"https://api.github.com/users/WangTaoTheTonic/orgs","repos_url":"https://api.github.com/users/WangTaoTheTonic/repos","events_url":"https://api.github.com/users/WangTaoTheTonic/events{/privacy}","received_events_url":"https://api.github.com/users/WangTaoTheTonic/received_events","type":"User","site_admin":false},"repo":{"id":18954614,"name":"spark","full_name":"WangTaoTheTonic/spark","owner":{"login":"WangTaoTheTonic","id":5276001,"avatar_url":"https://avatars.githubusercontent.com/u/5276001?v=3","gravatar_id":"","url":"https://api.github.com/users/WangTaoTheTonic","html_url":"https://github.com/WangTaoTheTonic","followers_url":"https://api.github.com/users/WangTaoTheTonic/followers","following_url":"https://api.github.com/users/WangTaoTheTonic/following{/other_user}","gists_url":"https://api.github.com/users/WangTaoTheTonic/gists{/gist_id}","starred_url":"https://api.github.com/users/WangTaoTheTonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangTaoTheTonic/subscriptions","organizations_url":"https://api.github.com/users/WangTaoTheTonic/orgs","repos_url":"https://api.github.com/users/WangTaoTheTonic/repos","events_url":"https://api.github.com/users/WangTaoTheTonic/events{/privacy}","received_events_url":"https://api.github.com/users/WangTaoTheTonic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WangTaoTheTonic/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/WangTaoTheTonic/spark","forks_url":"https://api.github.com/repos/WangTaoTheTonic/spark/forks","keys_url":"https://api.github.com/repos/WangTaoTheTonic/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WangTaoTheTonic/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WangTaoTheTonic/spark/teams","hooks_url":"https://api.github.com/repos/WangTaoTheTonic/spark/hooks","issue_events_url":"https://api.github.com/repos/WangTaoTheTonic/spark/issues/events{/number}","events_url":"https://api.github.com/repos/WangTaoTheTonic/spark/events","assignees_url":"https://api.github.com/repos/WangTaoTheTonic/spark/assignees{/user}","branches_url":"https://api.github.com/repos/WangTaoTheTonic/spark/branches{/branch}","tags_url":"https://api.github.com/repos/WangTaoTheTonic/spark/tags","blobs_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WangTaoTheTonic/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/WangTaoTheTonic/spark/languages","stargazers_url":"https://api.github.com/repos/WangTaoTheTonic/spark/stargazers","contributors_url":"https://api.github.com/repos/WangTaoTheTonic/spark/contributors","subscribers_url":"https://api.github.com/repos/WangTaoTheTonic/spark/subscribers","subscription_url":"https://api.github.com/repos/WangTaoTheTonic/spark/subscription","commits_url":"https://api.github.com/repos/WangTaoTheTonic/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/WangTaoTheTonic/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/WangTaoTheTonic/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/WangTaoTheTonic/spark/contents/{+path}","compare_url":"https://api.github.com/repos/WangTaoTheTonic/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WangTaoTheTonic/spark/merges","archive_url":"https://api.github.com/repos/WangTaoTheTonic/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WangTaoTheTonic/spark/downloads","issues_url":"https://api.github.com/repos/WangTaoTheTonic/spark/issues{/number}","pulls_url":"https://api.github.com/repos/WangTaoTheTonic/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/WangTaoTheTonic/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/WangTaoTheTonic/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WangTaoTheTonic/spark/labels{/name}","releases_url":"https://api.github.com/repos/WangTaoTheTonic/spark/releases{/id}","created_at":"2014-04-20T01:10:21Z","updated_at":"2014-11-25T14:23:14Z","pushed_at":"2014-12-04T13:45:27Z","git_url":"git://github.com/WangTaoTheTonic/spark.git","ssh_url":"git@github.com:WangTaoTheTonic/spark.git","clone_url":"https://github.com/WangTaoTheTonic/spark.git","svn_url":"https://github.com/WangTaoTheTonic/spark","homepage":null,"size":97949,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7e758d709286e73d2c878d4a2d2b4606386142c7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-12-04T12:17:39Z","pushed_at":"2014-12-04T12:18:19Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":987904,"stargazers_count":2221,"watchers_count":2221,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1983,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":321,"forks":1983,"open_issues":321,"watchers":2221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3607"},"html":{"href":"https://github.com/apache/spark/pull/3607"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3607"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3607/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3607/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3607/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0566bb89318a848ee6d2f551430d9fd135a22c7d"}}}}