GitHub PullRequestReviewCommentEvent at 2014-12-29 14:19:36
Repository: gaia
Actor: chirarobert
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/22312789","id":22312789,"diff_hunk":"@@ -0,0 +1,61 @@\n+# This Source Code Form is subject to the terms of the Mozilla Public","path":"tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/fxaccounts.py","position":1,"original_position":1,"commit_id":"4217acc92c1c114d175f2a35f7ff61d37ec1f586","original_commit_id":"4217acc92c1c114d175f2a35f7ff61d37ec1f586","user":{"login":"chirarobert","id":6347849,"avatar_url":"https://avatars.githubusercontent.com/u/6347849?v=3","gravatar_id":"","url":"https://api.github.com/users/chirarobert","html_url":"https://github.com/chirarobert","followers_url":"https://api.github.com/users/chirarobert/followers","following_url":"https://api.github.com/users/chirarobert/following{/other_user}","gists_url":"https://api.github.com/users/chirarobert/gists{/gist_id}","starred_url":"https://api.github.com/users/chirarobert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirarobert/subscriptions","organizations_url":"https://api.github.com/users/chirarobert/orgs","repos_url":"https://api.github.com/users/chirarobert/repos","events_url":"https://api.github.com/users/chirarobert/events{/privacy}","received_events_url":"https://api.github.com/users/chirarobert/received_events","type":"User","site_admin":false},"body":"From the code it looks like the fxa page is in the system app, I would suggest moving the file there instead of the settings folder. @mwargers @JohanLorenzo What do you guys think?","created_at":"2014-12-29T14:19:36Z","updated_at":"2014-12-29T14:19:36Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/26829#discussion_r22312789","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26829","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/22312789"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26829#discussion_r22312789"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26829"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26829","id":26185717,"html_url":"https://github.com/mozilla-b2g/gaia/pull/26829","diff_url":"https://github.com/mozilla-b2g/gaia/pull/26829.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/26829.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26829","number":26829,"state":"open","locked":false,"title":"Bug 1112334 - Write a test for basic Find My Device logging in existing ...","user":{"login":"mwargers","id":2105568,"avatar_url":"https://avatars.githubusercontent.com/u/2105568?v=3","gravatar_id":"","url":"https://api.github.com/users/mwargers","html_url":"https://github.com/mwargers","followers_url":"https://api.github.com/users/mwargers/followers","following_url":"https://api.github.com/users/mwargers/following{/other_user}","gists_url":"https://api.github.com/users/mwargers/gists{/gist_id}","starred_url":"https://api.github.com/users/mwargers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwargers/subscriptions","organizations_url":"https://api.github.com/users/mwargers/orgs","repos_url":"https://api.github.com/users/mwargers/repos","events_url":"https://api.github.com/users/mwargers/events{/privacy}","received_events_url":"https://api.github.com/users/mwargers/received_events","type":"User","site_admin":false},"body":"...account","created_at":"2014-12-16T22:30:25Z","updated_at":"2014-12-29T14:19:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"709166765f156154967ba0b07a56ff7b37e796a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26829/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26829/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26829/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4217acc92c1c114d175f2a35f7ff61d37ec1f586","head":{"label":"mwargers:findmydevice","ref":"findmydevice","sha":"4217acc92c1c114d175f2a35f7ff61d37ec1f586","user":{"login":"mwargers","id":2105568,"avatar_url":"https://avatars.githubusercontent.com/u/2105568?v=3","gravatar_id":"","url":"https://api.github.com/users/mwargers","html_url":"https://github.com/mwargers","followers_url":"https://api.github.com/users/mwargers/followers","following_url":"https://api.github.com/users/mwargers/following{/other_user}","gists_url":"https://api.github.com/users/mwargers/gists{/gist_id}","starred_url":"https://api.github.com/users/mwargers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwargers/subscriptions","organizations_url":"https://api.github.com/users/mwargers/orgs","repos_url":"https://api.github.com/users/mwargers/repos","events_url":"https://api.github.com/users/mwargers/events{/privacy}","received_events_url":"https://api.github.com/users/mwargers/received_events","type":"User","site_admin":false},"repo":{"id":24760261,"name":"gaia","full_name":"mwargers/gaia","owner":{"login":"mwargers","id":2105568,"avatar_url":"https://avatars.githubusercontent.com/u/2105568?v=3","gravatar_id":"","url":"https://api.github.com/users/mwargers","html_url":"https://github.com/mwargers","followers_url":"https://api.github.com/users/mwargers/followers","following_url":"https://api.github.com/users/mwargers/following{/other_user}","gists_url":"https://api.github.com/users/mwargers/gists{/gist_id}","starred_url":"https://api.github.com/users/mwargers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwargers/subscriptions","organizations_url":"https://api.github.com/users/mwargers/orgs","repos_url":"https://api.github.com/users/mwargers/repos","events_url":"https://api.github.com/users/mwargers/events{/privacy}","received_events_url":"https://api.github.com/users/mwargers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwargers/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/mwargers/gaia","forks_url":"https://api.github.com/repos/mwargers/gaia/forks","keys_url":"https://api.github.com/repos/mwargers/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwargers/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwargers/gaia/teams","hooks_url":"https://api.github.com/repos/mwargers/gaia/hooks","issue_events_url":"https://api.github.com/repos/mwargers/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mwargers/gaia/events","assignees_url":"https://api.github.com/repos/mwargers/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mwargers/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mwargers/gaia/tags","blobs_url":"https://api.github.com/repos/mwargers/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwargers/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwargers/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwargers/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwargers/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mwargers/gaia/languages","stargazers_url":"https://api.github.com/repos/mwargers/gaia/stargazers","contributors_url":"https://api.github.com/repos/mwargers/gaia/contributors","subscribers_url":"https://api.github.com/repos/mwargers/gaia/subscribers","subscription_url":"https://api.github.com/repos/mwargers/gaia/subscription","commits_url":"https://api.github.com/repos/mwargers/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwargers/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwargers/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwargers/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mwargers/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mwargers/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwargers/gaia/merges","archive_url":"https://api.github.com/repos/mwargers/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwargers/gaia/downloads","issues_url":"https://api.github.com/repos/mwargers/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mwargers/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mwargers/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mwargers/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwargers/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mwargers/gaia/releases{/id}","created_at":"2014-10-03T13:54:50Z","updated_at":"2014-10-09T15:24:59Z","pushed_at":"2014-12-29T14:17:25Z","git_url":"git://github.com/mwargers/gaia.git","ssh_url":"git@github.com:mwargers/gaia.git","clone_url":"https://github.com/mwargers/gaia.git","svn_url":"https://github.com/mwargers/gaia","homepage":"https://wiki.mozilla.org/B2G","size":875096,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"3fdccaac6fb2de3f047204f9f749dabdb90efbba","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-12-29T13:49:30Z","pushed_at":"2014-12-29T13:49:30Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1361553,"stargazers_count":1834,"watchers_count":1834,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2136,"mirror_url":null,"open_issues_count":780,"forks":2136,"open_issues":780,"watchers":1834,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26829"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26829"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26829"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26829/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26829/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26829/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4217acc92c1c114d175f2a35f7ff61d37ec1f586"}}}}