GitHub PullRequestReviewCommentEvent at 2014-10-25 10:54:55
Repository: akka
Actor: mwegrz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/19374912","id":19374912,"diff_hunk":"@@ -355,6 +393,18 @@ abstract class ProcessorSpec(config: Config) extends AkkaSpec(config) with Persi\n       processor ! Persistent(\"b\")\n       List(0, 1, 2, 3) foreach (expectMsg(_))\n     }\n+\n+    \"be used as a stackable modification\" in {\n+      val processor = EventFilter.warning(message = \"aroundPreStart called\", occurrences = 1) intercept {","path":"akka-persistence/src/test/scala/akka/persistence/ProcessorSpec.scala","position":null,"original_position":51,"commit_id":"8b4e93dea3b562f9c4fbb41f91aad4495b0cda79","original_commit_id":"dd031defde2baaa0da927f736ebe9f36b492952b","user":{"login":"mwegrz","id":7756433,"avatar_url":"https://avatars.githubusercontent.com/u/7756433?v=2","gravatar_id":"","url":"https://api.github.com/users/mwegrz","html_url":"https://github.com/mwegrz","followers_url":"https://api.github.com/users/mwegrz/followers","following_url":"https://api.github.com/users/mwegrz/following{/other_user}","gists_url":"https://api.github.com/users/mwegrz/gists{/gist_id}","starred_url":"https://api.github.com/users/mwegrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwegrz/subscriptions","organizations_url":"https://api.github.com/users/mwegrz/orgs","repos_url":"https://api.github.com/users/mwegrz/repos","events_url":"https://api.github.com/users/mwegrz/events{/privacy}","received_events_url":"https://api.github.com/users/mwegrz/received_events","type":"User","site_admin":false},"body":"Thanks for review and comments. I have changed the test accordingly. Please verify.","created_at":"2014-10-25T10:54:55Z","updated_at":"2014-10-25T10:54:55Z","html_url":"https://github.com/akka/akka/pull/16126#discussion_r19374912","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/16126","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/19374912"},"html":{"href":"https://github.com/akka/akka/pull/16126#discussion_r19374912"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/16126"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/16126","id":23210668,"html_url":"https://github.com/akka/akka/pull/16126","diff_url":"https://github.com/akka/akka/pull/16126.diff","patch_url":"https://github.com/akka/akka/pull/16126.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/16126","number":16126,"state":"open","locked":false,"title":"=per #15937 Allow PersistentActor to be used as a stackable modification","user":{"login":"mwegrz","id":7756433,"avatar_url":"https://avatars.githubusercontent.com/u/7756433?v=2","gravatar_id":"","url":"https://api.github.com/users/mwegrz","html_url":"https://github.com/mwegrz","followers_url":"https://api.github.com/users/mwegrz/followers","following_url":"https://api.github.com/users/mwegrz/following{/other_user}","gists_url":"https://api.github.com/users/mwegrz/gists{/gist_id}","starred_url":"https://api.github.com/users/mwegrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwegrz/subscriptions","organizations_url":"https://api.github.com/users/mwegrz/orgs","repos_url":"https://api.github.com/users/mwegrz/repos","events_url":"https://api.github.com/users/mwegrz/events{/privacy}","received_events_url":"https://api.github.com/users/mwegrz/received_events","type":"User","site_admin":false},"body":"Fixes the problem reported in [#15937](http://github.com/akka/akka/issues/15937). PersistentActor now calls `super.around*` life-cycle hooks and allows to be mixed into e.g. ActorSubscriber. All current tests + new ones added by me have passed. Method preRestartDefault, lines 326-338 in Processor.scala needs closer attention as adding a call to `super.aroundPreRestart` caused some deeper refactoring - please see the comment in the source code.","created_at":"2014-10-23T07:25:35Z","updated_at":"2014-10-25T10:54:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f5e1b9d44bcdc3c12b8312d0f0dbdfdb5bc7765","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/16126/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/16126/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments/{number}","comments_url":"https://api.github.com/repos/akka/akka/issues/16126/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/8b4e93dea3b562f9c4fbb41f91aad4495b0cda79","head":{"label":"mwegrz:mwegrz-allow-persistentactor-to-be-used-as-a-stackable-modification","ref":"mwegrz-allow-persistentactor-to-be-used-as-a-stackable-modification","sha":"8b4e93dea3b562f9c4fbb41f91aad4495b0cda79","user":{"login":"mwegrz","id":7756433,"avatar_url":"https://avatars.githubusercontent.com/u/7756433?v=2","gravatar_id":"","url":"https://api.github.com/users/mwegrz","html_url":"https://github.com/mwegrz","followers_url":"https://api.github.com/users/mwegrz/followers","following_url":"https://api.github.com/users/mwegrz/following{/other_user}","gists_url":"https://api.github.com/users/mwegrz/gists{/gist_id}","starred_url":"https://api.github.com/users/mwegrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwegrz/subscriptions","organizations_url":"https://api.github.com/users/mwegrz/orgs","repos_url":"https://api.github.com/users/mwegrz/repos","events_url":"https://api.github.com/users/mwegrz/events{/privacy}","received_events_url":"https://api.github.com/users/mwegrz/received_events","type":"User","site_admin":false},"repo":{"id":25525824,"name":"akka","full_name":"mwegrz/akka","owner":{"login":"mwegrz","id":7756433,"avatar_url":"https://avatars.githubusercontent.com/u/7756433?v=2","gravatar_id":"","url":"https://api.github.com/users/mwegrz","html_url":"https://github.com/mwegrz","followers_url":"https://api.github.com/users/mwegrz/followers","following_url":"https://api.github.com/users/mwegrz/following{/other_user}","gists_url":"https://api.github.com/users/mwegrz/gists{/gist_id}","starred_url":"https://api.github.com/users/mwegrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwegrz/subscriptions","organizations_url":"https://api.github.com/users/mwegrz/orgs","repos_url":"https://api.github.com/users/mwegrz/repos","events_url":"https://api.github.com/users/mwegrz/events{/privacy}","received_events_url":"https://api.github.com/users/mwegrz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwegrz/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/mwegrz/akka","forks_url":"https://api.github.com/repos/mwegrz/akka/forks","keys_url":"https://api.github.com/repos/mwegrz/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwegrz/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwegrz/akka/teams","hooks_url":"https://api.github.com/repos/mwegrz/akka/hooks","issue_events_url":"https://api.github.com/repos/mwegrz/akka/issues/events{/number}","events_url":"https://api.github.com/repos/mwegrz/akka/events","assignees_url":"https://api.github.com/repos/mwegrz/akka/assignees{/user}","branches_url":"https://api.github.com/repos/mwegrz/akka/branches{/branch}","tags_url":"https://api.github.com/repos/mwegrz/akka/tags","blobs_url":"https://api.github.com/repos/mwegrz/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwegrz/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwegrz/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwegrz/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwegrz/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/mwegrz/akka/languages","stargazers_url":"https://api.github.com/repos/mwegrz/akka/stargazers","contributors_url":"https://api.github.com/repos/mwegrz/akka/contributors","subscribers_url":"https://api.github.com/repos/mwegrz/akka/subscribers","subscription_url":"https://api.github.com/repos/mwegrz/akka/subscription","commits_url":"https://api.github.com/repos/mwegrz/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwegrz/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwegrz/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwegrz/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/mwegrz/akka/contents/{+path}","compare_url":"https://api.github.com/repos/mwegrz/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwegrz/akka/merges","archive_url":"https://api.github.com/repos/mwegrz/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwegrz/akka/downloads","issues_url":"https://api.github.com/repos/mwegrz/akka/issues{/number}","pulls_url":"https://api.github.com/repos/mwegrz/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/mwegrz/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/mwegrz/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwegrz/akka/labels{/name}","releases_url":"https://api.github.com/repos/mwegrz/akka/releases{/id}","created_at":"2014-10-21T14:08:21Z","updated_at":"2014-10-21T10:14:04Z","pushed_at":"2014-10-25T10:37:07Z","git_url":"git://github.com/mwegrz/akka.git","ssh_url":"git@github.com:mwegrz/akka.git","clone_url":"https://github.com/mwegrz/akka.git","svn_url":"https://github.com/mwegrz/akka","homepage":"http://akka.io","size":155169,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"ad35be7de1fe9246478f4b01aa293cb9b4ff5494","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=2","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=2","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2014-10-24T21:43:57Z","pushed_at":"2014-10-24T14:02:42Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":234198,"stargazers_count":3107,"watchers_count":3107,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":855,"mirror_url":null,"open_issues_count":477,"forks":855,"open_issues":477,"watchers":3107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/16126"},"html":{"href":"https://github.com/akka/akka/pull/16126"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/16126"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/16126/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/16126/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/16126/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/8b4e93dea3b562f9c4fbb41f91aad4495b0cda79"}}}}