GitHub PullRequestReviewCommentEvent at 2014-01-22 18:27:07
Repository: qtfaststart
Actor: danielgtaylor
Payload: {"comment":{"url":"https://api.github.com/repos/danielgtaylor/qtfaststart/pulls/comments/9085678","id":9085678,"diff_hunk":"@@ -146,8 +148,28 @@ def _find_atoms_ex(parent_atom, datastream):\n             # Ignore this atom, seek to the end of it.\n             datastream.seek(atom.position + atom.size)\n \n-\n-def process(infilename, outfilename, limit=float('inf'), to_end=False):\n+def _moov_is_compressed(datastream, moov_atom):\n+    \"\"\"\n+        scan the atoms under the moov atom and detect whether or not the\n+        atom data is compressed\n+    \"\"\"\n+    # seek to the beginning of the moov atom contents\n+    datastream.seek(moov_atom.position+8)\n+    \n+    # step through the moov atom childeren to see if a cmov atom is among them","path":"qtfaststart/processor.py","position":47,"original_position":47,"commit_id":"9ca58eb3f1db7412ed50faac676796dd2d25ae8e","original_commit_id":"9ca58eb3f1db7412ed50faac676796dd2d25ae8e","user":{"login":"danielgtaylor","id":106826,"avatar_url":"https://gravatar.com/avatar/bb0a0764f087f1d035e569d00600576c?d=https%3A%2F%2Fidenticons.github.com%2Fb5dd44e859fddd824255601f057fee36.png&r=x","gravatar_id":"bb0a0764f087f1d035e569d00600576c","url":"https://api.github.com/users/danielgtaylor","html_url":"https://github.com/danielgtaylor","followers_url":"https://api.github.com/users/danielgtaylor/followers","following_url":"https://api.github.com/users/danielgtaylor/following{/other_user}","gists_url":"https://api.github.com/users/danielgtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgtaylor/subscriptions","organizations_url":"https://api.github.com/users/danielgtaylor/orgs","repos_url":"https://api.github.com/users/danielgtaylor/repos","events_url":"https://api.github.com/users/danielgtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/danielgtaylor/received_events","type":"User","site_admin":false},"body":"Is it common for compressed `moov` atoms to contain multiple child atoms instead of just one `cmov` blob? Is there an optimization for the non-compressed case here where we can just check the first child atom instead of reading all of them?","created_at":"2014-01-22T18:27:07Z","updated_at":"2014-01-22T18:27:07Z","html_url":"https://github.com/danielgtaylor/qtfaststart/pull/15#discussion_r9085678","pull_request_url":"https://api.github.com/repos/danielgtaylor/qtfaststart/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/danielgtaylor/qtfaststart/pulls/comments/9085678"},"html":{"href":"https://github.com/danielgtaylor/qtfaststart/pull/15#discussion_r9085678"},"pull_request":{"href":"https://api.github.com/repos/danielgtaylor/qtfaststart/pulls/15"}}}}