GitHub PullRequestEvent at 2014-02-14 09:06:21
Repository: openh264
Actor: volvet
Payload: {"action":"opened","number":288,"pull_request":{"url":"https://api.github.com/repos/cisco/openh264/pulls/288","id":12546821,"html_url":"https://github.com/cisco/openh264/pull/288","diff_url":"https://github.com/cisco/openh264/pull/288.diff","patch_url":"https://github.com/cisco/openh264/pull/288.patch","issue_url":"https://api.github.com/repos/cisco/openh264/issues/288","number":288,"state":"open","title":"use forward declaration to replace type cast","user":{"login":"volvet","id":6102708,"avatar_url":"https://gravatar.com/avatar/5b6555e1b6c8e785d1f2bc0726636665?d=https%3A%2F%2Fidenticons.github.com%2F596450800ea1d5e315ea938f7ca98b01.png&r=x","gravatar_id":"5b6555e1b6c8e785d1f2bc0726636665","url":"https://api.github.com/users/volvet","html_url":"https://github.com/volvet","followers_url":"https://api.github.com/users/volvet/followers","following_url":"https://api.github.com/users/volvet/following{/other_user}","gists_url":"https://api.github.com/users/volvet/gists{/gist_id}","starred_url":"https://api.github.com/users/volvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volvet/subscriptions","organizations_url":"https://api.github.com/users/volvet/orgs","repos_url":"https://api.github.com/users/volvet/repos","events_url":"https://api.github.com/users/volvet/events{/privacy}","received_events_url":"https://api.github.com/users/volvet/received_events","type":"User","site_admin":false},"body":"Change: \r\n   1.  use forward declaration to replace type casting,  clean related code. \r\n   2.  Potential issue fix:  in function CWelsLib::CreateIface,  it does not make sense to check ppEncCtx when decide to return 0 or 1.  \r\n\r\nReview: \r\nhttps://rbcommons.com/s/OpenH264/r/81/\r\n","created_at":"2014-02-14T09:06:21Z","updated_at":"2014-02-14T09:06:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/openh264/pulls/288/commits","review_comments_url":"https://api.github.com/repos/cisco/openh264/pulls/288/comments","review_comment_url":"https://api.github.com/repos/cisco/openh264/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cisco/openh264/issues/288/comments","statuses_url":"https://api.github.com/repos/cisco/openh264/statuses/7f59e2f8d950c937945c7ca4271584ab23859d61","head":{"label":"volvet:develop_b","ref":"develop_b","sha":"7f59e2f8d950c937945c7ca4271584ab23859d61","user":{"login":"volvet","id":6102708,"avatar_url":"https://gravatar.com/avatar/5b6555e1b6c8e785d1f2bc0726636665?d=https%3A%2F%2Fidenticons.github.com%2F596450800ea1d5e315ea938f7ca98b01.png&r=x","gravatar_id":"5b6555e1b6c8e785d1f2bc0726636665","url":"https://api.github.com/users/volvet","html_url":"https://github.com/volvet","followers_url":"https://api.github.com/users/volvet/followers","following_url":"https://api.github.com/users/volvet/following{/other_user}","gists_url":"https://api.github.com/users/volvet/gists{/gist_id}","starred_url":"https://api.github.com/users/volvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volvet/subscriptions","organizations_url":"https://api.github.com/users/volvet/orgs","repos_url":"https://api.github.com/users/volvet/repos","events_url":"https://api.github.com/users/volvet/events{/privacy}","received_events_url":"https://api.github.com/users/volvet/received_events","type":"User","site_admin":false},"repo":{"id":15153548,"name":"openh264","full_name":"volvet/openh264","owner":{"login":"volvet","id":6102708,"avatar_url":"https://gravatar.com/avatar/5b6555e1b6c8e785d1f2bc0726636665?d=https%3A%2F%2Fidenticons.github.com%2F596450800ea1d5e315ea938f7ca98b01.png&r=x","gravatar_id":"5b6555e1b6c8e785d1f2bc0726636665","url":"https://api.github.com/users/volvet","html_url":"https://github.com/volvet","followers_url":"https://api.github.com/users/volvet/followers","following_url":"https://api.github.com/users/volvet/following{/other_user}","gists_url":"https://api.github.com/users/volvet/gists{/gist_id}","starred_url":"https://api.github.com/users/volvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volvet/subscriptions","organizations_url":"https://api.github.com/users/volvet/orgs","repos_url":"https://api.github.com/users/volvet/repos","events_url":"https://api.github.com/users/volvet/events{/privacy}","received_events_url":"https://api.github.com/users/volvet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/volvet/openh264","description":"Open Source H.264 Codec ","fork":true,"url":"https://api.github.com/repos/volvet/openh264","forks_url":"https://api.github.com/repos/volvet/openh264/forks","keys_url":"https://api.github.com/repos/volvet/openh264/keys{/key_id}","collaborators_url":"https://api.github.com/repos/volvet/openh264/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/volvet/openh264/teams","hooks_url":"https://api.github.com/repos/volvet/openh264/hooks","issue_events_url":"https://api.github.com/repos/volvet/openh264/issues/events{/number}","events_url":"https://api.github.com/repos/volvet/openh264/events","assignees_url":"https://api.github.com/repos/volvet/openh264/assignees{/user}","branches_url":"https://api.github.com/repos/volvet/openh264/branches{/branch}","tags_url":"https://api.github.com/repos/volvet/openh264/tags","blobs_url":"https://api.github.com/repos/volvet/openh264/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/volvet/openh264/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/volvet/openh264/git/refs{/sha}","trees_url":"https://api.github.com/repos/volvet/openh264/git/trees{/sha}","statuses_url":"https://api.github.com/repos/volvet/openh264/statuses/{sha}","languages_url":"https://api.github.com/repos/volvet/openh264/languages","stargazers_url":"https://api.github.com/repos/volvet/openh264/stargazers","contributors_url":"https://api.github.com/repos/volvet/openh264/contributors","subscribers_url":"https://api.github.com/repos/volvet/openh264/subscribers","subscription_url":"https://api.github.com/repos/volvet/openh264/subscription","commits_url":"https://api.github.com/repos/volvet/openh264/commits{/sha}","git_commits_url":"https://api.github.com/repos/volvet/openh264/git/commits{/sha}","comments_url":"https://api.github.com/repos/volvet/openh264/comments{/number}","issue_comment_url":"https://api.github.com/repos/volvet/openh264/issues/comments/{number}","contents_url":"https://api.github.com/repos/volvet/openh264/contents/{+path}","compare_url":"https://api.github.com/repos/volvet/openh264/compare/{base}...{head}","merges_url":"https://api.github.com/repos/volvet/openh264/merges","archive_url":"https://api.github.com/repos/volvet/openh264/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/volvet/openh264/downloads","issues_url":"https://api.github.com/repos/volvet/openh264/issues{/number}","pulls_url":"https://api.github.com/repos/volvet/openh264/pulls{/number}","milestones_url":"https://api.github.com/repos/volvet/openh264/milestones{/number}","notifications_url":"https://api.github.com/repos/volvet/openh264/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/volvet/openh264/labels{/name}","releases_url":"https://api.github.com/repos/volvet/openh264/releases{/id}","created_at":"2013-12-13T03:02:12Z","updated_at":"2014-02-14T09:06:21Z","pushed_at":"2014-02-14T08:51:26Z","git_url":"git://github.com/volvet/openh264.git","ssh_url":"git@github.com:volvet/openh264.git","clone_url":"https://github.com/volvet/openh264.git","svn_url":"https://github.com/volvet/openh264","homepage":null,"size":5131,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"cisco:master","ref":"master","sha":"dbb894442f31e070dbffe5ec0ac9e78d4e5efc6a","user":{"login":"cisco","id":1376999,"avatar_url":"https://gravatar.com/avatar/f89fde1eed1051f3ebf6d762b38e9a35?d=https%3A%2F%2Fidenticons.github.com%2F2f62adead300826a03913f06424cac52.png&r=x","gravatar_id":"f89fde1eed1051f3ebf6d762b38e9a35","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":13909573,"name":"openh264","full_name":"cisco/openh264","owner":{"login":"cisco","id":1376999,"avatar_url":"https://gravatar.com/avatar/f89fde1eed1051f3ebf6d762b38e9a35?d=https%3A%2F%2Fidenticons.github.com%2F2f62adead300826a03913f06424cac52.png&r=x","gravatar_id":"f89fde1eed1051f3ebf6d762b38e9a35","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/openh264","description":"Open Source H.264 Codec ","fork":false,"url":"https://api.github.com/repos/cisco/openh264","forks_url":"https://api.github.com/repos/cisco/openh264/forks","keys_url":"https://api.github.com/repos/cisco/openh264/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/openh264/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/openh264/teams","hooks_url":"https://api.github.com/repos/cisco/openh264/hooks","issue_events_url":"https://api.github.com/repos/cisco/openh264/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/openh264/events","assignees_url":"https://api.github.com/repos/cisco/openh264/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/openh264/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/openh264/tags","blobs_url":"https://api.github.com/repos/cisco/openh264/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/openh264/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/openh264/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/openh264/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/openh264/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/openh264/languages","stargazers_url":"https://api.github.com/repos/cisco/openh264/stargazers","contributors_url":"https://api.github.com/repos/cisco/openh264/contributors","subscribers_url":"https://api.github.com/repos/cisco/openh264/subscribers","subscription_url":"https://api.github.com/repos/cisco/openh264/subscription","commits_url":"https://api.github.com/repos/cisco/openh264/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/openh264/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/openh264/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/openh264/issues/comments/{number}","contents_url":"https://api.github.com/repos/cisco/openh264/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/openh264/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/openh264/merges","archive_url":"https://api.github.com/repos/cisco/openh264/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/openh264/downloads","issues_url":"https://api.github.com/repos/cisco/openh264/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/openh264/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/openh264/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/openh264/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/openh264/labels{/name}","releases_url":"https://api.github.com/repos/cisco/openh264/releases{/id}","created_at":"2013-10-27T20:20:31Z","updated_at":"2014-02-13T23:18:04Z","pushed_at":"2014-02-13T23:18:03Z","git_url":"git://github.com/cisco/openh264.git","ssh_url":"git@github.com:cisco/openh264.git","clone_url":"https://github.com/cisco/openh264.git","svn_url":"https://github.com/cisco/openh264","homepage":null,"size":9245,"stargazers_count":1076,"watchers_count":1076,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":182,"mirror_url":null,"open_issues_count":6,"forks":182,"open_issues":6,"watchers":1076,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/openh264/pulls/288"},"html":{"href":"https://github.com/cisco/openh264/pull/288"},"issue":{"href":"https://api.github.com/repos/cisco/openh264/issues/288"},"comments":{"href":"https://api.github.com/repos/cisco/openh264/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/openh264/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/openh264/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cisco/openh264/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/openh264/statuses/7f59e2f8d950c937945c7ca4271584ab23859d61"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":106,"deletions":111,"changed_files":3}}