GitHub PullRequestReviewCommentEvent at 2014-09-09 00:09:07
Repository: Glowstone
Actor: turt2live
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/comments/17275538","id":17275538,"diff_hunk":"@@ -0,0 +1,18 @@\n+package net.glowstone.block.blocktype;\n+\n+import net.glowstone.block.GlowBlockState;\n+import net.glowstone.block.blocktype.BlockType;\n+import net.glowstone.entity.GlowPlayer;\n+import org.bukkit.block.BlockFace;\n+import org.bukkit.inventory.ItemStack;\n+import org.bukkit.util.Vector;\n+\n+public class BlockWater extends BlockType {\n+\n+    @Override\n+    public void placeBlock(GlowPlayer player, GlowBlockState state, BlockFace face, ItemStack holding, Vector clickedLoc) {\n+        state.setType(getMaterial());\n+        state.setRawData((byte)8);\n+    }\n+\n+}","path":"src/main/java/net/glowstone/block/blocktype/BlockWater.java","position":18,"original_position":18,"commit_id":"6dfd03f124d6c36a667a8ed1f6c143b5029823a5","original_commit_id":"6dfd03f124d6c36a667a8ed1f6c143b5029823a5","user":{"login":"turt2live","id":1190097,"avatar_url":"https://avatars.githubusercontent.com/u/1190097?v=2","gravatar_id":"1ff897313ab7ed45a24871913d0968e6","url":"https://api.github.com/users/turt2live","html_url":"https://github.com/turt2live","followers_url":"https://api.github.com/users/turt2live/followers","following_url":"https://api.github.com/users/turt2live/following{/other_user}","gists_url":"https://api.github.com/users/turt2live/gists{/gist_id}","starred_url":"https://api.github.com/users/turt2live/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turt2live/subscriptions","organizations_url":"https://api.github.com/users/turt2live/orgs","repos_url":"https://api.github.com/users/turt2live/repos","events_url":"https://api.github.com/users/turt2live/events{/privacy}","received_events_url":"https://api.github.com/users/turt2live/received_events","type":"User","site_admin":false},"body":"All files need a single newline character at the end","created_at":"2014-09-09T00:09:07Z","updated_at":"2014-09-09T00:09:07Z","html_url":"https://github.com/SpaceManiac/Glowstone/pull/236#discussion_r17275538","pull_request_url":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/236","_links":{"self":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/comments/17275538"},"html":{"href":"https://github.com/SpaceManiac/Glowstone/pull/236#discussion_r17275538"},"pull_request":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/236","id":20926373,"html_url":"https://github.com/SpaceManiac/Glowstone/pull/236","diff_url":"https://github.com/SpaceManiac/Glowstone/pull/236.diff","patch_url":"https://github.com/SpaceManiac/Glowstone/pull/236.patch","issue_url":"https://api.github.com/repos/SpaceManiac/Glowstone/issues/236","number":236,"state":"open","locked":false,"title":"Implemented buckets","user":{"login":"TomCaserta","id":592309,"avatar_url":"https://avatars.githubusercontent.com/u/592309?v=2","gravatar_id":"386493a04d5dd186bee305c7c18d6053","url":"https://api.github.com/users/TomCaserta","html_url":"https://github.com/TomCaserta","followers_url":"https://api.github.com/users/TomCaserta/followers","following_url":"https://api.github.com/users/TomCaserta/following{/other_user}","gists_url":"https://api.github.com/users/TomCaserta/gists{/gist_id}","starred_url":"https://api.github.com/users/TomCaserta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomCaserta/subscriptions","organizations_url":"https://api.github.com/users/TomCaserta/orgs","repos_url":"https://api.github.com/users/TomCaserta/repos","events_url":"https://api.github.com/users/TomCaserta/events{/privacy}","received_events_url":"https://api.github.com/users/TomCaserta/received_events","type":"User","site_admin":false},"body":"Added items for buckets and placement. I am unable to figure out how to get the block face for the bukkit event on line 35 in ItemBucket.java. However the rest of the implementation works.","created_at":"2014-09-08T23:59:53Z","updated_at":"2014-09-09T00:09:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c46657660588c486dfd84c9847881cddc3d65570","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/236/commits","review_comments_url":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/236/comments","review_comment_url":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SpaceManiac/Glowstone/issues/236/comments","statuses_url":"https://api.github.com/repos/SpaceManiac/Glowstone/statuses/6dfd03f124d6c36a667a8ed1f6c143b5029823a5","head":{"label":"TomCaserta:buckets","ref":"buckets","sha":"6dfd03f124d6c36a667a8ed1f6c143b5029823a5","user":{"login":"TomCaserta","id":592309,"avatar_url":"https://avatars.githubusercontent.com/u/592309?v=2","gravatar_id":"386493a04d5dd186bee305c7c18d6053","url":"https://api.github.com/users/TomCaserta","html_url":"https://github.com/TomCaserta","followers_url":"https://api.github.com/users/TomCaserta/followers","following_url":"https://api.github.com/users/TomCaserta/following{/other_user}","gists_url":"https://api.github.com/users/TomCaserta/gists{/gist_id}","starred_url":"https://api.github.com/users/TomCaserta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomCaserta/subscriptions","organizations_url":"https://api.github.com/users/TomCaserta/orgs","repos_url":"https://api.github.com/users/TomCaserta/repos","events_url":"https://api.github.com/users/TomCaserta/events{/privacy}","received_events_url":"https://api.github.com/users/TomCaserta/received_events","type":"User","site_admin":false},"repo":{"id":23811865,"name":"Glowstone","full_name":"TomCaserta/Glowstone","owner":{"login":"TomCaserta","id":592309,"avatar_url":"https://avatars.githubusercontent.com/u/592309?v=2","gravatar_id":"386493a04d5dd186bee305c7c18d6053","url":"https://api.github.com/users/TomCaserta","html_url":"https://github.com/TomCaserta","followers_url":"https://api.github.com/users/TomCaserta/followers","following_url":"https://api.github.com/users/TomCaserta/following{/other_user}","gists_url":"https://api.github.com/users/TomCaserta/gists{/gist_id}","starred_url":"https://api.github.com/users/TomCaserta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomCaserta/subscriptions","organizations_url":"https://api.github.com/users/TomCaserta/orgs","repos_url":"https://api.github.com/users/TomCaserta/repos","events_url":"https://api.github.com/users/TomCaserta/events{/privacy}","received_events_url":"https://api.github.com/users/TomCaserta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomCaserta/Glowstone","description":"An open-source server for the Bukkit Minecraft modding interface.","fork":true,"url":"https://api.github.com/repos/TomCaserta/Glowstone","forks_url":"https://api.github.com/repos/TomCaserta/Glowstone/forks","keys_url":"https://api.github.com/repos/TomCaserta/Glowstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomCaserta/Glowstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomCaserta/Glowstone/teams","hooks_url":"https://api.github.com/repos/TomCaserta/Glowstone/hooks","issue_events_url":"https://api.github.com/repos/TomCaserta/Glowstone/issues/events{/number}","events_url":"https://api.github.com/repos/TomCaserta/Glowstone/events","assignees_url":"https://api.github.com/repos/TomCaserta/Glowstone/assignees{/user}","branches_url":"https://api.github.com/repos/TomCaserta/Glowstone/branches{/branch}","tags_url":"https://api.github.com/repos/TomCaserta/Glowstone/tags","blobs_url":"https://api.github.com/repos/TomCaserta/Glowstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomCaserta/Glowstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomCaserta/Glowstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomCaserta/Glowstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomCaserta/Glowstone/statuses/{sha}","languages_url":"https://api.github.com/repos/TomCaserta/Glowstone/languages","stargazers_url":"https://api.github.com/repos/TomCaserta/Glowstone/stargazers","contributors_url":"https://api.github.com/repos/TomCaserta/Glowstone/contributors","subscribers_url":"https://api.github.com/repos/TomCaserta/Glowstone/subscribers","subscription_url":"https://api.github.com/repos/TomCaserta/Glowstone/subscription","commits_url":"https://api.github.com/repos/TomCaserta/Glowstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomCaserta/Glowstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomCaserta/Glowstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomCaserta/Glowstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/TomCaserta/Glowstone/contents/{+path}","compare_url":"https://api.github.com/repos/TomCaserta/Glowstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomCaserta/Glowstone/merges","archive_url":"https://api.github.com/repos/TomCaserta/Glowstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomCaserta/Glowstone/downloads","issues_url":"https://api.github.com/repos/TomCaserta/Glowstone/issues{/number}","pulls_url":"https://api.github.com/repos/TomCaserta/Glowstone/pulls{/number}","milestones_url":"https://api.github.com/repos/TomCaserta/Glowstone/milestones{/number}","notifications_url":"https://api.github.com/repos/TomCaserta/Glowstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomCaserta/Glowstone/labels{/name}","releases_url":"https://api.github.com/repos/TomCaserta/Glowstone/releases{/id}","created_at":"2014-09-08T23:10:03Z","updated_at":"2014-09-08T19:53:55Z","pushed_at":"2014-09-08T23:57:53Z","git_url":"git://github.com/TomCaserta/Glowstone.git","ssh_url":"git@github.com:TomCaserta/Glowstone.git","clone_url":"https://github.com/TomCaserta/Glowstone.git","svn_url":"https://github.com/TomCaserta/Glowstone","homepage":"http://www.glowstone.net/","size":11636,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpaceManiac:master","ref":"master","sha":"8d9cf2febb247e0bbf011ca6f5faa92f1aaf244b","user":{"login":"SpaceManiac","id":222630,"avatar_url":"https://avatars.githubusercontent.com/u/222630?v=2","gravatar_id":"6404217e45aaafd0fa54b267222de2fc","url":"https://api.github.com/users/SpaceManiac","html_url":"https://github.com/SpaceManiac","followers_url":"https://api.github.com/users/SpaceManiac/followers","following_url":"https://api.github.com/users/SpaceManiac/following{/other_user}","gists_url":"https://api.github.com/users/SpaceManiac/gists{/gist_id}","starred_url":"https://api.github.com/users/SpaceManiac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpaceManiac/subscriptions","organizations_url":"https://api.github.com/users/SpaceManiac/orgs","repos_url":"https://api.github.com/users/SpaceManiac/repos","events_url":"https://api.github.com/users/SpaceManiac/events{/privacy}","received_events_url":"https://api.github.com/users/SpaceManiac/received_events","type":"User","site_admin":false},"repo":{"id":1501888,"name":"Glowstone","full_name":"SpaceManiac/Glowstone","owner":{"login":"SpaceManiac","id":222630,"avatar_url":"https://avatars.githubusercontent.com/u/222630?v=2","gravatar_id":"6404217e45aaafd0fa54b267222de2fc","url":"https://api.github.com/users/SpaceManiac","html_url":"https://github.com/SpaceManiac","followers_url":"https://api.github.com/users/SpaceManiac/followers","following_url":"https://api.github.com/users/SpaceManiac/following{/other_user}","gists_url":"https://api.github.com/users/SpaceManiac/gists{/gist_id}","starred_url":"https://api.github.com/users/SpaceManiac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpaceManiac/subscriptions","organizations_url":"https://api.github.com/users/SpaceManiac/orgs","repos_url":"https://api.github.com/users/SpaceManiac/repos","events_url":"https://api.github.com/users/SpaceManiac/events{/privacy}","received_events_url":"https://api.github.com/users/SpaceManiac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SpaceManiac/Glowstone","description":"An open-source server for the Bukkit Minecraft modding interface.","fork":false,"url":"https://api.github.com/repos/SpaceManiac/Glowstone","forks_url":"https://api.github.com/repos/SpaceManiac/Glowstone/forks","keys_url":"https://api.github.com/repos/SpaceManiac/Glowstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpaceManiac/Glowstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpaceManiac/Glowstone/teams","hooks_url":"https://api.github.com/repos/SpaceManiac/Glowstone/hooks","issue_events_url":"https://api.github.com/repos/SpaceManiac/Glowstone/issues/events{/number}","events_url":"https://api.github.com/repos/SpaceManiac/Glowstone/events","assignees_url":"https://api.github.com/repos/SpaceManiac/Glowstone/assignees{/user}","branches_url":"https://api.github.com/repos/SpaceManiac/Glowstone/branches{/branch}","tags_url":"https://api.github.com/repos/SpaceManiac/Glowstone/tags","blobs_url":"https://api.github.com/repos/SpaceManiac/Glowstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpaceManiac/Glowstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpaceManiac/Glowstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpaceManiac/Glowstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpaceManiac/Glowstone/statuses/{sha}","languages_url":"https://api.github.com/repos/SpaceManiac/Glowstone/languages","stargazers_url":"https://api.github.com/repos/SpaceManiac/Glowstone/stargazers","contributors_url":"https://api.github.com/repos/SpaceManiac/Glowstone/contributors","subscribers_url":"https://api.github.com/repos/SpaceManiac/Glowstone/subscribers","subscription_url":"https://api.github.com/repos/SpaceManiac/Glowstone/subscription","commits_url":"https://api.github.com/repos/SpaceManiac/Glowstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpaceManiac/Glowstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpaceManiac/Glowstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpaceManiac/Glowstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/SpaceManiac/Glowstone/contents/{+path}","compare_url":"https://api.github.com/repos/SpaceManiac/Glowstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpaceManiac/Glowstone/merges","archive_url":"https://api.github.com/repos/SpaceManiac/Glowstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpaceManiac/Glowstone/downloads","issues_url":"https://api.github.com/repos/SpaceManiac/Glowstone/issues{/number}","pulls_url":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls{/number}","milestones_url":"https://api.github.com/repos/SpaceManiac/Glowstone/milestones{/number}","notifications_url":"https://api.github.com/repos/SpaceManiac/Glowstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpaceManiac/Glowstone/labels{/name}","releases_url":"https://api.github.com/repos/SpaceManiac/Glowstone/releases{/id}","created_at":"2011-03-20T01:40:35Z","updated_at":"2014-09-08T23:40:52Z","pushed_at":"2014-09-08T05:08:41Z","git_url":"git://github.com/SpaceManiac/Glowstone.git","ssh_url":"git@github.com:SpaceManiac/Glowstone.git","clone_url":"https://github.com/SpaceManiac/Glowstone.git","svn_url":"https://github.com/SpaceManiac/Glowstone","homepage":"http://www.glowstone.net/","size":11636,"stargazers_count":218,"watchers_count":218,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":95,"mirror_url":null,"open_issues_count":105,"forks":95,"open_issues":105,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/236"},"html":{"href":"https://github.com/SpaceManiac/Glowstone/pull/236"},"issue":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/issues/236"},"comments":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/SpaceManiac/Glowstone/statuses/6dfd03f124d6c36a667a8ed1f6c143b5029823a5"}}}}