GitHub PullRequestReviewCommentEvent at 2014-10-01 20:15:26
Repository: wildfly-core
Actor: bstansberry
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/18304841","id":18304841,"diff_hunk":"@@ -34,6 +34,11 @@ public FutureServiceContainer() {\n         super(JBossExecutors.directExecutor());\n     }\n \n+    public FutureServiceContainer(ServiceContainer container) {\n+        this();\n+        done(container);\n+    }\n+","path":"server/src/main/java/org/jboss/as/server/FutureServiceContainer.java","position":8,"original_position":8,"commit_id":"92b880866970913cbeb1eea4b93d80c7a273a555","original_commit_id":"92b880866970913cbeb1eea4b93d80c7a273a555","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"The JMX testsuite should just create its own variant of this if it needs one. I don't want extension modules depending on this class; it's an internal detail only public because host-controller uses it.","created_at":"2014-10-01T20:15:26Z","updated_at":"2014-10-01T20:15:26Z","html_url":"https://github.com/wildfly/wildfly-core/pull/215#discussion_r18304841","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/18304841"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/215#discussion_r18304841"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/215","id":22080450,"html_url":"https://github.com/wildfly/wildfly-core/pull/215","diff_url":"https://github.com/wildfly/wildfly-core/pull/215.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/215.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/215","number":215,"state":"open","locked":false,"title":"Add dependency support for direct mbeans.","user":{"login":"alesj","id":331896,"avatar_url":"https://avatars.githubusercontent.com/u/331896?v=2","gravatar_id":"","url":"https://api.github.com/users/alesj","html_url":"https://github.com/alesj","followers_url":"https://api.github.com/users/alesj/followers","following_url":"https://api.github.com/users/alesj/following{/other_user}","gists_url":"https://api.github.com/users/alesj/gists{/gist_id}","starred_url":"https://api.github.com/users/alesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesj/subscriptions","organizations_url":"https://api.github.com/users/alesj/orgs","repos_url":"https://api.github.com/users/alesj/repos","events_url":"https://api.github.com/users/alesj/events{/privacy}","received_events_url":"https://api.github.com/users/alesj/received_events","type":"User","site_admin":false},"body":"[WFLY-3921]; \r\nWe should be able to depend on existing mbeans from jboss-service.xml.\r\n(e.g. mbeans registered directly from JMX API)","created_at":"2014-10-01T15:21:51Z","updated_at":"2014-10-01T20:15:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e50970dfc629668a2b04a0d0de53692122b5a51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/215/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/215/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/215/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/92b880866970913cbeb1eea4b93d80c7a273a555","head":{"label":"alesj:jmx_int","ref":"jmx_int","sha":"92b880866970913cbeb1eea4b93d80c7a273a555","user":{"login":"alesj","id":331896,"avatar_url":"https://avatars.githubusercontent.com/u/331896?v=2","gravatar_id":"","url":"https://api.github.com/users/alesj","html_url":"https://github.com/alesj","followers_url":"https://api.github.com/users/alesj/followers","following_url":"https://api.github.com/users/alesj/following{/other_user}","gists_url":"https://api.github.com/users/alesj/gists{/gist_id}","starred_url":"https://api.github.com/users/alesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesj/subscriptions","organizations_url":"https://api.github.com/users/alesj/orgs","repos_url":"https://api.github.com/users/alesj/repos","events_url":"https://api.github.com/users/alesj/events{/privacy}","received_events_url":"https://api.github.com/users/alesj/received_events","type":"User","site_admin":false},"repo":{"id":23002752,"name":"wildfly-core","full_name":"alesj/wildfly-core","owner":{"login":"alesj","id":331896,"avatar_url":"https://avatars.githubusercontent.com/u/331896?v=2","gravatar_id":"","url":"https://api.github.com/users/alesj","html_url":"https://github.com/alesj","followers_url":"https://api.github.com/users/alesj/followers","following_url":"https://api.github.com/users/alesj/following{/other_user}","gists_url":"https://api.github.com/users/alesj/gists{/gist_id}","starred_url":"https://api.github.com/users/alesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesj/subscriptions","organizations_url":"https://api.github.com/users/alesj/orgs","repos_url":"https://api.github.com/users/alesj/repos","events_url":"https://api.github.com/users/alesj/events{/privacy}","received_events_url":"https://api.github.com/users/alesj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alesj/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/alesj/wildfly-core","forks_url":"https://api.github.com/repos/alesj/wildfly-core/forks","keys_url":"https://api.github.com/repos/alesj/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alesj/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alesj/wildfly-core/teams","hooks_url":"https://api.github.com/repos/alesj/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/alesj/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/alesj/wildfly-core/events","assignees_url":"https://api.github.com/repos/alesj/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/alesj/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/alesj/wildfly-core/tags","blobs_url":"https://api.github.com/repos/alesj/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alesj/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alesj/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/alesj/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alesj/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/alesj/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/alesj/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/alesj/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/alesj/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/alesj/wildfly-core/subscription","commits_url":"https://api.github.com/repos/alesj/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/alesj/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/alesj/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/alesj/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/alesj/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/alesj/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alesj/wildfly-core/merges","archive_url":"https://api.github.com/repos/alesj/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alesj/wildfly-core/downloads","issues_url":"https://api.github.com/repos/alesj/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/alesj/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/alesj/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/alesj/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alesj/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/alesj/wildfly-core/releases{/id}","created_at":"2014-08-15T20:57:23Z","updated_at":"2014-08-26T13:22:51Z","pushed_at":"2014-10-01T15:03:35Z","git_url":"git://github.com/alesj/wildfly-core.git","ssh_url":"git@github.com:alesj/wildfly-core.git","clone_url":"https://github.com/alesj/wildfly-core.git","svn_url":"https://github.com/alesj/wildfly-core","homepage":null,"size":33527,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"ca9cb1e63532c6b77f243738f68ac49b88fea211","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","created_at":"2014-07-01T16:33:34Z","updated_at":"2014-09-06T22:42:49Z","pushed_at":"2014-10-01T19:03:45Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":38073,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":18,"forks":65,"open_issues":18,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/215"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/215"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/215"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/92b880866970913cbeb1eea4b93d80c7a273a555"}}}}