GitHub PullRequestReviewCommentEvent at 2014-08-04 20:09:38
Repository: moonstone
Actor: ryanjduffy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/15777694","id":15777694,"diff_hunk":"@@ -201,24 +253,26 @@\n \t \t/**\n \t \t* @private\n \t \t*/\n-\t\trefreshScrollState: function () {","path":"source/IntegerPicker.js","position":145,"original_position":145,"commit_id":"fa50a2c0bbfc719206ab58d475e29899c4a246d7","original_commit_id":"fa50a2c0bbfc719206ab58d475e29899c4a246d7","user":{"login":"ryanjduffy","id":788456,"avatar_url":"https://avatars.githubusercontent.com/u/788456?v=2","gravatar_id":"9d9ef720860edfffd477c6f2330efc91","url":"https://api.github.com/users/ryanjduffy","html_url":"https://github.com/ryanjduffy","followers_url":"https://api.github.com/users/ryanjduffy/followers","following_url":"https://api.github.com/users/ryanjduffy/following{/other_user}","gists_url":"https://api.github.com/users/ryanjduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjduffy/subscriptions","organizations_url":"https://api.github.com/users/ryanjduffy/orgs","repos_url":"https://api.github.com/users/ryanjduffy/repos","events_url":"https://api.github.com/users/ryanjduffy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjduffy/received_events","type":"User","site_admin":false},"body":"Good catch. Do you think it should be calling this directly or waterfalling an event instead? Or perhaps calling a more standard API (e.g. reflow())?","created_at":"2014-08-04T20:09:38Z","updated_at":"2014-08-04T20:09:38Z","html_url":"https://github.com/enyojs/moonstone/pull/1493#discussion_r15777694","pull_request_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1493","_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/15777694"},"html":{"href":"https://github.com/enyojs/moonstone/pull/1493#discussion_r15777694"},"pull_request":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1493"}}},"pull_request":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/1493","id":19177299,"html_url":"https://github.com/enyojs/moonstone/pull/1493","diff_url":"https://github.com/enyojs/moonstone/pull/1493.diff","patch_url":"https://github.com/enyojs/moonstone/pull/1493.patch","issue_url":"https://api.github.com/repos/enyojs/moonstone/issues/1493","number":1493,"state":"open","title":"Fixes CMB-602","user":{"login":"ryanjduffy","id":788456,"avatar_url":"https://avatars.githubusercontent.com/u/788456?v=2","gravatar_id":"9d9ef720860edfffd477c6f2330efc91","url":"https://api.github.com/users/ryanjduffy","html_url":"https://github.com/ryanjduffy","followers_url":"https://api.github.com/users/ryanjduffy/followers","following_url":"https://api.github.com/users/ryanjduffy/following{/other_user}","gists_url":"https://api.github.com/users/ryanjduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjduffy/subscriptions","organizations_url":"https://api.github.com/users/ryanjduffy/orgs","repos_url":"https://api.github.com/users/ryanjduffy/repos","events_url":"https://api.github.com/users/ryanjduffy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjduffy/received_events","type":"User","site_admin":false},"body":"# Issue\r\nIntegerPicker and SimpleIntegerPicker render every value in their range when only one is displayed at a time. They also wrap by scrolling through their entire range rather than truly wrapping the first value after the last value (or last before the first)\r\n\r\n# Fix\r\nRefactor both to use FlyweightRepeater limited to include only the number of items required. Will also scroll the shortest distance when the value changes which improves wrapping UX.\r\n\r\nEnyo-DCO-Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>","created_at":"2014-07-31T20:43:11Z","updated_at":"2014-08-04T20:09:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1493/commits","review_comments_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1493/comments","review_comment_url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enyojs/moonstone/issues/1493/comments","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/fa50a2c0bbfc719206ab58d475e29899c4a246d7","head":{"label":"enyojs:CMB-730-ryanjduffy","ref":"CMB-730-ryanjduffy","sha":"fa50a2c0bbfc719206ab58d475e29899c4a246d7","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"70103c13ada6801c095816e50198045c","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"70103c13ada6801c095816e50198045c","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2014-07-28T03:02:12Z","pushed_at":"2014-08-04T17:29:54Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":91892,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":6,"mirror_url":null,"open_issues_count":40,"forks":6,"open_issues":40,"watchers":26,"default_branch":"master"}},"base":{"label":"enyojs:master","ref":"master","sha":"b0da3c54317e4daed78c6940a2ec08afae38c04a","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"70103c13ada6801c095816e50198045c","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"70103c13ada6801c095816e50198045c","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2014-07-28T03:02:12Z","pushed_at":"2014-08-04T17:29:54Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":91892,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":6,"mirror_url":null,"open_issues_count":40,"forks":6,"open_issues":40,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1493"},"html":{"href":"https://github.com/enyojs/moonstone/pull/1493"},"issue":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/1493"},"comments":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/1493/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1493/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1493/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/moonstone/statuses/fa50a2c0bbfc719206ab58d475e29899c4a246d7"}}}}