GitHub PullRequestReviewCommentEvent at 2014-07-04 08:11:04
Repository: yast-registration
Actor: jreidinger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-registration/pulls/comments/14550684","id":14550684,"diff_hunk":"@@ -77,6 +77,7 @@ def create_addon_with_deps(root)\n       :friendly_name,\n       :identifier,\n       :name,\n+      :predecessor,","path":"src/lib/registration/addon.rb","position":4,"original_position":4,"commit_id":"4ae40653b46e996fe96dc0e91503e985064e29aa","original_commit_id":"4ae40653b46e996fe96dc0e91503e985064e29aa","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?","gravatar_id":"f9a9cf77af20d925b328ee8c95c0068c","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"I think this is not needed, it is hidden attribute of addon. You should use it only with `updates_addon?` not alone.","created_at":"2014-07-04T08:11:04Z","updated_at":"2014-07-04T08:11:04Z","html_url":"https://github.com/yast/yast-registration/pull/125#discussion_r14550684","pull_request_url":"https://api.github.com/repos/yast/yast-registration/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/comments/14550684"},"html":{"href":"https://github.com/yast/yast-registration/pull/125#discussion_r14550684"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-registration/pulls/125","id":17983474,"html_url":"https://github.com/yast/yast-registration/pull/125","diff_url":"https://github.com/yast/yast-registration/pull/125.diff","patch_url":"https://github.com/yast/yast-registration/pull/125.patch","issue_url":"https://api.github.com/repos/yast/yast-registration/issues/125","number":125,"state":"open","title":"Use \"predecessor\" attribute to handle addon renames (bnc#883206)","user":{"login":"lslezak","id":907998,"avatar_url":"https://avatars.githubusercontent.com/u/907998?","gravatar_id":"654c5b4f0d657240edff9440a901839b","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},"body":"- 3.1.84\r\n\r\n*Note: merge after it's confirmed by the SCC team*","created_at":"2014-07-04T08:08:49Z","updated_at":"2014-07-04T08:11:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99cbbd3dfb2636dc351cbbfbcd3534a87ad05083","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-registration/pulls/125/commits","review_comments_url":"https://api.github.com/repos/yast/yast-registration/pulls/125/comments","review_comment_url":"https://api.github.com/repos/yast/yast-registration/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yast/yast-registration/issues/125/comments","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/4ae40653b46e996fe96dc0e91503e985064e29aa","head":{"label":"yast:predecessor","ref":"predecessor","sha":"4ae40653b46e996fe96dc0e91503e985064e29aa","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368197,"name":"yast-registration","full_name":"yast/yast-registration","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-registration","description":"YaST module registration","fork":false,"url":"https://api.github.com/repos/yast/yast-registration","forks_url":"https://api.github.com/repos/yast/yast-registration/forks","keys_url":"https://api.github.com/repos/yast/yast-registration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-registration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-registration/teams","hooks_url":"https://api.github.com/repos/yast/yast-registration/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-registration/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-registration/events","assignees_url":"https://api.github.com/repos/yast/yast-registration/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-registration/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-registration/tags","blobs_url":"https://api.github.com/repos/yast/yast-registration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-registration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-registration/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-registration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-registration/languages","stargazers_url":"https://api.github.com/repos/yast/yast-registration/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-registration/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-registration/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-registration/subscription","commits_url":"https://api.github.com/repos/yast/yast-registration/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-registration/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-registration/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-registration/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-registration/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-registration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-registration/merges","archive_url":"https://api.github.com/repos/yast/yast-registration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-registration/downloads","issues_url":"https://api.github.com/repos/yast/yast-registration/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-registration/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-registration/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-registration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-registration/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-registration/releases{/id}","created_at":"2012-05-18T10:25:55Z","updated_at":"2014-06-26T10:35:17Z","pushed_at":"2014-07-04T08:06:36Z","git_url":"git://github.com/yast/yast-registration.git","ssh_url":"git@github.com:yast/yast-registration.git","clone_url":"https://github.com/yast/yast-registration.git","svn_url":"https://github.com/yast/yast-registration","homepage":"http://en.opensuse.org/Portal:YaST","size":8327,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"4fc8792970ae511adc737e991d259c7bc1f9528b","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368197,"name":"yast-registration","full_name":"yast/yast-registration","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-registration","description":"YaST module registration","fork":false,"url":"https://api.github.com/repos/yast/yast-registration","forks_url":"https://api.github.com/repos/yast/yast-registration/forks","keys_url":"https://api.github.com/repos/yast/yast-registration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-registration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-registration/teams","hooks_url":"https://api.github.com/repos/yast/yast-registration/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-registration/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-registration/events","assignees_url":"https://api.github.com/repos/yast/yast-registration/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-registration/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-registration/tags","blobs_url":"https://api.github.com/repos/yast/yast-registration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-registration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-registration/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-registration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-registration/languages","stargazers_url":"https://api.github.com/repos/yast/yast-registration/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-registration/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-registration/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-registration/subscription","commits_url":"https://api.github.com/repos/yast/yast-registration/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-registration/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-registration/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-registration/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-registration/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-registration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-registration/merges","archive_url":"https://api.github.com/repos/yast/yast-registration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-registration/downloads","issues_url":"https://api.github.com/repos/yast/yast-registration/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-registration/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-registration/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-registration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-registration/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-registration/releases{/id}","created_at":"2012-05-18T10:25:55Z","updated_at":"2014-06-26T10:35:17Z","pushed_at":"2014-07-04T08:06:36Z","git_url":"git://github.com/yast/yast-registration.git","ssh_url":"git@github.com:yast/yast-registration.git","clone_url":"https://github.com/yast/yast-registration.git","svn_url":"https://github.com/yast/yast-registration","homepage":"http://en.opensuse.org/Portal:YaST","size":8327,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/125"},"html":{"href":"https://github.com/yast/yast-registration/pull/125"},"issue":{"href":"https://api.github.com/repos/yast/yast-registration/issues/125"},"comments":{"href":"https://api.github.com/repos/yast/yast-registration/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-registration/statuses/4ae40653b46e996fe96dc0e91503e985064e29aa"}}}}