GitHub PullRequestReviewCommentEvent at 2014-04-17 13:34:11
Repository: mf-chsdi3
Actor: gjn
Payload: {"comment":{"url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/comments/11731769","id":11731769,"diff_hunk":"@@ -164,9 +164,10 @@ def _feature_search(self):\n             self.searchText.remove(timeInterval.group(1))\n             if min != max:\n                 timeFilter = [start, stop]\n-        searchdText = self._query_fields('@detail')\n+        # searchText list can be empty when timerange filter is used alone\n+        searchdText = self._query_fields('@detail') if not self.searchText else ''\n         if self.quadindex is not None:\n-            searchdText += ' & (' + self._get_quadindex_string() + ')'\n+            searchdText += ' & (' + self._get_quadindex_string() + ')' if not searchdText else '(' + self._get_quadindex_string() + ')'","path":"chsdi/views/search.py","position":9,"original_position":9,"commit_id":"c203f80eaebc714424de4117ba8b1bf2048f764d","original_commit_id":"c203f80eaebc714424de4117ba8b1bf2048f764d","user":{"login":"gjn","id":2572317,"avatar_url":"https://avatars.githubusercontent.com/u/2572317?","gravatar_id":"6856d9511ef090dc14eb7d14bcd19ffc","url":"https://api.github.com/users/gjn","html_url":"https://github.com/gjn","followers_url":"https://api.github.com/users/gjn/followers","following_url":"https://api.github.com/users/gjn/following{/other_user}","gists_url":"https://api.github.com/users/gjn/gists{/gist_id}","starred_url":"https://api.github.com/users/gjn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjn/subscriptions","organizations_url":"https://api.github.com/users/gjn/orgs","repos_url":"https://api.github.com/users/gjn/repos","events_url":"https://api.github.com/users/gjn/events{/privacy}","received_events_url":"https://api.github.com/users/gjn/received_events","type":"User","site_admin":false},"body":"Doesn't `if not searchdText ` return `True` when the string is empty?","created_at":"2014-04-17T13:34:11Z","updated_at":"2014-04-17T13:34:11Z","html_url":"https://github.com/geoadmin/mf-chsdi3/pull/617#discussion_r11731769","pull_request_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/617","_links":{"self":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/comments/11731769"},"html":{"href":"https://github.com/geoadmin/mf-chsdi3/pull/617#discussion_r11731769"},"pull_request":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/617"}}}}