GitHub PullRequestReviewCommentEvent at 2014-11-19 04:42:23
Repository: maestro
Actor: SamRoberts
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/CommBank/maestro/pulls/comments/20557579","id":20557579,"diff_hunk":"@@ -19,4 +19,19 @@ package data\n   * Represents a field of `A` with type `B`. It has the name of the field and a getter given an\n   * instance of `A`.\n   */\n-case class Field[A, B](name: String, get: A => B)\n+case class Field[A : Manifest, B : Manifest](name: String, get: A => B) {\n+  val typeA = manifest[A]\n+  val typeB = manifest[B]\n+\n+  /**\n+   * Fields are consider equal if name and type of column are equal\n+   * Notice that this function will be working correctly only with Fields generated by FieldsMacro.\n+   * Do not try to use it with custom created fields.\n+   */\n+  override def equals(other: Any): Boolean = other match {\n+    case f: Field[_, _] => typeA == f.typeA && typeB == f.typeB && name == f.name","path":"maestro-core/src/main/scala/au/com/cba/omnia/maestro/core/data/Field.scala","position":15,"original_position":15,"commit_id":"b5e8f71c80767fd3a3a87ba5488e7e090b8efd4b","original_commit_id":"a0f5213dd759404e5c69c1fa480e194adf1eb321","user":{"login":"SamRoberts","id":1086978,"avatar_url":"https://avatars.githubusercontent.com/u/1086978?v=3","gravatar_id":"","url":"https://api.github.com/users/SamRoberts","html_url":"https://github.com/SamRoberts","followers_url":"https://api.github.com/users/SamRoberts/followers","following_url":"https://api.github.com/users/SamRoberts/following{/other_user}","gists_url":"https://api.github.com/users/SamRoberts/gists{/gist_id}","starred_url":"https://api.github.com/users/SamRoberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamRoberts/subscriptions","organizations_url":"https://api.github.com/users/SamRoberts/orgs","repos_url":"https://api.github.com/users/SamRoberts/repos","events_url":"https://api.github.com/users/SamRoberts/events{/privacy}","received_events_url":"https://api.github.com/users/SamRoberts/received_events","type":"User","site_admin":false},"body":"No, it's not very nice. But it's also a situation that should never happen.","created_at":"2014-11-19T04:42:23Z","updated_at":"2014-11-19T04:42:23Z","html_url":"https://github.com/CommBank/maestro/pull/242#discussion_r20557579","pull_request_url":"https://api.github.com/repos/CommBank/maestro/pulls/242","_links":{"self":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/comments/20557579"},"html":{"href":"https://github.com/CommBank/maestro/pull/242#discussion_r20557579"},"pull_request":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/CommBank/maestro/pulls/242","id":24663834,"html_url":"https://github.com/CommBank/maestro/pull/242","diff_url":"https://github.com/CommBank/maestro/pull/242.diff","patch_url":"https://github.com/CommBank/maestro/pull/242.patch","issue_url":"https://api.github.com/repos/CommBank/maestro/issues/242","number":242,"state":"open","locked":false,"title":"Field equality","user":{"login":"huragan","id":3033666,"avatar_url":"https://avatars.githubusercontent.com/u/3033666?v=3","gravatar_id":"","url":"https://api.github.com/users/huragan","html_url":"https://github.com/huragan","followers_url":"https://api.github.com/users/huragan/followers","following_url":"https://api.github.com/users/huragan/following{/other_user}","gists_url":"https://api.github.com/users/huragan/gists{/gist_id}","starred_url":"https://api.github.com/users/huragan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huragan/subscriptions","organizations_url":"https://api.github.com/users/huragan/orgs","repos_url":"https://api.github.com/users/huragan/repos","events_url":"https://api.github.com/users/huragan/events{/privacy}","received_events_url":"https://api.github.com/users/huragan/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-19T03:33:54Z","updated_at":"2014-11-19T04:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"000ac16c71ec5b6a63f4c15dca01d04450f997e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CommBank/maestro/pulls/242/commits","review_comments_url":"https://api.github.com/repos/CommBank/maestro/pulls/242/comments","review_comment_url":"https://api.github.com/repos/CommBank/maestro/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CommBank/maestro/issues/242/comments","statuses_url":"https://api.github.com/repos/CommBank/maestro/statuses/b5e8f71c80767fd3a3a87ba5488e7e090b8efd4b","head":{"label":"CommBank:field_equality","ref":"field_equality","sha":"b5e8f71c80767fd3a3a87ba5488e7e090b8efd4b","user":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"repo":{"id":17347463,"name":"maestro","full_name":"CommBank/maestro","owner":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CommBank/maestro","description":"Data Pipelines that are well typed and enforce good convention","fork":false,"url":"https://api.github.com/repos/CommBank/maestro","forks_url":"https://api.github.com/repos/CommBank/maestro/forks","keys_url":"https://api.github.com/repos/CommBank/maestro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CommBank/maestro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CommBank/maestro/teams","hooks_url":"https://api.github.com/repos/CommBank/maestro/hooks","issue_events_url":"https://api.github.com/repos/CommBank/maestro/issues/events{/number}","events_url":"https://api.github.com/repos/CommBank/maestro/events","assignees_url":"https://api.github.com/repos/CommBank/maestro/assignees{/user}","branches_url":"https://api.github.com/repos/CommBank/maestro/branches{/branch}","tags_url":"https://api.github.com/repos/CommBank/maestro/tags","blobs_url":"https://api.github.com/repos/CommBank/maestro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CommBank/maestro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CommBank/maestro/git/refs{/sha}","trees_url":"https://api.github.com/repos/CommBank/maestro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CommBank/maestro/statuses/{sha}","languages_url":"https://api.github.com/repos/CommBank/maestro/languages","stargazers_url":"https://api.github.com/repos/CommBank/maestro/stargazers","contributors_url":"https://api.github.com/repos/CommBank/maestro/contributors","subscribers_url":"https://api.github.com/repos/CommBank/maestro/subscribers","subscription_url":"https://api.github.com/repos/CommBank/maestro/subscription","commits_url":"https://api.github.com/repos/CommBank/maestro/commits{/sha}","git_commits_url":"https://api.github.com/repos/CommBank/maestro/git/commits{/sha}","comments_url":"https://api.github.com/repos/CommBank/maestro/comments{/number}","issue_comment_url":"https://api.github.com/repos/CommBank/maestro/issues/comments/{number}","contents_url":"https://api.github.com/repos/CommBank/maestro/contents/{+path}","compare_url":"https://api.github.com/repos/CommBank/maestro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CommBank/maestro/merges","archive_url":"https://api.github.com/repos/CommBank/maestro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CommBank/maestro/downloads","issues_url":"https://api.github.com/repos/CommBank/maestro/issues{/number}","pulls_url":"https://api.github.com/repos/CommBank/maestro/pulls{/number}","milestones_url":"https://api.github.com/repos/CommBank/maestro/milestones{/number}","notifications_url":"https://api.github.com/repos/CommBank/maestro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CommBank/maestro/labels{/name}","releases_url":"https://api.github.com/repos/CommBank/maestro/releases{/id}","created_at":"2014-03-02T21:34:53Z","updated_at":"2014-11-18T04:48:15Z","pushed_at":"2014-11-19T04:05:12Z","git_url":"git://github.com/CommBank/maestro.git","ssh_url":"git@github.com:CommBank/maestro.git","clone_url":"https://github.com/CommBank/maestro.git","svn_url":"https://github.com/CommBank/maestro","homepage":"https://commbank.github.io/maestro","size":21236,"stargazers_count":17,"watchers_count":17,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":62,"forks":10,"open_issues":62,"watchers":17,"default_branch":"master"}},"base":{"label":"CommBank:master","ref":"master","sha":"86b7edb8662b793a6ea56c4e5c77317b040e635b","user":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"repo":{"id":17347463,"name":"maestro","full_name":"CommBank/maestro","owner":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CommBank/maestro","description":"Data Pipelines that are well typed and enforce good convention","fork":false,"url":"https://api.github.com/repos/CommBank/maestro","forks_url":"https://api.github.com/repos/CommBank/maestro/forks","keys_url":"https://api.github.com/repos/CommBank/maestro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CommBank/maestro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CommBank/maestro/teams","hooks_url":"https://api.github.com/repos/CommBank/maestro/hooks","issue_events_url":"https://api.github.com/repos/CommBank/maestro/issues/events{/number}","events_url":"https://api.github.com/repos/CommBank/maestro/events","assignees_url":"https://api.github.com/repos/CommBank/maestro/assignees{/user}","branches_url":"https://api.github.com/repos/CommBank/maestro/branches{/branch}","tags_url":"https://api.github.com/repos/CommBank/maestro/tags","blobs_url":"https://api.github.com/repos/CommBank/maestro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CommBank/maestro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CommBank/maestro/git/refs{/sha}","trees_url":"https://api.github.com/repos/CommBank/maestro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CommBank/maestro/statuses/{sha}","languages_url":"https://api.github.com/repos/CommBank/maestro/languages","stargazers_url":"https://api.github.com/repos/CommBank/maestro/stargazers","contributors_url":"https://api.github.com/repos/CommBank/maestro/contributors","subscribers_url":"https://api.github.com/repos/CommBank/maestro/subscribers","subscription_url":"https://api.github.com/repos/CommBank/maestro/subscription","commits_url":"https://api.github.com/repos/CommBank/maestro/commits{/sha}","git_commits_url":"https://api.github.com/repos/CommBank/maestro/git/commits{/sha}","comments_url":"https://api.github.com/repos/CommBank/maestro/comments{/number}","issue_comment_url":"https://api.github.com/repos/CommBank/maestro/issues/comments/{number}","contents_url":"https://api.github.com/repos/CommBank/maestro/contents/{+path}","compare_url":"https://api.github.com/repos/CommBank/maestro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CommBank/maestro/merges","archive_url":"https://api.github.com/repos/CommBank/maestro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CommBank/maestro/downloads","issues_url":"https://api.github.com/repos/CommBank/maestro/issues{/number}","pulls_url":"https://api.github.com/repos/CommBank/maestro/pulls{/number}","milestones_url":"https://api.github.com/repos/CommBank/maestro/milestones{/number}","notifications_url":"https://api.github.com/repos/CommBank/maestro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CommBank/maestro/labels{/name}","releases_url":"https://api.github.com/repos/CommBank/maestro/releases{/id}","created_at":"2014-03-02T21:34:53Z","updated_at":"2014-11-18T04:48:15Z","pushed_at":"2014-11-19T04:05:12Z","git_url":"git://github.com/CommBank/maestro.git","ssh_url":"git@github.com:CommBank/maestro.git","clone_url":"https://github.com/CommBank/maestro.git","svn_url":"https://github.com/CommBank/maestro","homepage":"https://commbank.github.io/maestro","size":21236,"stargazers_count":17,"watchers_count":17,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":62,"forks":10,"open_issues":62,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/242"},"html":{"href":"https://github.com/CommBank/maestro/pull/242"},"issue":{"href":"https://api.github.com/repos/CommBank/maestro/issues/242"},"comments":{"href":"https://api.github.com/repos/CommBank/maestro/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/CommBank/maestro/statuses/b5e8f71c80767fd3a3a87ba5488e7e090b8efd4b"}}}}