GitHub PullRequestReviewCommentEvent at 2014-07-17 14:30:07
Repository: bem-site-engine
Actor: tormozz48
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bem/bem-site-engine/pulls/comments/15060358","id":15060358,"diff_hunk":"@@ -23,18 +23,19 @@ module.exports = function(obj) {\n             translators: [],\n             tags: {}\n         },\n-        promises = util.findNodesByCriteria(obj.sitemap, function() {\n-                return this.source;\n-            })\n+        promises = util\n+            .findNodesByCriteria(obj.sitemap, function() { return this.source; }, false)\n             .map(function (node) {\n-                return vow.allResolved(languages.map(function (lang) {\n+                return vow.all(languages.map(function (lang) {\n                     return analyzeMetaInformation(node, lang, collected)\n                         .then(function(res) {\n                             return loadMDFile(res.node, lang, res.repo);\n                         })\n-                        .then(function (res) {\n-                            node.source[lang].url = node.source[lang].content;\n-                            node.source[lang].content = res;\n+                        .then(function(res) {\n+                            if(res) {","path":"src/data/snapshot/load_sources.js","position":20,"original_position":20,"commit_id":"25b3f0679fb1971b821aced59b1ac9a5713b69df","original_commit_id":"25b3f0679fb1971b821aced59b1ac9a5713b69df","user":{"login":"tormozz48","id":996162,"avatar_url":"https://avatars.githubusercontent.com/u/996162?","gravatar_id":"b45acb98dd42b1d0f45158c34725ccf5","url":"https://api.github.com/users/tormozz48","html_url":"https://github.com/tormozz48","followers_url":"https://api.github.com/users/tormozz48/followers","following_url":"https://api.github.com/users/tormozz48/following{/other_user}","gists_url":"https://api.github.com/users/tormozz48/gists{/gist_id}","starred_url":"https://api.github.com/users/tormozz48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tormozz48/subscriptions","organizations_url":"https://api.github.com/users/tormozz48/orgs","repos_url":"https://api.github.com/users/tormozz48/repos","events_url":"https://api.github.com/users/tormozz48/events{/privacy}","received_events_url":"https://api.github.com/users/tormozz48/received_events","type":"User","site_admin":false},"body":"We already have provided detail logging for all cases inside loadMDFile method","created_at":"2014-07-17T14:30:07Z","updated_at":"2014-07-17T14:30:07Z","html_url":"https://github.com/bem/bem-site-engine/pull/3#discussion_r15060358","pull_request_url":"https://api.github.com/repos/bem/bem-site-engine/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/bem/bem-site-engine/pulls/comments/15060358"},"html":{"href":"https://github.com/bem/bem-site-engine/pull/3#discussion_r15060358"},"pull_request":{"href":"https://api.github.com/repos/bem/bem-site-engine/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/bem/bem-site-engine/pulls/3","id":18336870,"html_url":"https://github.com/bem/bem-site-engine/pull/3","diff_url":"https://github.com/bem/bem-site-engine/pull/3.diff","patch_url":"https://github.com/bem/bem-site-engine/pull/3.patch","issue_url":"https://api.github.com/repos/bem/bem-site-engine/issues/3","number":3,"state":"open","title":"tightened conditions for successful data build","user":{"login":"tormozz48","id":996162,"avatar_url":"https://avatars.githubusercontent.com/u/996162?","gravatar_id":"b45acb98dd42b1d0f45158c34725ccf5","url":"https://api.github.com/users/tormozz48","html_url":"https://github.com/tormozz48","followers_url":"https://api.github.com/users/tormozz48/followers","following_url":"https://api.github.com/users/tormozz48/following{/other_user}","gists_url":"https://api.github.com/users/tormozz48/gists{/gist_id}","starred_url":"https://api.github.com/users/tormozz48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tormozz48/subscriptions","organizations_url":"https://api.github.com/users/tormozz48/orgs","repos_url":"https://api.github.com/users/tormozz48/repos","events_url":"https://api.github.com/users/tormozz48/events{/privacy}","received_events_url":"https://api.github.com/users/tormozz48/received_events","type":"User","site_admin":false},"body":"Now if any of doc *.md files doesn't load by any reasons the main process will be stopped with error\r\nThe same way was already been implemented for people and library loading\r\n\r\n@tadatuta @tavriaforever @dab ","created_at":"2014-07-14T08:35:45Z","updated_at":"2014-07-17T14:30:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"311cf4fb0d29c4c04f91970176165df7e4e3ab13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bem/bem-site-engine/pulls/3/commits","review_comments_url":"https://api.github.com/repos/bem/bem-site-engine/pulls/3/comments","review_comment_url":"https://api.github.com/repos/bem/bem-site-engine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bem/bem-site-engine/issues/3/comments","statuses_url":"https://api.github.com/repos/bem/bem-site-engine/statuses/25b3f0679fb1971b821aced59b1ac9a5713b69df","head":{"label":"bem:BEMINFO-329","ref":"BEMINFO-329","sha":"25b3f0679fb1971b821aced59b1ac9a5713b69df","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?","gravatar_id":"18b6e3435ca67fe775d3b21e1a70b25a","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":21749342,"name":"bem-site-engine","full_name":"bem/bem-site-engine","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?","gravatar_id":"18b6e3435ca67fe775d3b21e1a70b25a","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/bem-site-engine","description":"BEM CMS based on Express framework.","fork":false,"url":"https://api.github.com/repos/bem/bem-site-engine","forks_url":"https://api.github.com/repos/bem/bem-site-engine/forks","keys_url":"https://api.github.com/repos/bem/bem-site-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/bem-site-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/bem-site-engine/teams","hooks_url":"https://api.github.com/repos/bem/bem-site-engine/hooks","issue_events_url":"https://api.github.com/repos/bem/bem-site-engine/issues/events{/number}","events_url":"https://api.github.com/repos/bem/bem-site-engine/events","assignees_url":"https://api.github.com/repos/bem/bem-site-engine/assignees{/user}","branches_url":"https://api.github.com/repos/bem/bem-site-engine/branches{/branch}","tags_url":"https://api.github.com/repos/bem/bem-site-engine/tags","blobs_url":"https://api.github.com/repos/bem/bem-site-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/bem-site-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/bem-site-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/bem-site-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/bem-site-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/bem-site-engine/languages","stargazers_url":"https://api.github.com/repos/bem/bem-site-engine/stargazers","contributors_url":"https://api.github.com/repos/bem/bem-site-engine/contributors","subscribers_url":"https://api.github.com/repos/bem/bem-site-engine/subscribers","subscription_url":"https://api.github.com/repos/bem/bem-site-engine/subscription","commits_url":"https://api.github.com/repos/bem/bem-site-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/bem-site-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/bem-site-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/bem-site-engine/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/bem-site-engine/contents/{+path}","compare_url":"https://api.github.com/repos/bem/bem-site-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/bem-site-engine/merges","archive_url":"https://api.github.com/repos/bem/bem-site-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/bem-site-engine/downloads","issues_url":"https://api.github.com/repos/bem/bem-site-engine/issues{/number}","pulls_url":"https://api.github.com/repos/bem/bem-site-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/bem-site-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/bem-site-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/bem-site-engine/labels{/name}","releases_url":"https://api.github.com/repos/bem/bem-site-engine/releases{/id}","created_at":"2014-07-11T19:54:28Z","updated_at":"2014-07-12T19:30:28Z","pushed_at":"2014-07-17T14:17:39Z","git_url":"git://github.com/bem/bem-site-engine.git","ssh_url":"git@github.com:bem/bem-site-engine.git","clone_url":"https://github.com/bem/bem-site-engine.git","svn_url":"https://github.com/bem/bem-site-engine","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"dev"}},"base":{"label":"bem:dev","ref":"dev","sha":"7fea20e3e5b521ded9648a93c8c2478d8194bcfd","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?","gravatar_id":"18b6e3435ca67fe775d3b21e1a70b25a","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":21749342,"name":"bem-site-engine","full_name":"bem/bem-site-engine","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?","gravatar_id":"18b6e3435ca67fe775d3b21e1a70b25a","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/bem-site-engine","description":"BEM CMS based on Express framework.","fork":false,"url":"https://api.github.com/repos/bem/bem-site-engine","forks_url":"https://api.github.com/repos/bem/bem-site-engine/forks","keys_url":"https://api.github.com/repos/bem/bem-site-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/bem-site-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/bem-site-engine/teams","hooks_url":"https://api.github.com/repos/bem/bem-site-engine/hooks","issue_events_url":"https://api.github.com/repos/bem/bem-site-engine/issues/events{/number}","events_url":"https://api.github.com/repos/bem/bem-site-engine/events","assignees_url":"https://api.github.com/repos/bem/bem-site-engine/assignees{/user}","branches_url":"https://api.github.com/repos/bem/bem-site-engine/branches{/branch}","tags_url":"https://api.github.com/repos/bem/bem-site-engine/tags","blobs_url":"https://api.github.com/repos/bem/bem-site-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/bem-site-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/bem-site-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/bem-site-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/bem-site-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/bem-site-engine/languages","stargazers_url":"https://api.github.com/repos/bem/bem-site-engine/stargazers","contributors_url":"https://api.github.com/repos/bem/bem-site-engine/contributors","subscribers_url":"https://api.github.com/repos/bem/bem-site-engine/subscribers","subscription_url":"https://api.github.com/repos/bem/bem-site-engine/subscription","commits_url":"https://api.github.com/repos/bem/bem-site-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/bem-site-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/bem-site-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/bem-site-engine/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/bem-site-engine/contents/{+path}","compare_url":"https://api.github.com/repos/bem/bem-site-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/bem-site-engine/merges","archive_url":"https://api.github.com/repos/bem/bem-site-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/bem-site-engine/downloads","issues_url":"https://api.github.com/repos/bem/bem-site-engine/issues{/number}","pulls_url":"https://api.github.com/repos/bem/bem-site-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/bem-site-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/bem-site-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/bem-site-engine/labels{/name}","releases_url":"https://api.github.com/repos/bem/bem-site-engine/releases{/id}","created_at":"2014-07-11T19:54:28Z","updated_at":"2014-07-12T19:30:28Z","pushed_at":"2014-07-17T14:17:39Z","git_url":"git://github.com/bem/bem-site-engine.git","ssh_url":"git@github.com:bem/bem-site-engine.git","clone_url":"https://github.com/bem/bem-site-engine.git","svn_url":"https://github.com/bem/bem-site-engine","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/bem/bem-site-engine/pulls/3"},"html":{"href":"https://github.com/bem/bem-site-engine/pull/3"},"issue":{"href":"https://api.github.com/repos/bem/bem-site-engine/issues/3"},"comments":{"href":"https://api.github.com/repos/bem/bem-site-engine/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/bem/bem-site-engine/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/bem/bem-site-engine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bem/bem-site-engine/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/bem/bem-site-engine/statuses/25b3f0679fb1971b821aced59b1ac9a5713b69df"}}}}