GitHub PullRequestEvent at 2014-10-31 10:46:02
Repository: neovim
Actor: tarruda
Payload: {"action":"closed","number":1358,"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1358","id":23564816,"html_url":"https://github.com/neovim/neovim/pull/1358","diff_url":"https://github.com/neovim/neovim/pull/1358.diff","patch_url":"https://github.com/neovim/neovim/pull/1358.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1358","number":1358,"state":"closed","locked":false,"title":"[RDY] Fix python setup","user":{"login":"elmart","id":135757,"avatar_url":"https://avatars.githubusercontent.com/u/135757?v=2","gravatar_id":"","url":"https://api.github.com/users/elmart","html_url":"https://github.com/elmart","followers_url":"https://api.github.com/users/elmart/followers","following_url":"https://api.github.com/users/elmart/following{/other_user}","gists_url":"https://api.github.com/users/elmart/gists{/gist_id}","starred_url":"https://api.github.com/users/elmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmart/subscriptions","organizations_url":"https://api.github.com/users/elmart/orgs","repos_url":"https://api.github.com/users/elmart/repos","events_url":"https://api.github.com/users/elmart/events{/privacy}","received_events_url":"https://api.github.com/users/elmart/received_events","type":"User","site_admin":false},"body":"This evening I wanted to try if my python plugins worked.\r\nI pip installed neovim module and added the call to python_setup to my .vimrc, and started neovim.\r\nBut all my python plugins complained about python not being available.\r\npython_setup.vim was executing before anything else, there were no errors... weird.\r\n\r\nUntil I realized it was picking the wrong version of python.\r\nI mean, I have macports python (version 2.7.8) in addition to system-level python (2.7.6). \r\nMacports python is the one first in my path, and the one I used to pip install neovim module.\r\nBut, for some reason, neovim was just picking system level python.\r\n\r\nIn the end, it turns out that, in python_setup.vim:\r\n- executable() calls do in fact respect $PATH, and detect macports version.\r\n- system() calls do not respect $PATH, and execute system-level python.\r\n\r\nAnd so, they don't find neovim module. But it doesn't say anything!\r\n\r\nSo, this PR fixes two points:\r\n- Makes python setup report errors, if any, making clear which python version is being picked.\r\n- Makes sure python version on user's path is used on system() calls.","created_at":"2014-10-29T21:05:46Z","updated_at":"2014-10-31T10:46:01Z","closed_at":"2014-10-31T10:46:00Z","merged_at":null,"merge_commit_sha":"e90595c152976b048854edcb6d0574e9c8505b4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1358/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1358/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1358/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/bf8090f3e88da22a402a9c628ac662973e510897","head":{"label":"elmart:python-setup","ref":"python-setup","sha":"bf8090f3e88da22a402a9c628ac662973e510897","user":{"login":"elmart","id":135757,"avatar_url":"https://avatars.githubusercontent.com/u/135757?v=2","gravatar_id":"","url":"https://api.github.com/users/elmart","html_url":"https://github.com/elmart","followers_url":"https://api.github.com/users/elmart/followers","following_url":"https://api.github.com/users/elmart/following{/other_user}","gists_url":"https://api.github.com/users/elmart/gists{/gist_id}","starred_url":"https://api.github.com/users/elmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmart/subscriptions","organizations_url":"https://api.github.com/users/elmart/orgs","repos_url":"https://api.github.com/users/elmart/repos","events_url":"https://api.github.com/users/elmart/events{/privacy}","received_events_url":"https://api.github.com/users/elmart/received_events","type":"User","site_admin":false},"repo":{"id":18412494,"name":"neovim","full_name":"elmart/neovim","owner":{"login":"elmart","id":135757,"avatar_url":"https://avatars.githubusercontent.com/u/135757?v=2","gravatar_id":"","url":"https://api.github.com/users/elmart","html_url":"https://github.com/elmart","followers_url":"https://api.github.com/users/elmart/followers","following_url":"https://api.github.com/users/elmart/following{/other_user}","gists_url":"https://api.github.com/users/elmart/gists{/gist_id}","starred_url":"https://api.github.com/users/elmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmart/subscriptions","organizations_url":"https://api.github.com/users/elmart/orgs","repos_url":"https://api.github.com/users/elmart/repos","events_url":"https://api.github.com/users/elmart/events{/privacy}","received_events_url":"https://api.github.com/users/elmart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elmart/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/elmart/neovim","forks_url":"https://api.github.com/repos/elmart/neovim/forks","keys_url":"https://api.github.com/repos/elmart/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elmart/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elmart/neovim/teams","hooks_url":"https://api.github.com/repos/elmart/neovim/hooks","issue_events_url":"https://api.github.com/repos/elmart/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/elmart/neovim/events","assignees_url":"https://api.github.com/repos/elmart/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/elmart/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/elmart/neovim/tags","blobs_url":"https://api.github.com/repos/elmart/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elmart/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elmart/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/elmart/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elmart/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/elmart/neovim/languages","stargazers_url":"https://api.github.com/repos/elmart/neovim/stargazers","contributors_url":"https://api.github.com/repos/elmart/neovim/contributors","subscribers_url":"https://api.github.com/repos/elmart/neovim/subscribers","subscription_url":"https://api.github.com/repos/elmart/neovim/subscription","commits_url":"https://api.github.com/repos/elmart/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/elmart/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/elmart/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/elmart/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/elmart/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/elmart/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elmart/neovim/merges","archive_url":"https://api.github.com/repos/elmart/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elmart/neovim/downloads","issues_url":"https://api.github.com/repos/elmart/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/elmart/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/elmart/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/elmart/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elmart/neovim/labels{/name}","releases_url":"https://api.github.com/repos/elmart/neovim/releases{/id}","created_at":"2014-04-03T17:50:33Z","updated_at":"2014-10-28T21:16:17Z","pushed_at":"2014-10-29T20:50:06Z","git_url":"git://github.com/elmart/neovim.git","ssh_url":"git@github.com:elmart/neovim.git","clone_url":"https://github.com/elmart/neovim.git","svn_url":"https://github.com/elmart/neovim","homepage":"http://neovim.org/","size":22901,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"3fc542b45bc6b3b826f7c2eabffe1ede3cb7afbf","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=2","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=2","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim for the 21st century","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2014-10-31T09:12:46Z","pushed_at":"2014-10-31T10:45:59Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org/","size":62484,"stargazers_count":10341,"watchers_count":10341,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":667,"mirror_url":null,"open_issues_count":245,"forks":667,"open_issues":245,"watchers":10341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1358"},"html":{"href":"https://github.com/neovim/neovim/pull/1358"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1358"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1358/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1358/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1358/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/bf8090f3e88da22a402a9c628ac662973e510897"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":11,"review_comments":5,"commits":2,"additions":17,"deletions":3,"changed_files":1}}