GitHub PullRequestReviewCommentEvent at 2014-11-06 15:03:28
Repository: deuce-client
Actor: BenjamenMeyer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/comments/19948917","id":19948917,"diff_hunk":"@@ -207,6 +235,10 @@ def _abort(error_code):\n \n FileBlockOffsetRule = Rule(val_file_block_offset(), lambda: _abort(600))\n \n+FileSplitterStateRule = Rule(file_splitter_state_validation(none_ok=True),\n+                             lambda: _abort(600))\n+FileSplitterInputStreamRule = Rule(file_splitter_input_stream_validation(),","path":"deuceclient/common/validation.py","position":57,"original_position":57,"commit_id":"e191653b8c4d5aced568eb5c0d12d2750c539f29","original_commit_id":"e191653b8c4d5aced568eb5c0d12d2750c539f29","user":{"login":"BenjamenMeyer","id":1074110,"avatar_url":"https://avatars.githubusercontent.com/u/1074110?v=2","gravatar_id":"","url":"https://api.github.com/users/BenjamenMeyer","html_url":"https://github.com/BenjamenMeyer","followers_url":"https://api.github.com/users/BenjamenMeyer/followers","following_url":"https://api.github.com/users/BenjamenMeyer/following{/other_user}","gists_url":"https://api.github.com/users/BenjamenMeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjamenMeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjamenMeyer/subscriptions","organizations_url":"https://api.github.com/users/BenjamenMeyer/orgs","repos_url":"https://api.github.com/users/BenjamenMeyer/repos","events_url":"https://api.github.com/users/BenjamenMeyer/events{/privacy}","received_events_url":"https://api.github.com/users/BenjamenMeyer/received_events","type":"User","site_admin":false},"body":"True, we are looking at attributes for the FileSplitterInputStreamRule; I didn't want to make it a hard dependency on a File object, but more of a File-like object. I could go either way...","created_at":"2014-11-06T15:03:28Z","updated_at":"2014-11-06T15:03:28Z","html_url":"https://github.com/rackerlabs/deuce-client/pull/27#discussion_r19948917","pull_request_url":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/comments/19948917"},"html":{"href":"https://github.com/rackerlabs/deuce-client/pull/27#discussion_r19948917"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/27","id":23707933,"html_url":"https://github.com/rackerlabs/deuce-client/pull/27","diff_url":"https://github.com/rackerlabs/deuce-client/pull/27.diff","patch_url":"https://github.com/rackerlabs/deuce-client/pull/27.patch","issue_url":"https://api.github.com/repos/rackerlabs/deuce-client/issues/27","number":27,"state":"open","locked":false,"title":"Bug Fix (upload content length) and Enhancement (File Splitting)","user":{"login":"BenjamenMeyer","id":1074110,"avatar_url":"https://avatars.githubusercontent.com/u/1074110?v=2","gravatar_id":"","url":"https://api.github.com/users/BenjamenMeyer","html_url":"https://github.com/BenjamenMeyer","followers_url":"https://api.github.com/users/BenjamenMeyer/followers","following_url":"https://api.github.com/users/BenjamenMeyer/following{/other_user}","gists_url":"https://api.github.com/users/BenjamenMeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjamenMeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjamenMeyer/subscriptions","organizations_url":"https://api.github.com/users/BenjamenMeyer/orgs","repos_url":"https://api.github.com/users/BenjamenMeyer/repos","events_url":"https://api.github.com/users/BenjamenMeyer/events{/privacy}","received_events_url":"https://api.github.com/users/BenjamenMeyer/received_events","type":"User","site_admin":false},"body":"- Bug Fix: headers for setting content length in upload were not actually being used\r\n- Enhancement: Introduces API for splitting a file into blocks; provides one implementation of the API to split a file into uniformly sized blocks\r\n\r\nDEPENDS: PR #24 \r\nStarts Resolving Issue #22 ","created_at":"2014-10-31T21:44:53Z","updated_at":"2014-11-06T15:03:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6674ec93af3bf0e32f8f85435bd02ec91e1e07c6","assignee":{"login":"BenjamenMeyer","id":1074110,"avatar_url":"https://avatars.githubusercontent.com/u/1074110?v=2","gravatar_id":"","url":"https://api.github.com/users/BenjamenMeyer","html_url":"https://github.com/BenjamenMeyer","followers_url":"https://api.github.com/users/BenjamenMeyer/followers","following_url":"https://api.github.com/users/BenjamenMeyer/following{/other_user}","gists_url":"https://api.github.com/users/BenjamenMeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjamenMeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjamenMeyer/subscriptions","organizations_url":"https://api.github.com/users/BenjamenMeyer/orgs","repos_url":"https://api.github.com/users/BenjamenMeyer/repos","events_url":"https://api.github.com/users/BenjamenMeyer/events{/privacy}","received_events_url":"https://api.github.com/users/BenjamenMeyer/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/27/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/27/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackerlabs/deuce-client/issues/27/comments","statuses_url":"https://api.github.com/repos/rackerlabs/deuce-client/statuses/e191653b8c4d5aced568eb5c0d12d2750c539f29","head":{"label":"BenjamenMeyer:bugfix_upload_content_length","ref":"bugfix_upload_content_length","sha":"e191653b8c4d5aced568eb5c0d12d2750c539f29","user":{"login":"BenjamenMeyer","id":1074110,"avatar_url":"https://avatars.githubusercontent.com/u/1074110?v=2","gravatar_id":"","url":"https://api.github.com/users/BenjamenMeyer","html_url":"https://github.com/BenjamenMeyer","followers_url":"https://api.github.com/users/BenjamenMeyer/followers","following_url":"https://api.github.com/users/BenjamenMeyer/following{/other_user}","gists_url":"https://api.github.com/users/BenjamenMeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjamenMeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjamenMeyer/subscriptions","organizations_url":"https://api.github.com/users/BenjamenMeyer/orgs","repos_url":"https://api.github.com/users/BenjamenMeyer/repos","events_url":"https://api.github.com/users/BenjamenMeyer/events{/privacy}","received_events_url":"https://api.github.com/users/BenjamenMeyer/received_events","type":"User","site_admin":false},"repo":{"id":23880367,"name":"deuce-client","full_name":"BenjamenMeyer/deuce-client","owner":{"login":"BenjamenMeyer","id":1074110,"avatar_url":"https://avatars.githubusercontent.com/u/1074110?v=2","gravatar_id":"","url":"https://api.github.com/users/BenjamenMeyer","html_url":"https://github.com/BenjamenMeyer","followers_url":"https://api.github.com/users/BenjamenMeyer/followers","following_url":"https://api.github.com/users/BenjamenMeyer/following{/other_user}","gists_url":"https://api.github.com/users/BenjamenMeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjamenMeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjamenMeyer/subscriptions","organizations_url":"https://api.github.com/users/BenjamenMeyer/orgs","repos_url":"https://api.github.com/users/BenjamenMeyer/repos","events_url":"https://api.github.com/users/BenjamenMeyer/events{/privacy}","received_events_url":"https://api.github.com/users/BenjamenMeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BenjamenMeyer/deuce-client","description":"Python Client Library for Deuce","fork":true,"url":"https://api.github.com/repos/BenjamenMeyer/deuce-client","forks_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/forks","keys_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/teams","hooks_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/hooks","issue_events_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/issues/events{/number}","events_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/events","assignees_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/assignees{/user}","branches_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/branches{/branch}","tags_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/tags","blobs_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/statuses/{sha}","languages_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/languages","stargazers_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/stargazers","contributors_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/contributors","subscribers_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/subscribers","subscription_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/subscription","commits_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/contents/{+path}","compare_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/merges","archive_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/downloads","issues_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/issues{/number}","pulls_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/pulls{/number}","milestones_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/milestones{/number}","notifications_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/labels{/name}","releases_url":"https://api.github.com/repos/BenjamenMeyer/deuce-client/releases{/id}","created_at":"2014-09-10T15:40:16Z","updated_at":"2014-09-22T14:28:28Z","pushed_at":"2014-11-04T22:23:40Z","git_url":"git://github.com/BenjamenMeyer/deuce-client.git","ssh_url":"git@github.com:BenjamenMeyer/deuce-client.git","clone_url":"https://github.com/BenjamenMeyer/deuce-client.git","svn_url":"https://github.com/BenjamenMeyer/deuce-client","homepage":null,"size":617,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"8a5e4e17853c7d19ce62ef019dbbf0a148f39e13","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=2","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23879782,"name":"deuce-client","full_name":"rackerlabs/deuce-client","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=2","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/deuce-client","description":"Python Client Library for Deuce","fork":false,"url":"https://api.github.com/repos/rackerlabs/deuce-client","forks_url":"https://api.github.com/repos/rackerlabs/deuce-client/forks","keys_url":"https://api.github.com/repos/rackerlabs/deuce-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/deuce-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/deuce-client/teams","hooks_url":"https://api.github.com/repos/rackerlabs/deuce-client/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/deuce-client/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/deuce-client/events","assignees_url":"https://api.github.com/repos/rackerlabs/deuce-client/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/deuce-client/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/deuce-client/tags","blobs_url":"https://api.github.com/repos/rackerlabs/deuce-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/deuce-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/deuce-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/deuce-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/deuce-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/deuce-client/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/deuce-client/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/deuce-client/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/deuce-client/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/deuce-client/subscription","commits_url":"https://api.github.com/repos/rackerlabs/deuce-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/deuce-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/deuce-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/deuce-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/deuce-client/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/deuce-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/deuce-client/merges","archive_url":"https://api.github.com/repos/rackerlabs/deuce-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/deuce-client/downloads","issues_url":"https://api.github.com/repos/rackerlabs/deuce-client/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/deuce-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/deuce-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/deuce-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/deuce-client/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/deuce-client/releases{/id}","created_at":"2014-09-10T15:25:18Z","updated_at":"2014-09-22T14:28:30Z","pushed_at":"2014-11-04T17:41:47Z","git_url":"git://github.com/rackerlabs/deuce-client.git","ssh_url":"git@github.com:rackerlabs/deuce-client.git","clone_url":"https://github.com/rackerlabs/deuce-client.git","svn_url":"https://github.com/rackerlabs/deuce-client","homepage":null,"size":742,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/27"},"html":{"href":"https://github.com/rackerlabs/deuce-client/pull/27"},"issue":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/issues/27"},"comments":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/deuce-client/statuses/e191653b8c4d5aced568eb5c0d12d2750c539f29"}}}}