GitHub PullRequestEvent at 2014-10-28 16:29:37
Repository: edx-platform
Actor: tymofij
Payload: {"action":"closed","number":5761,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/5761","id":23464750,"html_url":"https://github.com/edx/edx-platform/pull/5761","diff_url":"https://github.com/edx/edx-platform/pull/5761.diff","patch_url":"https://github.com/edx/edx-platform/pull/5761.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/5761","number":5761,"state":"closed","locked":false,"title":"Do not show middle-click href in marketing iframe for logged in users","user":{"login":"tymofij","id":123786,"avatar_url":"https://avatars.githubusercontent.com/u/123786?v=2","gravatar_id":"","url":"https://api.github.com/users/tymofij","html_url":"https://github.com/tymofij","followers_url":"https://api.github.com/users/tymofij/followers","following_url":"https://api.github.com/users/tymofij/following{/other_user}","gists_url":"https://api.github.com/users/tymofij/gists{/gist_id}","starred_url":"https://api.github.com/users/tymofij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymofij/subscriptions","organizations_url":"https://api.github.com/users/tymofij/orgs","repos_url":"https://api.github.com/users/tymofij/repos","events_url":"https://api.github.com/users/tymofij/events{/privacy}","received_events_url":"https://api.github.com/users/tymofij/received_events","type":"User","site_admin":false},"body":"https://github.com/edx/edx-platform/pull/5657/ beside of reducing JS size in marketing iframe added real middle-clickable hrefs on \"Enrol\" button.\r\n\r\nFor anonymous users it pointed to registration-for-a-course page\r\nFor logged in users it pointed to course-about-page.\r\n\r\nLeft-clicking was not affected, as it was handled javascriptically.\r\n\r\nIssue I just found was that courses which did not yet start instead of About display \"page not found\".\r\nThis patch removes added link for authorized users, avoiding possible confusion and experience worse than it was before TNL-281.\r\n\r\n@explorerleslie @cahrens @auraz @martynjames ","created_at":"2014-10-28T15:29:10Z","updated_at":"2014-10-28T16:29:36Z","closed_at":"2014-10-28T16:29:36Z","merged_at":"2014-10-28T16:29:36Z","merge_commit_sha":"e80243a6cab2e5656403fd11d6c2b8f799d6e980","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/5761/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/5761/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/5761/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/960f7b206a1cb93adff9abb98cfda9f092158e44","head":{"label":"edx:tim/mktg-iframe-fix","ref":"tim/mktg-iframe-fix","sha":"960f7b206a1cb93adff9abb98cfda9f092158e44","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-10-28T13:22:24Z","pushed_at":"2014-10-28T16:29:36Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1651715,"stargazers_count":1488,"watchers_count":1488,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":854,"mirror_url":null,"open_issues_count":103,"forks":854,"open_issues":103,"watchers":1488,"default_branch":"master"}},"base":{"label":"edx:rc/2014-10-27","ref":"rc/2014-10-27","sha":"ee5594841652f77299610cbd1b49a8033436fb39","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-10-28T13:22:24Z","pushed_at":"2014-10-28T16:29:36Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1651715,"stargazers_count":1488,"watchers_count":1488,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":854,"mirror_url":null,"open_issues_count":103,"forks":854,"open_issues":103,"watchers":1488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/5761"},"html":{"href":"https://github.com/edx/edx-platform/pull/5761"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/5761"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/5761/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/5761/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/5761/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/960f7b206a1cb93adff9abb98cfda9f092158e44"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tymofij","id":123786,"avatar_url":"https://avatars.githubusercontent.com/u/123786?v=2","gravatar_id":"","url":"https://api.github.com/users/tymofij","html_url":"https://github.com/tymofij","followers_url":"https://api.github.com/users/tymofij/followers","following_url":"https://api.github.com/users/tymofij/following{/other_user}","gists_url":"https://api.github.com/users/tymofij/gists{/gist_id}","starred_url":"https://api.github.com/users/tymofij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymofij/subscriptions","organizations_url":"https://api.github.com/users/tymofij/orgs","repos_url":"https://api.github.com/users/tymofij/repos","events_url":"https://api.github.com/users/tymofij/events{/privacy}","received_events_url":"https://api.github.com/users/tymofij/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":3,"changed_files":1}}