GitHub PullRequestReviewCommentEvent at 2014-09-15 09:55:59
Repository: citra
Actor: neobrain
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/17533569","id":17533569,"diff_hunk":"@@ -7,25 +7,25 @@\n // Make sure we pick up USER_DIR if set in config.h\n #include \"common/common.h\"\n \n-// Directory seperators, do we need this?\n+// Directory separators, do we need this?\n #define DIR_SEP \"/\"\n #define DIR_SEP_CHR '/'\n \n #ifndef MAX_PATH\n-#define MAX_PATH    260\n+#define MAX_PATH 260\n #endif\n \n // The user data dir\n #define ROOT_DIR \".\"\n #ifdef _WIN32\n     #define USERDATA_DIR \"user\"\n-    #define EMU_DATA_DIR \"emu\"\n+    #define EMU_DATA_DIR \"citra\"\n #else\n     #define USERDATA_DIR \"user\"\n     #ifdef USER_DIR\n         #define EMU_DATA_DIR USER_DIR\n     #else\n-        #define EMU_DATA_DIR \".emu\"\n+        #define EMU_DATA_DIR \".citra\"","path":"src/common/common_paths.h","position":26,"original_position":26,"commit_id":"eb0478fedeaed7eae41a32e086b279377405cc44","original_commit_id":"87fa4fb092a547ef1db5188f67a77637cbaa8196","user":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=2","gravatar_id":"0e2ad4f720c57b96ab4bc6a24c2b59fd","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"body":"That's what you ask now. And then an Android file browser and a KDE file manager with the same name come around... (cf. Dolphin)","created_at":"2014-09-15T09:55:59Z","updated_at":"2014-09-15T09:55:59Z","html_url":"https://github.com/citra-emu/citra/pull/108#discussion_r17533569","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/17533569"},"html":{"href":"https://github.com/citra-emu/citra/pull/108#discussion_r17533569"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/108","id":21190758,"html_url":"https://github.com/citra-emu/citra/pull/108","diff_url":"https://github.com/citra-emu/citra/pull/108.diff","patch_url":"https://github.com/citra-emu/citra/pull/108.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/108","number":108,"state":"open","locked":false,"title":"Configuration files","user":{"login":"archshift","id":5377832,"avatar_url":"https://avatars.githubusercontent.com/u/5377832?v=2","gravatar_id":"82c98623a890b20497487f8f2b8b86ab","url":"https://api.github.com/users/archshift","html_url":"https://github.com/archshift","followers_url":"https://api.github.com/users/archshift/followers","following_url":"https://api.github.com/users/archshift/following{/other_user}","gists_url":"https://api.github.com/users/archshift/gists{/gist_id}","starred_url":"https://api.github.com/users/archshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archshift/subscriptions","organizations_url":"https://api.github.com/users/archshift/orgs","repos_url":"https://api.github.com/users/archshift/repos","events_url":"https://api.github.com/users/archshift/events{/privacy}","received_events_url":"https://api.github.com/users/archshift/received_events","type":"User","site_admin":false},"body":"Do not merge - this is a preliminary PR for discussion.\r\n\r\nAs of now, incorporates Dolphin's INI code for a configuration system. So far, handles for input controls have been added, but they haven't been hooked yet into the parts of code that use them. ","created_at":"2014-09-13T08:14:46Z","updated_at":"2014-09-15T09:55:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7d553a74a9041c301e2c77e14f136abb8d48de7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/108/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/108/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/108/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/eb0478fedeaed7eae41a32e086b279377405cc44","head":{"label":"archshift:config","ref":"config","sha":"eb0478fedeaed7eae41a32e086b279377405cc44","user":{"login":"archshift","id":5377832,"avatar_url":"https://avatars.githubusercontent.com/u/5377832?v=2","gravatar_id":"82c98623a890b20497487f8f2b8b86ab","url":"https://api.github.com/users/archshift","html_url":"https://github.com/archshift","followers_url":"https://api.github.com/users/archshift/followers","following_url":"https://api.github.com/users/archshift/following{/other_user}","gists_url":"https://api.github.com/users/archshift/gists{/gist_id}","starred_url":"https://api.github.com/users/archshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archshift/subscriptions","organizations_url":"https://api.github.com/users/archshift/orgs","repos_url":"https://api.github.com/users/archshift/repos","events_url":"https://api.github.com/users/archshift/events{/privacy}","received_events_url":"https://api.github.com/users/archshift/received_events","type":"User","site_admin":false},"repo":{"id":19927346,"name":"citra","full_name":"archshift/citra","owner":{"login":"archshift","id":5377832,"avatar_url":"https://avatars.githubusercontent.com/u/5377832?v=2","gravatar_id":"82c98623a890b20497487f8f2b8b86ab","url":"https://api.github.com/users/archshift","html_url":"https://github.com/archshift","followers_url":"https://api.github.com/users/archshift/followers","following_url":"https://api.github.com/users/archshift/following{/other_user}","gists_url":"https://api.github.com/users/archshift/gists{/gist_id}","starred_url":"https://api.github.com/users/archshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archshift/subscriptions","organizations_url":"https://api.github.com/users/archshift/orgs","repos_url":"https://api.github.com/users/archshift/repos","events_url":"https://api.github.com/users/archshift/events{/privacy}","received_events_url":"https://api.github.com/users/archshift/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/archshift/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/archshift/citra","forks_url":"https://api.github.com/repos/archshift/citra/forks","keys_url":"https://api.github.com/repos/archshift/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/archshift/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/archshift/citra/teams","hooks_url":"https://api.github.com/repos/archshift/citra/hooks","issue_events_url":"https://api.github.com/repos/archshift/citra/issues/events{/number}","events_url":"https://api.github.com/repos/archshift/citra/events","assignees_url":"https://api.github.com/repos/archshift/citra/assignees{/user}","branches_url":"https://api.github.com/repos/archshift/citra/branches{/branch}","tags_url":"https://api.github.com/repos/archshift/citra/tags","blobs_url":"https://api.github.com/repos/archshift/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/archshift/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/archshift/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/archshift/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/archshift/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/archshift/citra/languages","stargazers_url":"https://api.github.com/repos/archshift/citra/stargazers","contributors_url":"https://api.github.com/repos/archshift/citra/contributors","subscribers_url":"https://api.github.com/repos/archshift/citra/subscribers","subscription_url":"https://api.github.com/repos/archshift/citra/subscription","commits_url":"https://api.github.com/repos/archshift/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/archshift/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/archshift/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/archshift/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/archshift/citra/contents/{+path}","compare_url":"https://api.github.com/repos/archshift/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/archshift/citra/merges","archive_url":"https://api.github.com/repos/archshift/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/archshift/citra/downloads","issues_url":"https://api.github.com/repos/archshift/citra/issues{/number}","pulls_url":"https://api.github.com/repos/archshift/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/archshift/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/archshift/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/archshift/citra/labels{/name}","releases_url":"https://api.github.com/repos/archshift/citra/releases{/id}","created_at":"2014-05-19T02:50:51Z","updated_at":"2014-08-22T22:45:21Z","pushed_at":"2014-09-15T00:50:26Z","git_url":"git://github.com/archshift/citra.git","ssh_url":"git@github.com:archshift/citra.git","clone_url":"https://github.com/archshift/citra.git","svn_url":"https://github.com/archshift/citra","homepage":null,"size":5123,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"5481115e71b1e8a35bce002926be3db6b91955a5","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":null,"url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":null,"url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2014-09-15T09:16:25Z","pushed_at":"2014-09-15T04:47:13Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":8380,"stargazers_count":196,"watchers_count":196,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":13,"forks":58,"open_issues":13,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/108"},"html":{"href":"https://github.com/citra-emu/citra/pull/108"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/108"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/eb0478fedeaed7eae41a32e086b279377405cc44"}}}}