GitHub PushEvent at 2014-02-01 02:21:24
Repository: team-accounts
Actor: adamdawkins
Payload: {"shas":[["b526791cd6d84e816475fb98ef0c33f3a5f68324","a98f2fb2688d07accc3dc2e77d0cad8d060e949e@gmail.com","Correct missing space after # in comments [rubocop auto-correct]\n\nOffences:\n\napp/models/explaination.rb:15:23: C: [Corrected] Missing space after #.\n    if transaction_id #this should never be nil in reality, but keeps\ntest simpler\n                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nspec/controllers/application_controller_spec.rb:24:9: C: [Corrected]\nMissing space after #.\n        #stub the login\n        ^^^^^^^^^^^^^^^","Adam Dawkins",true],["c2abfce74775a46d7f35633fcb109d657945ad82","a98f2fb2688d07accc3dc2e77d0cad8d060e949e@gmail.com","Use def with parentheses when there are parameters [rubocop]\n\nOffences:\n\napp/controllers/application_controller.rb:13:12: C: [Corrected] Use def\nwith parentheses when there are parameters.\n def login user_id\n           ^^^^^^^\napp/models/transaction.rb:57:19: C: [Corrected] Use def with parentheses\nwhen there are parameters.\n  def self.import file\n                  ^^^^\napp/models/transaction.rb:76:26: C: [Corrected] Use def with parentheses\nwhen there are parameters.\n  def date_from_hsbc_csv date_string\n                         ^^^^^^^^^^^\napp/models/transaction_import.rb:40:43: C: [Corrected] Use def with\nparentheses when there are parameters.\n  def self.build_transaction_from_csv_row row\n                                          ^^^\napp/models/transaction_import.rb:48:39: C: [Corrected] Use def with\nparentheses when there are parameters.\n  def self.build_balance_from_csv_row row\n                                      ^^^","Adam Dawkins",true],["e3646751e8924961232817bbc929b7befc7c6094","a98f2fb2688d07accc3dc2e77d0cad8d060e949e@gmail.com","Correct space around block braces [rubocop auto-correct]\n\nOffences:\n\nspec/controllers/application_controller_spec.rb:57:14: C: [Corrected]\nSpace missing to the left of {.\n         proc{ controller.login(1) }.should raise_error \"user already\nlogged in\"\n             ^\nspec/models/balance_spec.rb:9:20: C: [Corrected] Space missing inside {.\n    let(:balance) {FactoryGirl.build(:balance)}\n                   ^\nspec/models/balance_spec.rb:9:47: C: [Corrected] Space missing inside }.\n\n▽\n  1\n    let(:balance) {FactoryGirl.build(:balance)}\n                                              ^\nspec/models/transaction_import_spec.rb:4:20: C: [Corrected] Space\nmissing inside {.\n  let(:test_file)\n{Rack::Test::UploadedFile.new(File.open(File.join(Rails.root,\n'/spec/fixtures/transactions_upload.csv')))}\n                   ^\nspec/models/transaction_import_spec.rb:4:124: C: [Corrected] Space\nmissing inside }.\n  let(:test_file)\n{Rack::Test::UploadedFile.new(File.open(File.join(Rails.root,\n'/spec/fixtures/transactions_upload.csv')))}\n                                                                                                                           ^\nspec/models/transaction_import_spec.rb:87:17: C: [Corrected] Space\nmissing inside {.\n        expect {@transaction_import.save}.to change(Transaction,\n:count).by 4\n                ^\nspec/models/transaction_import_spec.rb:87:41: C: [Corrected] Space\nmissing inside }.\n        expect {@transaction_import.save}.to change(Transaction,\n:count).by 4\n                                        ^\nspec/models/transaction_import_spec.rb:95:17: C: [Corrected] Space\nmissing inside {.\n        expect {@transaction_import.save}.to change(Balance, :count).by\n3\n                ^\nspec/models/transaction_import_spec.rb:95:41: C: [Corrected] Space\nmissing inside }.\n        expect {@transaction_import.save}.to change(Balance, :count).by\n3\n                                        ^\nspec/models/transaction_spec.rb:9:24: C: [Corrected] Space missing\ninside {.\n    let(:transaction) {FactoryGirl.build(:transaction)}\n                       ^\nspec/models/transaction_spec.rb:9:55: C: [Corrected] Space missing\ninside }.\n    let(:transaction) {FactoryGirl.build(:transaction)}\n                                                      ^\nspec/models/user_spec.rb:8:15: C: [Corrected] Space missing inside {.\n  let(:user) {FactoryGirl.build(:user)}\n              ^\nspec/models/user_spec.rb:8:39: C: [Corrected] Space missing inside }.\n  let(:user) {FactoryGirl.build(:user)}","Adam Dawkins",true],["9794189cd2e493aa68a5bbdf255b9eb26c38cfba","a98f2fb2688d07accc3dc2e77d0cad8d060e949e@gmail.com","Correct space inside hash literals [rubocop -a]\n\nOffences:\n\napp/models/transaction.rb:6:52: C: [Corrected] Space inside { missing.\n  validates :amount, presence: true, numericality: {greater_than: 0.00}\n                                                   ^\napp/models/transaction.rb:6:71: C: [Corrected] Space inside } missing.\n  validates :amount, presence: true, numericality: {greater_than: 0.00}\n                                                                      ^\nspec/views/explainations/_form.html.haml_spec.rb:7:61: C: [Corrected]\nSpace inside { missing.\n    render partial: \"explainations/form.html.haml\", locals:\n{explaination: Explaination.new, transaction: transaction}\n                                                            ^\nspec/views/explainations/_form.html.haml_spec.rb:7:118: C: [Corrected]\nSpace inside } missing.\n    render partial: \"explainations/form.html.haml\", locals:\n{explaination: Explaination.new, transaction: transaction}","Adam Dawkins",true],["7cd14e4b41ad1f1bdec7ee68def451b05908f4bc","a98f2fb2688d07accc3dc2e77d0cad8d060e949e@gmail.com","Correct use of `raise` to `fail` [rubocop]","Adam Dawkins",true],["2b0bb1825c639a4d40dd146d7a3134889c29cf2a","a98f2fb2688d07accc3dc2e77d0cad8d060e949e@gmail.com","Correct various whitespace style errors [rubocop -a]\n\nOffences:\n\napp/controllers/users_controller.rb:21:1: C: [Corrected] Trailing\nwhitespace detected.\napp/models/explaination.rb:20:1: C: [Corrected] Trailing whitespace\ndetected.\napp/models/explaination.rb:20:1: C: [Corrected] Extra empty line\ndetected at body end.\napp/models/transaction.rb:26:9: C: [Corrected] Trailing whitespace\ndetected.\n    else\n        ^\napp/models/transaction.rb:45:18: C: [Corrected] Trailing whitespace\ndetected.\n      description\n                 ^\napp/models/transaction.rb:61:39: C: [Corrected] Trailing whitespace\ndetected.\n      @transaction.date = hash['Date']\n                                      ^^^\napp/models/transaction.rb:62:53: C: [Corrected] Trailing whitespace\ndetected.\n      @transaction.description = hash['Description']\n                                                    ^^^\napp/models/transaction.rb:75:1: C: [Corrected] Trailing whitespace\ndetected.\napp/models/transaction.rb:77:15: C: [Corrected] Trailing whitespace\ndetected.\n    months = {\n              ^\napp/models/transaction.rb:79:80: C: [Corrected] Trailing whitespace\ndetected.\n      'Jul' => 7, 'Aug' => 8, 'Sep' => 9, 'Oct' => 10, 'Nov' => 11,\n'Dec' => 12\n                                                                               ^\napp/models/transaction.rb:83:26: C: [Corrected] Trailing whitespace\ndetected.\n    month = months[month]\n                         ^\napp/models/transaction.rb:85:6: C: [Corrected] Trailing whitespace\ndetected.\n  end\n     ^^\napp/models/transaction_import.rb:13:8: C: [Corrected] Trailing\nwhitespace detected.\n    end\n       ^\napp/models/transaction_import.rb:21:73: C: [Corrected] Trailing\nwhitespace detected.\n      transaction = TransactionImport.build_transaction_from_csv_row row\n                                                                        ^\napp/models/transaction_import.rb:43:80: C: [Corrected] Trailing\nwhitespace detected.\n    transaction.amount = transaction.is_credit ? row[:paid_in] :\nrow[:paid_out]\n                                                                               ^\napp/models/transaction_import.rb:53:1: C: [Corrected] Trailing\nwhitespace detected.\nfeatures/support/env.rb:15:76: C: [Corrected] Trailing whitespace\ndetected.\n                                                                           ^\nfeatures/support/env.rb:16:83: C: [Corrected] Trailing whitespace\ndetected.\n                                                                                  ^\nfeatures/support/env.rb:58:1: C: [Corrected] 1 trailing blank lines\ndetected.\nspec/controllers/application_controller_spec.rb:13:1: C: [Corrected]\nTrailing whitespace detected.\nspec/controllers/application_controller_spec.rb:47:42: C: [Corrected]\nTrailing whitespace detected.\n        expect(session[:user_id]).to eq 1\n                                         ^\nspec/controllers/application_controller_spec.rb:49:8: C: [Corrected]\nTrailing whitespace detected.\n    end\n       ^\nspec/controllers/application_controller_spec.rb:55:1: C: [Corrected]\nTrailing whitespace detected.\nspec/controllers/explainations_controller_spec.rb:6:22: C: [Corrected]\nTrailing whitespace detected.\n      before :each do\n                     ^\nspec/controllers/explainations_controller_spec.rb:21:10: C: [Corrected]\nTrailing whitespace detected.\n      end\n         ^\nspec/controllers/explainations_controller_spec.rb:23:49: C: [Corrected]\nTrailing whitespace detected.\n      it \"assigns the @explaination variable\" do\n                                                ^\nspec/controllers/explainations_controller_spec.rb:36:41: C: [Corrected]\nTrailing whitespace detected.\n    context \"with invalid attributes\" do\n                                        ^\nspec/controllers/explainations_controller_spec.rb:40:46: C: [Corrected]\nTrailing whitespace detected.\n      it \"does not create an explaination\" do\n                                             ^\nspec/controllers/sessions_controller_spec.rb:14:1: C: [Corrected]\nTrailing whitespace detected.\nspec/controllers/sessions_controller_spec.rb:26:1: C: [Corrected]\nTrailing whitespace detected.\nspec/controllers/sessions_controller_spec.rb:29:10: C: [Corrected]\nTrailing whitespace detected.\n      end\n         ^\nspec/controllers/sessions_controller_spec.rb:41:22: C: [Corrected]\nTrailing whitespace detected.\n      before :each do\n                     ^\nspec/controllers/sessions_controller_spec.rb:45:38: C: [Corrected]\nTrailing whitespace detected.\n             password: @user.password\n                                     ^\nspec/controllers/sessions_controller_spec.rb:109:28: C: [Corrected]\nTrailing whitespace detected.\n      session[:user_id] = 1\n                           ^^^^^^\nspec/controllers/sessions_controller_spec.rb:112:1: C: [Corrected]\nTrailing whitespace detected.\nspec/controllers/sessions_controller_spec.rb:121:33: C: [Corrected]\nTrailing whitespace detected.\n    it \"sets a flash message\" do\n                                ^\nspec/controllers/transactions_controller_spec.rb:5:21: C: [Corrected]\nTrailing whitespace detected.\n  describe \"#new\" do\n                    ^\nspec/controllers/transactions_controller_spec.rb:11:37: C: [Corrected]\nTrailing whitespace detected.\n    it \"renders the new template\" do\n                                    ^\nspec/controllers/transactions_controller_spec.rb:22:22: C: [Corrected]\nTrailing whitespace detected.\n      before :each do\n                     ^\nspec/controllers/transactions_controller_spec.rb:51:41: C: [Corrected]\nTrailing whitespace detected.\n    context \"with invalid attributes\" do\n                                        ^\nspec/controllers/transactions_controller_spec.rb:55:44: C: [Corrected]\nTrailing whitespace detected.\n      it \"does not create a transaction\" do\n                                           ^\nspec/controllers/transactions_controller_spec.rb:80:43: C: [Corrected]\nTrailing whitespace detected.\n    it \"sets the @transaction variable\" do\n                                          ^\nspec/controllers/transactions_controller_spec.rb:90:20: C: [Corrected]\nTrailing whitespace detected.\n    before :each do\n                   ^\nspec/controllers/transactions_controller_spec.rb:92:17: C: [Corrected]\nTrailing whitespace detected.\n      2.times do\n                ^\nspec/controllers/transactions_controller_spec.rb:94:10: C: [Corrected]\nTrailing whitespace detected.\n      end\n         ^\nspec/controllers/transactions_controller_spec.rb:109:20: C: [Corrected]\nTrailing whitespace detected.\n    before :each do\n                   ^\nspec/controllers/transactions_controller_spec.rb:115:132: C: [Corrected]\nTrailing whitespace detected.\n      post 'import', file:\nRack::Test::UploadedFile.new(File.open(File.join(Rails.root,\n'/spec/fixtures/transactions_upload.csv')))\n                                                                                                                                   ^^\nspec/controllers/users_controller_spec.rb:17:8: C: [Corrected] Trailing\nwhitespace detected.\n    end\n       ^\nspec/controllers/users_controller_spec.rb:20:48: C: [Corrected] Trailing\nwhitespace detected.\n      expect(response).to render_template \"new\"\n                                               ^\nspec/controllers/users_controller_spec.rb:24:29: C: [Corrected] Trailing\nwhitespace detected.\n  describe \"POST #create\" do\n                            ^\nspec/controllers/users_controller_spec.rb:27:22: C: [Corrected] Trailing\nwhitespace detected.\n      before :each do\n                     ^\nspec/controllers/users_controller_spec.rb:31:33: C: [Corrected] Trailing\nwhitespace detected.\n      it \"creates a new user\" do\n                                ^\nspec/controllers/users_controller_spec.rb:48:41: C: [Corrected] Trailing\nwhitespace detected.\n    context \"with invalid attributes\" do\n                                        ^\nspec/controllers/users_controller_spec.rb:49:22: C: [Corrected] Trailing\nwhitespace detected.\n      before :each do\n                     ^\nspec/controllers/users_controller_spec.rb:53:37: C: [Corrected] Trailing\nwhitespace detected.\n      it \"does not create a user\" do\n                                    ^\nspec/helpers/application_helper_spec.rb:14:1: C: [Corrected] Trailing\nwhitespace detected.\nspec/models/balance_spec.rb:16:6: C: [Corrected] Trailing whitespace\ndetected.\n  end\n     ^\nspec/models/category_spec.rb:7:1: C: [Corrected] Trailing whitespace\ndetected.\nspec/models/explaination_spec.rb:20:1: C: [Corrected] Trailing\nwhitespace detected.\nspec/models/explaination_spec.rb:32:1: C: [Corrected] Trailing\nwhitespace detected.\nspec/models/explaination_spec.rb:33:80: C: [Corrected] Trailing\nwhitespace detected.\n    it \"is invalid if amount is greater than transaction unexplained\namount\" do\n                                                                               ^\nspec/models/explaination_spec.rb:39:22: C: [Corrected] Trailing\nwhitespace detected.\n      ).to be_invalid\n                     ^\nspec/models/transaction_import_spec.rb:19:22: C: [Corrected] Trailing\nwhitespace detected.\n      before :each do\n                     ^\nspec/models/transaction_import_spec.rb:49:22: C: [Corrected] Trailing\nwhitespace detected.\n      before :each do\n                     ^\nspec/models/transaction_import_spec.rb:54:24: C: [Corrected] Trailing\nwhitespace detected.\n        before :each do\n                       ^\nspec/models/transaction_import_spec.rb:60:12: C: [Corrected] Trailing\nwhitespace detected.\n        end\n           ^\nspec/models/transaction_import_spec.rb:91:16: C: [Corrected] Space\ninside parentheses detected.\n        expect( @transaction_import.save ).to eq true\n               ^\nspec/models/transaction_import_spec.rb:91:41: C: [Corrected] Space\ninside parentheses detected.\n        expect( @transaction_import.save ).to eq true\n                                        ^\nspec/models/transaction_spec.rb:18:1: C: [Corrected] Trailing whitespace\ndetected.\nspec/models/transaction_spec.rb:19:30: C: [Corrected] Trailing\nwhitespace detected.\n   describe \"associations\" do\n                             ^\nspec/models/transaction_spec.rb:47:21: C: [Corrected] Trailing\nwhitespace detected.\n      before :all do\n                    ^\nspec/models/transaction_spec.rb:71:30: C: [Corrected] Trailing\nwhitespace detected.\n      it \"returns a float\" do\n                             ^\nspec/models/transaction_spec.rb:74:58: C: [Corrected] Trailing\nwhitespace detected.\n      it \"returns the sum of the explaination amounts\" do\n                                                         ^\nspec/models/transaction_spec.rb:79:1: C: [Corrected] Trailing whitespace\ndetected.\nspec/models/transaction_spec.rb:82:36: C: [Corrected] Trailing\nwhitespace detected.\n  describe \"#unexplained_amount\" do\n                                   ^\nspec/models/transaction_spec.rb:94:10: C: [Corrected] Trailing\nwhitespace detected.\n      end\n         ^\nspec/models/transaction_spec.rb:122:23: C: [Corrected] Trailing\nwhitespace detected.\n  describe \"#value\" do\n                      ^\nspec/models/transaction_spec.rb:127:28: C: [Corrected] Trailing\nwhitespace detected.\n    it \"returns a float\" do\n                           ^\nspec/models/transaction_spec.rb:136:39: C: [Corrected] Trailing\nwhitespace detected.\n      it \"returns a positive value\" do\n                                      ^\nspec/models/transaction_spec.rb:151:39: C: [Corrected] Trailing\nwhitespace detected.\n      it \"returns a negative value\" do\n                                      ^\nspec/models/transaction_spec.rb:162:31: C: [Corrected] Trailing\nwhitespace detected.\n  describe \"#display_value\" do\n                              ^\nspec/models/transaction_spec.rb:166:1: C: [Corrected] Trailing\nwhitespace detected.\nspec/models/transaction_spec.rb:167:46: C: [Corrected] Trailing\nwhitespace detected.\n    it \"returns the formatted to currency\" do\n                                             ^\nspec/models/transaction_spec.rb:171:40: C: [Corrected] Trailing\nwhitespace detected.\n    it \"returns the currency in GBP\" do\n                                       ^\nspec/models/transaction_spec.rb:189:23: C: [Corrected] Trailing\nwhitespace detected.\n  describe \"#label\" do\n                      ^\nspec/models/transaction_spec.rb:193:64: C: [Corrected] Trailing\nwhitespace detected.\n        expect(transaction.label).to eq transaction.description\n                                                               ^\nspec/models/transaction_spec.rb:197:40: C: [Corrected] Trailing\nwhitespace detected.\n    context \"multiple explainations\" do\n                                       ^\nspec/models/transaction_spec.rb:208:34: C: [Corrected] Trailing\nwhitespace detected.\n    context \"one explaination\" do\n                                 ^\nspec/models/transaction_spec.rb:209:51: C: [Corrected] Trailing\nwhitespace detected.\n      it \"returns the explaination description\" do\n                                                  ^\nspec/models/transaction_spec.rb:222:132: C: [Corrected] Trailing\nwhitespace detected.\n        Transaction.import\nRack::Test::UploadedFile.new(File.open(File.join(Rails.root,\n'/spec/fixtures/transactions_upload.csv')))\n                                                                                                                                   ^^\nspec/models/user_spec.rb:11:21: C: [Corrected] Trailing whitespace\ndetected.\n    before(:each) do\n                    ^\nspec/models/user_spec.rb:25:6: C: [Corrected] Trailing whitespace\ndetected.\n  end\n     ^^\nspec/requests/home_spec.rb:21:55: C: [Corrected] Space missing after\ncolon.\n        expect(page).to have_selector 'h1#title', text:'Team Budget'\n                                                      ^\nspec/requests/home_spec.rb:26:32: C: [Corrected] Trailing whitespace\ndetected.\n    context \"user logged in\" do\n                               ^\nspec/requests/home_spec.rb:27:22: C: [Corrected] Trailing whitespace\ndetected.\n      before :each do\n                     ^\nspec/requests/login_spec.rb:7:36: C: [Corrected] Trailing whitespace\ndetected.\n    context \"user not logged in\" do\n                                   ^\nspec/requests/login_spec.rb:23:1: C: [Corrected] Trailing whitespace\ndetected.\nspec/requests/login_spec.rb:38:21: C: [Corrected] Trailing whitespace\ndetected.\n      before :all do\n                    ^\nspec/requests/transaction_csv_uploads_spec.rb:22:8: C: [Corrected]\nTrailing whitespace detected.\n    end\n       ^\nspec/requests/transactions_spec.rb:8:22: C: [Corrected] Trailing\nwhitespace detected.\n      before :each do\n                     ^\nspec/requests/transactions_spec.rb:80:1: C: [Corrected] Trailing\nwhitespace detected.\nspec/requests/transactions_spec.rb:82:35: C: [Corrected] Trailing\nwhitespace detected.\n    context \"valid transaction\" do\n                                  ^\nspec/requests/transactions_spec.rb:118:22: C: [Corrected] Trailing\nwhitespace detected.\n      before :each do\n                     ^\nspec/requests/user_spec.rb:40:23: C: [Corrected] Trailing whitespace\ndetected.\n      before(:each) do\n                      ^\nspec/requests/user_spec.rb:57:23: C: [Corrected] Trailing whitespace\ndetected.\n      before(:each) do\n                      ^\nspec/views/explainations/_form.html.haml_spec.rb:17:59: C: [Corrected]\nTrailing whitespace detected.\n  it \"has a hidden input with the transaction id in it\" do\n                                                          ^\nspec/views/explainations/_form.html.haml_spec.rb:21:48: C: [Corrected]\nTrailing whitespace detected.\n  it \"displays an 'Add explaination' button\" do\n                                               ^\nspec/views/explainations/_form.html.haml_spec.rb:25:39: C: [Corrected]\nTrailing whitespace detected.\n  it \"displays a category dropdown\" do\n                                      ^\nspec/views/transactions/new.html.haml_spec.rb:20:1: C: [Corrected]\nTrailing whitespace detected.\nspec/views/transactions/show.html.haml_spec.rb:11:49: C: [Corrected]\nTrailing whitespace detected.\n    it \"displays the transaction description\" do\n                                                ^\nspec/views/transactions/show.html.haml_spec.rb:44:46: C: [Corrected]\nTrailing whitespace detected.\n    it \"displays an explainations heading\" do\n                                             ^\nspec/views/transactions/show.html.haml_spec.rb:53:51: C: [Corrected]\nTrailing whitespace detected.\n  context \"transaction with unexplained amount\" do\n                                                  ^\nspec/views/transactions/show.html.haml_spec.rb:56:53: C: [Corrected]\nTrailing whitespace detected.\n      @transaction = FactoryGirl.create :transaction\n                                                    ^\nspec/views/transactions/show.html.haml_spec.rb:57:42: C: [Corrected]\nTrailing whitespace detected.\n      visit transaction_path @transaction\n                                         ^\nspec/views/transactions/show.html.haml_spec.rb:59:1: C: [Corrected]\nTrailing whitespace detected.\nspec/views/transactions/show.html.haml_spec.rb:62:8: C: [Corrected]\nTrailing whitespace detected.\n    end\n       ^\nspec/views/transactions/show.html.haml_spec.rb:69:54: C: [Corrected]\nTrailing whitespace detected.\n  context \"transaction with no unexplained amount\" do\n                                                     ^\nspec/views/transactions/show.html.haml_spec.rb:74:42: C: [Corrected]\nTrailing whitespace detected.\n      visit transaction_path @transaction\n                                         ^","Adam Dawkins",true]],"size":6,"ref":"refs/heads/develop","head":"2b0bb1825c639a4d40dd146d7a3134889c29cf2a"}