GitHub PullRequestReviewCommentEvent at 2014-06-18 20:12:51
Repository: spark
Actor: umop
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/spark/pulls/comments/13937398","id":13937398,"diff_hunk":"@@ -119,15 +119,15 @@ class Outline {\n     }\n   }\n \n-  OutlineTopLevelItem _create(services.OutlineTopLevelEntry data) {","path":"ide/app/lib/outline.dart","position":4,"original_position":4,"commit_id":"f96dfd2fee32171a17ed16d3cadc2ad4df54027a","original_commit_id":"f96dfd2fee32171a17ed16d3cadc2ad4df54027a","user":{"login":"umop","id":357955,"avatar_url":"https://avatars.githubusercontent.com/u/357955?","gravatar_id":"760a960a97dc4d2ba2cf242b740004cf","url":"https://api.github.com/users/umop","html_url":"https://github.com/umop","followers_url":"https://api.github.com/users/umop/followers","following_url":"https://api.github.com/users/umop/following{/other_user}","gists_url":"https://api.github.com/users/umop/gists{/gist_id}","starred_url":"https://api.github.com/users/umop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umop/subscriptions","organizations_url":"https://api.github.com/users/umop/orgs","repos_url":"https://api.github.com/users/umop/repos","events_url":"https://api.github.com/users/umop/events{/privacy}","received_events_url":"https://api.github.com/users/umop/received_events","type":"User","site_admin":false},"body":"This is also the philosophy I was using when [bubbling events up the outline hierarchy](https://github.com/dart-lang/spark/pull/2618/files#diff-0f5bbdbf2ede4ecced63ee7338de4a15L356).","created_at":"2014-06-18T20:12:51Z","updated_at":"2014-06-18T20:12:51Z","html_url":"https://github.com/dart-lang/spark/pull/2618#discussion_r13937398","pull_request_url":"https://api.github.com/repos/dart-lang/spark/pulls/2618","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/comments/13937398"},"html":{"href":"https://github.com/dart-lang/spark/pull/2618#discussion_r13937398"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/2618"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/spark/pulls/2618","id":17278692,"html_url":"https://github.com/dart-lang/spark/pull/2618","diff_url":"https://github.com/dart-lang/spark/pull/2618.diff","patch_url":"https://github.com/dart-lang/spark/pull/2618.patch","issue_url":"https://api.github.com/repos/dart-lang/spark/issues/2618","number":2618,"state":"open","title":"Fix class members appearing as top-level elements in outline","user":{"login":"ussuri","id":5606182,"avatar_url":"https://avatars.githubusercontent.com/u/5606182?","gravatar_id":"1516d304ef0f0f973d6ee56d3377a0ce","url":"https://api.github.com/users/ussuri","html_url":"https://github.com/ussuri","followers_url":"https://api.github.com/users/ussuri/followers","following_url":"https://api.github.com/users/ussuri/following{/other_user}","gists_url":"https://api.github.com/users/ussuri/gists{/gist_id}","starred_url":"https://api.github.com/users/ussuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ussuri/subscriptions","organizations_url":"https://api.github.com/users/ussuri/orgs","repos_url":"https://api.github.com/users/ussuri/repos","events_url":"https://api.github.com/users/ussuri/events{/privacy}","received_events_url":"https://api.github.com/users/ussuri/received_events","type":"User","site_admin":false},"body":"@umop\r\n\r\nFixes #2614\r\n\r\nAlso cleans up outline CSS.\r\n\r\n![screen shot 2014-06-18 at 12 26 08 am](https://cloud.githubusercontent.com/assets/5606182/3310722/e062e1d6-f6b9-11e3-9ff5-d33aaa1d5b0b.png)\r\n","created_at":"2014-06-18T07:26:38Z","updated_at":"2014-06-18T20:12:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df03fd844ec0baeac55ad24adf1309d35cfe2786","assignee":null,"milestone":{"url":"https://api.github.com/repos/dart-lang/spark/milestones/4","labels_url":"https://api.github.com/repos/dart-lang/spark/milestones/4/labels","id":474456,"number":4,"title":"MVP1.0: Chrome App dev (Dev preview)","description":"External developer preview for Chrome App dev in JS","creator":{"login":"srsaroop","id":2283581,"avatar_url":"https://avatars.githubusercontent.com/u/2283581?","gravatar_id":"ff82ff79810c3c74a65620f1800fe8a6","url":"https://api.github.com/users/srsaroop","html_url":"https://github.com/srsaroop","followers_url":"https://api.github.com/users/srsaroop/followers","following_url":"https://api.github.com/users/srsaroop/following{/other_user}","gists_url":"https://api.github.com/users/srsaroop/gists{/gist_id}","starred_url":"https://api.github.com/users/srsaroop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srsaroop/subscriptions","organizations_url":"https://api.github.com/users/srsaroop/orgs","repos_url":"https://api.github.com/users/srsaroop/repos","events_url":"https://api.github.com/users/srsaroop/events{/privacy}","received_events_url":"https://api.github.com/users/srsaroop/received_events","type":"User","site_admin":false},"open_issues":307,"closed_issues":135,"state":"open","created_at":"2013-11-04T22:56:47Z","updated_at":"2014-06-18T18:46:43Z","due_on":"2014-07-31T07:00:00Z"},"commits_url":"https://api.github.com/repos/dart-lang/spark/pulls/2618/commits","review_comments_url":"https://api.github.com/repos/dart-lang/spark/pulls/2618/comments","review_comment_url":"https://api.github.com/repos/dart-lang/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dart-lang/spark/issues/2618/comments","statuses_url":"https://api.github.com/repos/dart-lang/spark/statuses/f96dfd2fee32171a17ed16d3cadc2ad4df54027a","head":{"label":"ussuri:resizable-outline-and-better-button","ref":"resizable-outline-and-better-button","sha":"f96dfd2fee32171a17ed16d3cadc2ad4df54027a","user":{"login":"ussuri","id":5606182,"avatar_url":"https://avatars.githubusercontent.com/u/5606182?","gravatar_id":"1516d304ef0f0f973d6ee56d3377a0ce","url":"https://api.github.com/users/ussuri","html_url":"https://github.com/ussuri","followers_url":"https://api.github.com/users/ussuri/followers","following_url":"https://api.github.com/users/ussuri/following{/other_user}","gists_url":"https://api.github.com/users/ussuri/gists{/gist_id}","starred_url":"https://api.github.com/users/ussuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ussuri/subscriptions","organizations_url":"https://api.github.com/users/ussuri/orgs","repos_url":"https://api.github.com/users/ussuri/repos","events_url":"https://api.github.com/users/ussuri/events{/privacy}","received_events_url":"https://api.github.com/users/ussuri/received_events","type":"User","site_admin":false},"repo":{"id":13309196,"name":"spark","full_name":"ussuri/spark","owner":{"login":"ussuri","id":5606182,"avatar_url":"https://avatars.githubusercontent.com/u/5606182?","gravatar_id":"1516d304ef0f0f973d6ee56d3377a0ce","url":"https://api.github.com/users/ussuri","html_url":"https://github.com/ussuri","followers_url":"https://api.github.com/users/ussuri/followers","following_url":"https://api.github.com/users/ussuri/following{/other_user}","gists_url":"https://api.github.com/users/ussuri/gists{/gist_id}","starred_url":"https://api.github.com/users/ussuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ussuri/subscriptions","organizations_url":"https://api.github.com/users/ussuri/orgs","repos_url":"https://api.github.com/users/ussuri/repos","events_url":"https://api.github.com/users/ussuri/events{/privacy}","received_events_url":"https://api.github.com/users/ussuri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ussuri/spark","description":"A Chrome app based development environment","fork":true,"url":"https://api.github.com/repos/ussuri/spark","forks_url":"https://api.github.com/repos/ussuri/spark/forks","keys_url":"https://api.github.com/repos/ussuri/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ussuri/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ussuri/spark/teams","hooks_url":"https://api.github.com/repos/ussuri/spark/hooks","issue_events_url":"https://api.github.com/repos/ussuri/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ussuri/spark/events","assignees_url":"https://api.github.com/repos/ussuri/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ussuri/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ussuri/spark/tags","blobs_url":"https://api.github.com/repos/ussuri/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ussuri/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ussuri/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ussuri/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ussuri/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ussuri/spark/languages","stargazers_url":"https://api.github.com/repos/ussuri/spark/stargazers","contributors_url":"https://api.github.com/repos/ussuri/spark/contributors","subscribers_url":"https://api.github.com/repos/ussuri/spark/subscribers","subscription_url":"https://api.github.com/repos/ussuri/spark/subscription","commits_url":"https://api.github.com/repos/ussuri/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ussuri/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ussuri/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ussuri/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/ussuri/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ussuri/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ussuri/spark/merges","archive_url":"https://api.github.com/repos/ussuri/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ussuri/spark/downloads","issues_url":"https://api.github.com/repos/ussuri/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ussuri/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ussuri/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ussuri/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ussuri/spark/labels{/name}","releases_url":"https://api.github.com/repos/ussuri/spark/releases{/id}","created_at":"2013-10-03T20:36:25Z","updated_at":"2014-06-18T07:59:38Z","pushed_at":"2014-06-18T07:59:38Z","git_url":"git://github.com/ussuri/spark.git","ssh_url":"git@github.com:ussuri/spark.git","clone_url":"https://github.com/ussuri/spark.git","svn_url":"https://github.com/ussuri/spark","homepage":"","size":24004,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"e85ae8e247f4ffa5eeefbd0774176b52a38b6374","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?","gravatar_id":"f41fe13f979f2f93cc8b971e1875bdf8","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":12931484,"name":"spark","full_name":"dart-lang/spark","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?","gravatar_id":"f41fe13f979f2f93cc8b971e1875bdf8","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/spark","description":"A Chrome app based development environment","fork":false,"url":"https://api.github.com/repos/dart-lang/spark","forks_url":"https://api.github.com/repos/dart-lang/spark/forks","keys_url":"https://api.github.com/repos/dart-lang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/spark/teams","hooks_url":"https://api.github.com/repos/dart-lang/spark/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/spark/events","assignees_url":"https://api.github.com/repos/dart-lang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/spark/tags","blobs_url":"https://api.github.com/repos/dart-lang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/spark/languages","stargazers_url":"https://api.github.com/repos/dart-lang/spark/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/spark/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/spark/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/spark/subscription","commits_url":"https://api.github.com/repos/dart-lang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/dart-lang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/spark/merges","archive_url":"https://api.github.com/repos/dart-lang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/spark/downloads","issues_url":"https://api.github.com/repos/dart-lang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/spark/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/spark/releases{/id}","created_at":"2013-09-18T18:42:21Z","updated_at":"2014-06-18T18:46:39Z","pushed_at":"2014-06-18T18:46:43Z","git_url":"git://github.com/dart-lang/spark.git","ssh_url":"git@github.com:dart-lang/spark.git","clone_url":"https://github.com/dart-lang/spark.git","svn_url":"https://github.com/dart-lang/spark","homepage":"","size":47277,"stargazers_count":1430,"watchers_count":1430,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":193,"mirror_url":null,"open_issues_count":334,"forks":193,"open_issues":334,"watchers":1430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/2618"},"html":{"href":"https://github.com/dart-lang/spark/pull/2618"},"issue":{"href":"https://api.github.com/repos/dart-lang/spark/issues/2618"},"comments":{"href":"https://api.github.com/repos/dart-lang/spark/issues/2618/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/2618/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/2618/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/spark/statuses/f96dfd2fee32171a17ed16d3cadc2ad4df54027a"}}}}