GitHub PullRequestEvent at 2014-11-25 13:08:16
Repository: NSString-UrlEncode
Actor: kevinrenskers
Payload: {"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls/3","id":24835367,"html_url":"https://github.com/kevinrenskers/NSString-UrlEncode/pull/3","diff_url":"https://github.com/kevinrenskers/NSString-UrlEncode/pull/3.diff","patch_url":"https://github.com/kevinrenskers/NSString-UrlEncode/pull/3.patch","issue_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/issues/3","number":3,"state":"closed","locked":false,"title":"Renamed Url/url to URL","user":{"login":"notjosh","id":33126,"avatar_url":"https://avatars.githubusercontent.com/u/33126?v=3","gravatar_id":"","url":"https://api.github.com/users/notjosh","html_url":"https://github.com/notjosh","followers_url":"https://api.github.com/users/notjosh/followers","following_url":"https://api.github.com/users/notjosh/following{/other_user}","gists_url":"https://api.github.com/users/notjosh/gists{/gist_id}","starred_url":"https://api.github.com/users/notjosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notjosh/subscriptions","organizations_url":"https://api.github.com/users/notjosh/orgs","repos_url":"https://api.github.com/users/notjosh/repos","events_url":"https://api.github.com/users/notjosh/events{/privacy}","received_events_url":"https://api.github.com/users/notjosh/received_events","type":"User","site_admin":false},"body":"As Cocoa uses \"URL\" (all caps) in places like `+[NSBundle URLForResource:...` etc, I've renamed the instances here to use uppercase for consistency.\r\n\r\nI've bumped the podspec to version 2.0.0 as it's a breaking API change also :)\r\n\r\nWhile we're at it, any thoughts on prefixing/namespacing the methods? As `-URLEncode` could be implemented in other frameworks.","created_at":"2014-11-21T12:00:08Z","updated_at":"2014-11-25T13:08:15Z","closed_at":"2014-11-25T13:08:15Z","merged_at":null,"merge_commit_sha":"3ee424c398da6f572ce9d7940dad7325bb5d94ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls/3/commits","review_comments_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls/3/comments","review_comment_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/issues/3/comments","statuses_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/statuses/cd07a752fa4a4a31f4231e689d2c68089d749eb4","head":{"label":"notjosh:master","ref":"master","sha":"cd07a752fa4a4a31f4231e689d2c68089d749eb4","user":{"login":"notjosh","id":33126,"avatar_url":"https://avatars.githubusercontent.com/u/33126?v=3","gravatar_id":"","url":"https://api.github.com/users/notjosh","html_url":"https://github.com/notjosh","followers_url":"https://api.github.com/users/notjosh/followers","following_url":"https://api.github.com/users/notjosh/following{/other_user}","gists_url":"https://api.github.com/users/notjosh/gists{/gist_id}","starred_url":"https://api.github.com/users/notjosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notjosh/subscriptions","organizations_url":"https://api.github.com/users/notjosh/orgs","repos_url":"https://api.github.com/users/notjosh/repos","events_url":"https://api.github.com/users/notjosh/events{/privacy}","received_events_url":"https://api.github.com/users/notjosh/received_events","type":"User","site_admin":false},"repo":{"id":26958085,"name":"NSString-UrlEncode","full_name":"notjosh/NSString-UrlEncode","owner":{"login":"notjosh","id":33126,"avatar_url":"https://avatars.githubusercontent.com/u/33126?v=3","gravatar_id":"","url":"https://api.github.com/users/notjosh","html_url":"https://github.com/notjosh","followers_url":"https://api.github.com/users/notjosh/followers","following_url":"https://api.github.com/users/notjosh/following{/other_user}","gists_url":"https://api.github.com/users/notjosh/gists{/gist_id}","starred_url":"https://api.github.com/users/notjosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notjosh/subscriptions","organizations_url":"https://api.github.com/users/notjosh/orgs","repos_url":"https://api.github.com/users/notjosh/repos","events_url":"https://api.github.com/users/notjosh/events{/privacy}","received_events_url":"https://api.github.com/users/notjosh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/notjosh/NSString-UrlEncode","description":"Category that adds urlEncode to NSString.","fork":true,"url":"https://api.github.com/repos/notjosh/NSString-UrlEncode","forks_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/forks","keys_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/teams","hooks_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/hooks","issue_events_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/issues/events{/number}","events_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/events","assignees_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/assignees{/user}","branches_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/branches{/branch}","tags_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/tags","blobs_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/git/refs{/sha}","trees_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/statuses/{sha}","languages_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/languages","stargazers_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/stargazers","contributors_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/contributors","subscribers_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/subscribers","subscription_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/subscription","commits_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/commits{/sha}","git_commits_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/git/commits{/sha}","comments_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/comments{/number}","issue_comment_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/issues/comments/{number}","contents_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/contents/{+path}","compare_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/merges","archive_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/downloads","issues_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/issues{/number}","pulls_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/pulls{/number}","milestones_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/milestones{/number}","notifications_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/labels{/name}","releases_url":"https://api.github.com/repos/notjosh/NSString-UrlEncode/releases{/id}","created_at":"2014-11-21T11:49:13Z","updated_at":"2014-11-21T12:59:51Z","pushed_at":"2014-11-21T12:59:51Z","git_url":"git://github.com/notjosh/NSString-UrlEncode.git","ssh_url":"git@github.com:notjosh/NSString-UrlEncode.git","clone_url":"https://github.com/notjosh/NSString-UrlEncode.git","svn_url":"https://github.com/notjosh/NSString-UrlEncode","homepage":null,"size":96,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kevinrenskers:master","ref":"master","sha":"fa5e4c5573fb898a2c6bb70d7d55b7b2f483798d","user":{"login":"kevinrenskers","id":229384,"avatar_url":"https://avatars.githubusercontent.com/u/229384?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinrenskers","html_url":"https://github.com/kevinrenskers","followers_url":"https://api.github.com/users/kevinrenskers/followers","following_url":"https://api.github.com/users/kevinrenskers/following{/other_user}","gists_url":"https://api.github.com/users/kevinrenskers/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrenskers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrenskers/subscriptions","organizations_url":"https://api.github.com/users/kevinrenskers/orgs","repos_url":"https://api.github.com/users/kevinrenskers/repos","events_url":"https://api.github.com/users/kevinrenskers/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrenskers/received_events","type":"User","site_admin":false},"repo":{"id":14022453,"name":"NSString-UrlEncode","full_name":"kevinrenskers/NSString-UrlEncode","owner":{"login":"kevinrenskers","id":229384,"avatar_url":"https://avatars.githubusercontent.com/u/229384?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinrenskers","html_url":"https://github.com/kevinrenskers","followers_url":"https://api.github.com/users/kevinrenskers/followers","following_url":"https://api.github.com/users/kevinrenskers/following{/other_user}","gists_url":"https://api.github.com/users/kevinrenskers/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrenskers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrenskers/subscriptions","organizations_url":"https://api.github.com/users/kevinrenskers/orgs","repos_url":"https://api.github.com/users/kevinrenskers/repos","events_url":"https://api.github.com/users/kevinrenskers/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrenskers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinrenskers/NSString-UrlEncode","description":"Category that adds urlEncode to NSString.","fork":false,"url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode","forks_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/forks","keys_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/teams","hooks_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/hooks","issue_events_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/issues/events{/number}","events_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/events","assignees_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/assignees{/user}","branches_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/branches{/branch}","tags_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/tags","blobs_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/languages","stargazers_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/stargazers","contributors_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/contributors","subscribers_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/subscribers","subscription_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/subscription","commits_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/issues/comments/{number}","contents_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/contents/{+path}","compare_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/merges","archive_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/downloads","issues_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/issues{/number}","pulls_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/labels{/name}","releases_url":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/releases{/id}","created_at":"2013-10-31T16:35:59Z","updated_at":"2014-11-25T13:05:08Z","pushed_at":"2014-11-25T13:07:32Z","git_url":"git://github.com/kevinrenskers/NSString-UrlEncode.git","ssh_url":"git@github.com:kevinrenskers/NSString-UrlEncode.git","clone_url":"https://github.com/kevinrenskers/NSString-UrlEncode.git","svn_url":"https://github.com/kevinrenskers/NSString-UrlEncode","homepage":null,"size":167,"stargazers_count":15,"watchers_count":15,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls/3"},"html":{"href":"https://github.com/kevinrenskers/NSString-UrlEncode/pull/3"},"issue":{"href":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/issues/3"},"comments":{"href":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/kevinrenskers/NSString-UrlEncode/statuses/cd07a752fa4a4a31f4231e689d2c68089d749eb4"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":2,"commits":2,"additions":22,"deletions":22,"changed_files":4}}