GitHub PullRequestReviewCommentEvent at 2014-05-22 12:11:38
Repository: ontohub
Actor: eugenk
Payload: {"comment":{"url":"https://api.github.com/repos/ontohub/ontohub/pulls/comments/12946419","id":12946419,"diff_hunk":"@@ -197,7 +198,10 @@ def import_xml(io, code_io, user)\n           end\n         }\n       save!\n-      versions.each(&:save!)\n+      versions.compact.each do |version|\n+        version.save!\n+        version.ontology.update_version!(to: version)\n+      end","path":"app/models/ontology/import.rb","position":16,"original_position":16,"commit_id":"0dda23492d6edbe1392af2e3267ef7e2648a641c","original_commit_id":"0dda23492d6edbe1392af2e3267ef7e2648a641c","user":{"login":"eugenk","id":339751,"avatar_url":"https://avatars.githubusercontent.com/u/339751?","gravatar_id":"1b777dd0f315bb88d60e3a62fc7348f1","url":"https://api.github.com/users/eugenk","html_url":"https://github.com/eugenk","followers_url":"https://api.github.com/users/eugenk/followers","following_url":"https://api.github.com/users/eugenk/following{/other_user}","gists_url":"https://api.github.com/users/eugenk/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenk/subscriptions","organizations_url":"https://api.github.com/users/eugenk/orgs","repos_url":"https://api.github.com/users/eugenk/repos","events_url":"https://api.github.com/users/eugenk/events{/privacy}","received_events_url":"https://api.github.com/users/eugenk/received_events","type":"User","site_admin":false},"body":"Just so I understand it: In this block, we assume that the versions are ordered by number (ascending), right?","created_at":"2014-05-22T12:11:38Z","updated_at":"2014-05-22T12:11:38Z","html_url":"https://github.com/ontohub/ontohub/pull/894#discussion_r12946419","pull_request_url":"https://api.github.com/repos/ontohub/ontohub/pulls/894","_links":{"self":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/comments/12946419"},"html":{"href":"https://github.com/ontohub/ontohub/pull/894#discussion_r12946419"},"pull_request":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/894"}}}}