GitHub PushEvent at 2014-12-06 04:01:03
Repository: VCard-Tools
Actor: evought
Payload: {"shas":[["da97c78c07d9a1586d34c58cab25e12fe527cd05","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Fixes #12 : Packages vCard classes in a namespace. Updates tests. Also fixes some of the inconsistency of VCard vs vCard in identifiers.","Eric Vought",false],["f0243aa4406fb5e4f0b162316da6cf3e4426d571","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","First pass at templates refactoring. Moved template functions to\nvcard-templates.php as static methods of the Template class. Began added unit\ntest cases for template methods.","Eric Vought",false],["c7981662773bdd05f8b8c37864b74915c9f9ac64","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Added new testcase for __toString(), initializing from raw vCard text, and\ninitializing from .vcf files. Added several .vcf vcard files for testing\npurposes.\nFound and fixed two issues:\n1) Empty fields in structured components on import were being\nset to empty string instead of not being set, causing round-trip comparisons\nto fail.\n2) The load path on file import was being saved in an internal property of\nvCard and this also caused round-trip comparisons to fail. vCard->Path was\nprivate, could not be set/unset/modified to cause comparisons to succeed,\nand *it was not being used anywhere*. There is no reciprocal ability to\n*save* a vCard back out to make use of the stored Path, for instance. Arguably,\nthere should be, but it can be just as easily argued that initializing from a\nfile *doesn't belong in vCard* (as we can already load from a string) and, if it\ndoes belong, that we need to think about the interface for storing/loading and\ndo it right (and do we want to load from URLs as well?). For now, I removed\nthe internal property so that equality comparisons succeeed.","Eric Vought",false],["9c12ea3e5ab37ff4fb46288b8e966b239be86371","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Modified VCardToolsTest to use the stored vcards added in previous commit\n(from VCardTools.php) instead of creating the test data again.","Eric Vought",false],["1efb14ae08d1e46984c22ad6c9705bdc6427ebb8","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Minor formatting.","Eric Vought",false],["c08b5464026fae0ca325a9398e8667a75e6bffaf","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Added convenience routines to load several sample vcards from disk for use\nas test fixtures.","Eric Vought",false],["19b79acea4b5aad91ea3a09b2b1edf7d4811c7d9","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Added convenience method for input properties of complex sample vcard for\nfuture tests ('John Doe Example') and sample raw .vcf in tests/vcards.","Eric Vought",false],["94095f9dc33db6375c53bc1d68614d4aba9f7fa0","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Improved unit test coverage.","Eric Vought",false],["66301e4604c242908a0dd82a82c401a595ee091c","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Improved unit test coverage. The essential features of templates (literal\noutput, lookups, conditional output, iteration, recursion, and fallbacks)\nare all covered to provide a foundation for refactoring.","Eric Vought",false],["b0ab3b8657d7dd7f4653bb9a9d7d5e0e8d6bf5bc","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Formatting.","Eric Vought",false],["6a63c2a33bc7dd780c9609e23bb7d4a178211d51","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Cleaned up ugly parsing loop.","Eric Vought",false],["c2b9d4670580b0ddc8dff6b56dc6552e2296db4a","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Second major refactoring pass. Refactored into a non-static class with fields\nto store the working set. The collections of named html fragments are now\ncalled 'fragments' to distinguish them from the Template instance.","Eric Vought",false],["44da8d10f9fa604d29f2a8feb79f2222dc831d74","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","More consistency in identifier naming.","Eric Vought",false],["f2de0f66df9d5ce0203e2cd485b1b7b72b69940b","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Implemented factory methods for Substitution, used it to clean up some\nof the parsing logic and eliminate potential mismatches. Need further\nrefactoring, particularly where the iteration over property values is\nconcerned.","Eric Vought",false],["b1a44a5fdff080818b4b7300e8af6c120091d0c5","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Doc comments.","Eric Vought",false],["6ae27aefa63ce8c1aa44044e5c2696f1dd244ee5","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Further refactoring. Logic now divided into processing fragments and\nprocessing any substitions contained in those fragments. Makes flow cleaner\nand cleans up a couple of border cases.","Eric Vought",false],["c0e9a571a38bfdcf3c707f66fbecfebdfcee598f","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Work on breaking out more of the parsing logic into subroutines, cleanup,\nassertions and comments.","Eric Vought",false],["a58ab27dc937a35e83ef704c859f3bcdc947077c","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Increased unit test converage, particularly of parsing substitutions.","Eric Vought",false],["e0d3ddb477aef08d59c9d2b1b8029902b924dee3","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Enhanced Substitution to parse the lookUp field, handle compound lookUps and\nmagic values, setting several predicates for interrogation, adding some error\nhandling, and then using the changes to greatly clarify the parsing logic in\ni_processLookUp(..). This also exposes some more functionality directly to\nunit testing. Added testcases. Probably getting to the bottom of the refactoring\nfor this pass. Mucked with doc comments to hopefully make the structure more\nclear.","Eric Vought",false],["00f0d5f51b99bec68464ac168895b2a61fe67e91","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Added a mechanism to register and retrieve named Templates, as well as to\nload Templates from INI files. Added testcases and test .init files.\nHave not yet moved the default template definition into an .ini file.","Eric Vought",false]],"size":28,"ref":"refs/heads/master","head":"e63c409039ab43a3426b99c7fc8177c71a0c0e15"}