GitHub PullRequestReviewCommentEvent at 2014-12-18 18:53:08
Repository: selfhub
Actor: dduugg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/selfhub/selfhub/pulls/comments/22061999","id":22061999,"diff_hunk":"@@ -0,0 +1,181 @@\n+# Contributing\n+\n+## General Workflow\n+\n+1. Fork the repo\n+1. Cut a namespaced feature branch from master\n+  - bug/...\n+  - feat/...\n+  - test/...\n+  - doc/...\n+  - refactor/...\n+1. Make commits to your feature branch. Prefix each commit like so:\n+  - (feat) Added a new feature\n+  - (fix) Fixed inconsistent tests [Fixes #0]\n+  - (refactor) ...\n+  - (cleanup) ...\n+  - (test) ...\n+  - (doc) ...\n+1. When you've finished with your fix or feature, Rebase upstream changes into your branch. submit a [pull request][]\n+   directly to master. Include a description of your changes.\n+1. Your pull request will be reviewed by another maintainer. The point of code\n+   reviews is to help keep the codebase clean and of high quality and, equally\n+   as important, to help you grow as a programmer. If your code reviewer\n+   requests you make a change you don't understand, ask them why.\n+1. Fix any issues raised by your code reviwer, and push your fixes as a single\n+   new commit.\n+1. Once the pull request has been reviewed, it will be merged by another member of the team. Do not merge your own commits.\n+\n+## Detailed Workflow\n+\n+### Fork the repo\n+\n+Use github’s interface to make a fork of the repo, then add that repo as an upstream remote:\n+\n+```\n+git remote add upstream https://github.com/hackreactor-labs/<NAME_OF_REPO>.git\n+```\n+\n+### Cut a namespaced feature branch from master\n+\n+Your branch should follow this naming convention:\n+  - bug/...\n+  - feat/...\n+  - test/...\n+  - doc/...\n+  - refactor/...\n+\n+These commands will help you do this:\n+\n+``` bash\n+\n+# Creates your branch and brings you there\n+git checkout -b `your-branch-name`\n+```\n+\n+### Make commits to your feature branch. \n+\n+Prefix each commit like so\n+  - (feat) Added a new feature\n+  - (fix) Fixed inconsistent tests [Fixes #0]\n+  - (refactor) ...\n+  - (cleanup) ...\n+  - (test) ...\n+  - (doc) ...\n+\n+Make changes and commits on your branch, and make sure that you\n+only make changes that are relevant to this branch. If you find\n+yourself making unrelated changes, make a new branch for those\n+changes.\n+\n+#### Commit Message Guidelines\n+\n+- Commit messages should be written in the present tense; e.g. \"Fix continuous\n+  integration script\".\n+- The first line of your commit message should be a brief summary of what the\n+  commit changes. Aim for about 70 characters max. Remember: This is a summary,\n+  not a detailed description of everything that changed.\n+- If you want to explain the commit in more depth, following the first line should\n+  be a blank line and then a more detailed description of the commit. This can be\n+  as detailed as you want, so dig into details here and keep the first line short.\n+\n+### Rebase upstream changes into your branch\n+\n+Once you are done making changes, you can begin the process of getting\n+your code merged into the main repo. Step 1 is to rebase upstream\n+changes to the master branch into yours by running this command\n+from your branch:\n+\n+```bash\n+git pull --rebase upstream master\n+```\n+\n+This will start the rebase process. You must commit all of your changes\n+before doing this. If there are no conflicts, this should just roll all\n+of your changes back on top of the changes from upstream, leading to a\n+nice, clean, linear commit history.\n+\n+If there are conflicting changes, git will start yelling at you part way\n+through the rebasing process. Git will pause rebasing to allow you to sort\n+out the conflicts. You do this the same way you solve merge conflicts,\n+by checking all of the files git says have been changed in both histories\n+and picking the versions you want. Be aware that these changes will show\n+up in your pull request, so try and incorporate upstream changes as much\n+as possible.\n+\n+You pick a file by `git add`ing it - you do not make commits during a\n+rebase.\n+\n+Once you are done fixing conflicts for a specific commit, run:\n+\n+```bash\n+git rebase --continue\n+```\n+\n+This will continue the rebasing process. Once you are done fixing all\n+conflicts you should run the existing tests to make sure you didn’t break\n+anything, then run your new tests (there are new tests, right?) and\n+make sure they work also.\n+\n+If rebasing broke anything, fix it, then repeat the above process until\n+you get here again and nothing is broken and all the tests pass.\n+\n+### Make a pull request\n+\n+Make a clear pull request from your fork and branch to the upstream master\n+branch, detailing exactly what changes you made and what feature this\n+should add. The clearer your pull request is the faster you can get\n+your changes incorporated into this repo.\n+\n+At least one other person MUST give your changes a code review, and once\n+they are satisfied they will merge your changes into upstream. Alternatively,\n+they may have some requested changes. You should make more commits to your\n+branch to fix these, then follow this process again from rebasing onwards.\n+\n+Once you get back here, make a comment requesting further review and\n+someone will look at your code again. If they like it, it will get merged,\n+else, just repeat again.\n+\n+Thanks for contributing!\n+\n+### Guidelines","path":"CONTRIBUTING.md","position":141,"original_position":141,"commit_id":"50b1bbb83874c9b97085a8573fc31a449df127ab","original_commit_id":"50b1bbb83874c9b97085a8573fc31a449df127ab","user":{"login":"dduugg","id":697964,"avatar_url":"https://avatars.githubusercontent.com/u/697964?v=3","gravatar_id":"","url":"https://api.github.com/users/dduugg","html_url":"https://github.com/dduugg","followers_url":"https://api.github.com/users/dduugg/followers","following_url":"https://api.github.com/users/dduugg/following{/other_user}","gists_url":"https://api.github.com/users/dduugg/gists{/gist_id}","starred_url":"https://api.github.com/users/dduugg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dduugg/subscriptions","organizations_url":"https://api.github.com/users/dduugg/orgs","repos_url":"https://api.github.com/users/dduugg/repos","events_url":"https://api.github.com/users/dduugg/events{/privacy}","received_events_url":"https://api.github.com/users/dduugg/received_events","type":"User","site_admin":false},"body":"Lots of formatting issues (and a broken link) in this section.","created_at":"2014-12-18T18:53:08Z","updated_at":"2014-12-18T18:53:08Z","html_url":"https://github.com/selfhub/selfhub/pull/23#discussion_r22061999","pull_request_url":"https://api.github.com/repos/selfhub/selfhub/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/selfhub/selfhub/pulls/comments/22061999"},"html":{"href":"https://github.com/selfhub/selfhub/pull/23#discussion_r22061999"},"pull_request":{"href":"https://api.github.com/repos/selfhub/selfhub/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/selfhub/selfhub/pulls/23","id":26250972,"html_url":"https://github.com/selfhub/selfhub/pull/23","diff_url":"https://github.com/selfhub/selfhub/pull/23.diff","patch_url":"https://github.com/selfhub/selfhub/pull/23.patch","issue_url":"https://api.github.com/repos/selfhub/selfhub/issues/23","number":23,"state":"open","locked":false,"title":"Update README and press_release","user":{"login":"cmperez","id":7391135,"avatar_url":"https://avatars.githubusercontent.com/u/7391135?v=3","gravatar_id":"","url":"https://api.github.com/users/cmperez","html_url":"https://github.com/cmperez","followers_url":"https://api.github.com/users/cmperez/followers","following_url":"https://api.github.com/users/cmperez/following{/other_user}","gists_url":"https://api.github.com/users/cmperez/gists{/gist_id}","starred_url":"https://api.github.com/users/cmperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmperez/subscriptions","organizations_url":"https://api.github.com/users/cmperez/orgs","repos_url":"https://api.github.com/users/cmperez/repos","events_url":"https://api.github.com/users/cmperez/events{/privacy}","received_events_url":"https://api.github.com/users/cmperez/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-17T19:48:40Z","updated_at":"2014-12-18T18:53:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ab03d1ee458f6cdf2008d9b4b13492926eca449","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/selfhub/selfhub/pulls/23/commits","review_comments_url":"https://api.github.com/repos/selfhub/selfhub/pulls/23/comments","review_comment_url":"https://api.github.com/repos/selfhub/selfhub/pulls/comments/{number}","comments_url":"https://api.github.com/repos/selfhub/selfhub/issues/23/comments","statuses_url":"https://api.github.com/repos/selfhub/selfhub/statuses/50b1bbb83874c9b97085a8573fc31a449df127ab","head":{"label":"cmperez:readme","ref":"readme","sha":"50b1bbb83874c9b97085a8573fc31a449df127ab","user":{"login":"cmperez","id":7391135,"avatar_url":"https://avatars.githubusercontent.com/u/7391135?v=3","gravatar_id":"","url":"https://api.github.com/users/cmperez","html_url":"https://github.com/cmperez","followers_url":"https://api.github.com/users/cmperez/followers","following_url":"https://api.github.com/users/cmperez/following{/other_user}","gists_url":"https://api.github.com/users/cmperez/gists{/gist_id}","starred_url":"https://api.github.com/users/cmperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmperez/subscriptions","organizations_url":"https://api.github.com/users/cmperez/orgs","repos_url":"https://api.github.com/users/cmperez/repos","events_url":"https://api.github.com/users/cmperez/events{/privacy}","received_events_url":"https://api.github.com/users/cmperez/received_events","type":"User","site_admin":false},"repo":{"id":28111352,"name":"selfhub","full_name":"cmperez/selfhub","owner":{"login":"cmperez","id":7391135,"avatar_url":"https://avatars.githubusercontent.com/u/7391135?v=3","gravatar_id":"","url":"https://api.github.com/users/cmperez","html_url":"https://github.com/cmperez","followers_url":"https://api.github.com/users/cmperez/followers","following_url":"https://api.github.com/users/cmperez/following{/other_user}","gists_url":"https://api.github.com/users/cmperez/gists{/gist_id}","starred_url":"https://api.github.com/users/cmperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmperez/subscriptions","organizations_url":"https://api.github.com/users/cmperez/orgs","repos_url":"https://api.github.com/users/cmperez/repos","events_url":"https://api.github.com/users/cmperez/events{/privacy}","received_events_url":"https://api.github.com/users/cmperez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmperez/selfhub","description":"","fork":true,"url":"https://api.github.com/repos/cmperez/selfhub","forks_url":"https://api.github.com/repos/cmperez/selfhub/forks","keys_url":"https://api.github.com/repos/cmperez/selfhub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmperez/selfhub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmperez/selfhub/teams","hooks_url":"https://api.github.com/repos/cmperez/selfhub/hooks","issue_events_url":"https://api.github.com/repos/cmperez/selfhub/issues/events{/number}","events_url":"https://api.github.com/repos/cmperez/selfhub/events","assignees_url":"https://api.github.com/repos/cmperez/selfhub/assignees{/user}","branches_url":"https://api.github.com/repos/cmperez/selfhub/branches{/branch}","tags_url":"https://api.github.com/repos/cmperez/selfhub/tags","blobs_url":"https://api.github.com/repos/cmperez/selfhub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmperez/selfhub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmperez/selfhub/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmperez/selfhub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmperez/selfhub/statuses/{sha}","languages_url":"https://api.github.com/repos/cmperez/selfhub/languages","stargazers_url":"https://api.github.com/repos/cmperez/selfhub/stargazers","contributors_url":"https://api.github.com/repos/cmperez/selfhub/contributors","subscribers_url":"https://api.github.com/repos/cmperez/selfhub/subscribers","subscription_url":"https://api.github.com/repos/cmperez/selfhub/subscription","commits_url":"https://api.github.com/repos/cmperez/selfhub/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmperez/selfhub/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmperez/selfhub/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmperez/selfhub/issues/comments/{number}","contents_url":"https://api.github.com/repos/cmperez/selfhub/contents/{+path}","compare_url":"https://api.github.com/repos/cmperez/selfhub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmperez/selfhub/merges","archive_url":"https://api.github.com/repos/cmperez/selfhub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmperez/selfhub/downloads","issues_url":"https://api.github.com/repos/cmperez/selfhub/issues{/number}","pulls_url":"https://api.github.com/repos/cmperez/selfhub/pulls{/number}","milestones_url":"https://api.github.com/repos/cmperez/selfhub/milestones{/number}","notifications_url":"https://api.github.com/repos/cmperez/selfhub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmperez/selfhub/labels{/name}","releases_url":"https://api.github.com/repos/cmperez/selfhub/releases{/id}","created_at":"2014-12-16T23:17:50Z","updated_at":"2014-12-16T22:25:58Z","pushed_at":"2014-12-17T22:45:46Z","git_url":"git://github.com/cmperez/selfhub.git","ssh_url":"git@github.com:cmperez/selfhub.git","clone_url":"https://github.com/cmperez/selfhub.git","svn_url":"https://github.com/cmperez/selfhub","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"selfhub:develop","ref":"develop","sha":"af984842638634c37d4246c7d192d3e1b12134a5","user":{"login":"selfhub","id":10214048,"avatar_url":"https://avatars.githubusercontent.com/u/10214048?v=3","gravatar_id":"","url":"https://api.github.com/users/selfhub","html_url":"https://github.com/selfhub","followers_url":"https://api.github.com/users/selfhub/followers","following_url":"https://api.github.com/users/selfhub/following{/other_user}","gists_url":"https://api.github.com/users/selfhub/gists{/gist_id}","starred_url":"https://api.github.com/users/selfhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selfhub/subscriptions","organizations_url":"https://api.github.com/users/selfhub/orgs","repos_url":"https://api.github.com/users/selfhub/repos","events_url":"https://api.github.com/users/selfhub/events{/privacy}","received_events_url":"https://api.github.com/users/selfhub/received_events","type":"Organization","site_admin":false},"repo":{"id":28109544,"name":"selfhub","full_name":"selfhub/selfhub","owner":{"login":"selfhub","id":10214048,"avatar_url":"https://avatars.githubusercontent.com/u/10214048?v=3","gravatar_id":"","url":"https://api.github.com/users/selfhub","html_url":"https://github.com/selfhub","followers_url":"https://api.github.com/users/selfhub/followers","following_url":"https://api.github.com/users/selfhub/following{/other_user}","gists_url":"https://api.github.com/users/selfhub/gists{/gist_id}","starred_url":"https://api.github.com/users/selfhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selfhub/subscriptions","organizations_url":"https://api.github.com/users/selfhub/orgs","repos_url":"https://api.github.com/users/selfhub/repos","events_url":"https://api.github.com/users/selfhub/events{/privacy}","received_events_url":"https://api.github.com/users/selfhub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/selfhub/selfhub","description":"","fork":false,"url":"https://api.github.com/repos/selfhub/selfhub","forks_url":"https://api.github.com/repos/selfhub/selfhub/forks","keys_url":"https://api.github.com/repos/selfhub/selfhub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selfhub/selfhub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selfhub/selfhub/teams","hooks_url":"https://api.github.com/repos/selfhub/selfhub/hooks","issue_events_url":"https://api.github.com/repos/selfhub/selfhub/issues/events{/number}","events_url":"https://api.github.com/repos/selfhub/selfhub/events","assignees_url":"https://api.github.com/repos/selfhub/selfhub/assignees{/user}","branches_url":"https://api.github.com/repos/selfhub/selfhub/branches{/branch}","tags_url":"https://api.github.com/repos/selfhub/selfhub/tags","blobs_url":"https://api.github.com/repos/selfhub/selfhub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selfhub/selfhub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selfhub/selfhub/git/refs{/sha}","trees_url":"https://api.github.com/repos/selfhub/selfhub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selfhub/selfhub/statuses/{sha}","languages_url":"https://api.github.com/repos/selfhub/selfhub/languages","stargazers_url":"https://api.github.com/repos/selfhub/selfhub/stargazers","contributors_url":"https://api.github.com/repos/selfhub/selfhub/contributors","subscribers_url":"https://api.github.com/repos/selfhub/selfhub/subscribers","subscription_url":"https://api.github.com/repos/selfhub/selfhub/subscription","commits_url":"https://api.github.com/repos/selfhub/selfhub/commits{/sha}","git_commits_url":"https://api.github.com/repos/selfhub/selfhub/git/commits{/sha}","comments_url":"https://api.github.com/repos/selfhub/selfhub/comments{/number}","issue_comment_url":"https://api.github.com/repos/selfhub/selfhub/issues/comments/{number}","contents_url":"https://api.github.com/repos/selfhub/selfhub/contents/{+path}","compare_url":"https://api.github.com/repos/selfhub/selfhub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selfhub/selfhub/merges","archive_url":"https://api.github.com/repos/selfhub/selfhub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selfhub/selfhub/downloads","issues_url":"https://api.github.com/repos/selfhub/selfhub/issues{/number}","pulls_url":"https://api.github.com/repos/selfhub/selfhub/pulls{/number}","milestones_url":"https://api.github.com/repos/selfhub/selfhub/milestones{/number}","notifications_url":"https://api.github.com/repos/selfhub/selfhub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selfhub/selfhub/labels{/name}","releases_url":"https://api.github.com/repos/selfhub/selfhub/releases{/id}","created_at":"2014-12-16T22:25:58Z","updated_at":"2014-12-17T19:50:45Z","pushed_at":"2014-12-17T19:50:44Z","git_url":"git://github.com/selfhub/selfhub.git","ssh_url":"git@github.com:selfhub/selfhub.git","clone_url":"https://github.com/selfhub/selfhub.git","svn_url":"https://github.com/selfhub/selfhub","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/selfhub/selfhub/pulls/23"},"html":{"href":"https://github.com/selfhub/selfhub/pull/23"},"issue":{"href":"https://api.github.com/repos/selfhub/selfhub/issues/23"},"comments":{"href":"https://api.github.com/repos/selfhub/selfhub/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/selfhub/selfhub/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/selfhub/selfhub/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/selfhub/selfhub/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/selfhub/selfhub/statuses/50b1bbb83874c9b97085a8573fc31a449df127ab"}}}}