GitHub PullRequestReviewCommentEvent at 2014-11-01 10:59:43
Repository: langchecker
Actor: flodolo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/comments/19703575","id":19703575,"diff_hunk":"@@ -5,33 +5,47 @@\n \n $todo  = [];\n \n-// We consider only mozilla.org, so $sites[0]\n-$current_website = $sites[0];\n-$reference_locale = Project::getReferenceLocale($current_website);\n-\n foreach ($mozilla as $current_locale) {\n-    // Ignore reference language\n-    if ($current_locale == $reference_locale) {\n-        continue;\n-    }\n \n     $todo[$current_locale]  = 0;\n \n-    foreach (Project::getWebsiteFiles($current_website) as $current_filename) {\n-        // Skip the loop if we don't have this lang file for the locale\n-        if (! Project::isSupportedLocale($current_website, $current_locale, $langfiles_subsets, $current_filename)) {\n+    foreach ($sites as $current_website) {","path":"views/countstrings.inc.php","position":19,"original_position":19,"commit_id":"fd47265bacb05eea6326ac69261cae26d766bafc","original_commit_id":"fd47265bacb05eea6326ac69261cae26d766bafc","user":{"login":"flodolo","id":3644868,"avatar_url":"https://avatars.githubusercontent.com/u/3644868?v=2","gravatar_id":"","url":"https://api.github.com/users/flodolo","html_url":"https://github.com/flodolo","followers_url":"https://api.github.com/users/flodolo/followers","following_url":"https://api.github.com/users/flodolo/following{/other_user}","gists_url":"https://api.github.com/users/flodolo/gists{/gist_id}","starred_url":"https://api.github.com/users/flodolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodolo/subscriptions","organizations_url":"https://api.github.com/users/flodolo/orgs","repos_url":"https://api.github.com/users/flodolo/repos","events_url":"https://api.github.com/users/flodolo/events{/privacy}","received_events_url":"https://api.github.com/users/flodolo/received_events","type":"User","site_admin":false},"body":"Use ```Project::getWebsitesByDataType($sites, 'lang')``` instead of $sites and you can drop the first check","created_at":"2014-11-01T10:59:43Z","updated_at":"2014-11-01T10:59:43Z","html_url":"https://github.com/mozilla-l10n/langchecker/pull/213#discussion_r19703575","pull_request_url":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/comments/19703575"},"html":{"href":"https://github.com/mozilla-l10n/langchecker/pull/213#discussion_r19703575"},"pull_request":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/213","id":23718223,"html_url":"https://github.com/mozilla-l10n/langchecker/pull/213","diff_url":"https://github.com/mozilla-l10n/langchecker/pull/213.diff","patch_url":"https://github.com/mozilla-l10n/langchecker/pull/213.patch","issue_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/213","number":213,"state":"open","locked":false,"title":"Issue #122: counstring view should give results for all projects","user":{"login":"pascalchevrel","id":454375,"avatar_url":"https://avatars.githubusercontent.com/u/454375?v=2","gravatar_id":"","url":"https://api.github.com/users/pascalchevrel","html_url":"https://github.com/pascalchevrel","followers_url":"https://api.github.com/users/pascalchevrel/followers","following_url":"https://api.github.com/users/pascalchevrel/following{/other_user}","gists_url":"https://api.github.com/users/pascalchevrel/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalchevrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalchevrel/subscriptions","organizations_url":"https://api.github.com/users/pascalchevrel/orgs","repos_url":"https://api.github.com/users/pascalchevrel/repos","events_url":"https://api.github.com/users/pascalchevrel/events{/privacy}","received_events_url":"https://api.github.com/users/pascalchevrel/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-01T10:56:22Z","updated_at":"2014-11-01T10:59:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dedeb349f6ad07a43eb244ba29c25c4e125f01ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/213/commits","review_comments_url":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/213/comments","review_comment_url":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/213/comments","statuses_url":"https://api.github.com/repos/mozilla-l10n/langchecker/statuses/fd47265bacb05eea6326ac69261cae26d766bafc","head":{"label":"pascalchevrel:issu-212-countstringview_all_projects","ref":"issu-212-countstringview_all_projects","sha":"fd47265bacb05eea6326ac69261cae26d766bafc","user":{"login":"pascalchevrel","id":454375,"avatar_url":"https://avatars.githubusercontent.com/u/454375?v=2","gravatar_id":"","url":"https://api.github.com/users/pascalchevrel","html_url":"https://github.com/pascalchevrel","followers_url":"https://api.github.com/users/pascalchevrel/followers","following_url":"https://api.github.com/users/pascalchevrel/following{/other_user}","gists_url":"https://api.github.com/users/pascalchevrel/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalchevrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalchevrel/subscriptions","organizations_url":"https://api.github.com/users/pascalchevrel/orgs","repos_url":"https://api.github.com/users/pascalchevrel/repos","events_url":"https://api.github.com/users/pascalchevrel/events{/privacy}","received_events_url":"https://api.github.com/users/pascalchevrel/received_events","type":"User","site_admin":false},"repo":{"id":23576902,"name":"langchecker","full_name":"pascalchevrel/langchecker","owner":{"login":"pascalchevrel","id":454375,"avatar_url":"https://avatars.githubusercontent.com/u/454375?v=2","gravatar_id":"","url":"https://api.github.com/users/pascalchevrel","html_url":"https://github.com/pascalchevrel","followers_url":"https://api.github.com/users/pascalchevrel/followers","following_url":"https://api.github.com/users/pascalchevrel/following{/other_user}","gists_url":"https://api.github.com/users/pascalchevrel/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalchevrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalchevrel/subscriptions","organizations_url":"https://api.github.com/users/pascalchevrel/orgs","repos_url":"https://api.github.com/users/pascalchevrel/repos","events_url":"https://api.github.com/users/pascalchevrel/events{/privacy}","received_events_url":"https://api.github.com/users/pascalchevrel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pascalchevrel/langchecker","description":"code to replicate the langchecker feature on my webdashboard","fork":true,"url":"https://api.github.com/repos/pascalchevrel/langchecker","forks_url":"https://api.github.com/repos/pascalchevrel/langchecker/forks","keys_url":"https://api.github.com/repos/pascalchevrel/langchecker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pascalchevrel/langchecker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pascalchevrel/langchecker/teams","hooks_url":"https://api.github.com/repos/pascalchevrel/langchecker/hooks","issue_events_url":"https://api.github.com/repos/pascalchevrel/langchecker/issues/events{/number}","events_url":"https://api.github.com/repos/pascalchevrel/langchecker/events","assignees_url":"https://api.github.com/repos/pascalchevrel/langchecker/assignees{/user}","branches_url":"https://api.github.com/repos/pascalchevrel/langchecker/branches{/branch}","tags_url":"https://api.github.com/repos/pascalchevrel/langchecker/tags","blobs_url":"https://api.github.com/repos/pascalchevrel/langchecker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pascalchevrel/langchecker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pascalchevrel/langchecker/git/refs{/sha}","trees_url":"https://api.github.com/repos/pascalchevrel/langchecker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pascalchevrel/langchecker/statuses/{sha}","languages_url":"https://api.github.com/repos/pascalchevrel/langchecker/languages","stargazers_url":"https://api.github.com/repos/pascalchevrel/langchecker/stargazers","contributors_url":"https://api.github.com/repos/pascalchevrel/langchecker/contributors","subscribers_url":"https://api.github.com/repos/pascalchevrel/langchecker/subscribers","subscription_url":"https://api.github.com/repos/pascalchevrel/langchecker/subscription","commits_url":"https://api.github.com/repos/pascalchevrel/langchecker/commits{/sha}","git_commits_url":"https://api.github.com/repos/pascalchevrel/langchecker/git/commits{/sha}","comments_url":"https://api.github.com/repos/pascalchevrel/langchecker/comments{/number}","issue_comment_url":"https://api.github.com/repos/pascalchevrel/langchecker/issues/comments/{number}","contents_url":"https://api.github.com/repos/pascalchevrel/langchecker/contents/{+path}","compare_url":"https://api.github.com/repos/pascalchevrel/langchecker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pascalchevrel/langchecker/merges","archive_url":"https://api.github.com/repos/pascalchevrel/langchecker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pascalchevrel/langchecker/downloads","issues_url":"https://api.github.com/repos/pascalchevrel/langchecker/issues{/number}","pulls_url":"https://api.github.com/repos/pascalchevrel/langchecker/pulls{/number}","milestones_url":"https://api.github.com/repos/pascalchevrel/langchecker/milestones{/number}","notifications_url":"https://api.github.com/repos/pascalchevrel/langchecker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pascalchevrel/langchecker/labels{/name}","releases_url":"https://api.github.com/repos/pascalchevrel/langchecker/releases{/id}","created_at":"2014-09-02T11:57:36Z","updated_at":"2014-09-24T15:58:13Z","pushed_at":"2014-11-01T10:56:02Z","git_url":"git://github.com/pascalchevrel/langchecker.git","ssh_url":"git@github.com:pascalchevrel/langchecker.git","clone_url":"https://github.com/pascalchevrel/langchecker.git","svn_url":"https://github.com/pascalchevrel/langchecker","homepage":null,"size":726,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-l10n:master","ref":"master","sha":"d624511bf7f32563dd65adcda83a11f0fbd7d25d","user":{"login":"mozilla-l10n","id":8619669,"avatar_url":"https://avatars.githubusercontent.com/u/8619669?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-l10n","html_url":"https://github.com/mozilla-l10n","followers_url":"https://api.github.com/users/mozilla-l10n/followers","following_url":"https://api.github.com/users/mozilla-l10n/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-l10n/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-l10n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-l10n/subscriptions","organizations_url":"https://api.github.com/users/mozilla-l10n/orgs","repos_url":"https://api.github.com/users/mozilla-l10n/repos","events_url":"https://api.github.com/users/mozilla-l10n/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-l10n/received_events","type":"Organization","site_admin":false},"repo":{"id":11282767,"name":"langchecker","full_name":"mozilla-l10n/langchecker","owner":{"login":"mozilla-l10n","id":8619669,"avatar_url":"https://avatars.githubusercontent.com/u/8619669?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-l10n","html_url":"https://github.com/mozilla-l10n","followers_url":"https://api.github.com/users/mozilla-l10n/followers","following_url":"https://api.github.com/users/mozilla-l10n/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-l10n/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-l10n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-l10n/subscriptions","organizations_url":"https://api.github.com/users/mozilla-l10n/orgs","repos_url":"https://api.github.com/users/mozilla-l10n/repos","events_url":"https://api.github.com/users/mozilla-l10n/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-l10n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-l10n/langchecker","description":"code to replicate the langchecker feature on my webdashboard","fork":false,"url":"https://api.github.com/repos/mozilla-l10n/langchecker","forks_url":"https://api.github.com/repos/mozilla-l10n/langchecker/forks","keys_url":"https://api.github.com/repos/mozilla-l10n/langchecker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-l10n/langchecker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-l10n/langchecker/teams","hooks_url":"https://api.github.com/repos/mozilla-l10n/langchecker/hooks","issue_events_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-l10n/langchecker/events","assignees_url":"https://api.github.com/repos/mozilla-l10n/langchecker/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-l10n/langchecker/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-l10n/langchecker/tags","blobs_url":"https://api.github.com/repos/mozilla-l10n/langchecker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-l10n/langchecker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-l10n/langchecker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-l10n/langchecker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-l10n/langchecker/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-l10n/langchecker/languages","stargazers_url":"https://api.github.com/repos/mozilla-l10n/langchecker/stargazers","contributors_url":"https://api.github.com/repos/mozilla-l10n/langchecker/contributors","subscribers_url":"https://api.github.com/repos/mozilla-l10n/langchecker/subscribers","subscription_url":"https://api.github.com/repos/mozilla-l10n/langchecker/subscription","commits_url":"https://api.github.com/repos/mozilla-l10n/langchecker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-l10n/langchecker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-l10n/langchecker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-l10n/langchecker/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-l10n/langchecker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-l10n/langchecker/merges","archive_url":"https://api.github.com/repos/mozilla-l10n/langchecker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-l10n/langchecker/downloads","issues_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-l10n/langchecker/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-l10n/langchecker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-l10n/langchecker/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-l10n/langchecker/releases{/id}","created_at":"2013-07-09T13:18:12Z","updated_at":"2014-09-02T01:23:36Z","pushed_at":"2014-10-31T21:42:50Z","git_url":"git://github.com/mozilla-l10n/langchecker.git","ssh_url":"git@github.com:mozilla-l10n/langchecker.git","clone_url":"https://github.com/mozilla-l10n/langchecker.git","svn_url":"https://github.com/mozilla-l10n/langchecker","homepage":null,"size":4760,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/213"},"html":{"href":"https://github.com/mozilla-l10n/langchecker/pull/213"},"issue":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/213"},"comments":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-l10n/langchecker/statuses/fd47265bacb05eea6326ac69261cae26d766bafc"}}}}