GitHub PullRequestEvent at 2014-07-31 20:21:31
Repository: angular.js
Actor: mzgol
Payload: {"action":"closed","number":7311,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/7311","id":15335568,"html_url":"https://github.com/angular/angular.js/pull/7311","diff_url":"https://github.com/angular/angular.js/pull/7311.diff","patch_url":"https://github.com/angular/angular.js/pull/7311.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/7311","number":7311,"state":"closed","title":"feat(jQuery): upgrade to jQuery to 2.1.1","user":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=1","gravatar_id":"72ea0622f7b690ed82f5261b16ff8cef","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"body":"feat(jQuery): upgrade to jQuery to 2.1.1\r\n\r\nThe data jQuery method was re-implemented in 2.0 in a secure way. This made\r\ncurrent hacky Angular solution to move data between elements via changing the\r\nvalue of the internal node[jQuery.expando] stop working. Instead, just copy the\r\ndata from the first element to the other one.\r\n\r\nTesting cache leaks on jQuery 2.x is not possible in the same way as it's done\r\nin jqLite or in jQuery 1.x as there is no publicly exposed data storage. One\r\nway to test it would be to intercept all places where a jQuery object is created\r\nto save a reference to the underlaying node but there is no single place in the\r\njQuery code through which all element creation passes (there are various\r\nshortcuts for performance reasons). Instead we rely on jqLite.cache testing\r\nto find potential data leaks.\r\n\r\nBREAKING CHANGE: Angular no longer supports jQuery versions below 2.1.1.\r\n\r\n**Original description:**\r\nThe data jQuery method was re-implemented in 2.0 in a secure way. This made\r\ncurrent hacky Angular solution to move data between elements via changing the\r\nvalue of the internal node[jQuery.expando] stop working. Instead, just move the\r\ndata from the first element to the other one.\r\n\r\ncc @caitp @IgorMinar","created_at":"2014-04-30T10:32:51Z","updated_at":"2014-07-31T20:21:29Z","closed_at":"2014-07-31T20:21:29Z","merged_at":"2014-07-31T20:21:29Z","merge_commit_sha":"1950e6c0dfa3bca2c2d94e25584fa43d3600ca50","assignee":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=1","gravatar_id":"72ea0622f7b690ed82f5261b16ff8cef","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/61","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/61/labels","id":732391,"number":61,"title":"1.3.0-beta.18","description":"","creator":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?v=1","gravatar_id":"007ba2fad36ea1313710744713dd6594","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":18,"state":"open","created_at":"2014-07-25T18:06:30Z","updated_at":"2014-07-31T20:21:29Z","due_on":"2014-08-01T07:00:00Z"},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/7311/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/7311/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/7311/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/9e7cb3c37543008e6236bb5a2c4536df2e1e43a9","head":{"label":"mzgol:jquery-2-compat","ref":"jquery-2-compat","sha":"9e7cb3c37543008e6236bb5a2c4536df2e1e43a9","user":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=1","gravatar_id":"72ea0622f7b690ed82f5261b16ff8cef","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"repo":{"id":9753166,"name":"angular.js","full_name":"mzgol/angular.js","owner":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=1","gravatar_id":"72ea0622f7b690ed82f5261b16ff8cef","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mzgol/angular.js","description":"","fork":true,"url":"https://api.github.com/repos/mzgol/angular.js","forks_url":"https://api.github.com/repos/mzgol/angular.js/forks","keys_url":"https://api.github.com/repos/mzgol/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mzgol/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mzgol/angular.js/teams","hooks_url":"https://api.github.com/repos/mzgol/angular.js/hooks","issue_events_url":"https://api.github.com/repos/mzgol/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/mzgol/angular.js/events","assignees_url":"https://api.github.com/repos/mzgol/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/mzgol/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/mzgol/angular.js/tags","blobs_url":"https://api.github.com/repos/mzgol/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mzgol/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mzgol/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mzgol/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mzgol/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mzgol/angular.js/languages","stargazers_url":"https://api.github.com/repos/mzgol/angular.js/stargazers","contributors_url":"https://api.github.com/repos/mzgol/angular.js/contributors","subscribers_url":"https://api.github.com/repos/mzgol/angular.js/subscribers","subscription_url":"https://api.github.com/repos/mzgol/angular.js/subscription","commits_url":"https://api.github.com/repos/mzgol/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mzgol/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mzgol/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mzgol/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/mzgol/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/mzgol/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mzgol/angular.js/merges","archive_url":"https://api.github.com/repos/mzgol/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mzgol/angular.js/downloads","issues_url":"https://api.github.com/repos/mzgol/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/mzgol/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mzgol/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mzgol/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mzgol/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/mzgol/angular.js/releases{/id}","created_at":"2013-04-29T16:57:39Z","updated_at":"2014-06-24T15:15:28Z","pushed_at":"2014-07-31T20:20:54Z","git_url":"git://github.com/mzgol/angular.js.git","ssh_url":"git@github.com:mzgol/angular.js.git","clone_url":"https://github.com/mzgol/angular.js.git","svn_url":"https://github.com/mzgol/angular.js","homepage":"http://angularjs.org","size":53448,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"38db2d4ceccbe9834c48756cde7f1242b5842637","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=1","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=1","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2014-07-31T19:52:46Z","pushed_at":"2014-07-31T20:21:05Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":200795,"stargazers_count":26708,"watchers_count":26708,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9616,"mirror_url":null,"open_issues_count":1064,"forks":9616,"open_issues":1064,"watchers":26708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/7311"},"html":{"href":"https://github.com/angular/angular.js/pull/7311"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/7311"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/7311/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/7311/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/7311/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/9e7cb3c37543008e6236bb5a2c4536df2e1e43a9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=1","gravatar_id":"72ea0622f7b690ed82f5261b16ff8cef","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"comments":9,"review_comments":23,"commits":1,"additions":102,"deletions":38,"changed_files":13}}