GitHub PullRequestReviewCommentEvent at 2014-05-13 13:27:50
Repository: cmssw
Actor: Dr15Jones
Payload: {"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/12582340","id":12582340,"diff_hunk":"@@ -94,7 +95,10 @@ FamosManager::setupGeometryAndField(edm::Run const& run, const edm::EventSetup &\n   edm::ESHandle < HepPDT::ParticleDataTable > pdt;\n   es.getData(pdt);\n   mySimEvent->initializePdt(&(*pdt));\n-  ParticleTable::instance(&(*pdt));\n+  \n+  if( !ParticleTable::instance() ) {\n+    pTableSentry_.reset( new ParticleTable::Sentry(pdt.product()) );","path":"FastSimulation/EventProducer/src/FamosManager.cc","position":15,"original_position":15,"commit_id":"088faffe399f77b728cc182c3365cbd6ae6b708e","original_commit_id":"088faffe399f77b728cc182c3365cbd6ae6b708e","user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?","gravatar_id":"77cceb256cbe19359ed41d214beab6e9","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"body":"Setting this at beginRun won't help since the thread which is used to call beginRun won't necessarily be the one used for the Event. The Sentry must be called for all top level modules routines (e.g. beginRun, produce) for which the data will be needed.","created_at":"2014-05-13T13:27:50Z","updated_at":"2014-05-13T13:27:50Z","html_url":"https://github.com/cms-sw/cmssw/pull/3809#discussion_r12582340","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/3809","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/12582340"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/3809#discussion_r12582340"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/3809"}}}}