GitHub PullRequestReviewCommentEvent at 2014-06-27 23:33:13
Repository: swagger-py
Actor: jnb
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/14320032","id":14320032,"diff_hunk":"@@ -169,6 +178,127 @@ def apply(self, request):\n         request.params[self.param_name] = self.api_key\n \n \n+class AsynchronousHttpClient(HttpClient):\n+    \"\"\"Asynchronous HTTP client implementation.\n+    \"\"\"\n+\n+    def setup(self, request_params):\n+        \"\"\"Sets up the request params as per Twisted Agent needs.\n+        Sets up crochet and triggers the API request in background\n+\n+        :param request_params: request parameters for API call\n+        :type request_params: dict\n+        \"\"\"\n+        self.request_params = {\n+            'method': str(request_params['method']),\n+            'bodyProducer': stringify_async_body(request_params),\n+            'headers': listify_headers(request_params['headers']),\n+            'uri': str(request_params['url'] + '?' + urllib.urlencode(\n+                request_params['params']))\n+        }\n+\n+        crochet.setup()\n+        self.eventual = self.fetch_deferred()\n+\n+    def wait(self, timeout):\n+        \"\"\"Requests based implemention with timeout","path":"swaggerpy/http_client.py","position":69,"original_position":69,"commit_id":"6e60c4ca1f085745e1ff0e35d0d266b53542fead","original_commit_id":"6e60c4ca1f085745e1ff0e35d0d266b53542fead","user":{"login":"jnb","id":514311,"avatar_url":"https://avatars.githubusercontent.com/u/514311?","gravatar_id":"2cfcf0a6c5a34c24959a9bf8d129d6c2","url":"https://api.github.com/users/jnb","html_url":"https://github.com/jnb","followers_url":"https://api.github.com/users/jnb/followers","following_url":"https://api.github.com/users/jnb/following{/other_user}","gists_url":"https://api.github.com/users/jnb/gists{/gist_id}","starred_url":"https://api.github.com/users/jnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnb/subscriptions","organizations_url":"https://api.github.com/users/jnb/orgs","repos_url":"https://api.github.com/users/jnb/repos","events_url":"https://api.github.com/users/jnb/events{/privacy}","received_events_url":"https://api.github.com/users/jnb/received_events","type":"User","site_admin":false},"body":"Is the 'requests' thing a typo?","created_at":"2014-06-27T23:33:13Z","updated_at":"2014-06-27T23:33:13Z","html_url":"https://github.com/Yelp/swagger-py/pull/5#discussion_r14320032","pull_request_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/14320032"},"html":{"href":"https://github.com/Yelp/swagger-py/pull/5#discussion_r14320032"},"pull_request":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/swagger-py/pulls/5","id":17672650,"html_url":"https://github.com/Yelp/swagger-py/pull/5","diff_url":"https://github.com/Yelp/swagger-py/pull/5.diff","patch_url":"https://github.com/Yelp/swagger-py/pull/5.patch","issue_url":"https://api.github.com/repos/Yelp/swagger-py/issues/5","number":5,"state":"open","title":"Async http addition","user":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?","gravatar_id":"c347f19cf8175355f6d2433a53ba15a5","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"body":"* Addition of AsynchronousHTTPClient and AsyncResponse class\r\n\r\n```\r\nrunning nosetests\r\nrunning egg_info\r\nwriting requirements to swaggerpy.egg-info/requires.txt\r\nwriting swaggerpy.egg-info/PKG-INFO\r\nwriting top-level names to swaggerpy.egg-info/top_level.txt\r\nwriting dependency_links to swaggerpy.egg-info/dependency_links.txt\r\nwriting entry points to swaggerpy.egg-info/entry_points.txt\r\nwriting requirements to swaggerpy.egg-info/requires.txt\r\nwriting swaggerpy.egg-info/PKG-INFO\r\nwriting top-level names to swaggerpy.egg-info/top_level.txt\r\nwriting dependency_links to swaggerpy.egg-info/dependency_links.txt\r\nwriting entry points to swaggerpy.egg-info/entry_points.txt\r\nreading manifest file 'swaggerpy.egg-info/SOURCES.txt'\r\nreading manifest template 'MANIFEST.in'\r\nwriting manifest file 'swaggerpy.egg-info/SOURCES.txt'\r\n/nail/home/prateek/pg/mypy/lib/python2.6/site-packages/twisted/internet/endpoints.py:30: DeprecationWarning: twisted.internet.interfaces.IStreamClientEndpointStringParser was deprecated in Twisted 14.0.0: This interface has been superseded by IStreamClientEndpointStringParserWithReactor.\r\n  from twisted.internet.interfaces import (\r\n/nail/home/prateek/pg/mypy/lib/python2.6/site-packages/twisted/internet/_sslverify.py:184: UserWarning: Your version of pyOpenSSL, 0.10, is out of date.  Please upgrade to at least 0.12 and install service_identity from <https://pypi.python.org/pypi/service_identity>. Without the service_identity module and a recent enough pyOpenSSL tosupport it, Twisted can perform only rudimentary TLS client hostnameverification.  Many valid certificate/hostname mappings may be rejected.\r\n  verifyHostname, VerificationError = _selectVerifyImplementation()\r\n................................................................................\r\n----------------------------------------------------------------------\r\nRan 80 tests in 0.537s\r\n\r\nOK\r\n```","created_at":"2014-06-26T21:00:13Z","updated_at":"2014-06-27T23:33:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ef0b4d1348d94d1db7f2ba57b0c0727612719cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Yelp/swagger-py/issues/5/comments","statuses_url":"https://api.github.com/repos/Yelp/swagger-py/statuses/6e60c4ca1f085745e1ff0e35d0d266b53542fead","head":{"label":"Yelp:AsyncHTTPaddition","ref":"AsyncHTTPaddition","sha":"6e60c4ca1f085745e1ff0e35d0d266b53542fead","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?","gravatar_id":"cedaa6f42505b701ae74f53ea1783c0b","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":20313056,"name":"swagger-py","full_name":"Yelp/swagger-py","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?","gravatar_id":"cedaa6f42505b701ae74f53ea1783c0b","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/swagger-py","description":"Swagger client library for Python - modified for Py2.6 and Swagger 1.1 (older) spec","fork":false,"url":"https://api.github.com/repos/Yelp/swagger-py","forks_url":"https://api.github.com/repos/Yelp/swagger-py/forks","keys_url":"https://api.github.com/repos/Yelp/swagger-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/swagger-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/swagger-py/teams","hooks_url":"https://api.github.com/repos/Yelp/swagger-py/hooks","issue_events_url":"https://api.github.com/repos/Yelp/swagger-py/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/swagger-py/events","assignees_url":"https://api.github.com/repos/Yelp/swagger-py/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/swagger-py/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/swagger-py/tags","blobs_url":"https://api.github.com/repos/Yelp/swagger-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/swagger-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/swagger-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/swagger-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/swagger-py/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/swagger-py/languages","stargazers_url":"https://api.github.com/repos/Yelp/swagger-py/stargazers","contributors_url":"https://api.github.com/repos/Yelp/swagger-py/contributors","subscribers_url":"https://api.github.com/repos/Yelp/swagger-py/subscribers","subscription_url":"https://api.github.com/repos/Yelp/swagger-py/subscription","commits_url":"https://api.github.com/repos/Yelp/swagger-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/swagger-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/swagger-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/swagger-py/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yelp/swagger-py/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/swagger-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/swagger-py/merges","archive_url":"https://api.github.com/repos/Yelp/swagger-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/swagger-py/downloads","issues_url":"https://api.github.com/repos/Yelp/swagger-py/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/swagger-py/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/swagger-py/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/swagger-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/swagger-py/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/swagger-py/releases{/id}","created_at":"2014-05-30T01:03:02Z","updated_at":"2014-06-25T23:42:47Z","pushed_at":"2014-06-26T22:20:12Z","git_url":"git://github.com/Yelp/swagger-py.git","ssh_url":"git@github.com:Yelp/swagger-py.git","clone_url":"https://github.com/Yelp/swagger-py.git","svn_url":"https://github.com/Yelp/swagger-py","homepage":"","size":731,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"Yelp:FutureResponse_v1","ref":"FutureResponse_v1","sha":"d2e79a840c9ca05639fdc31db2dce59725b10aea","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?","gravatar_id":"cedaa6f42505b701ae74f53ea1783c0b","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":20313056,"name":"swagger-py","full_name":"Yelp/swagger-py","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?","gravatar_id":"cedaa6f42505b701ae74f53ea1783c0b","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/swagger-py","description":"Swagger client library for Python - modified for Py2.6 and Swagger 1.1 (older) spec","fork":false,"url":"https://api.github.com/repos/Yelp/swagger-py","forks_url":"https://api.github.com/repos/Yelp/swagger-py/forks","keys_url":"https://api.github.com/repos/Yelp/swagger-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/swagger-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/swagger-py/teams","hooks_url":"https://api.github.com/repos/Yelp/swagger-py/hooks","issue_events_url":"https://api.github.com/repos/Yelp/swagger-py/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/swagger-py/events","assignees_url":"https://api.github.com/repos/Yelp/swagger-py/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/swagger-py/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/swagger-py/tags","blobs_url":"https://api.github.com/repos/Yelp/swagger-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/swagger-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/swagger-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/swagger-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/swagger-py/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/swagger-py/languages","stargazers_url":"https://api.github.com/repos/Yelp/swagger-py/stargazers","contributors_url":"https://api.github.com/repos/Yelp/swagger-py/contributors","subscribers_url":"https://api.github.com/repos/Yelp/swagger-py/subscribers","subscription_url":"https://api.github.com/repos/Yelp/swagger-py/subscription","commits_url":"https://api.github.com/repos/Yelp/swagger-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/swagger-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/swagger-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/swagger-py/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yelp/swagger-py/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/swagger-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/swagger-py/merges","archive_url":"https://api.github.com/repos/Yelp/swagger-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/swagger-py/downloads","issues_url":"https://api.github.com/repos/Yelp/swagger-py/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/swagger-py/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/swagger-py/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/swagger-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/swagger-py/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/swagger-py/releases{/id}","created_at":"2014-05-30T01:03:02Z","updated_at":"2014-06-25T23:42:47Z","pushed_at":"2014-06-26T22:20:12Z","git_url":"git://github.com/Yelp/swagger-py.git","ssh_url":"git@github.com:Yelp/swagger-py.git","clone_url":"https://github.com/Yelp/swagger-py.git","svn_url":"https://github.com/Yelp/swagger-py","homepage":"","size":731,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/5"},"html":{"href":"https://github.com/Yelp/swagger-py/pull/5"},"issue":{"href":"https://api.github.com/repos/Yelp/swagger-py/issues/5"},"comments":{"href":"https://api.github.com/repos/Yelp/swagger-py/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/swagger-py/statuses/6e60c4ca1f085745e1ff0e35d0d266b53542fead"}}}}