GitHub PullRequestReviewCommentEvent at 2014-07-31 21:43:24
Repository: kubernetes
Actor: lavalamp
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/15672011","id":15672011,"diff_hunk":"@@ -0,0 +1,223 @@\n+/*\n+Copyright 2014 Google Inc. All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package conversion\n+\n+import (\n+\t\"fmt\"\n+\t\"reflect\"\n+\n+\t\"gopkg.in/v1/yaml\"\n+)\n+\n+// MetaInsertionFactory is used to create an object to store and retrieve\n+// the version and kind information for all objects. The default uses the\n+// keys \"apiVersion\" and \"kind\" respectively. The object produced by this","path":"pkg/conversion/scheme.go","position":28,"original_position":28,"commit_id":"dcec689e0711501cee66259b277c50ad7d2ce78f","original_commit_id":"dcec689e0711501cee66259b277c50ad7d2ce78f","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=1","gravatar_id":"1a843544abcf9f764d28e3427a4a9610","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"body":"SGTM, will do.","created_at":"2014-07-31T21:43:24Z","updated_at":"2014-07-31T21:43:24Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/723#discussion_r15672011","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/723","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/15672011"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/723#discussion_r15672011"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/723","id":19172197,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/723","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/723.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/723.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/723","number":723,"state":"open","title":"Split api package.","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=1","gravatar_id":"1a843544abcf9f764d28e3427a4a9610","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"body":"This change moves all of the generic functionality out of pkg/api and into pkg/conversion. This is one of the steps necessary to making #700 a reality.\r\n\r\nNo functionality is changed, even though it's a lot of code changes. In particular, the api package tests all still pass unchanged.\r\n\r\nI feel like after we do this, we can refocuse the api package--move a bunch of stuff from tools into api, for example.","created_at":"2014-07-31T19:14:46Z","updated_at":"2014-07-31T21:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e06ac216d25929b5d620f59b58a5f3bb0e5848a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/723/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/723/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/723/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/dcec689e0711501cee66259b277c50ad7d2ce78f","head":{"label":"lavalamp:splitApi","ref":"splitApi","sha":"dcec689e0711501cee66259b277c50ad7d2ce78f","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=1","gravatar_id":"1a843544abcf9f764d28e3427a4a9610","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"repo":{"id":20749157,"name":"kubernetes","full_name":"lavalamp/kubernetes","owner":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=1","gravatar_id":"1a843544abcf9f764d28e3427a4a9610","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lavalamp/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/lavalamp/kubernetes","forks_url":"https://api.github.com/repos/lavalamp/kubernetes/forks","keys_url":"https://api.github.com/repos/lavalamp/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lavalamp/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lavalamp/kubernetes/teams","hooks_url":"https://api.github.com/repos/lavalamp/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/lavalamp/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/lavalamp/kubernetes/events","assignees_url":"https://api.github.com/repos/lavalamp/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/lavalamp/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/lavalamp/kubernetes/tags","blobs_url":"https://api.github.com/repos/lavalamp/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lavalamp/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lavalamp/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/lavalamp/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lavalamp/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/lavalamp/kubernetes/languages","stargazers_url":"https://api.github.com/repos/lavalamp/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/lavalamp/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/lavalamp/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/lavalamp/kubernetes/subscription","commits_url":"https://api.github.com/repos/lavalamp/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/lavalamp/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/lavalamp/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/lavalamp/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/lavalamp/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/lavalamp/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lavalamp/kubernetes/merges","archive_url":"https://api.github.com/repos/lavalamp/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lavalamp/kubernetes/downloads","issues_url":"https://api.github.com/repos/lavalamp/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/lavalamp/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/lavalamp/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/lavalamp/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lavalamp/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/lavalamp/kubernetes/releases{/id}","created_at":"2014-06-12T00:36:13Z","updated_at":"2014-07-15T22:39:06Z","pushed_at":"2014-07-31T19:10:52Z","git_url":"git://github.com/lavalamp/kubernetes.git","ssh_url":"git@github.com:lavalamp/kubernetes.git","clone_url":"https://github.com/lavalamp/kubernetes.git","svn_url":"https://github.com/lavalamp/kubernetes","homepage":null,"size":9172,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"28d42a79a4c21a7977192529dd4034d8a7f8a644","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=1","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=1","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-07-31T21:41:55Z","pushed_at":"2014-07-31T21:34:09Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":17860,"stargazers_count":2842,"watchers_count":2842,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":338,"mirror_url":null,"open_issues_count":137,"forks":338,"open_issues":137,"watchers":2842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/723"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/723"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/723"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/dcec689e0711501cee66259b277c50ad7d2ce78f"}}}}