GitHub PullRequestReviewCommentEvent at 2014-08-31 02:55:52
Repository: citra
Actor: yuriks
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/16932816","id":16932816,"diff_hunk":"@@ -127,25 +131,25 @@ void Init();\n void Shutdown();\n \n template <typename T>\n-inline void Read(T &var, const u32 addr);\n+inline void Read(T &var, VAddr addr);","path":"src/core/mem_map.h","position":16,"original_position":16,"commit_id":"d828e164cecd162af65152fc6823670422360ebc","original_commit_id":"d828e164cecd162af65152fc6823670422360ebc","user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=2","gravatar_id":"5bfd65be96a3339f048963eeeee7dd2e","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"body":"I think my original idea was to remove const from all the declarations (since they don't do anything/are an implementation detail there) but I must've changed my mind.","created_at":"2014-08-31T02:55:52Z","updated_at":"2014-08-31T02:55:52Z","html_url":"https://github.com/citra-emu/citra/pull/82#discussion_r16932816","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/16932816"},"html":{"href":"https://github.com/citra-emu/citra/pull/82#discussion_r16932816"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/82","id":20458464,"html_url":"https://github.com/citra-emu/citra/pull/82","diff_url":"https://github.com/citra-emu/citra/pull/82.diff","patch_url":"https://github.com/citra-emu/citra/pull/82.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/82","number":82,"state":"open","locked":false,"title":"Introduce VAddr and PAddr typedefs for ARM addresses.","user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=2","gravatar_id":"5bfd65be96a3339f048963eeeee7dd2e","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"body":"This is more of a RFC than a PR proper. I think something like this would be interesting to have to clearly distinguish the addressing spaces (which are ambiguous in some functions.) Right now the entire code just uses u32 for addresses, which makes it non-obvious when something's supposed to be an address or not. I'm not enamored with the names, but would like to know if people think this is a worthwhile idea.","created_at":"2014-08-28T18:44:24Z","updated_at":"2014-08-31T02:55:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10ec6266dd82faacc15ecaa4f83224bdf2084498","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/82/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/82/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/82/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/d828e164cecd162af65152fc6823670422360ebc","head":{"label":"yuriks:addr-types","ref":"addr-types","sha":"d828e164cecd162af65152fc6823670422360ebc","user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=2","gravatar_id":"5bfd65be96a3339f048963eeeee7dd2e","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"repo":{"id":22018631,"name":"citra","full_name":"yuriks/citra","owner":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=2","gravatar_id":"5bfd65be96a3339f048963eeeee7dd2e","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuriks/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/yuriks/citra","forks_url":"https://api.github.com/repos/yuriks/citra/forks","keys_url":"https://api.github.com/repos/yuriks/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuriks/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuriks/citra/teams","hooks_url":"https://api.github.com/repos/yuriks/citra/hooks","issue_events_url":"https://api.github.com/repos/yuriks/citra/issues/events{/number}","events_url":"https://api.github.com/repos/yuriks/citra/events","assignees_url":"https://api.github.com/repos/yuriks/citra/assignees{/user}","branches_url":"https://api.github.com/repos/yuriks/citra/branches{/branch}","tags_url":"https://api.github.com/repos/yuriks/citra/tags","blobs_url":"https://api.github.com/repos/yuriks/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuriks/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuriks/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuriks/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuriks/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/yuriks/citra/languages","stargazers_url":"https://api.github.com/repos/yuriks/citra/stargazers","contributors_url":"https://api.github.com/repos/yuriks/citra/contributors","subscribers_url":"https://api.github.com/repos/yuriks/citra/subscribers","subscription_url":"https://api.github.com/repos/yuriks/citra/subscription","commits_url":"https://api.github.com/repos/yuriks/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuriks/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuriks/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuriks/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/yuriks/citra/contents/{+path}","compare_url":"https://api.github.com/repos/yuriks/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuriks/citra/merges","archive_url":"https://api.github.com/repos/yuriks/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuriks/citra/downloads","issues_url":"https://api.github.com/repos/yuriks/citra/issues{/number}","pulls_url":"https://api.github.com/repos/yuriks/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/yuriks/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/yuriks/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuriks/citra/labels{/name}","releases_url":"https://api.github.com/repos/yuriks/citra/releases{/id}","created_at":"2014-07-19T20:23:37Z","updated_at":"2014-08-28T18:42:13Z","pushed_at":"2014-08-31T01:36:27Z","git_url":"git://github.com/yuriks/citra.git","ssh_url":"git@github.com:yuriks/citra.git","clone_url":"https://github.com/yuriks/citra.git","svn_url":"https://github.com/yuriks/citra","homepage":null,"size":4551,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"7122c46937b2382879de4fbee1c3eaf50c9c35b4","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":null,"url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":null,"url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2014-08-31T00:57:42Z","pushed_at":"2014-08-28T22:18:21Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":7584,"stargazers_count":176,"watchers_count":176,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":48,"mirror_url":null,"open_issues_count":10,"forks":48,"open_issues":10,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/82"},"html":{"href":"https://github.com/citra-emu/citra/pull/82"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/82"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/d828e164cecd162af65152fc6823670422360ebc"}}}}