GitHub PullRequestEvent at 2014-12-17 22:03:40
Repository: manageiq
Actor: jrafanie
Payload: {"action":"closed","number":1253,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1253","id":26247177,"html_url":"https://github.com/ManageIQ/manageiq/pull/1253","diff_url":"https://github.com/ManageIQ/manageiq/pull/1253.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1253.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1253","number":1253,"state":"closed","locked":false,"title":"Use more descriptive assertions","user":{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false},"body":"The previous spelling:\r\n\r\n```\r\nxs.select { ..something.. }.should_not be_empty\r\n```\r\n\r\ncan only fail when the filtered collection *is* empty. Which means the failure message is... less than helpful.\r\n\r\nBy using `.should include(..)`, when it fails, we're shown what *was* in there. This makes it much easier to work out why the particular expected value is absent.\r\n\r\nThe same issue doesn't apply to `.should be_empty`, but I've changed the two instances of that for symmetry.\r\n\r\n---\r\n\r\nBefore:\r\n\r\n```\r\n  1) MiqExpression.model_details with :typ=>tag VmCloud\r\n     Failure/Error: result.select { |r| r.first == \"Instance.My Company Tags : Auto Approve - Max CPU\" }.should_not be_empty\r\n       expected empty? to return false, got true\r\n     # ./spec/models/miq_expression/model_details_spec.rb:31:in `block (4 levels) in <top (required)>'\r\n```\r\n\r\nAfter:\r\n\r\n```\r\n  1) MiqExpression.model_details with :typ=>tag VmCloud\r\n     Failure/Error: result.map(&:first).should include(\"Instance.My Company Tags : Auto Approve - Max CPU\")\r\n       expected [\"Vm Cloud.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.Cloud/Infrastructure Provider.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.Cluster.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.Datastore.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.Host.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.Miq Group.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.Repository.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.Resource Pool.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.Service.My Company Tags : Auto Approve - Max CPU\", \"Vm Cloud.User.My Company Tags : Auto Approve - Max CPU\"] to include \"Instance.My Company Tags : Auto Approve - Max CPU\"\r\n     # ./spec/models/miq_expression/model_details_spec.rb:31:in `block (4 levels) in <top (required)>'\r\n```","created_at":"2014-12-17T18:54:47Z","updated_at":"2014-12-17T22:03:39Z","closed_at":"2014-12-17T22:03:39Z","merged_at":"2014-12-17T22:03:39Z","merge_commit_sha":"23ed56488405f26d30aae5eb7e62e55b0d3ab237","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1253/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1253/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1253/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/6ee33197314a0c5e63d29f5dd484fcac751e0493","head":{"label":"matthewd:select-empty","ref":"select-empty","sha":"6ee33197314a0c5e63d29f5dd484fcac751e0493","user":{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false},"repo":{"id":24419300,"name":"manageiq","full_name":"matthewd/manageiq","owner":{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewd/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/matthewd/manageiq","forks_url":"https://api.github.com/repos/matthewd/manageiq/forks","keys_url":"https://api.github.com/repos/matthewd/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewd/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewd/manageiq/teams","hooks_url":"https://api.github.com/repos/matthewd/manageiq/hooks","issue_events_url":"https://api.github.com/repos/matthewd/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/matthewd/manageiq/events","assignees_url":"https://api.github.com/repos/matthewd/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/matthewd/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/matthewd/manageiq/tags","blobs_url":"https://api.github.com/repos/matthewd/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewd/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewd/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewd/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewd/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewd/manageiq/languages","stargazers_url":"https://api.github.com/repos/matthewd/manageiq/stargazers","contributors_url":"https://api.github.com/repos/matthewd/manageiq/contributors","subscribers_url":"https://api.github.com/repos/matthewd/manageiq/subscribers","subscription_url":"https://api.github.com/repos/matthewd/manageiq/subscription","commits_url":"https://api.github.com/repos/matthewd/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewd/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewd/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewd/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/matthewd/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/matthewd/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewd/manageiq/merges","archive_url":"https://api.github.com/repos/matthewd/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewd/manageiq/downloads","issues_url":"https://api.github.com/repos/matthewd/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/matthewd/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewd/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewd/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewd/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/matthewd/manageiq/releases{/id}","created_at":"2014-09-24T14:53:44Z","updated_at":"2014-09-23T19:24:45Z","pushed_at":"2014-12-17T18:20:01Z","git_url":"git://github.com/matthewd/manageiq.git","ssh_url":"git@github.com:matthewd/manageiq.git","clone_url":"https://github.com/matthewd/manageiq.git","svn_url":"https://github.com/matthewd/manageiq","homepage":"manageiq.org","size":60180,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"835f4675d5caea78f93f5af206ec9e6e6ca5c4f2","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2014-12-17T21:53:41Z","pushed_at":"2014-12-17T22:03:40Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":81667,"stargazers_count":71,"watchers_count":71,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":204,"forks":79,"open_issues":204,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1253"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1253"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1253"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1253/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1253/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1253/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/6ee33197314a0c5e63d29f5dd484fcac751e0493"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":14,"deletions":14,"changed_files":2}}