GitHub PullRequestReviewCommentEvent at 2014-05-13 20:54:48
Repository: webmaker-events-2
Actor: jbuck
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/webmaker-events-2/pulls/comments/12608129","id":12608129,"diff_hunk":"@@ -173,13 +173,14 @@ angular.module('myApp.controllers', [])\n       });\n     }\n   ])\n-  .controller('eventDetailController', ['$scope', '$http', '$routeParams', 'eventService', 'moment',\n-    function ($scope, $http, $routeParams, eventService, moment) {\n-\n+  .controller('eventDetailController', ['$scope', '$http', '$routeParams', '$sanitize', 'eventService', 'moment',\n+    function ($scope, $http, $routeParams, $sanitize, eventService, moment) {\n       eventService.get({\n         id: $routeParams.id,\n       }, function (data) {\n \n+        data.description = $sanitize(data.description);","path":"app/js/controllers.js","position":13,"original_position":13,"commit_id":"d90bac65afba6740aa15ff04ed7672677403c814","original_commit_id":"d90bac65afba6740aa15ff04ed7672677403c814","user":{"login":"jbuck","id":578466,"avatar_url":"https://avatars.githubusercontent.com/u/578466?","gravatar_id":"7fc0a83242c7c0d724124a7a0536ee38","url":"https://api.github.com/users/jbuck","html_url":"https://github.com/jbuck","followers_url":"https://api.github.com/users/jbuck/followers","following_url":"https://api.github.com/users/jbuck/following{/other_user}","gists_url":"https://api.github.com/users/jbuck/gists{/gist_id}","starred_url":"https://api.github.com/users/jbuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbuck/subscriptions","organizations_url":"https://api.github.com/users/jbuck/orgs","repos_url":"https://api.github.com/users/jbuck/repos","events_url":"https://api.github.com/users/jbuck/events{/privacy}","received_events_url":"https://api.github.com/users/jbuck/received_events","type":"User","site_admin":false},"body":"So the reason that description needed sanitization was because we explictly called $sce.trustAsHtml() in the markdown filter. Now that we're not calling that, do we need to actually explictly sanitize it here?","created_at":"2014-05-13T20:54:48Z","updated_at":"2014-05-13T20:54:48Z","html_url":"https://github.com/mozilla/webmaker-events-2/pull/85#discussion_r12608129","pull_request_url":"https://api.github.com/repos/mozilla/webmaker-events-2/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/mozilla/webmaker-events-2/pulls/comments/12608129"},"html":{"href":"https://github.com/mozilla/webmaker-events-2/pull/85#discussion_r12608129"},"pull_request":{"href":"https://api.github.com/repos/mozilla/webmaker-events-2/pulls/85"}}}}