GitHub PullRequestReviewCommentEvent at 2014-12-13 20:50:38
Repository: raco
Actor: stechu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/uwescience/raco/pulls/comments/21791148","id":21791148,"diff_hunk":"@@ -329,6 +329,13 @@ def store(self, op):\n         self.tables.add_table(op.relation_key, scheme, self.evaluate(op.input))\n         return None\n \n+    def sink(self, op):\n+        scheme = op.input.scheme()\n+        self.tables.add_table(\n+            relation_key.RelationKey(\"OUTPUT\"),","path":"raco/fakedb.py","position":7,"original_position":7,"commit_id":"49b63d1a635f4dd858799f0b627aa7c4a25a7542","original_commit_id":"49b63d1a635f4dd858799f0b627aa7c4a25a7542","user":{"login":"stechu","id":720571,"avatar_url":"https://avatars.githubusercontent.com/u/720571?v=3","gravatar_id":"","url":"https://api.github.com/users/stechu","html_url":"https://github.com/stechu","followers_url":"https://api.github.com/users/stechu/followers","following_url":"https://api.github.com/users/stechu/following{/other_user}","gists_url":"https://api.github.com/users/stechu/gists{/gist_id}","starred_url":"https://api.github.com/users/stechu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stechu/subscriptions","organizations_url":"https://api.github.com/users/stechu/orgs","repos_url":"https://api.github.com/users/stechu/repos","events_url":"https://api.github.com/users/stechu/events{/privacy}","received_events_url":"https://api.github.com/users/stechu/received_events","type":"User","site_admin":false},"body":"Because  https://github.com/uwescience/raco/blob/master/raco/myrial/myrial_test.py#L69 assumes that. It is semi-reasonable because this can test whether a sink operator throws is a valid tuple or not. ","created_at":"2014-12-13T20:50:38Z","updated_at":"2014-12-13T20:50:38Z","html_url":"https://github.com/uwescience/raco/pull/377#discussion_r21791148","pull_request_url":"https://api.github.com/repos/uwescience/raco/pulls/377","_links":{"self":{"href":"https://api.github.com/repos/uwescience/raco/pulls/comments/21791148"},"html":{"href":"https://github.com/uwescience/raco/pull/377#discussion_r21791148"},"pull_request":{"href":"https://api.github.com/repos/uwescience/raco/pulls/377"}}},"pull_request":{"url":"https://api.github.com/repos/uwescience/raco/pulls/377","id":26018907,"html_url":"https://github.com/uwescience/raco/pull/377","diff_url":"https://github.com/uwescience/raco/pull/377.diff","patch_url":"https://github.com/uwescience/raco/pull/377.patch","issue_url":"https://api.github.com/repos/uwescience/raco/issues/377","number":377,"state":"open","locked":false,"title":"Add sink operator","user":{"login":"stechu","id":720571,"avatar_url":"https://avatars.githubusercontent.com/u/720571?v=3","gravatar_id":"","url":"https://api.github.com/users/stechu","html_url":"https://github.com/stechu","followers_url":"https://api.github.com/users/stechu/followers","following_url":"https://api.github.com/users/stechu/following{/other_user}","gists_url":"https://api.github.com/users/stechu/gists{/gist_id}","starred_url":"https://api.github.com/users/stechu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stechu/subscriptions","organizations_url":"https://api.github.com/users/stechu/orgs","repos_url":"https://api.github.com/users/stechu/repos","events_url":"https://api.github.com/users/stechu/events{/privacy}","received_events_url":"https://api.github.com/users/stechu/received_events","type":"User","site_admin":false},"body":"fixes #376 ","created_at":"2014-12-13T08:23:59Z","updated_at":"2014-12-13T20:50:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e0441f8bf07c1fd2158e839b366f0d95868272","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uwescience/raco/pulls/377/commits","review_comments_url":"https://api.github.com/repos/uwescience/raco/pulls/377/comments","review_comment_url":"https://api.github.com/repos/uwescience/raco/pulls/comments/{number}","comments_url":"https://api.github.com/repos/uwescience/raco/issues/377/comments","statuses_url":"https://api.github.com/repos/uwescience/raco/statuses/49b63d1a635f4dd858799f0b627aa7c4a25a7542","head":{"label":"uwescience:shumo_add_sink_operator","ref":"shumo_add_sink_operator","sha":"49b63d1a635f4dd858799f0b627aa7c4a25a7542","user":{"login":"uwescience","id":2243113,"avatar_url":"https://avatars.githubusercontent.com/u/2243113?v=3","gravatar_id":"","url":"https://api.github.com/users/uwescience","html_url":"https://github.com/uwescience","followers_url":"https://api.github.com/users/uwescience/followers","following_url":"https://api.github.com/users/uwescience/following{/other_user}","gists_url":"https://api.github.com/users/uwescience/gists{/gist_id}","starred_url":"https://api.github.com/users/uwescience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwescience/subscriptions","organizations_url":"https://api.github.com/users/uwescience/orgs","repos_url":"https://api.github.com/users/uwescience/repos","events_url":"https://api.github.com/users/uwescience/events{/privacy}","received_events_url":"https://api.github.com/users/uwescience/received_events","type":"Organization","site_admin":false},"repo":{"id":6326372,"name":"raco","full_name":"uwescience/raco","owner":{"login":"uwescience","id":2243113,"avatar_url":"https://avatars.githubusercontent.com/u/2243113?v=3","gravatar_id":"","url":"https://api.github.com/users/uwescience","html_url":"https://github.com/uwescience","followers_url":"https://api.github.com/users/uwescience/followers","following_url":"https://api.github.com/users/uwescience/following{/other_user}","gists_url":"https://api.github.com/users/uwescience/gists{/gist_id}","starred_url":"https://api.github.com/users/uwescience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwescience/subscriptions","organizations_url":"https://api.github.com/users/uwescience/orgs","repos_url":"https://api.github.com/users/uwescience/repos","events_url":"https://api.github.com/users/uwescience/events{/privacy}","received_events_url":"https://api.github.com/users/uwescience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwescience/raco","description":"Compilation and rule-based optimization framework for datalog.  Includes an RA compiler.","fork":false,"url":"https://api.github.com/repos/uwescience/raco","forks_url":"https://api.github.com/repos/uwescience/raco/forks","keys_url":"https://api.github.com/repos/uwescience/raco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwescience/raco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwescience/raco/teams","hooks_url":"https://api.github.com/repos/uwescience/raco/hooks","issue_events_url":"https://api.github.com/repos/uwescience/raco/issues/events{/number}","events_url":"https://api.github.com/repos/uwescience/raco/events","assignees_url":"https://api.github.com/repos/uwescience/raco/assignees{/user}","branches_url":"https://api.github.com/repos/uwescience/raco/branches{/branch}","tags_url":"https://api.github.com/repos/uwescience/raco/tags","blobs_url":"https://api.github.com/repos/uwescience/raco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwescience/raco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwescience/raco/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwescience/raco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwescience/raco/statuses/{sha}","languages_url":"https://api.github.com/repos/uwescience/raco/languages","stargazers_url":"https://api.github.com/repos/uwescience/raco/stargazers","contributors_url":"https://api.github.com/repos/uwescience/raco/contributors","subscribers_url":"https://api.github.com/repos/uwescience/raco/subscribers","subscription_url":"https://api.github.com/repos/uwescience/raco/subscription","commits_url":"https://api.github.com/repos/uwescience/raco/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwescience/raco/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwescience/raco/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwescience/raco/issues/comments/{number}","contents_url":"https://api.github.com/repos/uwescience/raco/contents/{+path}","compare_url":"https://api.github.com/repos/uwescience/raco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwescience/raco/merges","archive_url":"https://api.github.com/repos/uwescience/raco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwescience/raco/downloads","issues_url":"https://api.github.com/repos/uwescience/raco/issues{/number}","pulls_url":"https://api.github.com/repos/uwescience/raco/pulls{/number}","milestones_url":"https://api.github.com/repos/uwescience/raco/milestones{/number}","notifications_url":"https://api.github.com/repos/uwescience/raco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwescience/raco/labels{/name}","releases_url":"https://api.github.com/repos/uwescience/raco/releases{/id}","created_at":"2012-10-21T22:26:47Z","updated_at":"2014-12-13T18:17:43Z","pushed_at":"2014-12-13T18:18:34Z","git_url":"git://github.com/uwescience/raco.git","ssh_url":"git@github.com:uwescience/raco.git","clone_url":"https://github.com/uwescience/raco.git","svn_url":"https://github.com/uwescience/raco","homepage":null,"size":58386,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":63,"forks":4,"open_issues":63,"watchers":11,"default_branch":"master"}},"base":{"label":"uwescience:master","ref":"master","sha":"29e4257e9c28cb2ed9a0fb8b91683f7fad832add","user":{"login":"uwescience","id":2243113,"avatar_url":"https://avatars.githubusercontent.com/u/2243113?v=3","gravatar_id":"","url":"https://api.github.com/users/uwescience","html_url":"https://github.com/uwescience","followers_url":"https://api.github.com/users/uwescience/followers","following_url":"https://api.github.com/users/uwescience/following{/other_user}","gists_url":"https://api.github.com/users/uwescience/gists{/gist_id}","starred_url":"https://api.github.com/users/uwescience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwescience/subscriptions","organizations_url":"https://api.github.com/users/uwescience/orgs","repos_url":"https://api.github.com/users/uwescience/repos","events_url":"https://api.github.com/users/uwescience/events{/privacy}","received_events_url":"https://api.github.com/users/uwescience/received_events","type":"Organization","site_admin":false},"repo":{"id":6326372,"name":"raco","full_name":"uwescience/raco","owner":{"login":"uwescience","id":2243113,"avatar_url":"https://avatars.githubusercontent.com/u/2243113?v=3","gravatar_id":"","url":"https://api.github.com/users/uwescience","html_url":"https://github.com/uwescience","followers_url":"https://api.github.com/users/uwescience/followers","following_url":"https://api.github.com/users/uwescience/following{/other_user}","gists_url":"https://api.github.com/users/uwescience/gists{/gist_id}","starred_url":"https://api.github.com/users/uwescience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwescience/subscriptions","organizations_url":"https://api.github.com/users/uwescience/orgs","repos_url":"https://api.github.com/users/uwescience/repos","events_url":"https://api.github.com/users/uwescience/events{/privacy}","received_events_url":"https://api.github.com/users/uwescience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwescience/raco","description":"Compilation and rule-based optimization framework for datalog.  Includes an RA compiler.","fork":false,"url":"https://api.github.com/repos/uwescience/raco","forks_url":"https://api.github.com/repos/uwescience/raco/forks","keys_url":"https://api.github.com/repos/uwescience/raco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwescience/raco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwescience/raco/teams","hooks_url":"https://api.github.com/repos/uwescience/raco/hooks","issue_events_url":"https://api.github.com/repos/uwescience/raco/issues/events{/number}","events_url":"https://api.github.com/repos/uwescience/raco/events","assignees_url":"https://api.github.com/repos/uwescience/raco/assignees{/user}","branches_url":"https://api.github.com/repos/uwescience/raco/branches{/branch}","tags_url":"https://api.github.com/repos/uwescience/raco/tags","blobs_url":"https://api.github.com/repos/uwescience/raco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwescience/raco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwescience/raco/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwescience/raco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwescience/raco/statuses/{sha}","languages_url":"https://api.github.com/repos/uwescience/raco/languages","stargazers_url":"https://api.github.com/repos/uwescience/raco/stargazers","contributors_url":"https://api.github.com/repos/uwescience/raco/contributors","subscribers_url":"https://api.github.com/repos/uwescience/raco/subscribers","subscription_url":"https://api.github.com/repos/uwescience/raco/subscription","commits_url":"https://api.github.com/repos/uwescience/raco/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwescience/raco/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwescience/raco/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwescience/raco/issues/comments/{number}","contents_url":"https://api.github.com/repos/uwescience/raco/contents/{+path}","compare_url":"https://api.github.com/repos/uwescience/raco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwescience/raco/merges","archive_url":"https://api.github.com/repos/uwescience/raco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwescience/raco/downloads","issues_url":"https://api.github.com/repos/uwescience/raco/issues{/number}","pulls_url":"https://api.github.com/repos/uwescience/raco/pulls{/number}","milestones_url":"https://api.github.com/repos/uwescience/raco/milestones{/number}","notifications_url":"https://api.github.com/repos/uwescience/raco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwescience/raco/labels{/name}","releases_url":"https://api.github.com/repos/uwescience/raco/releases{/id}","created_at":"2012-10-21T22:26:47Z","updated_at":"2014-12-13T18:17:43Z","pushed_at":"2014-12-13T18:18:34Z","git_url":"git://github.com/uwescience/raco.git","ssh_url":"git@github.com:uwescience/raco.git","clone_url":"https://github.com/uwescience/raco.git","svn_url":"https://github.com/uwescience/raco","homepage":null,"size":58386,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":63,"forks":4,"open_issues":63,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uwescience/raco/pulls/377"},"html":{"href":"https://github.com/uwescience/raco/pull/377"},"issue":{"href":"https://api.github.com/repos/uwescience/raco/issues/377"},"comments":{"href":"https://api.github.com/repos/uwescience/raco/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/uwescience/raco/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/uwescience/raco/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/uwescience/raco/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/uwescience/raco/statuses/49b63d1a635f4dd858799f0b627aa7c4a25a7542"}}}}