GitHub PullRequestEvent at 2014-11-17 17:19:11
Repository: angular-permission
Actor: ankri
Payload: {"action":"opened","number":19,"pull_request":{"url":"https://api.github.com/repos/Narzerus/angular-permission/pulls/19","id":24551198,"html_url":"https://github.com/Narzerus/angular-permission/pull/19","diff_url":"https://github.com/Narzerus/angular-permission/pull/19.diff","patch_url":"https://github.com/Narzerus/angular-permission/pull/19.patch","issue_url":"https://api.github.com/repos/Narzerus/angular-permission/issues/19","number":19,"state":"open","locked":false,"title":"Test fix","user":{"login":"ankri","id":2842920,"avatar_url":"https://avatars.githubusercontent.com/u/2842920?v=3","gravatar_id":"","url":"https://api.github.com/users/ankri","html_url":"https://github.com/ankri","followers_url":"https://api.github.com/users/ankri/followers","following_url":"https://api.github.com/users/ankri/following{/other_user}","gists_url":"https://api.github.com/users/ankri/gists{/gist_id}","starred_url":"https://api.github.com/users/ankri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankri/subscriptions","organizations_url":"https://api.github.com/users/ankri/orgs","repos_url":"https://api.github.com/users/ankri/repos","events_url":"https://api.github.com/users/ankri/events{/privacy}","received_events_url":"https://api.github.com/users/ankri/received_events","type":"User","site_admin":false},"body":"I'm not exactly sure whether it was a bug in the test, or with UI Router because I don't know this part of UI-Router very well.\r\nThe isset parameter now gets converted to a String. I checked it was a Boolean as of 0.2.11. This is why the test doesn't work anymore.\r\n\r\nThis one works:\r\n```javascript\r\nPermissionProvider.defineRole('withParams', function(params) {\r\n  return params.isset === 'true';\r\n});\r\n```","created_at":"2014-11-17T17:19:11Z","updated_at":"2014-11-17T17:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Narzerus/angular-permission/pulls/19/commits","review_comments_url":"https://api.github.com/repos/Narzerus/angular-permission/pulls/19/comments","review_comment_url":"https://api.github.com/repos/Narzerus/angular-permission/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Narzerus/angular-permission/issues/19/comments","statuses_url":"https://api.github.com/repos/Narzerus/angular-permission/statuses/5bf45e3ab2191914f9c9a55bae703be324d86a78","head":{"label":"ankri:ui-router-update","ref":"ui-router-update","sha":"5bf45e3ab2191914f9c9a55bae703be324d86a78","user":{"login":"ankri","id":2842920,"avatar_url":"https://avatars.githubusercontent.com/u/2842920?v=3","gravatar_id":"","url":"https://api.github.com/users/ankri","html_url":"https://github.com/ankri","followers_url":"https://api.github.com/users/ankri/followers","following_url":"https://api.github.com/users/ankri/following{/other_user}","gists_url":"https://api.github.com/users/ankri/gists{/gist_id}","starred_url":"https://api.github.com/users/ankri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankri/subscriptions","organizations_url":"https://api.github.com/users/ankri/orgs","repos_url":"https://api.github.com/users/ankri/repos","events_url":"https://api.github.com/users/ankri/events{/privacy}","received_events_url":"https://api.github.com/users/ankri/received_events","type":"User","site_admin":false},"repo":{"id":25926756,"name":"angular-permission","full_name":"ankri/angular-permission","owner":{"login":"ankri","id":2842920,"avatar_url":"https://avatars.githubusercontent.com/u/2842920?v=3","gravatar_id":"","url":"https://api.github.com/users/ankri","html_url":"https://github.com/ankri","followers_url":"https://api.github.com/users/ankri/followers","following_url":"https://api.github.com/users/ankri/following{/other_user}","gists_url":"https://api.github.com/users/ankri/gists{/gist_id}","starred_url":"https://api.github.com/users/ankri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankri/subscriptions","organizations_url":"https://api.github.com/users/ankri/orgs","repos_url":"https://api.github.com/users/ankri/repos","events_url":"https://api.github.com/users/ankri/events{/privacy}","received_events_url":"https://api.github.com/users/ankri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ankri/angular-permission","description":"Simple route authorization via roles/permissions","fork":true,"url":"https://api.github.com/repos/ankri/angular-permission","forks_url":"https://api.github.com/repos/ankri/angular-permission/forks","keys_url":"https://api.github.com/repos/ankri/angular-permission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ankri/angular-permission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ankri/angular-permission/teams","hooks_url":"https://api.github.com/repos/ankri/angular-permission/hooks","issue_events_url":"https://api.github.com/repos/ankri/angular-permission/issues/events{/number}","events_url":"https://api.github.com/repos/ankri/angular-permission/events","assignees_url":"https://api.github.com/repos/ankri/angular-permission/assignees{/user}","branches_url":"https://api.github.com/repos/ankri/angular-permission/branches{/branch}","tags_url":"https://api.github.com/repos/ankri/angular-permission/tags","blobs_url":"https://api.github.com/repos/ankri/angular-permission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ankri/angular-permission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ankri/angular-permission/git/refs{/sha}","trees_url":"https://api.github.com/repos/ankri/angular-permission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ankri/angular-permission/statuses/{sha}","languages_url":"https://api.github.com/repos/ankri/angular-permission/languages","stargazers_url":"https://api.github.com/repos/ankri/angular-permission/stargazers","contributors_url":"https://api.github.com/repos/ankri/angular-permission/contributors","subscribers_url":"https://api.github.com/repos/ankri/angular-permission/subscribers","subscription_url":"https://api.github.com/repos/ankri/angular-permission/subscription","commits_url":"https://api.github.com/repos/ankri/angular-permission/commits{/sha}","git_commits_url":"https://api.github.com/repos/ankri/angular-permission/git/commits{/sha}","comments_url":"https://api.github.com/repos/ankri/angular-permission/comments{/number}","issue_comment_url":"https://api.github.com/repos/ankri/angular-permission/issues/comments/{number}","contents_url":"https://api.github.com/repos/ankri/angular-permission/contents/{+path}","compare_url":"https://api.github.com/repos/ankri/angular-permission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ankri/angular-permission/merges","archive_url":"https://api.github.com/repos/ankri/angular-permission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ankri/angular-permission/downloads","issues_url":"https://api.github.com/repos/ankri/angular-permission/issues{/number}","pulls_url":"https://api.github.com/repos/ankri/angular-permission/pulls{/number}","milestones_url":"https://api.github.com/repos/ankri/angular-permission/milestones{/number}","notifications_url":"https://api.github.com/repos/ankri/angular-permission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ankri/angular-permission/labels{/name}","releases_url":"https://api.github.com/repos/ankri/angular-permission/releases{/id}","created_at":"2014-10-29T15:15:15Z","updated_at":"2014-10-30T10:10:06Z","pushed_at":"2014-11-17T17:13:08Z","git_url":"git://github.com/ankri/angular-permission.git","ssh_url":"git@github.com:ankri/angular-permission.git","clone_url":"https://github.com/ankri/angular-permission.git","svn_url":"https://github.com/ankri/angular-permission","homepage":"","size":217,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Narzerus:master","ref":"master","sha":"33d1d485e29971421d73b4ada737a3525e24b0bf","user":{"login":"Narzerus","id":1808674,"avatar_url":"https://avatars.githubusercontent.com/u/1808674?v=3","gravatar_id":"","url":"https://api.github.com/users/Narzerus","html_url":"https://github.com/Narzerus","followers_url":"https://api.github.com/users/Narzerus/followers","following_url":"https://api.github.com/users/Narzerus/following{/other_user}","gists_url":"https://api.github.com/users/Narzerus/gists{/gist_id}","starred_url":"https://api.github.com/users/Narzerus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narzerus/subscriptions","organizations_url":"https://api.github.com/users/Narzerus/orgs","repos_url":"https://api.github.com/users/Narzerus/repos","events_url":"https://api.github.com/users/Narzerus/events{/privacy}","received_events_url":"https://api.github.com/users/Narzerus/received_events","type":"User","site_admin":false},"repo":{"id":23593647,"name":"angular-permission","full_name":"Narzerus/angular-permission","owner":{"login":"Narzerus","id":1808674,"avatar_url":"https://avatars.githubusercontent.com/u/1808674?v=3","gravatar_id":"","url":"https://api.github.com/users/Narzerus","html_url":"https://github.com/Narzerus","followers_url":"https://api.github.com/users/Narzerus/followers","following_url":"https://api.github.com/users/Narzerus/following{/other_user}","gists_url":"https://api.github.com/users/Narzerus/gists{/gist_id}","starred_url":"https://api.github.com/users/Narzerus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narzerus/subscriptions","organizations_url":"https://api.github.com/users/Narzerus/orgs","repos_url":"https://api.github.com/users/Narzerus/repos","events_url":"https://api.github.com/users/Narzerus/events{/privacy}","received_events_url":"https://api.github.com/users/Narzerus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Narzerus/angular-permission","description":"Simple route authorization via roles/permissions","fork":false,"url":"https://api.github.com/repos/Narzerus/angular-permission","forks_url":"https://api.github.com/repos/Narzerus/angular-permission/forks","keys_url":"https://api.github.com/repos/Narzerus/angular-permission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Narzerus/angular-permission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Narzerus/angular-permission/teams","hooks_url":"https://api.github.com/repos/Narzerus/angular-permission/hooks","issue_events_url":"https://api.github.com/repos/Narzerus/angular-permission/issues/events{/number}","events_url":"https://api.github.com/repos/Narzerus/angular-permission/events","assignees_url":"https://api.github.com/repos/Narzerus/angular-permission/assignees{/user}","branches_url":"https://api.github.com/repos/Narzerus/angular-permission/branches{/branch}","tags_url":"https://api.github.com/repos/Narzerus/angular-permission/tags","blobs_url":"https://api.github.com/repos/Narzerus/angular-permission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Narzerus/angular-permission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Narzerus/angular-permission/git/refs{/sha}","trees_url":"https://api.github.com/repos/Narzerus/angular-permission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Narzerus/angular-permission/statuses/{sha}","languages_url":"https://api.github.com/repos/Narzerus/angular-permission/languages","stargazers_url":"https://api.github.com/repos/Narzerus/angular-permission/stargazers","contributors_url":"https://api.github.com/repos/Narzerus/angular-permission/contributors","subscribers_url":"https://api.github.com/repos/Narzerus/angular-permission/subscribers","subscription_url":"https://api.github.com/repos/Narzerus/angular-permission/subscription","commits_url":"https://api.github.com/repos/Narzerus/angular-permission/commits{/sha}","git_commits_url":"https://api.github.com/repos/Narzerus/angular-permission/git/commits{/sha}","comments_url":"https://api.github.com/repos/Narzerus/angular-permission/comments{/number}","issue_comment_url":"https://api.github.com/repos/Narzerus/angular-permission/issues/comments/{number}","contents_url":"https://api.github.com/repos/Narzerus/angular-permission/contents/{+path}","compare_url":"https://api.github.com/repos/Narzerus/angular-permission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Narzerus/angular-permission/merges","archive_url":"https://api.github.com/repos/Narzerus/angular-permission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Narzerus/angular-permission/downloads","issues_url":"https://api.github.com/repos/Narzerus/angular-permission/issues{/number}","pulls_url":"https://api.github.com/repos/Narzerus/angular-permission/pulls{/number}","milestones_url":"https://api.github.com/repos/Narzerus/angular-permission/milestones{/number}","notifications_url":"https://api.github.com/repos/Narzerus/angular-permission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Narzerus/angular-permission/labels{/name}","releases_url":"https://api.github.com/repos/Narzerus/angular-permission/releases{/id}","created_at":"2014-09-02T20:02:07Z","updated_at":"2014-11-16T04:55:16Z","pushed_at":"2014-11-09T18:02:36Z","git_url":"git://github.com/Narzerus/angular-permission.git","ssh_url":"git@github.com:Narzerus/angular-permission.git","clone_url":"https://github.com/Narzerus/angular-permission.git","svn_url":"https://github.com/Narzerus/angular-permission","homepage":"","size":557,"stargazers_count":123,"watchers_count":123,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":7,"forks":14,"open_issues":7,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Narzerus/angular-permission/pulls/19"},"html":{"href":"https://github.com/Narzerus/angular-permission/pull/19"},"issue":{"href":"https://api.github.com/repos/Narzerus/angular-permission/issues/19"},"comments":{"href":"https://api.github.com/repos/Narzerus/angular-permission/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/Narzerus/angular-permission/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/Narzerus/angular-permission/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Narzerus/angular-permission/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/Narzerus/angular-permission/statuses/5bf45e3ab2191914f9c9a55bae703be324d86a78"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":531,"deletions":9,"changed_files":5}}