GitHub PullRequestEvent at 2014-12-22 08:49:08
Repository: assertj-core
Actor: hgcummings
Payload: {"action":"opened","number":304,"pull_request":{"url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/304","id":26444881,"html_url":"https://github.com/joel-costigliola/assertj-core/pull/304","diff_url":"https://github.com/joel-costigliola/assertj-core/pull/304.diff","patch_url":"https://github.com/joel-costigliola/assertj-core/pull/304.patch","issue_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/304","number":304,"state":"open","locked":false,"title":"Use platform-specific newlines when verifying error messages","user":{"login":"hgcummings","id":1159423,"avatar_url":"https://avatars.githubusercontent.com/u/1159423?v=3","gravatar_id":"","url":"https://api.github.com/users/hgcummings","html_url":"https://github.com/hgcummings","followers_url":"https://api.github.com/users/hgcummings/followers","following_url":"https://api.github.com/users/hgcummings/following{/other_user}","gists_url":"https://api.github.com/users/hgcummings/gists{/gist_id}","starred_url":"https://api.github.com/users/hgcummings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgcummings/subscriptions","organizations_url":"https://api.github.com/users/hgcummings/orgs","repos_url":"https://api.github.com/users/hgcummings/repos","events_url":"https://api.github.com/users/hgcummings/events{/privacy}","received_events_url":"https://api.github.com/users/hgcummings/received_events","type":"User","site_admin":false},"body":"A few tests were failing on a clean checkout on Windows due to comparing platform-specific newlines from the production code against Unix-style newlines in the test code. I've fixed this by using {{String.format}} with the {{%n}} format specifier. This is consistent with other existing tests.","created_at":"2014-12-22T08:49:08Z","updated_at":"2014-12-22T08:49:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/304/commits","review_comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/304/comments","review_comment_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/304/comments","statuses_url":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/3bbeeabc780b3e678698d23f31c79928bd1e7a04","head":{"label":"hgcummings:newlines","ref":"newlines","sha":"3bbeeabc780b3e678698d23f31c79928bd1e7a04","user":{"login":"hgcummings","id":1159423,"avatar_url":"https://avatars.githubusercontent.com/u/1159423?v=3","gravatar_id":"","url":"https://api.github.com/users/hgcummings","html_url":"https://github.com/hgcummings","followers_url":"https://api.github.com/users/hgcummings/followers","following_url":"https://api.github.com/users/hgcummings/following{/other_user}","gists_url":"https://api.github.com/users/hgcummings/gists{/gist_id}","starred_url":"https://api.github.com/users/hgcummings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgcummings/subscriptions","organizations_url":"https://api.github.com/users/hgcummings/orgs","repos_url":"https://api.github.com/users/hgcummings/repos","events_url":"https://api.github.com/users/hgcummings/events{/privacy}","received_events_url":"https://api.github.com/users/hgcummings/received_events","type":"User","site_admin":false},"repo":{"id":28330694,"name":"assertj-core","full_name":"hgcummings/assertj-core","owner":{"login":"hgcummings","id":1159423,"avatar_url":"https://avatars.githubusercontent.com/u/1159423?v=3","gravatar_id":"","url":"https://api.github.com/users/hgcummings","html_url":"https://github.com/hgcummings","followers_url":"https://api.github.com/users/hgcummings/followers","following_url":"https://api.github.com/users/hgcummings/following{/other_user}","gists_url":"https://api.github.com/users/hgcummings/gists{/gist_id}","starred_url":"https://api.github.com/users/hgcummings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgcummings/subscriptions","organizations_url":"https://api.github.com/users/hgcummings/orgs","repos_url":"https://api.github.com/users/hgcummings/repos","events_url":"https://api.github.com/users/hgcummings/events{/privacy}","received_events_url":"https://api.github.com/users/hgcummings/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hgcummings/assertj-core","description":"AssertJ is a library of assertions similar to fest-assert but providing a richer set of assertions.","fork":true,"url":"https://api.github.com/repos/hgcummings/assertj-core","forks_url":"https://api.github.com/repos/hgcummings/assertj-core/forks","keys_url":"https://api.github.com/repos/hgcummings/assertj-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hgcummings/assertj-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hgcummings/assertj-core/teams","hooks_url":"https://api.github.com/repos/hgcummings/assertj-core/hooks","issue_events_url":"https://api.github.com/repos/hgcummings/assertj-core/issues/events{/number}","events_url":"https://api.github.com/repos/hgcummings/assertj-core/events","assignees_url":"https://api.github.com/repos/hgcummings/assertj-core/assignees{/user}","branches_url":"https://api.github.com/repos/hgcummings/assertj-core/branches{/branch}","tags_url":"https://api.github.com/repos/hgcummings/assertj-core/tags","blobs_url":"https://api.github.com/repos/hgcummings/assertj-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hgcummings/assertj-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hgcummings/assertj-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hgcummings/assertj-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hgcummings/assertj-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hgcummings/assertj-core/languages","stargazers_url":"https://api.github.com/repos/hgcummings/assertj-core/stargazers","contributors_url":"https://api.github.com/repos/hgcummings/assertj-core/contributors","subscribers_url":"https://api.github.com/repos/hgcummings/assertj-core/subscribers","subscription_url":"https://api.github.com/repos/hgcummings/assertj-core/subscription","commits_url":"https://api.github.com/repos/hgcummings/assertj-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hgcummings/assertj-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hgcummings/assertj-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hgcummings/assertj-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/hgcummings/assertj-core/contents/{+path}","compare_url":"https://api.github.com/repos/hgcummings/assertj-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hgcummings/assertj-core/merges","archive_url":"https://api.github.com/repos/hgcummings/assertj-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hgcummings/assertj-core/downloads","issues_url":"https://api.github.com/repos/hgcummings/assertj-core/issues{/number}","pulls_url":"https://api.github.com/repos/hgcummings/assertj-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hgcummings/assertj-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hgcummings/assertj-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hgcummings/assertj-core/labels{/name}","releases_url":"https://api.github.com/repos/hgcummings/assertj-core/releases{/id}","created_at":"2014-12-22T08:31:19Z","updated_at":"2014-12-22T08:31:23Z","pushed_at":"2014-12-22T08:46:38Z","git_url":"git://github.com/hgcummings/assertj-core.git","ssh_url":"git@github.com:hgcummings/assertj-core.git","clone_url":"https://github.com/hgcummings/assertj-core.git","svn_url":"https://github.com/hgcummings/assertj-core","homepage":"","size":21247,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joel-costigliola:master","ref":"master","sha":"3305b848286e883ce713bbe092a199448539614d","user":{"login":"joel-costigliola","id":382613,"avatar_url":"https://avatars.githubusercontent.com/u/382613?v=3","gravatar_id":"","url":"https://api.github.com/users/joel-costigliola","html_url":"https://github.com/joel-costigliola","followers_url":"https://api.github.com/users/joel-costigliola/followers","following_url":"https://api.github.com/users/joel-costigliola/following{/other_user}","gists_url":"https://api.github.com/users/joel-costigliola/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-costigliola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-costigliola/subscriptions","organizations_url":"https://api.github.com/users/joel-costigliola/orgs","repos_url":"https://api.github.com/users/joel-costigliola/repos","events_url":"https://api.github.com/users/joel-costigliola/events{/privacy}","received_events_url":"https://api.github.com/users/joel-costigliola/received_events","type":"User","site_admin":false},"repo":{"id":8779606,"name":"assertj-core","full_name":"joel-costigliola/assertj-core","owner":{"login":"joel-costigliola","id":382613,"avatar_url":"https://avatars.githubusercontent.com/u/382613?v=3","gravatar_id":"","url":"https://api.github.com/users/joel-costigliola","html_url":"https://github.com/joel-costigliola","followers_url":"https://api.github.com/users/joel-costigliola/followers","following_url":"https://api.github.com/users/joel-costigliola/following{/other_user}","gists_url":"https://api.github.com/users/joel-costigliola/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-costigliola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-costigliola/subscriptions","organizations_url":"https://api.github.com/users/joel-costigliola/orgs","repos_url":"https://api.github.com/users/joel-costigliola/repos","events_url":"https://api.github.com/users/joel-costigliola/events{/privacy}","received_events_url":"https://api.github.com/users/joel-costigliola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joel-costigliola/assertj-core","description":"AssertJ is a library of assertions similar to fest-assert but providing a richer set of assertions.","fork":false,"url":"https://api.github.com/repos/joel-costigliola/assertj-core","forks_url":"https://api.github.com/repos/joel-costigliola/assertj-core/forks","keys_url":"https://api.github.com/repos/joel-costigliola/assertj-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joel-costigliola/assertj-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joel-costigliola/assertj-core/teams","hooks_url":"https://api.github.com/repos/joel-costigliola/assertj-core/hooks","issue_events_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/events{/number}","events_url":"https://api.github.com/repos/joel-costigliola/assertj-core/events","assignees_url":"https://api.github.com/repos/joel-costigliola/assertj-core/assignees{/user}","branches_url":"https://api.github.com/repos/joel-costigliola/assertj-core/branches{/branch}","tags_url":"https://api.github.com/repos/joel-costigliola/assertj-core/tags","blobs_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/{sha}","languages_url":"https://api.github.com/repos/joel-costigliola/assertj-core/languages","stargazers_url":"https://api.github.com/repos/joel-costigliola/assertj-core/stargazers","contributors_url":"https://api.github.com/repos/joel-costigliola/assertj-core/contributors","subscribers_url":"https://api.github.com/repos/joel-costigliola/assertj-core/subscribers","subscription_url":"https://api.github.com/repos/joel-costigliola/assertj-core/subscription","commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/joel-costigliola/assertj-core/contents/{+path}","compare_url":"https://api.github.com/repos/joel-costigliola/assertj-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joel-costigliola/assertj-core/merges","archive_url":"https://api.github.com/repos/joel-costigliola/assertj-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joel-costigliola/assertj-core/downloads","issues_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues{/number}","pulls_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls{/number}","milestones_url":"https://api.github.com/repos/joel-costigliola/assertj-core/milestones{/number}","notifications_url":"https://api.github.com/repos/joel-costigliola/assertj-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joel-costigliola/assertj-core/labels{/name}","releases_url":"https://api.github.com/repos/joel-costigliola/assertj-core/releases{/id}","created_at":"2013-03-14T16:18:49Z","updated_at":"2014-12-20T15:58:25Z","pushed_at":"2014-12-21T05:19:59Z","git_url":"git://github.com/joel-costigliola/assertj-core.git","ssh_url":"git@github.com:joel-costigliola/assertj-core.git","clone_url":"https://github.com/joel-costigliola/assertj-core.git","svn_url":"https://github.com/joel-costigliola/assertj-core","homepage":"","size":21247,"stargazers_count":326,"watchers_count":326,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"open_issues_count":55,"forks":85,"open_issues":55,"watchers":326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/304"},"html":{"href":"https://github.com/joel-costigliola/assertj-core/pull/304"},"issue":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/304"},"comments":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/3bbeeabc780b3e678698d23f31c79928bd1e7a04"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":26,"deletions":26,"changed_files":2}}