GitHub PullRequestEvent at 2014-07-03 12:41:43
Repository: Meridian59_103
Actor: skittles1
Payload: {"action":"opened","number":500,"pull_request":{"url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/500","id":17941652,"html_url":"https://github.com/Daenks/Meridian59_103/pull/500","diff_url":"https://github.com/Daenks/Meridian59_103/pull/500.diff","patch_url":"https://github.com/Daenks/Meridian59_103/pull/500.patch","issue_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues/500","number":500,"state":"open","title":"Spell overhaul, spellpower and duration display.","user":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?","gravatar_id":"39e08a0288df8c3237a5c30b12ff5d74","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"body":"This is the first part of an overhaul of how spells work and how they are called in the code. Spells with unique effects (eg. hold, blind) will have the function that performs that effect renamed to 'DoSpell' in the code to streamline any action that needs to happen when a unique effect is called for any spell. All monsters, rooms and items will be able to call any spell's unique effect by sending the spell a DoSpell with appropriate parameters. So far, hold, blind, dazzle, all wall/cloud spells and the spells/skills based off them are modified.\r\n\r\nAdded a system setting to toggle display of spellpower, displayed by CastSpell in spell.kod, and if applicable spell duration for unique effect, displayed by DoSpell in spell.kod. PE durations should ideally be displayed in the icon description or tooltip so I haven't included these here.\r\n\r\nAlso included are changes to the duration calculations for hold, blind and dazzle - these now work entirely in milliseconds rather than being converted at the end. The duration calculations are changed from (iSpellPower/n) to (iSpellPower*n) and all variables in the calculation (base time, multiplier, random deviation) are variables that can be changed from the admin console in game, but default to the values currently on the live servers. This is mainly for testing purposes.\r\n\r\nThe only gameplay change so far is lowering the hold from falling from the Riija temple bridge from 30 seconds to 20.","created_at":"2014-07-03T12:41:43Z","updated_at":"2014-07-03T12:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/500/commits","review_comments_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/500/comments","review_comment_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues/500/comments","statuses_url":"https://api.github.com/repos/Daenks/Meridian59_103/statuses/49f2a68a4c2d99352ac27fa49c2f54628c649e18","head":{"label":"skittles1:spelloverhaul","ref":"spelloverhaul","sha":"49f2a68a4c2d99352ac27fa49c2f54628c649e18","user":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?","gravatar_id":"39e08a0288df8c3237a5c30b12ff5d74","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"repo":{"id":16250474,"name":"Meridian59_103","full_name":"skittles1/Meridian59_103","owner":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?","gravatar_id":"39e08a0288df8c3237a5c30b12ff5d74","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skittles1/Meridian59_103","description":"The MMORPG Meridian 59 - Server 103","fork":true,"url":"https://api.github.com/repos/skittles1/Meridian59_103","forks_url":"https://api.github.com/repos/skittles1/Meridian59_103/forks","keys_url":"https://api.github.com/repos/skittles1/Meridian59_103/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skittles1/Meridian59_103/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skittles1/Meridian59_103/teams","hooks_url":"https://api.github.com/repos/skittles1/Meridian59_103/hooks","issue_events_url":"https://api.github.com/repos/skittles1/Meridian59_103/issues/events{/number}","events_url":"https://api.github.com/repos/skittles1/Meridian59_103/events","assignees_url":"https://api.github.com/repos/skittles1/Meridian59_103/assignees{/user}","branches_url":"https://api.github.com/repos/skittles1/Meridian59_103/branches{/branch}","tags_url":"https://api.github.com/repos/skittles1/Meridian59_103/tags","blobs_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/refs{/sha}","trees_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skittles1/Meridian59_103/statuses/{sha}","languages_url":"https://api.github.com/repos/skittles1/Meridian59_103/languages","stargazers_url":"https://api.github.com/repos/skittles1/Meridian59_103/stargazers","contributors_url":"https://api.github.com/repos/skittles1/Meridian59_103/contributors","subscribers_url":"https://api.github.com/repos/skittles1/Meridian59_103/subscribers","subscription_url":"https://api.github.com/repos/skittles1/Meridian59_103/subscription","commits_url":"https://api.github.com/repos/skittles1/Meridian59_103/commits{/sha}","git_commits_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/commits{/sha}","comments_url":"https://api.github.com/repos/skittles1/Meridian59_103/comments{/number}","issue_comment_url":"https://api.github.com/repos/skittles1/Meridian59_103/issues/comments/{number}","contents_url":"https://api.github.com/repos/skittles1/Meridian59_103/contents/{+path}","compare_url":"https://api.github.com/repos/skittles1/Meridian59_103/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skittles1/Meridian59_103/merges","archive_url":"https://api.github.com/repos/skittles1/Meridian59_103/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skittles1/Meridian59_103/downloads","issues_url":"https://api.github.com/repos/skittles1/Meridian59_103/issues{/number}","pulls_url":"https://api.github.com/repos/skittles1/Meridian59_103/pulls{/number}","milestones_url":"https://api.github.com/repos/skittles1/Meridian59_103/milestones{/number}","notifications_url":"https://api.github.com/repos/skittles1/Meridian59_103/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skittles1/Meridian59_103/labels{/name}","releases_url":"https://api.github.com/repos/skittles1/Meridian59_103/releases{/id}","created_at":"2014-01-26T09:26:09Z","updated_at":"2014-07-01T04:17:51Z","pushed_at":"2014-07-03T12:41:00Z","git_url":"git://github.com/skittles1/Meridian59_103.git","ssh_url":"git@github.com:skittles1/Meridian59_103.git","clone_url":"https://github.com/skittles1/Meridian59_103.git","svn_url":"https://github.com/skittles1/Meridian59_103","homepage":"openmeridian.org","size":59052,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Daenks:master","ref":"master","sha":"3c588093b9f692eefe51b751672ad47b5e01b5c1","user":{"login":"Daenks","id":552647,"avatar_url":"https://avatars.githubusercontent.com/u/552647?","gravatar_id":"7c6baacc6cb2104b50a72dc1eea47c44","url":"https://api.github.com/users/Daenks","html_url":"https://github.com/Daenks","followers_url":"https://api.github.com/users/Daenks/followers","following_url":"https://api.github.com/users/Daenks/following{/other_user}","gists_url":"https://api.github.com/users/Daenks/gists{/gist_id}","starred_url":"https://api.github.com/users/Daenks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daenks/subscriptions","organizations_url":"https://api.github.com/users/Daenks/orgs","repos_url":"https://api.github.com/users/Daenks/repos","events_url":"https://api.github.com/users/Daenks/events{/privacy}","received_events_url":"https://api.github.com/users/Daenks/received_events","type":"User","site_admin":false},"repo":{"id":14400546,"name":"Meridian59_103","full_name":"Daenks/Meridian59_103","owner":{"login":"Daenks","id":552647,"avatar_url":"https://avatars.githubusercontent.com/u/552647?","gravatar_id":"7c6baacc6cb2104b50a72dc1eea47c44","url":"https://api.github.com/users/Daenks","html_url":"https://github.com/Daenks","followers_url":"https://api.github.com/users/Daenks/followers","following_url":"https://api.github.com/users/Daenks/following{/other_user}","gists_url":"https://api.github.com/users/Daenks/gists{/gist_id}","starred_url":"https://api.github.com/users/Daenks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daenks/subscriptions","organizations_url":"https://api.github.com/users/Daenks/orgs","repos_url":"https://api.github.com/users/Daenks/repos","events_url":"https://api.github.com/users/Daenks/events{/privacy}","received_events_url":"https://api.github.com/users/Daenks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Daenks/Meridian59_103","description":"The MMORPG Meridian 59 - Server 103","fork":true,"url":"https://api.github.com/repos/Daenks/Meridian59_103","forks_url":"https://api.github.com/repos/Daenks/Meridian59_103/forks","keys_url":"https://api.github.com/repos/Daenks/Meridian59_103/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Daenks/Meridian59_103/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Daenks/Meridian59_103/teams","hooks_url":"https://api.github.com/repos/Daenks/Meridian59_103/hooks","issue_events_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues/events{/number}","events_url":"https://api.github.com/repos/Daenks/Meridian59_103/events","assignees_url":"https://api.github.com/repos/Daenks/Meridian59_103/assignees{/user}","branches_url":"https://api.github.com/repos/Daenks/Meridian59_103/branches{/branch}","tags_url":"https://api.github.com/repos/Daenks/Meridian59_103/tags","blobs_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/refs{/sha}","trees_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Daenks/Meridian59_103/statuses/{sha}","languages_url":"https://api.github.com/repos/Daenks/Meridian59_103/languages","stargazers_url":"https://api.github.com/repos/Daenks/Meridian59_103/stargazers","contributors_url":"https://api.github.com/repos/Daenks/Meridian59_103/contributors","subscribers_url":"https://api.github.com/repos/Daenks/Meridian59_103/subscribers","subscription_url":"https://api.github.com/repos/Daenks/Meridian59_103/subscription","commits_url":"https://api.github.com/repos/Daenks/Meridian59_103/commits{/sha}","git_commits_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/commits{/sha}","comments_url":"https://api.github.com/repos/Daenks/Meridian59_103/comments{/number}","issue_comment_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues/comments/{number}","contents_url":"https://api.github.com/repos/Daenks/Meridian59_103/contents/{+path}","compare_url":"https://api.github.com/repos/Daenks/Meridian59_103/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Daenks/Meridian59_103/merges","archive_url":"https://api.github.com/repos/Daenks/Meridian59_103/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Daenks/Meridian59_103/downloads","issues_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues{/number}","pulls_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls{/number}","milestones_url":"https://api.github.com/repos/Daenks/Meridian59_103/milestones{/number}","notifications_url":"https://api.github.com/repos/Daenks/Meridian59_103/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Daenks/Meridian59_103/labels{/name}","releases_url":"https://api.github.com/repos/Daenks/Meridian59_103/releases{/id}","created_at":"2013-11-14T16:29:15Z","updated_at":"2014-06-30T21:44:17Z","pushed_at":"2014-06-30T21:44:15Z","git_url":"git://github.com/Daenks/Meridian59_103.git","ssh_url":"git@github.com:Daenks/Meridian59_103.git","clone_url":"https://github.com/Daenks/Meridian59_103.git","svn_url":"https://github.com/Daenks/Meridian59_103","homepage":"openmeridian.org","size":64000,"stargazers_count":16,"watchers_count":16,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":33,"mirror_url":null,"open_issues_count":93,"forks":33,"open_issues":93,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/500"},"html":{"href":"https://github.com/Daenks/Meridian59_103/pull/500"},"issue":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/issues/500"},"comments":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/statuses/49f2a68a4c2d99352ac27fa49c2f54628c649e18"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":143,"deletions":125,"changed_files":20}}