GitHub PullRequestEvent at 2014-03-18 16:26:18
Repository: salt
Actor: thatch45
Payload: {"action":"closed","number":11308,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/11308","id":13662675,"html_url":"https://github.com/saltstack/salt/pull/11308","diff_url":"https://github.com/saltstack/salt/pull/11308.diff","patch_url":"https://github.com/saltstack/salt/pull/11308.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/11308","number":11308,"state":"closed","title":"Rewrite jid comparison for job cache cleanup","user":{"login":"basepi","id":702318,"avatar_url":"https://avatars.githubusercontent.com/u/702318?","gravatar_id":"8a53fba454e31b5ec532e8df78832a16","url":"https://api.github.com/users/basepi","html_url":"https://github.com/basepi","followers_url":"https://api.github.com/users/basepi/followers","following_url":"https://api.github.com/users/basepi/following{/other_user}","gists_url":"https://api.github.com/users/basepi/gists{/gist_id}","starred_url":"https://api.github.com/users/basepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basepi/subscriptions","organizations_url":"https://api.github.com/users/basepi/orgs","repos_url":"https://api.github.com/users/basepi/repos","events_url":"https://api.github.com/users/basepi/events{/privacy}","received_events_url":"https://api.github.com/users/basepi/received_events","type":"User","site_admin":false},"body":"Previous iteration was naive, just converted the first 10 characters of\r\nthe jid to integers and subtracted.  However, that means that any time\r\nwe go tick over midnight, it adds 76 to the difference (since hours are\r\nnot tracked in base 10).  Now, we parse out the jid, convert to a\r\ndatetime object, and compare using a timedelta object.\r\n\r\nWill not cherry-pick cleanly, so I will submit that as a secondary pull request.","created_at":"2014-03-17T23:30:41Z","updated_at":"2014-03-18T16:26:17Z","closed_at":"2014-03-18T16:26:17Z","merged_at":"2014-03-18T16:26:17Z","merge_commit_sha":"0a132688a847c4911ac122a64b0e24cc27146d48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/11308/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/11308/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/11308/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/4f8f1e99b7d872cab8fcde26e54dbc73c8403698","head":{"label":"basepi:keepjobsrewrite","ref":"keepjobsrewrite","sha":"4f8f1e99b7d872cab8fcde26e54dbc73c8403698","user":{"login":"basepi","id":702318,"avatar_url":"https://avatars.githubusercontent.com/u/702318?","gravatar_id":"8a53fba454e31b5ec532e8df78832a16","url":"https://api.github.com/users/basepi","html_url":"https://github.com/basepi","followers_url":"https://api.github.com/users/basepi/followers","following_url":"https://api.github.com/users/basepi/following{/other_user}","gists_url":"https://api.github.com/users/basepi/gists{/gist_id}","starred_url":"https://api.github.com/users/basepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basepi/subscriptions","organizations_url":"https://api.github.com/users/basepi/orgs","repos_url":"https://api.github.com/users/basepi/repos","events_url":"https://api.github.com/users/basepi/events{/privacy}","received_events_url":"https://api.github.com/users/basepi/received_events","type":"User","site_admin":false},"repo":{"id":7823385,"name":"salt","full_name":"basepi/salt","owner":{"login":"basepi","id":702318,"avatar_url":"https://avatars.githubusercontent.com/u/702318?","gravatar_id":"8a53fba454e31b5ec532e8df78832a16","url":"https://api.github.com/users/basepi","html_url":"https://github.com/basepi","followers_url":"https://api.github.com/users/basepi/followers","following_url":"https://api.github.com/users/basepi/following{/other_user}","gists_url":"https://api.github.com/users/basepi/gists{/gist_id}","starred_url":"https://api.github.com/users/basepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basepi/subscriptions","organizations_url":"https://api.github.com/users/basepi/orgs","repos_url":"https://api.github.com/users/basepi/repos","events_url":"https://api.github.com/users/basepi/events{/privacy}","received_events_url":"https://api.github.com/users/basepi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basepi/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/basepi/salt","forks_url":"https://api.github.com/repos/basepi/salt/forks","keys_url":"https://api.github.com/repos/basepi/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basepi/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basepi/salt/teams","hooks_url":"https://api.github.com/repos/basepi/salt/hooks","issue_events_url":"https://api.github.com/repos/basepi/salt/issues/events{/number}","events_url":"https://api.github.com/repos/basepi/salt/events","assignees_url":"https://api.github.com/repos/basepi/salt/assignees{/user}","branches_url":"https://api.github.com/repos/basepi/salt/branches{/branch}","tags_url":"https://api.github.com/repos/basepi/salt/tags","blobs_url":"https://api.github.com/repos/basepi/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basepi/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basepi/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/basepi/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basepi/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/basepi/salt/languages","stargazers_url":"https://api.github.com/repos/basepi/salt/stargazers","contributors_url":"https://api.github.com/repos/basepi/salt/contributors","subscribers_url":"https://api.github.com/repos/basepi/salt/subscribers","subscription_url":"https://api.github.com/repos/basepi/salt/subscription","commits_url":"https://api.github.com/repos/basepi/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/basepi/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/basepi/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/basepi/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/basepi/salt/contents/{+path}","compare_url":"https://api.github.com/repos/basepi/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basepi/salt/merges","archive_url":"https://api.github.com/repos/basepi/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basepi/salt/downloads","issues_url":"https://api.github.com/repos/basepi/salt/issues{/number}","pulls_url":"https://api.github.com/repos/basepi/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/basepi/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/basepi/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basepi/salt/labels{/name}","releases_url":"https://api.github.com/repos/basepi/salt/releases{/id}","created_at":"2013-01-25T16:06:11Z","updated_at":"2014-03-18T16:26:17Z","pushed_at":"2014-03-18T15:18:42Z","git_url":"git://github.com/basepi/salt.git","ssh_url":"git@github.com:basepi/salt.git","clone_url":"https://github.com/basepi/salt.git","svn_url":"https://github.com/basepi/salt","homepage":"saltstack.org","size":43162,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop","master_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"b6f4882c7cadc2a6b14bdb958569f24704deda13","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?","gravatar_id":"8e25be5fcc652c85b518a5755986615f","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?","gravatar_id":"8e25be5fcc652c85b518a5755986615f","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Central system and configuration manager ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2014-03-18T16:26:17Z","pushed_at":"2014-03-18T16:26:17Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.org","size":99916,"stargazers_count":3145,"watchers_count":3145,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1214,"mirror_url":null,"open_issues_count":1190,"forks":1214,"open_issues":1190,"watchers":3145,"default_branch":"develop","master_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/11308"},"html":{"href":"https://github.com/saltstack/salt/pull/11308"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/11308"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/11308/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/11308/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/11308/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/4f8f1e99b7d872cab8fcde26e54dbc73c8403698"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?","gravatar_id":"ff7bc69b52eecf808141c470543db4f3","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":20,"deletions":5,"changed_files":1}}