GitHub PullRequestReviewCommentEvent at 2014-10-28 06:28:23
Repository: bomberman
Actor: Neki
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Neki/bomberman/pulls/comments/19454897","id":19454897,"diff_hunk":"@@ -0,0 +1,59 @@\n+#include \"ServerHandler.h\"\n+#include <QWidget>\n+#include \"easylogging++.h\"\n+\n+ServerHandler::ServerHandler() : QWidget(), server_process_(std::unique_ptr<QProcess>(new QProcess(this))) {\n+}\n+\n+ServerHandler::~ServerHandler() {\n+    terminateServer();\n+}\n+\n+void ServerHandler::runServer() {\n+    LOG(INFO) << \"Starting server...\";\n+    if (running_) {","path":"src/client/ServerHandler.cc","position":14,"original_position":14,"commit_id":"97373cd22ccccf959b243695758679b6647c9847","original_commit_id":"97373cd22ccccf959b243695758679b6647c9847","user":{"login":"Neki","id":2143664,"avatar_url":"https://avatars.githubusercontent.com/u/2143664?v=2","gravatar_id":"","url":"https://api.github.com/users/Neki","html_url":"https://github.com/Neki","followers_url":"https://api.github.com/users/Neki/followers","following_url":"https://api.github.com/users/Neki/following{/other_user}","gists_url":"https://api.github.com/users/Neki/gists{/gist_id}","starred_url":"https://api.github.com/users/Neki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neki/subscriptions","organizations_url":"https://api.github.com/users/Neki/orgs","repos_url":"https://api.github.com/users/Neki/repos","events_url":"https://api.github.com/users/Neki/events{/privacy}","received_events_url":"https://api.github.com/users/Neki/received_events","type":"User","site_admin":false},"body":"Que se passe-t-il si le serveur crash ? Il faudrait plutôt interroger la liste des processes pour voir si le process serveur existe toujours.\r\nSous UNIX, la méthode serait de créer un fichier server.pid contenant le process ID (PID) du server, ce qui permet de le retrouver dans la liste des processes. Je ne connais pas l'équivalent Windows.","created_at":"2014-10-28T06:28:23Z","updated_at":"2014-10-28T06:28:23Z","html_url":"https://github.com/Neki/bomberman/pull/29#discussion_r19454897","pull_request_url":"https://api.github.com/repos/Neki/bomberman/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/Neki/bomberman/pulls/comments/19454897"},"html":{"href":"https://github.com/Neki/bomberman/pull/29#discussion_r19454897"},"pull_request":{"href":"https://api.github.com/repos/Neki/bomberman/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/Neki/bomberman/pulls/29","id":23422923,"html_url":"https://github.com/Neki/bomberman/pull/29","diff_url":"https://github.com/Neki/bomberman/pull/29.diff","patch_url":"https://github.com/Neki/bomberman/pull/29.patch","issue_url":"https://api.github.com/repos/Neki/bomberman/issues/29","number":29,"state":"open","locked":false,"title":"spawning server via gui, terminating it at the end","user":{"login":"arkandias33","id":5164914,"avatar_url":"https://avatars.githubusercontent.com/u/5164914?v=2","gravatar_id":"","url":"https://api.github.com/users/arkandias33","html_url":"https://github.com/arkandias33","followers_url":"https://api.github.com/users/arkandias33/followers","following_url":"https://api.github.com/users/arkandias33/following{/other_user}","gists_url":"https://api.github.com/users/arkandias33/gists{/gist_id}","starred_url":"https://api.github.com/users/arkandias33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkandias33/subscriptions","organizations_url":"https://api.github.com/users/arkandias33/orgs","repos_url":"https://api.github.com/users/arkandias33/repos","events_url":"https://api.github.com/users/arkandias33/events{/privacy}","received_events_url":"https://api.github.com/users/arkandias33/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-27T22:57:14Z","updated_at":"2014-10-28T06:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e7735483803c6a13d1138d8a4635d07cc126ae2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Neki/bomberman/pulls/29/commits","review_comments_url":"https://api.github.com/repos/Neki/bomberman/pulls/29/comments","review_comment_url":"https://api.github.com/repos/Neki/bomberman/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Neki/bomberman/issues/29/comments","statuses_url":"https://api.github.com/repos/Neki/bomberman/statuses/97373cd22ccccf959b243695758679b6647c9847","head":{"label":"Neki:topic/st_spawnserver","ref":"topic/st_spawnserver","sha":"97373cd22ccccf959b243695758679b6647c9847","user":{"login":"Neki","id":2143664,"avatar_url":"https://avatars.githubusercontent.com/u/2143664?v=2","gravatar_id":"","url":"https://api.github.com/users/Neki","html_url":"https://github.com/Neki","followers_url":"https://api.github.com/users/Neki/followers","following_url":"https://api.github.com/users/Neki/following{/other_user}","gists_url":"https://api.github.com/users/Neki/gists{/gist_id}","starred_url":"https://api.github.com/users/Neki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neki/subscriptions","organizations_url":"https://api.github.com/users/Neki/orgs","repos_url":"https://api.github.com/users/Neki/repos","events_url":"https://api.github.com/users/Neki/events{/privacy}","received_events_url":"https://api.github.com/users/Neki/received_events","type":"User","site_admin":false},"repo":{"id":24291681,"name":"bomberman","full_name":"Neki/bomberman","owner":{"login":"Neki","id":2143664,"avatar_url":"https://avatars.githubusercontent.com/u/2143664?v=2","gravatar_id":"","url":"https://api.github.com/users/Neki","html_url":"https://github.com/Neki","followers_url":"https://api.github.com/users/Neki/followers","following_url":"https://api.github.com/users/Neki/following{/other_user}","gists_url":"https://api.github.com/users/Neki/gists{/gist_id}","starred_url":"https://api.github.com/users/Neki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neki/subscriptions","organizations_url":"https://api.github.com/users/Neki/orgs","repos_url":"https://api.github.com/users/Neki/repos","events_url":"https://api.github.com/users/Neki/events{/privacy}","received_events_url":"https://api.github.com/users/Neki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Neki/bomberman","description":"Yet another bomberman clone (student project - written in C++)","fork":false,"url":"https://api.github.com/repos/Neki/bomberman","forks_url":"https://api.github.com/repos/Neki/bomberman/forks","keys_url":"https://api.github.com/repos/Neki/bomberman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neki/bomberman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neki/bomberman/teams","hooks_url":"https://api.github.com/repos/Neki/bomberman/hooks","issue_events_url":"https://api.github.com/repos/Neki/bomberman/issues/events{/number}","events_url":"https://api.github.com/repos/Neki/bomberman/events","assignees_url":"https://api.github.com/repos/Neki/bomberman/assignees{/user}","branches_url":"https://api.github.com/repos/Neki/bomberman/branches{/branch}","tags_url":"https://api.github.com/repos/Neki/bomberman/tags","blobs_url":"https://api.github.com/repos/Neki/bomberman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neki/bomberman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neki/bomberman/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neki/bomberman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neki/bomberman/statuses/{sha}","languages_url":"https://api.github.com/repos/Neki/bomberman/languages","stargazers_url":"https://api.github.com/repos/Neki/bomberman/stargazers","contributors_url":"https://api.github.com/repos/Neki/bomberman/contributors","subscribers_url":"https://api.github.com/repos/Neki/bomberman/subscribers","subscription_url":"https://api.github.com/repos/Neki/bomberman/subscription","commits_url":"https://api.github.com/repos/Neki/bomberman/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neki/bomberman/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neki/bomberman/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neki/bomberman/issues/comments/{number}","contents_url":"https://api.github.com/repos/Neki/bomberman/contents/{+path}","compare_url":"https://api.github.com/repos/Neki/bomberman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neki/bomberman/merges","archive_url":"https://api.github.com/repos/Neki/bomberman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neki/bomberman/downloads","issues_url":"https://api.github.com/repos/Neki/bomberman/issues{/number}","pulls_url":"https://api.github.com/repos/Neki/bomberman/pulls{/number}","milestones_url":"https://api.github.com/repos/Neki/bomberman/milestones{/number}","notifications_url":"https://api.github.com/repos/Neki/bomberman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neki/bomberman/labels{/name}","releases_url":"https://api.github.com/repos/Neki/bomberman/releases{/id}","created_at":"2014-09-21T13:29:14Z","updated_at":"2014-09-27T11:20:11Z","pushed_at":"2014-10-27T23:10:19Z","git_url":"git://github.com/Neki/bomberman.git","ssh_url":"git@github.com:Neki/bomberman.git","clone_url":"https://github.com/Neki/bomberman.git","svn_url":"https://github.com/Neki/bomberman","homepage":null,"size":3068,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Neki:master","ref":"master","sha":"8009bead4559ea149e102b482cdfbae1082dfd6a","user":{"login":"Neki","id":2143664,"avatar_url":"https://avatars.githubusercontent.com/u/2143664?v=2","gravatar_id":"","url":"https://api.github.com/users/Neki","html_url":"https://github.com/Neki","followers_url":"https://api.github.com/users/Neki/followers","following_url":"https://api.github.com/users/Neki/following{/other_user}","gists_url":"https://api.github.com/users/Neki/gists{/gist_id}","starred_url":"https://api.github.com/users/Neki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neki/subscriptions","organizations_url":"https://api.github.com/users/Neki/orgs","repos_url":"https://api.github.com/users/Neki/repos","events_url":"https://api.github.com/users/Neki/events{/privacy}","received_events_url":"https://api.github.com/users/Neki/received_events","type":"User","site_admin":false},"repo":{"id":24291681,"name":"bomberman","full_name":"Neki/bomberman","owner":{"login":"Neki","id":2143664,"avatar_url":"https://avatars.githubusercontent.com/u/2143664?v=2","gravatar_id":"","url":"https://api.github.com/users/Neki","html_url":"https://github.com/Neki","followers_url":"https://api.github.com/users/Neki/followers","following_url":"https://api.github.com/users/Neki/following{/other_user}","gists_url":"https://api.github.com/users/Neki/gists{/gist_id}","starred_url":"https://api.github.com/users/Neki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neki/subscriptions","organizations_url":"https://api.github.com/users/Neki/orgs","repos_url":"https://api.github.com/users/Neki/repos","events_url":"https://api.github.com/users/Neki/events{/privacy}","received_events_url":"https://api.github.com/users/Neki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Neki/bomberman","description":"Yet another bomberman clone (student project - written in C++)","fork":false,"url":"https://api.github.com/repos/Neki/bomberman","forks_url":"https://api.github.com/repos/Neki/bomberman/forks","keys_url":"https://api.github.com/repos/Neki/bomberman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neki/bomberman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neki/bomberman/teams","hooks_url":"https://api.github.com/repos/Neki/bomberman/hooks","issue_events_url":"https://api.github.com/repos/Neki/bomberman/issues/events{/number}","events_url":"https://api.github.com/repos/Neki/bomberman/events","assignees_url":"https://api.github.com/repos/Neki/bomberman/assignees{/user}","branches_url":"https://api.github.com/repos/Neki/bomberman/branches{/branch}","tags_url":"https://api.github.com/repos/Neki/bomberman/tags","blobs_url":"https://api.github.com/repos/Neki/bomberman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neki/bomberman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neki/bomberman/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neki/bomberman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neki/bomberman/statuses/{sha}","languages_url":"https://api.github.com/repos/Neki/bomberman/languages","stargazers_url":"https://api.github.com/repos/Neki/bomberman/stargazers","contributors_url":"https://api.github.com/repos/Neki/bomberman/contributors","subscribers_url":"https://api.github.com/repos/Neki/bomberman/subscribers","subscription_url":"https://api.github.com/repos/Neki/bomberman/subscription","commits_url":"https://api.github.com/repos/Neki/bomberman/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neki/bomberman/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neki/bomberman/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neki/bomberman/issues/comments/{number}","contents_url":"https://api.github.com/repos/Neki/bomberman/contents/{+path}","compare_url":"https://api.github.com/repos/Neki/bomberman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neki/bomberman/merges","archive_url":"https://api.github.com/repos/Neki/bomberman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neki/bomberman/downloads","issues_url":"https://api.github.com/repos/Neki/bomberman/issues{/number}","pulls_url":"https://api.github.com/repos/Neki/bomberman/pulls{/number}","milestones_url":"https://api.github.com/repos/Neki/bomberman/milestones{/number}","notifications_url":"https://api.github.com/repos/Neki/bomberman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neki/bomberman/labels{/name}","releases_url":"https://api.github.com/repos/Neki/bomberman/releases{/id}","created_at":"2014-09-21T13:29:14Z","updated_at":"2014-09-27T11:20:11Z","pushed_at":"2014-10-27T23:10:19Z","git_url":"git://github.com/Neki/bomberman.git","ssh_url":"git@github.com:Neki/bomberman.git","clone_url":"https://github.com/Neki/bomberman.git","svn_url":"https://github.com/Neki/bomberman","homepage":null,"size":3068,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neki/bomberman/pulls/29"},"html":{"href":"https://github.com/Neki/bomberman/pull/29"},"issue":{"href":"https://api.github.com/repos/Neki/bomberman/issues/29"},"comments":{"href":"https://api.github.com/repos/Neki/bomberman/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/Neki/bomberman/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/Neki/bomberman/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Neki/bomberman/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/Neki/bomberman/statuses/97373cd22ccccf959b243695758679b6647c9847"}}}}