GitHub PullRequestReviewCommentEvent at 2014-05-17 23:40:28
Repository: Cataclysm-DDA
Actor: BevapDin
Payload: {"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/12771395","id":12771395,"diff_hunk":"@@ -268,21 +286,16 @@ class vehicle : public JsonSerializer, public JsonDeserializer\n \n // install a new part to vehicle (force to skip possibility check)\n     int install_part (int dx, int dy, std::string id, int hp = -1, bool force = false);\n+// Install a copy of the given part, skips possibility check\n+    int install_part (int dx, int dy, const vehicle_part &part);\n+// install a new part to vehicle (force to skip possibility check)\n+    int install_part (int dx, int dy, const std::string &id, const item &item_used);","path":"src/vehicle.h","position":45,"original_position":45,"commit_id":"d16f5eac8d55fa0c8f292c1cb05b123d19198849","original_commit_id":"d16f5eac8d55fa0c8f292c1cb05b123d19198849","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?","gravatar_id":"e453b8ec0e85e4d9d5ce7a6c1285c4a3","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"The force parameter was only used in mapgen.cpp for merging vehicles to wreckages. That code now calls `install_part (int dx, int dy, const vehicle_part &part);`, which behaves like force=true, so now change.\r\n\r\n`install_part (int dx, int dy, const std::string &id, const item &item_used);` is called from veh_interact.cpp when the player has installed a part and behaves like force=false (the default), no change there either.\r\n\r\nI simply didn't see any need for this parameter on these functions.","created_at":"2014-05-17T23:40:28Z","updated_at":"2014-05-17T23:40:28Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7674#discussion_r12771395","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7674","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/12771395"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7674#discussion_r12771395"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7674"}}}}