GitHub PullRequestReviewCommentEvent at 2014-11-14 18:26:44
Repository: olympia
Actor: olivier-m
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/comments/20376039","id":20376039,"diff_hunk":"@@ -112,6 +112,10 @@ def can_be_perf_tested(self):\n                        not self.version.addon.disabled_by_user)\n         return is_eligible\n \n+    def can_be_signed(self):\n+        \"\"\"True only if extension is xpi\"\"\"\n+        return os.path.splitext(self.filename)[1] == '.xpi'","path":"apps/files/models.py","position":6,"original_position":6,"commit_id":"a6bfa4413cf4794e4e76d3402019d8d72a7f4184","original_commit_id":"a6bfa4413cf4794e4e76d3402019d8d72a7f4184","user":{"login":"olivier-m","id":683641,"avatar_url":"https://avatars.githubusercontent.com/u/683641?v=3","gravatar_id":"","url":"https://api.github.com/users/olivier-m","html_url":"https://github.com/olivier-m","followers_url":"https://api.github.com/users/olivier-m/followers","following_url":"https://api.github.com/users/olivier-m/following{/other_user}","gists_url":"https://api.github.com/users/olivier-m/gists{/gist_id}","starred_url":"https://api.github.com/users/olivier-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivier-m/subscriptions","organizations_url":"https://api.github.com/users/olivier-m/orgs","repos_url":"https://api.github.com/users/olivier-m/repos","events_url":"https://api.github.com/users/olivier-m/events{/privacy}","received_events_url":"https://api.github.com/users/olivier-m/received_events","type":"User","site_admin":false},"body":"We are working at the file level, I didn't find any other way to check if we can sign the file or not. We might add .jar too","created_at":"2014-11-14T18:26:44Z","updated_at":"2014-11-14T18:26:44Z","html_url":"https://github.com/mozilla/olympia/pull/353#discussion_r20376039","pull_request_url":"https://api.github.com/repos/mozilla/olympia/pulls/353","_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments/20376039"},"html":{"href":"https://github.com/mozilla/olympia/pull/353#discussion_r20376039"},"pull_request":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/353"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/353","id":23750973,"html_url":"https://github.com/mozilla/olympia/pull/353","diff_url":"https://github.com/mozilla/olympia/pull/353.diff","patch_url":"https://github.com/mozilla/olympia/pull/353.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/353","number":353,"state":"open","locked":false,"title":"trunion api (bugs 1070189, 1070191)","user":{"login":"olivier-m","id":683641,"avatar_url":"https://avatars.githubusercontent.com/u/683641?v=3","gravatar_id":"","url":"https://api.github.com/users/olivier-m","html_url":"https://github.com/olivier-m","followers_url":"https://api.github.com/users/olivier-m/followers","following_url":"https://api.github.com/users/olivier-m/following{/other_user}","gists_url":"https://api.github.com/users/olivier-m/gists{/gist_id}","starred_url":"https://api.github.com/users/olivier-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivier-m/subscriptions","organizations_url":"https://api.github.com/users/olivier-m/orgs","repos_url":"https://api.github.com/users/olivier-m/repos","events_url":"https://api.github.com/users/olivier-m/events{/privacy}","received_events_url":"https://api.github.com/users/olivier-m/received_events","type":"User","site_admin":false},"body":"WIP, DO NOT MERGE\r\n\r\nBug 1070189: Call the trunion API (not tested with servers yet)\r\nBug 1070191: Signing management command","created_at":"2014-11-03T10:09:39Z","updated_at":"2014-11-14T18:26:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7775ea3968464a0a646311ef0c9fcd975770a081","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/353/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/353/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/353/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/a6bfa4413cf4794e4e76d3402019d8d72a7f4184","head":{"label":"olivier-m:1070189-trunion-api","ref":"1070189-trunion-api","sha":"a6bfa4413cf4794e4e76d3402019d8d72a7f4184","user":{"login":"olivier-m","id":683641,"avatar_url":"https://avatars.githubusercontent.com/u/683641?v=3","gravatar_id":"","url":"https://api.github.com/users/olivier-m","html_url":"https://github.com/olivier-m","followers_url":"https://api.github.com/users/olivier-m/followers","following_url":"https://api.github.com/users/olivier-m/following{/other_user}","gists_url":"https://api.github.com/users/olivier-m/gists{/gist_id}","starred_url":"https://api.github.com/users/olivier-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivier-m/subscriptions","organizations_url":"https://api.github.com/users/olivier-m/orgs","repos_url":"https://api.github.com/users/olivier-m/repos","events_url":"https://api.github.com/users/olivier-m/events{/privacy}","received_events_url":"https://api.github.com/users/olivier-m/received_events","type":"User","site_admin":false},"repo":{"id":23430490,"name":"olympia","full_name":"olivier-m/olympia","owner":{"login":"olivier-m","id":683641,"avatar_url":"https://avatars.githubusercontent.com/u/683641?v=3","gravatar_id":"","url":"https://api.github.com/users/olivier-m","html_url":"https://github.com/olivier-m","followers_url":"https://api.github.com/users/olivier-m/followers","following_url":"https://api.github.com/users/olivier-m/following{/other_user}","gists_url":"https://api.github.com/users/olivier-m/gists{/gist_id}","starred_url":"https://api.github.com/users/olivier-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivier-m/subscriptions","organizations_url":"https://api.github.com/users/olivier-m/orgs","repos_url":"https://api.github.com/users/olivier-m/repos","events_url":"https://api.github.com/users/olivier-m/events{/privacy}","received_events_url":"https://api.github.com/users/olivier-m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olivier-m/olympia","description":"addons.mozilla.org, reloaded.","fork":true,"url":"https://api.github.com/repos/olivier-m/olympia","forks_url":"https://api.github.com/repos/olivier-m/olympia/forks","keys_url":"https://api.github.com/repos/olivier-m/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olivier-m/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olivier-m/olympia/teams","hooks_url":"https://api.github.com/repos/olivier-m/olympia/hooks","issue_events_url":"https://api.github.com/repos/olivier-m/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/olivier-m/olympia/events","assignees_url":"https://api.github.com/repos/olivier-m/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/olivier-m/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/olivier-m/olympia/tags","blobs_url":"https://api.github.com/repos/olivier-m/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olivier-m/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olivier-m/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/olivier-m/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olivier-m/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/olivier-m/olympia/languages","stargazers_url":"https://api.github.com/repos/olivier-m/olympia/stargazers","contributors_url":"https://api.github.com/repos/olivier-m/olympia/contributors","subscribers_url":"https://api.github.com/repos/olivier-m/olympia/subscribers","subscription_url":"https://api.github.com/repos/olivier-m/olympia/subscription","commits_url":"https://api.github.com/repos/olivier-m/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/olivier-m/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/olivier-m/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/olivier-m/olympia/issues/comments/{number}","contents_url":"https://api.github.com/repos/olivier-m/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/olivier-m/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olivier-m/olympia/merges","archive_url":"https://api.github.com/repos/olivier-m/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olivier-m/olympia/downloads","issues_url":"https://api.github.com/repos/olivier-m/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/olivier-m/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/olivier-m/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/olivier-m/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olivier-m/olympia/labels{/name}","releases_url":"https://api.github.com/repos/olivier-m/olympia/releases{/id}","created_at":"2014-08-28T14:15:46Z","updated_at":"2014-10-01T06:13:49Z","pushed_at":"2014-11-10T15:22:25Z","git_url":"git://github.com/olivier-m/olympia.git","ssh_url":"git@github.com:olivier-m/olympia.git","clone_url":"https://github.com/olivier-m/olympia.git","svn_url":"https://github.com/olivier-m/olympia","homepage":"https://addons.mozilla.org/","size":265948,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"ad24184ff88c74639c9b19b26d4065fc4c6dd45d","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2014-11-14T17:07:45Z","pushed_at":"2014-11-13T21:10:38Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":325332,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":10,"forks":59,"open_issues":10,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/353"},"html":{"href":"https://github.com/mozilla/olympia/pull/353"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/353"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/353/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/353/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/353/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/a6bfa4413cf4794e4e76d3402019d8d72a7f4184"}}}}