GitHub PullRequestReviewCommentEvent at 2014-12-13 00:43:44
Repository: NAB
Actor: scottpurdy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/numenta/NAB/pulls/comments/21783291","id":21783291,"diff_hunk":"@@ -142,7 +142,7 @@ def detectDataSet(args):\n \n   results[\"label\"] = labels\n \n-  results.to_csv(outputPath, index=False, float_format=\"%.3f\")\n+  results.to_csv(outputPath, index=False)","path":"nab/detectors/base.py","position":5,"original_position":5,"commit_id":"beff77f854ca4564fd711cc2b5b102abc3a5cfcd","original_commit_id":"beff77f854ca4564fd711cc2b5b102abc3a5cfcd","user":{"login":"scottpurdy","id":239726,"avatar_url":"https://avatars.githubusercontent.com/u/239726?v=3","gravatar_id":"","url":"https://api.github.com/users/scottpurdy","html_url":"https://github.com/scottpurdy","followers_url":"https://api.github.com/users/scottpurdy/followers","following_url":"https://api.github.com/users/scottpurdy/following{/other_user}","gists_url":"https://api.github.com/users/scottpurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/scottpurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottpurdy/subscriptions","organizations_url":"https://api.github.com/users/scottpurdy/orgs","repos_url":"https://api.github.com/users/scottpurdy/repos","events_url":"https://api.github.com/users/scottpurdy/events{/privacy}","received_events_url":"https://api.github.com/users/scottpurdy/received_events","type":"User","site_admin":false},"body":"What is the default format? I'm guessing it is fine if the results are good but we may want to make sure it preserves full precision. I know that `repr(f)` will preserve full precision but I don't know what pandas does.","created_at":"2014-12-13T00:43:44Z","updated_at":"2014-12-13T00:43:44Z","html_url":"https://github.com/numenta/NAB/pull/45#discussion_r21783291","pull_request_url":"https://api.github.com/repos/numenta/NAB/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/numenta/NAB/pulls/comments/21783291"},"html":{"href":"https://github.com/numenta/NAB/pull/45#discussion_r21783291"},"pull_request":{"href":"https://api.github.com/repos/numenta/NAB/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/numenta/NAB/pulls/45","id":26013069,"html_url":"https://github.com/numenta/NAB/pull/45","diff_url":"https://github.com/numenta/NAB/pull/45.diff","patch_url":"https://github.com/numenta/NAB/pull/45.patch","issue_url":"https://api.github.com/repos/numenta/NAB/issues/45","number":45,"state":"open","locked":false,"title":"Removed float spec","user":{"login":"BoltzmannBrain","id":8323700,"avatar_url":"https://avatars.githubusercontent.com/u/8323700?v=3","gravatar_id":"","url":"https://api.github.com/users/BoltzmannBrain","html_url":"https://github.com/BoltzmannBrain","followers_url":"https://api.github.com/users/BoltzmannBrain/followers","following_url":"https://api.github.com/users/BoltzmannBrain/following{/other_user}","gists_url":"https://api.github.com/users/BoltzmannBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltzmannBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltzmannBrain/subscriptions","organizations_url":"https://api.github.com/users/BoltzmannBrain/orgs","repos_url":"https://api.github.com/users/BoltzmannBrain/repos","events_url":"https://api.github.com/users/BoltzmannBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BoltzmannBrain/received_events","type":"User","site_admin":false},"body":"@subutai @scottpurdy please review. This is the rounding bug.","created_at":"2014-12-13T00:33:46Z","updated_at":"2014-12-13T00:43:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42a89baad1166536a8f8ff022a7b0a83d35a5bde","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/numenta/NAB/pulls/45/commits","review_comments_url":"https://api.github.com/repos/numenta/NAB/pulls/45/comments","review_comment_url":"https://api.github.com/repos/numenta/NAB/pulls/comments/{number}","comments_url":"https://api.github.com/repos/numenta/NAB/issues/45/comments","statuses_url":"https://api.github.com/repos/numenta/NAB/statuses/beff77f854ca4564fd711cc2b5b102abc3a5cfcd","head":{"label":"BoltzmannBrain:pandas_rounding","ref":"pandas_rounding","sha":"beff77f854ca4564fd711cc2b5b102abc3a5cfcd","user":{"login":"BoltzmannBrain","id":8323700,"avatar_url":"https://avatars.githubusercontent.com/u/8323700?v=3","gravatar_id":"","url":"https://api.github.com/users/BoltzmannBrain","html_url":"https://github.com/BoltzmannBrain","followers_url":"https://api.github.com/users/BoltzmannBrain/followers","following_url":"https://api.github.com/users/BoltzmannBrain/following{/other_user}","gists_url":"https://api.github.com/users/BoltzmannBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltzmannBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltzmannBrain/subscriptions","organizations_url":"https://api.github.com/users/BoltzmannBrain/orgs","repos_url":"https://api.github.com/users/BoltzmannBrain/repos","events_url":"https://api.github.com/users/BoltzmannBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BoltzmannBrain/received_events","type":"User","site_admin":false},"repo":{"id":27847901,"name":"NAB","full_name":"BoltzmannBrain/NAB","owner":{"login":"BoltzmannBrain","id":8323700,"avatar_url":"https://avatars.githubusercontent.com/u/8323700?v=3","gravatar_id":"","url":"https://api.github.com/users/BoltzmannBrain","html_url":"https://github.com/BoltzmannBrain","followers_url":"https://api.github.com/users/BoltzmannBrain/followers","following_url":"https://api.github.com/users/BoltzmannBrain/following{/other_user}","gists_url":"https://api.github.com/users/BoltzmannBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltzmannBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltzmannBrain/subscriptions","organizations_url":"https://api.github.com/users/BoltzmannBrain/orgs","repos_url":"https://api.github.com/users/BoltzmannBrain/repos","events_url":"https://api.github.com/users/BoltzmannBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BoltzmannBrain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BoltzmannBrain/NAB","description":"The Numenta Anomaly Benchmark","fork":true,"url":"https://api.github.com/repos/BoltzmannBrain/NAB","forks_url":"https://api.github.com/repos/BoltzmannBrain/NAB/forks","keys_url":"https://api.github.com/repos/BoltzmannBrain/NAB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BoltzmannBrain/NAB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BoltzmannBrain/NAB/teams","hooks_url":"https://api.github.com/repos/BoltzmannBrain/NAB/hooks","issue_events_url":"https://api.github.com/repos/BoltzmannBrain/NAB/issues/events{/number}","events_url":"https://api.github.com/repos/BoltzmannBrain/NAB/events","assignees_url":"https://api.github.com/repos/BoltzmannBrain/NAB/assignees{/user}","branches_url":"https://api.github.com/repos/BoltzmannBrain/NAB/branches{/branch}","tags_url":"https://api.github.com/repos/BoltzmannBrain/NAB/tags","blobs_url":"https://api.github.com/repos/BoltzmannBrain/NAB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BoltzmannBrain/NAB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BoltzmannBrain/NAB/git/refs{/sha}","trees_url":"https://api.github.com/repos/BoltzmannBrain/NAB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BoltzmannBrain/NAB/statuses/{sha}","languages_url":"https://api.github.com/repos/BoltzmannBrain/NAB/languages","stargazers_url":"https://api.github.com/repos/BoltzmannBrain/NAB/stargazers","contributors_url":"https://api.github.com/repos/BoltzmannBrain/NAB/contributors","subscribers_url":"https://api.github.com/repos/BoltzmannBrain/NAB/subscribers","subscription_url":"https://api.github.com/repos/BoltzmannBrain/NAB/subscription","commits_url":"https://api.github.com/repos/BoltzmannBrain/NAB/commits{/sha}","git_commits_url":"https://api.github.com/repos/BoltzmannBrain/NAB/git/commits{/sha}","comments_url":"https://api.github.com/repos/BoltzmannBrain/NAB/comments{/number}","issue_comment_url":"https://api.github.com/repos/BoltzmannBrain/NAB/issues/comments/{number}","contents_url":"https://api.github.com/repos/BoltzmannBrain/NAB/contents/{+path}","compare_url":"https://api.github.com/repos/BoltzmannBrain/NAB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BoltzmannBrain/NAB/merges","archive_url":"https://api.github.com/repos/BoltzmannBrain/NAB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BoltzmannBrain/NAB/downloads","issues_url":"https://api.github.com/repos/BoltzmannBrain/NAB/issues{/number}","pulls_url":"https://api.github.com/repos/BoltzmannBrain/NAB/pulls{/number}","milestones_url":"https://api.github.com/repos/BoltzmannBrain/NAB/milestones{/number}","notifications_url":"https://api.github.com/repos/BoltzmannBrain/NAB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BoltzmannBrain/NAB/labels{/name}","releases_url":"https://api.github.com/repos/BoltzmannBrain/NAB/releases{/id}","created_at":"2014-12-11T01:13:18Z","updated_at":"2014-12-11T01:13:21Z","pushed_at":"2014-12-13T00:33:10Z","git_url":"git://github.com/BoltzmannBrain/NAB.git","ssh_url":"git@github.com:BoltzmannBrain/NAB.git","clone_url":"https://github.com/BoltzmannBrain/NAB.git","svn_url":"https://github.com/BoltzmannBrain/NAB","homepage":"","size":8019,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numenta:master","ref":"master","sha":"44b2c831a34aca6003a536e790ced5fd25f012e1","user":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"repo":{"id":19504082,"name":"NAB","full_name":"numenta/NAB","owner":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numenta/NAB","description":"The Numenta Anomaly Benchmark","fork":false,"url":"https://api.github.com/repos/numenta/NAB","forks_url":"https://api.github.com/repos/numenta/NAB/forks","keys_url":"https://api.github.com/repos/numenta/NAB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numenta/NAB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numenta/NAB/teams","hooks_url":"https://api.github.com/repos/numenta/NAB/hooks","issue_events_url":"https://api.github.com/repos/numenta/NAB/issues/events{/number}","events_url":"https://api.github.com/repos/numenta/NAB/events","assignees_url":"https://api.github.com/repos/numenta/NAB/assignees{/user}","branches_url":"https://api.github.com/repos/numenta/NAB/branches{/branch}","tags_url":"https://api.github.com/repos/numenta/NAB/tags","blobs_url":"https://api.github.com/repos/numenta/NAB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numenta/NAB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numenta/NAB/git/refs{/sha}","trees_url":"https://api.github.com/repos/numenta/NAB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numenta/NAB/statuses/{sha}","languages_url":"https://api.github.com/repos/numenta/NAB/languages","stargazers_url":"https://api.github.com/repos/numenta/NAB/stargazers","contributors_url":"https://api.github.com/repos/numenta/NAB/contributors","subscribers_url":"https://api.github.com/repos/numenta/NAB/subscribers","subscription_url":"https://api.github.com/repos/numenta/NAB/subscription","commits_url":"https://api.github.com/repos/numenta/NAB/commits{/sha}","git_commits_url":"https://api.github.com/repos/numenta/NAB/git/commits{/sha}","comments_url":"https://api.github.com/repos/numenta/NAB/comments{/number}","issue_comment_url":"https://api.github.com/repos/numenta/NAB/issues/comments/{number}","contents_url":"https://api.github.com/repos/numenta/NAB/contents/{+path}","compare_url":"https://api.github.com/repos/numenta/NAB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numenta/NAB/merges","archive_url":"https://api.github.com/repos/numenta/NAB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numenta/NAB/downloads","issues_url":"https://api.github.com/repos/numenta/NAB/issues{/number}","pulls_url":"https://api.github.com/repos/numenta/NAB/pulls{/number}","milestones_url":"https://api.github.com/repos/numenta/NAB/milestones{/number}","notifications_url":"https://api.github.com/repos/numenta/NAB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numenta/NAB/labels{/name}","releases_url":"https://api.github.com/repos/numenta/NAB/releases{/id}","created_at":"2014-05-06T17:39:21Z","updated_at":"2014-11-21T11:28:39Z","pushed_at":"2014-11-06T20:46:19Z","git_url":"git://github.com/numenta/NAB.git","ssh_url":"git@github.com:numenta/NAB.git","clone_url":"https://github.com/numenta/NAB.git","svn_url":"https://github.com/numenta/NAB","homepage":"","size":9858,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":21,"forks":10,"open_issues":21,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numenta/NAB/pulls/45"},"html":{"href":"https://github.com/numenta/NAB/pull/45"},"issue":{"href":"https://api.github.com/repos/numenta/NAB/issues/45"},"comments":{"href":"https://api.github.com/repos/numenta/NAB/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/numenta/NAB/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/numenta/NAB/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/numenta/NAB/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/numenta/NAB/statuses/beff77f854ca4564fd711cc2b5b102abc3a5cfcd"}}}}