GitHub PullRequestReviewCommentEvent at 2014-08-07 12:17:31
Repository: boost_python_exception
Actor: abingham
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/abingham/boost_python_exception/pulls/comments/15931834","id":15931834,"diff_hunk":"@@ -0,0 +1,79 @@\n+#ifndef INCLUDE_BOOST_PYTHON_EXCEPTION_PYTHON_VERSION_H\n+#define INCLUDE_BOOST_PYTHON_EXCEPTION_PYTHON_VERSION_H\n+\n+#include <iosfwd>\n+\n+namespace boost_python_exception {\n+\n+\t/**\n+\t * @brief A python version number\n+\t */\n+\tstruct version{\n+\t\t/**\n+\t\t * @brief Major part of version number\n+\t\t */\n+\t\tunsigned int major;\n+\n+\t\t/**\n+\t\t * @brief Minor part of version number\n+\t\t */\n+\t\tunsigned int minor;\n+\n+\t\t/**\n+\t\t * @brief Micro part of version number\n+\t\t */\n+\t\tunsigned int micro;\n+\n+\t\t/**\n+\t\t * @brief Construct a new version object\n+\t\t * @param major Major version (first number)\n+\t\t * @param minor Minor version (second number)\n+\t\t * @param micro Micro version (third number)\n+\t\t */\n+\t\tversion(unsigned int major, unsigned int minor, unsigned int micro);\n+\t};\n+\n+\t/**\n+\t * @brief Compares to versions numbers for identity\n+\t * @param lhs left hand side argument\n+\t * @param rhs right hand side argument\n+\t * @return true if both arguments are in equal major, minor and micro version\n+\t */\n+\tbool operator== (version const& lhs, version const& rhs);\n+\n+\t/**\n+\t * @brief Compares to versions numbers for identity\n+\t * @param lhs left hand side argument\n+\t * @param rhs right hand side argument\n+\t * @return false if both arguments are in equal major, minor and micro version\n+\t */\n+\tbool operator!= (version const& lhs, version const& rhs);\n+\n+\t/**\n+\t * @brief Inserts a psapp::python::version into an output stream","path":"src/boost_python_exception/python_version.hpp","position":53,"original_position":53,"commit_id":"320202979caec2315f04562c5f6c01af1def2a2c","original_commit_id":"dd7238497da0b963b446c166885b581bacda3d96","user":{"login":"abingham","id":79224,"avatar_url":"https://avatars.githubusercontent.com/u/79224?v=2","gravatar_id":"0df634d79a731ee6eeee1b814726abb6","url":"https://api.github.com/users/abingham","html_url":"https://github.com/abingham","followers_url":"https://api.github.com/users/abingham/followers","following_url":"https://api.github.com/users/abingham/following{/other_user}","gists_url":"https://api.github.com/users/abingham/gists{/gist_id}","starred_url":"https://api.github.com/users/abingham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abingham/subscriptions","organizations_url":"https://api.github.com/users/abingham/orgs","repos_url":"https://api.github.com/users/abingham/repos","events_url":"https://api.github.com/users/abingham/events{/privacy}","received_events_url":"https://api.github.com/users/abingham/received_events","type":"User","site_admin":false},"body":"psapp::python is the wrong namespace","created_at":"2014-08-07T12:17:31Z","updated_at":"2014-08-07T12:17:31Z","html_url":"https://github.com/abingham/boost_python_exception/pull/9#discussion_r15931834","pull_request_url":"https://api.github.com/repos/abingham/boost_python_exception/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/abingham/boost_python_exception/pulls/comments/15931834"},"html":{"href":"https://github.com/abingham/boost_python_exception/pull/9#discussion_r15931834"},"pull_request":{"href":"https://api.github.com/repos/abingham/boost_python_exception/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/abingham/boost_python_exception/pulls/9","id":19461363,"html_url":"https://github.com/abingham/boost_python_exception/pull/9","diff_url":"https://github.com/abingham/boost_python_exception/pull/9.diff","patch_url":"https://github.com/abingham/boost_python_exception/pull/9.patch","issue_url":"https://api.github.com/repos/abingham/boost_python_exception/issues/9","number":9,"state":"open","title":"Added python_version() function + struct","user":{"login":"MathMagique","id":8329826,"avatar_url":"https://avatars.githubusercontent.com/u/8329826?v=2","gravatar_id":"846b8ff6a0668d0f6cb2b66e6abc9720","url":"https://api.github.com/users/MathMagique","html_url":"https://github.com/MathMagique","followers_url":"https://api.github.com/users/MathMagique/followers","following_url":"https://api.github.com/users/MathMagique/following{/other_user}","gists_url":"https://api.github.com/users/MathMagique/gists{/gist_id}","starred_url":"https://api.github.com/users/MathMagique/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathMagique/subscriptions","organizations_url":"https://api.github.com/users/MathMagique/orgs","repos_url":"https://api.github.com/users/MathMagique/repos","events_url":"https://api.github.com/users/MathMagique/events{/privacy}","received_events_url":"https://api.github.com/users/MathMagique/received_events","type":"User","site_admin":false},"body":"solves issue #6 ","created_at":"2014-08-07T11:38:59Z","updated_at":"2014-08-07T12:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f77c272e12aae9d98d9443845b479b9f2c8b08e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/abingham/boost_python_exception/pulls/9/commits","review_comments_url":"https://api.github.com/repos/abingham/boost_python_exception/pulls/9/comments","review_comment_url":"https://api.github.com/repos/abingham/boost_python_exception/pulls/comments/{number}","comments_url":"https://api.github.com/repos/abingham/boost_python_exception/issues/9/comments","statuses_url":"https://api.github.com/repos/abingham/boost_python_exception/statuses/320202979caec2315f04562c5f6c01af1def2a2c","head":{"label":"MathMagique:master","ref":"master","sha":"320202979caec2315f04562c5f6c01af1def2a2c","user":{"login":"MathMagique","id":8329826,"avatar_url":"https://avatars.githubusercontent.com/u/8329826?v=2","gravatar_id":"846b8ff6a0668d0f6cb2b66e6abc9720","url":"https://api.github.com/users/MathMagique","html_url":"https://github.com/MathMagique","followers_url":"https://api.github.com/users/MathMagique/followers","following_url":"https://api.github.com/users/MathMagique/following{/other_user}","gists_url":"https://api.github.com/users/MathMagique/gists{/gist_id}","starred_url":"https://api.github.com/users/MathMagique/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathMagique/subscriptions","organizations_url":"https://api.github.com/users/MathMagique/orgs","repos_url":"https://api.github.com/users/MathMagique/repos","events_url":"https://api.github.com/users/MathMagique/events{/privacy}","received_events_url":"https://api.github.com/users/MathMagique/received_events","type":"User","site_admin":false},"repo":{"id":22718728,"name":"boost_python_exception","full_name":"MathMagique/boost_python_exception","owner":{"login":"MathMagique","id":8329826,"avatar_url":"https://avatars.githubusercontent.com/u/8329826?v=2","gravatar_id":"846b8ff6a0668d0f6cb2b66e6abc9720","url":"https://api.github.com/users/MathMagique","html_url":"https://github.com/MathMagique","followers_url":"https://api.github.com/users/MathMagique/followers","following_url":"https://api.github.com/users/MathMagique/following{/other_user}","gists_url":"https://api.github.com/users/MathMagique/gists{/gist_id}","starred_url":"https://api.github.com/users/MathMagique/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathMagique/subscriptions","organizations_url":"https://api.github.com/users/MathMagique/orgs","repos_url":"https://api.github.com/users/MathMagique/repos","events_url":"https://api.github.com/users/MathMagique/events{/privacy}","received_events_url":"https://api.github.com/users/MathMagique/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MathMagique/boost_python_exception","description":"Library to simplify working with Python exceptions when using Boost.Python.","fork":true,"url":"https://api.github.com/repos/MathMagique/boost_python_exception","forks_url":"https://api.github.com/repos/MathMagique/boost_python_exception/forks","keys_url":"https://api.github.com/repos/MathMagique/boost_python_exception/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MathMagique/boost_python_exception/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MathMagique/boost_python_exception/teams","hooks_url":"https://api.github.com/repos/MathMagique/boost_python_exception/hooks","issue_events_url":"https://api.github.com/repos/MathMagique/boost_python_exception/issues/events{/number}","events_url":"https://api.github.com/repos/MathMagique/boost_python_exception/events","assignees_url":"https://api.github.com/repos/MathMagique/boost_python_exception/assignees{/user}","branches_url":"https://api.github.com/repos/MathMagique/boost_python_exception/branches{/branch}","tags_url":"https://api.github.com/repos/MathMagique/boost_python_exception/tags","blobs_url":"https://api.github.com/repos/MathMagique/boost_python_exception/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MathMagique/boost_python_exception/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MathMagique/boost_python_exception/git/refs{/sha}","trees_url":"https://api.github.com/repos/MathMagique/boost_python_exception/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MathMagique/boost_python_exception/statuses/{sha}","languages_url":"https://api.github.com/repos/MathMagique/boost_python_exception/languages","stargazers_url":"https://api.github.com/repos/MathMagique/boost_python_exception/stargazers","contributors_url":"https://api.github.com/repos/MathMagique/boost_python_exception/contributors","subscribers_url":"https://api.github.com/repos/MathMagique/boost_python_exception/subscribers","subscription_url":"https://api.github.com/repos/MathMagique/boost_python_exception/subscription","commits_url":"https://api.github.com/repos/MathMagique/boost_python_exception/commits{/sha}","git_commits_url":"https://api.github.com/repos/MathMagique/boost_python_exception/git/commits{/sha}","comments_url":"https://api.github.com/repos/MathMagique/boost_python_exception/comments{/number}","issue_comment_url":"https://api.github.com/repos/MathMagique/boost_python_exception/issues/comments/{number}","contents_url":"https://api.github.com/repos/MathMagique/boost_python_exception/contents/{+path}","compare_url":"https://api.github.com/repos/MathMagique/boost_python_exception/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MathMagique/boost_python_exception/merges","archive_url":"https://api.github.com/repos/MathMagique/boost_python_exception/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MathMagique/boost_python_exception/downloads","issues_url":"https://api.github.com/repos/MathMagique/boost_python_exception/issues{/number}","pulls_url":"https://api.github.com/repos/MathMagique/boost_python_exception/pulls{/number}","milestones_url":"https://api.github.com/repos/MathMagique/boost_python_exception/milestones{/number}","notifications_url":"https://api.github.com/repos/MathMagique/boost_python_exception/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MathMagique/boost_python_exception/labels{/name}","releases_url":"https://api.github.com/repos/MathMagique/boost_python_exception/releases{/id}","created_at":"2014-08-07T11:22:25Z","updated_at":"2014-08-07T11:36:07Z","pushed_at":"2014-08-07T12:13:12Z","git_url":"git://github.com/MathMagique/boost_python_exception.git","ssh_url":"git@github.com:MathMagique/boost_python_exception.git","clone_url":"https://github.com/MathMagique/boost_python_exception.git","svn_url":"https://github.com/MathMagique/boost_python_exception","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abingham:master","ref":"master","sha":"93f59a8d0a785c5720597eb45f247ef0194f1c86","user":{"login":"abingham","id":79224,"avatar_url":"https://avatars.githubusercontent.com/u/79224?v=2","gravatar_id":"0df634d79a731ee6eeee1b814726abb6","url":"https://api.github.com/users/abingham","html_url":"https://github.com/abingham","followers_url":"https://api.github.com/users/abingham/followers","following_url":"https://api.github.com/users/abingham/following{/other_user}","gists_url":"https://api.github.com/users/abingham/gists{/gist_id}","starred_url":"https://api.github.com/users/abingham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abingham/subscriptions","organizations_url":"https://api.github.com/users/abingham/orgs","repos_url":"https://api.github.com/users/abingham/repos","events_url":"https://api.github.com/users/abingham/events{/privacy}","received_events_url":"https://api.github.com/users/abingham/received_events","type":"User","site_admin":false},"repo":{"id":22575043,"name":"boost_python_exception","full_name":"abingham/boost_python_exception","owner":{"login":"abingham","id":79224,"avatar_url":"https://avatars.githubusercontent.com/u/79224?v=2","gravatar_id":"0df634d79a731ee6eeee1b814726abb6","url":"https://api.github.com/users/abingham","html_url":"https://github.com/abingham","followers_url":"https://api.github.com/users/abingham/followers","following_url":"https://api.github.com/users/abingham/following{/other_user}","gists_url":"https://api.github.com/users/abingham/gists{/gist_id}","starred_url":"https://api.github.com/users/abingham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abingham/subscriptions","organizations_url":"https://api.github.com/users/abingham/orgs","repos_url":"https://api.github.com/users/abingham/repos","events_url":"https://api.github.com/users/abingham/events{/privacy}","received_events_url":"https://api.github.com/users/abingham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abingham/boost_python_exception","description":"Library to simplify working with Python exceptions when using Boost.Python.","fork":false,"url":"https://api.github.com/repos/abingham/boost_python_exception","forks_url":"https://api.github.com/repos/abingham/boost_python_exception/forks","keys_url":"https://api.github.com/repos/abingham/boost_python_exception/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abingham/boost_python_exception/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abingham/boost_python_exception/teams","hooks_url":"https://api.github.com/repos/abingham/boost_python_exception/hooks","issue_events_url":"https://api.github.com/repos/abingham/boost_python_exception/issues/events{/number}","events_url":"https://api.github.com/repos/abingham/boost_python_exception/events","assignees_url":"https://api.github.com/repos/abingham/boost_python_exception/assignees{/user}","branches_url":"https://api.github.com/repos/abingham/boost_python_exception/branches{/branch}","tags_url":"https://api.github.com/repos/abingham/boost_python_exception/tags","blobs_url":"https://api.github.com/repos/abingham/boost_python_exception/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abingham/boost_python_exception/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abingham/boost_python_exception/git/refs{/sha}","trees_url":"https://api.github.com/repos/abingham/boost_python_exception/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abingham/boost_python_exception/statuses/{sha}","languages_url":"https://api.github.com/repos/abingham/boost_python_exception/languages","stargazers_url":"https://api.github.com/repos/abingham/boost_python_exception/stargazers","contributors_url":"https://api.github.com/repos/abingham/boost_python_exception/contributors","subscribers_url":"https://api.github.com/repos/abingham/boost_python_exception/subscribers","subscription_url":"https://api.github.com/repos/abingham/boost_python_exception/subscription","commits_url":"https://api.github.com/repos/abingham/boost_python_exception/commits{/sha}","git_commits_url":"https://api.github.com/repos/abingham/boost_python_exception/git/commits{/sha}","comments_url":"https://api.github.com/repos/abingham/boost_python_exception/comments{/number}","issue_comment_url":"https://api.github.com/repos/abingham/boost_python_exception/issues/comments/{number}","contents_url":"https://api.github.com/repos/abingham/boost_python_exception/contents/{+path}","compare_url":"https://api.github.com/repos/abingham/boost_python_exception/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abingham/boost_python_exception/merges","archive_url":"https://api.github.com/repos/abingham/boost_python_exception/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abingham/boost_python_exception/downloads","issues_url":"https://api.github.com/repos/abingham/boost_python_exception/issues{/number}","pulls_url":"https://api.github.com/repos/abingham/boost_python_exception/pulls{/number}","milestones_url":"https://api.github.com/repos/abingham/boost_python_exception/milestones{/number}","notifications_url":"https://api.github.com/repos/abingham/boost_python_exception/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abingham/boost_python_exception/labels{/name}","releases_url":"https://api.github.com/repos/abingham/boost_python_exception/releases{/id}","created_at":"2014-08-03T13:08:35Z","updated_at":"2014-08-03T13:13:40Z","pushed_at":"2014-08-07T05:36:16Z","git_url":"git://github.com/abingham/boost_python_exception.git","ssh_url":"git@github.com:abingham/boost_python_exception.git","clone_url":"https://github.com/abingham/boost_python_exception.git","svn_url":"https://github.com/abingham/boost_python_exception","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abingham/boost_python_exception/pulls/9"},"html":{"href":"https://github.com/abingham/boost_python_exception/pull/9"},"issue":{"href":"https://api.github.com/repos/abingham/boost_python_exception/issues/9"},"comments":{"href":"https://api.github.com/repos/abingham/boost_python_exception/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/abingham/boost_python_exception/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/abingham/boost_python_exception/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/abingham/boost_python_exception/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/abingham/boost_python_exception/statuses/320202979caec2315f04562c5f6c01af1def2a2c"}}}}