GitHub PushEvent at 2014-10-26 23:21:38
Repository: reddit
Actor: iKevinY
Payload: {"shas":[["59fe54f754c988b987b92c67c67e0fc5c64c6d45","8acd4149124f558cb3ad67060944a65cee55a3b9@gmail.com","Send gold intro message to users claiming codes","Chad Birch",true],["18e59c5c538049a9e7317cc78e6cbbf91355d36f","8acd4149124f558cb3ad67060944a65cee55a3b9@gmail.com","Add features/benefits link to gold remaining box","Chad Birch",true],["94e7b31c45e6207c3eb3d76795d173a71cac29fa","093951bb2639c3ae4fa13749e64f8f80cf765b24@reddit.com","Details:  Allow 'listing_only' for AJAX purposes","Roger Ostrander",true],["e276a9dbd7d23051908071599432dab75a34e246","822ec91a7ef82248fd36162ca8ac3283eba70848@reddit.com","Websockets: add metrics for connection time and failures.\n\nThis should hopefully give us better insight into how sutro's holding up\nfrom the client perspective and potentially allow for earlier alerting\non failures.","Neil Williams",true],["fa0a371d42fb4d0229fbe6c44b1dbdc792befb5c","68fe070e4407f91e770af0da719da91010ad5df4@gmail.com","Pad submit buttons\n\nI noticed that in Chrome, some of our buttons had no padding at all, which made\nthem look terrible.  Others, however, were fine.  This turned out to be a\ndifferent between `<input type=\"submit\">` and `<button>` elements.  The easiest\nplace to see this was comparing the save buttons on `/prefs` (ugly) and any of\nthe other preferences tabs (pretty).\n\nIn `reddit.less`, we reset the margin and padding of a whole bunch of elements\nto be 0.  `<input>`s are in this list, although `<button>`s are not.\\*  Thus,\nno padding.\n\nNow we set the padding `<button>`s and select types of `<input>`s.  I chose the\nrules from what Chrome automatically applies, since that seemed like a\nreasonable default.\n\nFirefox notably ignored the `padding: 0` before, and continues to ignore\nwhatever I set, with the result that it looked good before and still looks\ngood now.  Whatever.\n\n----\n\n\\* I decided not to add a reset of button margin and padding.  Padding we now\nset again to something useful, per this commit, but margin could have effects\nacross the site that I didn't want to track down.","xiongchiamiov",true],["5a2250c2bd89b2d9c4518bf8148f660748df4cc4","4e13656a33b70868610c094ac5d2ed59a423f7f5@saynotolinux.com","Whitelist publicly-visible attributes on private subreddits\n\nThis plugs a hole where you could get the number of subscribers\nof a private subreddit. Thanks to /u/GoldenSights for the report\n\nPreviously a blacklist was used to drop private attrs,\nbut a whitelist is less likely to result in info leakage when\nnew attributes are added.","Jordan Milne",true],["f701b678799905506bc5ade9149ade336824259c","4e13656a33b70868610c094ac5d2ed59a423f7f5@saynotolinux.com","Handle backslash trickery in VDestination","Jordan Milne",true]],"size":7,"ref":"refs/heads/master","head":"f701b678799905506bc5ade9149ade336824259c"}