GitHub PullRequestEvent at 2014-05-01 16:56:28
Repository: NLog
Actor: Xharze
Payload: {"action":"closed","number":336,"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/336","id":15389036,"html_url":"https://github.com/NLog/NLog/pull/336","diff_url":"https://github.com/NLog/NLog/pull/336.diff","patch_url":"https://github.com/NLog/NLog/pull/336.patch","issue_url":"https://api.github.com/repos/NLog/NLog/issues/336","number":336,"state":"closed","title":"Fix for invalid XML characters in Log4JXmlEventLayoutRenderer","user":{"login":"JvanderStad","id":5426370,"avatar_url":"https://avatars.githubusercontent.com/u/5426370?","gravatar_id":"7bdc45839e5e4fa8a365c87967ad3615","url":"https://api.github.com/users/JvanderStad","html_url":"https://github.com/JvanderStad","followers_url":"https://api.github.com/users/JvanderStad/followers","following_url":"https://api.github.com/users/JvanderStad/following{/other_user}","gists_url":"https://api.github.com/users/JvanderStad/gists{/gist_id}","starred_url":"https://api.github.com/users/JvanderStad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JvanderStad/subscriptions","organizations_url":"https://api.github.com/users/JvanderStad/orgs","repos_url":"https://api.github.com/users/JvanderStad/repos","events_url":"https://api.github.com/users/JvanderStad/events{/privacy}","received_events_url":"https://api.github.com/users/JvanderStad/received_events","type":"User","site_admin":false},"body":"Added a helper class for handling invalid XML characters (Use in Log4JXmlEventLayoutRenderer)\r\n\r\nI'm using a external obfuscated dll.. They used obfuscated method names which contain invalid XML characters. The XmlWriter methods in Log4JXmlEventLayoutRenderer could not handle them.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/5426370/2852781/27ccdd64-d13b-11e3-8ac8-72640b39d02a.png)\r\n\r\nI created extension methods which filters the invalid XML-characters..","created_at":"2014-05-01T14:20:15Z","updated_at":"2014-05-01T16:56:28Z","closed_at":"2014-05-01T16:56:28Z","merged_at":"2014-05-01T16:56:28Z","merge_commit_sha":"23a55577ed0627366fd8d91ca4eb368e1187a0c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NLog/NLog/pulls/336/commits","review_comments_url":"https://api.github.com/repos/NLog/NLog/pulls/336/comments","review_comment_url":"https://api.github.com/repos/NLog/NLog/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/336/comments","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/26f18708c86201a6c6665ea948c67d18102a870d","head":{"label":"JvanderStad:fix/invalid-characters-in-xml","ref":"fix/invalid-characters-in-xml","sha":"26f18708c86201a6c6665ea948c67d18102a870d","user":{"login":"JvanderStad","id":5426370,"avatar_url":"https://avatars.githubusercontent.com/u/5426370?","gravatar_id":"7bdc45839e5e4fa8a365c87967ad3615","url":"https://api.github.com/users/JvanderStad","html_url":"https://github.com/JvanderStad","followers_url":"https://api.github.com/users/JvanderStad/followers","following_url":"https://api.github.com/users/JvanderStad/following{/other_user}","gists_url":"https://api.github.com/users/JvanderStad/gists{/gist_id}","starred_url":"https://api.github.com/users/JvanderStad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JvanderStad/subscriptions","organizations_url":"https://api.github.com/users/JvanderStad/orgs","repos_url":"https://api.github.com/users/JvanderStad/repos","events_url":"https://api.github.com/users/JvanderStad/events{/privacy}","received_events_url":"https://api.github.com/users/JvanderStad/received_events","type":"User","site_admin":false},"repo":{"id":19344065,"name":"NLog","full_name":"JvanderStad/NLog","owner":{"login":"JvanderStad","id":5426370,"avatar_url":"https://avatars.githubusercontent.com/u/5426370?","gravatar_id":"7bdc45839e5e4fa8a365c87967ad3615","url":"https://api.github.com/users/JvanderStad","html_url":"https://github.com/JvanderStad","followers_url":"https://api.github.com/users/JvanderStad/followers","following_url":"https://api.github.com/users/JvanderStad/following{/other_user}","gists_url":"https://api.github.com/users/JvanderStad/gists{/gist_id}","starred_url":"https://api.github.com/users/JvanderStad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JvanderStad/subscriptions","organizations_url":"https://api.github.com/users/JvanderStad/orgs","repos_url":"https://api.github.com/users/JvanderStad/repos","events_url":"https://api.github.com/users/JvanderStad/events{/privacy}","received_events_url":"https://api.github.com/users/JvanderStad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JvanderStad/NLog","description":"NLog - Advanced .NET and Silverlight Logging","fork":true,"url":"https://api.github.com/repos/JvanderStad/NLog","forks_url":"https://api.github.com/repos/JvanderStad/NLog/forks","keys_url":"https://api.github.com/repos/JvanderStad/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JvanderStad/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JvanderStad/NLog/teams","hooks_url":"https://api.github.com/repos/JvanderStad/NLog/hooks","issue_events_url":"https://api.github.com/repos/JvanderStad/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/JvanderStad/NLog/events","assignees_url":"https://api.github.com/repos/JvanderStad/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/JvanderStad/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/JvanderStad/NLog/tags","blobs_url":"https://api.github.com/repos/JvanderStad/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JvanderStad/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JvanderStad/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/JvanderStad/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JvanderStad/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/JvanderStad/NLog/languages","stargazers_url":"https://api.github.com/repos/JvanderStad/NLog/stargazers","contributors_url":"https://api.github.com/repos/JvanderStad/NLog/contributors","subscribers_url":"https://api.github.com/repos/JvanderStad/NLog/subscribers","subscription_url":"https://api.github.com/repos/JvanderStad/NLog/subscription","commits_url":"https://api.github.com/repos/JvanderStad/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/JvanderStad/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/JvanderStad/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/JvanderStad/NLog/issues/comments/{number}","contents_url":"https://api.github.com/repos/JvanderStad/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/JvanderStad/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JvanderStad/NLog/merges","archive_url":"https://api.github.com/repos/JvanderStad/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JvanderStad/NLog/downloads","issues_url":"https://api.github.com/repos/JvanderStad/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/JvanderStad/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/JvanderStad/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/JvanderStad/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JvanderStad/NLog/labels{/name}","releases_url":"https://api.github.com/repos/JvanderStad/NLog/releases{/id}","created_at":"2014-05-01T12:43:28Z","updated_at":"2014-05-01T16:56:28Z","pushed_at":"2014-05-01T14:14:59Z","git_url":"git://github.com/JvanderStad/NLog.git","ssh_url":"git@github.com:JvanderStad/NLog.git","clone_url":"https://github.com/JvanderStad/NLog.git","svn_url":"https://github.com/JvanderStad/NLog","homepage":null,"size":44618,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NLog:master","ref":"master","sha":"3f21263b21dcaa6716ea7651253fcb41d0e751db","user":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?","gravatar_id":"62ebe04b5080ab8153460da594fde43d","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?","gravatar_id":"62ebe04b5080ab8153460da594fde43d","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced .NET and Silverlight Logging","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments/{number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","created_at":"2012-09-12T13:49:29Z","updated_at":"2014-05-01T16:56:28Z","pushed_at":"2014-05-01T16:56:28Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":null,"size":56484,"stargazers_count":485,"watchers_count":485,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":192,"mirror_url":null,"open_issues_count":127,"forks":192,"open_issues":127,"watchers":485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/336"},"html":{"href":"https://github.com/NLog/NLog/pull/336"},"issue":{"href":"https://api.github.com/repos/NLog/NLog/issues/336"},"comments":{"href":"https://api.github.com/repos/NLog/NLog/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/NLog/NLog/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NLog/NLog/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/NLog/NLog/statuses/26f18708c86201a6c6665ea948c67d18102a870d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Xharze","id":498258,"avatar_url":"https://avatars.githubusercontent.com/u/498258?","gravatar_id":"a03f4d56e65571977ce1b5eb270b46e3","url":"https://api.github.com/users/Xharze","html_url":"https://github.com/Xharze","followers_url":"https://api.github.com/users/Xharze/followers","following_url":"https://api.github.com/users/Xharze/following{/other_user}","gists_url":"https://api.github.com/users/Xharze/gists{/gist_id}","starred_url":"https://api.github.com/users/Xharze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xharze/subscriptions","organizations_url":"https://api.github.com/users/Xharze/orgs","repos_url":"https://api.github.com/users/Xharze/repos","events_url":"https://api.github.com/users/Xharze/events{/privacy}","received_events_url":"https://api.github.com/users/Xharze/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":106,"deletions":27,"changed_files":3}}