GitHub PullRequestEvent at 2014-04-21 14:05:28
Repository: rust-http
Actor: chris-morgan
Payload: {"action":"closed","number":79,"pull_request":{"url":"https://api.github.com/repos/chris-morgan/rust-http/pulls/79","id":14693833,"html_url":"https://github.com/chris-morgan/rust-http/pull/79","diff_url":"https://github.com/chris-morgan/rust-http/pull/79.diff","patch_url":"https://github.com/chris-morgan/rust-http/pull/79.patch","issue_url":"https://api.github.com/repos/chris-morgan/rust-http/issues/79","number":79,"state":"closed","title":"Remove mut ~str, use std::strbuf::StrBuf","user":{"login":"richo","id":476418,"avatar_url":"https://avatars.githubusercontent.com/u/476418?","gravatar_id":"f39a093535874d323647c1cb64a6e36b","url":"https://api.github.com/users/richo","html_url":"https://github.com/richo","followers_url":"https://api.github.com/users/richo/followers","following_url":"https://api.github.com/users/richo/following{/other_user}","gists_url":"https://api.github.com/users/richo/gists{/gist_id}","starred_url":"https://api.github.com/users/richo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richo/subscriptions","organizations_url":"https://api.github.com/users/richo/orgs","repos_url":"https://api.github.com/users/richo/repos","events_url":"https://api.github.com/users/richo/events{/privacy}","received_events_url":"https://api.github.com/users/richo/received_events","type":"User","site_admin":false},"body":"Per mozilla/rust@d8e45ea7c054b4ad6fb82ec3a9fcf1736b4d7260 this ports all\r\nuses of ~str as temporary vectors to use StrBuf instead.\r\n\r\nThere are places where I'm doing lots of really fiddly type juggling\r\ninside functions that could absolutely be ported to just use StrBuf as\r\nthe interface, but this would break compatibility outside of them\r\n(insofar as it does already- this library totally explodes on a post\r\nd8e45ea7c rust)","created_at":"2014-04-13T12:31:04Z","updated_at":"2014-04-21T14:05:27Z","closed_at":"2014-04-21T14:05:27Z","merged_at":"2014-04-21T14:05:27Z","merge_commit_sha":"18680717c2bb1f733e16122195bad3aefd02cd7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chris-morgan/rust-http/pulls/79/commits","review_comments_url":"https://api.github.com/repos/chris-morgan/rust-http/pulls/79/comments","review_comment_url":"https://api.github.com/repos/chris-morgan/rust-http/pulls/comments/{number}","comments_url":"https://api.github.com/repos/chris-morgan/rust-http/issues/79/comments","statuses_url":"https://api.github.com/repos/chris-morgan/rust-http/statuses/6663480b1d2c5f24b777d5c3ef9d9614c97cb5b0","head":{"label":"richo:use_str_buf","ref":"use_str_buf","sha":"6663480b1d2c5f24b777d5c3ef9d9614c97cb5b0","user":{"login":"richo","id":476418,"avatar_url":"https://avatars.githubusercontent.com/u/476418?","gravatar_id":"f39a093535874d323647c1cb64a6e36b","url":"https://api.github.com/users/richo","html_url":"https://github.com/richo","followers_url":"https://api.github.com/users/richo/followers","following_url":"https://api.github.com/users/richo/following{/other_user}","gists_url":"https://api.github.com/users/richo/gists{/gist_id}","starred_url":"https://api.github.com/users/richo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richo/subscriptions","organizations_url":"https://api.github.com/users/richo/orgs","repos_url":"https://api.github.com/users/richo/repos","events_url":"https://api.github.com/users/richo/events{/privacy}","received_events_url":"https://api.github.com/users/richo/received_events","type":"User","site_admin":false},"repo":{"id":18728680,"name":"rust-http","full_name":"richo/rust-http","owner":{"login":"richo","id":476418,"avatar_url":"https://avatars.githubusercontent.com/u/476418?","gravatar_id":"f39a093535874d323647c1cb64a6e36b","url":"https://api.github.com/users/richo","html_url":"https://github.com/richo","followers_url":"https://api.github.com/users/richo/followers","following_url":"https://api.github.com/users/richo/following{/other_user}","gists_url":"https://api.github.com/users/richo/gists{/gist_id}","starred_url":"https://api.github.com/users/richo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richo/subscriptions","organizations_url":"https://api.github.com/users/richo/orgs","repos_url":"https://api.github.com/users/richo/repos","events_url":"https://api.github.com/users/richo/events{/privacy}","received_events_url":"https://api.github.com/users/richo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richo/rust-http","description":"Rust HTTP library (server and client)","fork":true,"url":"https://api.github.com/repos/richo/rust-http","forks_url":"https://api.github.com/repos/richo/rust-http/forks","keys_url":"https://api.github.com/repos/richo/rust-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richo/rust-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richo/rust-http/teams","hooks_url":"https://api.github.com/repos/richo/rust-http/hooks","issue_events_url":"https://api.github.com/repos/richo/rust-http/issues/events{/number}","events_url":"https://api.github.com/repos/richo/rust-http/events","assignees_url":"https://api.github.com/repos/richo/rust-http/assignees{/user}","branches_url":"https://api.github.com/repos/richo/rust-http/branches{/branch}","tags_url":"https://api.github.com/repos/richo/rust-http/tags","blobs_url":"https://api.github.com/repos/richo/rust-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richo/rust-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richo/rust-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/richo/rust-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richo/rust-http/statuses/{sha}","languages_url":"https://api.github.com/repos/richo/rust-http/languages","stargazers_url":"https://api.github.com/repos/richo/rust-http/stargazers","contributors_url":"https://api.github.com/repos/richo/rust-http/contributors","subscribers_url":"https://api.github.com/repos/richo/rust-http/subscribers","subscription_url":"https://api.github.com/repos/richo/rust-http/subscription","commits_url":"https://api.github.com/repos/richo/rust-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/richo/rust-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/richo/rust-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/richo/rust-http/issues/comments/{number}","contents_url":"https://api.github.com/repos/richo/rust-http/contents/{+path}","compare_url":"https://api.github.com/repos/richo/rust-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richo/rust-http/merges","archive_url":"https://api.github.com/repos/richo/rust-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richo/rust-http/downloads","issues_url":"https://api.github.com/repos/richo/rust-http/issues{/number}","pulls_url":"https://api.github.com/repos/richo/rust-http/pulls{/number}","milestones_url":"https://api.github.com/repos/richo/rust-http/milestones{/number}","notifications_url":"https://api.github.com/repos/richo/rust-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richo/rust-http/labels{/name}","releases_url":"https://api.github.com/repos/richo/rust-http/releases{/id}","created_at":"2014-04-13T12:28:32Z","updated_at":"2014-04-21T14:05:27Z","pushed_at":"2014-04-19T20:55:02Z","git_url":"git://github.com/richo/rust-http.git","ssh_url":"git@github.com:richo/rust-http.git","clone_url":"https://github.com/richo/rust-http.git","svn_url":"https://github.com/richo/rust-http","homepage":null,"size":828,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chris-morgan:master","ref":"master","sha":"94f13f7e7059584ac2b4339a03e811ccaad61a81","user":{"login":"chris-morgan","id":392868,"avatar_url":"https://avatars.githubusercontent.com/u/392868?","gravatar_id":"16a138ff3b9c8f1663f8a0613c47b60a","url":"https://api.github.com/users/chris-morgan","html_url":"https://github.com/chris-morgan","followers_url":"https://api.github.com/users/chris-morgan/followers","following_url":"https://api.github.com/users/chris-morgan/following{/other_user}","gists_url":"https://api.github.com/users/chris-morgan/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-morgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-morgan/subscriptions","organizations_url":"https://api.github.com/users/chris-morgan/orgs","repos_url":"https://api.github.com/users/chris-morgan/repos","events_url":"https://api.github.com/users/chris-morgan/events{/privacy}","received_events_url":"https://api.github.com/users/chris-morgan/received_events","type":"User","site_admin":false},"repo":{"id":11979541,"name":"rust-http","full_name":"chris-morgan/rust-http","owner":{"login":"chris-morgan","id":392868,"avatar_url":"https://avatars.githubusercontent.com/u/392868?","gravatar_id":"16a138ff3b9c8f1663f8a0613c47b60a","url":"https://api.github.com/users/chris-morgan","html_url":"https://github.com/chris-morgan","followers_url":"https://api.github.com/users/chris-morgan/followers","following_url":"https://api.github.com/users/chris-morgan/following{/other_user}","gists_url":"https://api.github.com/users/chris-morgan/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-morgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-morgan/subscriptions","organizations_url":"https://api.github.com/users/chris-morgan/orgs","repos_url":"https://api.github.com/users/chris-morgan/repos","events_url":"https://api.github.com/users/chris-morgan/events{/privacy}","received_events_url":"https://api.github.com/users/chris-morgan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chris-morgan/rust-http","description":"Rust HTTP library (server and client)","fork":false,"url":"https://api.github.com/repos/chris-morgan/rust-http","forks_url":"https://api.github.com/repos/chris-morgan/rust-http/forks","keys_url":"https://api.github.com/repos/chris-morgan/rust-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chris-morgan/rust-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chris-morgan/rust-http/teams","hooks_url":"https://api.github.com/repos/chris-morgan/rust-http/hooks","issue_events_url":"https://api.github.com/repos/chris-morgan/rust-http/issues/events{/number}","events_url":"https://api.github.com/repos/chris-morgan/rust-http/events","assignees_url":"https://api.github.com/repos/chris-morgan/rust-http/assignees{/user}","branches_url":"https://api.github.com/repos/chris-morgan/rust-http/branches{/branch}","tags_url":"https://api.github.com/repos/chris-morgan/rust-http/tags","blobs_url":"https://api.github.com/repos/chris-morgan/rust-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chris-morgan/rust-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chris-morgan/rust-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/chris-morgan/rust-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chris-morgan/rust-http/statuses/{sha}","languages_url":"https://api.github.com/repos/chris-morgan/rust-http/languages","stargazers_url":"https://api.github.com/repos/chris-morgan/rust-http/stargazers","contributors_url":"https://api.github.com/repos/chris-morgan/rust-http/contributors","subscribers_url":"https://api.github.com/repos/chris-morgan/rust-http/subscribers","subscription_url":"https://api.github.com/repos/chris-morgan/rust-http/subscription","commits_url":"https://api.github.com/repos/chris-morgan/rust-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/chris-morgan/rust-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/chris-morgan/rust-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/chris-morgan/rust-http/issues/comments/{number}","contents_url":"https://api.github.com/repos/chris-morgan/rust-http/contents/{+path}","compare_url":"https://api.github.com/repos/chris-morgan/rust-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chris-morgan/rust-http/merges","archive_url":"https://api.github.com/repos/chris-morgan/rust-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chris-morgan/rust-http/downloads","issues_url":"https://api.github.com/repos/chris-morgan/rust-http/issues{/number}","pulls_url":"https://api.github.com/repos/chris-morgan/rust-http/pulls{/number}","milestones_url":"https://api.github.com/repos/chris-morgan/rust-http/milestones{/number}","notifications_url":"https://api.github.com/repos/chris-morgan/rust-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chris-morgan/rust-http/labels{/name}","releases_url":"https://api.github.com/repos/chris-morgan/rust-http/releases{/id}","created_at":"2013-08-08T15:20:23Z","updated_at":"2014-04-21T14:05:27Z","pushed_at":"2014-04-21T14:05:27Z","git_url":"git://github.com/chris-morgan/rust-http.git","ssh_url":"git@github.com:chris-morgan/rust-http.git","clone_url":"https://github.com/chris-morgan/rust-http.git","svn_url":"https://github.com/chris-morgan/rust-http","homepage":null,"size":2217,"stargazers_count":238,"watchers_count":238,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":66,"mirror_url":null,"open_issues_count":11,"forks":66,"open_issues":11,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chris-morgan/rust-http/pulls/79"},"html":{"href":"https://github.com/chris-morgan/rust-http/pull/79"},"issue":{"href":"https://api.github.com/repos/chris-morgan/rust-http/issues/79"},"comments":{"href":"https://api.github.com/repos/chris-morgan/rust-http/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/chris-morgan/rust-http/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/chris-morgan/rust-http/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/chris-morgan/rust-http/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/chris-morgan/rust-http/statuses/6663480b1d2c5f24b777d5c3ef9d9614c97cb5b0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chris-morgan","id":392868,"avatar_url":"https://avatars.githubusercontent.com/u/392868?","gravatar_id":"16a138ff3b9c8f1663f8a0613c47b60a","url":"https://api.github.com/users/chris-morgan","html_url":"https://github.com/chris-morgan","followers_url":"https://api.github.com/users/chris-morgan/followers","following_url":"https://api.github.com/users/chris-morgan/following{/other_user}","gists_url":"https://api.github.com/users/chris-morgan/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-morgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-morgan/subscriptions","organizations_url":"https://api.github.com/users/chris-morgan/orgs","repos_url":"https://api.github.com/users/chris-morgan/repos","events_url":"https://api.github.com/users/chris-morgan/events{/privacy}","received_events_url":"https://api.github.com/users/chris-morgan/received_events","type":"User","site_admin":false},"comments":10,"review_comments":12,"commits":5,"additions":395,"deletions":395,"changed_files":27}}