GitHub PullRequestReviewCommentEvent at 2014-12-15 20:21:20
Repository: dustjacket
Actor: totherik
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aredridel/dustjacket/pulls/comments/21853471","id":21853471,"diff_hunk":"@@ -5,49 +5,78 @@\n         if (dust.addLoadMiddleware) return;\n \n         var originalLoader = dust.onLoad;\n-        var middlewares = [];\n+        var middlewares = [\n+            defaultCacheLoader\n+        ];\n \n         dust.addLoadMiddleware = addLoadMiddleware;\n+        dust.clearMiddleware = clearMiddleware;\n \n         function addLoadMiddleware(middleware) {\n             middlewares.push(middleware);\n         }\n \n-        dust.onLoad = load;\n+        function clearMiddleware() {\n+            middlewares = [];","path":"index.js","position":18,"original_position":18,"commit_id":"4f0200cadab205e79d64c32743eb834098eeabae","original_commit_id":"4f0200cadab205e79d64c32743eb834098eeabae","user":{"login":"totherik","id":412006,"avatar_url":"https://avatars.githubusercontent.com/u/412006?v=3","gravatar_id":"","url":"https://api.github.com/users/totherik","html_url":"https://github.com/totherik","followers_url":"https://api.github.com/users/totherik/followers","following_url":"https://api.github.com/users/totherik/following{/other_user}","gists_url":"https://api.github.com/users/totherik/gists{/gist_id}","starred_url":"https://api.github.com/users/totherik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totherik/subscriptions","organizations_url":"https://api.github.com/users/totherik/orgs","repos_url":"https://api.github.com/users/totherik/repos","events_url":"https://api.github.com/users/totherik/events{/privacy}","received_events_url":"https://api.github.com/users/totherik/received_events","type":"User","site_admin":false},"body":"should there be a `reset` in addition to, or instead of, `clear`? Once cleared there's no way (unless I'm misreading) to get back to original state (if that's even desirable)","created_at":"2014-12-15T20:21:20Z","updated_at":"2014-12-15T20:21:20Z","html_url":"https://github.com/aredridel/dustjacket/pull/2#discussion_r21853471","pull_request_url":"https://api.github.com/repos/aredridel/dustjacket/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/aredridel/dustjacket/pulls/comments/21853471"},"html":{"href":"https://github.com/aredridel/dustjacket/pull/2#discussion_r21853471"},"pull_request":{"href":"https://api.github.com/repos/aredridel/dustjacket/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/aredridel/dustjacket/pulls/2","id":26091042,"html_url":"https://github.com/aredridel/dustjacket/pull/2","diff_url":"https://github.com/aredridel/dustjacket/pull/2.diff","patch_url":"https://github.com/aredridel/dustjacket/pull/2.patch","issue_url":"https://api.github.com/repos/aredridel/dustjacket/issues/2","number":2,"state":"open","locked":false,"title":"Rework loader middleware to be a replacement for dust.load, rather than shimmed into dust.onLoad","user":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"body":null,"created_at":"2014-12-15T18:39:56Z","updated_at":"2014-12-15T20:21:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"210c8e3173c0733c62fa51eee2a3c83e445df142","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aredridel/dustjacket/pulls/2/commits","review_comments_url":"https://api.github.com/repos/aredridel/dustjacket/pulls/2/comments","review_comment_url":"https://api.github.com/repos/aredridel/dustjacket/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aredridel/dustjacket/issues/2/comments","statuses_url":"https://api.github.com/repos/aredridel/dustjacket/statuses/4f0200cadab205e79d64c32743eb834098eeabae","head":{"label":"aredridel:loader-improvements","ref":"loader-improvements","sha":"4f0200cadab205e79d64c32743eb834098eeabae","user":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"repo":{"id":27453511,"name":"dustjacket","full_name":"aredridel/dustjacket","owner":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aredridel/dustjacket","description":"Loader middleware for dustjs","fork":false,"url":"https://api.github.com/repos/aredridel/dustjacket","forks_url":"https://api.github.com/repos/aredridel/dustjacket/forks","keys_url":"https://api.github.com/repos/aredridel/dustjacket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aredridel/dustjacket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aredridel/dustjacket/teams","hooks_url":"https://api.github.com/repos/aredridel/dustjacket/hooks","issue_events_url":"https://api.github.com/repos/aredridel/dustjacket/issues/events{/number}","events_url":"https://api.github.com/repos/aredridel/dustjacket/events","assignees_url":"https://api.github.com/repos/aredridel/dustjacket/assignees{/user}","branches_url":"https://api.github.com/repos/aredridel/dustjacket/branches{/branch}","tags_url":"https://api.github.com/repos/aredridel/dustjacket/tags","blobs_url":"https://api.github.com/repos/aredridel/dustjacket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aredridel/dustjacket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aredridel/dustjacket/git/refs{/sha}","trees_url":"https://api.github.com/repos/aredridel/dustjacket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aredridel/dustjacket/statuses/{sha}","languages_url":"https://api.github.com/repos/aredridel/dustjacket/languages","stargazers_url":"https://api.github.com/repos/aredridel/dustjacket/stargazers","contributors_url":"https://api.github.com/repos/aredridel/dustjacket/contributors","subscribers_url":"https://api.github.com/repos/aredridel/dustjacket/subscribers","subscription_url":"https://api.github.com/repos/aredridel/dustjacket/subscription","commits_url":"https://api.github.com/repos/aredridel/dustjacket/commits{/sha}","git_commits_url":"https://api.github.com/repos/aredridel/dustjacket/git/commits{/sha}","comments_url":"https://api.github.com/repos/aredridel/dustjacket/comments{/number}","issue_comment_url":"https://api.github.com/repos/aredridel/dustjacket/issues/comments/{number}","contents_url":"https://api.github.com/repos/aredridel/dustjacket/contents/{+path}","compare_url":"https://api.github.com/repos/aredridel/dustjacket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aredridel/dustjacket/merges","archive_url":"https://api.github.com/repos/aredridel/dustjacket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aredridel/dustjacket/downloads","issues_url":"https://api.github.com/repos/aredridel/dustjacket/issues{/number}","pulls_url":"https://api.github.com/repos/aredridel/dustjacket/pulls{/number}","milestones_url":"https://api.github.com/repos/aredridel/dustjacket/milestones{/number}","notifications_url":"https://api.github.com/repos/aredridel/dustjacket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aredridel/dustjacket/labels{/name}","releases_url":"https://api.github.com/repos/aredridel/dustjacket/releases{/id}","created_at":"2014-12-02T21:08:02Z","updated_at":"2014-12-04T17:31:20Z","pushed_at":"2014-12-15T20:19:21Z","git_url":"git://github.com/aredridel/dustjacket.git","ssh_url":"git@github.com:aredridel/dustjacket.git","clone_url":"https://github.com/aredridel/dustjacket.git","svn_url":"https://github.com/aredridel/dustjacket","homepage":"","size":216,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"aredridel:master","ref":"master","sha":"3fe494ec0d427666513fb48b67aa2a91d13ef587","user":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"repo":{"id":27453511,"name":"dustjacket","full_name":"aredridel/dustjacket","owner":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aredridel/dustjacket","description":"Loader middleware for dustjs","fork":false,"url":"https://api.github.com/repos/aredridel/dustjacket","forks_url":"https://api.github.com/repos/aredridel/dustjacket/forks","keys_url":"https://api.github.com/repos/aredridel/dustjacket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aredridel/dustjacket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aredridel/dustjacket/teams","hooks_url":"https://api.github.com/repos/aredridel/dustjacket/hooks","issue_events_url":"https://api.github.com/repos/aredridel/dustjacket/issues/events{/number}","events_url":"https://api.github.com/repos/aredridel/dustjacket/events","assignees_url":"https://api.github.com/repos/aredridel/dustjacket/assignees{/user}","branches_url":"https://api.github.com/repos/aredridel/dustjacket/branches{/branch}","tags_url":"https://api.github.com/repos/aredridel/dustjacket/tags","blobs_url":"https://api.github.com/repos/aredridel/dustjacket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aredridel/dustjacket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aredridel/dustjacket/git/refs{/sha}","trees_url":"https://api.github.com/repos/aredridel/dustjacket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aredridel/dustjacket/statuses/{sha}","languages_url":"https://api.github.com/repos/aredridel/dustjacket/languages","stargazers_url":"https://api.github.com/repos/aredridel/dustjacket/stargazers","contributors_url":"https://api.github.com/repos/aredridel/dustjacket/contributors","subscribers_url":"https://api.github.com/repos/aredridel/dustjacket/subscribers","subscription_url":"https://api.github.com/repos/aredridel/dustjacket/subscription","commits_url":"https://api.github.com/repos/aredridel/dustjacket/commits{/sha}","git_commits_url":"https://api.github.com/repos/aredridel/dustjacket/git/commits{/sha}","comments_url":"https://api.github.com/repos/aredridel/dustjacket/comments{/number}","issue_comment_url":"https://api.github.com/repos/aredridel/dustjacket/issues/comments/{number}","contents_url":"https://api.github.com/repos/aredridel/dustjacket/contents/{+path}","compare_url":"https://api.github.com/repos/aredridel/dustjacket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aredridel/dustjacket/merges","archive_url":"https://api.github.com/repos/aredridel/dustjacket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aredridel/dustjacket/downloads","issues_url":"https://api.github.com/repos/aredridel/dustjacket/issues{/number}","pulls_url":"https://api.github.com/repos/aredridel/dustjacket/pulls{/number}","milestones_url":"https://api.github.com/repos/aredridel/dustjacket/milestones{/number}","notifications_url":"https://api.github.com/repos/aredridel/dustjacket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aredridel/dustjacket/labels{/name}","releases_url":"https://api.github.com/repos/aredridel/dustjacket/releases{/id}","created_at":"2014-12-02T21:08:02Z","updated_at":"2014-12-04T17:31:20Z","pushed_at":"2014-12-15T20:19:21Z","git_url":"git://github.com/aredridel/dustjacket.git","ssh_url":"git@github.com:aredridel/dustjacket.git","clone_url":"https://github.com/aredridel/dustjacket.git","svn_url":"https://github.com/aredridel/dustjacket","homepage":"","size":216,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aredridel/dustjacket/pulls/2"},"html":{"href":"https://github.com/aredridel/dustjacket/pull/2"},"issue":{"href":"https://api.github.com/repos/aredridel/dustjacket/issues/2"},"comments":{"href":"https://api.github.com/repos/aredridel/dustjacket/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/aredridel/dustjacket/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/aredridel/dustjacket/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aredridel/dustjacket/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/aredridel/dustjacket/statuses/4f0200cadab205e79d64c32743eb834098eeabae"}}}}