GitHub PushEvent at 2014-10-23 14:54:09
Repository: git
Actor: seveas
Payload: {"shas":[["7ce7c7607b14248b1a3ae7cdd1c079eb3b6efa09","0aa497b8475a933a4e2a8b8666146d28b036a2b1@zib.de","convert: drop arguments other than 'path' from would_convert_to_git()\n\nIt is only the path that matters in the decision whether to filter\nor not.  Clarify this by making path the only argument of\nwould_convert_to_git().\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Steffen Prohaska",true],["23b0c4782e5f9357e6189253021053a4404ddf4e","0aa497b8475a933a4e2a8b8666146d28b036a2b1@zib.de","config.c: add git_env_ulong() to parse environment variable\n\nThe new function parses an integeral value that fits in unsigned\nlong in human readable form, i.e. possibly with unit suffix, e.g.\n10k = 10240, etc., from an environment variable.  Parsing of\nGIT_MMAP_LIMIT and GIT_ALLOC_LIMIT will use it in later patches.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Steffen Prohaska",true],["9927d9627fe01d780e754a02cf9adc36e084c587","0aa497b8475a933a4e2a8b8666146d28b036a2b1@zib.de","memory_limit: use git_env_ulong() to parse GIT_ALLOC_LIMIT\n\nGIT_ALLOC_LIMIT limits xmalloc()'s size, which is of type size_t.\nBetter use git_env_ulong() to parse the environment variable, so\nthat the postfixes 'k', 'm', and 'g' can be used; and use size_t to\nstore the limit for consistency.  The change to size_t has no direct\npractical impact, because the environment variable is only meant to\nbe used for our own tests, and we use it to test small sizes.\n\nThe cast of size in the call to die() is changed to uintmax_t to\nmatch the format string PRIuMAX.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Steffen Prohaska",true],["02710228dd79d9f9c6fa180233491639b603c06d","0aa497b8475a933a4e2a8b8666146d28b036a2b1@zib.de","mmap_limit: introduce GIT_MMAP_LIMIT to allow testing expected mmap size\n\nIn order to test expectations about mmap in a way similar to testing\nexpectations about malloc with GIT_ALLOC_LIMIT introduced by\nd41489a6 (Add more large blob test cases, 2012-03-07), introduce a\nnew environment variable GIT_MMAP_LIMIT to limit the largest allowed\nmmap length.\n\nxmmap() is modified to check the size of the requested region and\nfail it if it is beyond the limit.  Together with GIT_ALLOC_LIMIT\ntests can now confirm expectations about memory consumption.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Steffen Prohaska",true],["b29763aa9bcbb99a59aec3820e30ff1864cfa765","0aa497b8475a933a4e2a8b8666146d28b036a2b1@zib.de","copy_fd(): do not close the input file descriptor\n\nThe caller, not this function, opened the file descriptor; it is\nselfish for the callee to close it when it is done reading from it.\nThe caller may want an option to rewind and re-read the contents\nafter it returns.\n\nSimplify the loop to copy the input in full to the output; its\nbody essentially is what a call to write_in_full() helper does.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\nHelped-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Steffen Prohaska",true],["9035d75a2be9d80d82676504d69553245017f6d4","0aa497b8475a933a4e2a8b8666146d28b036a2b1@zib.de","convert: stream from fd to required clean filter to reduce used address space\n\nThe data is streamed to the filter process anyway.  Better avoid mapping\nthe file if possible.  This is especially useful if a clean filter\nreduces the size, for example if it computes a sha1 for binary data,\nlike git media.  The file size that the previous implementation could\nhandle was limited by the available address space; large files for\nexample could not be handled with (32-bit) msysgit.  The new\nimplementation can filter files of any size as long as the filter output\nis small enough.\n\nThe new code path is only taken if the filter is required.  The filter\nconsumes data directly from the fd.  If it fails, the original data is\nnot immediately available.  The condition can easily be handled as\na fatal error, which is expected for a required filter anyway.\n\nIf the filter was not required, the condition would need to be handled\nin a different way, like seeking to 0 and reading the data.  But this\nwould require more restructuring of the code and is probably not worth\nit.  The obvious approach of falling back to reading all data would not\nhelp achieving the main purpose of this patch, which is to handle large\nfiles with limited address space.  If reading all data is an option, we\ncan simply take the old code path right away and mmap the entire file.\n\nThe environment variable GIT_MMAP_LIMIT, which has been introduced in\na previous commit is used to test that the expected code path is taken.\nA related test that exercises required filters is modified to verify\nthat the data actually has been modified on its way from the file system\nto the object store.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Steffen Prohaska",true],["1c4b6604126781361fe89d88ace70f53079fbab5","9de348c050f7cd1ca590883733c4e531ce610bf4@gmail.com","cleanups: ensure that git-compat-util.h is included first\n\nCodingGuidelines states that the first #include in C files should be\ngit-compat-util.h or another header file that includes it, such as\ncache.h or builtin.h.\n\nSigned-off-by: David Aguilar <davvid@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","David Aguilar",true],["3bfcb95fa84d8bacb01a990c5bdb16df13462279","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","receive-pack: do not overallocate command structure\n\nAn \"update\" command in the protocol exchange consists of 40-hex old\nobject name, SP, 40-hex new object name, SP, and a refname, but the\nfirst instance is further followed by a NUL with feature requests.\n\nThe command structure, which has a flex-array member that stores the\nrefname at the end, was allocated based on the whole length of the\nupdate command, without excluding the trailing feature requests.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["0e3c339bb69670b39161838de17f440480e1358a","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","receive-pack: parse feature request a bit earlier\n\nIdeally, we should have also allowed the first \"shallow\" to carry\nthe feature request trailer, but that is water under the bridge\nnow.  This makes the next step to factor out the queuing of commands\neasier to review.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["c09b71ccc45f4be3acca5e809a18a000cae09faf","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","receive-pack: do not reuse old_sha1[] for other things\n\nThis piece of code reads object names of shallow boundaries, not\nold_sha1[], i.e. the current value the ref points at, which is to be\nreplaced by what is in new_sha1[].\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["39895c74d809962bf76a6d720618df30f4bac8b1","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","receive-pack: factor out queueing of command\n\nMake a helper function to accept a line of a protocol message and\nqueue an update command out of the code from read_head_info().\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["621b0599fda143aff7fbf2bca7479997a06a5d11","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","send-pack: move REF_STATUS_REJECT_NODELETE logic a bit higher\n\n20e8b465 (refactor ref status logic for pushing, 2010-01-08)\nrestructured the code to set status for each ref to be pushed, but\ndid not quite go far enough.  We inspect the status set earlier by\nset_refs_status_for_push() and then perform yet another update to\nthe status of a ref with an otherwise OK status to be deleted to\nmark it with REF_STATUS_REJECT_NODELETE when the protocol tells us\nnever to delete.\n\nSplit the latter into a separate loop that comes before we enter the\nper-ref loop.  This way we would have one less condition to check in\nthe main loop.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["e40671a3d9115f2c0cea614d8b5d265150f44c24","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","send-pack: refactor decision to send update per ref\n\nA new helper function ref_update_to_be_sent() decides for each ref\nif the update is to be sent based on the status previously set by\nset_ref_status_for_push() and also if this is a mirrored push.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["64de20a1265b676f9cc0e5f46379a017560fa333","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","send-pack: always send capabilities\n\nWe tried to avoid sending one extra byte, NUL and nothing behind it\nto signal there is no protocol capabilities being sent, on the first\ncommand packet on the wire, but it just made the code look ugly.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["887f3533fd764722ffb6e4ea34c01ad9256f0186","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","send-pack: factor out capability string generation\n\nA run of 'var ? \" var\" : \"\"' fed to a long printf string in a deeply\nnested block was hard to read.  Move it outside the loop and format\nit into a strbuf.\n\nAs an added bonus, the trick to add \"agent=<agent-name>\" by using\ntwo conditionals is replaced by a more readable version.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["52d2ae582e84c6d4ace8ab7e021808915148816a","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","receive-pack: factor out capability string generation\n\nSimilar to the previous one for send-pack, make it easier and\ncleaner to add to capability advertisement.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["ab2b0c908aa1d1643fb15ffca4b943c3add9b945","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","send-pack: rename \"new_refs\" to \"need_pack_data\"\n\nThe variable counts how many non-deleting command is being sent, but\nis only checked with 0-ness to decide if we need to send the pack\ndata.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["b783aa71c096032c02a20f9a41c5f42ce7b914c4","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","send-pack: refactor inspecting and resetting status and sending commands\n\nThe main loop over remote_refs list inspects the ref status\nto see if we need to generate pack data (i.e. a delete-only push\ndoes not need to send any additional data), resets it to \"expecting\nthe status report\" state, and formats the actual update commands\nto be sent.\n\nSplit the former two out of the main loop, as it will become\nconditional in later steps.\n\nBesides, we should have code that does real thing here, before the\n\"Finally, tell the other end!\" part ;-)\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["c67072b90bdc56501483e0ba96d0d833e86362c3","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","send-pack: clarify that cmds_sent is a boolean\n\nWe use it to make sure that the feature request is sent only once on\nthe very first request packet (ignoring the \"shallow \" line, which\nwas an unfortunate mistake we cannot retroactively fix with existing\nreceive-pack already deployed in the field) and we set it to \"true\"\nwith cmds_sent++, not because we care about the actual number of\nupdates sent but because it is merely an idiomatic way.\n\nSet it explicitly to one to clarify that the code that uses this\nvariable only cares about its zero-ness.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true],["a50e7ca3215492b16d96221cf762dbe71ed99722","a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","gpg-interface: move parse_gpg_output() to where it should be\n\nEarlier, ffb6d7d5 (Move commit GPG signature verification to\ncommit.c, 2013-03-31) moved this helper that used to be in pretty.c\n(i.e. the output code path) to commit.c for better reusability.\n\nIt was a good first step in the right direction, but still suffers\nfrom a myopic view that commits will be the only thing we would ever\nwant to sign---we would actually want to be able to reuse it even\nwider.\n\nThe function interprets what GPG said; gpg-interface is obviously a\nbetter place.  Move it there.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Junio C Hamano",true]],"size":202,"ref":"refs/heads/master","head":"19b5d50cb15637f20b9cce01806b3a256491d613"}