GitHub PullRequestEvent at 2014-09-02 05:20:46
Repository: stan
Actor: syclik
Payload: {"action":"closed","number":947,"pull_request":{"url":"https://api.github.com/repos/stan-dev/stan/pulls/947","id":20458020,"html_url":"https://github.com/stan-dev/stan/pull/947","diff_url":"https://github.com/stan-dev/stan/pull/947.diff","patch_url":"https://github.com/stan-dev/stan/pull/947.patch","issue_url":"https://api.github.com/repos/stan-dev/stan/issues/947","number":947,"state":"closed","locked":false,"title":"Feature/test nan acos","user":{"login":"PeterLi2016","id":3487481,"avatar_url":"https://avatars.githubusercontent.com/u/3487481?v=2","gravatar_id":"776dbdd01477e565bd8d43c226d4a99a","url":"https://api.github.com/users/PeterLi2016","html_url":"https://github.com/PeterLi2016","followers_url":"https://api.github.com/users/PeterLi2016/followers","following_url":"https://api.github.com/users/PeterLi2016/following{/other_user}","gists_url":"https://api.github.com/users/PeterLi2016/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterLi2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterLi2016/subscriptions","organizations_url":"https://api.github.com/users/PeterLi2016/orgs","repos_url":"https://api.github.com/users/PeterLi2016/repos","events_url":"https://api.github.com/users/PeterLi2016/events{/privacy}","received_events_url":"https://api.github.com/users/PeterLi2016/received_events","type":"User","site_admin":false},"body":"#### Summary:\r\nAdded NaN tests for acos in agrad/fwd/functions, and agrad/rev/functions with doc on behavior at NaN. I also added more boundary tests to verify derivative behavior outside of [-1,1]. I also switched to the no namespace version of acos to match the double version that is called.\r\n\r\n#### Intended Effect:\r\nAdded NaN tests for acos in agrad/fwd/functions, and agrad/rev/functions with doc on behavior at NaN. \r\n\r\n#### How to Verify:\r\nRun test/unit-agrad-fwd/functions/acos, test/unit-agrad-rev/functions/acos\r\n\r\n#### Side Effects:\r\nNone.\r\n\r\n#### Documentation:\r\nAdded doc on behavior of acos at NaN and partial derivatives.\r\n\r\n#### Reviewer Suggestions:\r\nAnyone.","created_at":"2014-08-28T18:36:51Z","updated_at":"2014-09-02T05:20:45Z","closed_at":"2014-09-02T05:20:45Z","merged_at":"2014-09-02T05:20:45Z","merge_commit_sha":"a4b7cd830823144299c8b05a2fe29f2061c6f72c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stan-dev/stan/pulls/947/commits","review_comments_url":"https://api.github.com/repos/stan-dev/stan/pulls/947/comments","review_comment_url":"https://api.github.com/repos/stan-dev/stan/pulls/comments/{number}","comments_url":"https://api.github.com/repos/stan-dev/stan/issues/947/comments","statuses_url":"https://api.github.com/repos/stan-dev/stan/statuses/bd0491fd97365b0481dec46e90f8761363c2907f","head":{"label":"stan-dev:feature/test-nan-acos","ref":"feature/test-nan-acos","sha":"bd0491fd97365b0481dec46e90f8761363c2907f","user":{"login":"stan-dev","id":3374820,"avatar_url":"https://avatars.githubusercontent.com/u/3374820?v=2","gravatar_id":"5385d8c646f45ece30ef66be7593f467","url":"https://api.github.com/users/stan-dev","html_url":"https://github.com/stan-dev","followers_url":"https://api.github.com/users/stan-dev/followers","following_url":"https://api.github.com/users/stan-dev/following{/other_user}","gists_url":"https://api.github.com/users/stan-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-dev/subscriptions","organizations_url":"https://api.github.com/users/stan-dev/orgs","repos_url":"https://api.github.com/users/stan-dev/repos","events_url":"https://api.github.com/users/stan-dev/events{/privacy}","received_events_url":"https://api.github.com/users/stan-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":8043756,"name":"stan","full_name":"stan-dev/stan","owner":{"login":"stan-dev","id":3374820,"avatar_url":"https://avatars.githubusercontent.com/u/3374820?v=2","gravatar_id":"5385d8c646f45ece30ef66be7593f467","url":"https://api.github.com/users/stan-dev","html_url":"https://github.com/stan-dev","followers_url":"https://api.github.com/users/stan-dev/followers","following_url":"https://api.github.com/users/stan-dev/following{/other_user}","gists_url":"https://api.github.com/users/stan-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-dev/subscriptions","organizations_url":"https://api.github.com/users/stan-dev/orgs","repos_url":"https://api.github.com/users/stan-dev/repos","events_url":"https://api.github.com/users/stan-dev/events{/privacy}","received_events_url":"https://api.github.com/users/stan-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stan-dev/stan","description":"Stan development repository (home page is linked below). The master branch contains the current release. The develop branch contains the latest stable development.  See the Developer Process Wiki for details.  ","fork":false,"url":"https://api.github.com/repos/stan-dev/stan","forks_url":"https://api.github.com/repos/stan-dev/stan/forks","keys_url":"https://api.github.com/repos/stan-dev/stan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stan-dev/stan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stan-dev/stan/teams","hooks_url":"https://api.github.com/repos/stan-dev/stan/hooks","issue_events_url":"https://api.github.com/repos/stan-dev/stan/issues/events{/number}","events_url":"https://api.github.com/repos/stan-dev/stan/events","assignees_url":"https://api.github.com/repos/stan-dev/stan/assignees{/user}","branches_url":"https://api.github.com/repos/stan-dev/stan/branches{/branch}","tags_url":"https://api.github.com/repos/stan-dev/stan/tags","blobs_url":"https://api.github.com/repos/stan-dev/stan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stan-dev/stan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stan-dev/stan/git/refs{/sha}","trees_url":"https://api.github.com/repos/stan-dev/stan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stan-dev/stan/statuses/{sha}","languages_url":"https://api.github.com/repos/stan-dev/stan/languages","stargazers_url":"https://api.github.com/repos/stan-dev/stan/stargazers","contributors_url":"https://api.github.com/repos/stan-dev/stan/contributors","subscribers_url":"https://api.github.com/repos/stan-dev/stan/subscribers","subscription_url":"https://api.github.com/repos/stan-dev/stan/subscription","commits_url":"https://api.github.com/repos/stan-dev/stan/commits{/sha}","git_commits_url":"https://api.github.com/repos/stan-dev/stan/git/commits{/sha}","comments_url":"https://api.github.com/repos/stan-dev/stan/comments{/number}","issue_comment_url":"https://api.github.com/repos/stan-dev/stan/issues/comments/{number}","contents_url":"https://api.github.com/repos/stan-dev/stan/contents/{+path}","compare_url":"https://api.github.com/repos/stan-dev/stan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stan-dev/stan/merges","archive_url":"https://api.github.com/repos/stan-dev/stan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stan-dev/stan/downloads","issues_url":"https://api.github.com/repos/stan-dev/stan/issues{/number}","pulls_url":"https://api.github.com/repos/stan-dev/stan/pulls{/number}","milestones_url":"https://api.github.com/repos/stan-dev/stan/milestones{/number}","notifications_url":"https://api.github.com/repos/stan-dev/stan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stan-dev/stan/labels{/name}","releases_url":"https://api.github.com/repos/stan-dev/stan/releases{/id}","created_at":"2013-02-06T03:25:04Z","updated_at":"2014-09-02T05:13:06Z","pushed_at":"2014-09-02T05:20:45Z","git_url":"git://github.com/stan-dev/stan.git","ssh_url":"git@github.com:stan-dev/stan.git","clone_url":"https://github.com/stan-dev/stan.git","svn_url":"https://github.com/stan-dev/stan","homepage":"http://mc-stan.org","size":318432,"stargazers_count":233,"watchers_count":233,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":71,"mirror_url":null,"open_issues_count":246,"forks":71,"open_issues":246,"watchers":233,"default_branch":"develop"}},"base":{"label":"stan-dev:develop","ref":"develop","sha":"2c4cc3ee5b78fa7cee563a1d9faf569b17c8f447","user":{"login":"stan-dev","id":3374820,"avatar_url":"https://avatars.githubusercontent.com/u/3374820?v=2","gravatar_id":"5385d8c646f45ece30ef66be7593f467","url":"https://api.github.com/users/stan-dev","html_url":"https://github.com/stan-dev","followers_url":"https://api.github.com/users/stan-dev/followers","following_url":"https://api.github.com/users/stan-dev/following{/other_user}","gists_url":"https://api.github.com/users/stan-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-dev/subscriptions","organizations_url":"https://api.github.com/users/stan-dev/orgs","repos_url":"https://api.github.com/users/stan-dev/repos","events_url":"https://api.github.com/users/stan-dev/events{/privacy}","received_events_url":"https://api.github.com/users/stan-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":8043756,"name":"stan","full_name":"stan-dev/stan","owner":{"login":"stan-dev","id":3374820,"avatar_url":"https://avatars.githubusercontent.com/u/3374820?v=2","gravatar_id":"5385d8c646f45ece30ef66be7593f467","url":"https://api.github.com/users/stan-dev","html_url":"https://github.com/stan-dev","followers_url":"https://api.github.com/users/stan-dev/followers","following_url":"https://api.github.com/users/stan-dev/following{/other_user}","gists_url":"https://api.github.com/users/stan-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-dev/subscriptions","organizations_url":"https://api.github.com/users/stan-dev/orgs","repos_url":"https://api.github.com/users/stan-dev/repos","events_url":"https://api.github.com/users/stan-dev/events{/privacy}","received_events_url":"https://api.github.com/users/stan-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stan-dev/stan","description":"Stan development repository (home page is linked below). The master branch contains the current release. The develop branch contains the latest stable development.  See the Developer Process Wiki for details.  ","fork":false,"url":"https://api.github.com/repos/stan-dev/stan","forks_url":"https://api.github.com/repos/stan-dev/stan/forks","keys_url":"https://api.github.com/repos/stan-dev/stan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stan-dev/stan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stan-dev/stan/teams","hooks_url":"https://api.github.com/repos/stan-dev/stan/hooks","issue_events_url":"https://api.github.com/repos/stan-dev/stan/issues/events{/number}","events_url":"https://api.github.com/repos/stan-dev/stan/events","assignees_url":"https://api.github.com/repos/stan-dev/stan/assignees{/user}","branches_url":"https://api.github.com/repos/stan-dev/stan/branches{/branch}","tags_url":"https://api.github.com/repos/stan-dev/stan/tags","blobs_url":"https://api.github.com/repos/stan-dev/stan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stan-dev/stan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stan-dev/stan/git/refs{/sha}","trees_url":"https://api.github.com/repos/stan-dev/stan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stan-dev/stan/statuses/{sha}","languages_url":"https://api.github.com/repos/stan-dev/stan/languages","stargazers_url":"https://api.github.com/repos/stan-dev/stan/stargazers","contributors_url":"https://api.github.com/repos/stan-dev/stan/contributors","subscribers_url":"https://api.github.com/repos/stan-dev/stan/subscribers","subscription_url":"https://api.github.com/repos/stan-dev/stan/subscription","commits_url":"https://api.github.com/repos/stan-dev/stan/commits{/sha}","git_commits_url":"https://api.github.com/repos/stan-dev/stan/git/commits{/sha}","comments_url":"https://api.github.com/repos/stan-dev/stan/comments{/number}","issue_comment_url":"https://api.github.com/repos/stan-dev/stan/issues/comments/{number}","contents_url":"https://api.github.com/repos/stan-dev/stan/contents/{+path}","compare_url":"https://api.github.com/repos/stan-dev/stan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stan-dev/stan/merges","archive_url":"https://api.github.com/repos/stan-dev/stan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stan-dev/stan/downloads","issues_url":"https://api.github.com/repos/stan-dev/stan/issues{/number}","pulls_url":"https://api.github.com/repos/stan-dev/stan/pulls{/number}","milestones_url":"https://api.github.com/repos/stan-dev/stan/milestones{/number}","notifications_url":"https://api.github.com/repos/stan-dev/stan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stan-dev/stan/labels{/name}","releases_url":"https://api.github.com/repos/stan-dev/stan/releases{/id}","created_at":"2013-02-06T03:25:04Z","updated_at":"2014-09-02T05:13:06Z","pushed_at":"2014-09-02T05:20:45Z","git_url":"git://github.com/stan-dev/stan.git","ssh_url":"git@github.com:stan-dev/stan.git","clone_url":"https://github.com/stan-dev/stan.git","svn_url":"https://github.com/stan-dev/stan","homepage":"http://mc-stan.org","size":318432,"stargazers_count":233,"watchers_count":233,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":71,"mirror_url":null,"open_issues_count":246,"forks":71,"open_issues":246,"watchers":233,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/stan-dev/stan/pulls/947"},"html":{"href":"https://github.com/stan-dev/stan/pull/947"},"issue":{"href":"https://api.github.com/repos/stan-dev/stan/issues/947"},"comments":{"href":"https://api.github.com/repos/stan-dev/stan/issues/947/comments"},"review_comments":{"href":"https://api.github.com/repos/stan-dev/stan/pulls/947/comments"},"review_comment":{"href":"https://api.github.com/repos/stan-dev/stan/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/stan-dev/stan/pulls/947/commits"},"statuses":{"href":"https://api.github.com/repos/stan-dev/stan/statuses/bd0491fd97365b0481dec46e90f8761363c2907f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=2","gravatar_id":"63e77a43dc133a7089f89e3cc01695a2","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":21,"additions":3052,"deletions":38,"changed_files":14}}