GitHub PullRequestReviewCommentEvent at 2014-12-10 14:59:30
Repository: curator
Actor: madrob
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/curator/pulls/comments/21607747","id":21607747,"diff_hunk":"@@ -104,11 +106,11 @@ public ChildReaper(CuratorFramework client, String path, Reaper.Mode mode, Sched\n     public ChildReaper(CuratorFramework client, String path, Reaper.Mode mode, ScheduledExecutorService executor, int reapingThresholdMs, String leaderPath)","path":"curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/ChildReaper.java","position":26,"original_position":26,"commit_id":"3eea676005e1121d44b9ec0e911d6959ac382f8a","original_commit_id":"915d66f90a12f1f89177cf4acf83d35e65949408","user":{"login":"madrob","id":1592330,"avatar_url":"https://avatars.githubusercontent.com/u/1592330?v=3","gravatar_id":"","url":"https://api.github.com/users/madrob","html_url":"https://github.com/madrob","followers_url":"https://api.github.com/users/madrob/followers","following_url":"https://api.github.com/users/madrob/following{/other_user}","gists_url":"https://api.github.com/users/madrob/gists{/gist_id}","starred_url":"https://api.github.com/users/madrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madrob/subscriptions","organizations_url":"https://api.github.com/users/madrob/orgs","repos_url":"https://api.github.com/users/madrob/repos","events_url":"https://api.github.com/users/madrob/events{/privacy}","received_events_url":"https://api.github.com/users/madrob/received_events","type":"User","site_admin":false},"body":"Sorry, thought I responded to the builder comment earlier... Adding a proper builder would be great, it would feel more like the rest of the Curator tools then. I'm not sure that being able to chain calls to `add()` does enough though. The use case I have in mind is adding a set of paths to all be reaped. Previously the code would look something like (pseudo-code):\r\n\r\nfor (String path : paths) { new ChildReaper(..., path, ...); }\r\n\r\nNow the intent is clearly to consolidate on reapers, so the inutitive thing to do would be\r\n\r\nr = new ChildReaper();\r\nfor (String path : paths) { r.addPath(r); }\r\n\r\nUnfortunately, the constructor requires a path, so either the first path has to be added twice (while it is not apparent from the client perspective that this is safe) or the client has to switch away from a for-each and to a loop that starts on the second element.\\\r\n\r\nMaybe this can all be sufficiently addressed using javadoc.","created_at":"2014-12-10T14:59:30Z","updated_at":"2014-12-10T14:59:30Z","html_url":"https://github.com/apache/curator/pull/57#discussion_r21607747","pull_request_url":"https://api.github.com/repos/apache/curator/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/apache/curator/pulls/comments/21607747"},"html":{"href":"https://github.com/apache/curator/pull/57#discussion_r21607747"},"pull_request":{"href":"https://api.github.com/repos/apache/curator/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/apache/curator/pulls/57","id":25771077,"html_url":"https://github.com/apache/curator/pull/57","diff_url":"https://github.com/apache/curator/pull/57.diff","patch_url":"https://github.com/apache/curator/pull/57.patch","issue_url":"https://api.github.com/repos/apache/curator/issues/57","number":57,"state":"open","locked":false,"title":"Added new apis to add additional paths to ChildReaper and a test.","user":{"login":"Randgalt","id":264818,"avatar_url":"https://avatars.githubusercontent.com/u/264818?v=3","gravatar_id":"","url":"https://api.github.com/users/Randgalt","html_url":"https://github.com/Randgalt","followers_url":"https://api.github.com/users/Randgalt/followers","following_url":"https://api.github.com/users/Randgalt/following{/other_user}","gists_url":"https://api.github.com/users/Randgalt/gists{/gist_id}","starred_url":"https://api.github.com/users/Randgalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Randgalt/subscriptions","organizations_url":"https://api.github.com/users/Randgalt/orgs","repos_url":"https://api.github.com/users/Randgalt/repos","events_url":"https://api.github.com/users/Randgalt/events{/privacy}","received_events_url":"https://api.github.com/users/Randgalt/received_events","type":"User","site_admin":false},"body":"Added new apis to add additional paths to ChildReaper and a test. This change is backward compatible","created_at":"2014-12-09T19:47:02Z","updated_at":"2014-12-10T14:59:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a021062e474dfdca767251f2d17db7f78a8e714e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/curator/pulls/57/commits","review_comments_url":"https://api.github.com/repos/apache/curator/pulls/57/comments","review_comment_url":"https://api.github.com/repos/apache/curator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/curator/issues/57/comments","statuses_url":"https://api.github.com/repos/apache/curator/statuses/3eea676005e1121d44b9ec0e911d6959ac382f8a","head":{"label":"apache:CURATOR-170","ref":"CURATOR-170","sha":"3eea676005e1121d44b9ec0e911d6959ac382f8a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17359057,"name":"curator","full_name":"apache/curator","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/curator","description":"Mirror of Apache Curator","fork":false,"url":"https://api.github.com/repos/apache/curator","forks_url":"https://api.github.com/repos/apache/curator/forks","keys_url":"https://api.github.com/repos/apache/curator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/curator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/curator/teams","hooks_url":"https://api.github.com/repos/apache/curator/hooks","issue_events_url":"https://api.github.com/repos/apache/curator/issues/events{/number}","events_url":"https://api.github.com/repos/apache/curator/events","assignees_url":"https://api.github.com/repos/apache/curator/assignees{/user}","branches_url":"https://api.github.com/repos/apache/curator/branches{/branch}","tags_url":"https://api.github.com/repos/apache/curator/tags","blobs_url":"https://api.github.com/repos/apache/curator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/curator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/curator/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/curator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/curator/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/curator/languages","stargazers_url":"https://api.github.com/repos/apache/curator/stargazers","contributors_url":"https://api.github.com/repos/apache/curator/contributors","subscribers_url":"https://api.github.com/repos/apache/curator/subscribers","subscription_url":"https://api.github.com/repos/apache/curator/subscription","commits_url":"https://api.github.com/repos/apache/curator/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/curator/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/curator/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/curator/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/curator/contents/{+path}","compare_url":"https://api.github.com/repos/apache/curator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/curator/merges","archive_url":"https://api.github.com/repos/apache/curator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/curator/downloads","issues_url":"https://api.github.com/repos/apache/curator/issues{/number}","pulls_url":"https://api.github.com/repos/apache/curator/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/curator/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/curator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/curator/labels{/name}","releases_url":"https://api.github.com/repos/apache/curator/releases{/id}","created_at":"2014-03-03T08:00:07Z","updated_at":"2014-12-06T21:47:50Z","pushed_at":"2014-12-10T14:43:36Z","git_url":"git://github.com/apache/curator.git","ssh_url":"git@github.com:apache/curator.git","clone_url":"https://github.com/apache/curator.git","svn_url":"https://github.com/apache/curator","homepage":null,"size":16035,"stargazers_count":96,"watchers_count":96,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":"git://git.apache.org/curator.git","open_issues_count":11,"forks":70,"open_issues":11,"watchers":96,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ef2ca578648e3ab8bf927ada169614011ec1ff2a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17359057,"name":"curator","full_name":"apache/curator","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/curator","description":"Mirror of Apache Curator","fork":false,"url":"https://api.github.com/repos/apache/curator","forks_url":"https://api.github.com/repos/apache/curator/forks","keys_url":"https://api.github.com/repos/apache/curator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/curator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/curator/teams","hooks_url":"https://api.github.com/repos/apache/curator/hooks","issue_events_url":"https://api.github.com/repos/apache/curator/issues/events{/number}","events_url":"https://api.github.com/repos/apache/curator/events","assignees_url":"https://api.github.com/repos/apache/curator/assignees{/user}","branches_url":"https://api.github.com/repos/apache/curator/branches{/branch}","tags_url":"https://api.github.com/repos/apache/curator/tags","blobs_url":"https://api.github.com/repos/apache/curator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/curator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/curator/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/curator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/curator/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/curator/languages","stargazers_url":"https://api.github.com/repos/apache/curator/stargazers","contributors_url":"https://api.github.com/repos/apache/curator/contributors","subscribers_url":"https://api.github.com/repos/apache/curator/subscribers","subscription_url":"https://api.github.com/repos/apache/curator/subscription","commits_url":"https://api.github.com/repos/apache/curator/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/curator/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/curator/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/curator/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/curator/contents/{+path}","compare_url":"https://api.github.com/repos/apache/curator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/curator/merges","archive_url":"https://api.github.com/repos/apache/curator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/curator/downloads","issues_url":"https://api.github.com/repos/apache/curator/issues{/number}","pulls_url":"https://api.github.com/repos/apache/curator/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/curator/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/curator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/curator/labels{/name}","releases_url":"https://api.github.com/repos/apache/curator/releases{/id}","created_at":"2014-03-03T08:00:07Z","updated_at":"2014-12-06T21:47:50Z","pushed_at":"2014-12-10T14:43:36Z","git_url":"git://github.com/apache/curator.git","ssh_url":"git@github.com:apache/curator.git","clone_url":"https://github.com/apache/curator.git","svn_url":"https://github.com/apache/curator","homepage":null,"size":16035,"stargazers_count":96,"watchers_count":96,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":"git://git.apache.org/curator.git","open_issues_count":11,"forks":70,"open_issues":11,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/curator/pulls/57"},"html":{"href":"https://github.com/apache/curator/pull/57"},"issue":{"href":"https://api.github.com/repos/apache/curator/issues/57"},"comments":{"href":"https://api.github.com/repos/apache/curator/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/curator/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/curator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/curator/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/apache/curator/statuses/3eea676005e1121d44b9ec0e911d6959ac382f8a"}}}}