GitHub PullRequestReviewCommentEvent at 2014-03-11 15:10:11
Repository: servo
Actor: jdm
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/servo/pulls/comments/10477296","id":10477296,"diff_hunk":"@@ -68,11 +68,13 @@ impl HTMLFieldSetElement {\n         ~\"\"\n     }\n \n-    pub fn Elements(&self) -> JS<HTMLCollection> {\n-        // FIXME: https://github.com/mozilla/servo/issues/1843\n+    pub fn Elements(&self, abstract_self: &JS<HTMLFieldSetElement>) -> JS<HTMLCollection> {\n+        let node: JS<Node> = NodeCast::from(abstract_self);\n+        let element: JS<Element> = ElementCast::from(abstract_self);\n         let doc = self.htmlelement.element.node.owner_doc();\n         let doc = doc.get();\n-        HTMLCollection::new(&doc.window, ~[])\n+        let listed_elements = [~\"button\", ~\"fieldset\", ~\"input\", ~\"keygen\", ~\"object\", ~\"output\", ~\"select\", ~\"textarea\"];\n+        HTMLCollection::create(&doc.window, &node, |elem| *elem != element && listed_elements.contains(&elem.get().tag_name))","path":"src/components/script/dom/htmlfieldsetelement.rs","position":27,"original_position":27,"commit_id":"1fc6731a66079aff7756536397f4a8552976866f","original_commit_id":"1fc6731a66079aff7756536397f4a8552976866f","user":{"login":"jdm","id":27658,"avatar_url":"https://gravatar.com/avatar/b13611d1950fd03a3e1d44195fa6f532?d=https%3A%2F%2Fidenticons.github.com%2Fb95466b8b139e9e1fa1400d527798b7c.png&r=x","gravatar_id":"b13611d1950fd03a3e1d44195fa6f532","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"body":"tag_name.as_slice()","created_at":"2014-03-11T15:10:11Z","updated_at":"2014-03-11T15:10:11Z","html_url":"https://github.com/mozilla/servo/pull/1865#discussion_r10477296","pull_request_url":"https://api.github.com/repos/mozilla/servo/pulls/1865","_links":{"self":{"href":"https://api.github.com/repos/mozilla/servo/pulls/comments/10477296"},"html":{"href":"https://github.com/mozilla/servo/pull/1865#discussion_r10477296"},"pull_request":{"href":"https://api.github.com/repos/mozilla/servo/pulls/1865"}}}}