All of those changes are complete.

On 9/04/2014 11:00 PM, James Moger wrote:
>
> In src/main/java/com/gitblit/wicket/charting/Flotr2LineChart.java:
>
> > +			String valueName) {
> > +		super(tagId, title, keyName, valueName);
> > +
> > +	}
> > +
> > +	@Override
> > +	protected void appendChart(StringBuilder sb) {
> > +		
> > +		String dName = "data_" + dataName;
> > +		sb.append("var labels_" + dataName + " = [");
> > +		if(xAxisIsDate){
> > +			// Generate labels for the dates
> > +			SimpleDateFormat df = new SimpleDateFormat(dateFormat);
> > +			df.setTimeZone(getTimeZone());
> > +			
> > +			// Sort the values first
>
> Sorting is unnecessary as the data is already sorted by the metrics 
> generator. And in fact, this sort method doesn't always work and can 
> generate interesting line graphs. :) You should be safe to toss this.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/gitblit/gitblit/pull/166/files#r11433892>.
>