fdo#78824: Avoid having two menu entries having the same accelarator.

Sort should have an 'S' as accelerator.  The other one can be auto-assigned.

Change-Id: I61e630c9b6d89658c65cca77333f1ad0a591e3ab
(cherry picked from commit 1d7c97a607615c3f176c9f553d1d011e4ee55c1d)
Reviewed-on: https://gerrit.libreoffice.org/9399
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Resolves: fdo#78838 past-the-end iterator

Inserting data in pColumnData invalidated miAutoPosColumn
See https://bugs.freedesktop.org/show_bug.cgi?id=78838#c6

Cherry-picked from 1df54514d7a1ebb1b4fa16cca386a34e7c41c490

Change-Id: Iece423cd8d14f5ae7bf382583c0369895a00f168
Reviewed-on: https://gerrit.libreoffice.org/9409
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
simplify and ensure valid miAutoPosColumn in all cases, fdo#78838 related

Unconditionally set miAutoPosColumn at the end of all operations so it
is also valid in case of pColumnData->clear() and no entries inserted
after pDoc->GetDataEntries().

Change-Id: I689632f696091fd9ce8e93c06d7918e5eaf05ab4
(cherry picked from commit 23e9f36a21f7daa6175f53fd244677b9c2e2a660)
Reviewed-on: https://gerrit.libreoffice.org/9412
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
fdo#78949 Handle (SAXParse-)Exception that can't pass getAllRelationships

...like it was already done in the similar else branch of
ReadRelInfoIfNecessary.  The call site at GetAllRelationshipsIfAny will
translate an m_nRelInfoStatus that remained RELINFO_NOT_INIT into an
IOException.

Change-Id: I79c601acd23b3b0020c7b4de4c20b0282524bce1
(cherry picked from commit 423921b085de43f53e42f957889dd96378d2c3c4)
Reviewed-on: https://gerrit.libreoffice.org/9411
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
fdo#78536: sfx2: template dialog: make the am-i-dead-yet check reentrant

In the fine tradition of our enterprise-grade code base, this lets the
check in SfxCommonTemplateDialog_Impl::Execute_Impl() do an early
return if the "this" instance has signalled its untimely demise even if
there are multiple calls of Execute_Impl() on the stack; extending
the scheme with further epicycles to make it work if the Execute_Impl()
calls happen on 2 different threads is left as an exercise for the
interested reader.

(regression from bcc52fb2ebdf77a1cc089857775fd742085b45b6)

(cherry picked from commit 838c580fdba8b1c72bc854d101d302be0e3861d5)

Conflicts:
	sfx2/source/dialog/templdlg.cxx

Change-Id: I1d9f0d82bf6d9f5da8f9bd2be57d01937d71fd26
Reviewed-on: https://gerrit.libreoffice.org/9406
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
resolved fdo#66620 keywords occur in unquoted context only

Change-Id: I4de41e5b66f1a856a786c521ca4ef2eec14c7499
(cherry picked from commit 0d361388060741fe8e2f1ba059fba95707bdc233)
Reviewed-on: https://gerrit.libreoffice.org/9405
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
-Werror,-Wunused-result

Change-Id: Iaa06237d3e554d3a3d9c87f6c5dba715343afa25
(cherry picked from commit 9cf5e4c2500fc5d579896ea08802aba5ca671c96)
fdo#78971 There's even a git hook to prevent commits containing SAL_DEBUG

Change-Id: I5a46e1eed129edf3648c68c36951d6fdf9bd370d
(cherry picked from commit dc24203e5f20dcbf2818651a8802e67338293b3c)
n#862510: Ignore baseline attributes with zero.

Change-Id: I1adc46e62c82c23645ccad0e11d5a7cb07114539
(cherry picked from commit 19abfaffe74b925e4428943d14187a7008797982)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Related: fdo#78151 fix 'pIds unsorted' warning

Change-Id: I00c533a25a851d8bf57f1b0758e98915d2291ee9
(cherry picked from commit 52871279e9811d437ebe881e30b6c76208c84e65)
Reviewed-on: https://gerrit.libreoffice.org/9413
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
(related: fdo#62176) Revert "reset min/max values in paragraph ...

... dialog before setting the actual value"

This prevents handling negative first-line indent in Impress, for which
it is necessary that the values are set before the limits.

This reverts commit 3d7ff1e907713d8ed53a1e193641a2f16de3c38b.

Change-Id: I47807d7d49716acab3657de1da64c6e9a99fc44d
(cherry picked from commit 35199df7b7af9d9dd3e98eb5f1b24ac1d407345c)
Reviewed-on: https://gerrit.libreoffice.org/9415
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
fdo#78815 Fix report builder toolbox controller

Change-Id: Iecbf84b29500729e228d22c8e50b119d1fb471c5
(cherry picked from commit 214de0e5124b44df0f37fdf89271a527667590dc)
Reviewed-on: https://gerrit.libreoffice.org/9422
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
SvxRelativeField: set the unit from the passed stringmap

In the Paragraph "Indents & Spacing" tab there are fields with unit:
<object class="svxlo-SvxRelativeField" id="spinED_LEFTINDENT:0cm">

But the unit is effectively ignored, and the resulting SvxRelativeField
with FUNIT_NONE and 9999 max somehow results in 0.18cm max when the
dialog sets cm as unit.

(cherry picked from commit 68bc8af6b6c4d0399bd10ed450d81aa2f17931a1)

Conflicts:
	svx/source/dialog/relfld.cxx

Change-Id: I6001c93079fd7d899f1e119913b29ea4898b1c34
Reviewed-on: https://gerrit.libreoffice.org/9416
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
valgrind: SfxBaseModel's pImpl of fallback TargetDocument for paste leaks

e.g. repeatedly pasting a metafile into writer and deleting it.

==13369== 342 (232 direct, 110 indirect) bytes in 1 blocks are definitely lost in loss record 19,396 of 22,170
==13369==    at 0x4A06965: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==13369==    by 0x686D72E: SfxBaseModel::SfxBaseModel(SfxObjectShell*) (sfxbasemodel.cxx:518)
==13369==    by 0x288CA9C1: SvxUnoDrawingModel::SvxUnoDrawingModel(SdrModel*) (unomod.cxx:255)
==13369==    by 0x28961055: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, char const*) (xmlexport.cxx:164)
==13369==    by 0x28960FA2: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&) (xmlexport.cxx:148)
==13369==    by 0x2896175E: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) (xmlexport.cxx:254)
==13369==    by 0x240B1002: SwFEShell::Paste(SvStream&, unsigned short, Point const*) (fecopy.cxx:1333)
==13369==    by 0x247B981A: SwTransferable::_PasteSdrFormat(TransferableDataHelper&, SwWrtShell&, unsigned short, Point const*, unsigned char, bool) (swdtflvr.cxx:2207)
==13369==    by 0x247B678E: SwTransferable::PasteData(TransferableDataHelper&, SwWrtShell&, unsigned short, unsigned long, unsigned short, bool, bool, Point const*, signed char, bool) (swdtflvr.cxx:1481)
==13369==    by 0x247B5AE4: SwTransferable::Paste(SwWrtShell&, TransferableDataHelper&) (swdtflvr.cxx:1150)
==13369==    by 0x2488FCCE: SwBaseShell::ExecClpbrd(SfxRequest&) (basesh.cxx:277)

     Reference< lang::XComponent > xTargetDocument( xComponent );
     if( !xTargetDocument.is() )
     {
>        xTargetDocument = new SvxUnoDrawingModel( pModel );
         pModel->setUnoModel( Reference< XInterface >::query( xTargetDocument ) );
     }

(cherry picked from commit fdca15fb864aca975533257d5ee83440992d8a7e)

Conflicts:
	sfx2/source/doc/sfxbasemodel.cxx

Change-Id: I3bd0fc983d9b6bdcdc91071a4ec3d2c584397ebf
Reviewed-on: https://gerrit.libreoffice.org/9384
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>