update from the traits on the core module