Sorry, You are wrong, Sure, we should test the value.

Remember, there are 3 cases:

the key "tizen.org/feature/opengles.version.1_1<http://tizen.org/feature/opengles.version.1_1>is
not present in the platform file . => o["openglesVersion1_1"] = false
====> In the code that equals to catch the Error
the key "tizen.org/feature/opengles.version.1_1<http://tizen.org/feature/opengles.version.1_1>is
existein the platform file . and the value associated is true  =>
o["openglesVersion1_1"] = true
the key "tizen.org/feature/opengles.version.1_1<http://tizen.org/feature/opengles.version.1_1>is
existein the platform file . and the value associated is false  =>
o["openglesVersion1_1"] = false


having keys with false value is allowed.

Baptste




2014-02-07 15:23 GMT+01:00 Raphael Kubo da Costa <notifications@github.com>:

> In system_info/system_info_instance.cc:
>
> >      o["opengles"] = picojson::value(true);
> > -
> > -    if (strstr(s, "1.1"))
> > +    if ((system_info_get_platform_
> bool(
> > +      "tizen.org/feature/opengles.version.1_1",
> > +      &b) == SYSTEM_INFO_ERROR_NONE)
> > +      && b == true)
>
> Plus can't you just use the first check here like you did in the previous
> ifs? You don't seem to really need to check if b is true since you cover
> the other case anyway.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/242/files#r9539731>
> .
>



-- 
Baptiste DURAND