That's probably a good fix to make. You have the length passed into that
function, so calculating the size if it's an array is probably pretty
straightforward (famous last words :-).


On Mon, Jan 27, 2014 at 11:21 PM, ramkrish86 <notifications@github.com>wrote:

> In phoenix-core/src/main/java/org/apache/phoenix/parse/ColumnDef.java:
>
> > -                 throw new SQLExceptionInfo.Builder(SQLExceptionCode.NONPOSITIVE_BINARY_LENGTH)
> > -                     .setColumnName(columnDefName.getColumnName()).build().buildException();
> > -             }
> > -             scale = null;
> > -         } else if (this.dataType == PDataType.INTEGER) {
> > -             maxLength = PDataType.INT_PRECISION;
> > -             scale = PDataType.ZERO;
> > -         } else if (this.dataType == PDataType.LONG) {
> > -             maxLength = PDataType.LONG_PRECISION;
> > -             scale = PDataType.ZERO;
> > -         } else {
> > -             // ignore maxLength and scale for other types.
> > -             maxLength = null;
> > -             scale = null;
> > -         }
> > +			if (!this.isArray) {
>
> Got the code from the apache git repo now.
>
> I saw that
>
>          if(isArrayType()) {
>         return null;
>     }
>
> this has been left as it is. If you are ok with this then am fine. Will
> start on #669 <https://github.com/forcedotcom/phoenix/issues/669>
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/forcedotcom/phoenix/pull/719/files#r9219300>
> .
>