stats: Enhance statistics output

Add basic NIC stats for all PHY ports when stats are enabled. In
addition, remove duplicate statistics and excessive use of
whitespace.

Change-Id: Iac7d7052f0cfbd459384b58eb7f1501d75e408c0
Signed-off-by: Kevin Traynor <kevin.traynor@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Mark D. Gray <mark.d.gray@intel.com>
docs: Add 'rte_kni' module requirement to setup

This module is required to successfully start 'ovs-dpdk'.

Change-Id: I696bfc32bf44bb4a804bcae5cc43da694ce63505
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Mark D. Gray <mark.d.gray@intel.com>
Reviewed-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
ovs-ivshm-mngr: Remove support for KNI

Guest KNI support was removed in a previous release, in favour of
Userspace-vHost. This means the 'ovs-ivshm-mngr' no longer needs
to support KNI. Remove it.

Change-Id: I169eb8abdc5dec116a2fe5a4b6978c222600c1b6
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Mark D. Gray <mark.d.gray@intel.com>
Reviewed-by: Meghan Halton <meghan.halton@intel.com>
ovs_client: remove debug logging

Debug logging previously addeded to ovs_client.c introduces
additional decisions which, coupled with the logging,
negatively impact performance. The degraded performance is
particularly evident in the IVSHMEM VM-VM test case.

Remove these logs to boost performance to its previous levels.

Change-Id: I8f5a8aff85ca86085c5e45735a28ae4a4c524863
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
Reviewed-By: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-By: Kevin Traynor <kevin.traynor@intel.com>
automake: Compile DPDK as single library

Change-Id: I7e589f6b6dc33db7f00f77af536ab53debc6625c
Signed-off-by: Mark D. Gray <mark.d.gray@intel.com>
Reviewed-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
docs: Update for DPDK v1.7.1

Change-Id: I76942753c776616b595e60bbb2ad202beeb28ae5
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
NEWS.md: Update for DPDK 1.7.1

Change-Id: I26361667284f4e8f896832eebac74380c4d1a8dd
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
datapath: Validate flags during port delete

Flags are used to indicate the type of vport being deleted (in port
or out port). These flags are not correctly validated and this
eventually results in "success" messages being returned to the dpif
even for failures cases. Fix this.

Change-Id: Iac76396e12a6b5fa80064ad25debdaf73fdb7e95
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
datapath: Validate flags during port add

Flags are used to indicate the type of vport being added (in port
or out port). These flags are not correctly validated and this
eventually results in "success" messages being returned to the dpif
even for failures cases. Fix this.

Change-Id: I017c16f640c940edf146315220b4d389df5dc237
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
datapath: Add additional port states

Currently a vport can be in one of two states - enabled or disabled.
This does not account for additional states, like a vport that was
previously added (and initialised) but has since been disabled. Extend
this to include additional states, like the aforementioned added but
disabled state.

Change-Id: I582b942e2eeae03ea6c0dcde45405c2ef6aea759
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
dpif-dpdk: Implement new datapath port state

Firstly, when adding a port, check if the port has been previously
added, by checking the lcoreid value associated with the port. If set
to a valid value, the port exists and merely needs to be re-enabled.
If not, the port does not exist and must be added and enabled.

Secondly, when deleting a port, ensure that both in-ports *and*
out-ports are deleted.

Change-Id: I8c0982b2f10b11ae9f408aa4db08c973ffbe23bf
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
tests: Add additional tests for new states

Add tests to validate the port state changes.

In addition, add an utils file for common test code.

Change-Id: I68a29228f3e9668ee3e073d56decd8de03b825f9
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
docs: Remove resolved issue

Change-Id: I9863e3147a463d0341abff643042667efb9bd3ac
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
NEWS.md: Update for port delete bugfix

Change-Id: I6c507dbad064c1621d97652a67e1205945e0f9f2
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
dpif: use VLOG only in dpdk_link

dpdk_link.c currently uses a combination of VLOG_ and RTE_LOG_
macros for logging. Remove all RTE_LOG_ macros, and replace with
VLOG_ macros.

Change-Id: I1c351b49f28cb229e4d69740d3acfcf7a39ee4d9
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
Reviewed-By: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-By: Kevin Traynor <kevin.traynor@intel.com>
Update bug report addresses

Update Open vSwitch code to point bug reports to
Intel (r) DPDK vSwitch list

Signed-off-by: Mark D. Gray <mark.d.gray@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Change-Id: I2c01aea03405cb980ef7708ff01f1d67900872db
tests: Fix file permissions

Change-Id: Ia1b750bf2a359ca412e37220fde8c4413ffdabba
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
tests: Fix issue with 'ovdk-vport' tests

In some cases these tests can fail due to missing environment vars.
This was because the environment wasn't carried over when executing
sudo. Add the '-E' flag to fix this.

Change-Id: Ie212a6c3de40fd2aea0b8fa8fbbd25de0b76ba59
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
openvswitch: Rename OpenvSwitch directory

Rename 'openvswitch' directory in preperation for move to subtree
format. Additionally, update top-level Makefile to *temporarily*
point to new directory, and update symlinks in the libvport
directory.  This will prevent a broken build.

Change-Id: I00c1aa78ac95ce8a8d562d259ca074aaf5611f3b
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Mark D. Gray <mark.d.gray@intel.com>
Reviewed-by: Ian Stokes <ian.stokes@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com
Squashed 'openvswitch/' content from commit b254093

git-subtree-dir: openvswitch
git-subtree-split: b254093d67c8aab09d2f95dc2ce22f57f7d97fe9