clean up and concerns
clean up
fixing specs
Convert specs to RSpec 3.1.7 syntax with Transpec

This conversion is done by Transpec 2.3.8 with the following command:
    transpec spec

* 10 conversions
    from: obj.should
      to: expect(obj).to

* 4 conversions
    from: -> { }.should_not
      to: expect { }.not_to

* 4 conversions
    from: describe 'some model' { }
      to: describe 'some model', :type => :model { }

* 2 conversions
    from: be_true
      to: be_truthy

* 1 conversion
    from: obj.should have(n).error_on(...)
      to: expect(obj.error_on(...).size).to eq(n)

* 1 conversion
    from: obj.should_not
      to: expect(obj).not_to

For more details: https://github.com/yujinakayama/transpec#supported-conversions
green specs