It's ok. Just one of those things. There's enough code that says what it
should. I just couldn't read it for what it actually was.

I was pair programming with a friend/coworker and he couldn't see it either.

All of it seems so simple now. But when I started there was a steep learning
curve. I'd never done anything with thrift or pail. And as you already
know my clojure skills are still ramping up. And I never was a Java
programmer.

My work here has been really good. I'm finding everything a lot more
intuitively now. I created a pail-fressian library in about a day.
I ran into some (difficult for me) errors because Fressian uses
byte-buffers and Pail uses byte arrays. But I figured it out in short
order. So my intuition is growing.

Pail-Fressian is basically pail-thrift with all the thrift parts removed and
the serializer is fressian/read and write, with byte-buffer, byte-array
conversion. There might be some things that could be better about it. 
But it's beyond me if there is. Creating a partitioner is weird because
there could be no type and the structure is up to the individual.

Eric


----- David Cuddeback's Original Message -----
> > @@ -34,7 +34,7 @@ provides serializers and partitioners that can be used with the `gen-structure`
> >  (gen-structure example.pail.PailStructure
> >                 :type MyUnion
> >                 :serializer (s/thrift-serializer MyUnion)
> > -               :partition (p/union-partitioner MyUnion))
> > +               :partitioner (p/union-partitioner MyUnion))
> 
> Ouch. I'm sorry about that. Thanks for fixing it. That will save others from having the same problem.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/dcuddeback/pail-thrift/pull/1/files#r8789831

-- 

Eric Gebhart
e.a.gebhart@gmail.com