Remove tx from AlreadyAskedFor list once we receive it, not when we process it.
build: osx: Fix incomplete framework packaging for codesigning

Starting with 10.9, Framework versions must be signed individually, rather
than as a single bundle version, in order to be properly codesigned. This
change ensures that the proper plist files and symlinks are present prior to
packaging.
[Qt] add all used colors in txtablemodel to guiconstants

- add colors used in TX status decoration
[Qt] simplify return code and return values in txtablemodel

- also move an added space in a string where it belongs
Broken addresses on command line no longer trigger testnet.

When passing a bitcoin: URI on the command line, invalid addresses do not incorrectly send the
user to the test network.
Move g_signals.SetBestChain(..) below SyncWithWallets
Combine CCoinsViewCache's HaveCoins and const GetCoins into AccessCoins.

The efficient version of CCoinsViewCache::GetCoins only works for known-to-exist
cache entries, requiring a separate HaveCoins call beforehand. This is
inefficient as both perform a hashtable lookup.

Replace the non-mutable GetCoins with AccessCoins, which returns a potentially-NULL
pointer. This also decreases the overloading of GetCoins.

Also replace some copying (inefficient) GetCoins calls with equivalent AccessCoins,
decreasing the copying.
[Qt] update form files for setting autoDefault explicitly to false

- also fixes indentation in one file (auto fixed by Qt Designer)
- removes several default parameters, which are not needed in the files
- related to #4840 (but not intended as fix for a no-bug)
Fixing compiler warning C4800: 'type' forcing value to bool 'true' or 'false'
qt: Remove thousands separators after decimal point

Revert thousands separators after decimal point, as introduced in #4167.
netbase: Use .data() instead of .c_str() on binary string

`.c_str()` is only guaranteed to return the data up to the first NUL
character.
Track modified size in TxMemPoolEntry so that we can correctly compute priority.
qt: fix tablet crash. closes #4854.

This backports the relevant parts of:
https://codereview.qt-project.org/#/c/82689/
Make script_{valid,invalid}.json validation flags configurable
Limit CNode::mapAskFor

Tighten resource constraints on CNode.
Avoid returning many "inv" orphans
Remove some unnecessary c_strs() in logging and the GUI

Includes `core: remove unneeded c_str() / Qt: replace c_str() with Qt code`
by P. Kaufmann.
Merge pull request #4868

2c2cc5d Remove some unnecessary c_strs() in logging and the GUI (Philip Kaufmann)
f7d0a86 netbase: Use .data() instead of .c_str() on binary string (Wladimir J. van der Laan)
remove unneeded cast in rpcmisc.cpp
Add init scripts and docs for Upstart and OpenRC