On Apr 30, 2014, at 3:02 PM, Tom Swirly <notifications@github.com> wrote:

> In src/ripple/json/impl/json_value.cpp:
> 
> > @@ -554,6 +554,26 @@ Value::operator= ( const Value& other )
> >      return *this;
> >  }
> >  
> > +Value::Value ( Value&& other )
> > +    : value_ ( other.value_ )
> > +    , type_ ( other.type_ )
> > +    , allocated_ ( other.allocated_ )
> > +# ifdef JSON_VALUE_USE_INTERNAL_MAP
> 
> Now you have made this change, it seems clear to me that Value::swap isn't correct, because it doesn't swap the values of itemIsUsed_ and memberNameIsStatic_ in the case that JSON_VALUE_USE_INTERNAL_MAP is defined.
> 
> Is my reasoning correct? If so, could I convince you to make this change?

Done (I think):

https://github.com/ripple/rippled/pull/339/commits

Howard