This was a misplaced idea what "Stale" meant.  It actually resulted in the
servers being removed from the list every 3 seconds, even if they were
still active.

Doug


On Wed, Jun 4, 2014 at 9:44 PM, evanShap <notifications@github.com> wrote:

> In lib/noam_server/located_servers.rb:
>
> > -    end
> > +		end
> > +
> > +		def reap
> > +			staleness_timeout = 3
> > +			staleness_threshold = Time.now.getutc - staleness_timeout
> > +			any_changes = false
> > +			@elements.dup.each_pair do |element_id, info|
> > +				if info[:last_modified] > staleness_threshold
> > +					@elements.delete(element_id)
> > +					any_changes = true
> > +				end
> > +			end
> > +			run_callbacks if any_changes
> > +		end
> > +
>
> @dougbradbury <https://github.com/dougbradbury> - I think the idea behind
> this was to protect against missed messages if the reaping was triggered on
> changes only. Is this a valid concern?
> … <#14669e98a5416693_>
> On Thu, May 29, 2014 at 1:19 PM, Doug Bradbury <notifications@github.com>
> wrote: In lib/noam_server/located_servers.rb: > - end > + end > + > + def
> reap > + staleness_timeout = 3 > + staleness_threshold = Time.now.getutc -
> staleness_timeout > + any_changes = false > + @elements.dup.each_pair do
> |element_id, info| > + if info[:last_modified] > staleness_threshold > +
> @elements.delete(element_id) > + any_changes = true > + end > + end > +
> run_callbacks if any_changes > + end > + This doesn't make much sense to
> me. I think that this would cause the servers to unnecessarily be reaped
> pretty often. The callback need to be run when a server gets added who has
> a new last_modified time. I think this will generate a lot of unnecessary
> traffic. — Reply to this email directly or view it on GitHub <
> https://github.com/noam-io/host/pull/8/files#r13202180>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/noam-io/host/pull/8/files#r13421888>.
>