I don’t really see why it should be private unless it is modifying the internal state of a data structure.

On 27 Mar 2014, at 16:57, Madnebular <notifications@github.com> wrote:

> In cvt/vision/board_detector/BoardDetector.h:
> 
> > +    void drawHomographyLines(Image& image,
> > +                             const PointSet2f& matched_model,
> > +                             const Matrix3f& homography) const;
> > +    
> > +    /**
> > +     * @brief  Debug function, draws a colored line from start to end
> > +     */
> > +    void drawLine(Image& image,
> > +                  const Point2f& start, const Point2f& end,
> > +                  float r, float g, float b) const;
> > +    
> > +  private:
> > +    /**
> > +     * @brief  Compares points according to distance from given center point
> > +     */
> > +    struct SquareDistanceComp
> No reason. Should they be public?
> 
> —
> Reply to this email directly or view it on GitHub.
>