Reformat index documentation

Move the paragraphs about running the reindex program and the index
names up to the top of the index section.  It makes more sense to
have them there, than in the middle of the setting descriptions.

Change-Id: I875a66173f752554803ca95bc166fba0dfbcd315
Add documentation of the index.threads setting

Change-Id: I4e7b737791968123d78c19ef558327609ef11b30
Escape dollar sign in plugin manifest entries

Escape dollar sign in plugin manifest entries, to prevent that
it is interpreted by the shell and thus get removed.

Change-Id: Iefd8abdcd207cb985f8156c7e41c094c1aa12b27
Access-control: Specifying what is meant by ssh access

As the owner still can't create a branch by pushing a reference over
ssh I think the previous statement isn't as clear as it could be.
Original commit 7ec4ac71ffa58f32e1443b0ca0110417244983c0 seems to
only deal with the create-branch command, not changing the behavior
over creating a reference by pushing it (over ssh).

Change-Id: Iac3f52b10ee6a92862622e8699c5daa1d4749247
Signed-off-by: Fredrik Luthander <fredrik@gandaraj.com>
Access-control: Administrators no longer have all capabilities by default

Update the documentation accordingly.

Change-Id: If62076b4671a3a46a68ef9dab12c462b90df2b50
Signed-off-by: Fredrik Luthander <fredrik@gandaraj.com>
Documentation: mention that index.commitWithin uses time units

Change-Id: I54a17369ce6395190b8a0c02fb77b260251cc6ba
Fix typo in REST API example for /test.submit_rule

Change-Id: I122aa4168b89fec2dc353718db847ef6a764ef71
Disable "save" button while saving commit message edit

After editing the commit message and pressing "save", the button
remains active until the message is saved and the dialog is closed.

Usually the edit completes quickly, but on some systems where the
network is slow it can take a few seconds.  If the user presses the
"save" button again (perhaps more than once) it will result in more
than one edit request being sent.  This can in some cases result in
inconsistency between the database and the git repository, which
prevents the change from being viewed any more until a new patch set
is manually uploaded.

Disable the "save" button after it has been pressed, to prevent this.

Change-Id: I820095a1d91b7fd7c498c7c24fa5e7e81e40a7eb
Hide `refs/heads/` prefix in cherry-pick branch suggestion list

Bug: Issue 2526
Change-Id: I82b8bf7f6abbdfbade7f508f2b974a98d8ca39b4
Access-control: Adding drafts to examples

Change-Id: I24c58a9a7ad0b73e9a06b1a87f01c9f299b623f0
Signed-off-by: Fredrik Luthander <fredrik@gandaraj.com>
Don't add "Patch File" download link for merge commits

The patch download does not work for commits with more than
one parent.

Bug: Issue 2538
Change-Id: I631500ab2b30c213f62d517cd492a1aca52f1211
ChangeScreen2: Respect comment visibility strategy

Bug: Issue 2456
Change-Id: I71f9ae2664a8f8c7f4eb8e019696764982781f58
SideBySide2: Fix syntax highlighting for shell files

Change-Id: I7b209eaeeb131d5e9c7a6d8417acca91bcb699cc
(cherry picked from commit 866c8e92a402a28427097e17285f6c179c98933c)
Emit ref-updated event when editing project access via web UI

Bug: Issue 2564
Change-Id: I9426f6969a234b081f72197ed0cb061512bc6e09
Disable commitWithin when running Reindex

Disable the 'commitWithin' from within Reindex by overriding
the configuration with '-1'. Treat negative values as the
original behavior, auto-flushing but not auto-committing, which
is the least safe but the most efficient for reindexing the
entire site. 

Change-Id: Ifdba797bee871d2a3d8928810a6304bacb850c8c
By default don't allow admins to create new branches by push

When pushing changes it is easy to make a typo in the refspec and
in this case new branches should not be created. If administrators
want to create branches by push they should explicitly assign
themselves the needed access rights.

This was broken by [1].

[1] https://gerrit-review.googlesource.com/#/c/54048/

Change-Id: I768bfd6d7cb193b0ec9f51c3fa768087ceb91acd
Bug: Issue 2557
Update the mysql documentation concerning charsets

This commit changes the mysql setup documentation because
there is no need to use latin1 encoding if you are using
another engine than the MyISAM engine.

Bug: Issue 1273
Change-Id: I432957381385c3e0390bb0db245139954300ecb8
(cherry picked from commit 13d07ecc7cd98cfd928a2b06d8755aea1fddde61)
Bump GERRIT_VERSION to 2.8.4

Change-Id: I3d1300a0d87e9ca59d971cc20f162d9f9eb8237f
Serialize GWT dbg and opt compiles

The GWT compiler swamps a system when it builds, using multiple
threads to build each permutation in parallel. It also requires
a lot of RAM. Buck is not aware of the cost of the genrule and
currently schedules both to build at the same time.

Make ui_opt depend on ui_dbg so Buck is forced to serialize these
build steps, reducing the load on average systems while possibly
extending build time on very powerful (e.g.  16 core) systems.

Change-Id: Icc1856c9c4e7919c28dc533e792fa25aadcdf801
Helper script to update API version in plugin archetype pom files

Running the script in the root of the Gerrit folder:

  ./tools/version NEW_VERSION

will replace the value in the first occurrence of the <version> tag
in the plugin archetype pom files with the value specified by
NEW_VERSION.

Change-Id: I9f529852af22a1eef7f30e2fcaea8acea28057d9