then can you please remove doPostLoanTransactionChecks method call from the
method. and also please update the jira issue with details like actions
performed on recovery repayment(summary update and once collected fully how
the system behaves)


On Tue, Apr 22, 2014 at 12:24 PM, andrew-dzak <notifications@github.com>wrote:

> In
> mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/Loan.java:
>
> > +            changedTransactionDetail = loanRepaymentScheduleTransactionProcessor.handleTransaction(getDisbursementDate(),
> > +                    allNonContraTransactionsPostDisbursement, getCurrency(), this.repaymentScheduleInstallments, charges());
> > +            for (final Map.Entry<Long, LoanTransaction> mapEntry : changedTransactionDetail.getNewTransactionMappings().entrySet()) {
> > +                mapEntry.getValue().updateLoan(this);
> > +            }
> > +            /***
> > +             * Commented since throwing exception if external id present for one
> > +             * of the transactions. for this need to save the reversed
> > +             * transactions first and then new transactions.
> > +             */
> > +            // this.loanTransactions.addAll(changedTransactionDetail.getNewTransactionMappings().values());
> > +        }
> > +
> > +        updateLoanSummaryDerivedFields();
> > +
> > +        doPostLoanTransactionChecks(loanTransaction.getTransactionDate(), loanLifecycleStateMachine);
>
> Hi Sorry for the late reply i was not working on friday and monday. Your
> answer to the "is it allowed to change the loan status in case of complete
> payment or over payment from closed written off state" The answer is no
> since we write off the principal any other money recover from the written
> off loan is treated as income. The status of the loan stays the same for
> now. kind regards Andrew
> … <#14588374d39f0a3a_>
> On Fri, Apr 18, 2014 at 10:01 AM, pramod <notifications@github.com>
> wrote: In
> mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/Loan.java:
> > + changedTransactionDetail =
> loanRepaymentScheduleTransactionProcessor.handleTransaction(getDisbursementDate(),
> > + allNonContraTransactionsPostDisbursement, getCurrency(),
> this.repaymentScheduleInstallments, charges()); > + for (final
> Map.Entry<Long, LoanTransaction> mapEntry :
> changedTransactionDetail.getNewTransactionMappings().entrySet()) { > +
> mapEntry.getValue().updateLoan(this); > + } > + /*** > + * Commented since
> throwing exception if external id present for one > + * of the
> transactions. for this need to save the reversed > + * transactions first
> and then new transactions. > + */ > + //
> this.loanTransactions.addAll(changedTransactionDetail.getNewTransactionMappings().values());
> > + } > + > + updateLoanSummaryDerivedFields(); > + > +
> doPostLoanTransactionChecks(loanTransaction.getTransactionDate(),
> loanLifecycleStateMachine); is it allowed to change the loan status in case
> of complete payment or over payment from closed written off state -- Reply
> to this email directly or view it on GitHub<
> https://github.com/openMF/mifosx/pull/864/files#r11766281> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openMF/mifosx/pull/864/files#r11840396>
> .
>



-- 
Regards,
Pramod