Kam

Merge current REST work into master
Kam how are you replying to these messages, just by email? they appear as a
wall of text that I can't parse, and for some reason they don't show up on
Github. Can you respond on github.com maybe?


On Thu, Aug 7, 2014 at 1:06 AM, Kam Kasravi <notifications@github.com>
wrote:

> In oryx-lambda-serving/pom.xml:
>
> > @@ -49,11 +49,21 @@
> >        <groupId>javax.ws.rs</groupId>
> >        <artifactId>javax.ws.rs-api</artifactId>
> >      </dependency>
> > -    <dependency>
> > -      <groupId>org.glassfish.jersey.core</groupId>
> > -      <artifactId>jersey-server</artifactId>
> > -      <scope>runtime</scope>
> > -    </dependency>
> > +      <dependency>
> > +        <groupId>org.glassfish.jersey.core</groupId>
> > +        <artifactId>jersey-server</artifactId>
> > +        <version>${jersey.version}</version>
>
> I'm still seeing <version> tags in the child poms. I'm saying there
> shouldn't need to be any at all. They inherit from the parent. There's
> still an outstanding to-do on the doc comment about reference.conf, and an
> open question >on application-class vs application-package I think. If
> you're able, you might squash the commits in this branch too. But I should
> also really figure out if that's possible to do automatically on merging
> the PR. Either way best to >not have the merge history there in master.
> (You may want to rebase instead of merge?)
> On Wednesday, August 6, 2014 2:53 PM, Sean Owen <notifications@github.com>
> wrote: In oryx-lambda-serving/pom.xml:
>  @@ -49,11 +49,21 @@ <groupId>javax.ws.rs</groupId>
> <artifactId>javax.ws.rs-api</artifactId> </dependency> - <dependency> -
> <groupId>org.glassfish.jersey.core</groupId> -
> <artifactId>jersey-server</artifactId> - <scope>runtime</scope> -
> </dependency> + <dependency> + <groupId>org.glassfish.jersey.core</groupId>
> + <artifactId>jersey-server</artifactId> +
> <version>${jersey.version}</version>
> I'm still seeing <version> tags in the child poms. I'm saying there
> shouldn't need to be any at all. They inherit from the parent. There's
> still an outstanding to-do on the doc comment about reference.conf, and an
> open question on application-class vs application-package I think. If
> you're able, you might squash the commits in this branch too. But I should
> also really figure out if that's possible to do automatically on merging
> the PR. Either way best to not have the merge history there in master. (You
> may want to rebase instead of merge?)… On Wed, Aug 6, 2014 at 10:44 PM, Kam
> Kasravi <notifications@github.com> wrote: In oryx-lambda-serving/pom.xml:
> > @@ -49,11 +49,21 @@ > <groupId>javax.ws.rs</groupId> >
> <artifactId>javax.ws.rs-api</artifactId> > </dependency> > - <dependency> >
> - <groupId>org.glassfish.jersey.core</groupId> > -
> <artifactId>jersey-server</artifactId> > - <scope>runtime</scope> > -
> </dependency> > + <dependency> > +
> <groupId>org.glassfish.jersey.core</groupId> > +
> <artifactId>jersey-server</artifactId> > +
> <version>${jersey.version}</version> Ok, I pushed an update with pull
> request. Take a look... On Wednesday, August 6, 2014 2:38 PM, Sean Owen <
> notifications@github.com> wrote: In oryx-lambda-serving/pom.xml: @@
> -49,11 +49,21 @@ <groupId>javax.ws.rs</groupId>
> <artifactId>javax.ws.rs-api</artifactId> </dependency> - <dependency> -
> <groupId>org.glassfish.jersey.core</groupId> -
> <artifactId>jersey-server</artifactId> - <scope>runtime</scope> -
> </dependency> + <dependency> + <groupId>org.glassfish.jersey.core</groupId>
> + <artifactId>jersey-server</artifactId> +
> <version>${jersey.version}</version> I can't quite make this out as it
> displays in the email, and can't see the original comment anymore. I just
> mean that <version> tags can be entirely managed in the parent, and never
> appear in the child poms. It helps centralize version management. ${..}
> syntax is a great way to further tie together versions declared for several
> components that should share a version.… On Wed, Aug 6, 2014 at 10:22 PM,
> Kam Kasravi < notifications@github.com> wrote: Sorry - not to be dense
> but do you mean -- parent -- <dependency>
> <groupId>org.glassfish.jersey.core</groupId>
> <artifactId>jersey-server</artifactId> <version>${jersey.version}</version>
> </dependency> -- child -- <dependency>
> <groupId>org.glassfish.jersey.core</groupId>
> <artifactId>jersey-server</artifactId> </dependency> — Reply to this email
> directly or view it on GitHub. — Reply to this email directly or view it on
> GitHub <https://github.com/OryxProject/oryx/pull/6/files#r15905800>. —
> Reply to this email directly or view it on GitHub. Updated pom.xml - I
> missed one ${jersey.version} in pryx-lambda-serving/pom.xml. Agreed - we do
> need to resolve application-class vs application-package. One must be
> defined or we should log an error. I missed the to-do comment regarding
> reference.conf other than what I addressed in the prior sentence. I'll see
> if I can squash commits on master. Currently my git flow is 'git commit
> -a', 'git pull origin master', 'git push origin kam'.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OryxProject/oryx/pull/6/files#r15911913>.
>