@mrdavidlaing thanks for pull request! It looks really good! Would be nice to explicitly state the intention at the end of the test. For example, wrap the call in expectation that no errors were raised. 
```
expect {
  instance_manager.wait_for_spot_instance_request_to_be_active(spot_instance_requests)
}.to_not raise_error
```