`valid_search_path?` should probably be renamed to absolute search path, and the reason that this was removed is because Puppet always adds two search paths that _are_ valid paths but are almost always missing. When the Puppet specs are run they frequently retrigger this code which can cause many thousands of errors to be logged. The idea is that we should only warn on relative paths and silently ignore directories that don't exist, since they're not harmful but also not useful.