add unit test for share