Cc pdlogs 61

Updated after review comments for the ENT feature.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against sprout_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
Thanks, Andy.  I will do exactly this for each application, sprout/bono, homestead, chronos, ralf.

David

From: Andy Caldwell [mailto:notifications@github.com]
Sent: Thursday, December 18, 2014 1:38 PM
To: Metaswitch/sprout
Cc: David Collins
Subject: Re: [sprout] Cc pdlogs 61 (#895)


In sprout/main.cpp<https://github.com/Metaswitch/sprout/pull/895#discussion-diff-22065651>:

> @@ -1042,6 +1047,8 @@ int main(int argc, char* argv[])

>    opt.daemon = PJ_FALSE;

>    opt.interactive = PJ_FALSE;

>

> +  openlog("sprout", PDLOG_PID, PDLOG_LOCAL6);

You really should use the process name from argv[0] (for consistency with other users of syslog and to distinguish between logs from bono and sprout on co-located systems).

This is non-trivial (argv[0] will equal /usr/share/clearwater/bin/bono rather than just bono), it looks like the easiest way to do this (without requiring c++14 features) is to use boost::filesystem<http://www.boost.org/doc/libs/1_57_0/libs/filesystem/doc/index.htm>:

boost::filesystem::path p = argv[0];

std::string binary_name = p.filename();

If you don't decide to do this, can you please raise an issue in the sprout repository so we keep track of the deficiency.

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/sprout/pull/895/files#r22065651>.