Sure.
On Mar 24, 2014 5:06 PM, "ashh87" <notifications@github.com> wrote:

> In
> OpenPGP-Keychain/src/main/java/org/sufficientlysecure/keychain/ui/dialog/UploadKeyDialogFragment.java:
>
> > +        UploadKeyDialogFragment fragment = new UploadKeyDialogFragment();
> > +        fragment.setArguments(bundle);
> > +        return fragment;
> > +    }
> > +
> > +
> > +
> > +    @Override
> > +    public Dialog onCreateDialog(Bundle savedInstanceState) {
> > +        super.onCreateDialog(savedInstanceState);
> > +        Bundle data = getArguments();
> > +        final Uri dataUri = data.getParcelable("ARG_DATA_URI");
> > +
> > +        AlertDialog.Builder dialog = new AlertDialog.Builder(getActivity())
> > +                .setIcon(android.R.drawable.ic_dialog_info)
> > +                .setTitle("Upload key")
>
> Please use strings.xml instead of hard-coding strings. There are already
> some upload related strings in there, so you should be able to re-use some
> of them, as appropriate.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/openpgp-keychain/openpgp-keychain/pull/472/files#r10880274>
> .
>