commit before convert to vector