I see. In that case just return Integer. The modulo operation should go
into the caller, not this function.

Sent from my mobile phone.
On May 12, 2014 1:23 AM, "Sushant Hiray" <notifications@github.com> wrote:

> In src/functions.cpp:
>
> > +RCP<const Basic> C4 = div(add(sq3, one), mul(i2, sq2));
> > +
> > +RCP<const Basic> mC0 = mul(minus_one, C0);
> > +RCP<const Basic> mC1 = mul(minus_one, C1);
> > +RCP<const Basic> mC2 = mul(minus_one, C2);
> > +RCP<const Basic> mC3 = mul(minus_one, C3);
> > +RCP<const Basic> mC4 = mul(minus_one, C4);
> > +
> > +// sin_table[n] represents the value of sin(2*pi*n/24) for n = 0..23
> > +RCP<const Basic> sin_table[] = {
> > +        zero, C0, C1, C2, C3, C4, one, C4, C3, C2, C1, C0,
> > +        zero, mC0, mC1, mC2, mC3, mC4, minus_one, mC4, mC3, mC2, mC1, mC0
> > +    };
> > +
> > +bool get_pi_shift(const RCP<const Basic> &arg,
> > +			  RCP<const Integer> &n,
>
> No, n is not necessarily between 0 and 11, though finally we do a n % 24after passing.
> So I guess we can very well pass an int, converting before passing rather
> than after passing.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sympy/csympy/pull/168/files#r12516130>
> .
>