Introduce Puppet-lint/syntax test into Packstack

- Add puppet-lint and puppet-syntax
- To run puppet-lint, please look at the README.md file.

Change-Id: I4b9e5d0c030b891545bc07f10091d748cdc1482e
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
(cherry picked from commit b2c341d4a52c46181b7ed506ce05c5b4eabcd89b)
Add workaround for PuppetLint.configuration.ignore_paths

- https://github.com/rodjek/puppet-lint/issues/331

Change-Id: Ic6578b2ffa84f6f3955e49e4279be972ea4a5a96
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
(cherry picked from commit 13e543e0f050e73ed24094c95e74eb04eb11940d)
Remove Deprecated parameters for keystone::endpoint class

List of deprecated parameters and their replacements:
- public_protocol (replaced by public_url)
- public_address (replaced by public_url)
- public_port (replaced by public_url)
- internal_address (replaced by internal_url)
- internal_port (replaced by internal_url)
- admin_address (replaced by admin_url)
- admin_port (replaced by admin_url)

Change-Id: I9233c2b398bc4d357310c2eb931ffe69f6bdeede
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
(cherry picked from commit 4fe6406bbe1eb4f042d666babdf42d9d15bc6871)
Merge "Add workaround for PuppetLint.configuration.ignore_paths" into juno
Do not override defaults in local_settings

By default, the puppet-horizon module sets some additional
variables in /etc/openstack-dashboard/local_settings that conflict
with the default values in the package version. Specifically:

COMPRESS_OFFLINE = True
FILE_UPLOAD_TEMP_DIR = '/tmp'

This patch fixes that and sets COMPRESS_OFFLINE to False and
FILE_UPLOAD_TEMP_DIR to /var/tmp. Please note it requires patch
https://review.openstack.org/133929 to puppet-horizon to work.

Change-Id: I48a838a04619efbbf8187e2d3cd22246f5ba29b6
Fixes: bz#1148770
(cherry picked from commit f199e5e48d3a6feca8b73806acf4ea9e2833d5f7)
[Neutron] Fix undef hiera value for gre protocol

We have to use 'None 'in python to pass 'undef' to hiera.

Change-Id: I72fc58c765b2fc67a2b27c677fd1fa1e9762244f
(cherry picked from commit e95098f5d5f21f830664608eebf964d4c46e3796)
Adds Warning when NetworkManager is active on hosts

Fixes: rhbz#1117115
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
(cherry picked from commit 2faa9a2cb616615f189a7ed6a7eade9a9f12c0e6)
(cherry picked from commit ff7caad9f1943d3d09f511efad8a1dcbb6a165c7)

Conflicts:
	packstack/plugins/neutron_350.py

Change-Id: I7e0fed8b47dabb492f2f3e683f8e8d65497ad816
Merge "Do not override defaults in local_settings" into juno
Merge "Adds Warning when NetworkManager is active on hosts" into juno
Switch juno openstack patches branch to f22-patches

Change-Id: I4ed6560797d6ef36c21c0947cb6427a22a97541b
[Neutron] Ensure ovs agent setup runs for all CONFIG_NEUTRON_ML2_TENANT_NETWORK_TYPES

Previously we used to pick only the first type from tenant network types,
Now packstack parses whole array and sets ovs agent on nodes accordingly.

Closes-Bug: rhbz#1163697 rhbz#1168242
Change-Id: I15be465c7d910cee7224c0bf78e2a6a9d93f9bb4
(cherry picked from commit 730f1497a943af7e4c53b25a03255ed400ecdc79)
[Neutron] Deprecate ovs and linuxbridge plugins

They are no longer available in Juno.
Change-Id: Ic191384ca46594340ce5cf13b08218299e784117
Avoid KeyError: 'CONFIG_CINDER_VOLUMES_SIZE' error

- When CONFIG_CINDER_VOLUMES_CREATE=n, it should always pass in the cinder
  volume size calculation block.

Change-Id: I6cf6fd4767c66dc87ea31cbafe17bb8fcfebbf70
Fixes: rhbz#1164359
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
(cherry picked from commit 58bd73af9757e7031aa29d252bc318953c39639d)
Do not create cinder-volumes if not needed

When CONFIG_CINDER_VOLUMES_CREATE=n, Packstack tries to create
cinder-volumes anyway after commit
58bd73af9757e7031aa29d252bc318953c39639d .

Change-Id: I4d385b45024602539c85164d9fe410fda510bab1
(cherry picked from commit 438e92a024cc299f6248e5a43f85412fdab441b9)
Check packstack/version.py for PEP8 issues

Change-Id: If7666db19a2a37c5fb55ad54570cc68c9a9b2ceb
(cherry picked from commit c470c4229f57ab65b76e0ae87df7a6c155471d14)
Merge "Do not create cinder-volumes if not needed" into juno
Merge "Avoid KeyError: 'CONFIG_CINDER_VOLUMES_SIZE' error" into juno
Merge "Switch juno openstack patches branch to f22-patches" into juno
Packstack Plugins Clean-up

- Deleted unused import
- Pep8 compliance
- Deleted unused variables

Change-Id: I45f135b2467427cd7ee3b5ba32745af2a631458a
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
(cherry picked from commit 3da12069efc9044b8f8f8fd4d4118c406f4fe649)
Configure TCP keepalive setting to all nodes

In some cases, it has been observed that services keep their
connection to RabbitMQ when they should not (e.g. during a
controller server hard reboot), creating instability. This patch
aims at fixing this by setting TCP keepalive parameters for
RabbitMQ connections, and setting kernel parameters to send
keepalive packets more often.

Change-Id: I7688a86e4ff617f20d6767f156c5d880e0d4d619
Fixes: bz#1167414
(cherry picked from commit 86a166a4718ae90eab78949f82f4f7c12ded2a6c)