[iOS] Web Inspector: JSContext inspection crashes in isMainThread, uninitialized WebCoreWebThreadIsLockedOrDisabled
https://bugs.webkit.org/show_bug.cgi?id=128959

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-02-18
Reviewed by David Kilzer.

When JavaScriptCore is used without WebCore on iOS (e.g. JSContext)
the WebCoreWebThread* functions will not be initialized. Avoid
calling the function pointer if it is uninitialized. This was
happening with remote inspection via StringImpl::createCFString
for implicit NSString / WTFString conversion which uses isMainThread.

* wtf/mac/MainThreadMac.mm:
(WTF::webThreadIsUninitializedOrLockedOrDisabled):
(WTF::isMainThread):
(WTF::canAccessThreadLocalDataForThread):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r164296.
http://trac.webkit.org/changeset/164296
https://bugs.webkit.org/show_bug.cgi?id=128989

Broke many media tests (Requested by eric_carlson on #webkit).

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
* html/HTMLMediaElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rename convertFixedAndStickyPosition() to convertPositionStyle()
https://bugs.webkit.org/show_bug.cgi?id=128987

Reviewed by NOBODY. This is addressing a post-commit review from Dean Jackson.

No new tests are necessary because there is no behavior change

* editing/EditingStyle.cpp:
(WebCore::EditingStyle::convertPositionStyle):
* editing/EditingStyle.h:
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Temporarily remove support for setting the maximumDecodedImageSize. It is causing assertions.

* Shared/WebPreferencesStore.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix build.

* UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:
(-[WKProcessClassConfiguration description]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Minibrowser: Add shortcut to open Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=128813

Patch by Diego Pino García <dpino@igalia.com> on 2014-02-18
Reviewed by Anders Carlsson.

Added shortcuts Ctrl+Shift+I and F12 for toggling Web Inspector.

* MiniBrowser/gtk/BrowserWindow.c:
(toggleWebInspector):
(browser_window_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: shift-clicking #fff swatch results in bad rgb value
https://bugs.webkit.org/show_bug.cgi?id=128954

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-02-18
Reviewed by Daniel Bates.

parseInt("FF", 16) is already 255. Do not multiply the result by 255.

* UserInterface/Color.js:
(WebInspector.Color.fromString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove unnecessary UserActionElementSet constructor, destructor
https://bugs.webkit.org/show_bug.cgi?id=128962

Reviewed by Andreas Kling.

UserActionElementSet constructor and destructor are not necessary, as is not the
static create() function that returns PassOwnPtr<UserActionElementSet>. The implicit
constructor and destructor can take care of creating and destroying the sole HashMap
member variable.

* dom/UserActionElementSet.cpp:
* dom/UserActionElementSet.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Follow-up: Add type-checked casts for StyleImage and subclasses
<http://webkit.org/b/128915>

Address some style issues based on feedback from Andreas Kling.

* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImageURL):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::~CSSImageSetValue):
(WebCore::CSSImageSetValue::hasFailedOrCanceledSubresources):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::hasFailedOrCanceledSubresources):
- Use the reference version of the type-checked casts since we
  know the pointers are not NULL.

* rendering/style/StyleImage.h:
- Use 'styleImage' instead of 'resource' in
  STYLE_IMAGE_TYPE_CASTS.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Editing transparent color shows incorrect opacity slider
https://bugs.webkit.org/show_bug.cgi?id=128975

Reviewed by Joseph Pecoraro.

The opacity slider should show a range of colors from transparent to the full opacity of the tinted color.

* UserInterface/ColorPicker.js:
(WebInspector.ColorPicker.prototype._updateSliders):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: editing a color in the Styles sidebar using the color picker only works once for a given color
https://bugs.webkit.org/show_bug.cgi?id=128965

Reviewed by Timothy Hatcher.

Use the WebInspector.TextMarker backing the CodeMirror TextMarker object to inspect its type in
order to identify color markers that were created for a color. This fixes a regression introduced
in http://webkit.org/b/125695 when we abstracted CodeMirror TextMarker objects.

* UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchClicked.updateCodeMirror.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchClicked.updateCodeMirror):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add more WKWebView SPI
https://bugs.webkit.org/show_bug.cgi?id=128994

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKHistoryDelegatePrivate.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _unreachableURL]):
(-[WKWebView _loadAlternateHTMLString:baseURL:forUnreachableURL:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164313 268f45cc-cd09-0410-ab3c-d52691b4dbfc