Hi,

Definitely I was thinking the same thing that this pull was getting a bit long.

How about if I move that functionality (the volume ramp) into the core? Would it be more accepted there?

> On Jan 3, 2014, at 5:11 AM, Lawrence Akka <notifications@github.com> wrote:
> 
> In examples/commandline/sonoshell.py:
> 
> >  
> >  from soco import SoCo
> >  from soco import SonosDiscovery
> >  
> >  
> > +def fade_volume(sonos, start, target, duration):
> > +    """ fade the volume (up or down) from start to target over duration seconds """
> Hi Adam (Jacob? AdamJacob?)
> 
> UPnP can be pretty confusing. There is in fact no such parameter as RampTimeSeconds! RampTime is an output parameter, not an input parameter, and RampTimeSeconds is a variable name. All this means is that the function calls I mentioned will return a number which is (presumably) the time in seconds taken to achieve the desired volume.
> 
> I am still not sure about including custom volume ramps in the command line demo - it seems a little too custom to me. Please could separate the two features into two different pull requests (and in general, there should in future be one feature per pull request ;-) )? You may also need to rebase onto the current head.
> 
> Lawrence
> 
> —
> Reply to this email directly or view it on GitHub.