[EFL] Enable -Werror for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=98715

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-09
Reviewed by Gyuyoung Kim.

Treat all warnings as errors, except the existing warnings in the
current code base ("unused-parameter", "sign-compare" and "switch").

Thanks for Raphael Kubo da Costa for the extra help.

* Source/CMakeLists.txt: Enable warnings as error for all libraries
(except WebKit and WebKit2) for the EFL port.
Other cmake-based ports are welcome to join.

* Source/cmake/WebKitHelpers.cmake: Treat warnings as errors by
default for cmake-based ports when ENABLE_WERROR is set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Month/week picker should submit month/week string
https://bugs.webkit.org/show_bug.cgi?id=101744

Reviewed by Kent Tamura.

Month/week picker should submit month/week string and not yyyy-mm-dd.

No new tests. Test will be added in Bug 101555 and Bug 101556.

* Resources/pagepopups/calendarPicker.js:
(DaysTable.prototype._handleDayClick):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][DRT] Force a repaint before tracking repaint rects.
https://bugs.webkit.org/show_bug.cgi?id=101743

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl: 

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::forceLayout): Added.
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools: 

Do like other ports and force a repaint before we start tracking
repaints so that the pixel results generated look more in line
with what's expected.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(displayWebView): Call DRTSupport::forceLayout() before start
tracking repaints.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
webkitpy/layouttests integration test fails if high shards/processes environment variables are used
https://bugs.webkit.org/show_bug.cgi?id=101455

Reviewed by Dirk Pranke.

Updating test to disregard WEBKIT_TEST_MAX_LOCKED_SHARDS environment variable.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_max_locked_shards):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WinCairo build fails to link
https://bugs.webkit.org/show_bug.cgi?id=101739

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-11-09
Reviewed by Kentaro Hara.

* win/WebKit2CFLite.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unmark now passing tests
https://bugs.webkit.org/show_bug.cgi?id=65531

Reviewed by Csaba Osztrogonác.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::viewModes):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r134051.
http://trac.webkit.org/changeset/134051
https://bugs.webkit.org/show_bug.cgi?id=101757

It didn't fix the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Rebaseline fast/table/025-expected
https://bugs.webkit.org/show_bug.cgi?id=101752

Unreviewed rebaseline after https://bugs.webkit.org/show_bug.cgi?id=11645.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-09

* platform/efl/TestExpectations:
* platform/efl/fast/table/025-expected.png:
* platform/efl/fast/table/025-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Rebaseline svg tests after 99870
https://bugs.webkit.org/show_bug.cgi?id=101756

Unreviewed svg baseline after https://bugs.webkit.org/show_bug.cgi?id=99870.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-09

* platform/efl/TestExpectations:
* platform/efl/svg/custom/pattern-scaling-expected.png: Added.
* platform/efl/svg/custom/pattern-scaling-expected.txt: Added.
* platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Stop watchlist from triggering QtBuildSystem rule on DerivedSources

Having DerivedSources.pri in the watchlist regexp was creating too much
noise.

Reviewed by Ossy.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Remove obsolete tokenizer settings
https://bugs.webkit.org/show_bug.cgi?id=101689

Reviewed by Yong Li.

These tokenizer settings are obsolete and should not be here.  Remove them.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
https://bugs.webkit.org/show_bug.cgi?id=101759

Reviewed by Kenneth Rohde Christiansen.

* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Improve
the check for an empty repaintRect -- we need to check if the
WKArrayRef has any items. `if (repaintRect)' will return true
regardless of whether the array is empty or not.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Need to clear exception in JSDictionary that might have been caused by previous operation.
https://bugs.webkit.org/show_bug.cgi?id=96614

Reviewed by George Staikos.

IndexedDB IDBDatabase::createObjectStore supports both String type of KeyPath and
String Array type of KeyPath. It will first try to get the keyPath as a String Array,
if fails, it will try to get KeyPath as a String, from the Dictionary. The first get
will leave the internal ExecState of Dictionary in exception state. We need to clear
the exception state before the 2nd query, otherwise the second query will also fail.

No new tests. The existing test case LayoutTests/storage/indexeddb/tutorial.html should
now work with this patch.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::getWithUndefinedOrNullCheck):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] r133953 broke the ARM_TRADITIONAL build
https://bugs.webkit.org/show_bug.cgi?id=101706

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-09
Reviewed by Csaba Osztrogonác.

Fix for both hardfp and softfp.

* dfg/DFGCCallHelpers.h:
(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Bump the jhbuild Cairo version to 1.12.8
https://bugs.webkit.org/show_bug.cgi?id=101721

Bump the Cairo version in Jhbuild moduleset to 1.12.8. This version
should fix multiple failures in canvas tests and also contains
fixes for X-related crashes that occurred from the 1.12.4 version onwards.

* gtk/jhbuild.modules:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r134068.
http://trac.webkit.org/changeset/134068
https://bugs.webkit.org/show_bug.cgi?id=101766

Caused crashes on the bots. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-11-09  Xan Lopez  <xlopez@igalia.com>

        [GTK] Do not use 'ls' to list IDL files in EXTRA_DIST
        https://bugs.webkit.org/show_bug.cgi?id=101581

        Reviewed by Martin Robinson.

        Use normal GNU Make wildcards instead of 'ls' to list files in
        EXTRA_DIST, it's safer and more straightforward.

        * GNUmakefile.am: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Unreviewed gardening - rebaseline a handful of image tests for chromium-mac-lion.

* platform/chromium-mac-lion/platform/chromium/compositing/layout-width-change-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/core/backgrounds-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[css] Text decoration's "blink" not valid when CSS3_TEXT is enabled
https://bugs.webkit.org/show_bug.cgi?id=101750

Reviewed by Ojan Vafai.

Source/WebCore:

This patch fixes an issue regarding "blink" value, which is valid for CSS 2.1
"text-decoration" property, but recently have its parser function modified by
the addition of CSS3 "-webkit-text-decoration-line" property.

The 'fast/css/getComputedStyle/getComputedStyle-text-decoration.html'
layout test is updated with all possible value combinations.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseTextDecoration): Added 'blink' value to list
if accepted.

LayoutTests:

This patch updates the "text-decoration" computed style layout tests to
handle a larger variety of value combinations.

* fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt:
* fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Give the view a size in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=101770

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-09
Reviewed by Laszlo Gombos.

2 tests are currently failing, because they expect us to paint, but we don't paint if the view size is empty.

* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI):
(TestWebKitAPI::PlatformWebView::resizeTo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134079 268f45cc-cd09-0410-ab3c-d52691b4dbfc