more work on qr generator