Added configurable parameters for nValidHits, nMissIn, nMissMid, maxRelTrkIsoDeltaRp3, relTrkIsoDeltaRSize

Added configurable parameters for nValidHits, nMissIn, nMissMid, and relTrkIsoDelaRp3
Hi Vincenzo,

Could you clarify for me what your concerns are about the code as it
written? Do you think that it will not work properly in this release or
that it will take too much time?

I am not very familiar with the syntax you suggested so if you could point
me to a piece of code where it is done this way, I am happy to implement
these changes. It's just not immediately clear to me why we should do it
this way.

Thanks for your help!

Cheers,
Jessica

On Fri, Oct 3, 2014 at 2:14 PM, Vincenzo Innocente <notifications@github.com
> wrote:

> In RecoTracker/DeDx/plugins/HLTDeDxFilter.cc:
>
> > @@ -109,6 +121,21 @@ bool
> >            cand.setTrack(track);
> >            chargedCandidates->push_back(cand);
> >         }
> > +
> > +       //calculate relative trk isolation only if parameter maxRelTrkIsoDeltaRp3 is different from default value of 99
> > +       if(maxRelTrkIsoDeltaRp3_ >= 0){
> > +       double ptCone = track->pt();
> > +       for(unsigned int j=0; j<trackCollection.size(); j++){
> > +	 reco::TrackRef track2  = reco::TrackRef( trackCollectionHandle, j );
> > +         if (track->eta() == track2->eta() && track->phi() == track2->phi()) continue; // do not compare track to itself
> > +         double trkDeltaR = deltaR(track->eta(), track->phi(), track2->eta(), track2->phi());
>
> tracks do not store eta phi pt (candidate do)
> so here you must first create local arrays
> float eta[trackCollection.size()], phi[trackCollection.size()],
> pt[trackCollection.size()];
> float ptcone[trackCollection.size()]
> fill in one loop
> and then proceed with the combinatorial.
> you can loop from i+1 if you fill both ptcone[i] and ptcone[j]
> when you arrive at j (unless selection occurred) the sum over [0,j-1] have
> been done in the previous iteration over i...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cms-sw/cmssw/pull/5665/files#r18391493>.
>