Andrei,
This method doesn’t return any error ever! You could argue that it should not use S_OK maybe, but I think Krzys who wrote this decided to use the standard return for all methods… There are many methods in DIRAC and LHCbDIRAC that only return S_OK indeed...
Cheers, Philippe

Le 16 févr. 2014 à 13:45, Andrei Tsaregorodtsev <notifications@github.com> a écrit :

> In RequestManagementSystem/Client/Request.py:
> 
> > @@ -282,6 +282,10 @@ def __len__( self ):
> >      """ nb of subRequests """
> >      return len( self.__operations__ )
> >  
> > +  def __str__( self ):
> > +    """ str operator """
> > +    return str( self.toJSON()["Value"] )
> This is a bad practice. If a method returns S_OK/S_ERROR, the result success must be checked
> 
> —
> Reply to this email directly or view it on GitHub.
> 

-- 
Dr Philippe Charpentier
J09210, Physics Department, CERN, CH-1211 Genève 23
LHCb Experiment Distributed Computing Coordinator
Office 2-R-007, Tel : +41 22 767 4244 ,  GSM : +41 76 487 0167
mailto:Philippe.Charpentier@cern.ch  http://cern.ch/Philippe.Charpentier