Log VirusScanner options at startup; remove unwanted quoting of file names

Well, my reasoning was that `DISABLED` is less likely to be used than
`disabled` for an actual executable/script, at least on Un*x systems.

Executable names are case sensitive on Un*x, so the sentinel value is
too.  Plus I prefer to keep sentinel values to a minimum (DISABLED is
one value, case insensitively, it has 256 matches).  They always seem a
bit untidy.

On 2014-11-10 10:49, Damian Jansen wrote:
> In zanata-war/src/main/java/org/zanata/rest/service/VirusScanner.java:
> 
>>          // If the system property is empty or null, we try to use
>>          // clamdscan, but we don't throw an exception if we can't find it.
>>          // clamscan would work too, but takes ~15 seconds
>>          String scannerProperty = System.getProperty("virusScanner");
>> -        this.disabled = "DISABLED".equals(scannerProperty);
>> -        if (scannerProperty == null || scannerProperty.isEmpty()) {
>> -            this.scannerName = "clamdscan";
>> -            this.scannerSet = false;
>> +        DISABLED = "DISABLED".equals(scannerProperty);
> 
> Should we ignore case here? "DISABLED" is as good as "disabled" is as
> good as "DiSaBLEd"
> 
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zanata/zanata-server/pull/576/files#r20063438>.
> 


-- 
Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat