modal working now