version 2

Ha class level are the only ones my ide doesn't do automatically because it
breaks dtos.

Anyway I think this is mainly a personal taste issue.  Do you want me too
remove them or can I leave as is?


On Mon, Jul 28, 2014 at 3:31 PM, christiangoudreau <notifications@github.com
> wrote:

> In src/main/java/com/arcbees/analytics/client/ClientAnalytics.java:
>
> > +public class ClientAnalytics extends AnalyticsImpl {
> > +    private final Map<String, Double> timingEvents = new HashMap<>();
> > +
> > +    @Inject
> > +    ClientAnalytics(@Named("gaAccount") final String userAccount,
> > +            @Named("uaAutoCreate") final boolean autoCreate) {
> > +        super(userAccount);
> > +
> > +        init();
> > +        if (autoCreate) {
> > +            create().go();
> > +        }
> > +    }
> > +
> > +    private void call(final JSONValue... params) {
> > +        final JSONArray aryParams = new JSONArray();
>
> I agree with you at a class level. Local variable doesn't have effect
> outside of their usage which means that the class is still immutable by
> design.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ArcBees/universal-analytics/pull/3/files#r15461520>.
>