Small improvements

Main one is switching to mailcore2

Notes: MailCore2 [might not be 10.7 compatible](https://github.com/MailCore/mailcore2/issues/566#issuecomment-34891672) so if this is OK we should probably make the plugin 10.8+ only
> I noticed a warning that tls isn’t used any more, which is true. I feel like an explicit setting in the client should carry some weight though. Maybe the default for the switch statement should change to

Yeah, I meant to ask you about that one. I wasn’t quite sure about the difference between all the connection types. Now you’ve cleared it up I’ll fix it.

Oh, and you’re right about the QSMailMediator changes - yeah. We’ll need to rebuild them all. I’d forgotten that mail core changed their class names (although pretty much everything else is the same), so that’ll need to be done. It’ll give me an excuse to improve the Gmail plugin - what’s the other mail mediator plugin?

On 11 Medi 2014, at 03:33, Rob McBroom <notifications@github.com> wrote:

> In QSEmailActions.m:
> 
> > +        attachment = [MCOAttachment attachmentWithContentsOfFile:path];
> > +        [builder addAttachment:attachment];
> > +    }
> > +    
> > +    // set up the connection
> > +    NSDictionary *serverDetails = [mediator smtpServerDetails];
> > +    NSString *server = [serverDetails objectForKey:QSMailMediatorServer];
> > +    if (!server) {
> > +        // can't continue without an SMTP server
> > +        QSShowNotifierWithAttributes([NSDictionary dictionaryWithObjectsAndKeys:@"MailMediatorMissingServerNotification", QSNotifierType, [QSResourceManager imageNamed:@"AlertStopIcon"], QSNotifierIcon, @"Quicksilver E-mail Support", QSNotifierTitle, @"The chosen e-mail handler does not provide an SMTP server.", QSNotifierText, nil]);
> > +        return;
> > +    }
> > +    unsigned int port = [serverDetails objectForKey:QSMailMediatorPort] ? [[serverDetails objectForKey:QSMailMediatorPort] unsignedIntValue] : 25;
> > +    
> > +    MCOConnectionType connType = 0;
> > +    BOOL tls = [[serverDetails objectForKey:QSMailMediatorTLS] isEqualToString:@"YES"];
> I noticed a warning that tls isn’t used any more, which is true. I feel like an explicit setting in the client should carry some weight though. Maybe the default for the switch statement should change to
> 
> connType = tls ? MCOConnectionTypeTLS : MCOConnectionTypeClear;
> —
> Reply to this email directly or view it on GitHub.
>