Style fix: Replace do…end with {} in expect blocks

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Convert specs to RSpec 2.14.8 syntax with Transpec

This conversion is done by Transpec 1.10.4 with the following command:
    transpec .

* 5 conversions
    from: obj.stub(:message)
      to: allow(obj).to receive(:message)

* 3 conversions
    from: obj.should
      to: expect(obj).to

* 1 conversion
    from: obj.should_receive(:message)
      to: expect(obj).to receive(:message)

* 1 conversion
    from: obj.should_not
      to: expect(obj).not_to

* 1 conversion
    from: Klass.any_instance.stub(:message)
      to: allow_any_instance_of(Klass).to receive(:message)
Add back request accidentally deleted in 7645789b

Signed-off-by: Alex Coles <alex@alexbcoles.com>
split CONTRIBUTING.md from README.md
add "Git Flow" link to CONTRIBUTING.md
Clean up acts_as_journalized SaveHooks
acts_as_journalized: Use save! instead of save

This should prevent journals silently not being saved on validations
errors.
JournalManager: Fix attempting to create two journals with same version

Calculate journal version based on existing maximum instead of count.

Up to now, when removing a journal note with another journal entry
existing afterwards, there could be a single journal with version 2,
resulting in validation errors for the next attempt to add a journal.
Fix WikiController test_update_stale_page_should_not_raise_an_error

The test didn't specify the version it depended on, so its assertion failed.

I have no idea why the second changed assertion ever worked, since the
journal's version should never change. This restores the line as it
was before commit c25bbee177dbb71d983ff78ab528889a6ba4bec5.
Merge branch 'fix/wp_journal_not_added' into release/3.0
Add skeleton test for ng WorkPackagesController

Use `$timeout` service with `$timeout.flush()` as a shortcut to build
and resolve promises.

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Fix ng WorkPackagesController relative root path handling

Extract projectIdentifier correctly from window.location when the
Rails application is running with a relative root path configured
(this solution is currently sub-optimal, relying on a global variable)

User Story #7089

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Mark API v1 as deprecated in CHANGELOG
Teach ng WorkPackagesHelper to format 'currency' type

Still missing L10n support: currently EUR symbol is hard-coded.

User Story # 5225

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Teach #column_data_type to handle CurrencyQueryColumn

Since this class is only available in a plugin, we need to handle
match against its class name as a String. A better long-term solution
should be found for plugins to add their own data type.

User Story # 5225

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Merge pull request #1176 from marutosi/finn-contribute

split CONTRIBUTING.md from README.md
Merge pull request #1177 from marutosi/finn-branch-model

add "Git Flow" link to CONTRIBUTING.md
Fix travis' ruby version

Because of RVM not supporting Ruby 2.1.0 anymore we need to change the
Ruby version for travis.
Merge pull request #1237 from opf/fix/work-package-costs-plugin-currency-type

Fix/work package costs plugin currency type
Fix circular dependency, make timeline column watchers less expensive