better way to handle the markup percentage