Fix more packaging errors

Date: Wed, 5 Nov 2014 11:08:03 -0200
From: Eriberto <eriberto@eriberto.pro.br>
To: Dmitry Bogatov <KAction@gnu.org>
Subject: pygithub
Sender: eribertomota@gmail.com
X-Google-Sender-Auth: t801EMw9usfN29E58UvpCMApdZY
Content-Type: text/plain; charset=UTF-8

Hi Dmitry,

Finally I reviewed the pygithub. I found some issues. Please:

1. d/control: the long description must be a 'description', not a
tutorial. Please, describe what the package does, where to use it and
its features. You can add a README.Debian file to put the tutorial. As
short description, I suggest 'library to access the GitHub API v3'
(from README.rst) or 'provide the full GitHub API v3'.

2. d/copyright:

  - Your copyright is very complex. The PKG-INFO file says that
Vincent Jacques is the upstream. So, the block 'Files: *' is ok. But I
suggest you to gather the all copyright notices from github/*[1].
Example (please check, this is an example only):

Files: github/*
License: LGPL-3+
Copyright: 2012        Christopher Gilbert <christopher.john.gilbert@gmail.com>
           2012         Dima Kukushkin <dima@kukushkin.me>
           2012         Michael Woodworth <mwoodworth@upverter.com>
           2012         Petteri Muilu <pmuilu@xena.(none)>
           2012         Philip Kimmey <philip@rover.com>
           2012         Steve English <steve.english@navetas.com>
           2012         Zearin <zearin@gonk.net>
           2012-2013 Michael Stead <michael.stead@gmail.com>
           2012-2013 Vincent Jacques <vincent@vincent-jacques.net>
           2013         AKFish <akfish@gmail.com>
           2013         Bill Mill <bill.mill@gmail.com>
           2013         davidbrai <davidbrai@gmail.com>
           2013         Ed Jackson <ed.jackson@gmail.com>
           2013         Jonathan J Hunt <hunt@braincorporation.com>
           2013         Mark Roddy <markroddy@gmail.com>
           2013         Michael Stead <michael.stead@gmail.com>
           2013         Peter Golm <golm.peter@gmail.com>
           2013         Srijan Choudhary <srijan4@gmail.com>
           2013         Stuart Glaser <stuglaser@gmail.com>

Other possibiity (I prefer) is:

Files: github/*
License: LGPL-3+
Copyright: 2012        Christopher Gilbert <christopher.john.gilbert@gmail.com>
           2012         Dima Kukushkin <dima@kukushkin.me>
                        Michael Woodworth <mwoodworth@upverter.com>
                        Petteri Muilu <pmuilu@xena.(none)>
                        Philip Kimmey <philip@rover.com>
                        Steve English <steve.english@navetas.com>
                        Zearin <zearin@gonk.net>
           2012-2013 Michael Stead <michael.stead@gmail.com>
                     Vincent Jacques <vincent@vincent-jacques.net>
           2013         AKFish <akfish@gmail.com>
                        Bill Mill <bill.mill@gmail.com>
                        davidbrai <davidbrai@gmail.com>
                        Ed Jackson <ed.jackson@gmail.com>
                        Jonathan J Hunt <hunt@braincorporation.com>
                        Mark Roddy <markroddy@gmail.com>
                        Michael Stead <michael.stead@gmail.com>
                        Peter Golm <golm.peter@gmail.com>
                        Srijan Choudhary <srijan4@gmail.com>
                        Stuart Glaser <stuglaser@gmail.com>

Note that I used the alphabetical order. The initial work for this
file is hard. But, when realeased a next version, you will need only:

or, in 2015:

You can see another example here[2]. Note that this last example has
some directories in a special case.

  - Please, move the license texts to end of file.

[1] http://dep.debian.net/deps/dep5/#copyright-field
[2] http://metadata.ftp-master.debian.org/changelogs/main/v/volatility/unstable_copyright

3. d/*.pyremove: a question: why you removed the test/ directory?

4. d/rules: please, add a blank line between the targets (before
'override_dh_install')

5. You have a Lintian message:

I: pygithub source: duplicate-short-description python-pygithub python3-pygithub

6. You package doesn't build twice. You need:

- Add this target to d/rules:

override_dh_auto_clean:
        dh_auto_clean
        rm -rf build

- Ignore changes in PyGithub.egg-info/SOURCES.txt[3]. You must create
the debian/source/options file with this content:

extend-diff-ignore = "^PyGithub.egg-info/SOURCES.txt$"

[3] https://www.debian.org/doc/manuals/maint-guide/dother.en.html#sourceopt

Cheers,

Eriberto