[CLEANUP] Add phpDoc to properties in ext:backend/Controller classes

Resolves: #62634
Releases: master
Change-Id: Iece95781c1c0b1d50364f308d1aabb1ac0f0ec85
Reviewed-on: http://review.typo3.org/33729
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[TASK] Remove unused variable from FeatureManager->getBestMatchingConfigurationForAllFeatures

Removed the variable $featureName as it is never used.

Resolves: #62637
Releases: master
Change-Id: I5125d59d4acdf5aca77eb7b4aa11cbcb9cc5217b
Reviewed-on: http://review.typo3.org/33739
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
[CLEANUP] Correct phpDoc of FrontendLoginController->getDisplayText Function

The parameter $stdWrapArray is definied as string in the phpDoc
annotation @param. Corrected this to array

Resolves: #62636
Releases: master, 6.2
Change-Id: Ie5b30878fec65f6102ae4afc0a2f24a2b791a356
Reviewed-on: http://review.typo3.org/33736
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
[TASK] RTE: Remove directories pi1, pi2 and pi3

Remove directories pi1, pi2 and pi3 and adapt configuration of spell
checker, frontend RTE and click enlarge features accordingly.

Releases: master
Resolves: #62632
Change-Id: Idc9954d4eb3e03aba5f1b042f1dbc2f0dabc2d88
Reviewed-on: http://review.typo3.org/33727
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
[!!!][TASK] Do not clear caches after extension config change

This change removes the cache flush after extension configuration changes.
Furthermore we avoid duplicate cache flushing on extension installation.

Resolves: #59966
Releases: master
Change-Id: I6b214ac76fb7305c40f0ce7a33b895323979cbe6
Reviewed-on: http://review.typo3.org/31180
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[TASK] Add verbose output to report mail for failed tests

Adds the failed tests messages to the mail.

Change-Id: I104b7ad98b2ce1ab8014a0751f7adc8c72ad6ca2
Resolves: #58786
Related: #62101
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33400
Reviewed-by: Benedict Burckhart <bb@code-plant.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[TASK] RTE: Use own user agent identification

Replace ExjJs outdated user agent identification.

Releases: master
Resolves: #62630
Change-Id: Ib057fd1ea2c2fc78b0bfdf1e275c69e98331c1c2
Reviewed-on: http://review.typo3.org/33720
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
[CLEANUP] Cleanup EXT:rsaauth

EXT:rsaauth has several minor flaws codewise that make
PHPStorms inspection go wild:
* Clean up direct usage of $GLOBALS[TYPO3_DB].
* TCA of tx_rsaauth_keys is not needed and can be removed, as a
result, "Oops! You should not see this" no longer shows
up in db_lowlevel.

Resolves: #62623
Releases: master
Change-Id: I865a9bd3f3f0ff681ba0838a8cbb3a14b885e44f
Reviewed-on: http://review.typo3.org/33712
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
[TASK] RTE: Cleanup references to AllowClipboardHelper for Mozilla

Support for allowClipboard policy has been removed from Firefox
since version 29.
This is a follow-up to change https://review.typo3.org/#/c/33367/

Releases: master, 6.2
Resolves: #62296
Change-Id: I71941c911bc9596495dfea5839d3dba678463357
Reviewed-on: http://review.typo3.org/33754
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
[BUGFIX] Additional Identity Properties not set on mapping error

When binding Fluid forms to nested objects, Fluid automatically adds
hidden fields with the identifiers of all affected objects so that
the persistence layer can update all objects correctly.

When a form was redisplayed due to property mapping errors, the
identity fields for the nested sub objects were no longer created.

This change fixes this by making sure all identity fields are rendered
recursively also after property mapping errors.

Backport from #29290
Resolves: #59253
Releases: master
Change-Id: Ib4b2a065d967e87aa42bdc889fef3f0b727b748b
Reviewed-on: http://review.typo3.org/30502
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] RTE: In IE, the pasting pad sometimes shows an error page

In IE, the pasting pad for plain text pasting sometimes shows an
error page.
Apparently, a timing issue.

Releases: master, 6.2
Resolves: #62658
Change-Id: Idb34ea6bc00d6020da637addee42cfd2db2d87f3
Reviewed-on: http://review.typo3.org/33758
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
[TASK] Use ajax.php for clickmenu

The clickmenu still used its own alt_clickmenu.php
entry point until now which is not needed anymore
with ajax.php.

Further steps (out of scope for this patch)
are: use JSON instead of proprietary XML
and jQuery instead of prototype.

Releases: master
Resolves: #62666
Change-Id: Iae4a9623c59a8c985d15dbc9be0c0544ce6abf8e
Reviewed-on: http://review.typo3.org/33763
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
[CLEANUP] Remove scheduler option for extended description

There is an always activated option
to show a description for tasks on hover.

This option is removed, the feature is
always turned on.

Releases: master
Resolves: #62663
Change-Id: I6f3b656fb9f4721dcd23982eda31f63309bb35ed
Reviewed-on: http://review.typo3.org/33761
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
[CLEANUP] Use correct casting syntax

Resolves: #62664
Releases: master
Change-Id: Ib8e0695fc234ab67a2f73a65737e07cf9a2d19c6
Reviewed-on: http://review.typo3.org/33757
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[TASK] Use a new icon for sorting inline records

Adopt the order icon to fit the others.

Resolves: #62661
Releases: master
Change-Id: I1f34fb7eb808e9da0d9c5ba8177da979814cdd1a
Reviewed-on: http://review.typo3.org/33765
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
[CLEANUP] Add phpDoc to properties in ext:backend

Fixes some minor things on the go.

Resolves: #62669
Releases: master
Change-Id: Ida96d56d5f81ac3f1050958aa8ed821613a87e67
Reviewed-on: http://review.typo3.org/33767
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
[TASK] Message usage in reports module and extensionmanager

Refactoring the reports module a bit to no longer use status
message HTML for rendering since this is a misuse.

Similar change in extension manager configuration of salted
passwords extension.

Resolves: #62614
Releases: master
Change-Id: I0b3e4e1dfed72441bb01abdb4ad35b7dc058a606
Reviewed-on: http://review.typo3.org/33703
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
[CLEANUP] Code Cleanup of AbstractPlugin

AbstractPlugin serves as a base for non-extbase plugins.
In order to allow for a notice free environment and no code warnings
within TYPO3 CMS AbstractPlugin should:
* provide a central property for Database access (DatabaseConnection)
* provide a central property to access GLOBALS['TSFE']
These properties will then aid both us in the CMS core development as
well as extension authors by supplying code completion in IDEs like
PHPStorm or alike.

Resolves: #62662
Releases: master
Change-Id: I6a698b2481f33643ab800c7152f710f4ed6706a5
Reviewed-on: http://review.typo3.org/33762
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>