Sounds great to me.


On 12 apr. 2014, at 19:34, Thijs Cadier <notifications@github.com> wrote:

In lib/appsignal/transaction.rb:

> @@ -124,7 +126,6 @@ def to_hash
>
>      def complete!
>        Appsignal.logger.debug("Completing transaction: #{@request_id}")
> -      Thread.current[:appsignal_transaction_id] = nil
>        current_transaction = Appsignal.transactions.delete(@request_id)

True, that would be exactly the same result. Maybe it would be a bit
cleaner to use self here and then clean up the transaction in an ensure.

—
Reply to this email directly or view it on
GitHub<https://github.com/appsignal/appsignal/pull/16/files#r11560714>
.