Windows bugfixes

Some minor bug fixes. With the current boost version with MSVC11 (=2012) an additional define is needed. 
Also, the template name in the DeformationFieldTrafo was confusing.
In the ITK Examples CMakeLists, there seems to be some problems with the line endings. It may help to check in my version. 
I agree, but when cutting and pasting from online examples, the capitalization is mixed.

 

If we decide for one, I would vote for capitalized, because then it would be easy to see what are CMake commands and what are other things like directory names or file names, which are typically lowercase or mixed.

 

 

From: Arnaud Gelas [mailto:notifications@github.com] 
Sent: Dienstag, 17. Juni 2014 10:46
To: statismo/statismo
Cc: tom-albrecht
Subject: Re: [statismo] Windows bugfixes (#43)

 

In Examples/ITK/CMakeLists.txt:

> -itkDeformationModelFitting 
> -itkBuildShapeModel 
> -itkBuildShapeModel_75pcvar 
> -itkShapeModelFitting 
> -itkLandmarkConstrainedShapeModelFitting 
> -itkBuildGaussianProcessDeformationModel
> -itkLowRankGaussianProcessImageToImageRegistration
> -itkSimpleGaussianProcessImageToImageRegistration
> -RUNTIME DESTINATION bin)
> -INSTALL(PROGRAMS runITKExamples.sh DESTINATION  bin)
> +CMAKE_MINIMUM_REQUIRED(VERSION 2.6)
> +PROJECT(ssm_itk)
> +SET(CMAKE_VERBOSE_MAKEFILE ON)
> +
> +
> +FIND_PACKAGE(ITK 4.1 REQUIRED)

it would be great to stick to lowercase or uppercase for cmake command to make it uniform throughout the library. I'd prefer it to be lowercase (my humble opinion)...

—
Reply to this email directly or view it on GitHub <https://github.com/statismo/statismo/pull/43/files#r13848303> .  <https://github.com/notifications/beacon/4539251__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxODYxMzk2NCwiZGF0YSI6eyJpZCI6MzQ4MjQ1MTl9fQ==--91e146ed1ffc24fdc91a820599ca988a8e5fde35.gif>