Broken cast

All the way back since 2001 (ed53aaf5842e82f9a8d4d053b39e7db61c6d62ce "#89611#
react for (Beamer!)Frame->dispose() from outside," adding member
SfxChildWindow_Impl::xListener), that MyStruct hack was not in sync with
SfxChildWindow_Impl, so

  ((MyStruct*)pImp)->bVisible = false;

probably corrputed pFact rather than change bVisible.  The origin of that
MyStruct hack is lost to history, but probably stems from an ancient time when
changes across modules where prohibitively expensive, esp. when some feature had
to be crammed in shortly before release...

Change-Id: I13dc30c96ef70b2cc09dc117231c021910e0ce1e
(cherry picked from commit 0cb6a92f86e02f6342be5e8f931dc1849114230c)
-Werror,-Wunused-private-field

Change-Id: Id34e28a76cd686496e7d5e65fff89d7a8d3d2d08
(cherry picked from commit 3b0db84516503ce72b803bf04b0432b36c1ac70c)
-Werror,-Winconsistent-missing-override

...looks like loplugin:saloverride has problems detecting missing overrides in
case of covariant return types

Change-Id: I08f2f67a33cd1cfaf9308cd87d7a5f92203980ed
(cherry picked from commit 166fe80d65f1d46e52d313cf8894d9604b6a2ab8)
-Werror,-Wuninitialized

(in TableModel ctor: base class 'comphelper::OBaseMutex' is
uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex')

Change-Id: I2a54a1123384bdeaee917ad9f1f0047f13c3860f
(cherry picked from commit f0332a4a77880a04697b93cec8f1c2b913f60d1a)
-Werror,-Wuninitialized

(in SvxGraphCtrlAccessibleContext ctor: base class 'comphelper::OBaseMutex' is
uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex')

Change-Id: Ic6791043828b7b9f69c76867e26ee02a5ee66817
(cherry picked from commit a8a8cb216fd2b25a1ed8b9c217685dccacaa428e)
-Werror,-Wuninitialized

(in PropertyComposer ctor: base class 'comphelper::OBaseMutex' is
uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex')

Change-Id: I41ede9ab34e89c8dde23ce2e4fd6393b05c979c6
(cherry picked from commit da9fd02a4d1a36cf9d22d5b36ba36240585284f6)
-Werror,-Wuninitialized

(in DummyRenderer ctor: base class 'comphelper::OBaseMutex' is
uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex')

Change-Id: I5b151176c676a58593933b3f2e33a3e2dfdcc630
(cherry picked from commit 34d464316872fec13fc024d630cbfcc26b77185a)
loplugin:saloverride

Change-Id: I62e8c07faf1fb38b39dfb41e0ba408d5c534312f
(cherry picked from commit 63fbe59d054a99224dac5fa25ff1a16890365746)