working on parmaters