I had originally bunched them together so that we could see all the ENV
assignments clearly, but I'll shortly be rebasing to use
Vcloud::Tools::Tester, at which point this is no longer required.

I'll shift them around at that point.



On Wed, May 21, 2014 at 8:57 AM, Dan Carley <notifications@github.com>wrote:

> In spec/integration/core/vm_spec.rb:
>
> > +    @vapp_template_name = ENV['VCLOUD_TEMPLATE_NAME']
> > +    @network_names = [ ENV['VCLOUD_NETWORK1_NAME'], ENV['VCLOUD_NETWORK2_NAME'] ]
> > +    @network_ips = {
> > +      ENV['VCLOUD_NETWORK1_NAME'] => ENV['VCLOUD_NETWORK1_IP'],
> > +      ENV['VCLOUD_NETWORK2_NAME'] => ENV['VCLOUD_NETWORK2_IP'],
> > +    }
> > +    @test_case_vapps = IntegrationHelper.create_test_case_vapps(
> > +      1, @vdc_name, @catalog_name, @vapp_template_name, @network_names, "vcloud-core-vm-tests")
> > +    @vapp = @test_case_vapps.first
> > +    @default_storage_profile_name = ENV['DEFAULT_STORAGE_PROFILE_NAME']
> > +    @new_storage_profile_name = ENV['VCLOUD_STORAGE_PROFILE_NAME']
> > +    vapp_vms = @vapp.fog_vms.map do |fog_vm|
> > +      vm_id = fog_vm[:href].split('/').last
> > +      Vcloud::Core::Vm.new(vm_id, @vapp)
> > +    end
> > +    @vm = vapp_vms.first
>
> There's a lot of instance variables here. Does it make sense to localise
> some of them to the contexts that use them?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alphagov/vcloud-core/pull/48/files#r12884426>
> .
>