Fix to allow nova workers to be overrideable attributes

Current code has workers hardcoded. Nova already defaults workers
to number of available cpus.  No way for administrator to customize
number of workers.

Change-Id: If31e1eb9c743646ff471a6fcd6fe15b03f289cc3
Closes-Bug: #1317247
Add missing AMQP options to nova.conf

Use the new attributes defined in common to allow
these extra MQ settings to be set for compute.

Depends on change I850c01a40aab02cf4531f7983543ef89e0e60446

Change-Id: I6adf9ff6c35b05294d58e8e6dac5d045e0d0d70f
Remove superfluous else branches

These "variable = nil" initialisations happen automatically.  While its
not much that is gained from that now, let's not create bad examples to
follow.

Change-Id: I48134f418a691e95679e95e742c31f8b13f3f79d
Merge "Remove superfluous else branches"
Allow unix_sock_rw_perms to have attribute overrides

Closes-Bug: #1324821
Change-Id: I468d4e278ff580c69704a37e75af7fe7289e7853
Fix Strainerfile

Change-Id: Id7b659e1b4fa49d6493281d7f6b868d73872fa45
Implements: blueprint per-repo-tests
Improve ChefSpec coverage

The remaining untouched resources are due to a non-existant suse spec.
I.e., the package resources coming from the suse platform_attributes:

  package[openstack-nova]            openstack-compute/recipes/nova-common.rb:33
  package[python-mysql]              openstack-compute/recipes/nova-common.rb:41

and this one, coming from a suse platform_family conditional:

  execute[loading kvm modules]       openstack-compute/recipes/libvirt.rb:103

Change-Id: Ic0bac7c8c1abe52e2e21d1daa71cf5e05f3b8991
Allow dnsmasq_config_file to have attribute overrides

Change-Id: Ide8d1015d1a4455cea680b8a5b5dbb7552c69e34
Closes-Bug: 1327031
Added missing cookbook dependency in README.md

Just add openstack-network as cookbook dependency in `Requirements`
section.

Change-Id: I718c7ec1e8cf1648ac416b61f4ecf8f98457d82b
Make retrieval of vmware_host_pass optional

Before this change, a non-vmware user would (without developer mode
have to create a data bag item for this pass even when not using it,
because otherwise the get_secret's call would fail.

Now, the lookup depends on the value of

    node[openstack][compute][driver].split('.').first

to work with both vmwareapi.VMwareESXDriver and vmwareapi.VMwareVCDriver

Implements: blueprint vmware-password-databag
Change-Id: I8c003deb2181b8120b343f85f8759d5de19036ca
Merge "Added missing cookbook dependency in README.md"
Merge "Make retrieval of vmware_host_pass optional"
Create state and lock paths

The instances path was bring created, but not the state or lock paths.
If these are overridden to different places, nova will fail to start.
Removed the unused hardcoded lock path in api and scheduler recipes.
Moved the path creation to nova-common recipe.

Change-Id: I7538edff91233761a1c6336ca4cfe080eeee093d
Closes-Bug: #1328956
Merge "Improve ChefSpec coverage"
Merge "Create state and lock paths"
Add resize_confirm_window configuration option

Add resize_confirm_window configuration option to nova.conf.erb

Closes-Bug: #1328522
Change-Id: I9839c7629bb58489468fd98032abcb76a87725f7
Remove the storage_availability_zone settings

* Remove the storage_availability_zone from nova.conf.
* Add some testcases.

Closes-Bug: #1326248
Change-Id: I2887c6fba8a904f46e5f0bd9a8faf9da7ff077ca
Allow inject_partition to have attribute overrides

* Add new libvirt_inject_partition attribute
* Add new testcases.

Closes-Bug: #1328959
Change-Id: I836ed057449583523b8bc21c001f979669b6cef8
Fixes a typo in nova-cert

It should be status instead of statusi passed to the supports attribute.
For now it doesn't cause any errors but that really depends on how chef
behaves.

Change-Id: I287ee2ce9daa80ca2f17e68b50cf44eefea81c98
Allow live migration attributes

Change-Id: I435200916b006af9146b8b2790fd167ad4d50fee
Closes-Bug: #1286582