Enhancement (DELETE) and Bug fixes (around POST response)

1. In fetch(), the check for negative response to raise HALNavigatorError,
       if raise_exc and not self.response:
            raise HALNavigatorError(self.response.text,
                                    status=self.status,
                                    nav=self,
                                    response=self.response,
            )    
   Is not too late in the flow?. I feel it should be checked before processing the response body 

2. PostResponse can have properties, hence implemented __call__ to return properties

3. DELETE method is similar to POST from Navigator perspective (non-idempotent) 
  Hence,
         a) Reused logic from POST to implement support for DELETE
         b) renamed PostResponse to HALResponse 
         c) renamed  create() to post() for clarity
   In order to provide backward compatibility, I created alias "create"  to "post"

4. HALNavigator should not allow POST if the uri is templated. The check for templated_uri 
   was missing. Created a wrapper function (@template_uri_check) to re-use for all methods - GET/POST/DELETE

TODO:
1. Enforce templated_uri check for all HTTP calls. Add test coverage 
2. a link usually have 'method' property (default to 'GET'), which can be used to restrict http operations. this helps to raise NotImplementedError and can have a controlled default function e.g autofetch
Hmm. How about making Link as separate class ? Instance of it can be a
property of Navigator
On 31 Oct 2014 08:29, "Josh Kuhn" <notifications@github.com> wrote:

> In restnavigator/halnav.py:
>
> > @@ -395,9 +488,10 @@ def __init__(self, parent, response):
> >          self.response = response
> >          self.template_uri = parent.template_uri
> >          self.template_args = parent.template_args
> > -        self.parameters = None  # POST doesn't have parameters
> > -        self.templated = False  # PostResponse can't be templated
> > +        self.parameters = None  # HALResponse doesn't have parameters
>
> I realized this was wrong. I got confused originally and thought the
> parameters were the url query params (which are for GET not POST), but it's
> the template_uri params. This leads me to believe we actually need a
> template_uri object that keeps track of its own parameters and will
> declutter the Navigator classes.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/deontologician/rest_navigator/pull/8/files#r19656074>.
>