Use COPY_STATEID to copy stateid.

Removed an unused call to state_share_check_conflict(), used
COPY_STATEID to copy delegation stateid.

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Reviewed-by: Srikrishan Malik <srimalik@in.ibm.com>
Clean up in nfs4_op_delegreturn

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Reviewed-by: Srikrishan Malik <srimalik@in.ibm.com>
Don't overwrite the delegation recall time

We should keep the first time when we attempt to recall the delegation
for calculating when to revoke. Don't overwrite that value with every
attempt to recall the delegation.

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Reviewed-by: Srikrishan Malik <srimalik@in.ibm.com>
Set lock_reclaim in get_delegation

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Reviewed-by: Srikrishan Malik <srimalik@in.ibm.com>
Fix subtract_deleg_from_list.

Delegation locks are full length locks unlike range locks, so there
is no need to do any subtraction!  Hence renamed the function to
remove_deleg_lock. This calls remove_from_locklist to properly free
the lock.

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>