The thing is that the __eq__ was not checking for class of the objects nor for the Table.type attribute, that's why I changed this method.

On May 1, 2014, at 10:07 AM, Daniel McDonald <notifications@github.com> wrote:

> In biom/table.py:
> 
> > @@ -444,60 +491,77 @@ def descriptive_equality(self, other):
> >              return "Observation metadata are not the same"
> >          if self.sample_metadata != other.sample_metadata:
> >              return "Sample metadata are not the same"
> > -        if not self._data_equality(other):
> > +        if not self._data_equality(other._data):
> >              return "Data elements are not the same"
> >  
> >          return "Tables appear equal"
> >  
> >      def __eq__(self, other):
> I'm a bit confused, all methods in test_table were passing when @ElDeveloper and I issued this PR. I specifically remember resolving this issue. Is your repo up to date?
> 
> (python27)10:07:11 tests@issue-290$ python test_table.py
> ........................................................................
> ----------------------------------------------------------------------
> Ran 72 tests in 0.342s
> 
> OK
> (python27)10:07:16 tests@issue-290$ git pull origin issue-290
> remote: Counting objects: 85, done.
> remote: Compressing objects: 100% (85/85), done.
> remote: Total 85 (delta 58), reused 0 (delta 0)
> Unpacking objects: 100% (85/85), done.
> From github.com:wasade/biom-format
>  * branch            issue-290  -> FETCH_HEAD
> Updating 0de5b30..6274ed2
> Fast-forward
>  biom/table.py       |  23 ++++++-----
>  tests/test_table.py | 390 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 395 insertions(+), 18 deletions(-)
> (python27)10:07:27 tests@issue-290$ python test_table.py
> .............................................................................
> ----------------------------------------------------------------------
> Ran 77 tests in 0.384s
> 
> OK
> (python27)10:07:30 tests@issue-290$
> —
> Reply to this email directly or view it on GitHub.
>