Try to fix
packet-mysql.c(1446) : warning C4244: 'function' : conversion from 'guint64' to 'gint', possible loss of data

Change-Id: Ie0b2e916e0d15287f5a3ededc404b678b45600d8
Reviewed-on: https://code.wireshark.org/review/1525
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add a cast to make MSVC happy.

Change-Id: Iee901ae56c796007821c1754056c61954e8a342f
Reviewed-on: https://code.wireshark.org/review/1526
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix build failures caused by lldp cleanup

Change-Id: I4d4aeb71720f02e4a6f4a8e5f803fd63dc7aed81
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Reviewed-on: https://code.wireshark.org/review/1524
Reviewed-by: Anders Broman <a.broman58@gmail.com>
sigcomp: Add buffer check to STATE-ACCESS

Two conditions were not checked, state_length == 0 && state_begin != 0
and the boundaries of the state buffer. The former is not a big deal,
but the second issue causes a buffer overrun (detected by ASAN).

The buffer size is supposed to be stored in the state buffer, that was
not the case for the initial two SIP SDP and Presence state buffers.
Fix a typo for presence_buf zero-ing while at it.

Bug: 9601
Change-Id: I41dde83185da60b670cca010ecc7b2a2aaaedeb9
Reviewed-on: https://code.wireshark.org/review/1529
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Minor changes to LBM dissectors:
(1) Display sequence numbers in both decimal and hex
(2) Fix an inconsistency in field naming between LBT-RU and LBT-RM.

bug:9718
Change-Id: I967062d6aa00ea9a3db51db94e56d37e68e642d3
Reviewed-on: https://code.wireshark.org/review/1531
Reviewed-by: Evan Huus <eapache@gmail.com>
Enhance Microsoft NLB dissection

Rewrite from Microsoft Network Monitor dissector

Based from NPL dissector 
https://nmparsers.codeplex.com/SourceControl/latest#Develop_Branch/NPL/Windows/nlb.npl

No yet support type Reliable Protocol (no found pcap with this pcap)

Change-Id: Ic5aa68798a629f9e0ad15337b192a1fe180ae62c
Reviewed-on: https://code.wireshark.org/review/1464
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Fix macro parens to avoid unexpected behaviour

Based on Icfe1e5477043dd695fd9b02b677ef29ac3fa8866 but rebased and simplified.

Change-Id: I9b7266e2fdcb58f38115250d785637cd585c69e0
Reviewed-on: https://code.wireshark.org/review/1532
Reviewed-by: Evan Huus <eapache@gmail.com>
Update kafka dissector closer to latest spec

Some new error values, some message types that have been "undocumented" as
internal-only, etc.

Change-Id: Iff15dd67b188c9e2745964d4916b22e0bea4243d
Reviewed-on: https://code.wireshark.org/review/1533
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: Ib4bbf1fa048cde14baf10bd31342b3c75e10b544
Reviewed-on: https://code.wireshark.org/review/1534
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Added check for MAUSB length being multiple of a DWORD.

MAUSB Packets should always be sent in DWORDs. This means that the
only valid values for the length field are multiples of 4.
This patch adds an expert info check to flag length fields that are
multiples of 4.

Change-Id: Ifb793f82aed4c9fb09a12f6ea97087733b58d14a
Reviewed-on: https://code.wireshark.org/review/1536
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
VALS() doesn't take the address of a (pointer to a) value_string, it takes
a pointer to a value_string.

Fixes the fuzz failure reported in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10079

Bug: 10079
Change-Id: Ifc8d6895cc33ad1f00386a3e59926322bd501125
Reviewed-on: https://code.wireshark.org/review/1538
Reviewed-by: Anders Broman <a.broman58@gmail.com>
fix dissect_usb_endpoint_descriptor

dissect_usb_endpoint_descriptor uses usb_trans_info, but the signature
contains a _U_ macro.

Change-Id: I87fe6d91d5f8cf15926bf2dfd6381a256cd0785d
Reviewed-on: https://code.wireshark.org/review/1537
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tweak ber_choice flow control.

There appear to be a couple of bugs in the flow control of this function (which
is very confusing), at least one of which is leading to a buffer overrun. See
the bug comments for more details and guesses of what the correct thing to do
is.

Bug:9579
Change-Id: Ibd3077792c7689a715ea53e8bf8c7a561c67389f
Reviewed-on: https://code.wireshark.org/review/1530
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Don't pass the address of a pointer to a *_string to VALS() or RVALS().

This is a followup to Ifc8d6895cc33ad1f00386a3e59926322bd501125; the MQ sample
captures I have don't seg-fault on this but the code was stillw wrong.

Change-Id: Ic689c06836b823a15217281d67b33580fd8e9823
Reviewed-on: https://code.wireshark.org/review/1539
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
PDCP LTE: add identification of ZUC based security algorithms

Change-Id: I63a66bc5822ac04f1a2bccd3a15adac30b65e397
Reviewed-on: https://code.wireshark.org/review/1541
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
"Reserved" is not a valid 'fieldconvert' value for an hf.

Fixes (for real this time, I swear!) the fuzz failure reported in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10079

Bug: 10079
Change-Id: I2a73ef32d704fc9ecc71fd983fc09cf4f9194b2e
Reviewed-on: https://code.wireshark.org/review/1542
Reviewed-by: Sean Onufer Stalley <sean.stalley@intel.com>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I3c54712108978d1bafe2b5da96e6a7d3d41948b5
Reviewed-on: https://code.wireshark.org/review/1535
Reviewed-by: Evan Huus <eapache@gmail.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I8727e74d0818f759f3c58c6f156b0b4e36eb7218
Reviewed-on: https://code.wireshark.org/review/1465
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Further LLDP dissection cleanup

Change-Id: I75f4ed401f63e993a2aefa1c289fd48fa00b46e2
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Reviewed-on: https://code.wireshark.org/review/1528
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Make it pass the new check in checkapi
"Error out if someone passes the address of a pointer to a *_string to
VALS() or RVALS()."

Change-Id: I1b5b9bbf512f8fdfaab5febea28db2c51d49c48c
Reviewed-on: https://code.wireshark.org/review/1544
Reviewed-by: Anders Broman <a.broman58@gmail.com>