I'm sorry, I may have misused the word "inline". I meant that as far as I
can tell you've created code blocks sitting free form in the middle of the
method, rather than being part of control flow. I've done that before, in
cases where it was the easiest way to avoid tediously renaming variables.
But I don't see that here. Am I missing something?
On Mar 28, 2014 6:54 PM, "Radu Mereuta" <notifications@github.com> wrote:

> In
> src/javasources/KTool/src/org/kframework/parser/concrete2/KSyntax2GrammarStatesFilter.java:
>
> > +
> > +    private int getUid() {
> > +        return seed++;
> > +    }
> > +
> > +    @Override
> > +    public void visit(Production prd) {
> > +        // TODO: put whitespace here instead of in grammar
> > +        NonTerminal nt = grammar.get(prd.getSort());
> > +        NextableState previous = nt.entryState;
> > +        if (prd.isListDecl()) {
> > +            UserList ul = (UserList) prd.getItems().get(0);
> > +
> > +            // label for '.Ids (list terminator)
> > +            NonTerminal specialNt = new NonTerminal(new NonTerminalId(prd.getSort() + "-special"));
> > +            {
>
> Inlining it makes it even more unreadable.
> That's just a very boring part of the code which creates a specific
> pattern of states.
> I've created a small picture in one of the comments which layout the
> result.
> Java is not the best language to make this look nice.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/318/files#r11090287>
> .
>