Revert "audioflinger: Bind new mixer code to the resampler property"

This reverts commit 9094602d5448482e63da2f56f8c637652a9e1a58.

Change-Id: I9f569082051916cd885c1bd140d5a2a766703407
Fix overload of SoftVideoDecoderOMXComponent::updatePortDefinitions

An overloaded function should take the same parameters as the function
it is overloading.

Change-Id: I8327fe1b363917515cf76c8f76bdbc05b2c0fbf0
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
Img_utils: Fix "unused" variables

For build-system CFLAGS clean-up, fix unused variables.

Change-Id: I589a73780f022271fce40f64305b29a84c382e5f
Libcpustats: Remove unused variable

For build-system CFLAGS clean-up, fix unused variable.

Change-Id: I6aba5f011d47271fae0ac5eca1d35a398dd56856
Remove unused parameter

Remove unused parameter clang complains about

Change-Id: I6710645658a802438e41d881d262231a10b091d3
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
Stagefright: Fix default typo

Change-Id: Ie2fef95a45dd124572bf062011a272898a371924
Remove check for an impossible condition

offset_for_ref_frame is an array rather than a pointer - it can't be
NULL (and the check causes a warning in clang).

Change-Id: I9b96e1e723e3b8caebd41821137ed6fb669d8cd4
Signed-off-by: Bernhard Rosenkraenzer <Bernhard.Rosenkranzer@linaro.org>
Remove extraneous parentheses

Remove extraneous parentheses that cause compiler warnings in clang

Change-Id: I88a3d84738433db85e4a04b673f82da7b0b1be10
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
Remove extraneous parentheses

Remove extraneous parentheses - they cause compiler warnings in clang

Change-Id: Ie2efd9714f9e2251cf3b204b5c5dd1a8b8aaca13
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
Fix uninitialized variable

In the case of !(err == OK && !mCancelled), sdpSize is used
uninitialized.

Change-Id: I33c6365ca6df13b0051491771d3eee3e35346b6d
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
Fix struct vs. class mismatches

Fix something being declared a struct and forward-declared a class and
vice versa.

gcc doesn't care, clang complains about the mismatch.

Change-Id: I7a7a8e9040e3c86fa1d73eb112631ea140861657
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
Fix struct vs. class mismatches

Fix class vs. struct mismatches clang whines about.

Change-Id: Ia551c796b6a5df8317943715447d0c28cdbf465a
Signed-off-by: Bernhard Rosenkraenzer <Bernhard.Rosenkranzer@linaro.org>

Conflicts:
	media/libstagefright/matroska/MatroskaExtractor.h
Add missing #includes

Some header files in stagefright try to use DISALLOW_EVIL_CONSTRUCTORS
(and even DISALLOW_IMPLICIT_CONSTRUCTORS, which isn't defined anywhere
in stagefright) without including the proper header.

With clang, this results in a build failure - with gcc,
it results in DISALLOW_EVIL_CONSTRUCTORS/DISALLOW_IMPLICIT_CONSTRUCTORS
not doing what they were intended to do, instead appearing as a method
in the DWARF debug sections of files using the headers.

Change-Id: Ie4e99affe98ed8fb1bfcf5ec604c19dcd5311c62
Signed-off-by: Bernhard Rosenkraenzer <Bernhard.Rosenkranzer@linaro.org>
Fix comparison of String8 to char* literal

Clang (correctly) interprets

if ("." == sName)

as

if ("." == (const char*)sName)

and recognizes that comparing the pointers isn't what was meant.

With

if (sName == ".")

both clang and gcc see and use String8::operator==(const char *),
ensuring we get the wanted behavior.

Change-Id: Ide240e13214a56f6899f72de3db75dac647e6d4b
Signed-off-by: Bernhard Rosenkraenzer <Bernhard.Rosenkranzer@linaro.org>
Fix linkage when building with clang, Intel CC or gcc -O0

This code fails to link when using clang, Intel CC, or gcc -O0 because of the
CHECK_GT statement in WifiDisplaySource::scheduleKeepAlive (explanation
at https://gcc.gnu.org/wiki/VerboseDiagnostics#missing_static_const_definition,
doesn't show up with gcc when optimizations are enabled because the
entire CHECK_GT statement is optimized away).

This fixes https://code.google.com/p/android/issues/detail?id=58221

Change-Id: I43d3629819a01971846c31e9f755d6e0567fb838
Signed-off-by: Bernhard Rosenkraenzer <Bernhard.Rosenkranzer@linaro.org>
Stagefright: Fix unused variables, functions, values

For build-system CFLAGS clean-up, remove unused functions and
variables.

Change-Id: Ic3dee56b589ea9a693efa1d72ba394036efff168

Conflicts:
	media/libstagefright/MediaCodecSource.cpp
	media/libstagefright/Utils.cpp