Move volume_clear option to where it's used

The `volume_clear` and `volume_clear_size` option are used in `lvm.py` so we
should move the definition there.

Change-Id: Ic619c2db0bb1b5ccc7dcbec1a500c3dcb1110b26
Correct a maybe-typo in pci_manager

the variable 'dev' in set_hvdevs are only used for list comprehension,
it does not make sense to use 'dev' again for updating self.stale.

Change-Id: I03f31bfcfc56a43e43eb88845e1d562f19a3a09e
baremetal: Remove depenency on libvirt's fetch_image method

It's messy for virt-drivers to depend on each other, so this patch alters
baremetal to use the cross-driver fetch function, instead of the libvirt
version.

Change-Id: I910c621452fa7eb9add417a8738e5757aeb1a48c
libvirt: Fix kwargs for _create_image

Rescue uses the `suffix` and `disk_images` kwargs of `_create_image`, but
passes them in as positional args. We should use explicit kwargs here to be
clear that rescue depends on both of those parameters being present.

In addition, disk mapping was being passed in as kwarg, but is actually a
positional arg, so we should pass it in as a positional arg to be clear that
it's required.

Change-Id: Iaa990729b4bb3569f4c71ceaf1adabed58f73026
move dict copy in prep for object-ify flavors

This change is to help split up the patches for object-ifying flavors.
It moves a dict copy of instance_type from the tests to
get_flavor_by_flavor_id().

Change-Id: I0082a56aa637169fd6e1db3aad56877c9f745bc5
refactor flavor db fakes in prep for object-ify flavors

This change is to help split up the patches for object-ifying flavors.
It refactors db fakes to provide default values for fields that are
not nullable in flavor objects.

Change-Id: I18575703cd5c52d4f446c9bca1edd7baf33b416f
refactor flavor manage tests in prep for object-ify flavors

This change is to help split up the patches for object-ifying flavors.
It refactors flavor manage tests to provide default values for fields
that are not nullable in flavor objects.

Change-Id: I59f0254269379ace2186ed90810c5d1a9f09fed7
Port fping extension to work in v2.1/v3 framework

Ports v2 fping extension and adapts it to the v2.1/v3 API
framework. API behaviour is identical.

- unittest code modified to share testing with both v2/v2.1
- Adds expected error decorators for API methods

Partially implements blueprint v2-on-v3-api

Change-Id: I8dc4ede46826bf6062097a3b4ba6be9a09a1bd12
Update NoMoreFixedIps message description

The exception NoMoreFixedIps within Nova is a generic exception.
It is used to indicate that the subnets within the network no longer
have any available fixed IPs for use.

The original message was non specific.  This change set provides an
updated message that indicates which network has exhausted its fixed
IP set.

This is important for operators that are deploying instances with
multiple networks.

Change-Id: Ib8b854381b616f83e82bc573f85e109f019897dc
Closes-Bug: #1366982
Merge "Port fping extension to work in v2.1/v3 framework"
Merge "baremetal: Remove depenency on libvirt's fetch_image method"
Merge "libvirt: Fix kwargs for _create_image"
Merge "Update NoMoreFixedIps message description"
Merge "move dict copy in prep for object-ify flavors"
Merge "refactor flavor db fakes in prep for object-ify flavors"
Merge "refactor flavor manage tests in prep for object-ify flavors"
Merge "Move volume_clear option to where it's used"
Merge "Correct a maybe-typo in pci_manager"