key value attributes working