Code review

In general I think this module looks good.

I only have a few questions and comments.
I removed this as I could not see that the cache was set anywhere.