New dissector for Character Generator Protocol (chargen).

Change-Id: I01e0508adc79dda11b3eaee51fa01110b8c83e39
Bug: 10178
Reviewed-on: https://code.wireshark.org/review/2220
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I17b5f3af2c4822805705fae9fdbb0375ba04acdd
Reviewed-on: https://code.wireshark.org/review/2225
Reviewed-by: Evan Huus <eapache@gmail.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I781c7eec381d3296d15e666385f549e44f62e3f1
Reviewed-on: https://code.wireshark.org/review/2226
Reviewed-by: Evan Huus <eapache@gmail.com>
Use tfs_f1_3_override_state to avoid unused variable error

Change-Id: I211f1bd2dcf61f27034e1e42e00ab3c1dc0c4c89
Reviewed-on: https://code.wireshark.org/review/2236
Reviewed-by: Evan Huus <eapache@gmail.com>
Register BER dissector as new.

This makes it possible to dissect part of a package as ASN.1.

Change-Id: I53dd6bc916fa0d2c932d77fef437c2094fdd29ed
Reviewed-on: https://code.wireshark.org/review/2238
Reviewed-by: Evan Huus <eapache@gmail.com>
iSCSI: Register iscsi dissector, so it can be used by iSER

Change-Id: I78e487c14859b82d7e1d79f99a92c759c73fbda2
Signed-off-by: Yan Burman <yanb@mellanox.com>
Reviewed-on: https://code.wireshark.org/review/2246
Reviewed-by: Michael Mann <mmann78@netscape.net>
Fix SDP dissector crash during fuzz testing

Change-Id: Ic133dd9440feb61964d197fa0aaacd86241f229d
Signed-off-by: Yan Burman <yanb@mellanox.com>
Reviewed-on: https://code.wireshark.org/review/2248
Reviewed-by: Michael Mann <mmann78@netscape.net>
Support out-of-source docbook build

Change-Id: I273a6317c459664a247d3f5623ef54b0a70a9ab8
Reviewed-on: https://code.wireshark.org/review/2232
Reviewed-by: Anders Broman <a.broman58@gmail.com>
STUN: Add support of MS-TURNBWM

Traversal using Relay NAT (TURN) Bandwidth Management Extensions
http://msdn.microsoft.com/en-us/library/ff595670.aspx

Change-Id: I58c7b758ae96226a45095243939b2ad2b4a91d4d
Reviewed-on: https://code.wireshark.org/review/1973
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Remove now-unused functions.

Change-Id: Iecf230d493b31ecab25b33c67323987459b23bd7
Reviewed-on: https://code.wireshark.org/review/2242
Reviewed-by: Michael Mann <mmann78@netscape.net>
Remove emem from ssl utils, use glib instead.

No exceptions can be thrown when loading a key from a file, so it's safe.

Change-Id: I14ee8569bb516fcb45b72f07f76d28ef4b32065c
Reviewed-on: https://code.wireshark.org/review/2243
Reviewed-by: Michael Mann <mmann78@netscape.net>
Remove last caller of se_strdup_printf

Also remove that function as it is now unused.

Fix what appeared to be a memory leak in the manual address resolution dialog
while in the neighbourhood.

Change-Id: I75128ab0f95e5a7673f92bfeea45191f00581c25
Reviewed-on: https://code.wireshark.org/review/2244
Reviewed-by: Michael Mann <mmann78@netscape.net>
Remove last remaining call to se_strdup

get_filter_from_packet_list_row_and_column now returns glib memory

Change-Id: I24361670322ff4a936c157a842b07f32c474089e
Reviewed-on: https://code.wireshark.org/review/2240
Reviewed-by: Evan Huus <eapache@gmail.com>
Remove emem in SNMP UAT, use glib instead

Change-Id: Ieea8c09d6a82285b0ba20f669c35394fbf195f50
Reviewed-on: https://code.wireshark.org/review/2241
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Evan Huus <eapache@gmail.com>
Display text representation of status codes

Adds a table containing all known StatusCodes and displays them if found.
The list of StatusCodes is in a separate file for easy generating of the list if necessary.

Change-Id: Iab74b22b7fc4fb53d8f072c4e3a4cea4ae18196c
Reviewed-on: https://code.wireshark.org/review/2126
Reviewed-by: Evan Huus <eapache@gmail.com>
Display status code info bits if set

Checks if a StatusCode has any of the additional info bits set and displays them accordingly.

Change-Id: Ic584233083174d3fd30c6ec6684f308e0e5ae22e
Reviewed-on: https://code.wireshark.org/review/2127
Reviewed-by: Evan Huus <eapache@gmail.com>
Cleanup subtree types in opcua plugin

- make ett_opcua_transport static, is only used locally
- format code grouping extern ett variables
- add subtree variables for encodingmasks of simple types

Change-Id: Ia044ca6ca0ff19e940a03d21610db67fe3679b01
Reviewed-on: https://code.wireshark.org/review/2157
Reviewed-by: Anders Broman <a.broman58@gmail.com>
glusterfs: correctly decode GFIDs that are passed in a dict

When a dict structure is passed by GlusterFS, the values are not encoded
normally. We now assume that the GFID in the dict is in network-order,
but this will be incorrect for Big Endian systems. The majority of
Gluster deployments are on Little Endian, and the GFID is displayed
correctly for this case. I am sorry for the few users on Big Endian
Gluster environments, they will see some GFIDs in Wireshark that don't
exist on the Gluster volume.

With this change, it is also made possible to filter on the GFID that is
contained inside of the dict.

Change-Id: I62a265eca34df23a507403397012cf652d43ca54
Reported-by: Vikhyat Umrao <vumrao@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://code.wireshark.org/review/1856
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
isakmp: support decryption for SHA-2 hash algorithms

Simply map ISAKMP hash IDs for sha256, sha384 and sha512 to gcrypt MDs.
Fixes bug 10181.

Change-Id: I9c8265bf3c5c8f8d2fd6d251cc0f267964e3be8e
Signed-off-by: Alex Badea <abadea@ixiacom.com>
Reviewed-on: https://code.wireshark.org/review/2250
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Fix indent (Use 4spaces like end of the file and modelines info

Change-Id: I80e0193240032e62c685c5b976df921ea1e6a581
Reviewed-on: https://code.wireshark.org/review/2251
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Graham Bloice <graham.bloice@trihedral.com>