working on updating parameters