Addition of SMS feature

Hi Tyler,

 

Sorry, I am fairly new to java and how github works.  I saw a bunch of comments.  Did you already make these corrections or is it something you need me to do?

 

As far as tests, I am not sure what is needed there.  I am not familiar with how test protocols are to be designed, but the code has been in use by me and several Nightscout users for some time and there have been no issues reported in the past month.

 

Thanks again for your help and let me know what’s next.

 

Darryl

 

From: Tyler Rhodes [mailto:notifications@github.com] 
Sent: Thursday, December 18, 2014 9:00 PM
To: nightscout/android-uploader
Cc: Darryl Schick
Subject: Re: [android-uploader] Addition of SMS feature (#108)

 

In app/src/main/java/com/nightscout/android/settings/SettingsActivity.java <https://github.com/nightscout/android-uploader/pull/108#discussion-diff-22086207> :

> @@ -133,6 +133,11 @@ private void setupSimplePreferencesScreen() {
>          getPreferenceScreen().addPreference(fakeHeader);
>          addPreferencesFromResource(R.xml.pref_labs);
>  
> +        // Add 'labs' preferences, and a corresponding header.
> +        fakeHeader = new PreferenceCategory(this);

setupSimplePreferencesScreen doesn't exist any more.

—
Reply to this email directly or view it on GitHub <https://github.com/nightscout/android-uploader/pull/108/files#r22086207> .  <https://github.com/notifications/beacon/AH1T7X2PzM5v_222g5KA4vrEYYVDe_KWks5nY34vgaJpZM4DJFqR.gif>