work on parameters and some testing