Fix suggestions logic

This code was previously repeating the same action (setting the
suggestions key for the given package to list(provides) once for every
element in the set. While this did not produce a functionally incorrect
result, it is unnecessary and poorly-constructed as-is. This commit
simplifies the logic, and only performs that action once.
Remove unused variables
Merge pull request #11648 from terminalmage/yum-cleanup

Fix suggestions logic