For this and most other comments, I'm a bit torn, as on one hand they are
in a good direction, on the other I wanted the examples to be similar to
the Rackspace ones, so that users can compare how little change is needed.
But if you think code elegance is more important, I can make the changes.


On Mon, Apr 28, 2014 at 3:09 AM, Andrew Phillips
<notifications@github.com>wrote:

> In
> google/src/main/java/org/jclouds/examples/google/computeengine/Constants.java:
>
> > + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> > + * KIND, either express or implied.  See the License for the
> > + * specific language governing permissions and limitations
> > + * under the License.
> > + */
> > +package org.jclouds.examples.google.computeengine;
> > +
> > +import static java.util.concurrent.TimeUnit.SECONDS;
> > +
> > +/**
> > + * Constants used by the Google Compute Engine Examples.
> > + *
> > + * @author Mikolaj Zalewski (based on code by Everett Toews)
> > + */
> > +public interface Constants {
> > +   public static final String PROVIDER = System.getProperty("provider.cs", "google-compute-engine");
>
> Actually, I don't think public static final are needed here - values in
> interfaces are public, static and final automatically?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds-examples/pull/44/files#r12032732>
> .
>