Squashing doesn't really interest me, unless the history is really messy.
We have merge commits, they're good enough for me.
On 25 Feb 2014 12:28, "Alexander Obuhovich" <notifications@github.com>
wrote:

> In library/Mockery/Expectation.php:
>
> > @@ -339,7 +342,8 @@ public function withArgs(array $args)
> >      public function withNoArgs()
> >      {
> >          $this->_noArgsExpectation = true;
>
> It was. Never saw that. I personally always reply to inline code comments
> when I implement wasn't been asked there. This way it's easier.
>
> Always doing a squash before PR merging is good idea, since having 5
> commits in main repo just to change 2 small methods doesn't make commit
> history cleaner.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/padraic/mockery/pull/279/files#r10033466>
> .
>