2010-09-10  Paul Sawaya  <psawaya@apple.com>

        Reviewed by Chris Marr.

        Refactored non-Mac specific code into GraphicsContext3DOpenGL.
        
        Moving this file into platform/graphics/mac for now, and only building on Mac.
        
        https://bugs.webkit.org/show_bug.cgi?id=30625



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
fixed typo in Changelog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
one more typo fix in Changelog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Adding file that should have been in http://trac.webkit.org/changeset/67226 but 
        I forgot to svn add.
        
        * platform/graphics/opengl: Added.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Copied from platform/graphics/mac/GraphicsContext3DMac.mm.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Give expected results files the right names

* platform/win/fast/text/hyphenate-first-word-expected.txt: Renamed from LayoutTests/platform/win/fast/text/hyphenate-first-word-actual.txt.
* platform/win/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/win/fast/text/hyphenate-locale-actual.txt.
* platform/win/html5lib/runner-expected.txt: Renamed from LayoutTests/platform/win/html5lib/runner-actual.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Restored a Changelog entry for a change that was reverted. I mistakenly thought reverted changes should be removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        compositing/iframes/iframe-src-change.html test fails on Windows
        https://bugs.webkit.org/show_bug.cgi?id=45554

        This test had the wrong behavior. It never actually entered compositing mode.
        Now give it a chance to do so (and test for it), and then test that the layers
        disappeared.

        * compositing/iframes/iframe-src-change-expected.txt:
        * compositing/iframes/iframe-src-change.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed
        https://bugs.webkit.org/show_bug.cgi?id=41371

        Drop support for closing comments with "-- >".  This was an attempt to
        be more IE-like in comment parsing, but it turns out to cause problems
        for some high-profile sites.  Firefox 4 is dropping support as well.
        We expect the spec to change soon too.

        * html/parser/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::nextToken):
        * html/parser/HTMLTokenizer.h:
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed
        https://bugs.webkit.org/show_bug.cgi?id=41371

        Update test results for new behavior.

        * fast/parser/comments-expected.txt:
        * fast/parser/comments.html:
          - Removed the redundant in-test expectations.
        * html5lib/runner-expected.txt:
          - We now "fail" these two tests.  We'll pass them again once the spec
            changes and HTML5lib updates its expectations.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Adam Barth  <abarth@webkit.org>

        Chromium build fix (one hopes!)

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::commitDocumentData):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skip file api tests for workers that could crash occasionally before
we figure out how to fix them.

* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        SVGGElement::rendererIsNeeded should return false when parent isn't SVG
        https://bugs.webkit.org/show_bug.cgi?id=45562

        Test: svg/custom/g-outside-svg.html

        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::rendererIsNeeded):
        * svg/SVGGElement.h:
2010-09-10  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        SVGGElement::rendererIsNeeded should return false when parent isn't SVG
        https://bugs.webkit.org/show_bug.cgi?id=45562

        * svg/custom/g-outside-svg-expected.txt: Added.
        * svg/custom/g-outside-svg.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Simon Fraser  <simon.fraser@apple.com>

        Re-enable some Windows compositing tests that no longer assert.

        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-09  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions from Frame to SelectionController as planned
        https://bugs.webkit.org/show_bug.cgi?id=45508

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::selectionBoundsRect):
        Call functions on selection().
2010-09-09  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions from Frame to SelectionController as planned
        https://bugs.webkit.org/show_bug.cgi?id=45508

        * WebView.cpp:
        (WebView::selectionRect):
        (WebView::centerSelectionInVisibleArea):
        Call functions on selection().
2010-09-09  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions from Frame to SelectionController as planned
        https://bugs.webkit.org/show_bug.cgi?id=45508

        * WebView/WebFrame.mm:
        (-[WebFrame _selectionGranularity]):
        (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
        (-[WebFrame _typingStyle]):
        (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation currentForm]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView jumpToSelection:]):
        (-[WebHTMLView centerSelectionInVisibleArea:]):
        (-[WebHTMLView _canSmartCopyOrDelete]):
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[WebHTMLView selectionRect]):
        (-[WebHTMLView selectionTextRects]):
        (-[WebHTMLView selectionImageRect]):
        * WebView/WebView.mm:
        (-[WebView setEditable:]):
        Call functions on selection().
2010-09-09  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions from Frame to SelectionController as planned
        https://bugs.webkit.org/show_bug.cgi?id=45508

        Also removed Frame::dragCaretController since it just called Page::dragCaretController.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):
        (WebCore::SelectionController::modify):
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        (WebCore::SelectionController::selectAll):
        (WebCore::SelectionController::focusedOrActiveStateChanged):
        (WebCore::SelectionController::notifyRendererOfSelectionChange):
        (WebCore::isFrameElement):
        (WebCore::SelectionController::setFocusedNodeIfNeeded):
        (WebCore::SelectionController::paintDragCaret):
        (WebCore::SelectionController::shouldDeleteSelection):
        (WebCore::SelectionController::selectionBounds):
        (WebCore::SelectionController::selectionTextRects):
        (WebCore::scanForForm):
        (WebCore::SelectionController::currentForm):
        (WebCore::SelectionController::revealSelection):
        (WebCore::SelectionController::setSelectionFromNone):
        (WebCore::SelectionController::shouldChangeSelection):
        * editing/SelectionController.h:
        Moved functions here from Frame.

        * page/Frame.cpp:
        * page/Frame.h:
        Moved functions to SelectionController.
        Reorganized header to be easier to read and a bit more logical.

        * WebCore.exp.in: Updated.

        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenWillBeRemoved):
        (WebCore::Document::nodeWillBeRemoved):
        Call Page::dragCaretController directly.

        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance):
        * dom/InputElement.cpp:
        (WebCore::InputElement::updateFocusAppearance):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::editingStyleAtPosition):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
        * editing/Editor.cpp:
        (WebCore::Editor::canSmartCopyOrDelete):
        (WebCore::Editor::textDirectionForSelection):
        (WebCore::Editor::appliedEditing):
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::revealSelectionAfterEditingOperation):
        (WebCore::Editor::transpose):
        (WebCore::Editor::changeSelectionAfterCommand):
        (WebCore::Editor::computeAndSetTypingStyle):
        (WebCore::Editor::selectionComputedStyle):
        (WebCore::Editor::styleForSelectionStart):
        (WebCore::Editor::findString):
        * editing/EditorCommand.cpp:
        (WebCore::executeDelete):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input):
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::insertTextRunWithoutNewlines):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::updateFocusAppearance):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/DragController.cpp:
        (WebCore::DragController::concludeEditDrag):
        (WebCore::dragLocForSelectionDrag):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectClosestWordFromMouseEvent):
        (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
        (WebCore::EventHandler::handleMousePressEventTripleClick):
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        (WebCore::EventHandler::updateSelectionForMouseDrag):
        (WebCore::EventHandler::handleMouseReleaseEvent):
        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocusInDocumentOrder):
        * page/chromium/EventHandlerChromium.cpp:
        (WebCore::EventHandler::passMousePressEventToSubframe):
        * page/chromium/FrameChromium.cpp:
        (WebCore::Frame::dragImageForSelection):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::selectionImage):
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::writeRange):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):
        Call functions on selection().


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove mention of "part" from Document.cpp
        https://bugs.webkit.org/show_bug.cgi?id=45566

        This is an old KHTML name that's lingering around.

        * dom/Document.cpp:
        (WebCore::Document::parentDocument):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  David Holloway  <dhollowa@chromium.org>

        Reviewed by Adam Barth.

        Change WebKit::WebFormElement::wasUserSubmitted to use WebCore::HTMLFormElement::submittedByUserGesture
        instead of WebCore::HTMLFormElement::submissionTrigger.
        Chromium AutoFill feature semantics changed with respect to what we mean by "user submitted" form.  A
        more accurate measure of the user manually submitting a form is via user gesture.
        https://bugs.webkit.org/show_bug.cgi?id=45128

        * src/WebFormElement.cpp:
        (WebKit::WebFormElement::wasUserSubmitted):
2010-09-10  David Holloway  <dhollowa@chromium.org>

        Reviewed by Adam Barth.

        Replace WebCore::HTMLFormElement::submissionTrigger with WebCore::HTMLFormElement::submittedByUserGesture.
        Chromium AutoFill feature semantics changed with respect to what we mean by "user submitted" form.  A
        more accurate measure of the user manually submitting a form is via user gesture.
        https://bugs.webkit.org/show_bug.cgi?id=45128

        No new tests as this is only used by the Chromium WebKit API.

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::HTMLFormElement):
        (WebCore::HTMLFormElement::prepareSubmit):
        (WebCore::HTMLFormElement::submit):
        (WebCore::HTMLFormElement::submittedByUserGesture):
        * html/HTMLFormElement.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        deduplicate-tests should be runnable from any WebKit directory
        https://bugs.webkit.org/show_bug.cgi?id=44709

        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling out r67241.
        http://trac.webkit.org/changeset/67241
        https://bugs.webkit.org/show_bug.cgi?id=44709

        Accidentally committed.

        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        execCommand("fontsize") on certain selected html generates too many SPAN tags.
        https://bugs.webkit.org/show_bug.cgi?id=28968

        Added a test to ensure only one font element is added when applying font-size
        to multiple inline nodes.

        * editing/style/apply-font-size-to-multiple-nodes-expected.txt: Added.
        * editing/style/apply-font-size-to-multiple-nodes.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Nat Duca  <nduca@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Accelerated Compositing: screen garbage when scrolling
        https://bugs.webkit.org/show_bug.cgi?id=45092

        Split LayerRenderChromium::drawLayers into several different
        functions, responsible for preparing the backbuffer, updating the
        root texture, compositing and performing the final
        swapbuffers. This are then used by the new
        WebViewImpl::composite rendering path.

        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::setBounds):
        (WebCore::LayerChromium::setFrame):
        (WebCore::LayerChromium::setNeedsDisplay):
        (WebCore::LayerChromium::resetNeedsDisplay):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::dirtyRect):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::prepareToDrawLayers):
        (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::present):
        * platform/graphics/chromium/LayerRendererChromium.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Implement HTML5 definition of script for-event neutering
        https://bugs.webkit.org/show_bug.cgi?id=45493

        * fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt:
        * fast/dom/HTMLScriptElement/script-tests/script-for-attribute-unexpected-execution.js: Beef up test with some more cases, change style to be more readable, and remove obsolete comments about supporting for-event.
2010-09-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Implement HTML5 definition of script for-event neutering
        https://bugs.webkit.org/show_bug.cgi?id=45493

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::shouldExecuteAsJavaScript): Same behavior, but reads more like the spec. Removed obsolete comments about supporting for-event.
        * html/parser/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::executeScript): Moved to runScript.
        (WebCore::HTMLScriptRunner::runScript): Checking shouldExecuteAsJavaScript() here means that external scripts which fail the check will never be requested.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67245 268f45cc-cd09-0410-ab3c-d52691b4dbfc