implemented till feature vector generation