Ticket 47668 - test: port ticket47490_test to Replica/Agreement interface (47600)

Bug Description:
	Ticket https://fedorahosted.org/389/ticket/47600 introduces new Replica/Agreement/Changelog interfaces.
	This ticket is to take into account those changes into ticket47490 test case

Fix Description:
	Call enableReplication from Replica Class.
	Call Agreement.create with properties

https://fedorahosted.org/389/ticket/47668

Reviewed by: Rich Megginson (thanks)

Platforms tested: F17 / F19 (jenkins)

Flag Day: no

Doc impact: no
Ticket #47660 - config_set_allowed_to_delete_attrs: Valgrind reports Invalid read

Description: There was a logic error in checking the availability of
a pointer.  Before checking the contents of an address, the correctness
of the pointer needed to be checked.

Also, one memory leak was found in the error return case.

Note: these 2 issues were introduece by this commit:
commit 94b123780b21e503b78bceca9d60904206ef91fa
Trac Ticket #447 - Possible to add invalid attribute to nsslapd-allowed-to-delete-attrs

https://fedorahosted.org/389/ticket/47660

Reviewed by rmeggins@redhat.com (Thank you, Rich!)
Ticket #47571 - targetattr ACIs ignore subtype

Description: commit 85a78741dfeb636a1cf7cced1576278e65f5bb58
introduced 2 coverity issues:
12423: Explicit null dereferenced
do_search (slapd/search.c)
If attribute list contains multiple "*"s and "aci"s in ldapsearch,
the previous code attempted to add "aci" once for "*" and replacing
"aci" with normalized aci (if any) once and eliminating the duplicated
"aci"s. The code contained a null dereferenced bug. Even if duplicated
attributes are included in the attribute list, they are removed later
in send_specific_attrs. Thus, this patch simplifies the logic to avoid
the null dereference.

12422: Logically dead code
comp_cmp (slapd/attr.c)
Eliminated the dead code (case s1 == NULL AND s2 == NULL).

https://fedorahosted.org/389/ticket/47571

Reviewed by rmeggins@redhat.com (Thank you, Rich!!)
Ticket 47629 - random crashes related to sync repl

Bug Description:  if there is no cookie, the persist thread starts
        before the initial refresh is complete, both threads use the
	same operation structure and there is a race condition
	on setting and freeing the search entry.

Fix Description:   ensure that the persist thread only starts sending
	updates once the refresh is complete

https://fedorahosted.org/389/ticket/47629

Reviewed by: Rich, thanks
Ticket #47657 add schema test suite and tests for Ticket #47634

https://fedorahosted.org/389/ticket/47657
Reviewed by: tbordaz (Thanks!)
Branch: master
Fix Description: Add tests for schema ticket #47634.  This also adds a suites
subdirectory to dirsrvtests and a schema subdirectory of suites.
Platforms tested: RHEL6 x86_64
Flag Day: no
Doc impact: no
Ticket #47675 logconv errors when search has invalid bind dn

https://fedorahosted.org/389/ticket/47675
Reviewed by: mreynolds (Thanks!)
Branch: master
Fix Description: Just skip processing the search request, and let the err=34
processing handle this case.
Platforms tested: RHEL6 x86_64
Flag Day: no
Doc impact: no
Ticket 47654 - fix double free

Bug Description:  Under certain circumstances the dbhome directory gets freed twice.

Fix Description:  Copy the db home directory into the private db directory array, instead
                  of passing a reference to it.

https://fedorahosted.org/389/ticket/47654

Reviewed by: rmeggins(Thanks!)
Ticket 408 - Fix crash when disabling/enabling the setting

Bug Description:  Enabling/disabling can lead to crash as the setting
                  was not designed to be dynamically updated.

Fix Description:  Do not use the actual config setting to determine if the
                  cache is enabled.  Instead we record when the cache is
                  initialized.  The server still needs to be restarted for
                  the config change to take effect.

                  Also freed the cache at server shtudown.

https://fedorahosted.org/389/ticket/408

Reviewed by: rmeggins(Thanks!)
Ticket 47620 - Unable to delete protocol timeout attribute

Bug Description:  Attempting to delete nsds5ReplicaProtocolTimeout from a replication
                  agreement unexpectedly fails with an error 53.

Fix Description:  The previous delete operation check was in the wrong location, and the
                  delete operation was treated as a modify - which then triggered the
                  error 53.  Added the correct check for the delete operation.

                  Also removed some old code for a CLEANALLRUV attribute that was never
                  implemented.

https://fedorahosted.org/389/ticket/47620

Reviewed by: nhosoi(Thanks!)
Ticket #47516 replication stops with excessive clock skew

https://fedorahosted.org/389/ticket/47516
Reviewed by: nhosoi (Thanks!)
Branch: master
Fix Description: The previous fix was not adequate.  Instead, the determination
of whether or not to ignore time skew should be determined in
csngen_adjust_time().
Platforms tested: RHEL6 x86_64
Flag Day: no
Doc impact: yes - document new config param
Ticket #342 - better error message when cache overflows

Description: commit 892bf12c1bb8b10afea3d6ff711059bf04e362cc
introduced an invalid memory read/write.  This patch prepares one
extra aclpblock for the acl cache overflow.

https://fedorahosted.org/389/ticket/342

Reviewed by rmeggins@redhat.com (Thank you, Rich!!)